admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
webrtc_m130/rtc_base/experiments/BUILD.gn

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

212 lines
5.5 KiB
Plaintext
Raw Permalink Normal View History

Moved ALR experiment settings to new experiments folder. This replaces most of the existing dependencies on the application limited region(ALR) detector. This is to achieve a greater separation of concerns and will make further refactoring regarding the ALR Detector less invasive on other parts of the code base. Bug: webrtc:8415 Change-Id: I92912254c6d02285cce6a88f6789f0ac94794c88 Reviewed-on: https://webrtc-review.googlesource.com/37560 Commit-Queue: Sebastian Jansson <srte@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21598}
2018-01-12 10:54:18 +01:00
# Copyright (c) 2018 The WebRTC project authors. All Rights Reserved.
#
# Use of this source code is governed by a BSD-style license
# that can be found in the LICENSE file in the root of the source
# tree. An additional intellectual property rights grant can be found
# in the file PATENTS. All contributing project authors may
# be found in the AUTHORS file in the root of the source tree.
import("../../webrtc.gni")
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("alr_experiment") {
Moved ALR experiment settings to new experiments folder. This replaces most of the existing dependencies on the application limited region(ALR) detector. This is to achieve a greater separation of concerns and will make further refactoring regarding the ALR Detector less invasive on other parts of the code base. Bug: webrtc:8415 Change-Id: I92912254c6d02285cce6a88f6789f0ac94794c88 Reviewed-on: https://webrtc-review.googlesource.com/37560 Commit-Queue: Sebastian Jansson <srte@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21598}
2018-01-12 10:54:18 +01:00
sources = [
"alr_experiment.cc",
"alr_experiment.h",
]
deps = [
Remove //rtc_base:logging from public deps Bug: webrtc:8603 Change-Id: I2704da8618f88032adac7ae9eb2a0f47fce4a836 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257908 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Auto-Submit: Florent Castelli <orphis@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36443}
2022-04-04 15:06:30 +02:00
"..:logging",
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 12/inf rename WebRtcKeyValueConfig to FieldTrialsView Bug: webrtc:10335 Change-Id: If725bd498c4c3daf144bee638230fa089fdde833 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256965 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Jonas Oreland <jonaso@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36365}
2022-03-29 11:04:48 +02:00
"../../api:field_trials_view",
Use propagated instead of global field trials for alr expriment Bug: webrtc:10335 Change-Id: I52a286d38dadaac79afd55ebbe3c06e44a7e881b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/330360 Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Åsa Persson <asapersson@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41333}
2023-12-06 18:23:20 +00:00
"//third_party/abseil-cpp/absl/strings:string_view",
Adopt absl::string_view in rtc_base/ (straightforward cases) Bug: webrtc:13579 Change-Id: I240db6285abb22652242bc0b2ebe9844ec4a45f0 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/258723 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Commit-Queue: Ali Tofigh <alito@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36561}
2022-04-13 12:55:15 +02:00
]
Moved ALR experiment settings to new experiments folder. This replaces most of the existing dependencies on the application limited region(ALR) detector. This is to achieve a greater separation of concerns and will make further refactoring regarding the ALR Detector less invasive on other parts of the code base. Bug: webrtc:8415 Change-Id: I92912254c6d02285cce6a88f6789f0ac94794c88 Reviewed-on: https://webrtc-review.googlesource.com/37560 Commit-Queue: Sebastian Jansson <srte@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21598}
2018-01-12 10:54:18 +01:00
}
Adds BBR network controller field trial. This CL adds a field trial to enable the BBR congestion control method. Since BBR is only implemented to handle per packet feedback, SendSideCongestionController is modified to recreate network controllers when the packet feedback availability changes and the BBR experiment is enabled. This also means that the periodic task used for process updates in the network controllers has to recreated. Bug: webrtc:8415 Change-Id: Ia24f7ad35336d2cc7a02bb3a445f1a84b8643475 Reviewed-on: https://webrtc-review.googlesource.com/61520 Commit-Queue: Sebastian Jansson <srte@webrtc.org> Reviewed-by: Stefan Holmer <stefan@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22791}
2018-04-09 11:13:04 +02:00
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("field_trial_parser") {
Adds field trial parser. Bug: webrtc:9346 Change-Id: Ibd07a1753feaa40d4be4d465d61f55bc8a8a9325 Reviewed-on: https://webrtc-review.googlesource.com/80263 Commit-Queue: Sebastian Jansson <srte@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Stefan Holmer <stefan@webrtc.org> Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23615}
2018-06-14 16:47:42 +02:00
sources = [
Add support for lists to the FieldTrialParser. List elements are separated by a |. If the key is given without a : we treat that as a empty list. We also support parsing multiple lists as a list-of-structs, see the unit test for usage examples. Bug: webrtc:9346 Change-Id: I32d3ce612fef476b1c481c00a893d7fa2f339e92 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/130464 Reviewed-by: Sebastian Jansson <srte@webrtc.org> Commit-Queue: Jonas Olsson <jonasolsson@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27560}
2019-04-11 11:53:26 +02:00
"field_trial_list.cc",
"field_trial_list.h",
Adds field trial parser. Bug: webrtc:9346 Change-Id: Ibd07a1753feaa40d4be4d465d61f55bc8a8a9325 Reviewed-on: https://webrtc-review.googlesource.com/80263 Commit-Queue: Sebastian Jansson <srte@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Stefan Holmer <stefan@webrtc.org> Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23615}
2018-06-14 16:47:42 +02:00
"field_trial_parser.cc",
"field_trial_parser.h",
"field_trial_units.cc",
"field_trial_units.h",
Adds struct parameters parser/encoder. This is similar to the field trial parser but it uses a normal struct with normal fields as underlying storage. This makes it easier to understand and use as only the encoding and parsing uses non- standard constructs. Additionally, it makes it easier to use the struct as a regular config struct when the values are not set using field trials. Bug: webrtc:9883 Change-Id: I5b16c2a71875b6f478383decff18fbaa62bc404a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145203 Reviewed-by: Jonas Olsson <jonasolsson@webrtc.org> Commit-Queue: Sebastian Jansson <srte@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28810}
2019-08-08 11:14:51 +02:00
"struct_parameters_parser.cc",
"struct_parameters_parser.h",
Adds field trial parser. Bug: webrtc:9346 Change-Id: Ibd07a1753feaa40d4be4d465d61f55bc8a8a9325 Reviewed-on: https://webrtc-review.googlesource.com/80263 Commit-Queue: Sebastian Jansson <srte@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Stefan Holmer <stefan@webrtc.org> Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23615}
2018-06-14 16:47:42 +02:00
]
deps = [
"../../api/units:data_rate",
"../../api/units:data_size",
"../../api/units:time_delta",
Adds check for unused field trial parameters. This adds a dcheck to detect if a FieldTrialParameter has been created but not used in parsing a field trial. This is an easy mistake to make and cause extra work debugging why nothing happens. Also improving the ergonomics of using the parameter and optional classes. Making it easier to use them as drop in replacements for their underlying classes. In particular, the optional parameter class implements and interface more similar to the optional class. Bug: webrtc:9510 Change-Id: I5a12dd66396fa4cac9c9cf517172ae2f06984060 Reviewed-on: https://webrtc-review.googlesource.com/96761 Commit-Queue: Sebastian Jansson <srte@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24527}
2018-09-03 10:15:13 +02:00
"../../rtc_base:checks",
Using more specific dependencies in rtc_base. Bug: webrtc:9718, webrtc:9838 Change-Id: I604c8fea574aabb795da7d5bba3ea751f87acb4c Reviewed-on: https://webrtc-review.googlesource.com/c/106300 Commit-Queue: Sebastian Jansson <srte@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25206}
2018-10-16 11:34:04 +02:00
"../../rtc_base:logging",
Add support for unsigned parameters in FieldTrialParser Bug: webrtc:10932 Change-Id: I3f56244a6be532065e4096cf1a289e27a032bc44 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150886 Commit-Queue: Björn Terelius <terelius@webrtc.org> Reviewed-by: Sebastian Jansson <srte@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29018}
2019-08-30 09:39:31 +02:00
"../../rtc_base:safe_conversions",
Add support for lists to the FieldTrialParser. List elements are separated by a |. If the key is given without a : we treat that as a empty list. We also support parsing multiple lists as a list-of-structs, see the unit test for usage examples. Bug: webrtc:9346 Change-Id: I32d3ce612fef476b1c481c00a893d7fa2f339e92 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/130464 Reviewed-by: Sebastian Jansson <srte@webrtc.org> Commit-Queue: Jonas Olsson <jonasolsson@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27560}
2019-04-11 11:53:26 +02:00
"../../rtc_base:stringutils",
Use std::make_unique instead of absl::make_unique. WebRTC is now using C++14 so there is no need to use the Abseil version of std::make_unique. This CL has been created with the following steps: git grep -l absl::make_unique | sort | uniq > /tmp/make_unique.txt git grep -l absl::WrapUnique | sort | uniq > /tmp/wrap_unique.txt git grep -l "#include <memory>" | sort | uniq > /tmp/memory.txt diff --new-line-format="" --unchanged-line-format="" \ /tmp/make_unique.txt /tmp/wrap_unique.txt | sort | \ uniq > /tmp/only_make_unique.txt diff --new-line-format="" --unchanged-line-format="" \ /tmp/only_make_unique.txt /tmp/memory.txt | \ xargs grep -l "absl/memory" > /tmp/add-memory.txt git grep -l "\babsl::make_unique\b" | \ xargs sed -i "s/\babsl::make_unique\b/std::make_unique/g" git checkout PRESUBMIT.py abseil-in-webrtc.md cat /tmp/add-memory.txt | \ xargs sed -i \ 's/#include "absl\/memory\/memory.h"/#include <memory>/g' git cl format # Manual fix order of the new inserted #include <memory> cat /tmp/only_make_unique | xargs grep -l "#include <memory>" | \ xargs sed -i '/#include "absl\/memory\/memory.h"/d' git ls-files | grep BUILD.gn | \ xargs sed -i '/\/\/third_party\/abseil-cpp\/absl\/memory/d' python tools_webrtc/gn_check_autofix.py \ -m tryserver.webrtc -b linux_rel # Repead the gn_check_autofix step for other platforms git ls-files | grep BUILD.gn | \ xargs sed -i 's/absl\/memory:memory/absl\/memory/g' git cl format Bug: webrtc:10945 Change-Id: I3fe28ea80f4dd3ba3cf28effd151d5e1f19aff89 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153221 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29209}
2019-09-17 17:06:18 +02:00
"//third_party/abseil-cpp/absl/memory",
Mass removal of absl_deps in all BUILD.gn files Bug: webrtc:341803749 Change-Id: Id73844ba8d63b9f2f2c9391d8d8116ad0864c36d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/351540 Commit-Queue: Florent Castelli <orphis@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42372}
2024-05-23 11:21:53 +00:00
"//third_party/abseil-cpp/absl/strings:string_view",
Adds field trial parser. Bug: webrtc:9346 Change-Id: Ibd07a1753feaa40d4be4d465d61f55bc8a8a9325 Reviewed-on: https://webrtc-review.googlesource.com/80263 Commit-Queue: Sebastian Jansson <srte@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Stefan Holmer <stefan@webrtc.org> Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23615}
2018-06-14 16:47:42 +02:00
]
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("quality_scaler_settings") {
Add ability to configure quality scaler settings through field trial. optional<int> min_frames: The minimum number frames to observe to make a scaling decision. Default: kMinFramesNeededToScale in quality_scaler.cc optional<double> initial_scale_factor: The sample period scale factor. Default: kSamplePeriodScaleFactor in quality_scaler.cc optional<double> scale_factor: Option to use a reduced sampling interval when last check did not result in an adaptation (if unset the initial_scale_factor is used). Bug: none Change-Id: I3bb955d1f8d7d7d49bc118361614b5aa59605231 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/135125 Commit-Queue: Åsa Persson <asapersson@webrtc.org> Reviewed-by: Stefan Holmer <stefan@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27860}
2019-05-06 14:17:35 +02:00
sources = [
"quality_scaler_settings.cc",
"quality_scaler_settings.h",
]
deps = [
":field_trial_parser",
Remove //rtc_base:logging from public deps Bug: webrtc:8603 Change-Id: I2704da8618f88032adac7ae9eb2a0f47fce4a836 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257908 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Auto-Submit: Florent Castelli <orphis@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36443}
2022-04-04 15:06:30 +02:00
"..:logging",
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 12/inf rename WebRtcKeyValueConfig to FieldTrialsView Bug: webrtc:10335 Change-Id: If725bd498c4c3daf144bee638230fa089fdde833 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256965 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Jonas Oreland <jonaso@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36365}
2022-03-29 11:04:48 +02:00
"../../api:field_trials_view",
Add ability to configure quality scaler settings through field trial. optional<int> min_frames: The minimum number frames to observe to make a scaling decision. Default: kMinFramesNeededToScale in quality_scaler.cc optional<double> initial_scale_factor: The sample period scale factor. Default: kSamplePeriodScaleFactor in quality_scaler.cc optional<double> scale_factor: Option to use a reduced sampling interval when last check did not result in an adaptation (if unset the initial_scale_factor is used). Bug: none Change-Id: I3bb955d1f8d7d7d49bc118361614b5aa59605231 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/135125 Commit-Queue: Åsa Persson <asapersson@webrtc.org> Reviewed-by: Stefan Holmer <stefan@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27860}
2019-05-06 14:17:35 +02:00
]
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("quality_scaling_experiment") {
Make quality scaler downscale faster. Include dropped frames by the encoder in the frame drop percentage. To react faster at low framerates: - Use ExpFilter instead of MovingAverage to filter QP values. - Reduce sampling interval while waiting for minimum number of needed frames (when not in fast rampup mode). A separate slower ExpFilter is used for upscaling. Bug: webrtc:9169 Change-Id: If7ff6c3bd4201fda2da67125889838fe96ce7061 Reviewed-on: https://webrtc-review.googlesource.com/70761 Commit-Queue: Åsa Persson <asapersson@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23014}
2018-04-24 16:53:25 +02:00
sources = [
"quality_scaling_experiment.cc",
"quality_scaling_experiment.h",
]
deps = [
Remove //rtc_base:logging from public deps Bug: webrtc:8603 Change-Id: I2704da8618f88032adac7ae9eb2a0f47fce4a836 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257908 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Auto-Submit: Florent Castelli <orphis@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36443}
2022-04-04 15:06:30 +02:00
"..:logging",
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 19/inf Convert most field trials used in PCLF tests. Change-Id: I26c0c4b1164bb0870aae1a488942cde888cb459d Bug: webrtc:10335 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/322703 Commit-Queue: Jeremy Leconte <jleconte@google.com> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Jonas Oreland <jonaso@webrtc.org> Cr-Commit-Position: refs/heads/main@{#40909}
2023-10-10 15:21:29 +02:00
"../../api:field_trials_view",
"../../api/transport:field_trial_based_config",
Make quality scaler downscale faster. Include dropped frames by the encoder in the frame drop percentage. To react faster at low framerates: - Use ExpFilter instead of MovingAverage to filter QP values. - Reduce sampling interval while waiting for minimum number of needed frames (when not in fast rampup mode). A separate slower ExpFilter is used for upscaling. Bug: webrtc:9169 Change-Id: If7ff6c3bd4201fda2da67125889838fe96ce7061 Reviewed-on: https://webrtc-review.googlesource.com/70761 Commit-Queue: Åsa Persson <asapersson@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23014}
2018-04-24 16:53:25 +02:00
"../../api/video_codecs:video_codecs_api",
Mass removal of absl_deps in all BUILD.gn files Bug: webrtc:341803749 Change-Id: Id73844ba8d63b9f2f2c9391d8d8116ad0864c36d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/351540 Commit-Queue: Florent Castelli <orphis@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42372}
2024-05-23 11:21:53 +00:00
"//third_party/abseil-cpp/absl/strings",
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 19/inf Convert most field trials used in PCLF tests. Change-Id: I26c0c4b1164bb0870aae1a488942cde888cb459d Bug: webrtc:10335 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/322703 Commit-Queue: Jeremy Leconte <jleconte@google.com> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Jonas Oreland <jonaso@webrtc.org> Cr-Commit-Position: refs/heads/main@{#40909}
2023-10-10 15:21:29 +02:00
]
Make quality scaler downscale faster. Include dropped frames by the encoder in the frame drop percentage. To react faster at low framerates: - Use ExpFilter instead of MovingAverage to filter QP values. - Reduce sampling interval while waiting for minimum number of needed frames (when not in fast rampup mode). A separate slower ExpFilter is used for upscaling. Bug: webrtc:9169 Change-Id: If7ff6c3bd4201fda2da67125889838fe96ce7061 Reviewed-on: https://webrtc-review.googlesource.com/70761 Commit-Queue: Åsa Persson <asapersson@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23014}
2018-04-24 16:53:25 +02:00
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("normalize_simulcast_size_experiment") {
Add field trial for normalized simulcast size. The width/height of the highest simulcast layer is divisible by 2^exponent. The exponent is allowed to be set through the field trial. Bug: none Change-Id: I2ec0af2deb6e3a176f705a2ad1c250a35b086701 Reviewed-on: https://webrtc-review.googlesource.com/c/104067 Reviewed-by: Stefan Holmer <stefan@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Commit-Queue: Åsa Persson <asapersson@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25159}
2018-10-12 17:36:57 +02:00
sources = [
"normalize_simulcast_size_experiment.cc",
"normalize_simulcast_size_experiment.h",
]
deps = [
Remove //rtc_base:logging from public deps Bug: webrtc:8603 Change-Id: I2704da8618f88032adac7ae9eb2a0f47fce4a836 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257908 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Auto-Submit: Florent Castelli <orphis@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36443}
2022-04-04 15:06:30 +02:00
"..:logging",
Use propagated field trials for WebRTC-NormalizeSimulcastResolution experiment Bug: webrtc:10335 Change-Id: I2db0ac9fc305e033c26cb8401db38317fbc71014 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/343761 Reviewed-by: Åsa Persson <asapersson@webrtc.org> Commit-Queue: Åsa Persson <asapersson@webrtc.org> Auto-Submit: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41934}
2024-03-20 15:41:27 +01:00
"../../api:field_trials_view",
Add field trial for normalized simulcast size. The width/height of the highest simulcast layer is divisible by 2^exponent. The exponent is allowed to be set through the field trial. Bug: none Change-Id: I2ec0af2deb6e3a176f705a2ad1c250a35b086701 Reviewed-on: https://webrtc-review.googlesource.com/c/104067 Reviewed-by: Stefan Holmer <stefan@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Commit-Queue: Åsa Persson <asapersson@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25159}
2018-10-12 17:36:57 +02:00
]
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("balanced_degradation_settings") {
Make balanced degradation settings configurable through field trial. Bug: none Change-Id: Iad6dfdfdae13149bb8abe4b884e288e50aa7b73d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/135102 Reviewed-by: Stefan Holmer <stefan@webrtc.org> Commit-Queue: Åsa Persson <asapersson@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27892}
2019-05-06 12:22:49 +02:00
sources = [
"balanced_degradation_settings.cc",
"balanced_degradation_settings.h",
]
deps = [
":field_trial_parser",
Remove //rtc_base:logging from public deps Bug: webrtc:8603 Change-Id: I2704da8618f88032adac7ae9eb2a0f47fce4a836 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257908 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Auto-Submit: Florent Castelli <orphis@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36443}
2022-04-04 15:06:30 +02:00
"..:logging",
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 12/inf rename WebRtcKeyValueConfig to FieldTrialsView Bug: webrtc:10335 Change-Id: If725bd498c4c3daf144bee638230fa089fdde833 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256965 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Jonas Oreland <jonaso@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36365}
2022-03-29 11:04:48 +02:00
"../../api:field_trials_view",
BalancedDegradationSettings: Add option to configure QP thresholds. Add possibility to configure low/high QP thresholds based on resolution. Bug: none Change-Id: Iaa3168b77678bd74feb67295d7658c0140721231 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141867 Reviewed-by: Sergey Silkin <ssilkin@webrtc.org> Commit-Queue: Åsa Persson <asapersson@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28348}
2019-06-20 15:45:07 +02:00
"../../api/video_codecs:video_codecs_api",
Make balanced degradation settings configurable through field trial. Bug: none Change-Id: Iad6dfdfdae13149bb8abe4b884e288e50aa7b73d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/135102 Reviewed-by: Stefan Holmer <stefan@webrtc.org> Commit-Queue: Åsa Persson <asapersson@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27892}
2019-05-06 12:22:49 +02:00
"../../system_wrappers:field_trial",
]
}
Add resolution_bitrate_limits to EncoderInfo field trial. Added class EncoderInfoSettings for parsing settings. Added use of class to SimulcastEncoderAdapter. Bug: none Change-Id: I8182b2ab43f0c330ebdf077e9f7cbc79247da90e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/202246 Commit-Queue: Åsa Persson <asapersson@webrtc.org> Reviewed-by: Sergey Silkin <ssilkin@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33050}
2021-01-20 15:36:13 +01:00
rtc_library("encoder_info_settings") {
sources = [
"encoder_info_settings.cc",
"encoder_info_settings.h",
]
deps = [
":field_trial_parser",
Remove //rtc_base:logging from public deps Bug: webrtc:8603 Change-Id: I2704da8618f88032adac7ae9eb2a0f47fce4a836 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257908 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Auto-Submit: Florent Castelli <orphis@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36443}
2022-04-04 15:06:30 +02:00
"..:logging",
Query EncoderInfoSettings through propagated field trials Instead of from the global field trial string. Bug: webrtc:42220378 Change-Id: Iddb41429e388792de02f702b4caa35689c57d9e5 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347720 Reviewed-by: Erik Språng <sprang@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42201}
2024-04-25 12:02:27 +02:00
"../../api:field_trials_view",
Add resolution_bitrate_limits to EncoderInfo field trial. Added class EncoderInfoSettings for parsing settings. Added use of class to SimulcastEncoderAdapter. Bug: none Change-Id: I8182b2ab43f0c330ebdf077e9f7cbc79247da90e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/202246 Commit-Queue: Åsa Persson <asapersson@webrtc.org> Reviewed-by: Sergey Silkin <ssilkin@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33050}
2021-01-20 15:36:13 +01:00
"../../api/video_codecs:video_codecs_api",
Mass removal of absl_deps in all BUILD.gn files Bug: webrtc:341803749 Change-Id: Id73844ba8d63b9f2f2c9391d8d8116ad0864c36d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/351540 Commit-Queue: Florent Castelli <orphis@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42372}
2024-05-23 11:21:53 +00:00
"//third_party/abseil-cpp/absl/strings:string_view",
Adopt absl::string_view in function parameters under rtc_base/ This is part of a large-scale effort to increase adoption of absl::string_view across the WebRTC code base. This CL converts the majority of "const std::string&"s in function parameters under rtc_base/ to absl::string_view. Bug: webrtc:13579 Change-Id: I2b1e3776aa42326aa405f76bb324a2d233b21dca Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/254081 Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Xavier Lepaul‎ <xalep@webrtc.org> Reviewed-by: Anders Lilienthal <andersc@webrtc.org> Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Ali Tofigh <alito@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36239}
2022-03-17 15:47:49 +01:00
]
Add resolution_bitrate_limits to EncoderInfo field trial. Added class EncoderInfoSettings for parsing settings. Added use of class to SimulcastEncoderAdapter. Bug: none Change-Id: I8182b2ab43f0c330ebdf077e9f7cbc79247da90e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/202246 Commit-Queue: Åsa Persson <asapersson@webrtc.org> Reviewed-by: Sergey Silkin <ssilkin@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33050}
2021-01-20 15:36:13 +01:00
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("rate_control_settings") {
Move congestion window field trial parsing to new class. This cl is part of work to move several experiments into a joint experiment group. Most of them vill be ralted to video, hence the name. Bug: webrtc:10223 Change-Id: I8767c43abb6aa910ab51710eeb908e0f9df1e296 Reviewed-on: https://webrtc-review.googlesource.com/c/118361 Commit-Queue: Erik Språng <sprang@webrtc.org> Reviewed-by: Sebastian Jansson <srte@webrtc.org> Reviewed-by: Stefan Holmer <stefan@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26346}
2019-01-21 16:30:55 +01:00
sources = [
"rate_control_settings.cc",
"rate_control_settings.h",
]
deps = [
":field_trial_parser",
Remove //rtc_base:logging from public deps Bug: webrtc:8603 Change-Id: I2704da8618f88032adac7ae9eb2a0f47fce4a836 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257908 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Auto-Submit: Florent Castelli <orphis@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36443}
2022-04-04 15:06:30 +02:00
"..:logging",
Remove //rtc_base:safe_conversions from public deps Bug: webrtc:8603 Change-Id: I285ac30975039f8fe9882d1673cc8e4a615c8618 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257912 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Auto-Submit: Florent Castelli <orphis@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36452}
2022-04-04 17:04:37 +02:00
"..:safe_conversions",
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 12/inf rename WebRtcKeyValueConfig to FieldTrialsView Bug: webrtc:10335 Change-Id: If725bd498c4c3daf144bee638230fa089fdde833 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256965 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Jonas Oreland <jonaso@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36365}
2022-03-29 11:04:48 +02:00
"../../api:field_trials_view",
Allow setting the initial congestion window size by config. Bug: webrtc:11148 Change-Id: I4700a261661dca51d769e0a277704e1f9316e83d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161089 Reviewed-by: Åsa Persson <asapersson@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Commit-Queue: Christoffer Rodbro <crodbro@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30038}
2019-12-06 13:13:40 +01:00
"../../api/units:data_size",
Account for simulcast hysteresis in padding rate calculation. Bug: webrtc:10271 Change-Id: If0b0eb7d94fb1c892880ff4745f34c43fcdeee54 Reviewed-on: https://webrtc-review.googlesource.com/c/120661 Commit-Queue: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26527}
2019-02-04 11:09:46 +01:00
"../../api/video_codecs:video_codecs_api",
Move VideoEncoderConfig from api/ into video/config This cl move VideoEncoderConfig from api/ to video/config. VideoStreamEncoderInterface and VideoStreamEncoderObserver are moved as collateral. brandt@ think that the reason these were in api/ in the first place had to downstream project. Functionality wise, this is a NOP, but it makes it easier to modify the encoder (config). Bug: webrtc:14451 Change-Id: I2610d815aeb186298498e7102cac773ecac8cd36 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/277002 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Artem Titov <titovartem@webrtc.org> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Commit-Queue: Jonas Oreland <jonaso@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38242}
2022-09-29 10:28:24 +02:00
"../../video/config:encoder_config",
Replace std::string::find() == 0 with absl::StartsWith (part 2). This CL has been generated using clang-tidy [1] except for changes to BUILD.gn files. [1] - https://clang.llvm.org/extra/clang-tidy/checks/abseil-string-find-startswith.html Bug: None Change-Id: Ibf75601065a53bde28623b8eef57bec067235640 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/172586 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30984}
2020-04-01 13:43:08 +02:00
"//third_party/abseil-cpp/absl/strings",
Move congestion window field trial parsing to new class. This cl is part of work to move several experiments into a joint experiment group. Most of them vill be ralted to video, hence the name. Bug: webrtc:10223 Change-Id: I8767c43abb6aa910ab51710eeb908e0f9df1e296 Reviewed-on: https://webrtc-review.googlesource.com/c/118361 Commit-Queue: Erik Språng <sprang@webrtc.org> Reviewed-by: Sebastian Jansson <srte@webrtc.org> Reviewed-by: Stefan Holmer <stefan@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26346}
2019-01-21 16:30:55 +01:00
]
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("keyframe_interval_settings_experiment") {
Make keyframe generation/request intervals configurable through field trials. Bug: webrtc:10427 Change-Id: I5e7182fc8932943adc3e5f147be51b0b5df93172 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127882 Reviewed-by: Åsa Persson <asapersson@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Jonas Oreland <jonaso@webrtc.org> Reviewed-by: Philip Eliasson <philipel@webrtc.org> Commit-Queue: Rasmus Brandt <brandtr@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27233}
2019-03-21 11:46:17 +01:00
sources = [
"keyframe_interval_settings.cc",
"keyframe_interval_settings.h",
]
deps = [
":field_trial_parser",
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 12/inf rename WebRtcKeyValueConfig to FieldTrialsView Bug: webrtc:10335 Change-Id: If725bd498c4c3daf144bee638230fa089fdde833 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256965 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Jonas Oreland <jonaso@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36365}
2022-03-29 11:04:48 +02:00
"../../api:field_trials_view",
Make keyframe generation/request intervals configurable through field trials. Bug: webrtc:10427 Change-Id: I5e7182fc8932943adc3e5f147be51b0b5df93172 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127882 Reviewed-by: Åsa Persson <asapersson@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Jonas Oreland <jonaso@webrtc.org> Reviewed-by: Philip Eliasson <philipel@webrtc.org> Commit-Queue: Rasmus Brandt <brandtr@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27233}
2019-03-21 11:46:17 +01:00
]
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("stable_target_rate_experiment") {
Add ability to parse stable bwe experiment settings Bug: webrtc:10126 Change-Id: If90aa2303b19d1ba9f9c53060e423ab1e6677ceb Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149174 Reviewed-by: Florent Castelli <orphis@webrtc.org> Commit-Queue: Erik Språng <sprang@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28960}
2019-08-23 20:02:13 +02:00
sources = [
"stable_target_rate_experiment.cc",
"stable_target_rate_experiment.h",
]
deps = [
":field_trial_parser",
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 12/inf rename WebRtcKeyValueConfig to FieldTrialsView Bug: webrtc:10335 Change-Id: If725bd498c4c3daf144bee638230fa089fdde833 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256965 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Jonas Oreland <jonaso@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36365}
2022-03-29 11:04:48 +02:00
"../../api:field_trials_view",
Add ability to parse stable bwe experiment settings Bug: webrtc:10126 Change-Id: If90aa2303b19d1ba9f9c53060e423ab1e6677ceb Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149174 Reviewed-by: Florent Castelli <orphis@webrtc.org> Commit-Queue: Erik Språng <sprang@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28960}
2019-08-23 20:02:13 +02:00
]
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("min_video_bitrate_experiment") {
Extend WebRTC-Video-MinVideoBitrate to experiment per-codec The experiment was extended to support per-codec minimum bitrates for the following codecs: * VP8 * VP9 * H.264 The old semantic meaning for the field trial is retained, in that specifying "br:" applies a minimum bitrate to all codecs. If "br:" is not specified, the per-codec minimum config is consulted. Bug: webrtc:11024 Change-Id: I89630262c7710771d5e25d039fe35f0bd217b58a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/156171 Commit-Queue: Elad Alon <eladalon@webrtc.org> Reviewed-by: Åsa Persson <asapersson@webrtc.org> Reviewed-by: Ying Wang <yinwa@webrtc.org> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29450}
2019-10-11 16:19:43 +02:00
sources = [
"min_video_bitrate_experiment.cc",
"min_video_bitrate_experiment.h",
]
deps = [
":field_trial_parser",
Propagate field trials for WebRTC-Video-MinVideoBitrate Instead of relying on the global field trial string Bug: webrtc:10335 Change-Id: I491be089ffc725fd28483edf10eae4ae5d17d651 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/346263 Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Åsa Persson <asapersson@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42021}
2024-04-09 10:53:39 +02:00
"../../api:field_trials_view",
Extend WebRTC-Video-MinVideoBitrate to experiment per-codec The experiment was extended to support per-codec minimum bitrates for the following codecs: * VP8 * VP9 * H.264 The old semantic meaning for the field trial is retained, in that specifying "br:" applies a minimum bitrate to all codecs. If "br:" is not specified, the per-codec minimum config is consulted. Bug: webrtc:11024 Change-Id: I89630262c7710771d5e25d039fe35f0bd217b58a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/156171 Commit-Queue: Elad Alon <eladalon@webrtc.org> Reviewed-by: Åsa Persson <asapersson@webrtc.org> Reviewed-by: Ying Wang <yinwa@webrtc.org> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29450}
2019-10-11 16:19:43 +02:00
"../../api/units:data_rate",
"../../api/video:video_frame",
"../../rtc_base:checks",
"../../rtc_base:logging",
]
}
Remove from chromium build targets that are not compatible with it. We need to be able build chromium with rtc_include_tests = true. It reveals a lot of targets that are not compatible with chromium but aren't marked so. `rtc_include_tests=true` has been considered a way to disable targets for the Chromium build, causing an overload on rtc_include_tests while the meaning of the two GN args (rtc_include_tests and build_with_chromium) should be kept separated. Bug: webrtc:12404 Change-Id: I2f72825445916eae7c20ef9338672d6a07a9b9ff Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/203890 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Andrey Logvin <landrey@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33124}
2021-02-01 09:56:37 +00:00
if (rtc_include_tests && !build_with_chromium) {
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("experiments_unittests") {
Adds BBR network controller field trial. This CL adds a field trial to enable the BBR congestion control method. Since BBR is only implemented to handle per packet feedback, SendSideCongestionController is modified to recreate network controllers when the packet feedback availability changes and the BBR experiment is enabled. This also means that the periodic task used for process updates in the network controllers has to recreated. Bug: webrtc:8415 Change-Id: Ia24f7ad35336d2cc7a02bb3a445f1a84b8643475 Reviewed-on: https://webrtc-review.googlesource.com/61520 Commit-Queue: Sebastian Jansson <srte@webrtc.org> Reviewed-by: Stefan Holmer <stefan@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22791}
2018-04-09 11:13:04 +02:00
testonly = true
sources = [
Make balanced degradation settings configurable through field trial. Bug: none Change-Id: Iad6dfdfdae13149bb8abe4b884e288e50aa7b73d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/135102 Reviewed-by: Stefan Holmer <stefan@webrtc.org> Commit-Queue: Åsa Persson <asapersson@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27892}
2019-05-06 12:22:49 +02:00
"balanced_degradation_settings_unittest.cc",
Add resolution_bitrate_limits to EncoderInfo field trial. Added class EncoderInfoSettings for parsing settings. Added use of class to SimulcastEncoderAdapter. Bug: none Change-Id: I8182b2ab43f0c330ebdf077e9f7cbc79247da90e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/202246 Commit-Queue: Åsa Persson <asapersson@webrtc.org> Reviewed-by: Sergey Silkin <ssilkin@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33050}
2021-01-20 15:36:13 +01:00
"encoder_info_settings_unittest.cc",
Add support for lists to the FieldTrialParser. List elements are separated by a |. If the key is given without a : we treat that as a empty list. We also support parsing multiple lists as a list-of-structs, see the unit test for usage examples. Bug: webrtc:9346 Change-Id: I32d3ce612fef476b1c481c00a893d7fa2f339e92 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/130464 Reviewed-by: Sebastian Jansson <srte@webrtc.org> Commit-Queue: Jonas Olsson <jonasolsson@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27560}
2019-04-11 11:53:26 +02:00
"field_trial_list_unittest.cc",
Adds field trial parser. Bug: webrtc:9346 Change-Id: Ibd07a1753feaa40d4be4d465d61f55bc8a8a9325 Reviewed-on: https://webrtc-review.googlesource.com/80263 Commit-Queue: Sebastian Jansson <srte@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Stefan Holmer <stefan@webrtc.org> Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23615}
2018-06-14 16:47:42 +02:00
"field_trial_parser_unittest.cc",
"field_trial_units_unittest.cc",
Make keyframe generation/request intervals configurable through field trials. Bug: webrtc:10427 Change-Id: I5e7182fc8932943adc3e5f147be51b0b5df93172 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127882 Reviewed-by: Åsa Persson <asapersson@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Jonas Oreland <jonaso@webrtc.org> Reviewed-by: Philip Eliasson <philipel@webrtc.org> Commit-Queue: Rasmus Brandt <brandtr@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27233}
2019-03-21 11:46:17 +01:00
"keyframe_interval_settings_unittest.cc",
Extend WebRTC-Video-MinVideoBitrate to experiment per-codec The experiment was extended to support per-codec minimum bitrates for the following codecs: * VP8 * VP9 * H.264 The old semantic meaning for the field trial is retained, in that specifying "br:" applies a minimum bitrate to all codecs. If "br:" is not specified, the per-codec minimum config is consulted. Bug: webrtc:11024 Change-Id: I89630262c7710771d5e25d039fe35f0bd217b58a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/156171 Commit-Queue: Elad Alon <eladalon@webrtc.org> Reviewed-by: Åsa Persson <asapersson@webrtc.org> Reviewed-by: Ying Wang <yinwa@webrtc.org> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29450}
2019-10-11 16:19:43 +02:00
"min_video_bitrate_experiment_unittest.cc",
Add field trial for normalized simulcast size. The width/height of the highest simulcast layer is divisible by 2^exponent. The exponent is allowed to be set through the field trial. Bug: none Change-Id: I2ec0af2deb6e3a176f705a2ad1c250a35b086701 Reviewed-on: https://webrtc-review.googlesource.com/c/104067 Reviewed-by: Stefan Holmer <stefan@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Commit-Queue: Åsa Persson <asapersson@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25159}
2018-10-12 17:36:57 +02:00
"normalize_simulcast_size_experiment_unittest.cc",
Add ability to configure quality scaler settings through field trial. optional<int> min_frames: The minimum number frames to observe to make a scaling decision. Default: kMinFramesNeededToScale in quality_scaler.cc optional<double> initial_scale_factor: The sample period scale factor. Default: kSamplePeriodScaleFactor in quality_scaler.cc optional<double> scale_factor: Option to use a reduced sampling interval when last check did not result in an adaptation (if unset the initial_scale_factor is used). Bug: none Change-Id: I3bb955d1f8d7d7d49bc118361614b5aa59605231 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/135125 Commit-Queue: Åsa Persson <asapersson@webrtc.org> Reviewed-by: Stefan Holmer <stefan@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27860}
2019-05-06 14:17:35 +02:00
"quality_scaler_settings_unittest.cc",
Make quality scaler downscale faster. Include dropped frames by the encoder in the frame drop percentage. To react faster at low framerates: - Use ExpFilter instead of MovingAverage to filter QP values. - Reduce sampling interval while waiting for minimum number of needed frames (when not in fast rampup mode). A separate slower ExpFilter is used for upscaling. Bug: webrtc:9169 Change-Id: If7ff6c3bd4201fda2da67125889838fe96ce7061 Reviewed-on: https://webrtc-review.googlesource.com/70761 Commit-Queue: Åsa Persson <asapersson@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23014}
2018-04-24 16:53:25 +02:00
"quality_scaling_experiment_unittest.cc",
Account for simulcast hysteresis in padding rate calculation. Bug: webrtc:10271 Change-Id: If0b0eb7d94fb1c892880ff4745f34c43fcdeee54 Reviewed-on: https://webrtc-review.googlesource.com/c/120661 Commit-Queue: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26527}
2019-02-04 11:09:46 +01:00
"rate_control_settings_unittest.cc",
Add ability to parse stable bwe experiment settings Bug: webrtc:10126 Change-Id: If90aa2303b19d1ba9f9c53060e423ab1e6677ceb Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149174 Reviewed-by: Florent Castelli <orphis@webrtc.org> Commit-Queue: Erik Språng <sprang@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28960}
2019-08-23 20:02:13 +02:00
"stable_target_rate_experiment_unittest.cc",
Adds struct parameters parser/encoder. This is similar to the field trial parser but it uses a normal struct with normal fields as underlying storage. This makes it easier to understand and use as only the encoding and parsing uses non- standard constructs. Additionally, it makes it easier to use the struct as a regular config struct when the values are not set using field trials. Bug: webrtc:9883 Change-Id: I5b16c2a71875b6f478383decff18fbaa62bc404a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145203 Reviewed-by: Jonas Olsson <jonasolsson@webrtc.org> Commit-Queue: Sebastian Jansson <srte@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28810}
2019-08-08 11:14:51 +02:00
"struct_parameters_parser_unittest.cc",
Adds BBR network controller field trial. This CL adds a field trial to enable the BBR congestion control method. Since BBR is only implemented to handle per packet feedback, SendSideCongestionController is modified to recreate network controllers when the packet feedback availability changes and the BBR experiment is enabled. This also means that the periodic task used for process updates in the network controllers has to recreated. Bug: webrtc:8415 Change-Id: Ia24f7ad35336d2cc7a02bb3a445f1a84b8643475 Reviewed-on: https://webrtc-review.googlesource.com/61520 Commit-Queue: Sebastian Jansson <srte@webrtc.org> Reviewed-by: Stefan Holmer <stefan@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22791}
2018-04-09 11:13:04 +02:00
]
deps = [
Make balanced degradation settings configurable through field trial. Bug: none Change-Id: Iad6dfdfdae13149bb8abe4b884e288e50aa7b73d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/135102 Reviewed-by: Stefan Holmer <stefan@webrtc.org> Commit-Queue: Åsa Persson <asapersson@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27892}
2019-05-06 12:22:49 +02:00
":balanced_degradation_settings",
Add resolution_bitrate_limits to EncoderInfo field trial. Added class EncoderInfoSettings for parsing settings. Added use of class to SimulcastEncoderAdapter. Bug: none Change-Id: I8182b2ab43f0c330ebdf077e9f7cbc79247da90e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/202246 Commit-Queue: Åsa Persson <asapersson@webrtc.org> Reviewed-by: Sergey Silkin <ssilkin@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33050}
2021-01-20 15:36:13 +01:00
":encoder_info_settings",
Adds field trial parser. Bug: webrtc:9346 Change-Id: Ibd07a1753feaa40d4be4d465d61f55bc8a8a9325 Reviewed-on: https://webrtc-review.googlesource.com/80263 Commit-Queue: Sebastian Jansson <srte@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Stefan Holmer <stefan@webrtc.org> Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23615}
2018-06-14 16:47:42 +02:00
":field_trial_parser",
Make keyframe generation/request intervals configurable through field trials. Bug: webrtc:10427 Change-Id: I5e7182fc8932943adc3e5f147be51b0b5df93172 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127882 Reviewed-by: Åsa Persson <asapersson@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Jonas Oreland <jonaso@webrtc.org> Reviewed-by: Philip Eliasson <philipel@webrtc.org> Commit-Queue: Rasmus Brandt <brandtr@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27233}
2019-03-21 11:46:17 +01:00
":keyframe_interval_settings_experiment",
Extend WebRTC-Video-MinVideoBitrate to experiment per-codec The experiment was extended to support per-codec minimum bitrates for the following codecs: * VP8 * VP9 * H.264 The old semantic meaning for the field trial is retained, in that specifying "br:" applies a minimum bitrate to all codecs. If "br:" is not specified, the per-codec minimum config is consulted. Bug: webrtc:11024 Change-Id: I89630262c7710771d5e25d039fe35f0bd217b58a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/156171 Commit-Queue: Elad Alon <eladalon@webrtc.org> Reviewed-by: Åsa Persson <asapersson@webrtc.org> Reviewed-by: Ying Wang <yinwa@webrtc.org> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29450}
2019-10-11 16:19:43 +02:00
":min_video_bitrate_experiment",
Add field trial for normalized simulcast size. The width/height of the highest simulcast layer is divisible by 2^exponent. The exponent is allowed to be set through the field trial. Bug: none Change-Id: I2ec0af2deb6e3a176f705a2ad1c250a35b086701 Reviewed-on: https://webrtc-review.googlesource.com/c/104067 Reviewed-by: Stefan Holmer <stefan@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Commit-Queue: Åsa Persson <asapersson@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25159}
2018-10-12 17:36:57 +02:00
":normalize_simulcast_size_experiment",
Add ability to configure quality scaler settings through field trial. optional<int> min_frames: The minimum number frames to observe to make a scaling decision. Default: kMinFramesNeededToScale in quality_scaler.cc optional<double> initial_scale_factor: The sample period scale factor. Default: kSamplePeriodScaleFactor in quality_scaler.cc optional<double> scale_factor: Option to use a reduced sampling interval when last check did not result in an adaptation (if unset the initial_scale_factor is used). Bug: none Change-Id: I3bb955d1f8d7d7d49bc118361614b5aa59605231 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/135125 Commit-Queue: Åsa Persson <asapersson@webrtc.org> Reviewed-by: Stefan Holmer <stefan@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27860}
2019-05-06 14:17:35 +02:00
":quality_scaler_settings",
Make quality scaler downscale faster. Include dropped frames by the encoder in the frame drop percentage. To react faster at low framerates: - Use ExpFilter instead of MovingAverage to filter QP values. - Reduce sampling interval while waiting for minimum number of needed frames (when not in fast rampup mode). A separate slower ExpFilter is used for upscaling. Bug: webrtc:9169 Change-Id: If7ff6c3bd4201fda2da67125889838fe96ce7061 Reviewed-on: https://webrtc-review.googlesource.com/70761 Commit-Queue: Åsa Persson <asapersson@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23014}
2018-04-24 16:53:25 +02:00
":quality_scaling_experiment",
Account for simulcast hysteresis in padding rate calculation. Bug: webrtc:10271 Change-Id: If0b0eb7d94fb1c892880ff4745f34c43fcdeee54 Reviewed-on: https://webrtc-review.googlesource.com/c/120661 Commit-Queue: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26527}
2019-02-04 11:09:46 +01:00
":rate_control_settings",
Add ability to parse stable bwe experiment settings Bug: webrtc:10126 Change-Id: If90aa2303b19d1ba9f9c53060e423ab1e6677ceb Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149174 Reviewed-by: Florent Castelli <orphis@webrtc.org> Commit-Queue: Erik Språng <sprang@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28960}
2019-08-23 20:02:13 +02:00
":stable_target_rate_experiment",
Decouple //rtc_base:rtc_base_tests_utils from gunit. This CL decouples //rtc_base:rtc_base_tests_utils from gunit by moving gunit helpers (rtc_base/gunit.h) and rtc_base/testclient.h (which depends on gunit helpers) to their own build target. It also removes some unused dependencies in the WebRTC build graph. Bug: None Change-Id: Ia9820e84ff697da39b351eef73c45f6e4bdf2623 Reviewed-on: https://webrtc-review.googlesource.com/c/111861 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25769}
2018-11-23 13:15:08 +01:00
"..:gunit_helpers",
Adds BBR network controller field trial. This CL adds a field trial to enable the BBR congestion control method. Since BBR is only implemented to handle per packet feedback, SendSideCongestionController is modified to recreate network controllers when the packet feedback availability changes and the BBR experiment is enabled. This also means that the periodic task used for process updates in the network controllers has to recreated. Bug: webrtc:8415 Change-Id: Ia24f7ad35336d2cc7a02bb3a445f1a84b8643475 Reviewed-on: https://webrtc-review.googlesource.com/61520 Commit-Queue: Sebastian Jansson <srte@webrtc.org> Reviewed-by: Stefan Holmer <stefan@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22791}
2018-04-09 11:13:04 +02:00
"../:rtc_base_tests_utils",
Extend WebRTC-Video-MinVideoBitrate to experiment per-codec The experiment was extended to support per-codec minimum bitrates for the following codecs: * VP8 * VP9 * H.264 The old semantic meaning for the field trial is retained, in that specifying "br:" applies a minimum bitrate to all codecs. If "br:" is not specified, the per-codec minimum config is consulted. Bug: webrtc:11024 Change-Id: I89630262c7710771d5e25d039fe35f0bd217b58a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/156171 Commit-Queue: Elad Alon <eladalon@webrtc.org> Reviewed-by: Åsa Persson <asapersson@webrtc.org> Reviewed-by: Ying Wang <yinwa@webrtc.org> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29450}
2019-10-11 16:19:43 +02:00
"../../api/units:data_rate",
"../../api/video:video_frame",
Account for simulcast hysteresis in padding rate calculation. Bug: webrtc:10271 Change-Id: If0b0eb7d94fb1c892880ff4745f34c43fcdeee54 Reviewed-on: https://webrtc-review.googlesource.com/c/120661 Commit-Queue: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26527}
2019-02-04 11:09:46 +01:00
"../../api/video_codecs:video_codecs_api",
Remove deprecated field_trial_default and metrics_default. This CL removes some deprecated build targets (and their headers) from system_wrappers: - field_trial_api - field_trial_default - metrics_api - metrics_default It also refreshes all the dependencies on field_trial.h and metrics.h. A nice side effect is that it is finally possible to remove 'nogncheck' from the following files (when it was used with field_trial_default and metrics_default): - sdk/objc/api/peerconnection/RTCMetricsSampleInfo+Private.h - sdk/android/src/jni/pc/peerconnectionfactory.cc - sdk/objc/api/peerconnection/RTCFieldTrials.mm Bug: webrtc:9631 Change-Id: Ib621f41ef8ad0aba4fe1c1d7e749c044afc956c3 No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/100524 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24878}
2018-09-28 08:51:10 +02:00
"../../system_wrappers:field_trial",
Use propagated field trials for WebRTC-NormalizeSimulcastResolution experiment Bug: webrtc:10335 Change-Id: I2db0ac9fc305e033c26cb8401db38317fbc71014 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/343761 Reviewed-by: Åsa Persson <asapersson@webrtc.org> Commit-Queue: Åsa Persson <asapersson@webrtc.org> Auto-Submit: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41934}
2024-03-20 15:41:27 +01:00
"../../test:explicit_key_value_config",
Adds BBR network controller field trial. This CL adds a field trial to enable the BBR congestion control method. Since BBR is only implemented to handle per packet feedback, SendSideCongestionController is modified to recreate network controllers when the packet feedback availability changes and the BBR experiment is enabled. This also means that the periodic task used for process updates in the network controllers has to recreated. Bug: webrtc:8415 Change-Id: Ia24f7ad35336d2cc7a02bb3a445f1a84b8643475 Reviewed-on: https://webrtc-review.googlesource.com/61520 Commit-Queue: Sebastian Jansson <srte@webrtc.org> Reviewed-by: Stefan Holmer <stefan@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22791}
2018-04-09 11:13:04 +02:00
"../../test:field_trial",
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 2 convert call/ (and the collaterals) Bug: webrtc:10335 Change-Id: I8f6bc13c032713aa2a947724b464f6f35454d39a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/254320 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Jonas Oreland <jonaso@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36165}
2022-03-09 15:12:07 +01:00
"../../test:scoped_key_value_config",
Delete rtc_base/unittest_main.cc Usage replaced with test/test_main.cc. Bug: webrtc:5996 Change-Id: I65e7539f2072fb45255a3c1af0b10dd06e1701ca Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/137805 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28010}
2019-05-21 13:01:58 +02:00
"../../test:test_main",
Add field trial for vp8 cpu speed configuration for arm. Bug: none Change-Id: I90c2475a229a1f10016e2ad84029e19b5a4f9966 Reviewed-on: https://webrtc-review.googlesource.com/c/107340 Commit-Queue: Åsa Persson <asapersson@webrtc.org> Reviewed-by: Stefan Holmer <stefan@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25484}
2018-11-02 11:38:46 +01:00
"../../test:test_support",
Move VideoEncoderConfig from api/ into video/config This cl move VideoEncoderConfig from api/ to video/config. VideoStreamEncoderInterface and VideoStreamEncoderObserver are moved as collateral. brandt@ think that the reason these were in api/ in the first place had to downstream project. Functionality wise, this is a NOP, but it makes it easier to modify the encoder (config). Bug: webrtc:14451 Change-Id: I2610d815aeb186298498e7102cac773ecac8cd36 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/277002 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Artem Titov <titovartem@webrtc.org> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Commit-Queue: Jonas Oreland <jonaso@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38242}
2022-09-29 10:28:24 +02:00
"../../video/config:encoder_config",
Mass removal of absl_deps in all BUILD.gn files Bug: webrtc:341803749 Change-Id: Id73844ba8d63b9f2f2c9391d8d8116ad0864c36d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/351540 Commit-Queue: Florent Castelli <orphis@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42372}
2024-05-23 11:21:53 +00:00
"//third_party/abseil-cpp/absl/strings:string_view",
Adopt absl::string_view in function parameters under rtc_base/ This is part of a large-scale effort to increase adoption of absl::string_view across the WebRTC code base. This CL converts the majority of "const std::string&"s in function parameters under rtc_base/ to absl::string_view. Bug: webrtc:13579 Change-Id: I2b1e3776aa42326aa405f76bb324a2d233b21dca Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/254081 Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Xavier Lepaul‎ <xalep@webrtc.org> Reviewed-by: Anders Lilienthal <andersc@webrtc.org> Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Ali Tofigh <alito@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36239}
2022-03-17 15:47:49 +01:00
]
Adds BBR network controller field trial. This CL adds a field trial to enable the BBR congestion control method. Since BBR is only implemented to handle per packet feedback, SendSideCongestionController is modified to recreate network controllers when the packet feedback availability changes and the BBR experiment is enabled. This also means that the periodic task used for process updates in the network controllers has to recreated. Bug: webrtc:8415 Change-Id: Ia24f7ad35336d2cc7a02bb3a445f1a84b8643475 Reviewed-on: https://webrtc-review.googlesource.com/61520 Commit-Queue: Sebastian Jansson <srte@webrtc.org> Reviewed-by: Stefan Holmer <stefan@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22791}
2018-04-09 11:13:04 +02:00
}
}
Reference in New Issue Copy Permalink