webrtc_m130/stats/attribute.cc

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

148 lines
4.9 KiB
C++
Raw Normal View History

/*
* Copyright 2024 The WebRTC Project Authors. All rights reserved.
*
* Use of this source code is governed by a BSD-style license
* that can be found in the LICENSE file in the root of the source
* tree. An additional intellectual property rights grant can be found
* in the file PATENTS. All contributing project authors may
* be found in the AUTHORS file in the root of the source tree.
*/
#include "api/stats/attribute.h"
#include "absl/types/variant.h"
#include "rtc_base/checks.h"
namespace webrtc {
namespace {
struct VisitIsSequence {
// Any type of vector is a sequence.
template <typename T>
bool operator()(const RTCStatsMember<std::vector<T>>* attribute) {
return true;
}
// Any other type is not.
template <typename T>
bool operator()(const RTCStatsMember<T>* attribute) {
return false;
}
};
struct VisitIsEqual {
template <typename T>
bool operator()(const RTCStatsMember<T>* attribute) {
Revert "[Stats] Move metric names to Attribute, constructed via AttributeInit." This reverts commit 84c48ae7513bad9c9ca19271569cd0431e780c32. Reason for revert: Breaks downstream project Original change's description: > [Stats] Move metric names to Attribute, constructed via AttributeInit. > > As of this CL, Attribute no longer implements RTCStatsMemberInterface > and a member no longer owns knowing its own name. The attribute knows > the name because we pass it down at construction time. > > To achieve this, the WEBRTC_RTCSTATS_IMPL() macro is updated to take > AttributeInits instead of raw member pointers, i.e. (name, ptr) pairs. > > By constructing RTCStatsMember<T> without a name parameter, it does the > same thing as the absl::optional<T> constructor. So RTCStatsMember<T>'s > days are numbered! > > Bug: webrtc:15164 > Change-Id: I560c0134bae1c2d7218426a1576425ecc1b677a7 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334203 > Commit-Queue: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Evan Shrubsole <eshr@google.com> > Cr-Commit-Position: refs/heads/main@{#41540} Bug: webrtc:15164 Change-Id: I9f416838153b26d4560ae98c37fb18a803d0295d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334901 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41550}
2024-01-17 16:59:52 +00:00
return attribute->IsEqual(other);
}
Revert "[Stats] Move metric names to Attribute, constructed via AttributeInit." This reverts commit 84c48ae7513bad9c9ca19271569cd0431e780c32. Reason for revert: Breaks downstream project Original change's description: > [Stats] Move metric names to Attribute, constructed via AttributeInit. > > As of this CL, Attribute no longer implements RTCStatsMemberInterface > and a member no longer owns knowing its own name. The attribute knows > the name because we pass it down at construction time. > > To achieve this, the WEBRTC_RTCSTATS_IMPL() macro is updated to take > AttributeInits instead of raw member pointers, i.e. (name, ptr) pairs. > > By constructing RTCStatsMember<T> without a name parameter, it does the > same thing as the absl::optional<T> constructor. So RTCStatsMember<T>'s > days are numbered! > > Bug: webrtc:15164 > Change-Id: I560c0134bae1c2d7218426a1576425ecc1b677a7 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334203 > Commit-Queue: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Evan Shrubsole <eshr@google.com> > Cr-Commit-Position: refs/heads/main@{#41540} Bug: webrtc:15164 Change-Id: I9f416838153b26d4560ae98c37fb18a803d0295d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334901 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41550}
2024-01-17 16:59:52 +00:00
const RTCStatsMemberInterface& other;
};
} // namespace
Revert "[Stats] Move metric names to Attribute, constructed via AttributeInit." This reverts commit 84c48ae7513bad9c9ca19271569cd0431e780c32. Reason for revert: Breaks downstream project Original change's description: > [Stats] Move metric names to Attribute, constructed via AttributeInit. > > As of this CL, Attribute no longer implements RTCStatsMemberInterface > and a member no longer owns knowing its own name. The attribute knows > the name because we pass it down at construction time. > > To achieve this, the WEBRTC_RTCSTATS_IMPL() macro is updated to take > AttributeInits instead of raw member pointers, i.e. (name, ptr) pairs. > > By constructing RTCStatsMember<T> without a name parameter, it does the > same thing as the absl::optional<T> constructor. So RTCStatsMember<T>'s > days are numbered! > > Bug: webrtc:15164 > Change-Id: I560c0134bae1c2d7218426a1576425ecc1b677a7 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334203 > Commit-Queue: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Evan Shrubsole <eshr@google.com> > Cr-Commit-Position: refs/heads/main@{#41540} Bug: webrtc:15164 Change-Id: I9f416838153b26d4560ae98c37fb18a803d0295d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334901 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41550}
2024-01-17 16:59:52 +00:00
Attribute::~Attribute() {}
// static
Attribute Attribute::FromMemberInterface(
const RTCStatsMemberInterface* member) {
switch (member->type()) {
case RTCStatsMemberInterface::Type::kBool:
return Attribute(&member->cast_to<RTCStatsMember<bool>>());
case RTCStatsMemberInterface::Type::kInt32:
return Attribute(&member->cast_to<RTCStatsMember<int32_t>>());
case RTCStatsMemberInterface::Type::kUint32:
return Attribute(&member->cast_to<RTCStatsMember<uint32_t>>());
case RTCStatsMemberInterface::Type::kInt64:
return Attribute(&member->cast_to<RTCStatsMember<int64_t>>());
case RTCStatsMemberInterface::Type::kUint64:
return Attribute(&member->cast_to<RTCStatsMember<uint64_t>>());
case RTCStatsMemberInterface::Type::kDouble:
return Attribute(&member->cast_to<RTCStatsMember<double>>());
case RTCStatsMemberInterface::Type::kString:
return Attribute(&member->cast_to<RTCStatsMember<std::string>>());
case RTCStatsMemberInterface::Type::kSequenceBool:
return Attribute(&member->cast_to<RTCStatsMember<std::vector<bool>>>());
case RTCStatsMemberInterface::Type::kSequenceInt32:
return Attribute(
&member->cast_to<RTCStatsMember<std::vector<int32_t>>>());
case RTCStatsMemberInterface::Type::kSequenceUint32:
return Attribute(
&member->cast_to<RTCStatsMember<std::vector<uint32_t>>>());
case RTCStatsMemberInterface::Type::kSequenceInt64:
return Attribute(
&member->cast_to<RTCStatsMember<std::vector<int64_t>>>());
case RTCStatsMemberInterface::Type::kSequenceUint64:
return Attribute(
&member->cast_to<RTCStatsMember<std::vector<uint64_t>>>());
case RTCStatsMemberInterface::Type::kSequenceDouble:
return Attribute(&member->cast_to<RTCStatsMember<std::vector<double>>>());
case RTCStatsMemberInterface::Type::kSequenceString:
return Attribute(
&member->cast_to<RTCStatsMember<std::vector<std::string>>>());
case RTCStatsMemberInterface::Type::kMapStringUint64:
return Attribute(
&member->cast_to<RTCStatsMember<std::map<std::string, uint64_t>>>());
case RTCStatsMemberInterface::Type::kMapStringDouble:
return Attribute(
&member->cast_to<RTCStatsMember<std::map<std::string, double>>>());
default:
RTC_CHECK_NOTREACHED();
}
}
const char* Attribute::name() const {
Revert "[Stats] Move metric names to Attribute, constructed via AttributeInit." This reverts commit 84c48ae7513bad9c9ca19271569cd0431e780c32. Reason for revert: Breaks downstream project Original change's description: > [Stats] Move metric names to Attribute, constructed via AttributeInit. > > As of this CL, Attribute no longer implements RTCStatsMemberInterface > and a member no longer owns knowing its own name. The attribute knows > the name because we pass it down at construction time. > > To achieve this, the WEBRTC_RTCSTATS_IMPL() macro is updated to take > AttributeInits instead of raw member pointers, i.e. (name, ptr) pairs. > > By constructing RTCStatsMember<T> without a name parameter, it does the > same thing as the absl::optional<T> constructor. So RTCStatsMember<T>'s > days are numbered! > > Bug: webrtc:15164 > Change-Id: I560c0134bae1c2d7218426a1576425ecc1b677a7 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334203 > Commit-Queue: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Evan Shrubsole <eshr@google.com> > Cr-Commit-Position: refs/heads/main@{#41540} Bug: webrtc:15164 Change-Id: I9f416838153b26d4560ae98c37fb18a803d0295d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334901 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41550}
2024-01-17 16:59:52 +00:00
return absl::visit([](const auto* attr) { return attr->name(); }, attribute_);
}
const Attribute::StatVariant& Attribute::as_variant() const {
return attribute_;
}
bool Attribute::has_value() const {
return absl::visit([](const auto* attr) { return attr->has_value(); },
attribute_);
}
Revert "[Stats] Move metric names to Attribute, constructed via AttributeInit." This reverts commit 84c48ae7513bad9c9ca19271569cd0431e780c32. Reason for revert: Breaks downstream project Original change's description: > [Stats] Move metric names to Attribute, constructed via AttributeInit. > > As of this CL, Attribute no longer implements RTCStatsMemberInterface > and a member no longer owns knowing its own name. The attribute knows > the name because we pass it down at construction time. > > To achieve this, the WEBRTC_RTCSTATS_IMPL() macro is updated to take > AttributeInits instead of raw member pointers, i.e. (name, ptr) pairs. > > By constructing RTCStatsMember<T> without a name parameter, it does the > same thing as the absl::optional<T> constructor. So RTCStatsMember<T>'s > days are numbered! > > Bug: webrtc:15164 > Change-Id: I560c0134bae1c2d7218426a1576425ecc1b677a7 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334203 > Commit-Queue: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Evan Shrubsole <eshr@google.com> > Cr-Commit-Position: refs/heads/main@{#41540} Bug: webrtc:15164 Change-Id: I9f416838153b26d4560ae98c37fb18a803d0295d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334901 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41550}
2024-01-17 16:59:52 +00:00
RTCStatsMemberInterface::Type Attribute::type() const {
return absl::visit([](const auto* attr) { return attr->type(); }, attribute_);
}
const RTCStatsMemberInterface* Attribute::member_ptr() const {
return absl::visit(
[](const auto* attr) {
return static_cast<const RTCStatsMemberInterface*>(attr);
},
attribute_);
}
bool Attribute::is_sequence() const {
return absl::visit(VisitIsSequence(), attribute_);
}
bool Attribute::is_string() const {
return absl::holds_alternative<const RTCStatsMember<std::string>*>(
attribute_);
}
Revert "[Stats] Move metric names to Attribute, constructed via AttributeInit." This reverts commit 84c48ae7513bad9c9ca19271569cd0431e780c32. Reason for revert: Breaks downstream project Original change's description: > [Stats] Move metric names to Attribute, constructed via AttributeInit. > > As of this CL, Attribute no longer implements RTCStatsMemberInterface > and a member no longer owns knowing its own name. The attribute knows > the name because we pass it down at construction time. > > To achieve this, the WEBRTC_RTCSTATS_IMPL() macro is updated to take > AttributeInits instead of raw member pointers, i.e. (name, ptr) pairs. > > By constructing RTCStatsMember<T> without a name parameter, it does the > same thing as the absl::optional<T> constructor. So RTCStatsMember<T>'s > days are numbered! > > Bug: webrtc:15164 > Change-Id: I560c0134bae1c2d7218426a1576425ecc1b677a7 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334203 > Commit-Queue: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Evan Shrubsole <eshr@google.com> > Cr-Commit-Position: refs/heads/main@{#41540} Bug: webrtc:15164 Change-Id: I9f416838153b26d4560ae98c37fb18a803d0295d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334901 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41550}
2024-01-17 16:59:52 +00:00
bool Attribute::is_defined() const {
return absl::visit([](const auto* attr) { return attr->is_defined(); },
attribute_);
}
Revert "[Stats] Attribute::ToString(), to replace member ValueToString/ToJson." This reverts commit 54be7084e0861a0179a5fccd0b27edf7d7994bbb. Reason for revert: Breaks downstream project. Original change's description: > [Stats] Attribute::ToString(), to replace member ValueToString/ToJson. > > Delete RTCStatsMember<T>::ValueToString() and ValueToJson() in favor of > Attribute::ToString(). > > The difference between "ToString" and "ToJson" is that the "ToJson" > version converts 64-bit integers and doubles to floating points with no > more than ~15 digits of precision as to not exceed JSON's precision > limitations. So only in edge cases of really large numbers or numbers > with a silly number of digits will the two methods produce different > results. Also JSON puts '\"' around map key names, e.g. "{\"foo\":123}" > as opposed to "{foo:123}". > > Going forward we see no reason to maintain two different string > converted paths that are this similar, so we only implement one > Attribute::ToString() method which does what "ToJson" did. > > In the next CL we can delete RTCStatsMember<T>. > > Bug: webrtc:15164 > Change-Id: Iaa8cf3bf14b40dc44664f75989832469603131c5 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334640 > Commit-Queue: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Evan Shrubsole <eshr@google.com> > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#41544} Bug: webrtc:15164 Change-Id: I187d7dff6f330a4a440279e6c32d88eb6ddefac8 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334820 Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41546}
2024-01-17 14:05:45 +00:00
std::string Attribute::ValueToString() const {
return absl::visit([](const auto* attr) { return attr->ValueToString(); },
attribute_);
}
std::string Attribute::ValueToJson() const {
return absl::visit([](const auto* attr) { return attr->ValueToJson(); },
attribute_);
}
Revert "[Stats] Move metric names to Attribute, constructed via AttributeInit." This reverts commit 84c48ae7513bad9c9ca19271569cd0431e780c32. Reason for revert: Breaks downstream project Original change's description: > [Stats] Move metric names to Attribute, constructed via AttributeInit. > > As of this CL, Attribute no longer implements RTCStatsMemberInterface > and a member no longer owns knowing its own name. The attribute knows > the name because we pass it down at construction time. > > To achieve this, the WEBRTC_RTCSTATS_IMPL() macro is updated to take > AttributeInits instead of raw member pointers, i.e. (name, ptr) pairs. > > By constructing RTCStatsMember<T> without a name parameter, it does the > same thing as the absl::optional<T> constructor. So RTCStatsMember<T>'s > days are numbered! > > Bug: webrtc:15164 > Change-Id: I560c0134bae1c2d7218426a1576425ecc1b677a7 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334203 > Commit-Queue: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Evan Shrubsole <eshr@google.com> > Cr-Commit-Position: refs/heads/main@{#41540} Bug: webrtc:15164 Change-Id: I9f416838153b26d4560ae98c37fb18a803d0295d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334901 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41550}
2024-01-17 16:59:52 +00:00
bool Attribute::IsEqual(const RTCStatsMemberInterface& other) const {
return absl::visit(VisitIsEqual{.other = *other.member_ptr()}, attribute_);
}
} // namespace webrtc