admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
webrtc_m130/stats/rtcstats_objects.cc

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

698 lines
22 KiB
C++
Raw Normal View History

RTCStatsCollector and RTCPeerConnectionStats added. This is the stats collector for the new stats types, RTCStats[1] and RTCStatsReport[2]. It so far only produces RTCPeerConnectionStats[3] as an example of how it would collect stats. Each RTCStats subclass will get a corresponding RTCStatsCollector::ProduceFooStats(). Stats reports are cached and returned as const references (ref counting). This allows stats to be inspected by multiple observers and across multiple threads. No copies will have to be made when surfacing this to Blink or other places. The current implementation of ProducePeerConnectionStats() only look at existing DataChannels. This might be incorret if data channels can be removed? Will investigate in a follow-up, crbug.com/636818. [1] https://www.w3.org/TR/2016/WD-webrtc-20160531/#idl-def-rtcstats [2] https://www.w3.org/TR/2016/WD-webrtc-20160531/#rtcstatsreport-object [3] https://w3c.github.io/webrtc-stats/archives/20160526/webrtc-stats.html#pcstats-dict* BUG=chromium:627816, chromium:636818 Review-Url: https://codereview.webrtc.org/2242043002 Cr-Commit-Position: refs/heads/master@{#13979}
2016-08-30 14:04:35 -07:00
/*
* Copyright 2016 The WebRTC Project Authors. All rights reserved.
*
* Use of this source code is governed by a BSD-style license
* that can be found in the LICENSE file in the root of the source
* tree. An additional intellectual property rights grant can be found
* in the file PATENTS. All contributing project authors may
* be found in the AUTHORS file in the root of the source tree.
*/
Fixing WebRTC after moving from src/webrtc to src/ In https://webrtc-review.googlesource.com/c/src/+/1560 we moved WebRTC from src/webrtc to src/ (in order to preserve an healthy git history). This CL takes care of fixing header guards, #include paths, etc... NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true TBR=tommi@webrtc.org Bug: chromium:611808 Change-Id: Iea91618212bee0af16aa3f05071eab8f93706578 Reviewed-on: https://webrtc-review.googlesource.com/1561 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#19846}
2017-09-15 06:47:31 +02:00
#include "api/stats/rtcstats_objects.h"
RTCStatsCollector and RTCPeerConnectionStats added. This is the stats collector for the new stats types, RTCStats[1] and RTCStatsReport[2]. It so far only produces RTCPeerConnectionStats[3] as an example of how it would collect stats. Each RTCStats subclass will get a corresponding RTCStatsCollector::ProduceFooStats(). Stats reports are cached and returned as const references (ref counting). This allows stats to be inspected by multiple observers and across multiple threads. No copies will have to be made when surfacing this to Blink or other places. The current implementation of ProducePeerConnectionStats() only look at existing DataChannels. This might be incorret if data channels can be removed? Will investigate in a follow-up, crbug.com/636818. [1] https://www.w3.org/TR/2016/WD-webrtc-20160531/#idl-def-rtcstats [2] https://www.w3.org/TR/2016/WD-webrtc-20160531/#rtcstatsreport-object [3] https://w3c.github.io/webrtc-stats/archives/20160526/webrtc-stats.html#pcstats-dict* BUG=chromium:627816, chromium:636818 Review-Url: https://codereview.webrtc.org/2242043002 Cr-Commit-Position: refs/heads/master@{#13979}
2016-08-30 14:04:35 -07:00
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2. This is a follow-up to https://webrtc-review.googlesource.com/c/src/+/106280. This time the whole code base is covered. Some files may have not been fixed though, whenever the IWYU tool was breaking the build. Bug: webrtc:8311 Change-Id: I2c31f552a87e887d33931d46e87b6208b1e483ef Reviewed-on: https://webrtc-review.googlesource.com/c/111965 Commit-Queue: Yves Gerey <yvesg@google.com> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25830}
2018-11-28 16:47:49 +01:00
#include <utility>
[Stats] Introduce Attribute, implementing RTCStatsMemberInterface. The plan is to replace Members() with Attributes() instead. For backwards-compatability during the transition, Attribute implements RTCStatsMemberInterface but the two classes serve the same purpose which is to allow iterating all metrics of a stats object. The reason for moving away from "members" is that we already have a way to express a variable that maybe has a value: absl::optional<T>. The only information the member adds is the const char* name(), which we'll move to Attribute in a future CL. We don't need to maintain an RTCStatsMemberInterface::Type enum in the future because absl::variant<T> has absl::holds_alternative<T>. Step 1: Add Attributes(). Step 2: Migrate to Attributes() and delete Members(). Step 3: Replaces all uses of RTCStatsMember<T> with absl::optional<T> and delete RTCStatsMember + RTCStatsMemberInterface. Bug: webrtc:15164 Change-Id: I3fdd5b24214bb5cc340a54a0171df73b516e1803 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/333840 Commit-Queue: Henrik Boström <hbos@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41507}
2024-01-11 11:41:10 +01:00
#include "api/stats/attribute.h"
Add origin trial ids to non-standard stats members. Bug: chromium:943076 Change-Id: I2d8211d3acd844cf602ed1c7de08bb7441263950 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128420 Commit-Queue: Jakob Ivarsson‎ <jakobi@webrtc.org> Reviewed-by: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27186}
2019-03-19 15:38:49 +01:00
#include "api/stats/rtc_stats.h"
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2. This is a follow-up to https://webrtc-review.googlesource.com/c/src/+/106280. This time the whole code base is covered. Some files may have not been fixed though, whenever the IWYU tool was breaking the build. Bug: webrtc:8311 Change-Id: I2c31f552a87e887d33931d46e87b6208b1e483ef Reviewed-on: https://webrtc-review.googlesource.com/c/111965 Commit-Queue: Yves Gerey <yvesg@google.com> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25830}
2018-11-28 16:47:49 +01:00
#include "rtc_base/checks.h"
Add origin trial ids to non-standard stats members. Bug: chromium:943076 Change-Id: I2d8211d3acd844cf602ed1c7de08bb7441263950 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128420 Commit-Queue: Jakob Ivarsson‎ <jakobi@webrtc.org> Reviewed-by: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27186}
2019-03-19 15:38:49 +01:00
RTCStatsCollector and RTCPeerConnectionStats added. This is the stats collector for the new stats types, RTCStats[1] and RTCStatsReport[2]. It so far only produces RTCPeerConnectionStats[3] as an example of how it would collect stats. Each RTCStats subclass will get a corresponding RTCStatsCollector::ProduceFooStats(). Stats reports are cached and returned as const references (ref counting). This allows stats to be inspected by multiple observers and across multiple threads. No copies will have to be made when surfacing this to Blink or other places. The current implementation of ProducePeerConnectionStats() only look at existing DataChannels. This might be incorret if data channels can be removed? Will investigate in a follow-up, crbug.com/636818. [1] https://www.w3.org/TR/2016/WD-webrtc-20160531/#idl-def-rtcstats [2] https://www.w3.org/TR/2016/WD-webrtc-20160531/#rtcstatsreport-object [3] https://w3c.github.io/webrtc-stats/archives/20160526/webrtc-stats.html#pcstats-dict* BUG=chromium:627816, chromium:636818 Review-Url: https://codereview.webrtc.org/2242043002 Cr-Commit-Position: refs/heads/master@{#13979}
2016-08-30 14:04:35 -07:00
namespace webrtc {
Turn off clang-format for WEBRTC_RTCSTATS_IMPL macros. Clang format wants to put all parameters to WEBRTC_RTCSTATS_IMPL on their own line, but we prefer to keep the header on the first line and put the variable arguments (the stats) on their own lines. Bug: None Change-Id: Ic53104b46fb3c91c134d524027a150ba10055ad5 Reviewed-on: https://chromium-review.googlesource.com/621409 Reviewed-by: Henrik Boström <hbos@webrtc.org> Commit-Queue: Steve Anton <steveanton@webrtc.org> Cr-Commit-Position: refs/heads/master@{#19505}
2017-08-18 09:40:25 -07:00
// clang-format off
RTCTransportStats[1] added, supporting all members. Address TODO in rtcstatscollector_unittest.cc before closing 653873. [1] https://w3c.github.io/webrtc-stats/#transportstats-dict* BUG=chromium:653873, chromium:633550, chromium:627816 Review-Url: https://codereview.webrtc.org/2408363002 Cr-Commit-Position: refs/heads/master@{#14740}
2016-10-24 04:00:05 -07:00
WEBRTC_RTCSTATS_IMPL(RTCCertificateStats, RTCStats, "certificate",
Revert "[Stats] Move metric names to Attribute, constructed via AttributeInit." This reverts commit 84c48ae7513bad9c9ca19271569cd0431e780c32. Reason for revert: Breaks downstream project Original change's description: > [Stats] Move metric names to Attribute, constructed via AttributeInit. > > As of this CL, Attribute no longer implements RTCStatsMemberInterface > and a member no longer owns knowing its own name. The attribute knows > the name because we pass it down at construction time. > > To achieve this, the WEBRTC_RTCSTATS_IMPL() macro is updated to take > AttributeInits instead of raw member pointers, i.e. (name, ptr) pairs. > > By constructing RTCStatsMember<T> without a name parameter, it does the > same thing as the absl::optional<T> constructor. So RTCStatsMember<T>'s > days are numbered! > > Bug: webrtc:15164 > Change-Id: I560c0134bae1c2d7218426a1576425ecc1b677a7 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334203 > Commit-Queue: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Evan Shrubsole <eshr@google.com> > Cr-Commit-Position: refs/heads/main@{#41540} Bug: webrtc:15164 Change-Id: I9f416838153b26d4560ae98c37fb18a803d0295d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334901 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41550}
2024-01-17 16:59:52 +00:00
&fingerprint,
&fingerprint_algorithm,
&base64_certificate,
&issuer_certificate_id)
Turn off clang-format for WEBRTC_RTCSTATS_IMPL macros. Clang format wants to put all parameters to WEBRTC_RTCSTATS_IMPL on their own line, but we prefer to keep the header on the first line and put the variable arguments (the stats) on their own lines. Bug: None Change-Id: Ic53104b46fb3c91c134d524027a150ba10055ad5 Reviewed-on: https://chromium-review.googlesource.com/621409 Reviewed-by: Henrik Boström <hbos@webrtc.org> Commit-Queue: Steve Anton <steveanton@webrtc.org> Cr-Commit-Position: refs/heads/master@{#19505}
2017-08-18 09:40:25 -07:00
// clang-format on
RTCTransportStats[1] added, supporting all members. Address TODO in rtcstatscollector_unittest.cc before closing 653873. [1] https://w3c.github.io/webrtc-stats/#transportstats-dict* BUG=chromium:653873, chromium:633550, chromium:627816 Review-Url: https://codereview.webrtc.org/2408363002 Cr-Commit-Position: refs/heads/master@{#14740}
2016-10-24 04:00:05 -07:00
stats: use Timestamp instead of uint64_t making it clear what unit is being used. BUG=webrtc:13756 Change-Id: I6354d35a8e02bb93a905ccf32cb0b294b4813e41 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/289460 Commit-Queue: Philipp Hancke <phancke@microsoft.com> Reviewed-by: Henrik Boström <hbos@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39008}
2023-01-04 15:17:42 +01:00
RTCCertificateStats::RTCCertificateStats(std::string id, Timestamp timestamp)
Revert "[Stats] Move metric names to Attribute, constructed via AttributeInit." This reverts commit 84c48ae7513bad9c9ca19271569cd0431e780c32. Reason for revert: Breaks downstream project Original change's description: > [Stats] Move metric names to Attribute, constructed via AttributeInit. > > As of this CL, Attribute no longer implements RTCStatsMemberInterface > and a member no longer owns knowing its own name. The attribute knows > the name because we pass it down at construction time. > > To achieve this, the WEBRTC_RTCSTATS_IMPL() macro is updated to take > AttributeInits instead of raw member pointers, i.e. (name, ptr) pairs. > > By constructing RTCStatsMember<T> without a name parameter, it does the > same thing as the absl::optional<T> constructor. So RTCStatsMember<T>'s > days are numbered! > > Bug: webrtc:15164 > Change-Id: I560c0134bae1c2d7218426a1576425ecc1b677a7 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334203 > Commit-Queue: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Evan Shrubsole <eshr@google.com> > Cr-Commit-Position: refs/heads/main@{#41540} Bug: webrtc:15164 Change-Id: I9f416838153b26d4560ae98c37fb18a803d0295d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334901 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41550}
2024-01-17 16:59:52 +00:00
: RTCStats(std::move(id), timestamp),
fingerprint("fingerprint"),
fingerprint_algorithm("fingerprintAlgorithm"),
base64_certificate("base64Certificate"),
issuer_certificate_id("issuerCertificateId") {}
RTCCertificateStats::RTCCertificateStats(const RTCCertificateStats& other) =
default;
RTCTransportStats[1] added, supporting all members. Address TODO in rtcstatscollector_unittest.cc before closing 653873. [1] https://w3c.github.io/webrtc-stats/#transportstats-dict* BUG=chromium:653873, chromium:633550, chromium:627816 Review-Url: https://codereview.webrtc.org/2408363002 Cr-Commit-Position: refs/heads/master@{#14740}
2016-10-24 04:00:05 -07:00
RTCCertificateStats::~RTCCertificateStats() {}
Turn off clang-format for WEBRTC_RTCSTATS_IMPL macros. Clang format wants to put all parameters to WEBRTC_RTCSTATS_IMPL on their own line, but we prefer to keep the header on the first line and put the variable arguments (the stats) on their own lines. Bug: None Change-Id: Ic53104b46fb3c91c134d524027a150ba10055ad5 Reviewed-on: https://chromium-review.googlesource.com/621409 Reviewed-by: Henrik Boström <hbos@webrtc.org> Commit-Queue: Steve Anton <steveanton@webrtc.org> Cr-Commit-Position: refs/heads/master@{#19505}
2017-08-18 09:40:25 -07:00
// clang-format off
RTCCodecStats[1] added. RTCStatsCollector supports "payloadType", "codec" and "clockRate". "channels", "parameters" and "implementation" need to be supported before closing crbug.com/659117. [1] https://w3c.github.io/webrtc-stats/#codec-dict* BUG=chromium:659117, chromium:627816, chromium:657854 NOTRY=True Review-Url: https://codereview.webrtc.org/2509803004 Cr-Commit-Position: refs/heads/master@{#15207}
2016-11-23 02:32:06 -08:00
WEBRTC_RTCSTATS_IMPL(RTCCodecStats, RTCStats, "codec",
Revert "[Stats] Move metric names to Attribute, constructed via AttributeInit." This reverts commit 84c48ae7513bad9c9ca19271569cd0431e780c32. Reason for revert: Breaks downstream project Original change's description: > [Stats] Move metric names to Attribute, constructed via AttributeInit. > > As of this CL, Attribute no longer implements RTCStatsMemberInterface > and a member no longer owns knowing its own name. The attribute knows > the name because we pass it down at construction time. > > To achieve this, the WEBRTC_RTCSTATS_IMPL() macro is updated to take > AttributeInits instead of raw member pointers, i.e. (name, ptr) pairs. > > By constructing RTCStatsMember<T> without a name parameter, it does the > same thing as the absl::optional<T> constructor. So RTCStatsMember<T>'s > days are numbered! > > Bug: webrtc:15164 > Change-Id: I560c0134bae1c2d7218426a1576425ecc1b677a7 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334203 > Commit-Queue: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Evan Shrubsole <eshr@google.com> > Cr-Commit-Position: refs/heads/main@{#41540} Bug: webrtc:15164 Change-Id: I9f416838153b26d4560ae98c37fb18a803d0295d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334901 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41550}
2024-01-17 16:59:52 +00:00
&transport_id,
&payload_type,
&mime_type,
&clock_rate,
&channels,
&sdp_fmtp_line)
Turn off clang-format for WEBRTC_RTCSTATS_IMPL macros. Clang format wants to put all parameters to WEBRTC_RTCSTATS_IMPL on their own line, but we prefer to keep the header on the first line and put the variable arguments (the stats) on their own lines. Bug: None Change-Id: Ic53104b46fb3c91c134d524027a150ba10055ad5 Reviewed-on: https://chromium-review.googlesource.com/621409 Reviewed-by: Henrik Boström <hbos@webrtc.org> Commit-Queue: Steve Anton <steveanton@webrtc.org> Cr-Commit-Position: refs/heads/master@{#19505}
2017-08-18 09:40:25 -07:00
// clang-format on
RTCCodecStats[1] added. RTCStatsCollector supports "payloadType", "codec" and "clockRate". "channels", "parameters" and "implementation" need to be supported before closing crbug.com/659117. [1] https://w3c.github.io/webrtc-stats/#codec-dict* BUG=chromium:659117, chromium:627816, chromium:657854 NOTRY=True Review-Url: https://codereview.webrtc.org/2509803004 Cr-Commit-Position: refs/heads/master@{#15207}
2016-11-23 02:32:06 -08:00
stats: use Timestamp instead of uint64_t making it clear what unit is being used. BUG=webrtc:13756 Change-Id: I6354d35a8e02bb93a905ccf32cb0b294b4813e41 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/289460 Commit-Queue: Philipp Hancke <phancke@microsoft.com> Reviewed-by: Henrik Boström <hbos@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39008}
2023-01-04 15:17:42 +01:00
RTCCodecStats::RTCCodecStats(std::string id, Timestamp timestamp)
Revert "[Stats] Move metric names to Attribute, constructed via AttributeInit." This reverts commit 84c48ae7513bad9c9ca19271569cd0431e780c32. Reason for revert: Breaks downstream project Original change's description: > [Stats] Move metric names to Attribute, constructed via AttributeInit. > > As of this CL, Attribute no longer implements RTCStatsMemberInterface > and a member no longer owns knowing its own name. The attribute knows > the name because we pass it down at construction time. > > To achieve this, the WEBRTC_RTCSTATS_IMPL() macro is updated to take > AttributeInits instead of raw member pointers, i.e. (name, ptr) pairs. > > By constructing RTCStatsMember<T> without a name parameter, it does the > same thing as the absl::optional<T> constructor. So RTCStatsMember<T>'s > days are numbered! > > Bug: webrtc:15164 > Change-Id: I560c0134bae1c2d7218426a1576425ecc1b677a7 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334203 > Commit-Queue: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Evan Shrubsole <eshr@google.com> > Cr-Commit-Position: refs/heads/main@{#41540} Bug: webrtc:15164 Change-Id: I9f416838153b26d4560ae98c37fb18a803d0295d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334901 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41550}
2024-01-17 16:59:52 +00:00
: RTCStats(std::move(id), timestamp),
transport_id("transportId"),
payload_type("payloadType"),
mime_type("mimeType"),
clock_rate("clockRate"),
channels("channels"),
sdp_fmtp_line("sdpFmtpLine") {}
RTCCodecStats::RTCCodecStats(const RTCCodecStats& other) = default;
RTCCodecStats[1] added. RTCStatsCollector supports "payloadType", "codec" and "clockRate". "channels", "parameters" and "implementation" need to be supported before closing crbug.com/659117. [1] https://w3c.github.io/webrtc-stats/#codec-dict* BUG=chromium:659117, chromium:627816, chromium:657854 NOTRY=True Review-Url: https://codereview.webrtc.org/2509803004 Cr-Commit-Position: refs/heads/master@{#15207}
2016-11-23 02:32:06 -08:00
RTCCodecStats::~RTCCodecStats() {}
Turn off clang-format for WEBRTC_RTCSTATS_IMPL macros. Clang format wants to put all parameters to WEBRTC_RTCSTATS_IMPL on their own line, but we prefer to keep the header on the first line and put the variable arguments (the stats) on their own lines. Bug: None Change-Id: Ic53104b46fb3c91c134d524027a150ba10055ad5 Reviewed-on: https://chromium-review.googlesource.com/621409 Reviewed-by: Henrik Boström <hbos@webrtc.org> Commit-Queue: Steve Anton <steveanton@webrtc.org> Cr-Commit-Position: refs/heads/master@{#19505}
2017-08-18 09:40:25 -07:00
// clang-format off
RTCTransportStats[1] added, supporting all members. Address TODO in rtcstatscollector_unittest.cc before closing 653873. [1] https://w3c.github.io/webrtc-stats/#transportstats-dict* BUG=chromium:653873, chromium:633550, chromium:627816 Review-Url: https://codereview.webrtc.org/2408363002 Cr-Commit-Position: refs/heads/master@{#14740}
2016-10-24 04:00:05 -07:00
WEBRTC_RTCSTATS_IMPL(RTCDataChannelStats, RTCStats, "data-channel",
Revert "[Stats] Move metric names to Attribute, constructed via AttributeInit." This reverts commit 84c48ae7513bad9c9ca19271569cd0431e780c32. Reason for revert: Breaks downstream project Original change's description: > [Stats] Move metric names to Attribute, constructed via AttributeInit. > > As of this CL, Attribute no longer implements RTCStatsMemberInterface > and a member no longer owns knowing its own name. The attribute knows > the name because we pass it down at construction time. > > To achieve this, the WEBRTC_RTCSTATS_IMPL() macro is updated to take > AttributeInits instead of raw member pointers, i.e. (name, ptr) pairs. > > By constructing RTCStatsMember<T> without a name parameter, it does the > same thing as the absl::optional<T> constructor. So RTCStatsMember<T>'s > days are numbered! > > Bug: webrtc:15164 > Change-Id: I560c0134bae1c2d7218426a1576425ecc1b677a7 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334203 > Commit-Queue: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Evan Shrubsole <eshr@google.com> > Cr-Commit-Position: refs/heads/main@{#41540} Bug: webrtc:15164 Change-Id: I9f416838153b26d4560ae98c37fb18a803d0295d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334901 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41550}
2024-01-17 16:59:52 +00:00
&label,
&protocol,
&data_channel_identifier,
&state,
&messages_sent,
&bytes_sent,
&messages_received,
&bytes_received)
Turn off clang-format for WEBRTC_RTCSTATS_IMPL macros. Clang format wants to put all parameters to WEBRTC_RTCSTATS_IMPL on their own line, but we prefer to keep the header on the first line and put the variable arguments (the stats) on their own lines. Bug: None Change-Id: Ic53104b46fb3c91c134d524027a150ba10055ad5 Reviewed-on: https://chromium-review.googlesource.com/621409 Reviewed-by: Henrik Boström <hbos@webrtc.org> Commit-Queue: Steve Anton <steveanton@webrtc.org> Cr-Commit-Position: refs/heads/master@{#19505}
2017-08-18 09:40:25 -07:00
// clang-format on
RTCTransportStats[1] added, supporting all members. Address TODO in rtcstatscollector_unittest.cc before closing 653873. [1] https://w3c.github.io/webrtc-stats/#transportstats-dict* BUG=chromium:653873, chromium:633550, chromium:627816 Review-Url: https://codereview.webrtc.org/2408363002 Cr-Commit-Position: refs/heads/master@{#14740}
2016-10-24 04:00:05 -07:00
stats: use Timestamp instead of uint64_t making it clear what unit is being used. BUG=webrtc:13756 Change-Id: I6354d35a8e02bb93a905ccf32cb0b294b4813e41 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/289460 Commit-Queue: Philipp Hancke <phancke@microsoft.com> Reviewed-by: Henrik Boström <hbos@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39008}
2023-01-04 15:17:42 +01:00
RTCDataChannelStats::RTCDataChannelStats(std::string id, Timestamp timestamp)
Revert "[Stats] Move metric names to Attribute, constructed via AttributeInit." This reverts commit 84c48ae7513bad9c9ca19271569cd0431e780c32. Reason for revert: Breaks downstream project Original change's description: > [Stats] Move metric names to Attribute, constructed via AttributeInit. > > As of this CL, Attribute no longer implements RTCStatsMemberInterface > and a member no longer owns knowing its own name. The attribute knows > the name because we pass it down at construction time. > > To achieve this, the WEBRTC_RTCSTATS_IMPL() macro is updated to take > AttributeInits instead of raw member pointers, i.e. (name, ptr) pairs. > > By constructing RTCStatsMember<T> without a name parameter, it does the > same thing as the absl::optional<T> constructor. So RTCStatsMember<T>'s > days are numbered! > > Bug: webrtc:15164 > Change-Id: I560c0134bae1c2d7218426a1576425ecc1b677a7 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334203 > Commit-Queue: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Evan Shrubsole <eshr@google.com> > Cr-Commit-Position: refs/heads/main@{#41540} Bug: webrtc:15164 Change-Id: I9f416838153b26d4560ae98c37fb18a803d0295d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334901 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41550}
2024-01-17 16:59:52 +00:00
: RTCStats(std::move(id), timestamp),
label("label"),
protocol("protocol"),
data_channel_identifier("dataChannelIdentifier"),
state("state"),
messages_sent("messagesSent"),
bytes_sent("bytesSent"),
messages_received("messagesReceived"),
bytes_received("bytesReceived") {}
RTCDataChannelStats::RTCDataChannelStats(const RTCDataChannelStats& other) =
default;
RTCTransportStats[1] added, supporting all members. Address TODO in rtcstatscollector_unittest.cc before closing 653873. [1] https://w3c.github.io/webrtc-stats/#transportstats-dict* BUG=chromium:653873, chromium:633550, chromium:627816 Review-Url: https://codereview.webrtc.org/2408363002 Cr-Commit-Position: refs/heads/master@{#14740}
2016-10-24 04:00:05 -07:00
RTCDataChannelStats::~RTCDataChannelStats() {}
Turn off clang-format for WEBRTC_RTCSTATS_IMPL macros. Clang format wants to put all parameters to WEBRTC_RTCSTATS_IMPL on their own line, but we prefer to keep the header on the first line and put the variable arguments (the stats) on their own lines. Bug: None Change-Id: Ic53104b46fb3c91c134d524027a150ba10055ad5 Reviewed-on: https://chromium-review.googlesource.com/621409 Reviewed-by: Henrik Boström <hbos@webrtc.org> Commit-Queue: Steve Anton <steveanton@webrtc.org> Cr-Commit-Position: refs/heads/master@{#19505}
2017-08-18 09:40:25 -07:00
// clang-format off
RTCIceCandidatePairStats[1] added. Note: In this initial CL most stats members are missing. This needs to be addressed before closing the RTCIceCandidatePairStats bug (crbug.com/633550). [1] https://w3c.github.io/webrtc-stats/#candidatepair-dict* BUG=chromium:633550, chromium:627816 Review-Url: https://codereview.webrtc.org/2390693003 Cr-Commit-Position: refs/heads/master@{#14604}
2016-10-11 14:54:49 -07:00
WEBRTC_RTCSTATS_IMPL(RTCIceCandidatePairStats, RTCStats, "candidate-pair",
Revert "[Stats] Move metric names to Attribute, constructed via AttributeInit." This reverts commit 84c48ae7513bad9c9ca19271569cd0431e780c32. Reason for revert: Breaks downstream project Original change's description: > [Stats] Move metric names to Attribute, constructed via AttributeInit. > > As of this CL, Attribute no longer implements RTCStatsMemberInterface > and a member no longer owns knowing its own name. The attribute knows > the name because we pass it down at construction time. > > To achieve this, the WEBRTC_RTCSTATS_IMPL() macro is updated to take > AttributeInits instead of raw member pointers, i.e. (name, ptr) pairs. > > By constructing RTCStatsMember<T> without a name parameter, it does the > same thing as the absl::optional<T> constructor. So RTCStatsMember<T>'s > days are numbered! > > Bug: webrtc:15164 > Change-Id: I560c0134bae1c2d7218426a1576425ecc1b677a7 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334203 > Commit-Queue: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Evan Shrubsole <eshr@google.com> > Cr-Commit-Position: refs/heads/main@{#41540} Bug: webrtc:15164 Change-Id: I9f416838153b26d4560ae98c37fb18a803d0295d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334901 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41550}
2024-01-17 16:59:52 +00:00
&transport_id,
&local_candidate_id,
&remote_candidate_id,
&state,
&priority,
&nominated,
&writable,
&packets_sent,
&packets_received,
&bytes_sent,
&bytes_received,
&total_round_trip_time,
&current_round_trip_time,
&available_outgoing_bitrate,
&available_incoming_bitrate,
&requests_received,
&requests_sent,
&responses_received,
&responses_sent,
&consent_requests_sent,
&packets_discarded_on_send,
&bytes_discarded_on_send,
&last_packet_received_timestamp,
&last_packet_sent_timestamp)
Turn off clang-format for WEBRTC_RTCSTATS_IMPL macros. Clang format wants to put all parameters to WEBRTC_RTCSTATS_IMPL on their own line, but we prefer to keep the header on the first line and put the variable arguments (the stats) on their own lines. Bug: None Change-Id: Ic53104b46fb3c91c134d524027a150ba10055ad5 Reviewed-on: https://chromium-review.googlesource.com/621409 Reviewed-by: Henrik Boström <hbos@webrtc.org> Commit-Queue: Steve Anton <steveanton@webrtc.org> Cr-Commit-Position: refs/heads/master@{#19505}
2017-08-18 09:40:25 -07:00
// clang-format on
RTCIceCandidatePairStats[1] added. Note: In this initial CL most stats members are missing. This needs to be addressed before closing the RTCIceCandidatePairStats bug (crbug.com/633550). [1] https://w3c.github.io/webrtc-stats/#candidatepair-dict* BUG=chromium:633550, chromium:627816 Review-Url: https://codereview.webrtc.org/2390693003 Cr-Commit-Position: refs/heads/master@{#14604}
2016-10-11 14:54:49 -07:00
api: use std::string in stats constructor instead of const reference or rvalues. This follows the style guide: https://google.github.io/styleguide/cppguide.html#Rvalue_references BUG=webrtc:14807 Change-Id: I936b99146520815ae8105806409d46565fa83546 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/289985 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Henrik Boström <hbos@webrtc.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Cr-Commit-Position: refs/heads/main@{#38996}
2023-01-02 13:20:45 +01:00
RTCIceCandidatePairStats::RTCIceCandidatePairStats(std::string id,
stats: use Timestamp instead of uint64_t making it clear what unit is being used. BUG=webrtc:13756 Change-Id: I6354d35a8e02bb93a905ccf32cb0b294b4813e41 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/289460 Commit-Queue: Philipp Hancke <phancke@microsoft.com> Reviewed-by: Henrik Boström <hbos@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39008}
2023-01-04 15:17:42 +01:00
Timestamp timestamp)
Revert "[Stats] Move metric names to Attribute, constructed via AttributeInit." This reverts commit 84c48ae7513bad9c9ca19271569cd0431e780c32. Reason for revert: Breaks downstream project Original change's description: > [Stats] Move metric names to Attribute, constructed via AttributeInit. > > As of this CL, Attribute no longer implements RTCStatsMemberInterface > and a member no longer owns knowing its own name. The attribute knows > the name because we pass it down at construction time. > > To achieve this, the WEBRTC_RTCSTATS_IMPL() macro is updated to take > AttributeInits instead of raw member pointers, i.e. (name, ptr) pairs. > > By constructing RTCStatsMember<T> without a name parameter, it does the > same thing as the absl::optional<T> constructor. So RTCStatsMember<T>'s > days are numbered! > > Bug: webrtc:15164 > Change-Id: I560c0134bae1c2d7218426a1576425ecc1b677a7 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334203 > Commit-Queue: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Evan Shrubsole <eshr@google.com> > Cr-Commit-Position: refs/heads/main@{#41540} Bug: webrtc:15164 Change-Id: I9f416838153b26d4560ae98c37fb18a803d0295d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334901 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41550}
2024-01-17 16:59:52 +00:00
: RTCStats(std::move(id), timestamp),
transport_id("transportId"),
local_candidate_id("localCandidateId"),
remote_candidate_id("remoteCandidateId"),
state("state"),
priority("priority"),
nominated("nominated"),
writable("writable"),
packets_sent("packetsSent"),
packets_received("packetsReceived"),
bytes_sent("bytesSent"),
bytes_received("bytesReceived"),
total_round_trip_time("totalRoundTripTime"),
current_round_trip_time("currentRoundTripTime"),
available_outgoing_bitrate("availableOutgoingBitrate"),
available_incoming_bitrate("availableIncomingBitrate"),
requests_received("requestsReceived"),
requests_sent("requestsSent"),
responses_received("responsesReceived"),
responses_sent("responsesSent"),
consent_requests_sent("consentRequestsSent"),
packets_discarded_on_send("packetsDiscardedOnSend"),
bytes_discarded_on_send("bytesDiscardedOnSend"),
last_packet_received_timestamp("lastPacketReceivedTimestamp"),
last_packet_sent_timestamp("lastPacketSentTimestamp") {}
RTCIceCandidatePairStats::RTCIceCandidatePairStats(
const RTCIceCandidatePairStats& other) = default;
RTCIceCandidatePairStats[1] added. Note: In this initial CL most stats members are missing. This needs to be addressed before closing the RTCIceCandidatePairStats bug (crbug.com/633550). [1] https://w3c.github.io/webrtc-stats/#candidatepair-dict* BUG=chromium:633550, chromium:627816 Review-Url: https://codereview.webrtc.org/2390693003 Cr-Commit-Position: refs/heads/master@{#14604}
2016-10-11 14:54:49 -07:00
RTCIceCandidatePairStats::~RTCIceCandidatePairStats() {}
Turn off clang-format for WEBRTC_RTCSTATS_IMPL macros. Clang format wants to put all parameters to WEBRTC_RTCSTATS_IMPL on their own line, but we prefer to keep the header on the first line and put the variable arguments (the stats) on their own lines. Bug: None Change-Id: Ic53104b46fb3c91c134d524027a150ba10055ad5 Reviewed-on: https://chromium-review.googlesource.com/621409 Reviewed-by: Henrik Boström <hbos@webrtc.org> Commit-Queue: Steve Anton <steveanton@webrtc.org> Cr-Commit-Position: refs/heads/master@{#19505}
2017-08-18 09:40:25 -07:00
// clang-format off
PeerConnectionInterface::GetStats() with selector argument added. This exposes the stats selection algorithm[1] on the PeerConnection. Per-spec, there are four flavors of getStats(): 1. RTCPeerConnection.getStats(). 2. RTCPeerConnection.getStats(MediaStreamTrack selector). 3. RTCRtpSender.getStats(). 4. RTCRtpReceiver.getStats(). 1) is the parameterless getStats() which is already shipped. 2) is the same as 3) and 4) except the track is used to look up the corresponding sender/receiver to use as the selector. 3) and 4) perform stats collection with a filter, which is implemented in RTCStatsCollector.GetStatsReport(selector). For technical reasons, it is easier to place GetStats() on the PeerConnection where the RTCStatsCollector lives than to place it on the sender/receiver. Passing the selector as an argument or as a "this" makes little difference other than style. Wiring Chrome up such that the JavaScript APIs is like the spec is trivial after GetStats() is added to PeerConnectionInterface. This CL also adds comments documenting our intent to deprecate and remove the legacy GetStats() APIs some time in the future. [1] https://w3c.github.io/webrtc-pc/#dfn-stats-selection-algorithm Bug: chromium:680172 Change-Id: I09316ba6f20b25d4f9c11785d0a1a1262d6062a1 Reviewed-on: https://webrtc-review.googlesource.com/62900 Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Commit-Queue: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22602}
2018-03-20 13:24:20 +01:00
WEBRTC_RTCSTATS_IMPL(RTCIceCandidateStats, RTCStats, "abstract-ice-candidate",
Revert "[Stats] Move metric names to Attribute, constructed via AttributeInit." This reverts commit 84c48ae7513bad9c9ca19271569cd0431e780c32. Reason for revert: Breaks downstream project Original change's description: > [Stats] Move metric names to Attribute, constructed via AttributeInit. > > As of this CL, Attribute no longer implements RTCStatsMemberInterface > and a member no longer owns knowing its own name. The attribute knows > the name because we pass it down at construction time. > > To achieve this, the WEBRTC_RTCSTATS_IMPL() macro is updated to take > AttributeInits instead of raw member pointers, i.e. (name, ptr) pairs. > > By constructing RTCStatsMember<T> without a name parameter, it does the > same thing as the absl::optional<T> constructor. So RTCStatsMember<T>'s > days are numbered! > > Bug: webrtc:15164 > Change-Id: I560c0134bae1c2d7218426a1576425ecc1b677a7 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334203 > Commit-Queue: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Evan Shrubsole <eshr@google.com> > Cr-Commit-Position: refs/heads/main@{#41540} Bug: webrtc:15164 Change-Id: I9f416838153b26d4560ae98c37fb18a803d0295d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334901 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41550}
2024-01-17 16:59:52 +00:00
&transport_id,
&is_remote,
&network_type,
&ip,
&address,
&port,
&protocol,
&relay_protocol,
&candidate_type,
&priority,
&url,
&foundation,
&related_address,
&related_port,
&username_fragment,
&tcp_type,
&vpn,
&network_adapter_type)
Turn off clang-format for WEBRTC_RTCSTATS_IMPL macros. Clang format wants to put all parameters to WEBRTC_RTCSTATS_IMPL on their own line, but we prefer to keep the header on the first line and put the variable arguments (the stats) on their own lines. Bug: None Change-Id: Ic53104b46fb3c91c134d524027a150ba10055ad5 Reviewed-on: https://chromium-review.googlesource.com/621409 Reviewed-by: Henrik Boström <hbos@webrtc.org> Commit-Queue: Steve Anton <steveanton@webrtc.org> Cr-Commit-Position: refs/heads/master@{#19505}
2017-08-18 09:40:25 -07:00
// clang-format on
RTCIceCandidateStats[1] added. The RTCStatsCollector collects candidates from candidate pairs. Note that there may be other candidates that are not paired with anything, stats for these should also be produced before closing crbug.com/632723. [1] https://w3c.github.io/webrtc-stats/#icecandidate-dict* BUG=chromium:627816, chromium:632723 Review-Url: https://codereview.webrtc.org/2384143002 Cr-Commit-Position: refs/heads/master@{#14565}
2016-10-07 02:18:47 -07:00
api: use std::string in stats constructor instead of const reference or rvalues. This follows the style guide: https://google.github.io/styleguide/cppguide.html#Rvalue_references BUG=webrtc:14807 Change-Id: I936b99146520815ae8105806409d46565fa83546 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/289985 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Henrik Boström <hbos@webrtc.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Cr-Commit-Position: refs/heads/main@{#38996}
2023-01-02 13:20:45 +01:00
RTCIceCandidateStats::RTCIceCandidateStats(std::string id,
stats: use Timestamp instead of uint64_t making it clear what unit is being used. BUG=webrtc:13756 Change-Id: I6354d35a8e02bb93a905ccf32cb0b294b4813e41 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/289460 Commit-Queue: Philipp Hancke <phancke@microsoft.com> Reviewed-by: Henrik Boström <hbos@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39008}
2023-01-04 15:17:42 +01:00
Timestamp timestamp,
Add network_type to local RTCIceCandidateStats Details: * Add RTCNetworkType enum * Add network_type to local ice candidate stats Bug: webrtc:8435 Change-Id: Idb872849c09ad49c8f759d02afdc825e397afa07 Reviewed-on: https://webrtc-review.googlesource.com/14680 Commit-Queue: Gary Liu <qinghualiu@google.com> Reviewed-by: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20822}
2017-11-21 10:49:36 -08:00
bool is_remote)
Revert "[Stats] Move metric names to Attribute, constructed via AttributeInit." This reverts commit 84c48ae7513bad9c9ca19271569cd0431e780c32. Reason for revert: Breaks downstream project Original change's description: > [Stats] Move metric names to Attribute, constructed via AttributeInit. > > As of this CL, Attribute no longer implements RTCStatsMemberInterface > and a member no longer owns knowing its own name. The attribute knows > the name because we pass it down at construction time. > > To achieve this, the WEBRTC_RTCSTATS_IMPL() macro is updated to take > AttributeInits instead of raw member pointers, i.e. (name, ptr) pairs. > > By constructing RTCStatsMember<T> without a name parameter, it does the > same thing as the absl::optional<T> constructor. So RTCStatsMember<T>'s > days are numbered! > > Bug: webrtc:15164 > Change-Id: I560c0134bae1c2d7218426a1576425ecc1b677a7 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334203 > Commit-Queue: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Evan Shrubsole <eshr@google.com> > Cr-Commit-Position: refs/heads/main@{#41540} Bug: webrtc:15164 Change-Id: I9f416838153b26d4560ae98c37fb18a803d0295d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334901 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41550}
2024-01-17 16:59:52 +00:00
: RTCStats(std::move(id), timestamp),
transport_id("transportId"),
is_remote("isRemote", is_remote),
network_type("networkType"),
ip("ip"),
address("address"),
port("port"),
protocol("protocol"),
relay_protocol("relayProtocol"),
candidate_type("candidateType"),
priority("priority"),
url("url"),
foundation("foundation"),
related_address("relatedAddress"),
related_port("relatedPort"),
username_fragment("usernameFragment"),
tcp_type("tcpType"),
vpn("vpn"),
network_adapter_type("networkAdapterType") {}
RTCIceCandidateStats::RTCIceCandidateStats(const RTCIceCandidateStats& other) =
default;
RTCIceCandidateStats[1] added. The RTCStatsCollector collects candidates from candidate pairs. Note that there may be other candidates that are not paired with anything, stats for these should also be produced before closing crbug.com/632723. [1] https://w3c.github.io/webrtc-stats/#icecandidate-dict* BUG=chromium:627816, chromium:632723 Review-Url: https://codereview.webrtc.org/2384143002 Cr-Commit-Position: refs/heads/master@{#14565}
2016-10-07 02:18:47 -07:00
RTCIceCandidateStats::~RTCIceCandidateStats() {}
const char RTCLocalIceCandidateStats::kType[] = "local-candidate";
stats: use Timestamp instead of uint64_t making it clear what unit is being used. BUG=webrtc:13756 Change-Id: I6354d35a8e02bb93a905ccf32cb0b294b4813e41 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/289460 Commit-Queue: Philipp Hancke <phancke@microsoft.com> Reviewed-by: Henrik Boström <hbos@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39008}
2023-01-04 15:17:42 +01:00
RTCLocalIceCandidateStats::RTCLocalIceCandidateStats(std::string id,
Timestamp timestamp)
: RTCIceCandidateStats(std::move(id), timestamp, false) {}
RTCIceCandidateStats[1] added. The RTCStatsCollector collects candidates from candidate pairs. Note that there may be other candidates that are not paired with anything, stats for these should also be produced before closing crbug.com/632723. [1] https://w3c.github.io/webrtc-stats/#icecandidate-dict* BUG=chromium:627816, chromium:632723 Review-Url: https://codereview.webrtc.org/2384143002 Cr-Commit-Position: refs/heads/master@{#14565}
2016-10-07 02:18:47 -07:00
PeerConnectionInterface::GetStats() with selector argument added. This exposes the stats selection algorithm[1] on the PeerConnection. Per-spec, there are four flavors of getStats(): 1. RTCPeerConnection.getStats(). 2. RTCPeerConnection.getStats(MediaStreamTrack selector). 3. RTCRtpSender.getStats(). 4. RTCRtpReceiver.getStats(). 1) is the parameterless getStats() which is already shipped. 2) is the same as 3) and 4) except the track is used to look up the corresponding sender/receiver to use as the selector. 3) and 4) perform stats collection with a filter, which is implemented in RTCStatsCollector.GetStatsReport(selector). For technical reasons, it is easier to place GetStats() on the PeerConnection where the RTCStatsCollector lives than to place it on the sender/receiver. Passing the selector as an argument or as a "this" makes little difference other than style. Wiring Chrome up such that the JavaScript APIs is like the spec is trivial after GetStats() is added to PeerConnectionInterface. This CL also adds comments documenting our intent to deprecate and remove the legacy GetStats() APIs some time in the future. [1] https://w3c.github.io/webrtc-pc/#dfn-stats-selection-algorithm Bug: chromium:680172 Change-Id: I09316ba6f20b25d4f9c11785d0a1a1262d6062a1 Reviewed-on: https://webrtc-review.googlesource.com/62900 Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Commit-Queue: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22602}
2018-03-20 13:24:20 +01:00
std::unique_ptr<RTCStats> RTCLocalIceCandidateStats::copy() const {
stats: replace new with std::make_unique apart from the certificate stats which need to update the reference to the previous certificate stats in the chain. BUG=None Change-Id: I27f58084b849fd9afe236e5b57139bedb8eb1811 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/274175 Commit-Queue: Philipp Hancke <phancke@microsoft.com> Reviewed-by: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38026}
2022-09-06 11:55:31 +02:00
return std::make_unique<RTCLocalIceCandidateStats>(*this);
PeerConnectionInterface::GetStats() with selector argument added. This exposes the stats selection algorithm[1] on the PeerConnection. Per-spec, there are four flavors of getStats(): 1. RTCPeerConnection.getStats(). 2. RTCPeerConnection.getStats(MediaStreamTrack selector). 3. RTCRtpSender.getStats(). 4. RTCRtpReceiver.getStats(). 1) is the parameterless getStats() which is already shipped. 2) is the same as 3) and 4) except the track is used to look up the corresponding sender/receiver to use as the selector. 3) and 4) perform stats collection with a filter, which is implemented in RTCStatsCollector.GetStatsReport(selector). For technical reasons, it is easier to place GetStats() on the PeerConnection where the RTCStatsCollector lives than to place it on the sender/receiver. Passing the selector as an argument or as a "this" makes little difference other than style. Wiring Chrome up such that the JavaScript APIs is like the spec is trivial after GetStats() is added to PeerConnectionInterface. This CL also adds comments documenting our intent to deprecate and remove the legacy GetStats() APIs some time in the future. [1] https://w3c.github.io/webrtc-pc/#dfn-stats-selection-algorithm Bug: chromium:680172 Change-Id: I09316ba6f20b25d4f9c11785d0a1a1262d6062a1 Reviewed-on: https://webrtc-review.googlesource.com/62900 Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Commit-Queue: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22602}
2018-03-20 13:24:20 +01:00
}
RTCIceCandidateStats[1] added. The RTCStatsCollector collects candidates from candidate pairs. Note that there may be other candidates that are not paired with anything, stats for these should also be produced before closing crbug.com/632723. [1] https://w3c.github.io/webrtc-stats/#icecandidate-dict* BUG=chromium:627816, chromium:632723 Review-Url: https://codereview.webrtc.org/2384143002 Cr-Commit-Position: refs/heads/master@{#14565}
2016-10-07 02:18:47 -07:00
const char* RTCLocalIceCandidateStats::type() const {
return kType;
}
const char RTCRemoteIceCandidateStats::kType[] = "remote-candidate";
stats: use Timestamp instead of uint64_t making it clear what unit is being used. BUG=webrtc:13756 Change-Id: I6354d35a8e02bb93a905ccf32cb0b294b4813e41 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/289460 Commit-Queue: Philipp Hancke <phancke@microsoft.com> Reviewed-by: Henrik Boström <hbos@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39008}
2023-01-04 15:17:42 +01:00
RTCRemoteIceCandidateStats::RTCRemoteIceCandidateStats(std::string id,
Timestamp timestamp)
: RTCIceCandidateStats(std::move(id), timestamp, true) {}
RTCIceCandidateStats[1] added. The RTCStatsCollector collects candidates from candidate pairs. Note that there may be other candidates that are not paired with anything, stats for these should also be produced before closing crbug.com/632723. [1] https://w3c.github.io/webrtc-stats/#icecandidate-dict* BUG=chromium:627816, chromium:632723 Review-Url: https://codereview.webrtc.org/2384143002 Cr-Commit-Position: refs/heads/master@{#14565}
2016-10-07 02:18:47 -07:00
PeerConnectionInterface::GetStats() with selector argument added. This exposes the stats selection algorithm[1] on the PeerConnection. Per-spec, there are four flavors of getStats(): 1. RTCPeerConnection.getStats(). 2. RTCPeerConnection.getStats(MediaStreamTrack selector). 3. RTCRtpSender.getStats(). 4. RTCRtpReceiver.getStats(). 1) is the parameterless getStats() which is already shipped. 2) is the same as 3) and 4) except the track is used to look up the corresponding sender/receiver to use as the selector. 3) and 4) perform stats collection with a filter, which is implemented in RTCStatsCollector.GetStatsReport(selector). For technical reasons, it is easier to place GetStats() on the PeerConnection where the RTCStatsCollector lives than to place it on the sender/receiver. Passing the selector as an argument or as a "this" makes little difference other than style. Wiring Chrome up such that the JavaScript APIs is like the spec is trivial after GetStats() is added to PeerConnectionInterface. This CL also adds comments documenting our intent to deprecate and remove the legacy GetStats() APIs some time in the future. [1] https://w3c.github.io/webrtc-pc/#dfn-stats-selection-algorithm Bug: chromium:680172 Change-Id: I09316ba6f20b25d4f9c11785d0a1a1262d6062a1 Reviewed-on: https://webrtc-review.googlesource.com/62900 Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Commit-Queue: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22602}
2018-03-20 13:24:20 +01:00
std::unique_ptr<RTCStats> RTCRemoteIceCandidateStats::copy() const {
stats: replace new with std::make_unique apart from the certificate stats which need to update the reference to the previous certificate stats in the chain. BUG=None Change-Id: I27f58084b849fd9afe236e5b57139bedb8eb1811 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/274175 Commit-Queue: Philipp Hancke <phancke@microsoft.com> Reviewed-by: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38026}
2022-09-06 11:55:31 +02:00
return std::make_unique<RTCRemoteIceCandidateStats>(*this);
PeerConnectionInterface::GetStats() with selector argument added. This exposes the stats selection algorithm[1] on the PeerConnection. Per-spec, there are four flavors of getStats(): 1. RTCPeerConnection.getStats(). 2. RTCPeerConnection.getStats(MediaStreamTrack selector). 3. RTCRtpSender.getStats(). 4. RTCRtpReceiver.getStats(). 1) is the parameterless getStats() which is already shipped. 2) is the same as 3) and 4) except the track is used to look up the corresponding sender/receiver to use as the selector. 3) and 4) perform stats collection with a filter, which is implemented in RTCStatsCollector.GetStatsReport(selector). For technical reasons, it is easier to place GetStats() on the PeerConnection where the RTCStatsCollector lives than to place it on the sender/receiver. Passing the selector as an argument or as a "this" makes little difference other than style. Wiring Chrome up such that the JavaScript APIs is like the spec is trivial after GetStats() is added to PeerConnectionInterface. This CL also adds comments documenting our intent to deprecate and remove the legacy GetStats() APIs some time in the future. [1] https://w3c.github.io/webrtc-pc/#dfn-stats-selection-algorithm Bug: chromium:680172 Change-Id: I09316ba6f20b25d4f9c11785d0a1a1262d6062a1 Reviewed-on: https://webrtc-review.googlesource.com/62900 Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Commit-Queue: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22602}
2018-03-20 13:24:20 +01:00
}
RTCIceCandidateStats[1] added. The RTCStatsCollector collects candidates from candidate pairs. Note that there may be other candidates that are not paired with anything, stats for these should also be produced before closing crbug.com/632723. [1] https://w3c.github.io/webrtc-stats/#icecandidate-dict* BUG=chromium:627816, chromium:632723 Review-Url: https://codereview.webrtc.org/2384143002 Cr-Commit-Position: refs/heads/master@{#14565}
2016-10-07 02:18:47 -07:00
const char* RTCRemoteIceCandidateStats::type() const {
return kType;
}
Turn off clang-format for WEBRTC_RTCSTATS_IMPL macros. Clang format wants to put all parameters to WEBRTC_RTCSTATS_IMPL on their own line, but we prefer to keep the header on the first line and put the variable arguments (the stats) on their own lines. Bug: None Change-Id: Ic53104b46fb3c91c134d524027a150ba10055ad5 Reviewed-on: https://chromium-review.googlesource.com/621409 Reviewed-by: Henrik Boström <hbos@webrtc.org> Commit-Queue: Steve Anton <steveanton@webrtc.org> Cr-Commit-Position: refs/heads/master@{#19505}
2017-08-18 09:40:25 -07:00
// clang-format off
RTCTransportStats[1] added, supporting all members. Address TODO in rtcstatscollector_unittest.cc before closing 653873. [1] https://w3c.github.io/webrtc-stats/#transportstats-dict* BUG=chromium:653873, chromium:633550, chromium:627816 Review-Url: https://codereview.webrtc.org/2408363002 Cr-Commit-Position: refs/heads/master@{#14740}
2016-10-24 04:00:05 -07:00
WEBRTC_RTCSTATS_IMPL(RTCPeerConnectionStats, RTCStats, "peer-connection",
Revert "[Stats] Move metric names to Attribute, constructed via AttributeInit." This reverts commit 84c48ae7513bad9c9ca19271569cd0431e780c32. Reason for revert: Breaks downstream project Original change's description: > [Stats] Move metric names to Attribute, constructed via AttributeInit. > > As of this CL, Attribute no longer implements RTCStatsMemberInterface > and a member no longer owns knowing its own name. The attribute knows > the name because we pass it down at construction time. > > To achieve this, the WEBRTC_RTCSTATS_IMPL() macro is updated to take > AttributeInits instead of raw member pointers, i.e. (name, ptr) pairs. > > By constructing RTCStatsMember<T> without a name parameter, it does the > same thing as the absl::optional<T> constructor. So RTCStatsMember<T>'s > days are numbered! > > Bug: webrtc:15164 > Change-Id: I560c0134bae1c2d7218426a1576425ecc1b677a7 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334203 > Commit-Queue: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Evan Shrubsole <eshr@google.com> > Cr-Commit-Position: refs/heads/main@{#41540} Bug: webrtc:15164 Change-Id: I9f416838153b26d4560ae98c37fb18a803d0295d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334901 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41550}
2024-01-17 16:59:52 +00:00
&data_channels_opened,
&data_channels_closed)
Turn off clang-format for WEBRTC_RTCSTATS_IMPL macros. Clang format wants to put all parameters to WEBRTC_RTCSTATS_IMPL on their own line, but we prefer to keep the header on the first line and put the variable arguments (the stats) on their own lines. Bug: None Change-Id: Ic53104b46fb3c91c134d524027a150ba10055ad5 Reviewed-on: https://chromium-review.googlesource.com/621409 Reviewed-by: Henrik Boström <hbos@webrtc.org> Commit-Queue: Steve Anton <steveanton@webrtc.org> Cr-Commit-Position: refs/heads/master@{#19505}
2017-08-18 09:40:25 -07:00
// clang-format on
RTCCertificateStats[1] added. [1] https://w3c.github.io/webrtc-stats/#certificatestats-dict* BUG=chromium:627816, chromium:629436 NOTRY=True Review-Url: https://codereview.webrtc.org/2243123002 Cr-Commit-Position: refs/heads/master@{#14484}
2016-10-03 14:16:56 -07:00
api: use std::string in stats constructor instead of const reference or rvalues. This follows the style guide: https://google.github.io/styleguide/cppguide.html#Rvalue_references BUG=webrtc:14807 Change-Id: I936b99146520815ae8105806409d46565fa83546 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/289985 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Henrik Boström <hbos@webrtc.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Cr-Commit-Position: refs/heads/main@{#38996}
2023-01-02 13:20:45 +01:00
RTCPeerConnectionStats::RTCPeerConnectionStats(std::string id,
stats: use Timestamp instead of uint64_t making it clear what unit is being used. BUG=webrtc:13756 Change-Id: I6354d35a8e02bb93a905ccf32cb0b294b4813e41 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/289460 Commit-Queue: Philipp Hancke <phancke@microsoft.com> Reviewed-by: Henrik Boström <hbos@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39008}
2023-01-04 15:17:42 +01:00
Timestamp timestamp)
Revert "[Stats] Move metric names to Attribute, constructed via AttributeInit." This reverts commit 84c48ae7513bad9c9ca19271569cd0431e780c32. Reason for revert: Breaks downstream project Original change's description: > [Stats] Move metric names to Attribute, constructed via AttributeInit. > > As of this CL, Attribute no longer implements RTCStatsMemberInterface > and a member no longer owns knowing its own name. The attribute knows > the name because we pass it down at construction time. > > To achieve this, the WEBRTC_RTCSTATS_IMPL() macro is updated to take > AttributeInits instead of raw member pointers, i.e. (name, ptr) pairs. > > By constructing RTCStatsMember<T> without a name parameter, it does the > same thing as the absl::optional<T> constructor. So RTCStatsMember<T>'s > days are numbered! > > Bug: webrtc:15164 > Change-Id: I560c0134bae1c2d7218426a1576425ecc1b677a7 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334203 > Commit-Queue: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Evan Shrubsole <eshr@google.com> > Cr-Commit-Position: refs/heads/main@{#41540} Bug: webrtc:15164 Change-Id: I9f416838153b26d4560ae98c37fb18a803d0295d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334901 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41550}
2024-01-17 16:59:52 +00:00
: RTCStats(std::move(id), timestamp),
data_channels_opened("dataChannelsOpened"),
data_channels_closed("dataChannelsClosed") {}
RTCPeerConnectionStats::RTCPeerConnectionStats(
const RTCPeerConnectionStats& other) = default;
rtc_stats: Update code to remove chromium style warnings suppression. The warning previously suppressed made it possible to define tings like constructors in the header, and "complex" objects did not need to have an explicit out-of-line copy constructor, destructor, etc. To be able to not suppress this warning, the RTCStats macro was split into a WEBRTC_RTCSTATS_DECL() and WEBRTC_RTCSTATS_IMPL() for .h and .cc respectively. Some copy constructors are also defined. BUG=chromium:627816 Review-Url: https://codereview.webrtc.org/2373503002 Cr-Commit-Position: refs/heads/master@{#14545}
2016-10-06 02:06:10 -07:00
RTCTransportStats[1] added, supporting all members. Address TODO in rtcstatscollector_unittest.cc before closing 653873. [1] https://w3c.github.io/webrtc-stats/#transportstats-dict* BUG=chromium:653873, chromium:633550, chromium:627816 Review-Url: https://codereview.webrtc.org/2408363002 Cr-Commit-Position: refs/heads/master@{#14740}
2016-10-24 04:00:05 -07:00
RTCPeerConnectionStats::~RTCPeerConnectionStats() {}
rtc_stats: Update code to remove chromium style warnings suppression. The warning previously suppressed made it possible to define tings like constructors in the header, and "complex" objects did not need to have an explicit out-of-line copy constructor, destructor, etc. To be able to not suppress this warning, the RTCStats macro was split into a WEBRTC_RTCSTATS_DECL() and WEBRTC_RTCSTATS_IMPL() for .h and .cc respectively. Some copy constructors are also defined. BUG=chromium:627816 Review-Url: https://codereview.webrtc.org/2373503002 Cr-Commit-Position: refs/heads/master@{#14545}
2016-10-06 02:06:10 -07:00
Turn off clang-format for WEBRTC_RTCSTATS_IMPL macros. Clang format wants to put all parameters to WEBRTC_RTCSTATS_IMPL on their own line, but we prefer to keep the header on the first line and put the variable arguments (the stats) on their own lines. Bug: None Change-Id: Ic53104b46fb3c91c134d524027a150ba10055ad5 Reviewed-on: https://chromium-review.googlesource.com/621409 Reviewed-by: Henrik Boström <hbos@webrtc.org> Commit-Queue: Steve Anton <steveanton@webrtc.org> Cr-Commit-Position: refs/heads/master@{#19505}
2017-08-18 09:40:25 -07:00
// clang-format off
Fix stats inheritance and rename RTP to Rtp making RTCOutboundRtpStreamStats inherit from RTCSentRtpStreamStats as defined in https://www.w3.org/TR/webrtc-stats/#outboundrtpstats-dict* This removes the duplicated definitions of packetsSent and bytesSent. BUG=webrtc:14948 Change-Id: I184998b65d59dbd0d1288733d55d8a884e6de970 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/295660 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Reviewed-by: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39481}
2023-03-01 08:28:53 +01:00
WEBRTC_RTCSTATS_IMPL(RTCRtpStreamStats, RTCStats, "rtp",
Revert "[Stats] Move metric names to Attribute, constructed via AttributeInit." This reverts commit 84c48ae7513bad9c9ca19271569cd0431e780c32. Reason for revert: Breaks downstream project Original change's description: > [Stats] Move metric names to Attribute, constructed via AttributeInit. > > As of this CL, Attribute no longer implements RTCStatsMemberInterface > and a member no longer owns knowing its own name. The attribute knows > the name because we pass it down at construction time. > > To achieve this, the WEBRTC_RTCSTATS_IMPL() macro is updated to take > AttributeInits instead of raw member pointers, i.e. (name, ptr) pairs. > > By constructing RTCStatsMember<T> without a name parameter, it does the > same thing as the absl::optional<T> constructor. So RTCStatsMember<T>'s > days are numbered! > > Bug: webrtc:15164 > Change-Id: I560c0134bae1c2d7218426a1576425ecc1b677a7 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334203 > Commit-Queue: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Evan Shrubsole <eshr@google.com> > Cr-Commit-Position: refs/heads/main@{#41540} Bug: webrtc:15164 Change-Id: I9f416838153b26d4560ae98c37fb18a803d0295d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334901 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41550}
2024-01-17 16:59:52 +00:00
&ssrc,
&kind,
&transport_id,
&codec_id)
Turn off clang-format for WEBRTC_RTCSTATS_IMPL macros. Clang format wants to put all parameters to WEBRTC_RTCSTATS_IMPL on their own line, but we prefer to keep the header on the first line and put the variable arguments (the stats) on their own lines. Bug: None Change-Id: Ic53104b46fb3c91c134d524027a150ba10055ad5 Reviewed-on: https://chromium-review.googlesource.com/621409 Reviewed-by: Henrik Boström <hbos@webrtc.org> Commit-Queue: Steve Anton <steveanton@webrtc.org> Cr-Commit-Position: refs/heads/master@{#19505}
2017-08-18 09:40:25 -07:00
// clang-format on
RTCOutboundRTPStreamStats[1] added. This also adds RTCRTPStreamStats[2] which it derives from. Not all stats are supported in this CL, this must be addressed before closing the issue. RTCStatsReport also gets a timestamp and ToString. [1] https://w3c.github.io/webrtc-stats/#outboundrtpstats-dict* [2] https://w3c.github.io/webrtc-stats/#streamstats-dict* This was previously reverted https://codereview.webrtc.org/2465223002/ because RTCStatsReport::Create added a new parameter not used by Chromium unittests. Temporarily added a default value to the argument to be removed after rolling and updating Chromium. BUG=chromium:627816, chromium:657856, chromium:657854 TBR=deadbeef@webrtc.org Review-Url: https://codereview.webrtc.org/2470703002 Cr-Commit-Position: refs/heads/master@{#14866}
2016-11-01 01:50:46 -07:00
Fix stats inheritance and rename RTP to Rtp making RTCOutboundRtpStreamStats inherit from RTCSentRtpStreamStats as defined in https://www.w3.org/TR/webrtc-stats/#outboundrtpstats-dict* This removes the duplicated definitions of packetsSent and bytesSent. BUG=webrtc:14948 Change-Id: I184998b65d59dbd0d1288733d55d8a884e6de970 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/295660 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Reviewed-by: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39481}
2023-03-01 08:28:53 +01:00
RTCRtpStreamStats::RTCRtpStreamStats(std::string id, Timestamp timestamp)
Revert "[Stats] Move metric names to Attribute, constructed via AttributeInit." This reverts commit 84c48ae7513bad9c9ca19271569cd0431e780c32. Reason for revert: Breaks downstream project Original change's description: > [Stats] Move metric names to Attribute, constructed via AttributeInit. > > As of this CL, Attribute no longer implements RTCStatsMemberInterface > and a member no longer owns knowing its own name. The attribute knows > the name because we pass it down at construction time. > > To achieve this, the WEBRTC_RTCSTATS_IMPL() macro is updated to take > AttributeInits instead of raw member pointers, i.e. (name, ptr) pairs. > > By constructing RTCStatsMember<T> without a name parameter, it does the > same thing as the absl::optional<T> constructor. So RTCStatsMember<T>'s > days are numbered! > > Bug: webrtc:15164 > Change-Id: I560c0134bae1c2d7218426a1576425ecc1b677a7 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334203 > Commit-Queue: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Evan Shrubsole <eshr@google.com> > Cr-Commit-Position: refs/heads/main@{#41540} Bug: webrtc:15164 Change-Id: I9f416838153b26d4560ae98c37fb18a803d0295d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334901 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41550}
2024-01-17 16:59:52 +00:00
: RTCStats(std::move(id), timestamp),
ssrc("ssrc"),
kind("kind"),
transport_id("transportId"),
codec_id("codecId") {}
RTCRtpStreamStats::RTCRtpStreamStats(const RTCRtpStreamStats& other) = default;
RTCOutboundRTPStreamStats[1] added. This also adds RTCRTPStreamStats[2] which it derives from. Not all stats are supported in this CL, this must be addressed before closing the issue. RTCStatsReport also gets a timestamp and ToString. [1] https://w3c.github.io/webrtc-stats/#outboundrtpstats-dict* [2] https://w3c.github.io/webrtc-stats/#streamstats-dict* This was previously reverted https://codereview.webrtc.org/2465223002/ because RTCStatsReport::Create added a new parameter not used by Chromium unittests. Temporarily added a default value to the argument to be removed after rolling and updating Chromium. BUG=chromium:627816, chromium:657856, chromium:657854 TBR=deadbeef@webrtc.org Review-Url: https://codereview.webrtc.org/2470703002 Cr-Commit-Position: refs/heads/master@{#14866}
2016-11-01 01:50:46 -07:00
Fix stats inheritance and rename RTP to Rtp making RTCOutboundRtpStreamStats inherit from RTCSentRtpStreamStats as defined in https://www.w3.org/TR/webrtc-stats/#outboundrtpstats-dict* This removes the duplicated definitions of packetsSent and bytesSent. BUG=webrtc:14948 Change-Id: I184998b65d59dbd0d1288733d55d8a884e6de970 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/295660 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Reviewed-by: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39481}
2023-03-01 08:28:53 +01:00
RTCRtpStreamStats::~RTCRtpStreamStats() {}
RTCOutboundRTPStreamStats[1] added. This also adds RTCRTPStreamStats[2] which it derives from. Not all stats are supported in this CL, this must be addressed before closing the issue. RTCStatsReport also gets a timestamp and ToString. [1] https://w3c.github.io/webrtc-stats/#outboundrtpstats-dict* [2] https://w3c.github.io/webrtc-stats/#streamstats-dict* This was previously reverted https://codereview.webrtc.org/2465223002/ because RTCStatsReport::Create added a new parameter not used by Chromium unittests. Temporarily added a default value to the argument to be removed after rolling and updating Chromium. BUG=chromium:627816, chromium:657856, chromium:657854 TBR=deadbeef@webrtc.org Review-Url: https://codereview.webrtc.org/2470703002 Cr-Commit-Position: refs/heads/master@{#14866}
2016-11-01 01:50:46 -07:00
Turn off clang-format for WEBRTC_RTCSTATS_IMPL macros. Clang format wants to put all parameters to WEBRTC_RTCSTATS_IMPL on their own line, but we prefer to keep the header on the first line and put the variable arguments (the stats) on their own lines. Bug: None Change-Id: Ic53104b46fb3c91c134d524027a150ba10055ad5 Reviewed-on: https://chromium-review.googlesource.com/621409 Reviewed-by: Henrik Boström <hbos@webrtc.org> Commit-Queue: Steve Anton <steveanton@webrtc.org> Cr-Commit-Position: refs/heads/master@{#19505}
2017-08-18 09:40:25 -07:00
// clang-format off
RTCInboundRTPStreamStats[1] added. Not all stats are collected in this CL, this must be addressed before closing the issue. [1] https://w3c.github.io/webrtc-stats/#inboundrtpstats-dict* Re-landed after having to be reverted https://codereview.webrtc.org/2470683002/ due to depending on a CL that was reverted. Now that that has re-landed https://codereview.webrtc.org/2470703002/ this is ready to re-land. BUG=chromium:627816, chromium:657855, chromium:657854 R=hta@webrtc.org TBR=deadbeef@webrtc.org Review-Url: https://codereview.webrtc.org/2465173003 Cr-Commit-Position: refs/heads/master@{#14868}
2016-11-01 03:00:17 -07:00
WEBRTC_RTCSTATS_IMPL(
Fix stats inheritance and rename RTP to Rtp making RTCOutboundRtpStreamStats inherit from RTCSentRtpStreamStats as defined in https://www.w3.org/TR/webrtc-stats/#outboundrtpstats-dict* This removes the duplicated definitions of packetsSent and bytesSent. BUG=webrtc:14948 Change-Id: I184998b65d59dbd0d1288733d55d8a884e6de970 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/295660 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Reviewed-by: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39481}
2023-03-01 08:28:53 +01:00
RTCReceivedRtpStreamStats, RTCRtpStreamStats, "received-rtp",
Revert "[Stats] Move metric names to Attribute, constructed via AttributeInit." This reverts commit 84c48ae7513bad9c9ca19271569cd0431e780c32. Reason for revert: Breaks downstream project Original change's description: > [Stats] Move metric names to Attribute, constructed via AttributeInit. > > As of this CL, Attribute no longer implements RTCStatsMemberInterface > and a member no longer owns knowing its own name. The attribute knows > the name because we pass it down at construction time. > > To achieve this, the WEBRTC_RTCSTATS_IMPL() macro is updated to take > AttributeInits instead of raw member pointers, i.e. (name, ptr) pairs. > > By constructing RTCStatsMember<T> without a name parameter, it does the > same thing as the absl::optional<T> constructor. So RTCStatsMember<T>'s > days are numbered! > > Bug: webrtc:15164 > Change-Id: I560c0134bae1c2d7218426a1576425ecc1b677a7 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334203 > Commit-Queue: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Evan Shrubsole <eshr@google.com> > Cr-Commit-Position: refs/heads/main@{#41540} Bug: webrtc:15164 Change-Id: I9f416838153b26d4560ae98c37fb18a803d0295d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334901 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41550}
2024-01-17 16:59:52 +00:00
&jitter,
&packets_lost)
[Stats] Add minimum RTCReceivedRtpStreamStats with jitter and packetsLost Spec: https://www.w3.org/TR/webrtc-stats/#receivedrtpstats-dict* According to the spec, |RTCReceivedRtpStreamStats| is the base class for |RTCInboundRtpStreamStats| and |RTCRemoteInboundRtpStreamStats|. This structure isn't visible in JavaScript but it's important to bring it up to spec for the C++ part. This CL adds the barebone |RTCReceivedRtpStreamStats| with a bunch of TODOs for later migrations. This commit makes the minimum |RTCReceivedRtpStreamStats| and rebase |RTCInboundRtpStreamStats| and |RTCRemoteInboundRtpStreamStats| to use the new class as the parent class. This commit also moves |jitter| and |packets_lost| to |RTCReceivedRtpStreamStats|, from |RTCInboundRtpStreamStats| and |RTCRemoteInboundRtpStreamStats|. Moving these two first because they are the two that exist in both subclasses for now. Bug: webrtc:12532 Change-Id: I0ec74fd241f16c1e1a6498b6baa621ca0489f279 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/210340 Commit-Queue: Henrik Boström <hbos@webrtc.org> Reviewed-by: Henrik Boström <hbos@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33435}
2021-03-09 09:25:28 -08:00
// clang-format on
api: use std::string in stats constructor instead of const reference or rvalues. This follows the style guide: https://google.github.io/styleguide/cppguide.html#Rvalue_references BUG=webrtc:14807 Change-Id: I936b99146520815ae8105806409d46565fa83546 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/289985 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Henrik Boström <hbos@webrtc.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Cr-Commit-Position: refs/heads/main@{#38996}
2023-01-02 13:20:45 +01:00
RTCReceivedRtpStreamStats::RTCReceivedRtpStreamStats(std::string id,
stats: use Timestamp instead of uint64_t making it clear what unit is being used. BUG=webrtc:13756 Change-Id: I6354d35a8e02bb93a905ccf32cb0b294b4813e41 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/289460 Commit-Queue: Philipp Hancke <phancke@microsoft.com> Reviewed-by: Henrik Boström <hbos@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39008}
2023-01-04 15:17:42 +01:00
Timestamp timestamp)
Revert "[Stats] Move metric names to Attribute, constructed via AttributeInit." This reverts commit 84c48ae7513bad9c9ca19271569cd0431e780c32. Reason for revert: Breaks downstream project Original change's description: > [Stats] Move metric names to Attribute, constructed via AttributeInit. > > As of this CL, Attribute no longer implements RTCStatsMemberInterface > and a member no longer owns knowing its own name. The attribute knows > the name because we pass it down at construction time. > > To achieve this, the WEBRTC_RTCSTATS_IMPL() macro is updated to take > AttributeInits instead of raw member pointers, i.e. (name, ptr) pairs. > > By constructing RTCStatsMember<T> without a name parameter, it does the > same thing as the absl::optional<T> constructor. So RTCStatsMember<T>'s > days are numbered! > > Bug: webrtc:15164 > Change-Id: I560c0134bae1c2d7218426a1576425ecc1b677a7 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334203 > Commit-Queue: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Evan Shrubsole <eshr@google.com> > Cr-Commit-Position: refs/heads/main@{#41540} Bug: webrtc:15164 Change-Id: I9f416838153b26d4560ae98c37fb18a803d0295d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334901 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41550}
2024-01-17 16:59:52 +00:00
: RTCRtpStreamStats(std::move(id), timestamp),
jitter("jitter"),
packets_lost("packetsLost") {}
RTCReceivedRtpStreamStats::RTCReceivedRtpStreamStats(
const RTCReceivedRtpStreamStats& other) = default;
[Stats] Add minimum RTCReceivedRtpStreamStats with jitter and packetsLost Spec: https://www.w3.org/TR/webrtc-stats/#receivedrtpstats-dict* According to the spec, |RTCReceivedRtpStreamStats| is the base class for |RTCInboundRtpStreamStats| and |RTCRemoteInboundRtpStreamStats|. This structure isn't visible in JavaScript but it's important to bring it up to spec for the C++ part. This CL adds the barebone |RTCReceivedRtpStreamStats| with a bunch of TODOs for later migrations. This commit makes the minimum |RTCReceivedRtpStreamStats| and rebase |RTCInboundRtpStreamStats| and |RTCRemoteInboundRtpStreamStats| to use the new class as the parent class. This commit also moves |jitter| and |packets_lost| to |RTCReceivedRtpStreamStats|, from |RTCInboundRtpStreamStats| and |RTCRemoteInboundRtpStreamStats|. Moving these two first because they are the two that exist in both subclasses for now. Bug: webrtc:12532 Change-Id: I0ec74fd241f16c1e1a6498b6baa621ca0489f279 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/210340 Commit-Queue: Henrik Boström <hbos@webrtc.org> Reviewed-by: Henrik Boström <hbos@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33435}
2021-03-09 09:25:28 -08:00
RTCReceivedRtpStreamStats::~RTCReceivedRtpStreamStats() {}
Add `RTCRemoteOutboundRtpStreamStats` for audio streams Changes: - adding the `RTCRemoteOutboundRtpStreamStats` dictionary (see [1]) - collection of remote outbound stats (only for audio streams) - adding `remote_id` to the inbound stats and set with the ID of the corresponding remote outbound stats only if the latter are available - unit tests [1] https://www.w3.org/TR/webrtc-stats/#dom-rtcremoteoutboundrtpstreamstats Tested: verified from chrome://webrtc-internals during an appr.tc call Bug: webrtc:12529 Change-Id: Ide91dc04a3c387ba439618a9c6b64a95994a1940 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/211042 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Reviewed-by: Sam Zackrisson <saza@webrtc.org> Reviewed-by: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33545}
2021-03-23 17:23:04 +01:00
// clang-format off
Revert "[Stats] Move metric names to Attribute, constructed via AttributeInit." This reverts commit 84c48ae7513bad9c9ca19271569cd0431e780c32. Reason for revert: Breaks downstream project Original change's description: > [Stats] Move metric names to Attribute, constructed via AttributeInit. > > As of this CL, Attribute no longer implements RTCStatsMemberInterface > and a member no longer owns knowing its own name. The attribute knows > the name because we pass it down at construction time. > > To achieve this, the WEBRTC_RTCSTATS_IMPL() macro is updated to take > AttributeInits instead of raw member pointers, i.e. (name, ptr) pairs. > > By constructing RTCStatsMember<T> without a name parameter, it does the > same thing as the absl::optional<T> constructor. So RTCStatsMember<T>'s > days are numbered! > > Bug: webrtc:15164 > Change-Id: I560c0134bae1c2d7218426a1576425ecc1b677a7 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334203 > Commit-Queue: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Evan Shrubsole <eshr@google.com> > Cr-Commit-Position: refs/heads/main@{#41540} Bug: webrtc:15164 Change-Id: I9f416838153b26d4560ae98c37fb18a803d0295d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334901 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41550}
2024-01-17 16:59:52 +00:00
WEBRTC_RTCSTATS_IMPL(
RTCSentRtpStreamStats, RTCRtpStreamStats, "sent-rtp",
&packets_sent,
&bytes_sent)
Add `RTCRemoteOutboundRtpStreamStats` for audio streams Changes: - adding the `RTCRemoteOutboundRtpStreamStats` dictionary (see [1]) - collection of remote outbound stats (only for audio streams) - adding `remote_id` to the inbound stats and set with the ID of the corresponding remote outbound stats only if the latter are available - unit tests [1] https://www.w3.org/TR/webrtc-stats/#dom-rtcremoteoutboundrtpstreamstats Tested: verified from chrome://webrtc-internals during an appr.tc call Bug: webrtc:12529 Change-Id: Ide91dc04a3c387ba439618a9c6b64a95994a1940 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/211042 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Reviewed-by: Sam Zackrisson <saza@webrtc.org> Reviewed-by: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33545}
2021-03-23 17:23:04 +01:00
// clang-format on
api: use std::string in stats constructor instead of const reference or rvalues. This follows the style guide: https://google.github.io/styleguide/cppguide.html#Rvalue_references BUG=webrtc:14807 Change-Id: I936b99146520815ae8105806409d46565fa83546 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/289985 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Henrik Boström <hbos@webrtc.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Cr-Commit-Position: refs/heads/main@{#38996}
2023-01-02 13:20:45 +01:00
RTCSentRtpStreamStats::RTCSentRtpStreamStats(std::string id,
stats: use Timestamp instead of uint64_t making it clear what unit is being used. BUG=webrtc:13756 Change-Id: I6354d35a8e02bb93a905ccf32cb0b294b4813e41 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/289460 Commit-Queue: Philipp Hancke <phancke@microsoft.com> Reviewed-by: Henrik Boström <hbos@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39008}
2023-01-04 15:17:42 +01:00
Timestamp timestamp)
Revert "[Stats] Move metric names to Attribute, constructed via AttributeInit." This reverts commit 84c48ae7513bad9c9ca19271569cd0431e780c32. Reason for revert: Breaks downstream project Original change's description: > [Stats] Move metric names to Attribute, constructed via AttributeInit. > > As of this CL, Attribute no longer implements RTCStatsMemberInterface > and a member no longer owns knowing its own name. The attribute knows > the name because we pass it down at construction time. > > To achieve this, the WEBRTC_RTCSTATS_IMPL() macro is updated to take > AttributeInits instead of raw member pointers, i.e. (name, ptr) pairs. > > By constructing RTCStatsMember<T> without a name parameter, it does the > same thing as the absl::optional<T> constructor. So RTCStatsMember<T>'s > days are numbered! > > Bug: webrtc:15164 > Change-Id: I560c0134bae1c2d7218426a1576425ecc1b677a7 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334203 > Commit-Queue: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Evan Shrubsole <eshr@google.com> > Cr-Commit-Position: refs/heads/main@{#41540} Bug: webrtc:15164 Change-Id: I9f416838153b26d4560ae98c37fb18a803d0295d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334901 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41550}
2024-01-17 16:59:52 +00:00
: RTCRtpStreamStats(std::move(id), timestamp),
packets_sent("packetsSent"),
bytes_sent("bytesSent") {}
RTCSentRtpStreamStats::RTCSentRtpStreamStats(
const RTCSentRtpStreamStats& other) = default;
Add `RTCRemoteOutboundRtpStreamStats` for audio streams Changes: - adding the `RTCRemoteOutboundRtpStreamStats` dictionary (see [1]) - collection of remote outbound stats (only for audio streams) - adding `remote_id` to the inbound stats and set with the ID of the corresponding remote outbound stats only if the latter are available - unit tests [1] https://www.w3.org/TR/webrtc-stats/#dom-rtcremoteoutboundrtpstreamstats Tested: verified from chrome://webrtc-internals during an appr.tc call Bug: webrtc:12529 Change-Id: Ide91dc04a3c387ba439618a9c6b64a95994a1940 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/211042 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Reviewed-by: Sam Zackrisson <saza@webrtc.org> Reviewed-by: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33545}
2021-03-23 17:23:04 +01:00
RTCSentRtpStreamStats::~RTCSentRtpStreamStats() {}
[Stats] Add minimum RTCReceivedRtpStreamStats with jitter and packetsLost Spec: https://www.w3.org/TR/webrtc-stats/#receivedrtpstats-dict* According to the spec, |RTCReceivedRtpStreamStats| is the base class for |RTCInboundRtpStreamStats| and |RTCRemoteInboundRtpStreamStats|. This structure isn't visible in JavaScript but it's important to bring it up to spec for the C++ part. This CL adds the barebone |RTCReceivedRtpStreamStats| with a bunch of TODOs for later migrations. This commit makes the minimum |RTCReceivedRtpStreamStats| and rebase |RTCInboundRtpStreamStats| and |RTCRemoteInboundRtpStreamStats| to use the new class as the parent class. This commit also moves |jitter| and |packets_lost| to |RTCReceivedRtpStreamStats|, from |RTCInboundRtpStreamStats| and |RTCRemoteInboundRtpStreamStats|. Moving these two first because they are the two that exist in both subclasses for now. Bug: webrtc:12532 Change-Id: I0ec74fd241f16c1e1a6498b6baa621ca0489f279 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/210340 Commit-Queue: Henrik Boström <hbos@webrtc.org> Reviewed-by: Henrik Boström <hbos@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33435}
2021-03-09 09:25:28 -08:00
// clang-format off
WEBRTC_RTCSTATS_IMPL(
stats: rename RTCInboundRTPStreamStats and RTCOutboundRTPStreamStats to RTCInboundRtpStreamStats and RTCOutboundRtpStreamStats respectively which follows the camel-casing convention used elsewhere. The old name is kept around as an alias for a limited amount of time to allow upgrading dependencies. BUG=webrtc:14973 Change-Id: Ibf4e65933fd6cc2e7e89955042f6f8fb0f6c7853 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/296261 Reviewed-by: Henrik Boström <hbos@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Cr-Commit-Position: refs/heads/main@{#39497}
2023-03-07 09:53:59 +01:00
RTCInboundRtpStreamStats, RTCReceivedRtpStreamStats, "inbound-rtp",
Revert "[Stats] Move metric names to Attribute, constructed via AttributeInit." This reverts commit 84c48ae7513bad9c9ca19271569cd0431e780c32. Reason for revert: Breaks downstream project Original change's description: > [Stats] Move metric names to Attribute, constructed via AttributeInit. > > As of this CL, Attribute no longer implements RTCStatsMemberInterface > and a member no longer owns knowing its own name. The attribute knows > the name because we pass it down at construction time. > > To achieve this, the WEBRTC_RTCSTATS_IMPL() macro is updated to take > AttributeInits instead of raw member pointers, i.e. (name, ptr) pairs. > > By constructing RTCStatsMember<T> without a name parameter, it does the > same thing as the absl::optional<T> constructor. So RTCStatsMember<T>'s > days are numbered! > > Bug: webrtc:15164 > Change-Id: I560c0134bae1c2d7218426a1576425ecc1b677a7 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334203 > Commit-Queue: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Evan Shrubsole <eshr@google.com> > Cr-Commit-Position: refs/heads/main@{#41540} Bug: webrtc:15164 Change-Id: I9f416838153b26d4560ae98c37fb18a803d0295d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334901 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41550}
2024-01-17 16:59:52 +00:00
&track_identifier,
&mid,
&remote_id,
&packets_received,
&packets_discarded,
&fec_packets_received,
&fec_bytes_received,
&fec_packets_discarded,
&fec_ssrc,
&bytes_received,
&header_bytes_received,
&retransmitted_packets_received,
&retransmitted_bytes_received,
&rtx_ssrc,
&last_packet_received_timestamp,
&jitter_buffer_delay,
&jitter_buffer_target_delay,
&jitter_buffer_minimum_delay,
&jitter_buffer_emitted_count,
&total_samples_received,
&concealed_samples,
&silent_concealed_samples,
&concealment_events,
&inserted_samples_for_deceleration,
&removed_samples_for_acceleration,
&audio_level,
&total_audio_energy,
&total_samples_duration,
&playout_id,
&frames_received,
&frame_width,
&frame_height,
&frames_per_second,
&frames_decoded,
&key_frames_decoded,
&frames_dropped,
&total_decode_time,
&total_processing_delay,
&total_assembly_time,
&frames_assembled_from_multiple_packets,
&total_inter_frame_delay,
&total_squared_inter_frame_delay,
&pause_count,
&total_pauses_duration,
&freeze_count,
&total_freezes_duration,
&content_type,
&estimated_playout_timestamp,
&decoder_implementation,
&fir_count,
&pli_count,
&nack_count,
&qp_sum,
&goog_timing_frame_info,
&power_efficient_decoder,
&jitter_buffer_flushes,
&delayed_packet_outage_samples,
&relative_packet_arrival_delay,
&interruption_count,
&total_interruption_duration,
&min_playout_delay)
Turn off clang-format for WEBRTC_RTCSTATS_IMPL macros. Clang format wants to put all parameters to WEBRTC_RTCSTATS_IMPL on their own line, but we prefer to keep the header on the first line and put the variable arguments (the stats) on their own lines. Bug: None Change-Id: Ic53104b46fb3c91c134d524027a150ba10055ad5 Reviewed-on: https://chromium-review.googlesource.com/621409 Reviewed-by: Henrik Boström <hbos@webrtc.org> Commit-Queue: Steve Anton <steveanton@webrtc.org> Cr-Commit-Position: refs/heads/master@{#19505}
2017-08-18 09:40:25 -07:00
// clang-format on
RTCInboundRTPStreamStats[1] added. Not all stats are collected in this CL, this must be addressed before closing the issue. [1] https://w3c.github.io/webrtc-stats/#inboundrtpstats-dict* Re-landed after having to be reverted https://codereview.webrtc.org/2470683002/ due to depending on a CL that was reverted. Now that that has re-landed https://codereview.webrtc.org/2470703002/ this is ready to re-land. BUG=chromium:627816, chromium:657855, chromium:657854 R=hta@webrtc.org TBR=deadbeef@webrtc.org Review-Url: https://codereview.webrtc.org/2465173003 Cr-Commit-Position: refs/heads/master@{#14868}
2016-11-01 03:00:17 -07:00
stats: rename RTCInboundRTPStreamStats and RTCOutboundRTPStreamStats to RTCInboundRtpStreamStats and RTCOutboundRtpStreamStats respectively which follows the camel-casing convention used elsewhere. The old name is kept around as an alias for a limited amount of time to allow upgrading dependencies. BUG=webrtc:14973 Change-Id: Ibf4e65933fd6cc2e7e89955042f6f8fb0f6c7853 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/296261 Reviewed-by: Henrik Boström <hbos@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Cr-Commit-Position: refs/heads/main@{#39497}
2023-03-07 09:53:59 +01:00
RTCInboundRtpStreamStats::RTCInboundRtpStreamStats(std::string id,
stats: use Timestamp instead of uint64_t making it clear what unit is being used. BUG=webrtc:13756 Change-Id: I6354d35a8e02bb93a905ccf32cb0b294b4813e41 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/289460 Commit-Queue: Philipp Hancke <phancke@microsoft.com> Reviewed-by: Henrik Boström <hbos@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39008}
2023-01-04 15:17:42 +01:00
Timestamp timestamp)
Revert "[Stats] Move metric names to Attribute, constructed via AttributeInit." This reverts commit 84c48ae7513bad9c9ca19271569cd0431e780c32. Reason for revert: Breaks downstream project Original change's description: > [Stats] Move metric names to Attribute, constructed via AttributeInit. > > As of this CL, Attribute no longer implements RTCStatsMemberInterface > and a member no longer owns knowing its own name. The attribute knows > the name because we pass it down at construction time. > > To achieve this, the WEBRTC_RTCSTATS_IMPL() macro is updated to take > AttributeInits instead of raw member pointers, i.e. (name, ptr) pairs. > > By constructing RTCStatsMember<T> without a name parameter, it does the > same thing as the absl::optional<T> constructor. So RTCStatsMember<T>'s > days are numbered! > > Bug: webrtc:15164 > Change-Id: I560c0134bae1c2d7218426a1576425ecc1b677a7 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334203 > Commit-Queue: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Evan Shrubsole <eshr@google.com> > Cr-Commit-Position: refs/heads/main@{#41540} Bug: webrtc:15164 Change-Id: I9f416838153b26d4560ae98c37fb18a803d0295d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334901 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41550}
2024-01-17 16:59:52 +00:00
: RTCReceivedRtpStreamStats(std::move(id), timestamp),
playout_id("playoutId"),
track_identifier("trackIdentifier"),
mid("mid"),
remote_id("remoteId"),
packets_received("packetsReceived"),
packets_discarded("packetsDiscarded"),
fec_packets_received("fecPacketsReceived"),
fec_bytes_received("fecBytesReceived"),
fec_packets_discarded("fecPacketsDiscarded"),
fec_ssrc("fecSsrc"),
bytes_received("bytesReceived"),
header_bytes_received("headerBytesReceived"),
retransmitted_packets_received("retransmittedPacketsReceived"),
retransmitted_bytes_received("retransmittedBytesReceived"),
rtx_ssrc("rtxSsrc"),
last_packet_received_timestamp("lastPacketReceivedTimestamp"),
jitter_buffer_delay("jitterBufferDelay"),
jitter_buffer_target_delay("jitterBufferTargetDelay"),
jitter_buffer_minimum_delay("jitterBufferMinimumDelay"),
jitter_buffer_emitted_count("jitterBufferEmittedCount"),
total_samples_received("totalSamplesReceived"),
concealed_samples("concealedSamples"),
silent_concealed_samples("silentConcealedSamples"),
concealment_events("concealmentEvents"),
inserted_samples_for_deceleration("insertedSamplesForDeceleration"),
removed_samples_for_acceleration("removedSamplesForAcceleration"),
audio_level("audioLevel"),
total_audio_energy("totalAudioEnergy"),
total_samples_duration("totalSamplesDuration"),
frames_received("framesReceived"),
frame_width("frameWidth"),
frame_height("frameHeight"),
frames_per_second("framesPerSecond"),
frames_decoded("framesDecoded"),
key_frames_decoded("keyFramesDecoded"),
frames_dropped("framesDropped"),
total_decode_time("totalDecodeTime"),
total_processing_delay("totalProcessingDelay"),
total_assembly_time("totalAssemblyTime"),
frames_assembled_from_multiple_packets(
"framesAssembledFromMultiplePackets"),
total_inter_frame_delay("totalInterFrameDelay"),
total_squared_inter_frame_delay("totalSquaredInterFrameDelay"),
pause_count("pauseCount"),
total_pauses_duration("totalPausesDuration"),
freeze_count("freezeCount"),
total_freezes_duration("totalFreezesDuration"),
content_type("contentType"),
estimated_playout_timestamp("estimatedPlayoutTimestamp"),
decoder_implementation("decoderImplementation"),
fir_count("firCount"),
pli_count("pliCount"),
nack_count("nackCount"),
qp_sum("qpSum"),
goog_timing_frame_info("googTimingFrameInfo"),
power_efficient_decoder("powerEfficientDecoder"),
jitter_buffer_flushes("jitterBufferFlushes"),
delayed_packet_outage_samples("delayedPacketOutageSamples"),
relative_packet_arrival_delay("relativePacketArrivalDelay"),
interruption_count("interruptionCount"),
total_interruption_duration("totalInterruptionDuration"),
min_playout_delay("minPlayoutDelay") {}
RTCInboundRtpStreamStats::RTCInboundRtpStreamStats(
const RTCInboundRtpStreamStats& other) = default;
stats: rename RTCInboundRTPStreamStats and RTCOutboundRTPStreamStats to RTCInboundRtpStreamStats and RTCOutboundRtpStreamStats respectively which follows the camel-casing convention used elsewhere. The old name is kept around as an alias for a limited amount of time to allow upgrading dependencies. BUG=webrtc:14973 Change-Id: Ibf4e65933fd6cc2e7e89955042f6f8fb0f6c7853 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/296261 Reviewed-by: Henrik Boström <hbos@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Cr-Commit-Position: refs/heads/main@{#39497}
2023-03-07 09:53:59 +01:00
RTCInboundRtpStreamStats::~RTCInboundRtpStreamStats() {}
RTCInboundRTPStreamStats[1] added. Not all stats are collected in this CL, this must be addressed before closing the issue. [1] https://w3c.github.io/webrtc-stats/#inboundrtpstats-dict* Re-landed after having to be reverted https://codereview.webrtc.org/2470683002/ due to depending on a CL that was reverted. Now that that has re-landed https://codereview.webrtc.org/2470703002/ this is ready to re-land. BUG=chromium:627816, chromium:657855, chromium:657854 R=hta@webrtc.org TBR=deadbeef@webrtc.org Review-Url: https://codereview.webrtc.org/2465173003 Cr-Commit-Position: refs/heads/master@{#14868}
2016-11-01 03:00:17 -07:00
Turn off clang-format for WEBRTC_RTCSTATS_IMPL macros. Clang format wants to put all parameters to WEBRTC_RTCSTATS_IMPL on their own line, but we prefer to keep the header on the first line and put the variable arguments (the stats) on their own lines. Bug: None Change-Id: Ic53104b46fb3c91c134d524027a150ba10055ad5 Reviewed-on: https://chromium-review.googlesource.com/621409 Reviewed-by: Henrik Boström <hbos@webrtc.org> Commit-Queue: Steve Anton <steveanton@webrtc.org> Cr-Commit-Position: refs/heads/master@{#19505}
2017-08-18 09:40:25 -07:00
// clang-format off
RTCOutboundRTPStreamStats[1] added. This also adds RTCRTPStreamStats[2] which it derives from. Not all stats are supported in this CL, this must be addressed before closing the issue. RTCStatsReport also gets a timestamp and ToString. [1] https://w3c.github.io/webrtc-stats/#outboundrtpstats-dict* [2] https://w3c.github.io/webrtc-stats/#streamstats-dict* This was previously reverted https://codereview.webrtc.org/2465223002/ because RTCStatsReport::Create added a new parameter not used by Chromium unittests. Temporarily added a default value to the argument to be removed after rolling and updating Chromium. BUG=chromium:627816, chromium:657856, chromium:657854 TBR=deadbeef@webrtc.org Review-Url: https://codereview.webrtc.org/2470703002 Cr-Commit-Position: refs/heads/master@{#14866}
2016-11-01 01:50:46 -07:00
WEBRTC_RTCSTATS_IMPL(
stats: rename RTCInboundRTPStreamStats and RTCOutboundRTPStreamStats to RTCInboundRtpStreamStats and RTCOutboundRtpStreamStats respectively which follows the camel-casing convention used elsewhere. The old name is kept around as an alias for a limited amount of time to allow upgrading dependencies. BUG=webrtc:14973 Change-Id: Ibf4e65933fd6cc2e7e89955042f6f8fb0f6c7853 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/296261 Reviewed-by: Henrik Boström <hbos@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Cr-Commit-Position: refs/heads/main@{#39497}
2023-03-07 09:53:59 +01:00
RTCOutboundRtpStreamStats, RTCSentRtpStreamStats, "outbound-rtp",
Revert "[Stats] Move metric names to Attribute, constructed via AttributeInit." This reverts commit 84c48ae7513bad9c9ca19271569cd0431e780c32. Reason for revert: Breaks downstream project Original change's description: > [Stats] Move metric names to Attribute, constructed via AttributeInit. > > As of this CL, Attribute no longer implements RTCStatsMemberInterface > and a member no longer owns knowing its own name. The attribute knows > the name because we pass it down at construction time. > > To achieve this, the WEBRTC_RTCSTATS_IMPL() macro is updated to take > AttributeInits instead of raw member pointers, i.e. (name, ptr) pairs. > > By constructing RTCStatsMember<T> without a name parameter, it does the > same thing as the absl::optional<T> constructor. So RTCStatsMember<T>'s > days are numbered! > > Bug: webrtc:15164 > Change-Id: I560c0134bae1c2d7218426a1576425ecc1b677a7 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334203 > Commit-Queue: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Evan Shrubsole <eshr@google.com> > Cr-Commit-Position: refs/heads/main@{#41540} Bug: webrtc:15164 Change-Id: I9f416838153b26d4560ae98c37fb18a803d0295d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334901 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41550}
2024-01-17 16:59:52 +00:00
&media_source_id,
&remote_id,
&mid,
&rid,
&retransmitted_packets_sent,
&header_bytes_sent,
&retransmitted_bytes_sent,
&target_bitrate,
&frames_encoded,
&key_frames_encoded,
&total_encode_time,
&total_encoded_bytes_target,
&frame_width,
&frame_height,
&frames_per_second,
&frames_sent,
&huge_frames_sent,
&total_packet_send_delay,
&quality_limitation_reason,
&quality_limitation_durations,
&quality_limitation_resolution_changes,
&content_type,
&encoder_implementation,
&fir_count,
&pli_count,
&nack_count,
&qp_sum,
&active,
&power_efficient_encoder,
&scalability_mode,
&rtx_ssrc)
Turn off clang-format for WEBRTC_RTCSTATS_IMPL macros. Clang format wants to put all parameters to WEBRTC_RTCSTATS_IMPL on their own line, but we prefer to keep the header on the first line and put the variable arguments (the stats) on their own lines. Bug: None Change-Id: Ic53104b46fb3c91c134d524027a150ba10055ad5 Reviewed-on: https://chromium-review.googlesource.com/621409 Reviewed-by: Henrik Boström <hbos@webrtc.org> Commit-Queue: Steve Anton <steveanton@webrtc.org> Cr-Commit-Position: refs/heads/master@{#19505}
2017-08-18 09:40:25 -07:00
// clang-format on
RTCOutboundRTPStreamStats[1] added. This also adds RTCRTPStreamStats[2] which it derives from. Not all stats are supported in this CL, this must be addressed before closing the issue. RTCStatsReport also gets a timestamp and ToString. [1] https://w3c.github.io/webrtc-stats/#outboundrtpstats-dict* [2] https://w3c.github.io/webrtc-stats/#streamstats-dict* This was previously reverted https://codereview.webrtc.org/2465223002/ because RTCStatsReport::Create added a new parameter not used by Chromium unittests. Temporarily added a default value to the argument to be removed after rolling and updating Chromium. BUG=chromium:627816, chromium:657856, chromium:657854 TBR=deadbeef@webrtc.org Review-Url: https://codereview.webrtc.org/2470703002 Cr-Commit-Position: refs/heads/master@{#14866}
2016-11-01 01:50:46 -07:00
stats: rename RTCInboundRTPStreamStats and RTCOutboundRTPStreamStats to RTCInboundRtpStreamStats and RTCOutboundRtpStreamStats respectively which follows the camel-casing convention used elsewhere. The old name is kept around as an alias for a limited amount of time to allow upgrading dependencies. BUG=webrtc:14973 Change-Id: Ibf4e65933fd6cc2e7e89955042f6f8fb0f6c7853 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/296261 Reviewed-by: Henrik Boström <hbos@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Cr-Commit-Position: refs/heads/main@{#39497}
2023-03-07 09:53:59 +01:00
RTCOutboundRtpStreamStats::RTCOutboundRtpStreamStats(std::string id,
stats: use Timestamp instead of uint64_t making it clear what unit is being used. BUG=webrtc:13756 Change-Id: I6354d35a8e02bb93a905ccf32cb0b294b4813e41 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/289460 Commit-Queue: Philipp Hancke <phancke@microsoft.com> Reviewed-by: Henrik Boström <hbos@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39008}
2023-01-04 15:17:42 +01:00
Timestamp timestamp)
Revert "[Stats] Move metric names to Attribute, constructed via AttributeInit." This reverts commit 84c48ae7513bad9c9ca19271569cd0431e780c32. Reason for revert: Breaks downstream project Original change's description: > [Stats] Move metric names to Attribute, constructed via AttributeInit. > > As of this CL, Attribute no longer implements RTCStatsMemberInterface > and a member no longer owns knowing its own name. The attribute knows > the name because we pass it down at construction time. > > To achieve this, the WEBRTC_RTCSTATS_IMPL() macro is updated to take > AttributeInits instead of raw member pointers, i.e. (name, ptr) pairs. > > By constructing RTCStatsMember<T> without a name parameter, it does the > same thing as the absl::optional<T> constructor. So RTCStatsMember<T>'s > days are numbered! > > Bug: webrtc:15164 > Change-Id: I560c0134bae1c2d7218426a1576425ecc1b677a7 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334203 > Commit-Queue: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Evan Shrubsole <eshr@google.com> > Cr-Commit-Position: refs/heads/main@{#41540} Bug: webrtc:15164 Change-Id: I9f416838153b26d4560ae98c37fb18a803d0295d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334901 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41550}
2024-01-17 16:59:52 +00:00
: RTCSentRtpStreamStats(std::move(id), timestamp),
media_source_id("mediaSourceId"),
remote_id("remoteId"),
mid("mid"),
rid("rid"),
retransmitted_packets_sent("retransmittedPacketsSent"),
header_bytes_sent("headerBytesSent"),
retransmitted_bytes_sent("retransmittedBytesSent"),
target_bitrate("targetBitrate"),
frames_encoded("framesEncoded"),
key_frames_encoded("keyFramesEncoded"),
total_encode_time("totalEncodeTime"),
total_encoded_bytes_target("totalEncodedBytesTarget"),
frame_width("frameWidth"),
frame_height("frameHeight"),
frames_per_second("framesPerSecond"),
frames_sent("framesSent"),
huge_frames_sent("hugeFramesSent"),
total_packet_send_delay("totalPacketSendDelay"),
quality_limitation_reason("qualityLimitationReason"),
quality_limitation_durations("qualityLimitationDurations"),
quality_limitation_resolution_changes(
"qualityLimitationResolutionChanges"),
content_type("contentType"),
encoder_implementation("encoderImplementation"),
fir_count("firCount"),
pli_count("pliCount"),
nack_count("nackCount"),
qp_sum("qpSum"),
active("active"),
power_efficient_encoder("powerEfficientEncoder"),
scalability_mode("scalabilityMode"),
rtx_ssrc("rtxSsrc") {}
RTCOutboundRtpStreamStats::RTCOutboundRtpStreamStats(
const RTCOutboundRtpStreamStats& other) = default;
RTCOutboundRTPStreamStats[1] added. This also adds RTCRTPStreamStats[2] which it derives from. Not all stats are supported in this CL, this must be addressed before closing the issue. RTCStatsReport also gets a timestamp and ToString. [1] https://w3c.github.io/webrtc-stats/#outboundrtpstats-dict* [2] https://w3c.github.io/webrtc-stats/#streamstats-dict* This was previously reverted https://codereview.webrtc.org/2465223002/ because RTCStatsReport::Create added a new parameter not used by Chromium unittests. Temporarily added a default value to the argument to be removed after rolling and updating Chromium. BUG=chromium:627816, chromium:657856, chromium:657854 TBR=deadbeef@webrtc.org Review-Url: https://codereview.webrtc.org/2470703002 Cr-Commit-Position: refs/heads/master@{#14866}
2016-11-01 01:50:46 -07:00
stats: rename RTCInboundRTPStreamStats and RTCOutboundRTPStreamStats to RTCInboundRtpStreamStats and RTCOutboundRtpStreamStats respectively which follows the camel-casing convention used elsewhere. The old name is kept around as an alias for a limited amount of time to allow upgrading dependencies. BUG=webrtc:14973 Change-Id: Ibf4e65933fd6cc2e7e89955042f6f8fb0f6c7853 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/296261 Reviewed-by: Henrik Boström <hbos@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Cr-Commit-Position: refs/heads/main@{#39497}
2023-03-07 09:53:59 +01:00
RTCOutboundRtpStreamStats::~RTCOutboundRtpStreamStats() {}
RTCOutboundRTPStreamStats[1] added. This also adds RTCRTPStreamStats[2] which it derives from. Not all stats are supported in this CL, this must be addressed before closing the issue. RTCStatsReport also gets a timestamp and ToString. [1] https://w3c.github.io/webrtc-stats/#outboundrtpstats-dict* [2] https://w3c.github.io/webrtc-stats/#streamstats-dict* This was previously reverted https://codereview.webrtc.org/2465223002/ because RTCStatsReport::Create added a new parameter not used by Chromium unittests. Temporarily added a default value to the argument to be removed after rolling and updating Chromium. BUG=chromium:627816, chromium:657856, chromium:657854 TBR=deadbeef@webrtc.org Review-Url: https://codereview.webrtc.org/2470703002 Cr-Commit-Position: refs/heads/master@{#14866}
2016-11-01 01:50:46 -07:00
Implement RTCRemoteInboundRtpStreamStats for both audio and video. This implements the essentials of RTCRemoteInboundRtpStreamStats. This includes: - ssrc - transportId - codecId - packetsLost - jitter - localId - roundTripTime https://w3c.github.io/webrtc-stats/#remoteinboundrtpstats-dict* The following members are not implemented because they require more work... - From RTCReceivedRtpStreamStats: packetsReceived, packetsDiscarded, packetsRepaired, burstPacketsLost, burstPacketsDiscarded, burstLossCount, burstDiscardCount, burstLossRate, burstDiscardRate, gapLossRate and gapDiscardRate. - From RTCRemoteInboundRtpStreamStats: fractionLost. Bug: webrtc:10455, webrtc:10456 Change-Id: If2ab0da7105d8c93bba58e14aa93bd22ffe57f1d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/138067 Commit-Queue: Henrik Boström <hbos@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28073}
2019-05-27 13:40:25 +02:00
// clang-format off
WEBRTC_RTCSTATS_IMPL(
Make sure "remote-inbound-rtp.jitter" and "packetsLost" is exposed to JS In refactoring CL https://webrtc-review.googlesource.com/c/src/+/210340, the RTCRemoteInboundRtpStreamStats hierarchy was updated to inherit from RTCReceivedRtpStreamStats but we forgot to update the WEBRTC_RTCSTATS_IMPL() macro to say that RTCReceivedRtpStreamStats is the parent. As a consequence, RTCReceivedRtpStreamStats's members (jitter and packetsLost) were not included when iterating over all members of RTCRemoteInboundRtpStreamStats, which means these two merics stopped being exposed to JavaScript in Chromium. There is sadly no way to safe-guard against this, but the fix is simple. TBR=hta@webrtc.org,meetwudi@gmail.com Bug: webrtc:12532 Change-Id: I0179dad6eaa592ee36cfe48978f2fc22133b8f45 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212866 Reviewed-by: Henrik Boström <hbos@webrtc.org> Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> Commit-Queue: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33543}
2021-03-23 15:18:55 +01:00
RTCRemoteInboundRtpStreamStats, RTCReceivedRtpStreamStats,
"remote-inbound-rtp",
Revert "[Stats] Move metric names to Attribute, constructed via AttributeInit." This reverts commit 84c48ae7513bad9c9ca19271569cd0431e780c32. Reason for revert: Breaks downstream project Original change's description: > [Stats] Move metric names to Attribute, constructed via AttributeInit. > > As of this CL, Attribute no longer implements RTCStatsMemberInterface > and a member no longer owns knowing its own name. The attribute knows > the name because we pass it down at construction time. > > To achieve this, the WEBRTC_RTCSTATS_IMPL() macro is updated to take > AttributeInits instead of raw member pointers, i.e. (name, ptr) pairs. > > By constructing RTCStatsMember<T> without a name parameter, it does the > same thing as the absl::optional<T> constructor. So RTCStatsMember<T>'s > days are numbered! > > Bug: webrtc:15164 > Change-Id: I560c0134bae1c2d7218426a1576425ecc1b677a7 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334203 > Commit-Queue: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Evan Shrubsole <eshr@google.com> > Cr-Commit-Position: refs/heads/main@{#41540} Bug: webrtc:15164 Change-Id: I9f416838153b26d4560ae98c37fb18a803d0295d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334901 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41550}
2024-01-17 16:59:52 +00:00
&local_id,
&round_trip_time,
&fraction_lost,
&total_round_trip_time,
&round_trip_time_measurements)
Implement RTCRemoteInboundRtpStreamStats for both audio and video. This implements the essentials of RTCRemoteInboundRtpStreamStats. This includes: - ssrc - transportId - codecId - packetsLost - jitter - localId - roundTripTime https://w3c.github.io/webrtc-stats/#remoteinboundrtpstats-dict* The following members are not implemented because they require more work... - From RTCReceivedRtpStreamStats: packetsReceived, packetsDiscarded, packetsRepaired, burstPacketsLost, burstPacketsDiscarded, burstLossCount, burstDiscardCount, burstLossRate, burstDiscardRate, gapLossRate and gapDiscardRate. - From RTCRemoteInboundRtpStreamStats: fractionLost. Bug: webrtc:10455, webrtc:10456 Change-Id: If2ab0da7105d8c93bba58e14aa93bd22ffe57f1d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/138067 Commit-Queue: Henrik Boström <hbos@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28073}
2019-05-27 13:40:25 +02:00
// clang-format on
RTCRemoteInboundRtpStreamStats::RTCRemoteInboundRtpStreamStats(
api: use std::string in stats constructor instead of const reference or rvalues. This follows the style guide: https://google.github.io/styleguide/cppguide.html#Rvalue_references BUG=webrtc:14807 Change-Id: I936b99146520815ae8105806409d46565fa83546 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/289985 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Henrik Boström <hbos@webrtc.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Cr-Commit-Position: refs/heads/main@{#38996}
2023-01-02 13:20:45 +01:00
std::string id,
stats: use Timestamp instead of uint64_t making it clear what unit is being used. BUG=webrtc:13756 Change-Id: I6354d35a8e02bb93a905ccf32cb0b294b4813e41 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/289460 Commit-Queue: Philipp Hancke <phancke@microsoft.com> Reviewed-by: Henrik Boström <hbos@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39008}
2023-01-04 15:17:42 +01:00
Timestamp timestamp)
Revert "[Stats] Move metric names to Attribute, constructed via AttributeInit." This reverts commit 84c48ae7513bad9c9ca19271569cd0431e780c32. Reason for revert: Breaks downstream project Original change's description: > [Stats] Move metric names to Attribute, constructed via AttributeInit. > > As of this CL, Attribute no longer implements RTCStatsMemberInterface > and a member no longer owns knowing its own name. The attribute knows > the name because we pass it down at construction time. > > To achieve this, the WEBRTC_RTCSTATS_IMPL() macro is updated to take > AttributeInits instead of raw member pointers, i.e. (name, ptr) pairs. > > By constructing RTCStatsMember<T> without a name parameter, it does the > same thing as the absl::optional<T> constructor. So RTCStatsMember<T>'s > days are numbered! > > Bug: webrtc:15164 > Change-Id: I560c0134bae1c2d7218426a1576425ecc1b677a7 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334203 > Commit-Queue: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Evan Shrubsole <eshr@google.com> > Cr-Commit-Position: refs/heads/main@{#41540} Bug: webrtc:15164 Change-Id: I9f416838153b26d4560ae98c37fb18a803d0295d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334901 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41550}
2024-01-17 16:59:52 +00:00
: RTCReceivedRtpStreamStats(std::move(id), timestamp),
local_id("localId"),
round_trip_time("roundTripTime"),
fraction_lost("fractionLost"),
total_round_trip_time("totalRoundTripTime"),
round_trip_time_measurements("roundTripTimeMeasurements") {}
RTCRemoteInboundRtpStreamStats::RTCRemoteInboundRtpStreamStats(
const RTCRemoteInboundRtpStreamStats& other) = default;
Implement RTCRemoteInboundRtpStreamStats for both audio and video. This implements the essentials of RTCRemoteInboundRtpStreamStats. This includes: - ssrc - transportId - codecId - packetsLost - jitter - localId - roundTripTime https://w3c.github.io/webrtc-stats/#remoteinboundrtpstats-dict* The following members are not implemented because they require more work... - From RTCReceivedRtpStreamStats: packetsReceived, packetsDiscarded, packetsRepaired, burstPacketsLost, burstPacketsDiscarded, burstLossCount, burstDiscardCount, burstLossRate, burstDiscardRate, gapLossRate and gapDiscardRate. - From RTCRemoteInboundRtpStreamStats: fractionLost. Bug: webrtc:10455, webrtc:10456 Change-Id: If2ab0da7105d8c93bba58e14aa93bd22ffe57f1d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/138067 Commit-Queue: Henrik Boström <hbos@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28073}
2019-05-27 13:40:25 +02:00
RTCRemoteInboundRtpStreamStats::~RTCRemoteInboundRtpStreamStats() {}
Add `RTCRemoteOutboundRtpStreamStats` for audio streams Changes: - adding the `RTCRemoteOutboundRtpStreamStats` dictionary (see [1]) - collection of remote outbound stats (only for audio streams) - adding `remote_id` to the inbound stats and set with the ID of the corresponding remote outbound stats only if the latter are available - unit tests [1] https://www.w3.org/TR/webrtc-stats/#dom-rtcremoteoutboundrtpstreamstats Tested: verified from chrome://webrtc-internals during an appr.tc call Bug: webrtc:12529 Change-Id: Ide91dc04a3c387ba439618a9c6b64a95994a1940 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/211042 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Reviewed-by: Sam Zackrisson <saza@webrtc.org> Reviewed-by: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33545}
2021-03-23 17:23:04 +01:00
// clang-format off
WEBRTC_RTCSTATS_IMPL(
RTCRemoteOutboundRtpStreamStats, RTCSentRtpStreamStats,
"remote-outbound-rtp",
Revert "[Stats] Move metric names to Attribute, constructed via AttributeInit." This reverts commit 84c48ae7513bad9c9ca19271569cd0431e780c32. Reason for revert: Breaks downstream project Original change's description: > [Stats] Move metric names to Attribute, constructed via AttributeInit. > > As of this CL, Attribute no longer implements RTCStatsMemberInterface > and a member no longer owns knowing its own name. The attribute knows > the name because we pass it down at construction time. > > To achieve this, the WEBRTC_RTCSTATS_IMPL() macro is updated to take > AttributeInits instead of raw member pointers, i.e. (name, ptr) pairs. > > By constructing RTCStatsMember<T> without a name parameter, it does the > same thing as the absl::optional<T> constructor. So RTCStatsMember<T>'s > days are numbered! > > Bug: webrtc:15164 > Change-Id: I560c0134bae1c2d7218426a1576425ecc1b677a7 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334203 > Commit-Queue: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Evan Shrubsole <eshr@google.com> > Cr-Commit-Position: refs/heads/main@{#41540} Bug: webrtc:15164 Change-Id: I9f416838153b26d4560ae98c37fb18a803d0295d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334901 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41550}
2024-01-17 16:59:52 +00:00
&local_id,
&remote_timestamp,
&reports_sent,
&round_trip_time,
&round_trip_time_measurements,
&total_round_trip_time)
Add `RTCRemoteOutboundRtpStreamStats` for audio streams Changes: - adding the `RTCRemoteOutboundRtpStreamStats` dictionary (see [1]) - collection of remote outbound stats (only for audio streams) - adding `remote_id` to the inbound stats and set with the ID of the corresponding remote outbound stats only if the latter are available - unit tests [1] https://www.w3.org/TR/webrtc-stats/#dom-rtcremoteoutboundrtpstreamstats Tested: verified from chrome://webrtc-internals during an appr.tc call Bug: webrtc:12529 Change-Id: Ide91dc04a3c387ba439618a9c6b64a95994a1940 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/211042 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Reviewed-by: Sam Zackrisson <saza@webrtc.org> Reviewed-by: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33545}
2021-03-23 17:23:04 +01:00
// clang-format on
RTCRemoteOutboundRtpStreamStats::RTCRemoteOutboundRtpStreamStats(
api: use std::string in stats constructor instead of const reference or rvalues. This follows the style guide: https://google.github.io/styleguide/cppguide.html#Rvalue_references BUG=webrtc:14807 Change-Id: I936b99146520815ae8105806409d46565fa83546 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/289985 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Henrik Boström <hbos@webrtc.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Cr-Commit-Position: refs/heads/main@{#38996}
2023-01-02 13:20:45 +01:00
std::string id,
stats: use Timestamp instead of uint64_t making it clear what unit is being used. BUG=webrtc:13756 Change-Id: I6354d35a8e02bb93a905ccf32cb0b294b4813e41 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/289460 Commit-Queue: Philipp Hancke <phancke@microsoft.com> Reviewed-by: Henrik Boström <hbos@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39008}
2023-01-04 15:17:42 +01:00
Timestamp timestamp)
Revert "[Stats] Move metric names to Attribute, constructed via AttributeInit." This reverts commit 84c48ae7513bad9c9ca19271569cd0431e780c32. Reason for revert: Breaks downstream project Original change's description: > [Stats] Move metric names to Attribute, constructed via AttributeInit. > > As of this CL, Attribute no longer implements RTCStatsMemberInterface > and a member no longer owns knowing its own name. The attribute knows > the name because we pass it down at construction time. > > To achieve this, the WEBRTC_RTCSTATS_IMPL() macro is updated to take > AttributeInits instead of raw member pointers, i.e. (name, ptr) pairs. > > By constructing RTCStatsMember<T> without a name parameter, it does the > same thing as the absl::optional<T> constructor. So RTCStatsMember<T>'s > days are numbered! > > Bug: webrtc:15164 > Change-Id: I560c0134bae1c2d7218426a1576425ecc1b677a7 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334203 > Commit-Queue: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Evan Shrubsole <eshr@google.com> > Cr-Commit-Position: refs/heads/main@{#41540} Bug: webrtc:15164 Change-Id: I9f416838153b26d4560ae98c37fb18a803d0295d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334901 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41550}
2024-01-17 16:59:52 +00:00
: RTCSentRtpStreamStats(std::move(id), timestamp),
local_id("localId"),
remote_timestamp("remoteTimestamp"),
reports_sent("reportsSent"),
round_trip_time("roundTripTime"),
round_trip_time_measurements("roundTripTimeMeasurements"),
total_round_trip_time("totalRoundTripTime") {}
RTCRemoteOutboundRtpStreamStats::RTCRemoteOutboundRtpStreamStats(
const RTCRemoteOutboundRtpStreamStats& other) = default;
Add `RTCRemoteOutboundRtpStreamStats` for audio streams Changes: - adding the `RTCRemoteOutboundRtpStreamStats` dictionary (see [1]) - collection of remote outbound stats (only for audio streams) - adding `remote_id` to the inbound stats and set with the ID of the corresponding remote outbound stats only if the latter are available - unit tests [1] https://www.w3.org/TR/webrtc-stats/#dom-rtcremoteoutboundrtpstreamstats Tested: verified from chrome://webrtc-internals during an appr.tc call Bug: webrtc:12529 Change-Id: Ide91dc04a3c387ba439618a9c6b64a95994a1940 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/211042 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Reviewed-by: Sam Zackrisson <saza@webrtc.org> Reviewed-by: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33545}
2021-03-23 17:23:04 +01:00
RTCRemoteOutboundRtpStreamStats::~RTCRemoteOutboundRtpStreamStats() {}
Implement RTCMediaSourceStats and friends in standard getStats(). This implements RTCAudioSourceStats and RTCVideoSourceStats, both inheriting from abstract dictionary RTCMediaSourceStats: https://w3c.github.io/webrtc-stats/#dom-rtcmediasourcestats All members are implemented except for the total "frames" counter: - trackIdentifier - kind - width - height - framesPerSecond This means to make googFrameWidthInput, googFrameHeightInput and googFrameRateInput obsolete. Implemented using the same code path as the goog stats, there are some minor bugs that should be fixed in the future, but not this CL: 1. We create media-source objects on a per-track attachment basis. If the same track is attached multiple times this results in multiple media-source objects, but the spec says it should be on a per-source basis. 2. framesPerSecond is only calculated after connecting (when we have a sender with SSRC), but if collected on a per-source basis the source should be able to tell us the FPS whether or not we are sending it. Bug: webrtc:10453 Change-Id: I23705a79f15075dca2536275934af1904a7f0d39 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/137804 Commit-Queue: Henrik Boström <hbos@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28028}
2019-05-22 15:49:42 +02:00
// clang-format off
WEBRTC_RTCSTATS_IMPL(RTCMediaSourceStats, RTCStats, "parent-media-source",
Revert "[Stats] Move metric names to Attribute, constructed via AttributeInit." This reverts commit 84c48ae7513bad9c9ca19271569cd0431e780c32. Reason for revert: Breaks downstream project Original change's description: > [Stats] Move metric names to Attribute, constructed via AttributeInit. > > As of this CL, Attribute no longer implements RTCStatsMemberInterface > and a member no longer owns knowing its own name. The attribute knows > the name because we pass it down at construction time. > > To achieve this, the WEBRTC_RTCSTATS_IMPL() macro is updated to take > AttributeInits instead of raw member pointers, i.e. (name, ptr) pairs. > > By constructing RTCStatsMember<T> without a name parameter, it does the > same thing as the absl::optional<T> constructor. So RTCStatsMember<T>'s > days are numbered! > > Bug: webrtc:15164 > Change-Id: I560c0134bae1c2d7218426a1576425ecc1b677a7 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334203 > Commit-Queue: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Evan Shrubsole <eshr@google.com> > Cr-Commit-Position: refs/heads/main@{#41540} Bug: webrtc:15164 Change-Id: I9f416838153b26d4560ae98c37fb18a803d0295d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334901 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41550}
2024-01-17 16:59:52 +00:00
&track_identifier,
&kind)
Implement RTCMediaSourceStats and friends in standard getStats(). This implements RTCAudioSourceStats and RTCVideoSourceStats, both inheriting from abstract dictionary RTCMediaSourceStats: https://w3c.github.io/webrtc-stats/#dom-rtcmediasourcestats All members are implemented except for the total "frames" counter: - trackIdentifier - kind - width - height - framesPerSecond This means to make googFrameWidthInput, googFrameHeightInput and googFrameRateInput obsolete. Implemented using the same code path as the goog stats, there are some minor bugs that should be fixed in the future, but not this CL: 1. We create media-source objects on a per-track attachment basis. If the same track is attached multiple times this results in multiple media-source objects, but the spec says it should be on a per-source basis. 2. framesPerSecond is only calculated after connecting (when we have a sender with SSRC), but if collected on a per-source basis the source should be able to tell us the FPS whether or not we are sending it. Bug: webrtc:10453 Change-Id: I23705a79f15075dca2536275934af1904a7f0d39 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/137804 Commit-Queue: Henrik Boström <hbos@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28028}
2019-05-22 15:49:42 +02:00
// clang-format on
stats: use Timestamp instead of uint64_t making it clear what unit is being used. BUG=webrtc:13756 Change-Id: I6354d35a8e02bb93a905ccf32cb0b294b4813e41 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/289460 Commit-Queue: Philipp Hancke <phancke@microsoft.com> Reviewed-by: Henrik Boström <hbos@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39008}
2023-01-04 15:17:42 +01:00
RTCMediaSourceStats::RTCMediaSourceStats(std::string id, Timestamp timestamp)
Revert "[Stats] Move metric names to Attribute, constructed via AttributeInit." This reverts commit 84c48ae7513bad9c9ca19271569cd0431e780c32. Reason for revert: Breaks downstream project Original change's description: > [Stats] Move metric names to Attribute, constructed via AttributeInit. > > As of this CL, Attribute no longer implements RTCStatsMemberInterface > and a member no longer owns knowing its own name. The attribute knows > the name because we pass it down at construction time. > > To achieve this, the WEBRTC_RTCSTATS_IMPL() macro is updated to take > AttributeInits instead of raw member pointers, i.e. (name, ptr) pairs. > > By constructing RTCStatsMember<T> without a name parameter, it does the > same thing as the absl::optional<T> constructor. So RTCStatsMember<T>'s > days are numbered! > > Bug: webrtc:15164 > Change-Id: I560c0134bae1c2d7218426a1576425ecc1b677a7 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334203 > Commit-Queue: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Evan Shrubsole <eshr@google.com> > Cr-Commit-Position: refs/heads/main@{#41540} Bug: webrtc:15164 Change-Id: I9f416838153b26d4560ae98c37fb18a803d0295d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334901 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41550}
2024-01-17 16:59:52 +00:00
: RTCStats(std::move(id), timestamp),
track_identifier("trackIdentifier"),
kind("kind") {}
RTCMediaSourceStats::RTCMediaSourceStats(const RTCMediaSourceStats& other) =
default;
Implement RTCMediaSourceStats and friends in standard getStats(). This implements RTCAudioSourceStats and RTCVideoSourceStats, both inheriting from abstract dictionary RTCMediaSourceStats: https://w3c.github.io/webrtc-stats/#dom-rtcmediasourcestats All members are implemented except for the total "frames" counter: - trackIdentifier - kind - width - height - framesPerSecond This means to make googFrameWidthInput, googFrameHeightInput and googFrameRateInput obsolete. Implemented using the same code path as the goog stats, there are some minor bugs that should be fixed in the future, but not this CL: 1. We create media-source objects on a per-track attachment basis. If the same track is attached multiple times this results in multiple media-source objects, but the spec says it should be on a per-source basis. 2. framesPerSecond is only calculated after connecting (when we have a sender with SSRC), but if collected on a per-source basis the source should be able to tell us the FPS whether or not we are sending it. Bug: webrtc:10453 Change-Id: I23705a79f15075dca2536275934af1904a7f0d39 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/137804 Commit-Queue: Henrik Boström <hbos@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28028}
2019-05-22 15:49:42 +02:00
RTCMediaSourceStats::~RTCMediaSourceStats() {}
// clang-format off
[getStats] Implement "media-source" audio levels, fixing Chrome bug. Implements RTCAudioSourceStats members: - audioLevel - totalAudioEnergy - totalSamplesDuration In this CL description these are collectively referred to as the audio levels. The audio levels are removed from sending "track" stats (in Chrome, these are now reported as undefined instead of 0). Background: For sending tracks, audio levels were always reported as 0 in Chrome (https://crbug.com/736403), while audio levels were correctly reported for receiving tracks. This problem affected the standard getStats() but not the legacy getStats(), blocking some people from migrating. This was likely not a problem in native third_party/webrtc code because the delivery of audio frames from device to send-stream uses a different code path outside of chromium. A recent PR (https://github.com/w3c/webrtc-stats/pull/451) moved the send-side audio levels to the RTCAudioSourceStats, while keeping the receive-side audio levels on the "track" stats. This allows an implementation to report the audio levels even if samples are not sent onto the network (such as if an ICE connection has not been established yet), reflecting some of the current implementation. Changes: 1. Audio levels are added to RTCAudioSourceStats. Send-side audio "track" stats are left undefined. Receive-side audio "track" stats are not changed in this CL and continue to work. 2. Audio level computation is moved from the AudioState and AudioTransportImpl to the AudioSendStream. This is because a) the AudioTransportImpl::RecordedDataIsAvailable() code path is not exercised in chromium, and b) audio levels should, per-spec, not be calculated on a per-call basis, for which the AudioState is defined. 3. The audio level computation is now performed in AudioSendStream::SendAudioData(), a code path used by both native and chromium code. 4. Comments are added to document behavior of existing code, such as AudioLevel and AudioSendStream::SendAudioData(). Note: In this CL, just like before this CL, audio level is only calculated after an AudioSendStream has been created. This means that before an O/A negotiation, audio levels are unavailable. According to spec, if we have an audio source, we should have audio levels. An immediate solution to this would have been to calculate the audio level at pc/rtp_sender.cc. The problem is that the LocalAudioSinkAdapter::OnData() code path, while exercised in chromium, is not exercised in native code. The issue of calculating audio levels on a per-source bases rather than on a per-send stream basis is left to https://crbug.com/webrtc/10771, an existing "media-source" bug. This CL can be verified manually in Chrome at: https://codepen.io/anon/pen/vqRGyq Bug: chromium:736403, webrtc:10771 Change-Id: I8036cd9984f3b187c3177470a8c0d6670a201a5a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/143789 Reviewed-by: Oskar Sundbom <ossu@webrtc.org> Reviewed-by: Stefan Holmer <stefan@webrtc.org> Commit-Queue: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28480}
2019-07-03 17:11:10 +02:00
WEBRTC_RTCSTATS_IMPL(RTCAudioSourceStats, RTCMediaSourceStats, "media-source",
Revert "[Stats] Move metric names to Attribute, constructed via AttributeInit." This reverts commit 84c48ae7513bad9c9ca19271569cd0431e780c32. Reason for revert: Breaks downstream project Original change's description: > [Stats] Move metric names to Attribute, constructed via AttributeInit. > > As of this CL, Attribute no longer implements RTCStatsMemberInterface > and a member no longer owns knowing its own name. The attribute knows > the name because we pass it down at construction time. > > To achieve this, the WEBRTC_RTCSTATS_IMPL() macro is updated to take > AttributeInits instead of raw member pointers, i.e. (name, ptr) pairs. > > By constructing RTCStatsMember<T> without a name parameter, it does the > same thing as the absl::optional<T> constructor. So RTCStatsMember<T>'s > days are numbered! > > Bug: webrtc:15164 > Change-Id: I560c0134bae1c2d7218426a1576425ecc1b677a7 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334203 > Commit-Queue: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Evan Shrubsole <eshr@google.com> > Cr-Commit-Position: refs/heads/main@{#41540} Bug: webrtc:15164 Change-Id: I9f416838153b26d4560ae98c37fb18a803d0295d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334901 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41550}
2024-01-17 16:59:52 +00:00
&audio_level,
&total_audio_energy,
&total_samples_duration,
&echo_return_loss,
&echo_return_loss_enhancement)
Implement RTCMediaSourceStats and friends in standard getStats(). This implements RTCAudioSourceStats and RTCVideoSourceStats, both inheriting from abstract dictionary RTCMediaSourceStats: https://w3c.github.io/webrtc-stats/#dom-rtcmediasourcestats All members are implemented except for the total "frames" counter: - trackIdentifier - kind - width - height - framesPerSecond This means to make googFrameWidthInput, googFrameHeightInput and googFrameRateInput obsolete. Implemented using the same code path as the goog stats, there are some minor bugs that should be fixed in the future, but not this CL: 1. We create media-source objects on a per-track attachment basis. If the same track is attached multiple times this results in multiple media-source objects, but the spec says it should be on a per-source basis. 2. framesPerSecond is only calculated after connecting (when we have a sender with SSRC), but if collected on a per-source basis the source should be able to tell us the FPS whether or not we are sending it. Bug: webrtc:10453 Change-Id: I23705a79f15075dca2536275934af1904a7f0d39 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/137804 Commit-Queue: Henrik Boström <hbos@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28028}
2019-05-22 15:49:42 +02:00
// clang-format on
stats: use Timestamp instead of uint64_t making it clear what unit is being used. BUG=webrtc:13756 Change-Id: I6354d35a8e02bb93a905ccf32cb0b294b4813e41 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/289460 Commit-Queue: Philipp Hancke <phancke@microsoft.com> Reviewed-by: Henrik Boström <hbos@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39008}
2023-01-04 15:17:42 +01:00
RTCAudioSourceStats::RTCAudioSourceStats(std::string id, Timestamp timestamp)
Revert "[Stats] Move metric names to Attribute, constructed via AttributeInit." This reverts commit 84c48ae7513bad9c9ca19271569cd0431e780c32. Reason for revert: Breaks downstream project Original change's description: > [Stats] Move metric names to Attribute, constructed via AttributeInit. > > As of this CL, Attribute no longer implements RTCStatsMemberInterface > and a member no longer owns knowing its own name. The attribute knows > the name because we pass it down at construction time. > > To achieve this, the WEBRTC_RTCSTATS_IMPL() macro is updated to take > AttributeInits instead of raw member pointers, i.e. (name, ptr) pairs. > > By constructing RTCStatsMember<T> without a name parameter, it does the > same thing as the absl::optional<T> constructor. So RTCStatsMember<T>'s > days are numbered! > > Bug: webrtc:15164 > Change-Id: I560c0134bae1c2d7218426a1576425ecc1b677a7 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334203 > Commit-Queue: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Evan Shrubsole <eshr@google.com> > Cr-Commit-Position: refs/heads/main@{#41540} Bug: webrtc:15164 Change-Id: I9f416838153b26d4560ae98c37fb18a803d0295d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334901 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41550}
2024-01-17 16:59:52 +00:00
: RTCMediaSourceStats(std::move(id), timestamp),
audio_level("audioLevel"),
total_audio_energy("totalAudioEnergy"),
total_samples_duration("totalSamplesDuration"),
echo_return_loss("echoReturnLoss"),
echo_return_loss_enhancement("echoReturnLossEnhancement") {}
RTCAudioSourceStats::RTCAudioSourceStats(const RTCAudioSourceStats& other) =
default;
Implement RTCMediaSourceStats and friends in standard getStats(). This implements RTCAudioSourceStats and RTCVideoSourceStats, both inheriting from abstract dictionary RTCMediaSourceStats: https://w3c.github.io/webrtc-stats/#dom-rtcmediasourcestats All members are implemented except for the total "frames" counter: - trackIdentifier - kind - width - height - framesPerSecond This means to make googFrameWidthInput, googFrameHeightInput and googFrameRateInput obsolete. Implemented using the same code path as the goog stats, there are some minor bugs that should be fixed in the future, but not this CL: 1. We create media-source objects on a per-track attachment basis. If the same track is attached multiple times this results in multiple media-source objects, but the spec says it should be on a per-source basis. 2. framesPerSecond is only calculated after connecting (when we have a sender with SSRC), but if collected on a per-source basis the source should be able to tell us the FPS whether or not we are sending it. Bug: webrtc:10453 Change-Id: I23705a79f15075dca2536275934af1904a7f0d39 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/137804 Commit-Queue: Henrik Boström <hbos@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28028}
2019-05-22 15:49:42 +02:00
RTCAudioSourceStats::~RTCAudioSourceStats() {}
// clang-format off
WEBRTC_RTCSTATS_IMPL(RTCVideoSourceStats, RTCMediaSourceStats, "media-source",
Revert "[Stats] Move metric names to Attribute, constructed via AttributeInit." This reverts commit 84c48ae7513bad9c9ca19271569cd0431e780c32. Reason for revert: Breaks downstream project Original change's description: > [Stats] Move metric names to Attribute, constructed via AttributeInit. > > As of this CL, Attribute no longer implements RTCStatsMemberInterface > and a member no longer owns knowing its own name. The attribute knows > the name because we pass it down at construction time. > > To achieve this, the WEBRTC_RTCSTATS_IMPL() macro is updated to take > AttributeInits instead of raw member pointers, i.e. (name, ptr) pairs. > > By constructing RTCStatsMember<T> without a name parameter, it does the > same thing as the absl::optional<T> constructor. So RTCStatsMember<T>'s > days are numbered! > > Bug: webrtc:15164 > Change-Id: I560c0134bae1c2d7218426a1576425ecc1b677a7 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334203 > Commit-Queue: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Evan Shrubsole <eshr@google.com> > Cr-Commit-Position: refs/heads/main@{#41540} Bug: webrtc:15164 Change-Id: I9f416838153b26d4560ae98c37fb18a803d0295d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334901 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41550}
2024-01-17 16:59:52 +00:00
&width,
&height,
&frames,
&frames_per_second)
Implement RTCMediaSourceStats and friends in standard getStats(). This implements RTCAudioSourceStats and RTCVideoSourceStats, both inheriting from abstract dictionary RTCMediaSourceStats: https://w3c.github.io/webrtc-stats/#dom-rtcmediasourcestats All members are implemented except for the total "frames" counter: - trackIdentifier - kind - width - height - framesPerSecond This means to make googFrameWidthInput, googFrameHeightInput and googFrameRateInput obsolete. Implemented using the same code path as the goog stats, there are some minor bugs that should be fixed in the future, but not this CL: 1. We create media-source objects on a per-track attachment basis. If the same track is attached multiple times this results in multiple media-source objects, but the spec says it should be on a per-source basis. 2. framesPerSecond is only calculated after connecting (when we have a sender with SSRC), but if collected on a per-source basis the source should be able to tell us the FPS whether or not we are sending it. Bug: webrtc:10453 Change-Id: I23705a79f15075dca2536275934af1904a7f0d39 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/137804 Commit-Queue: Henrik Boström <hbos@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28028}
2019-05-22 15:49:42 +02:00
// clang-format on
stats: use Timestamp instead of uint64_t making it clear what unit is being used. BUG=webrtc:13756 Change-Id: I6354d35a8e02bb93a905ccf32cb0b294b4813e41 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/289460 Commit-Queue: Philipp Hancke <phancke@microsoft.com> Reviewed-by: Henrik Boström <hbos@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39008}
2023-01-04 15:17:42 +01:00
RTCVideoSourceStats::RTCVideoSourceStats(std::string id, Timestamp timestamp)
Revert "[Stats] Move metric names to Attribute, constructed via AttributeInit." This reverts commit 84c48ae7513bad9c9ca19271569cd0431e780c32. Reason for revert: Breaks downstream project Original change's description: > [Stats] Move metric names to Attribute, constructed via AttributeInit. > > As of this CL, Attribute no longer implements RTCStatsMemberInterface > and a member no longer owns knowing its own name. The attribute knows > the name because we pass it down at construction time. > > To achieve this, the WEBRTC_RTCSTATS_IMPL() macro is updated to take > AttributeInits instead of raw member pointers, i.e. (name, ptr) pairs. > > By constructing RTCStatsMember<T> without a name parameter, it does the > same thing as the absl::optional<T> constructor. So RTCStatsMember<T>'s > days are numbered! > > Bug: webrtc:15164 > Change-Id: I560c0134bae1c2d7218426a1576425ecc1b677a7 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334203 > Commit-Queue: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Evan Shrubsole <eshr@google.com> > Cr-Commit-Position: refs/heads/main@{#41540} Bug: webrtc:15164 Change-Id: I9f416838153b26d4560ae98c37fb18a803d0295d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334901 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41550}
2024-01-17 16:59:52 +00:00
: RTCMediaSourceStats(std::move(id), timestamp),
width("width"),
height("height"),
frames("frames"),
frames_per_second("framesPerSecond") {}
RTCVideoSourceStats::RTCVideoSourceStats(const RTCVideoSourceStats& other) =
default;
Implement RTCMediaSourceStats and friends in standard getStats(). This implements RTCAudioSourceStats and RTCVideoSourceStats, both inheriting from abstract dictionary RTCMediaSourceStats: https://w3c.github.io/webrtc-stats/#dom-rtcmediasourcestats All members are implemented except for the total "frames" counter: - trackIdentifier - kind - width - height - framesPerSecond This means to make googFrameWidthInput, googFrameHeightInput and googFrameRateInput obsolete. Implemented using the same code path as the goog stats, there are some minor bugs that should be fixed in the future, but not this CL: 1. We create media-source objects on a per-track attachment basis. If the same track is attached multiple times this results in multiple media-source objects, but the spec says it should be on a per-source basis. 2. framesPerSecond is only calculated after connecting (when we have a sender with SSRC), but if collected on a per-source basis the source should be able to tell us the FPS whether or not we are sending it. Bug: webrtc:10453 Change-Id: I23705a79f15075dca2536275934af1904a7f0d39 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/137804 Commit-Queue: Henrik Boström <hbos@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28028}
2019-05-22 15:49:42 +02:00
RTCVideoSourceStats::~RTCVideoSourceStats() {}
Turn off clang-format for WEBRTC_RTCSTATS_IMPL macros. Clang format wants to put all parameters to WEBRTC_RTCSTATS_IMPL on their own line, but we prefer to keep the header on the first line and put the variable arguments (the stats) on their own lines. Bug: None Change-Id: Ic53104b46fb3c91c134d524027a150ba10055ad5 Reviewed-on: https://chromium-review.googlesource.com/621409 Reviewed-by: Henrik Boström <hbos@webrtc.org> Commit-Queue: Steve Anton <steveanton@webrtc.org> Cr-Commit-Position: refs/heads/master@{#19505}
2017-08-18 09:40:25 -07:00
// clang-format off
RTCTransportStats[1] added, supporting all members. Address TODO in rtcstatscollector_unittest.cc before closing 653873. [1] https://w3c.github.io/webrtc-stats/#transportstats-dict* BUG=chromium:653873, chromium:633550, chromium:627816 Review-Url: https://codereview.webrtc.org/2408363002 Cr-Commit-Position: refs/heads/master@{#14740}
2016-10-24 04:00:05 -07:00
WEBRTC_RTCSTATS_IMPL(RTCTransportStats, RTCStats, "transport",
Revert "[Stats] Move metric names to Attribute, constructed via AttributeInit." This reverts commit 84c48ae7513bad9c9ca19271569cd0431e780c32. Reason for revert: Breaks downstream project Original change's description: > [Stats] Move metric names to Attribute, constructed via AttributeInit. > > As of this CL, Attribute no longer implements RTCStatsMemberInterface > and a member no longer owns knowing its own name. The attribute knows > the name because we pass it down at construction time. > > To achieve this, the WEBRTC_RTCSTATS_IMPL() macro is updated to take > AttributeInits instead of raw member pointers, i.e. (name, ptr) pairs. > > By constructing RTCStatsMember<T> without a name parameter, it does the > same thing as the absl::optional<T> constructor. So RTCStatsMember<T>'s > days are numbered! > > Bug: webrtc:15164 > Change-Id: I560c0134bae1c2d7218426a1576425ecc1b677a7 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334203 > Commit-Queue: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Evan Shrubsole <eshr@google.com> > Cr-Commit-Position: refs/heads/main@{#41540} Bug: webrtc:15164 Change-Id: I9f416838153b26d4560ae98c37fb18a803d0295d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334901 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41550}
2024-01-17 16:59:52 +00:00
&bytes_sent,
&packets_sent,
&bytes_received,
&packets_received,
&rtcp_transport_stats_id,
&dtls_state,
&selected_candidate_pair_id,
&local_certificate_id,
&remote_certificate_id,
&tls_version,
&dtls_cipher,
&dtls_role,
&srtp_cipher,
&selected_candidate_pair_changes,
&ice_role,
&ice_local_username_fragment,
&ice_state)
Turn off clang-format for WEBRTC_RTCSTATS_IMPL macros. Clang format wants to put all parameters to WEBRTC_RTCSTATS_IMPL on their own line, but we prefer to keep the header on the first line and put the variable arguments (the stats) on their own lines. Bug: None Change-Id: Ic53104b46fb3c91c134d524027a150ba10055ad5 Reviewed-on: https://chromium-review.googlesource.com/621409 Reviewed-by: Henrik Boström <hbos@webrtc.org> Commit-Queue: Steve Anton <steveanton@webrtc.org> Cr-Commit-Position: refs/heads/master@{#19505}
2017-08-18 09:40:25 -07:00
// clang-format on
RTCDataChannelStats[1] added, supporting all stats members. Also updates MockDataChannel to also mock id, messages_sent, bytes_sent, messages_received and bytes_received. [1] https://w3c.github.io/webrtc-stats/#dcstats-dict* BUG=chromium:654927, chromium:627816 Review-Url: https://codereview.webrtc.org/2420473002 Cr-Commit-Position: refs/heads/master@{#14670}
2016-10-18 12:48:31 -07:00
stats: use Timestamp instead of uint64_t making it clear what unit is being used. BUG=webrtc:13756 Change-Id: I6354d35a8e02bb93a905ccf32cb0b294b4813e41 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/289460 Commit-Queue: Philipp Hancke <phancke@microsoft.com> Reviewed-by: Henrik Boström <hbos@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39008}
2023-01-04 15:17:42 +01:00
RTCTransportStats::RTCTransportStats(std::string id, Timestamp timestamp)
Revert "[Stats] Move metric names to Attribute, constructed via AttributeInit." This reverts commit 84c48ae7513bad9c9ca19271569cd0431e780c32. Reason for revert: Breaks downstream project Original change's description: > [Stats] Move metric names to Attribute, constructed via AttributeInit. > > As of this CL, Attribute no longer implements RTCStatsMemberInterface > and a member no longer owns knowing its own name. The attribute knows > the name because we pass it down at construction time. > > To achieve this, the WEBRTC_RTCSTATS_IMPL() macro is updated to take > AttributeInits instead of raw member pointers, i.e. (name, ptr) pairs. > > By constructing RTCStatsMember<T> without a name parameter, it does the > same thing as the absl::optional<T> constructor. So RTCStatsMember<T>'s > days are numbered! > > Bug: webrtc:15164 > Change-Id: I560c0134bae1c2d7218426a1576425ecc1b677a7 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334203 > Commit-Queue: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Evan Shrubsole <eshr@google.com> > Cr-Commit-Position: refs/heads/main@{#41540} Bug: webrtc:15164 Change-Id: I9f416838153b26d4560ae98c37fb18a803d0295d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334901 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41550}
2024-01-17 16:59:52 +00:00
: RTCStats(std::move(id), timestamp),
bytes_sent("bytesSent"),
packets_sent("packetsSent"),
bytes_received("bytesReceived"),
packets_received("packetsReceived"),
rtcp_transport_stats_id("rtcpTransportStatsId"),
dtls_state("dtlsState"),
selected_candidate_pair_id("selectedCandidatePairId"),
local_certificate_id("localCertificateId"),
remote_certificate_id("remoteCertificateId"),
tls_version("tlsVersion"),
dtls_cipher("dtlsCipher"),
dtls_role("dtlsRole"),
srtp_cipher("srtpCipher"),
selected_candidate_pair_changes("selectedCandidatePairChanges"),
ice_role("iceRole"),
ice_local_username_fragment("iceLocalUsernameFragment"),
ice_state("iceState") {}
RTCTransportStats::RTCTransportStats(const RTCTransportStats& other) = default;
rtc_stats: Update code to remove chromium style warnings suppression. The warning previously suppressed made it possible to define tings like constructors in the header, and "complex" objects did not need to have an explicit out-of-line copy constructor, destructor, etc. To be able to not suppress this warning, the RTCStats macro was split into a WEBRTC_RTCSTATS_DECL() and WEBRTC_RTCSTATS_IMPL() for .h and .cc respectively. Some copy constructors are also defined. BUG=chromium:627816 Review-Url: https://codereview.webrtc.org/2373503002 Cr-Commit-Position: refs/heads/master@{#14545}
2016-10-06 02:06:10 -07:00
RTCTransportStats[1] added, supporting all members. Address TODO in rtcstatscollector_unittest.cc before closing 653873. [1] https://w3c.github.io/webrtc-stats/#transportstats-dict* BUG=chromium:653873, chromium:633550, chromium:627816 Review-Url: https://codereview.webrtc.org/2408363002 Cr-Commit-Position: refs/heads/master@{#14740}
2016-10-24 04:00:05 -07:00
RTCTransportStats::~RTCTransportStats() {}
rtc_stats: Update code to remove chromium style warnings suppression. The warning previously suppressed made it possible to define tings like constructors in the header, and "complex" objects did not need to have an explicit out-of-line copy constructor, destructor, etc. To be able to not suppress this warning, the RTCStats macro was split into a WEBRTC_RTCSTATS_DECL() and WEBRTC_RTCSTATS_IMPL() for .h and .cc respectively. Some copy constructors are also defined. BUG=chromium:627816 Review-Url: https://codereview.webrtc.org/2373503002 Cr-Commit-Position: refs/heads/master@{#14545}
2016-10-06 02:06:10 -07:00
Add RTCAudioPlayoutStats to GetStats(). This is done by allowing implementations of AudioDeviceModule to implement the GetStats() method. The default implementation returns nullopt, in which case RTCAudioPlayoutStats will not be visible in the stats. Bug: webrtc:14653 Change-Id: I8e4aa6f1b8fcfa47a30f633d28a4013191752e20 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/290563 Reviewed-by: Henrik Boström <hbos@webrtc.org> Commit-Queue: Fredrik Hernqvist <fhernqvist@google.com> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Reviewed-by: Olga Sharonova <olka@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39115}
2023-01-13 16:42:36 +01:00
RTCAudioPlayoutStats::RTCAudioPlayoutStats(const std::string& id,
Timestamp timestamp)
Revert "[Stats] Move metric names to Attribute, constructed via AttributeInit." This reverts commit 84c48ae7513bad9c9ca19271569cd0431e780c32. Reason for revert: Breaks downstream project Original change's description: > [Stats] Move metric names to Attribute, constructed via AttributeInit. > > As of this CL, Attribute no longer implements RTCStatsMemberInterface > and a member no longer owns knowing its own name. The attribute knows > the name because we pass it down at construction time. > > To achieve this, the WEBRTC_RTCSTATS_IMPL() macro is updated to take > AttributeInits instead of raw member pointers, i.e. (name, ptr) pairs. > > By constructing RTCStatsMember<T> without a name parameter, it does the > same thing as the absl::optional<T> constructor. So RTCStatsMember<T>'s > days are numbered! > > Bug: webrtc:15164 > Change-Id: I560c0134bae1c2d7218426a1576425ecc1b677a7 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334203 > Commit-Queue: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Evan Shrubsole <eshr@google.com> > Cr-Commit-Position: refs/heads/main@{#41540} Bug: webrtc:15164 Change-Id: I9f416838153b26d4560ae98c37fb18a803d0295d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334901 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41550}
2024-01-17 16:59:52 +00:00
: RTCStats(std::move(id), timestamp),
kind("kind", "audio"),
synthesized_samples_duration("synthesizedSamplesDuration"),
synthesized_samples_events("synthesizedSamplesEvents"),
total_samples_duration("totalSamplesDuration"),
total_playout_delay("totalPlayoutDelay"),
total_samples_count("totalSamplesCount") {}
RTCAudioPlayoutStats::RTCAudioPlayoutStats(const RTCAudioPlayoutStats& other) =
default;
Add RTCAudioPlayoutStats to GetStats(). This is done by allowing implementations of AudioDeviceModule to implement the GetStats() method. The default implementation returns nullopt, in which case RTCAudioPlayoutStats will not be visible in the stats. Bug: webrtc:14653 Change-Id: I8e4aa6f1b8fcfa47a30f633d28a4013191752e20 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/290563 Reviewed-by: Henrik Boström <hbos@webrtc.org> Commit-Queue: Fredrik Hernqvist <fhernqvist@google.com> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Reviewed-by: Olga Sharonova <olka@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39115}
2023-01-13 16:42:36 +01:00
RTCAudioPlayoutStats::~RTCAudioPlayoutStats() {}
Revert "[Stats] Move metric names to Attribute, constructed via AttributeInit." This reverts commit 84c48ae7513bad9c9ca19271569cd0431e780c32. Reason for revert: Breaks downstream project Original change's description: > [Stats] Move metric names to Attribute, constructed via AttributeInit. > > As of this CL, Attribute no longer implements RTCStatsMemberInterface > and a member no longer owns knowing its own name. The attribute knows > the name because we pass it down at construction time. > > To achieve this, the WEBRTC_RTCSTATS_IMPL() macro is updated to take > AttributeInits instead of raw member pointers, i.e. (name, ptr) pairs. > > By constructing RTCStatsMember<T> without a name parameter, it does the > same thing as the absl::optional<T> constructor. So RTCStatsMember<T>'s > days are numbered! > > Bug: webrtc:15164 > Change-Id: I560c0134bae1c2d7218426a1576425ecc1b677a7 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334203 > Commit-Queue: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Evan Shrubsole <eshr@google.com> > Cr-Commit-Position: refs/heads/main@{#41540} Bug: webrtc:15164 Change-Id: I9f416838153b26d4560ae98c37fb18a803d0295d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334901 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41550}
2024-01-17 16:59:52 +00:00
// clang-format off
WEBRTC_RTCSTATS_IMPL(RTCAudioPlayoutStats, RTCStats, "media-playout",
&kind,
&synthesized_samples_duration,
&synthesized_samples_events,
&total_samples_duration,
&total_playout_delay,
&total_samples_count)
// clang-format on
RTCStatsCollector and RTCPeerConnectionStats added. This is the stats collector for the new stats types, RTCStats[1] and RTCStatsReport[2]. It so far only produces RTCPeerConnectionStats[3] as an example of how it would collect stats. Each RTCStats subclass will get a corresponding RTCStatsCollector::ProduceFooStats(). Stats reports are cached and returned as const references (ref counting). This allows stats to be inspected by multiple observers and across multiple threads. No copies will have to be made when surfacing this to Blink or other places. The current implementation of ProducePeerConnectionStats() only look at existing DataChannels. This might be incorret if data channels can be removed? Will investigate in a follow-up, crbug.com/636818. [1] https://www.w3.org/TR/2016/WD-webrtc-20160531/#idl-def-rtcstats [2] https://www.w3.org/TR/2016/WD-webrtc-20160531/#rtcstatsreport-object [3] https://w3c.github.io/webrtc-stats/archives/20160526/webrtc-stats.html#pcstats-dict* BUG=chromium:627816, chromium:636818 Review-Url: https://codereview.webrtc.org/2242043002 Cr-Commit-Position: refs/heads/master@{#13979}
2016-08-30 14:04:35 -07:00
} // namespace webrtc
Reference in New Issue Copy Permalink