admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
webrtc_m130/modules/audio_processing/agc2/rnn_vad/BUILD.gn

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

335 lines
8.5 KiB
Plaintext
Raw Normal View History

Reland "Reland "AGC2 RNN VAD: initial build targets"" This reverts commit 772d43d4c0acbbc09c3dc280c0ffd17e9569700b. Reason for revert: fix issues and reland revert Original change's description: > Revert "Reland "AGC2 RNN VAD: initial build targets"" > > This reverts commit e0031500bafa4b114adfb2d29444592f1e7b3795. > > Reason for revert: reland automatically landed by mistake > > Original change's description: > > Reland "AGC2 RNN VAD: initial build targets" > > > > This reverts commit a153c00bceb832e697365f52e6a7697fdf210efa. > > > > Reason for revert: fix issues and reland revert > > > > Original change's description: > > > Revert "AGC2 RNN VAD: initial build targets" > > > > > > This reverts commit 8628f5bb7c7f5bd0373567095af08cebe8bb7f8d. > > > > > > Reason for revert: iOS buildbot failing > > > > > > Original change's description: > > > > AGC2 RNN VAD: initial build targets > > > > > > > > rnn_vad_tool is an executable that reads a wav file of any sample rate > > > > compatible with 10 ms frames that are resampled and, when the VAD is > > > > fully landed, will process the resampled frames to compute the VAD > > > > probability. > > > > > > > > To avoid mac, win and ios trybot failures, to_be_removed.h/.cc have > > > > been added and will be removed as soon as the :lib target includes > > > > code that leads to a non-empty static lib file on those platforms. > > > > > > > > Bug: webrtc:9076 > > > > Change-Id: I810c08acfa1adf2029e3baac2adda3045ae5214a > > > > Reviewed-on: https://webrtc-review.googlesource.com/70202 > > > > Reviewed-by: Alex Loiko <aleloi@webrtc.org> > > > > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > > > > Cr-Commit-Position: refs/heads/master@{#22898} > > > > > > TBR=alessiob@webrtc.org,aleloi@webrtc.org > > > > > > Change-Id: Ic6014dde78b0ef371804c52608145ba8acdd9c97 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: webrtc:9076 > > > Reviewed-on: https://webrtc-review.googlesource.com/70144 > > > Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> > > > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > > > Cr-Commit-Position: refs/heads/master@{#22899} > > > > TBR=alessiob@webrtc.org,aleloi@webrtc.org > > > > Change-Id: I55e5a77274684b4cff3c950ca3514cc769d5dc26 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: webrtc:9076 > > Reviewed-on: https://webrtc-review.googlesource.com/70145 > > Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> > > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#22901} > > TBR=alessiob@webrtc.org,aleloi@webrtc.org > > Change-Id: Ia6a837f79ac3f12aa4b0659938454141c69fee61 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:9076 > Reviewed-on: https://webrtc-review.googlesource.com/70520 > Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#22902} TBR=alessiob@webrtc.org,aleloi@webrtc.org Change-Id: If0884ab59d66ac3ba6460dbfe14a083f20493c10 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:9076 Reviewed-on: https://webrtc-review.googlesource.com/70521 Reviewed-by: Minyue Li <minyue@webrtc.org> Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22904}
2018-04-17 15:58:40 +02:00
# Copyright (c) 2018 The WebRTC project authors. All Rights Reserved.
#
# Use of this source code is governed by a BSD-style license
# that can be found in the LICENSE file in the root of the source
# tree. An additional intellectual property rights grant can be found
# in the file PATENTS. All contributing project authors may
# be found in the AUTHORS file in the root of the source tree.
import("../../../../webrtc.gni")
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("rnn_vad") {
Restrict RNN VAD and PFFFT wrapper visibility Bug: webrtc:10482 Change-Id: Idb0f8a87ef881970b51fcfe3296fef4924094c81 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/129860 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27305}
2019-03-27 09:30:14 +01:00
visibility = [ "../*" ]
RNN VAD build file refactoring: split into separate (private) targets First step to only expose the relevant RNN VAD API to AGC2. Bug: webrtc:7494 Change-Id: I7f11f6eebded124c30cabd64963c8e3ccc35e58f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185124 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32185}
2020-09-24 15:50:15 +02:00
sources = [
"features_extraction.cc",
"features_extraction.h",
"rnn.cc",
"rnn.h",
]
RNN VAD optimizations: `VectorMath::DotProduct()` NEON arm64 Results: RNN VAD realtime factor improved from 140x to 195x (+55x) Test device: Pixel 2 XL Benchmark setup: max clock speed forced on all the cores by setting "performance" as scaling governor Bug: webrtc:10480 Change-Id: I3e92f643853ad1fe990db909c578ce78ee826c03 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198842 Reviewed-by: Per Åhgren <peah@webrtc.org> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32888}
2020-12-28 17:57:24 +01:00
defines = []
RNN VAD build file refactoring: split into separate (private) targets First step to only expose the relevant RNN VAD API to AGC2. Bug: webrtc:7494 Change-Id: I7f11f6eebded124c30cabd64963c8e3ccc35e58f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185124 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32185}
2020-09-24 15:50:15 +02:00
if (rtc_build_with_neon && current_cpu != "arm64") {
suppressed_configs += [ "//build/config/compiler:compiler_arm_fpu" ]
cflags = [ "-mfpu=neon" ]
}
deps = [
":rnn_vad_common",
RNN VAD: FC layer isolated into rnn_fc.h/.cc Refactoring done to more easily and cleanly add SIMD optimizations and to remove `FullyConnectedLayer` from the RNN VAD api. Minor improvements (readability, API): - `FullyConnectedLayer` gets the ActivationFunction enum and not a function view anymore - SSE2 optimization moved into `FullyConnectedLayer::ComputeOutputSse2` - layer name added for improved logs Bug: webrtc:10480 Change-Id: Ida4903a67655e19ef0464f378c433c1f6e96dca7 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195444 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Sam Zackrisson <saza@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32766}
2020-12-03 19:33:52 +01:00
":rnn_vad_layers",
RNN VAD build file refactoring: split into separate (private) targets First step to only expose the relevant RNN VAD API to AGC2. Bug: webrtc:7494 Change-Id: I7f11f6eebded124c30cabd64963c8e3ccc35e58f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185124 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32185}
2020-09-24 15:50:15 +02:00
":rnn_vad_lp_residual",
":rnn_vad_pitch",
":rnn_vad_sequence_buffer",
":rnn_vad_spectral_features",
"..:biquad_filter",
AGC2 RNN VAD: safe SIMD optimizations scheme + AVX2 kill switch In preparation for adding AVX2 code, a safe scheme to support different SIMD optimizations is added. Safety features: - AVX2 kill switch to stop using it even if supported by the architecture - struct indicating the available CPU features propagated from AGC2 to each component; in this way - better control over the unit tests - no need to propagate individual kill switches but just set to false features that are turned off Note that (i) this CL does not change the performance of the RNN VAD and (ii) no AVX2 optimization is added yet. Bug: webrtc:10480 Change-Id: I0e61f3311ecd140f38369cf68b6e5954f3dc1f5a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193140 Reviewed-by: Per Åhgren <peah@webrtc.org> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32739}
2020-11-27 16:02:38 +01:00
"..:cpu_features",
RNN VAD build file refactoring: split into separate (private) targets First step to only expose the relevant RNN VAD API to AGC2. Bug: webrtc:7494 Change-Id: I7f11f6eebded124c30cabd64963c8e3ccc35e58f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185124 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32185}
2020-09-24 15:50:15 +02:00
"../../../../api:array_view",
"../../../../rtc_base:checks",
AGC2 RNN VAD size_t -> int Motivation: read "On Unsigned Integers" section in https://google.github.io/styleguide/cppguide.html#Integer_Types Plus, improved readability by getting rid of a bunch of `static_cast<int>`s. Bug: webrtc:10480 Change-Id: I911aa8cd08f5ccde4ee6f23534240d1faa84cdea Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/190880 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32524}
2020-10-29 20:50:13 +01:00
"../../../../rtc_base:safe_compare",
"../../../../rtc_base:safe_conversions",
RNN VAD build file refactoring: split into separate (private) targets First step to only expose the relevant RNN VAD API to AGC2. Bug: webrtc:7494 Change-Id: I7f11f6eebded124c30cabd64963c8e3ccc35e58f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185124 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32185}
2020-09-24 15:50:15 +02:00
"//third_party/rnnoise:rnn_vad",
]
}
rtc_library("rnn_vad_auto_correlation") {
Reland "Reland "AGC2 RNN VAD: initial build targets"" This reverts commit 772d43d4c0acbbc09c3dc280c0ffd17e9569700b. Reason for revert: fix issues and reland revert Original change's description: > Revert "Reland "AGC2 RNN VAD: initial build targets"" > > This reverts commit e0031500bafa4b114adfb2d29444592f1e7b3795. > > Reason for revert: reland automatically landed by mistake > > Original change's description: > > Reland "AGC2 RNN VAD: initial build targets" > > > > This reverts commit a153c00bceb832e697365f52e6a7697fdf210efa. > > > > Reason for revert: fix issues and reland revert > > > > Original change's description: > > > Revert "AGC2 RNN VAD: initial build targets" > > > > > > This reverts commit 8628f5bb7c7f5bd0373567095af08cebe8bb7f8d. > > > > > > Reason for revert: iOS buildbot failing > > > > > > Original change's description: > > > > AGC2 RNN VAD: initial build targets > > > > > > > > rnn_vad_tool is an executable that reads a wav file of any sample rate > > > > compatible with 10 ms frames that are resampled and, when the VAD is > > > > fully landed, will process the resampled frames to compute the VAD > > > > probability. > > > > > > > > To avoid mac, win and ios trybot failures, to_be_removed.h/.cc have > > > > been added and will be removed as soon as the :lib target includes > > > > code that leads to a non-empty static lib file on those platforms. > > > > > > > > Bug: webrtc:9076 > > > > Change-Id: I810c08acfa1adf2029e3baac2adda3045ae5214a > > > > Reviewed-on: https://webrtc-review.googlesource.com/70202 > > > > Reviewed-by: Alex Loiko <aleloi@webrtc.org> > > > > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > > > > Cr-Commit-Position: refs/heads/master@{#22898} > > > > > > TBR=alessiob@webrtc.org,aleloi@webrtc.org > > > > > > Change-Id: Ic6014dde78b0ef371804c52608145ba8acdd9c97 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: webrtc:9076 > > > Reviewed-on: https://webrtc-review.googlesource.com/70144 > > > Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> > > > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > > > Cr-Commit-Position: refs/heads/master@{#22899} > > > > TBR=alessiob@webrtc.org,aleloi@webrtc.org > > > > Change-Id: I55e5a77274684b4cff3c950ca3514cc769d5dc26 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: webrtc:9076 > > Reviewed-on: https://webrtc-review.googlesource.com/70145 > > Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> > > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#22901} > > TBR=alessiob@webrtc.org,aleloi@webrtc.org > > Change-Id: Ia6a837f79ac3f12aa4b0659938454141c69fee61 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:9076 > Reviewed-on: https://webrtc-review.googlesource.com/70520 > Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#22902} TBR=alessiob@webrtc.org,aleloi@webrtc.org Change-Id: If0884ab59d66ac3ba6460dbfe14a083f20493c10 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:9076 Reviewed-on: https://webrtc-review.googlesource.com/70521 Reviewed-by: Minyue Li <minyue@webrtc.org> Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22904}
2018-04-17 15:58:40 +02:00
sources = [
Reland "RNN VAD: Replace Ooura with PFFFT for the pitch auto correlation." This reverts commit d38ce9f82402a995289b87e044125847d12eb658. Reason for revert: land this first, then fix downstream Original change's description: > Revert "RNN VAD: Replace Ooura with PFFFT for the pitch auto correlation." > > This reverts commit 8fcd6537f242ffd74154a62dad410e573e2efc4b. > > Reason for revert: broke internal projects. > > Original change's description: > > RNN VAD: Replace Ooura with PFFFT for the pitch auto correlation. > > > > Bug: webrtc:9577, webrtc:10480 > > Change-Id: I6d58866d48b8eaaa4102551b88d4f55133d1915c > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/130482 > > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > > Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#27387} > > TBR=gustaf@webrtc.org,alessiob@webrtc.org > > Change-Id: Ia05057326ebc277f334b13db0bfec9d4442903c2 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:9577, webrtc:10480 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/130369 > Reviewed-by: Qingsi Wang <qingsi@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#27405} TBR=gustaf@webrtc.org,alessiob@webrtc.org,qingsi@webrtc.org Change-Id: I345f00d798fb67d0f02bf1e89319dac7f0287485 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:9577, webrtc:10480 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/130516 Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27407}
2019-04-02 06:58:45 +00:00
"auto_correlation.cc",
"auto_correlation.h",
RNN VAD build file refactoring: split into separate (private) targets First step to only expose the relevant RNN VAD API to AGC2. Bug: webrtc:7494 Change-Id: I7f11f6eebded124c30cabd64963c8e3ccc35e58f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185124 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32185}
2020-09-24 15:50:15 +02:00
]
deps = [
":rnn_vad_common",
"../../../../api:array_view",
"../../../../rtc_base:checks",
"../../utility:pffft_wrapper",
]
}
AGC2 RNN VAD: safe SIMD optimizations scheme + AVX2 kill switch In preparation for adding AVX2 code, a safe scheme to support different SIMD optimizations is added. Safety features: - AVX2 kill switch to stop using it even if supported by the architecture - struct indicating the available CPU features propagated from AGC2 to each component; in this way - better control over the unit tests - no need to propagate individual kill switches but just set to false features that are turned off Note that (i) this CL does not change the performance of the RNN VAD and (ii) no AVX2 optimization is added yet. Bug: webrtc:10480 Change-Id: I0e61f3311ecd140f38369cf68b6e5954f3dc1f5a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193140 Reviewed-by: Per Åhgren <peah@webrtc.org> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32739}
2020-11-27 16:02:38 +01:00
rtc_source_set("rnn_vad_common") {
RNN VAD build file refactoring: split into separate (private) targets First step to only expose the relevant RNN VAD API to AGC2. Bug: webrtc:7494 Change-Id: I7f11f6eebded124c30cabd64963c8e3ccc35e58f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185124 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32185}
2020-09-24 15:50:15 +02:00
# TODO(alessiob): Make this target visibility private.
visibility = [
":*",
AGC2: VadWithLevel -> VoiceActivityDetectorWrapper 1/2 Internal refactoring of AGC2. This CL is needed in preparation for its child CL to correctly show the upcoming changes in the diff. Bug: webrtc:7494 Change-Id: If7f837e064243d5ffe09e21fc68f489bb00dfdc5 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/234527 Reviewed-by: Hanna Silen <silen@webrtc.org> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/main@{#35170}
2021-10-08 08:15:29 +02:00
"..:vad_wrapper",
RNN VAD build file refactoring: split into separate (private) targets First step to only expose the relevant RNN VAD API to AGC2. Bug: webrtc:7494 Change-Id: I7f11f6eebded124c30cabd64963c8e3ccc35e58f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185124 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32185}
2020-09-24 15:50:15 +02:00
]
AGC2 RNN VAD: safe SIMD optimizations scheme + AVX2 kill switch In preparation for adding AVX2 code, a safe scheme to support different SIMD optimizations is added. Safety features: - AVX2 kill switch to stop using it even if supported by the architecture - struct indicating the available CPU features propagated from AGC2 to each component; in this way - better control over the unit tests - no need to propagate individual kill switches but just set to false features that are turned off Note that (i) this CL does not change the performance of the RNN VAD and (ii) no AVX2 optimization is added yet. Bug: webrtc:10480 Change-Id: I0e61f3311ecd140f38369cf68b6e5954f3dc1f5a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193140 Reviewed-by: Per Åhgren <peah@webrtc.org> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32739}
2020-11-27 16:02:38 +01:00
sources = [ "common.h" ]
RNN VAD build file refactoring: split into separate (private) targets First step to only expose the relevant RNN VAD API to AGC2. Bug: webrtc:7494 Change-Id: I7f11f6eebded124c30cabd64963c8e3ccc35e58f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185124 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32185}
2020-09-24 15:50:15 +02:00
deps = [
"../../../../rtc_base/system:arch",
"../../../../system_wrappers",
]
}
rtc_library("rnn_vad_lp_residual") {
sources = [
AGC2 RNN VAD: Linear Prediction Residual Functions to estimate the inverse filter via LPC and compute the LP residual applying the inverse filter. This CL also includes test utilities, in particular BinaryFileReader, used to read chunks of data and optionally cast them on the fly, and Create*Reader() functions to read resource files available at test time. Bug: webrtc:9076 Change-Id: Ia4793b8ad6a63cb3089ed11ddad89d1aa0b840f6 Reviewed-on: https://webrtc-review.googlesource.com/70244 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Jesus de Vicente Pena <devicentepena@webrtc.org> Reviewed-by: Alex Loiko <aleloi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22946}
2018-04-19 17:56:55 +02:00
"lp_residual.cc",
"lp_residual.h",
RNN VAD build file refactoring: split into separate (private) targets First step to only expose the relevant RNN VAD API to AGC2. Bug: webrtc:7494 Change-Id: I7f11f6eebded124c30cabd64963c8e3ccc35e58f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185124 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32185}
2020-09-24 15:50:15 +02:00
]
deps = [
"../../../../api:array_view",
"../../../../rtc_base:checks",
RNN VAD: LP residual optimized (part 4) This CL removes the circular shift to compute the convolution in `ComputeLpResidual()`, which is now 4x faster (benchmarked with the `RnnVadTest.DISABLED_ComputeLpResidualBenchmark` unit test). Note that the `RnnVadTest.LpResidualPipelineBitExactness` unit test is still passing. Bug: webrtc:10480 Change-Id: Ia7767d9b57378c12c8ff31f58fea03905be5c5de Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/189964 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Per Åhgren <peah@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32491}
2020-10-26 12:09:28 +01:00
"../../../../rtc_base:safe_compare",
RNN VAD build file refactoring: split into separate (private) targets First step to only expose the relevant RNN VAD API to AGC2. Bug: webrtc:7494 Change-Id: I7f11f6eebded124c30cabd64963c8e3ccc35e58f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185124 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32185}
2020-09-24 15:50:15 +02:00
]
}
RNN VAD: FC layer isolated into rnn_fc.h/.cc Refactoring done to more easily and cleanly add SIMD optimizations and to remove `FullyConnectedLayer` from the RNN VAD api. Minor improvements (readability, API): - `FullyConnectedLayer` gets the ActivationFunction enum and not a function view anymore - SSE2 optimization moved into `FullyConnectedLayer::ComputeOutputSse2` - layer name added for improved logs Bug: webrtc:10480 Change-Id: Ida4903a67655e19ef0464f378c433c1f6e96dca7 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195444 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Sam Zackrisson <saza@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32766}
2020-12-03 19:33:52 +01:00
rtc_source_set("rnn_vad_layers") {
sources = [
"rnn_fc.cc",
"rnn_fc.h",
RNN VAD: GRU layer isolated into rnn_gru.h/.cc Refactoring done to more easily and cleanly add SIMD optimizations and to remove `GatedRecurrentLayer` from the RNN VAD api. Bug: webrtc:10480 Change-Id: Ie1dffdd9b19c57c03a0b634f6818c0780456a66c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195445 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32770}
2020-12-03 19:35:05 +01:00
"rnn_gru.cc",
"rnn_gru.h",
RNN VAD: FC layer isolated into rnn_fc.h/.cc Refactoring done to more easily and cleanly add SIMD optimizations and to remove `FullyConnectedLayer` from the RNN VAD api. Minor improvements (readability, API): - `FullyConnectedLayer` gets the ActivationFunction enum and not a function view anymore - SSE2 optimization moved into `FullyConnectedLayer::ComputeOutputSse2` - layer name added for improved logs Bug: webrtc:10480 Change-Id: Ida4903a67655e19ef0464f378c433c1f6e96dca7 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195444 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Sam Zackrisson <saza@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32766}
2020-12-03 19:33:52 +01:00
]
RNN VAD optimizations: `VectorMath::DotProduct()` NEON arm64 Results: RNN VAD realtime factor improved from 140x to 195x (+55x) Test device: Pixel 2 XL Benchmark setup: max clock speed forced on all the cores by setting "performance" as scaling governor Bug: webrtc:10480 Change-Id: I3e92f643853ad1fe990db909c578ce78ee826c03 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198842 Reviewed-by: Per Åhgren <peah@webrtc.org> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32888}
2020-12-28 17:57:24 +01:00
defines = []
if (rtc_build_with_neon && current_cpu != "arm64") {
suppressed_configs += [ "//build/config/compiler:compiler_arm_fpu" ]
cflags = [ "-mfpu=neon" ]
}
RNN VAD: FC layer isolated into rnn_fc.h/.cc Refactoring done to more easily and cleanly add SIMD optimizations and to remove `FullyConnectedLayer` from the RNN VAD api. Minor improvements (readability, API): - `FullyConnectedLayer` gets the ActivationFunction enum and not a function view anymore - SSE2 optimization moved into `FullyConnectedLayer::ComputeOutputSse2` - layer name added for improved logs Bug: webrtc:10480 Change-Id: Ida4903a67655e19ef0464f378c433c1f6e96dca7 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195444 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Sam Zackrisson <saza@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32766}
2020-12-03 19:33:52 +01:00
deps = [
":rnn_vad_common",
RNN VAD: GRU layer optimized Using `VectorMath::DotProduct()` in GatedRecurrentLayer to reuse existing SIMD optimizations. Results: - When SSE2/AVX2 is avilable, the GRU layer takes 40% of the unoptimized code - The realtime factor for the VAD improved as follows - SSE2: from 570x to 630x - AVX2: from 610x to 680x This CL also improved the GRU layer benchmark by (i) benchmarking a GRU layer havibng the same size of that used in the VAD and (ii) by prefetching a long input sequence. Bug: webrtc:10480 Change-Id: I9716b15661e4c6b81592b4cf7c172d90e41b5223 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195545 Reviewed-by: Per Åhgren <peah@webrtc.org> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32803}
2020-12-08 11:26:05 +01:00
":vector_math",
RNN VAD: FC layer isolated into rnn_fc.h/.cc Refactoring done to more easily and cleanly add SIMD optimizations and to remove `FullyConnectedLayer` from the RNN VAD api. Minor improvements (readability, API): - `FullyConnectedLayer` gets the ActivationFunction enum and not a function view anymore - SSE2 optimization moved into `FullyConnectedLayer::ComputeOutputSse2` - layer name added for improved logs Bug: webrtc:10480 Change-Id: Ida4903a67655e19ef0464f378c433c1f6e96dca7 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195444 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Sam Zackrisson <saza@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32766}
2020-12-03 19:33:52 +01:00
"..:cpu_features",
"../../../../api:array_view",
"../../../../api:function_view",
"../../../../rtc_base:checks",
"../../../../rtc_base:safe_conversions",
"//third_party/rnnoise:rnn_vad",
]
RNN VAD: GRU layer optimized Using `VectorMath::DotProduct()` in GatedRecurrentLayer to reuse existing SIMD optimizations. Results: - When SSE2/AVX2 is avilable, the GRU layer takes 40% of the unoptimized code - The realtime factor for the VAD improved as follows - SSE2: from 570x to 630x - AVX2: from 610x to 680x This CL also improved the GRU layer benchmark by (i) benchmarking a GRU layer havibng the same size of that used in the VAD and (ii) by prefetching a long input sequence. Bug: webrtc:10480 Change-Id: I9716b15661e4c6b81592b4cf7c172d90e41b5223 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195545 Reviewed-by: Per Åhgren <peah@webrtc.org> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32803}
2020-12-08 11:26:05 +01:00
if (current_cpu == "x86" || current_cpu == "x64") {
deps += [ ":vector_math_avx2" ]
}
RNN VAD: FC layer isolated into rnn_fc.h/.cc Refactoring done to more easily and cleanly add SIMD optimizations and to remove `FullyConnectedLayer` from the RNN VAD api. Minor improvements (readability, API): - `FullyConnectedLayer` gets the ActivationFunction enum and not a function view anymore - SSE2 optimization moved into `FullyConnectedLayer::ComputeOutputSse2` - layer name added for improved logs Bug: webrtc:10480 Change-Id: Ida4903a67655e19ef0464f378c433c1f6e96dca7 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195444 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Sam Zackrisson <saza@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32766}
2020-12-03 19:33:52 +01:00
absl_deps = [ "//third_party/abseil-cpp/absl/strings" ]
}
RNN VAD: `VectorMath::DotProduct` with AVX2 optimization This CL adds a new library for the RNN VAD that provides (optimized) vector math ops. The scheme is the same of the `VectorMath` class of AEC3 to ensure correct builds across different platforms. Bug: webrtc:10480 Change-Id: I96bcfbf930ca27388ab5f2d52c022ddb73acf8e6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194326 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Per Åhgren <peah@webrtc.org> Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32741}
2020-11-26 14:10:06 +01:00
rtc_source_set("vector_math") {
sources = [ "vector_math.h" ]
deps = [
"..:cpu_features",
"../../../../api:array_view",
"../../../../rtc_base:checks",
RNN VAD: FC and GRU layers implicit conversion to ArrayView Plus a few minor code readability improvements. Bug: webrtc:10480 Change-Id: I590d8e203b1d05959a8c15373841e37abe83237e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195334 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32764}
2020-12-03 16:54:38 +01:00
"../../../../rtc_base:safe_conversions",
RNN VAD: `VectorMath::DotProduct` with AVX2 optimization This CL adds a new library for the RNN VAD that provides (optimized) vector math ops. The scheme is the same of the `VectorMath` class of AEC3 to ensure correct builds across different platforms. Bug: webrtc:10480 Change-Id: I96bcfbf930ca27388ab5f2d52c022ddb73acf8e6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194326 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Per Åhgren <peah@webrtc.org> Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32741}
2020-11-26 14:10:06 +01:00
"../../../../rtc_base/system:arch",
]
}
if (current_cpu == "x86" || current_cpu == "x64") {
rtc_library("vector_math_avx2") {
sources = [ "vector_math_avx2.cc" ]
if (is_win) {
cflags = [ "/arch:AVX2" ]
} else {
cflags = [
"-mavx2",
"-mfma",
]
}
deps = [
":vector_math",
"../../../../api:array_view",
"../../../../rtc_base:checks",
RNN VAD: FC and GRU layers implicit conversion to ArrayView Plus a few minor code readability improvements. Bug: webrtc:10480 Change-Id: I590d8e203b1d05959a8c15373841e37abe83237e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195334 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32764}
2020-12-03 16:54:38 +01:00
"../../../../rtc_base:safe_conversions",
RNN VAD: `VectorMath::DotProduct` with AVX2 optimization This CL adds a new library for the RNN VAD that provides (optimized) vector math ops. The scheme is the same of the `VectorMath` class of AEC3 to ensure correct builds across different platforms. Bug: webrtc:10480 Change-Id: I96bcfbf930ca27388ab5f2d52c022ddb73acf8e6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194326 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Per Åhgren <peah@webrtc.org> Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32741}
2020-11-26 14:10:06 +01:00
]
}
}
RNN VAD build file refactoring: split into separate (private) targets First step to only expose the relevant RNN VAD API to AGC2. Bug: webrtc:7494 Change-Id: I7f11f6eebded124c30cabd64963c8e3ccc35e58f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185124 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32185}
2020-09-24 15:50:15 +02:00
rtc_library("rnn_vad_pitch") {
sources = [
AGC2 RNN VAD: Pitch Search Functions to estimate pitch period and gain. Bug: webrtc:9076 Change-Id: Icfe9430dcae11bdb96165c5bfe6e2b1d3bf848ab Reviewed-on: https://webrtc-review.googlesource.com/70382 Commit-Queue: Alex Loiko <aleloi@webrtc.org> Reviewed-by: Per Åhgren <peah@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23066}
2018-04-27 16:44:11 +02:00
"pitch_search.cc",
"pitch_search.h",
"pitch_search_internal.cc",
"pitch_search_internal.h",
RNN VAD build file refactoring: split into separate (private) targets First step to only expose the relevant RNN VAD API to AGC2. Bug: webrtc:7494 Change-Id: I7f11f6eebded124c30cabd64963c8e3ccc35e58f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185124 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32185}
2020-09-24 15:50:15 +02:00
]
RNN VAD optimizations: `VectorMath::DotProduct()` NEON arm64 Results: RNN VAD realtime factor improved from 140x to 195x (+55x) Test device: Pixel 2 XL Benchmark setup: max clock speed forced on all the cores by setting "performance" as scaling governor Bug: webrtc:10480 Change-Id: I3e92f643853ad1fe990db909c578ce78ee826c03 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198842 Reviewed-by: Per Åhgren <peah@webrtc.org> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32888}
2020-12-28 17:57:24 +01:00
defines = []
if (rtc_build_with_neon && current_cpu != "arm64") {
suppressed_configs += [ "//build/config/compiler:compiler_arm_fpu" ]
cflags = [ "-mfpu=neon" ]
}
RNN VAD build file refactoring: split into separate (private) targets First step to only expose the relevant RNN VAD API to AGC2. Bug: webrtc:7494 Change-Id: I7f11f6eebded124c30cabd64963c8e3ccc35e58f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185124 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32185}
2020-09-24 15:50:15 +02:00
deps = [
":rnn_vad_auto_correlation",
":rnn_vad_common",
RNN VAD: `VectorMath::DotProduct` with AVX2 optimization This CL adds a new library for the RNN VAD that provides (optimized) vector math ops. The scheme is the same of the `VectorMath` class of AEC3 to ensure correct builds across different platforms. Bug: webrtc:10480 Change-Id: I96bcfbf930ca27388ab5f2d52c022ddb73acf8e6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194326 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Per Åhgren <peah@webrtc.org> Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32741}
2020-11-26 14:10:06 +01:00
":vector_math",
AGC2 RNN VAD: safe SIMD optimizations scheme + AVX2 kill switch In preparation for adding AVX2 code, a safe scheme to support different SIMD optimizations is added. Safety features: - AVX2 kill switch to stop using it even if supported by the architecture - struct indicating the available CPU features propagated from AGC2 to each component; in this way - better control over the unit tests - no need to propagate individual kill switches but just set to false features that are turned off Note that (i) this CL does not change the performance of the RNN VAD and (ii) no AVX2 optimization is added yet. Bug: webrtc:10480 Change-Id: I0e61f3311ecd140f38369cf68b6e5954f3dc1f5a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193140 Reviewed-by: Per Åhgren <peah@webrtc.org> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32739}
2020-11-27 16:02:38 +01:00
"..:cpu_features",
RNN VAD build file refactoring: split into separate (private) targets First step to only expose the relevant RNN VAD API to AGC2. Bug: webrtc:7494 Change-Id: I7f11f6eebded124c30cabd64963c8e3ccc35e58f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185124 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32185}
2020-09-24 15:50:15 +02:00
"../../../../api:array_view",
"../../../../rtc_base:checks",
Reland "RNN VAD: pitch search optimizations (part 1)" This reverts commit 1b6b958a4aa574b7852fe62efe5d4f96ce085d8b. Reason for revert: Bug fix Original change's description: > Revert "RNN VAD: pitch search optimizations (part 1)" > > This reverts commit 9da3e177fd5c2236cc15fea0ee8933e1dd0d8f6d. > > Reason for revert: bug in ComputePitchPeriod48kHz() > > Original change's description: > > RNN VAD: pitch search optimizations (part 1) > > > > TL;DR this CL improves efficiency and includes several code > > readability improvements mainly triggered by the comments to > > patch set #10. > > > > Highlights: > > - Split `FindBestPitchPeriods()` into 12 and 24 kHz versions > > to hard-code the input size and simplify the 24 kHz version > > - Loop in `ComputePitchPeriod48kHz()` (new name for > > `RefinePitchPeriod48kHz()`) removed since the lags for which > > we need to compute the auto correlation are a few > > - `ComputePitchGainThreshold()` was only used in unit tests; it's been > > moved into the anon ns and the test removed > > > > This CL makes `ComputePitchPeriod48kHz()` is about 10% faster (measured > > with https://webrtc-review.googlesource.com/c/src/+/191320/4/modules/audio_processing/agc2/rnn_vad/pitch_search_internal_unittest.cc). > > The realtime factor has improved by about +14%. > > > > Benchmarked as follows: > > ``` > > out/release/modules_unittests \ > > --gtest_filter=*RnnVadTest.DISABLED_RnnVadPerformance* \ > > --gtest_also_run_disabled_tests --logs > > ``` > > > > Results: > > > > | baseline | this CL > > ------+----------------------+------------------------ > > run 1 | 24.0231 +/- 0.591016 | 23.568 +/- 0.990788 > > | 370.06x | 377.207x > > ------+----------------------+------------------------ > > run 2 | 24.0485 +/- 0.957498 | 23.3714 +/- 0.857523 > > | 369.67x | 380.379x > > ------+----------------------+------------------------ > > run 2 | 25.4091 +/- 2.6123 | 23.709 +/- 1.04477 > > | 349.875x | 374.963x > > > > Bug: webrtc:10480 > > Change-Id: I9a3e9164b2442114b928de506c92a547c273882f > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/191320 > > Reviewed-by: Per Åhgren <peah@webrtc.org> > > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#32568} > > TBR=alessiob@webrtc.org,peah@webrtc.org > > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:10480 > Change-Id: I2a91f4f29566f872a7dfa220b31c6c625ed075db > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/192660 > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#32581} TBR=alessiob@webrtc.org,peah@webrtc.org # Not skipping CQ checks because this is a reland. Bug: webrtc:10480 Change-Id: I66e3e8d73ebc04a437c01a0396cd5613c42a8cf5 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/192780 Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Per Åhgren <peah@webrtc.org> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32585}
2020-11-11 12:06:09 +01:00
"../../../../rtc_base:gtest_prod",
RNN VAD: Pitch periods as integers and for-if-break optimization This CL includes two changes: 1. the type for (inverted) lags and pitch periods changed from size_t to int to reduce the chance of bugs with pitch period manipulations 2. CheckLowerPitchPeriodsAndComputePitchGain() is optimized by replacing an unnecessary if statement inside the loop with the predetermined number of loops Bug: webrtc:10480 Change-Id: I38432699254b37a2c0111279c28be8dc65b87e9b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/139252 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org> Reviewed-by: Fredrik Hernqvist <fhernqvist@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32521}
2020-10-29 15:49:57 +01:00
"../../../../rtc_base:safe_compare",
AGC2 RNN VAD size_t -> int Motivation: read "On Unsigned Integers" section in https://google.github.io/styleguide/cppguide.html#Integer_Types Plus, improved readability by getting rid of a bunch of `static_cast<int>`s. Bug: webrtc:10480 Change-Id: I911aa8cd08f5ccde4ee6f23534240d1faa84cdea Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/190880 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32524}
2020-10-29 20:50:13 +01:00
"../../../../rtc_base:safe_conversions",
RNN VAD: use `VectorMath::DotProduct()` for pitch search This CL brings a large improvement to the RNN VAD CPU performance by finally using `VectorMath::DotProduct()` for pitch search. The realtime factor improved from about 390x to 570x for SSE2 (+180x, 45% faster) and to 610x for AVX2 (+235x, 60% faster). RNN VAD benchmark results: ``` +-----+-------+------+------+ | run | none* | SSE2 | AVX2 | +-----+-------+------+------+ | 1 | 393x | 572x | 618x | | 2 | 388x | 568x | 607x | | 3 | 393x | 564x | 599x | +-----+-------+------+------+ ``` *: baseline, no SIMD used for pitch search, but SSE2 used for the RNN Results obtained as follows: 1. Force SSE2 in `DISABLED_RnnVadPerformance` for the RNN part in order to measure the baseline correctly: ``` RnnBasedVad rnn_vad({/*sse2=*/true, /*avx2=*/true, /*neon=*/false}); ``` 2. Run the test: ``` $ ./out/release/modules_unittests \ --gtest_filter=*RnnVadTest*DISABLED_RnnVadPerformance* \ --gtest_also_run_disabled_tests --logs ``` Bug: webrtc:10480 Change-Id: I89a2bd420265540026944b9c0f1fdd4bfda7f475 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195001 Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32755}
2020-11-26 14:32:14 +01:00
"../../../../rtc_base/system:arch",
RNN VAD build file refactoring: split into separate (private) targets First step to only expose the relevant RNN VAD API to AGC2. Bug: webrtc:7494 Change-Id: I7f11f6eebded124c30cabd64963c8e3ccc35e58f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185124 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32185}
2020-09-24 15:50:15 +02:00
]
RNN VAD: `VectorMath::DotProduct` with AVX2 optimization This CL adds a new library for the RNN VAD that provides (optimized) vector math ops. The scheme is the same of the `VectorMath` class of AEC3 to ensure correct builds across different platforms. Bug: webrtc:10480 Change-Id: I96bcfbf930ca27388ab5f2d52c022ddb73acf8e6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194326 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Per Åhgren <peah@webrtc.org> Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32741}
2020-11-26 14:10:06 +01:00
if (current_cpu == "x86" || current_cpu == "x64") {
deps += [ ":vector_math_avx2" ]
}
RNN VAD build file refactoring: split into separate (private) targets First step to only expose the relevant RNN VAD API to AGC2. Bug: webrtc:7494 Change-Id: I7f11f6eebded124c30cabd64963c8e3ccc35e58f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185124 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32185}
2020-09-24 15:50:15 +02:00
}
rtc_source_set("rnn_vad_ring_buffer") {
sources = [ "ring_buffer.h" ]
deps = [
"../../../../api:array_view",
"../../../../rtc_base:checks",
]
}
rtc_source_set("rnn_vad_sequence_buffer") {
sources = [ "sequence_buffer.h" ]
deps = [
"../../../../api:array_view",
"../../../../rtc_base:checks",
]
}
rtc_library("rnn_vad_spectral_features") {
sources = [
AGC2 RNN VAD: Spectral features extraction. This CL defines SpectralFeaturesExtractor which is responsible for computing the spectral features used as input for the RNN. Bug: webrtc:9076 Change-Id: I5e1396b89eca9c13bb268e8419a16436a9c3450f Reviewed-on: https://webrtc-review.googlesource.com/73760 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Alex Loiko <aleloi@webrtc.org> Reviewed-by: Ivo Creusen <ivoc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23206}
2018-05-09 13:40:38 +02:00
"spectral_features.cc",
"spectral_features.h",
AGC2 RNN VAD: Spectral features internal API. This CL adds helper functions to be used for the spectral features computation. Namely, it includes the following: - band boundaries (frequency to FFT coeffcient index) - band energy coefficients - log band energy coefficients - fixed size DCT table and computation Bug: webrtc:9076 Change-Id: I03a8799b226d986bc1e37cefd0c3039f94b5592a Reviewed-on: https://webrtc-review.googlesource.com/73687 Reviewed-by: Alex Loiko <aleloi@webrtc.org> Reviewed-by: Minyue Li <minyue@webrtc.org> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23170}
2018-05-08 11:10:45 +02:00
"spectral_features_internal.cc",
"spectral_features_internal.h",
Reland "Reland "AGC2 RNN VAD: initial build targets"" This reverts commit 772d43d4c0acbbc09c3dc280c0ffd17e9569700b. Reason for revert: fix issues and reland revert Original change's description: > Revert "Reland "AGC2 RNN VAD: initial build targets"" > > This reverts commit e0031500bafa4b114adfb2d29444592f1e7b3795. > > Reason for revert: reland automatically landed by mistake > > Original change's description: > > Reland "AGC2 RNN VAD: initial build targets" > > > > This reverts commit a153c00bceb832e697365f52e6a7697fdf210efa. > > > > Reason for revert: fix issues and reland revert > > > > Original change's description: > > > Revert "AGC2 RNN VAD: initial build targets" > > > > > > This reverts commit 8628f5bb7c7f5bd0373567095af08cebe8bb7f8d. > > > > > > Reason for revert: iOS buildbot failing > > > > > > Original change's description: > > > > AGC2 RNN VAD: initial build targets > > > > > > > > rnn_vad_tool is an executable that reads a wav file of any sample rate > > > > compatible with 10 ms frames that are resampled and, when the VAD is > > > > fully landed, will process the resampled frames to compute the VAD > > > > probability. > > > > > > > > To avoid mac, win and ios trybot failures, to_be_removed.h/.cc have > > > > been added and will be removed as soon as the :lib target includes > > > > code that leads to a non-empty static lib file on those platforms. > > > > > > > > Bug: webrtc:9076 > > > > Change-Id: I810c08acfa1adf2029e3baac2adda3045ae5214a > > > > Reviewed-on: https://webrtc-review.googlesource.com/70202 > > > > Reviewed-by: Alex Loiko <aleloi@webrtc.org> > > > > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > > > > Cr-Commit-Position: refs/heads/master@{#22898} > > > > > > TBR=alessiob@webrtc.org,aleloi@webrtc.org > > > > > > Change-Id: Ic6014dde78b0ef371804c52608145ba8acdd9c97 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: webrtc:9076 > > > Reviewed-on: https://webrtc-review.googlesource.com/70144 > > > Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> > > > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > > > Cr-Commit-Position: refs/heads/master@{#22899} > > > > TBR=alessiob@webrtc.org,aleloi@webrtc.org > > > > Change-Id: I55e5a77274684b4cff3c950ca3514cc769d5dc26 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: webrtc:9076 > > Reviewed-on: https://webrtc-review.googlesource.com/70145 > > Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> > > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#22901} > > TBR=alessiob@webrtc.org,aleloi@webrtc.org > > Change-Id: Ia6a837f79ac3f12aa4b0659938454141c69fee61 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:9076 > Reviewed-on: https://webrtc-review.googlesource.com/70520 > Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#22902} TBR=alessiob@webrtc.org,aleloi@webrtc.org Change-Id: If0884ab59d66ac3ba6460dbfe14a083f20493c10 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:9076 Reviewed-on: https://webrtc-review.googlesource.com/70521 Reviewed-by: Minyue Li <minyue@webrtc.org> Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22904}
2018-04-17 15:58:40 +02:00
]
deps = [
RNN VAD build file refactoring: split into separate (private) targets First step to only expose the relevant RNN VAD API to AGC2. Bug: webrtc:7494 Change-Id: I7f11f6eebded124c30cabd64963c8e3ccc35e58f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185124 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32185}
2020-09-24 15:50:15 +02:00
":rnn_vad_common",
":rnn_vad_ring_buffer",
":rnn_vad_symmetric_matrix_buffer",
Reland "Reland "AGC2 RNN VAD: initial build targets"" This reverts commit 772d43d4c0acbbc09c3dc280c0ffd17e9569700b. Reason for revert: fix issues and reland revert Original change's description: > Revert "Reland "AGC2 RNN VAD: initial build targets"" > > This reverts commit e0031500bafa4b114adfb2d29444592f1e7b3795. > > Reason for revert: reland automatically landed by mistake > > Original change's description: > > Reland "AGC2 RNN VAD: initial build targets" > > > > This reverts commit a153c00bceb832e697365f52e6a7697fdf210efa. > > > > Reason for revert: fix issues and reland revert > > > > Original change's description: > > > Revert "AGC2 RNN VAD: initial build targets" > > > > > > This reverts commit 8628f5bb7c7f5bd0373567095af08cebe8bb7f8d. > > > > > > Reason for revert: iOS buildbot failing > > > > > > Original change's description: > > > > AGC2 RNN VAD: initial build targets > > > > > > > > rnn_vad_tool is an executable that reads a wav file of any sample rate > > > > compatible with 10 ms frames that are resampled and, when the VAD is > > > > fully landed, will process the resampled frames to compute the VAD > > > > probability. > > > > > > > > To avoid mac, win and ios trybot failures, to_be_removed.h/.cc have > > > > been added and will be removed as soon as the :lib target includes > > > > code that leads to a non-empty static lib file on those platforms. > > > > > > > > Bug: webrtc:9076 > > > > Change-Id: I810c08acfa1adf2029e3baac2adda3045ae5214a > > > > Reviewed-on: https://webrtc-review.googlesource.com/70202 > > > > Reviewed-by: Alex Loiko <aleloi@webrtc.org> > > > > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > > > > Cr-Commit-Position: refs/heads/master@{#22898} > > > > > > TBR=alessiob@webrtc.org,aleloi@webrtc.org > > > > > > Change-Id: Ic6014dde78b0ef371804c52608145ba8acdd9c97 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: webrtc:9076 > > > Reviewed-on: https://webrtc-review.googlesource.com/70144 > > > Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> > > > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > > > Cr-Commit-Position: refs/heads/master@{#22899} > > > > TBR=alessiob@webrtc.org,aleloi@webrtc.org > > > > Change-Id: I55e5a77274684b4cff3c950ca3514cc769d5dc26 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: webrtc:9076 > > Reviewed-on: https://webrtc-review.googlesource.com/70145 > > Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> > > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#22901} > > TBR=alessiob@webrtc.org,aleloi@webrtc.org > > Change-Id: Ia6a837f79ac3f12aa4b0659938454141c69fee61 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:9076 > Reviewed-on: https://webrtc-review.googlesource.com/70520 > Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#22902} TBR=alessiob@webrtc.org,aleloi@webrtc.org Change-Id: If0884ab59d66ac3ba6460dbfe14a083f20493c10 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:9076 Reviewed-on: https://webrtc-review.googlesource.com/70521 Reviewed-by: Minyue Li <minyue@webrtc.org> Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22904}
2018-04-17 15:58:40 +02:00
"../../../../api:array_view",
"../../../../rtc_base:checks",
AGC2 RNN VAD size_t -> int Motivation: read "On Unsigned Integers" section in https://google.github.io/styleguide/cppguide.html#Integer_Types Plus, improved readability by getting rid of a bunch of `static_cast<int>`s. Bug: webrtc:10480 Change-Id: I911aa8cd08f5ccde4ee6f23534240d1faa84cdea Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/190880 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32524}
2020-10-29 20:50:13 +01:00
"../../../../rtc_base:safe_compare",
Reland "RNN VAD: Replace Ooura with PFFFT for the pitch auto correlation." This reverts commit d38ce9f82402a995289b87e044125847d12eb658. Reason for revert: land this first, then fix downstream Original change's description: > Revert "RNN VAD: Replace Ooura with PFFFT for the pitch auto correlation." > > This reverts commit 8fcd6537f242ffd74154a62dad410e573e2efc4b. > > Reason for revert: broke internal projects. > > Original change's description: > > RNN VAD: Replace Ooura with PFFFT for the pitch auto correlation. > > > > Bug: webrtc:9577, webrtc:10480 > > Change-Id: I6d58866d48b8eaaa4102551b88d4f55133d1915c > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/130482 > > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > > Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#27387} > > TBR=gustaf@webrtc.org,alessiob@webrtc.org > > Change-Id: Ia05057326ebc277f334b13db0bfec9d4442903c2 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:9577, webrtc:10480 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/130369 > Reviewed-by: Qingsi Wang <qingsi@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#27405} TBR=gustaf@webrtc.org,alessiob@webrtc.org,qingsi@webrtc.org Change-Id: I345f00d798fb67d0f02bf1e89319dac7f0287485 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:9577, webrtc:10480 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/130516 Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27407}
2019-04-02 06:58:45 +00:00
"../../utility:pffft_wrapper",
RNN VAD build file refactoring: split into separate (private) targets First step to only expose the relevant RNN VAD API to AGC2. Bug: webrtc:7494 Change-Id: I7f11f6eebded124c30cabd64963c8e3ccc35e58f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185124 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32185}
2020-09-24 15:50:15 +02:00
]
}
rtc_source_set("rnn_vad_symmetric_matrix_buffer") {
sources = [ "symmetric_matrix_buffer.h" ]
deps = [
"../../../../api:array_view",
"../../../../rtc_base:checks",
AGC2 RNN VAD size_t -> int Motivation: read "On Unsigned Integers" section in https://google.github.io/styleguide/cppguide.html#Integer_Types Plus, improved readability by getting rid of a bunch of `static_cast<int>`s. Bug: webrtc:10480 Change-Id: I911aa8cd08f5ccde4ee6f23534240d1faa84cdea Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/190880 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32524}
2020-10-29 20:50:13 +01:00
"../../../../rtc_base:safe_compare",
Reland "Reland "AGC2 RNN VAD: initial build targets"" This reverts commit 772d43d4c0acbbc09c3dc280c0ffd17e9569700b. Reason for revert: fix issues and reland revert Original change's description: > Revert "Reland "AGC2 RNN VAD: initial build targets"" > > This reverts commit e0031500bafa4b114adfb2d29444592f1e7b3795. > > Reason for revert: reland automatically landed by mistake > > Original change's description: > > Reland "AGC2 RNN VAD: initial build targets" > > > > This reverts commit a153c00bceb832e697365f52e6a7697fdf210efa. > > > > Reason for revert: fix issues and reland revert > > > > Original change's description: > > > Revert "AGC2 RNN VAD: initial build targets" > > > > > > This reverts commit 8628f5bb7c7f5bd0373567095af08cebe8bb7f8d. > > > > > > Reason for revert: iOS buildbot failing > > > > > > Original change's description: > > > > AGC2 RNN VAD: initial build targets > > > > > > > > rnn_vad_tool is an executable that reads a wav file of any sample rate > > > > compatible with 10 ms frames that are resampled and, when the VAD is > > > > fully landed, will process the resampled frames to compute the VAD > > > > probability. > > > > > > > > To avoid mac, win and ios trybot failures, to_be_removed.h/.cc have > > > > been added and will be removed as soon as the :lib target includes > > > > code that leads to a non-empty static lib file on those platforms. > > > > > > > > Bug: webrtc:9076 > > > > Change-Id: I810c08acfa1adf2029e3baac2adda3045ae5214a > > > > Reviewed-on: https://webrtc-review.googlesource.com/70202 > > > > Reviewed-by: Alex Loiko <aleloi@webrtc.org> > > > > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > > > > Cr-Commit-Position: refs/heads/master@{#22898} > > > > > > TBR=alessiob@webrtc.org,aleloi@webrtc.org > > > > > > Change-Id: Ic6014dde78b0ef371804c52608145ba8acdd9c97 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: webrtc:9076 > > > Reviewed-on: https://webrtc-review.googlesource.com/70144 > > > Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> > > > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > > > Cr-Commit-Position: refs/heads/master@{#22899} > > > > TBR=alessiob@webrtc.org,aleloi@webrtc.org > > > > Change-Id: I55e5a77274684b4cff3c950ca3514cc769d5dc26 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: webrtc:9076 > > Reviewed-on: https://webrtc-review.googlesource.com/70145 > > Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> > > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#22901} > > TBR=alessiob@webrtc.org,aleloi@webrtc.org > > Change-Id: Ia6a837f79ac3f12aa4b0659938454141c69fee61 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:9076 > Reviewed-on: https://webrtc-review.googlesource.com/70520 > Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#22902} TBR=alessiob@webrtc.org,aleloi@webrtc.org Change-Id: If0884ab59d66ac3ba6460dbfe14a083f20493c10 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:9076 Reviewed-on: https://webrtc-review.googlesource.com/70521 Reviewed-by: Minyue Li <minyue@webrtc.org> Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22904}
2018-04-17 15:58:40 +02:00
]
}
if (rtc_include_tests) {
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("test_utils") {
AGC2 RNN VAD: Linear Prediction Residual Functions to estimate the inverse filter via LPC and compute the LP residual applying the inverse filter. This CL also includes test utilities, in particular BinaryFileReader, used to read chunks of data and optionally cast them on the fly, and Create*Reader() functions to read resource files available at test time. Bug: webrtc:9076 Change-Id: Ia4793b8ad6a63cb3089ed11ddad89d1aa0b840f6 Reviewed-on: https://webrtc-review.googlesource.com/70244 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Jesus de Vicente Pena <devicentepena@webrtc.org> Reviewed-by: Alex Loiko <aleloi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22946}
2018-04-19 17:56:55 +02:00
testonly = true
sources = [
"test_utils.cc",
"test_utils.h",
]
deps = [
Reland "RNN VAD: Replace Ooura with PFFFT for the pitch auto correlation." This reverts commit d38ce9f82402a995289b87e044125847d12eb658. Reason for revert: land this first, then fix downstream Original change's description: > Revert "RNN VAD: Replace Ooura with PFFFT for the pitch auto correlation." > > This reverts commit 8fcd6537f242ffd74154a62dad410e573e2efc4b. > > Reason for revert: broke internal projects. > > Original change's description: > > RNN VAD: Replace Ooura with PFFFT for the pitch auto correlation. > > > > Bug: webrtc:9577, webrtc:10480 > > Change-Id: I6d58866d48b8eaaa4102551b88d4f55133d1915c > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/130482 > > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > > Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#27387} > > TBR=gustaf@webrtc.org,alessiob@webrtc.org > > Change-Id: Ia05057326ebc277f334b13db0bfec9d4442903c2 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:9577, webrtc:10480 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/130369 > Reviewed-by: Qingsi Wang <qingsi@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#27405} TBR=gustaf@webrtc.org,alessiob@webrtc.org,qingsi@webrtc.org Change-Id: I345f00d798fb67d0f02bf1e89319dac7f0287485 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:9577, webrtc:10480 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/130516 Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27407}
2019-04-02 06:58:45 +00:00
":rnn_vad",
RNN VAD build file refactoring: split into separate (private) targets First step to only expose the relevant RNN VAD API to AGC2. Bug: webrtc:7494 Change-Id: I7f11f6eebded124c30cabd64963c8e3ccc35e58f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185124 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32185}
2020-09-24 15:50:15 +02:00
":rnn_vad_common",
AGC2 RNN VAD: Linear Prediction Residual Functions to estimate the inverse filter via LPC and compute the LP residual applying the inverse filter. This CL also includes test utilities, in particular BinaryFileReader, used to read chunks of data and optionally cast them on the fly, and Create*Reader() functions to read resource files available at test time. Bug: webrtc:9076 Change-Id: Ia4793b8ad6a63cb3089ed11ddad89d1aa0b840f6 Reviewed-on: https://webrtc-review.googlesource.com/70244 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Jesus de Vicente Pena <devicentepena@webrtc.org> Reviewed-by: Alex Loiko <aleloi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22946}
2018-04-19 17:56:55 +02:00
"../../../../api:array_view",
Remove rtc_base/scoped_ref_ptr.h. The type rtc::scoped_refptr<T> is now part of api/. Please include it from api/scoped_refptr.h. More info: See: https://groups.google.com/forum/#!topic/discuss-webrtc/Mme2MSz4z4o. Bug: webrtc:9887, webrtc:8205 No-Try: True Change-Id: Ic6c7c81e226e59f12f7933e472f573ae097b55bf Reviewed-on: https://webrtc-review.googlesource.com/c/119041 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26414}
2019-01-25 20:26:48 +01:00
"../../../../api:scoped_refptr",
AGC2 RNN VAD: Linear Prediction Residual Functions to estimate the inverse filter via LPC and compute the LP residual applying the inverse filter. This CL also includes test utilities, in particular BinaryFileReader, used to read chunks of data and optionally cast them on the fly, and Create*Reader() functions to read resource files available at test time. Bug: webrtc:9076 Change-Id: Ia4793b8ad6a63cb3089ed11ddad89d1aa0b840f6 Reviewed-on: https://webrtc-review.googlesource.com/70244 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Jesus de Vicente Pena <devicentepena@webrtc.org> Reviewed-by: Alex Loiko <aleloi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22946}
2018-04-19 17:56:55 +02:00
"../../../../rtc_base:checks",
AGC2 RNN VAD size_t -> int Motivation: read "On Unsigned Integers" section in https://google.github.io/styleguide/cppguide.html#Integer_Types Plus, improved readability by getting rid of a bunch of `static_cast<int>`s. Bug: webrtc:10480 Change-Id: I911aa8cd08f5ccde4ee6f23534240d1faa84cdea Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/190880 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32524}
2020-10-29 20:50:13 +01:00
"../../../../rtc_base:safe_compare",
AGC2 RNN VAD: Linear Prediction Residual Functions to estimate the inverse filter via LPC and compute the LP residual applying the inverse filter. This CL also includes test utilities, in particular BinaryFileReader, used to read chunks of data and optionally cast them on the fly, and Create*Reader() functions to read resource files available at test time. Bug: webrtc:9076 Change-Id: Ia4793b8ad6a63cb3089ed11ddad89d1aa0b840f6 Reviewed-on: https://webrtc-review.googlesource.com/70244 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Jesus de Vicente Pena <devicentepena@webrtc.org> Reviewed-by: Alex Loiko <aleloi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22946}
2018-04-19 17:56:55 +02:00
"../../../../test:fileutils",
"../../../../test:test_support",
]
}
unittest_resources = [
AGC2 RNN VAD: Spectral features internal API. This CL adds helper functions to be used for the spectral features computation. Namely, it includes the following: - band boundaries (frequency to FFT coeffcient index) - band energy coefficients - log band energy coefficients - fixed size DCT table and computation Bug: webrtc:9076 Change-Id: I03a8799b226d986bc1e37cefd0c3039f94b5592a Reviewed-on: https://webrtc-review.googlesource.com/73687 Reviewed-by: Alex Loiko <aleloi@webrtc.org> Reviewed-by: Minyue Li <minyue@webrtc.org> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23170}
2018-05-08 11:10:45 +02:00
"../../../../resources/audio_processing/agc2/rnn_vad/band_energies.dat",
AGC2 RNN VAD: Linear Prediction Residual Functions to estimate the inverse filter via LPC and compute the LP residual applying the inverse filter. This CL also includes test utilities, in particular BinaryFileReader, used to read chunks of data and optionally cast them on the fly, and Create*Reader() functions to read resource files available at test time. Bug: webrtc:9076 Change-Id: Ia4793b8ad6a63cb3089ed11ddad89d1aa0b840f6 Reviewed-on: https://webrtc-review.googlesource.com/70244 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Jesus de Vicente Pena <devicentepena@webrtc.org> Reviewed-by: Alex Loiko <aleloi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22946}
2018-04-19 17:56:55 +02:00
"../../../../resources/audio_processing/agc2/rnn_vad/pitch_buf_24k.dat",
"../../../../resources/audio_processing/agc2/rnn_vad/pitch_lp_res.dat",
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
"../../../../resources/audio_processing/agc2/rnn_vad/pitch_search_int.dat",
AGC2 RNN VAD: Polishing. - Code clean: exploiting the recently added ArrayView ctor for std::array - Pitch search internal unit test: long const arrays moved to a resource file - Minor changes Bug: webrtc:9076 Change-Id: Iaf30753f2498b4568860d72e0b81f5351235692f TBR: aleloi@webrtc.org Reviewed-on: https://webrtc-review.googlesource.com/76920 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23248}
2018-05-15 15:52:38 +02:00
"../../../../resources/audio_processing/agc2/rnn_vad/samples.pcm",
Reland "Reland "AGC2 RNN VAD: Recurrent Neural Network impl"" This reverts commit 3c9f47434f0af3b16f1b8f43cd4500be6fd2ac17. Reason for revert: downstream projects fixed Original change's description: > Revert "Reland "AGC2 RNN VAD: Recurrent Neural Network impl"" > > This reverts commit e0bba68edea74ca33f4c492eba290c089f233f6b. > > Reason for revert: <INSERT REASONING HERE> > > Original change's description: > > Reland "AGC2 RNN VAD: Recurrent Neural Network impl" > > > > This reverts commit 97e349ace7a3fd64fff270f0d780e02bb708f503. > > > > Reason for revert: downstream projects fixed > > > > Original change's description: > > > Revert "AGC2 RNN VAD: Recurrent Neural Network impl" > > > > > > This reverts commit 2491cb73820fe82923b848dfcab6772b4b0addb0. > > > > > > Reason for revert: broke internal build > > > > > > Original change's description: > > > > AGC2 RNN VAD: Recurrent Neural Network impl > > > > > > > > RNN implementation for the AGC2 VAD that includes a fully connected > > > > layer and a gated recurrent unit layer. > > > > > > > > Bug: webrtc:9076 > > > > Change-Id: Ibb8b0b4e9213f09eb9dbe118bbdc94d7e8e4f91b > > > > Reviewed-on: https://webrtc-review.googlesource.com/72060 > > > > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > > > > Reviewed-by: Alex Loiko <aleloi@webrtc.org> > > > > Reviewed-by: Ivo Creusen <ivoc@webrtc.org> > > > > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > > > > Cr-Commit-Position: refs/heads/master@{#23101} > > > > > > TBR=phoglund@webrtc.org,alessiob@webrtc.org,aleloi@webrtc.org,ivoc@webrtc.org > > > > > > Change-Id: Ic311c4b7d79094e959d3a2c4a53c398f34c954e2 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: webrtc:9076 > > > Reviewed-on: https://webrtc-review.googlesource.com/74200 > > > Reviewed-by: Sam Zackrisson <saza@webrtc.org> > > > Commit-Queue: Sam Zackrisson <saza@webrtc.org> > > > Cr-Commit-Position: refs/heads/master@{#23103} > > > > TBR=phoglund@webrtc.org,saza@webrtc.org,alessiob@webrtc.org,aleloi@webrtc.org,ivoc@webrtc.org > > > > Change-Id: I0c7f8e0f59be926322d05b1da1d4d19c0777dab2 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: webrtc:9076 > > Reviewed-on: https://webrtc-review.googlesource.com/74460 > > Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> > > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#23113} > > TBR=phoglund@webrtc.org,saza@webrtc.org,alessiob@webrtc.org,aleloi@webrtc.org,ivoc@webrtc.org > > Change-Id: I3985a6d38df1d4438a50d031bc9f6cf41eb83121 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:9076 > Reviewed-on: https://webrtc-review.googlesource.com/74560 > Reviewed-by: Sam Zackrisson <saza@webrtc.org> > Commit-Queue: Sam Zackrisson <saza@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#23117} TBR=phoglund@webrtc.org,saza@webrtc.org,alessiob@webrtc.org,aleloi@webrtc.org,ivoc@webrtc.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: webrtc:9076 Change-Id: I4d81786837017d4daf0dbb1218306795b977ade5 Reviewed-on: https://webrtc-review.googlesource.com/74760 Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23138}
2018-05-07 09:29:54 +00:00
"../../../../resources/audio_processing/agc2/rnn_vad/vad_prob.dat",
AGC2 RNN VAD: Linear Prediction Residual Functions to estimate the inverse filter via LPC and compute the LP residual applying the inverse filter. This CL also includes test utilities, in particular BinaryFileReader, used to read chunks of data and optionally cast them on the fly, and Create*Reader() functions to read resource files available at test time. Bug: webrtc:9076 Change-Id: Ia4793b8ad6a63cb3089ed11ddad89d1aa0b840f6 Reviewed-on: https://webrtc-review.googlesource.com/70244 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Jesus de Vicente Pena <devicentepena@webrtc.org> Reviewed-by: Alex Loiko <aleloi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22946}
2018-04-19 17:56:55 +02:00
]
if (is_ios) {
bundle_data("unittests_bundle_data") {
testonly = true
sources = unittest_resources
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
outputs = [ "{{bundle_resources_dir}}/{{source_file_part}}" ]
AGC2 RNN VAD: Linear Prediction Residual Functions to estimate the inverse filter via LPC and compute the LP residual applying the inverse filter. This CL also includes test utilities, in particular BinaryFileReader, used to read chunks of data and optionally cast them on the fly, and Create*Reader() functions to read resource files available at test time. Bug: webrtc:9076 Change-Id: Ia4793b8ad6a63cb3089ed11ddad89d1aa0b840f6 Reviewed-on: https://webrtc-review.googlesource.com/70244 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Jesus de Vicente Pena <devicentepena@webrtc.org> Reviewed-by: Alex Loiko <aleloi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22946}
2018-04-19 17:56:55 +02:00
}
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("unittests") {
AGC2 RNN VAD: Sequence buffer The SequenceBuffer class template implements a linear buffer with a Push operation that is used to add a fixed size chunk of new samples into the buffer. Its properties are its size and the size of the chunks that are pushed. It is used to implement the pitch buffer in the RNN VAD feature extractor, for which a ring buffer would be a painful choice. Bug: webrtc:9076 Change-Id: I4767bf06d5a414dbed724a96ea4186ef013a1e30 Reviewed-on: https://webrtc-review.googlesource.com/70204 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22919}
2018-04-17 16:46:45 +02:00
testonly = true
sources = [
Reland "RNN VAD: Replace Ooura with PFFFT for the pitch auto correlation." This reverts commit d38ce9f82402a995289b87e044125847d12eb658. Reason for revert: land this first, then fix downstream Original change's description: > Revert "RNN VAD: Replace Ooura with PFFFT for the pitch auto correlation." > > This reverts commit 8fcd6537f242ffd74154a62dad410e573e2efc4b. > > Reason for revert: broke internal projects. > > Original change's description: > > RNN VAD: Replace Ooura with PFFFT for the pitch auto correlation. > > > > Bug: webrtc:9577, webrtc:10480 > > Change-Id: I6d58866d48b8eaaa4102551b88d4f55133d1915c > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/130482 > > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > > Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#27387} > > TBR=gustaf@webrtc.org,alessiob@webrtc.org > > Change-Id: Ia05057326ebc277f334b13db0bfec9d4442903c2 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:9577, webrtc:10480 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/130369 > Reviewed-by: Qingsi Wang <qingsi@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#27405} TBR=gustaf@webrtc.org,alessiob@webrtc.org,qingsi@webrtc.org Change-Id: I345f00d798fb67d0f02bf1e89319dac7f0287485 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:9577, webrtc:10480 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/130516 Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27407}
2019-04-02 06:58:45 +00:00
"auto_correlation_unittest.cc",
AGC2 RNN VAD: Feature extraction. This CL finalizes the feature extraction part for the RNN VAD adding a class that combines a high-pass filter, LP residual computation, pitch estimation and spectral features extraction. This CL also includes a minor refactoring of the pitch estimation library. Bug: webrtc:9076 Change-Id: I918b9e143bc6dd2bf508a891446067258a68a777 Reviewed-on: https://webrtc-review.googlesource.com/75504 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Alex Loiko <aleloi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23235}
2018-05-14 20:22:18 +02:00
"features_extraction_unittest.cc",
AGC2 RNN VAD: Linear Prediction Residual Functions to estimate the inverse filter via LPC and compute the LP residual applying the inverse filter. This CL also includes test utilities, in particular BinaryFileReader, used to read chunks of data and optionally cast them on the fly, and Create*Reader() functions to read resource files available at test time. Bug: webrtc:9076 Change-Id: Ia4793b8ad6a63cb3089ed11ddad89d1aa0b840f6 Reviewed-on: https://webrtc-review.googlesource.com/70244 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Jesus de Vicente Pena <devicentepena@webrtc.org> Reviewed-by: Alex Loiko <aleloi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22946}
2018-04-19 17:56:55 +02:00
"lp_residual_unittest.cc",
AGC2 RNN VAD: Pitch Search Functions to estimate pitch period and gain. Bug: webrtc:9076 Change-Id: Icfe9430dcae11bdb96165c5bfe6e2b1d3bf848ab Reviewed-on: https://webrtc-review.googlesource.com/70382 Commit-Queue: Alex Loiko <aleloi@webrtc.org> Reviewed-by: Per Åhgren <peah@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23066}
2018-04-27 16:44:11 +02:00
"pitch_search_internal_unittest.cc",
"pitch_search_unittest.cc",
AGC2 RNN VAD: Ring buffer Ring buffer template for a finite number of arrays of given type and size. Bug: webrtc:9076 Change-Id: Ia6c2065b0013f4a00f693966641f9aebe09f6f5c Reviewed-on: https://webrtc-review.googlesource.com/70161 Reviewed-by: Alex Loiko <aleloi@webrtc.org> Reviewed-by: Sam Zackrisson <saza@webrtc.org> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22939}
2018-04-19 14:28:00 +02:00
"ring_buffer_unittest.cc",
RNN VAD: FC layer isolated into rnn_fc.h/.cc Refactoring done to more easily and cleanly add SIMD optimizations and to remove `FullyConnectedLayer` from the RNN VAD api. Minor improvements (readability, API): - `FullyConnectedLayer` gets the ActivationFunction enum and not a function view anymore - SSE2 optimization moved into `FullyConnectedLayer::ComputeOutputSse2` - layer name added for improved logs Bug: webrtc:10480 Change-Id: Ida4903a67655e19ef0464f378c433c1f6e96dca7 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195444 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Sam Zackrisson <saza@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32766}
2020-12-03 19:33:52 +01:00
"rnn_fc_unittest.cc",
RNN VAD: GRU layer isolated into rnn_gru.h/.cc Refactoring done to more easily and cleanly add SIMD optimizations and to remove `GatedRecurrentLayer` from the RNN VAD api. Bug: webrtc:10480 Change-Id: Ie1dffdd9b19c57c03a0b634f6818c0780456a66c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195445 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32770}
2020-12-03 19:35:05 +01:00
"rnn_gru_unittest.cc",
Reland "Reland "AGC2 RNN VAD: Recurrent Neural Network impl"" This reverts commit 3c9f47434f0af3b16f1b8f43cd4500be6fd2ac17. Reason for revert: downstream projects fixed Original change's description: > Revert "Reland "AGC2 RNN VAD: Recurrent Neural Network impl"" > > This reverts commit e0bba68edea74ca33f4c492eba290c089f233f6b. > > Reason for revert: <INSERT REASONING HERE> > > Original change's description: > > Reland "AGC2 RNN VAD: Recurrent Neural Network impl" > > > > This reverts commit 97e349ace7a3fd64fff270f0d780e02bb708f503. > > > > Reason for revert: downstream projects fixed > > > > Original change's description: > > > Revert "AGC2 RNN VAD: Recurrent Neural Network impl" > > > > > > This reverts commit 2491cb73820fe82923b848dfcab6772b4b0addb0. > > > > > > Reason for revert: broke internal build > > > > > > Original change's description: > > > > AGC2 RNN VAD: Recurrent Neural Network impl > > > > > > > > RNN implementation for the AGC2 VAD that includes a fully connected > > > > layer and a gated recurrent unit layer. > > > > > > > > Bug: webrtc:9076 > > > > Change-Id: Ibb8b0b4e9213f09eb9dbe118bbdc94d7e8e4f91b > > > > Reviewed-on: https://webrtc-review.googlesource.com/72060 > > > > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > > > > Reviewed-by: Alex Loiko <aleloi@webrtc.org> > > > > Reviewed-by: Ivo Creusen <ivoc@webrtc.org> > > > > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > > > > Cr-Commit-Position: refs/heads/master@{#23101} > > > > > > TBR=phoglund@webrtc.org,alessiob@webrtc.org,aleloi@webrtc.org,ivoc@webrtc.org > > > > > > Change-Id: Ic311c4b7d79094e959d3a2c4a53c398f34c954e2 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: webrtc:9076 > > > Reviewed-on: https://webrtc-review.googlesource.com/74200 > > > Reviewed-by: Sam Zackrisson <saza@webrtc.org> > > > Commit-Queue: Sam Zackrisson <saza@webrtc.org> > > > Cr-Commit-Position: refs/heads/master@{#23103} > > > > TBR=phoglund@webrtc.org,saza@webrtc.org,alessiob@webrtc.org,aleloi@webrtc.org,ivoc@webrtc.org > > > > Change-Id: I0c7f8e0f59be926322d05b1da1d4d19c0777dab2 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: webrtc:9076 > > Reviewed-on: https://webrtc-review.googlesource.com/74460 > > Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> > > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#23113} > > TBR=phoglund@webrtc.org,saza@webrtc.org,alessiob@webrtc.org,aleloi@webrtc.org,ivoc@webrtc.org > > Change-Id: I3985a6d38df1d4438a50d031bc9f6cf41eb83121 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:9076 > Reviewed-on: https://webrtc-review.googlesource.com/74560 > Reviewed-by: Sam Zackrisson <saza@webrtc.org> > Commit-Queue: Sam Zackrisson <saza@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#23117} TBR=phoglund@webrtc.org,saza@webrtc.org,alessiob@webrtc.org,aleloi@webrtc.org,ivoc@webrtc.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: webrtc:9076 Change-Id: I4d81786837017d4daf0dbb1218306795b977ade5 Reviewed-on: https://webrtc-review.googlesource.com/74760 Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23138}
2018-05-07 09:29:54 +00:00
"rnn_unittest.cc",
AGC2 RNN VAD: Polishing. - Code clean: exploiting the recently added ArrayView ctor for std::array - Pitch search internal unit test: long const arrays moved to a resource file - Minor changes Bug: webrtc:9076 Change-Id: Iaf30753f2498b4568860d72e0b81f5351235692f TBR: aleloi@webrtc.org Reviewed-on: https://webrtc-review.googlesource.com/76920 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23248}
2018-05-15 15:52:38 +02:00
"rnn_vad_unittest.cc",
AGC2 RNN VAD: Sequence buffer The SequenceBuffer class template implements a linear buffer with a Push operation that is used to add a fixed size chunk of new samples into the buffer. Its properties are its size and the size of the chunks that are pushed. It is used to implement the pitch buffer in the RNN VAD feature extractor, for which a ring buffer would be a painful choice. Bug: webrtc:9076 Change-Id: I4767bf06d5a414dbed724a96ea4186ef013a1e30 Reviewed-on: https://webrtc-review.googlesource.com/70204 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22919}
2018-04-17 16:46:45 +02:00
"sequence_buffer_unittest.cc",
AGC2 RNN VAD: Spectral features internal API. This CL adds helper functions to be used for the spectral features computation. Namely, it includes the following: - band boundaries (frequency to FFT coeffcient index) - band energy coefficients - log band energy coefficients - fixed size DCT table and computation Bug: webrtc:9076 Change-Id: I03a8799b226d986bc1e37cefd0c3039f94b5592a Reviewed-on: https://webrtc-review.googlesource.com/73687 Reviewed-by: Alex Loiko <aleloi@webrtc.org> Reviewed-by: Minyue Li <minyue@webrtc.org> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23170}
2018-05-08 11:10:45 +02:00
"spectral_features_internal_unittest.cc",
AGC2 RNN VAD: Spectral features extraction. This CL defines SpectralFeaturesExtractor which is responsible for computing the spectral features used as input for the RNN. Bug: webrtc:9076 Change-Id: I5e1396b89eca9c13bb268e8419a16436a9c3450f Reviewed-on: https://webrtc-review.googlesource.com/73760 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Alex Loiko <aleloi@webrtc.org> Reviewed-by: Ivo Creusen <ivoc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23206}
2018-05-09 13:40:38 +02:00
"spectral_features_unittest.cc",
AGC2 RNN VAD: Symmetric matrix buffer Adding a data structure to cache the results of pair-wise comparisons between items stored in a ring buffer. This is used to avoid recomputing the pair-wise comparison every time that a new item is added in a ring buffer. Bug: webrtc:9076 Change-Id: I88fb67a80bd3fd8497764dc7ae7e0a577c06b20f Reviewed-on: https://webrtc-review.googlesource.com/70162 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22942}
2018-04-19 16:48:07 +02:00
"symmetric_matrix_buffer_unittest.cc",
RNN VAD: `VectorMath::DotProduct` with AVX2 optimization This CL adds a new library for the RNN VAD that provides (optimized) vector math ops. The scheme is the same of the `VectorMath` class of AEC3 to ensure correct builds across different platforms. Bug: webrtc:10480 Change-Id: I96bcfbf930ca27388ab5f2d52c022ddb73acf8e6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194326 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Per Åhgren <peah@webrtc.org> Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32741}
2020-11-26 14:10:06 +01:00
"vector_math_unittest.cc",
AGC2 RNN VAD: Sequence buffer The SequenceBuffer class template implements a linear buffer with a Push operation that is used to add a fixed size chunk of new samples into the buffer. Its properties are its size and the size of the chunks that are pushed. It is used to implement the pitch buffer in the RNN VAD feature extractor, for which a ring buffer would be a painful choice. Bug: webrtc:9076 Change-Id: I4767bf06d5a414dbed724a96ea4186ef013a1e30 Reviewed-on: https://webrtc-review.googlesource.com/70204 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22919}
2018-04-17 16:46:45 +02:00
]
RNN VAD optimizations: `VectorMath::DotProduct()` NEON arm64 Results: RNN VAD realtime factor improved from 140x to 195x (+55x) Test device: Pixel 2 XL Benchmark setup: max clock speed forced on all the cores by setting "performance" as scaling governor Bug: webrtc:10480 Change-Id: I3e92f643853ad1fe990db909c578ce78ee826c03 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198842 Reviewed-by: Per Åhgren <peah@webrtc.org> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32888}
2020-12-28 17:57:24 +01:00
defines = []
if (rtc_build_with_neon && current_cpu != "arm64") {
suppressed_configs += [ "//build/config/compiler:compiler_arm_fpu" ]
cflags = [ "-mfpu=neon" ]
}
AGC2 RNN VAD: Sequence buffer The SequenceBuffer class template implements a linear buffer with a Push operation that is used to add a fixed size chunk of new samples into the buffer. Its properties are its size and the size of the chunks that are pushed. It is used to implement the pitch buffer in the RNN VAD feature extractor, for which a ring buffer would be a painful choice. Bug: webrtc:9076 Change-Id: I4767bf06d5a414dbed724a96ea4186ef013a1e30 Reviewed-on: https://webrtc-review.googlesource.com/70204 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22919}
2018-04-17 16:46:45 +02:00
deps = [
RNN VAD: more specific build target names. Bug: webrtc:9076 Change-Id: Ie35ce0f864318a1ddc552285a5535fe411168202 Reviewed-on: https://webrtc-review.googlesource.com/91760 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Per Åhgren <peah@webrtc.org> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24162}
2018-08-01 10:24:15 +02:00
":rnn_vad",
RNN VAD build file refactoring: split into separate (private) targets First step to only expose the relevant RNN VAD API to AGC2. Bug: webrtc:7494 Change-Id: I7f11f6eebded124c30cabd64963c8e3ccc35e58f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185124 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32185}
2020-09-24 15:50:15 +02:00
":rnn_vad_auto_correlation",
":rnn_vad_common",
RNN VAD: FC layer isolated into rnn_fc.h/.cc Refactoring done to more easily and cleanly add SIMD optimizations and to remove `FullyConnectedLayer` from the RNN VAD api. Minor improvements (readability, API): - `FullyConnectedLayer` gets the ActivationFunction enum and not a function view anymore - SSE2 optimization moved into `FullyConnectedLayer::ComputeOutputSse2` - layer name added for improved logs Bug: webrtc:10480 Change-Id: Ida4903a67655e19ef0464f378c433c1f6e96dca7 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195444 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Sam Zackrisson <saza@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32766}
2020-12-03 19:33:52 +01:00
":rnn_vad_layers",
RNN VAD build file refactoring: split into separate (private) targets First step to only expose the relevant RNN VAD API to AGC2. Bug: webrtc:7494 Change-Id: I7f11f6eebded124c30cabd64963c8e3ccc35e58f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185124 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32185}
2020-09-24 15:50:15 +02:00
":rnn_vad_lp_residual",
":rnn_vad_pitch",
":rnn_vad_ring_buffer",
":rnn_vad_sequence_buffer",
":rnn_vad_spectral_features",
":rnn_vad_symmetric_matrix_buffer",
RNN VAD: more specific build target names. Bug: webrtc:9076 Change-Id: Ie35ce0f864318a1ddc552285a5535fe411168202 Reviewed-on: https://webrtc-review.googlesource.com/91760 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Per Åhgren <peah@webrtc.org> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24162}
2018-08-01 10:24:15 +02:00
":test_utils",
RNN VAD: `VectorMath::DotProduct` with AVX2 optimization This CL adds a new library for the RNN VAD that provides (optimized) vector math ops. The scheme is the same of the `VectorMath` class of AEC3 to ensure correct builds across different platforms. Bug: webrtc:10480 Change-Id: I96bcfbf930ca27388ab5f2d52c022ddb73acf8e6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194326 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Per Åhgren <peah@webrtc.org> Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32741}
2020-11-26 14:10:06 +01:00
":vector_math",
AGC2 RNN VAD: safe SIMD optimizations scheme + AVX2 kill switch In preparation for adding AVX2 code, a safe scheme to support different SIMD optimizations is added. Safety features: - AVX2 kill switch to stop using it even if supported by the architecture - struct indicating the available CPU features propagated from AGC2 to each component; in this way - better control over the unit tests - no need to propagate individual kill switches but just set to false features that are turned off Note that (i) this CL does not change the performance of the RNN VAD and (ii) no AVX2 optimization is added yet. Bug: webrtc:10480 Change-Id: I0e61f3311ecd140f38369cf68b6e5954f3dc1f5a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193140 Reviewed-by: Per Åhgren <peah@webrtc.org> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32739}
2020-11-27 16:02:38 +01:00
"..:cpu_features",
AGC2 RNN VAD: Polishing. - Code clean: exploiting the recently added ArrayView ctor for std::array - Pitch search internal unit test: long const arrays moved to a resource file - Minor changes Bug: webrtc:9076 Change-Id: Iaf30753f2498b4568860d72e0b81f5351235692f TBR: aleloi@webrtc.org Reviewed-on: https://webrtc-review.googlesource.com/76920 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23248}
2018-05-15 15:52:38 +02:00
"../..:audioproc_test_utils",
AGC2 RNN VAD: Sequence buffer The SequenceBuffer class template implements a linear buffer with a Push operation that is used to add a fixed size chunk of new samples into the buffer. Its properties are its size and the size of the chunks that are pushed. It is used to implement the pitch buffer in the RNN VAD feature extractor, for which a ring buffer would be a painful choice. Bug: webrtc:9076 Change-Id: I4767bf06d5a414dbed724a96ea4186ef013a1e30 Reviewed-on: https://webrtc-review.googlesource.com/70204 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22919}
2018-04-17 16:46:45 +02:00
"../../../../api:array_view",
FFT-based auto correlation. During pitch search in the RNN VAD, we calculate auto correlation. Before this CL, we computed kNumInvertedLags12kHz=147 dot products of vectors with kBufSize12kHz-kMaxPitch12kHz=240 elements. This was the most time consuming step of the new VAD. This CL makes the computation happen in frequency domain. Profiling shows a 3x speed increase. In future, we can try using a more efficient FFT and to reduce the FFT length to some of e.g. 400, 405, 432. # For minimal Clang plugin check change. TBR: kwiberg@webrtc.org Bug: webrtc:9076 Change-Id: I688251a415869d53175a37f390f441d4e035d954 Reviewed-on: https://webrtc-review.googlesource.com/73366 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> Commit-Queue: Alex Loiko <aleloi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23171}
2018-05-08 13:11:12 +02:00
"../../../../common_audio/",
Reland "Reland "AGC2 RNN VAD: Recurrent Neural Network impl"" This reverts commit 3c9f47434f0af3b16f1b8f43cd4500be6fd2ac17. Reason for revert: downstream projects fixed Original change's description: > Revert "Reland "AGC2 RNN VAD: Recurrent Neural Network impl"" > > This reverts commit e0bba68edea74ca33f4c492eba290c089f233f6b. > > Reason for revert: <INSERT REASONING HERE> > > Original change's description: > > Reland "AGC2 RNN VAD: Recurrent Neural Network impl" > > > > This reverts commit 97e349ace7a3fd64fff270f0d780e02bb708f503. > > > > Reason for revert: downstream projects fixed > > > > Original change's description: > > > Revert "AGC2 RNN VAD: Recurrent Neural Network impl" > > > > > > This reverts commit 2491cb73820fe82923b848dfcab6772b4b0addb0. > > > > > > Reason for revert: broke internal build > > > > > > Original change's description: > > > > AGC2 RNN VAD: Recurrent Neural Network impl > > > > > > > > RNN implementation for the AGC2 VAD that includes a fully connected > > > > layer and a gated recurrent unit layer. > > > > > > > > Bug: webrtc:9076 > > > > Change-Id: Ibb8b0b4e9213f09eb9dbe118bbdc94d7e8e4f91b > > > > Reviewed-on: https://webrtc-review.googlesource.com/72060 > > > > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > > > > Reviewed-by: Alex Loiko <aleloi@webrtc.org> > > > > Reviewed-by: Ivo Creusen <ivoc@webrtc.org> > > > > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > > > > Cr-Commit-Position: refs/heads/master@{#23101} > > > > > > TBR=phoglund@webrtc.org,alessiob@webrtc.org,aleloi@webrtc.org,ivoc@webrtc.org > > > > > > Change-Id: Ic311c4b7d79094e959d3a2c4a53c398f34c954e2 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: webrtc:9076 > > > Reviewed-on: https://webrtc-review.googlesource.com/74200 > > > Reviewed-by: Sam Zackrisson <saza@webrtc.org> > > > Commit-Queue: Sam Zackrisson <saza@webrtc.org> > > > Cr-Commit-Position: refs/heads/master@{#23103} > > > > TBR=phoglund@webrtc.org,saza@webrtc.org,alessiob@webrtc.org,aleloi@webrtc.org,ivoc@webrtc.org > > > > Change-Id: I0c7f8e0f59be926322d05b1da1d4d19c0777dab2 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: webrtc:9076 > > Reviewed-on: https://webrtc-review.googlesource.com/74460 > > Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> > > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#23113} > > TBR=phoglund@webrtc.org,saza@webrtc.org,alessiob@webrtc.org,aleloi@webrtc.org,ivoc@webrtc.org > > Change-Id: I3985a6d38df1d4438a50d031bc9f6cf41eb83121 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:9076 > Reviewed-on: https://webrtc-review.googlesource.com/74560 > Reviewed-by: Sam Zackrisson <saza@webrtc.org> > Commit-Queue: Sam Zackrisson <saza@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#23117} TBR=phoglund@webrtc.org,saza@webrtc.org,alessiob@webrtc.org,aleloi@webrtc.org,ivoc@webrtc.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: webrtc:9076 Change-Id: I4d81786837017d4daf0dbb1218306795b977ade5 Reviewed-on: https://webrtc-review.googlesource.com/74760 Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23138}
2018-05-07 09:29:54 +00:00
"../../../../rtc_base:checks",
AGC2 RNN VAD: Polishing. - Code clean: exploiting the recently added ArrayView ctor for std::array - Pitch search internal unit test: long const arrays moved to a resource file - Minor changes Bug: webrtc:9076 Change-Id: Iaf30753f2498b4568860d72e0b81f5351235692f TBR: aleloi@webrtc.org Reviewed-on: https://webrtc-review.googlesource.com/76920 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23248}
2018-05-15 15:52:38 +02:00
"../../../../rtc_base:logging",
AGC2 RNN VAD size_t -> int Motivation: read "On Unsigned Integers" section in https://google.github.io/styleguide/cppguide.html#Integer_Types Plus, improved readability by getting rid of a bunch of `static_cast<int>`s. Bug: webrtc:10480 Change-Id: I911aa8cd08f5ccde4ee6f23534240d1faa84cdea Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/190880 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32524}
2020-10-29 20:50:13 +01:00
"../../../../rtc_base:safe_compare",
"../../../../rtc_base:safe_conversions",
RNN VAD: use `VectorMath::DotProduct()` for pitch search This CL brings a large improvement to the RNN VAD CPU performance by finally using `VectorMath::DotProduct()` for pitch search. The realtime factor improved from about 390x to 570x for SSE2 (+180x, 45% faster) and to 610x for AVX2 (+235x, 60% faster). RNN VAD benchmark results: ``` +-----+-------+------+------+ | run | none* | SSE2 | AVX2 | +-----+-------+------+------+ | 1 | 393x | 572x | 618x | | 2 | 388x | 568x | 607x | | 3 | 393x | 564x | 599x | +-----+-------+------+------+ ``` *: baseline, no SIMD used for pitch search, but SSE2 used for the RNN Results obtained as follows: 1. Force SSE2 in `DISABLED_RnnVadPerformance` for the RNN part in order to measure the baseline correctly: ``` RnnBasedVad rnn_vad({/*sse2=*/true, /*avx2=*/true, /*neon=*/false}); ``` 2. Run the test: ``` $ ./out/release/modules_unittests \ --gtest_filter=*RnnVadTest*DISABLED_RnnVadPerformance* \ --gtest_also_run_disabled_tests --logs ``` Bug: webrtc:10480 Change-Id: I89a2bd420265540026944b9c0f1fdd4bfda7f475 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195001 Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32755}
2020-11-26 14:32:14 +01:00
"../../../../rtc_base:stringutils",
RNN VAD: FC layer with SSE2 impl This CL adds the SSE2 optimized implementation for fully connected (FC) layers. The change includes a weights re-alignment op done once at construction time. It is required in order to optimize the load op to fill 128 bit registers. This CL also includes unit test adaptations and a benchmark test (disabled by default). Bug: webrtc:10480 Change-Id: I5ed87f0a629faaaf4c8bffbce1cea5557518f8c8 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141862 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29712}
2019-11-01 19:36:39 +01:00
"../../../../rtc_base/system:arch",
AGC2 RNN VAD: Sequence buffer The SequenceBuffer class template implements a linear buffer with a Push operation that is used to add a fixed size chunk of new samples into the buffer. Its properties are its size and the size of the chunks that are pushed. It is used to implement the pitch buffer in the RNN VAD feature extractor, for which a ring buffer would be a painful choice. Bug: webrtc:9076 Change-Id: I4767bf06d5a414dbed724a96ea4186ef013a1e30 Reviewed-on: https://webrtc-review.googlesource.com/70204 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22919}
2018-04-17 16:46:45 +02:00
"../../../../test:test_support",
RNN VAD: Switch to PFFFT This CL replaces KissFFT with PFFFT for the spectral features computation. Remarks: - Extra FFT output vector copy eliminated - Scaling and windowing merged into a single vector for efficiency - Nyquist frequency hack to keep the iteration in BandFeaturesExtractor::ComputeSpectralCrossCorrelation simple Bug: webrtc:9577, webrtc:10480 Change-Id: I436563bd257f66a243f5402be270ffcf859bd184 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/130221 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Per Åhgren <peah@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27536}
2019-04-10 11:11:09 +02:00
"../../utility:pffft_wrapper",
Reland "Reland "AGC2 RNN VAD: Recurrent Neural Network impl"" This reverts commit 3c9f47434f0af3b16f1b8f43cd4500be6fd2ac17. Reason for revert: downstream projects fixed Original change's description: > Revert "Reland "AGC2 RNN VAD: Recurrent Neural Network impl"" > > This reverts commit e0bba68edea74ca33f4c492eba290c089f233f6b. > > Reason for revert: <INSERT REASONING HERE> > > Original change's description: > > Reland "AGC2 RNN VAD: Recurrent Neural Network impl" > > > > This reverts commit 97e349ace7a3fd64fff270f0d780e02bb708f503. > > > > Reason for revert: downstream projects fixed > > > > Original change's description: > > > Revert "AGC2 RNN VAD: Recurrent Neural Network impl" > > > > > > This reverts commit 2491cb73820fe82923b848dfcab6772b4b0addb0. > > > > > > Reason for revert: broke internal build > > > > > > Original change's description: > > > > AGC2 RNN VAD: Recurrent Neural Network impl > > > > > > > > RNN implementation for the AGC2 VAD that includes a fully connected > > > > layer and a gated recurrent unit layer. > > > > > > > > Bug: webrtc:9076 > > > > Change-Id: Ibb8b0b4e9213f09eb9dbe118bbdc94d7e8e4f91b > > > > Reviewed-on: https://webrtc-review.googlesource.com/72060 > > > > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > > > > Reviewed-by: Alex Loiko <aleloi@webrtc.org> > > > > Reviewed-by: Ivo Creusen <ivoc@webrtc.org> > > > > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > > > > Cr-Commit-Position: refs/heads/master@{#23101} > > > > > > TBR=phoglund@webrtc.org,alessiob@webrtc.org,aleloi@webrtc.org,ivoc@webrtc.org > > > > > > Change-Id: Ic311c4b7d79094e959d3a2c4a53c398f34c954e2 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: webrtc:9076 > > > Reviewed-on: https://webrtc-review.googlesource.com/74200 > > > Reviewed-by: Sam Zackrisson <saza@webrtc.org> > > > Commit-Queue: Sam Zackrisson <saza@webrtc.org> > > > Cr-Commit-Position: refs/heads/master@{#23103} > > > > TBR=phoglund@webrtc.org,saza@webrtc.org,alessiob@webrtc.org,aleloi@webrtc.org,ivoc@webrtc.org > > > > Change-Id: I0c7f8e0f59be926322d05b1da1d4d19c0777dab2 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: webrtc:9076 > > Reviewed-on: https://webrtc-review.googlesource.com/74460 > > Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> > > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#23113} > > TBR=phoglund@webrtc.org,saza@webrtc.org,alessiob@webrtc.org,aleloi@webrtc.org,ivoc@webrtc.org > > Change-Id: I3985a6d38df1d4438a50d031bc9f6cf41eb83121 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:9076 > Reviewed-on: https://webrtc-review.googlesource.com/74560 > Reviewed-by: Sam Zackrisson <saza@webrtc.org> > Commit-Queue: Sam Zackrisson <saza@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#23117} TBR=phoglund@webrtc.org,saza@webrtc.org,alessiob@webrtc.org,aleloi@webrtc.org,ivoc@webrtc.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: webrtc:9076 Change-Id: I4d81786837017d4daf0dbb1218306795b977ade5 Reviewed-on: https://webrtc-review.googlesource.com/74760 Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23138}
2018-05-07 09:29:54 +00:00
"//third_party/rnnoise:rnn_vad",
AGC2 RNN VAD: Sequence buffer The SequenceBuffer class template implements a linear buffer with a Push operation that is used to add a fixed size chunk of new samples into the buffer. Its properties are its size and the size of the chunks that are pushed. It is used to implement the pitch buffer in the RNN VAD feature extractor, for which a ring buffer would be a painful choice. Bug: webrtc:9076 Change-Id: I4767bf06d5a414dbed724a96ea4186ef013a1e30 Reviewed-on: https://webrtc-review.googlesource.com/70204 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22919}
2018-04-17 16:46:45 +02:00
]
RNN VAD: `VectorMath::DotProduct` with AVX2 optimization This CL adds a new library for the RNN VAD that provides (optimized) vector math ops. The scheme is the same of the `VectorMath` class of AEC3 to ensure correct builds across different platforms. Bug: webrtc:10480 Change-Id: I96bcfbf930ca27388ab5f2d52c022ddb73acf8e6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194326 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Per Åhgren <peah@webrtc.org> Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32741}
2020-11-26 14:10:06 +01:00
if (current_cpu == "x86" || current_cpu == "x64") {
deps += [ ":vector_math_avx2" ]
}
Use absl_deps in order to preapre to the Abseil component build release. Bug: webrtc:1046390 Change-Id: Ia35545599de23b1a2c2d8be2d53469af7ac16f1d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176502 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31463}
2020-06-05 14:30:41 +02:00
absl_deps = [ "//third_party/abseil-cpp/absl/memory" ]
AGC2 RNN VAD: Linear Prediction Residual Functions to estimate the inverse filter via LPC and compute the LP residual applying the inverse filter. This CL also includes test utilities, in particular BinaryFileReader, used to read chunks of data and optionally cast them on the fly, and Create*Reader() functions to read resource files available at test time. Bug: webrtc:9076 Change-Id: Ia4793b8ad6a63cb3089ed11ddad89d1aa0b840f6 Reviewed-on: https://webrtc-review.googlesource.com/70244 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Jesus de Vicente Pena <devicentepena@webrtc.org> Reviewed-by: Alex Loiko <aleloi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22946}
2018-04-19 17:56:55 +02:00
data = unittest_resources
if (is_ios) {
deps += [ ":unittests_bundle_data" ]
}
AGC2 RNN VAD: Sequence buffer The SequenceBuffer class template implements a linear buffer with a Push operation that is used to add a fixed size chunk of new samples into the buffer. Its properties are its size and the size of the chunks that are pushed. It is used to implement the pitch buffer in the RNN VAD feature extractor, for which a ring buffer would be a painful choice. Bug: webrtc:9076 Change-Id: I4767bf06d5a414dbed724a96ea4186ef013a1e30 Reviewed-on: https://webrtc-review.googlesource.com/70204 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22919}
2018-04-17 16:46:45 +02:00
}
Remove from chromium build targets that are not compatible with it. We need to be able build chromium with rtc_include_tests = true. It reveals a lot of targets that are not compatible with chromium but aren't marked so. `rtc_include_tests=true` has been considered a way to disable targets for the Chromium build, causing an overload on rtc_include_tests while the meaning of the two GN args (rtc_include_tests and build_with_chromium) should be kept separated. Bug: webrtc:12404 Change-Id: I2f72825445916eae7c20ef9338672d6a07a9b9ff Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/203890 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Andrey Logvin <landrey@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33124}
2021-02-01 09:56:37 +00:00
if (!build_with_chromium) {
rtc_executable("rnn_vad_tool") {
testonly = true
sources = [ "rnn_vad_tool.cc" ]
deps = [
":rnn_vad",
":rnn_vad_common",
"..:cpu_features",
"../../../../api:array_view",
"../../../../common_audio",
Remove //rtc_base:logging from public deps Bug: webrtc:8603 Change-Id: I2704da8618f88032adac7ae9eb2a0f47fce4a836 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257908 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Auto-Submit: Florent Castelli <orphis@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36443}
2022-04-04 15:06:30 +02:00
"../../../../rtc_base:logging",
Remove from chromium build targets that are not compatible with it. We need to be able build chromium with rtc_include_tests = true. It reveals a lot of targets that are not compatible with chromium but aren't marked so. `rtc_include_tests=true` has been considered a way to disable targets for the Chromium build, causing an overload on rtc_include_tests while the meaning of the two GN args (rtc_include_tests and build_with_chromium) should be kept separated. Bug: webrtc:12404 Change-Id: I2f72825445916eae7c20ef9338672d6a07a9b9ff Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/203890 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Andrey Logvin <landrey@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33124}
2021-02-01 09:56:37 +00:00
"../../../../rtc_base:rtc_base_approved",
"../../../../rtc_base:safe_compare",
"../../../../test:test_support",
"//third_party/abseil-cpp/absl/flags:flag",
"//third_party/abseil-cpp/absl/flags:parse",
]
}
Reland "Reland "AGC2 RNN VAD: initial build targets"" This reverts commit 772d43d4c0acbbc09c3dc280c0ffd17e9569700b. Reason for revert: fix issues and reland revert Original change's description: > Revert "Reland "AGC2 RNN VAD: initial build targets"" > > This reverts commit e0031500bafa4b114adfb2d29444592f1e7b3795. > > Reason for revert: reland automatically landed by mistake > > Original change's description: > > Reland "AGC2 RNN VAD: initial build targets" > > > > This reverts commit a153c00bceb832e697365f52e6a7697fdf210efa. > > > > Reason for revert: fix issues and reland revert > > > > Original change's description: > > > Revert "AGC2 RNN VAD: initial build targets" > > > > > > This reverts commit 8628f5bb7c7f5bd0373567095af08cebe8bb7f8d. > > > > > > Reason for revert: iOS buildbot failing > > > > > > Original change's description: > > > > AGC2 RNN VAD: initial build targets > > > > > > > > rnn_vad_tool is an executable that reads a wav file of any sample rate > > > > compatible with 10 ms frames that are resampled and, when the VAD is > > > > fully landed, will process the resampled frames to compute the VAD > > > > probability. > > > > > > > > To avoid mac, win and ios trybot failures, to_be_removed.h/.cc have > > > > been added and will be removed as soon as the :lib target includes > > > > code that leads to a non-empty static lib file on those platforms. > > > > > > > > Bug: webrtc:9076 > > > > Change-Id: I810c08acfa1adf2029e3baac2adda3045ae5214a > > > > Reviewed-on: https://webrtc-review.googlesource.com/70202 > > > > Reviewed-by: Alex Loiko <aleloi@webrtc.org> > > > > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > > > > Cr-Commit-Position: refs/heads/master@{#22898} > > > > > > TBR=alessiob@webrtc.org,aleloi@webrtc.org > > > > > > Change-Id: Ic6014dde78b0ef371804c52608145ba8acdd9c97 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: webrtc:9076 > > > Reviewed-on: https://webrtc-review.googlesource.com/70144 > > > Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> > > > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > > > Cr-Commit-Position: refs/heads/master@{#22899} > > > > TBR=alessiob@webrtc.org,aleloi@webrtc.org > > > > Change-Id: I55e5a77274684b4cff3c950ca3514cc769d5dc26 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: webrtc:9076 > > Reviewed-on: https://webrtc-review.googlesource.com/70145 > > Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> > > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#22901} > > TBR=alessiob@webrtc.org,aleloi@webrtc.org > > Change-Id: Ia6a837f79ac3f12aa4b0659938454141c69fee61 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:9076 > Reviewed-on: https://webrtc-review.googlesource.com/70520 > Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#22902} TBR=alessiob@webrtc.org,aleloi@webrtc.org Change-Id: If0884ab59d66ac3ba6460dbfe14a083f20493c10 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:9076 Reviewed-on: https://webrtc-review.googlesource.com/70521 Reviewed-by: Minyue Li <minyue@webrtc.org> Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22904}
2018-04-17 15:58:40 +02:00
}
}
Reference in New Issue Copy Permalink