admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
webrtc_m130/webrtc/base/base.gyp

680 lines
18 KiB
Plaintext
Raw Normal View History

Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base. BUG=N/A R=niklas.enbom@webrtc.org Review URL: https://webrtc-codereview.appspot.com/17479005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6129 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 18:00:26 +00:00
# Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
#
# Use of this source code is governed by a BSD-style license
# that can be found in the LICENSE file in the root of the source
# tree. An additional intellectual property rights grant can be found
# in the file PATENTS. All contributing project authors may
# be found in the AUTHORS file in the root of the source tree.
{
'includes': [ '../build/common.gypi', ],
'conditions': [
Reland of Cleanup webrtc/base/base.gyp (patchset #1 id:1 of https://codereview.webrtc.org/1856323003/ ) Reason for revert: Creating template CL for reland Original issue's description: > Revert of Cleanup webrtc/base/base.gyp (patchset #2 id:80001 of https://codereview.webrtc.org/1859803002/ ) > > Reason for revert: > For some odd reason this breaks chromium.webrtc.fyi bots: > ../../third_party/webrtc_overrides/webrtc/base/win32socketinit.cc:13:2: error: "Only compile this on Windows" > #error "Only compile this on Windows" > ^ > 1 error generated. > > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/11515/steps/compile/logs/stdio > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/builds/4650/steps/compile/logs/stdio > > Original issue's description: > > Cleanup webrtc/base/base.gyp > > > > * Remove all source exclusions since they make the file very hard to > > read and heavily increases the risk for mistakes. > > * Don't compile the openssl* sources if use_openssl==0. > > * Move platform specific sources into conditional includes to make it > > easier to verify a 1:1 mapping with BUILD.gn (since GN doesn't support > > automatic detection of platform specific sources based on filenames). > > * Add missing sources for the GN build. > > * Reorder some blocks to make GYP vs GN mapping match. > > > > BUG=webrtc:4256 > > R=perkj@webrtc.org, torbjorng@webrtc.org > > > > Committed: https://crrev.com/47f33cb28ffb0fa0f053ae0aa0086e11f85bf444 > > Cr-Commit-Position: refs/heads/master@{#12235} > > TBR=perkj@webrtc.org,torbjorng@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:4256 > NOTRY=True > > Committed: https://crrev.com/c8587ad92d394bfb60498df1209a3beb9017e001 > Cr-Commit-Position: refs/heads/master@{#12237} TBR=perkj@webrtc.org,torbjorng@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4256 Review URL: https://codereview.webrtc.org/1857163003 Cr-Commit-Position: refs/heads/master@{#12242}
2016-04-05 08:13:31 -07:00
['os_posix==1 and OS!="mac" and OS!="ios"', {
Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base. BUG=N/A R=niklas.enbom@webrtc.org Review URL: https://webrtc-codereview.appspot.com/17479005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6129 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 18:00:26 +00:00
'conditions': [
['sysroot!=""', {
'variables': {
'pkg-config': '../../../build/linux/pkg-config-wrapper "<(sysroot)" "<(target_arch)"',
},
}, {
'variables': {
'pkg-config': 'pkg-config'
},
}],
],
}],
],
'targets': [
Add a target for the approved subset of rtc_base. rtc_base drags in a bunch of unwieldly dependencies (e.g. nss and json) not required for standalone webrtc (aka rtc/media). The root of the problem appears to be that MessageQueue depends on a socket server. (And since common.h -> logging.h -> thread.h -> messagequeue.h, this dependency spreads quickly.) This starts a new target for a "purified" subset of rtc_base. It adds the files which are already being used, replacing the use of common.h with checks.h. desktop_capture is a lost cause, and retains its dependency on the full rtc_base. The hope is that as additional components are desired they will be cleaned and added to rtc_base_approved. BUG=3806 R=andresp@webrtc.org, henrike@webrtc.org Review URL: https://webrtc-codereview.appspot.com/22649004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@7188 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-16 01:03:29 +00:00
{
# The subset of rtc_base approved for use outside of libjingle.
'target_name': 'rtc_base_approved',
'type': 'static_library',
'sources': [
Introduce rtc::ArrayView<T>, which keeps track of an array that it doesn't own The main intended use case is as a function argument, replacing the harder-to-read and harder-to-use separate pointer and size arguments. It's easier to read because it's just one argument instead of two, and with clearly defined semantics; it's easier to use because it has iterators, and will automatically figure out the size of arrays. BUG=webrtc:5028 R=andrew@webrtc.org, solenberg@webrtc.org Review URL: https://codereview.webrtc.org/1408403002 . Cr-Commit-Position: refs/heads/master@{#10415}
2015-10-26 19:51:29 +01:00
'array_view.h',
Move rtc::AtomicOps to webrtc/base/atomicops.h. Removes FixedSizeLockFreeQueue which isn't used anymore. This enabled moving rtc::AtomicOps to webrtc/base/atomicops.h where they should be. BUG=4330 R=tommi@webrtc.org Review URL: https://webrtc-codereview.appspot.com/51789004 Cr-Commit-Position: refs/heads/master@{#9120}
2015-04-30 14:16:07 +02:00
'atomicops.h',
Move bind.h to rtc_base_approved. This is more a correction than a change since bind.h was incorrectly not a part of rtc_base when building with Chromium while still being used (since it's a header file only). The only dependencies that bind.h has, are in rtc_base_approved, so there's no need to restrict usage of it to rtc_base users only. NOTRY=true TBR=perkj NO_DEPENDENCY_CHECKS=true Review URL: https://codereview.webrtc.org/1911403002 . Cr-Commit-Position: refs/heads/master@{#12474}
2016-04-22 19:34:59 +02:00
'bind.h',
Moved ByteBuffer/BitBuffer into rtc_base_approved. Also pulls in constructormagic.h, byteorder.h, and basictypes.h. BUG= R=pthatcher@webrtc.org Review URL: https://webrtc-codereview.appspot.com/49069004 Cr-Commit-Position: refs/heads/master@{#9062}
2015-04-22 15:43:08 -07:00
'bitbuffer.cc',
'bitbuffer.h',
rtc::Buffer improvements 1. Constructors, SetData(), and AppendData() now accept uint8_t*, int8_t*, and char*. Previously, they accepted void*, meaning that any kind of pointer was accepted. I think requiring an explicit cast in cases where the input array isn't already of a byte-sized type is a better compromise between convenience and safety. 2. data() can now return a uint8_t* instead of a char*, which seems more appropriate for a byte array, and is harder to mix up with zero-terminated C strings. data<int8_t>() is also available so that callers that want that type instead won't have to cast, as is data<char>() (which remains the default until all existing callers have been fixed). 3. Constructors, SetData(), and AppendData() now accept arrays natively, not just decayed to pointers. The advantage of this is that callers don't have to pass the size separately. 4. There are new constructors that allow setting size and capacity without initializing the array. Previously, this had to be done separately after construction. 5. Instead of TransferTo(), Buffer now supports swap(), and move construction and assignment, and has a Pass() method that works just like std::move(). (The Pass method is modeled after scoped_ptr::Pass().) R=jmarusic@webrtc.org, tommi@webrtc.org Review URL: https://webrtc-codereview.appspot.com/42989004 Cr-Commit-Position: refs/heads/master@{#9033}
2015-04-20 14:03:07 +02:00
'buffer.h',
Keep track of DTLS packet sizes to prevent partial reads. The current use of rtc::FifoBuffer can lead to reading across DTLS packet boundaries which could cause packets to not being processed correctly. This CL introduces the new class rtc::BufferQueue and changes the StreamInterfaceChannel to use it instead of the rtc::FifoBuffer. BUG=chromium:447431 R=juberti@google.com Review URL: https://webrtc-codereview.appspot.com/52509004 Cr-Commit-Position: refs/heads/master@{#9254}
2015-05-21 17:52:01 +02:00
'bufferqueue.cc',
'bufferqueue.h',
Moved ByteBuffer/BitBuffer into rtc_base_approved. Also pulls in constructormagic.h, byteorder.h, and basictypes.h. BUG= R=pthatcher@webrtc.org Review URL: https://webrtc-codereview.appspot.com/49069004 Cr-Commit-Position: refs/heads/master@{#9062}
2015-04-22 15:43:08 -07:00
'bytebuffer.cc',
'bytebuffer.h',
'byteorder.h',
Add a target for the approved subset of rtc_base. rtc_base drags in a bunch of unwieldly dependencies (e.g. nss and json) not required for standalone webrtc (aka rtc/media). The root of the problem appears to be that MessageQueue depends on a socket server. (And since common.h -> logging.h -> thread.h -> messagequeue.h, this dependency spreads quickly.) This starts a new target for a "purified" subset of rtc_base. It adds the files which are already being used, replacing the use of common.h with checks.h. desktop_capture is a lost cause, and retains its dependency on the full rtc_base. The hope is that as additional components are desired they will be cleaned and added to rtc_base_approved. BUG=3806 R=andresp@webrtc.org, henrike@webrtc.org Review URL: https://webrtc-codereview.appspot.com/22649004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@7188 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-16 01:03:29 +00:00
'checks.cc',
'checks.h',
Moved ByteBuffer/BitBuffer into rtc_base_approved. Also pulls in constructormagic.h, byteorder.h, and basictypes.h. BUG= R=pthatcher@webrtc.org Review URL: https://webrtc-codereview.appspot.com/49069004 Cr-Commit-Position: refs/heads/master@{#9062}
2015-04-22 15:43:08 -07:00
'constructormagic.h',
Move copyonwritebuffer to rtc_base_approved. The other buffer classes as well as all other dependencies are in rtc_base_approved, so I think this is a better place for it. Additionally I found that code in Chromium that already depends on the other buffer classes but now depends on the CopyOnWriteBuffer class, needed to have their build files updated and they previously depended on the buffer classes in rtc_base_approved. TBR=jbauch@webrtc.org Review URL: https://codereview.webrtc.org/1820643002 Cr-Commit-Position: refs/heads/master@{#12059}
2016-03-19 11:36:18 -07:00
'copyonwritebuffer.cc',
'copyonwritebuffer.h',
Move CriticalSection into rtc_base_approved. This class is being used from both libjingle and webrtc but we recently had a regression when we added dependency on libjingle's Thread class. This cleans that up and moves the implementation of CriticalSection and helper classes into the source file. I'm also improving debugging facilities and constness. BUG= R=magjed@webrtc.org Review URL: https://webrtc-codereview.appspot.com/51769004 Cr-Commit-Position: refs/heads/master@{#9089}
2015-04-27 17:39:23 +02:00
'criticalsection.cc',
'criticalsection.h',
New macro: RTC_DEPRECATED (for annotating deprecated functions) Review URL: https://codereview.webrtc.org/1494133003 Cr-Commit-Position: refs/heads/master@{#11042}
2015-12-16 01:09:16 -08:00
'deprecation.h',
Move rtc::Event to rtc_base_approved. We need an event implementation in WebRTC that allows us to specify whether it's manually reset or automatically. EventWrapper currently doesn't support it and it adds a heap allocation + vtable, so rtc::Event is the lighter of the two. I'm also tidying rtc::Event up a bit. Removing member variable that's not needed on all platforms and moving the mutex itself up in the member list given the recent alignment scare on Mac. R=pbos@webrtc.org Review URL: https://webrtc-codereview.appspot.com/38999004 Cr-Commit-Position: refs/heads/master@{#8292} git-svn-id: http://webrtc.googlecode.com/svn/trunk@8292 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-09 10:23:27 +00:00
'event.cc',
'event.h',
Move trace_event and associated files to webrtc/base. Also starting to use TRACE_EVENT from thread.cc in webrtc/base, to track Invoke() calls. BUG= R=magjed@webrtc.org, tina.legrand@webrtc.org Review URL: https://webrtc-codereview.appspot.com/42769004 Cr-Commit-Position: refs/heads/master@{#8755} git-svn-id: http://webrtc.googlecode.com/svn/trunk@8755 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-17 14:25:37 +00:00
'event_tracer.cc',
'event_tracer.h',
Add a target for the approved subset of rtc_base. rtc_base drags in a bunch of unwieldly dependencies (e.g. nss and json) not required for standalone webrtc (aka rtc/media). The root of the problem appears to be that MessageQueue depends on a socket server. (And since common.h -> logging.h -> thread.h -> messagequeue.h, this dependency spreads quickly.) This starts a new target for a "purified" subset of rtc_base. It adds the files which are already being used, replacing the use of common.h with checks.h. desktop_capture is a lost cause, and retains its dependency on the full rtc_base. The hope is that as additional components are desired they will be cleaned and added to rtc_base_approved. BUG=3806 R=andresp@webrtc.org, henrike@webrtc.org Review URL: https://webrtc-codereview.appspot.com/22649004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@7188 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-16 01:03:29 +00:00
'exp_filter.cc',
'exp_filter.h',
Reland of Initial version of file wrapper Fixes a conversion issue. BUG=webrtc:6177 R=sprang@webrtc.org TBR=mflodman@webrtc.org patch from issue 2214763002 at patchset 450001 (http://crrev.com/2214763002#ps450001) Review URL: https://codereview.webrtc.org/2306553002 . Cr-Commit-Position: refs/heads/master@{#14044}
2016-09-02 13:38:32 +02:00
'file.cc',
'file.h',
Moved format_macros.h from rtc_base to rtc_base_approved. BUG=webrtc:3806 NOTRY=True Review-Url: https://codereview.webrtc.org/2272003002 Cr-Commit-Position: refs/heads/master@{#13921}
2016-08-25 04:43:45 -07:00
'format_macros.h',
Adding more detail to MessageQueue::Dispatch logging. Every message will now be traced with the location from which it was posted, including function name, file and line number. This CL also writes a normal LOG message when the dispatch took more than a certain amount of time (currently 50ms). This logging should help us identify messages that are taking longer than expected to be dispatched. R=pthatcher@webrtc.org, tommi@webrtc.org Review URL: https://codereview.webrtc.org/2019423006 . Cr-Commit-Position: refs/heads/master@{#13104}
2016-06-10 14:17:27 -07:00
'location.h',
'location.cc',
Add a target for the approved subset of rtc_base. rtc_base drags in a bunch of unwieldly dependencies (e.g. nss and json) not required for standalone webrtc (aka rtc/media). The root of the problem appears to be that MessageQueue depends on a socket server. (And since common.h -> logging.h -> thread.h -> messagequeue.h, this dependency spreads quickly.) This starts a new target for a "purified" subset of rtc_base. It adds the files which are already being used, replacing the use of common.h with checks.h. desktop_capture is a lost cause, and retains its dependency on the full rtc_base. The hope is that as additional components are desired they will be cleaned and added to rtc_base_approved. BUG=3806 R=andresp@webrtc.org, henrike@webrtc.org Review URL: https://webrtc-codereview.appspot.com/22649004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@7188 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-16 01:03:29 +00:00
'md5.cc',
'md5.h',
Fix clang style warnings in webrtc/base Mostly this consists of marking functions with override when applicable, and moving function bodies from .h to .cc files. Not inlining virtual functions with simple bodies such as { return false; } strikes me as probably losing more in readability than we gain in binary size and compilation time, but I guess it's just like any other case where enabling a generally good warning forces us to write slightly worse code in a couple of places. BUG=163 R=kjellander@webrtc.org, tommi@webrtc.org Review URL: https://webrtc-codereview.appspot.com/47429004 Cr-Commit-Position: refs/heads/master@{#8656} git-svn-id: http://webrtc.googlecode.com/svn/trunk@8656 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-09 22:21:53 +00:00
'md5digest.cc',
Add a target for the approved subset of rtc_base. rtc_base drags in a bunch of unwieldly dependencies (e.g. nss and json) not required for standalone webrtc (aka rtc/media). The root of the problem appears to be that MessageQueue depends on a socket server. (And since common.h -> logging.h -> thread.h -> messagequeue.h, this dependency spreads quickly.) This starts a new target for a "purified" subset of rtc_base. It adds the files which are already being used, replacing the use of common.h with checks.h. desktop_capture is a lost cause, and retains its dependency on the full rtc_base. The hope is that as additional components are desired they will be cleaned and added to rtc_base_approved. BUG=3806 R=andresp@webrtc.org, henrike@webrtc.org Review URL: https://webrtc-codereview.appspot.com/22649004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@7188 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-16 01:03:29 +00:00
'md5digest.h',
Revert "Revert of Implement the NackModule as part of the new jitter buffer. (patchset #19 id:360001 of https://codereview.webrtc.org/1715673002/ )" This reverts commit eb648bf0e5a9bae185bcd6b4b3be371e1da3507d. Re-reverting to fix original CL (https://codereview.webrtc.org/1715673002/). TBR=stefan@webrtc.org, tommi@webrtc.org, torbjorng@webrtc.org BUG=webrtc:5514 Review URL: https://codereview.webrtc.org/1769113003 Cr-Commit-Position: refs/heads/master@{#11904}
2016-03-08 03:36:15 -08:00
'mod_ops.h',
Added log messages for some important call setup events: - First audio RTP packet sent / received - First RTP packet of the first video frame sent / received - Last RTP packet of the first video frame sent / received These timestamps should make it easier to measure how fast the call becomes established from the user's perspective. Review URL: https://codereview.webrtc.org/1765443002 Cr-Commit-Position: refs/heads/master@{#12287}
2016-04-07 15:36:45 -07:00
'onetimeevent.h',
Rename Maybe to Optional And add examples of good and bad usage to the documentation. R=aluebs@webrtc.org, henrik.lundin@webrtc.org, pthatcher@webrtc.org Review URL: https://codereview.webrtc.org/1432553007 . Cr-Commit-Position: refs/heads/master@{#10588}
2015-11-10 22:34:18 +01:00
'optional.h',
Reland 28629004: adding new AEC dump start interface for chrome. This is required because we are not allow to pass CRT objects across dll boundaries, that says, when we pass a file descriptor from chrome dll to libpeerconnection dll, the file descriptor will become invalid immediate, more information can be found here: http://msdn.microsoft.com/en-us/library/ms235460.aspx R=andresp@webrtc.org, andrew@webrtc.org, bjornv@webrtc.org, henrike@webrtc.org, henrikg@webrtc.org Review URL: https://webrtc-codereview.appspot.com/30629004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@7418 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-10 08:36:56 +00:00
'platform_file.cc',
'platform_file.h',
Add platform_thread source files and move types from thread_checker_impl to there. BUG= R=henrika@webrtc.org Review URL: https://webrtc-codereview.appspot.com/52529004 Cr-Commit-Position: refs/heads/master@{#9201}
2015-05-18 09:51:42 +02:00
'platform_thread.cc',
'platform_thread.h',
Move ThreadWrapper to ProcessThread in base. Also removes all virtual methods. Permits using a thread from rtc_base_approved (namely event tracing). BUG=webrtc:5158 R=tommi@webrtc.org Review URL: https://codereview.webrtc.org/1469013002 Cr-Commit-Position: refs/heads/master@{#10760}
2015-11-23 14:47:56 -08:00
'platform_thread_types.h',
Add a race-checking mechanism. Permits CHECKing/DCHECKing that methods are being accessed in a thread-safe manner, even if they are not used by one single thread (thread pools such as VideoToolbox OK). BUG= R=danilchap@webrtc.org, tommi@webrtc.org Review URL: https://codereview.webrtc.org/2097403002 . Cr-Commit-Position: refs/heads/master@{#13358}
2016-07-01 12:45:15 +02:00
'race_checker.cc',
'race_checker.h',
Rewrote the PRNG using an xorshift* algorithm and moved the files from test/ to base/. Created a simple unit test for the new random number generator. (It mostly tests that the generated numbers are consistent with the intended distribution, e.g. uniform. It is not a comprehensive test of the quality of the random numbers.) Several assertions in OveruseDetectorTest seem to depend on the exact sequence of random numbers. I updated those numbers to work with the new PRNG. Compute the standard deviation of the expected result in TestReorderFilter instead of passing an uncertainty parameter. BUG=webrtc:5177 Review URL: https://codereview.webrtc.org/1457023002 Cr-Commit-Position: refs/heads/master@{#10965}
2015-12-10 01:50:55 -08:00
'random.cc',
'random.h',
Bitrate controller for VideoToolbox encoder. Also fixes a crash on encoder Release. BUG=webrtc:4081 Review URL: https://codereview.webrtc.org/1660963002 Cr-Commit-Position: refs/heads/master@{#11729}
2016-02-23 22:49:42 -08:00
'rate_statistics.cc',
'rate_statistics.h',
Reland of actor NACK bitrate allocation (patchset #1 id:1 of https://codereview.webrtc.org/2131913003/ ) Reason for revert: Upstream fixes in place, should be OK now. Original issue's description: > Revert of Refactor NACK bitrate allocation (patchset #16 id:300001 of https://codereview.webrtc.org/2061423003/ ) > > Reason for revert: > Breaks upstream code. > > Original issue's description: > > Refactor NACK bitrate allocation > > > > Nack bitrate allocation should not be done on a per-rtp-module basis, > > but rather shared bitrate pool per call. This CL moves allocation to the > > pacer and cleans up a bunch if bitrate stats handling. > > > > BUG= > > R=danilchap@webrtc.org, stefan@webrtc.org, tommi@webrtc.org > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/5fc59e810b8ea848702f2dbc740fe190608e1413 > > TBR=tommi@webrtc.org,danilchap@webrtc.org,stefan@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= > > Committed: https://crrev.com/e5dd44101eca485f5ad12e5f7ce6f6b0d204116b > Cr-Commit-Position: refs/heads/master@{#13417} TBR=tommi@webrtc.org,danilchap@webrtc.org,stefan@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Review-Url: https://codereview.webrtc.org/2146013002 Cr-Commit-Position: refs/heads/master@{#13465}
2016-07-13 09:11:28 -07:00
'rate_limiter.cc',
'rate_limiter.h',
Merge video_engine_core into webrtc target. Merges the two video targets since video_engine is no longer usable standalone. BUG=webrtc:1695 R=mflodman@webrtc.org, stefan@webrtc.org Review URL: https://codereview.webrtc.org/1184763009. Cr-Commit-Position: refs/heads/master@{#9479}
2015-06-22 07:57:16 +02:00
'ratetracker.cc',
'ratetracker.h',
Move refcount.h and scoped_ref_ptr.h to rtc_base_approved. BUG= Review URL: https://codereview.webrtc.org/1701533002 Cr-Commit-Position: refs/heads/master@{#11615}
2016-02-14 08:11:10 -08:00
'refcount.h',
Revert of Safe numeric library: base/numerics (copied from Chromium) (patchset #11 id:250001 of https://codereview.webrtc.org/1753293002/ ) Reason for revert: Looks like the Chrome iOS build is broken because of these two changes. So I'm going to have to revert. Here's the error: https://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/185624/steps/compile/logs/stdio FAILED: rm -f arch/libsafe_numerics.arm64.a && ./gyp-mac-tool filter-libtool libtool -static -o arch/libsafe_numerics.arm64.a error: /Applications/Xcode7.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: no files specified Usage: /Applications/Xcode7.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool -static [-] file [...] [-filelist listfile[,dirname]] [-arch_only arch] [-sacLT] [-no_warning_for_no_symbols] Usage: /Applications/Xcode7.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool -dynamic [-] file [...] [-filelist listfile[,dirname]] [-arch_only arch] [-o output] [-install_name name] [-compatibility_version #] [-current_version #] [-seg1addr 0x#] [-segs_read_only_addr 0x#] [-segs_read_write_addr 0x#] [-seg_addr_table <filename>] [-seg_addr_table_filename <file_system_path>] [-all_load] [-noall_load] FAILED: rm -f arch/libsafe_numerics.armv7.a && ./gyp-mac-tool filter-libtool libtool -static -o arch/libsafe_numerics.armv7.a error: /Applications/Xcode7.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: no files specified Usage: /Applications/Xcode7.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool -static [-] file [...] [-filelist listfile[,dirname]] [-arch_only arch] [-sacLT] [-no_warning_for_no_symbols] Usage: /Applications/Xcode7.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool -dynamic [-] file [...] [-filelist listfile[,dirname]] [-arch_only arch] [-o output] [-install_name name] [-compatibility_version #] [-current_version #] [-seg1addr 0x#] [-segs_read_only_addr 0x#] [-segs_read_write_addr 0x#] [-seg_addr_table <filename>] [-seg_addr_table_filename <file_system_path>] [-all_load] [-noall_load] ninja: build stopped: subcommand failed. Original issue's description: > Safe numeric library added: base/numerics (copied from Chromium) > > This copies the contents (unittest excluded) of base/numerics in > chromium to base/numerics in webrtc. Files added: > - safe_conversions.h > - safe_conversions_impl.h > - safe_math.h > - safe_math_impl.h > > A really old version of safe_conversions[_impl].h previously existed in > base/, this has been deleted and sources using it have been updated > to include the new base/numerics/safe_converions.h. > > This CL also adds a DEPS file to webrtc/base. > > NOPRESUBMIT=True > BUG=webrtc:5548, webrtc:5623 > > Committed: https://crrev.com/de1c81b2d2196be611674aa6019b9db3a9329042 > Cr-Commit-Position: refs/heads/master@{#11907} TBR=kjellander@webrtc.org,kwiberg@webrtc.org,tina.legrand@webrtc.org,hbos@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:5548, webrtc:5623 Review URL: https://codereview.webrtc.org/1792613002 . Cr-Commit-Position: refs/heads/master@{#11965}
2016-03-11 17:12:32 -08:00
'safe_conversions.h',
'safe_conversions_impl.h',
Add functions to interact with ASan and MSan, and some sample uses The sample uses are from when I debugged bug 617124. The change in neteq_network_stats_unittest.cc is a fix for a minor unrelated bug found by the try bots when I tried to land this CL (a test was passing uninitialized packet data to NetEq). BUG=chromium:617124 Review-Url: https://codereview.webrtc.org/2293893002 Cr-Commit-Position: refs/heads/master@{#14034}
2016-09-02 00:39:33 -07:00
'sanitizer.h',
Move refcount.h and scoped_ref_ptr.h to rtc_base_approved. BUG= Review URL: https://codereview.webrtc.org/1701533002 Cr-Commit-Position: refs/heads/master@{#11615}
2016-02-14 08:11:10 -08:00
'scoped_ref_ptr.h',
Add a target for the approved subset of rtc_base. rtc_base drags in a bunch of unwieldly dependencies (e.g. nss and json) not required for standalone webrtc (aka rtc/media). The root of the problem appears to be that MessageQueue depends on a socket server. (And since common.h -> logging.h -> thread.h -> messagequeue.h, this dependency spreads quickly.) This starts a new target for a "purified" subset of rtc_base. It adds the files which are already being used, replacing the use of common.h with checks.h. desktop_capture is a lost cause, and retains its dependency on the full rtc_base. The hope is that as additional components are desired they will be cleaned and added to rtc_base_approved. BUG=3806 R=andresp@webrtc.org, henrike@webrtc.org Review URL: https://webrtc-codereview.appspot.com/22649004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@7188 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-16 01:03:29 +00:00
'stringencode.cc',
'stringencode.h',
'stringutils.cc',
'stringutils.h',
Move swap_queue.h to base/ This will let us use the SwapQueue as a message queue for the event log's output thread. See https://codereview.webrtc.org/1687703002/ Review URL: https://codereview.webrtc.org/1812823007 Cr-Commit-Position: refs/heads/master@{#12113}
2016-03-24 01:51:52 -07:00
'swap_queue.h',
Move SystemInfo to rtc_base_approved and delete unused code. This cl removes a lot of unused functionality in SystemInfo and reduces dependencies. There's duplicate functionality in this class and WebRTC's CpuInfo class, so I'm consolidating the two implementations. The CpuInfo interface will still exist since it's being used from Chrome to initialize the core count before the sandbox is engaged. With this change, the SystemInfo class will get the benefit too of this initialization. NOTRY=true (using no try due to a dead android try bot) Review URL: https://codereview.webrtc.org/1286163003 Cr-Commit-Position: refs/heads/master@{#9743}
2015-08-20 05:04:09 -07:00
'systeminfo.cc',
'systeminfo.h',
Unify the two copies of template_util.h This patch basically deletes webrtc/base/template_util.h (which is the more outdated copy, although there are only cosmetical differences) and moves webrtc/system_wrappers/source/template_util.h to take its place. The reunified header uses the rtc namespace like the old webrtc/base/template_util.h, rather than the webrtc namespace like webrtc/system_wrappers/source/template_util.h. R=aluebs@webrtc.org, andrew@webrtc.org Review URL: https://webrtc-codereview.appspot.com/38579004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@8050 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-13 20:32:04 +00:00
'template_util.h',
Move thread_annotations.h to webrtc/base/. R=andresp@webrtc.org, mflodman@webrtc.org BUG= Review URL: https://webrtc-codereview.appspot.com/27579004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@7283 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-24 06:05:00 +00:00
'thread_annotations.h',
Move ThreadChecker into rtc_base_approved. To do this, I'm removing ThreadChecker's dependency on the 'Thread' class, so that the checker works with any thread and doesn't rely on TLS. Also simplifying CriticalSection's implementation on Windows since a critical section on Windows already knows what thread currently owns the lock. BUG= R=mflodman@webrtc.org Review URL: https://webrtc-codereview.appspot.com/40539004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@8151 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-26 15:27:29 +00:00
'thread_checker.h',
'thread_checker_impl.cc',
'thread_checker_impl.h',
Implement timestamp translation/filter in VideoCapturer. Use in AndroidVideoCapturer. BUG=webrtc:5740 Review-Url: https://codereview.webrtc.org/2017443003 Cr-Commit-Position: refs/heads/master@{#13254}
2016-06-22 08:36:53 -07:00
'timestampaligner.cc',
'timestampaligner.h',
Add a target for the approved subset of rtc_base. rtc_base drags in a bunch of unwieldly dependencies (e.g. nss and json) not required for standalone webrtc (aka rtc/media). The root of the problem appears to be that MessageQueue depends on a socket server. (And since common.h -> logging.h -> thread.h -> messagequeue.h, this dependency spreads quickly.) This starts a new target for a "purified" subset of rtc_base. It adds the files which are already being used, replacing the use of common.h with checks.h. desktop_capture is a lost cause, and retains its dependency on the full rtc_base. The hope is that as additional components are desired they will be cleaned and added to rtc_base_approved. BUG=3806 R=andresp@webrtc.org, henrike@webrtc.org Review URL: https://webrtc-codereview.appspot.com/22649004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@7188 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-16 01:03:29 +00:00
'timeutils.cc',
'timeutils.h',
Move trace_event and associated files to webrtc/base. Also starting to use TRACE_EVENT from thread.cc in webrtc/base, to track Invoke() calls. BUG= R=magjed@webrtc.org, tina.legrand@webrtc.org Review URL: https://webrtc-codereview.appspot.com/42769004 Cr-Commit-Position: refs/heads/master@{#8755} git-svn-id: http://webrtc.googlecode.com/svn/trunk@8755 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-17 14:25:37 +00:00
'trace_event.h',
rtc::Buffer: Let SetData and AppendData accept anything with .data() and .size() In addition to setting or appending from another Buffer, which was already possible, this allows for e.g. std::vector and rtc::ArrayView arguments. Review-Url: https://codereview.webrtc.org/2293983002 Cr-Commit-Position: refs/heads/master@{#14073}
2016-09-05 07:46:20 -07:00
'type_traits.h',
Moved ByteBuffer/BitBuffer into rtc_base_approved. Also pulls in constructormagic.h, byteorder.h, and basictypes.h. BUG= R=pthatcher@webrtc.org Review URL: https://webrtc-codereview.appspot.com/49069004 Cr-Commit-Position: refs/heads/master@{#9062}
2015-04-22 15:43:08 -07:00
],
'conditions': [
Reland of Initial version of file wrapper Fixes a conversion issue. BUG=webrtc:6177 R=sprang@webrtc.org TBR=mflodman@webrtc.org patch from issue 2214763002 at patchset 450001 (http://crrev.com/2214763002#ps450001) Review URL: https://codereview.webrtc.org/2306553002 . Cr-Commit-Position: refs/heads/master@{#14044}
2016-09-02 13:38:32 +02:00
['os_posix==1', {
'sources': [
'file_posix.cc',
],
}],
['OS=="win"', {
'sources': [
'file_win.cc',
],
}],
Moved ByteBuffer/BitBuffer into rtc_base_approved. Also pulls in constructormagic.h, byteorder.h, and basictypes.h. BUG= R=pthatcher@webrtc.org Review URL: https://webrtc-codereview.appspot.com/49069004 Cr-Commit-Position: refs/heads/master@{#9062}
2015-04-22 15:43:08 -07:00
['build_with_chromium==1', {
Move Chromium logging into rtc_base_approved. The corresponding set of overrides weren't moved when logging.cc etc. was moved over. This wasn't noticed because all existing targets before webrtc fuzzers used to link both rtc_base and rtc_base_approved in Chromium. Also adding //base:base as a dependency, this used to be linked in by other targets either way before but generated build errors when a target solely depends on rtc_base_approved. BUG=webrtc:4771 R=kjellander@webrtc.org TBR=henrikg@webrtc.org Review URL: https://codereview.webrtc.org/1473223005 . Cr-Commit-Position: refs/heads/master@{#10792}
2015-11-25 21:36:14 +01:00
'dependencies': [
'<(DEPTH)/base/base.gyp:base',
],
Moved ByteBuffer/BitBuffer into rtc_base_approved. Also pulls in constructormagic.h, byteorder.h, and basictypes.h. BUG= R=pthatcher@webrtc.org Review URL: https://webrtc-codereview.appspot.com/49069004 Cr-Commit-Position: refs/heads/master@{#9062}
2015-04-22 15:43:08 -07:00
'include_dirs': [
Update build files to use webrtc_overrides in Chromium instead of overrides. This re-lands https://codereview.webrtc.org/1354933002/ This is a part of moving the overrides to Chromium. See bug comment #65 for all steps. Depends on https://codereview.chromium.org/1345873004/ BUG=chromium:468375 Review URL: https://codereview.webrtc.org/1345313004 Cr-Commit-Position: refs/heads/master@{#10115}
2015-09-30 03:48:52 -07:00
'../../webrtc_overrides',
Moved ByteBuffer/BitBuffer into rtc_base_approved. Also pulls in constructormagic.h, byteorder.h, and basictypes.h. BUG= R=pthatcher@webrtc.org Review URL: https://webrtc-codereview.appspot.com/49069004 Cr-Commit-Position: refs/heads/master@{#9062}
2015-04-22 15:43:08 -07:00
],
Move Chromium logging into rtc_base_approved. The corresponding set of overrides weren't moved when logging.cc etc. was moved over. This wasn't noticed because all existing targets before webrtc fuzzers used to link both rtc_base and rtc_base_approved in Chromium. Also adding //base:base as a dependency, this used to be linked in by other targets either way before but generated build errors when a target solely depends on rtc_base_approved. BUG=webrtc:4771 R=kjellander@webrtc.org TBR=henrikg@webrtc.org Review URL: https://codereview.webrtc.org/1473223005 . Cr-Commit-Position: refs/heads/master@{#10792}
2015-11-25 21:36:14 +01:00
'sources': [
'../../webrtc_overrides/webrtc/base/logging.cc',
'../../webrtc_overrides/webrtc/base/logging.h',
],
Reland of Cleanup webrtc/base/base.gyp (patchset #1 id:1 of https://codereview.webrtc.org/1856323003/ ) Reason for revert: Creating template CL for reland Original issue's description: > Revert of Cleanup webrtc/base/base.gyp (patchset #2 id:80001 of https://codereview.webrtc.org/1859803002/ ) > > Reason for revert: > For some odd reason this breaks chromium.webrtc.fyi bots: > ../../third_party/webrtc_overrides/webrtc/base/win32socketinit.cc:13:2: error: "Only compile this on Windows" > #error "Only compile this on Windows" > ^ > 1 error generated. > > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/11515/steps/compile/logs/stdio > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/builds/4650/steps/compile/logs/stdio > > Original issue's description: > > Cleanup webrtc/base/base.gyp > > > > * Remove all source exclusions since they make the file very hard to > > read and heavily increases the risk for mistakes. > > * Don't compile the openssl* sources if use_openssl==0. > > * Move platform specific sources into conditional includes to make it > > easier to verify a 1:1 mapping with BUILD.gn (since GN doesn't support > > automatic detection of platform specific sources based on filenames). > > * Add missing sources for the GN build. > > * Reorder some blocks to make GYP vs GN mapping match. > > > > BUG=webrtc:4256 > > R=perkj@webrtc.org, torbjorng@webrtc.org > > > > Committed: https://crrev.com/47f33cb28ffb0fa0f053ae0aa0086e11f85bf444 > > Cr-Commit-Position: refs/heads/master@{#12235} > > TBR=perkj@webrtc.org,torbjorng@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:4256 > NOTRY=True > > Committed: https://crrev.com/c8587ad92d394bfb60498df1209a3beb9017e001 > Cr-Commit-Position: refs/heads/master@{#12237} TBR=perkj@webrtc.org,torbjorng@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4256 Review URL: https://codereview.webrtc.org/1857163003 Cr-Commit-Position: refs/heads/master@{#12242}
2016-04-05 08:13:31 -07:00
}, {
'sources': [
Move base/logging.* to rtc_base_approved. BUG= R=pbos@webrtc.org Review URL: https://webrtc-codereview.appspot.com/47299004 Cr-Commit-Position: refs/heads/master@{#9272}
2015-05-25 10:45:43 +02:00
'logging.cc',
'logging.h',
Replace use of GetMacOSStatusErrorString (deprecated) with use of NSOSStatusErrorDomain. This should unblock the roll. TBR=kjellander@webrtc.org Review URL: https://codereview.webrtc.org/1921463002 . Cr-Commit-Position: refs/heads/master@{#12479}
2016-04-24 17:32:48 +02:00
'logging_mac.mm',
Moved ByteBuffer/BitBuffer into rtc_base_approved. Also pulls in constructormagic.h, byteorder.h, and basictypes.h. BUG= R=pthatcher@webrtc.org Review URL: https://webrtc-codereview.appspot.com/49069004 Cr-Commit-Position: refs/heads/master@{#9062}
2015-04-22 15:43:08 -07:00
],
Reland of New task queueing primitive for async tasks: TaskQueue. New task queueing primitive for async tasks: TaskQueue. TaskQueue is a new way to asynchronously execute tasks sequentially in a thread safe manner with minimal locking. The implementation uses OS supported APIs to do this that are compatible with async IO notifications from things like sockets and files. This class is a part of rtc_base_approved, so can be used by both the webrtc and libjingle parts of the WebRTC library. Moving forward, we can replace rtc::Thread and webrtc::ProcessThread with this implementation. NOTE: It should not be assumed that all tasks that execute on a TaskQueue, run on the same thread. E.g. on Mac and iOS, we use GCD dispatch queues which means that tasks might execute on different threads depending on what's the most efficient thing to do. TBR=perkj@webrtc.org,phoglund@webrtc.org Review-Url: https://codereview.webrtc.org/1984503002 Cr-Commit-Position: refs/heads/master@{#12749}
2016-05-14 11:31:40 -07:00
}],
Split TaskQueue out into a separate build target. This is needed as there are targets such as newlib_pnacl/remoting_client_plugin_newlib.pexe that depend on rtc_base_approved but don't need TaskQueue. We could implement support for TaskQueue in nacl using ppapi types, but it looks like there isn't a need for it. Libevent isn't supported for nacl either, so I'm introducing a layer on top of rtc_base_approved for TaskQueue. It's conceivable that this target will morph into a target that holds other threading primitives such as platform_thread and possibly socket related operations, which is also an area that we currently #ifdef out for nacl in a few places. Functional change: Removes the "is_nacl" check. R=phoglund@webrtc.org Review-Url: https://codereview.webrtc.org/2001913002 Cr-Commit-Position: refs/heads/master@{#12878}
2016-05-24 11:40:35 -07:00
['OS=="mac" and build_with_chromium==0', {
'all_dependent_settings': {
'xcode_settings': {
'OTHER_LDFLAGS': [
# needed for logging_mac.mm
'-framework Foundation',
],
},
},
}], # OS=="mac" and build_with_chromium==0
Migrated GN target :g711_test Migrated GN target :g711_test from webrtc/modules/audio_coding/codecs/g711/g711.gypi NOTRY=True BUG=webrtc:6191 Review-Url: https://codereview.webrtc.org/2273623002 Cr-Commit-Position: refs/heads/master@{#13864}
2016-08-23 08:08:23 -07:00
['OS=="android"', {
'link_settings': {
'libraries': [
'-llog',
],
},
}],
Split TaskQueue out into a separate build target. This is needed as there are targets such as newlib_pnacl/remoting_client_plugin_newlib.pexe that depend on rtc_base_approved but don't need TaskQueue. We could implement support for TaskQueue in nacl using ppapi types, but it looks like there isn't a need for it. Libevent isn't supported for nacl either, so I'm introducing a layer on top of rtc_base_approved for TaskQueue. It's conceivable that this target will morph into a target that holds other threading primitives such as platform_thread and possibly socket related operations, which is also an area that we currently #ifdef out for nacl in a few places. Functional change: Removes the "is_nacl" check. R=phoglund@webrtc.org Review-Url: https://codereview.webrtc.org/2001913002 Cr-Commit-Position: refs/heads/master@{#12878}
2016-05-24 11:40:35 -07:00
],
},
{
'target_name': 'rtc_task_queue',
'type': 'static_library',
'dependencies': [
'rtc_base_approved',
],
'sources': [
Implement SequencedTaskChecker. SequencedTaskChecker is a helper class used to help verify that some methods of a class are called on the same task queue or thread. A SequencedTaskChecker is bound to a a task queue if the object is created on a task queue, or a thread otherwise. BUG=webrtc:5687 Review-Url: https://codereview.webrtc.org/2125113003 Cr-Commit-Position: refs/heads/master@{#13452}
2016-07-12 15:04:07 -07:00
'sequenced_task_checker.h',
'sequenced_task_checker_impl.cc',
'sequenced_task_checker_impl.h',
Split TaskQueue out into a separate build target. This is needed as there are targets such as newlib_pnacl/remoting_client_plugin_newlib.pexe that depend on rtc_base_approved but don't need TaskQueue. We could implement support for TaskQueue in nacl using ppapi types, but it looks like there isn't a need for it. Libevent isn't supported for nacl either, so I'm introducing a layer on top of rtc_base_approved for TaskQueue. It's conceivable that this target will morph into a target that holds other threading primitives such as platform_thread and possibly socket related operations, which is also an area that we currently #ifdef out for nacl in a few places. Functional change: Removes the "is_nacl" check. R=phoglund@webrtc.org Review-Url: https://codereview.webrtc.org/2001913002 Cr-Commit-Position: refs/heads/master@{#12878}
2016-05-24 11:40:35 -07:00
],
'conditions': [
Do not build task_queue.cc and include from webrtc_overrides in Chrome. This is step 2 of the plan below. The modified plan 1. First land unmodified task_queue.h into webrtc_override in Chrome 2. Modify build files in the webrtc repo to include the task_queue.h and task_queue.cc from webrtc_overrides. This will breaks webrtc Chrome FYI. 3. Combine a roll of webrtc to Chrome and a the cl in https://codereview.chromium.org/2293913003/ into one cl. The combined cl will roll in build files from 2 and add task_queue.cc in webrtc_overrides and build task_queue_unittest.cc as part of content_unittests to test task_queue.cc in webrtc_overrides. 4... Start using task queues in webrtc........ BUG=webrtc:5687 Review-Url: https://codereview.webrtc.org/2289203002 Cr-Commit-Position: refs/heads/master@{#13983}
2016-08-30 23:01:06 -07:00
['build_with_chromium==1', {
'include_dirs': [
'../../webrtc_overrides'
Fix component build in chrome after recent TaskQueue cl TBR=phoglund Review URL: https://codereview.webrtc.org/1985533002 . Cr-Commit-Position: refs/heads/master@{#12753}
2016-05-15 13:42:45 +02:00
],
Do not build task_queue.cc and include from webrtc_overrides in Chrome. This is step 2 of the plan below. The modified plan 1. First land unmodified task_queue.h into webrtc_override in Chrome 2. Modify build files in the webrtc repo to include the task_queue.h and task_queue.cc from webrtc_overrides. This will breaks webrtc Chrome FYI. 3. Combine a roll of webrtc to Chrome and a the cl in https://codereview.chromium.org/2293913003/ into one cl. The combined cl will roll in build files from 2 and add task_queue.cc in webrtc_overrides and build task_queue_unittest.cc as part of content_unittests to test task_queue.cc in webrtc_overrides. 4... Start using task queues in webrtc........ BUG=webrtc:5687 Review-Url: https://codereview.webrtc.org/2289203002 Cr-Commit-Position: refs/heads/master@{#13983}
2016-08-30 23:01:06 -07:00
'sources' : [
'../../webrtc_overrides/webrtc/base/task_queue.cc',
'../../webrtc_overrides/webrtc/base/task_queue.h',
]
} , {
# If not build for chromium, use our own implementation.
'sources' : [
'task_queue.h',
'task_queue_posix.h',
Separate building and enabling libevent. We're now ready https://codereview.webrtc.org/1984503002/ downstream, so make sure we can enable libevent but still choose which libevent implementation to use. This follows the common pattern where an enable_ flag controls whether we should use the feature at all, whereas build_ controls if we should use the dependency from our DEPS file or something else. NOTRY=True Review-Url: https://codereview.webrtc.org/1980003002 Cr-Commit-Position: refs/heads/master@{#12772}
2016-05-17 03:44:28 -07:00
],
Reland of New task queueing primitive for async tasks: TaskQueue. New task queueing primitive for async tasks: TaskQueue. TaskQueue is a new way to asynchronously execute tasks sequentially in a thread safe manner with minimal locking. The implementation uses OS supported APIs to do this that are compatible with async IO notifications from things like sockets and files. This class is a part of rtc_base_approved, so can be used by both the webrtc and libjingle parts of the WebRTC library. Moving forward, we can replace rtc::Thread and webrtc::ProcessThread with this implementation. NOTE: It should not be assumed that all tasks that execute on a TaskQueue, run on the same thread. E.g. on Mac and iOS, we use GCD dispatch queues which means that tasks might execute on different threads depending on what's the most efficient thing to do. TBR=perkj@webrtc.org,phoglund@webrtc.org Review-Url: https://codereview.webrtc.org/1984503002 Cr-Commit-Position: refs/heads/master@{#12749}
2016-05-14 11:31:40 -07:00
'conditions': [
Do not build task_queue.cc and include from webrtc_overrides in Chrome. This is step 2 of the plan below. The modified plan 1. First land unmodified task_queue.h into webrtc_override in Chrome 2. Modify build files in the webrtc repo to include the task_queue.h and task_queue.cc from webrtc_overrides. This will breaks webrtc Chrome FYI. 3. Combine a roll of webrtc to Chrome and a the cl in https://codereview.chromium.org/2293913003/ into one cl. The combined cl will roll in build files from 2 and add task_queue.cc in webrtc_overrides and build task_queue_unittest.cc as part of content_unittests to test task_queue.cc in webrtc_overrides. 4... Start using task queues in webrtc........ BUG=webrtc:5687 Review-Url: https://codereview.webrtc.org/2289203002 Cr-Commit-Position: refs/heads/master@{#13983}
2016-08-30 23:01:06 -07:00
['build_libevent==1', {
'dependencies': [
'<(DEPTH)/base/third_party/libevent/libevent.gyp:libevent',
],
Reland of New task queueing primitive for async tasks: TaskQueue. New task queueing primitive for async tasks: TaskQueue. TaskQueue is a new way to asynchronously execute tasks sequentially in a thread safe manner with minimal locking. The implementation uses OS supported APIs to do this that are compatible with async IO notifications from things like sockets and files. This class is a part of rtc_base_approved, so can be used by both the webrtc and libjingle parts of the WebRTC library. Moving forward, we can replace rtc::Thread and webrtc::ProcessThread with this implementation. NOTE: It should not be assumed that all tasks that execute on a TaskQueue, run on the same thread. E.g. on Mac and iOS, we use GCD dispatch queues which means that tasks might execute on different threads depending on what's the most efficient thing to do. TBR=perkj@webrtc.org,phoglund@webrtc.org Review-Url: https://codereview.webrtc.org/1984503002 Cr-Commit-Position: refs/heads/master@{#12749}
2016-05-14 11:31:40 -07:00
}],
Do not build task_queue.cc and include from webrtc_overrides in Chrome. This is step 2 of the plan below. The modified plan 1. First land unmodified task_queue.h into webrtc_override in Chrome 2. Modify build files in the webrtc repo to include the task_queue.h and task_queue.cc from webrtc_overrides. This will breaks webrtc Chrome FYI. 3. Combine a roll of webrtc to Chrome and a the cl in https://codereview.chromium.org/2293913003/ into one cl. The combined cl will roll in build files from 2 and add task_queue.cc in webrtc_overrides and build task_queue_unittest.cc as part of content_unittests to test task_queue.cc in webrtc_overrides. 4... Start using task queues in webrtc........ BUG=webrtc:5687 Review-Url: https://codereview.webrtc.org/2289203002 Cr-Commit-Position: refs/heads/master@{#13983}
2016-08-30 23:01:06 -07:00
['enable_libevent==1', {
'sources': [
'task_queue_libevent.cc',
'task_queue_posix.cc',
],
'defines': [ 'WEBRTC_BUILD_LIBEVENT' ],
'all_dependent_settings': {
'defines': [ 'WEBRTC_BUILD_LIBEVENT' ]
},
}, {
# If not libevent, fall back to the other task queues.
'conditions': [
['OS=="mac" or OS=="ios"', {
'sources': [
'task_queue_gcd.cc',
'task_queue_posix.cc',
],
}],
['OS=="win"', {
'sources': [ 'task_queue_win.cc' ],
}]
],
}],
]
Reland of New task queueing primitive for async tasks: TaskQueue. New task queueing primitive for async tasks: TaskQueue. TaskQueue is a new way to asynchronously execute tasks sequentially in a thread safe manner with minimal locking. The implementation uses OS supported APIs to do this that are compatible with async IO notifications from things like sockets and files. This class is a part of rtc_base_approved, so can be used by both the webrtc and libjingle parts of the WebRTC library. Moving forward, we can replace rtc::Thread and webrtc::ProcessThread with this implementation. NOTE: It should not be assumed that all tasks that execute on a TaskQueue, run on the same thread. E.g. on Mac and iOS, we use GCD dispatch queues which means that tasks might execute on different threads depending on what's the most efficient thing to do. TBR=perkj@webrtc.org,phoglund@webrtc.org Review-Url: https://codereview.webrtc.org/1984503002 Cr-Commit-Position: refs/heads/master@{#12749}
2016-05-14 11:31:40 -07:00
}],
Add a target for the approved subset of rtc_base. rtc_base drags in a bunch of unwieldly dependencies (e.g. nss and json) not required for standalone webrtc (aka rtc/media). The root of the problem appears to be that MessageQueue depends on a socket server. (And since common.h -> logging.h -> thread.h -> messagequeue.h, this dependency spreads quickly.) This starts a new target for a "purified" subset of rtc_base. It adds the files which are already being used, replacing the use of common.h with checks.h. desktop_capture is a lost cause, and retains its dependency on the full rtc_base. The hope is that as additional components are desired they will be cleaned and added to rtc_base_approved. BUG=3806 R=andresp@webrtc.org, henrike@webrtc.org Review URL: https://webrtc-codereview.appspot.com/22649004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@7188 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-16 01:03:29 +00:00
],
},
Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base. BUG=N/A R=niklas.enbom@webrtc.org Review URL: https://webrtc-codereview.appspot.com/17479005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6129 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 18:00:26 +00:00
{
Put base tests in webrtc_tests.gyp BUG=N/A R=andrew@webrtc.org, pbos@webrtc.org Review URL: https://webrtc-codereview.appspot.com/14249004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@7140 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-10 17:28:19 +00:00
'target_name': 'rtc_base',
Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base. BUG=N/A R=niklas.enbom@webrtc.org Review URL: https://webrtc-codereview.appspot.com/17479005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6129 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 18:00:26 +00:00
'type': 'static_library',
Add a target for the approved subset of rtc_base. rtc_base drags in a bunch of unwieldly dependencies (e.g. nss and json) not required for standalone webrtc (aka rtc/media). The root of the problem appears to be that MessageQueue depends on a socket server. (And since common.h -> logging.h -> thread.h -> messagequeue.h, this dependency spreads quickly.) This starts a new target for a "purified" subset of rtc_base. It adds the files which are already being used, replacing the use of common.h with checks.h. desktop_capture is a lost cause, and retains its dependency on the full rtc_base. The hope is that as additional components are desired they will be cleaned and added to rtc_base_approved. BUG=3806 R=andresp@webrtc.org, henrike@webrtc.org Review URL: https://webrtc-codereview.appspot.com/22649004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@7188 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-16 01:03:29 +00:00
'dependencies': [
Fix style violations in common_types.h and config.h Mostly, it's about moving constructors and descructors to the .cc files, so that they won't be inlined everywhere. The reason this CL is so big is that a lot of code was using common_types.h without declaring a dependency on webrtc_common, which broke the build once common_types.h started to depend on common_types.cc. BUG=163 R=kjellander@webrtc.org Review URL: https://webrtc-codereview.appspot.com/26089004 Cr-Commit-Position: refs/heads/master@{#8516} git-svn-id: http://webrtc.googlecode.com/svn/trunk@8516 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-26 13:59:22 +00:00
'<(webrtc_root)/common.gyp:webrtc_common',
Add a target for the approved subset of rtc_base. rtc_base drags in a bunch of unwieldly dependencies (e.g. nss and json) not required for standalone webrtc (aka rtc/media). The root of the problem appears to be that MessageQueue depends on a socket server. (And since common.h -> logging.h -> thread.h -> messagequeue.h, this dependency spreads quickly.) This starts a new target for a "purified" subset of rtc_base. It adds the files which are already being used, replacing the use of common.h with checks.h. desktop_capture is a lost cause, and retains its dependency on the full rtc_base. The hope is that as additional components are desired they will be cleaned and added to rtc_base_approved. BUG=3806 R=andresp@webrtc.org, henrike@webrtc.org Review URL: https://webrtc-codereview.appspot.com/22649004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@7188 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-16 01:03:29 +00:00
'rtc_base_approved',
],
Make :rtc_base_approved a public dep of :rtc_base. It looks to me like targets :rtc_base_approved is logically a subset of :rtc_base, and so any targets depending on :rtc_base expect to also get access to the headers in :rtc_base_approved. Thus I think it's appropriate for :rtc_base to have :rtc_base_approved in public_deps, so that `gn check` will permit this without clients having to explicitly depend on both. NOTRY=True Review URL: https://codereview.webrtc.org/1578833002 Cr-Commit-Position: refs/heads/master@{#11227}
2016-01-12 09:46:55 -08:00
'export_dependent_settings': [
'rtc_base_approved',
],
Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base. BUG=N/A R=niklas.enbom@webrtc.org Review URL: https://webrtc-codereview.appspot.com/17479005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6129 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 18:00:26 +00:00
'defines': [
'FEATURE_ENABLE_SSL',
Purge nss files and dependencies. This replaces https://codereview.webrtc.org/1313233005 which was reverted after triggering Chromium issues. The only difference is that we're cleaned up dependencies on use_openssl from the gyp file. Since https://codereview.chromium.org/1358913003 landed, this CL should cause no Chromium issues. BUG=webrtc:4497 Review URL: https://codereview.webrtc.org/1351503004 Cr-Commit-Position: refs/heads/master@{#10019}
2015-09-22 11:58:04 -07:00
'SSL_USE_OPENSSL',
'HAVE_OPENSSL_SSL_H',
Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base. BUG=N/A R=niklas.enbom@webrtc.org Review URL: https://webrtc-codereview.appspot.com/17479005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6129 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 18:00:26 +00:00
'LOGGING=1',
],
'sources': [
Reland of move all reference to carbon api (patchset #1 id:1 of https://codereview.webrtc.org/2317343003/ ) Reason for revert: Build issues have now _really_ been fixed Original issue's description: > Revert of move all reference to carbon api (patchset #2 id:300001 of https://codereview.webrtc.org/2321493002/ ) > > Reason for revert: > Still breaks Chromium mac compile: > [4542/22193] CXX obj/third_party/webrtc/base/rtc_base/unixfilesystem.o > FAILED: obj/third_party/webrtc/base/rtc_base/unixfilesystem.o > /b/c/cipd/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/webrtc/base/rtc_base/unixfilesystem.o.d -DLOGGING=1 -DV8_DEPRECATION_WARNINGS -DENABLE_NOTIFICATIONS -DENABLE_PEPPER_CDMS -DENABLE_PLUGINS=1 -DENABLE_PDF=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DUSE_BROWSER_SPELLCHECKER=1 -DDCHECK_ALWAYS_ON=1 -DNO_TCMALLOC -DUSE_EXTERNAL_POPUP_MENU=1 -DENABLE_WEBRTC=1 -DENABLE_EXTENSIONS=1 -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DUSE_PROPRIETARY_CODECS -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=280106-1 -DCR_XCODE_VERSION=0511 -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DWEBRTC_RESTRICT_LOGGING -DEXPAT_RELATIVE_PATH -DENABLE_EXTERNAL_AUTH -DHAVE_OPENSSL_SSL_H -DHAVE_SCTP -DHAVE_SRTP -DHAVE_WEBRTC_VIDEO -DHAVE_WEBRTC_VOICE -DLOGGING_INSIDE_WEBRTC -DSRTP_RELATIVE_PATH -DSSL_USE_OPENSSL -DUSE_WEBRTC_DEV_BRANCH -DSSL_USE_OPENSSL -DHAVE_OPENSSL_SSL_H -DFEATURE_ENABLE_SSL -DLOGGING=1 -DFEATURE_ENABLE_SSL -DFEATURE_ENABLE_VOICEMAIL -DEXPAT_RELATIVE_PATH -DGTEST_RELATIVE_PATH -DNO_MAIN_THREAD_WRAPPING -DNO_SOUND_SYSTEM -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_POSIX -DWEBRTC_MAC -DNO_MAIN_THREAD_WRAPPING -I../../third_party/webrtc_overrides -I../../third_party/boringssl/src/include -I../.. -Igen -I../../third_party/jsoncpp/overrides/include -I../../third_party/jsoncpp/source/include -I../../third_party/webrtc_overrides -I../../third_party -I../../third_party/boringssl/src/include -Wno-uninitialized -fno-strict-aliasing -fstack-protector -fcolor-diagnostics -arch x86_64 -O2 -g1 -isysroot /Applications/Xcode5.1.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk -mmacosx-version-min=10.7 -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Wheader-hygiene -Wstring-conversion -Werror -Wall -Wno-unused-variable -Wpartial-availability -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -fno-threadsafe-statics -fvisibility-inlines-hidden -std=c++11 -stdlib=libc++ -fno-rtti -fno-exceptions -c ../../third_party/webrtc/base/unixfilesystem.cc -o obj/third_party/webrtc/base/rtc_base/unixfilesystem.o > ../../third_party/webrtc/base/unixfilesystem.cc:375:11: error: variable has incomplete type 'FSRef' > FSRef fr; > ^ > /Applications/Xcode5.1.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/System/Library/Frameworks/CoreFoundation.framework/Headers/CFURL.h:467:8: note: forward declaration of 'FSRef' > struct FSRef; > ^ > ../../third_party/webrtc/base/unixfilesystem.cc:376:27: error: use of undeclared identifier 'kUserDomain' > if (0 != FSFindFolder(kUserDomain, kApplicationSupportFolderType, > ^ > ../../third_party/webrtc/base/unixfilesystem.cc:376:40: error: use of undeclared identifier 'kApplicationSupportFolderType' > if (0 != FSFindFolder(kUserDomain, kApplicationSupportFolderType, > ^ > ../../third_party/webrtc/base/unixfilesystem.cc:377:27: error: use of undeclared identifier 'kCreateFolder'; did you mean 'CreateFolder'? > kCreateFolder, &fr)) > ^~~~~~~~~~~~~ > CreateFolder > ../../third_party/webrtc/base/unixfilesystem.cc:92:22: note: 'CreateFolder' declared here > bool UnixFilesystem::CreateFolder(const Pathname &path, mode_t mode) { > > Original issue's description: > > Reland of move all reference to carbon api (patchset #1 id:1 of https://codereview.webrtc.org/2316563002/ ) > > > > Reason for revert: > > Chromium build issues have been resolved. > > > > Original issue's description: > > > Revert of Remove all reference to carbon api (patchset #2 id:20001 of https://codereview.webrtc.org/2299633002/ ) > > > > > > Reason for revert: > > > Breaks chromium build > > > > > > Original issue's description: > > > > Remove all reference to carbon api > > > > > > > > BUG=webrtc:6282 > > > > > > > > Committed: https://crrev.com/dbd8b6bec4143c940b2f2ca8cd85c25d17327964 > > > > Cr-Commit-Position: refs/heads/master@{#14080} > > > > > > TBR=magjed@webrtc.org,mflodman@webrtc.org > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > NOPRESUBMIT=true > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG=webrtc:6282 > > > > > > Committed: https://crrev.com/b096aa7fd375a980daab3a986596548ca5de2a1c > > > Cr-Commit-Position: refs/heads/master@{#14081} > > > > TBR=magjed@webrtc.org,mflodman@webrtc.org > > # Not skipping CQ checks because original CL landed more than 1 days ago. > > BUG=webrtc:6282 > > > > Committed: https://crrev.com/a90879b64fd8db57c0274169311d6b51dd59f1a0 > > Cr-Commit-Position: refs/heads/master@{#14125} > > TBR=mflodman@webrtc.org,kthelgason@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6282 > > Committed: https://crrev.com/4e0581f543b026cbc31c3b24cf65c7f51dcd6124 > Cr-Commit-Position: refs/heads/master@{#14133} TBR=mflodman@webrtc.org,magjed@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6282 Review-Url: https://codereview.webrtc.org/2327573002 Cr-Commit-Position: refs/heads/master@{#14155}
2016-09-09 03:19:48 -07:00
'applefilesystem.mm',
Add arraysize() macro from Chromium, and make use of it in a few places. This not only shortens some test code, it makes it more robust against changing the lengths of the arrays later and forgetting to update the length constants (which bit me). BUG=none TEST=none R=hta@webrtc.org, tommi@webrtc.org Review URL: https://webrtc-codereview.appspot.com/34829004 Cr-Commit-Position: refs/heads/master@{#8191} git-svn-id: http://webrtc.googlecode.com/svn/trunk@8191 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-28 21:36:55 +00:00
'arraysize.h',
Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base. BUG=N/A R=niklas.enbom@webrtc.org Review URL: https://webrtc-codereview.appspot.com/17479005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6129 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 18:00:26 +00:00
'asyncfile.cc',
'asyncfile.h',
'asyncinvoker.cc',
'asyncinvoker.h',
Add missing sources to webrtc/base/base.gyp During my work on setting up a GN build for WebRTC, I discovered that the base.gyp is trying to remove source files (for the Chromium build) that are not added in the initial set. I assume these files should be listed and that GYP just doesn't complain when it's trying to remove a file that is not present in the sources list. natserver_main.cc is also removed, since it's not used anywhere. There are also a couple of other header files that are used in other code that probably also should be listed in base.gyp (please do this in another CL): * compile_assert.h * dscp.h * move.h * template_util.h BUG=None TEST=Trybots passing clobber compile step. R=henrike@webrtc.org Review URL: https://webrtc-codereview.appspot.com/13659004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6438 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-16 07:11:19 +00:00
'asyncinvoker-inl.h',
Fix clang style warnings in webrtc/base Mostly this consists of marking functions with override when applicable, and moving function bodies from .h to .cc files. Not inlining virtual functions with simple bodies such as { return false; } strikes me as probably losing more in readability than we gain in binary size and compilation time, but I guess it's just like any other case where enabling a generally good warning forces us to write slightly worse code in a couple of places. BUG=163 R=kjellander@webrtc.org, tommi@webrtc.org Review URL: https://webrtc-codereview.appspot.com/47429004 Cr-Commit-Position: refs/heads/master@{#8656} git-svn-id: http://webrtc.googlecode.com/svn/trunk@8656 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-09 22:21:53 +00:00
'asyncpacketsocket.cc',
Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base. BUG=N/A R=niklas.enbom@webrtc.org Review URL: https://webrtc-codereview.appspot.com/17479005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6129 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 18:00:26 +00:00
'asyncpacketsocket.h',
Fix clang style warnings in webrtc/base Mostly this consists of marking functions with override when applicable, and moving function bodies from .h to .cc files. Not inlining virtual functions with simple bodies such as { return false; } strikes me as probably losing more in readability than we gain in binary size and compilation time, but I guess it's just like any other case where enabling a generally good warning forces us to write slightly worse code in a couple of places. BUG=163 R=kjellander@webrtc.org, tommi@webrtc.org Review URL: https://webrtc-codereview.appspot.com/47429004 Cr-Commit-Position: refs/heads/master@{#8656} git-svn-id: http://webrtc.googlecode.com/svn/trunk@8656 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-09 22:21:53 +00:00
'asyncresolverinterface.cc',
Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base. BUG=N/A R=niklas.enbom@webrtc.org Review URL: https://webrtc-codereview.appspot.com/17479005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6129 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 18:00:26 +00:00
'asyncresolverinterface.h',
'asyncsocket.cc',
'asyncsocket.h',
'asynctcpsocket.cc',
'asynctcpsocket.h',
'asyncudpsocket.cc',
'asyncudpsocket.h',
'autodetectproxy.cc',
'autodetectproxy.h',
'base64.cc',
'base64.h',
'common.cc',
'common.h',
'crc32.cc',
'crc32.h',
Fix clang style warnings in webrtc/base Mostly this consists of marking functions with override when applicable, and moving function bodies from .h to .cc files. Not inlining virtual functions with simple bodies such as { return false; } strikes me as probably losing more in readability than we gain in binary size and compilation time, but I guess it's just like any other case where enabling a generally good warning forces us to write slightly worse code in a couple of places. BUG=163 R=kjellander@webrtc.org, tommi@webrtc.org Review URL: https://webrtc-codereview.appspot.com/47429004 Cr-Commit-Position: refs/heads/master@{#8656} git-svn-id: http://webrtc.googlecode.com/svn/trunk@8656 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-09 22:21:53 +00:00
'cryptstring.cc',
Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base. BUG=N/A R=niklas.enbom@webrtc.org Review URL: https://webrtc-codereview.appspot.com/17479005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6129 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 18:00:26 +00:00
'cryptstring.h',
'diskcache.cc',
'diskcache.h',
Provides log sinks for rotating logs. Intended for use on mobile devices to record call logs. BUG=4838 Review URL: https://codereview.webrtc.org/1230823009 Cr-Commit-Position: refs/heads/master@{#9615}
2015-07-22 12:12:17 -07:00
'filerotatingstream.cc',
'filerotatingstream.h',
Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base. BUG=N/A R=niklas.enbom@webrtc.org Review URL: https://webrtc-codereview.appspot.com/17479005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6129 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 18:00:26 +00:00
'fileutils.cc',
'fileutils.h',
'firewallsocketserver.cc',
'firewallsocketserver.h',
'flags.cc',
'flags.h',
'gunit_prod.h',
'helpers.cc',
'helpers.h',
'httpbase.cc',
'httpbase.h',
'httpclient.cc',
'httpclient.h',
'httpcommon-inl.h',
'httpcommon.cc',
'httpcommon.h',
'httprequest.cc',
'httprequest.h',
'ipaddress.cc',
'ipaddress.h',
'linked_ptr.h',
'messagedigest.cc',
'messagedigest.h',
'messagehandler.cc',
'messagehandler.h',
'messagequeue.cc',
'messagequeue.h',
'nethelpers.cc',
'nethelpers.h',
'network.cc',
'network.h',
Create network change notifier and pass the event to NetworkManager BUG= Review URL: https://codereview.webrtc.org/1391703003 Cr-Commit-Position: refs/heads/master@{#10325}
2015-10-19 09:39:32 -07:00
'networkmonitor.cc',
'networkmonitor.h',
Adds clearer function to create rtc::Thread without Physical SocketServer Moves logic of default SocketServer from MessageQueue to SocketServer Review-Url: https://codereview.webrtc.org/1891293002 Cr-Commit-Position: refs/heads/master@{#12541}
2016-04-28 01:32:48 -07:00
'nullsocketserver.cc',
Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base. BUG=N/A R=niklas.enbom@webrtc.org Review URL: https://webrtc-codereview.appspot.com/17479005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6129 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 18:00:26 +00:00
'nullsocketserver.h',
Purge nss files and dependencies. This replaces https://codereview.webrtc.org/1313233005 which was reverted after triggering Chromium issues. The only difference is that we're cleaned up dependencies on use_openssl from the gyp file. Since https://codereview.chromium.org/1358913003 landed, this CL should cause no Chromium issues. BUG=webrtc:4497 Review URL: https://codereview.webrtc.org/1351503004 Cr-Commit-Position: refs/heads/master@{#10019}
2015-09-22 11:58:04 -07:00
'openssl.h',
'openssladapter.cc',
'openssladapter.h',
'openssldigest.cc',
'openssldigest.h',
'opensslidentity.cc',
'opensslidentity.h',
'opensslstreamadapter.cc',
'opensslstreamadapter.h',
Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base. BUG=N/A R=niklas.enbom@webrtc.org Review URL: https://webrtc-codereview.appspot.com/17479005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6129 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 18:00:26 +00:00
'pathutils.cc',
'pathutils.h',
'physicalsocketserver.cc',
'physicalsocketserver.h',
'proxydetect.cc',
'proxydetect.h',
'proxyinfo.cc',
'proxyinfo.h',
'ratelimiter.cc',
'ratelimiter.h',
Adds RTCCertificate, a reference counted object indirectly owning an SSLCertificate (by owning the SSLIdentity). BUG=webrtc:4927 R=tommi@chromium.org, tommi@webrtc.org, torbjorng@webrtc.org Review URL: https://codereview.webrtc.org/1299223002 . Cr-Commit-Position: refs/heads/master@{#9741}
2015-08-20 12:15:54 +02:00
'rtccertificate.cc',
'rtccertificate.h',
RTCCertificateGenerator added. This is a new way of generating RTCCertificate objects that is meant to replace DtlsIdentityStoreInterface and all of its implementations (clean up work). It is similar to the identity store in that it generates on the worker thread and does callback on the signaling thread, but: - It does not generate identities in the background that you did not ask for (preemptive generation made more sense before certificates were parameterized, not so much anymore, and ECDSA which will be most common takes like <=2 ms to generate). - As such this code is less complicated than the store's code. - The API is different, it takes Optional<uint64_t> expires and it returns RTCCertificates, not SSLIdentities. - It supports a blocking version of GenerateCertificate that can be called from any thread, necessary for Chrome which can generate certificates before the signaling/worker threads have been initialized as WebRTC-threads (Chrome can invoke this version on the worker thread outside of WebRTC). This CL does not remove the identity store, only adds the alternative. Follow-up CLs will start using it, the store will be removed once it is no longer used anywhere. BUG=webrtc:5707, webrtc:5708 R=hta@webrtc.org, torbjorng@webrtc.org Review URL: https://codereview.webrtc.org/1883813002 . Cr-Commit-Position: refs/heads/master@{#12381}
2016-04-15 17:55:21 +02:00
'rtccertificategenerator.cc',
'rtccertificategenerator.h',
Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base. BUG=N/A R=niklas.enbom@webrtc.org Review URL: https://webrtc-codereview.appspot.com/17479005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6129 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 18:00:26 +00:00
'sha1.cc',
'sha1.h',
Fix clang style warnings in webrtc/base Mostly this consists of marking functions with override when applicable, and moving function bodies from .h to .cc files. Not inlining virtual functions with simple bodies such as { return false; } strikes me as probably losing more in readability than we gain in binary size and compilation time, but I guess it's just like any other case where enabling a generally good warning forces us to write slightly worse code in a couple of places. BUG=163 R=kjellander@webrtc.org, tommi@webrtc.org Review URL: https://webrtc-codereview.appspot.com/47429004 Cr-Commit-Position: refs/heads/master@{#8656} git-svn-id: http://webrtc.googlecode.com/svn/trunk@8656 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-09 22:21:53 +00:00
'sha1digest.cc',
Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base. BUG=N/A R=niklas.enbom@webrtc.org Review URL: https://webrtc-codereview.appspot.com/17479005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6129 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 18:00:26 +00:00
'sha1digest.h',
Revert 8260 "Base RWLockWrapper on rtc::SharedExclusiveLock." Unfortunately this caused channel teardown to hang. More details in email(s). > Base RWLockWrapper on rtc::SharedExclusiveLock. > > Also moves rtc::Event and rtc::SharedExclusiveLock to rtc_base_approved. > > R=tommi@webrtc.org > BUG= > > Review URL: https://webrtc-codereview.appspot.com/38889004 TBR=pbos@webrtc.org Review URL: https://webrtc-codereview.appspot.com/34999005 Cr-Commit-Position: refs/heads/master@{#8284} git-svn-id: http://webrtc.googlecode.com/svn/trunk@8284 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-07 22:35:54 +00:00
'sharedexclusivelock.cc',
'sharedexclusivelock.h',
Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base. BUG=N/A R=niklas.enbom@webrtc.org Review URL: https://webrtc-codereview.appspot.com/17479005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6129 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 18:00:26 +00:00
'signalthread.cc',
'signalthread.h',
Fix clang style warnings in webrtc/base Mostly this consists of marking functions with override when applicable, and moving function bodies from .h to .cc files. Not inlining virtual functions with simple bodies such as { return false; } strikes me as probably losing more in readability than we gain in binary size and compilation time, but I guess it's just like any other case where enabling a generally good warning forces us to write slightly worse code in a couple of places. BUG=163 R=kjellander@webrtc.org, tommi@webrtc.org Review URL: https://webrtc-codereview.appspot.com/47429004 Cr-Commit-Position: refs/heads/master@{#8656} git-svn-id: http://webrtc.googlecode.com/svn/trunk@8656 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-09 22:21:53 +00:00
'sigslot.cc',
Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base. BUG=N/A R=niklas.enbom@webrtc.org Review URL: https://webrtc-codereview.appspot.com/17479005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6129 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 18:00:26 +00:00
'sigslot.h',
'sigslotrepeater.h',
'socket.h',
'socketadapters.cc',
'socketadapters.h',
'socketaddress.cc',
'socketaddress.h',
'socketaddresspair.cc',
'socketaddresspair.h',
'socketfactory.h',
'socketpool.cc',
'socketpool.h',
'socketserver.h',
'socketstream.cc',
'socketstream.h',
'ssladapter.cc',
'ssladapter.h',
'sslfingerprint.cc',
'sslfingerprint.h',
'sslidentity.cc',
'sslidentity.h',
'sslsocketfactory.cc',
'sslsocketfactory.h',
'sslstreamadapter.cc',
'sslstreamadapter.h',
'stream.cc',
'stream.h',
'task.cc',
'task.h',
'taskparent.cc',
'taskparent.h',
'taskrunner.cc',
'taskrunner.h',
'thread.cc',
'thread.h',
'timing.cc',
'timing.h',
'urlencode.cc',
'urlencode.h',
'worker.cc',
'worker.h',
],
Put base tests in webrtc_tests.gyp BUG=N/A R=andrew@webrtc.org, pbos@webrtc.org Review URL: https://webrtc-codereview.appspot.com/14249004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@7140 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-10 17:28:19 +00:00
# TODO(henrike): issue 3307, make rtc_base build without disabling
Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base. BUG=N/A R=niklas.enbom@webrtc.org Review URL: https://webrtc-codereview.appspot.com/17479005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6129 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 18:00:26 +00:00
# these flags.
'cflags!': [
'-Wextra',
'-Wall',
],
'direct_dependent_settings': {
'defines': [
'FEATURE_ENABLE_SSL',
Purge nss files and dependencies. This replaces https://codereview.webrtc.org/1313233005 which was reverted after triggering Chromium issues. The only difference is that we're cleaned up dependencies on use_openssl from the gyp file. Since https://codereview.chromium.org/1358913003 landed, this CL should cause no Chromium issues. BUG=webrtc:4497 Review URL: https://codereview.webrtc.org/1351503004 Cr-Commit-Position: refs/heads/master@{#10019}
2015-09-22 11:58:04 -07:00
'SSL_USE_OPENSSL',
'HAVE_OPENSSL_SSL_H',
Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base. BUG=N/A R=niklas.enbom@webrtc.org Review URL: https://webrtc-codereview.appspot.com/17479005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6129 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 18:00:26 +00:00
],
},
'include_dirs': [
'../../third_party/jsoncpp/overrides/include',
'../../third_party/jsoncpp/source/include',
],
'conditions': [
['build_with_chromium==1', {
'include_dirs': [
Update build files to use webrtc_overrides in Chromium instead of overrides. This re-lands https://codereview.webrtc.org/1354933002/ This is a part of moving the overrides to Chromium. See bug comment #65 for all steps. Depends on https://codereview.chromium.org/1345873004/ BUG=chromium:468375 Review URL: https://codereview.webrtc.org/1345313004 Cr-Commit-Position: refs/heads/master@{#10115}
2015-09-30 03:48:52 -07:00
'../../webrtc_overrides',
Remove more dependencies on openssl, add dependency on boringssl. Continues on r6798 R=andrew@webrtc.org, fbarchard@chromium.org, kjellander@webrtc.org Review URL: https://webrtc-codereview.appspot.com/14029004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6867 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-11 21:06:30 +00:00
'../../boringssl/src/include',
Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base. BUG=N/A R=niklas.enbom@webrtc.org Review URL: https://webrtc-codereview.appspot.com/17479005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6129 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 18:00:26 +00:00
],
Reland of Cleanup webrtc/base/base.gyp (patchset #1 id:1 of https://codereview.webrtc.org/1856323003/ ) Reason for revert: Creating template CL for reland Original issue's description: > Revert of Cleanup webrtc/base/base.gyp (patchset #2 id:80001 of https://codereview.webrtc.org/1859803002/ ) > > Reason for revert: > For some odd reason this breaks chromium.webrtc.fyi bots: > ../../third_party/webrtc_overrides/webrtc/base/win32socketinit.cc:13:2: error: "Only compile this on Windows" > #error "Only compile this on Windows" > ^ > 1 error generated. > > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/11515/steps/compile/logs/stdio > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/builds/4650/steps/compile/logs/stdio > > Original issue's description: > > Cleanup webrtc/base/base.gyp > > > > * Remove all source exclusions since they make the file very hard to > > read and heavily increases the risk for mistakes. > > * Don't compile the openssl* sources if use_openssl==0. > > * Move platform specific sources into conditional includes to make it > > easier to verify a 1:1 mapping with BUILD.gn (since GN doesn't support > > automatic detection of platform specific sources based on filenames). > > * Add missing sources for the GN build. > > * Reorder some blocks to make GYP vs GN mapping match. > > > > BUG=webrtc:4256 > > R=perkj@webrtc.org, torbjorng@webrtc.org > > > > Committed: https://crrev.com/47f33cb28ffb0fa0f053ae0aa0086e11f85bf444 > > Cr-Commit-Position: refs/heads/master@{#12235} > > TBR=perkj@webrtc.org,torbjorng@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:4256 > NOTRY=True > > Committed: https://crrev.com/c8587ad92d394bfb60498df1209a3beb9017e001 > Cr-Commit-Position: refs/heads/master@{#12237} TBR=perkj@webrtc.org,torbjorng@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4256 Review URL: https://codereview.webrtc.org/1857163003 Cr-Commit-Position: refs/heads/master@{#12242}
2016-04-05 08:13:31 -07:00
'conditions': [
['OS=="win"', {
'sources': [
'../../webrtc_overrides/webrtc/base/win32socketinit.cc',
],
}],
],
'defines': [
'NO_MAIN_THREAD_WRAPPING',
Fix MSVS project files generation. BUG=5044 TBR=kjellander@webrtc.org TEST=Runhooks with GYP_GENERATORS=msvs-ninja Review URL: https://codereview.webrtc.org/1386613002 Cr-Commit-Position: refs/heads/master@{#10151}
2015-10-02 10:07:50 -07:00
],
Reland of Cleanup webrtc/base/base.gyp (patchset #1 id:1 of https://codereview.webrtc.org/1856323003/ ) Reason for revert: Creating template CL for reland Original issue's description: > Revert of Cleanup webrtc/base/base.gyp (patchset #2 id:80001 of https://codereview.webrtc.org/1859803002/ ) > > Reason for revert: > For some odd reason this breaks chromium.webrtc.fyi bots: > ../../third_party/webrtc_overrides/webrtc/base/win32socketinit.cc:13:2: error: "Only compile this on Windows" > #error "Only compile this on Windows" > ^ > 1 error generated. > > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/11515/steps/compile/logs/stdio > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/builds/4650/steps/compile/logs/stdio > > Original issue's description: > > Cleanup webrtc/base/base.gyp > > > > * Remove all source exclusions since they make the file very hard to > > read and heavily increases the risk for mistakes. > > * Don't compile the openssl* sources if use_openssl==0. > > * Move platform specific sources into conditional includes to make it > > easier to verify a 1:1 mapping with BUILD.gn (since GN doesn't support > > automatic detection of platform specific sources based on filenames). > > * Add missing sources for the GN build. > > * Reorder some blocks to make GYP vs GN mapping match. > > > > BUG=webrtc:4256 > > R=perkj@webrtc.org, torbjorng@webrtc.org > > > > Committed: https://crrev.com/47f33cb28ffb0fa0f053ae0aa0086e11f85bf444 > > Cr-Commit-Position: refs/heads/master@{#12235} > > TBR=perkj@webrtc.org,torbjorng@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:4256 > NOTRY=True > > Committed: https://crrev.com/c8587ad92d394bfb60498df1209a3beb9017e001 > Cr-Commit-Position: refs/heads/master@{#12237} TBR=perkj@webrtc.org,torbjorng@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4256 Review URL: https://codereview.webrtc.org/1857163003 Cr-Commit-Position: refs/heads/master@{#12242}
2016-04-05 08:13:31 -07:00
'direct_dependent_settings': {
'defines': [
'NO_MAIN_THREAD_WRAPPING',
],
},
}, {
'sources': [
Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base. BUG=N/A R=niklas.enbom@webrtc.org Review URL: https://webrtc-codereview.appspot.com/17479005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6129 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 18:00:26 +00:00
'bandwidthsmoother.cc',
'bandwidthsmoother.h',
'callback.h',
'fileutils_mock.h',
'httpserver.cc',
'httpserver.h',
'json.cc',
'json.h',
Provides log sinks for rotating logs. Intended for use on mobile devices to record call logs. BUG=4838 Review URL: https://codereview.webrtc.org/1230823009 Cr-Commit-Position: refs/heads/master@{#9615}
2015-07-22 12:12:17 -07:00
'logsinks.cc',
'logsinks.h',
Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base. BUG=N/A R=niklas.enbom@webrtc.org Review URL: https://webrtc-codereview.appspot.com/17479005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6129 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 18:00:26 +00:00
'mathutils.h',
'multipart.cc',
'multipart.h',
'natserver.cc',
'natserver.h',
'natsocketfactory.cc',
'natsocketfactory.h',
'nattypes.cc',
'nattypes.h',
'optionsfile.cc',
'optionsfile.h',
'profiler.cc',
'profiler.h',
'proxyserver.cc',
'proxyserver.h',
'referencecountedsingletonfactory.h',
'rollingaccumulator.h',
'scopedptrcollection.h',
'sec_buffer.h',
'sslconfig.h',
'sslroots.h',
'testbase64.h',
'testclient.cc',
'testclient.h',
'transformadapter.cc',
'transformadapter.h',
'versionparsing.cc',
'versionparsing.h',
'virtualsocketserver.cc',
'virtualsocketserver.h',
'window.h',
Revert of Cleanup webrtc/base/base.gyp (patchset #2 id:80001 of https://codereview.webrtc.org/1859803002/ ) Reason for revert: For some odd reason this breaks chromium.webrtc.fyi bots: ../../third_party/webrtc_overrides/webrtc/base/win32socketinit.cc:13:2: error: "Only compile this on Windows" #error "Only compile this on Windows" ^ 1 error generated. https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/11515/steps/compile/logs/stdio https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/builds/4650/steps/compile/logs/stdio Original issue's description: > Cleanup webrtc/base/base.gyp > > * Remove all source exclusions since they make the file very hard to > read and heavily increases the risk for mistakes. > * Don't compile the openssl* sources if use_openssl==0. > * Move platform specific sources into conditional includes to make it > easier to verify a 1:1 mapping with BUILD.gn (since GN doesn't support > automatic detection of platform specific sources based on filenames). > * Add missing sources for the GN build. > * Reorder some blocks to make GYP vs GN mapping match. > > BUG=webrtc:4256 > R=perkj@webrtc.org, torbjorng@webrtc.org > > Committed: https://crrev.com/47f33cb28ffb0fa0f053ae0aa0086e11f85bf444 > Cr-Commit-Position: refs/heads/master@{#12235} TBR=perkj@webrtc.org,torbjorng@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:4256 NOTRY=True Review URL: https://codereview.webrtc.org/1856323003 Cr-Commit-Position: refs/heads/master@{#12237}
2016-04-05 05:23:26 -07:00
'windowpicker.h',
Reland of Cleanup webrtc/base/base.gyp (patchset #1 id:1 of https://codereview.webrtc.org/1856323003/ ) Reason for revert: Creating template CL for reland Original issue's description: > Revert of Cleanup webrtc/base/base.gyp (patchset #2 id:80001 of https://codereview.webrtc.org/1859803002/ ) > > Reason for revert: > For some odd reason this breaks chromium.webrtc.fyi bots: > ../../third_party/webrtc_overrides/webrtc/base/win32socketinit.cc:13:2: error: "Only compile this on Windows" > #error "Only compile this on Windows" > ^ > 1 error generated. > > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/11515/steps/compile/logs/stdio > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/builds/4650/steps/compile/logs/stdio > > Original issue's description: > > Cleanup webrtc/base/base.gyp > > > > * Remove all source exclusions since they make the file very hard to > > read and heavily increases the risk for mistakes. > > * Don't compile the openssl* sources if use_openssl==0. > > * Move platform specific sources into conditional includes to make it > > easier to verify a 1:1 mapping with BUILD.gn (since GN doesn't support > > automatic detection of platform specific sources based on filenames). > > * Add missing sources for the GN build. > > * Reorder some blocks to make GYP vs GN mapping match. > > > > BUG=webrtc:4256 > > R=perkj@webrtc.org, torbjorng@webrtc.org > > > > Committed: https://crrev.com/47f33cb28ffb0fa0f053ae0aa0086e11f85bf444 > > Cr-Commit-Position: refs/heads/master@{#12235} > > TBR=perkj@webrtc.org,torbjorng@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:4256 > NOTRY=True > > Committed: https://crrev.com/c8587ad92d394bfb60498df1209a3beb9017e001 > Cr-Commit-Position: refs/heads/master@{#12237} TBR=perkj@webrtc.org,torbjorng@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4256 Review URL: https://codereview.webrtc.org/1857163003 Cr-Commit-Position: refs/heads/master@{#12242}
2016-04-05 08:13:31 -07:00
'windowpickerfactory.h',
Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base. BUG=N/A R=niklas.enbom@webrtc.org Review URL: https://webrtc-codereview.appspot.com/17479005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6129 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 18:00:26 +00:00
],
Makes it possible to prevent some third party libraries (jsoncpp and openssl) from being linked. This makes it possible to link webrtc with external implementations of those libraries in case the project depending on webrtc requires another version of those libraries. BUG=3379 R=wu@webrtc.org Review URL: https://webrtc-codereview.appspot.com/17699005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6455 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-16 21:35:20 +00:00
'conditions': [
base: Renaming + conforming: post commit review changes for https://webrtc-codereview.appspot.com/17699005/ BUG=N/A R=niklas.enbom@webrtc.org Review URL: https://webrtc-codereview.appspot.com/20709004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6467 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-17 14:48:44 +00:00
['build_json==1', {
Makes it possible to prevent some third party libraries (jsoncpp and openssl) from being linked. This makes it possible to link webrtc with external implementations of those libraries in case the project depending on webrtc requires another version of those libraries. BUG=3379 R=wu@webrtc.org Review URL: https://webrtc-codereview.appspot.com/17699005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6455 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-16 21:35:20 +00:00
'dependencies': [
'<(DEPTH)/third_party/jsoncpp/jsoncpp.gyp:jsoncpp',
],
}, {
'include_dirs': [
'<(json_root)',
],
'defines': [
# When defined changes the include path for json.h to where it
# is expected to be when building json outside of the standalone
# build.
base: Renaming + conforming: post commit review changes for https://webrtc-codereview.appspot.com/17699005/ BUG=N/A R=niklas.enbom@webrtc.org Review URL: https://webrtc-codereview.appspot.com/20709004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6467 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-17 14:48:44 +00:00
'WEBRTC_EXTERNAL_JSON',
Makes it possible to prevent some third party libraries (jsoncpp and openssl) from being linked. This makes it possible to link webrtc with external implementations of those libraries in case the project depending on webrtc requires another version of those libraries. BUG=3379 R=wu@webrtc.org Review URL: https://webrtc-codereview.appspot.com/17699005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6455 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-16 21:35:20 +00:00
],
}],
Reland of Cleanup webrtc/base/base.gyp (patchset #1 id:1 of https://codereview.webrtc.org/1856323003/ ) Reason for revert: Creating template CL for reland Original issue's description: > Revert of Cleanup webrtc/base/base.gyp (patchset #2 id:80001 of https://codereview.webrtc.org/1859803002/ ) > > Reason for revert: > For some odd reason this breaks chromium.webrtc.fyi bots: > ../../third_party/webrtc_overrides/webrtc/base/win32socketinit.cc:13:2: error: "Only compile this on Windows" > #error "Only compile this on Windows" > ^ > 1 error generated. > > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/11515/steps/compile/logs/stdio > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/builds/4650/steps/compile/logs/stdio > > Original issue's description: > > Cleanup webrtc/base/base.gyp > > > > * Remove all source exclusions since they make the file very hard to > > read and heavily increases the risk for mistakes. > > * Don't compile the openssl* sources if use_openssl==0. > > * Move platform specific sources into conditional includes to make it > > easier to verify a 1:1 mapping with BUILD.gn (since GN doesn't support > > automatic detection of platform specific sources based on filenames). > > * Add missing sources for the GN build. > > * Reorder some blocks to make GYP vs GN mapping match. > > > > BUG=webrtc:4256 > > R=perkj@webrtc.org, torbjorng@webrtc.org > > > > Committed: https://crrev.com/47f33cb28ffb0fa0f053ae0aa0086e11f85bf444 > > Cr-Commit-Position: refs/heads/master@{#12235} > > TBR=perkj@webrtc.org,torbjorng@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:4256 > NOTRY=True > > Committed: https://crrev.com/c8587ad92d394bfb60498df1209a3beb9017e001 > Cr-Commit-Position: refs/heads/master@{#12237} TBR=perkj@webrtc.org,torbjorng@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4256 Review URL: https://codereview.webrtc.org/1857163003 Cr-Commit-Position: refs/heads/master@{#12242}
2016-04-05 08:13:31 -07:00
['OS=="linux"', {
'sources': [
'dbus.cc',
'dbus.h',
'libdbusglibsymboltable.cc',
'libdbusglibsymboltable.h',
'linuxfdwalk.c',
'linuxfdwalk.h',
],
}],
['os_posix==1', {
'sources': [
'latebindingsymboltable.cc',
'latebindingsymboltable.h',
'posix.cc',
'posix.h',
],
}],
['OS=="mac"', {
'sources': [
'macasyncsocket.cc',
'macasyncsocket.h',
'maccocoasocketserver.h',
'maccocoasocketserver.mm',
'macsocketserver.cc',
'macsocketserver.h',
'macwindowpicker.cc',
'macwindowpicker.h',
],
}],
['OS=="win"', {
'sources': [
'diskcache_win32.cc',
'diskcache_win32.h',
'win32regkey.cc',
'win32regkey.h',
'win32socketinit.cc',
'win32socketinit.h',
'win32socketserver.cc',
'win32socketserver.h',
],
}],
Disable warnings failing when using Clang on Windows. This makes it possible to build WebRTC using Clang on Windows. Depends on https://codereview.webrtc.org/1524703006/ BUG=webrtc:5360, webrtc:5366 NOTRY=True Review URL: https://codereview.webrtc.org/1522223002 Cr-Commit-Position: refs/heads/master@{#11058}
2015-12-16 14:05:29 -08:00
['OS=="win" and clang==1', {
'msvs_settings': {
'VCCLCompilerTool': {
'AdditionalOptions': [
# Disable warnings failing when compiling with Clang on Windows.
# https://bugs.chromium.org/p/webrtc/issues/detail?id=5366
Roll chromium_revision 7a4fb8d..f527e86 (370025:370073) Change log: https://chromium.googlesource.com/chromium/src/+log/7a4fb8d..f527e86 Full diff: https://chromium.googlesource.com/chromium/src/+/7a4fb8d..f527e86 No dependencies changed. Clang was updated 255169:257953. Details: https://chromium.googlesource.com/chromium/src/+/7a4fb8d..f527e86/tools/clang/scripts/update.py NOTRY=True NOPRESUBMIT=True Review URL: https://codereview.webrtc.org/1593713013 Cr-Commit-Position: refs/heads/master@{#11301}
2016-01-19 04:47:17 -08:00
'-Wno-sign-compare',
Disable warnings failing when using Clang on Windows. This makes it possible to build WebRTC using Clang on Windows. Depends on https://codereview.webrtc.org/1524703006/ BUG=webrtc:5360, webrtc:5366 NOTRY=True Review URL: https://codereview.webrtc.org/1522223002 Cr-Commit-Position: refs/heads/master@{#11058}
2015-12-16 14:05:29 -08:00
'-Wno-missing-braces',
],
},
},
}],
Reland of Cleanup webrtc/base/base.gyp (patchset #1 id:1 of https://codereview.webrtc.org/1856323003/ ) Reason for revert: Creating template CL for reland Original issue's description: > Revert of Cleanup webrtc/base/base.gyp (patchset #2 id:80001 of https://codereview.webrtc.org/1859803002/ ) > > Reason for revert: > For some odd reason this breaks chromium.webrtc.fyi bots: > ../../third_party/webrtc_overrides/webrtc/base/win32socketinit.cc:13:2: error: "Only compile this on Windows" > #error "Only compile this on Windows" > ^ > 1 error generated. > > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/11515/steps/compile/logs/stdio > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/builds/4650/steps/compile/logs/stdio > > Original issue's description: > > Cleanup webrtc/base/base.gyp > > > > * Remove all source exclusions since they make the file very hard to > > read and heavily increases the risk for mistakes. > > * Don't compile the openssl* sources if use_openssl==0. > > * Move platform specific sources into conditional includes to make it > > easier to verify a 1:1 mapping with BUILD.gn (since GN doesn't support > > automatic detection of platform specific sources based on filenames). > > * Add missing sources for the GN build. > > * Reorder some blocks to make GYP vs GN mapping match. > > > > BUG=webrtc:4256 > > R=perkj@webrtc.org, torbjorng@webrtc.org > > > > Committed: https://crrev.com/47f33cb28ffb0fa0f053ae0aa0086e11f85bf444 > > Cr-Commit-Position: refs/heads/master@{#12235} > > TBR=perkj@webrtc.org,torbjorng@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:4256 > NOTRY=True > > Committed: https://crrev.com/c8587ad92d394bfb60498df1209a3beb9017e001 > Cr-Commit-Position: refs/heads/master@{#12237} TBR=perkj@webrtc.org,torbjorng@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4256 Review URL: https://codereview.webrtc.org/1857163003 Cr-Commit-Position: refs/heads/master@{#12242}
2016-04-05 08:13:31 -07:00
], # conditions
}], # build_with_chromium==0
['OS=="android"', {
'sources': [
'ifaddrs-android.cc',
'ifaddrs-android.h',
Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base. BUG=N/A R=niklas.enbom@webrtc.org Review URL: https://webrtc-codereview.appspot.com/17479005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6129 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 18:00:26 +00:00
],
'link_settings': {
'libraries': [
'-llog',
'-lGLESv2',
],
},
Reland of Cleanup webrtc/base/base.gyp (patchset #1 id:1 of https://codereview.webrtc.org/1856323003/ ) Reason for revert: Creating template CL for reland Original issue's description: > Revert of Cleanup webrtc/base/base.gyp (patchset #2 id:80001 of https://codereview.webrtc.org/1859803002/ ) > > Reason for revert: > For some odd reason this breaks chromium.webrtc.fyi bots: > ../../third_party/webrtc_overrides/webrtc/base/win32socketinit.cc:13:2: error: "Only compile this on Windows" > #error "Only compile this on Windows" > ^ > 1 error generated. > > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/11515/steps/compile/logs/stdio > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/builds/4650/steps/compile/logs/stdio > > Original issue's description: > > Cleanup webrtc/base/base.gyp > > > > * Remove all source exclusions since they make the file very hard to > > read and heavily increases the risk for mistakes. > > * Don't compile the openssl* sources if use_openssl==0. > > * Move platform specific sources into conditional includes to make it > > easier to verify a 1:1 mapping with BUILD.gn (since GN doesn't support > > automatic detection of platform specific sources based on filenames). > > * Add missing sources for the GN build. > > * Reorder some blocks to make GYP vs GN mapping match. > > > > BUG=webrtc:4256 > > R=perkj@webrtc.org, torbjorng@webrtc.org > > > > Committed: https://crrev.com/47f33cb28ffb0fa0f053ae0aa0086e11f85bf444 > > Cr-Commit-Position: refs/heads/master@{#12235} > > TBR=perkj@webrtc.org,torbjorng@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:4256 > NOTRY=True > > Committed: https://crrev.com/c8587ad92d394bfb60498df1209a3beb9017e001 > Cr-Commit-Position: refs/heads/master@{#12237} TBR=perkj@webrtc.org,torbjorng@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4256 Review URL: https://codereview.webrtc.org/1857163003 Cr-Commit-Position: refs/heads/master@{#12242}
2016-04-05 08:13:31 -07:00
}],
base.gyp: Add conditions for NaCl builds. These are needed to be able to cleanup the NaCl GYP code in src/third_party/libjingle before switching over to WebRTC's own targets. See https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libjingle/libjingle_nacl.gyp&l=260 for details. BUG=webrtc:4256 R=perkj@webrtc.org Review URL: https://codereview.webrtc.org/1984613002 . Cr-Commit-Position: refs/heads/master@{#12819}
2016-05-20 09:52:43 +02:00
['(OS=="mac" or OS=="ios") and nacl_untrusted_build==0', {
Reland of Cleanup webrtc/base/base.gyp (patchset #1 id:1 of https://codereview.webrtc.org/1856323003/ ) Reason for revert: Creating template CL for reland Original issue's description: > Revert of Cleanup webrtc/base/base.gyp (patchset #2 id:80001 of https://codereview.webrtc.org/1859803002/ ) > > Reason for revert: > For some odd reason this breaks chromium.webrtc.fyi bots: > ../../third_party/webrtc_overrides/webrtc/base/win32socketinit.cc:13:2: error: "Only compile this on Windows" > #error "Only compile this on Windows" > ^ > 1 error generated. > > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/11515/steps/compile/logs/stdio > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/builds/4650/steps/compile/logs/stdio > > Original issue's description: > > Cleanup webrtc/base/base.gyp > > > > * Remove all source exclusions since they make the file very hard to > > read and heavily increases the risk for mistakes. > > * Don't compile the openssl* sources if use_openssl==0. > > * Move platform specific sources into conditional includes to make it > > easier to verify a 1:1 mapping with BUILD.gn (since GN doesn't support > > automatic detection of platform specific sources based on filenames). > > * Add missing sources for the GN build. > > * Reorder some blocks to make GYP vs GN mapping match. > > > > BUG=webrtc:4256 > > R=perkj@webrtc.org, torbjorng@webrtc.org > > > > Committed: https://crrev.com/47f33cb28ffb0fa0f053ae0aa0086e11f85bf444 > > Cr-Commit-Position: refs/heads/master@{#12235} > > TBR=perkj@webrtc.org,torbjorng@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:4256 > NOTRY=True > > Committed: https://crrev.com/c8587ad92d394bfb60498df1209a3beb9017e001 > Cr-Commit-Position: refs/heads/master@{#12237} TBR=perkj@webrtc.org,torbjorng@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4256 Review URL: https://codereview.webrtc.org/1857163003 Cr-Commit-Position: refs/heads/master@{#12242}
2016-04-05 08:13:31 -07:00
'sources': [
'maccocoathreadhelper.h',
'maccocoathreadhelper.mm',
'macconversion.cc',
'macconversion.h',
'macifaddrs_converter.cc',
'scoped_autorelease_pool.h',
'scoped_autorelease_pool.mm',
Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base. BUG=N/A R=niklas.enbom@webrtc.org Review URL: https://webrtc-codereview.appspot.com/17479005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6129 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 18:00:26 +00:00
],
}],
['OS=="ios"', {
'all_dependent_settings': {
'xcode_settings': {
'OTHER_LDFLAGS': [
AppRTCDemo file logging. Adds logging macros to log logs to a file. Undeletes CircularFileStream for that purpose. BUG= R=jiayl@webrtc.org, pbos@webrtc.org Review URL: https://codereview.webrtc.org/1217473011 . Cr-Commit-Position: refs/heads/master@{#9582}
2015-07-14 12:55:44 -07:00
'-framework CFNetwork',
Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base. BUG=N/A R=niklas.enbom@webrtc.org Review URL: https://webrtc-codereview.appspot.com/17479005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6129 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 18:00:26 +00:00
'-framework Foundation',
'-framework Security',
'-framework SystemConfiguration',
'-framework UIKit',
],
},
},
}],
Reland of Cleanup webrtc/base/base.gyp (patchset #1 id:1 of https://codereview.webrtc.org/1856323003/ ) Reason for revert: Creating template CL for reland Original issue's description: > Revert of Cleanup webrtc/base/base.gyp (patchset #2 id:80001 of https://codereview.webrtc.org/1859803002/ ) > > Reason for revert: > For some odd reason this breaks chromium.webrtc.fyi bots: > ../../third_party/webrtc_overrides/webrtc/base/win32socketinit.cc:13:2: error: "Only compile this on Windows" > #error "Only compile this on Windows" > ^ > 1 error generated. > > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/11515/steps/compile/logs/stdio > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/builds/4650/steps/compile/logs/stdio > > Original issue's description: > > Cleanup webrtc/base/base.gyp > > > > * Remove all source exclusions since they make the file very hard to > > read and heavily increases the risk for mistakes. > > * Don't compile the openssl* sources if use_openssl==0. > > * Move platform specific sources into conditional includes to make it > > easier to verify a 1:1 mapping with BUILD.gn (since GN doesn't support > > automatic detection of platform specific sources based on filenames). > > * Add missing sources for the GN build. > > * Reorder some blocks to make GYP vs GN mapping match. > > > > BUG=webrtc:4256 > > R=perkj@webrtc.org, torbjorng@webrtc.org > > > > Committed: https://crrev.com/47f33cb28ffb0fa0f053ae0aa0086e11f85bf444 > > Cr-Commit-Position: refs/heads/master@{#12235} > > TBR=perkj@webrtc.org,torbjorng@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:4256 > NOTRY=True > > Committed: https://crrev.com/c8587ad92d394bfb60498df1209a3beb9017e001 > Cr-Commit-Position: refs/heads/master@{#12237} TBR=perkj@webrtc.org,torbjorng@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4256 Review URL: https://codereview.webrtc.org/1857163003 Cr-Commit-Position: refs/heads/master@{#12242}
2016-04-05 08:13:31 -07:00
['use_x11==1', {
'sources': [
'x11windowpicker.cc',
'x11windowpicker.h',
],
Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base. BUG=N/A R=niklas.enbom@webrtc.org Review URL: https://webrtc-codereview.appspot.com/17479005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6129 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 18:00:26 +00:00
'link_settings': {
'libraries': [
'-ldl',
'-lrt',
'-lXext',
'-lX11',
'-lXcomposite',
'-lXrender',
],
},
Rename linuxwindowpicker to x11windowpicker & only use it with use_x11 These days we have Linux chromium builds that don't use X11. We don't want webrtc to add an X11 dependency to those builds. BUG=3625 R=henrike@webrtc.org, tnakamura@webrtc.org Review URL: https://webrtc-codereview.appspot.com/20049004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6909 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-15 14:44:13 +00:00
}],
['OS=="linux"', {
'link_settings': {
'libraries': [
'-ldl',
'-lrt',
],
},
Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base. BUG=N/A R=niklas.enbom@webrtc.org Review URL: https://webrtc-codereview.appspot.com/17479005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6129 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 18:00:26 +00:00
}],
['OS=="mac"', {
Reland of Cleanup webrtc/base/base.gyp (patchset #1 id:1 of https://codereview.webrtc.org/1856323003/ ) Reason for revert: Creating template CL for reland Original issue's description: > Revert of Cleanup webrtc/base/base.gyp (patchset #2 id:80001 of https://codereview.webrtc.org/1859803002/ ) > > Reason for revert: > For some odd reason this breaks chromium.webrtc.fyi bots: > ../../third_party/webrtc_overrides/webrtc/base/win32socketinit.cc:13:2: error: "Only compile this on Windows" > #error "Only compile this on Windows" > ^ > 1 error generated. > > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/11515/steps/compile/logs/stdio > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/builds/4650/steps/compile/logs/stdio > > Original issue's description: > > Cleanup webrtc/base/base.gyp > > > > * Remove all source exclusions since they make the file very hard to > > read and heavily increases the risk for mistakes. > > * Don't compile the openssl* sources if use_openssl==0. > > * Move platform specific sources into conditional includes to make it > > easier to verify a 1:1 mapping with BUILD.gn (since GN doesn't support > > automatic detection of platform specific sources based on filenames). > > * Add missing sources for the GN build. > > * Reorder some blocks to make GYP vs GN mapping match. > > > > BUG=webrtc:4256 > > R=perkj@webrtc.org, torbjorng@webrtc.org > > > > Committed: https://crrev.com/47f33cb28ffb0fa0f053ae0aa0086e11f85bf444 > > Cr-Commit-Position: refs/heads/master@{#12235} > > TBR=perkj@webrtc.org,torbjorng@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:4256 > NOTRY=True > > Committed: https://crrev.com/c8587ad92d394bfb60498df1209a3beb9017e001 > Cr-Commit-Position: refs/heads/master@{#12237} TBR=perkj@webrtc.org,torbjorng@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4256 Review URL: https://codereview.webrtc.org/1857163003 Cr-Commit-Position: refs/heads/master@{#12242}
2016-04-05 08:13:31 -07:00
'sources': [
'macutils.cc',
'macutils.h',
],
Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base. BUG=N/A R=niklas.enbom@webrtc.org Review URL: https://webrtc-codereview.appspot.com/17479005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6129 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 18:00:26 +00:00
'all_dependent_settings': {
'link_settings': {
'xcode_settings': {
'OTHER_LDFLAGS': [
'-framework Cocoa',
'-framework Foundation',
'-framework IOKit',
'-framework Security',
'-framework SystemConfiguration',
],
},
},
},
}],
base.gyp: Add conditions for NaCl builds. These are needed to be able to cleanup the NaCl GYP code in src/third_party/libjingle before switching over to WebRTC's own targets. See https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libjingle/libjingle_nacl.gyp&l=260 for details. BUG=webrtc:4256 R=perkj@webrtc.org Review URL: https://codereview.webrtc.org/1984613002 . Cr-Commit-Position: refs/heads/master@{#12819}
2016-05-20 09:52:43 +02:00
['OS=="win" and nacl_untrusted_build==0', {
Reland of Cleanup webrtc/base/base.gyp (patchset #1 id:1 of https://codereview.webrtc.org/1856323003/ ) Reason for revert: Creating template CL for reland Original issue's description: > Revert of Cleanup webrtc/base/base.gyp (patchset #2 id:80001 of https://codereview.webrtc.org/1859803002/ ) > > Reason for revert: > For some odd reason this breaks chromium.webrtc.fyi bots: > ../../third_party/webrtc_overrides/webrtc/base/win32socketinit.cc:13:2: error: "Only compile this on Windows" > #error "Only compile this on Windows" > ^ > 1 error generated. > > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/11515/steps/compile/logs/stdio > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/builds/4650/steps/compile/logs/stdio > > Original issue's description: > > Cleanup webrtc/base/base.gyp > > > > * Remove all source exclusions since they make the file very hard to > > read and heavily increases the risk for mistakes. > > * Don't compile the openssl* sources if use_openssl==0. > > * Move platform specific sources into conditional includes to make it > > easier to verify a 1:1 mapping with BUILD.gn (since GN doesn't support > > automatic detection of platform specific sources based on filenames). > > * Add missing sources for the GN build. > > * Reorder some blocks to make GYP vs GN mapping match. > > > > BUG=webrtc:4256 > > R=perkj@webrtc.org, torbjorng@webrtc.org > > > > Committed: https://crrev.com/47f33cb28ffb0fa0f053ae0aa0086e11f85bf444 > > Cr-Commit-Position: refs/heads/master@{#12235} > > TBR=perkj@webrtc.org,torbjorng@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:4256 > NOTRY=True > > Committed: https://crrev.com/c8587ad92d394bfb60498df1209a3beb9017e001 > Cr-Commit-Position: refs/heads/master@{#12237} TBR=perkj@webrtc.org,torbjorng@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4256 Review URL: https://codereview.webrtc.org/1857163003 Cr-Commit-Position: refs/heads/master@{#12242}
2016-04-05 08:13:31 -07:00
'sources': [
'win32.cc',
'win32.h',
'win32filesystem.cc',
'win32filesystem.h',
'win32securityerrors.cc',
'win32window.cc',
'win32window.h',
'win32windowpicker.cc',
'win32windowpicker.h',
'winfirewall.cc',
'winfirewall.h',
'winping.cc',
'winping.h',
Reland 1531763006 Enable IPv6 temporary address filtering on iOS. We'll only use temporary address for IPv6. However, due to a bug in iOS sdk, the necessary headers are not included. This change copies the minimum necessary definitions such that we could retrieve the ip attributes. BUG=webrtc:4343 Committed: https://crrev.com/29488c23644721c10a45eba74c67602b0262e582 Cr-Commit-Position: refs/heads/master@{#11114} patch from issue 1531763006 at patchset 200001 (http://crrev.com/1531763006#ps200001) TBR=pthatcher@webrtc.org Review URL: https://codereview.webrtc.org/1551703002 . Cr-Commit-Position: refs/heads/master@{#11133}
2015-12-28 14:06:55 -08:00
],
Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base. BUG=N/A R=niklas.enbom@webrtc.org Review URL: https://webrtc-codereview.appspot.com/17479005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6129 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 18:00:26 +00:00
'link_settings': {
'libraries': [
'-lcrypt32.lib',
'-liphlpapi.lib',
'-lsecur32.lib',
],
},
# Suppress warnings about WIN32_LEAN_AND_MEAN.
'msvs_disabled_warnings': [4005, 4703],
'defines': [
'_CRT_NONSTDC_NO_DEPRECATE',
],
}],
Reland of Cleanup webrtc/base/base.gyp (patchset #1 id:1 of https://codereview.webrtc.org/1856323003/ ) Reason for revert: Creating template CL for reland Original issue's description: > Revert of Cleanup webrtc/base/base.gyp (patchset #2 id:80001 of https://codereview.webrtc.org/1859803002/ ) > > Reason for revert: > For some odd reason this breaks chromium.webrtc.fyi bots: > ../../third_party/webrtc_overrides/webrtc/base/win32socketinit.cc:13:2: error: "Only compile this on Windows" > #error "Only compile this on Windows" > ^ > 1 error generated. > > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/11515/steps/compile/logs/stdio > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/builds/4650/steps/compile/logs/stdio > > Original issue's description: > > Cleanup webrtc/base/base.gyp > > > > * Remove all source exclusions since they make the file very hard to > > read and heavily increases the risk for mistakes. > > * Don't compile the openssl* sources if use_openssl==0. > > * Move platform specific sources into conditional includes to make it > > easier to verify a 1:1 mapping with BUILD.gn (since GN doesn't support > > automatic detection of platform specific sources based on filenames). > > * Add missing sources for the GN build. > > * Reorder some blocks to make GYP vs GN mapping match. > > > > BUG=webrtc:4256 > > R=perkj@webrtc.org, torbjorng@webrtc.org > > > > Committed: https://crrev.com/47f33cb28ffb0fa0f053ae0aa0086e11f85bf444 > > Cr-Commit-Position: refs/heads/master@{#12235} > > TBR=perkj@webrtc.org,torbjorng@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:4256 > NOTRY=True > > Committed: https://crrev.com/c8587ad92d394bfb60498df1209a3beb9017e001 > Cr-Commit-Position: refs/heads/master@{#12237} TBR=perkj@webrtc.org,torbjorng@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4256 Review URL: https://codereview.webrtc.org/1857163003 Cr-Commit-Position: refs/heads/master@{#12242}
2016-04-05 08:13:31 -07:00
['os_posix==1', {
'sources': [
'ifaddrs_converter.cc',
'ifaddrs_converter.h',
Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base. BUG=N/A R=niklas.enbom@webrtc.org Review URL: https://webrtc-codereview.appspot.com/17479005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6129 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 18:00:26 +00:00
'unixfilesystem.cc',
'unixfilesystem.h',
],
'configurations': {
'Debug_Base': {
'defines': [
# Chromium's build/common.gypi defines this for all posix
# _except_ for ios & mac. We want it there as well, e.g.
# because ASSERT and friends trigger off of it.
'_DEBUG',
],
},
}
}],
Reland of Cleanup webrtc/base/base.gyp (patchset #1 id:1 of https://codereview.webrtc.org/1856323003/ ) Reason for revert: Creating template CL for reland Original issue's description: > Revert of Cleanup webrtc/base/base.gyp (patchset #2 id:80001 of https://codereview.webrtc.org/1859803002/ ) > > Reason for revert: > For some odd reason this breaks chromium.webrtc.fyi bots: > ../../third_party/webrtc_overrides/webrtc/base/win32socketinit.cc:13:2: error: "Only compile this on Windows" > #error "Only compile this on Windows" > ^ > 1 error generated. > > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/11515/steps/compile/logs/stdio > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/builds/4650/steps/compile/logs/stdio > > Original issue's description: > > Cleanup webrtc/base/base.gyp > > > > * Remove all source exclusions since they make the file very hard to > > read and heavily increases the risk for mistakes. > > * Don't compile the openssl* sources if use_openssl==0. > > * Move platform specific sources into conditional includes to make it > > easier to verify a 1:1 mapping with BUILD.gn (since GN doesn't support > > automatic detection of platform specific sources based on filenames). > > * Add missing sources for the GN build. > > * Reorder some blocks to make GYP vs GN mapping match. > > > > BUG=webrtc:4256 > > R=perkj@webrtc.org, torbjorng@webrtc.org > > > > Committed: https://crrev.com/47f33cb28ffb0fa0f053ae0aa0086e11f85bf444 > > Cr-Commit-Position: refs/heads/master@{#12235} > > TBR=perkj@webrtc.org,torbjorng@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:4256 > NOTRY=True > > Committed: https://crrev.com/c8587ad92d394bfb60498df1209a3beb9017e001 > Cr-Commit-Position: refs/heads/master@{#12237} TBR=perkj@webrtc.org,torbjorng@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4256 Review URL: https://codereview.webrtc.org/1857163003 Cr-Commit-Position: refs/heads/master@{#12242}
2016-04-05 08:13:31 -07:00
['OS=="linux" or OS=="android"', {
'sources': [
Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base. BUG=N/A R=niklas.enbom@webrtc.org Review URL: https://webrtc-codereview.appspot.com/17479005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6129 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 18:00:26 +00:00
'linux.cc',
'linux.h',
],
}],
Purge nss files and dependencies. This replaces https://codereview.webrtc.org/1313233005 which was reverted after triggering Chromium issues. The only difference is that we're cleaned up dependencies on use_openssl from the gyp file. Since https://codereview.chromium.org/1358913003 landed, this CL should cause no Chromium issues. BUG=webrtc:4497 Review URL: https://codereview.webrtc.org/1351503004 Cr-Commit-Position: refs/heads/master@{#10019}
2015-09-22 11:58:04 -07:00
['build_ssl==1', {
'dependencies': [
'<(DEPTH)/third_party/boringssl/boringssl.gyp:boringssl',
],
}, {
'include_dirs': [
'<(ssl_root)',
],
}],
Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base. BUG=N/A R=niklas.enbom@webrtc.org Review URL: https://webrtc-codereview.appspot.com/17479005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6129 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 18:00:26 +00:00
],
},
Move gtest_prod_util.h out of webrtc/test tree. This is needed because the target is defined in webrtc/common.gyp and its current location crosses package boundaries when generating projects for some build systems. NOTRY=True Review URL: https://codereview.webrtc.org/1665603003 Cr-Commit-Position: refs/heads/master@{#11496}
2016-02-05 00:23:50 -08:00
{
'target_name': 'gtest_prod',
'type': 'static_library',
'sources': [
'gtest_prod_util.h',
],
},
Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base. BUG=N/A R=niklas.enbom@webrtc.org Review URL: https://webrtc-codereview.appspot.com/17479005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6129 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 18:00:26 +00:00
],
}
Reference in New Issue Copy Permalink