admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
webrtc_m130/api/DEPS

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

260 lines
5.4 KiB
Plaintext
Raw Normal View History

Simplify api/DEPS presubmit check. After the problem fixed by [1], it seems wiser to only check that `include_rules` contains all the top level directories and delegate the action of adding a rule for .cc file to the first user of an header from a new root level directory. This should make the presubmit check more actionable (in [1] for example the solution was to *not* add "+ios" but to consider ios/ as a non WebRTC directory). [1] - https://webrtc-review.googlesource.com/c/107707 Bug: webrtc:9887, webrtc:9924 Change-Id: Ic85e2153a2b83a4874c8faec3c5d1a8c61fe6faf Reviewed-on: https://webrtc-review.googlesource.com/c/107731 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25386}
2018-10-26 13:17:47 +02:00
# This is supposed to be a complete list of top-level directories,
# excepting only api/ itself.
Reland "Add check_deps rules in DEPS files." Relanding https://codereview.webrtc.org/1796413002/ without the change to the openmax_dl include path (which broke downstream code). TBR=tommi@webrtc.org BUG=webrtc:5623 TESTED=Passing runs using: buildtools/checkdeps/checkdeps.py --root=. talk buildtools/checkdeps/checkdeps.py --root=. webrtc Review URL: https://codereview.webrtc.org/1804333002 . Cr-Commit-Position: refs/heads/master@{#12031}
2016-03-17 12:05:36 +01:00
include_rules = [
Use checkdeps to ensure API headers don't include internal headers. This CL updates the checkdeps configuration for the api/ folder in order to explicitly avoid to #include non API headers from API headers. In order to force a careful review of potential exceptions to this rule, the CL also adds mbonadei@ and kwiberg@ as OWNERS of api/DEPS. Bug: webrtc:9887 Change-Id: I0ada6f1020186b2782c7d060af36079c452ba1aa Reviewed-on: https://webrtc-review.googlesource.com/c/106800 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25338}
2018-10-24 13:57:25 +02:00
"-audio",
"-base",
"-build",
"-buildtools",
"-build_overrides",
"-call",
"-common_audio",
"-common_video",
"-data",
"-examples",
Add tool for generating field trial registry header The tool will generate a C++ header with all field trials in REGISTERED_FIELD_TRIALS. This registry will later be used while looking up field trials from native code to ensure they have been properly registered in accordance with the policy. Bug: webrtc:14154 Change-Id: I29bf880735121034585c541c46ef19f617d0afb9 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276268 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Emil Lundmark <lndmrk@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38426}
2022-09-21 15:20:22 +02:00
"-experiments",
Add root doc site definition for WebRTC documentation Bug: None Change-Id: I64f5a356e0358360bd8326c39c8b0a898b879ebf Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/208641 Commit-Queue: Artem Titov <titovartem@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33360}
2021-03-01 17:30:29 +01:00
"-g3doc",
Add missing directory to api/DEPS and PRESUBMIT.py. TBR: kwiberg@webrtc.org Bug: webrtc:9887 Change-Id: Ib285005fc2a25549e72922bc38b05a170c6ef228 No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/c/107707 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Yves Gerey <yvesg@google.com> Cr-Commit-Position: refs/heads/master@{#25342}
2018-10-24 15:53:33 +02:00
"-ios",
Use checkdeps to ensure API headers don't include internal headers. This CL updates the checkdeps configuration for the api/ folder in order to explicitly avoid to #include non API headers from API headers. In order to force a careful review of potential exceptions to this rule, the CL also adds mbonadei@ and kwiberg@ as OWNERS of api/DEPS. Bug: webrtc:9887 Change-Id: I0ada6f1020186b2782c7d060af36079c452ba1aa Reviewed-on: https://webrtc-review.googlesource.com/c/106800 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25338}
2018-10-24 13:57:25 +02:00
"-infra",
"-logging",
"-media",
dcsctp: Add bounded byte reader and writer Packets, chunks, parameters and error causes - the SCTP entities that are sent on the wire - are buffers with fields that are stored in big endian and that generally consist of a fixed header size, and a variable sized part, that can e.g. be encoded sub-fields or serialized strings. The BoundedByteReader and BoundedByteWriter utilities make it easy to read those fields with as much aid from the compiler as possible, by having compile-time assertions that fields are not accessed outside the buffer's span. There are some byte reading functionality already in modules/rtp_rtcp, but that module would be a bit unfortunate to depend on, and doesn't have the compile time bounds checking that is the biggest feature of this abstraction of an rtc::ArrayView. Bug: webrtc:12614 Change-Id: I9fc641aff22221018dda9add4e2c44853c0f64f0 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212967 Commit-Queue: Victor Boivie <boivie@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33597}
2021-03-25 13:11:03 +01:00
"-net",
Use checkdeps to ensure API headers don't include internal headers. This CL updates the checkdeps configuration for the api/ folder in order to explicitly avoid to #include non API headers from API headers. In order to force a careful review of potential exceptions to this rule, the CL also adds mbonadei@ and kwiberg@ as OWNERS of api/DEPS. Bug: webrtc:9887 Change-Id: I0ada6f1020186b2782c7d060af36079c452ba1aa Reviewed-on: https://webrtc-review.googlesource.com/c/106800 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25338}
2018-10-24 13:57:25 +02:00
"-modules",
"-out",
"-p2p",
"-pc",
"-resources",
"-rtc_base",
"-rtc_tools",
"-sdk",
"-stats",
"-style-guide",
"-system_wrappers",
"-test",
"-testing",
"-third_party",
"-tools",
"-tools_webrtc",
"-video",
"-external/webrtc/webrtc", # Android platform build.
"-libyuv",
"-common_types.h",
"-WebRTC",
Reland "Add check_deps rules in DEPS files." Relanding https://codereview.webrtc.org/1796413002/ without the change to the openmax_dl include path (which broke downstream code). TBR=tommi@webrtc.org BUG=webrtc:5623 TESTED=Passing runs using: buildtools/checkdeps/checkdeps.py --root=. talk buildtools/checkdeps/checkdeps.py --root=. webrtc Review URL: https://codereview.webrtc.org/1804333002 . Cr-Commit-Position: refs/heads/master@{#12031}
2016-03-17 12:05:36 +01:00
]
specific_include_rules = {
Use checkdeps to ensure API headers don't include internal headers. This CL updates the checkdeps configuration for the api/ folder in order to explicitly avoid to #include non API headers from API headers. In order to force a careful review of potential exceptions to this rule, the CL also adds mbonadei@ and kwiberg@ as OWNERS of api/DEPS. Bug: webrtc:9887 Change-Id: I0ada6f1020186b2782c7d060af36079c452ba1aa Reviewed-on: https://webrtc-review.googlesource.com/c/106800 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25338}
2018-10-24 13:57:25 +02:00
# Some internal headers are allowed even in API headers:
Add ability to pass factory for RtpTransportControllerSend to PeerConnectionFactoryDependencies. This way we can have custom implementation of RtpTransportControllerSendInterface and pass it properly to Call. Call relies on RtpTransportControllerSendInterface already so this is natural way to customize RTP related classes. If there is custom factory present in dependencies it will be used, otherwise default factory will be used. Intention behind this change is to have ability to have custom QoS with custom parameters. Bug: webrtc:12778 Change-Id: I5b88957025621ef4bcd63eaa98c218ad213da9c8 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/217769 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Commit-Queue: Philipp Hancke <phancke@nvidia.com> Cr-Commit-Position: refs/heads/master@{#34181}
2021-05-31 14:02:28 +02:00
"call_factory_interface\.h": [
"+call/rtp_transport_controller_send_factory_interface.h",
],
Use checkdeps to ensure API headers don't include internal headers. This CL updates the checkdeps configuration for the api/ folder in order to explicitly avoid to #include non API headers from API headers. In order to force a careful review of potential exceptions to this rule, the CL also adds mbonadei@ and kwiberg@ as OWNERS of api/DEPS. Bug: webrtc:9887 Change-Id: I0ada6f1020186b2782c7d060af36079c452ba1aa Reviewed-on: https://webrtc-review.googlesource.com/c/106800 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25338}
2018-10-24 13:57:25 +02:00
".*\.h": [
"+rtc_base/checks.h",
"+rtc_base/system/rtc_export.h",
Use template instantiation declaration/definition for RTCStatsMember<T>. This CL works around an "Explicit specialization after instantiation error" when building with clang-cl and is_component_build=true (see crbug.com/1018579). On top of that it uses "template instantiation declarations/declarations" in order to avoid to instantiate the template in clients code. TBR: hbos@webrtc.org Bug: webrtc:9419, chromium:1018579 Change-Id: I1b2862de678586afc81e8f7a407947322f8a06c4 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/158795 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Yves Gerey <yvesg@google.com> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29683}
2019-11-04 16:31:08 +01:00
"+rtc_base/system/rtc_export_template.h",
Adds shared base class for data units. This reduces code duplication and ensures common behavior between the unit classes. Bug: webrtc:9709 Change-Id: I9529ef10b3f538355f53250a2b67c6b4e250cce8 Reviewed-on: https://webrtc-review.googlesource.com/c/110901 Commit-Queue: Sebastian Jansson <srte@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25690}
2018-11-19 11:17:12 +01:00
"+rtc_base/units/unit_base.h",
Use checkdeps to ensure API headers don't include internal headers. This CL updates the checkdeps configuration for the api/ folder in order to explicitly avoid to #include non API headers from API headers. In order to force a careful review of potential exceptions to this rule, the CL also adds mbonadei@ and kwiberg@ as OWNERS of api/DEPS. Bug: webrtc:9887 Change-Id: I0ada6f1020186b2782c7d060af36079c452ba1aa Reviewed-on: https://webrtc-review.googlesource.com/c/106800 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25338}
2018-10-24 13:57:25 +02:00
],
"array_view\.h": [
"+rtc_base/type_traits.h",
],
Opus implementation of the AudioEncoderFactoryTemplate API This was previously reverted, because external projects were using the internal webrtc::AudioEncoderOpus class and broke when it was renamed. This re-land avoids renaming it immediately, to give those projects time to adapt. It also has to revert some of the changes I had made to the Config struct, since that was also used by the same external projects. BUG=webrtc:7831 Review-Url: https://codereview.webrtc.org/2948483002 Cr-Commit-Position: refs/heads/master@{#18852}
2017-06-30 04:23:22 -07:00
# Needed because AudioEncoderOpus is in the wrong place for
# backwards compatibilty reasons. See
# https://bugs.chromium.org/p/webrtc/issues/detail?id=7847
"audio_encoder_opus\.h": [
Fixing WebRTC after moving from src/webrtc to src/ In https://webrtc-review.googlesource.com/c/src/+/1560 we moved WebRTC from src/webrtc to src/ (in order to preserve an healthy git history). This CL takes care of fixing header guards, #include paths, etc... NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true TBR=tommi@webrtc.org Bug: chromium:611808 Change-Id: Iea91618212bee0af16aa3f05071eab8f93706578 Reviewed-on: https://webrtc-review.googlesource.com/1561 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#19846}
2017-09-15 06:47:31 +02:00
"+modules/audio_coding/codecs/opus/audio_encoder_opus.h",
Opus implementation of the AudioEncoderFactoryTemplate API This was previously reverted, because external projects were using the internal webrtc::AudioEncoderOpus class and broke when it was renamed. This re-land avoids renaming it immediately, to give those projects time to adapt. It also has to revert some of the changes I had made to the Config struct, since that was also used by the same external projects. BUG=webrtc:7831 Review-Url: https://codereview.webrtc.org/2948483002 Cr-Commit-Position: refs/heads/master@{#18852}
2017-06-30 04:23:22 -07:00
],
(4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries Mechanically generated by running this command: tools_webrtc/do-renames.sh update all-renames.txt && git cl format Then manually updating: tools_webrtc/sanitizers/tsan_suppressions_webrtc.cc Bug: webrtc:10159 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I54824cd91dada8fc3ee3d098f971bc319d477833 Reviewed-on: https://webrtc-review.googlesource.com/c/115653 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26226}
2019-01-11 09:11:00 -08:00
"async_resolver_factory\.h": [
"+rtc_base/async_resolver_interface.h",
Use checkdeps to ensure API headers don't include internal headers. This CL updates the checkdeps configuration for the api/ folder in order to explicitly avoid to #include non API headers from API headers. In order to force a careful review of potential exceptions to this rule, the CL also adds mbonadei@ and kwiberg@ as OWNERS of api/DEPS. Bug: webrtc:9887 Change-Id: I0ada6f1020186b2782c7d060af36079c452ba1aa Reviewed-on: https://webrtc-review.googlesource.com/c/106800 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25338}
2018-10-24 13:57:25 +02:00
],
Add a new API to DNS resolution This API should allow existing factories to be used unmodified, but offers a new API that documents ownership better and does not use sigslot. Bug: webrtc:12598 Change-Id: I0f68371059cd4a18ab07b87fc0e7526dcc0ac669 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212609 Reviewed-by: Tommi <tommi@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33553}
2021-03-24 12:13:28 +00:00
"async_dns_resolver\.h": [
"+rtc_base/socket_address.h",
],
Use checkdeps to ensure API headers don't include internal headers. This CL updates the checkdeps configuration for the api/ folder in order to explicitly avoid to #include non API headers from API headers. In order to force a careful review of potential exceptions to this rule, the CL also adds mbonadei@ and kwiberg@ as OWNERS of api/DEPS. Bug: webrtc:9887 Change-Id: I0ada6f1020186b2782c7d060af36079c452ba1aa Reviewed-on: https://webrtc-review.googlesource.com/c/106800 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25338}
2018-10-24 13:57:25 +02:00
"candidate\.h": [
"+rtc_base/network_constants.h",
(4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries Mechanically generated by running this command: tools_webrtc/do-renames.sh update all-renames.txt && git cl format Then manually updating: tools_webrtc/sanitizers/tsan_suppressions_webrtc.cc Bug: webrtc:10159 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I54824cd91dada8fc3ee3d098f971bc319d477833 Reviewed-on: https://webrtc-review.googlesource.com/c/115653 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26226}
2019-01-11 09:11:00 -08:00
"+rtc_base/socket_address.h",
Use checkdeps to ensure API headers don't include internal headers. This CL updates the checkdeps configuration for the api/ folder in order to explicitly avoid to #include non API headers from API headers. In order to force a careful review of potential exceptions to this rule, the CL also adds mbonadei@ and kwiberg@ as OWNERS of api/DEPS. Bug: webrtc:9887 Change-Id: I0ada6f1020186b2782c7d060af36079c452ba1aa Reviewed-on: https://webrtc-review.googlesource.com/c/106800 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25338}
2018-10-24 13:57:25 +02:00
],
(4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries Mechanically generated by running this command: tools_webrtc/do-renames.sh update all-renames.txt && git cl format Then manually updating: tools_webrtc/sanitizers/tsan_suppressions_webrtc.cc Bug: webrtc:10159 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I54824cd91dada8fc3ee3d098f971bc319d477833 Reviewed-on: https://webrtc-review.googlesource.com/c/115653 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26226}
2019-01-11 09:11:00 -08:00
"data_channel_interface\.h": [
"+rtc_base/copy_on_write_buffer.h",
Use checkdeps to ensure API headers don't include internal headers. This CL updates the checkdeps configuration for the api/ folder in order to explicitly avoid to #include non API headers from API headers. In order to force a careful review of potential exceptions to this rule, the CL also adds mbonadei@ and kwiberg@ as OWNERS of api/DEPS. Bug: webrtc:9887 Change-Id: I0ada6f1020186b2782c7d060af36079c452ba1aa Reviewed-on: https://webrtc-review.googlesource.com/c/106800 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25338}
2018-10-24 13:57:25 +02:00
],
Pull a DataChannelTransportInterface out of MediaTransportInterface. DataChannelTransportInterface takes the OpenChannel, SendData, CloseChannel, and SetDataSink methods. MediaTransportInterface inherits from DataChannelTransportInterface. DatagramTransportInterface, the newer alternative to MediaTransportInterface, also inherits from DataChannelTransportInterface. This will allow further refactors to enable the use of media-transport style data channels alongside the datagram transport. Bug: webrtc:9719 Change-Id: I2dd873785ea52d38055b62545c17e9e17c4e70c6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/147840 Reviewed-by: Steve Anton <steveanton@webrtc.org> Commit-Queue: Bjorn Mellem <mellem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28846}
2019-08-01 10:48:20 -07:00
"data_channel_transport_interface\.h": [
"+rtc_base/copy_on_write_buffer.h",
],
(4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries Mechanically generated by running this command: tools_webrtc/do-renames.sh update all-renames.txt && git cl format Then manually updating: tools_webrtc/sanitizers/tsan_suppressions_webrtc.cc Bug: webrtc:10159 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I54824cd91dada8fc3ee3d098f971bc319d477833 Reviewed-on: https://webrtc-review.googlesource.com/c/115653 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26226}
2019-01-11 09:11:00 -08:00
"dtls_transport_interface\.h": [
Expose DtlsTransport::remote_ssl_certificates Bug: chromium:907849 Change-Id: If990d541099edb9a327230e1d78a03b406269885 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/131951 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27558}
2019-04-10 17:20:42 +02:00
"+rtc_base/ssl_certificate.h",
Add API for returning a webrtc::DtlsTransport for a MID on a PC This includes a refactoring of jseptransport to store a refcounted object instead of a std::unique_ptr to the cricket::DtlsTransport. Bug: chromium:907849 Change-Id: Ib557ce72c2e6ce8af297c2b8deb7ec3a103d6d31 Reviewed-on: https://webrtc-review.googlesource.com/c/111920 Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25831}
2018-11-28 16:47:46 +01:00
],
Use checkdeps to ensure API headers don't include internal headers. This CL updates the checkdeps configuration for the api/ folder in order to explicitly avoid to #include non API headers from API headers. In order to force a careful review of potential exceptions to this rule, the CL also adds mbonadei@ and kwiberg@ as OWNERS of api/DEPS. Bug: webrtc:9887 Change-Id: I0ada6f1020186b2782c7d060af36079c452ba1aa Reviewed-on: https://webrtc-review.googlesource.com/c/106800 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25338}
2018-10-24 13:57:25 +02:00
"fec_controller\.h": [
"+modules/include/module_fec_types.h",
],
(4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries Mechanically generated by running this command: tools_webrtc/do-renames.sh update all-renames.txt && git cl format Then manually updating: tools_webrtc/sanitizers/tsan_suppressions_webrtc.cc Bug: webrtc:10159 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I54824cd91dada8fc3ee3d098f971bc319d477833 Reviewed-on: https://webrtc-review.googlesource.com/c/115653 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26226}
2019-01-11 09:11:00 -08:00
"media_stream_interface\.h": [
Use checkdeps to ensure API headers don't include internal headers. This CL updates the checkdeps configuration for the api/ folder in order to explicitly avoid to #include non API headers from API headers. In order to force a careful review of potential exceptions to this rule, the CL also adds mbonadei@ and kwiberg@ as OWNERS of api/DEPS. Bug: webrtc:9887 Change-Id: I0ada6f1020186b2782c7d060af36079c452ba1aa Reviewed-on: https://webrtc-review.googlesource.com/c/106800 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25338}
2018-10-24 13:57:25 +02:00
"+modules/audio_processing/include/audio_processing_statistics.h",
],
Prepare to move packet_socket_factory to api/. I gave up on removing proxy_info, user_agent and tcp_options. I don't think it's feasible to remove them without removing all the proxy code. The assumption that you can set the proxy and user agent long after you have created the factory is entrenched in unit tests and the code itself. So is the ability to set tcp opts depending on protocol or endpoint properties. It may be easier to untangle proxy stuff from the factory later, when it becomes a more first-class citizen and isn't passed via the allocator. Requires https://chromium-review.googlesource.com/c/chromium/src/+/1778870 to land first. Bug: webrtc:7447 Change-Id: Ib496e2bb689ea415e9f8ec1dfedff13a83fa4a8a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150799 Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29091}
2019-09-05 14:35:04 +02:00
"packet_socket_factory\.h": [
"+rtc_base/proxy_info.h",
"+rtc_base/async_packet_socket.h",
],
(4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries Mechanically generated by running this command: tools_webrtc/do-renames.sh update all-renames.txt && git cl format Then manually updating: tools_webrtc/sanitizers/tsan_suppressions_webrtc.cc Bug: webrtc:10159 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I54824cd91dada8fc3ee3d098f971bc319d477833 Reviewed-on: https://webrtc-review.googlesource.com/c/115653 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26226}
2019-01-11 09:11:00 -08:00
"peer_connection_interface\.h": [
Add ability to pass factory for RtpTransportControllerSend to PeerConnectionFactoryDependencies. This way we can have custom implementation of RtpTransportControllerSendInterface and pass it properly to Call. Call relies on RtpTransportControllerSendInterface already so this is natural way to customize RTP related classes. If there is custom factory present in dependencies it will be used, otherwise default factory will be used. Intention behind this change is to have ability to have custom QoS with custom parameters. Bug: webrtc:12778 Change-Id: I5b88957025621ef4bcd63eaa98c218ad213da9c8 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/217769 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Commit-Queue: Philipp Hancke <phancke@nvidia.com> Cr-Commit-Position: refs/heads/master@{#34181}
2021-05-31 14:02:28 +02:00
"+call/rtp_transport_controller_send_factory_interface.h",
(4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries Mechanically generated by running this command: tools_webrtc/do-renames.sh update all-renames.txt && git cl format Then manually updating: tools_webrtc/sanitizers/tsan_suppressions_webrtc.cc Bug: webrtc:10159 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I54824cd91dada8fc3ee3d098f971bc319d477833 Reviewed-on: https://webrtc-review.googlesource.com/c/115653 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26226}
2019-01-11 09:11:00 -08:00
"+media/base/media_config.h",
"+media/base/media_engine.h",
Deprecate PeerConnectionFactory::CreatePeerConnection Applications should use CreatePeerConnectionOrError instead. Moved fallback implementations of CreatePeerConnection into the api/peer_connection_interface.h file, so that we do not have to declare these methods in the proxy. Bug: webrtc:12238 Change-Id: I70c56336641c2a108b68446ae41f43409277a584 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/217762 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33964}
2021-05-09 14:58:57 +00:00
"+p2p/base/port.h",
(4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries Mechanically generated by running this command: tools_webrtc/do-renames.sh update all-renames.txt && git cl format Then manually updating: tools_webrtc/sanitizers/tsan_suppressions_webrtc.cc Bug: webrtc:10159 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I54824cd91dada8fc3ee3d098f971bc319d477833 Reviewed-on: https://webrtc-review.googlesource.com/c/115653 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26226}
2019-01-11 09:11:00 -08:00
"+p2p/base/port_allocator.h",
Deprecate PeerConnectionFactory::CreatePeerConnection Applications should use CreatePeerConnectionOrError instead. Moved fallback implementations of CreatePeerConnection into the api/peer_connection_interface.h file, so that we do not have to declare these methods in the proxy. Bug: webrtc:12238 Change-Id: I70c56336641c2a108b68446ae41f43409277a584 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/217762 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33964}
2021-05-09 14:58:57 +00:00
"+rtc_base/network.h",
"+rtc_base/network_constants.h",
Reland "Pass NetworkMonitorFactory through PeerConnectionFactory." This is a reland of 003c9be817817ed0e3aef3f50c78ae5cb31bc0ff Found some downstream code that relies on NetworkMonitorFactory::SetFactory, so I'm adding those methods back temporarily. BasicNetworkManager will fall back to the static factory if the one passed into PeerConnectionFactory is null. Original change's description: > Pass NetworkMonitorFactory through PeerConnectionFactory. > > Previously the instance was set through a static method, which was > really only done because it was difficult to add new > PeerConnectionFactory construction arguments at the time. > > Now that we have PeerConnectionFactoryDependencies it's easy to clean > this up. > > I'm doing this because I plan to add a NetworkMonitor implementation > for iOS, and don't want to inherit this ugliness. > > Bug: webrtc:9883 > Change-Id: Id94dc061ab1c7186b81af8547393a6e336ff04c2 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180241 > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > Reviewed-by: Sami Kalliomäki <sakal@webrtc.org> > Commit-Queue: Taylor <deadbeef@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#31815} TBR=hta@webrtc.org, sakal@webrtc.org Bug: webrtc:9883 Change-Id: I2e817c423f21936f87532a9694eb9a0a1b70c212 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180722 Reviewed-by: Taylor <deadbeef@webrtc.org> Commit-Queue: Taylor <deadbeef@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31824}
2020-07-31 16:07:52 -07:00
"+rtc_base/network_monitor_factory.h",
(4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries Mechanically generated by running this command: tools_webrtc/do-renames.sh update all-renames.txt && git cl format Then manually updating: tools_webrtc/sanitizers/tsan_suppressions_webrtc.cc Bug: webrtc:10159 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I54824cd91dada8fc3ee3d098f971bc319d477833 Reviewed-on: https://webrtc-review.googlesource.com/c/115653 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26226}
2019-01-11 09:11:00 -08:00
"+rtc_base/rtc_certificate.h",
"+rtc_base/rtc_certificate_generator.h",
"+rtc_base/socket_address.h",
"+rtc_base/ssl_certificate.h",
"+rtc_base/ssl_stream_adapter.h",
Deprecate PeerConnectionFactory::CreatePeerConnection Applications should use CreatePeerConnectionOrError instead. Moved fallback implementations of CreatePeerConnection into the api/peer_connection_interface.h file, so that we do not have to declare these methods in the proxy. Bug: webrtc:12238 Change-Id: I70c56336641c2a108b68446ae41f43409277a584 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/217762 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33964}
2021-05-09 14:58:57 +00:00
"+rtc_base/thread.h",
Clean up api/ DEPS Add missing entries, move definitions to closer DEPS files. Tbr: shampson@webrtc.org Tbr: terelius@webrtc.org Bug: None Change-Id: I07574ad4d440eb729d21aba673981833261c1fcf Reviewed-on: https://webrtc-review.googlesource.com/c/115742 Commit-Queue: Steve Anton <steveanton@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26114}
2018-12-27 11:15:19 -08:00
],
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2. This is a follow-up to https://webrtc-review.googlesource.com/c/src/+/106280. This time the whole code base is covered. Some files may have not been fixed though, whenever the IWYU tool was breaking the build. Bug: webrtc:8311 Change-Id: I2c31f552a87e887d33931d46e87b6208b1e483ef Reviewed-on: https://webrtc-review.googlesource.com/c/111965 Commit-Queue: Yves Gerey <yvesg@google.com> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25830}
2018-11-28 16:47:49 +01:00
"proxy\.h": [
Clean up api/ DEPS Add missing entries, move definitions to closer DEPS files. Tbr: shampson@webrtc.org Tbr: terelius@webrtc.org Bug: None Change-Id: I07574ad4d440eb729d21aba673981833261c1fcf Reviewed-on: https://webrtc-review.googlesource.com/c/115742 Commit-Queue: Steve Anton <steveanton@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26114}
2018-12-27 11:15:19 -08:00
"+rtc_base/event.h",
(4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries Mechanically generated by running this command: tools_webrtc/do-renames.sh update all-renames.txt && git cl format Then manually updating: tools_webrtc/sanitizers/tsan_suppressions_webrtc.cc Bug: webrtc:10159 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I54824cd91dada8fc3ee3d098f971bc319d477833 Reviewed-on: https://webrtc-review.googlesource.com/c/115653 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26226}
2019-01-11 09:11:00 -08:00
"+rtc_base/message_handler.h", # Inherits from it.
Clean up api/ DEPS Add missing entries, move definitions to closer DEPS files. Tbr: shampson@webrtc.org Tbr: terelius@webrtc.org Bug: None Change-Id: I07574ad4d440eb729d21aba673981833261c1fcf Reviewed-on: https://webrtc-review.googlesource.com/c/115742 Commit-Queue: Steve Anton <steveanton@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26114}
2018-12-27 11:15:19 -08:00
"+rtc_base/thread.h",
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2. This is a follow-up to https://webrtc-review.googlesource.com/c/src/+/106280. This time the whole code base is covered. Some files may have not been fixed though, whenever the IWYU tool was breaking the build. Bug: webrtc:8311 Change-Id: I2c31f552a87e887d33931d46e87b6208b1e483ef Reviewed-on: https://webrtc-review.googlesource.com/c/111965 Commit-Queue: Yves Gerey <yvesg@google.com> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25830}
2018-11-28 16:47:49 +01:00
],
(4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries Mechanically generated by running this command: tools_webrtc/do-renames.sh update all-renames.txt && git cl format Then manually updating: tools_webrtc/sanitizers/tsan_suppressions_webrtc.cc Bug: webrtc:10159 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I54824cd91dada8fc3ee3d098f971bc319d477833 Reviewed-on: https://webrtc-review.googlesource.com/c/115653 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26226}
2019-01-11 09:11:00 -08:00
"ref_counted_base\.h": [
"+rtc_base/ref_counter.h",
Use checkdeps to ensure API headers don't include internal headers. This CL updates the checkdeps configuration for the api/ folder in order to explicitly avoid to #include non API headers from API headers. In order to force a careful review of potential exceptions to this rule, the CL also adds mbonadei@ and kwiberg@ as OWNERS of api/DEPS. Bug: webrtc:9887 Change-Id: I0ada6f1020186b2782c7d060af36079c452ba1aa Reviewed-on: https://webrtc-review.googlesource.com/c/106800 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25338}
2018-10-24 13:57:25 +02:00
],
(4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries Mechanically generated by running this command: tools_webrtc/do-renames.sh update all-renames.txt && git cl format Then manually updating: tools_webrtc/sanitizers/tsan_suppressions_webrtc.cc Bug: webrtc:10159 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I54824cd91dada8fc3ee3d098f971bc319d477833 Reviewed-on: https://webrtc-review.googlesource.com/c/115653 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26226}
2019-01-11 09:11:00 -08:00
"rtc_error\.h": [
Use checkdeps to ensure API headers don't include internal headers. This CL updates the checkdeps configuration for the api/ folder in order to explicitly avoid to #include non API headers from API headers. In order to force a careful review of potential exceptions to this rule, the CL also adds mbonadei@ and kwiberg@ as OWNERS of api/DEPS. Bug: webrtc:9887 Change-Id: I0ada6f1020186b2782c7d060af36079c452ba1aa Reviewed-on: https://webrtc-review.googlesource.com/c/106800 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25338}
2018-10-24 13:57:25 +02:00
"+rtc_base/logging.h",
],
Promote RtcEventLogOutputFile to api/ Preparation for deleting PeerConnectionInterface::StartRtcEventLog method with a PlatformFile argument. Bug: webrtc:6463 Change-Id: Ia9fa1d99a3d87f3bf193e73382690b782ffea65c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/135285 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27879}
2019-05-08 13:53:51 +02:00
"rtc_event_log_output_file.h": [
# For private member and constructor.
"+rtc_base/system/file_wrapper.h",
],
Use checkdeps to ensure API headers don't include internal headers. This CL updates the checkdeps configuration for the api/ folder in order to explicitly avoid to #include non API headers from API headers. In order to force a careful review of potential exceptions to this rule, the CL also adds mbonadei@ and kwiberg@ as OWNERS of api/DEPS. Bug: webrtc:9887 Change-Id: I0ada6f1020186b2782c7d060af36079c452ba1aa Reviewed-on: https://webrtc-review.googlesource.com/c/106800 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25338}
2018-10-24 13:57:25 +02:00
Rename api/stats_types.h to api/legacy_stats_types.h. As to not break downstream projects, the old name api/stats_types.h is kept around to help include api/legacy_stats_types.h. We can delete this in a follow-up. NOTRY=True Bug: webrtc:14180 Change-Id: I270ca5e366ae36e324cbc9f982bbb066ab92d203 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283081 Commit-Queue: Henrik Boström <hbos@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38610}
2022-11-11 10:07:34 +01:00
"legacy_stats_types\.h": [
Use checkdeps to ensure API headers don't include internal headers. This CL updates the checkdeps configuration for the api/ folder in order to explicitly avoid to #include non API headers from API headers. In order to force a careful review of potential exceptions to this rule, the CL also adds mbonadei@ and kwiberg@ as OWNERS of api/DEPS. Bug: webrtc:9887 Change-Id: I0ada6f1020186b2782c7d060af36079c452ba1aa Reviewed-on: https://webrtc-review.googlesource.com/c/106800 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25338}
2018-10-24 13:57:25 +02:00
"+rtc_base/thread_checker.h",
],
"audio_decoder\.h": [
"+rtc_base/buffer.h",
],
"audio_encoder\.h": [
"+rtc_base/buffer.h",
],
"audioproc_float\.h": [
"+modules/audio_processing/include/audio_processing.h",
],
Surface ResidualEchoDetector creation to API This allows users to inject the residual echo detector, as a step toward making it an optional part of compilation. Bug: webrtc:11292, webrtc:11539 Change-Id: I7fcc8dbaced67a82851cd6cdcbc115eb01c21fcf Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/174040 Reviewed-by: Per Åhgren <peah@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Sam Zackrisson <saza@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31222}
2020-05-12 10:48:19 +02:00
"echo_detector_creator\.h": [
"+modules/audio_processing/include/audio_processing.h",
Introduce Sync-Decoding based on Metronome Adds new class DecodeSynchronizer that will coalesce the decoding of received streams on the metronome. This feature is experimental and is backed by a field trial WebRTC-FrameBuffer3. This experiment now has 3 arms to it, "WebRTC-FrameBuffer3/arm:FrameBuffer2/": Default, uses old frame buffer. "WebRTC-FrameBuffer3/arm:FrameBuffer3/": Uses new frame buffer. "WebRTC-FrameBuffer3/arm:SyncDecoding/": Uses new frame buffer with frame scheduled on the metronome. The SyncDecoding arm will not work until it is wired up in the follow-up CL. This change also makes the following modifications, * Adds FakeMetronome utilities for tests using a metronome. * Makes FrameDecodeScheduler an interface. The default implementation is TaskQueueFrameDecodeScheduler. * FrameDecodeScheduler now has a Stop() method, which must be called before destruction. TBR=philipel@webrtc.org Change-Id: I58a306bb883604b0be3eb2a04b3d07dbdf185c71 Bug: webrtc:13658 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250665 Reviewed-by: Henrik Boström <hbos@webrtc.org> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Reviewed-by: Stefan Holmer <holmer@google.com> Reviewed-by: Stefan Holmer <stefan@webrtc.org> Commit-Queue: Evan Shrubsole <eshr@webrtc.org> Cr-Commit-Position: refs/heads/main@{#35988}
2022-02-11 15:30:26 +01:00
],
Add rtc::make_ref_counted to api/ This cl adds a forwarding header, a build target, and migrates headers in api/ to use it. Moving actual implementation, will follow, in https://webrtc-review.googlesource.com/c/src/+/265390. Bug: webrtc:12701 Change-Id: Id950725d7d054de8a83b3800b9c9a6437344de86 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265660 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37200}
2022-06-13 10:36:38 +02:00
"make_ref_counted\.h": [
"+rtc_base/ref_counted_object.h",
],
Use checkdeps to ensure API headers don't include internal headers. This CL updates the checkdeps configuration for the api/ folder in order to explicitly avoid to #include non API headers from API headers. In order to force a careful review of potential exceptions to this rule, the CL also adds mbonadei@ and kwiberg@ as OWNERS of api/DEPS. Bug: webrtc:9887 Change-Id: I0ada6f1020186b2782c7d060af36079c452ba1aa Reviewed-on: https://webrtc-review.googlesource.com/c/106800 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25338}
2018-10-24 13:57:25 +02:00
"mock.*\.h": [
"+test/gmock.h",
],
Revert "Add checks for api/test mocks to make sure they're complete" This reverts commit e87ec28b807f84babe228f54690c686fcf86a0fb. Reason for revert: Breaks upstream. Original change's description: > Add checks for api/test mocks to make sure they're complete > > Also unifies the mock inheritance if they inherited from a ref counted > interface: > - it should only inherit from the interface > - it should use make_ref_counted > > Bug: webrtc:14594 > Change-Id: I7b0514b632ccd0798028b50f19812ac0a196e13c > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262423 > Commit-Queue: Florent Castelli <orphis@webrtc.org> > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#38602} Bug: webrtc:14594 Change-Id: I9f2d9c3656b43e3006ec03ae7d792d0a53f47ebd No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/282940 Auto-Submit: Florent Castelli <orphis@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#38604}
2022-11-10 13:28:42 +00:00
"mock_peerconnectioninterface\.h": [
"+rtc_base/ref_counted_object.h",
],
"mock_video_track\.h": [
"+rtc_base/ref_counted_object.h",
],
Add SequenceChecker on Notifier Bug: None Change-Id: I85e80576d92ddae55a3fbd144338d9c57fb80065 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252520 Reviewed-by: Artem Titov <titovartem@webrtc.org> Auto-Submit: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36116}
2022-03-03 05:55:22 +09:00
"notifier\.h": [
"+rtc_base/system/no_unique_address.h",
],
Use checkdeps to ensure API headers don't include internal headers. This CL updates the checkdeps configuration for the api/ folder in order to explicitly avoid to #include non API headers from API headers. In order to force a careful review of potential exceptions to this rule, the CL also adds mbonadei@ and kwiberg@ as OWNERS of api/DEPS. Bug: webrtc:9887 Change-Id: I0ada6f1020186b2782c7d060af36079c452ba1aa Reviewed-on: https://webrtc-review.googlesource.com/c/106800 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25338}
2018-10-24 13:57:25 +02:00
"simulated_network\.h": [
"+rtc_base/random.h",
"+rtc_base/thread_annotations.h",
],
"test_dependency_factory\.h": [
"+rtc_base/thread_checker.h",
],
Reland "Using simulated rtc::Thread for peer connection scenario tests." This is a reland of b70c5c5ce97e7dcf2e1d8453f5ea0639d4b60453 Original change's description: > Using simulated rtc::Thread for peer connection scenario tests. > > Bug: webrtc:11255 > Change-Id: I5d29e997a7209ffc64595082358cca9b2115d07a > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165689 > Commit-Queue: Sebastian Jansson <srte@webrtc.org> > Reviewed-by: Steve Anton <steveanton@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#30258} Bug: webrtc:11255 Change-Id: If65cd56b59158cebec5609407a721fbdb47cfd1b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166046 Reviewed-by: Steve Anton <steveanton@webrtc.org> Commit-Queue: Sebastian Jansson <srte@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30294}
2020-01-16 11:45:59 +01:00
"time_controller\.h": [
"+rtc_base/thread.h",
],
Use checkdeps to ensure API headers don't include internal headers. This CL updates the checkdeps configuration for the api/ folder in order to explicitly avoid to #include non API headers from API headers. In order to force a careful review of potential exceptions to this rule, the CL also adds mbonadei@ and kwiberg@ as OWNERS of api/DEPS. Bug: webrtc:9887 Change-Id: I0ada6f1020186b2782c7d060af36079c452ba1aa Reviewed-on: https://webrtc-review.googlesource.com/c/106800 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25338}
2018-10-24 13:57:25 +02:00
"videocodec_test_fixture\.h": [
"+modules/video_coding/include/video_codec_interface.h"
],
Move SequenceChecker header to API: step 1, move header only Bug: webrtc:12419 Change-Id: I54db9a594f56d051a295167ca5997351443a0f2e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/205380 Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33189}
2021-02-04 15:06:50 +01:00
"sequence_checker\.h": [
"+rtc_base/synchronization/sequence_checker_internal.h",
"+rtc_base/thread_annotations.h",
],
Add CreateAsyncDnsResolver to PacketSocketFactory API This unlocks migration from AsyncResolver to AsyncDnsResolver for clients that implement PacketSocketFactory. A default implementation is provided, so that clients that implement CreateAsyncResolver will still see their name resolution work. Bug: webrtc:12598 Change-Id: If835cbc753712e9f5b4bd3d5805c7f7d2a561ee5 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/233500 Commit-Queue: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Markus Handell <handellm@webrtc.org> Cr-Commit-Position: refs/heads/main@{#35131}
2021-10-01 15:11:17 +00:00
"wrapping_async_dns_resolver\.h": [
"+rtc_base/async_resolver.h",
"+rtc_base/async_resolver_interface.h",
"+rtc_base/socket_address.h",
"+rtc_base/third_party/sigslot/sigslot.h",
"+rtc_base/thread_annotations.h",
],
New VideoEncoderFactoryTemplate. The VideoEncoderFactoryTemplate takes encoder implementations as template arguments, making it possible to easily implement a VideoEncoderFactory only using the implementations required for the particular application. This will replace the BuiltinVideoEncoderFactory. Change-Id: Ifb0e93d0d4491664fb7f7acf085190d8a90ddc0e Bug: webrtc:13573 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251904 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Commit-Queue: Philip Eliasson <philipel@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36216}
2022-03-16 12:11:42 +01:00
"video_encoder_factory_template.*\.h": [
"+modules/video_coding",
],
New VideoDecoderFactoryTemplate. The VideoDecoderFactoryTemplate takes decoder implementations as template arguments, making it possible to easily implement a VideoDecoderFactory only using the implementations required for the particular application. This will replace the BuiltinVideoDecoderFactory. Bug: webrtc:13573 Change-Id: I0213acd20b69dacf06fc6934851b73bd19b1afc8 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268470 Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Commit-Queue: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37523}
2022-07-14 16:06:51 +02:00
"video_decoder_factory_template.*\.h": [
"+modules/video_coding",
],
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 13/inf Create FieldTrials class for setting the field trials from a string in a program. We can later e.g add a builder class where one can add key/value pairs. This class is supposed to replace webrtc::field_trial::InitFieldTrialsFromString. No-Try: True Bug: webrtc:10335 Change-Id: I17f45e401102fddda50ca7c4a04bea2f1cb87788 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256973 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36376}
2022-03-30 07:57:48 +02:00
"field_trials\.h": [
"+rtc_base/containers/flat_map.h",
],
Make header files self contained. This CL adds #includes to header files in order to make them self contained after the preprocessor pass. Bug: b/251890128 Change-Id: I81c3ba38fb8ab8a2bbd151ba99aa871fae9f1b1b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/278422 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38327}
2022-10-07 21:47:49 +00:00
"video_track_source_proxy_factory.h": [
"+rtc_base/thread.h",
],
Add FieldTrialsRegistry that verifies looked up field trials This new class implements the existing FieldTrialsView interface, extending it with the verification functionality. For now, the verification will only be performed if the rtc_strict_field_trials GN arg is set. Most classes extending FieldTrialsView today have been converted to extend from FieldTrialsRegistry instead to automatically perform verification. Bug: webrtc:14154 Change-Id: I4819724cd66a04507e62fcc2bb1019187b6ba8c7 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276270 Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Emil Lundmark <lndmrk@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38453}
2022-09-21 15:20:22 +02:00
"field_trials_registry\.h": [
"+rtc_base/containers/flat_set.h",
],
Simplify api/DEPS presubmit check. After the problem fixed by [1], it seems wiser to only check that `include_rules` contains all the top level directories and delegate the action of adding a rule for .cc file to the first user of an header from a new root level directory. This should make the presubmit check more actionable (in [1] for example the solution was to *not* add "+ios" but to consider ios/ as a non WebRTC directory). [1] - https://webrtc-review.googlesource.com/c/107707 Bug: webrtc:9887, webrtc:9924 Change-Id: Ic85e2153a2b83a4874c8faec3c5d1a8c61fe6faf Reviewed-on: https://webrtc-review.googlesource.com/c/107731 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25386}
2018-10-26 13:17:47 +02:00
# .cc files in api/ should not be restricted in what they can #include,
# so we re-add all the top-level directories here. (That's because .h
# files leak their #includes to whoever's #including them, but .cc files
# do not since no one #includes them.)
Move AudioDecoder and related stuff to the api/ directory BUG=webrtc:5805, webrtc:6725 Review-Url: https://codereview.webrtc.org/2668523004 Cr-Commit-Position: refs/heads/master@{#16534}
2017-02-10 08:15:44 -08:00
".*\.cc": [
Use checkdeps to ensure API headers don't include internal headers. This CL updates the checkdeps configuration for the api/ folder in order to explicitly avoid to #include non API headers from API headers. In order to force a careful review of potential exceptions to this rule, the CL also adds mbonadei@ and kwiberg@ as OWNERS of api/DEPS. Bug: webrtc:9887 Change-Id: I0ada6f1020186b2782c7d060af36079c452ba1aa Reviewed-on: https://webrtc-review.googlesource.com/c/106800 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25338}
2018-10-24 13:57:25 +02:00
"+audio",
"+call",
"+common_audio",
"+common_video",
"+examples",
Add FieldTrialsRegistry that verifies looked up field trials This new class implements the existing FieldTrialsView interface, extending it with the verification functionality. For now, the verification will only be performed if the rtc_strict_field_trials GN arg is set. Most classes extending FieldTrialsView today have been converted to extend from FieldTrialsRegistry instead to automatically perform verification. Bug: webrtc:14154 Change-Id: I4819724cd66a04507e62fcc2bb1019187b6ba8c7 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276270 Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Emil Lundmark <lndmrk@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38453}
2022-09-21 15:20:22 +02:00
"+experiments",
Use checkdeps to ensure API headers don't include internal headers. This CL updates the checkdeps configuration for the api/ folder in order to explicitly avoid to #include non API headers from API headers. In order to force a careful review of potential exceptions to this rule, the CL also adds mbonadei@ and kwiberg@ as OWNERS of api/DEPS. Bug: webrtc:9887 Change-Id: I0ada6f1020186b2782c7d060af36079c452ba1aa Reviewed-on: https://webrtc-review.googlesource.com/c/106800 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25338}
2018-10-24 13:57:25 +02:00
"+logging",
"+media",
"+modules",
"+p2p",
"+pc",
"+rtc_base",
"+rtc_tools",
"+sdk",
"+stats",
"+system_wrappers",
"+test",
"+tools",
"+tools_webrtc",
"+video",
"+third_party",
Add CreatePeerConnectionFactory overloads that take audio codec factory args BUG=5805 Review-Url: https://codereview.webrtc.org/2653343003 Cr-Commit-Position: refs/heads/master@{#16371}
2017-01-31 01:48:08 -08:00
],
Reland "Add check_deps rules in DEPS files." Relanding https://codereview.webrtc.org/1796413002/ without the change to the openmax_dl include path (which broke downstream code). TBR=tommi@webrtc.org BUG=webrtc:5623 TESTED=Passing runs using: buildtools/checkdeps/checkdeps.py --root=. talk buildtools/checkdeps/checkdeps.py --root=. webrtc Review URL: https://codereview.webrtc.org/1804333002 . Cr-Commit-Position: refs/heads/master@{#12031}
2016-03-17 12:05:36 +01:00
}
Reference in New Issue Copy Permalink