admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
webrtc_m130/api/peer_connection_proxy.h

155 lines
6.5 KiB
C
Raw Normal View History

Adds trunk/talk folder of revision 359 from libjingles google code to trunk/talk git-svn-id: http://webrtc.googlecode.com/svn/trunk@4318 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-10 00:45:36 +00:00
/*
Fix license headers in webrtc/api. In addition to the code moved from talk/app/webrtc there were some files in webrtc/api/objctests that still had the libjingle license header. BUG=webrtc:5418 TBR=tkchin@webrtc.org NOTRY=True Review URL: https://codereview.webrtc.org/1680293005 Cr-Commit-Position: refs/heads/master@{#11552}
2016-02-10 07:54:43 -08:00
* Copyright 2012 The WebRTC project authors. All Rights Reserved.
Adds trunk/talk folder of revision 359 from libjingles google code to trunk/talk git-svn-id: http://webrtc.googlecode.com/svn/trunk@4318 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-10 00:45:36 +00:00
*
Fix license headers in webrtc/api. In addition to the code moved from talk/app/webrtc there were some files in webrtc/api/objctests that still had the libjingle license header. BUG=webrtc:5418 TBR=tkchin@webrtc.org NOTRY=True Review URL: https://codereview.webrtc.org/1680293005 Cr-Commit-Position: refs/heads/master@{#11552}
2016-02-10 07:54:43 -08:00
* Use of this source code is governed by a BSD-style license
* that can be found in the LICENSE file in the root of the source
* tree. An additional intellectual property rights grant can be found
* in the file PATENTS. All contributing project authors may
* be found in the AUTHORS file in the root of the source tree.
Adds trunk/talk folder of revision 359 from libjingles google code to trunk/talk git-svn-id: http://webrtc.googlecode.com/svn/trunk@4318 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-10 00:45:36 +00:00
*/
(4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries Mechanically generated by running this command: tools_webrtc/do-renames.sh update all-renames.txt && git cl format Then manually updating: tools_webrtc/sanitizers/tsan_suppressions_webrtc.cc Bug: webrtc:10159 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I54824cd91dada8fc3ee3d098f971bc319d477833 Reviewed-on: https://webrtc-review.googlesource.com/c/115653 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26226}
2019-01-11 09:11:00 -08:00
#ifndef API_PEER_CONNECTION_PROXY_H_
#define API_PEER_CONNECTION_PROXY_H_
Adds trunk/talk folder of revision 359 from libjingles google code to trunk/talk git-svn-id: http://webrtc.googlecode.com/svn/trunk@4318 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-10 00:45:36 +00:00
Add PeerConnection::StartRtcEventLog version that takes RtcEventLogOutput as parameter This will allow Chrome to provide a RtcEventLogOutput object that reports the log back to Chrome, allowing Chrome to manage the log by itself - write it to a file, upload it to a server, etc. Bug: webrtc:8111 Change-Id: I6a2a6945fc8586ef10e0fb9c56eaa8fda00dfc98 Reviewed-on: https://webrtc-review.googlesource.com/8081 Commit-Queue: Elad Alon <eladalon@webrtc.org> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20295}
2017-10-13 16:29:40 +02:00
#include <memory>
Enable cpplint and fix cpplint errors in webrtc/api Adding 'explicit' to these constructors has a low risk of causing compatibility problems: explicit RTCConfiguration(RTCConfigurationType type) explicit IdBase(StatsType type) BUG=webrtc:5267 TESTED=Fixed issues reported by: find webrtc/api -type f -name *.cc -o -name *.h | xargs cpplint.py followed by 'git cl presubmit'. Review-Url: https://codereview.webrtc.org/2663063003 Cr-Commit-Position: refs/heads/master@{#16392}
2017-02-01 01:55:59 -08:00
#include <string>
#include <vector>
(4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries Mechanically generated by running this command: tools_webrtc/do-renames.sh update all-renames.txt && git cl format Then manually updating: tools_webrtc/sanitizers/tsan_suppressions_webrtc.cc Bug: webrtc:10159 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I54824cd91dada8fc3ee3d098f971bc319d477833 Reviewed-on: https://webrtc-review.googlesource.com/c/115653 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26226}
2019-01-11 09:11:00 -08:00
#include "api/peer_connection_interface.h"
Fixing WebRTC after moving from src/webrtc to src/ In https://webrtc-review.googlesource.com/c/src/+/1560 we moved WebRTC from src/webrtc to src/ (in order to preserve an healthy git history). This CL takes care of fixing header guards, #include paths, etc... NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true TBR=tommi@webrtc.org Bug: chromium:611808 Change-Id: Iea91618212bee0af16aa3f05071eab8f93706578 Reviewed-on: https://webrtc-review.googlesource.com/1561 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#19846}
2017-09-15 06:47:31 +02:00
#include "api/proxy.h"
Adds trunk/talk folder of revision 359 from libjingles google code to trunk/talk git-svn-id: http://webrtc.googlecode.com/svn/trunk@4318 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-10 00:45:36 +00:00
namespace webrtc {
Adding more comments to every header file in api/ subdirectory. Many of these interfaces are not intuitive, or are the way they are for complex historical reasons, so it would be nice to document these things for future developers. Also, many nonstandard things (such as RTCConfiguration options) were not documented at all before this CL. BUG=webrtc:7131 TBR=pthatcher@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2680273002 Cr-Commit-Position: refs/heads/master@{#16485}
2017-02-08 01:38:21 -08:00
// TODO(deadbeef): Move this to .cc file and out of api/. What threads methods
// are called on is an implementation detail.
Rename BEGIN_PROXY_MAP --> BEGIN_SIGNALLING_PROXY_MAP. And BEGIN_WORKER_PROXY_MAP --> BEGIN_PROXY_MAP. This rename was suggested by Tommi, with the idea that a proxy invoking methods on the worker thread should be the common case. It's a followup to https://codereview.webrtc.org/1861633002/ This cl also adds unittests for proxy calls to the worker thread. BUG=webrtc:5426 Review URL: https://codereview.webrtc.org/1871833002 Cr-Commit-Position: refs/heads/master@{#12374}
2016-04-15 03:49:07 -07:00
BEGIN_SIGNALING_PROXY_MAP(PeerConnection)
Reformat the WebRTC code base Running clang-format with chromium's style guide. The goal is n-fold: * providing consistency and readability (that's what code guidelines are for) * preventing noise with presubmit checks and git cl format * building on the previous point: making it easier to automatically fix format issues * you name it Please consider using git-hyper-blame to ignore this commit. Bug: webrtc:9340 Change-Id: I694567c4cdf8cee2860958cfe82bfaf25848bb87 Reviewed-on: https://webrtc-review.googlesource.com/81185 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23660}
2018-06-19 15:03:05 +02:00
PROXY_SIGNALING_THREAD_DESTRUCTOR()
PROXY_METHOD0(rtc::scoped_refptr<StreamCollectionInterface>, local_streams)
PROXY_METHOD0(rtc::scoped_refptr<StreamCollectionInterface>, remote_streams)
PROXY_METHOD1(bool, AddStream, MediaStreamInterface*)
PROXY_METHOD1(void, RemoveStream, MediaStreamInterface*)
PROXY_METHOD2(RTCErrorOr<rtc::scoped_refptr<RtpSenderInterface>>,
AddTrack,
rtc::scoped_refptr<MediaStreamTrackInterface>,
Update PeerConnectionProxy to reflect new PeerConnectionInterface methods Bug: webrtc:10133 Change-Id: I0fa62d7265b3a101e7c55695fca47b72d7fabf58 Reviewed-on: https://webrtc-review.googlesource.com/c/114913 Reviewed-by: Seth Hampson <shampson@webrtc.org> Commit-Queue: Steve Anton <steveanton@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26060}
2018-12-18 16:29:34 -08:00
const std::vector<std::string>&)
Reformat the WebRTC code base Running clang-format with chromium's style guide. The goal is n-fold: * providing consistency and readability (that's what code guidelines are for) * preventing noise with presubmit checks and git cl format * building on the previous point: making it easier to automatically fix format issues * you name it Please consider using git-hyper-blame to ignore this commit. Bug: webrtc:9340 Change-Id: I694567c4cdf8cee2860958cfe82bfaf25848bb87 Reviewed-on: https://webrtc-review.googlesource.com/81185 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23660}
2018-06-19 15:03:05 +02:00
PROXY_METHOD1(bool, RemoveTrack, RtpSenderInterface*)
Update PeerConnectionProxy to reflect new PeerConnectionInterface methods Bug: webrtc:10133 Change-Id: I0fa62d7265b3a101e7c55695fca47b72d7fabf58 Reviewed-on: https://webrtc-review.googlesource.com/c/114913 Reviewed-by: Seth Hampson <shampson@webrtc.org> Commit-Queue: Steve Anton <steveanton@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26060}
2018-12-18 16:29:34 -08:00
PROXY_METHOD1(RTCError, RemoveTrackNew, rtc::scoped_refptr<RtpSenderInterface>)
Reformat the WebRTC code base Running clang-format with chromium's style guide. The goal is n-fold: * providing consistency and readability (that's what code guidelines are for) * preventing noise with presubmit checks and git cl format * building on the previous point: making it easier to automatically fix format issues * you name it Please consider using git-hyper-blame to ignore this commit. Bug: webrtc:9340 Change-Id: I694567c4cdf8cee2860958cfe82bfaf25848bb87 Reviewed-on: https://webrtc-review.googlesource.com/81185 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23660}
2018-06-19 15:03:05 +02:00
PROXY_METHOD1(RTCErrorOr<rtc::scoped_refptr<RtpTransceiverInterface>>,
AddTransceiver,
rtc::scoped_refptr<MediaStreamTrackInterface>)
PROXY_METHOD2(RTCErrorOr<rtc::scoped_refptr<RtpTransceiverInterface>>,
AddTransceiver,
rtc::scoped_refptr<MediaStreamTrackInterface>,
const RtpTransceiverInit&)
PROXY_METHOD1(RTCErrorOr<rtc::scoped_refptr<RtpTransceiverInterface>>,
AddTransceiver,
cricket::MediaType)
PROXY_METHOD2(RTCErrorOr<rtc::scoped_refptr<RtpTransceiverInterface>>,
AddTransceiver,
cricket::MediaType,
const RtpTransceiverInit&)
PROXY_METHOD2(rtc::scoped_refptr<RtpSenderInterface>,
CreateSender,
const std::string&,
const std::string&)
PROXY_CONSTMETHOD0(std::vector<rtc::scoped_refptr<RtpSenderInterface>>,
GetSenders)
PROXY_CONSTMETHOD0(std::vector<rtc::scoped_refptr<RtpReceiverInterface>>,
GetReceivers)
PROXY_CONSTMETHOD0(std::vector<rtc::scoped_refptr<RtpTransceiverInterface>>,
GetTransceivers)
PROXY_METHOD3(bool,
GetStats,
StatsObserver*,
MediaStreamTrackInterface*,
StatsOutputLevel)
PROXY_METHOD1(void, GetStats, RTCStatsCollectorCallback*)
PROXY_METHOD2(void,
GetStats,
rtc::scoped_refptr<RtpSenderInterface>,
Update PeerConnectionProxy to reflect new PeerConnectionInterface methods Bug: webrtc:10133 Change-Id: I0fa62d7265b3a101e7c55695fca47b72d7fabf58 Reviewed-on: https://webrtc-review.googlesource.com/c/114913 Reviewed-by: Seth Hampson <shampson@webrtc.org> Commit-Queue: Steve Anton <steveanton@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26060}
2018-12-18 16:29:34 -08:00
rtc::scoped_refptr<RTCStatsCollectorCallback>)
Reformat the WebRTC code base Running clang-format with chromium's style guide. The goal is n-fold: * providing consistency and readability (that's what code guidelines are for) * preventing noise with presubmit checks and git cl format * building on the previous point: making it easier to automatically fix format issues * you name it Please consider using git-hyper-blame to ignore this commit. Bug: webrtc:9340 Change-Id: I694567c4cdf8cee2860958cfe82bfaf25848bb87 Reviewed-on: https://webrtc-review.googlesource.com/81185 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23660}
2018-06-19 15:03:05 +02:00
PROXY_METHOD2(void,
GetStats,
rtc::scoped_refptr<RtpReceiverInterface>,
Update PeerConnectionProxy to reflect new PeerConnectionInterface methods Bug: webrtc:10133 Change-Id: I0fa62d7265b3a101e7c55695fca47b72d7fabf58 Reviewed-on: https://webrtc-review.googlesource.com/c/114913 Reviewed-by: Seth Hampson <shampson@webrtc.org> Commit-Queue: Steve Anton <steveanton@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26060}
2018-12-18 16:29:34 -08:00
rtc::scoped_refptr<RTCStatsCollectorCallback>)
Delete almost all default methods on PeerConnectionInterface Keeping default implementations only for methods involved in ongoing transitions. Intended to catch inconsistencies between the interface and the PeerConnectionProxy class, at compile time. Bug: webrtc:10716 Change-Id: I4cb126c353855f7288ba09273fa6f87aaa0f32eb Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/140860 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Henrik Boström <hbos@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29224}
2019-09-13 15:41:21 +02:00
PROXY_METHOD0(void, ClearStatsCache)
Reformat the WebRTC code base Running clang-format with chromium's style guide. The goal is n-fold: * providing consistency and readability (that's what code guidelines are for) * preventing noise with presubmit checks and git cl format * building on the previous point: making it easier to automatically fix format issues * you name it Please consider using git-hyper-blame to ignore this commit. Bug: webrtc:9340 Change-Id: I694567c4cdf8cee2860958cfe82bfaf25848bb87 Reviewed-on: https://webrtc-review.googlesource.com/81185 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23660}
2018-06-19 15:03:05 +02:00
PROXY_METHOD2(rtc::scoped_refptr<DataChannelInterface>,
CreateDataChannel,
const std::string&,
const DataChannelInit*)
PROXY_CONSTMETHOD0(const SessionDescriptionInterface*, local_description)
PROXY_CONSTMETHOD0(const SessionDescriptionInterface*, remote_description)
PROXY_CONSTMETHOD0(const SessionDescriptionInterface*,
current_local_description)
PROXY_CONSTMETHOD0(const SessionDescriptionInterface*,
current_remote_description)
Update PeerConnectionProxy to reflect new PeerConnectionInterface methods Bug: webrtc:10133 Change-Id: I0fa62d7265b3a101e7c55695fca47b72d7fabf58 Reviewed-on: https://webrtc-review.googlesource.com/c/114913 Reviewed-by: Seth Hampson <shampson@webrtc.org> Commit-Queue: Steve Anton <steveanton@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26060}
2018-12-18 16:29:34 -08:00
PROXY_CONSTMETHOD0(const SessionDescriptionInterface*,
pending_local_description)
PROXY_CONSTMETHOD0(const SessionDescriptionInterface*,
pending_remote_description)
[PeerConnection] Implement restartIce(). This is part of "Perfect Negotiation" (https://crbug.com/980872). Spec PR here (merged): https://github.com/w3c/webrtc-pc/pull/2169 Spec: https://w3c.github.io/webrtc-pc/#dfn-localufragstoreplace The restartIce() makes the next createOffer() generate new ICE credentials, as if {iceRestart:true} was passed in as options. It also causes negotiationneeded. This is better than manually restarting ICE because it survives rollbacks (when that is implemented) and restartIce() can be called regardless of current signalingState. Bug: chromium:980881 Change-Id: I8e70bec31ce9d4d6a303bd35e91b2dcc28fcad60 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144941 Commit-Queue: Henrik Boström <hbos@webrtc.org> Reviewed-by: Steve Anton <steveanton@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28596}
2019-07-18 11:16:56 +02:00
PROXY_METHOD0(void, RestartIce)
Reformat the WebRTC code base Running clang-format with chromium's style guide. The goal is n-fold: * providing consistency and readability (that's what code guidelines are for) * preventing noise with presubmit checks and git cl format * building on the previous point: making it easier to automatically fix format issues * you name it Please consider using git-hyper-blame to ignore this commit. Bug: webrtc:9340 Change-Id: I694567c4cdf8cee2860958cfe82bfaf25848bb87 Reviewed-on: https://webrtc-review.googlesource.com/81185 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23660}
2018-06-19 15:03:05 +02:00
PROXY_METHOD2(void,
CreateOffer,
CreateSessionDescriptionObserver*,
const RTCOfferAnswerOptions&)
PROXY_METHOD2(void,
CreateAnswer,
CreateSessionDescriptionObserver*,
const RTCOfferAnswerOptions&)
PROXY_METHOD2(void,
[Perfect Negotiation] Implement non-racy version of SetLocalDescription. BACKGROUND When SLD is invoked with SetSessionDescriptionObserver, the observer is called by posting a message back to the execution thread, delaying the call. This delay is "artificial" - it's not necessary; the operation is already complete. It's a post from the signaling thread to the signaling thread. The rationale for the post was to avoid the observer making recursive calls back into the PeerConnection. The problem with this is that by the time the observer is called, the PeerConnection could already have executed other operations and modified its states. This causes the referenced bug: one can have a race where SLD is resolved "too late" (after a pending SRD is executed) and the signaling state observed when SLD resolves doesn't make sense. When implementing Unified Plan, we fixed similar issues for SRD by adding a version that takes SetRemoteDescriptionObserverInterface as argument instead of SetSessionDescriptionObserver. The new version did not have the delay. The old version had to be kept around not to break downstream projects that had dependencies both on he delay and on allowing the PC to be destroyed midst-operation without informing its observers. THIS CL This does the old SRD fix for SLD as well: A new observer interface is added, SetLocalDescriptionObserverInterface, and PeerConnection::SetLocalDescription() is overloaded. If you call it with the old observer, you get the delay, but if you call it with the new observer, you don't get a delay. - SetLocalDescriptionObserverInterface is added. - SetLocalDescription is overloaded. - The adapter for SetSessionDescriptionObserver that causes the delay previously only used for SRD is updated to handle both SLD and SRD. - FakeSetLocalDescriptionObserver is added and MockSetRemoteDescriptionObserver is renamed "Fake...". Bug: chromium:1071733 Change-Id: I920368e648bede481058ac22f5b8794752a220b3 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179100 Commit-Queue: Henrik Boström <hbos@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31798}
2020-07-28 10:39:36 +02:00
SetLocalDescription,
Reland "[Perfect Negotiation] Implement non-racy version of SetLocalDescription." This is a reland of d4089cae47334a4228b69d6bb23f2e49ebb7496e with the following fix: Invoke MaybeStartGathering as the last step of DoSetLocalDescription. This ensures that candidates and onicegatheringstatechange does not happen before SLD is resolved. This is important for passing external/wpt/webrtc/RTCPeerConnection-iceGatheringState.html. Original change's description: > [Perfect Negotiation] Implement non-racy version of SetLocalDescription. > > BACKGROUND > > When SLD is invoked with SetSessionDescriptionObserver, the observer is > called by posting a message back to the execution thread, delaying the > call. This delay is "artificial" - it's not necessary; the operation is > already complete. It's a post from the signaling thread to the signaling > thread. The rationale for the post was to avoid the observer making > recursive calls back into the PeerConnection. The problem with this is > that by the time the observer is called, the PeerConnection could > already have executed other operations and modified its states. > > This causes the referenced bug: one can have a race where SLD is > resolved "too late" (after a pending SRD is executed) and the signaling > state observed when SLD resolves doesn't make sense. > > When implementing Unified Plan, we fixed similar issues for SRD by > adding a version that takes SetRemoteDescriptionObserverInterface as > argument instead of SetSessionDescriptionObserver. The new version did > not have the delay. The old version had to be kept around not to break > downstream projects that had dependencies both on he delay and on > allowing the PC to be destroyed midst-operation without informing its > observers. > > THIS CL > > This does the old SRD fix for SLD as well: A new observer interface is > added, SetLocalDescriptionObserverInterface, and > PeerConnection::SetLocalDescription() is overloaded. If you call it with > the old observer, you get the delay, but if you call it with the new > observer, you don't get a delay. > > - SetLocalDescriptionObserverInterface is added. > - SetLocalDescription is overloaded. > - The adapter for SetSessionDescriptionObserver that causes the delay > previously only used for SRD is updated to handle both SLD and SRD. > - FakeSetLocalDescriptionObserver is added and > MockSetRemoteDescriptionObserver is renamed "Fake...". > > Bug: chromium:1071733 > Change-Id: I920368e648bede481058ac22f5b8794752a220b3 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179100 > Commit-Queue: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#31798} TBR=hta@webrtc.org Bug: chromium:1071733 Change-Id: Ic6e8d96afa1c19604762f373716c08dbfa9d178c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180481 Commit-Queue: Henrik Boström <hbos@webrtc.org> Reviewed-by: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31804}
2020-07-29 12:04:00 +02:00
std::unique_ptr<SessionDescriptionInterface>,
rtc::scoped_refptr<SetLocalDescriptionObserverInterface>)
PROXY_METHOD1(void,
SetLocalDescription,
rtc::scoped_refptr<SetLocalDescriptionObserverInterface>)
[Perfect Negotiation] Implement non-racy version of SetLocalDescription. BACKGROUND When SLD is invoked with SetSessionDescriptionObserver, the observer is called by posting a message back to the execution thread, delaying the call. This delay is "artificial" - it's not necessary; the operation is already complete. It's a post from the signaling thread to the signaling thread. The rationale for the post was to avoid the observer making recursive calls back into the PeerConnection. The problem with this is that by the time the observer is called, the PeerConnection could already have executed other operations and modified its states. This causes the referenced bug: one can have a race where SLD is resolved "too late" (after a pending SRD is executed) and the signaling state observed when SLD resolves doesn't make sense. When implementing Unified Plan, we fixed similar issues for SRD by adding a version that takes SetRemoteDescriptionObserverInterface as argument instead of SetSessionDescriptionObserver. The new version did not have the delay. The old version had to be kept around not to break downstream projects that had dependencies both on he delay and on allowing the PC to be destroyed midst-operation without informing its observers. THIS CL This does the old SRD fix for SLD as well: A new observer interface is added, SetLocalDescriptionObserverInterface, and PeerConnection::SetLocalDescription() is overloaded. If you call it with the old observer, you get the delay, but if you call it with the new observer, you don't get a delay. - SetLocalDescriptionObserverInterface is added. - SetLocalDescription is overloaded. - The adapter for SetSessionDescriptionObserver that causes the delay previously only used for SRD is updated to handle both SLD and SRD. - FakeSetLocalDescriptionObserver is added and MockSetRemoteDescriptionObserver is renamed "Fake...". Bug: chromium:1071733 Change-Id: I920368e648bede481058ac22f5b8794752a220b3 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179100 Commit-Queue: Henrik Boström <hbos@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31798}
2020-07-28 10:39:36 +02:00
PROXY_METHOD2(void,
Reland "[Perfect Negotiation] Implement non-racy version of SetLocalDescription." This is a reland of d4089cae47334a4228b69d6bb23f2e49ebb7496e with the following fix: Invoke MaybeStartGathering as the last step of DoSetLocalDescription. This ensures that candidates and onicegatheringstatechange does not happen before SLD is resolved. This is important for passing external/wpt/webrtc/RTCPeerConnection-iceGatheringState.html. Original change's description: > [Perfect Negotiation] Implement non-racy version of SetLocalDescription. > > BACKGROUND > > When SLD is invoked with SetSessionDescriptionObserver, the observer is > called by posting a message back to the execution thread, delaying the > call. This delay is "artificial" - it's not necessary; the operation is > already complete. It's a post from the signaling thread to the signaling > thread. The rationale for the post was to avoid the observer making > recursive calls back into the PeerConnection. The problem with this is > that by the time the observer is called, the PeerConnection could > already have executed other operations and modified its states. > > This causes the referenced bug: one can have a race where SLD is > resolved "too late" (after a pending SRD is executed) and the signaling > state observed when SLD resolves doesn't make sense. > > When implementing Unified Plan, we fixed similar issues for SRD by > adding a version that takes SetRemoteDescriptionObserverInterface as > argument instead of SetSessionDescriptionObserver. The new version did > not have the delay. The old version had to be kept around not to break > downstream projects that had dependencies both on he delay and on > allowing the PC to be destroyed midst-operation without informing its > observers. > > THIS CL > > This does the old SRD fix for SLD as well: A new observer interface is > added, SetLocalDescriptionObserverInterface, and > PeerConnection::SetLocalDescription() is overloaded. If you call it with > the old observer, you get the delay, but if you call it with the new > observer, you don't get a delay. > > - SetLocalDescriptionObserverInterface is added. > - SetLocalDescription is overloaded. > - The adapter for SetSessionDescriptionObserver that causes the delay > previously only used for SRD is updated to handle both SLD and SRD. > - FakeSetLocalDescriptionObserver is added and > MockSetRemoteDescriptionObserver is renamed "Fake...". > > Bug: chromium:1071733 > Change-Id: I920368e648bede481058ac22f5b8794752a220b3 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179100 > Commit-Queue: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#31798} TBR=hta@webrtc.org Bug: chromium:1071733 Change-Id: Ic6e8d96afa1c19604762f373716c08dbfa9d178c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180481 Commit-Queue: Henrik Boström <hbos@webrtc.org> Reviewed-by: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31804}
2020-07-29 12:04:00 +02:00
SetLocalDescription,
[Perfect Negotiation] Implement non-racy version of SetLocalDescription. BACKGROUND When SLD is invoked with SetSessionDescriptionObserver, the observer is called by posting a message back to the execution thread, delaying the call. This delay is "artificial" - it's not necessary; the operation is already complete. It's a post from the signaling thread to the signaling thread. The rationale for the post was to avoid the observer making recursive calls back into the PeerConnection. The problem with this is that by the time the observer is called, the PeerConnection could already have executed other operations and modified its states. This causes the referenced bug: one can have a race where SLD is resolved "too late" (after a pending SRD is executed) and the signaling state observed when SLD resolves doesn't make sense. When implementing Unified Plan, we fixed similar issues for SRD by adding a version that takes SetRemoteDescriptionObserverInterface as argument instead of SetSessionDescriptionObserver. The new version did not have the delay. The old version had to be kept around not to break downstream projects that had dependencies both on he delay and on allowing the PC to be destroyed midst-operation without informing its observers. THIS CL This does the old SRD fix for SLD as well: A new observer interface is added, SetLocalDescriptionObserverInterface, and PeerConnection::SetLocalDescription() is overloaded. If you call it with the old observer, you get the delay, but if you call it with the new observer, you don't get a delay. - SetLocalDescriptionObserverInterface is added. - SetLocalDescription is overloaded. - The adapter for SetSessionDescriptionObserver that causes the delay previously only used for SRD is updated to handle both SLD and SRD. - FakeSetLocalDescriptionObserver is added and MockSetRemoteDescriptionObserver is renamed "Fake...". Bug: chromium:1071733 Change-Id: I920368e648bede481058ac22f5b8794752a220b3 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179100 Commit-Queue: Henrik Boström <hbos@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31798}
2020-07-28 10:39:36 +02:00
SetSessionDescriptionObserver*,
SessionDescriptionInterface*)
Reland "[Perfect Negotiation] Implement non-racy version of SetLocalDescription." This is a reland of d4089cae47334a4228b69d6bb23f2e49ebb7496e with the following fix: Invoke MaybeStartGathering as the last step of DoSetLocalDescription. This ensures that candidates and onicegatheringstatechange does not happen before SLD is resolved. This is important for passing external/wpt/webrtc/RTCPeerConnection-iceGatheringState.html. Original change's description: > [Perfect Negotiation] Implement non-racy version of SetLocalDescription. > > BACKGROUND > > When SLD is invoked with SetSessionDescriptionObserver, the observer is > called by posting a message back to the execution thread, delaying the > call. This delay is "artificial" - it's not necessary; the operation is > already complete. It's a post from the signaling thread to the signaling > thread. The rationale for the post was to avoid the observer making > recursive calls back into the PeerConnection. The problem with this is > that by the time the observer is called, the PeerConnection could > already have executed other operations and modified its states. > > This causes the referenced bug: one can have a race where SLD is > resolved "too late" (after a pending SRD is executed) and the signaling > state observed when SLD resolves doesn't make sense. > > When implementing Unified Plan, we fixed similar issues for SRD by > adding a version that takes SetRemoteDescriptionObserverInterface as > argument instead of SetSessionDescriptionObserver. The new version did > not have the delay. The old version had to be kept around not to break > downstream projects that had dependencies both on he delay and on > allowing the PC to be destroyed midst-operation without informing its > observers. > > THIS CL > > This does the old SRD fix for SLD as well: A new observer interface is > added, SetLocalDescriptionObserverInterface, and > PeerConnection::SetLocalDescription() is overloaded. If you call it with > the old observer, you get the delay, but if you call it with the new > observer, you don't get a delay. > > - SetLocalDescriptionObserverInterface is added. > - SetLocalDescription is overloaded. > - The adapter for SetSessionDescriptionObserver that causes the delay > previously only used for SRD is updated to handle both SLD and SRD. > - FakeSetLocalDescriptionObserver is added and > MockSetRemoteDescriptionObserver is renamed "Fake...". > > Bug: chromium:1071733 > Change-Id: I920368e648bede481058ac22f5b8794752a220b3 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179100 > Commit-Queue: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#31798} TBR=hta@webrtc.org Bug: chromium:1071733 Change-Id: Ic6e8d96afa1c19604762f373716c08dbfa9d178c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180481 Commit-Queue: Henrik Boström <hbos@webrtc.org> Reviewed-by: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31804}
2020-07-29 12:04:00 +02:00
PROXY_METHOD1(void, SetLocalDescription, SetSessionDescriptionObserver*)
Revert "[Perfect Negotiation] Implement non-racy version of SetLocalDescription." This reverts commit d4089cae47334a4228b69d6bb23f2e49ebb7496e. Reason for revert: Breaks chromium WPT that is timing sensitive to onicegatheringstatechanges. This CL accidentally moved the MaybeStartGatheringIceCandidates to after completing the SLD call. The fix is to move it back. I'll do that in a re-land. Original change's description: > [Perfect Negotiation] Implement non-racy version of SetLocalDescription. > > BACKGROUND > > When SLD is invoked with SetSessionDescriptionObserver, the observer is > called by posting a message back to the execution thread, delaying the > call. This delay is "artificial" - it's not necessary; the operation is > already complete. It's a post from the signaling thread to the signaling > thread. The rationale for the post was to avoid the observer making > recursive calls back into the PeerConnection. The problem with this is > that by the time the observer is called, the PeerConnection could > already have executed other operations and modified its states. > > This causes the referenced bug: one can have a race where SLD is > resolved "too late" (after a pending SRD is executed) and the signaling > state observed when SLD resolves doesn't make sense. > > When implementing Unified Plan, we fixed similar issues for SRD by > adding a version that takes SetRemoteDescriptionObserverInterface as > argument instead of SetSessionDescriptionObserver. The new version did > not have the delay. The old version had to be kept around not to break > downstream projects that had dependencies both on he delay and on > allowing the PC to be destroyed midst-operation without informing its > observers. > > THIS CL > > This does the old SRD fix for SLD as well: A new observer interface is > added, SetLocalDescriptionObserverInterface, and > PeerConnection::SetLocalDescription() is overloaded. If you call it with > the old observer, you get the delay, but if you call it with the new > observer, you don't get a delay. > > - SetLocalDescriptionObserverInterface is added. > - SetLocalDescription is overloaded. > - The adapter for SetSessionDescriptionObserver that causes the delay > previously only used for SRD is updated to handle both SLD and SRD. > - FakeSetLocalDescriptionObserver is added and > MockSetRemoteDescriptionObserver is renamed "Fake...". > > Bug: chromium:1071733 > Change-Id: I920368e648bede481058ac22f5b8794752a220b3 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179100 > Commit-Queue: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#31798} TBR=hbos@webrtc.org,hta@webrtc.org Change-Id: Ie1e1ecc49f3b1d7a7e230db6d36decbc4cbe8c86 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1071733 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180480 Reviewed-by: Henrik Boström <hbos@webrtc.org> Commit-Queue: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31802}
2020-07-29 09:46:40 +00:00
PROXY_METHOD2(void,
SetRemoteDescription,
std::unique_ptr<SessionDescriptionInterface>,
rtc::scoped_refptr<SetRemoteDescriptionObserverInterface>)
Reland "[Perfect Negotiation] Implement non-racy version of SetLocalDescription." This is a reland of d4089cae47334a4228b69d6bb23f2e49ebb7496e with the following fix: Invoke MaybeStartGathering as the last step of DoSetLocalDescription. This ensures that candidates and onicegatheringstatechange does not happen before SLD is resolved. This is important for passing external/wpt/webrtc/RTCPeerConnection-iceGatheringState.html. Original change's description: > [Perfect Negotiation] Implement non-racy version of SetLocalDescription. > > BACKGROUND > > When SLD is invoked with SetSessionDescriptionObserver, the observer is > called by posting a message back to the execution thread, delaying the > call. This delay is "artificial" - it's not necessary; the operation is > already complete. It's a post from the signaling thread to the signaling > thread. The rationale for the post was to avoid the observer making > recursive calls back into the PeerConnection. The problem with this is > that by the time the observer is called, the PeerConnection could > already have executed other operations and modified its states. > > This causes the referenced bug: one can have a race where SLD is > resolved "too late" (after a pending SRD is executed) and the signaling > state observed when SLD resolves doesn't make sense. > > When implementing Unified Plan, we fixed similar issues for SRD by > adding a version that takes SetRemoteDescriptionObserverInterface as > argument instead of SetSessionDescriptionObserver. The new version did > not have the delay. The old version had to be kept around not to break > downstream projects that had dependencies both on he delay and on > allowing the PC to be destroyed midst-operation without informing its > observers. > > THIS CL > > This does the old SRD fix for SLD as well: A new observer interface is > added, SetLocalDescriptionObserverInterface, and > PeerConnection::SetLocalDescription() is overloaded. If you call it with > the old observer, you get the delay, but if you call it with the new > observer, you don't get a delay. > > - SetLocalDescriptionObserverInterface is added. > - SetLocalDescription is overloaded. > - The adapter for SetSessionDescriptionObserver that causes the delay > previously only used for SRD is updated to handle both SLD and SRD. > - FakeSetLocalDescriptionObserver is added and > MockSetRemoteDescriptionObserver is renamed "Fake...". > > Bug: chromium:1071733 > Change-Id: I920368e648bede481058ac22f5b8794752a220b3 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179100 > Commit-Queue: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#31798} TBR=hta@webrtc.org Bug: chromium:1071733 Change-Id: Ic6e8d96afa1c19604762f373716c08dbfa9d178c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180481 Commit-Queue: Henrik Boström <hbos@webrtc.org> Reviewed-by: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31804}
2020-07-29 12:04:00 +02:00
PROXY_METHOD2(void,
SetRemoteDescription,
SetSessionDescriptionObserver*,
SessionDescriptionInterface*)
Update PeerConnectionProxy to reflect new PeerConnectionInterface methods Bug: webrtc:10133 Change-Id: I0fa62d7265b3a101e7c55695fca47b72d7fabf58 Reviewed-on: https://webrtc-review.googlesource.com/c/114913 Reviewed-by: Seth Hampson <shampson@webrtc.org> Commit-Queue: Steve Anton <steveanton@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26060}
2018-12-18 16:29:34 -08:00
PROXY_METHOD0(PeerConnectionInterface::RTCConfiguration, GetConfiguration)
RTCError as return type for PeerConnectionInterface::SetConfiguration Bug: None Change-Id: I6dd7378ceac617e29945d72906cb8e2e0bd49538 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149166 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Sami Kalliomäki <sakal@webrtc.org> Reviewed-by: Steve Anton <steveanton@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28910}
2019-08-19 09:58:17 +02:00
PROXY_METHOD1(RTCError,
Reformat the WebRTC code base Running clang-format with chromium's style guide. The goal is n-fold: * providing consistency and readability (that's what code guidelines are for) * preventing noise with presubmit checks and git cl format * building on the previous point: making it easier to automatically fix format issues * you name it Please consider using git-hyper-blame to ignore this commit. Bug: webrtc:9340 Change-Id: I694567c4cdf8cee2860958cfe82bfaf25848bb87 Reviewed-on: https://webrtc-review.googlesource.com/81185 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23660}
2018-06-19 15:03:05 +02:00
SetConfiguration,
Update PeerConnectionProxy to reflect new PeerConnectionInterface methods Bug: webrtc:10133 Change-Id: I0fa62d7265b3a101e7c55695fca47b72d7fabf58 Reviewed-on: https://webrtc-review.googlesource.com/c/114913 Reviewed-by: Seth Hampson <shampson@webrtc.org> Commit-Queue: Steve Anton <steveanton@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26060}
2018-12-18 16:29:34 -08:00
const PeerConnectionInterface::RTCConfiguration&)
Reformat the WebRTC code base Running clang-format with chromium's style guide. The goal is n-fold: * providing consistency and readability (that's what code guidelines are for) * preventing noise with presubmit checks and git cl format * building on the previous point: making it easier to automatically fix format issues * you name it Please consider using git-hyper-blame to ignore this commit. Bug: webrtc:9340 Change-Id: I694567c4cdf8cee2860958cfe82bfaf25848bb87 Reviewed-on: https://webrtc-review.googlesource.com/81185 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23660}
2018-06-19 15:03:05 +02:00
PROXY_METHOD1(bool, AddIceCandidate, const IceCandidateInterface*)
[PeerConnection] Implement asynchronous version of AddIceCandidate(). This is the same as the existing version, except it uses the Operations Chain. As such, if an asynchronous operation that uses the chain is currently pending, such as CreateOffer() or CreateAnswer(), AddIceCandidate() will not happen until the previous operation completes. Bug: chromium:1019222 Change-Id: Ie6e5fc386fa9c29b5e2f8e3f65bfbaf9837d351c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/158741 Commit-Queue: Henrik Boström <hbos@webrtc.org> Reviewed-by: Steve Anton <steveanton@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29704}
2019-11-06 12:36:12 +01:00
PROXY_METHOD2(void,
AddIceCandidate,
std::unique_ptr<IceCandidateInterface>,
std::function<void(RTCError)>)
Update PeerConnectionProxy to reflect new PeerConnectionInterface methods Bug: webrtc:10133 Change-Id: I0fa62d7265b3a101e7c55695fca47b72d7fabf58 Reviewed-on: https://webrtc-review.googlesource.com/c/114913 Reviewed-by: Seth Hampson <shampson@webrtc.org> Commit-Queue: Steve Anton <steveanton@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26060}
2018-12-18 16:29:34 -08:00
PROXY_METHOD1(bool, RemoveIceCandidates, const std::vector<cricket::Candidate>&)
PROXY_METHOD1(RTCError, SetBitrate, const BitrateSettings&)
Reformat the WebRTC code base Running clang-format with chromium's style guide. The goal is n-fold: * providing consistency and readability (that's what code guidelines are for) * preventing noise with presubmit checks and git cl format * building on the previous point: making it easier to automatically fix format issues * you name it Please consider using git-hyper-blame to ignore this commit. Bug: webrtc:9340 Change-Id: I694567c4cdf8cee2860958cfe82bfaf25848bb87 Reviewed-on: https://webrtc-review.googlesource.com/81185 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23660}
2018-06-19 15:03:05 +02:00
PROXY_METHOD1(void, SetAudioPlayout, bool)
PROXY_METHOD1(void, SetAudioRecording, bool)
Add LookupDtlsTransportByMid to proxy map Bug: chromium:907849 Change-Id: Ib707f18fdf67617967b83cd17f0454d182b8011f Reviewed-on: https://webrtc-review.googlesource.com/c/112907 Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25885}
2018-12-03 18:45:19 +01:00
PROXY_METHOD1(rtc::scoped_refptr<DtlsTransportInterface>,
LookupDtlsTransportByMid,
const std::string&)
Add GetSctpTransport to proxy map Should have been in previous CL. Bug: chromium:818643 Change-Id: I7306c37820ddc5552f6002d77d46768636a1b45b Reviewed-on: https://webrtc-review.googlesource.com/c/125083 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26915}
2019-02-28 21:33:00 +01:00
PROXY_CONSTMETHOD0(rtc::scoped_refptr<SctpTransportInterface>, GetSctpTransport)
Reformat the WebRTC code base Running clang-format with chromium's style guide. The goal is n-fold: * providing consistency and readability (that's what code guidelines are for) * preventing noise with presubmit checks and git cl format * building on the previous point: making it easier to automatically fix format issues * you name it Please consider using git-hyper-blame to ignore this commit. Bug: webrtc:9340 Change-Id: I694567c4cdf8cee2860958cfe82bfaf25848bb87 Reviewed-on: https://webrtc-review.googlesource.com/81185 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23660}
2018-06-19 15:03:05 +02:00
PROXY_METHOD0(SignalingState, signaling_state)
PROXY_METHOD0(IceConnectionState, ice_connection_state)
Update PeerConnectionProxy to reflect new PeerConnectionInterface methods Bug: webrtc:10133 Change-Id: I0fa62d7265b3a101e7c55695fca47b72d7fabf58 Reviewed-on: https://webrtc-review.googlesource.com/c/114913 Reviewed-by: Seth Hampson <shampson@webrtc.org> Commit-Queue: Steve Anton <steveanton@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26060}
2018-12-18 16:29:34 -08:00
PROXY_METHOD0(IceConnectionState, standardized_ice_connection_state)
PROXY_METHOD0(PeerConnectionState, peer_connection_state)
Reformat the WebRTC code base Running clang-format with chromium's style guide. The goal is n-fold: * providing consistency and readability (that's what code guidelines are for) * preventing noise with presubmit checks and git cl format * building on the previous point: making it easier to automatically fix format issues * you name it Please consider using git-hyper-blame to ignore this commit. Bug: webrtc:9340 Change-Id: I694567c4cdf8cee2860958cfe82bfaf25848bb87 Reviewed-on: https://webrtc-review.googlesource.com/81185 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23660}
2018-06-19 15:03:05 +02:00
PROXY_METHOD0(IceGatheringState, ice_gathering_state)
Reland "Expose can_trickle_ice_candidates on PeerConnection" This reverts commit cb8c40138ca170f841bc45fa6771cdfc4b966e5f. Reason for revert: Added missing default. Original change's description: > Revert "Expose can_trickle_ice_candidates on PeerConnection" > > This reverts commit c6a65c8866487c6adc0a7bb472d3bad9389501f9. > > Reason for revert: Breaks downstream due to missing default > > Original change's description: > > Expose can_trickle_ice_candidates on PeerConnection > > > > Bug: chromium:708484 > > Change-Id: I9a40e75066341f0d9f965bd3718bfcb3f0459533 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169450 > > Commit-Queue: Harald Alvestrand <hta@webrtc.org> > > Reviewed-by: Taylor <deadbeef@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#30653} > > TBR=deadbeef@webrtc.org,hta@webrtc.org > > Change-Id: Iaa5b977c4237715a8a5127cf167cf6512a3f7059 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:708484 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169540 > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > Commit-Queue: Harald Alvestrand <hta@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#30655} TBR=deadbeef@webrtc.org,hta@webrtc.org Change-Id: I608da7781f158b4b02dd226d4dcd5615c4935fa8 Bug: chromium:708484 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169541 Commit-Queue: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30656}
2020-03-02 11:20:00 +01:00
PROXY_METHOD0(absl::optional<bool>, can_trickle_ice_candidates)
[Adaptation] Add ability to inject resources on the PeerConnection. This unblocks injecting platform-specific resources, such as power usage signals in Chrome. This CL adds AddAdaptationResource to PeerConnectionInterface and integration tests verifying that if an injected resource is overusing, resolution will soon be reduced. To aid testing, some testing-only classes have been updated. Bug: webrtc:11525 Change-Id: I820099e79f18d910fd641ee1412ad064b99ebce9 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/177003 Reviewed-by: Evan Shrubsole <eshr@google.com> Reviewed-by: Stefan Holmer <stefan@webrtc.org> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Commit-Queue: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31505}
2020-06-11 12:26:53 +02:00
PROXY_METHOD1(void, AddAdaptationResource, rtc::scoped_refptr<Resource>)
Reformat the WebRTC code base Running clang-format with chromium's style guide. The goal is n-fold: * providing consistency and readability (that's what code guidelines are for) * preventing noise with presubmit checks and git cl format * building on the previous point: making it easier to automatically fix format issues * you name it Please consider using git-hyper-blame to ignore this commit. Bug: webrtc:9340 Change-Id: I694567c4cdf8cee2860958cfe82bfaf25848bb87 Reviewed-on: https://webrtc-review.googlesource.com/81185 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23660}
2018-06-19 15:03:05 +02:00
PROXY_METHOD2(bool,
StartRtcEventLog,
std::unique_ptr<RtcEventLogOutput>,
Update PeerConnectionProxy to reflect new PeerConnectionInterface methods Bug: webrtc:10133 Change-Id: I0fa62d7265b3a101e7c55695fca47b72d7fabf58 Reviewed-on: https://webrtc-review.googlesource.com/c/114913 Reviewed-by: Seth Hampson <shampson@webrtc.org> Commit-Queue: Steve Anton <steveanton@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26060}
2018-12-18 16:29:34 -08:00
int64_t)
Add missing proxy function for overloaded StartRtcEventLog peer connection function. TBR=kwiberg@webrtc.org Bug: webrtc:6463, webrtc:10716 Change-Id: I1cdfb87e30a9aef5ecc297339721397591542646 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/140164 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28164}
2019-06-04 11:23:32 -07:00
PROXY_METHOD1(bool, StartRtcEventLog, std::unique_ptr<RtcEventLogOutput>)
Reformat the WebRTC code base Running clang-format with chromium's style guide. The goal is n-fold: * providing consistency and readability (that's what code guidelines are for) * preventing noise with presubmit checks and git cl format * building on the previous point: making it easier to automatically fix format issues * you name it Please consider using git-hyper-blame to ignore this commit. Bug: webrtc:9340 Change-Id: I694567c4cdf8cee2860958cfe82bfaf25848bb87 Reviewed-on: https://webrtc-review.googlesource.com/81185 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23660}
2018-06-19 15:03:05 +02:00
PROXY_METHOD0(void, StopRtcEventLog)
PROXY_METHOD0(void, Close)
Adding some features to proxy.h, and restructuring the macros. New features are: - Invoke a destructor on the worker thread. - Make proxy wrapper for a non-refcounted object. - Ability to use unique_ptrs (as arguments or return values). These features are needed by this CL: https://codereview.webrtc.org/2632613002/ BUG=None Review-Url: https://codereview.webrtc.org/2628343003 Cr-Commit-Position: refs/heads/master@{#16151}
2017-01-18 08:55:23 -08:00
END_PROXY_MAP()
Adds trunk/talk folder of revision 359 from libjingles google code to trunk/talk git-svn-id: http://webrtc.googlecode.com/svn/trunk@4318 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-10 00:45:36 +00:00
} // namespace webrtc
(4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries Mechanically generated by running this command: tools_webrtc/do-renames.sh update all-renames.txt && git cl format Then manually updating: tools_webrtc/sanitizers/tsan_suppressions_webrtc.cc Bug: webrtc:10159 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I54824cd91dada8fc3ee3d098f971bc319d477833 Reviewed-on: https://webrtc-review.googlesource.com/c/115653 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26226}
2019-01-11 09:11:00 -08:00
#endif // API_PEER_CONNECTION_PROXY_H_
Reference in New Issue Copy Permalink