admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
webrtc_m130/api/video_codecs/BUILD.gn

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

495 lines
14 KiB
Plaintext
Raw Normal View History

Reland of Move video_encoder.h and video_decoder.h to /api and create GN targets for them (patchset #1 id:1 of https://codereview.webrtc.org/2794033002/ ) Reason for revert: Reland with temporary deprecated API to not break chromium and google3. Original issue's description: > Revert of Move video_encoder.h and video_decoder.h to /api and create GN targets for them (patchset #8 id:140001 of https://codereview.webrtc.org/2780943003/ ) > > Reason for revert: > Suspect of breaking Chrome FYI bots. > > See > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/23065 > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder > > Example logs: > ../../content/renderer/media/gpu/rtc_video_encoder_unittest.cc:18:46: fatal error: third_party/webrtc/video_encoder.h: No such file or directory > #include "third_party/webrtc/video_encoder.h" > ^ > > Original issue's description: > > Move video_encoder.h and video_decoder.h to /api and create GN targets for them > > > > BUG=webrtc:5881 > > # Because PRESUBMIT ignores LINT blacklist for moved files and these > > # headers have some not easy to resolve issues. > > NOPRESUBMIT=True > > > > Review-Url: https://codereview.webrtc.org/2780943003 > > Cr-Commit-Position: refs/heads/master@{#17511} > > Committed: https://chromium.googlesource.com/external/webrtc/+/c42f54057050c933008a49d57582577bfb9aed25 > > TBR=solenberg@webrtc.org,sprang@webrtc.org,ilnik@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:5881 > > Review-Url: https://codereview.webrtc.org/2794033002 > Cr-Commit-Position: refs/heads/master@{#17514} > Committed: https://chromium.googlesource.com/external/webrtc/+/716d7ac5c1ed6e392e264b34065800bbf03772b3 TBR=solenberg@webrtc.org,sprang@webrtc.org,guidou@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5881 Review-Url: https://codereview.webrtc.org/2795163002 Cr-Commit-Position: refs/heads/master@{#17537}
2017-04-05 03:02:20 -07:00
# Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
#
# Use of this source code is governed by a BSD-style license
# that can be found in the LICENSE file in the root of the source
# tree. An additional intellectual property rights grant can be found
# in the file PATENTS. All contributing project authors may
# be found in the AUTHORS file in the root of the source tree.
import("../../webrtc.gni")
if (is_android) {
import("//build/config/android/config.gni")
import("//build/config/android/rules.gni")
}
New enum ScalabilityMode. Used instead of string representation in lower-levels of encoder configuration, to avoid string comparisons (with risk of misspelling) in lots of places. Bug: webrtc:11607 Change-Id: I4d51c2265aac297c29976d2aa601d8ffb33b7326 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259870 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Florent Castelli <orphis@webrtc.org> Reviewed-by: Åsa Persson <asapersson@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36706}
2022-04-29 11:03:13 +02:00
rtc_source_set("scalability_mode") {
Add public visibility for scalability_mode target Bug: webrtc:11607 Change-Id: I93681ef6ff5918bd3bb26b006a9db9cab1805df2 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265862 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37223}
2022-06-15 12:52:01 +02:00
visibility = [ "*" ]
Let PCF.GetRtpSenderCapabilities return codecs' scalabilityModes. Also move ScalabilityModeToString to api and add RTC_EXPORT so that Chromium can use it. Bug: chromium:986069 Change-Id: I5dbbb6de9b14ca20f3ae0630552dcd44595ad5ef Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267780 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com> Cr-Commit-Position: refs/heads/main@{#37444}
2022-07-05 21:06:28 +09:00
sources = [
"scalability_mode.cc",
"scalability_mode.h",
]
deps = [
"../../rtc_base:checks",
"../../rtc_base/system:rtc_export",
Mass removal of absl_deps in all BUILD.gn files Bug: webrtc:341803749 Change-Id: Id73844ba8d63b9f2f2c9391d8d8116ad0864c36d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/351540 Commit-Queue: Florent Castelli <orphis@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42372}
2024-05-23 11:21:53 +00:00
"//third_party/abseil-cpp/absl/strings:string_view",
Let PCF.GetRtpSenderCapabilities return codecs' scalabilityModes. Also move ScalabilityModeToString to api and add RTC_EXPORT so that Chromium can use it. Bug: chromium:986069 Change-Id: I5dbbb6de9b14ca20f3ae0630552dcd44595ad5ef Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267780 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com> Cr-Commit-Position: refs/heads/main@{#37444}
2022-07-05 21:06:28 +09:00
]
New enum ScalabilityMode. Used instead of string representation in lower-levels of encoder configuration, to avoid string comparisons (with risk of misspelling) in lots of places. Bug: webrtc:11607 Change-Id: I4d51c2265aac297c29976d2aa601d8ffb33b7326 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259870 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Florent Castelli <orphis@webrtc.org> Reviewed-by: Åsa Persson <asapersson@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36706}
2022-04-29 11:03:13 +02:00
}
api/video_codecs: Add scalability mode helper functions. Bug: webrtc:13960 Change-Id: I8c86e440223929594aec06e8b32b4bbe73546a94 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/273303 Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Florent Castelli <orphis@webrtc.org> Commit-Queue: Åsa Persson <asapersson@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37994}
2022-09-02 11:05:13 +02:00
rtc_source_set("scalability_mode_helper") {
visibility = [ "*" ]
sources = [
"scalability_mode_helper.cc",
"scalability_mode_helper.h",
]
Add `ScalabilityModeStringToEnum` helper function. Bug: none Change-Id: Iea602c88afbfe1f8f8e94b353eda96d62b651bd8 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/319882 Commit-Queue: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/main@{#40732}
2023-09-11 17:30:26 +02:00
deps = [
":scalability_mode",
"../../modules/video_coding/svc:scalability_mode_util",
Mass removal of absl_deps in all BUILD.gn files Bug: webrtc:341803749 Change-Id: Id73844ba8d63b9f2f2c9391d8d8116ad0864c36d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/351540 Commit-Queue: Florent Castelli <orphis@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42372}
2024-05-23 11:21:53 +00:00
"//third_party/abseil-cpp/absl/strings:string_view",
api/video_codecs: Add scalability mode helper functions. Bug: webrtc:13960 Change-Id: I8c86e440223929594aec06e8b32b4bbe73546a94 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/273303 Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Florent Castelli <orphis@webrtc.org> Commit-Queue: Åsa Persson <asapersson@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37994}
2022-09-02 11:05:13 +02:00
"//third_party/abseil-cpp/absl/types:optional",
]
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("video_codecs_api") {
Revert "Revert "GN rtc_* templates: Set default visibility to webrtc_root + "/*""" This reverts commit c73e1f437889d882cbf2987f7fb3a029a6150613. Reason for revert: The problem with failed deps in chrome content/renderer had already been fixed in https://webrtc-review.googlesource.com/c/src/+/38660 Original change's description: > Revert "GN rtc_* templates: Set default visibility to webrtc_root + "/*"" > > This reverts commit 588c548657b3ddf76e7b3f241263eef7f5799f16. > > Reason for revert: > > Breaks Chrome FYI: > > /b/c/b/Linux_Builder/src/buildtools/linux64/gn gen //out/Release --check > -> returned 1 > ERROR at //build/split_static_library.gni:12:5: Dependency not allowed. > static_library(target_name) { > ^---------------------------- > The item //content/renderer:renderer > can not depend on //third_party/webrtc/media:rtc_internal_video_codecs > because it is not in //third_party/webrtc/media:rtc_internal_video_codecs's visibility list: [ > //third_party/webrtc/* > //third_party/webrtc_overrides/* > ] > > https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.webrtc.fyi%2FLinux_Builder%2F23560%2F%2B%2Frecipes%2Fsteps%2Fgenerate_build_files%2F0%2Fstdout > > Original change's description: > > GN rtc_* templates: Set default visibility to webrtc_root + "/*" > > > > This means that by default, targets are visible to everything under > > the WebRTC root, but not visible to anything else. > > > > API targets are manually tagged with visibility "*", so that targets > > outside the WebRTC tree can see them. > > > > BUG=webrtc:8254 > > > > Change-Id: Icdbee6e0d22d93240ff2fb530c8f9dc48e351509 > > Reviewed-on: https://webrtc-review.googlesource.com/24140 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#21548} > > TBR=mbonadei@webrtc.org,kwiberg@webrtc.org > > Change-Id: I06620ce3d6f67482935c22efa231dd6cab91625a > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:8254 > Reviewed-on: https://webrtc-review.googlesource.com/38760 > Reviewed-by: Per Kjellander <perkj@webrtc.org> > Commit-Queue: Per Kjellander <perkj@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#21555} TBR=mbonadei@webrtc.org,kwiberg@webrtc.org,perkj@webrtc.org Change-Id: I6f720078ce21bd172e0a6471bae8c4c011e4a657 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:8254 Reviewed-on: https://webrtc-review.googlesource.com/38860 Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Per Kjellander <perkj@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21558}
2018-01-10 15:54:53 +00:00
visibility = [ "*" ]
Reland of Move video_encoder.h and video_decoder.h to /api and create GN targets for them (patchset #1 id:1 of https://codereview.webrtc.org/2794033002/ ) Reason for revert: Reland with temporary deprecated API to not break chromium and google3. Original issue's description: > Revert of Move video_encoder.h and video_decoder.h to /api and create GN targets for them (patchset #8 id:140001 of https://codereview.webrtc.org/2780943003/ ) > > Reason for revert: > Suspect of breaking Chrome FYI bots. > > See > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/23065 > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder > > Example logs: > ../../content/renderer/media/gpu/rtc_video_encoder_unittest.cc:18:46: fatal error: third_party/webrtc/video_encoder.h: No such file or directory > #include "third_party/webrtc/video_encoder.h" > ^ > > Original issue's description: > > Move video_encoder.h and video_decoder.h to /api and create GN targets for them > > > > BUG=webrtc:5881 > > # Because PRESUBMIT ignores LINT blacklist for moved files and these > > # headers have some not easy to resolve issues. > > NOPRESUBMIT=True > > > > Review-Url: https://codereview.webrtc.org/2780943003 > > Cr-Commit-Position: refs/heads/master@{#17511} > > Committed: https://chromium.googlesource.com/external/webrtc/+/c42f54057050c933008a49d57582577bfb9aed25 > > TBR=solenberg@webrtc.org,sprang@webrtc.org,ilnik@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:5881 > > Review-Url: https://codereview.webrtc.org/2794033002 > Cr-Commit-Position: refs/heads/master@{#17514} > Committed: https://chromium.googlesource.com/external/webrtc/+/716d7ac5c1ed6e392e264b34065800bbf03772b3 TBR=solenberg@webrtc.org,sprang@webrtc.org,guidou@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5881 Review-Url: https://codereview.webrtc.org/2795163002 Cr-Commit-Position: refs/heads/master@{#17537}
2017-04-05 03:02:20 -07:00
sources = [
Adding some AV1 constants and helper functions I've added a basic AV1 impl to Chrome Remote Desktop and am looking into what is needed to test with I444 (Profile-1) in our platform. This CL adds a few helper functions, constants, and enums that can be used to configure the SDP with different AV1 profiles. More work is still needed but I wanted to get this in place first so I can build on it in the CRD host code. Change-Id: I1af9ebf31f833138e8c36e0c0a30e32289e7b58e Bug: chromium:1329660 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264000 Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Commit-Queue: Joe Downing <joedow@google.com> Cr-Commit-Position: refs/heads/main@{#37182}
2022-06-09 15:56:08 -07:00
"av1_profile.cc",
"av1_profile.h",
Move h264_profile_level_id and vp9_profile to api/video_codecs This is a refactor to simplify a follow-up CL of adding SdpVideoFormat::IsSameCodec. The original files media/base/h264_profile_level_id.* and media/base/vp9_profile.h must be kept until downstream projects stop using them. Bug: chroimium:1187565 Change-Id: Ib39eca095a3d61939a914d9bffaf4b891ddd222f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/215236 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Johannes Kron <kron@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33782}
2021-04-19 09:09:26 +02:00
"h264_profile_level_id.cc",
"h264_profile_level_id.h",
Fix chromium warnings for SdpVideoFormat. Bug: webrtc:163 Change-Id: I29ad3c00116692f047456df7721ba636bbb2ca89 Reviewed-on: https://webrtc-review.googlesource.com/64723 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22618}
2018-03-27 08:31:45 +02:00
"sdp_video_format.cc",
Reland of Prepare for injectable SW decoders (patchset #1 id:1 of https://codereview.webrtc.org/3010953002/ ) Reason for revert: Fix bug introduced by keeping the allocated decoders in a map. Original issue's description: > Revert of Prepare for injectable SW decoders (patchset #3 id:40001 of https://codereview.webrtc.org/3009973002/ ) > > Reason for revert: > Tentative revert since it seems to cause problems in Chrome, MAC. > > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Tester/builds/42684 > > > > Original issue's description: > > Prepare for injectable SW decoders > > > > Pretty much mirrors the work done on the encoding side in CLs: > > > > "Clean up ownership of webrtc::VideoEncoder" > > https://codereview.webrtc.org/3007643002/ > > > > "Let VideoEncoderSoftwareFallbackWrapper own the wrapped encoder" > > https://codereview.webrtc.org/3007683002/ > > > > "WebRtcVideoEngine: Encapsulate logic for unifying internal and external video codecs" > > https://codereview.webrtc.org/3006713002/ > > > > BUG=webrtc:7925 > > > > Review-Url: https://codereview.webrtc.org/3009973002 > > Cr-Commit-Position: refs/heads/master@{#19641} > > Committed: https://chromium.googlesource.com/external/webrtc/+/084c55a63a2d9bdc71579458406d44f8bab9f454 > > TBR=magjed@webrtc.org,andersc@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:7925 > > Review-Url: https://codereview.webrtc.org/3010953002 > Cr-Commit-Position: refs/heads/master@{#19647} > Committed: https://chromium.googlesource.com/external/webrtc/+/1f88531038c24c5ce3b0f4cfc682b970770a71f6 TBR=magjed@webrtc.org,perkj@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:7925 Review-Url: https://codereview.webrtc.org/3005363002 Cr-Commit-Position: refs/heads/master@{#19782}
2017-09-11 11:50:51 -07:00
"sdp_video_format.h",
Add temporary accessors for numberOfTemporalLayers Intended to be used in downstream code when deleting deleting this attribute. Bug: webrtc:11607 Change-Id: I39417997a2ec2e72d726da476b5bce88abe267b6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267843 Reviewed-by: Erik Språng <sprang@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37445}
2022-07-05 14:22:27 +02:00
"simulcast_stream.cc",
Define SimulcastStream as an alias for SpatialLayer Step one in making it a separate type, that will be done as a followup, after downstream code is updated to use the new name. Bug: webrtc:11607 Change-Id: I6fa664a0729b1cfd71b7f02b6441880beee0e741 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262806 Reviewed-by: Erik Språng <sprang@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36946}
2022-05-20 13:38:49 +02:00
"simulcast_stream.h",
Move definition of SpatialLayer to api/video_codecs/spatial_layer.h Bug: webrtc:7660 Change-Id: I54009ebc5f65b6875a8c079ab5264e0c5ce9f654 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/181500 Reviewed-by: Erik Språng <sprang@webrtc.org> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31942}
2020-08-14 15:32:14 +02:00
"spatial_layer.h",
Reland "Move class VideoCodec from common_types.h to its own api header file." This is a reland of efc71e565e9b36bcdfb4571f59e34bbd8fabd0cd Differs from the original cl by not widening the type of VideoCodec::width and VideoCodec::height. Original change's description: > Move class VideoCodec from common_types.h to its own api header file. > > Bug: webrtc:7660 > Change-Id: I91f19bfc2565461328f30081f8383e136419aefb > Reviewed-on: https://webrtc-review.googlesource.com/79881 > Commit-Queue: Niels Moller <nisse@webrtc.org> > Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> > Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#23544} Bug: webrtc:7660 Change-Id: I7cf74a85a61ea2b831e6f32b3b3e17514ebefec8 Reviewed-on: https://webrtc-review.googlesource.com/82140 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23569}
2018-06-08 14:03:44 +02:00
"video_codec.cc",
Add placeholder header file api/video_codecs/video_codec.h. This is a preparation for moving declaration of the VideoCodec class to this file. Applications using the legacy VideoCodec class should start including this file instead of common_types.h. Bug: webrtc:7660 Change-Id: I9fe1a2bffa7b0c17059fc4e3b7e351f5019f1d00 Reviewed-on: https://webrtc-review.googlesource.com/80150 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23465}
2018-05-31 10:44:51 +02:00
"video_codec.h",
Fix chromium warnings for SdpVideoFormat. Bug: webrtc:163 Change-Id: I29ad3c00116692f047456df7721ba636bbb2ca89 Reviewed-on: https://webrtc-review.googlesource.com/64723 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22618}
2018-03-27 08:31:45 +02:00
"video_decoder.cc",
Reland of Move video_encoder.h and video_decoder.h to /api and create GN targets for them (patchset #1 id:1 of https://codereview.webrtc.org/2794033002/ ) Reason for revert: Reland with temporary deprecated API to not break chromium and google3. Original issue's description: > Revert of Move video_encoder.h and video_decoder.h to /api and create GN targets for them (patchset #8 id:140001 of https://codereview.webrtc.org/2780943003/ ) > > Reason for revert: > Suspect of breaking Chrome FYI bots. > > See > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/23065 > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder > > Example logs: > ../../content/renderer/media/gpu/rtc_video_encoder_unittest.cc:18:46: fatal error: third_party/webrtc/video_encoder.h: No such file or directory > #include "third_party/webrtc/video_encoder.h" > ^ > > Original issue's description: > > Move video_encoder.h and video_decoder.h to /api and create GN targets for them > > > > BUG=webrtc:5881 > > # Because PRESUBMIT ignores LINT blacklist for moved files and these > > # headers have some not easy to resolve issues. > > NOPRESUBMIT=True > > > > Review-Url: https://codereview.webrtc.org/2780943003 > > Cr-Commit-Position: refs/heads/master@{#17511} > > Committed: https://chromium.googlesource.com/external/webrtc/+/c42f54057050c933008a49d57582577bfb9aed25 > > TBR=solenberg@webrtc.org,sprang@webrtc.org,ilnik@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:5881 > > Review-Url: https://codereview.webrtc.org/2794033002 > Cr-Commit-Position: refs/heads/master@{#17514} > Committed: https://chromium.googlesource.com/external/webrtc/+/716d7ac5c1ed6e392e264b34065800bbf03772b3 TBR=solenberg@webrtc.org,sprang@webrtc.org,guidou@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5881 Review-Url: https://codereview.webrtc.org/2795163002 Cr-Commit-Position: refs/heads/master@{#17537}
2017-04-05 03:02:20 -07:00
"video_decoder.h",
Add VideoDecoderFactory function to pass Environment for VideoDecoder construction Bug: webrtc:15791 Change-Id: I3fa962ae13d8b36092a5b910f1ce6e946689daea Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/335680 Reviewed-by: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41600}
2024-01-22 13:17:05 +01:00
"video_decoder_factory.cc",
Add new video codec factories This CL adds interfaces for the new video codec factories and wires them up in WebRtcVideoEngine. The default behavior is unmodified however, and the new code is currently unused except for the tests. A follow-up CL will be uploaded for exposing them in the PeerConnectionFactory API: https://codereview.webrtc.org/3004353002/. BUG=webrtc:7925 R=andersc@webrtc.org, stefan@webrtc.org Review-Url: https://codereview.webrtc.org/3007073002 . Cr-Commit-Position: refs/heads/master@{#19828}
2017-09-14 10:24:54 +02:00
"video_decoder_factory.h",
Removing VCMCodecDataBase::Codec and VideoCodingModule::Codec. This CL brings us one step closer to removing CodecDatabase and GenericEncoder, by removing the static VCM::Codec(). Codec specific methods are moved to video_encoder.cc (they already belonged to this class) and getting default generic codec settings has been moved to a test specific file. This CL also makes video_encoder.h pass style guide and lint checks, since these checks are triggered with the new video_encoder.cc file. BUG=webrtc:8064 Review-Url: https://codereview.webrtc.org/2993923002 Cr-Commit-Position: refs/heads/master@{#19303}
2017-08-10 02:43:14 -07:00
"video_encoder.cc",
Reland of Move video_encoder.h and video_decoder.h to /api and create GN targets for them (patchset #1 id:1 of https://codereview.webrtc.org/2794033002/ ) Reason for revert: Reland with temporary deprecated API to not break chromium and google3. Original issue's description: > Revert of Move video_encoder.h and video_decoder.h to /api and create GN targets for them (patchset #8 id:140001 of https://codereview.webrtc.org/2780943003/ ) > > Reason for revert: > Suspect of breaking Chrome FYI bots. > > See > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/23065 > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder > > Example logs: > ../../content/renderer/media/gpu/rtc_video_encoder_unittest.cc:18:46: fatal error: third_party/webrtc/video_encoder.h: No such file or directory > #include "third_party/webrtc/video_encoder.h" > ^ > > Original issue's description: > > Move video_encoder.h and video_decoder.h to /api and create GN targets for them > > > > BUG=webrtc:5881 > > # Because PRESUBMIT ignores LINT blacklist for moved files and these > > # headers have some not easy to resolve issues. > > NOPRESUBMIT=True > > > > Review-Url: https://codereview.webrtc.org/2780943003 > > Cr-Commit-Position: refs/heads/master@{#17511} > > Committed: https://chromium.googlesource.com/external/webrtc/+/c42f54057050c933008a49d57582577bfb9aed25 > > TBR=solenberg@webrtc.org,sprang@webrtc.org,ilnik@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:5881 > > Review-Url: https://codereview.webrtc.org/2794033002 > Cr-Commit-Position: refs/heads/master@{#17514} > Committed: https://chromium.googlesource.com/external/webrtc/+/716d7ac5c1ed6e392e264b34065800bbf03772b3 TBR=solenberg@webrtc.org,sprang@webrtc.org,guidou@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5881 Review-Url: https://codereview.webrtc.org/2795163002 Cr-Commit-Position: refs/heads/master@{#17537}
2017-04-05 03:02:20 -07:00
"video_encoder.h",
Add new video codec factories This CL adds interfaces for the new video codec factories and wires them up in WebRtcVideoEngine. The default behavior is unmodified however, and the new code is currently unused except for the tests. A follow-up CL will be uploaded for exposing them in the PeerConnectionFactory API: https://codereview.webrtc.org/3004353002/. BUG=webrtc:7925 R=andersc@webrtc.org, stefan@webrtc.org Review-Url: https://codereview.webrtc.org/3007073002 . Cr-Commit-Position: refs/heads/master@{#19828}
2017-09-14 10:24:54 +02:00
"video_encoder_factory.h",
Create Vp8FrameBufferController Vp8FrameBufferController is currently just a renamed Vp8TemporalLayers, but subsequent CLs will modify Vp8FrameBufferController in ways that are not relevant for Vp8TemporalLayers. Namely: 1. Loss notifications will be added. 2. Packet-loss rate will be tracked. 3. RTT will be tracked. 4. Vp8FrameBufferController will be made injectable. Vp8TemporalLayers is retained in order to: 1. Avoid needlessly changing api/. 2. Place for code shared between DefaultTemporalLayers and ScreenshareLayers. We can remove it in the future (with a proper public announcement). Bug: webrtc:10382 Change-Id: I49ad1b9bc1954d51bb0b5e60361985f1eb12ae9f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126045 Reviewed-by: Erik Språng <sprang@webrtc.org> Commit-Queue: Elad Alon <eladalon@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27009}
2019-03-06 21:14:54 +01:00
"vp8_frame_buffer_controller.h",
Break FrameConfig out of Vp8TemporalLayers FrameConfig is not specific to temporal layers. Anything that can control referenced/updated buffers could potentially use it. Bug: webrtc:10259 Change-Id: I04ed177ee884693798c3b69e35fd4255ce1e9062 Reviewed-on: https://webrtc-review.googlesource.com/c/120355 Reviewed-by: Erik Språng <sprang@webrtc.org> Commit-Queue: Elad Alon <eladalon@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26448}
2019-01-29 14:05:55 +01:00
"vp8_frame_config.cc",
"vp8_frame_config.h",
Use single FrameBufferController in VP8, created by a factory. This CL paves the way to making FrameBufferController injectable. LibvpxVp8Encoder can manage multiple streams. Prior to this CL, each stream had its own frame buffer controller, all of them held in a vector by LibvpxVp8Encoder. This complicated the code and produced some code duplication (cf. SetupTemporalLayers). This CL: 1. Replaces CreateVp8TemporalLayers() by a factory. (Later CLs will make this factory injectable.) 2. Makes LibvpxVp8Encoder use a single controller. This single controller will, in the case of multiple streams, delegate its work to multiple controllers, but that fact is not visible to LibvpxVp8Encoder. This CL also squashes CL #126046 (Send notifications of RTT and PLR changes to Vp8FrameBufferController) into it. Bug: webrtc:10382 Change-Id: Id9b55734bebb457acc276f34a7a9e52cc19c8eb9 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126483 Commit-Queue: Elad Alon <eladalon@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27206}
2019-03-20 11:56:20 +01:00
"vp8_temporal_layers.cc",
Move TemporalLayers to api/video_codecs. Also renaming it Vp8TemporalLayers to show that it is codec specific. Bug: webrtc:9012 Change-Id: I18187538b8142cdd7538f1a4ed1bada09d040f1f Reviewed-on: https://webrtc-review.googlesource.com/c/104643 Commit-Queue: Erik Språng <sprang@webrtc.org> Reviewed-by: Per Kjellander <perkj@webrtc.org> Reviewed-by: Sebastian Jansson <srte@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25137}
2018-10-12 10:30:31 +02:00
"vp8_temporal_layers.h",
Move h264_profile_level_id and vp9_profile to api/video_codecs This is a refactor to simplify a follow-up CL of adding SdpVideoFormat::IsSameCodec. The original files media/base/h264_profile_level_id.* and media/base/vp9_profile.h must be kept until downstream projects stop using them. Bug: chroimium:1187565 Change-Id: Ib39eca095a3d61939a914d9bffaf4b891ddd222f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/215236 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Johannes Kron <kron@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33782}
2021-04-19 09:09:26 +02:00
"vp9_profile.cc",
"vp9_profile.h",
Reland of Move video_encoder.h and video_decoder.h to /api and create GN targets for them (patchset #1 id:1 of https://codereview.webrtc.org/2794033002/ ) Reason for revert: Reland with temporary deprecated API to not break chromium and google3. Original issue's description: > Revert of Move video_encoder.h and video_decoder.h to /api and create GN targets for them (patchset #8 id:140001 of https://codereview.webrtc.org/2780943003/ ) > > Reason for revert: > Suspect of breaking Chrome FYI bots. > > See > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/23065 > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder > > Example logs: > ../../content/renderer/media/gpu/rtc_video_encoder_unittest.cc:18:46: fatal error: third_party/webrtc/video_encoder.h: No such file or directory > #include "third_party/webrtc/video_encoder.h" > ^ > > Original issue's description: > > Move video_encoder.h and video_decoder.h to /api and create GN targets for them > > > > BUG=webrtc:5881 > > # Because PRESUBMIT ignores LINT blacklist for moved files and these > > # headers have some not easy to resolve issues. > > NOPRESUBMIT=True > > > > Review-Url: https://codereview.webrtc.org/2780943003 > > Cr-Commit-Position: refs/heads/master@{#17511} > > Committed: https://chromium.googlesource.com/external/webrtc/+/c42f54057050c933008a49d57582577bfb9aed25 > > TBR=solenberg@webrtc.org,sprang@webrtc.org,ilnik@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:5881 > > Review-Url: https://codereview.webrtc.org/2794033002 > Cr-Commit-Position: refs/heads/master@{#17514} > Committed: https://chromium.googlesource.com/external/webrtc/+/716d7ac5c1ed6e392e264b34065800bbf03772b3 TBR=solenberg@webrtc.org,sprang@webrtc.org,guidou@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5881 Review-Url: https://codereview.webrtc.org/2795163002 Cr-Commit-Position: refs/heads/master@{#17537}
2017-04-05 03:02:20 -07:00
]
Add H265 codec name and profile/tier/level utils. This adds H265 codec name and profile/tier/level handling needed for H265 SDP negotiation. Bug: webrtc:13485 Change-Id: I838b910042ce36f8ae3979c41a73ee46935c57d8 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/315900 Reviewed-by: Erik Språng <sprang@webrtc.org> Reviewed-by: Sergey Silkin <ssilkin@webrtc.org> Commit-Queue: Jianlin Qiu <jianlin.qiu@intel.com> Cr-Commit-Position: refs/heads/main@{#40661}
2023-08-30 12:26:24 +08:00
if (rtc_use_h265) {
sources += [
"h265_profile_tier_level.cc",
"h265_profile_tier_level.h",
]
}
Reland of Move video_encoder.h and video_decoder.h to /api and create GN targets for them (patchset #1 id:1 of https://codereview.webrtc.org/2794033002/ ) Reason for revert: Reland with temporary deprecated API to not break chromium and google3. Original issue's description: > Revert of Move video_encoder.h and video_decoder.h to /api and create GN targets for them (patchset #8 id:140001 of https://codereview.webrtc.org/2780943003/ ) > > Reason for revert: > Suspect of breaking Chrome FYI bots. > > See > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/23065 > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder > > Example logs: > ../../content/renderer/media/gpu/rtc_video_encoder_unittest.cc:18:46: fatal error: third_party/webrtc/video_encoder.h: No such file or directory > #include "third_party/webrtc/video_encoder.h" > ^ > > Original issue's description: > > Move video_encoder.h and video_decoder.h to /api and create GN targets for them > > > > BUG=webrtc:5881 > > # Because PRESUBMIT ignores LINT blacklist for moved files and these > > # headers have some not easy to resolve issues. > > NOPRESUBMIT=True > > > > Review-Url: https://codereview.webrtc.org/2780943003 > > Cr-Commit-Position: refs/heads/master@{#17511} > > Committed: https://chromium.googlesource.com/external/webrtc/+/c42f54057050c933008a49d57582577bfb9aed25 > > TBR=solenberg@webrtc.org,sprang@webrtc.org,ilnik@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:5881 > > Review-Url: https://codereview.webrtc.org/2794033002 > Cr-Commit-Position: refs/heads/master@{#17514} > Committed: https://chromium.googlesource.com/external/webrtc/+/716d7ac5c1ed6e392e264b34065800bbf03772b3 TBR=solenberg@webrtc.org,sprang@webrtc.org,guidou@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5881 Review-Url: https://codereview.webrtc.org/2795163002 Cr-Commit-Position: refs/heads/master@{#17537}
2017-04-05 03:02:20 -07:00
deps = [
New enum ScalabilityMode. Used instead of string representation in lower-levels of encoder configuration, to avoid string comparisons (with risk of misspelling) in lots of places. Bug: webrtc:11607 Change-Id: I4d51c2265aac297c29976d2aa601d8ffb33b7326 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259870 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Florent Castelli <orphis@webrtc.org> Reviewed-by: Åsa Persson <asapersson@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36706}
2022-04-29 11:03:13 +02:00
":scalability_mode",
Define FecControllerOverride and plumb it down to VideoEncoder The purpose of this interface is to allow VideoEncoder to override the bandwidth allocation set by FecController in RtpVideoSender. This CL defines the interface and sends it down to VideoSender. Two upcoming CLs will: 1. Make LibvpxVp8Encoder pass it on to the (injectable) FrameBufferController, where it might be put to good use. 2. Modify RtpVideoSender to respond to the message sent to it via this API. TBR=kwiberg@webrtc.org Bug: webrtc:10769 Change-Id: I2ef82f0ddcde7fd078e32d8aabf6efe43e0f7f8a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/143962 Commit-Queue: Elad Alon <eladalon@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28416}
2019-06-28 15:19:43 +02:00
"..:fec_controller_api",
Remove rtc_base/scoped_ref_ptr.h. The type rtc::scoped_refptr<T> is now part of api/. Please include it from api/scoped_refptr.h. More info: See: https://groups.google.com/forum/#!topic/discuss-webrtc/Mme2MSz4z4o. Bug: webrtc:9887, webrtc:8205 No-Try: True Change-Id: Ic6c7c81e226e59f12f7933e472f573ae097b55bf Reviewed-on: https://webrtc-review.googlesource.com/c/119041 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26414}
2019-01-25 20:26:48 +01:00
"..:scoped_refptr",
Add codec comparison function to SdpVideoFormat SdpVideoFormat is used to configure video encoder and decoders. This CL adds support for comparing two SdpVideoFormat objects to determine if they specify the same video codec. This functionality previously only existed in media/base/codec.h which made the code sensitive to circular dependencies. Once downstream projects stop using cricket::IsSameCodec, this code can be removed. Bug: chromium:1187565 Change-Id: I242069aa6af07917637384c80ee4820887defc7d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/213427 Commit-Queue: Johannes Kron <kron@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33794}
2021-04-20 15:53:52 +02:00
"../../api:array_view",
Reland "Unify access to SDP codec parameters" This is a reland of commit 63d03f586bb668f72113b61030ec0930aa192010 Original change's description: > Unify access to SDP codec parameters > > which come from the a=fmtp:<pt> lines in the SDP and were used as either > std::map<std::string, std:string> > with three aliases, > cricket::CodecParameterMap > SdpAudioFormat::Parameters > SdpVideoFormat::Parameters > > Use webrtc::CodecParameterMap in all places. > > BUG=None > > Change-Id: If47692bde7347834c349c6539b43309d8770e67b > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/330420 > Reviewed-by: Florent Castelli <orphis@webrtc.org> > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > Commit-Queue: Philipp Hancke <phancke@microsoft.com> > Cr-Commit-Position: refs/heads/main@{#41375} Bug: None Change-Id: I5f8f45688df232eb37b12fa3e56a893a1c754e17 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/331402 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Florent Castelli <orphis@webrtc.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Cr-Commit-Position: refs/heads/main@{#41467}
2023-12-14 09:45:39 +01:00
"../../api:rtp_parameters",
sdp: backfill default codec parameters for AV1 as required by https://aomediacodec.github.io/av1-rtp-spec/#72-sdp-parameters Also unify usage of profile fmtp parameter. Most notably this causes SDP answers to include the default values. These default values correspond to libaom's default values for AV1E_SET_TARGET_SEQ_LEVEL_IDX, AV1E_SET_TIER_MASK as used in https://source.chromium.org/chromium/chromium/src/+/main:third_party/libaom/source/libaom/aom/aomcx.h and g_profile in aom_codec_enc_cfg https://source.chromium.org/chromium/chromium/src/+/main:third_party/libaom/source/libaom/aom/aom_encoder.h;l=415;drc=b58207f5aecc39db7d3da766e7d171e5d2c3598e Note: AV1 is inconsistently cased in variable/struct/method/class names. The canonical casing should probably be "Av1" since it is an acronym standing for "AOMedia Video 1". BUG=webrtc:15703 Change-Id: I11864b7666fea906cd1a0759c7ad45997beab90e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/331360 Reviewed-by: Sergey Silkin <ssilkin@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Cr-Commit-Position: refs/heads/main@{#41654}
2024-01-03 16:47:05 +01:00
"../../media:media_constants",
Break FrameConfig out of Vp8TemporalLayers FrameConfig is not specific to temporal layers. Anything that can control referenced/updated buffers could potentially use it. Bug: webrtc:10259 Change-Id: I04ed177ee884693798c3b69e35fd4255ce1e9062 Reviewed-on: https://webrtc-review.googlesource.com/c/120355 Reviewed-by: Erik Språng <sprang@webrtc.org> Commit-Queue: Elad Alon <eladalon@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26448}
2019-01-29 14:05:55 +01:00
"../../modules/video_coding:codec_globals_headers",
Fix circular dependencies between optional, array_view, and rtc_base. This splits things out of rtc_base and makes dependencies explicit. Bug: webrtc:6828 Change-Id: Id521896c3c43595349021c857bec216e429a0c8d Reviewed-on: https://webrtc-review.googlesource.com/32780 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21264}
2017-12-13 16:05:42 +01:00
"../../rtc_base:checks",
Add FuzzyMatchSdpVideoFormat convenience function for VideoEncoderFactoryTemplate. Bug: webrtc:13573 Change-Id: I6813f2a2524271be7862b700da4831575ec6e206 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/279701 Commit-Queue: Xavier Lepaul‎ <xalep@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38463}
2022-10-18 16:05:38 +02:00
"../../rtc_base:logging",
Remove //rtc_base:macromagic from public deps Bug: webrtc:8603 Change-Id: I9708df48c9bde9f86ba2d1a92a278bb0d09f3865 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257909 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Auto-Submit: Florent Castelli <orphis@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36444}
2022-04-04 15:18:46 +02:00
"../../rtc_base:macromagic",
Remove //rtc_base:refcount from public deps Bug: webrtc:8603 Change-Id: Ib27a107ae809df739492846175f0e9c4af40d21a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257910 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Auto-Submit: Florent Castelli <orphis@webrtc.org> Reviewed-by: Florent Castelli <orphis@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36447}
2022-04-05 02:54:12 +02:00
"../../rtc_base:refcount",
Remove //rtc_base:stringutils from public deps Bug: webrtc:8603 Change-Id: Ic2dfbe28d310cb4b35983b73e895fc95e8439669 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257913 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Auto-Submit: Florent Castelli <orphis@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36453}
2022-04-04 17:14:02 +02:00
"../../rtc_base:stringutils",
Export symbols needed by the Chromium component build (part 3). This CL uses RTC_EXPORT (defined in rtc_base/system/rtc_export.h) to mark WebRTC symbols as visible from a shared library, this doesn't mean these symbols are part of the public API (please continue to refer to [1] for info about what is considered public WebRTC API). Bug: webrtc:9419 Change-Id: I4d4e2ae52ee01de68147fd0f2cfe4c92d600ad94 Reviewed-on: https://webrtc-review.googlesource.com/c/106343 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25207}
2018-10-16 14:13:50 +02:00
"../../rtc_base/system:rtc_export",
Add VideoDecoderFactory function to pass Environment for VideoDecoder construction Bug: webrtc:15791 Change-Id: I3fa962ae13d8b36092a5b910f1ce6e946689daea Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/335680 Reviewed-by: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41600}
2024-01-22 13:17:05 +01:00
"../environment",
Add new more flexible VideoEncoder::SetRate() method. This CL changes the API for webrtc::VideoEncoder. There is a legacy method called SetRates(). This is indicated as being deprecated, but there seem to be a number of usages still left. Then there is the new SetRateAllocation() method which takes a VideoBitrateAllocation instance instead of a single target bitrate. This CL adds a new version of SetRates() which moves all the existing parameters in a RateControlParameters struct, and adds a bandwidth allocation signal. The intent of this signal is to allow the encoder to know how close to the target it needs to stay. If the encoder rate is network restricted, it will need to be more aggressive in keep the rate down and possibly drop frames. If there is some margin for overshoot, it might do different trade-offs. Furthermore, the frame rate signal is changes from an integer to a floating point type in order to get more precise rates at low frame rates and the return type has been changed to void since the only use of the previous values to log it and that is better done inside encoder where the error condition originates. The intent is to properly deprecate the "old" SetRates() / SetRateAllocation() methods, send out a PSA and then remove them in two weeks. Changes required by users should be trivial, as using the new headroom signal is optional. Bug: webrtc:10155, webrtc:10481 Change-Id: I4f797b0b0c73086111869ef4ee5f42bf530f5fde Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/129724 Commit-Queue: Erik Språng <sprang@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27314}
2019-03-27 15:00:43 +01:00
"../units:data_rate",
Move EncodedImage class to api/video/ Bug: webrtc:9378 Change-Id: I8fb3b19cad0ad428abc6c8e6b507180d461882ba Reviewed-on: https://webrtc-review.googlesource.com/c/104002 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Peter Slatala <psla@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25033}
2018-10-05 14:17:58 +02:00
"../video:encoded_image",
Introduce new api to initialize VideoDecoder Bug: webrtc:13045 Change-Id: If14fa3998176ee07b6f2835745568f70347ccac6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227766 Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34694}
2021-08-09 15:30:47 +02:00
"../video:render_resolution",
Reland "RtpEncodingParameters::request_resolution patch 1" This reverts commit b625101da8d798c936cfd695505a5514644158b0. Reason for revert: Found problem that was specific how configuration is handled for VP9. A 1-line change in webrtc_video_engine.cc line 3715. Thanks Rasmus and great that this was tested! Original change's description: > Revert "RtpEncodingParameters::request_resolution patch 1" > > This reverts commit ef7359e679e579ccb79afacf5c42e8c6020124e2. > > Reason for revert: Breaks downstream test > > Original change's description: > > RtpEncodingParameters::request_resolution patch 1 > > > > This patch adds RtpEncodingParameters::request_resolution > > with documentation and plumming. No behaviour is changed yet. > > > > Bug: webrtc:14451 > > Change-Id: I1f4f83a312ee8c293e3d8f02b950751e62048304 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276262 > > Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> > > Reviewed-by: Henrik Boström <hbos@webrtc.org> > > Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> > > Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> > > Commit-Queue: Jonas Oreland <jonaso@webrtc.org> > > Cr-Commit-Position: refs/heads/main@{#38172} > > Bug: webrtc:14451 > Change-Id: I4b9590e23ec38e9e1c2e51a4600ef96b129439f2 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276541 > Commit-Queue: Björn Terelius <terelius@webrtc.org> > Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> > Reviewed-by: Jonas Oreland <jonaso@webrtc.org> > Owners-Override: Björn Terelius <terelius@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#38176} Bug: webrtc:14451 Change-Id: Ica9b74180bce22d09bf289126bb5ac137bf9eb70 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276543 Reviewed-by: Henrik Boström <hbos@webrtc.org> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Commit-Queue: Jonas Oreland <jonaso@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38178}
2022-09-23 12:08:57 +02:00
"../video:resolution",
Directly include VideoBitrateAllocation in api targets Bug: webrtc:9271 Change-Id: I5389f5ba0c29ba8bc5391544152e6b06da77f91c Reviewed-on: https://webrtc-review.googlesource.com/76940 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Erik Språng <sprang@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23245}
2018-05-15 15:12:55 +02:00
"../video:video_bitrate_allocation",
Move some video codec constants to separate file. kMaxSimulcastStreams, kMaxSpatialLayers and kMaxTemporalStreams don't really beling on VideoBitrateAllocation. common_types.h is going away and it feels dubious to requrie include of the full VideoEncoder api to use them. Therefore moving them into a seprate file/target. Also includes some remaining cleanup of includes. Bug: webrtc:9271 Change-Id: I7ded3d97a9a835ac756159700774445a2b93a697 Reviewed-on: https://webrtc-review.googlesource.com/c/117305 Reviewed-by: Stefan Holmer <stefan@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Commit-Queue: Erik Språng <sprang@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26299}
2019-01-16 17:10:57 +01:00
"../video:video_codec_constants",
New file api/video/BUILD.gn Build targets involving files under api/video/ are moved into this file, from api/BUILD.gn. In addition, drop "_api" part of target names, and move the header file api/videosinkinterface.h to api/video/video_sink_interface.h. Bug: webrtc:9253 Change-Id: I2896d3f063db8dff902bc29738578395b2fcc155 Reviewed-on: https://webrtc-review.googlesource.com/75500 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23207}
2018-05-11 11:15:30 +02:00
"../video:video_frame",
Apply include-cleaner to api/video_codecs Bug: webrtc:42226242 Change-Id: I7292811f782ec9a6710c84b1fc36e42ae7ea2c17 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/359840 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Dor Hen <dorhen@meta.com> Cr-Commit-Position: refs/heads/main@{#42802}
2024-08-19 01:13:31 -07:00
"../video:video_frame_type",
Prepare for splitting the api/video:video_frames build rule. This change is part of a change to break the dependency between "api:rtp_headers" and "api/video:video_frame". It does so by first creating an empty "api/video:video_rtp_headers" build rule so that downstream projects can be fixed before moving the source files. Bug: webrtc:10668 Change-Id: I81aa6edfef3639b457a40aa93de048e62cbfd8ef Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/140291 Commit-Queue: Chen Xing <chxg@google.com> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28209}
2019-06-10 12:59:38 +02:00
"../video:video_rtp_headers",
Use Abseil container algorithms in api/ Bug: None Change-Id: I87439a234d7018757eb61e99d5c6f9c7be4ab357 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128825 Commit-Queue: Steve Anton <steveanton@webrtc.org> Reviewed-by: Amit Hilbuch <amithi@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27272}
2019-03-25 13:53:07 -07:00
"//third_party/abseil-cpp/absl/algorithm:container",
Add ability for VideoEncoder to signal frame rate allocation. This CL add new data to the VideoEncoder::EncoderInfo struct, indicating how the encoder intends to allocate frames across spatial and temporal layers. This metadata will be used in upcoming CLs to control how the encoder's rate controller performs. Bug: webrtc:10155 Change-Id: Id56fae04bae5f230d1a985171097d7ca83a3be8a Reviewed-on: https://webrtc-review.googlesource.com/c/117900 Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Commit-Queue: Erik Språng <sprang@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26300}
2019-01-17 15:27:50 +01:00
"//third_party/abseil-cpp/absl/container:inlined_vector",
Replace _stricmp with absl::EqualsIgnoreCase All uses check only for equality. Bug: webrtc:6424 Change-Id: I8755dde02370c89dbc2226bb703664c9e4f88bdb Reviewed-on: https://webrtc-review.googlesource.com/c/106383 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25274}
2018-10-19 15:29:54 +02:00
"//third_party/abseil-cpp/absl/strings",
Mass removal of absl_deps in all BUILD.gn files Bug: webrtc:341803749 Change-Id: Id73844ba8d63b9f2f2c9391d8d8116ad0864c36d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/351540 Commit-Queue: Florent Castelli <orphis@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42372}
2024-05-23 11:21:53 +00:00
"//third_party/abseil-cpp/absl/strings:string_view",
Replace rtc::Optional with absl::optional in api This is a no-op change because rtc::Optional is an alias to absl::optional This CL generated by running script with parameter 'api' Then undo changes to optional target itself and optional_unittests find $@ -type f \( -name \*.h -o -name \*.cc \) \ -exec sed -i 's|rtc::Optional|absl::optional|g' {} \+ \ -exec sed -i 's|rtc::nullopt|absl::nullopt|g' {} \+ \ -exec sed -i 's|#include "api/optional.h"|#include "absl/types/optional.h"|' {} \+ find $@ -type f -name BUILD.gn \ -exec sed -r -i 's|"[\./api]*:optional"|"//third_party/abseil-cpp/absl/types:optional"|' {} \+; git cl format Bug: webrtc:9078 Change-Id: I44093da213369d6a502e33792c694f620f53b779 Reviewed-on: https://webrtc-review.googlesource.com/84621 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23707}
2018-06-21 13:32:56 +02:00
"//third_party/abseil-cpp/absl/types:optional",
Reland of Move video_encoder.h and video_decoder.h to /api and create GN targets for them (patchset #1 id:1 of https://codereview.webrtc.org/2794033002/ ) Reason for revert: Reland with temporary deprecated API to not break chromium and google3. Original issue's description: > Revert of Move video_encoder.h and video_decoder.h to /api and create GN targets for them (patchset #8 id:140001 of https://codereview.webrtc.org/2780943003/ ) > > Reason for revert: > Suspect of breaking Chrome FYI bots. > > See > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/23065 > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder > > Example logs: > ../../content/renderer/media/gpu/rtc_video_encoder_unittest.cc:18:46: fatal error: third_party/webrtc/video_encoder.h: No such file or directory > #include "third_party/webrtc/video_encoder.h" > ^ > > Original issue's description: > > Move video_encoder.h and video_decoder.h to /api and create GN targets for them > > > > BUG=webrtc:5881 > > # Because PRESUBMIT ignores LINT blacklist for moved files and these > > # headers have some not easy to resolve issues. > > NOPRESUBMIT=True > > > > Review-Url: https://codereview.webrtc.org/2780943003 > > Cr-Commit-Position: refs/heads/master@{#17511} > > Committed: https://chromium.googlesource.com/external/webrtc/+/c42f54057050c933008a49d57582577bfb9aed25 > > TBR=solenberg@webrtc.org,sprang@webrtc.org,ilnik@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:5881 > > Review-Url: https://codereview.webrtc.org/2794033002 > Cr-Commit-Position: refs/heads/master@{#17514} > Committed: https://chromium.googlesource.com/external/webrtc/+/716d7ac5c1ed6e392e264b34065800bbf03772b3 TBR=solenberg@webrtc.org,sprang@webrtc.org,guidou@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5881 Review-Url: https://codereview.webrtc.org/2795163002 Cr-Commit-Position: refs/heads/master@{#17537}
2017-04-05 03:02:20 -07:00
]
}
Built in video codec factories. To prepare for making the software codecs optional and injectable, these codec factories provide a way to pass in identical factories as were the default old behaviour. Bug: webrtc:7925 Change-Id: I0c70fa3c56c999e9d1af6e172eff2fbba849e921 Reviewed-on: https://webrtc-review.googlesource.com/71162 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23096}
2018-05-03 11:28:29 +02:00
Add interface class for bitstream parser. Bug: webrtc:10439 Change-Id: I0decbbf4aa21a96db50f340f200ccf8adc9e8b53 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128760 Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27237}
2019-03-22 11:19:08 +01:00
rtc_source_set("bitstream_parser_api") {
visibility = [ "*" ]
Replace RTC_FALLTHROUGH with ABSL_FALLTHROUGH_INTENTED Bug: None Change-Id: I7287403f3fb13b8e30f92ca3cf1882b03bb53a6e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166176 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30283}
2020-01-16 14:41:10 +01:00
sources = [ "bitstream_parser.h" ]
Mass removal of absl_deps in all BUILD.gn files Bug: webrtc:341803749 Change-Id: Id73844ba8d63b9f2f2c9391d8d8116ad0864c36d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/351540 Commit-Queue: Florent Castelli <orphis@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42372}
2024-05-23 11:21:53 +00:00
deps = [
"..:array_view",
"//third_party/abseil-cpp/absl/types:optional",
]
Add interface class for bitstream parser. Bug: webrtc:10439 Change-Id: I0decbbf4aa21a96db50f340f200ccf8adc9e8b53 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128760 Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27237}
2019-03-22 11:19:08 +01:00
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("builtin_video_decoder_factory") {
Built in video codec factories. To prepare for making the software codecs optional and injectable, these codec factories provide a way to pass in identical factories as were the default old behaviour. Bug: webrtc:7925 Change-Id: I0c70fa3c56c999e9d1af6e172eff2fbba849e921 Reviewed-on: https://webrtc-review.googlesource.com/71162 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23096}
2018-05-03 11:28:29 +02:00
visibility = [ "*" ]
allow_poison = [
"audio_codecs", # TODO(bugs.webrtc.org/8396): Remove.
"software_video_codecs",
]
sources = [
"builtin_video_decoder_factory.cc",
"builtin_video_decoder_factory.h",
]
deps = [
":video_codecs_api",
Remove rtc_base/scoped_ref_ptr.h. The type rtc::scoped_refptr<T> is now part of api/. Please include it from api/scoped_refptr.h. More info: See: https://groups.google.com/forum/#!topic/discuss-webrtc/Mme2MSz4z4o. Bug: webrtc:9887, webrtc:8205 No-Try: True Change-Id: Ic6c7c81e226e59f12f7933e472f573ae097b55bf Reviewed-on: https://webrtc-review.googlesource.com/c/119041 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26414}
2019-01-25 20:26:48 +01:00
"../../api:scoped_refptr",
Built in video codec factories. To prepare for making the software codecs optional and injectable, these codec factories provide a way to pass in identical factories as were the default old behaviour. Bug: webrtc:7925 Change-Id: I0c70fa3c56c999e9d1af6e172eff2fbba849e921 Reviewed-on: https://webrtc-review.googlesource.com/71162 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23096}
2018-05-03 11:28:29 +02:00
"../../media:rtc_internal_video_codecs",
Export symbols needed by the Chromium component build (part 6). This CL uses RTC_EXPORT (defined in rtc_base/system/rtc_export.h) to mark WebRTC symbols as visible from a shared library, this doesn't mean these symbols are part of the public API (please continue to refer to [1] for info about what is considered public WebRTC API). [1] - https://webrtc.googlesource.com/src/+/HEAD/native-api.md Bug: webrtc:9419 Change-Id: I67a4d016a11deca5ac5459826741dd2d3f7931d5 Reviewed-on: https://webrtc-review.googlesource.com/c/107400 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25298}
2018-10-22 17:08:37 +02:00
"../../rtc_base/system:rtc_export",
Built in video codec factories. To prepare for making the software codecs optional and injectable, these codec factories provide a way to pass in identical factories as were the default old behaviour. Bug: webrtc:7925 Change-Id: I0c70fa3c56c999e9d1af6e172eff2fbba849e921 Reviewed-on: https://webrtc-review.googlesource.com/71162 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23096}
2018-05-03 11:28:29 +02:00
]
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("builtin_video_encoder_factory") {
Built in video codec factories. To prepare for making the software codecs optional and injectable, these codec factories provide a way to pass in identical factories as were the default old behaviour. Bug: webrtc:7925 Change-Id: I0c70fa3c56c999e9d1af6e172eff2fbba849e921 Reviewed-on: https://webrtc-review.googlesource.com/71162 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23096}
2018-05-03 11:28:29 +02:00
visibility = [ "*" ]
Propagate Environment through SimulcastEncoderAdapter when provided Bug: webrtc:15860 Change-Id: Iabd7752ada2f8f774de1e2adc02a4157004bf43c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/342720 Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Florent Castelli <orphis@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41893}
2024-03-12 16:58:18 +01:00
allow_poison = [ "software_video_codecs" ]
Built in video codec factories. To prepare for making the software codecs optional and injectable, these codec factories provide a way to pass in identical factories as were the default old behaviour. Bug: webrtc:7925 Change-Id: I0c70fa3c56c999e9d1af6e172eff2fbba849e921 Reviewed-on: https://webrtc-review.googlesource.com/71162 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23096}
2018-05-03 11:28:29 +02:00
sources = [
"builtin_video_encoder_factory.cc",
"builtin_video_encoder_factory.h",
]
deps = [
":video_codecs_api",
"../../media:rtc_internal_video_codecs",
Delete EncoderSimulcastProxy in favor of SimulcastEncoderAdapter. Because the adapter has a passthrough mode, it can already handle both singlecast and simulcast cases, meaning the proxy is no longer providing value. Let's delete. Bug: webrtc:15001 Change-Id: I480eaba599448e9b82b8cf7f829dc35ad6ce0434 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/297740 Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Commit-Queue: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39579}
2023-03-15 11:29:30 +01:00
"../../media:rtc_simulcast_encoder_adapter",
Export symbols needed by the Chromium component build (part 6). This CL uses RTC_EXPORT (defined in rtc_base/system/rtc_export.h) to mark WebRTC symbols as visible from a shared library, this doesn't mean these symbols are part of the public API (please continue to refer to [1] for info about what is considered public WebRTC API). [1] - https://webrtc.googlesource.com/src/+/HEAD/native-api.md Bug: webrtc:9419 Change-Id: I67a4d016a11deca5ac5459826741dd2d3f7931d5 Reviewed-on: https://webrtc-review.googlesource.com/c/107400 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25298}
2018-10-22 17:08:37 +02:00
"../../rtc_base/system:rtc_export",
Propagate Environment through SimulcastEncoderAdapter when provided Bug: webrtc:15860 Change-Id: Iabd7752ada2f8f774de1e2adc02a4157004bf43c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/342720 Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Florent Castelli <orphis@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41893}
2024-03-12 16:58:18 +01:00
"../environment",
Add API for querying codec support. Implement - BuiltinVideoEncoderFactory::QueryCodecSupport - QualityAnalyzingVideoEncoderFactory::QueryCodecSupport - FakeWebRtcVideoEncoderFactory::QueryCodecSupport Bug: webrtc:11607 Change-Id: I9a138bbdc809abf5577dd27d84a51d0ed77d62ba Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/290381 Reviewed-by: Erik Språng <sprang@webrtc.org> Commit-Queue: Åsa Persson <asapersson@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38994}
2023-01-02 19:46:13 +01:00
"//third_party/abseil-cpp/absl/types:optional",
]
Built in video codec factories. To prepare for making the software codecs optional and injectable, these codec factories provide a way to pass in identical factories as were the default old behaviour. Bug: webrtc:7925 Change-Id: I0c70fa3c56c999e9d1af6e172eff2fbba849e921 Reviewed-on: https://webrtc-review.googlesource.com/71162 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23096}
2018-05-03 11:28:29 +02:00
}
Make rtc_software_fallback_wrappers target visible. Need to depend on them from Chromium. Bug: webrtc:7925 Change-Id: Iea1bb3b937c602920bfd87f885c87c790ac7bc17 Reviewed-on: https://webrtc-review.googlesource.com/82061 Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23580}
2018-06-12 11:15:56 +02:00
New VideoEncoderFactoryTemplate. The VideoEncoderFactoryTemplate takes encoder implementations as template arguments, making it possible to easily implement a VideoEncoderFactory only using the implementations required for the particular application. This will replace the BuiltinVideoEncoderFactory. Change-Id: Ifb0e93d0d4491664fb7f7acf085190d8a90ddc0e Bug: webrtc:13573 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251904 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Commit-Queue: Philip Eliasson <philipel@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36216}
2022-03-16 12:11:42 +01:00
rtc_source_set("video_encoder_factory_template") {
visibility = [ "*" ]
allow_poison = [ "software_video_codecs" ]
public = [ "video_encoder_factory_template.h" ]
Update SupportsScalabilityMode functions to use enum ScalabilityMode. And add missing values to ScalabilityMode. Bug: webrtc:11607 Change-Id: I892ac35a3528db11b0901d26902699ecfe8f49a4 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260982 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Åsa Persson <asapersson@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36792}
2022-05-05 14:37:05 +02:00
deps = [
Apply include-cleaner to api/video_codecs Bug: webrtc:42226242 Change-Id: I7292811f782ec9a6710c84b1fc36e42ae7ea2c17 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/359840 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Dor Hen <dorhen@meta.com> Cr-Commit-Position: refs/heads/main@{#42802}
2024-08-19 01:13:31 -07:00
":scalability_mode",
Update SupportsScalabilityMode functions to use enum ScalabilityMode. And add missing values to ScalabilityMode. Bug: webrtc:11607 Change-Id: I892ac35a3528db11b0901d26902699ecfe8f49a4 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260982 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Åsa Persson <asapersson@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36792}
2022-05-05 14:37:05 +02:00
":video_codecs_api",
In VideoEncoderFactoryTemplate pass webrtc::Environment to individual traits when supported Bug: webrtc:15860 Change-Id: I022887e57855c072ddfb0edaf37cd96e9fc64ea6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/342981 Reviewed-by: Philip Eliasson <philipel@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41909}
2024-03-14 18:39:44 +01:00
"..:array_view",
Update SupportsScalabilityMode functions to use enum ScalabilityMode. And add missing values to ScalabilityMode. Bug: webrtc:11607 Change-Id: I892ac35a3528db11b0901d26902699ecfe8f49a4 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260982 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Åsa Persson <asapersson@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36792}
2022-05-05 14:37:05 +02:00
"../../modules/video_coding/svc:scalability_mode_util",
In VideoEncoderFactoryTemplate pass webrtc::Environment to individual traits when supported Bug: webrtc:15860 Change-Id: I022887e57855c072ddfb0edaf37cd96e9fc64ea6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/342981 Reviewed-by: Philip Eliasson <philipel@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41909}
2024-03-14 18:39:44 +01:00
"../environment",
Mass removal of absl_deps in all BUILD.gn files Bug: webrtc:341803749 Change-Id: Id73844ba8d63b9f2f2c9391d8d8116ad0864c36d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/351540 Commit-Queue: Florent Castelli <orphis@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42372}
2024-05-23 11:21:53 +00:00
"//third_party/abseil-cpp/absl/algorithm:container",
Apply include-cleaner to api/video_codecs Bug: webrtc:42226242 Change-Id: I7292811f782ec9a6710c84b1fc36e42ae7ea2c17 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/359840 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Dor Hen <dorhen@meta.com> Cr-Commit-Position: refs/heads/main@{#42802}
2024-08-19 01:13:31 -07:00
"//third_party/abseil-cpp/absl/types:optional",
Update SupportsScalabilityMode functions to use enum ScalabilityMode. And add missing values to ScalabilityMode. Bug: webrtc:11607 Change-Id: I892ac35a3528db11b0901d26902699ecfe8f49a4 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260982 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Åsa Persson <asapersson@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36792}
2022-05-05 14:37:05 +02:00
]
New VideoEncoderFactoryTemplate. The VideoEncoderFactoryTemplate takes encoder implementations as template arguments, making it possible to easily implement a VideoEncoderFactory only using the implementations required for the particular application. This will replace the BuiltinVideoEncoderFactory. Change-Id: Ifb0e93d0d4491664fb7f7acf085190d8a90ddc0e Bug: webrtc:13573 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251904 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Commit-Queue: Philip Eliasson <philipel@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36216}
2022-03-16 12:11:42 +01:00
}
rtc_source_set("video_encoder_factory_template_libvpx_vp8_adapter") {
visibility = [ "*" ]
allow_poison = [ "software_video_codecs" ]
public = [ "video_encoder_factory_template_libvpx_vp8_adapter.h" ]
Move VP8 SupportsScalabilityMode utility to its own build target Intended to let Vp8TemporalLayersFactory (an api/ target) reuse this function, without depending on the codec implementation, and without introducing a dependency cycle with the webrtc_vp8 build target. Bug: webrtc:11607 Change-Id: I671422e994e1005da8c7d768e8dd8ff795553e51 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261308 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Åsa Persson <asapersson@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36816}
2022-05-09 14:35:09 +02:00
deps = [
Apply include-cleaner to api/video_codecs Bug: webrtc:42226242 Change-Id: I7292811f782ec9a6710c84b1fc36e42ae7ea2c17 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/359840 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Dor Hen <dorhen@meta.com> Cr-Commit-Position: refs/heads/main@{#42802}
2024-08-19 01:13:31 -07:00
":scalability_mode",
Make header files self contained. This CL adds #includes to header files in order to make them self contained after the preprocessor pass. Bug: b/251890128 Change-Id: I81c3ba38fb8ab8a2bbd151ba99aa871fae9f1b1b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/278422 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38327}
2022-10-07 21:47:49 +00:00
":video_codecs_api",
Move VP8 SupportsScalabilityMode utility to its own build target Intended to let Vp8TemporalLayersFactory (an api/ target) reuse this function, without depending on the codec implementation, and without introducing a dependency cycle with the webrtc_vp8 build target. Bug: webrtc:11607 Change-Id: I671422e994e1005da8c7d768e8dd8ff795553e51 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261308 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Åsa Persson <asapersson@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36816}
2022-05-09 14:35:09 +02:00
"../../modules/video_coding:webrtc_vp8",
"../../modules/video_coding:webrtc_vp8_scalability",
In VideoEncoderFactoryTemplate pass webrtc::Environment to individual traits Bug: webrtc:15860 Change-Id: I8727491e60247433db4753678c69d16b8a1d5a72 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/343781 Reviewed-by: Philip Eliasson <philipel@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41990}
2024-03-22 15:58:15 +01:00
"../environment",
Mass removal of absl_deps in all BUILD.gn files Bug: webrtc:341803749 Change-Id: Id73844ba8d63b9f2f2c9391d8d8116ad0864c36d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/351540 Commit-Queue: Florent Castelli <orphis@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42372}
2024-05-23 11:21:53 +00:00
"//third_party/abseil-cpp/absl/container:inlined_vector",
Move VP8 SupportsScalabilityMode utility to its own build target Intended to let Vp8TemporalLayersFactory (an api/ target) reuse this function, without depending on the codec implementation, and without introducing a dependency cycle with the webrtc_vp8 build target. Bug: webrtc:11607 Change-Id: I671422e994e1005da8c7d768e8dd8ff795553e51 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261308 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Åsa Persson <asapersson@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36816}
2022-05-09 14:35:09 +02:00
]
New VideoEncoderFactoryTemplate. The VideoEncoderFactoryTemplate takes encoder implementations as template arguments, making it possible to easily implement a VideoEncoderFactory only using the implementations required for the particular application. This will replace the BuiltinVideoEncoderFactory. Change-Id: Ifb0e93d0d4491664fb7f7acf085190d8a90ddc0e Bug: webrtc:13573 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251904 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Commit-Queue: Philip Eliasson <philipel@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36216}
2022-03-16 12:11:42 +01:00
}
rtc_source_set("video_encoder_factory_template_libvpx_vp9_adapter") {
visibility = [ "*" ]
allow_poison = [ "software_video_codecs" ]
public = [ "video_encoder_factory_template_libvpx_vp9_adapter.h" ]
In VideoEncoderFactoryTemplate pass webrtc::Environment to individual traits Bug: webrtc:15860 Change-Id: I8727491e60247433db4753678c69d16b8a1d5a72 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/343781 Reviewed-by: Philip Eliasson <philipel@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41990}
2024-03-22 15:58:15 +01:00
deps = [
Apply include-cleaner to api/video_codecs Bug: webrtc:42226242 Change-Id: I7292811f782ec9a6710c84b1fc36e42ae7ea2c17 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/359840 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Dor Hen <dorhen@meta.com> Cr-Commit-Position: refs/heads/main@{#42802}
2024-08-19 01:13:31 -07:00
":scalability_mode",
In VideoEncoderFactoryTemplate pass webrtc::Environment to individual traits Bug: webrtc:15860 Change-Id: I8727491e60247433db4753678c69d16b8a1d5a72 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/343781 Reviewed-by: Philip Eliasson <philipel@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41990}
2024-03-22 15:58:15 +01:00
":video_codecs_api",
"../../modules/video_coding:webrtc_vp9",
"../environment",
]
New VideoEncoderFactoryTemplate. The VideoEncoderFactoryTemplate takes encoder implementations as template arguments, making it possible to easily implement a VideoEncoderFactory only using the implementations required for the particular application. This will replace the BuiltinVideoEncoderFactory. Change-Id: Ifb0e93d0d4491664fb7f7acf085190d8a90ddc0e Bug: webrtc:13573 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251904 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Commit-Queue: Philip Eliasson <philipel@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36216}
2022-03-16 12:11:42 +01:00
}
rtc_source_set("video_encoder_factory_template_open_h264_adapter") {
visibility = [ "*" ]
allow_poison = [ "software_video_codecs" ]
public = [ "video_encoder_factory_template_open_h264_adapter.h" ]
In VideoEncoderFactoryTemplate pass webrtc::Environment to individual traits Bug: webrtc:15860 Change-Id: I8727491e60247433db4753678c69d16b8a1d5a72 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/343781 Reviewed-by: Philip Eliasson <philipel@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41990}
2024-03-22 15:58:15 +01:00
deps = [
Apply include-cleaner to api/video_codecs Bug: webrtc:42226242 Change-Id: I7292811f782ec9a6710c84b1fc36e42ae7ea2c17 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/359840 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Dor Hen <dorhen@meta.com> Cr-Commit-Position: refs/heads/main@{#42802}
2024-08-19 01:13:31 -07:00
":scalability_mode",
":video_codecs_api",
In VideoEncoderFactoryTemplate pass webrtc::Environment to individual traits Bug: webrtc:15860 Change-Id: I8727491e60247433db4753678c69d16b8a1d5a72 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/343781 Reviewed-by: Philip Eliasson <philipel@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41990}
2024-03-22 15:58:15 +01:00
"../../modules/video_coding:webrtc_h264",
"../environment",
]
New VideoEncoderFactoryTemplate. The VideoEncoderFactoryTemplate takes encoder implementations as template arguments, making it possible to easily implement a VideoEncoderFactory only using the implementations required for the particular application. This will replace the BuiltinVideoEncoderFactory. Change-Id: Ifb0e93d0d4491664fb7f7acf085190d8a90ddc0e Bug: webrtc:13573 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251904 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Commit-Queue: Philip Eliasson <philipel@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36216}
2022-03-16 12:11:42 +01:00
}
rtc_source_set("video_encoder_factory_template_libaom_av1_adapter") {
visibility = [ "*" ]
allow_poison = [ "software_video_codecs" ]
public = [ "video_encoder_factory_template_libaom_av1_adapter.h" ]
deps = [
New enum ScalabilityMode. Used instead of string representation in lower-levels of encoder configuration, to avoid string comparisons (with risk of misspelling) in lots of places. Bug: webrtc:11607 Change-Id: I4d51c2265aac297c29976d2aa601d8ffb33b7326 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259870 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Florent Castelli <orphis@webrtc.org> Reviewed-by: Åsa Persson <asapersson@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36706}
2022-04-29 11:03:13 +02:00
":scalability_mode",
Make header files self contained. This CL adds #includes to header files in order to make them self contained after the preprocessor pass. Bug: b/251890128 Change-Id: I81c3ba38fb8ab8a2bbd151ba99aa871fae9f1b1b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/278422 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38327}
2022-10-07 21:47:49 +00:00
":video_codecs_api",
Update SupportsScalabilityMode functions to use enum ScalabilityMode. And add missing values to ScalabilityMode. Bug: webrtc:11607 Change-Id: I892ac35a3528db11b0901d26902699ecfe8f49a4 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260982 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Åsa Persson <asapersson@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36792}
2022-05-05 14:37:05 +02:00
"../../modules/video_coding/codecs/av1:av1_svc_config",
New VideoEncoderFactoryTemplate. The VideoEncoderFactoryTemplate takes encoder implementations as template arguments, making it possible to easily implement a VideoEncoderFactory only using the implementations required for the particular application. This will replace the BuiltinVideoEncoderFactory. Change-Id: Ifb0e93d0d4491664fb7f7acf085190d8a90ddc0e Bug: webrtc:13573 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251904 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Commit-Queue: Philip Eliasson <philipel@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36216}
2022-03-16 12:11:42 +01:00
"../../modules/video_coding/codecs/av1:libaom_av1_encoder",
New enum ScalabilityMode. Used instead of string representation in lower-levels of encoder configuration, to avoid string comparisons (with risk of misspelling) in lots of places. Bug: webrtc:11607 Change-Id: I4d51c2265aac297c29976d2aa601d8ffb33b7326 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259870 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Florent Castelli <orphis@webrtc.org> Reviewed-by: Åsa Persson <asapersson@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36706}
2022-04-29 11:03:13 +02:00
"../../modules/video_coding/svc:scalability_mode_util",
In VideoEncoderFactoryTemplate pass webrtc::Environment to individual traits Bug: webrtc:15860 Change-Id: I8727491e60247433db4753678c69d16b8a1d5a72 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/343781 Reviewed-by: Philip Eliasson <philipel@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41990}
2024-03-22 15:58:15 +01:00
"../environment",
Mass removal of absl_deps in all BUILD.gn files Bug: webrtc:341803749 Change-Id: Id73844ba8d63b9f2f2c9391d8d8116ad0864c36d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/351540 Commit-Queue: Florent Castelli <orphis@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42372}
2024-05-23 11:21:53 +00:00
"//third_party/abseil-cpp/absl/container:inlined_vector",
New VideoEncoderFactoryTemplate. The VideoEncoderFactoryTemplate takes encoder implementations as template arguments, making it possible to easily implement a VideoEncoderFactory only using the implementations required for the particular application. This will replace the BuiltinVideoEncoderFactory. Change-Id: Ifb0e93d0d4491664fb7f7acf085190d8a90ddc0e Bug: webrtc:13573 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251904 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Commit-Queue: Philip Eliasson <philipel@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36216}
2022-03-16 12:11:42 +01:00
]
}
New VideoDecoderFactoryTemplate. The VideoDecoderFactoryTemplate takes decoder implementations as template arguments, making it possible to easily implement a VideoDecoderFactory only using the implementations required for the particular application. This will replace the BuiltinVideoDecoderFactory. Bug: webrtc:13573 Change-Id: I0213acd20b69dacf06fc6934851b73bd19b1afc8 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268470 Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Commit-Queue: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37523}
2022-07-14 16:06:51 +02:00
rtc_source_set("video_decoder_factory_template") {
visibility = [ "*" ]
allow_poison = [ "software_video_codecs" ]
public = [ "video_decoder_factory_template.h" ]
deps = [
":video_codecs_api",
Pass webrtc::Environment through VideoDecoderFactoryTemplate::Create Bug: webrtc:15791 Change-Id: Ia648995b7edd53a59f64afde0d74994b68524d39 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/340142 Reviewed-by: Philip Eliasson <philipel@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41783}
2024-02-21 13:16:19 +01:00
"..:array_view",
"../environment",
Mass removal of absl_deps in all BUILD.gn files Bug: webrtc:341803749 Change-Id: Id73844ba8d63b9f2f2c9391d8d8116ad0864c36d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/351540 Commit-Queue: Florent Castelli <orphis@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42372}
2024-05-23 11:21:53 +00:00
"//third_party/abseil-cpp/absl/algorithm:container",
New VideoDecoderFactoryTemplate. The VideoDecoderFactoryTemplate takes decoder implementations as template arguments, making it possible to easily implement a VideoDecoderFactory only using the implementations required for the particular application. This will replace the BuiltinVideoDecoderFactory. Bug: webrtc:13573 Change-Id: I0213acd20b69dacf06fc6934851b73bd19b1afc8 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268470 Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Commit-Queue: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37523}
2022-07-14 16:06:51 +02:00
]
}
rtc_source_set("video_decoder_factory_template_libvpx_vp8_adapter") {
visibility = [ "*" ]
allow_poison = [ "software_video_codecs" ]
public = [ "video_decoder_factory_template_libvpx_vp8_adapter.h" ]
Make header files self contained. This CL adds #includes to header files in order to make them self contained after the preprocessor pass. Bug: b/251890128 Change-Id: I81c3ba38fb8ab8a2bbd151ba99aa871fae9f1b1b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/278422 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38327}
2022-10-07 21:47:49 +00:00
deps = [
":video_codecs_api",
"../../modules/video_coding:webrtc_vp8",
Pass webrtc::Environment through VideoDecoderFactoryTemplate::Create Bug: webrtc:15791 Change-Id: Ia648995b7edd53a59f64afde0d74994b68524d39 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/340142 Reviewed-by: Philip Eliasson <philipel@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41783}
2024-02-21 13:16:19 +01:00
"../environment",
Make header files self contained. This CL adds #includes to header files in order to make them self contained after the preprocessor pass. Bug: b/251890128 Change-Id: I81c3ba38fb8ab8a2bbd151ba99aa871fae9f1b1b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/278422 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38327}
2022-10-07 21:47:49 +00:00
]
New VideoDecoderFactoryTemplate. The VideoDecoderFactoryTemplate takes decoder implementations as template arguments, making it possible to easily implement a VideoDecoderFactory only using the implementations required for the particular application. This will replace the BuiltinVideoDecoderFactory. Bug: webrtc:13573 Change-Id: I0213acd20b69dacf06fc6934851b73bd19b1afc8 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268470 Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Commit-Queue: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37523}
2022-07-14 16:06:51 +02:00
}
rtc_source_set("video_decoder_factory_template_libvpx_vp9_adapter") {
visibility = [ "*" ]
allow_poison = [ "software_video_codecs" ]
public = [ "video_decoder_factory_template_libvpx_vp9_adapter.h" ]
Apply include-cleaner to api/video_codecs Bug: webrtc:42226242 Change-Id: I7292811f782ec9a6710c84b1fc36e42ae7ea2c17 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/359840 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Dor Hen <dorhen@meta.com> Cr-Commit-Position: refs/heads/main@{#42802}
2024-08-19 01:13:31 -07:00
deps = [
":video_codecs_api",
"../../modules/video_coding:webrtc_vp9",
]
New VideoDecoderFactoryTemplate. The VideoDecoderFactoryTemplate takes decoder implementations as template arguments, making it possible to easily implement a VideoDecoderFactory only using the implementations required for the particular application. This will replace the BuiltinVideoDecoderFactory. Bug: webrtc:13573 Change-Id: I0213acd20b69dacf06fc6934851b73bd19b1afc8 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268470 Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Commit-Queue: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37523}
2022-07-14 16:06:51 +02:00
}
rtc_source_set("video_decoder_factory_template_open_h264_adapter") {
visibility = [ "*" ]
allow_poison = [ "software_video_codecs" ]
public = [ "video_decoder_factory_template_open_h264_adapter.h" ]
Apply include-cleaner to api/video_codecs Bug: webrtc:42226242 Change-Id: I7292811f782ec9a6710c84b1fc36e42ae7ea2c17 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/359840 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Dor Hen <dorhen@meta.com> Cr-Commit-Position: refs/heads/main@{#42802}
2024-08-19 01:13:31 -07:00
deps = [
":video_codecs_api",
"../../modules/video_coding:webrtc_h264",
]
New VideoDecoderFactoryTemplate. The VideoDecoderFactoryTemplate takes decoder implementations as template arguments, making it possible to easily implement a VideoDecoderFactory only using the implementations required for the particular application. This will replace the BuiltinVideoDecoderFactory. Bug: webrtc:13573 Change-Id: I0213acd20b69dacf06fc6934851b73bd19b1afc8 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268470 Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Commit-Queue: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37523}
2022-07-14 16:06:51 +02:00
}
rtc_source_set("video_decoder_factory_template_dav1d_adapter") {
visibility = [ "*" ]
allow_poison = [ "software_video_codecs" ]
public = [ "video_decoder_factory_template_dav1d_adapter.h" ]
Make header files self contained. This CL adds #includes to header files in order to make them self contained after the preprocessor pass. Bug: b/251890128 Change-Id: I81c3ba38fb8ab8a2bbd151ba99aa871fae9f1b1b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/278422 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38327}
2022-10-07 21:47:49 +00:00
deps = [
":video_codecs_api",
"../../modules/video_coding/codecs/av1:dav1d_decoder",
]
New VideoDecoderFactoryTemplate. The VideoDecoderFactoryTemplate takes decoder implementations as template arguments, making it possible to easily implement a VideoDecoderFactory only using the implementations required for the particular application. This will replace the BuiltinVideoDecoderFactory. Bug: webrtc:13573 Change-Id: I0213acd20b69dacf06fc6934851b73bd19b1afc8 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268470 Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Commit-Queue: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37523}
2022-07-14 16:06:51 +02:00
}
Reland "New video encoder API." This reverts commit 56e63097498d0ad6fe2eca779b7df173cc6a0fca. Reason for revert: Preparing for reland Original change's description: > Revert "New video encoder API." > > This reverts commit 42f12d5183016060dcddc0b515a53294853559fe. > > Reason for revert: tests fails downstream > > Original change's description: > > New video encoder API. > > > > Also initial implementation wrapping the libaom AV1 encoder. > > > > Note that for now this is intended for prototype purposes. > > > > Bug: none > > Change-Id: Iac42ca4aecb6a204601c9f00bfb300e3eda3c4f4 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/306181 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Philip Eliasson <philipel@webrtc.org> > > Reviewed-by: Erik Språng <sprang@webrtc.org> > > Cr-Commit-Position: refs/heads/main@{#42108} > > Bug: none > Change-Id: I927260353afb91df6c7650364baee4f13a098efd > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347883 > Commit-Queue: Philip Eliasson <philipel@webrtc.org> > Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> > Reviewed-by: Philip Eliasson <philipel@webrtc.org> > Owners-Override: Philip Eliasson <philipel@webrtc.org> > Auto-Submit: Danil Chapovalov <danilchap@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#42111} Bug: none Change-Id: Ib72ef5359ead697d27301e2ca2408e8b27165931 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349001 Commit-Queue: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42172}
2024-04-24 16:31:58 +02:00
rtc_source_set("video_encoding_general") {
public = [ "video_encoding_general.h" ]
}
rtc_source_set("video_encoder_interface") {
public = [ "video_encoder_interface.h" ]
deps = [
":video_encoding_general",
Apply include-cleaner to api/video_codecs Bug: webrtc:42226242 Change-Id: I7292811f782ec9a6710c84b1fc36e42ae7ea2c17 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/359840 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Dor Hen <dorhen@meta.com> Cr-Commit-Position: refs/heads/main@{#42802}
2024-08-19 01:13:31 -07:00
"..:array_view",
"..:scoped_refptr",
Reland "New video encoder API." This reverts commit 56e63097498d0ad6fe2eca779b7df173cc6a0fca. Reason for revert: Preparing for reland Original change's description: > Revert "New video encoder API." > > This reverts commit 42f12d5183016060dcddc0b515a53294853559fe. > > Reason for revert: tests fails downstream > > Original change's description: > > New video encoder API. > > > > Also initial implementation wrapping the libaom AV1 encoder. > > > > Note that for now this is intended for prototype purposes. > > > > Bug: none > > Change-Id: Iac42ca4aecb6a204601c9f00bfb300e3eda3c4f4 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/306181 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Philip Eliasson <philipel@webrtc.org> > > Reviewed-by: Erik Språng <sprang@webrtc.org> > > Cr-Commit-Position: refs/heads/main@{#42108} > > Bug: none > Change-Id: I927260353afb91df6c7650364baee4f13a098efd > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347883 > Commit-Queue: Philip Eliasson <philipel@webrtc.org> > Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> > Reviewed-by: Philip Eliasson <philipel@webrtc.org> > Owners-Override: Philip Eliasson <philipel@webrtc.org> > Auto-Submit: Danil Chapovalov <danilchap@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#42111} Bug: none Change-Id: Ib72ef5359ead697d27301e2ca2408e8b27165931 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349001 Commit-Queue: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42172}
2024-04-24 16:31:58 +02:00
"../../api/units:data_rate",
Add `OutputFunctions` to FrameEncodeSettings. Bug: b/336978562 Change-Id: I9fe2d78368f4619532e64670fc9167ddfe253ffe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350920 Reviewed-by: Erik Språng <sprang@webrtc.org> Commit-Queue: Philip Eliasson <philipel@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42350}
2024-05-20 16:49:13 +02:00
"../../api/units:data_size",
Reland "New video encoder API." This reverts commit 56e63097498d0ad6fe2eca779b7df173cc6a0fca. Reason for revert: Preparing for reland Original change's description: > Revert "New video encoder API." > > This reverts commit 42f12d5183016060dcddc0b515a53294853559fe. > > Reason for revert: tests fails downstream > > Original change's description: > > New video encoder API. > > > > Also initial implementation wrapping the libaom AV1 encoder. > > > > Note that for now this is intended for prototype purposes. > > > > Bug: none > > Change-Id: Iac42ca4aecb6a204601c9f00bfb300e3eda3c4f4 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/306181 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Philip Eliasson <philipel@webrtc.org> > > Reviewed-by: Erik Språng <sprang@webrtc.org> > > Cr-Commit-Position: refs/heads/main@{#42108} > > Bug: none > Change-Id: I927260353afb91df6c7650364baee4f13a098efd > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347883 > Commit-Queue: Philip Eliasson <philipel@webrtc.org> > Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> > Reviewed-by: Philip Eliasson <philipel@webrtc.org> > Owners-Override: Philip Eliasson <philipel@webrtc.org> > Auto-Submit: Danil Chapovalov <danilchap@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#42111} Bug: none Change-Id: Ib72ef5359ead697d27301e2ca2408e8b27165931 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349001 Commit-Queue: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42172}
2024-04-24 16:31:58 +02:00
"../../api/units:time_delta",
"../../api/units:timestamp",
"../../api/video:encoded_image",
"../../api/video:resolution",
"../../api/video:video_frame",
"../../api/video_codecs:video_codecs_api",
"../../rtc_base:rtc_numerics",
"//third_party/abseil-cpp/absl/functional:any_invocable",
"//third_party/abseil-cpp/absl/types:optional",
"//third_party/abseil-cpp/absl/types:variant",
]
}
rtc_source_set("video_encoder_factory_interface") {
public = [ "video_encoder_factory_interface.h" ]
deps = [
":video_encoder_interface",
":video_encoding_general",
"../../api/units:time_delta",
"../../api/video:resolution",
"../../rtc_base:rtc_numerics",
Apply include-cleaner to api/video_codecs Bug: webrtc:42226242 Change-Id: I7292811f782ec9a6710c84b1fc36e42ae7ea2c17 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/359840 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Dor Hen <dorhen@meta.com> Cr-Commit-Position: refs/heads/main@{#42802}
2024-08-19 01:13:31 -07:00
"../video:video_frame",
Reland "New video encoder API." This reverts commit 56e63097498d0ad6fe2eca779b7df173cc6a0fca. Reason for revert: Preparing for reland Original change's description: > Revert "New video encoder API." > > This reverts commit 42f12d5183016060dcddc0b515a53294853559fe. > > Reason for revert: tests fails downstream > > Original change's description: > > New video encoder API. > > > > Also initial implementation wrapping the libaom AV1 encoder. > > > > Note that for now this is intended for prototype purposes. > > > > Bug: none > > Change-Id: Iac42ca4aecb6a204601c9f00bfb300e3eda3c4f4 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/306181 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Philip Eliasson <philipel@webrtc.org> > > Reviewed-by: Erik Språng <sprang@webrtc.org> > > Cr-Commit-Position: refs/heads/main@{#42108} > > Bug: none > Change-Id: I927260353afb91df6c7650364baee4f13a098efd > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347883 > Commit-Queue: Philip Eliasson <philipel@webrtc.org> > Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> > Reviewed-by: Philip Eliasson <philipel@webrtc.org> > Owners-Override: Philip Eliasson <philipel@webrtc.org> > Auto-Submit: Danil Chapovalov <danilchap@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#42111} Bug: none Change-Id: Ib72ef5359ead697d27301e2ca2408e8b27165931 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349001 Commit-Queue: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42172}
2024-04-24 16:31:58 +02:00
"//third_party/abseil-cpp/absl/types:optional",
"//third_party/abseil-cpp/absl/types:variant",
]
}
rtc_library("simple_encoder_wrapper") {
sources = [
"simple_encoder_wrapper.cc",
"simple_encoder_wrapper.h",
]
deps = [
":video_encoder_factory_interface",
":video_encoder_interface",
Apply include-cleaner to api/video_codecs Bug: webrtc:42226242 Change-Id: I7292811f782ec9a6710c84b1fc36e42ae7ea2c17 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/359840 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Dor Hen <dorhen@meta.com> Cr-Commit-Position: refs/heads/main@{#42802}
2024-08-19 01:13:31 -07:00
"..:array_view",
"..:scoped_refptr",
Reland "New video encoder API." This reverts commit 56e63097498d0ad6fe2eca779b7df173cc6a0fca. Reason for revert: Preparing for reland Original change's description: > Revert "New video encoder API." > > This reverts commit 42f12d5183016060dcddc0b515a53294853559fe. > > Reason for revert: tests fails downstream > > Original change's description: > > New video encoder API. > > > > Also initial implementation wrapping the libaom AV1 encoder. > > > > Note that for now this is intended for prototype purposes. > > > > Bug: none > > Change-Id: Iac42ca4aecb6a204601c9f00bfb300e3eda3c4f4 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/306181 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Philip Eliasson <philipel@webrtc.org> > > Reviewed-by: Erik Språng <sprang@webrtc.org> > > Cr-Commit-Position: refs/heads/main@{#42108} > > Bug: none > Change-Id: I927260353afb91df6c7650364baee4f13a098efd > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347883 > Commit-Queue: Philip Eliasson <philipel@webrtc.org> > Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> > Reviewed-by: Philip Eliasson <philipel@webrtc.org> > Owners-Override: Philip Eliasson <philipel@webrtc.org> > Auto-Submit: Danil Chapovalov <danilchap@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#42111} Bug: none Change-Id: Ib72ef5359ead697d27301e2ca2408e8b27165931 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349001 Commit-Queue: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42172}
2024-04-24 16:31:58 +02:00
"../../api/units:data_rate",
"../../api/video_codecs:scalability_mode",
"../../api/video_codecs:scalability_mode_helper",
"../../common_video/generic_frame_descriptor:generic_frame_descriptor",
"../../modules/video_coding/svc:scalability_structures",
Apply include-cleaner to api/video_codecs Bug: webrtc:42226242 Change-Id: I7292811f782ec9a6710c84b1fc36e42ae7ea2c17 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/359840 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Dor Hen <dorhen@meta.com> Cr-Commit-Position: refs/heads/main@{#42802}
2024-08-19 01:13:31 -07:00
"../../modules/video_coding/svc:scalable_video_controller",
"../../rtc_base:checks",
Reland "New video encoder API." This reverts commit 56e63097498d0ad6fe2eca779b7df173cc6a0fca. Reason for revert: Preparing for reland Original change's description: > Revert "New video encoder API." > > This reverts commit 42f12d5183016060dcddc0b515a53294853559fe. > > Reason for revert: tests fails downstream > > Original change's description: > > New video encoder API. > > > > Also initial implementation wrapping the libaom AV1 encoder. > > > > Note that for now this is intended for prototype purposes. > > > > Bug: none > > Change-Id: Iac42ca4aecb6a204601c9f00bfb300e3eda3c4f4 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/306181 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Philip Eliasson <philipel@webrtc.org> > > Reviewed-by: Erik Språng <sprang@webrtc.org> > > Cr-Commit-Position: refs/heads/main@{#42108} > > Bug: none > Change-Id: I927260353afb91df6c7650364baee4f13a098efd > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347883 > Commit-Queue: Philip Eliasson <philipel@webrtc.org> > Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> > Reviewed-by: Philip Eliasson <philipel@webrtc.org> > Owners-Override: Philip Eliasson <philipel@webrtc.org> > Auto-Submit: Danil Chapovalov <danilchap@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#42111} Bug: none Change-Id: Ib72ef5359ead697d27301e2ca2408e8b27165931 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349001 Commit-Queue: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42172}
2024-04-24 16:31:58 +02:00
"../../rtc_base:logging",
Apply include-cleaner to api/video_codecs Bug: webrtc:42226242 Change-Id: I7292811f782ec9a6710c84b1fc36e42ae7ea2c17 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/359840 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Dor Hen <dorhen@meta.com> Cr-Commit-Position: refs/heads/main@{#42802}
2024-08-19 01:13:31 -07:00
"../../rtc_base:rtc_numerics",
"../transport/rtp:dependency_descriptor",
"../units:data_size",
"../units:frequency",
"../units:timestamp",
"../video:video_frame",
Reland "New video encoder API." This reverts commit 56e63097498d0ad6fe2eca779b7df173cc6a0fca. Reason for revert: Preparing for reland Original change's description: > Revert "New video encoder API." > > This reverts commit 42f12d5183016060dcddc0b515a53294853559fe. > > Reason for revert: tests fails downstream > > Original change's description: > > New video encoder API. > > > > Also initial implementation wrapping the libaom AV1 encoder. > > > > Note that for now this is intended for prototype purposes. > > > > Bug: none > > Change-Id: Iac42ca4aecb6a204601c9f00bfb300e3eda3c4f4 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/306181 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Philip Eliasson <philipel@webrtc.org> > > Reviewed-by: Erik Språng <sprang@webrtc.org> > > Cr-Commit-Position: refs/heads/main@{#42108} > > Bug: none > Change-Id: I927260353afb91df6c7650364baee4f13a098efd > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347883 > Commit-Queue: Philip Eliasson <philipel@webrtc.org> > Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> > Reviewed-by: Philip Eliasson <philipel@webrtc.org> > Owners-Override: Philip Eliasson <philipel@webrtc.org> > Auto-Submit: Danil Chapovalov <danilchap@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#42111} Bug: none Change-Id: Ib72ef5359ead697d27301e2ca2408e8b27165931 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349001 Commit-Queue: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42172}
2024-04-24 16:31:58 +02:00
"//third_party/abseil-cpp/absl/algorithm:container",
"//third_party/abseil-cpp/absl/functional:any_invocable",
Apply include-cleaner to api/video_codecs Bug: webrtc:42226242 Change-Id: I7292811f782ec9a6710c84b1fc36e42ae7ea2c17 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/359840 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Dor Hen <dorhen@meta.com> Cr-Commit-Position: refs/heads/main@{#42802}
2024-08-19 01:13:31 -07:00
"//third_party/abseil-cpp/absl/strings:string_view",
"//third_party/abseil-cpp/absl/types:optional",
Move EncodeResultCallback to FrameEncodeSettings. Bug: b/336978562 Change-Id: I25cb6662a6b66fba9d22d974e1b6da48e137d0ea Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349225 Reviewed-by: Erik Språng <sprang@webrtc.org> Commit-Queue: Philip Eliasson <philipel@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42284}
2024-04-26 16:32:07 +02:00
"//third_party/abseil-cpp/absl/types:variant",
Reland "New video encoder API." This reverts commit 56e63097498d0ad6fe2eca779b7df173cc6a0fca. Reason for revert: Preparing for reland Original change's description: > Revert "New video encoder API." > > This reverts commit 42f12d5183016060dcddc0b515a53294853559fe. > > Reason for revert: tests fails downstream > > Original change's description: > > New video encoder API. > > > > Also initial implementation wrapping the libaom AV1 encoder. > > > > Note that for now this is intended for prototype purposes. > > > > Bug: none > > Change-Id: Iac42ca4aecb6a204601c9f00bfb300e3eda3c4f4 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/306181 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Philip Eliasson <philipel@webrtc.org> > > Reviewed-by: Erik Språng <sprang@webrtc.org> > > Cr-Commit-Position: refs/heads/main@{#42108} > > Bug: none > Change-Id: I927260353afb91df6c7650364baee4f13a098efd > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347883 > Commit-Queue: Philip Eliasson <philipel@webrtc.org> > Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> > Reviewed-by: Philip Eliasson <philipel@webrtc.org> > Owners-Override: Philip Eliasson <philipel@webrtc.org> > Auto-Submit: Danil Chapovalov <danilchap@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#42111} Bug: none Change-Id: Ib72ef5359ead697d27301e2ca2408e8b27165931 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349001 Commit-Queue: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42172}
2024-04-24 16:31:58 +02:00
]
}
rtc_library("simple_encoder_wrapper_unittests") {
testonly = true
sources = [ "simple_encoder_wrapper_unittests.cc" ]
deps = [
":simple_encoder_wrapper",
":video_encoder_factory_interface",
":video_encoder_interface",
Apply include-cleaner to api/video_codecs Bug: webrtc:42226242 Change-Id: I7292811f782ec9a6710c84b1fc36e42ae7ea2c17 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/359840 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Dor Hen <dorhen@meta.com> Cr-Commit-Position: refs/heads/main@{#42802}
2024-08-19 01:13:31 -07:00
":video_encoding_general",
Reland "New video encoder API." This reverts commit 56e63097498d0ad6fe2eca779b7df173cc6a0fca. Reason for revert: Preparing for reland Original change's description: > Revert "New video encoder API." > > This reverts commit 42f12d5183016060dcddc0b515a53294853559fe. > > Reason for revert: tests fails downstream > > Original change's description: > > New video encoder API. > > > > Also initial implementation wrapping the libaom AV1 encoder. > > > > Note that for now this is intended for prototype purposes. > > > > Bug: none > > Change-Id: Iac42ca4aecb6a204601c9f00bfb300e3eda3c4f4 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/306181 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Philip Eliasson <philipel@webrtc.org> > > Reviewed-by: Erik Språng <sprang@webrtc.org> > > Cr-Commit-Position: refs/heads/main@{#42108} > > Bug: none > Change-Id: I927260353afb91df6c7650364baee4f13a098efd > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347883 > Commit-Queue: Philip Eliasson <philipel@webrtc.org> > Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> > Reviewed-by: Philip Eliasson <philipel@webrtc.org> > Owners-Override: Philip Eliasson <philipel@webrtc.org> > Auto-Submit: Danil Chapovalov <danilchap@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#42111} Bug: none Change-Id: Ib72ef5359ead697d27301e2ca2408e8b27165931 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349001 Commit-Queue: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42172}
2024-04-24 16:31:58 +02:00
"../../api/video:video_frame",
"../../api/video_codecs:libaom_av1_encoder_factory",
"../../test:fileutils",
"../../test:test_support",
"../../test:video_test_support",
Apply include-cleaner to api/video_codecs Bug: webrtc:42226242 Change-Id: I7292811f782ec9a6710c84b1fc36e42ae7ea2c17 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/359840 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Dor Hen <dorhen@meta.com> Cr-Commit-Position: refs/heads/main@{#42802}
2024-08-19 01:13:31 -07:00
"//third_party/abseil-cpp/absl/types:optional",
Reland "New video encoder API." This reverts commit 56e63097498d0ad6fe2eca779b7df173cc6a0fca. Reason for revert: Preparing for reland Original change's description: > Revert "New video encoder API." > > This reverts commit 42f12d5183016060dcddc0b515a53294853559fe. > > Reason for revert: tests fails downstream > > Original change's description: > > New video encoder API. > > > > Also initial implementation wrapping the libaom AV1 encoder. > > > > Note that for now this is intended for prototype purposes. > > > > Bug: none > > Change-Id: Iac42ca4aecb6a204601c9f00bfb300e3eda3c4f4 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/306181 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Philip Eliasson <philipel@webrtc.org> > > Reviewed-by: Erik Språng <sprang@webrtc.org> > > Cr-Commit-Position: refs/heads/main@{#42108} > > Bug: none > Change-Id: I927260353afb91df6c7650364baee4f13a098efd > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347883 > Commit-Queue: Philip Eliasson <philipel@webrtc.org> > Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> > Reviewed-by: Philip Eliasson <philipel@webrtc.org> > Owners-Override: Philip Eliasson <philipel@webrtc.org> > Auto-Submit: Danil Chapovalov <danilchap@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#42111} Bug: none Change-Id: Ib72ef5359ead697d27301e2ca2408e8b27165931 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349001 Commit-Queue: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42172}
2024-04-24 16:31:58 +02:00
]
}
rtc_library("libaom_av1_encoder_factory") {
sources = [
"libaom_av1_encoder_factory.cc",
"libaom_av1_encoder_factory.h",
]
deps = [
Apply include-cleaner to api/video_codecs Bug: webrtc:42226242 Change-Id: I7292811f782ec9a6710c84b1fc36e42ae7ea2c17 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/359840 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Dor Hen <dorhen@meta.com> Cr-Commit-Position: refs/heads/main@{#42802}
2024-08-19 01:13:31 -07:00
":video_codecs_api",
Reland "New video encoder API." This reverts commit 56e63097498d0ad6fe2eca779b7df173cc6a0fca. Reason for revert: Preparing for reland Original change's description: > Revert "New video encoder API." > > This reverts commit 42f12d5183016060dcddc0b515a53294853559fe. > > Reason for revert: tests fails downstream > > Original change's description: > > New video encoder API. > > > > Also initial implementation wrapping the libaom AV1 encoder. > > > > Note that for now this is intended for prototype purposes. > > > > Bug: none > > Change-Id: Iac42ca4aecb6a204601c9f00bfb300e3eda3c4f4 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/306181 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Philip Eliasson <philipel@webrtc.org> > > Reviewed-by: Erik Språng <sprang@webrtc.org> > > Cr-Commit-Position: refs/heads/main@{#42108} > > Bug: none > Change-Id: I927260353afb91df6c7650364baee4f13a098efd > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347883 > Commit-Queue: Philip Eliasson <philipel@webrtc.org> > Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> > Reviewed-by: Philip Eliasson <philipel@webrtc.org> > Owners-Override: Philip Eliasson <philipel@webrtc.org> > Auto-Submit: Danil Chapovalov <danilchap@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#42111} Bug: none Change-Id: Ib72ef5359ead697d27301e2ca2408e8b27165931 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349001 Commit-Queue: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42172}
2024-04-24 16:31:58 +02:00
":video_encoder_factory_interface",
":video_encoder_interface",
Apply include-cleaner to api/video_codecs Bug: webrtc:42226242 Change-Id: I7292811f782ec9a6710c84b1fc36e42ae7ea2c17 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/359840 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Dor Hen <dorhen@meta.com> Cr-Commit-Position: refs/heads/main@{#42802}
2024-08-19 01:13:31 -07:00
":video_encoding_general",
"..:array_view",
"..:scoped_refptr",
Reland "New video encoder API." This reverts commit 56e63097498d0ad6fe2eca779b7df173cc6a0fca. Reason for revert: Preparing for reland Original change's description: > Revert "New video encoder API." > > This reverts commit 42f12d5183016060dcddc0b515a53294853559fe. > > Reason for revert: tests fails downstream > > Original change's description: > > New video encoder API. > > > > Also initial implementation wrapping the libaom AV1 encoder. > > > > Note that for now this is intended for prototype purposes. > > > > Bug: none > > Change-Id: Iac42ca4aecb6a204601c9f00bfb300e3eda3c4f4 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/306181 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Philip Eliasson <philipel@webrtc.org> > > Reviewed-by: Erik Språng <sprang@webrtc.org> > > Cr-Commit-Position: refs/heads/main@{#42108} > > Bug: none > Change-Id: I927260353afb91df6c7650364baee4f13a098efd > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347883 > Commit-Queue: Philip Eliasson <philipel@webrtc.org> > Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> > Reviewed-by: Philip Eliasson <philipel@webrtc.org> > Owners-Override: Philip Eliasson <philipel@webrtc.org> > Auto-Submit: Danil Chapovalov <danilchap@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#42111} Bug: none Change-Id: Ib72ef5359ead697d27301e2ca2408e8b27165931 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349001 Commit-Queue: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42172}
2024-04-24 16:31:58 +02:00
"../../api/units:time_delta",
Apply include-cleaner to api/video_codecs Bug: webrtc:42226242 Change-Id: I7292811f782ec9a6710c84b1fc36e42ae7ea2c17 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/359840 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Dor Hen <dorhen@meta.com> Cr-Commit-Position: refs/heads/main@{#42802}
2024-08-19 01:13:31 -07:00
"../../rtc_base:checks",
Reland "New video encoder API." This reverts commit 56e63097498d0ad6fe2eca779b7df173cc6a0fca. Reason for revert: Preparing for reland Original change's description: > Revert "New video encoder API." > > This reverts commit 42f12d5183016060dcddc0b515a53294853559fe. > > Reason for revert: tests fails downstream > > Original change's description: > > New video encoder API. > > > > Also initial implementation wrapping the libaom AV1 encoder. > > > > Note that for now this is intended for prototype purposes. > > > > Bug: none > > Change-Id: Iac42ca4aecb6a204601c9f00bfb300e3eda3c4f4 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/306181 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Philip Eliasson <philipel@webrtc.org> > > Reviewed-by: Erik Språng <sprang@webrtc.org> > > Cr-Commit-Position: refs/heads/main@{#42108} > > Bug: none > Change-Id: I927260353afb91df6c7650364baee4f13a098efd > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347883 > Commit-Queue: Philip Eliasson <philipel@webrtc.org> > Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> > Reviewed-by: Philip Eliasson <philipel@webrtc.org> > Owners-Override: Philip Eliasson <philipel@webrtc.org> > Auto-Submit: Danil Chapovalov <danilchap@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#42111} Bug: none Change-Id: Ib72ef5359ead697d27301e2ca2408e8b27165931 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349001 Commit-Queue: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42172}
2024-04-24 16:31:58 +02:00
"../../rtc_base:logging",
Apply include-cleaner to api/video_codecs Bug: webrtc:42226242 Change-Id: I7292811f782ec9a6710c84b1fc36e42ae7ea2c17 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/359840 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Dor Hen <dorhen@meta.com> Cr-Commit-Position: refs/heads/main@{#42802}
2024-08-19 01:13:31 -07:00
"../../rtc_base:rtc_numerics",
Fix iwyu error introduced recently. This fixes a build error introduced by: https://webrtc-review.googlesource.com/c/src/+/349001 bot: https://ci.chromium.org/ui/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20ios-device Error: ../../third_party/webrtc/api/video_codecs/libaom_av1_encoder_factory.cc:494:27: error: expected ';' after expression 494 | rtc::SimpleStringBuilder sb(buf); | ^ | ; ../../third_party/webrtc/api/video_codecs/libaom_av1_encoder_factory.cc:494:8: error: no member named 'SimpleStringBuilder' in namespace 'rtc' Bug: none Change-Id: I020040f367005ab56068cf4356e5effb380b7200 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349320 Auto-Submit: Tomas Gunnarsson <tommi@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42189}
2024-04-29 08:24:09 +02:00
"../../rtc_base:stringutils",
Apply include-cleaner to api/video_codecs Bug: webrtc:42226242 Change-Id: I7292811f782ec9a6710c84b1fc36e42ae7ea2c17 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/359840 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Dor Hen <dorhen@meta.com> Cr-Commit-Position: refs/heads/main@{#42802}
2024-08-19 01:13:31 -07:00
"../units:data_rate",
"../units:data_size",
"../video:resolution",
"../video:video_frame",
Use absl::Cleanup to perform callbacks on encoding error. Bug: b/336978562 Change-Id: I8cf9bbea5192fd470c02b7f40dafce00f199cada Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/351040 Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Commit-Queue: Philip Eliasson <philipel@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42357}
2024-05-21 09:25:08 +02:00
"//third_party/abseil-cpp/absl/algorithm:container",
"//third_party/abseil-cpp/absl/cleanup",
Apply include-cleaner to api/video_codecs Bug: webrtc:42226242 Change-Id: I7292811f782ec9a6710c84b1fc36e42ae7ea2c17 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/359840 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Dor Hen <dorhen@meta.com> Cr-Commit-Position: refs/heads/main@{#42802}
2024-08-19 01:13:31 -07:00
"//third_party/abseil-cpp/absl/types:optional",
"//third_party/abseil-cpp/absl/types:variant",
Mass removal of absl_deps in all BUILD.gn files Bug: webrtc:341803749 Change-Id: Id73844ba8d63b9f2f2c9391d8d8116ad0864c36d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/351540 Commit-Queue: Florent Castelli <orphis@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42372}
2024-05-23 11:21:53 +00:00
"//third_party/libaom",
Use absl::Cleanup to perform callbacks on encoding error. Bug: b/336978562 Change-Id: I8cf9bbea5192fd470c02b7f40dafce00f199cada Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/351040 Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Commit-Queue: Philip Eliasson <philipel@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42357}
2024-05-21 09:25:08 +02:00
]
Reland "New video encoder API." This reverts commit 56e63097498d0ad6fe2eca779b7df173cc6a0fca. Reason for revert: Preparing for reland Original change's description: > Revert "New video encoder API." > > This reverts commit 42f12d5183016060dcddc0b515a53294853559fe. > > Reason for revert: tests fails downstream > > Original change's description: > > New video encoder API. > > > > Also initial implementation wrapping the libaom AV1 encoder. > > > > Note that for now this is intended for prototype purposes. > > > > Bug: none > > Change-Id: Iac42ca4aecb6a204601c9f00bfb300e3eda3c4f4 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/306181 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Philip Eliasson <philipel@webrtc.org> > > Reviewed-by: Erik Språng <sprang@webrtc.org> > > Cr-Commit-Position: refs/heads/main@{#42108} > > Bug: none > Change-Id: I927260353afb91df6c7650364baee4f13a098efd > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347883 > Commit-Queue: Philip Eliasson <philipel@webrtc.org> > Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> > Reviewed-by: Philip Eliasson <philipel@webrtc.org> > Owners-Override: Philip Eliasson <philipel@webrtc.org> > Auto-Submit: Danil Chapovalov <danilchap@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#42111} Bug: none Change-Id: Ib72ef5359ead697d27301e2ca2408e8b27165931 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349001 Commit-Queue: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42172}
2024-04-24 16:31:58 +02:00
}
rtc_library("libaom_av1_encoder_factory_test") {
testonly = true
sources = [ "libaom_av1_encoder_factory_test.cc" ]
data = [ "../../resources/reference_video_640x360_30fps.y4m" ]
deps = [
":libaom_av1_encoder_factory",
Apply include-cleaner to api/video_codecs Bug: webrtc:42226242 Change-Id: I7292811f782ec9a6710c84b1fc36e42ae7ea2c17 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/359840 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Dor Hen <dorhen@meta.com> Cr-Commit-Position: refs/heads/main@{#42802}
2024-08-19 01:13:31 -07:00
":video_encoder_factory_interface",
Reland "New video encoder API." This reverts commit 56e63097498d0ad6fe2eca779b7df173cc6a0fca. Reason for revert: Preparing for reland Original change's description: > Revert "New video encoder API." > > This reverts commit 42f12d5183016060dcddc0b515a53294853559fe. > > Reason for revert: tests fails downstream > > Original change's description: > > New video encoder API. > > > > Also initial implementation wrapping the libaom AV1 encoder. > > > > Note that for now this is intended for prototype purposes. > > > > Bug: none > > Change-Id: Iac42ca4aecb6a204601c9f00bfb300e3eda3c4f4 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/306181 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Philip Eliasson <philipel@webrtc.org> > > Reviewed-by: Erik Språng <sprang@webrtc.org> > > Cr-Commit-Position: refs/heads/main@{#42108} > > Bug: none > Change-Id: I927260353afb91df6c7650364baee4f13a098efd > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347883 > Commit-Queue: Philip Eliasson <philipel@webrtc.org> > Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> > Reviewed-by: Philip Eliasson <philipel@webrtc.org> > Owners-Override: Philip Eliasson <philipel@webrtc.org> > Auto-Submit: Danil Chapovalov <danilchap@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#42111} Bug: none Change-Id: Ib72ef5359ead697d27301e2ca2408e8b27165931 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349001 Commit-Queue: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42172}
2024-04-24 16:31:58 +02:00
":video_encoder_interface",
Apply include-cleaner to api/video_codecs Bug: webrtc:42226242 Change-Id: I7292811f782ec9a6710c84b1fc36e42ae7ea2c17 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/359840 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Dor Hen <dorhen@meta.com> Cr-Commit-Position: refs/heads/main@{#42802}
2024-08-19 01:13:31 -07:00
":video_encoding_general",
"..:array_view",
"..:scoped_refptr",
Reland "New video encoder API." This reverts commit 56e63097498d0ad6fe2eca779b7df173cc6a0fca. Reason for revert: Preparing for reland Original change's description: > Revert "New video encoder API." > > This reverts commit 42f12d5183016060dcddc0b515a53294853559fe. > > Reason for revert: tests fails downstream > > Original change's description: > > New video encoder API. > > > > Also initial implementation wrapping the libaom AV1 encoder. > > > > Note that for now this is intended for prototype purposes. > > > > Bug: none > > Change-Id: Iac42ca4aecb6a204601c9f00bfb300e3eda3c4f4 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/306181 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Philip Eliasson <philipel@webrtc.org> > > Reviewed-by: Erik Språng <sprang@webrtc.org> > > Cr-Commit-Position: refs/heads/main@{#42108} > > Bug: none > Change-Id: I927260353afb91df6c7650364baee4f13a098efd > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347883 > Commit-Queue: Philip Eliasson <philipel@webrtc.org> > Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> > Reviewed-by: Philip Eliasson <philipel@webrtc.org> > Owners-Override: Philip Eliasson <philipel@webrtc.org> > Auto-Submit: Danil Chapovalov <danilchap@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#42111} Bug: none Change-Id: Ib72ef5359ead697d27301e2ca2408e8b27165931 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349001 Commit-Queue: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42172}
2024-04-24 16:31:58 +02:00
"../../api/video:video_frame",
"../../api/video_codecs:video_codecs_api",
"../../common_video:common_video",
"../../modules/video_coding/codecs/av1:dav1d_decoder",
Apply include-cleaner to api/video_codecs Bug: webrtc:42226242 Change-Id: I7292811f782ec9a6710c84b1fc36e42ae7ea2c17 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/359840 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Dor Hen <dorhen@meta.com> Cr-Commit-Position: refs/heads/main@{#42802}
2024-08-19 01:13:31 -07:00
"../../rtc_base:checks",
Reland "New video encoder API." This reverts commit 56e63097498d0ad6fe2eca779b7df173cc6a0fca. Reason for revert: Preparing for reland Original change's description: > Revert "New video encoder API." > > This reverts commit 42f12d5183016060dcddc0b515a53294853559fe. > > Reason for revert: tests fails downstream > > Original change's description: > > New video encoder API. > > > > Also initial implementation wrapping the libaom AV1 encoder. > > > > Note that for now this is intended for prototype purposes. > > > > Bug: none > > Change-Id: Iac42ca4aecb6a204601c9f00bfb300e3eda3c4f4 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/306181 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Philip Eliasson <philipel@webrtc.org> > > Reviewed-by: Erik Språng <sprang@webrtc.org> > > Cr-Commit-Position: refs/heads/main@{#42108} > > Bug: none > Change-Id: I927260353afb91df6c7650364baee4f13a098efd > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347883 > Commit-Queue: Philip Eliasson <philipel@webrtc.org> > Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> > Reviewed-by: Philip Eliasson <philipel@webrtc.org> > Owners-Override: Philip Eliasson <philipel@webrtc.org> > Auto-Submit: Danil Chapovalov <danilchap@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#42111} Bug: none Change-Id: Ib72ef5359ead697d27301e2ca2408e8b27165931 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349001 Commit-Queue: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42172}
2024-04-24 16:31:58 +02:00
"../../rtc_base:logging",
"../../test:fileutils",
"../../test:test_support",
Extract video writing into separate target Bug: None Change-Id: I3af192606eb623e21a4d648fb69bb62c14ab8b0d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/355560 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42541}
2024-06-26 13:23:44 +02:00
"../../test:video_frame_writer",
Reland "New video encoder API." This reverts commit 56e63097498d0ad6fe2eca779b7df173cc6a0fca. Reason for revert: Preparing for reland Original change's description: > Revert "New video encoder API." > > This reverts commit 42f12d5183016060dcddc0b515a53294853559fe. > > Reason for revert: tests fails downstream > > Original change's description: > > New video encoder API. > > > > Also initial implementation wrapping the libaom AV1 encoder. > > > > Note that for now this is intended for prototype purposes. > > > > Bug: none > > Change-Id: Iac42ca4aecb6a204601c9f00bfb300e3eda3c4f4 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/306181 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Philip Eliasson <philipel@webrtc.org> > > Reviewed-by: Erik Språng <sprang@webrtc.org> > > Cr-Commit-Position: refs/heads/main@{#42108} > > Bug: none > Change-Id: I927260353afb91df6c7650364baee4f13a098efd > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347883 > Commit-Queue: Philip Eliasson <philipel@webrtc.org> > Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> > Reviewed-by: Philip Eliasson <philipel@webrtc.org> > Owners-Override: Philip Eliasson <philipel@webrtc.org> > Auto-Submit: Danil Chapovalov <danilchap@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#42111} Bug: none Change-Id: Ib72ef5359ead697d27301e2ca2408e8b27165931 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349001 Commit-Queue: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42172}
2024-04-24 16:31:58 +02:00
"../../test:video_test_support",
Apply include-cleaner to api/video_codecs Bug: webrtc:42226242 Change-Id: I7292811f782ec9a6710c84b1fc36e42ae7ea2c17 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/359840 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Dor Hen <dorhen@meta.com> Cr-Commit-Position: refs/heads/main@{#42802}
2024-08-19 01:13:31 -07:00
"../units:data_rate",
"../units:data_size",
"../units:time_delta",
"../units:timestamp",
"../video:encoded_image",
"//third_party/abseil-cpp/absl/types:optional",
Mass removal of absl_deps in all BUILD.gn files Bug: webrtc:341803749 Change-Id: Id73844ba8d63b9f2f2c9391d8d8116ad0864c36d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/351540 Commit-Queue: Florent Castelli <orphis@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42372}
2024-05-23 11:21:53 +00:00
"//third_party/abseil-cpp/absl/types:variant",
Reland "New video encoder API." This reverts commit 56e63097498d0ad6fe2eca779b7df173cc6a0fca. Reason for revert: Preparing for reland Original change's description: > Revert "New video encoder API." > > This reverts commit 42f12d5183016060dcddc0b515a53294853559fe. > > Reason for revert: tests fails downstream > > Original change's description: > > New video encoder API. > > > > Also initial implementation wrapping the libaom AV1 encoder. > > > > Note that for now this is intended for prototype purposes. > > > > Bug: none > > Change-Id: Iac42ca4aecb6a204601c9f00bfb300e3eda3c4f4 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/306181 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Philip Eliasson <philipel@webrtc.org> > > Reviewed-by: Erik Språng <sprang@webrtc.org> > > Cr-Commit-Position: refs/heads/main@{#42108} > > Bug: none > Change-Id: I927260353afb91df6c7650364baee4f13a098efd > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347883 > Commit-Queue: Philip Eliasson <philipel@webrtc.org> > Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> > Reviewed-by: Philip Eliasson <philipel@webrtc.org> > Owners-Override: Philip Eliasson <philipel@webrtc.org> > Auto-Submit: Danil Chapovalov <danilchap@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#42111} Bug: none Change-Id: Ib72ef5359ead697d27301e2ca2408e8b27165931 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349001 Commit-Queue: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42172}
2024-04-24 16:31:58 +02:00
]
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("vp8_temporal_layers_factory") {
Move TemporalLayers to api/video_codecs. Also renaming it Vp8TemporalLayers to show that it is codec specific. Bug: webrtc:9012 Change-Id: I18187538b8142cdd7538f1a4ed1bada09d040f1f Reviewed-on: https://webrtc-review.googlesource.com/c/104643 Commit-Queue: Erik Språng <sprang@webrtc.org> Reviewed-by: Per Kjellander <perkj@webrtc.org> Reviewed-by: Sebastian Jansson <srte@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25137}
2018-10-12 10:30:31 +02:00
visibility = [ "*" ]
allow_poison = [ "software_video_codecs" ]
sources = [
Use single FrameBufferController in VP8, created by a factory. This CL paves the way to making FrameBufferController injectable. LibvpxVp8Encoder can manage multiple streams. Prior to this CL, each stream had its own frame buffer controller, all of them held in a vector by LibvpxVp8Encoder. This complicated the code and produced some code duplication (cf. SetupTemporalLayers). This CL: 1. Replaces CreateVp8TemporalLayers() by a factory. (Later CLs will make this factory injectable.) 2. Makes LibvpxVp8Encoder use a single controller. This single controller will, in the case of multiple streams, delegate its work to multiple controllers, but that fact is not visible to LibvpxVp8Encoder. This CL also squashes CL #126046 (Send notifications of RTT and PLR changes to Vp8FrameBufferController) into it. Bug: webrtc:10382 Change-Id: Id9b55734bebb457acc276f34a7a9e52cc19c8eb9 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126483 Commit-Queue: Elad Alon <eladalon@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27206}
2019-03-20 11:56:20 +01:00
"vp8_temporal_layers_factory.cc",
"vp8_temporal_layers_factory.h",
Move TemporalLayers to api/video_codecs. Also renaming it Vp8TemporalLayers to show that it is codec specific. Bug: webrtc:9012 Change-Id: I18187538b8142cdd7538f1a4ed1bada09d040f1f Reviewed-on: https://webrtc-review.googlesource.com/c/104643 Commit-Queue: Erik Språng <sprang@webrtc.org> Reviewed-by: Per Kjellander <perkj@webrtc.org> Reviewed-by: Sebastian Jansson <srte@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25137}
2018-10-12 10:30:31 +02:00
]
deps = [
":video_codecs_api",
Pass FecControllerOverride to Vp8FrameBufferControllerFactory::Create Previously, FecControllerOverride was passed to Vp8FrameBufferController::SetFecControllerOverride. Passing to the factory is a more elegant way, since it's only used when the controller is constructed. TBR=kwiberg@webrtc.org Bug: webrtc:10769 Change-Id: Iae599889e7ca9003e3200c2911239cbb763ee65a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144380 Reviewed-by: Erik Språng <sprang@webrtc.org> Commit-Queue: Elad Alon <eladalon@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28443}
2019-07-02 11:20:09 +02:00
"../:fec_controller_api",
Use single FrameBufferController in VP8, created by a factory. This CL paves the way to making FrameBufferController injectable. LibvpxVp8Encoder can manage multiple streams. Prior to this CL, each stream had its own frame buffer controller, all of them held in a vector by LibvpxVp8Encoder. This complicated the code and produced some code duplication (cf. SetupTemporalLayers). This CL: 1. Replaces CreateVp8TemporalLayers() by a factory. (Later CLs will make this factory injectable.) 2. Makes LibvpxVp8Encoder use a single controller. This single controller will, in the case of multiple streams, delegate its work to multiple controllers, but that fact is not visible to LibvpxVp8Encoder. This CL also squashes CL #126046 (Send notifications of RTT and PLR changes to Vp8FrameBufferController) into it. Bug: webrtc:10382 Change-Id: Id9b55734bebb457acc276f34a7a9e52cc19c8eb9 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126483 Commit-Queue: Elad Alon <eladalon@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27206}
2019-03-20 11:56:20 +01:00
"../../modules/video_coding:video_coding_utility",
Move TemporalLayers to api/video_codecs. Also renaming it Vp8TemporalLayers to show that it is codec specific. Bug: webrtc:9012 Change-Id: I18187538b8142cdd7538f1a4ed1bada09d040f1f Reviewed-on: https://webrtc-review.googlesource.com/c/104643 Commit-Queue: Erik Språng <sprang@webrtc.org> Reviewed-by: Per Kjellander <perkj@webrtc.org> Reviewed-by: Sebastian Jansson <srte@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25137}
2018-10-12 10:30:31 +02:00
"../../modules/video_coding:webrtc_vp8_temporal_layers",
Use single FrameBufferController in VP8, created by a factory. This CL paves the way to making FrameBufferController injectable. LibvpxVp8Encoder can manage multiple streams. Prior to this CL, each stream had its own frame buffer controller, all of them held in a vector by LibvpxVp8Encoder. This complicated the code and produced some code duplication (cf. SetupTemporalLayers). This CL: 1. Replaces CreateVp8TemporalLayers() by a factory. (Later CLs will make this factory injectable.) 2. Makes LibvpxVp8Encoder use a single controller. This single controller will, in the case of multiple streams, delegate its work to multiple controllers, but that fact is not visible to LibvpxVp8Encoder. This CL also squashes CL #126046 (Send notifications of RTT and PLR changes to Vp8FrameBufferController) into it. Bug: webrtc:10382 Change-Id: Id9b55734bebb457acc276f34a7a9e52cc19c8eb9 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126483 Commit-Queue: Elad Alon <eladalon@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27206}
2019-03-20 11:56:20 +01:00
"../../rtc_base:checks",
Move TemporalLayers to api/video_codecs. Also renaming it Vp8TemporalLayers to show that it is codec specific. Bug: webrtc:9012 Change-Id: I18187538b8142cdd7538f1a4ed1bada09d040f1f Reviewed-on: https://webrtc-review.googlesource.com/c/104643 Commit-Queue: Erik Språng <sprang@webrtc.org> Reviewed-by: Per Kjellander <perkj@webrtc.org> Reviewed-by: Sebastian Jansson <srte@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25137}
2018-10-12 10:30:31 +02:00
]
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("rtc_software_fallback_wrappers") {
Make rtc_software_fallback_wrappers target visible. Need to depend on them from Chromium. Bug: webrtc:7925 Change-Id: Iea1bb3b937c602920bfd87f885c87c790ac7bc17 Reviewed-on: https://webrtc-review.googlesource.com/82061 Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23580}
2018-06-12 11:15:56 +02:00
visibility = [ "*" ]
sources = [
"video_decoder_software_fallback_wrapper.cc",
"video_decoder_software_fallback_wrapper.h",
"video_encoder_software_fallback_wrapper.cc",
"video_encoder_software_fallback_wrapper.h",
]
deps = [
":video_codecs_api",
Define FecControllerOverride and plumb it down to VideoEncoder The purpose of this interface is to allow VideoEncoder to override the bandwidth allocation set by FecController in RtpVideoSender. This CL defines the interface and sends it down to VideoSender. Two upcoming CLs will: 1. Make LibvpxVp8Encoder pass it on to the (injectable) FrameBufferController, where it might be put to good use. 2. Modify RtpVideoSender to respond to the message sent to it via this API. TBR=kwiberg@webrtc.org Bug: webrtc:10769 Change-Id: I2ef82f0ddcde7fd078e32d8aabf6efe43e0f7f8a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/143962 Commit-Queue: Elad Alon <eladalon@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28416}
2019-06-28 15:19:43 +02:00
"..:fec_controller_api",
Apply include-cleaner to api/video_codecs Bug: webrtc:42226242 Change-Id: I7292811f782ec9a6710c84b1fc36e42ae7ea2c17 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/359840 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Dor Hen <dorhen@meta.com> Cr-Commit-Position: refs/heads/main@{#42802}
2024-08-19 01:13:31 -07:00
"..:scoped_refptr",
Allow to use propagated field trials in VideoDecoderSoftwareFallbackWrapper Bug: webrtc:15791 Change-Id: Ida5e1c6f46e5aa9530af441b345abb80d2a5349e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/339862 Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Philip Eliasson <philipel@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41760}
2024-02-15 16:29:52 +01:00
"../../api:field_trials_view",
"../../api/environment",
Reland "Add scaling interface to VideoFrameBuffer" (Reland with no changes after the fix to the downstream project) This can be overriden for kNative frame types to perform scaling efficiently. Default implementations for existing buffer types require actual buffer implementation, thus this CL also merges "video_frame" with "video_frame_I420" build targets. Originally Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/186303 (Landing with TBR as it's unchaged reland of already approved CL) TBR=nisse@webrtc.org,sakal@webrtc.org Bug: webrtc:11976, chromium:1132299 Change-Id: Ia23f7d3e474bd9cdc177104cc5c6d772f04b210f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/187345 Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Stefan Holmer <stefan@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32362}
2020-10-08 14:36:33 +00:00
"../../api/video:video_frame",
Remove remaining .cc files from rtc_media_base Also remove all dependencies on rtc_media_base except for a few that are suspected of being linker directives. Bug: webrtc:14775 Change-Id: Ic0daf88b5422047d3ed7079ee6af9e689853310c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/341461 Commit-Queue: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Jeremy Leconte <jleconte@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41886}
2024-03-12 12:06:16 +00:00
"../../media:video_common",
Make rtc_software_fallback_wrappers target visible. Need to depend on them from Chromium. Bug: webrtc:7925 Change-Id: Iea1bb3b937c602920bfd87f885c87c790ac7bc17 Reviewed-on: https://webrtc-review.googlesource.com/82061 Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23580}
2018-06-12 11:15:56 +02:00
"../../modules/video_coding:video_codec_interface",
Allow software fallback on lowest simulcast stream for temporal support Bug: webrtc:11324 Change-Id: Ie505be0cda74c0444065d86c3727671c62bd4842 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167527 Reviewed-by: Sebastian Jansson <srte@webrtc.org> Reviewed-by: Evan Shrubsole <eshr@google.com> Reviewed-by: Åsa Persson <asapersson@webrtc.org> Commit-Queue: Erik Språng <sprang@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30437}
2020-01-31 13:51:12 +01:00
"../../modules/video_coding:video_coding_utility",
Make rtc_software_fallback_wrappers target visible. Need to depend on them from Chromium. Bug: webrtc:7925 Change-Id: Iea1bb3b937c602920bfd87f885c87c790ac7bc17 Reviewed-on: https://webrtc-review.googlesource.com/82061 Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23580}
2018-06-12 11:15:56 +02:00
"../../rtc_base:checks",
Move event_tracer out of rtc_base_approved Bug: webrtc:9838 Change-Id: Ic3c424729b5edd3e378c4195afe33ae5c88ad491 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259312 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36637}
2022-04-19 17:47:13 +02:00
"../../rtc_base:event_tracer",
Remove //rtc_base:logging from public deps Bug: webrtc:8603 Change-Id: I2704da8618f88032adac7ae9eb2a0f47fce4a836 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257908 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Auto-Submit: Florent Castelli <orphis@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36443}
2022-04-04 15:06:30 +02:00
"../../rtc_base:logging",
Encoder type agnostic resolution based fallback WebRTC-Video-EncoderFallbackSettings/resolution_threshold_px:X sets resolution threshold to switch from primary to fallback encoder. When the field trial is present, VP8-specific resolution based fallback settings, provided by WebRTC-VP8-Forced-Fallback-Encoder-v2, are ignored. Bug: none Change-Id: I8f2e28438547f3896c7fc288ed6634720328f3a0 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/314760 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Commit-Queue: Sergey Silkin <ssilkin@webrtc.org> Reviewed-by: Åsa Persson <asapersson@webrtc.org> Cr-Commit-Position: refs/heads/main@{#40526}
2023-08-04 13:59:43 +02:00
"../../rtc_base/experiments:field_trial_parser",
Export symbols needed by the Chromium component build (part 8). This CL uses RTC_EXPORT (defined in rtc_base/system/rtc_export.h) to mark WebRTC symbols as visible from a shared library, this doesn't mean these symbols are part of the public API (please continue to refer to [1] for info about what is considered public WebRTC API). [1] - https://webrtc.googlesource.com/src/+/HEAD/native-api.md Bug: webrtc:9419 Change-Id: Ib2c29054b2ae008f5291bd3b762a504b18534326 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/130513 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27410}
2019-04-02 11:33:59 +02:00
"../../rtc_base/system:rtc_export",
Add fallback histograms for VideoDecoderSoftwareFallbackWrapper Track the number of samples that are decoded until a fallback to software decoder happens. Bug: chromium:1061376 Change-Id: Ida3ae94034ec83a6d28001cb7be343b8b99b99c3 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170468 Commit-Queue: Johannes Kron <kron@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30814}
2020-03-17 10:01:43 +01:00
"../../system_wrappers:metrics",
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2. This is a follow-up to https://webrtc-review.googlesource.com/c/src/+/106280. This time the whole code base is covered. Some files may have not been fixed though, whenever the IWYU tool was breaking the build. Bug: webrtc:8311 Change-Id: I2c31f552a87e887d33931d46e87b6208b1e483ef Reviewed-on: https://webrtc-review.googlesource.com/c/111965 Commit-Queue: Yves Gerey <yvesg@google.com> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25830}
2018-11-28 16:47:49 +01:00
"../video:encoded_image",
Make rtc_software_fallback_wrappers target visible. Need to depend on them from Chromium. Bug: webrtc:7925 Change-Id: Iea1bb3b937c602920bfd87f885c87c790ac7bc17 Reviewed-on: https://webrtc-review.googlesource.com/82061 Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23580}
2018-06-12 11:15:56 +02:00
"../video:video_bitrate_allocation",
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2. This is a follow-up to https://webrtc-review.googlesource.com/c/src/+/106280. This time the whole code base is covered. Some files may have not been fixed though, whenever the IWYU tool was breaking the build. Bug: webrtc:8311 Change-Id: I2c31f552a87e887d33931d46e87b6208b1e483ef Reviewed-on: https://webrtc-review.googlesource.com/c/111965 Commit-Queue: Yves Gerey <yvesg@google.com> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25830}
2018-11-28 16:47:49 +01:00
"../video:video_frame",
Apply include-cleaner to api/video_codecs Bug: webrtc:42226242 Change-Id: I7292811f782ec9a6710c84b1fc36e42ae7ea2c17 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/359840 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Dor Hen <dorhen@meta.com> Cr-Commit-Position: refs/heads/main@{#42802}
2024-08-19 01:13:31 -07:00
"../video:video_frame_type",
Prepare for splitting the api/video:video_frames build rule. This change is part of a change to break the dependency between "api:rtp_headers" and "api/video:video_frame". It does so by first creating an empty "api/video:video_rtp_headers" build rule so that downstream projects can be fixed before moving the source files. Bug: webrtc:10668 Change-Id: I81aa6edfef3639b457a40aa93de048e62cbfd8ef Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/140291 Commit-Queue: Chen Xing <chxg@google.com> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28209}
2019-06-10 12:59:38 +02:00
"../video:video_rtp_headers",
Replace std::string::find() == 0 with absl::StartsWith (part 2). This CL has been generated using clang-tidy [1] except for changes to BUILD.gn files. [1] - https://clang.llvm.org/extra/clang-tidy/checks/abseil-string-find-startswith.html Bug: None Change-Id: Ibf75601065a53bde28623b8eef57bec067235640 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/172586 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30984}
2020-04-01 13:43:08 +02:00
"//third_party/abseil-cpp/absl/strings",
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2. This is a follow-up to https://webrtc-review.googlesource.com/c/src/+/106280. This time the whole code base is covered. Some files may have not been fixed though, whenever the IWYU tool was breaking the build. Bug: webrtc:8311 Change-Id: I2c31f552a87e887d33931d46e87b6208b1e483ef Reviewed-on: https://webrtc-review.googlesource.com/c/111965 Commit-Queue: Yves Gerey <yvesg@google.com> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25830}
2018-11-28 16:47:49 +01:00
"//third_party/abseil-cpp/absl/types:optional",
Make rtc_software_fallback_wrappers target visible. Need to depend on them from Chromium. Bug: webrtc:7925 Change-Id: Iea1bb3b937c602920bfd87f885c87c790ac7bc17 Reviewed-on: https://webrtc-review.googlesource.com/82061 Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23580}
2018-06-12 11:15:56 +02:00
]
}
Reference in New Issue Copy Permalink