admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
webrtc_m130/sdk/BUILD.gn

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

1225 lines
44 KiB
Plaintext
Raw Normal View History

Build dynamic iOS SDK. - Places most ObjC code into webrtc/sdk/objc instead. - New gyp targets to build, strip and export symbols for dylib. - Removes old script used to generate dylib. BUG= Review URL: https://codereview.webrtc.org/1903663002 Cr-Commit-Position: refs/heads/master@{#12524}
2016-04-27 01:54:20 -07:00
# Copyright 2016 The WebRTC project authors. All Rights Reserved.
#
# Use of this source code is governed by a BSD-style license
# that can be found in the LICENSE file in the root of the source
# tree. An additional intellectual property rights grant can be found
# in the file PATENTS. All contributing project authors may
# be found in the AUTHORS file in the root of the source tree.
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
import("../webrtc.gni")
[GN] Add rtc_sdk_framework_objc target to GN The build artifacts don't look completely identical to the ones generated by the GYP targets, but manual review shows the same symbols are exported. On iOS, the version generated by the GN follows convention, including a "Headers" directory, and the .modulemap file. I think this is preferred over the gyp version. BUG=webrtc:6320 NOTRY=True TESTED=Run AppRTCDemo on iOS + Mac and verified with nm that they export the same symbols. Review-Url: https://codereview.webrtc.org/2340633003 Cr-Commit-Position: refs/heads/master@{#14228}
2016-09-15 04:30:18 -07:00
if (is_ios) {
import("//build/config/ios/rules.gni")
Enable more unittests on iOS, and disable those that fail on simulator Tests enabled: * modules_unittests * ortc_unittests * rtc_media_unittests * rtc_unittests * video_capture_tests * video_engine_tests BUG=webrtc:5566,webrtc:4752,webrtc:5568,webrtc:5569 Review-Url: https://codereview.webrtc.org/2938193002 Cr-Commit-Position: refs/heads/master@{#18710}
2017-06-22 01:47:20 -07:00
import("//build/config/ios/ios_sdk.gni")
[GN] Add rtc_sdk_framework_objc target to GN The build artifacts don't look completely identical to the ones generated by the GYP targets, but manual review shows the same symbols are exported. On iOS, the version generated by the GN follows convention, including a "Headers" directory, and the .modulemap file. I think this is preferred over the gyp version. BUG=webrtc:6320 NOTRY=True TESTED=Run AppRTCDemo on iOS + Mac and verified with nm that they export the same symbols. Review-Url: https://codereview.webrtc.org/2340633003 Cr-Commit-Position: refs/heads/master@{#14228}
2016-09-15 04:30:18 -07:00
}
Build dynamic iOS SDK. - Places most ObjC code into webrtc/sdk/objc instead. - New gyp targets to build, strip and export symbols for dylib. - Removes old script used to generate dylib. BUG= Review URL: https://codereview.webrtc.org/1903663002 Cr-Commit-Position: refs/heads/master@{#12524}
2016-04-27 01:54:20 -07:00
Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2911053002/ ) Reason for revert: Take three of relanding this after all internal issues have been resolved. Original issue's description: > Revert of Split iOS sdk in to separate targets (patchset #3 id:320001 of https://codereview.webrtc.org/2893843003/ ) > > Reason for revert: > Breaks downstream project. > > Original issue's description: > > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2893593002/ ) > > > > Reason for revert: > > Take two of fixing downstream issues? > > > > Original issue's description: > > > Revert of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890733003/ ) > > > > > > Reason for revert: > > > Still problems with downstream projects > > > > > > Original issue's description: > > > > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890513002/ ) > > > > > > > > Reason for revert: > > > > Fixing downstream breakages > > > > > > > > Original issue's description: > > > > > Revert of Split iOS sdk in to separate targets (patchset #13 id:280001 of https://codereview.webrtc.org/2862543002/ ) > > > > > > > > > > Reason for revert: > > > > > Breaking downstream projects. > > > > > > > > > > Original issue's description: > > > > > > Split iOS sdk in to separate targets > > > > > > > > > > > > This CL splits the iOS sdk into separate static libraries for video, > > > > > > audio, ui, common, and peerconnection-related code. This will in the > > > > > > future make it easier to compile WebRTC without unneeded components. > > > > > > > > > > > > BUG=webrtc:4867 > > > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2862543002 > > > > > > Cr-Commit-Position: refs/heads/master@{#18166} > > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/52c83fe7102f566cf35a7533092873d58b38f426 > > > > > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,kthelgason@webrtc.org > > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > > NOPRESUBMIT=true > > > > > NOTREECHECKS=true > > > > > NOTRY=true > > > > > BUG=webrtc:4867 > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2890513002 > > > > > Cr-Commit-Position: refs/heads/master@{#18170} > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/9756238084707787f735e1294e896e462e459717 > > > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > NOPRESUBMIT=true > > > > NOTREECHECKS=true > > > > NOTRY=true > > > > BUG=webrtc:4867 > > > > > > > > Review-Url: https://codereview.webrtc.org/2890733003 > > > > Cr-Commit-Position: refs/heads/master@{#18174} > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/d51e042492bedd057bc0cac7828979d5c7369cea > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > NOPRESUBMIT=true > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG=webrtc:4867 > > > > > > Review-Url: https://codereview.webrtc.org/2893593002 > > > Cr-Commit-Position: refs/heads/master@{#18182} > > > Committed: https://chromium.googlesource.com/external/webrtc/+/37144b214e2baf62ecb262ab878dde8c59cdd6a3 > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=webrtc:4867 > > > > Review-Url: https://codereview.webrtc.org/2893843003 > > Cr-Commit-Position: refs/heads/master@{#18303} > > Committed: https://chromium.googlesource.com/external/webrtc/+/580c3522d294c877adfe555048c675bd8d166657 > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org,kthelgason@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:4867 > > Review-Url: https://codereview.webrtc.org/2911053002 > Cr-Commit-Position: refs/heads/master@{#18309} > Committed: https://chromium.googlesource.com/external/webrtc/+/af5c05540cc8208f682cafe88c5c16a505479196 TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org,mbonadei@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4867 Review-Url: https://codereview.webrtc.org/2913753003 Cr-Commit-Position: refs/heads/master@{#18319}
2017-05-30 01:48:47 -07:00
declare_args() {
# Determine whether or not to include metal rendering
rtc_use_metal_rendering = is_mac || (is_ios && current_cpu == "arm64")
}
GN: New conventions, default target and refactorings Introduce a convention on categorizing GN targets: 1. Production code 2. Tests 3. Examples 4. Tools The first two have targets spread out all over the tree, while the latter are isolated to examples/ and tools/ directories. Another new convention: Each directory's BUILD.gn file shall contain a target named similar to the directory name. This target shall contain the 'most common' production code, i.e. so that most consumers of the directory can depend on only the directory (which implicitly means that target in GN). //webrtc:webrtc_tests is changed to depend on all WebRTC tests. From now on, it's necessary to add new test targets to this dependency tree in order to get them compiled. Two new group targets are created: //webrtc/modules/audio_coding:audio_coding_tests //webrtc/modules/audio_processing:audio_processing_tests to reduce the long list of tests in //webrtc:webrtc_tests. Visibility on //webrtc:webrtc and //webrtc:webrtc_tests is restricted to the root target, to avoid circular dependencies due to the monolithic property of these targets (a problem we've had in the past). The 'root' target at the top level is renamed to 'default', which means GN will build this target instead of _all_ generated targets (see https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/faq.md#Can-I-control-what-targets-are-built-by-default). This target now depends on everything we want to build, meaning all targets now explicitly needs to be wired up from the root target in order to get build. Having this, the number of compiled objects on Android is decreased from 8855 to 6276. It also gives us better control over our build. BUG=webrtc:6440 TESTED=git cl try --clobber NOTRY=True Review-Url: https://codereview.webrtc.org/2441383002 Cr-Commit-Position: refs/heads/master@{#14821}
2016-10-28 05:44:03 -07:00
group("sdk") {
Enable libjingle_peerconnection_datachannelonly_so target. This change also wires up the rest of the production code in webrtc/sdk/android to be built when the directory is a dependency. BUG=webrtc:7613 NOTRY=True Change-Id: Ideda181970a5a570c3f8148b033e471e926243d1 Reviewed-on: https://chromium-review.googlesource.com/548038 Reviewed-by: Zhi Huang <zhihuang@webrtc.org> Commit-Queue: Henrik Kjellander <kjellander@webrtc.org> Cr-Commit-Position: refs/heads/master@{#18791}
2017-06-27 08:56:46 +02:00
public_deps = []
if (!build_with_chromium) {
if (is_android) {
public_deps += [ "android" ]
}
if (is_ios) {
Rename all objc targets to be suffixed for consistency BUG=webrtc:6412 Review-Url: https://codereview.webrtc.org/3001023003 Cr-Commit-Position: refs/heads/master@{#19489}
2017-08-24 05:43:45 -07:00
public_deps += [ ":framework_objc" ]
Enable libjingle_peerconnection_datachannelonly_so target. This change also wires up the rest of the production code in webrtc/sdk/android to be built when the directory is a dependency. BUG=webrtc:7613 NOTRY=True Change-Id: Ideda181970a5a570c3f8148b033e471e926243d1 Reviewed-on: https://chromium-review.googlesource.com/548038 Reviewed-by: Zhi Huang <zhihuang@webrtc.org> Commit-Queue: Henrik Kjellander <kjellander@webrtc.org> Cr-Commit-Position: refs/heads/master@{#18791}
2017-06-27 08:56:46 +02:00
}
GN: New conventions, default target and refactorings Introduce a convention on categorizing GN targets: 1. Production code 2. Tests 3. Examples 4. Tools The first two have targets spread out all over the tree, while the latter are isolated to examples/ and tools/ directories. Another new convention: Each directory's BUILD.gn file shall contain a target named similar to the directory name. This target shall contain the 'most common' production code, i.e. so that most consumers of the directory can depend on only the directory (which implicitly means that target in GN). //webrtc:webrtc_tests is changed to depend on all WebRTC tests. From now on, it's necessary to add new test targets to this dependency tree in order to get them compiled. Two new group targets are created: //webrtc/modules/audio_coding:audio_coding_tests //webrtc/modules/audio_processing:audio_processing_tests to reduce the long list of tests in //webrtc:webrtc_tests. Visibility on //webrtc:webrtc and //webrtc:webrtc_tests is restricted to the root target, to avoid circular dependencies due to the monolithic property of these targets (a problem we've had in the past). The 'root' target at the top level is renamed to 'default', which means GN will build this target instead of _all_ generated targets (see https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/faq.md#Can-I-control-what-targets-are-built-by-default). This target now depends on everything we want to build, meaning all targets now explicitly needs to be wired up from the root target in order to get build. Having this, the number of compiled objects on Android is decreased from 8855 to 6276. It also gives us better control over our build. BUG=webrtc:6440 TESTED=git cl try --clobber NOTRY=True Review-Url: https://codereview.webrtc.org/2441383002 Cr-Commit-Position: refs/heads/master@{#14821}
2016-10-28 05:44:03 -07:00
}
}
Bump mac deployment target to 10.9 BUG=webrtc:6431 Review-Url: https://codereview.webrtc.org/2488943002 Cr-Commit-Position: refs/heads/master@{#15004}
2016-11-09 07:44:27 -08:00
if (is_ios || is_mac) {
Rename all objc targets to be suffixed for consistency BUG=webrtc:6412 Review-Url: https://codereview.webrtc.org/3001023003 Cr-Commit-Position: refs/heads/master@{#19489}
2017-08-24 05:43:45 -07:00
config("common_config_objc") {
Fix iOS GN build and cleanup system_wrappers Compile fixes for GN on iOS that finally gets our bots green. Changes to system_wrappers: * Updated to only use inclusive sources for maintainability * Add a few missing GN headers. * Cleanup GYP hack for atomic32_mac.cc * Renamed changes sources to avoid problems with GYP/GN file suffix rules: - atomic32_mac.cc -> atomic32_darwin.cc - atomic32_posix.cc -> atomic32_non_darwin_unix.cc See https://code.google.com/p/chromium/codesearch#chromium/src/build/config/BUILDCONFIG.gn&l=325 for details on which extensions can/cannot be used. BUG=webrtc:5586 NOTRY=True Review-Url: https://codereview.webrtc.org/1999723002 Cr-Commit-Position: refs/heads/master@{#12897}
2016-05-25 11:37:11 -07:00
include_dirs = [
"objc/Framework/Classes",
Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2911053002/ ) Reason for revert: Take three of relanding this after all internal issues have been resolved. Original issue's description: > Revert of Split iOS sdk in to separate targets (patchset #3 id:320001 of https://codereview.webrtc.org/2893843003/ ) > > Reason for revert: > Breaks downstream project. > > Original issue's description: > > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2893593002/ ) > > > > Reason for revert: > > Take two of fixing downstream issues? > > > > Original issue's description: > > > Revert of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890733003/ ) > > > > > > Reason for revert: > > > Still problems with downstream projects > > > > > > Original issue's description: > > > > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890513002/ ) > > > > > > > > Reason for revert: > > > > Fixing downstream breakages > > > > > > > > Original issue's description: > > > > > Revert of Split iOS sdk in to separate targets (patchset #13 id:280001 of https://codereview.webrtc.org/2862543002/ ) > > > > > > > > > > Reason for revert: > > > > > Breaking downstream projects. > > > > > > > > > > Original issue's description: > > > > > > Split iOS sdk in to separate targets > > > > > > > > > > > > This CL splits the iOS sdk into separate static libraries for video, > > > > > > audio, ui, common, and peerconnection-related code. This will in the > > > > > > future make it easier to compile WebRTC without unneeded components. > > > > > > > > > > > > BUG=webrtc:4867 > > > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2862543002 > > > > > > Cr-Commit-Position: refs/heads/master@{#18166} > > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/52c83fe7102f566cf35a7533092873d58b38f426 > > > > > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,kthelgason@webrtc.org > > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > > NOPRESUBMIT=true > > > > > NOTREECHECKS=true > > > > > NOTRY=true > > > > > BUG=webrtc:4867 > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2890513002 > > > > > Cr-Commit-Position: refs/heads/master@{#18170} > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/9756238084707787f735e1294e896e462e459717 > > > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > NOPRESUBMIT=true > > > > NOTREECHECKS=true > > > > NOTRY=true > > > > BUG=webrtc:4867 > > > > > > > > Review-Url: https://codereview.webrtc.org/2890733003 > > > > Cr-Commit-Position: refs/heads/master@{#18174} > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/d51e042492bedd057bc0cac7828979d5c7369cea > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > NOPRESUBMIT=true > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG=webrtc:4867 > > > > > > Review-Url: https://codereview.webrtc.org/2893593002 > > > Cr-Commit-Position: refs/heads/master@{#18182} > > > Committed: https://chromium.googlesource.com/external/webrtc/+/37144b214e2baf62ecb262ab878dde8c59cdd6a3 > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=webrtc:4867 > > > > Review-Url: https://codereview.webrtc.org/2893843003 > > Cr-Commit-Position: refs/heads/master@{#18303} > > Committed: https://chromium.googlesource.com/external/webrtc/+/580c3522d294c877adfe555048c675bd8d166657 > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org,kthelgason@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:4867 > > Review-Url: https://codereview.webrtc.org/2911053002 > Cr-Commit-Position: refs/heads/master@{#18309} > Committed: https://chromium.googlesource.com/external/webrtc/+/af5c05540cc8208f682cafe88c5c16a505479196 TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org,mbonadei@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4867 Review-Url: https://codereview.webrtc.org/2913753003 Cr-Commit-Position: refs/heads/master@{#18319}
2017-05-30 01:48:47 -07:00
"objc/Framework/Classes/Audio",
"objc/Framework/Classes/Common",
"objc/Framework/Classes/Metal",
"objc/Framework/Classes/PeerConnection",
"objc/Framework/Classes/UI",
"objc/Framework/Classes/Video",
"objc/Framework/Classes/VideoToolbox",
Fix iOS GN build and cleanup system_wrappers Compile fixes for GN on iOS that finally gets our bots green. Changes to system_wrappers: * Updated to only use inclusive sources for maintainability * Add a few missing GN headers. * Cleanup GYP hack for atomic32_mac.cc * Renamed changes sources to avoid problems with GYP/GN file suffix rules: - atomic32_mac.cc -> atomic32_darwin.cc - atomic32_posix.cc -> atomic32_non_darwin_unix.cc See https://code.google.com/p/chromium/codesearch#chromium/src/build/config/BUILDCONFIG.gn&l=325 for details on which extensions can/cannot be used. BUG=webrtc:5586 NOTRY=True Review-Url: https://codereview.webrtc.org/1999723002 Cr-Commit-Position: refs/heads/master@{#12897}
2016-05-25 11:37:11 -07:00
"objc/Framework/Headers",
]
Reenable some supressed warnings for the objc SDK. Bug: webrtc:8441 Change-Id: I6b427dfc1fe275e274d042766e0850628cf19994 Reviewed-on: https://webrtc-review.googlesource.com/15000 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20425}
2017-10-24 15:28:51 +02:00
cflags = [
"-Wstrict-overflow",
"-Wmissing-field-initializers",
]
Fix iOS GN build and cleanup system_wrappers Compile fixes for GN on iOS that finally gets our bots green. Changes to system_wrappers: * Updated to only use inclusive sources for maintainability * Add a few missing GN headers. * Cleanup GYP hack for atomic32_mac.cc * Renamed changes sources to avoid problems with GYP/GN file suffix rules: - atomic32_mac.cc -> atomic32_darwin.cc - atomic32_posix.cc -> atomic32_non_darwin_unix.cc See https://code.google.com/p/chromium/codesearch#chromium/src/build/config/BUILDCONFIG.gn&l=325 for details on which extensions can/cannot be used. BUG=webrtc:5586 NOTRY=True Review-Url: https://codereview.webrtc.org/1999723002 Cr-Commit-Position: refs/heads/master@{#12897}
2016-05-25 11:37:11 -07:00
}
Broadcast extension for AppRTCMobile on iOS This provides an environment for testing out using WebRTC from an iOS extension. It implements a ReplayKit broadcast extension for live streaming games and screensharing. The extension is only supported on iOS 11+ and is guarded by a build flag. Bug: webrtc:9335 Change-Id: Id218d6c73ef7599f5953c5a1e0e62e5d0dc4f10b Reviewed-on: https://webrtc-review.googlesource.com/80000 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23504}
2018-06-04 10:24:37 +02:00
config("used_from_extension") {
if (is_ios && rtc_apprtcmobile_broadcast_extension) {
cflags = [ "-fapplication-extension" ]
}
}
Rename all objc targets to be suffixed for consistency BUG=webrtc:6412 Review-Url: https://codereview.webrtc.org/3001023003 Cr-Commit-Position: refs/heads/master@{#19489}
2017-08-24 05:43:45 -07:00
rtc_static_library("common_objc") {
Change visibility of some build targets that are publicly used. Bug: None Change-Id: I9b0dc56364648ac4d4fa4b8bb67af44700621b24 Reviewed-on: https://webrtc-review.googlesource.com/93282 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24256}
2018-08-09 10:54:40 +02:00
visibility = [ "*" ]
Build dynamic iOS SDK. - Places most ObjC code into webrtc/sdk/objc instead. - New gyp targets to build, strip and export symbols for dylib. - Removes old script used to generate dylib. BUG= Review URL: https://codereview.webrtc.org/1903663002 Cr-Commit-Position: refs/heads/master@{#12524}
2016-04-27 01:54:20 -07:00
sources = [
Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2911053002/ ) Reason for revert: Take three of relanding this after all internal issues have been resolved. Original issue's description: > Revert of Split iOS sdk in to separate targets (patchset #3 id:320001 of https://codereview.webrtc.org/2893843003/ ) > > Reason for revert: > Breaks downstream project. > > Original issue's description: > > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2893593002/ ) > > > > Reason for revert: > > Take two of fixing downstream issues? > > > > Original issue's description: > > > Revert of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890733003/ ) > > > > > > Reason for revert: > > > Still problems with downstream projects > > > > > > Original issue's description: > > > > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890513002/ ) > > > > > > > > Reason for revert: > > > > Fixing downstream breakages > > > > > > > > Original issue's description: > > > > > Revert of Split iOS sdk in to separate targets (patchset #13 id:280001 of https://codereview.webrtc.org/2862543002/ ) > > > > > > > > > > Reason for revert: > > > > > Breaking downstream projects. > > > > > > > > > > Original issue's description: > > > > > > Split iOS sdk in to separate targets > > > > > > > > > > > > This CL splits the iOS sdk into separate static libraries for video, > > > > > > audio, ui, common, and peerconnection-related code. This will in the > > > > > > future make it easier to compile WebRTC without unneeded components. > > > > > > > > > > > > BUG=webrtc:4867 > > > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2862543002 > > > > > > Cr-Commit-Position: refs/heads/master@{#18166} > > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/52c83fe7102f566cf35a7533092873d58b38f426 > > > > > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,kthelgason@webrtc.org > > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > > NOPRESUBMIT=true > > > > > NOTREECHECKS=true > > > > > NOTRY=true > > > > > BUG=webrtc:4867 > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2890513002 > > > > > Cr-Commit-Position: refs/heads/master@{#18170} > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/9756238084707787f735e1294e896e462e459717 > > > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > NOPRESUBMIT=true > > > > NOTREECHECKS=true > > > > NOTRY=true > > > > BUG=webrtc:4867 > > > > > > > > Review-Url: https://codereview.webrtc.org/2890733003 > > > > Cr-Commit-Position: refs/heads/master@{#18174} > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/d51e042492bedd057bc0cac7828979d5c7369cea > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > NOPRESUBMIT=true > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG=webrtc:4867 > > > > > > Review-Url: https://codereview.webrtc.org/2893593002 > > > Cr-Commit-Position: refs/heads/master@{#18182} > > > Committed: https://chromium.googlesource.com/external/webrtc/+/37144b214e2baf62ecb262ab878dde8c59cdd6a3 > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=webrtc:4867 > > > > Review-Url: https://codereview.webrtc.org/2893843003 > > Cr-Commit-Position: refs/heads/master@{#18303} > > Committed: https://chromium.googlesource.com/external/webrtc/+/580c3522d294c877adfe555048c675bd8d166657 > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org,kthelgason@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:4867 > > Review-Url: https://codereview.webrtc.org/2911053002 > Cr-Commit-Position: refs/heads/master@{#18309} > Committed: https://chromium.googlesource.com/external/webrtc/+/af5c05540cc8208f682cafe88c5c16a505479196 TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org,mbonadei@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4867 Review-Url: https://codereview.webrtc.org/2913753003 Cr-Commit-Position: refs/heads/master@{#18319}
2017-05-30 01:48:47 -07:00
"objc/Framework/Classes/Common/NSString+StdString.h",
"objc/Framework/Classes/Common/NSString+StdString.mm",
"objc/Framework/Classes/Common/RTCDispatcher+Private.h",
"objc/Framework/Classes/Common/RTCDispatcher.m",
"objc/Framework/Classes/Common/RTCFieldTrials.mm",
"objc/Framework/Classes/Common/RTCLogging.mm",
Access UIApplication on main thread Track UIApplication applicationState changes from a C++ class. Uses NSNotificationCenter to access changes on the main thread and exposes a local variable that can be checked from any thread. This fixes a runtime warning on iOS 11 beta. My Objective-C++ is a little rusty so please check if this follows the conventions for C++ code in the project. It also changes the interface exposed by RTCUIApplication.h, not sure if that has impact on any public APIs that needs to be documented somewhere? Bug: webrtc:7773 Change-Id: I9c8ba090ef9f28d812114026a906cef742192c39 Reviewed-on: https://chromium-review.googlesource.com/527442 Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Kári Tristan Helgason <kthelgason@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#18558}
2017-06-12 14:16:20 +02:00
"objc/Framework/Classes/Common/RTCUIApplicationStatusObserver.h",
"objc/Framework/Classes/Common/RTCUIApplicationStatusObserver.m",
Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2911053002/ ) Reason for revert: Take three of relanding this after all internal issues have been resolved. Original issue's description: > Revert of Split iOS sdk in to separate targets (patchset #3 id:320001 of https://codereview.webrtc.org/2893843003/ ) > > Reason for revert: > Breaks downstream project. > > Original issue's description: > > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2893593002/ ) > > > > Reason for revert: > > Take two of fixing downstream issues? > > > > Original issue's description: > > > Revert of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890733003/ ) > > > > > > Reason for revert: > > > Still problems with downstream projects > > > > > > Original issue's description: > > > > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890513002/ ) > > > > > > > > Reason for revert: > > > > Fixing downstream breakages > > > > > > > > Original issue's description: > > > > > Revert of Split iOS sdk in to separate targets (patchset #13 id:280001 of https://codereview.webrtc.org/2862543002/ ) > > > > > > > > > > Reason for revert: > > > > > Breaking downstream projects. > > > > > > > > > > Original issue's description: > > > > > > Split iOS sdk in to separate targets > > > > > > > > > > > > This CL splits the iOS sdk into separate static libraries for video, > > > > > > audio, ui, common, and peerconnection-related code. This will in the > > > > > > future make it easier to compile WebRTC without unneeded components. > > > > > > > > > > > > BUG=webrtc:4867 > > > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2862543002 > > > > > > Cr-Commit-Position: refs/heads/master@{#18166} > > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/52c83fe7102f566cf35a7533092873d58b38f426 > > > > > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,kthelgason@webrtc.org > > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > > NOPRESUBMIT=true > > > > > NOTREECHECKS=true > > > > > NOTRY=true > > > > > BUG=webrtc:4867 > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2890513002 > > > > > Cr-Commit-Position: refs/heads/master@{#18170} > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/9756238084707787f735e1294e896e462e459717 > > > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > NOPRESUBMIT=true > > > > NOTREECHECKS=true > > > > NOTRY=true > > > > BUG=webrtc:4867 > > > > > > > > Review-Url: https://codereview.webrtc.org/2890733003 > > > > Cr-Commit-Position: refs/heads/master@{#18174} > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/d51e042492bedd057bc0cac7828979d5c7369cea > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > NOPRESUBMIT=true > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG=webrtc:4867 > > > > > > Review-Url: https://codereview.webrtc.org/2893593002 > > > Cr-Commit-Position: refs/heads/master@{#18182} > > > Committed: https://chromium.googlesource.com/external/webrtc/+/37144b214e2baf62ecb262ab878dde8c59cdd6a3 > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=webrtc:4867 > > > > Review-Url: https://codereview.webrtc.org/2893843003 > > Cr-Commit-Position: refs/heads/master@{#18303} > > Committed: https://chromium.googlesource.com/external/webrtc/+/580c3522d294c877adfe555048c675bd8d166657 > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org,kthelgason@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:4867 > > Review-Url: https://codereview.webrtc.org/2911053002 > Cr-Commit-Position: refs/heads/master@{#18309} > Committed: https://chromium.googlesource.com/external/webrtc/+/af5c05540cc8208f682cafe88c5c16a505479196 TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org,mbonadei@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4867 Review-Url: https://codereview.webrtc.org/2913753003 Cr-Commit-Position: refs/heads/master@{#18319}
2017-05-30 01:48:47 -07:00
"objc/Framework/Classes/Common/helpers.h",
"objc/Framework/Classes/Common/helpers.mm",
Add new class to handle releasing CFTypeRefs. The new class wraps any CoreFoundation Type ref and automatically releases it when it goes out of scope. Conceptually similar to std::unique_ptr. Bug: webrtc:7825 Change-Id: Ie49572b9215fcb5b92b2c0c3e3d52b0b3cf01752 Reviewed-on: https://webrtc-review.googlesource.com/3380 Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20045}
2017-09-28 19:28:52 +02:00
"objc/Framework/Classes/Common/scoped_cftyperef.h",
Build dynamic iOS SDK. - Places most ObjC code into webrtc/sdk/objc instead. - New gyp targets to build, strip and export symbols for dylib. - Removes old script used to generate dylib. BUG= Review URL: https://codereview.webrtc.org/1903663002 Cr-Commit-Position: refs/heads/master@{#12524}
2016-04-27 01:54:20 -07:00
"objc/Framework/Headers/WebRTC/RTCDispatcher.h",
"objc/Framework/Headers/WebRTC/RTCFieldTrials.h",
"objc/Framework/Headers/WebRTC/RTCLogging.h",
"objc/Framework/Headers/WebRTC/RTCMacros.h",
]
iOS/MacOS:Refactor metal rendering by extracting common implementation in separate super class. Included changes: - Fix rendering on iOS to support NV12 and i420 frames - Improve code style - Update build targets - Update tests BUG=webrtc:7079 Review-Url: https://codereview.webrtc.org/2784243003 Cr-Commit-Position: refs/heads/master@{#17923}
2017-04-28 02:14:54 -07:00
Enabling 'gn check' on webrtc/sdk BUG=webrtc:7499 Review-Url: https://codereview.webrtc.org/2818433003 Cr-Commit-Position: refs/heads/master@{#17805}
2017-04-21 00:02:02 -07:00
deps = [
Fix circular dependencies between optional, array_view, and rtc_base. This splits things out of rtc_base and makes dependencies explicit. Bug: webrtc:6828 Change-Id: Id521896c3c43595349021c857bec216e429a0c8d Reviewed-on: https://webrtc-review.googlesource.com/32780 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21264}
2017-12-13 16:05:42 +01:00
"../rtc_base:checks",
Remove remains of webrtc/base All downstream code have been updated to the new location. In PRESUBMIT.py: * Remove webrtc/rtc_base from CPP_BLACKLIST * Add webrtc/rtc_base to LEGACY_API_DIRS Fix some duplicated paths in webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn BUG=webrtc:7634 TBR=kwiberg@webrtc.org Review-Url: https://codereview.webrtc.org/2976293002 Cr-Commit-Position: refs/heads/master@{#19094}
2017-07-19 10:40:47 -07:00
"../rtc_base:rtc_base",
Enabling 'gn check' on webrtc/sdk BUG=webrtc:7499 Review-Url: https://codereview.webrtc.org/2818433003 Cr-Commit-Position: refs/heads/master@{#17805}
2017-04-21 00:02:02 -07:00
]
Broadcast extension for AppRTCMobile on iOS This provides an environment for testing out using WebRTC from an iOS extension. It implements a ReplayKit broadcast extension for live streaming games and screensharing. The extension is only supported on iOS 11+ and is guarded by a build flag. Bug: webrtc:9335 Change-Id: Id218d6c73ef7599f5953c5a1e0e62e5d0dc4f10b Reviewed-on: https://webrtc-review.googlesource.com/80000 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23504}
2018-06-04 10:24:37 +02:00
configs += [
"..:common_objc",
":used_from_extension",
]
Reland of GN: Enable ARC for Mac and iOS in rtc_* templates (patchset #1 id:1 of https://codereview.webrtc.org/2827223003/ ) Reason for revert: Relanding after fixing ARC issue. Original issue's description: > Revert of GN: Enable ARC for Mac and iOS in rtc_* templates (patchset #3 id:40001 of https://codereview.webrtc.org/2781713004/ ) > > Reason for revert: > Breaks mac build > > Original issue's description: > > GN: Enable ARC for Mac and iOS in rtc_* templates > > > > Remove all uses of retain/release and NSAutoreleasePool. > > > > This makes transformation to Bazel easier. > > > > This CL subsumes https://codereview.webrtc.org/2778163002 and depends on https://codereview.webrtc.org/2784483002/ > > > > BUG=webrtc:6412 > > > > Review-Url: https://codereview.webrtc.org/2781713004 > > Cr-Commit-Position: refs/heads/master@{#17780} > > Committed: https://chromium.googlesource.com/external/webrtc/+/6bda02b51dc00401d2a0d04be996ed10e5acac47 > > TBR=kjellander@webrtc.org,magjed@webrtc.org,stefan@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6412 > > Review-Url: https://codereview.webrtc.org/2827223003 > Cr-Commit-Position: refs/heads/master@{#17784} > Committed: https://chromium.googlesource.com/external/webrtc/+/7c8786ae8f2d8481f74b0ab16eb91a8101fe51dc TBR=kjellander@webrtc.org,magjed@webrtc.org,stefan@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6412 Review-Url: https://codereview.webrtc.org/2834273002 Cr-Commit-Position: refs/heads/master@{#17836}
2017-04-24 00:57:16 -07:00
Rename all objc targets to be suffixed for consistency BUG=webrtc:6412 Review-Url: https://codereview.webrtc.org/3001023003 Cr-Commit-Position: refs/heads/master@{#19489}
2017-08-24 05:43:45 -07:00
public_configs = [ ":common_config_objc" ]
iOS/MacOS:Refactor metal rendering by extracting common implementation in separate super class. Included changes: - Fix rendering on iOS to support NV12 and i420 frames - Improve code style - Update build targets - Update tests BUG=webrtc:7079 Review-Url: https://codereview.webrtc.org/2784243003 Cr-Commit-Position: refs/heads/master@{#17923}
2017-04-28 02:14:54 -07:00
GN: Add SDK tests to rtc_unittests. In https://codereview.webrtc.org/2034923003 it was discovered that a test binary rtc_sdk_peerconnection_objc_tests was a dependency to rtc_unittests. Unfortunately gtest doesn't include dependent executables into the same test executable; only libraries (so theses tests weren't run). This CL incorporates those tests into rtc_unittests and does the same changes to the GN build. BUG=webrtc:5949 TESTED=Built and ran rtc_unittests locally on Mac. NOTRY=True Review-Url: https://codereview.webrtc.org/2041743003 Cr-Commit-Position: refs/heads/master@{#13060}
2016-06-08 01:14:15 -07:00
if (is_ios) {
sources += [
Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2911053002/ ) Reason for revert: Take three of relanding this after all internal issues have been resolved. Original issue's description: > Revert of Split iOS sdk in to separate targets (patchset #3 id:320001 of https://codereview.webrtc.org/2893843003/ ) > > Reason for revert: > Breaks downstream project. > > Original issue's description: > > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2893593002/ ) > > > > Reason for revert: > > Take two of fixing downstream issues? > > > > Original issue's description: > > > Revert of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890733003/ ) > > > > > > Reason for revert: > > > Still problems with downstream projects > > > > > > Original issue's description: > > > > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890513002/ ) > > > > > > > > Reason for revert: > > > > Fixing downstream breakages > > > > > > > > Original issue's description: > > > > > Revert of Split iOS sdk in to separate targets (patchset #13 id:280001 of https://codereview.webrtc.org/2862543002/ ) > > > > > > > > > > Reason for revert: > > > > > Breaking downstream projects. > > > > > > > > > > Original issue's description: > > > > > > Split iOS sdk in to separate targets > > > > > > > > > > > > This CL splits the iOS sdk into separate static libraries for video, > > > > > > audio, ui, common, and peerconnection-related code. This will in the > > > > > > future make it easier to compile WebRTC without unneeded components. > > > > > > > > > > > > BUG=webrtc:4867 > > > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2862543002 > > > > > > Cr-Commit-Position: refs/heads/master@{#18166} > > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/52c83fe7102f566cf35a7533092873d58b38f426 > > > > > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,kthelgason@webrtc.org > > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > > NOPRESUBMIT=true > > > > > NOTREECHECKS=true > > > > > NOTRY=true > > > > > BUG=webrtc:4867 > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2890513002 > > > > > Cr-Commit-Position: refs/heads/master@{#18170} > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/9756238084707787f735e1294e896e462e459717 > > > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > NOPRESUBMIT=true > > > > NOTREECHECKS=true > > > > NOTRY=true > > > > BUG=webrtc:4867 > > > > > > > > Review-Url: https://codereview.webrtc.org/2890733003 > > > > Cr-Commit-Position: refs/heads/master@{#18174} > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/d51e042492bedd057bc0cac7828979d5c7369cea > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > NOPRESUBMIT=true > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG=webrtc:4867 > > > > > > Review-Url: https://codereview.webrtc.org/2893593002 > > > Cr-Commit-Position: refs/heads/master@{#18182} > > > Committed: https://chromium.googlesource.com/external/webrtc/+/37144b214e2baf62ecb262ab878dde8c59cdd6a3 > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=webrtc:4867 > > > > Review-Url: https://codereview.webrtc.org/2893843003 > > Cr-Commit-Position: refs/heads/master@{#18303} > > Committed: https://chromium.googlesource.com/external/webrtc/+/580c3522d294c877adfe555048c675bd8d166657 > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org,kthelgason@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:4867 > > Review-Url: https://codereview.webrtc.org/2911053002 > Cr-Commit-Position: refs/heads/master@{#18309} > Committed: https://chromium.googlesource.com/external/webrtc/+/af5c05540cc8208f682cafe88c5c16a505479196 TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org,mbonadei@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4867 Review-Url: https://codereview.webrtc.org/2913753003 Cr-Commit-Position: refs/heads/master@{#18319}
2017-05-30 01:48:47 -07:00
"objc/Framework/Classes/Common/UIDevice+RTCDevice.mm",
Use 15fps for iPhone 4S NOTRY=True BUG= Review-Url: https://codereview.webrtc.org/2188883002 Cr-Commit-Position: refs/heads/master@{#13564}
2016-07-28 14:52:55 -07:00
"objc/Framework/Headers/WebRTC/UIDevice+RTCDevice.h",
GN: Add SDK tests to rtc_unittests. In https://codereview.webrtc.org/2034923003 it was discovered that a test binary rtc_sdk_peerconnection_objc_tests was a dependency to rtc_unittests. Unfortunately gtest doesn't include dependent executables into the same test executable; only libraries (so theses tests weren't run). This CL incorporates those tests into rtc_unittests and does the same changes to the GN build. BUG=webrtc:5949 TESTED=Built and ran rtc_unittests locally on Mac. NOTRY=True Review-Url: https://codereview.webrtc.org/2041743003 Cr-Commit-Position: refs/heads/master@{#13060}
2016-06-08 01:14:15 -07:00
]
iOS/MacOS:Refactor metal rendering by extracting common implementation in separate super class. Included changes: - Fix rendering on iOS to support NV12 and i420 frames - Improve code style - Update build targets - Update tests BUG=webrtc:7079 Review-Url: https://codereview.webrtc.org/2784243003 Cr-Commit-Position: refs/heads/master@{#17923}
2017-04-28 02:14:54 -07:00
}
Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2911053002/ ) Reason for revert: Take three of relanding this after all internal issues have been resolved. Original issue's description: > Revert of Split iOS sdk in to separate targets (patchset #3 id:320001 of https://codereview.webrtc.org/2893843003/ ) > > Reason for revert: > Breaks downstream project. > > Original issue's description: > > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2893593002/ ) > > > > Reason for revert: > > Take two of fixing downstream issues? > > > > Original issue's description: > > > Revert of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890733003/ ) > > > > > > Reason for revert: > > > Still problems with downstream projects > > > > > > Original issue's description: > > > > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890513002/ ) > > > > > > > > Reason for revert: > > > > Fixing downstream breakages > > > > > > > > Original issue's description: > > > > > Revert of Split iOS sdk in to separate targets (patchset #13 id:280001 of https://codereview.webrtc.org/2862543002/ ) > > > > > > > > > > Reason for revert: > > > > > Breaking downstream projects. > > > > > > > > > > Original issue's description: > > > > > > Split iOS sdk in to separate targets > > > > > > > > > > > > This CL splits the iOS sdk into separate static libraries for video, > > > > > > audio, ui, common, and peerconnection-related code. This will in the > > > > > > future make it easier to compile WebRTC without unneeded components. > > > > > > > > > > > > BUG=webrtc:4867 > > > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2862543002 > > > > > > Cr-Commit-Position: refs/heads/master@{#18166} > > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/52c83fe7102f566cf35a7533092873d58b38f426 > > > > > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,kthelgason@webrtc.org > > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > > NOPRESUBMIT=true > > > > > NOTREECHECKS=true > > > > > NOTRY=true > > > > > BUG=webrtc:4867 > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2890513002 > > > > > Cr-Commit-Position: refs/heads/master@{#18170} > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/9756238084707787f735e1294e896e462e459717 > > > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > NOPRESUBMIT=true > > > > NOTREECHECKS=true > > > > NOTRY=true > > > > BUG=webrtc:4867 > > > > > > > > Review-Url: https://codereview.webrtc.org/2890733003 > > > > Cr-Commit-Position: refs/heads/master@{#18174} > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/d51e042492bedd057bc0cac7828979d5c7369cea > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > NOPRESUBMIT=true > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG=webrtc:4867 > > > > > > Review-Url: https://codereview.webrtc.org/2893593002 > > > Cr-Commit-Position: refs/heads/master@{#18182} > > > Committed: https://chromium.googlesource.com/external/webrtc/+/37144b214e2baf62ecb262ab878dde8c59cdd6a3 > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=webrtc:4867 > > > > Review-Url: https://codereview.webrtc.org/2893843003 > > Cr-Commit-Position: refs/heads/master@{#18303} > > Committed: https://chromium.googlesource.com/external/webrtc/+/580c3522d294c877adfe555048c675bd8d166657 > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org,kthelgason@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:4867 > > Review-Url: https://codereview.webrtc.org/2911053002 > Cr-Commit-Position: refs/heads/master@{#18309} > Committed: https://chromium.googlesource.com/external/webrtc/+/af5c05540cc8208f682cafe88c5c16a505479196 TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org,mbonadei@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4867 Review-Url: https://codereview.webrtc.org/2913753003 Cr-Commit-Position: refs/heads/master@{#18319}
2017-05-30 01:48:47 -07:00
if (!build_with_chromium) {
sources += [
Add new Logger to iOS SDK to be able to intercept logs and report them to the appropriate system Bug: webrtc:8695 Change-Id: I4f81529222dcaf3dded1a0ab93fabf5cda1fdef8 Reviewed-on: https://webrtc-review.googlesource.com/37001 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21821}
2018-01-30 15:46:13 +01:00
"objc/Framework/Classes/Common/RTCCallbackLogger.mm",
Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2911053002/ ) Reason for revert: Take three of relanding this after all internal issues have been resolved. Original issue's description: > Revert of Split iOS sdk in to separate targets (patchset #3 id:320001 of https://codereview.webrtc.org/2893843003/ ) > > Reason for revert: > Breaks downstream project. > > Original issue's description: > > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2893593002/ ) > > > > Reason for revert: > > Take two of fixing downstream issues? > > > > Original issue's description: > > > Revert of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890733003/ ) > > > > > > Reason for revert: > > > Still problems with downstream projects > > > > > > Original issue's description: > > > > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890513002/ ) > > > > > > > > Reason for revert: > > > > Fixing downstream breakages > > > > > > > > Original issue's description: > > > > > Revert of Split iOS sdk in to separate targets (patchset #13 id:280001 of https://codereview.webrtc.org/2862543002/ ) > > > > > > > > > > Reason for revert: > > > > > Breaking downstream projects. > > > > > > > > > > Original issue's description: > > > > > > Split iOS sdk in to separate targets > > > > > > > > > > > > This CL splits the iOS sdk into separate static libraries for video, > > > > > > audio, ui, common, and peerconnection-related code. This will in the > > > > > > future make it easier to compile WebRTC without unneeded components. > > > > > > > > > > > > BUG=webrtc:4867 > > > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2862543002 > > > > > > Cr-Commit-Position: refs/heads/master@{#18166} > > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/52c83fe7102f566cf35a7533092873d58b38f426 > > > > > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,kthelgason@webrtc.org > > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > > NOPRESUBMIT=true > > > > > NOTREECHECKS=true > > > > > NOTRY=true > > > > > BUG=webrtc:4867 > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2890513002 > > > > > Cr-Commit-Position: refs/heads/master@{#18170} > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/9756238084707787f735e1294e896e462e459717 > > > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > NOPRESUBMIT=true > > > > NOTREECHECKS=true > > > > NOTRY=true > > > > BUG=webrtc:4867 > > > > > > > > Review-Url: https://codereview.webrtc.org/2890733003 > > > > Cr-Commit-Position: refs/heads/master@{#18174} > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/d51e042492bedd057bc0cac7828979d5c7369cea > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > NOPRESUBMIT=true > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG=webrtc:4867 > > > > > > Review-Url: https://codereview.webrtc.org/2893593002 > > > Cr-Commit-Position: refs/heads/master@{#18182} > > > Committed: https://chromium.googlesource.com/external/webrtc/+/37144b214e2baf62ecb262ab878dde8c59cdd6a3 > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=webrtc:4867 > > > > Review-Url: https://codereview.webrtc.org/2893843003 > > Cr-Commit-Position: refs/heads/master@{#18303} > > Committed: https://chromium.googlesource.com/external/webrtc/+/580c3522d294c877adfe555048c675bd8d166657 > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org,kthelgason@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:4867 > > Review-Url: https://codereview.webrtc.org/2911053002 > Cr-Commit-Position: refs/heads/master@{#18309} > Committed: https://chromium.googlesource.com/external/webrtc/+/af5c05540cc8208f682cafe88c5c16a505479196 TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org,mbonadei@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4867 Review-Url: https://codereview.webrtc.org/2913753003 Cr-Commit-Position: refs/heads/master@{#18319}
2017-05-30 01:48:47 -07:00
"objc/Framework/Classes/Common/RTCFileLogger.mm",
Add new Logger to iOS SDK to be able to intercept logs and report them to the appropriate system Bug: webrtc:8695 Change-Id: I4f81529222dcaf3dded1a0ab93fabf5cda1fdef8 Reviewed-on: https://webrtc-review.googlesource.com/37001 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21821}
2018-01-30 15:46:13 +01:00
"objc/Framework/Headers/WebRTC/RTCCallbackLogger.h",
Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2911053002/ ) Reason for revert: Take three of relanding this after all internal issues have been resolved. Original issue's description: > Revert of Split iOS sdk in to separate targets (patchset #3 id:320001 of https://codereview.webrtc.org/2893843003/ ) > > Reason for revert: > Breaks downstream project. > > Original issue's description: > > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2893593002/ ) > > > > Reason for revert: > > Take two of fixing downstream issues? > > > > Original issue's description: > > > Revert of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890733003/ ) > > > > > > Reason for revert: > > > Still problems with downstream projects > > > > > > Original issue's description: > > > > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890513002/ ) > > > > > > > > Reason for revert: > > > > Fixing downstream breakages > > > > > > > > Original issue's description: > > > > > Revert of Split iOS sdk in to separate targets (patchset #13 id:280001 of https://codereview.webrtc.org/2862543002/ ) > > > > > > > > > > Reason for revert: > > > > > Breaking downstream projects. > > > > > > > > > > Original issue's description: > > > > > > Split iOS sdk in to separate targets > > > > > > > > > > > > This CL splits the iOS sdk into separate static libraries for video, > > > > > > audio, ui, common, and peerconnection-related code. This will in the > > > > > > future make it easier to compile WebRTC without unneeded components. > > > > > > > > > > > > BUG=webrtc:4867 > > > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2862543002 > > > > > > Cr-Commit-Position: refs/heads/master@{#18166} > > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/52c83fe7102f566cf35a7533092873d58b38f426 > > > > > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,kthelgason@webrtc.org > > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > > NOPRESUBMIT=true > > > > > NOTREECHECKS=true > > > > > NOTRY=true > > > > > BUG=webrtc:4867 > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2890513002 > > > > > Cr-Commit-Position: refs/heads/master@{#18170} > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/9756238084707787f735e1294e896e462e459717 > > > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > NOPRESUBMIT=true > > > > NOTREECHECKS=true > > > > NOTRY=true > > > > BUG=webrtc:4867 > > > > > > > > Review-Url: https://codereview.webrtc.org/2890733003 > > > > Cr-Commit-Position: refs/heads/master@{#18174} > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/d51e042492bedd057bc0cac7828979d5c7369cea > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > NOPRESUBMIT=true > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG=webrtc:4867 > > > > > > Review-Url: https://codereview.webrtc.org/2893593002 > > > Cr-Commit-Position: refs/heads/master@{#18182} > > > Committed: https://chromium.googlesource.com/external/webrtc/+/37144b214e2baf62ecb262ab878dde8c59cdd6a3 > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=webrtc:4867 > > > > Review-Url: https://codereview.webrtc.org/2893843003 > > Cr-Commit-Position: refs/heads/master@{#18303} > > Committed: https://chromium.googlesource.com/external/webrtc/+/580c3522d294c877adfe555048c675bd8d166657 > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org,kthelgason@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:4867 > > Review-Url: https://codereview.webrtc.org/2911053002 > Cr-Commit-Position: refs/heads/master@{#18309} > Committed: https://chromium.googlesource.com/external/webrtc/+/af5c05540cc8208f682cafe88c5c16a505479196 TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org,mbonadei@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4867 Review-Url: https://codereview.webrtc.org/2913753003 Cr-Commit-Position: refs/heads/master@{#18319}
2017-05-30 01:48:47 -07:00
"objc/Framework/Headers/WebRTC/RTCFileLogger.h",
]
}
}
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
if (!build_with_chromium) {
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
if (is_ios) {
Moving iOS Audio Device to sdk. This change forks the existing iOS audio device module and audio device from modules/audio_device/ into sdk/objc/Framework. It also updates RTCPeerConnectionFactory to use the forked implementation. The unit tests are re-implemented as XCTests. (was: https://webrtc-review.googlesource.com/c/src/+/67300) Bug: webrtc:9120 Change-Id: I46c09900246f75ca5285aeb38f7b8b295784ffac Reviewed-on: https://webrtc-review.googlesource.com/76741 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Commit-Queue: Peter Hanspers <peterhanspers@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23238}
2018-05-15 10:22:36 +02:00
rtc_static_library("native_api_audio_device_module") {
visibility = [ "*" ]
sources = [
"objc/Framework/Native/api/audio_device_module.h",
"objc/Framework/Native/api/audio_device_module.mm",
]
deps = [
":audio_device",
"../modules/audio_device:audio_device_api",
"../modules/audio_device:audio_device_generic",
"../rtc_base:checks",
"../rtc_base:rtc_base_approved",
"../system_wrappers",
"../system_wrappers:metrics_api",
]
if (is_clang) {
# Suppress warnings from the Chromium Clang plugin
# (bugs.webrtc.org/163).
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
}
}
rtc_source_set("audio_session_observer") {
visibility = [ ":*" ]
sources = [
"objc/Framework/Native/src/audio/audio_session_observer.h",
]
deps = [
"../rtc_base:rtc_base",
]
}
rtc_static_library("audio_device") {
visibility = [ "*" ]
sources = [
"objc/Framework/Native/src/audio/audio_device_ios.h",
"objc/Framework/Native/src/audio/audio_device_ios.mm",
"objc/Framework/Native/src/audio/audio_device_module_ios.h",
"objc/Framework/Native/src/audio/audio_device_module_ios.mm",
"objc/Framework/Native/src/audio/voice_processing_audio_unit.h",
"objc/Framework/Native/src/audio/voice_processing_audio_unit.mm",
]
deps = [
":audio_objc",
":audio_session_observer",
":common_objc",
"../api:array_view",
"../modules/audio_device:audio_device_api",
"../modules/audio_device:audio_device_buffer",
"../modules/audio_device:audio_device_generic",
"../rtc_base:checks",
"../rtc_base:rtc_base",
"../rtc_base/system:fallthrough",
"../sdk:common_objc",
"../system_wrappers:metrics_api",
]
if (is_clang) {
# Suppress warnings from the Chromium Clang plugin
# (bugs.webrtc.org/163).
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
}
}
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
rtc_static_library("audio_objc") {
sources = [
"objc/Framework/Classes/Audio/RTCAudioSession+Configuration.mm",
"objc/Framework/Classes/Audio/RTCAudioSession+Private.h",
"objc/Framework/Classes/Audio/RTCAudioSession.mm",
"objc/Framework/Classes/Audio/RTCAudioSessionConfiguration.m",
Moving iOS Audio Device to sdk. This change forks the existing iOS audio device module and audio device from modules/audio_device/ into sdk/objc/Framework. It also updates RTCPeerConnectionFactory to use the forked implementation. The unit tests are re-implemented as XCTests. (was: https://webrtc-review.googlesource.com/c/src/+/67300) Bug: webrtc:9120 Change-Id: I46c09900246f75ca5285aeb38f7b8b295784ffac Reviewed-on: https://webrtc-review.googlesource.com/76741 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Commit-Queue: Peter Hanspers <peterhanspers@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23238}
2018-05-15 10:22:36 +02:00
"objc/Framework/Classes/Audio/RTCNativeAudioSessionDelegateAdapter.h",
"objc/Framework/Classes/Audio/RTCNativeAudioSessionDelegateAdapter.mm",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
"objc/Framework/Headers/WebRTC/RTCAudioSession.h",
"objc/Framework/Headers/WebRTC/RTCAudioSessionConfiguration.h",
]
Broadcast extension for AppRTCMobile on iOS This provides an environment for testing out using WebRTC from an iOS extension. It implements a ReplayKit broadcast extension for live streaming games and screensharing. The extension is only supported on iOS 11+ and is guarded by a build flag. Bug: webrtc:9335 Change-Id: Id218d6c73ef7599f5953c5a1e0e62e5d0dc4f10b Reviewed-on: https://webrtc-review.googlesource.com/80000 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23504}
2018-06-04 10:24:37 +02:00
configs += [
"..:common_objc",
":used_from_extension",
]
Move RTCAudioSession* files modules/audio_device/ -> sdk/Framework. BUG=NONE Review-Url: https://codereview.webrtc.org/2855023003 Cr-Commit-Position: refs/heads/master@{#18443}
2017-06-05 05:48:47 -07:00
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
public_configs = [ ":common_config_objc" ]
Fix public Obj-C header import. Fixes the Cocoapod. Bug: None Change-Id: If3ace3d01ba111fc83ae18455e8ff1cb5fc7b476 Reviewed-on: https://webrtc-review.googlesource.com/1572 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Sami Kalliomäki <sakal@webrtc.org> Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org> Cr-Commit-Position: refs/heads/master@{#19863}
2017-09-15 14:07:30 +02:00
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
deps = [
Moving iOS Audio Device to sdk. This change forks the existing iOS audio device module and audio device from modules/audio_device/ into sdk/objc/Framework. It also updates RTCPeerConnectionFactory to use the forked implementation. The unit tests are re-implemented as XCTests. (was: https://webrtc-review.googlesource.com/c/src/+/67300) Bug: webrtc:9120 Change-Id: I46c09900246f75ca5285aeb38f7b8b295784ffac Reviewed-on: https://webrtc-review.googlesource.com/76741 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Commit-Queue: Peter Hanspers <peterhanspers@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23238}
2018-05-15 10:22:36 +02:00
":audio_session_observer",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
":common_objc",
"../rtc_base:checks",
Moving iOS Audio Device to sdk. This change forks the existing iOS audio device module and audio device from modules/audio_device/ into sdk/objc/Framework. It also updates RTCPeerConnectionFactory to use the forked implementation. The unit tests are re-implemented as XCTests. (was: https://webrtc-review.googlesource.com/c/src/+/67300) Bug: webrtc:9120 Change-Id: I46c09900246f75ca5285aeb38f7b8b295784ffac Reviewed-on: https://webrtc-review.googlesource.com/76741 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Commit-Queue: Peter Hanspers <peterhanspers@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23238}
2018-05-15 10:22:36 +02:00
"../rtc_base:rtc_base",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
"../rtc_base:rtc_base_approved",
]
Move RTCAudioSession* files modules/audio_device/ -> sdk/Framework. BUG=NONE Review-Url: https://codereview.webrtc.org/2855023003 Cr-Commit-Position: refs/heads/master@{#18443}
2017-06-05 05:48:47 -07:00
}
}
Support building WebRTC without audio and video for IOS. Reorganized the targets in webrtc/sdk/BUILD.gn so that the applications which use WebRTC DataChannel only can depend on the "peerconnection_factory_no_media" instead of "rtc_sdk_objc" to reduce the binary size. Provided a no-media implementation of RTCPeerConnectionFactory using the macro "HAVE_NO_MEDIA". BUG=webrtc:7613 Review-Url: https://codereview.webrtc.org/2944643002 Cr-Commit-Position: refs/heads/master@{#18819}
2017-06-28 14:05:44 -07:00
Fix native api in preparation for native_api example. Add native api conversions for video frames and video renderer. This also requires some changes to sdk/BUILD to avoid cyclic dependencies. Bug: webrtc:8832 Change-Id: Ibf21e63bdcae195dcb61d63f9262e6a8dc4fa790 Reviewed-on: https://webrtc-review.googlesource.com/57142 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22340}
2018-03-07 10:32:03 +01:00
rtc_static_library("videosource_objc") {
Support building WebRTC without audio and video for IOS. Reorganized the targets in webrtc/sdk/BUILD.gn so that the applications which use WebRTC DataChannel only can depend on the "peerconnection_factory_no_media" instead of "rtc_sdk_objc" to reduce the binary size. Provided a no-media implementation of RTCPeerConnectionFactory using the macro "HAVE_NO_MEDIA". BUG=webrtc:7613 Review-Url: https://codereview.webrtc.org/2944643002 Cr-Commit-Position: refs/heads/master@{#18819}
2017-06-28 14:05:44 -07:00
sources = [
Fix native api in preparation for native_api example. Add native api conversions for video frames and video renderer. This also requires some changes to sdk/BUILD to avoid cyclic dependencies. Bug: webrtc:8832 Change-Id: Ibf21e63bdcae195dcb61d63f9262e6a8dc4fa790 Reviewed-on: https://webrtc-review.googlesource.com/57142 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22340}
2018-03-07 10:32:03 +01:00
"objc/Framework/Classes/PeerConnection/RTCVideoSource+Private.h",
"objc/Framework/Classes/PeerConnection/RTCVideoSource.mm",
"objc/Framework/Headers/WebRTC/RTCVideoSource.h",
Support building WebRTC without audio and video for IOS. Reorganized the targets in webrtc/sdk/BUILD.gn so that the applications which use WebRTC DataChannel only can depend on the "peerconnection_factory_no_media" instead of "rtc_sdk_objc" to reduce the binary size. Provided a no-media implementation of RTCPeerConnectionFactory using the macro "HAVE_NO_MEDIA". BUG=webrtc:7613 Review-Url: https://codereview.webrtc.org/2944643002 Cr-Commit-Position: refs/heads/master@{#18819}
2017-06-28 14:05:44 -07:00
]
deps = [
Rename all objc targets to be suffixed for consistency BUG=webrtc:6412 Review-Url: https://codereview.webrtc.org/3001023003 Cr-Commit-Position: refs/heads/master@{#19489}
2017-08-24 05:43:45 -07:00
":common_objc",
Fix native api in preparation for native_api example. Add native api conversions for video frames and video renderer. This also requires some changes to sdk/BUILD to avoid cyclic dependencies. Bug: webrtc:8832 Change-Id: Ibf21e63bdcae195dcb61d63f9262e6a8dc4fa790 Reviewed-on: https://webrtc-review.googlesource.com/57142 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22340}
2018-03-07 10:32:03 +01:00
":mediasource_objc",
":native_video",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
":videoframebuffer_objc",
Support building WebRTC without audio and video for IOS. Reorganized the targets in webrtc/sdk/BUILD.gn so that the applications which use WebRTC DataChannel only can depend on the "peerconnection_factory_no_media" instead of "rtc_sdk_objc" to reduce the binary size. Provided a no-media implementation of RTCPeerConnectionFactory using the macro "HAVE_NO_MEDIA". BUG=webrtc:7613 Review-Url: https://codereview.webrtc.org/2944643002 Cr-Commit-Position: refs/heads/master@{#18819}
2017-06-28 14:05:44 -07:00
"../api:libjingle_peerconnection_api",
New file api/video/BUILD.gn Build targets involving files under api/video/ are moved into this file, from api/BUILD.gn. In addition, drop "_api" part of target names, and move the header file api/videosinkinterface.h to api/video/video_sink_interface.h. Bug: webrtc:9253 Change-Id: I2896d3f063db8dff902bc29738578395b2fcc155 Reviewed-on: https://webrtc-review.googlesource.com/75500 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23207}
2018-05-11 11:15:30 +02:00
"../api/video:video_frame",
"../api/video:video_frame_i420",
Support building WebRTC without audio and video for IOS. Reorganized the targets in webrtc/sdk/BUILD.gn so that the applications which use WebRTC DataChannel only can depend on the "peerconnection_factory_no_media" instead of "rtc_sdk_objc" to reduce the binary size. Provided a no-media implementation of RTCPeerConnectionFactory using the macro "HAVE_NO_MEDIA". BUG=webrtc:7613 Review-Url: https://codereview.webrtc.org/2944643002 Cr-Commit-Position: refs/heads/master@{#18819}
2017-06-28 14:05:44 -07:00
"../common_video",
"../media:rtc_media_base",
Fix circular dependencies between optional, array_view, and rtc_base. This splits things out of rtc_base and makes dependencies explicit. Bug: webrtc:6828 Change-Id: Id521896c3c43595349021c857bec216e429a0c8d Reviewed-on: https://webrtc-review.googlesource.com/32780 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21264}
2017-12-13 16:05:42 +01:00
"../rtc_base:checks",
Remove remains of webrtc/base All downstream code have been updated to the new location. In PRESUBMIT.py: * Remove webrtc/rtc_base from CPP_BLACKLIST * Add webrtc/rtc_base to LEGACY_API_DIRS Fix some duplicated paths in webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn BUG=webrtc:7634 TBR=kwiberg@webrtc.org Review-Url: https://codereview.webrtc.org/2976293002 Cr-Commit-Position: refs/heads/master@{#19094}
2017-07-19 10:40:47 -07:00
"../rtc_base:rtc_base",
Removing $rtc_libyuv_dir and removing useless dependencies on libyuv. This CL removes the following GN variables: rtc_build_libyuv, rtc_libyuv_dir (as requested in webrtc:7906). It also removes some unneeded dependencies on //third_party/libyuv. WebRTC targets were using public_deps to depend on //third_party/libyuv and this created a build graph where targets that were depending on //third_party/libyuv were not declaring the dependency to GN because they were somehow getting it from another target that was exposing //third_party/libyuv header files even if it wasn't directly depending on it. Bug: webrtc:8605, webrtc:7906 Change-Id: If71f7988fd80421dc2ad887cf94c2ac66366c3fb Reviewed-on: https://webrtc-review.googlesource.com/32201 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21275}
2017-12-14 11:24:00 +01:00
"//third_party/libyuv",
Support building WebRTC without audio and video for IOS. Reorganized the targets in webrtc/sdk/BUILD.gn so that the applications which use WebRTC DataChannel only can depend on the "peerconnection_factory_no_media" instead of "rtc_sdk_objc" to reduce the binary size. Provided a no-media implementation of RTCPeerConnectionFactory using the macro "HAVE_NO_MEDIA". BUG=webrtc:7613 Review-Url: https://codereview.webrtc.org/2944643002 Cr-Commit-Position: refs/heads/master@{#18819}
2017-06-28 14:05:44 -07:00
]
Broadcast extension for AppRTCMobile on iOS This provides an environment for testing out using WebRTC from an iOS extension. It implements a ReplayKit broadcast extension for live streaming games and screensharing. The extension is only supported on iOS 11+ and is guarded by a build flag. Bug: webrtc:9335 Change-Id: Id218d6c73ef7599f5953c5a1e0e62e5d0dc4f10b Reviewed-on: https://webrtc-review.googlesource.com/80000 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23504}
2018-06-04 10:24:37 +02:00
configs += [
"..:common_objc",
":used_from_extension",
]
Support building WebRTC without audio and video for IOS. Reorganized the targets in webrtc/sdk/BUILD.gn so that the applications which use WebRTC DataChannel only can depend on the "peerconnection_factory_no_media" instead of "rtc_sdk_objc" to reduce the binary size. Provided a no-media implementation of RTCPeerConnectionFactory using the macro "HAVE_NO_MEDIA". BUG=webrtc:7613 Review-Url: https://codereview.webrtc.org/2944643002 Cr-Commit-Position: refs/heads/master@{#18819}
2017-06-28 14:05:44 -07:00
}
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
rtc_static_library("videoframebuffer_objc") {
Change visibility of some build targets that are publicly used. Bug: None Change-Id: I9b0dc56364648ac4d4fa4b8bb67af44700621b24 Reviewed-on: https://webrtc-review.googlesource.com/93282 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24256}
2018-08-09 10:54:40 +02:00
visibility = [ "*" ]
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
sources = [
"objc/Framework/Classes/PeerConnection/RTCVideoFrame.mm",
"objc/Framework/Classes/Video/RTCCVPixelBuffer.mm",
"objc/Framework/Classes/Video/RTCI420Buffer+Private.h",
"objc/Framework/Classes/Video/RTCI420Buffer.mm",
"objc/Framework/Headers/WebRTC/RTCVideoFrame.h",
"objc/Framework/Headers/WebRTC/RTCVideoFrameBuffer.h",
]
deps = [
":common_objc",
New file api/video/BUILD.gn Build targets involving files under api/video/ are moved into this file, from api/BUILD.gn. In addition, drop "_api" part of target names, and move the header file api/videosinkinterface.h to api/video/video_sink_interface.h. Bug: webrtc:9253 Change-Id: I2896d3f063db8dff902bc29738578395b2fcc155 Reviewed-on: https://webrtc-review.googlesource.com/75500 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23207}
2018-05-11 11:15:30 +02:00
"//api/video:video_frame",
"//api/video:video_frame_i420",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
"//common_video",
"//rtc_base:checks",
"//rtc_base:rtc_base_approved",
"//third_party/libyuv",
]
Broadcast extension for AppRTCMobile on iOS This provides an environment for testing out using WebRTC from an iOS extension. It implements a ReplayKit broadcast extension for live streaming games and screensharing. The extension is only supported on iOS 11+ and is guarded by a build flag. Bug: webrtc:9335 Change-Id: Id218d6c73ef7599f5953c5a1e0e62e5d0dc4f10b Reviewed-on: https://webrtc-review.googlesource.com/80000 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23504}
2018-06-04 10:24:37 +02:00
configs += [
"..:common_objc",
":used_from_extension",
]
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
}
Rename all objc targets to be suffixed for consistency BUG=webrtc:6412 Review-Url: https://codereview.webrtc.org/3001023003 Cr-Commit-Position: refs/heads/master@{#19489}
2017-08-24 05:43:45 -07:00
rtc_static_library("video_objc") {
Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2911053002/ ) Reason for revert: Take three of relanding this after all internal issues have been resolved. Original issue's description: > Revert of Split iOS sdk in to separate targets (patchset #3 id:320001 of https://codereview.webrtc.org/2893843003/ ) > > Reason for revert: > Breaks downstream project. > > Original issue's description: > > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2893593002/ ) > > > > Reason for revert: > > Take two of fixing downstream issues? > > > > Original issue's description: > > > Revert of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890733003/ ) > > > > > > Reason for revert: > > > Still problems with downstream projects > > > > > > Original issue's description: > > > > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890513002/ ) > > > > > > > > Reason for revert: > > > > Fixing downstream breakages > > > > > > > > Original issue's description: > > > > > Revert of Split iOS sdk in to separate targets (patchset #13 id:280001 of https://codereview.webrtc.org/2862543002/ ) > > > > > > > > > > Reason for revert: > > > > > Breaking downstream projects. > > > > > > > > > > Original issue's description: > > > > > > Split iOS sdk in to separate targets > > > > > > > > > > > > This CL splits the iOS sdk into separate static libraries for video, > > > > > > audio, ui, common, and peerconnection-related code. This will in the > > > > > > future make it easier to compile WebRTC without unneeded components. > > > > > > > > > > > > BUG=webrtc:4867 > > > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2862543002 > > > > > > Cr-Commit-Position: refs/heads/master@{#18166} > > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/52c83fe7102f566cf35a7533092873d58b38f426 > > > > > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,kthelgason@webrtc.org > > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > > NOPRESUBMIT=true > > > > > NOTREECHECKS=true > > > > > NOTRY=true > > > > > BUG=webrtc:4867 > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2890513002 > > > > > Cr-Commit-Position: refs/heads/master@{#18170} > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/9756238084707787f735e1294e896e462e459717 > > > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > NOPRESUBMIT=true > > > > NOTREECHECKS=true > > > > NOTRY=true > > > > BUG=webrtc:4867 > > > > > > > > Review-Url: https://codereview.webrtc.org/2890733003 > > > > Cr-Commit-Position: refs/heads/master@{#18174} > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/d51e042492bedd057bc0cac7828979d5c7369cea > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > NOPRESUBMIT=true > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG=webrtc:4867 > > > > > > Review-Url: https://codereview.webrtc.org/2893593002 > > > Cr-Commit-Position: refs/heads/master@{#18182} > > > Committed: https://chromium.googlesource.com/external/webrtc/+/37144b214e2baf62ecb262ab878dde8c59cdd6a3 > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=webrtc:4867 > > > > Review-Url: https://codereview.webrtc.org/2893843003 > > Cr-Commit-Position: refs/heads/master@{#18303} > > Committed: https://chromium.googlesource.com/external/webrtc/+/580c3522d294c877adfe555048c675bd8d166657 > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org,kthelgason@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:4867 > > Review-Url: https://codereview.webrtc.org/2911053002 > Cr-Commit-Position: refs/heads/master@{#18309} > Committed: https://chromium.googlesource.com/external/webrtc/+/af5c05540cc8208f682cafe88c5c16a505479196 TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org,mbonadei@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4867 Review-Url: https://codereview.webrtc.org/2913753003 Cr-Commit-Position: refs/heads/master@{#18319}
2017-05-30 01:48:47 -07:00
sources = [
Removed file RTCCameraVideoCapturer.mm that isn't needed Also added post commit review changes. BUG=webrtc:7898 Review-Url: https://codereview.webrtc.org/2988783002 Cr-Commit-Position: refs/heads/master@{#19145}
2017-07-25 15:48:39 -07:00
"objc/Framework/Classes/Video/AVCaptureSession+DevicePosition.h",
"objc/Framework/Classes/Video/AVCaptureSession+DevicePosition.mm",
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
"objc/Framework/Classes/Video/RTCDefaultShader.h",
"objc/Framework/Classes/Video/RTCDefaultShader.mm",
"objc/Framework/Classes/Video/RTCI420TextureCache.h",
"objc/Framework/Classes/Video/RTCI420TextureCache.mm",
"objc/Framework/Classes/Video/RTCOpenGLDefines.h",
"objc/Framework/Classes/Video/RTCShader.h",
"objc/Framework/Classes/Video/RTCShader.mm",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
"objc/Framework/Headers/WebRTC/RTCVideoViewShading.h",
iOS/MacOS:Refactor metal rendering by extracting common implementation in separate super class. Included changes: - Fix rendering on iOS to support NV12 and i420 frames - Improve code style - Update build targets - Update tests BUG=webrtc:7079 Review-Url: https://codereview.webrtc.org/2784243003 Cr-Commit-Position: refs/heads/master@{#17923}
2017-04-28 02:14:54 -07:00
]
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
libs = []
iOS/MacOS:Refactor metal rendering by extracting common implementation in separate super class. Included changes: - Fix rendering on iOS to support NV12 and i420 frames - Improve code style - Update build targets - Update tests BUG=webrtc:7079 Review-Url: https://codereview.webrtc.org/2784243003 Cr-Commit-Position: refs/heads/master@{#17923}
2017-04-28 02:14:54 -07:00
if (is_ios) {
Reland of Add metal view, shaders and renderer. (patchset #1 id:1 of https://codereview.webrtc.org/2711003004/ ) Reason for revert: Re-land Original issue's description: > Revert of Add metal view, shaders and renderer. (patchset #18 id:340001 of https://codereview.webrtc.org/2651743007/ ) > > Reason for revert: > Reverting due to breakage in the Google3 import > > Original issue's description: > > Add metal view, shaders and renderer. > > > > This CL submits standalone Metal view, renderer and shader. > > > > BUG=webrtc:7079 > > > > Review-Url: https://codereview.webrtc.org/2651743007 > > Cr-Commit-Position: refs/heads/master@{#16787} > > Committed: https://chromium.googlesource.com/external/webrtc/+/fc8c97f950a4fead4a5debe3c838942db1834010 > > TBR=magjed@webrtc.org,kthelgason@webrtc.org,tkchin@webrtc.org,haysc@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7079 > > Review-Url: https://codereview.webrtc.org/2711003004 > Cr-Commit-Position: refs/heads/master@{#16788} > Committed: https://chromium.googlesource.com/external/webrtc/+/b681aabdfcdcb22de049df3916f2dd8c40dcbf57 TBR=magjed@webrtc.org,kthelgason@webrtc.org,tkchin@webrtc.org,haysc@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:7079 Review-Url: https://codereview.webrtc.org/2716703004 Cr-Commit-Position: refs/heads/master@{#16846}
2017-02-26 11:44:13 -08:00
sources += [
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
"objc/Framework/Classes/Video/RTCNV12TextureCache.h",
"objc/Framework/Classes/Video/RTCNV12TextureCache.m",
Reland of Add metal view, shaders and renderer. (patchset #1 id:1 of https://codereview.webrtc.org/2711003004/ ) Reason for revert: Re-land Original issue's description: > Revert of Add metal view, shaders and renderer. (patchset #18 id:340001 of https://codereview.webrtc.org/2651743007/ ) > > Reason for revert: > Reverting due to breakage in the Google3 import > > Original issue's description: > > Add metal view, shaders and renderer. > > > > This CL submits standalone Metal view, renderer and shader. > > > > BUG=webrtc:7079 > > > > Review-Url: https://codereview.webrtc.org/2651743007 > > Cr-Commit-Position: refs/heads/master@{#16787} > > Committed: https://chromium.googlesource.com/external/webrtc/+/fc8c97f950a4fead4a5debe3c838942db1834010 > > TBR=magjed@webrtc.org,kthelgason@webrtc.org,tkchin@webrtc.org,haysc@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7079 > > Review-Url: https://codereview.webrtc.org/2711003004 > Cr-Commit-Position: refs/heads/master@{#16788} > Committed: https://chromium.googlesource.com/external/webrtc/+/b681aabdfcdcb22de049df3916f2dd8c40dcbf57 TBR=magjed@webrtc.org,kthelgason@webrtc.org,tkchin@webrtc.org,haysc@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:7079 Review-Url: https://codereview.webrtc.org/2716703004 Cr-Commit-Position: refs/heads/master@{#16846}
2017-02-26 11:44:13 -08:00
]
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
libs += [
"GLKit.framework",
"OpenGLES.framework",
"QuartzCore.framework",
]
} else if (is_mac) {
libs += [
"CoreMedia.framework",
"CoreVideo.framework",
"OpenGL.framework",
Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2911053002/ ) Reason for revert: Take three of relanding this after all internal issues have been resolved. Original issue's description: > Revert of Split iOS sdk in to separate targets (patchset #3 id:320001 of https://codereview.webrtc.org/2893843003/ ) > > Reason for revert: > Breaks downstream project. > > Original issue's description: > > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2893593002/ ) > > > > Reason for revert: > > Take two of fixing downstream issues? > > > > Original issue's description: > > > Revert of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890733003/ ) > > > > > > Reason for revert: > > > Still problems with downstream projects > > > > > > Original issue's description: > > > > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890513002/ ) > > > > > > > > Reason for revert: > > > > Fixing downstream breakages > > > > > > > > Original issue's description: > > > > > Revert of Split iOS sdk in to separate targets (patchset #13 id:280001 of https://codereview.webrtc.org/2862543002/ ) > > > > > > > > > > Reason for revert: > > > > > Breaking downstream projects. > > > > > > > > > > Original issue's description: > > > > > > Split iOS sdk in to separate targets > > > > > > > > > > > > This CL splits the iOS sdk into separate static libraries for video, > > > > > > audio, ui, common, and peerconnection-related code. This will in the > > > > > > future make it easier to compile WebRTC without unneeded components. > > > > > > > > > > > > BUG=webrtc:4867 > > > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2862543002 > > > > > > Cr-Commit-Position: refs/heads/master@{#18166} > > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/52c83fe7102f566cf35a7533092873d58b38f426 > > > > > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,kthelgason@webrtc.org > > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > > NOPRESUBMIT=true > > > > > NOTREECHECKS=true > > > > > NOTRY=true > > > > > BUG=webrtc:4867 > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2890513002 > > > > > Cr-Commit-Position: refs/heads/master@{#18170} > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/9756238084707787f735e1294e896e462e459717 > > > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > NOPRESUBMIT=true > > > > NOTREECHECKS=true > > > > NOTRY=true > > > > BUG=webrtc:4867 > > > > > > > > Review-Url: https://codereview.webrtc.org/2890733003 > > > > Cr-Commit-Position: refs/heads/master@{#18174} > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/d51e042492bedd057bc0cac7828979d5c7369cea > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > NOPRESUBMIT=true > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG=webrtc:4867 > > > > > > Review-Url: https://codereview.webrtc.org/2893593002 > > > Cr-Commit-Position: refs/heads/master@{#18182} > > > Committed: https://chromium.googlesource.com/external/webrtc/+/37144b214e2baf62ecb262ab878dde8c59cdd6a3 > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=webrtc:4867 > > > > Review-Url: https://codereview.webrtc.org/2893843003 > > Cr-Commit-Position: refs/heads/master@{#18303} > > Committed: https://chromium.googlesource.com/external/webrtc/+/580c3522d294c877adfe555048c675bd8d166657 > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org,kthelgason@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:4867 > > Review-Url: https://codereview.webrtc.org/2911053002 > Cr-Commit-Position: refs/heads/master@{#18309} > Committed: https://chromium.googlesource.com/external/webrtc/+/af5c05540cc8208f682cafe88c5c16a505479196 TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org,mbonadei@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4867 Review-Url: https://codereview.webrtc.org/2913753003 Cr-Commit-Position: refs/heads/master@{#18319}
2017-05-30 01:48:47 -07:00
]
Reland of Add metal view, shaders and renderer. (patchset #1 id:1 of https://codereview.webrtc.org/2711003004/ ) Reason for revert: Re-land Original issue's description: > Revert of Add metal view, shaders and renderer. (patchset #18 id:340001 of https://codereview.webrtc.org/2651743007/ ) > > Reason for revert: > Reverting due to breakage in the Google3 import > > Original issue's description: > > Add metal view, shaders and renderer. > > > > This CL submits standalone Metal view, renderer and shader. > > > > BUG=webrtc:7079 > > > > Review-Url: https://codereview.webrtc.org/2651743007 > > Cr-Commit-Position: refs/heads/master@{#16787} > > Committed: https://chromium.googlesource.com/external/webrtc/+/fc8c97f950a4fead4a5debe3c838942db1834010 > > TBR=magjed@webrtc.org,kthelgason@webrtc.org,tkchin@webrtc.org,haysc@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7079 > > Review-Url: https://codereview.webrtc.org/2711003004 > Cr-Commit-Position: refs/heads/master@{#16788} > Committed: https://chromium.googlesource.com/external/webrtc/+/b681aabdfcdcb22de049df3916f2dd8c40dcbf57 TBR=magjed@webrtc.org,kthelgason@webrtc.org,tkchin@webrtc.org,haysc@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:7079 Review-Url: https://codereview.webrtc.org/2716703004 Cr-Commit-Position: refs/heads/master@{#16846}
2017-02-26 11:44:13 -08:00
}
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2911053002/ ) Reason for revert: Take three of relanding this after all internal issues have been resolved. Original issue's description: > Revert of Split iOS sdk in to separate targets (patchset #3 id:320001 of https://codereview.webrtc.org/2893843003/ ) > > Reason for revert: > Breaks downstream project. > > Original issue's description: > > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2893593002/ ) > > > > Reason for revert: > > Take two of fixing downstream issues? > > > > Original issue's description: > > > Revert of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890733003/ ) > > > > > > Reason for revert: > > > Still problems with downstream projects > > > > > > Original issue's description: > > > > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890513002/ ) > > > > > > > > Reason for revert: > > > > Fixing downstream breakages > > > > > > > > Original issue's description: > > > > > Revert of Split iOS sdk in to separate targets (patchset #13 id:280001 of https://codereview.webrtc.org/2862543002/ ) > > > > > > > > > > Reason for revert: > > > > > Breaking downstream projects. > > > > > > > > > > Original issue's description: > > > > > > Split iOS sdk in to separate targets > > > > > > > > > > > > This CL splits the iOS sdk into separate static libraries for video, > > > > > > audio, ui, common, and peerconnection-related code. This will in the > > > > > > future make it easier to compile WebRTC without unneeded components. > > > > > > > > > > > > BUG=webrtc:4867 > > > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2862543002 > > > > > > Cr-Commit-Position: refs/heads/master@{#18166} > > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/52c83fe7102f566cf35a7533092873d58b38f426 > > > > > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,kthelgason@webrtc.org > > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > > NOPRESUBMIT=true > > > > > NOTREECHECKS=true > > > > > NOTRY=true > > > > > BUG=webrtc:4867 > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2890513002 > > > > > Cr-Commit-Position: refs/heads/master@{#18170} > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/9756238084707787f735e1294e896e462e459717 > > > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > NOPRESUBMIT=true > > > > NOTREECHECKS=true > > > > NOTRY=true > > > > BUG=webrtc:4867 > > > > > > > > Review-Url: https://codereview.webrtc.org/2890733003 > > > > Cr-Commit-Position: refs/heads/master@{#18174} > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/d51e042492bedd057bc0cac7828979d5c7369cea > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > NOPRESUBMIT=true > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG=webrtc:4867 > > > > > > Review-Url: https://codereview.webrtc.org/2893593002 > > > Cr-Commit-Position: refs/heads/master@{#18182} > > > Committed: https://chromium.googlesource.com/external/webrtc/+/37144b214e2baf62ecb262ab878dde8c59cdd6a3 > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=webrtc:4867 > > > > Review-Url: https://codereview.webrtc.org/2893843003 > > Cr-Commit-Position: refs/heads/master@{#18303} > > Committed: https://chromium.googlesource.com/external/webrtc/+/580c3522d294c877adfe555048c675bd8d166657 > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org,kthelgason@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:4867 > > Review-Url: https://codereview.webrtc.org/2911053002 > Cr-Commit-Position: refs/heads/master@{#18309} > Committed: https://chromium.googlesource.com/external/webrtc/+/af5c05540cc8208f682cafe88c5c16a505479196 TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org,mbonadei@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4867 Review-Url: https://codereview.webrtc.org/2913753003 Cr-Commit-Position: refs/heads/master@{#18319}
2017-05-30 01:48:47 -07:00
deps = [
Rename all objc targets to be suffixed for consistency BUG=webrtc:6412 Review-Url: https://codereview.webrtc.org/3001023003 Cr-Commit-Position: refs/heads/master@{#19489}
2017-08-24 05:43:45 -07:00
":common_objc",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
":mediaconstraints_objc",
Create experimental Obj-C++ API. This can be used to wrap Objective-C components in C++ classes, so users can use the WebRTC C++ API directly together with the iOS specific components provided by our SDK. Bug: webrtc:8832 Change-Id: I6d34f7ec62d51df8d3a5340a2e17d30ae73e13e8 Reviewed-on: https://webrtc-review.googlesource.com/46162 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21850}
2018-02-01 15:47:05 +01:00
":native_video",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
":videoframebuffer_objc",
Fix native api in preparation for native_api example. Add native api conversions for video frames and video renderer. This also requires some changes to sdk/BUILD to avoid cyclic dependencies. Bug: webrtc:8832 Change-Id: Ibf21e63bdcae195dcb61d63f9262e6a8dc4fa790 Reviewed-on: https://webrtc-review.googlesource.com/57142 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22340}
2018-03-07 10:32:03 +01:00
":videosource_objc",
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
"../api:libjingle_peerconnection_api",
New file api/video/BUILD.gn Build targets involving files under api/video/ are moved into this file, from api/BUILD.gn. In addition, drop "_api" part of target names, and move the header file api/videosinkinterface.h to api/video/video_sink_interface.h. Bug: webrtc:9253 Change-Id: I2896d3f063db8dff902bc29738578395b2fcc155 Reviewed-on: https://webrtc-review.googlesource.com/75500 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23207}
2018-05-11 11:15:30 +02:00
"../api/video:video_frame",
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
"../common_video",
"../media:rtc_media_base",
Fix circular dependencies between optional, array_view, and rtc_base. This splits things out of rtc_base and makes dependencies explicit. Bug: webrtc:6828 Change-Id: Id521896c3c43595349021c857bec216e429a0c8d Reviewed-on: https://webrtc-review.googlesource.com/32780 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21264}
2017-12-13 16:05:42 +01:00
"../rtc_base:checks",
Remove remains of webrtc/base All downstream code have been updated to the new location. In PRESUBMIT.py: * Remove webrtc/rtc_base from CPP_BLACKLIST * Add webrtc/rtc_base to LEGACY_API_DIRS Fix some duplicated paths in webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn BUG=webrtc:7634 TBR=kwiberg@webrtc.org Review-Url: https://codereview.webrtc.org/2976293002 Cr-Commit-Position: refs/heads/master@{#19094}
2017-07-19 10:40:47 -07:00
"../rtc_base:rtc_base",
Replace rtc::Optional with absl::optional This is a no-op change because rtc::Optional is an alias to absl::optional This CL generated by running script passing top level directories except rtc_base and api find $@ -type f \( -name \*.h -o -name \*.cc -o -name \*.mm \) \ -exec sed -i 's|rtc::Optional|absl::optional|g' {} \+ \ -exec sed -i 's|rtc::nullopt|absl::nullopt|g' {} \+ \ -exec sed -i 's|#include "api/optional.h"|#include "absl/types/optional.h"|' {} \+ find $@ -type f -name BUILD.gn \ -exec sed -r -i 's|"[\./api]*:optional"|"//third_party/abseil-cpp/absl/types:optional"|' {} \+; git cl format Bug: webrtc:9078 Change-Id: I9465c172e65ba6e6ed4e4fdc35b0b265038d6f71 Reviewed-on: https://webrtc-review.googlesource.com/84584 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23697}
2018-06-21 10:17:24 +02:00
"//third_party/abseil-cpp/absl/types:optional",
Build dynamic iOS SDK. - Places most ObjC code into webrtc/sdk/objc instead. - New gyp targets to build, strip and export symbols for dylib. - Removes old script used to generate dylib. BUG= Review URL: https://codereview.webrtc.org/1903663002 Cr-Commit-Position: refs/heads/master@{#12524}
2016-04-27 01:54:20 -07:00
]
Broadcast extension for AppRTCMobile on iOS This provides an environment for testing out using WebRTC from an iOS extension. It implements a ReplayKit broadcast extension for live streaming games and screensharing. The extension is only supported on iOS 11+ and is guarded by a build flag. Bug: webrtc:9335 Change-Id: Id218d6c73ef7599f5953c5a1e0e62e5d0dc4f10b Reviewed-on: https://webrtc-review.googlesource.com/80000 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23504}
2018-06-04 10:24:37 +02:00
configs += [
"..:common_objc",
":used_from_extension",
]
Implement CVO for iOS capturer The rotation is currently always applied by AVFoundation by reconfiguring the capture connection video orientation. This CL sets the rotation field in the frame instead. This avoids the current flash in the video when the device is rotated, and also avoids reconfiguring the local encoder and remote decoder when the device is rotated. BUG=b/30651939 Review-Url: https://codereview.webrtc.org/2271583003 Cr-Commit-Position: refs/heads/master@{#13916}
2016-08-25 03:25:04 -07:00
}
GN: Tighten up test target visibility + refactorings Make all rtc_source_test target that contains tests that are included in a test executable only be visible to the rtc_test target. Doing this exposed a couple of errors and dependency problems that were resolved. Having this could have prevented duplicated execution of tests like the case that was recently fixed by deadbeef@ in https://codereview.webrtc.org/2820263004 New targets: * //webrtc/modules/rtp_rtcp:fec_test_helper * //webrtc/modules/rtp_rtcp:mock_rtp_rtcp * //webrtc/modules/remote_bitrate_estimator:mock_remote_bitrate_observer The mock files and targets should probably be moved into webrtc/test in the future, but that's out of the scope of this CL. BUG=webrtc:5716 NOTRY=True Review-Url: https://codereview.webrtc.org/2828793003 Cr-Commit-Position: refs/heads/master@{#17863}
2017-04-25 04:04:50 -07:00
Rename all objc targets to be suffixed for consistency BUG=webrtc:6412 Review-Url: https://codereview.webrtc.org/3001023003 Cr-Commit-Position: refs/heads/master@{#19489}
2017-08-24 05:43:45 -07:00
rtc_static_library("ui_objc") {
Revert "Revert "GN rtc_* templates: Set default visibility to webrtc_root + "/*""" This reverts commit c73e1f437889d882cbf2987f7fb3a029a6150613. Reason for revert: The problem with failed deps in chrome content/renderer had already been fixed in https://webrtc-review.googlesource.com/c/src/+/38660 Original change's description: > Revert "GN rtc_* templates: Set default visibility to webrtc_root + "/*"" > > This reverts commit 588c548657b3ddf76e7b3f241263eef7f5799f16. > > Reason for revert: > > Breaks Chrome FYI: > > /b/c/b/Linux_Builder/src/buildtools/linux64/gn gen //out/Release --check > -> returned 1 > ERROR at //build/split_static_library.gni:12:5: Dependency not allowed. > static_library(target_name) { > ^---------------------------- > The item //content/renderer:renderer > can not depend on //third_party/webrtc/media:rtc_internal_video_codecs > because it is not in //third_party/webrtc/media:rtc_internal_video_codecs's visibility list: [ > //third_party/webrtc/* > //third_party/webrtc_overrides/* > ] > > https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.webrtc.fyi%2FLinux_Builder%2F23560%2F%2B%2Frecipes%2Fsteps%2Fgenerate_build_files%2F0%2Fstdout > > Original change's description: > > GN rtc_* templates: Set default visibility to webrtc_root + "/*" > > > > This means that by default, targets are visible to everything under > > the WebRTC root, but not visible to anything else. > > > > API targets are manually tagged with visibility "*", so that targets > > outside the WebRTC tree can see them. > > > > BUG=webrtc:8254 > > > > Change-Id: Icdbee6e0d22d93240ff2fb530c8f9dc48e351509 > > Reviewed-on: https://webrtc-review.googlesource.com/24140 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#21548} > > TBR=mbonadei@webrtc.org,kwiberg@webrtc.org > > Change-Id: I06620ce3d6f67482935c22efa231dd6cab91625a > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:8254 > Reviewed-on: https://webrtc-review.googlesource.com/38760 > Reviewed-by: Per Kjellander <perkj@webrtc.org> > Commit-Queue: Per Kjellander <perkj@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#21555} TBR=mbonadei@webrtc.org,kwiberg@webrtc.org,perkj@webrtc.org Change-Id: I6f720078ce21bd172e0a6471bae8c4c011e4a657 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:8254 Reviewed-on: https://webrtc-review.googlesource.com/38860 Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Per Kjellander <perkj@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21558}
2018-01-10 15:54:53 +00:00
visibility = [ "*" ]
Mark built-in software video codecs as poisonous. The goal is to make these injectable, and only VP8 and VP9 specific targets should depend on them. Bug: webrtc:7925 Change-Id: Ie9239a54d197fe70c93de0582797211fef6997a2 Reviewed-on: https://webrtc-review.googlesource.com/72082 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23021}
2018-04-24 16:39:05 +02:00
allow_poison = [
"audio_codecs", # TODO(bugs.webrtc.org/8396): Remove.
"software_video_codecs", # TODO(bugs.webrtc.org/7925): Remove.
]
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
if (is_ios) {
sources = [
"objc/Framework/Classes/UI/RTCCameraPreviewView.m",
"objc/Framework/Classes/UI/RTCEAGLVideoView.m",
"objc/Framework/Headers/WebRTC/RTCCameraPreviewView.h",
"objc/Framework/Headers/WebRTC/RTCEAGLVideoView.h",
]
GN: Tighten up test target visibility + refactorings Make all rtc_source_test target that contains tests that are included in a test executable only be visible to the rtc_test target. Doing this exposed a couple of errors and dependency problems that were resolved. Having this could have prevented duplicated execution of tests like the case that was recently fixed by deadbeef@ in https://codereview.webrtc.org/2820263004 New targets: * //webrtc/modules/rtp_rtcp:fec_test_helper * //webrtc/modules/rtp_rtcp:mock_rtp_rtcp * //webrtc/modules/remote_bitrate_estimator:mock_remote_bitrate_observer The mock files and targets should probably be moved into webrtc/test in the future, but that's out of the scope of this CL. BUG=webrtc:5716 NOTRY=True Review-Url: https://codereview.webrtc.org/2828793003 Cr-Commit-Position: refs/heads/master@{#17863}
2017-04-25 04:04:50 -07:00
}
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
if (is_mac) {
sources = [
"objc/Framework/Classes/UI/RTCNSGLVideoView.m",
"objc/Framework/Headers/WebRTC/RTCNSGLVideoView.h",
]
}
configs += [ "..:common_objc" ]
Enabling 'gn check' on webrtc/sdk BUG=webrtc:7499 Review-Url: https://codereview.webrtc.org/2818433003 Cr-Commit-Position: refs/heads/master@{#17805}
2017-04-21 00:02:02 -07:00
deps = [
Rename all objc targets to be suffixed for consistency BUG=webrtc:6412 Review-Url: https://codereview.webrtc.org/3001023003 Cr-Commit-Position: refs/heads/master@{#19489}
2017-08-24 05:43:45 -07:00
":common_objc",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
":video_objc",
":videocapture_objc",
":videoframebuffer_objc",
Enabling 'gn check' on webrtc/sdk BUG=webrtc:7499 Review-Url: https://codereview.webrtc.org/2818433003 Cr-Commit-Position: refs/heads/master@{#17805}
2017-04-21 00:02:02 -07:00
]
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
}
Enabling 'gn check' on webrtc/sdk BUG=webrtc:7499 Review-Url: https://codereview.webrtc.org/2818433003 Cr-Commit-Position: refs/heads/master@{#17805}
2017-04-21 00:02:02 -07:00
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
if (rtc_use_metal_rendering) {
Rename all objc targets to be suffixed for consistency BUG=webrtc:6412 Review-Url: https://codereview.webrtc.org/3001023003 Cr-Commit-Position: refs/heads/master@{#19489}
2017-08-24 05:43:45 -07:00
rtc_static_library("metal_objc") {
sdk:metal_objc should be publicly visible. TBR=kthelgason@webrtc.org,phoglund@webrtc.org Bug: webrtc:8855 Change-Id: I1a1fdb57d908b479bac1870c4709ebfbeedc1565 No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/54305 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22058}
2018-02-16 17:55:36 +01:00
visibility = [ "*" ]
Mark built-in software video codecs as poisonous. The goal is to make these injectable, and only VP8 and VP9 specific targets should depend on them. Bug: webrtc:7925 Change-Id: Ie9239a54d197fe70c93de0582797211fef6997a2 Reviewed-on: https://webrtc-review.googlesource.com/72082 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23021}
2018-04-24 16:39:05 +02:00
allow_poison = [
"audio_codecs", # TODO(bugs.webrtc.org/8396): Remove.
"software_video_codecs", # TODO(bugs.webrtc.org/7925): Remove.
]
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
sources = [
"objc/Framework/Classes/Metal/RTCMTLI420Renderer.h",
"objc/Framework/Classes/Metal/RTCMTLI420Renderer.mm",
"objc/Framework/Classes/Metal/RTCMTLRenderer+Private.h",
"objc/Framework/Classes/Metal/RTCMTLRenderer.h",
"objc/Framework/Classes/Metal/RTCMTLRenderer.mm",
]
if (is_ios) {
sources += [
"objc/Framework/Classes/Metal/RTCMTLNV12Renderer.h",
"objc/Framework/Classes/Metal/RTCMTLNV12Renderer.mm",
Adding a Metal RGB renderer. The new RTCMTLRGBRenderer dynamically handles both the kCVPixelFormatType_32BGRA and the kCVPixelFormatType_32ARGB pixel formats. Change-Id: I935532f762eff74c4b84fea9b855191f4c321fb7 Bug: webrtc:9200 Reviewed-on: https://webrtc-review.googlesource.com/72482 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Commit-Queue: Peter Hanspers <peterhanspers@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23100}
2018-05-03 14:06:04 +02:00
"objc/Framework/Classes/Metal/RTCMTLRGBRenderer.h",
"objc/Framework/Classes/Metal/RTCMTLRGBRenderer.mm",
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
"objc/Framework/Classes/Metal/RTCMTLVideoView.m",
"objc/Framework/Headers/WebRTC/RTCMTLVideoView.h",
]
Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2911053002/ ) Reason for revert: Take three of relanding this after all internal issues have been resolved. Original issue's description: > Revert of Split iOS sdk in to separate targets (patchset #3 id:320001 of https://codereview.webrtc.org/2893843003/ ) > > Reason for revert: > Breaks downstream project. > > Original issue's description: > > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2893593002/ ) > > > > Reason for revert: > > Take two of fixing downstream issues? > > > > Original issue's description: > > > Revert of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890733003/ ) > > > > > > Reason for revert: > > > Still problems with downstream projects > > > > > > Original issue's description: > > > > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890513002/ ) > > > > > > > > Reason for revert: > > > > Fixing downstream breakages > > > > > > > > Original issue's description: > > > > > Revert of Split iOS sdk in to separate targets (patchset #13 id:280001 of https://codereview.webrtc.org/2862543002/ ) > > > > > > > > > > Reason for revert: > > > > > Breaking downstream projects. > > > > > > > > > > Original issue's description: > > > > > > Split iOS sdk in to separate targets > > > > > > > > > > > > This CL splits the iOS sdk into separate static libraries for video, > > > > > > audio, ui, common, and peerconnection-related code. This will in the > > > > > > future make it easier to compile WebRTC without unneeded components. > > > > > > > > > > > > BUG=webrtc:4867 > > > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2862543002 > > > > > > Cr-Commit-Position: refs/heads/master@{#18166} > > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/52c83fe7102f566cf35a7533092873d58b38f426 > > > > > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,kthelgason@webrtc.org > > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > > NOPRESUBMIT=true > > > > > NOTREECHECKS=true > > > > > NOTRY=true > > > > > BUG=webrtc:4867 > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2890513002 > > > > > Cr-Commit-Position: refs/heads/master@{#18170} > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/9756238084707787f735e1294e896e462e459717 > > > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > NOPRESUBMIT=true > > > > NOTREECHECKS=true > > > > NOTRY=true > > > > BUG=webrtc:4867 > > > > > > > > Review-Url: https://codereview.webrtc.org/2890733003 > > > > Cr-Commit-Position: refs/heads/master@{#18174} > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/d51e042492bedd057bc0cac7828979d5c7369cea > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > NOPRESUBMIT=true > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG=webrtc:4867 > > > > > > Review-Url: https://codereview.webrtc.org/2893593002 > > > Cr-Commit-Position: refs/heads/master@{#18182} > > > Committed: https://chromium.googlesource.com/external/webrtc/+/37144b214e2baf62ecb262ab878dde8c59cdd6a3 > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=webrtc:4867 > > > > Review-Url: https://codereview.webrtc.org/2893843003 > > Cr-Commit-Position: refs/heads/master@{#18303} > > Committed: https://chromium.googlesource.com/external/webrtc/+/580c3522d294c877adfe555048c675bd8d166657 > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org,kthelgason@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:4867 > > Review-Url: https://codereview.webrtc.org/2911053002 > Cr-Commit-Position: refs/heads/master@{#18309} > Committed: https://chromium.googlesource.com/external/webrtc/+/af5c05540cc8208f682cafe88c5c16a505479196 TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org,mbonadei@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4867 Review-Url: https://codereview.webrtc.org/2913753003 Cr-Commit-Position: refs/heads/master@{#18319}
2017-05-30 01:48:47 -07:00
}
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
if (is_mac) {
sources += [
"objc/Framework/Classes/Metal/RTCMTLNSVideoView.m",
"objc/Framework/Headers/WebRTC/RTCMTLNSVideoView.h",
]
}
libs = [
"CoreVideo.framework",
"Metal.framework",
"MetalKit.framework",
]
deps = [
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
":common_objc",
":peerconnectionfactory_base_objc",
Rename all objc targets to be suffixed for consistency BUG=webrtc:6412 Review-Url: https://codereview.webrtc.org/3001023003 Cr-Commit-Position: refs/heads/master@{#19489}
2017-08-24 05:43:45 -07:00
":video_objc",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
":videoframebuffer_objc",
Fix native api in preparation for native_api example. Add native api conversions for video frames and video renderer. This also requires some changes to sdk/BUILD to avoid cyclic dependencies. Bug: webrtc:8832 Change-Id: Ibf21e63bdcae195dcb61d63f9262e6a8dc4fa790 Reviewed-on: https://webrtc-review.googlesource.com/57142 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22340}
2018-03-07 10:32:03 +01:00
":videorenderer_objc",
New file api/video/BUILD.gn Build targets involving files under api/video/ are moved into this file, from api/BUILD.gn. In addition, drop "_api" part of target names, and move the header file api/videosinkinterface.h to api/video/video_sink_interface.h. Bug: webrtc:9253 Change-Id: I2896d3f063db8dff902bc29738578395b2fcc155 Reviewed-on: https://webrtc-review.googlesource.com/75500 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23207}
2018-05-11 11:15:30 +02:00
"../api/video:video_frame",
Fix circular dependencies between optional, array_view, and rtc_base. This splits things out of rtc_base and makes dependencies explicit. Bug: webrtc:6828 Change-Id: Id521896c3c43595349021c857bec216e429a0c8d Reviewed-on: https://webrtc-review.googlesource.com/32780 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21264}
2017-12-13 16:05:42 +01:00
"../rtc_base:checks",
Remove remains of webrtc/base All downstream code have been updated to the new location. In PRESUBMIT.py: * Remove webrtc/rtc_base from CPP_BLACKLIST * Add webrtc/rtc_base to LEGACY_API_DIRS Fix some duplicated paths in webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn BUG=webrtc:7634 TBR=kwiberg@webrtc.org Review-Url: https://codereview.webrtc.org/2976293002 Cr-Commit-Position: refs/heads/master@{#19094}
2017-07-19 10:40:47 -07:00
"../rtc_base:rtc_base_approved",
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
]
configs += [ "..:common_objc" ]
Rename all objc targets to be suffixed for consistency BUG=webrtc:6412 Review-Url: https://codereview.webrtc.org/3001023003 Cr-Commit-Position: refs/heads/master@{#19489}
2017-08-24 05:43:45 -07:00
public_configs = [ ":common_config_objc" ]
Refactor rtc_unittests into several targets. Also fix some warnings. NOTRY=True BUG=webrtc:6954 Review-Url: https://codereview.webrtc.org/2611663002 Cr-Commit-Position: refs/heads/master@{#15900}
2017-01-04 07:11:23 -08:00
}
}
[GN] Add rtc_sdk_framework_objc target to GN The build artifacts don't look completely identical to the ones generated by the GYP targets, but manual review shows the same symbols are exported. On iOS, the version generated by the GN follows convention, including a "Headers" directory, and the .modulemap file. I think this is preferred over the gyp version. BUG=webrtc:6320 NOTRY=True TESTED=Run AppRTCDemo on iOS + Mac and verified with nm that they export the same symbols. Review-Url: https://codereview.webrtc.org/2340633003 Cr-Commit-Position: refs/heads/master@{#14228}
2016-09-15 04:30:18 -07:00
Add an example app for iOS native API. Demonstrates how to use the iOS native API to wrap components into C++ classes. This CL also introduces a native API wrapper for the capturer. The C++ code is forked from the corresponding CL for Android at https://webrtc-review.googlesource.com/c/src/+/60540 Bug: webrtc:8832 Change-Id: I12d9f30e701c0222628e329218f6d5bfca26e6e0 Reviewed-on: https://webrtc-review.googlesource.com/61422 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22484}
2018-03-15 09:41:03 +01:00
rtc_static_library("videocapturebase_objc") {
visibility = [ "*" ]
sources = [
"objc/Framework/Classes/PeerConnection/RTCVideoCapturer.m",
"objc/Framework/Headers/WebRTC/RTCVideoCapturer.h",
]
libs = [ "AVFoundation.framework" ]
configs += [ "..:common_objc" ]
public_configs = [ ":common_config_objc" ]
deps = [
":common_objc",
":videoframebuffer_objc",
]
}
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
rtc_static_library("videocapture_objc") {
Revert "Revert "GN rtc_* templates: Set default visibility to webrtc_root + "/*""" This reverts commit c73e1f437889d882cbf2987f7fb3a029a6150613. Reason for revert: The problem with failed deps in chrome content/renderer had already been fixed in https://webrtc-review.googlesource.com/c/src/+/38660 Original change's description: > Revert "GN rtc_* templates: Set default visibility to webrtc_root + "/*"" > > This reverts commit 588c548657b3ddf76e7b3f241263eef7f5799f16. > > Reason for revert: > > Breaks Chrome FYI: > > /b/c/b/Linux_Builder/src/buildtools/linux64/gn gen //out/Release --check > -> returned 1 > ERROR at //build/split_static_library.gni:12:5: Dependency not allowed. > static_library(target_name) { > ^---------------------------- > The item //content/renderer:renderer > can not depend on //third_party/webrtc/media:rtc_internal_video_codecs > because it is not in //third_party/webrtc/media:rtc_internal_video_codecs's visibility list: [ > //third_party/webrtc/* > //third_party/webrtc_overrides/* > ] > > https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.webrtc.fyi%2FLinux_Builder%2F23560%2F%2B%2Frecipes%2Fsteps%2Fgenerate_build_files%2F0%2Fstdout > > Original change's description: > > GN rtc_* templates: Set default visibility to webrtc_root + "/*" > > > > This means that by default, targets are visible to everything under > > the WebRTC root, but not visible to anything else. > > > > API targets are manually tagged with visibility "*", so that targets > > outside the WebRTC tree can see them. > > > > BUG=webrtc:8254 > > > > Change-Id: Icdbee6e0d22d93240ff2fb530c8f9dc48e351509 > > Reviewed-on: https://webrtc-review.googlesource.com/24140 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#21548} > > TBR=mbonadei@webrtc.org,kwiberg@webrtc.org > > Change-Id: I06620ce3d6f67482935c22efa231dd6cab91625a > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:8254 > Reviewed-on: https://webrtc-review.googlesource.com/38760 > Reviewed-by: Per Kjellander <perkj@webrtc.org> > Commit-Queue: Per Kjellander <perkj@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#21555} TBR=mbonadei@webrtc.org,kwiberg@webrtc.org,perkj@webrtc.org Change-Id: I6f720078ce21bd172e0a6471bae8c4c011e4a657 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:8254 Reviewed-on: https://webrtc-review.googlesource.com/38860 Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Per Kjellander <perkj@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21558}
2018-01-10 15:54:53 +00:00
visibility = [ "*" ]
Mark built-in software video codecs as poisonous. The goal is to make these injectable, and only VP8 and VP9 specific targets should depend on them. Bug: webrtc:7925 Change-Id: Ie9239a54d197fe70c93de0582797211fef6997a2 Reviewed-on: https://webrtc-review.googlesource.com/72082 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23021}
2018-04-24 16:39:05 +02:00
allow_poison = [
"audio_codecs", # TODO(bugs.webrtc.org/8396): Remove.
"software_video_codecs", # TODO(bugs.webrtc.org/7925): Remove.
]
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
sources = [
Support building WebRTC without audio and video for IOS. Reorganized the targets in webrtc/sdk/BUILD.gn so that the applications which use WebRTC DataChannel only can depend on the "peerconnection_factory_no_media" instead of "rtc_sdk_objc" to reduce the binary size. Provided a no-media implementation of RTCPeerConnectionFactory using the macro "HAVE_NO_MEDIA". BUG=webrtc:7613 Review-Url: https://codereview.webrtc.org/2944643002 Cr-Commit-Position: refs/heads/master@{#18819}
2017-06-28 14:05:44 -07:00
"objc/Framework/Classes/PeerConnection/RTCCameraVideoCapturer.m",
"objc/Framework/Headers/WebRTC/RTCCameraVideoCapturer.h",
]
if (is_ios) {
sources += [
"objc/Framework/Classes/PeerConnection/RTCFileVideoCapturer.m",
Reland "Add file capturer to AppRTCMobile on simulator." This is a reland of 5adcd198752b651f7b7e9199a91f9b873b7d7237 Original change's description: > Add file capturer to AppRTCMobile on simulator. > > To achieve this, the CL does the following > - Adds sample mp4 video > - Refactors the existing RTCFileVideoCapturer to achieve continious > capture and adds tests. > > Bug: webrtc:8406 > Change-Id: Ibc0891176c58ec9053b42e340d2113036e7199ec > Reviewed-on: https://webrtc-review.googlesource.com/12180 > Reviewed-by: Anders Carlsson <andersc@webrtc.org> > Reviewed-by: Magnus Jedvert <magjed@webrtc.org> > Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#20598} Bug: webrtc:8406 Change-Id: I93be89b86e342a9a8195e19ebaf4aef1410d2c20 Reviewed-on: https://webrtc-review.googlesource.com/23200 Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20870}
2017-11-15 13:15:24 +01:00
"objc/Framework/Headers/WebRTC/RTCFileVideoCapturer.h",
Support building WebRTC without audio and video for IOS. Reorganized the targets in webrtc/sdk/BUILD.gn so that the applications which use WebRTC DataChannel only can depend on the "peerconnection_factory_no_media" instead of "rtc_sdk_objc" to reduce the binary size. Provided a no-media implementation of RTCPeerConnectionFactory using the macro "HAVE_NO_MEDIA". BUG=webrtc:7613 Review-Url: https://codereview.webrtc.org/2944643002 Cr-Commit-Position: refs/heads/master@{#18819}
2017-06-28 14:05:44 -07:00
]
}
libs = [ "AVFoundation.framework" ]
configs += [ "..:common_objc" ]
Rename all objc targets to be suffixed for consistency BUG=webrtc:6412 Review-Url: https://codereview.webrtc.org/3001023003 Cr-Commit-Position: refs/heads/master@{#19489}
2017-08-24 05:43:45 -07:00
public_configs = [ ":common_config_objc" ]
Support building WebRTC without audio and video for IOS. Reorganized the targets in webrtc/sdk/BUILD.gn so that the applications which use WebRTC DataChannel only can depend on the "peerconnection_factory_no_media" instead of "rtc_sdk_objc" to reduce the binary size. Provided a no-media implementation of RTCPeerConnectionFactory using the macro "HAVE_NO_MEDIA". BUG=webrtc:7613 Review-Url: https://codereview.webrtc.org/2944643002 Cr-Commit-Position: refs/heads/master@{#18819}
2017-06-28 14:05:44 -07:00
deps = [
Rename all objc targets to be suffixed for consistency BUG=webrtc:6412 Review-Url: https://codereview.webrtc.org/3001023003 Cr-Commit-Position: refs/heads/master@{#19489}
2017-08-24 05:43:45 -07:00
":common_objc",
":video_objc",
Add an example app for iOS native API. Demonstrates how to use the iOS native API to wrap components into C++ classes. This CL also introduces a native API wrapper for the capturer. The C++ code is forked from the corresponding CL for Android at https://webrtc-review.googlesource.com/c/src/+/60540 Bug: webrtc:8832 Change-Id: I12d9f30e701c0222628e329218f6d5bfca26e6e0 Reviewed-on: https://webrtc-review.googlesource.com/61422 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22484}
2018-03-15 09:41:03 +01:00
":videocapturebase_objc",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
":videoframebuffer_objc",
Support building WebRTC without audio and video for IOS. Reorganized the targets in webrtc/sdk/BUILD.gn so that the applications which use WebRTC DataChannel only can depend on the "peerconnection_factory_no_media" instead of "rtc_sdk_objc" to reduce the binary size. Provided a no-media implementation of RTCPeerConnectionFactory using the macro "HAVE_NO_MEDIA". BUG=webrtc:7613 Review-Url: https://codereview.webrtc.org/2944643002 Cr-Commit-Position: refs/heads/master@{#18819}
2017-06-28 14:05:44 -07:00
]
}
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
rtc_static_library("videocodec_objc") {
GN hack to tag targets as poisonous (and use it with audio codecs) Only specially taggged targets may transitively depend on poisonous targets. We first apply it to audio codecs. This makes it much clearer exactly what parts of the code still have dependencies on the audio codecs (and we want to eventually get rid of pretty much all of them). Bug: webrtc:8396, webrtc:9121 Change-Id: Iba5c2e806c702b5cfe881022674705f647896d43 Reviewed-on: https://webrtc-review.googlesource.com/69520 Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22979}
2018-04-22 19:55:00 +02:00
visibility = [ "*" ]
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
sources = [
"objc/Framework/Classes/PeerConnection/RTCEncodedImage.mm",
Obj-C SDK for parsing and generating H264 ProfileLevelIds. Expose this functionality in the Obj-C SDK to make it nicer to use for Obj-C clients. Bug: None Change-Id: I5cb511af8799ac0fda15153d16f2550b848b93b2 Reviewed-on: https://webrtc-review.googlesource.com/80481 Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23488}
2018-06-01 12:51:09 +02:00
"objc/Framework/Classes/PeerConnection/RTCH264ProfileLevelId.mm",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
"objc/Framework/Classes/PeerConnection/RTCRtpFragmentationHeader.mm",
"objc/Framework/Classes/PeerConnection/RTCVideoCodec+Private.h",
"objc/Framework/Classes/PeerConnection/RTCVideoCodec.mm",
Reland of Injectable Obj-C video codecs (patchset #1 id:1 of https://codereview.webrtc.org/2980173002/ ) Reason for revert: Relanding after fixing issues with no video. Original issue's description: > Revert of Injectable Obj-C video codecs (patchset #2 id:370001 of https://codereview.webrtc.org/2979983002/ ) > > Reason for revert: > Still having problems with no video. Reverting. > Once no video is visible, no video is available from then on even if the callee app is in the foreground. > > > Original issue's description: > > Reland of Injectable Obj-C video codecs (patchset #1 id:1 of https://codereview.webrtc.org/2979973002/ ) > > > > Reason for revert: > > Fix the broken build file > > > > Original issue's description: > > > Revert of Injectable Obj-C video codecs (patchset #3 id:400001 of https://codereview.webrtc.org/2981583002/ ) > > > > > > Reason for revert: > > > Breaks bots. Build file incorrect. > > > > > > Original issue's description: > > > > Reland of Injectable Obj-C video codecs (patchset #1 id:1 of https://codereview.webrtc.org/2975963002/ ) > > > > > > > > Reason for revert: > > > > New CL for fixing the issues > > > > > > > > Original issue's description: > > > > > Revert of Injectable Obj-C video codecs (patchset #8 id:140001 of https://codereview.webrtc.org/2966023002/ ) > > > > > > > > > > Reason for revert: > > > > > Causes no video in certain scenarios. Please come up with a test plan or unit test to prevent such problems in the future. > > > > > > > > > > Original issue's description: > > > > > > Injectable Obj-C video codecs > > > > > > > > > > > > Initial CL for this effort, with a working RTCVideoEncoder/Decoder for H264 > > > > > > (wrapping the VideoToolbox codec). > > > > > > > > > > > > Some notes / things left to do: > > > > > > - There are some hard-coded references to codec types that are supported by > > > > > > webrtc::VideoCodec, cricket::VideoCodec, webrtc::CodecSpecificInfo etc > > > > > > since we need to convert to/from these types in ObjCVideoEncoder/Decoder. > > > > > > These types would need to be more codec agnostic to avoid this. > > > > > > - Most interfaces are borrowed from the design document for injectable > > > > > > codecs in Android. Some data in the corresponding C++ classes is discarded > > > > > > when converting to the Obj-C version, since it has fewer fields. I have not > > > > > > verified whether all data that we do keep is needed, or whether we might be > > > > > > losing anything useful in these conversions. > > > > > > - Implement the VideoToolbox codec code directly in the RTCVideoEncoderH264 > > > > > > classes, instead of wrapping webrtc::H264VideoToolboxEncoder / decoder. > > > > > > Eliminates converting between ObjC/C++ types outside the ObjCVideoEncoder/ > > > > > > Decoder wrapper classes. > > > > > > - List the injected codec factory's supported codecs in the list of codecs in > > > > > > AppRTCMobile. > > > > > > > > > > > > BUG=webrtc:7924 > > > > > > R=magjed@webrtc.org > > > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2966023002 . > > > > > > Cr-Commit-Position: refs/heads/master@{#18928} > > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/a0349c138db62c52435be84b6c837f5f4758e264 > > > > > > > > > > TBR=magjed@webrtc.org,andersc@webrtc.org > > > > > # Not skipping CQ checks because original CL landed more than 1 days ago. > > > > > BUG=webrtc:7924 > > > > > NOTRY=true > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2975963002 > > > > > Cr-Commit-Position: refs/heads/master@{#18979} > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/1095ada7ad56fe29b7b2bbc560a8f6475a7978ce > > > > > > > > R=magjed@webrtc.org > > > > TBR=tkchin@webrtc.org > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > NOPRESUBMIT=true > > > > NOTREECHECKS=true > > > > NOTRY=true > > > > BUG=webrtc:7924 > > > > > > > > Review-Url: https://codereview.webrtc.org/2981583002 . > > > > Cr-Commit-Position: refs/heads/master@{#19002} > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/a5f1de1e6541de03f944bcbf49be87c01f57a18b > > > > > > TBR=magjed@webrtc.org,tkchin@webrtc.org,jtteh@webrtc.org,andersc@webrtc.org > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > NOPRESUBMIT=true > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG=webrtc:7924 > > > > > > Review-Url: https://codereview.webrtc.org/2979973002 > > > Cr-Commit-Position: refs/heads/master@{#19004} > > > Committed: https://chromium.googlesource.com/external/webrtc/+/81d40ee1491d5229c2677cc04b1f40d67c2babef > > > > TBR=magjed@webrtc.org,tkchin@webrtc.org,jtteh@webrtc.org,sprang@webrtc.org > > BUG=webrtc:7924 > > > > Review-Url: https://codereview.webrtc.org/2979983002 > > Cr-Commit-Position: refs/heads/master@{#19005} > > Committed: https://chromium.googlesource.com/external/webrtc/+/732a3437da4db7b452758b8e1cf26fce0ce3bf65 > > TBR=magjed@webrtc.org,tkchin@webrtc.org,sprang@webrtc.org,haysc@webrtc.org,andersc@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:7924 > > Review-Url: https://codereview.webrtc.org/2980173002 > Cr-Commit-Position: refs/heads/master@{#19036} > Committed: https://chromium.googlesource.com/external/webrtc/+/860f7298166084d966749e22b69aa2fdcf4d4ed6 TBR=magjed@webrtc.org,tkchin@webrtc.org,sprang@webrtc.org,haysc@webrtc.org,andersc@webrtc.org,jtteh@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:7924 Review-Url: https://codereview.webrtc.org/2977213002 Cr-Commit-Position: refs/heads/master@{#19135}
2017-07-25 07:55:58 -07:00
"objc/Framework/Classes/PeerConnection/RTCVideoCodecH264.mm",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
"objc/Framework/Classes/PeerConnection/RTCVideoEncoderSettings.mm",
"objc/Framework/Headers/WebRTC/RTCVideoCodec.h",
"objc/Framework/Headers/WebRTC/RTCVideoCodecFactory.h",
"objc/Framework/Headers/WebRTC/RTCVideoCodecH264.h",
Support building WebRTC without audio and video for IOS. Reorganized the targets in webrtc/sdk/BUILD.gn so that the applications which use WebRTC DataChannel only can depend on the "peerconnection_factory_no_media" instead of "rtc_sdk_objc" to reduce the binary size. Provided a no-media implementation of RTCPeerConnectionFactory using the macro "HAVE_NO_MEDIA". BUG=webrtc:7613 Review-Url: https://codereview.webrtc.org/2944643002 Cr-Commit-Position: refs/heads/master@{#18819}
2017-06-28 14:05:44 -07:00
]
Init max supported H.264 profile at runtime on iOS Bug: webrtc:9134, webrtc:7992 Change-Id: Id24c570bf3296298901f61ee817a3d7c3f8c6347 Reviewed-on: https://webrtc-review.googlesource.com/71560 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23034}
2018-04-26 15:41:01 +03:00
if (is_ios) {
sources += [
"objc/Framework/Classes/Video/UIDevice+H264Profile.h",
"objc/Framework/Classes/Video/UIDevice+H264Profile.mm",
]
}
Support building WebRTC without audio and video for IOS. Reorganized the targets in webrtc/sdk/BUILD.gn so that the applications which use WebRTC DataChannel only can depend on the "peerconnection_factory_no_media" instead of "rtc_sdk_objc" to reduce the binary size. Provided a no-media implementation of RTCPeerConnectionFactory using the macro "HAVE_NO_MEDIA". BUG=webrtc:7613 Review-Url: https://codereview.webrtc.org/2944643002 Cr-Commit-Position: refs/heads/master@{#18819}
2017-06-28 14:05:44 -07:00
if (!build_with_chromium && is_clang) {
# Suppress warnings from the Chromium Clang plugin
# (bugs.webrtc.org/163).
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
}
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
public_configs = [ ":common_config_objc" ]
deps = [
Rename all objc targets to be suffixed for consistency BUG=webrtc:6412 Review-Url: https://codereview.webrtc.org/3001023003 Cr-Commit-Position: refs/heads/master@{#19489}
2017-08-24 05:43:45 -07:00
":common_objc",
Reland of Injectable Obj-C video codecs (patchset #1 id:1 of https://codereview.webrtc.org/2980173002/ ) Reason for revert: Relanding after fixing issues with no video. Original issue's description: > Revert of Injectable Obj-C video codecs (patchset #2 id:370001 of https://codereview.webrtc.org/2979983002/ ) > > Reason for revert: > Still having problems with no video. Reverting. > Once no video is visible, no video is available from then on even if the callee app is in the foreground. > > > Original issue's description: > > Reland of Injectable Obj-C video codecs (patchset #1 id:1 of https://codereview.webrtc.org/2979973002/ ) > > > > Reason for revert: > > Fix the broken build file > > > > Original issue's description: > > > Revert of Injectable Obj-C video codecs (patchset #3 id:400001 of https://codereview.webrtc.org/2981583002/ ) > > > > > > Reason for revert: > > > Breaks bots. Build file incorrect. > > > > > > Original issue's description: > > > > Reland of Injectable Obj-C video codecs (patchset #1 id:1 of https://codereview.webrtc.org/2975963002/ ) > > > > > > > > Reason for revert: > > > > New CL for fixing the issues > > > > > > > > Original issue's description: > > > > > Revert of Injectable Obj-C video codecs (patchset #8 id:140001 of https://codereview.webrtc.org/2966023002/ ) > > > > > > > > > > Reason for revert: > > > > > Causes no video in certain scenarios. Please come up with a test plan or unit test to prevent such problems in the future. > > > > > > > > > > Original issue's description: > > > > > > Injectable Obj-C video codecs > > > > > > > > > > > > Initial CL for this effort, with a working RTCVideoEncoder/Decoder for H264 > > > > > > (wrapping the VideoToolbox codec). > > > > > > > > > > > > Some notes / things left to do: > > > > > > - There are some hard-coded references to codec types that are supported by > > > > > > webrtc::VideoCodec, cricket::VideoCodec, webrtc::CodecSpecificInfo etc > > > > > > since we need to convert to/from these types in ObjCVideoEncoder/Decoder. > > > > > > These types would need to be more codec agnostic to avoid this. > > > > > > - Most interfaces are borrowed from the design document for injectable > > > > > > codecs in Android. Some data in the corresponding C++ classes is discarded > > > > > > when converting to the Obj-C version, since it has fewer fields. I have not > > > > > > verified whether all data that we do keep is needed, or whether we might be > > > > > > losing anything useful in these conversions. > > > > > > - Implement the VideoToolbox codec code directly in the RTCVideoEncoderH264 > > > > > > classes, instead of wrapping webrtc::H264VideoToolboxEncoder / decoder. > > > > > > Eliminates converting between ObjC/C++ types outside the ObjCVideoEncoder/ > > > > > > Decoder wrapper classes. > > > > > > - List the injected codec factory's supported codecs in the list of codecs in > > > > > > AppRTCMobile. > > > > > > > > > > > > BUG=webrtc:7924 > > > > > > R=magjed@webrtc.org > > > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2966023002 . > > > > > > Cr-Commit-Position: refs/heads/master@{#18928} > > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/a0349c138db62c52435be84b6c837f5f4758e264 > > > > > > > > > > TBR=magjed@webrtc.org,andersc@webrtc.org > > > > > # Not skipping CQ checks because original CL landed more than 1 days ago. > > > > > BUG=webrtc:7924 > > > > > NOTRY=true > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2975963002 > > > > > Cr-Commit-Position: refs/heads/master@{#18979} > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/1095ada7ad56fe29b7b2bbc560a8f6475a7978ce > > > > > > > > R=magjed@webrtc.org > > > > TBR=tkchin@webrtc.org > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > NOPRESUBMIT=true > > > > NOTREECHECKS=true > > > > NOTRY=true > > > > BUG=webrtc:7924 > > > > > > > > Review-Url: https://codereview.webrtc.org/2981583002 . > > > > Cr-Commit-Position: refs/heads/master@{#19002} > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/a5f1de1e6541de03f944bcbf49be87c01f57a18b > > > > > > TBR=magjed@webrtc.org,tkchin@webrtc.org,jtteh@webrtc.org,andersc@webrtc.org > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > NOPRESUBMIT=true > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG=webrtc:7924 > > > > > > Review-Url: https://codereview.webrtc.org/2979973002 > > > Cr-Commit-Position: refs/heads/master@{#19004} > > > Committed: https://chromium.googlesource.com/external/webrtc/+/81d40ee1491d5229c2677cc04b1f40d67c2babef > > > > TBR=magjed@webrtc.org,tkchin@webrtc.org,jtteh@webrtc.org,sprang@webrtc.org > > BUG=webrtc:7924 > > > > Review-Url: https://codereview.webrtc.org/2979983002 > > Cr-Commit-Position: refs/heads/master@{#19005} > > Committed: https://chromium.googlesource.com/external/webrtc/+/732a3437da4db7b452758b8e1cf26fce0ce3bf65 > > TBR=magjed@webrtc.org,tkchin@webrtc.org,sprang@webrtc.org,haysc@webrtc.org,andersc@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:7924 > > Review-Url: https://codereview.webrtc.org/2980173002 > Cr-Commit-Position: refs/heads/master@{#19036} > Committed: https://chromium.googlesource.com/external/webrtc/+/860f7298166084d966749e22b69aa2fdcf4d4ed6 TBR=magjed@webrtc.org,tkchin@webrtc.org,sprang@webrtc.org,haysc@webrtc.org,andersc@webrtc.org,jtteh@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:7924 Review-Url: https://codereview.webrtc.org/2977213002 Cr-Commit-Position: refs/heads/master@{#19135}
2017-07-25 07:55:58 -07:00
"../api/video_codecs:video_codecs_api",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
"../common_video",
Init max supported H.264 profile at runtime on iOS Bug: webrtc:9134, webrtc:7992 Change-Id: Id24c570bf3296298901f61ee817a3d7c3f8c6347 Reviewed-on: https://webrtc-review.googlesource.com/71560 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23034}
2018-04-26 15:41:01 +03:00
"../media:rtc_h264_profile_id",
Support building WebRTC without audio and video for IOS. Reorganized the targets in webrtc/sdk/BUILD.gn so that the applications which use WebRTC DataChannel only can depend on the "peerconnection_factory_no_media" instead of "rtc_sdk_objc" to reduce the binary size. Provided a no-media implementation of RTCPeerConnectionFactory using the macro "HAVE_NO_MEDIA". BUG=webrtc:7613 Review-Url: https://codereview.webrtc.org/2944643002 Cr-Commit-Position: refs/heads/master@{#18819}
2017-06-28 14:05:44 -07:00
"../media:rtc_media_base",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
"../modules:module_api",
"../modules/video_coding:video_codec_interface",
"../rtc_base:rtc_base_approved",
Reland of Injectable Obj-C video codecs (patchset #1 id:1 of https://codereview.webrtc.org/2980173002/ ) Reason for revert: Relanding after fixing issues with no video. Original issue's description: > Revert of Injectable Obj-C video codecs (patchset #2 id:370001 of https://codereview.webrtc.org/2979983002/ ) > > Reason for revert: > Still having problems with no video. Reverting. > Once no video is visible, no video is available from then on even if the callee app is in the foreground. > > > Original issue's description: > > Reland of Injectable Obj-C video codecs (patchset #1 id:1 of https://codereview.webrtc.org/2979973002/ ) > > > > Reason for revert: > > Fix the broken build file > > > > Original issue's description: > > > Revert of Injectable Obj-C video codecs (patchset #3 id:400001 of https://codereview.webrtc.org/2981583002/ ) > > > > > > Reason for revert: > > > Breaks bots. Build file incorrect. > > > > > > Original issue's description: > > > > Reland of Injectable Obj-C video codecs (patchset #1 id:1 of https://codereview.webrtc.org/2975963002/ ) > > > > > > > > Reason for revert: > > > > New CL for fixing the issues > > > > > > > > Original issue's description: > > > > > Revert of Injectable Obj-C video codecs (patchset #8 id:140001 of https://codereview.webrtc.org/2966023002/ ) > > > > > > > > > > Reason for revert: > > > > > Causes no video in certain scenarios. Please come up with a test plan or unit test to prevent such problems in the future. > > > > > > > > > > Original issue's description: > > > > > > Injectable Obj-C video codecs > > > > > > > > > > > > Initial CL for this effort, with a working RTCVideoEncoder/Decoder for H264 > > > > > > (wrapping the VideoToolbox codec). > > > > > > > > > > > > Some notes / things left to do: > > > > > > - There are some hard-coded references to codec types that are supported by > > > > > > webrtc::VideoCodec, cricket::VideoCodec, webrtc::CodecSpecificInfo etc > > > > > > since we need to convert to/from these types in ObjCVideoEncoder/Decoder. > > > > > > These types would need to be more codec agnostic to avoid this. > > > > > > - Most interfaces are borrowed from the design document for injectable > > > > > > codecs in Android. Some data in the corresponding C++ classes is discarded > > > > > > when converting to the Obj-C version, since it has fewer fields. I have not > > > > > > verified whether all data that we do keep is needed, or whether we might be > > > > > > losing anything useful in these conversions. > > > > > > - Implement the VideoToolbox codec code directly in the RTCVideoEncoderH264 > > > > > > classes, instead of wrapping webrtc::H264VideoToolboxEncoder / decoder. > > > > > > Eliminates converting between ObjC/C++ types outside the ObjCVideoEncoder/ > > > > > > Decoder wrapper classes. > > > > > > - List the injected codec factory's supported codecs in the list of codecs in > > > > > > AppRTCMobile. > > > > > > > > > > > > BUG=webrtc:7924 > > > > > > R=magjed@webrtc.org > > > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2966023002 . > > > > > > Cr-Commit-Position: refs/heads/master@{#18928} > > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/a0349c138db62c52435be84b6c837f5f4758e264 > > > > > > > > > > TBR=magjed@webrtc.org,andersc@webrtc.org > > > > > # Not skipping CQ checks because original CL landed more than 1 days ago. > > > > > BUG=webrtc:7924 > > > > > NOTRY=true > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2975963002 > > > > > Cr-Commit-Position: refs/heads/master@{#18979} > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/1095ada7ad56fe29b7b2bbc560a8f6475a7978ce > > > > > > > > R=magjed@webrtc.org > > > > TBR=tkchin@webrtc.org > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > NOPRESUBMIT=true > > > > NOTREECHECKS=true > > > > NOTRY=true > > > > BUG=webrtc:7924 > > > > > > > > Review-Url: https://codereview.webrtc.org/2981583002 . > > > > Cr-Commit-Position: refs/heads/master@{#19002} > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/a5f1de1e6541de03f944bcbf49be87c01f57a18b > > > > > > TBR=magjed@webrtc.org,tkchin@webrtc.org,jtteh@webrtc.org,andersc@webrtc.org > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > NOPRESUBMIT=true > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG=webrtc:7924 > > > > > > Review-Url: https://codereview.webrtc.org/2979973002 > > > Cr-Commit-Position: refs/heads/master@{#19004} > > > Committed: https://chromium.googlesource.com/external/webrtc/+/81d40ee1491d5229c2677cc04b1f40d67c2babef > > > > TBR=magjed@webrtc.org,tkchin@webrtc.org,jtteh@webrtc.org,sprang@webrtc.org > > BUG=webrtc:7924 > > > > Review-Url: https://codereview.webrtc.org/2979983002 > > Cr-Commit-Position: refs/heads/master@{#19005} > > Committed: https://chromium.googlesource.com/external/webrtc/+/732a3437da4db7b452758b8e1cf26fce0ce3bf65 > > TBR=magjed@webrtc.org,tkchin@webrtc.org,sprang@webrtc.org,haysc@webrtc.org,andersc@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:7924 > > Review-Url: https://codereview.webrtc.org/2980173002 > Cr-Commit-Position: refs/heads/master@{#19036} > Committed: https://chromium.googlesource.com/external/webrtc/+/860f7298166084d966749e22b69aa2fdcf4d4ed6 TBR=magjed@webrtc.org,tkchin@webrtc.org,sprang@webrtc.org,haysc@webrtc.org,andersc@webrtc.org,jtteh@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:7924 Review-Url: https://codereview.webrtc.org/2977213002 Cr-Commit-Position: refs/heads/master@{#19135}
2017-07-25 07:55:58 -07:00
"../system_wrappers:field_trial_api",
Support building WebRTC without audio and video for IOS. Reorganized the targets in webrtc/sdk/BUILD.gn so that the applications which use WebRTC DataChannel only can depend on the "peerconnection_factory_no_media" instead of "rtc_sdk_objc" to reduce the binary size. Provided a no-media implementation of RTCPeerConnectionFactory using the macro "HAVE_NO_MEDIA". BUG=webrtc:7613 Review-Url: https://codereview.webrtc.org/2944643002 Cr-Commit-Position: refs/heads/master@{#18819}
2017-06-28 14:05:44 -07:00
]
}
Enable building WebRTC without built-in software codecs This CL adds a GN build flag to include builtin software codecs (enabled by default). When setting the flag to false, libvpx can also be excluded. The benefit is that the resulting binary is smaller. Replaces https://webrtc-review.googlesource.com/c/src/+/29203 Bug: webrtc:7925 Change-Id: Id330ea8a43169e449ee139eca18e4557cc932e10 Reviewed-on: https://webrtc-review.googlesource.com/36340 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21818}
2018-01-30 10:32:13 +01:00
rtc_static_library("default_codec_factory_objc") {
sources = [
"objc/Framework/Classes/PeerConnection/RTCDefaultVideoDecoderFactory.m",
"objc/Framework/Classes/PeerConnection/RTCDefaultVideoEncoderFactory.m",
]
deps = [
":common_objc",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
":native_video",
":videocodec_objc",
ObjC SDK: Stop using built-in SW video codecs This CL removes the use of default built-in SW in the ObjC layer. If a client want to depend on the video SW codecs, they must inject them explicitly. Bug: webrtc:7925 Change-Id: If752e7f02109ff768dc5ec38d935203de85987c2 Reviewed-on: https://webrtc-review.googlesource.com/69800 Commit-Queue: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23073}
2018-04-13 15:36:43 +02:00
":vp8",
":vp9",
Enable building WebRTC without built-in software codecs This CL adds a GN build flag to include builtin software codecs (enabled by default). When setting the flag to false, libvpx can also be excluded. The benefit is that the resulting binary is smaller. Replaces https://webrtc-review.googlesource.com/c/src/+/29203 Bug: webrtc:7925 Change-Id: Id330ea8a43169e449ee139eca18e4557cc932e10 Reviewed-on: https://webrtc-review.googlesource.com/36340 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21818}
2018-01-30 10:32:13 +01:00
]
}
rtc_static_library("vp8") {
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
visibility = [ "*" ]
Break out the part of the iSAC codec that's used for Voice Activity Detection The audio processing code is using parts of the iSAC codec to do voice activity detection (VAD), but it's undesirable for it to pull in the entire iSAC codec as a dependency. So this CL factors out the parts of iSAC that's needed for VAD to a separate build target. Bug: webrtc:8396 Change-Id: I884e25d8fd0bc815fca664352b0573b4b173880e Reviewed-on: https://webrtc-review.googlesource.com/69640 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23110}
2018-04-27 04:31:53 +02:00
allow_poison = [ "software_video_codecs" ]
Enable building WebRTC without built-in software codecs This CL adds a GN build flag to include builtin software codecs (enabled by default). When setting the flag to false, libvpx can also be excluded. The benefit is that the resulting binary is smaller. Replaces https://webrtc-review.googlesource.com/c/src/+/29203 Bug: webrtc:7925 Change-Id: Id330ea8a43169e449ee139eca18e4557cc932e10 Reviewed-on: https://webrtc-review.googlesource.com/36340 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21818}
2018-01-30 10:32:13 +01:00
sources = [
"objc/Framework/Classes/PeerConnection/RTCVideoCodecVP8.mm",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
"objc/Framework/Headers/WebRTC/RTCVideoDecoderVP8.h",
"objc/Framework/Headers/WebRTC/RTCVideoEncoderVP8.h",
Enable building WebRTC without built-in software codecs This CL adds a GN build flag to include builtin software codecs (enabled by default). When setting the flag to false, libvpx can also be excluded. The benefit is that the resulting binary is smaller. Replaces https://webrtc-review.googlesource.com/c/src/+/29203 Bug: webrtc:7925 Change-Id: Id330ea8a43169e449ee139eca18e4557cc932e10 Reviewed-on: https://webrtc-review.googlesource.com/36340 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21818}
2018-01-30 10:32:13 +01:00
]
deps = [
Fix native api in preparation for native_api example. Add native api conversions for video frames and video renderer. This also requires some changes to sdk/BUILD to avoid cyclic dependencies. Bug: webrtc:8832 Change-Id: Ibf21e63bdcae195dcb61d63f9262e6a8dc4fa790 Reviewed-on: https://webrtc-review.googlesource.com/57142 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22340}
2018-03-07 10:32:03 +01:00
":wrapped_native_codec_objc",
Enable building WebRTC without built-in software codecs This CL adds a GN build flag to include builtin software codecs (enabled by default). When setting the flag to false, libvpx can also be excluded. The benefit is that the resulting binary is smaller. Replaces https://webrtc-review.googlesource.com/c/src/+/29203 Bug: webrtc:7925 Change-Id: Id330ea8a43169e449ee139eca18e4557cc932e10 Reviewed-on: https://webrtc-review.googlesource.com/36340 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21818}
2018-01-30 10:32:13 +01:00
"../modules/video_coding:webrtc_vp8",
"../system_wrappers:metrics_default",
]
}
rtc_static_library("vp9") {
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
visibility = [ "*" ]
Break out the part of the iSAC codec that's used for Voice Activity Detection The audio processing code is using parts of the iSAC codec to do voice activity detection (VAD), but it's undesirable for it to pull in the entire iSAC codec as a dependency. So this CL factors out the parts of iSAC that's needed for VAD to a separate build target. Bug: webrtc:8396 Change-Id: I884e25d8fd0bc815fca664352b0573b4b173880e Reviewed-on: https://webrtc-review.googlesource.com/69640 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23110}
2018-04-27 04:31:53 +02:00
allow_poison = [ "software_video_codecs" ]
Enable building WebRTC without built-in software codecs This CL adds a GN build flag to include builtin software codecs (enabled by default). When setting the flag to false, libvpx can also be excluded. The benefit is that the resulting binary is smaller. Replaces https://webrtc-review.googlesource.com/c/src/+/29203 Bug: webrtc:7925 Change-Id: Id330ea8a43169e449ee139eca18e4557cc932e10 Reviewed-on: https://webrtc-review.googlesource.com/36340 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21818}
2018-01-30 10:32:13 +01:00
sources = [
"objc/Framework/Classes/PeerConnection/RTCVideoCodecVP9.mm",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
"objc/Framework/Headers/WebRTC/RTCVideoDecoderVP9.h",
"objc/Framework/Headers/WebRTC/RTCVideoEncoderVP9.h",
Enable building WebRTC without built-in software codecs This CL adds a GN build flag to include builtin software codecs (enabled by default). When setting the flag to false, libvpx can also be excluded. The benefit is that the resulting binary is smaller. Replaces https://webrtc-review.googlesource.com/c/src/+/29203 Bug: webrtc:7925 Change-Id: Id330ea8a43169e449ee139eca18e4557cc932e10 Reviewed-on: https://webrtc-review.googlesource.com/36340 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21818}
2018-01-30 10:32:13 +01:00
]
deps = [
Fix native api in preparation for native_api example. Add native api conversions for video frames and video renderer. This also requires some changes to sdk/BUILD to avoid cyclic dependencies. Bug: webrtc:8832 Change-Id: Ibf21e63bdcae195dcb61d63f9262e6a8dc4fa790 Reviewed-on: https://webrtc-review.googlesource.com/57142 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22340}
2018-03-07 10:32:03 +01:00
":wrapped_native_codec_objc",
Enable building WebRTC without built-in software codecs This CL adds a GN build flag to include builtin software codecs (enabled by default). When setting the flag to false, libvpx can also be excluded. The benefit is that the resulting binary is smaller. Replaces https://webrtc-review.googlesource.com/c/src/+/29203 Bug: webrtc:7925 Change-Id: Id330ea8a43169e449ee139eca18e4557cc932e10 Reviewed-on: https://webrtc-review.googlesource.com/36340 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21818}
2018-01-30 10:32:13 +01:00
"../modules/video_coding:webrtc_vp9",
"../system_wrappers:metrics_default",
]
}
Support building WebRTC without audio and video for IOS. Reorganized the targets in webrtc/sdk/BUILD.gn so that the applications which use WebRTC DataChannel only can depend on the "peerconnection_factory_no_media" instead of "rtc_sdk_objc" to reduce the binary size. Provided a no-media implementation of RTCPeerConnectionFactory using the macro "HAVE_NO_MEDIA". BUG=webrtc:7613 Review-Url: https://codereview.webrtc.org/2944643002 Cr-Commit-Position: refs/heads/master@{#18819}
2017-06-28 14:05:44 -07:00
# Build the PeerConnectionFactory without audio/video support.
# This target depends on the objc_peeerconnectionfactory_base which still
# includes some audio/video related objects such as RTCAudioSource because
# these objects are just thin wrappers of native C++ interfaces required
# when implementing webrtc::PeerConnectionFactoryInterface and
# webrtc::PeerConnectionInterface.
Remove ObjC static library target. It's been unused for a while and starting to be a maintainance burden. Bug: webrtc:8943 Change-Id: Ie49d6b06bdeb002496007725009ea194b8130f2b Reviewed-on: https://webrtc-review.googlesource.com/60160 Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22339}
2018-03-06 10:18:43 +01:00
# The applications which only use WebRTC DataChannel can depend on this.
Rename all objc targets to be suffixed for consistency BUG=webrtc:6412 Review-Url: https://codereview.webrtc.org/3001023003 Cr-Commit-Position: refs/heads/master@{#19489}
2017-08-24 05:43:45 -07:00
rtc_static_library("peerconnectionfactory_no_media_objc") {
Revert "Revert "GN rtc_* templates: Set default visibility to webrtc_root + "/*""" This reverts commit c73e1f437889d882cbf2987f7fb3a029a6150613. Reason for revert: The problem with failed deps in chrome content/renderer had already been fixed in https://webrtc-review.googlesource.com/c/src/+/38660 Original change's description: > Revert "GN rtc_* templates: Set default visibility to webrtc_root + "/*"" > > This reverts commit 588c548657b3ddf76e7b3f241263eef7f5799f16. > > Reason for revert: > > Breaks Chrome FYI: > > /b/c/b/Linux_Builder/src/buildtools/linux64/gn gen //out/Release --check > -> returned 1 > ERROR at //build/split_static_library.gni:12:5: Dependency not allowed. > static_library(target_name) { > ^---------------------------- > The item //content/renderer:renderer > can not depend on //third_party/webrtc/media:rtc_internal_video_codecs > because it is not in //third_party/webrtc/media:rtc_internal_video_codecs's visibility list: [ > //third_party/webrtc/* > //third_party/webrtc_overrides/* > ] > > https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.webrtc.fyi%2FLinux_Builder%2F23560%2F%2B%2Frecipes%2Fsteps%2Fgenerate_build_files%2F0%2Fstdout > > Original change's description: > > GN rtc_* templates: Set default visibility to webrtc_root + "/*" > > > > This means that by default, targets are visible to everything under > > the WebRTC root, but not visible to anything else. > > > > API targets are manually tagged with visibility "*", so that targets > > outside the WebRTC tree can see them. > > > > BUG=webrtc:8254 > > > > Change-Id: Icdbee6e0d22d93240ff2fb530c8f9dc48e351509 > > Reviewed-on: https://webrtc-review.googlesource.com/24140 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#21548} > > TBR=mbonadei@webrtc.org,kwiberg@webrtc.org > > Change-Id: I06620ce3d6f67482935c22efa231dd6cab91625a > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:8254 > Reviewed-on: https://webrtc-review.googlesource.com/38760 > Reviewed-by: Per Kjellander <perkj@webrtc.org> > Commit-Queue: Per Kjellander <perkj@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#21555} TBR=mbonadei@webrtc.org,kwiberg@webrtc.org,perkj@webrtc.org Change-Id: I6f720078ce21bd172e0a6471bae8c4c011e4a657 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:8254 Reviewed-on: https://webrtc-review.googlesource.com/38860 Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Per Kjellander <perkj@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21558}
2018-01-10 15:54:53 +00:00
visibility = [ "*" ]
Mark built-in software video codecs as poisonous. The goal is to make these injectable, and only VP8 and VP9 specific targets should depend on them. Bug: webrtc:7925 Change-Id: Ie9239a54d197fe70c93de0582797211fef6997a2 Reviewed-on: https://webrtc-review.googlesource.com/72082 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23021}
2018-04-24 16:39:05 +02:00
allow_poison = [
"audio_codecs", # TODO(bugs.webrtc.org/8396): Remove.
"software_video_codecs", # TODO(bugs.webrtc.org/7925): Remove.
]
Support building WebRTC without audio and video for IOS. Reorganized the targets in webrtc/sdk/BUILD.gn so that the applications which use WebRTC DataChannel only can depend on the "peerconnection_factory_no_media" instead of "rtc_sdk_objc" to reduce the binary size. Provided a no-media implementation of RTCPeerConnectionFactory using the macro "HAVE_NO_MEDIA". BUG=webrtc:7613 Review-Url: https://codereview.webrtc.org/2944643002 Cr-Commit-Position: refs/heads/master@{#18819}
2017-06-28 14:05:44 -07:00
defines = [ "HAVE_NO_MEDIA" ]
sources = [
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
"objc/Framework/Classes/Common/noop.mm",
Support building WebRTC without audio and video for IOS. Reorganized the targets in webrtc/sdk/BUILD.gn so that the applications which use WebRTC DataChannel only can depend on the "peerconnection_factory_no_media" instead of "rtc_sdk_objc" to reduce the binary size. Provided a no-media implementation of RTCPeerConnectionFactory using the macro "HAVE_NO_MEDIA". BUG=webrtc:7613 Review-Url: https://codereview.webrtc.org/2944643002 Cr-Commit-Position: refs/heads/master@{#18819}
2017-06-28 14:05:44 -07:00
]
Rename all objc targets to be suffixed for consistency BUG=webrtc:6412 Review-Url: https://codereview.webrtc.org/3001023003 Cr-Commit-Position: refs/heads/master@{#19489}
2017-08-24 05:43:45 -07:00
public_configs = [ ":common_config_objc" ]
Support building WebRTC without audio and video for IOS. Reorganized the targets in webrtc/sdk/BUILD.gn so that the applications which use WebRTC DataChannel only can depend on the "peerconnection_factory_no_media" instead of "rtc_sdk_objc" to reduce the binary size. Provided a no-media implementation of RTCPeerConnectionFactory using the macro "HAVE_NO_MEDIA". BUG=webrtc:7613 Review-Url: https://codereview.webrtc.org/2944643002 Cr-Commit-Position: refs/heads/master@{#18819}
2017-06-28 14:05:44 -07:00
deps = [
Create experimental Obj-C++ API. This can be used to wrap Objective-C components in C++ classes, so users can use the WebRTC C++ API directly together with the iOS specific components provided by our SDK. Bug: webrtc:8832 Change-Id: I6d34f7ec62d51df8d3a5340a2e17d30ae73e13e8 Reviewed-on: https://webrtc-review.googlesource.com/46162 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21850}
2018-02-01 15:47:05 +01:00
":native_api",
":native_video",
Rename all objc targets to be suffixed for consistency BUG=webrtc:6412 Review-Url: https://codereview.webrtc.org/3001023003 Cr-Commit-Position: refs/heads/master@{#19489}
2017-08-24 05:43:45 -07:00
":peerconnectionfactory_base_objc",
Support building WebRTC without audio and video for IOS. Reorganized the targets in webrtc/sdk/BUILD.gn so that the applications which use WebRTC DataChannel only can depend on the "peerconnection_factory_no_media" instead of "rtc_sdk_objc" to reduce the binary size. Provided a no-media implementation of RTCPeerConnectionFactory using the macro "HAVE_NO_MEDIA". BUG=webrtc:7613 Review-Url: https://codereview.webrtc.org/2944643002 Cr-Commit-Position: refs/heads/master@{#18819}
2017-06-28 14:05:44 -07:00
"../api:libjingle_peerconnection_api",
Remove remains of webrtc/base All downstream code have been updated to the new location. In PRESUBMIT.py: * Remove webrtc/rtc_base from CPP_BLACKLIST * Add webrtc/rtc_base to LEGACY_API_DIRS Fix some duplicated paths in webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn BUG=webrtc:7634 TBR=kwiberg@webrtc.org Review-Url: https://codereview.webrtc.org/2976293002 Cr-Commit-Position: refs/heads/master@{#19094}
2017-07-19 10:40:47 -07:00
"../rtc_base:rtc_base",
Support building WebRTC without audio and video for IOS. Reorganized the targets in webrtc/sdk/BUILD.gn so that the applications which use WebRTC DataChannel only can depend on the "peerconnection_factory_no_media" instead of "rtc_sdk_objc" to reduce the binary size. Provided a no-media implementation of RTCPeerConnectionFactory using the macro "HAVE_NO_MEDIA". BUG=webrtc:7613 Review-Url: https://codereview.webrtc.org/2944643002 Cr-Commit-Position: refs/heads/master@{#18819}
2017-06-28 14:05:44 -07:00
]
}
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
rtc_static_library("mediaconstraints_objc") {
sources = [
"objc/Framework/Classes/PeerConnection/RTCMediaConstraints+Private.h",
"objc/Framework/Classes/PeerConnection/RTCMediaConstraints.mm",
"objc/Framework/Headers/WebRTC/RTCMediaConstraints.h",
]
public_configs = [ ":common_config_objc" ]
deps = [
":common_objc",
"../api:libjingle_peerconnection_api",
]
}
Fix native api in preparation for native_api example. Add native api conversions for video frames and video renderer. This also requires some changes to sdk/BUILD to avoid cyclic dependencies. Bug: webrtc:8832 Change-Id: Ibf21e63bdcae195dcb61d63f9262e6a8dc4fa790 Reviewed-on: https://webrtc-review.googlesource.com/57142 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22340}
2018-03-07 10:32:03 +01:00
rtc_source_set("videorenderer_objc") {
sources = [
"objc/Framework/Headers/WebRTC/RTCVideoRenderer.h",
]
configs += [ "..:common_objc" ]
visibility = [ "*" ]
public_configs = [ ":common_config_objc" ]
}
rtc_static_library("videorendereradapter_objc") {
GN hack to tag targets as poisonous (and use it with audio codecs) Only specially taggged targets may transitively depend on poisonous targets. We first apply it to audio codecs. This makes it much clearer exactly what parts of the code still have dependencies on the audio codecs (and we want to eventually get rid of pretty much all of them). Bug: webrtc:8396, webrtc:9121 Change-Id: Iba5c2e806c702b5cfe881022674705f647896d43 Reviewed-on: https://webrtc-review.googlesource.com/69520 Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22979}
2018-04-22 19:55:00 +02:00
visibility = [ "*" ]
Mark built-in software video codecs as poisonous. The goal is to make these injectable, and only VP8 and VP9 specific targets should depend on them. Bug: webrtc:7925 Change-Id: Ie9239a54d197fe70c93de0582797211fef6997a2 Reviewed-on: https://webrtc-review.googlesource.com/72082 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23021}
2018-04-24 16:39:05 +02:00
allow_poison = [
"audio_codecs", # TODO(bugs.webrtc.org/8396): Remove.
"software_video_codecs", # TODO(bugs.webrtc.org/7925): Remove.
]
Fix native api in preparation for native_api example. Add native api conversions for video frames and video renderer. This also requires some changes to sdk/BUILD to avoid cyclic dependencies. Bug: webrtc:8832 Change-Id: Ibf21e63bdcae195dcb61d63f9262e6a8dc4fa790 Reviewed-on: https://webrtc-review.googlesource.com/57142 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22340}
2018-03-07 10:32:03 +01:00
sources = [
"objc/Framework/Classes/PeerConnection/RTCVideoRendererAdapter+Private.h",
"objc/Framework/Classes/PeerConnection/RTCVideoRendererAdapter.h",
"objc/Framework/Classes/PeerConnection/RTCVideoRendererAdapter.mm",
]
configs += [ "..:common_objc" ]
public_configs = [ ":common_config_objc" ]
deps = [
":common_objc",
":native_api",
":videoframebuffer_objc",
":videorenderer_objc",
"../api:libjingle_peerconnection_api",
]
}
rtc_static_library("mediasource_objc") {
sources = [
"objc/Framework/Classes/PeerConnection/RTCMediaSource+Private.h",
"objc/Framework/Classes/PeerConnection/RTCMediaSource.mm",
"objc/Framework/Headers/WebRTC/RTCMediaSource.h",
]
Broadcast extension for AppRTCMobile on iOS This provides an environment for testing out using WebRTC from an iOS extension. It implements a ReplayKit broadcast extension for live streaming games and screensharing. The extension is only supported on iOS 11+ and is guarded by a build flag. Bug: webrtc:9335 Change-Id: Id218d6c73ef7599f5953c5a1e0e62e5d0dc4f10b Reviewed-on: https://webrtc-review.googlesource.com/80000 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23504}
2018-06-04 10:24:37 +02:00
configs += [
"..:common_objc",
":used_from_extension",
]
Fix native api in preparation for native_api example. Add native api conversions for video frames and video renderer. This also requires some changes to sdk/BUILD to avoid cyclic dependencies. Bug: webrtc:8832 Change-Id: Ibf21e63bdcae195dcb61d63f9262e6a8dc4fa790 Reviewed-on: https://webrtc-review.googlesource.com/57142 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22340}
2018-03-07 10:32:03 +01:00
public_configs = [ ":common_config_objc" ]
deps = [
":common_objc",
"../api:libjingle_peerconnection_api",
"../rtc_base:checks",
]
}
Rename all objc targets to be suffixed for consistency BUG=webrtc:6412 Review-Url: https://codereview.webrtc.org/3001023003 Cr-Commit-Position: refs/heads/master@{#19489}
2017-08-24 05:43:45 -07:00
rtc_static_library("peerconnectionfactory_base_objc") {
GN hack to tag targets as poisonous (and use it with audio codecs) Only specially taggged targets may transitively depend on poisonous targets. We first apply it to audio codecs. This makes it much clearer exactly what parts of the code still have dependencies on the audio codecs (and we want to eventually get rid of pretty much all of them). Bug: webrtc:8396, webrtc:9121 Change-Id: Iba5c2e806c702b5cfe881022674705f647896d43 Reviewed-on: https://webrtc-review.googlesource.com/69520 Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22979}
2018-04-22 19:55:00 +02:00
visibility = [ "*" ]
Mark built-in software video codecs as poisonous. The goal is to make these injectable, and only VP8 and VP9 specific targets should depend on them. Bug: webrtc:7925 Change-Id: Ie9239a54d197fe70c93de0582797211fef6997a2 Reviewed-on: https://webrtc-review.googlesource.com/72082 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23021}
2018-04-24 16:39:05 +02:00
allow_poison = [
"audio_codecs", # TODO(bugs.webrtc.org/8396): Remove.
"software_video_codecs", # TODO(bugs.webrtc.org/7925): Remove.
]
Support building WebRTC without audio and video for IOS. Reorganized the targets in webrtc/sdk/BUILD.gn so that the applications which use WebRTC DataChannel only can depend on the "peerconnection_factory_no_media" instead of "rtc_sdk_objc" to reduce the binary size. Provided a no-media implementation of RTCPeerConnectionFactory using the macro "HAVE_NO_MEDIA". BUG=webrtc:7613 Review-Url: https://codereview.webrtc.org/2944643002 Cr-Commit-Position: refs/heads/master@{#18819}
2017-06-28 14:05:44 -07:00
sources = [
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
"objc/Framework/Classes/PeerConnection/RTCAudioSource+Private.h",
"objc/Framework/Classes/PeerConnection/RTCAudioSource.mm",
"objc/Framework/Classes/PeerConnection/RTCAudioTrack+Private.h",
"objc/Framework/Classes/PeerConnection/RTCAudioTrack.mm",
Add certificate generate/set functionality to bring iOS closer to JS API The JS API supports two operations which have never been implemented in the iOS counterpart: - generate a new certificate - use this certificate when creating a new PeerConnection Both functions are illustrated in the generateCertificate example code: - https://developer.mozilla.org/en-US/docs/Web/API/RTCPeerConnection/generateCertificate Currently, on iOS, a new certificate is automatically generated for every PeerConnection with no programmatic way to set a specific certificate. Work sponsored by |pipe| Bug: webrtc:9498 Change-Id: Ic1936c3de8b8bd18aef67c784727b72f90e7157c Reviewed-on: https://webrtc-review.googlesource.com/87303 Commit-Queue: Steve Anton <steveanton@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Steve Anton <steveanton@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24276}
2018-07-05 15:28:24 +02:00
"objc/Framework/Classes/PeerConnection/RTCCertificate.mm",
Expose TurnCustomizer as a native ObjC property. Bug: webrtc:8471 Change-Id: Ic0d904b0c3742e552f20fbebb26d55d2bdd76c72 Reviewed-on: https://webrtc-review.googlesource.com/16566 Commit-Queue: Zeke Chin <tkchin@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20481}
2017-10-27 15:42:08 -07:00
"objc/Framework/Classes/PeerConnection/RTCConfiguration+Native.h",
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
"objc/Framework/Classes/PeerConnection/RTCConfiguration+Private.h",
"objc/Framework/Classes/PeerConnection/RTCConfiguration.mm",
"objc/Framework/Classes/PeerConnection/RTCDataChannel+Private.h",
"objc/Framework/Classes/PeerConnection/RTCDataChannel.mm",
"objc/Framework/Classes/PeerConnection/RTCDataChannelConfiguration+Private.h",
"objc/Framework/Classes/PeerConnection/RTCDataChannelConfiguration.mm",
Expose RTCDtmfSender API via RTCRtpSender in ObjC SDK. Expose RTCDtmfSender API for ObcC SDK via exising RTCRtpSender to provide ability to use DTMF tones in ObjC apps which uses WebRTC. Android SDK has already exposed DTMF API via Java's DtmfSender object, there changes provide similar functionaly to ObjC SDK. Bug: webrtc:8713 Change-Id: Id68fddbbc362211dc8032fa31b38812d1cff8ed9 Reviewed-on: https://webrtc-review.googlesource.com/35800 Commit-Queue: Taylor Brandstetter <deadbeef@webrtc.org> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21505}
2018-01-02 14:44:35 +03:00
"objc/Framework/Classes/PeerConnection/RTCDtmfSender+Private.h",
"objc/Framework/Classes/PeerConnection/RTCDtmfSender.mm",
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
"objc/Framework/Classes/PeerConnection/RTCIceCandidate+Private.h",
"objc/Framework/Classes/PeerConnection/RTCIceCandidate.mm",
"objc/Framework/Classes/PeerConnection/RTCIceServer+Private.h",
"objc/Framework/Classes/PeerConnection/RTCIceServer.mm",
Reinstate "iOS - Add iceRegatherIntervalRange." This reverts commit 93adc3209b5ff10adaba54d5eab6b53bc2780685. Reverted originally because it depended on a CL which was reverted. That CL has been reinstated in: https: //chromium-review.googlesource.com/#/c/572070/ Bug: webrtc:7969 Change-Id: I608bbeaaba02e84908433c8260cf236df0307a97 Reviewed-on: https://chromium-review.googlesource.com/572405 Reviewed-by: Zeke Chin <tkchin@webrtc.org> Cr-Commit-Position: refs/heads/master@{#19035}
2017-07-14 16:06:41 -07:00
"objc/Framework/Classes/PeerConnection/RTCIntervalRange+Private.h",
"objc/Framework/Classes/PeerConnection/RTCIntervalRange.mm",
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
"objc/Framework/Classes/PeerConnection/RTCLegacyStatsReport+Private.h",
"objc/Framework/Classes/PeerConnection/RTCLegacyStatsReport.mm",
"objc/Framework/Classes/PeerConnection/RTCMediaStream+Private.h",
"objc/Framework/Classes/PeerConnection/RTCMediaStream.mm",
"objc/Framework/Classes/PeerConnection/RTCMediaStreamTrack+Private.h",
"objc/Framework/Classes/PeerConnection/RTCMediaStreamTrack.mm",
"objc/Framework/Classes/PeerConnection/RTCMetrics.mm",
"objc/Framework/Classes/PeerConnection/RTCMetricsSampleInfo+Private.h",
"objc/Framework/Classes/PeerConnection/RTCMetricsSampleInfo.mm",
"objc/Framework/Classes/PeerConnection/RTCPeerConnection+DataChannel.mm",
Reland ObjC API for BWE allocation strategy Bug: webrtc:8243 Change-Id: Ib1b8349bffe98490ba5f1d12b18e848e89cdb9ce Reviewed-on: https://webrtc-review.googlesource.com/16640 Reviewed-by: Alex Narest <alexnarest@webrtc.org> Commit-Queue: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20534}
2017-10-28 16:26:55 +02:00
"objc/Framework/Classes/PeerConnection/RTCPeerConnection+Native.h",
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
"objc/Framework/Classes/PeerConnection/RTCPeerConnection+Private.h",
"objc/Framework/Classes/PeerConnection/RTCPeerConnection+Stats.mm",
"objc/Framework/Classes/PeerConnection/RTCPeerConnection.mm",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
"objc/Framework/Classes/PeerConnection/RTCPeerConnectionFactory+Native.h",
"objc/Framework/Classes/PeerConnection/RTCPeerConnectionFactory+Private.h",
"objc/Framework/Classes/PeerConnection/RTCPeerConnectionFactory.mm",
Create a peer connection factory builder Similar to the builder on android: https://cs.chromium.org/chromium/src/third_party/webrtc/sdk/android/api/org/webrtc/PeerConnectionFactory.java?rcl=b90e63c620877712e45ee320cfa25cb825bf5373&l=134 1. A builder will allow us to choose what module factories to provide and use default for the others. 2. A helper category is added to provide helpers functions for creating common builders. Bug: None Change-Id: I5889bdd7dc2a2aeded62ef5f2c2381edd07089b3 Reviewed-on: https://webrtc-review.googlesource.com/83280 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23696}
2018-06-20 16:18:59 -07:00
"objc/Framework/Classes/PeerConnection/RTCPeerConnectionFactoryBuilder+DefaultComponents.h",
"objc/Framework/Classes/PeerConnection/RTCPeerConnectionFactoryBuilder+DefaultComponents.mm",
"objc/Framework/Classes/PeerConnection/RTCPeerConnectionFactoryBuilder.h",
"objc/Framework/Classes/PeerConnection/RTCPeerConnectionFactoryBuilder.mm",
Exposed setOptions via RTCPeerConnectionFactory Exposed setOptions API for iOS SDK via RTCPeerConnectionFactory method to provide ability to disable encryption and control which network adapters are ignored. Only subset of webrtc::PeerConnectionFactoryInterface::Options options are exposed via iOS SDK, additional options can be exposed as requested. Android SDK has already exposed setOption API via Java's PeerConnection constructor, there changes provide similar functionaly to iOS SDK. Bug: webrtc:8712 Change-Id: Ia2de38cf382afc1bad9bbec6c6eac21ad29aee89 Reviewed-on: https://webrtc-review.googlesource.com/34900 Commit-Queue: Taylor Brandstetter <deadbeef@webrtc.org> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21504}
2018-01-02 13:33:16 +03:00
"objc/Framework/Classes/PeerConnection/RTCPeerConnectionFactoryOptions+Private.h",
"objc/Framework/Classes/PeerConnection/RTCPeerConnectionFactoryOptions.mm",
Add Rtcp parameters for PeerConnection senders Bug: webrtc:7580 Change-Id: Ibcf5e849a1f11f21fa75f6d006fecf1cd54f8552 Reviewed-on: https://webrtc-review.googlesource.com/78063 Reviewed-by: Sami Kalliomäki <sakal@webrtc.org> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23407}
2018-05-24 16:24:21 +02:00
"objc/Framework/Classes/PeerConnection/RTCRtcpParameters+Private.h",
"objc/Framework/Classes/PeerConnection/RTCRtcpParameters.mm",
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
"objc/Framework/Classes/PeerConnection/RTCRtpCodecParameters+Private.h",
"objc/Framework/Classes/PeerConnection/RTCRtpCodecParameters.mm",
"objc/Framework/Classes/PeerConnection/RTCRtpEncodingParameters+Private.h",
"objc/Framework/Classes/PeerConnection/RTCRtpEncodingParameters.mm",
Add HeaderExtensions to RtpParameters Bug: webrtc:7580 Change-Id: I4fcf3e8bc4975a6b2baa6f24a17c254d2bf521d9 Reviewed-on: https://webrtc-review.googlesource.com/78288 Commit-Queue: Florent Castelli <orphis@webrtc.org> Reviewed-by: Sami Kalliomäki <sakal@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23584}
2018-06-12 18:33:49 +02:00
"objc/Framework/Classes/PeerConnection/RTCRtpHeaderExtension+Private.h",
"objc/Framework/Classes/PeerConnection/RTCRtpHeaderExtension.mm",
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
"objc/Framework/Classes/PeerConnection/RTCRtpParameters+Private.h",
"objc/Framework/Classes/PeerConnection/RTCRtpParameters.mm",
"objc/Framework/Classes/PeerConnection/RTCRtpReceiver+Private.h",
"objc/Framework/Classes/PeerConnection/RTCRtpReceiver.mm",
"objc/Framework/Classes/PeerConnection/RTCRtpSender+Private.h",
"objc/Framework/Classes/PeerConnection/RTCRtpSender.mm",
Add new PeerConnection APIs to the ObjC SDK This CL adds wrappers for the following PeerConnection native APIs to the Objective C API: - SdpSemantics enum added to the RTCConfiguration - RTCRtpTransceiver - RTCPeerConnection.addTrack - RTCPeerConnection.removeTrack - RTCPeerConnection.addTransceiver - RTCPeerConnection.transceivers Bug: webrtc:8870 Change-Id: I9449df9742a59e90894712dc7749ca30b569d94b Reviewed-on: https://webrtc-review.googlesource.com/54780 Commit-Queue: Steve Anton <steveanton@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22214}
2018-02-27 15:34:53 -08:00
"objc/Framework/Classes/PeerConnection/RTCRtpTransceiver+Private.h",
"objc/Framework/Classes/PeerConnection/RTCRtpTransceiver.mm",
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
"objc/Framework/Classes/PeerConnection/RTCSSLAdapter.mm",
"objc/Framework/Classes/PeerConnection/RTCSessionDescription+Private.h",
"objc/Framework/Classes/PeerConnection/RTCSessionDescription.mm",
"objc/Framework/Classes/PeerConnection/RTCTracing.mm",
"objc/Framework/Classes/PeerConnection/RTCVideoTrack+Private.h",
"objc/Framework/Classes/PeerConnection/RTCVideoTrack.mm",
Re-add removed sdk headers to the framework target. Bug: None Change-Id: I67a2463c3995e0d83a6b189712b77c0c322bdf0d Reviewed-on: https://chromium-review.googlesource.com/518942 Commit-Queue: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#18342}
2017-05-31 10:04:55 +02:00
"objc/Framework/Headers/WebRTC/RTCAudioSource.h",
"objc/Framework/Headers/WebRTC/RTCAudioTrack.h",
Add certificate generate/set functionality to bring iOS closer to JS API The JS API supports two operations which have never been implemented in the iOS counterpart: - generate a new certificate - use this certificate when creating a new PeerConnection Both functions are illustrated in the generateCertificate example code: - https://developer.mozilla.org/en-US/docs/Web/API/RTCPeerConnection/generateCertificate Currently, on iOS, a new certificate is automatically generated for every PeerConnection with no programmatic way to set a specific certificate. Work sponsored by |pipe| Bug: webrtc:9498 Change-Id: Ic1936c3de8b8bd18aef67c784727b72f90e7157c Reviewed-on: https://webrtc-review.googlesource.com/87303 Commit-Queue: Steve Anton <steveanton@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Steve Anton <steveanton@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24276}
2018-07-05 15:28:24 +02:00
"objc/Framework/Headers/WebRTC/RTCCertificate.h",
Remove unsupported mac framework target. We don't have a use case for it and have no reason to support it. BUG=webrtc:6706 Review-Url: https://codereview.webrtc.org/2543723004 Cr-Commit-Position: refs/heads/master@{#15428}
2016-12-05 11:27:30 -08:00
"objc/Framework/Headers/WebRTC/RTCConfiguration.h",
"objc/Framework/Headers/WebRTC/RTCDataChannel.h",
"objc/Framework/Headers/WebRTC/RTCDataChannelConfiguration.h",
Expose RTCDtmfSender API via RTCRtpSender in ObjC SDK. Expose RTCDtmfSender API for ObcC SDK via exising RTCRtpSender to provide ability to use DTMF tones in ObjC apps which uses WebRTC. Android SDK has already exposed DTMF API via Java's DtmfSender object, there changes provide similar functionaly to ObjC SDK. Bug: webrtc:8713 Change-Id: Id68fddbbc362211dc8032fa31b38812d1cff8ed9 Reviewed-on: https://webrtc-review.googlesource.com/35800 Commit-Queue: Taylor Brandstetter <deadbeef@webrtc.org> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21505}
2018-01-02 14:44:35 +03:00
"objc/Framework/Headers/WebRTC/RTCDtmfSender.h",
Remove unsupported mac framework target. We don't have a use case for it and have no reason to support it. BUG=webrtc:6706 Review-Url: https://codereview.webrtc.org/2543723004 Cr-Commit-Position: refs/heads/master@{#15428}
2016-12-05 11:27:30 -08:00
"objc/Framework/Headers/WebRTC/RTCIceCandidate.h",
"objc/Framework/Headers/WebRTC/RTCIceServer.h",
Reinstate "iOS - Add iceRegatherIntervalRange." This reverts commit 93adc3209b5ff10adaba54d5eab6b53bc2780685. Reverted originally because it depended on a CL which was reverted. That CL has been reinstated in: https: //chromium-review.googlesource.com/#/c/572070/ Bug: webrtc:7969 Change-Id: I608bbeaaba02e84908433c8260cf236df0307a97 Reviewed-on: https://chromium-review.googlesource.com/572405 Reviewed-by: Zeke Chin <tkchin@webrtc.org> Cr-Commit-Position: refs/heads/master@{#19035}
2017-07-14 16:06:41 -07:00
"objc/Framework/Headers/WebRTC/RTCIntervalRange.h",
Remove unsupported mac framework target. We don't have a use case for it and have no reason to support it. BUG=webrtc:6706 Review-Url: https://codereview.webrtc.org/2543723004 Cr-Commit-Position: refs/heads/master@{#15428}
2016-12-05 11:27:30 -08:00
"objc/Framework/Headers/WebRTC/RTCLegacyStatsReport.h",
"objc/Framework/Headers/WebRTC/RTCMediaStream.h",
"objc/Framework/Headers/WebRTC/RTCMediaStreamTrack.h",
"objc/Framework/Headers/WebRTC/RTCMetrics.h",
"objc/Framework/Headers/WebRTC/RTCMetricsSampleInfo.h",
"objc/Framework/Headers/WebRTC/RTCPeerConnection.h",
"objc/Framework/Headers/WebRTC/RTCPeerConnectionFactory.h",
Exposed setOptions via RTCPeerConnectionFactory Exposed setOptions API for iOS SDK via RTCPeerConnectionFactory method to provide ability to disable encryption and control which network adapters are ignored. Only subset of webrtc::PeerConnectionFactoryInterface::Options options are exposed via iOS SDK, additional options can be exposed as requested. Android SDK has already exposed setOption API via Java's PeerConnection constructor, there changes provide similar functionaly to iOS SDK. Bug: webrtc:8712 Change-Id: Ia2de38cf382afc1bad9bbec6c6eac21ad29aee89 Reviewed-on: https://webrtc-review.googlesource.com/34900 Commit-Queue: Taylor Brandstetter <deadbeef@webrtc.org> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21504}
2018-01-02 13:33:16 +03:00
"objc/Framework/Headers/WebRTC/RTCPeerConnectionFactoryOptions.h",
Add Rtcp parameters for PeerConnection senders Bug: webrtc:7580 Change-Id: Ibcf5e849a1f11f21fa75f6d006fecf1cd54f8552 Reviewed-on: https://webrtc-review.googlesource.com/78063 Reviewed-by: Sami Kalliomäki <sakal@webrtc.org> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23407}
2018-05-24 16:24:21 +02:00
"objc/Framework/Headers/WebRTC/RTCRtcpParameters.h",
Remove unsupported mac framework target. We don't have a use case for it and have no reason to support it. BUG=webrtc:6706 Review-Url: https://codereview.webrtc.org/2543723004 Cr-Commit-Position: refs/heads/master@{#15428}
2016-12-05 11:27:30 -08:00
"objc/Framework/Headers/WebRTC/RTCRtpCodecParameters.h",
"objc/Framework/Headers/WebRTC/RTCRtpEncodingParameters.h",
Add HeaderExtensions to RtpParameters Bug: webrtc:7580 Change-Id: I4fcf3e8bc4975a6b2baa6f24a17c254d2bf521d9 Reviewed-on: https://webrtc-review.googlesource.com/78288 Commit-Queue: Florent Castelli <orphis@webrtc.org> Reviewed-by: Sami Kalliomäki <sakal@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23584}
2018-06-12 18:33:49 +02:00
"objc/Framework/Headers/WebRTC/RTCRtpHeaderExtension.h",
Remove unsupported mac framework target. We don't have a use case for it and have no reason to support it. BUG=webrtc:6706 Review-Url: https://codereview.webrtc.org/2543723004 Cr-Commit-Position: refs/heads/master@{#15428}
2016-12-05 11:27:30 -08:00
"objc/Framework/Headers/WebRTC/RTCRtpParameters.h",
"objc/Framework/Headers/WebRTC/RTCRtpReceiver.h",
"objc/Framework/Headers/WebRTC/RTCRtpSender.h",
Add new PeerConnection APIs to the ObjC SDK This CL adds wrappers for the following PeerConnection native APIs to the Objective C API: - SdpSemantics enum added to the RTCConfiguration - RTCRtpTransceiver - RTCPeerConnection.addTrack - RTCPeerConnection.removeTrack - RTCPeerConnection.addTransceiver - RTCPeerConnection.transceivers Bug: webrtc:8870 Change-Id: I9449df9742a59e90894712dc7749ca30b569d94b Reviewed-on: https://webrtc-review.googlesource.com/54780 Commit-Queue: Steve Anton <steveanton@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22214}
2018-02-27 15:34:53 -08:00
"objc/Framework/Headers/WebRTC/RTCRtpTransceiver.h",
Remove unsupported mac framework target. We don't have a use case for it and have no reason to support it. BUG=webrtc:6706 Review-Url: https://codereview.webrtc.org/2543723004 Cr-Commit-Position: refs/heads/master@{#15428}
2016-12-05 11:27:30 -08:00
"objc/Framework/Headers/WebRTC/RTCSSLAdapter.h",
"objc/Framework/Headers/WebRTC/RTCSessionDescription.h",
"objc/Framework/Headers/WebRTC/RTCTracing.h",
"objc/Framework/Headers/WebRTC/RTCVideoTrack.h",
]
[GN] Add rtc_sdk_framework_objc target to GN The build artifacts don't look completely identical to the ones generated by the GYP targets, but manual review shows the same symbols are exported. On iOS, the version generated by the GN follows convention, including a "Headers" directory, and the .modulemap file. I think this is preferred over the gyp version. BUG=webrtc:6320 NOTRY=True TESTED=Run AppRTCDemo on iOS + Mac and verified with nm that they export the same symbols. Review-Url: https://codereview.webrtc.org/2340633003 Cr-Commit-Position: refs/heads/master@{#14228}
2016-09-15 04:30:18 -07:00
Broadcast extension for AppRTCMobile on iOS This provides an environment for testing out using WebRTC from an iOS extension. It implements a ReplayKit broadcast extension for live streaming games and screensharing. The extension is only supported on iOS 11+ and is guarded by a build flag. Bug: webrtc:9335 Change-Id: Id218d6c73ef7599f5953c5a1e0e62e5d0dc4f10b Reviewed-on: https://webrtc-review.googlesource.com/80000 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23504}
2018-06-04 10:24:37 +02:00
configs += [
"..:common_objc",
":used_from_extension",
]
Rename all objc targets to be suffixed for consistency BUG=webrtc:6412 Review-Url: https://codereview.webrtc.org/3001023003 Cr-Commit-Position: refs/heads/master@{#19489}
2017-08-24 05:43:45 -07:00
public_configs = [ ":common_config_objc" ]
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
[GN] Add rtc_sdk_framework_objc target to GN The build artifacts don't look completely identical to the ones generated by the GYP targets, but manual review shows the same symbols are exported. On iOS, the version generated by the GN follows convention, including a "Headers" directory, and the .modulemap file. I think this is preferred over the gyp version. BUG=webrtc:6320 NOTRY=True TESTED=Run AppRTCDemo on iOS + Mac and verified with nm that they export the same symbols. Review-Url: https://codereview.webrtc.org/2340633003 Cr-Commit-Position: refs/heads/master@{#14228}
2016-09-15 04:30:18 -07:00
deps = [
Rename all objc targets to be suffixed for consistency BUG=webrtc:6412 Review-Url: https://codereview.webrtc.org/3001023003 Cr-Commit-Position: refs/heads/master@{#19489}
2017-08-24 05:43:45 -07:00
":common_objc",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
":mediaconstraints_objc",
Fix native api in preparation for native_api example. Add native api conversions for video frames and video renderer. This also requires some changes to sdk/BUILD to avoid cyclic dependencies. Bug: webrtc:8832 Change-Id: Ibf21e63bdcae195dcb61d63f9262e6a8dc4fa790 Reviewed-on: https://webrtc-review.googlesource.com/57142 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22340}
2018-03-07 10:32:03 +01:00
":mediasource_objc",
Create experimental Obj-C++ API. This can be used to wrap Objective-C components in C++ classes, so users can use the WebRTC C++ API directly together with the iOS specific components provided by our SDK. Bug: webrtc:8832 Change-Id: I6d34f7ec62d51df8d3a5340a2e17d30ae73e13e8 Reviewed-on: https://webrtc-review.googlesource.com/46162 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21850}
2018-02-01 15:47:05 +01:00
":native_api",
":native_video",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
":video_objc",
":videocodec_objc",
":videoframebuffer_objc",
Fix native api in preparation for native_api example. Add native api conversions for video frames and video renderer. This also requires some changes to sdk/BUILD to avoid cyclic dependencies. Bug: webrtc:8832 Change-Id: Ibf21e63bdcae195dcb61d63f9262e6a8dc4fa790 Reviewed-on: https://webrtc-review.googlesource.com/57142 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22340}
2018-03-07 10:32:03 +01:00
":videorenderer_objc",
":videorendereradapter_objc",
":videosource_objc",
Stop using public_deps in pc/. TBR=phoglund@webrtc.org Bug: webrtc:8603 Change-Id: If18e5a4d212392bbd9b4e1f9c2f00ee79a2ab348 No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/29864 Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21139}
2017-12-06 11:23:19 +01:00
"../api:libjingle_peerconnection_api",
Create a peer connection factory builder Similar to the builder on android: https://cs.chromium.org/chromium/src/third_party/webrtc/sdk/android/api/org/webrtc/PeerConnectionFactory.java?rcl=b90e63c620877712e45ee320cfa25cb825bf5373&l=134 1. A builder will allow us to choose what module factories to provide and use default for the others. 2. A helper category is added to provide helpers functions for creating common builders. Bug: None Change-Id: I5889bdd7dc2a2aeded62ef5f2c2381edd07089b3 Reviewed-on: https://webrtc-review.googlesource.com/83280 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23696}
2018-06-20 16:18:59 -07:00
"../api/audio_codecs:audio_codecs_api",
AudioCodingModule::Create(): Require caller to supply an AudioDecoderFactory So that we don't have to be capable of creating one ourselves, which requires a dependency on the audio decoders. BUG=webrtc:5801, webrtc:8396 Change-Id: I80749ec3b86cba73994307046d05964f59167d44 Reviewed-on: https://webrtc-review.googlesource.com/18440 Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Oskar Sundbom <ossu@webrtc.org> Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22774}
2018-04-06 10:06:42 +02:00
"../api/audio_codecs:builtin_audio_decoder_factory",
Create a peer connection factory builder Similar to the builder on android: https://cs.chromium.org/chromium/src/third_party/webrtc/sdk/android/api/org/webrtc/PeerConnectionFactory.java?rcl=b90e63c620877712e45ee320cfa25cb825bf5373&l=134 1. A builder will allow us to choose what module factories to provide and use default for the others. 2. A helper category is added to provide helpers functions for creating common builders. Bug: None Change-Id: I5889bdd7dc2a2aeded62ef5f2c2381edd07089b3 Reviewed-on: https://webrtc-review.googlesource.com/83280 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23696}
2018-06-20 16:18:59 -07:00
"../api/audio_codecs:builtin_audio_encoder_factory",
New file api/video/BUILD.gn Build targets involving files under api/video/ are moved into this file, from api/BUILD.gn. In addition, drop "_api" part of target names, and move the header file api/videosinkinterface.h to api/video/video_sink_interface.h. Bug: webrtc:9253 Change-Id: I2896d3f063db8dff902bc29738578395b2fcc155 Reviewed-on: https://webrtc-review.googlesource.com/75500 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23207}
2018-05-11 11:15:30 +02:00
"../api/video:video_frame",
Injectable software video codecs in Obj-C. When injecting video codec factories in the Obj-C SDK, use the new peer connection API that uses webrtc::Video{De,En}CoderFactory classes and does not automatically add internal software codecs. Instead the injected factory can support internal VP8 and VP9 codecs through the included Obj-C classes RTCVideo{De,En}coderVP{8,9}. When not explicitly injecting any video codec factory, the old code path is still used and injects only H264 as an external codec and the internal codec factory is used. Bug: webrtc:7925 Change-Id: I657d30dfde71da9c0be341e213ab9f97a04caa58 Reviewed-on: https://webrtc-review.googlesource.com/3620 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20175}
2017-10-05 16:55:38 +02:00
"../api/video_codecs:video_codecs_api",
Revert "Revert "Revert "Revert "Support more formats in RTCVideoFrame"""" This reverts commit 1cfeb435427a2fa677a495e34c882096efc193d0. Reason for revert: Fix unit test Original change's description: > Revert "Revert "Revert "Support more formats in RTCVideoFrame""" > > This reverts commit 7583390d1a3a7c4e9a77da0d77250abac0c34d1d. > > Reason for revert: Breaks unit tests > > Original change's description: > > Revert "Revert "Support more formats in RTCVideoFrame"" > > > > This reverts commit 0789dab2cbd1617e94d7300e375163d42345f3d4. > > > > Reason for revert: Include obc_corevideoframebuffer target > > > > Original change's description: > > > Revert "Support more formats in RTCVideoFrame" > > > > > > This reverts commit bd2220a9c496ef2e8567b68d4be9435a110bdc34. > > > > > > Reason for revert: Broke external clients > > > > > > Original change's description: > > > > Support more formats in RTCVideoFrame > > > > > > > > Implement Obj-C version of webrtc::VideoFrameBuffer and use that in > > > > RTCVideoFrame. > > > > > > > > Bug: webrtc:7785 > > > > Change-Id: I49f42bcf451dd6769b3a79a65fe7b400dce22677 > > > > Reviewed-on: https://chromium-review.googlesource.com/536773 > > > > Commit-Queue: Anders Carlsson <andersc@webrtc.org> > > > > Reviewed-by: Magnus Jedvert <magjed@webrtc.org> > > > > Cr-Commit-Position: refs/heads/master@{#18691} > > > > > > TBR=magjed@webrtc.org,andersc@webrtc.org > > > > > > Change-Id: Id765dd9543ed0613a6b2de108b268c3501025fcd > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: webrtc:7785 > > > Reviewed-on: https://chromium-review.googlesource.com/542837 > > > Reviewed-by: Anders Carlsson <andersc@webrtc.org> > > > Commit-Queue: Anders Carlsson <andersc@webrtc.org> > > > Cr-Commit-Position: refs/heads/master@{#18697} > > > > TBR=magjed@webrtc.org,andersc@webrtc.org > > > > Change-Id: I1ef5313b4a6c56eb8c7fd02d95db62c4e3c00255 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: webrtc:7785 > > Reviewed-on: https://chromium-review.googlesource.com/542838 > > Commit-Queue: Anders Carlsson <andersc@webrtc.org> > > Reviewed-by: Anders Carlsson <andersc@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#18716} > > TBR=magjed@webrtc.org,andersc@webrtc.org > > Change-Id: Id12f33698eb02041607cb9a5c54f37f01bfac5b1 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:7785 > Reviewed-on: https://chromium-review.googlesource.com/544840 > Reviewed-by: Anders Carlsson <andersc@webrtc.org> > Commit-Queue: Anders Carlsson <andersc@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#18718} TBR=magjed@webrtc.org,andersc@webrtc.org Change-Id: I184303ecba8db91ef7de709f982a295a2efe92eb Bug: webrtc:7785 Reviewed-on: https://chromium-review.googlesource.com/544841 Commit-Queue: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#18731}
2017-06-22 15:26:30 +02:00
"../common_video",
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
"../media:rtc_media_base",
Reland of Injectable Obj-C video codecs (patchset #1 id:1 of https://codereview.webrtc.org/2980173002/ ) Reason for revert: Relanding after fixing issues with no video. Original issue's description: > Revert of Injectable Obj-C video codecs (patchset #2 id:370001 of https://codereview.webrtc.org/2979983002/ ) > > Reason for revert: > Still having problems with no video. Reverting. > Once no video is visible, no video is available from then on even if the callee app is in the foreground. > > > Original issue's description: > > Reland of Injectable Obj-C video codecs (patchset #1 id:1 of https://codereview.webrtc.org/2979973002/ ) > > > > Reason for revert: > > Fix the broken build file > > > > Original issue's description: > > > Revert of Injectable Obj-C video codecs (patchset #3 id:400001 of https://codereview.webrtc.org/2981583002/ ) > > > > > > Reason for revert: > > > Breaks bots. Build file incorrect. > > > > > > Original issue's description: > > > > Reland of Injectable Obj-C video codecs (patchset #1 id:1 of https://codereview.webrtc.org/2975963002/ ) > > > > > > > > Reason for revert: > > > > New CL for fixing the issues > > > > > > > > Original issue's description: > > > > > Revert of Injectable Obj-C video codecs (patchset #8 id:140001 of https://codereview.webrtc.org/2966023002/ ) > > > > > > > > > > Reason for revert: > > > > > Causes no video in certain scenarios. Please come up with a test plan or unit test to prevent such problems in the future. > > > > > > > > > > Original issue's description: > > > > > > Injectable Obj-C video codecs > > > > > > > > > > > > Initial CL for this effort, with a working RTCVideoEncoder/Decoder for H264 > > > > > > (wrapping the VideoToolbox codec). > > > > > > > > > > > > Some notes / things left to do: > > > > > > - There are some hard-coded references to codec types that are supported by > > > > > > webrtc::VideoCodec, cricket::VideoCodec, webrtc::CodecSpecificInfo etc > > > > > > since we need to convert to/from these types in ObjCVideoEncoder/Decoder. > > > > > > These types would need to be more codec agnostic to avoid this. > > > > > > - Most interfaces are borrowed from the design document for injectable > > > > > > codecs in Android. Some data in the corresponding C++ classes is discarded > > > > > > when converting to the Obj-C version, since it has fewer fields. I have not > > > > > > verified whether all data that we do keep is needed, or whether we might be > > > > > > losing anything useful in these conversions. > > > > > > - Implement the VideoToolbox codec code directly in the RTCVideoEncoderH264 > > > > > > classes, instead of wrapping webrtc::H264VideoToolboxEncoder / decoder. > > > > > > Eliminates converting between ObjC/C++ types outside the ObjCVideoEncoder/ > > > > > > Decoder wrapper classes. > > > > > > - List the injected codec factory's supported codecs in the list of codecs in > > > > > > AppRTCMobile. > > > > > > > > > > > > BUG=webrtc:7924 > > > > > > R=magjed@webrtc.org > > > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2966023002 . > > > > > > Cr-Commit-Position: refs/heads/master@{#18928} > > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/a0349c138db62c52435be84b6c837f5f4758e264 > > > > > > > > > > TBR=magjed@webrtc.org,andersc@webrtc.org > > > > > # Not skipping CQ checks because original CL landed more than 1 days ago. > > > > > BUG=webrtc:7924 > > > > > NOTRY=true > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2975963002 > > > > > Cr-Commit-Position: refs/heads/master@{#18979} > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/1095ada7ad56fe29b7b2bbc560a8f6475a7978ce > > > > > > > > R=magjed@webrtc.org > > > > TBR=tkchin@webrtc.org > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > NOPRESUBMIT=true > > > > NOTREECHECKS=true > > > > NOTRY=true > > > > BUG=webrtc:7924 > > > > > > > > Review-Url: https://codereview.webrtc.org/2981583002 . > > > > Cr-Commit-Position: refs/heads/master@{#19002} > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/a5f1de1e6541de03f944bcbf49be87c01f57a18b > > > > > > TBR=magjed@webrtc.org,tkchin@webrtc.org,jtteh@webrtc.org,andersc@webrtc.org > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > NOPRESUBMIT=true > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG=webrtc:7924 > > > > > > Review-Url: https://codereview.webrtc.org/2979973002 > > > Cr-Commit-Position: refs/heads/master@{#19004} > > > Committed: https://chromium.googlesource.com/external/webrtc/+/81d40ee1491d5229c2677cc04b1f40d67c2babef > > > > TBR=magjed@webrtc.org,tkchin@webrtc.org,jtteh@webrtc.org,sprang@webrtc.org > > BUG=webrtc:7924 > > > > Review-Url: https://codereview.webrtc.org/2979983002 > > Cr-Commit-Position: refs/heads/master@{#19005} > > Committed: https://chromium.googlesource.com/external/webrtc/+/732a3437da4db7b452758b8e1cf26fce0ce3bf65 > > TBR=magjed@webrtc.org,tkchin@webrtc.org,sprang@webrtc.org,haysc@webrtc.org,andersc@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:7924 > > Review-Url: https://codereview.webrtc.org/2980173002 > Cr-Commit-Position: refs/heads/master@{#19036} > Committed: https://chromium.googlesource.com/external/webrtc/+/860f7298166084d966749e22b69aa2fdcf4d4ed6 TBR=magjed@webrtc.org,tkchin@webrtc.org,sprang@webrtc.org,haysc@webrtc.org,andersc@webrtc.org,jtteh@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:7924 Review-Url: https://codereview.webrtc.org/2977213002 Cr-Commit-Position: refs/heads/master@{#19135}
2017-07-25 07:55:58 -07:00
"../modules:module_api",
Create a peer connection factory builder Similar to the builder on android: https://cs.chromium.org/chromium/src/third_party/webrtc/sdk/android/api/org/webrtc/PeerConnectionFactory.java?rcl=b90e63c620877712e45ee320cfa25cb825bf5373&l=134 1. A builder will allow us to choose what module factories to provide and use default for the others. 2. A helper category is added to provide helpers functions for creating common builders. Bug: None Change-Id: I5889bdd7dc2a2aeded62ef5f2c2381edd07089b3 Reviewed-on: https://webrtc-review.googlesource.com/83280 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23696}
2018-06-20 16:18:59 -07:00
"../modules/audio_device:audio_device_api",
"../modules/audio_processing:audio_processing",
Add untracked headers to video_coding. This creates a new target for pure defines and interfaces. I think that makes sense (though include/ makes it harder to see when .cc and .h files should live together). Bug: webrtc:7620 Change-Id: Ifb0f50faf99166202836c0446feed3443eb52c6e Reviewed-on: https://webrtc-review.googlesource.com/34657 Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21516}
2018-01-08 11:05:10 +01:00
"../modules/video_coding:video_codec_interface",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
"../pc:create_pc_factory",
Support building WebRTC without audio and video for IOS. Reorganized the targets in webrtc/sdk/BUILD.gn so that the applications which use WebRTC DataChannel only can depend on the "peerconnection_factory_no_media" instead of "rtc_sdk_objc" to reduce the binary size. Provided a no-media implementation of RTCPeerConnectionFactory using the macro "HAVE_NO_MEDIA". BUG=webrtc:7613 Review-Url: https://codereview.webrtc.org/2944643002 Cr-Commit-Position: refs/heads/master@{#18819}
2017-06-28 14:05:44 -07:00
"../pc:peerconnection",
Fix circular dependencies between optional, array_view, and rtc_base. This splits things out of rtc_base and makes dependencies explicit. Bug: webrtc:6828 Change-Id: Id521896c3c43595349021c857bec216e429a0c8d Reviewed-on: https://webrtc-review.googlesource.com/32780 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21264}
2017-12-13 16:05:42 +01:00
"../rtc_base:checks",
Remove remains of webrtc/base All downstream code have been updated to the new location. In PRESUBMIT.py: * Remove webrtc/rtc_base from CPP_BLACKLIST * Add webrtc/rtc_base to LEGACY_API_DIRS Fix some duplicated paths in webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn BUG=webrtc:7634 TBR=kwiberg@webrtc.org Review-Url: https://codereview.webrtc.org/2976293002 Cr-Commit-Position: refs/heads/master@{#19094}
2017-07-19 10:40:47 -07:00
"../rtc_base:rtc_base",
Add missing dependencies on //third_party/abseil-cpp/absl/memory. Abseil uses -isystem and -imsvc because of some warnings, these two flags are not used by "gn check", this introduced some regressions. CL https://chromium-review.googlesource.com/c/chromium/src/+/1124478 will try to switch back absl to -I. Bug: None Change-Id: I52e857ef1d11831393c35a1bee09479b83827bad Reviewed-on: https://webrtc-review.googlesource.com/88121 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23923}
2018-07-11 09:18:37 +02:00
"//third_party/abseil-cpp/absl/memory",
[GN] Add rtc_sdk_framework_objc target to GN The build artifacts don't look completely identical to the ones generated by the GYP targets, but manual review shows the same symbols are exported. On iOS, the version generated by the GN follows convention, including a "Headers" directory, and the .modulemap file. I think this is preferred over the gyp version. BUG=webrtc:6320 NOTRY=True TESTED=Run AppRTCDemo on iOS + Mac and verified with nm that they export the same symbols. Review-Url: https://codereview.webrtc.org/2340633003 Cr-Commit-Position: refs/heads/master@{#14228}
2016-09-15 04:30:18 -07:00
]
Moving iOS Audio Device to sdk. This change forks the existing iOS audio device module and audio device from modules/audio_device/ into sdk/objc/Framework. It also updates RTCPeerConnectionFactory to use the forked implementation. The unit tests are re-implemented as XCTests. (was: https://webrtc-review.googlesource.com/c/src/+/67300) Bug: webrtc:9120 Change-Id: I46c09900246f75ca5285aeb38f7b8b295784ffac Reviewed-on: https://webrtc-review.googlesource.com/76741 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Commit-Queue: Peter Hanspers <peterhanspers@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23238}
2018-05-15 10:22:36 +02:00
if (is_ios) {
deps += [ ":native_api_audio_device_module" ]
}
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
}
Reland of GN: Enable ARC for Mac and iOS in rtc_* templates (patchset #1 id:1 of https://codereview.webrtc.org/2827223003/ ) Reason for revert: Relanding after fixing ARC issue. Original issue's description: > Revert of GN: Enable ARC for Mac and iOS in rtc_* templates (patchset #3 id:40001 of https://codereview.webrtc.org/2781713004/ ) > > Reason for revert: > Breaks mac build > > Original issue's description: > > GN: Enable ARC for Mac and iOS in rtc_* templates > > > > Remove all uses of retain/release and NSAutoreleasePool. > > > > This makes transformation to Bazel easier. > > > > This CL subsumes https://codereview.webrtc.org/2778163002 and depends on https://codereview.webrtc.org/2784483002/ > > > > BUG=webrtc:6412 > > > > Review-Url: https://codereview.webrtc.org/2781713004 > > Cr-Commit-Position: refs/heads/master@{#17780} > > Committed: https://chromium.googlesource.com/external/webrtc/+/6bda02b51dc00401d2a0d04be996ed10e5acac47 > > TBR=kjellander@webrtc.org,magjed@webrtc.org,stefan@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6412 > > Review-Url: https://codereview.webrtc.org/2827223003 > Cr-Commit-Position: refs/heads/master@{#17784} > Committed: https://chromium.googlesource.com/external/webrtc/+/7c8786ae8f2d8481f74b0ab16eb91a8101fe51dc TBR=kjellander@webrtc.org,magjed@webrtc.org,stefan@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6412 Review-Url: https://codereview.webrtc.org/2834273002 Cr-Commit-Position: refs/heads/master@{#17836}
2017-04-24 00:57:16 -07:00
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
if (rtc_include_tests) {
Reland "Add file capturer to AppRTCMobile on simulator." This is a reland of 5adcd198752b651f7b7e9199a91f9b873b7d7237 Original change's description: > Add file capturer to AppRTCMobile on simulator. > > To achieve this, the CL does the following > - Adds sample mp4 video > - Refactors the existing RTCFileVideoCapturer to achieve continious > capture and adds tests. > > Bug: webrtc:8406 > Change-Id: Ibc0891176c58ec9053b42e340d2113036e7199ec > Reviewed-on: https://webrtc-review.googlesource.com/12180 > Reviewed-by: Anders Carlsson <andersc@webrtc.org> > Reviewed-by: Magnus Jedvert <magjed@webrtc.org> > Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#20598} Bug: webrtc:8406 Change-Id: I93be89b86e342a9a8195e19ebaf4aef1410d2c20 Reviewed-on: https://webrtc-review.googlesource.com/23200 Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20870}
2017-11-15 13:15:24 +01:00
if (is_ios) {
Add xctest target to migrate sdk/objc/Framework to it. This CL adds all the scaffolding needed to support xctest target in sdk/objc/Framework and adds the target to the bot configuration. The benefits of this are two-fold. 1. We'll separate framework unittests from their current target, `rtc_unittests`, that has many many other tests. This way framework unit tests will have nice, compact, selfcontained target. 2. We'll harvest the power of XCTest (native testing framework) that should hopefully make adding and writing objc tests easier. This CL migrates only one test to prove the setup works. More tests will be migrated in follow up cls. Bug: webrtc:8382 Change-Id: I0b5b9596c2a6d91683d13632323441de1aa461e0 Reviewed-on: https://webrtc-review.googlesource.com/8501 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org> Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org> Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20289}
2017-10-12 13:46:00 +02:00
rtc_source_set("sdk_unittests_sources") {
testonly = true
include_dirs = [
"objc/Framework/Headers",
"objc/Framework/Classes",
]
Reland "Add file capturer to AppRTCMobile on simulator." This is a reland of 5adcd198752b651f7b7e9199a91f9b873b7d7237 Original change's description: > Add file capturer to AppRTCMobile on simulator. > > To achieve this, the CL does the following > - Adds sample mp4 video > - Refactors the existing RTCFileVideoCapturer to achieve continious > capture and adds tests. > > Bug: webrtc:8406 > Change-Id: Ibc0891176c58ec9053b42e340d2113036e7199ec > Reviewed-on: https://webrtc-review.googlesource.com/12180 > Reviewed-by: Anders Carlsson <andersc@webrtc.org> > Reviewed-by: Magnus Jedvert <magjed@webrtc.org> > Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#20598} Bug: webrtc:8406 Change-Id: I93be89b86e342a9a8195e19ebaf4aef1410d2c20 Reviewed-on: https://webrtc-review.googlesource.com/23200 Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20870}
2017-11-15 13:15:24 +01:00
Add xctest target to migrate sdk/objc/Framework to it. This CL adds all the scaffolding needed to support xctest target in sdk/objc/Framework and adds the target to the bot configuration. The benefits of this are two-fold. 1. We'll separate framework unittests from their current target, `rtc_unittests`, that has many many other tests. This way framework unit tests will have nice, compact, selfcontained target. 2. We'll harvest the power of XCTest (native testing framework) that should hopefully make adding and writing objc tests easier. This CL migrates only one test to prove the setup works. More tests will be migrated in follow up cls. Bug: webrtc:8382 Change-Id: I0b5b9596c2a6d91683d13632323441de1aa461e0 Reviewed-on: https://webrtc-review.googlesource.com/8501 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org> Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org> Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20289}
2017-10-12 13:46:00 +02:00
sources = [
Reland "Add unit tests for RTCCVPixelBuffer and ObjCVideoTrackSource." This is a reland of 4ea50c2b421ae3e40d1d02b8eb8c5802288b181e Original change's description: > Add unit tests for RTCCVPixelBuffer and ObjCVideoTrackSource. > > This CL also fixes a couple of bugs found in the toI420 method for > RTCCVPixelBuffers backed by RGB CVPixelBuffers. > > Bug: webrtc:9007 > Change-Id: I19ab8177f4b124a503cfda9f0166bd960f668982 > Reviewed-on: https://webrtc-review.googlesource.com/64940 > Commit-Queue: Anders Carlsson <andersc@webrtc.org> > Reviewed-by: Kári Helgason <kthelgason@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#22656} Bug: webrtc:9007 Change-Id: I2a787c64f8d23ffc4ef2419fc258d965f8a9480b Reviewed-on: https://webrtc-review.googlesource.com/66341 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22706}
2018-04-03 11:40:39 +02:00
"objc/Framework/UnitTests/ObjCVideoTrackSource_xctest.mm",
"objc/Framework/UnitTests/RTCCVPixelBuffer_xctest.mm",
Add new Logger to iOS SDK to be able to intercept logs and report them to the appropriate system Bug: webrtc:8695 Change-Id: I4f81529222dcaf3dded1a0ab93fabf5cda1fdef8 Reviewed-on: https://webrtc-review.googlesource.com/37001 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21821}
2018-01-30 15:46:13 +01:00
"objc/Framework/UnitTests/RTCCallbackLogger_xctest.m",
Adding test to check for c++ in framework headers. Bug: webrtc:8469 Change-Id: I336a2aa75638920901c2bddf07fb03cb00ccb83e Reviewed-on: https://webrtc-review.googlesource.com/38020 Commit-Queue: Peter Hanspers <peterhanspers@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21536}
2018-01-09 14:26:41 +01:00
"objc/Framework/UnitTests/RTCDoNotPutCPlusPlusInFrameworkHeaders_xctest.m",
Reland "Add file capturer to AppRTCMobile on simulator." This is a reland of 5adcd198752b651f7b7e9199a91f9b873b7d7237 Original change's description: > Add file capturer to AppRTCMobile on simulator. > > To achieve this, the CL does the following > - Adds sample mp4 video > - Refactors the existing RTCFileVideoCapturer to achieve continious > capture and adds tests. > > Bug: webrtc:8406 > Change-Id: Ibc0891176c58ec9053b42e340d2113036e7199ec > Reviewed-on: https://webrtc-review.googlesource.com/12180 > Reviewed-by: Anders Carlsson <andersc@webrtc.org> > Reviewed-by: Magnus Jedvert <magjed@webrtc.org> > Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#20598} Bug: webrtc:8406 Change-Id: I93be89b86e342a9a8195e19ebaf4aef1410d2c20 Reviewed-on: https://webrtc-review.googlesource.com/23200 Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20870}
2017-11-15 13:15:24 +01:00
"objc/Framework/UnitTests/RTCFileVideoCapturer_xctest.mm",
Obj-C SDK for parsing and generating H264 ProfileLevelIds. Expose this functionality in the Obj-C SDK to make it nicer to use for Obj-C clients. Bug: None Change-Id: I5cb511af8799ac0fda15153d16f2550b848b93b2 Reviewed-on: https://webrtc-review.googlesource.com/80481 Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23488}
2018-06-01 12:51:09 +02:00
"objc/Framework/UnitTests/RTCH264ProfileLevelId_xctest.m",
Fixed crash when PCF is destroyed before PC in ObjC Bug: webrtc:9231 Change-Id: Iaf18257b8f38fa786d462bca5f860f9a7b1cc2d0 Reviewed-on: https://webrtc-review.googlesource.com/78800 Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23674}
2018-06-19 12:51:51 +03:00
"objc/Framework/UnitTests/RTCPeerConnectionFactory_xctest.m",
Reland "Add unit tests for RTCCVPixelBuffer and ObjCVideoTrackSource." This is a reland of 4ea50c2b421ae3e40d1d02b8eb8c5802288b181e Original change's description: > Add unit tests for RTCCVPixelBuffer and ObjCVideoTrackSource. > > This CL also fixes a couple of bugs found in the toI420 method for > RTCCVPixelBuffers backed by RGB CVPixelBuffers. > > Bug: webrtc:9007 > Change-Id: I19ab8177f4b124a503cfda9f0166bd960f668982 > Reviewed-on: https://webrtc-review.googlesource.com/64940 > Commit-Queue: Anders Carlsson <andersc@webrtc.org> > Reviewed-by: Kári Helgason <kthelgason@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#22656} Bug: webrtc:9007 Change-Id: I2a787c64f8d23ffc4ef2419fc258d965f8a9480b Reviewed-on: https://webrtc-review.googlesource.com/66341 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22706}
2018-04-03 11:40:39 +02:00
"objc/Framework/UnitTests/frame_buffer_helpers.h",
"objc/Framework/UnitTests/frame_buffer_helpers.mm",
Add xctest target to migrate sdk/objc/Framework to it. This CL adds all the scaffolding needed to support xctest target in sdk/objc/Framework and adds the target to the bot configuration. The benefits of this are two-fold. 1. We'll separate framework unittests from their current target, `rtc_unittests`, that has many many other tests. This way framework unit tests will have nice, compact, selfcontained target. 2. We'll harvest the power of XCTest (native testing framework) that should hopefully make adding and writing objc tests easier. This CL migrates only one test to prove the setup works. More tests will be migrated in follow up cls. Bug: webrtc:8382 Change-Id: I0b5b9596c2a6d91683d13632323441de1aa461e0 Reviewed-on: https://webrtc-review.googlesource.com/8501 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org> Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org> Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20289}
2017-10-12 13:46:00 +02:00
]
Reland "Add file capturer to AppRTCMobile on simulator." This is a reland of 5adcd198752b651f7b7e9199a91f9b873b7d7237 Original change's description: > Add file capturer to AppRTCMobile on simulator. > > To achieve this, the CL does the following > - Adds sample mp4 video > - Refactors the existing RTCFileVideoCapturer to achieve continious > capture and adds tests. > > Bug: webrtc:8406 > Change-Id: Ibc0891176c58ec9053b42e340d2113036e7199ec > Reviewed-on: https://webrtc-review.googlesource.com/12180 > Reviewed-by: Anders Carlsson <andersc@webrtc.org> > Reviewed-by: Magnus Jedvert <magjed@webrtc.org> > Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#20598} Bug: webrtc:8406 Change-Id: I93be89b86e342a9a8195e19ebaf4aef1410d2c20 Reviewed-on: https://webrtc-review.googlesource.com/23200 Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20870}
2017-11-15 13:15:24 +01:00
Moving iOS Audio Device to sdk. This change forks the existing iOS audio device module and audio device from modules/audio_device/ into sdk/objc/Framework. It also updates RTCPeerConnectionFactory to use the forked implementation. The unit tests are re-implemented as XCTests. (was: https://webrtc-review.googlesource.com/c/src/+/67300) Bug: webrtc:9120 Change-Id: I46c09900246f75ca5285aeb38f7b8b295784ffac Reviewed-on: https://webrtc-review.googlesource.com/76741 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Commit-Queue: Peter Hanspers <peterhanspers@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23238}
2018-05-15 10:22:36 +02:00
# TODO(peterhanspers): Reenable these tests on simulator.
# See bugs.webrtc.org/7812
if (!use_ios_simulator) {
sources += [
"objc/Framework/UnitTests/RTCAudioDeviceModule_xctest.mm",
"objc/Framework/UnitTests/RTCAudioDevice_xctest.mm",
]
}
Add xctest target to migrate sdk/objc/Framework to it. This CL adds all the scaffolding needed to support xctest target in sdk/objc/Framework and adds the target to the bot configuration. The benefits of this are two-fold. 1. We'll separate framework unittests from their current target, `rtc_unittests`, that has many many other tests. This way framework unit tests will have nice, compact, selfcontained target. 2. We'll harvest the power of XCTest (native testing framework) that should hopefully make adding and writing objc tests easier. This CL migrates only one test to prove the setup works. More tests will be migrated in follow up cls. Bug: webrtc:8382 Change-Id: I0b5b9596c2a6d91683d13632323441de1aa461e0 Reviewed-on: https://webrtc-review.googlesource.com/8501 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org> Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org> Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20289}
2017-10-12 13:46:00 +02:00
deps = [
Moving iOS Audio Device to sdk. This change forks the existing iOS audio device module and audio device from modules/audio_device/ into sdk/objc/Framework. It also updates RTCPeerConnectionFactory to use the forked implementation. The unit tests are re-implemented as XCTests. (was: https://webrtc-review.googlesource.com/c/src/+/67300) Bug: webrtc:9120 Change-Id: I46c09900246f75ca5285aeb38f7b8b295784ffac Reviewed-on: https://webrtc-review.googlesource.com/76741 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Commit-Queue: Peter Hanspers <peterhanspers@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23238}
2018-05-15 10:22:36 +02:00
":audio_device",
":audio_objc",
Add xctest target to migrate sdk/objc/Framework to it. This CL adds all the scaffolding needed to support xctest target in sdk/objc/Framework and adds the target to the bot configuration. The benefits of this are two-fold. 1. We'll separate framework unittests from their current target, `rtc_unittests`, that has many many other tests. This way framework unit tests will have nice, compact, selfcontained target. 2. We'll harvest the power of XCTest (native testing framework) that should hopefully make adding and writing objc tests easier. This CL migrates only one test to prove the setup works. More tests will be migrated in follow up cls. Bug: webrtc:8382 Change-Id: I0b5b9596c2a6d91683d13632323441de1aa461e0 Reviewed-on: https://webrtc-review.googlesource.com/8501 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org> Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org> Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20289}
2017-10-12 13:46:00 +02:00
":common_objc",
Generate iOS framework umbrella header. Instead of keeping the umbrella header in sync manually and needing ifdefs to make it include the correct headers depending on platform, generate it based on the headers we include in the framework target. Can also be used to only include internal software codec headers when compiling with support for them. Bug: webrtc:7925 Change-Id: I63f97af1efc8710cfd62d527fcb343fed05daae2 Reviewed-on: https://webrtc-review.googlesource.com/38702 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21613}
2018-01-15 13:31:03 +01:00
":framework_objc",
Reland "Add unit tests for RTCCVPixelBuffer and ObjCVideoTrackSource." This is a reland of 4ea50c2b421ae3e40d1d02b8eb8c5802288b181e Original change's description: > Add unit tests for RTCCVPixelBuffer and ObjCVideoTrackSource. > > This CL also fixes a couple of bugs found in the toI420 method for > RTCCVPixelBuffers backed by RGB CVPixelBuffers. > > Bug: webrtc:9007 > Change-Id: I19ab8177f4b124a503cfda9f0166bd960f668982 > Reviewed-on: https://webrtc-review.googlesource.com/64940 > Commit-Queue: Anders Carlsson <andersc@webrtc.org> > Reviewed-by: Kári Helgason <kthelgason@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#22656} Bug: webrtc:9007 Change-Id: I2a787c64f8d23ffc4ef2419fc258d965f8a9480b Reviewed-on: https://webrtc-review.googlesource.com/66341 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22706}
2018-04-03 11:40:39 +02:00
":native_api",
Moving iOS Audio Device to sdk. This change forks the existing iOS audio device module and audio device from modules/audio_device/ into sdk/objc/Framework. It also updates RTCPeerConnectionFactory to use the forked implementation. The unit tests are re-implemented as XCTests. (was: https://webrtc-review.googlesource.com/c/src/+/67300) Bug: webrtc:9120 Change-Id: I46c09900246f75ca5285aeb38f7b8b295784ffac Reviewed-on: https://webrtc-review.googlesource.com/76741 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Commit-Queue: Peter Hanspers <peterhanspers@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23238}
2018-05-15 10:22:36 +02:00
":native_api_audio_device_module",
Reland "Add unit tests for RTCCVPixelBuffer and ObjCVideoTrackSource." This is a reland of 4ea50c2b421ae3e40d1d02b8eb8c5802288b181e Original change's description: > Add unit tests for RTCCVPixelBuffer and ObjCVideoTrackSource. > > This CL also fixes a couple of bugs found in the toI420 method for > RTCCVPixelBuffers backed by RGB CVPixelBuffers. > > Bug: webrtc:9007 > Change-Id: I19ab8177f4b124a503cfda9f0166bd960f668982 > Reviewed-on: https://webrtc-review.googlesource.com/64940 > Commit-Queue: Anders Carlsson <andersc@webrtc.org> > Reviewed-by: Kári Helgason <kthelgason@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#22656} Bug: webrtc:9007 Change-Id: I2a787c64f8d23ffc4ef2419fc258d965f8a9480b Reviewed-on: https://webrtc-review.googlesource.com/66341 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22706}
2018-04-03 11:40:39 +02:00
":native_video",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
":videocapture_objc",
Obj-C SDK for parsing and generating H264 ProfileLevelIds. Expose this functionality in the Obj-C SDK to make it nicer to use for Obj-C clients. Bug: None Change-Id: I5cb511af8799ac0fda15153d16f2550b848b93b2 Reviewed-on: https://webrtc-review.googlesource.com/80481 Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23488}
2018-06-01 12:51:09 +02:00
":videocodec_objc",
Reland "Add unit tests for RTCCVPixelBuffer and ObjCVideoTrackSource." This is a reland of 4ea50c2b421ae3e40d1d02b8eb8c5802288b181e Original change's description: > Add unit tests for RTCCVPixelBuffer and ObjCVideoTrackSource. > > This CL also fixes a couple of bugs found in the toI420 method for > RTCCVPixelBuffers backed by RGB CVPixelBuffers. > > Bug: webrtc:9007 > Change-Id: I19ab8177f4b124a503cfda9f0166bd960f668982 > Reviewed-on: https://webrtc-review.googlesource.com/64940 > Commit-Queue: Anders Carlsson <andersc@webrtc.org> > Reviewed-by: Kári Helgason <kthelgason@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#22656} Bug: webrtc:9007 Change-Id: I2a787c64f8d23ffc4ef2419fc258d965f8a9480b Reviewed-on: https://webrtc-review.googlesource.com/66341 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22706}
2018-04-03 11:40:39 +02:00
":videoframebuffer_objc",
Fix native api in preparation for native_api example. Add native api conversions for video frames and video renderer. This also requires some changes to sdk/BUILD to avoid cyclic dependencies. Bug: webrtc:8832 Change-Id: Ibf21e63bdcae195dcb61d63f9262e6a8dc4fa790 Reviewed-on: https://webrtc-review.googlesource.com/57142 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22340}
2018-03-07 10:32:03 +01:00
":videosource_objc",
Add xctest target to migrate sdk/objc/Framework to it. This CL adds all the scaffolding needed to support xctest target in sdk/objc/Framework and adds the target to the bot configuration. The benefits of this are two-fold. 1. We'll separate framework unittests from their current target, `rtc_unittests`, that has many many other tests. This way framework unit tests will have nice, compact, selfcontained target. 2. We'll harvest the power of XCTest (native testing framework) that should hopefully make adding and writing objc tests easier. This CL migrates only one test to prove the setup works. More tests will be migrated in follow up cls. Bug: webrtc:8382 Change-Id: I0b5b9596c2a6d91683d13632323441de1aa461e0 Reviewed-on: https://webrtc-review.googlesource.com/8501 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org> Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org> Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20289}
2017-10-12 13:46:00 +02:00
":videotoolbox_objc",
New file api/video/BUILD.gn Build targets involving files under api/video/ are moved into this file, from api/BUILD.gn. In addition, drop "_api" part of target names, and move the header file api/videosinkinterface.h to api/video/video_sink_interface.h. Bug: webrtc:9253 Change-Id: I2896d3f063db8dff902bc29738578395b2fcc155 Reviewed-on: https://webrtc-review.googlesource.com/75500 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23207}
2018-05-11 11:15:30 +02:00
"../api/video:video_frame_i420",
Reland "Add unit tests for RTCCVPixelBuffer and ObjCVideoTrackSource." This is a reland of 4ea50c2b421ae3e40d1d02b8eb8c5802288b181e Original change's description: > Add unit tests for RTCCVPixelBuffer and ObjCVideoTrackSource. > > This CL also fixes a couple of bugs found in the toI420 method for > RTCCVPixelBuffers backed by RGB CVPixelBuffers. > > Bug: webrtc:9007 > Change-Id: I19ab8177f4b124a503cfda9f0166bd960f668982 > Reviewed-on: https://webrtc-review.googlesource.com/64940 > Commit-Queue: Anders Carlsson <andersc@webrtc.org> > Reviewed-by: Kári Helgason <kthelgason@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#22656} Bug: webrtc:9007 Change-Id: I2a787c64f8d23ffc4ef2419fc258d965f8a9480b Reviewed-on: https://webrtc-review.googlesource.com/66341 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22706}
2018-04-03 11:40:39 +02:00
"../common_video:common_video",
Add xctest target to migrate sdk/objc/Framework to it. This CL adds all the scaffolding needed to support xctest target in sdk/objc/Framework and adds the target to the bot configuration. The benefits of this are two-fold. 1. We'll separate framework unittests from their current target, `rtc_unittests`, that has many many other tests. This way framework unit tests will have nice, compact, selfcontained target. 2. We'll harvest the power of XCTest (native testing framework) that should hopefully make adding and writing objc tests easier. This CL migrates only one test to prove the setup works. More tests will be migrated in follow up cls. Bug: webrtc:8382 Change-Id: I0b5b9596c2a6d91683d13632323441de1aa461e0 Reviewed-on: https://webrtc-review.googlesource.com/8501 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org> Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org> Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20289}
2017-10-12 13:46:00 +02:00
"../media:rtc_media_base",
Reland "Add unit tests for RTCCVPixelBuffer and ObjCVideoTrackSource." This is a reland of 4ea50c2b421ae3e40d1d02b8eb8c5802288b181e Original change's description: > Add unit tests for RTCCVPixelBuffer and ObjCVideoTrackSource. > > This CL also fixes a couple of bugs found in the toI420 method for > RTCCVPixelBuffers backed by RGB CVPixelBuffers. > > Bug: webrtc:9007 > Change-Id: I19ab8177f4b124a503cfda9f0166bd960f668982 > Reviewed-on: https://webrtc-review.googlesource.com/64940 > Commit-Queue: Anders Carlsson <andersc@webrtc.org> > Reviewed-by: Kári Helgason <kthelgason@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#22656} Bug: webrtc:9007 Change-Id: I2a787c64f8d23ffc4ef2419fc258d965f8a9480b Reviewed-on: https://webrtc-review.googlesource.com/66341 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22706}
2018-04-03 11:40:39 +02:00
"../media:rtc_media_tests_utils",
Add xctest target to migrate sdk/objc/Framework to it. This CL adds all the scaffolding needed to support xctest target in sdk/objc/Framework and adds the target to the bot configuration. The benefits of this are two-fold. 1. We'll separate framework unittests from their current target, `rtc_unittests`, that has many many other tests. This way framework unit tests will have nice, compact, selfcontained target. 2. We'll harvest the power of XCTest (native testing framework) that should hopefully make adding and writing objc tests easier. This CL migrates only one test to prove the setup works. More tests will be migrated in follow up cls. Bug: webrtc:8382 Change-Id: I0b5b9596c2a6d91683d13632323441de1aa461e0 Reviewed-on: https://webrtc-review.googlesource.com/8501 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org> Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org> Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20289}
2017-10-12 13:46:00 +02:00
"../modules:module_api",
"../rtc_base:rtc_base",
"../rtc_base:rtc_base_tests_utils",
Fix paths that were trying to go above the root by using too many "../.." This doesn't cause problems because seems like GN just ignores these attempts and confines everything to the root. Bug: None Change-Id: Ief50b6e10f3950b319d0bde547f91dcc7f237cda Reviewed-on: https://webrtc-review.googlesource.com/90041 Commit-Queue: Oleh Prypin <oprypin@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24063}
2018-07-23 10:04:12 +02:00
"../system_wrappers:system_wrappers",
"../system_wrappers:system_wrappers_default",
Reland "Add unit tests for RTCCVPixelBuffer and ObjCVideoTrackSource." This is a reland of 4ea50c2b421ae3e40d1d02b8eb8c5802288b181e Original change's description: > Add unit tests for RTCCVPixelBuffer and ObjCVideoTrackSource. > > This CL also fixes a couple of bugs found in the toI420 method for > RTCCVPixelBuffers backed by RGB CVPixelBuffers. > > Bug: webrtc:9007 > Change-Id: I19ab8177f4b124a503cfda9f0166bd960f668982 > Reviewed-on: https://webrtc-review.googlesource.com/64940 > Commit-Queue: Anders Carlsson <andersc@webrtc.org> > Reviewed-by: Kári Helgason <kthelgason@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#22656} Bug: webrtc:9007 Change-Id: I2a787c64f8d23ffc4ef2419fc258d965f8a9480b Reviewed-on: https://webrtc-review.googlesource.com/66341 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22706}
2018-04-03 11:40:39 +02:00
"//third_party/libyuv",
Add xctest target to migrate sdk/objc/Framework to it. This CL adds all the scaffolding needed to support xctest target in sdk/objc/Framework and adds the target to the bot configuration. The benefits of this are two-fold. 1. We'll separate framework unittests from their current target, `rtc_unittests`, that has many many other tests. This way framework unit tests will have nice, compact, selfcontained target. 2. We'll harvest the power of XCTest (native testing framework) that should hopefully make adding and writing objc tests easier. This CL migrates only one test to prove the setup works. More tests will be migrated in follow up cls. Bug: webrtc:8382 Change-Id: I0b5b9596c2a6d91683d13632323441de1aa461e0 Reviewed-on: https://webrtc-review.googlesource.com/8501 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org> Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org> Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20289}
2017-10-12 13:46:00 +02:00
]
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
if (rtc_use_metal_rendering) {
Add renderer-agnostic delegate protocol. The MTL renderer should also have a way to notify it's delegate that it's content size changed. The plan is to introduce this new protocol, move existing clients over to implementing it in favour of RTCEAGLVideoViewDelegate, and then finally removing the old protocol. Bug: b/73147161 Change-Id: I908d7b2667e44e02a58066d701a48efec0e98d14 Reviewed-on: https://webrtc-review.googlesource.com/70243 Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22944}
2018-04-19 17:38:05 +02:00
sources += [ "objc/Framework/UnitTests/RTCMTLVideoView_xctest.m" ]
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
deps += [ ":metal_objc" ]
}
Add xctest target to migrate sdk/objc/Framework to it. This CL adds all the scaffolding needed to support xctest target in sdk/objc/Framework and adds the target to the bot configuration. The benefits of this are two-fold. 1. We'll separate framework unittests from their current target, `rtc_unittests`, that has many many other tests. This way framework unit tests will have nice, compact, selfcontained target. 2. We'll harvest the power of XCTest (native testing framework) that should hopefully make adding and writing objc tests easier. This CL migrates only one test to prove the setup works. More tests will be migrated in follow up cls. Bug: webrtc:8382 Change-Id: I0b5b9596c2a6d91683d13632323441de1aa461e0 Reviewed-on: https://webrtc-review.googlesource.com/8501 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org> Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org> Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20289}
2017-10-12 13:46:00 +02:00
public_deps = [
"//build/config/ios:xctest",
"//third_party/ocmock",
]
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
Generate iOS framework umbrella header. Instead of keeping the umbrella header in sync manually and needing ifdefs to make it include the correct headers depending on platform, generate it based on the headers we include in the framework target. Can also be used to only include internal software codec headers when compiling with support for them. Bug: webrtc:7925 Change-Id: I63f97af1efc8710cfd62d527fcb343fed05daae2 Reviewed-on: https://webrtc-review.googlesource.com/38702 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21613}
2018-01-15 13:31:03 +01:00
include_dirs += [ "$root_out_dir/WebRTC.framework/Headers/" ]
Add xctest target to migrate sdk/objc/Framework to it. This CL adds all the scaffolding needed to support xctest target in sdk/objc/Framework and adds the target to the bot configuration. The benefits of this are two-fold. 1. We'll separate framework unittests from their current target, `rtc_unittests`, that has many many other tests. This way framework unit tests will have nice, compact, selfcontained target. 2. We'll harvest the power of XCTest (native testing framework) that should hopefully make adding and writing objc tests easier. This CL migrates only one test to prove the setup works. More tests will be migrated in follow up cls. Bug: webrtc:8382 Change-Id: I0b5b9596c2a6d91683d13632323441de1aa461e0 Reviewed-on: https://webrtc-review.googlesource.com/8501 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org> Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org> Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20289}
2017-10-12 13:46:00 +02:00
}
Reland "Add file capturer to AppRTCMobile on simulator." This is a reland of 5adcd198752b651f7b7e9199a91f9b873b7d7237 Original change's description: > Add file capturer to AppRTCMobile on simulator. > > To achieve this, the CL does the following > - Adds sample mp4 video > - Refactors the existing RTCFileVideoCapturer to achieve continious > capture and adds tests. > > Bug: webrtc:8406 > Change-Id: Ibc0891176c58ec9053b42e340d2113036e7199ec > Reviewed-on: https://webrtc-review.googlesource.com/12180 > Reviewed-by: Anders Carlsson <andersc@webrtc.org> > Reviewed-by: Magnus Jedvert <magjed@webrtc.org> > Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#20598} Bug: webrtc:8406 Change-Id: I93be89b86e342a9a8195e19ebaf4aef1410d2c20 Reviewed-on: https://webrtc-review.googlesource.com/23200 Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20870}
2017-11-15 13:15:24 +01:00
bundle_data("sdk_unittests_bundle_data") {
sources = [
Moving iOS Audio Device to sdk. This change forks the existing iOS audio device module and audio device from modules/audio_device/ into sdk/objc/Framework. It also updates RTCPeerConnectionFactory to use the forked implementation. The unit tests are re-implemented as XCTests. (was: https://webrtc-review.googlesource.com/c/src/+/67300) Bug: webrtc:9120 Change-Id: I46c09900246f75ca5285aeb38f7b8b295784ffac Reviewed-on: https://webrtc-review.googlesource.com/76741 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Commit-Queue: Peter Hanspers <peterhanspers@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23238}
2018-05-15 10:22:36 +02:00
"objc/Framework/UnitTests/audio_short16.pcm",
"objc/Framework/UnitTests/audio_short44.pcm",
"objc/Framework/UnitTests/audio_short48.pcm",
# Sample video taken from https://media.xiph.org/video/derf/
Reland "Add file capturer to AppRTCMobile on simulator." This is a reland of 5adcd198752b651f7b7e9199a91f9b873b7d7237 Original change's description: > Add file capturer to AppRTCMobile on simulator. > > To achieve this, the CL does the following > - Adds sample mp4 video > - Refactors the existing RTCFileVideoCapturer to achieve continious > capture and adds tests. > > Bug: webrtc:8406 > Change-Id: Ibc0891176c58ec9053b42e340d2113036e7199ec > Reviewed-on: https://webrtc-review.googlesource.com/12180 > Reviewed-by: Anders Carlsson <andersc@webrtc.org> > Reviewed-by: Magnus Jedvert <magjed@webrtc.org> > Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#20598} Bug: webrtc:8406 Change-Id: I93be89b86e342a9a8195e19ebaf4aef1410d2c20 Reviewed-on: https://webrtc-review.googlesource.com/23200 Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20870}
2017-11-15 13:15:24 +01:00
"objc/Framework/UnitTests/foreman.mp4",
]
outputs = [
"{{bundle_resources_dir}}/{{source_file_part}}",
]
}
Add xctest target to migrate sdk/objc/Framework to it. This CL adds all the scaffolding needed to support xctest target in sdk/objc/Framework and adds the target to the bot configuration. The benefits of this are two-fold. 1. We'll separate framework unittests from their current target, `rtc_unittests`, that has many many other tests. This way framework unit tests will have nice, compact, selfcontained target. 2. We'll harvest the power of XCTest (native testing framework) that should hopefully make adding and writing objc tests easier. This CL migrates only one test to prove the setup works. More tests will be migrated in follow up cls. Bug: webrtc:8382 Change-Id: I0b5b9596c2a6d91683d13632323441de1aa461e0 Reviewed-on: https://webrtc-review.googlesource.com/8501 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org> Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org> Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20289}
2017-10-12 13:46:00 +02:00
rtc_ios_xctest_test("sdk_unittests") {
info_plist = "//test/ios/Info.plist"
sources = [
"objc/Framework/UnitTests/main.m",
]
Reland "Add file capturer to AppRTCMobile on simulator." This is a reland of 5adcd198752b651f7b7e9199a91f9b873b7d7237 Original change's description: > Add file capturer to AppRTCMobile on simulator. > > To achieve this, the CL does the following > - Adds sample mp4 video > - Refactors the existing RTCFileVideoCapturer to achieve continious > capture and adds tests. > > Bug: webrtc:8406 > Change-Id: Ibc0891176c58ec9053b42e340d2113036e7199ec > Reviewed-on: https://webrtc-review.googlesource.com/12180 > Reviewed-by: Anders Carlsson <andersc@webrtc.org> > Reviewed-by: Magnus Jedvert <magjed@webrtc.org> > Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#20598} Bug: webrtc:8406 Change-Id: I93be89b86e342a9a8195e19ebaf4aef1410d2c20 Reviewed-on: https://webrtc-review.googlesource.com/23200 Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20870}
2017-11-15 13:15:24 +01:00
Add xctest target to migrate sdk/objc/Framework to it. This CL adds all the scaffolding needed to support xctest target in sdk/objc/Framework and adds the target to the bot configuration. The benefits of this are two-fold. 1. We'll separate framework unittests from their current target, `rtc_unittests`, that has many many other tests. This way framework unit tests will have nice, compact, selfcontained target. 2. We'll harvest the power of XCTest (native testing framework) that should hopefully make adding and writing objc tests easier. This CL migrates only one test to prove the setup works. More tests will be migrated in follow up cls. Bug: webrtc:8382 Change-Id: I0b5b9596c2a6d91683d13632323441de1aa461e0 Reviewed-on: https://webrtc-review.googlesource.com/8501 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org> Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org> Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20289}
2017-10-12 13:46:00 +02:00
_bundle_id_suffix = ios_generic_test_bundle_id_suffix
extra_substitutions = [ "GTEST_BUNDLE_ID_SUFFIX=$_bundle_id_suffix" ]
deps = [
Fixed crash when PCF is destroyed before PC in ObjC Bug: webrtc:9231 Change-Id: Iaf18257b8f38fa786d462bca5f860f9a7b1cc2d0 Reviewed-on: https://webrtc-review.googlesource.com/78800 Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23674}
2018-06-19 12:51:51 +03:00
":peerconnectionfactory_base_objc",
Reland "Add file capturer to AppRTCMobile on simulator." This is a reland of 5adcd198752b651f7b7e9199a91f9b873b7d7237 Original change's description: > Add file capturer to AppRTCMobile on simulator. > > To achieve this, the CL does the following > - Adds sample mp4 video > - Refactors the existing RTCFileVideoCapturer to achieve continious > capture and adds tests. > > Bug: webrtc:8406 > Change-Id: Ibc0891176c58ec9053b42e340d2113036e7199ec > Reviewed-on: https://webrtc-review.googlesource.com/12180 > Reviewed-by: Anders Carlsson <andersc@webrtc.org> > Reviewed-by: Magnus Jedvert <magjed@webrtc.org> > Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#20598} Bug: webrtc:8406 Change-Id: I93be89b86e342a9a8195e19ebaf4aef1410d2c20 Reviewed-on: https://webrtc-review.googlesource.com/23200 Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20870}
2017-11-15 13:15:24 +01:00
":sdk_unittests_bundle_data",
Add xctest target to migrate sdk/objc/Framework to it. This CL adds all the scaffolding needed to support xctest target in sdk/objc/Framework and adds the target to the bot configuration. The benefits of this are two-fold. 1. We'll separate framework unittests from their current target, `rtc_unittests`, that has many many other tests. This way framework unit tests will have nice, compact, selfcontained target. 2. We'll harvest the power of XCTest (native testing framework) that should hopefully make adding and writing objc tests easier. This CL migrates only one test to prove the setup works. More tests will be migrated in follow up cls. Bug: webrtc:8382 Change-Id: I0b5b9596c2a6d91683d13632323441de1aa461e0 Reviewed-on: https://webrtc-review.googlesource.com/8501 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org> Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org> Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20289}
2017-10-12 13:46:00 +02:00
":sdk_unittests_sources",
]
ldflags = [ "-all_load" ]
}
}
# TODO(denicija): once all tests are migrated to xctest remove this source set.
Support compiling with the lastest iOS SDK. Bug: None Change-Id: I2bc4b4f3eba9c5f6b3a94fce076dc575c5be057d Reviewed-on: https://webrtc-review.googlesource.com/90720 Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24163}
2018-07-27 12:34:54 +02:00
rtc_source_set("rtc_unittests_objc") {
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
testonly = true
Reland of GN: Enable ARC for Mac and iOS in rtc_* templates (patchset #1 id:1 of https://codereview.webrtc.org/2827223003/ ) Reason for revert: Relanding after fixing ARC issue. Original issue's description: > Revert of GN: Enable ARC for Mac and iOS in rtc_* templates (patchset #3 id:40001 of https://codereview.webrtc.org/2781713004/ ) > > Reason for revert: > Breaks mac build > > Original issue's description: > > GN: Enable ARC for Mac and iOS in rtc_* templates > > > > Remove all uses of retain/release and NSAutoreleasePool. > > > > This makes transformation to Bazel easier. > > > > This CL subsumes https://codereview.webrtc.org/2778163002 and depends on https://codereview.webrtc.org/2784483002/ > > > > BUG=webrtc:6412 > > > > Review-Url: https://codereview.webrtc.org/2781713004 > > Cr-Commit-Position: refs/heads/master@{#17780} > > Committed: https://chromium.googlesource.com/external/webrtc/+/6bda02b51dc00401d2a0d04be996ed10e5acac47 > > TBR=kjellander@webrtc.org,magjed@webrtc.org,stefan@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6412 > > Review-Url: https://codereview.webrtc.org/2827223003 > Cr-Commit-Position: refs/heads/master@{#17784} > Committed: https://chromium.googlesource.com/external/webrtc/+/7c8786ae8f2d8481f74b0ab16eb91a8101fe51dc TBR=kjellander@webrtc.org,magjed@webrtc.org,stefan@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6412 Review-Url: https://codereview.webrtc.org/2834273002 Cr-Commit-Position: refs/heads/master@{#17836}
2017-04-24 00:57:16 -07:00
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
sources = [
Add certificate generate/set functionality to bring iOS closer to JS API The JS API supports two operations which have never been implemented in the iOS counterpart: - generate a new certificate - use this certificate when creating a new PeerConnection Both functions are illustrated in the generateCertificate example code: - https://developer.mozilla.org/en-US/docs/Web/API/RTCPeerConnection/generateCertificate Currently, on iOS, a new certificate is automatically generated for every PeerConnection with no programmatic way to set a specific certificate. Work sponsored by |pipe| Bug: webrtc:9498 Change-Id: Ic1936c3de8b8bd18aef67c784727b72f90e7157c Reviewed-on: https://webrtc-review.googlesource.com/87303 Commit-Queue: Steve Anton <steveanton@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Steve Anton <steveanton@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24276}
2018-07-05 15:28:24 +02:00
"objc/Framework/UnitTests/RTCCertificateTest.mm",
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
"objc/Framework/UnitTests/RTCConfigurationTest.mm",
"objc/Framework/UnitTests/RTCDataChannelConfigurationTest.mm",
"objc/Framework/UnitTests/RTCIceCandidateTest.mm",
"objc/Framework/UnitTests/RTCIceServerTest.mm",
Reinstate "iOS - Add iceRegatherIntervalRange." This reverts commit 93adc3209b5ff10adaba54d5eab6b53bc2780685. Reverted originally because it depended on a CL which was reverted. That CL has been reinstated in: https: //chromium-review.googlesource.com/#/c/572070/ Bug: webrtc:7969 Change-Id: I608bbeaaba02e84908433c8260cf236df0307a97 Reviewed-on: https://chromium-review.googlesource.com/572405 Reviewed-by: Zeke Chin <tkchin@webrtc.org> Cr-Commit-Position: refs/heads/master@{#19035}
2017-07-14 16:06:41 -07:00
"objc/Framework/UnitTests/RTCIntervalRangeTests.mm",
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
"objc/Framework/UnitTests/RTCMediaConstraintsTest.mm",
Create a peer connection factory builder Similar to the builder on android: https://cs.chromium.org/chromium/src/third_party/webrtc/sdk/android/api/org/webrtc/PeerConnectionFactory.java?rcl=b90e63c620877712e45ee320cfa25cb825bf5373&l=134 1. A builder will allow us to choose what module factories to provide and use default for the others. 2. A helper category is added to provide helpers functions for creating common builders. Bug: None Change-Id: I5889bdd7dc2a2aeded62ef5f2c2381edd07089b3 Reviewed-on: https://webrtc-review.googlesource.com/83280 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23696}
2018-06-20 16:18:59 -07:00
"objc/Framework/UnitTests/RTCPeerConnectionFactoryBuilderTest.mm",
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
"objc/Framework/UnitTests/RTCPeerConnectionTest.mm",
"objc/Framework/UnitTests/RTCSessionDescriptionTest.mm",
Trace loggging: Check for g_event_logger is not null before calling it. BUG=webrtc:7868 Review-Url: https://codereview.webrtc.org/2961663002 Cr-Commit-Position: refs/heads/master@{#18933}
2017-07-07 11:02:15 -07:00
"objc/Framework/UnitTests/RTCTracingTest.mm",
Reland of Injectable Obj-C video codecs (patchset #1 id:1 of https://codereview.webrtc.org/2980173002/ ) Reason for revert: Relanding after fixing issues with no video. Original issue's description: > Revert of Injectable Obj-C video codecs (patchset #2 id:370001 of https://codereview.webrtc.org/2979983002/ ) > > Reason for revert: > Still having problems with no video. Reverting. > Once no video is visible, no video is available from then on even if the callee app is in the foreground. > > > Original issue's description: > > Reland of Injectable Obj-C video codecs (patchset #1 id:1 of https://codereview.webrtc.org/2979973002/ ) > > > > Reason for revert: > > Fix the broken build file > > > > Original issue's description: > > > Revert of Injectable Obj-C video codecs (patchset #3 id:400001 of https://codereview.webrtc.org/2981583002/ ) > > > > > > Reason for revert: > > > Breaks bots. Build file incorrect. > > > > > > Original issue's description: > > > > Reland of Injectable Obj-C video codecs (patchset #1 id:1 of https://codereview.webrtc.org/2975963002/ ) > > > > > > > > Reason for revert: > > > > New CL for fixing the issues > > > > > > > > Original issue's description: > > > > > Revert of Injectable Obj-C video codecs (patchset #8 id:140001 of https://codereview.webrtc.org/2966023002/ ) > > > > > > > > > > Reason for revert: > > > > > Causes no video in certain scenarios. Please come up with a test plan or unit test to prevent such problems in the future. > > > > > > > > > > Original issue's description: > > > > > > Injectable Obj-C video codecs > > > > > > > > > > > > Initial CL for this effort, with a working RTCVideoEncoder/Decoder for H264 > > > > > > (wrapping the VideoToolbox codec). > > > > > > > > > > > > Some notes / things left to do: > > > > > > - There are some hard-coded references to codec types that are supported by > > > > > > webrtc::VideoCodec, cricket::VideoCodec, webrtc::CodecSpecificInfo etc > > > > > > since we need to convert to/from these types in ObjCVideoEncoder/Decoder. > > > > > > These types would need to be more codec agnostic to avoid this. > > > > > > - Most interfaces are borrowed from the design document for injectable > > > > > > codecs in Android. Some data in the corresponding C++ classes is discarded > > > > > > when converting to the Obj-C version, since it has fewer fields. I have not > > > > > > verified whether all data that we do keep is needed, or whether we might be > > > > > > losing anything useful in these conversions. > > > > > > - Implement the VideoToolbox codec code directly in the RTCVideoEncoderH264 > > > > > > classes, instead of wrapping webrtc::H264VideoToolboxEncoder / decoder. > > > > > > Eliminates converting between ObjC/C++ types outside the ObjCVideoEncoder/ > > > > > > Decoder wrapper classes. > > > > > > - List the injected codec factory's supported codecs in the list of codecs in > > > > > > AppRTCMobile. > > > > > > > > > > > > BUG=webrtc:7924 > > > > > > R=magjed@webrtc.org > > > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2966023002 . > > > > > > Cr-Commit-Position: refs/heads/master@{#18928} > > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/a0349c138db62c52435be84b6c837f5f4758e264 > > > > > > > > > > TBR=magjed@webrtc.org,andersc@webrtc.org > > > > > # Not skipping CQ checks because original CL landed more than 1 days ago. > > > > > BUG=webrtc:7924 > > > > > NOTRY=true > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2975963002 > > > > > Cr-Commit-Position: refs/heads/master@{#18979} > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/1095ada7ad56fe29b7b2bbc560a8f6475a7978ce > > > > > > > > R=magjed@webrtc.org > > > > TBR=tkchin@webrtc.org > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > NOPRESUBMIT=true > > > > NOTREECHECKS=true > > > > NOTRY=true > > > > BUG=webrtc:7924 > > > > > > > > Review-Url: https://codereview.webrtc.org/2981583002 . > > > > Cr-Commit-Position: refs/heads/master@{#19002} > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/a5f1de1e6541de03f944bcbf49be87c01f57a18b > > > > > > TBR=magjed@webrtc.org,tkchin@webrtc.org,jtteh@webrtc.org,andersc@webrtc.org > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > NOPRESUBMIT=true > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG=webrtc:7924 > > > > > > Review-Url: https://codereview.webrtc.org/2979973002 > > > Cr-Commit-Position: refs/heads/master@{#19004} > > > Committed: https://chromium.googlesource.com/external/webrtc/+/81d40ee1491d5229c2677cc04b1f40d67c2babef > > > > TBR=magjed@webrtc.org,tkchin@webrtc.org,jtteh@webrtc.org,sprang@webrtc.org > > BUG=webrtc:7924 > > > > Review-Url: https://codereview.webrtc.org/2979983002 > > Cr-Commit-Position: refs/heads/master@{#19005} > > Committed: https://chromium.googlesource.com/external/webrtc/+/732a3437da4db7b452758b8e1cf26fce0ce3bf65 > > TBR=magjed@webrtc.org,tkchin@webrtc.org,sprang@webrtc.org,haysc@webrtc.org,andersc@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:7924 > > Review-Url: https://codereview.webrtc.org/2980173002 > Cr-Commit-Position: refs/heads/master@{#19036} > Committed: https://chromium.googlesource.com/external/webrtc/+/860f7298166084d966749e22b69aa2fdcf4d4ed6 TBR=magjed@webrtc.org,tkchin@webrtc.org,sprang@webrtc.org,haysc@webrtc.org,andersc@webrtc.org,jtteh@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:7924 Review-Url: https://codereview.webrtc.org/2977213002 Cr-Commit-Position: refs/heads/master@{#19135}
2017-07-25 07:55:58 -07:00
"objc/Framework/UnitTests/objc_video_decoder_factory_tests.mm",
"objc/Framework/UnitTests/objc_video_encoder_factory_tests.mm",
Add tests for ScopedCFTypeRef. Copy the chromium pattern of taking Traits as template args to be able to write a testable implementation of ScopedTypeRef. Add unit tests for th current implementation. Bug: webrtc:7825 Change-Id: I26017952c042c8323b9c3841ec309e32d1c04a85 Reviewed-on: https://webrtc-review.googlesource.com/5621 Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20165}
2017-10-05 14:06:52 +02:00
"objc/Framework/UnitTests/scoped_cftyperef_tests.mm",
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
]
Add tests for starting and stopping RTCCameraVideoCapturer. Bug: webrtc:8755 Change-Id: I07d9a203276359069af7ba384c58612df7f2b467 Reviewed-on: https://webrtc-review.googlesource.com/40240 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21692}
2018-01-19 11:28:44 +01:00
if (is_ios) {
Enable more unittests on iOS, and disable those that fail on simulator Tests enabled: * modules_unittests * ortc_unittests * rtc_media_unittests * rtc_unittests * video_capture_tests * video_engine_tests BUG=webrtc:5566,webrtc:4752,webrtc:5568,webrtc:5569 Review-Url: https://codereview.webrtc.org/2938193002 Cr-Commit-Position: refs/heads/master@{#18710}
2017-06-22 01:47:20 -07:00
sources +=
[ "objc/Framework/UnitTests/RTCCameraVideoCapturerTests.mm" ]
}
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
# |-ObjC| flag needed to make sure category method implementations
# are included:
# https://developer.apple.com/library/mac/qa/qa1490/_index.html
ldflags = [ "-ObjC" ]
deps = [
Add tests for ScopedCFTypeRef. Copy the chromium pattern of taking Traits as template args to be able to write a testable implementation of ScopedTypeRef. Add unit tests for th current implementation. Bug: webrtc:7825 Change-Id: I26017952c042c8323b9c3841ec309e32d1c04a85 Reviewed-on: https://webrtc-review.googlesource.com/5621 Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20165}
2017-10-05 14:06:52 +02:00
":common_objc",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
":mediaconstraints_objc",
":native_api",
Create experimental Obj-C++ API. This can be used to wrap Objective-C components in C++ classes, so users can use the WebRTC C++ API directly together with the iOS specific components provided by our SDK. Bug: webrtc:8832 Change-Id: I6d34f7ec62d51df8d3a5340a2e17d30ae73e13e8 Reviewed-on: https://webrtc-review.googlesource.com/46162 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21850}
2018-02-01 15:47:05 +01:00
":native_video",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
":peerconnectionfactory_base_objc",
":video_objc",
":videocapture_objc",
":videocodec_objc",
":videoframebuffer_objc",
Fix native api in preparation for native_api example. Add native api conversions for video frames and video renderer. This also requires some changes to sdk/BUILD to avoid cyclic dependencies. Bug: webrtc:8832 Change-Id: Ibf21e63bdcae195dcb61d63f9262e6a8dc4fa790 Reviewed-on: https://webrtc-review.googlesource.com/57142 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22340}
2018-03-07 10:32:03 +01:00
":videosource_objc",
Rename all objc targets to be suffixed for consistency BUG=webrtc:6412 Review-Url: https://codereview.webrtc.org/3001023003 Cr-Commit-Position: refs/heads/master@{#19489}
2017-08-24 05:43:45 -07:00
":videotoolbox_objc",
Create a peer connection factory builder Similar to the builder on android: https://cs.chromium.org/chromium/src/third_party/webrtc/sdk/android/api/org/webrtc/PeerConnectionFactory.java?rcl=b90e63c620877712e45ee320cfa25cb825bf5373&l=134 1. A builder will allow us to choose what module factories to provide and use default for the others. 2. A helper category is added to provide helpers functions for creating common builders. Bug: None Change-Id: I5889bdd7dc2a2aeded62ef5f2c2381edd07089b3 Reviewed-on: https://webrtc-review.googlesource.com/83280 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23696}
2018-06-20 16:18:59 -07:00
"../api/audio_codecs:audio_codecs_api",
"../api/audio_codecs:builtin_audio_decoder_factory",
"../api/audio_codecs:builtin_audio_encoder_factory",
ObjC SDK: Stop using built-in SW video codecs This CL removes the use of default built-in SW in the ObjC layer. If a client want to depend on the video SW codecs, they must inject them explicitly. Bug: webrtc:7925 Change-Id: If752e7f02109ff768dc5ec38d935203de85987c2 Reviewed-on: https://webrtc-review.googlesource.com/69800 Commit-Queue: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23073}
2018-04-13 15:36:43 +02:00
"../api/video_codecs:video_codecs_api",
Let CreateVideoDecoder take a cricket::VideoCodec. This makes it possible for decoder factories to actually provide any video codec, not just the ones WebRTC knows about. It also brings the decoder factory interface more in line with that of the encoder factory. BUG=webrtc:8140 Review-Url: https://codereview.webrtc.org/3007433002 Cr-Commit-Position: refs/heads/master@{#19654}
2017-09-04 04:36:21 -07:00
"../media:rtc_media_base",
Reland of Injectable Obj-C video codecs (patchset #1 id:1 of https://codereview.webrtc.org/2980173002/ ) Reason for revert: Relanding after fixing issues with no video. Original issue's description: > Revert of Injectable Obj-C video codecs (patchset #2 id:370001 of https://codereview.webrtc.org/2979983002/ ) > > Reason for revert: > Still having problems with no video. Reverting. > Once no video is visible, no video is available from then on even if the callee app is in the foreground. > > > Original issue's description: > > Reland of Injectable Obj-C video codecs (patchset #1 id:1 of https://codereview.webrtc.org/2979973002/ ) > > > > Reason for revert: > > Fix the broken build file > > > > Original issue's description: > > > Revert of Injectable Obj-C video codecs (patchset #3 id:400001 of https://codereview.webrtc.org/2981583002/ ) > > > > > > Reason for revert: > > > Breaks bots. Build file incorrect. > > > > > > Original issue's description: > > > > Reland of Injectable Obj-C video codecs (patchset #1 id:1 of https://codereview.webrtc.org/2975963002/ ) > > > > > > > > Reason for revert: > > > > New CL for fixing the issues > > > > > > > > Original issue's description: > > > > > Revert of Injectable Obj-C video codecs (patchset #8 id:140001 of https://codereview.webrtc.org/2966023002/ ) > > > > > > > > > > Reason for revert: > > > > > Causes no video in certain scenarios. Please come up with a test plan or unit test to prevent such problems in the future. > > > > > > > > > > Original issue's description: > > > > > > Injectable Obj-C video codecs > > > > > > > > > > > > Initial CL for this effort, with a working RTCVideoEncoder/Decoder for H264 > > > > > > (wrapping the VideoToolbox codec). > > > > > > > > > > > > Some notes / things left to do: > > > > > > - There are some hard-coded references to codec types that are supported by > > > > > > webrtc::VideoCodec, cricket::VideoCodec, webrtc::CodecSpecificInfo etc > > > > > > since we need to convert to/from these types in ObjCVideoEncoder/Decoder. > > > > > > These types would need to be more codec agnostic to avoid this. > > > > > > - Most interfaces are borrowed from the design document for injectable > > > > > > codecs in Android. Some data in the corresponding C++ classes is discarded > > > > > > when converting to the Obj-C version, since it has fewer fields. I have not > > > > > > verified whether all data that we do keep is needed, or whether we might be > > > > > > losing anything useful in these conversions. > > > > > > - Implement the VideoToolbox codec code directly in the RTCVideoEncoderH264 > > > > > > classes, instead of wrapping webrtc::H264VideoToolboxEncoder / decoder. > > > > > > Eliminates converting between ObjC/C++ types outside the ObjCVideoEncoder/ > > > > > > Decoder wrapper classes. > > > > > > - List the injected codec factory's supported codecs in the list of codecs in > > > > > > AppRTCMobile. > > > > > > > > > > > > BUG=webrtc:7924 > > > > > > R=magjed@webrtc.org > > > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2966023002 . > > > > > > Cr-Commit-Position: refs/heads/master@{#18928} > > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/a0349c138db62c52435be84b6c837f5f4758e264 > > > > > > > > > > TBR=magjed@webrtc.org,andersc@webrtc.org > > > > > # Not skipping CQ checks because original CL landed more than 1 days ago. > > > > > BUG=webrtc:7924 > > > > > NOTRY=true > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2975963002 > > > > > Cr-Commit-Position: refs/heads/master@{#18979} > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/1095ada7ad56fe29b7b2bbc560a8f6475a7978ce > > > > > > > > R=magjed@webrtc.org > > > > TBR=tkchin@webrtc.org > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > NOPRESUBMIT=true > > > > NOTREECHECKS=true > > > > NOTRY=true > > > > BUG=webrtc:7924 > > > > > > > > Review-Url: https://codereview.webrtc.org/2981583002 . > > > > Cr-Commit-Position: refs/heads/master@{#19002} > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/a5f1de1e6541de03f944bcbf49be87c01f57a18b > > > > > > TBR=magjed@webrtc.org,tkchin@webrtc.org,jtteh@webrtc.org,andersc@webrtc.org > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > NOPRESUBMIT=true > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG=webrtc:7924 > > > > > > Review-Url: https://codereview.webrtc.org/2979973002 > > > Cr-Commit-Position: refs/heads/master@{#19004} > > > Committed: https://chromium.googlesource.com/external/webrtc/+/81d40ee1491d5229c2677cc04b1f40d67c2babef > > > > TBR=magjed@webrtc.org,tkchin@webrtc.org,jtteh@webrtc.org,sprang@webrtc.org > > BUG=webrtc:7924 > > > > Review-Url: https://codereview.webrtc.org/2979983002 > > Cr-Commit-Position: refs/heads/master@{#19005} > > Committed: https://chromium.googlesource.com/external/webrtc/+/732a3437da4db7b452758b8e1cf26fce0ce3bf65 > > TBR=magjed@webrtc.org,tkchin@webrtc.org,sprang@webrtc.org,haysc@webrtc.org,andersc@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:7924 > > Review-Url: https://codereview.webrtc.org/2980173002 > Cr-Commit-Position: refs/heads/master@{#19036} > Committed: https://chromium.googlesource.com/external/webrtc/+/860f7298166084d966749e22b69aa2fdcf4d4ed6 TBR=magjed@webrtc.org,tkchin@webrtc.org,sprang@webrtc.org,haysc@webrtc.org,andersc@webrtc.org,jtteh@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:7924 Review-Url: https://codereview.webrtc.org/2977213002 Cr-Commit-Position: refs/heads/master@{#19135}
2017-07-25 07:55:58 -07:00
"../modules:module_api",
Create a peer connection factory builder Similar to the builder on android: https://cs.chromium.org/chromium/src/third_party/webrtc/sdk/android/api/org/webrtc/PeerConnectionFactory.java?rcl=b90e63c620877712e45ee320cfa25cb825bf5373&l=134 1. A builder will allow us to choose what module factories to provide and use default for the others. 2. A helper category is added to provide helpers functions for creating common builders. Bug: None Change-Id: I5889bdd7dc2a2aeded62ef5f2c2381edd07089b3 Reviewed-on: https://webrtc-review.googlesource.com/83280 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23696}
2018-06-20 16:18:59 -07:00
"../modules/audio_device:audio_device_api",
"../modules/audio_processing:audio_processing",
Add untracked headers to video_coding. This creates a new target for pure defines and interfaces. I think that makes sense (though include/ makes it harder to see when .cc and .h files should live together). Bug: webrtc:7620 Change-Id: Ifb0f50faf99166202836c0446feed3443eb52c6e Reviewed-on: https://webrtc-review.googlesource.com/34657 Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21516}
2018-01-08 11:05:10 +01:00
"../modules/video_coding:video_codec_interface",
Remove remains of webrtc/base All downstream code have been updated to the new location. In PRESUBMIT.py: * Remove webrtc/rtc_base from CPP_BLACKLIST * Add webrtc/rtc_base to LEGACY_API_DIRS Fix some duplicated paths in webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn BUG=webrtc:7634 TBR=kwiberg@webrtc.org Review-Url: https://codereview.webrtc.org/2976293002 Cr-Commit-Position: refs/heads/master@{#19094}
2017-07-19 10:40:47 -07:00
"../rtc_base:rtc_base_tests_utils",
Delete root header file typedef.h. Usage replaced with stdint.h, rtc_base/system/arch.h and rtc_base/system/unused.h, as appropriate. Bug: webrtc:6854 Change-Id: I97225465d14b969903d92979e2df3c3c05d35f18 Reviewed-on: https://webrtc-review.googlesource.com/90249 Reviewed-by: Niklas Enbom <niklas.enbom@webrtc.org> Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24100}
2018-07-25 16:05:48 +02:00
"../rtc_base/system:unused",
Fix paths that were trying to go above the root by using too many "../.." This doesn't cause problems because seems like GN just ignores these attempts and confines everything to the root. Bug: None Change-Id: Ief50b6e10f3950b319d0bde547f91dcc7f237cda Reviewed-on: https://webrtc-review.googlesource.com/90041 Commit-Queue: Oleh Prypin <oprypin@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24063}
2018-07-23 10:04:12 +02:00
"../system_wrappers:system_wrappers_default",
Add tests for ScopedCFTypeRef. Copy the chromium pattern of taking Traits as template args to be able to write a testable implementation of ScopedTypeRef. Add unit tests for th current implementation. Bug: webrtc:7825 Change-Id: I26017952c042c8323b9c3841ec309e32d1c04a85 Reviewed-on: https://webrtc-review.googlesource.com/5621 Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20165}
2017-10-05 14:06:52 +02:00
"//test:test_support",
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
"//third_party/ocmock",
]
Move RTCAudioSession* files modules/audio_device/ -> sdk/Framework. BUG=NONE Review-Url: https://codereview.webrtc.org/2855023003 Cr-Commit-Position: refs/heads/master@{#18443}
2017-06-05 05:48:47 -07:00
if (is_ios) {
sources += [ "objc/Framework/UnitTests/RTCAudioSessionTest.mm" ]
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
deps += [ ":audio_objc" ]
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
}
[GN] Add rtc_sdk_framework_objc target to GN The build artifacts don't look completely identical to the ones generated by the GYP targets, but manual review shows the same symbols are exported. On iOS, the version generated by the GN follows convention, including a "Headers" directory, and the .modulemap file. I think this is preferred over the gyp version. BUG=webrtc:6320 NOTRY=True TESTED=Run AppRTCDemo on iOS + Mac and verified with nm that they export the same symbols. Review-Url: https://codereview.webrtc.org/2340633003 Cr-Commit-Position: refs/heads/master@{#14228}
2016-09-15 04:30:18 -07:00
}
}
GN: Build iOS framework in build_ios_libs.sh BUG=webrtc:6372 NOTRY=True R=kjellander@webrtc.org Review URL: https://codereview.webrtc.org/2408983002 . Cr-Commit-Position: refs/heads/master@{#14603}
2016-10-11 13:27:26 -07:00
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
if (is_ios) {
Generate iOS framework umbrella header. Instead of keeping the umbrella header in sync manually and needing ifdefs to make it include the correct headers depending on platform, generate it based on the headers we include in the framework target. Can also be used to only include internal software codec headers when compiling with support for them. Bug: webrtc:7925 Change-Id: I63f97af1efc8710cfd62d527fcb343fed05daae2 Reviewed-on: https://webrtc-review.googlesource.com/38702 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21613}
2018-01-15 13:31:03 +01:00
ios_framework_bundle_with_umbrella_header("framework_objc") {
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
info_plist = "objc/Framework/Info.plist"
output_name = "WebRTC"
Revert "Adding injectable audio decoder and encoder factory support to the RTCPeerConnection obj-c layer." This reverts commit 96de428fd1f301c3ad1355183b45e44db5ef3f7f. Reason for revert: Gives compile errors because the new ObjC++ headers are included in some targets that use ObjC. Original change's description: > Adding injectable audio decoder and encoder factory support to the RTCPeerConnection obj-c layer. > > Bug: webrtc:8093 > Change-Id: I868ce5f75a72c6deb065dec60784289d045ae22a > Reviewed-on: https://chromium-review.googlesource.com/608981 > Commit-Queue: Jeremy Newton-Smith <jeremyns@webrtc.org> > Reviewed-by: Zeke Chin <tkchin@webrtc.org> > Reviewed-by: Kári Tristan Helgason <kthelgason@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#19477} TBR=kjellander@webrtc.org,tkchin@webrtc.org,kthelgason@webrtc.org,jeremyns@webrtc.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: webrtc:8093 Change-Id: I3ade9dd979c9f13990a2972b15b786b8e78e1cd4 Reviewed-on: https://chromium-review.googlesource.com/640810 Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Commit-Queue: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#19573}
2017-08-29 09:49:43 +00:00
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
common_objc_headers = [
Move RTCAudioSession* files modules/audio_device/ -> sdk/Framework. BUG=NONE Review-Url: https://codereview.webrtc.org/2855023003 Cr-Commit-Position: refs/heads/master@{#18443}
2017-06-05 05:48:47 -07:00
"objc/Framework/Headers/WebRTC/RTCAudioSession.h",
Revert "Adding injectable audio decoder and encoder factory support to the RTCPeerConnection obj-c layer." This reverts commit 96de428fd1f301c3ad1355183b45e44db5ef3f7f. Reason for revert: Gives compile errors because the new ObjC++ headers are included in some targets that use ObjC. Original change's description: > Adding injectable audio decoder and encoder factory support to the RTCPeerConnection obj-c layer. > > Bug: webrtc:8093 > Change-Id: I868ce5f75a72c6deb065dec60784289d045ae22a > Reviewed-on: https://chromium-review.googlesource.com/608981 > Commit-Queue: Jeremy Newton-Smith <jeremyns@webrtc.org> > Reviewed-by: Zeke Chin <tkchin@webrtc.org> > Reviewed-by: Kári Tristan Helgason <kthelgason@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#19477} TBR=kjellander@webrtc.org,tkchin@webrtc.org,kthelgason@webrtc.org,jeremyns@webrtc.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: webrtc:8093 Change-Id: I3ade9dd979c9f13990a2972b15b786b8e78e1cd4 Reviewed-on: https://chromium-review.googlesource.com/640810 Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Commit-Queue: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#19573}
2017-08-29 09:49:43 +00:00
"objc/Framework/Headers/WebRTC/RTCVideoCodec.h",
"objc/Framework/Headers/WebRTC/RTCVideoCodecFactory.h",
Move RTCAudioSession* files modules/audio_device/ -> sdk/Framework. BUG=NONE Review-Url: https://codereview.webrtc.org/2855023003 Cr-Commit-Position: refs/heads/master@{#18443}
2017-06-05 05:48:47 -07:00
"objc/Framework/Headers/WebRTC/RTCAudioSessionConfiguration.h",
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
"objc/Framework/Headers/WebRTC/RTCAudioSource.h",
"objc/Framework/Headers/WebRTC/RTCAudioTrack.h",
"objc/Framework/Headers/WebRTC/RTCCameraVideoCapturer.h",
"objc/Framework/Headers/WebRTC/RTCCameraPreviewView.h",
Add RTCCertificate to framework headers. Bug: webrtc:9498 Change-Id: I3902d73741f78ab58188b0d4c6865afce9eff104 Reviewed-on: https://webrtc-review.googlesource.com/94481 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24305}
2018-08-16 09:29:19 +02:00
"objc/Framework/Headers/WebRTC/RTCCertificate.h",
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
"objc/Framework/Headers/WebRTC/RTCConfiguration.h",
"objc/Framework/Headers/WebRTC/RTCDataChannel.h",
"objc/Framework/Headers/WebRTC/RTCDataChannelConfiguration.h",
"objc/Framework/Headers/WebRTC/RTCDispatcher.h",
"objc/Framework/Headers/WebRTC/RTCEAGLVideoView.h",
"objc/Framework/Headers/WebRTC/RTCFieldTrials.h",
Reland "Add file capturer to AppRTCMobile on simulator." This is a reland of 5adcd198752b651f7b7e9199a91f9b873b7d7237 Original change's description: > Add file capturer to AppRTCMobile on simulator. > > To achieve this, the CL does the following > - Adds sample mp4 video > - Refactors the existing RTCFileVideoCapturer to achieve continious > capture and adds tests. > > Bug: webrtc:8406 > Change-Id: Ibc0891176c58ec9053b42e340d2113036e7199ec > Reviewed-on: https://webrtc-review.googlesource.com/12180 > Reviewed-by: Anders Carlsson <andersc@webrtc.org> > Reviewed-by: Magnus Jedvert <magjed@webrtc.org> > Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#20598} Bug: webrtc:8406 Change-Id: I93be89b86e342a9a8195e19ebaf4aef1410d2c20 Reviewed-on: https://webrtc-review.googlesource.com/23200 Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20870}
2017-11-15 13:15:24 +01:00
"objc/Framework/Headers/WebRTC/RTCFileVideoCapturer.h",
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
"objc/Framework/Headers/WebRTC/RTCIceCandidate.h",
"objc/Framework/Headers/WebRTC/RTCIceServer.h",
Reinstate "iOS - Add iceRegatherIntervalRange." This reverts commit 93adc3209b5ff10adaba54d5eab6b53bc2780685. Reverted originally because it depended on a CL which was reverted. That CL has been reinstated in: https: //chromium-review.googlesource.com/#/c/572070/ Bug: webrtc:7969 Change-Id: I608bbeaaba02e84908433c8260cf236df0307a97 Reviewed-on: https://chromium-review.googlesource.com/572405 Reviewed-by: Zeke Chin <tkchin@webrtc.org> Cr-Commit-Position: refs/heads/master@{#19035}
2017-07-14 16:06:41 -07:00
"objc/Framework/Headers/WebRTC/RTCIntervalRange.h",
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
"objc/Framework/Headers/WebRTC/RTCLegacyStatsReport.h",
"objc/Framework/Headers/WebRTC/RTCLogging.h",
"objc/Framework/Headers/WebRTC/RTCMacros.h",
"objc/Framework/Headers/WebRTC/RTCMediaConstraints.h",
"objc/Framework/Headers/WebRTC/RTCMediaSource.h",
"objc/Framework/Headers/WebRTC/RTCMediaStream.h",
"objc/Framework/Headers/WebRTC/RTCMediaStreamTrack.h",
"objc/Framework/Headers/WebRTC/RTCMetrics.h",
"objc/Framework/Headers/WebRTC/RTCMetricsSampleInfo.h",
Include RTCMTLVideoView even on archs without metal. This makes fixes some weirdness with the order of architectures in fat binaries, and with the umbrella header generation. Bug: webrtc:9573 Change-Id: Ibf4318c761da58e724820eba623d37b4739e6860 Reviewed-on: https://webrtc-review.googlesource.com/91421 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24160}
2018-07-31 15:39:25 +02:00
"objc/Framework/Headers/WebRTC/RTCMTLVideoView.h",
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
"objc/Framework/Headers/WebRTC/RTCPeerConnection.h",
"objc/Framework/Headers/WebRTC/RTCPeerConnectionFactory.h",
Exposed setOptions via RTCPeerConnectionFactory Exposed setOptions API for iOS SDK via RTCPeerConnectionFactory method to provide ability to disable encryption and control which network adapters are ignored. Only subset of webrtc::PeerConnectionFactoryInterface::Options options are exposed via iOS SDK, additional options can be exposed as requested. Android SDK has already exposed setOption API via Java's PeerConnection constructor, there changes provide similar functionaly to iOS SDK. Bug: webrtc:8712 Change-Id: Ia2de38cf382afc1bad9bbec6c6eac21ad29aee89 Reviewed-on: https://webrtc-review.googlesource.com/34900 Commit-Queue: Taylor Brandstetter <deadbeef@webrtc.org> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21504}
2018-01-02 13:33:16 +03:00
"objc/Framework/Headers/WebRTC/RTCPeerConnectionFactoryOptions.h",
Add missing header file to WebRTC iOS SDK. This header is missing from the public headers when building the framework. Bug: None Change-Id: I7ce3a57d5fa34d344239dfddcc6e29aee35a2ded Reviewed-on: https://webrtc-review.googlesource.com/79942 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23453}
2018-05-30 16:58:30 +02:00
"objc/Framework/Headers/WebRTC/RTCRtcpParameters.h",
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
"objc/Framework/Headers/WebRTC/RTCRtpCodecParameters.h",
"objc/Framework/Headers/WebRTC/RTCRtpEncodingParameters.h",
Add HeaderExtensions to RtpParameters Bug: webrtc:7580 Change-Id: I4fcf3e8bc4975a6b2baa6f24a17c254d2bf521d9 Reviewed-on: https://webrtc-review.googlesource.com/78288 Commit-Queue: Florent Castelli <orphis@webrtc.org> Reviewed-by: Sami Kalliomäki <sakal@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23584}
2018-06-12 18:33:49 +02:00
"objc/Framework/Headers/WebRTC/RTCRtpHeaderExtension.h",
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
"objc/Framework/Headers/WebRTC/RTCRtpParameters.h",
"objc/Framework/Headers/WebRTC/RTCRtpReceiver.h",
"objc/Framework/Headers/WebRTC/RTCRtpSender.h",
Add new PeerConnection APIs to the ObjC SDK This CL adds wrappers for the following PeerConnection native APIs to the Objective C API: - SdpSemantics enum added to the RTCConfiguration - RTCRtpTransceiver - RTCPeerConnection.addTrack - RTCPeerConnection.removeTrack - RTCPeerConnection.addTransceiver - RTCPeerConnection.transceivers Bug: webrtc:8870 Change-Id: I9449df9742a59e90894712dc7749ca30b569d94b Reviewed-on: https://webrtc-review.googlesource.com/54780 Commit-Queue: Steve Anton <steveanton@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22214}
2018-02-27 15:34:53 -08:00
"objc/Framework/Headers/WebRTC/RTCRtpTransceiver.h",
Expose RTCDtmfSender API via RTCRtpSender in ObjC SDK. Expose RTCDtmfSender API for ObcC SDK via exising RTCRtpSender to provide ability to use DTMF tones in ObjC apps which uses WebRTC. Android SDK has already exposed DTMF API via Java's DtmfSender object, there changes provide similar functionaly to ObjC SDK. Bug: webrtc:8713 Change-Id: Id68fddbbc362211dc8032fa31b38812d1cff8ed9 Reviewed-on: https://webrtc-review.googlesource.com/35800 Commit-Queue: Taylor Brandstetter <deadbeef@webrtc.org> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21505}
2018-01-02 14:44:35 +03:00
"objc/Framework/Headers/WebRTC/RTCDtmfSender.h",
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
"objc/Framework/Headers/WebRTC/RTCSSLAdapter.h",
"objc/Framework/Headers/WebRTC/RTCSessionDescription.h",
"objc/Framework/Headers/WebRTC/RTCTracing.h",
"objc/Framework/Headers/WebRTC/RTCVideoCapturer.h",
Injectable software video codecs in Obj-C. When injecting video codec factories in the Obj-C SDK, use the new peer connection API that uses webrtc::Video{De,En}CoderFactory classes and does not automatically add internal software codecs. Instead the injected factory can support internal VP8 and VP9 codecs through the included Obj-C classes RTCVideo{De,En}coderVP{8,9}. When not explicitly injecting any video codec factory, the old code path is still used and injects only H264 as an external codec and the internal codec factory is used. Bug: webrtc:7925 Change-Id: I657d30dfde71da9c0be341e213ab9f97a04caa58 Reviewed-on: https://webrtc-review.googlesource.com/3620 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20175}
2017-10-05 16:55:38 +02:00
"objc/Framework/Headers/WebRTC/RTCVideoCodecH264.h",
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
"objc/Framework/Headers/WebRTC/RTCVideoFrame.h",
Revert "Revert "Revert "Revert "Support more formats in RTCVideoFrame"""" This reverts commit 1cfeb435427a2fa677a495e34c882096efc193d0. Reason for revert: Fix unit test Original change's description: > Revert "Revert "Revert "Support more formats in RTCVideoFrame""" > > This reverts commit 7583390d1a3a7c4e9a77da0d77250abac0c34d1d. > > Reason for revert: Breaks unit tests > > Original change's description: > > Revert "Revert "Support more formats in RTCVideoFrame"" > > > > This reverts commit 0789dab2cbd1617e94d7300e375163d42345f3d4. > > > > Reason for revert: Include obc_corevideoframebuffer target > > > > Original change's description: > > > Revert "Support more formats in RTCVideoFrame" > > > > > > This reverts commit bd2220a9c496ef2e8567b68d4be9435a110bdc34. > > > > > > Reason for revert: Broke external clients > > > > > > Original change's description: > > > > Support more formats in RTCVideoFrame > > > > > > > > Implement Obj-C version of webrtc::VideoFrameBuffer and use that in > > > > RTCVideoFrame. > > > > > > > > Bug: webrtc:7785 > > > > Change-Id: I49f42bcf451dd6769b3a79a65fe7b400dce22677 > > > > Reviewed-on: https://chromium-review.googlesource.com/536773 > > > > Commit-Queue: Anders Carlsson <andersc@webrtc.org> > > > > Reviewed-by: Magnus Jedvert <magjed@webrtc.org> > > > > Cr-Commit-Position: refs/heads/master@{#18691} > > > > > > TBR=magjed@webrtc.org,andersc@webrtc.org > > > > > > Change-Id: Id765dd9543ed0613a6b2de108b268c3501025fcd > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: webrtc:7785 > > > Reviewed-on: https://chromium-review.googlesource.com/542837 > > > Reviewed-by: Anders Carlsson <andersc@webrtc.org> > > > Commit-Queue: Anders Carlsson <andersc@webrtc.org> > > > Cr-Commit-Position: refs/heads/master@{#18697} > > > > TBR=magjed@webrtc.org,andersc@webrtc.org > > > > Change-Id: I1ef5313b4a6c56eb8c7fd02d95db62c4e3c00255 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: webrtc:7785 > > Reviewed-on: https://chromium-review.googlesource.com/542838 > > Commit-Queue: Anders Carlsson <andersc@webrtc.org> > > Reviewed-by: Anders Carlsson <andersc@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#18716} > > TBR=magjed@webrtc.org,andersc@webrtc.org > > Change-Id: Id12f33698eb02041607cb9a5c54f37f01bfac5b1 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:7785 > Reviewed-on: https://chromium-review.googlesource.com/544840 > Reviewed-by: Anders Carlsson <andersc@webrtc.org> > Commit-Queue: Anders Carlsson <andersc@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#18718} TBR=magjed@webrtc.org,andersc@webrtc.org Change-Id: I184303ecba8db91ef7de709f982a295a2efe92eb Bug: webrtc:7785 Reviewed-on: https://chromium-review.googlesource.com/544841 Commit-Queue: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#18731}
2017-06-22 15:26:30 +02:00
"objc/Framework/Headers/WebRTC/RTCVideoFrameBuffer.h",
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
"objc/Framework/Headers/WebRTC/RTCVideoRenderer.h",
"objc/Framework/Headers/WebRTC/RTCVideoSource.h",
"objc/Framework/Headers/WebRTC/RTCVideoTrack.h",
"objc/Framework/Headers/WebRTC/RTCVideoViewShading.h",
"objc/Framework/Headers/WebRTC/UIDevice+RTCDevice.h",
ObjC SDK: Stop using built-in SW video codecs This CL removes the use of default built-in SW in the ObjC layer. If a client want to depend on the video SW codecs, they must inject them explicitly. Bug: webrtc:7925 Change-Id: If752e7f02109ff768dc5ec38d935203de85987c2 Reviewed-on: https://webrtc-review.googlesource.com/69800 Commit-Queue: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23073}
2018-04-13 15:36:43 +02:00
"objc/Framework/Headers/WebRTC/RTCVideoDecoderVP8.h",
"objc/Framework/Headers/WebRTC/RTCVideoDecoderVP9.h",
"objc/Framework/Headers/WebRTC/RTCVideoEncoderVP8.h",
"objc/Framework/Headers/WebRTC/RTCVideoEncoderVP9.h",
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
]
ObjC SDK: Stop using built-in SW video codecs This CL removes the use of default built-in SW in the ObjC layer. If a client want to depend on the video SW codecs, they must inject them explicitly. Bug: webrtc:7925 Change-Id: If752e7f02109ff768dc5ec38d935203de85987c2 Reviewed-on: https://webrtc-review.googlesource.com/69800 Commit-Queue: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23073}
2018-04-13 15:36:43 +02:00
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
if (!build_with_chromium) {
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
common_objc_headers += [
Add new Logger to iOS SDK to be able to intercept logs and report them to the appropriate system Bug: webrtc:8695 Change-Id: I4f81529222dcaf3dded1a0ab93fabf5cda1fdef8 Reviewed-on: https://webrtc-review.googlesource.com/37001 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21821}
2018-01-30 15:46:13 +01:00
"objc/Framework/Headers/WebRTC/RTCCallbackLogger.h",
"objc/Framework/Headers/WebRTC/RTCFileLogger.h",
]
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
}
Reland of Adding backward compatibility header (patchset #1 id:1 of https://codereview.webrtc.org/2908143003/ ) Reason for revert: Take three of relanding this after all internal issues have been resolved. Original issue's description: > Revert of Adding backward compatibility header (patchset #1 id:1 of https://codereview.webrtc.org/2909923002/ ) > > Reason for revert: > Breaks downstream project. > > Original issue's description: > > Adding backward compatibility header > > > > This header will be removed ad soon as downstream projects will be > > updated. > > > > BUG=webrtc:4867 > > NOTRY=True > > TBR=kjellander@webrtc.org > > > > Review-Url: https://codereview.webrtc.org/2909923002 > > Cr-Commit-Position: refs/heads/master@{#18306} > > Committed: https://chromium.googlesource.com/external/webrtc/+/4fa8a97cc3268de73ad021ff56aaa9bf1a566ed4 > > TBR=kjellander@webrtc.org,magjed@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:4867 > > Review-Url: https://codereview.webrtc.org/2908143003 > Cr-Commit-Position: refs/heads/master@{#18308} > Committed: https://chromium.googlesource.com/external/webrtc/+/6684fdce93ff25a837117cd7a811a6d86cbe4b20 TBR=kjellander@webrtc.org,magjed@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4867 Review-Url: https://codereview.webrtc.org/2912773003 Cr-Commit-Position: refs/heads/master@{#18320}
2017-05-30 01:50:35 -07:00
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
sources = common_objc_headers
public_headers = common_objc_headers
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
ldflags = [
"-all_load",
"-install_name",
"@rpath/$output_name.framework/$output_name",
]
Actually move CoreVideoFrameBuffer from webrtc/common_video/ to webrtc/sdk/objc/ The previous reland https://codereview.webrtc.org/2860033002/ didn't actually move CoreVideoFrameBuffer because of a rebase mistake. This CL moves the files. BUG=None Review-Url: https://codereview.webrtc.org/2864303002 Cr-Commit-Position: refs/heads/master@{#18048}
2017-05-08 05:32:05 -07:00
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
deps = [
Rename all objc targets to be suffixed for consistency BUG=webrtc:6412 Review-Url: https://codereview.webrtc.org/3001023003 Cr-Commit-Position: refs/heads/master@{#19489}
2017-08-24 05:43:45 -07:00
":audio_objc",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
":common_objc",
":default_codec_factory_objc",
":native_api",
":native_video",
":peerconnectionfactory_base_objc",
Rename all objc targets to be suffixed for consistency BUG=webrtc:6412 Review-Url: https://codereview.webrtc.org/3001023003 Cr-Commit-Position: refs/heads/master@{#19489}
2017-08-24 05:43:45 -07:00
":ui_objc",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
":videocapture_objc",
":videocodec_objc",
":videotoolbox_objc",
Remove remains of webrtc/base All downstream code have been updated to the new location. In PRESUBMIT.py: * Remove webrtc/rtc_base from CPP_BLACKLIST * Add webrtc/rtc_base to LEGACY_API_DIRS Fix some duplicated paths in webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn BUG=webrtc:7634 TBR=kwiberg@webrtc.org Review-Url: https://codereview.webrtc.org/2976293002 Cr-Commit-Position: refs/heads/master@{#19094}
2017-07-19 10:40:47 -07:00
"../rtc_base:rtc_base_approved",
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
"../system_wrappers:field_trial_default",
"../system_wrappers:metrics_default",
Reland Use runtime enabled features API to enable dual stream mode This is an unchanged patch after dependency fixes in downstream projects are implemented. Original patch was reviewed here: https://webrtc-review.googlesource.com/c/src/+/39008 TBR=phoglund@webrtc.org,ilnik@webrtc.org,nisse@webrtc.org,philipel@webrtc.org,lliuu@webrtc.org Change-Id: I648bbf63d34282a48cabc854615005ec65b28cb3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:8287 Reviewed-on: https://webrtc-review.googlesource.com/40420 Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21674}
2018-01-17 19:57:24 +00:00
"../system_wrappers:runtime_enabled_features_default",
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
]
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
if (rtc_use_metal_rendering) {
deps += [ ":metal_objc" ]
}
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
libs = [
"AVFoundation.framework",
"CoreGraphics.framework",
"CoreMedia.framework",
"GLKit.framework",
]
Broadcast extension for AppRTCMobile on iOS This provides an environment for testing out using WebRTC from an iOS extension. It implements a ReplayKit broadcast extension for live streaming games and screensharing. The extension is only supported on iOS 11+ and is guarded by a build flag. Bug: webrtc:9335 Change-Id: Id218d6c73ef7599f5953c5a1e0e62e5d0dc4f10b Reviewed-on: https://webrtc-review.googlesource.com/80000 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23504}
2018-06-04 10:24:37 +02:00
configs += [
"..:common_objc",
":used_from_extension",
]
Actually move CoreVideoFrameBuffer from webrtc/common_video/ to webrtc/sdk/objc/ The previous reland https://codereview.webrtc.org/2860033002/ didn't actually move CoreVideoFrameBuffer because of a rebase mistake. This CL moves the files. BUG=None Review-Url: https://codereview.webrtc.org/2864303002 Cr-Commit-Position: refs/heads/master@{#18048}
2017-05-08 05:32:05 -07:00
Rename all objc targets to be suffixed for consistency BUG=webrtc:6412 Review-Url: https://codereview.webrtc.org/3001023003 Cr-Commit-Position: refs/heads/master@{#19489}
2017-08-24 05:43:45 -07:00
public_configs = [ ":common_config_objc" ]
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
}
Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2911053002/ ) Reason for revert: Take three of relanding this after all internal issues have been resolved. Original issue's description: > Revert of Split iOS sdk in to separate targets (patchset #3 id:320001 of https://codereview.webrtc.org/2893843003/ ) > > Reason for revert: > Breaks downstream project. > > Original issue's description: > > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2893593002/ ) > > > > Reason for revert: > > Take two of fixing downstream issues? > > > > Original issue's description: > > > Revert of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890733003/ ) > > > > > > Reason for revert: > > > Still problems with downstream projects > > > > > > Original issue's description: > > > > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890513002/ ) > > > > > > > > Reason for revert: > > > > Fixing downstream breakages > > > > > > > > Original issue's description: > > > > > Revert of Split iOS sdk in to separate targets (patchset #13 id:280001 of https://codereview.webrtc.org/2862543002/ ) > > > > > > > > > > Reason for revert: > > > > > Breaking downstream projects. > > > > > > > > > > Original issue's description: > > > > > > Split iOS sdk in to separate targets > > > > > > > > > > > > This CL splits the iOS sdk into separate static libraries for video, > > > > > > audio, ui, common, and peerconnection-related code. This will in the > > > > > > future make it easier to compile WebRTC without unneeded components. > > > > > > > > > > > > BUG=webrtc:4867 > > > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2862543002 > > > > > > Cr-Commit-Position: refs/heads/master@{#18166} > > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/52c83fe7102f566cf35a7533092873d58b38f426 > > > > > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,kthelgason@webrtc.org > > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > > NOPRESUBMIT=true > > > > > NOTREECHECKS=true > > > > > NOTRY=true > > > > > BUG=webrtc:4867 > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2890513002 > > > > > Cr-Commit-Position: refs/heads/master@{#18170} > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/9756238084707787f735e1294e896e462e459717 > > > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > NOPRESUBMIT=true > > > > NOTREECHECKS=true > > > > NOTRY=true > > > > BUG=webrtc:4867 > > > > > > > > Review-Url: https://codereview.webrtc.org/2890733003 > > > > Cr-Commit-Position: refs/heads/master@{#18174} > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/d51e042492bedd057bc0cac7828979d5c7369cea > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > NOPRESUBMIT=true > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG=webrtc:4867 > > > > > > Review-Url: https://codereview.webrtc.org/2893593002 > > > Cr-Commit-Position: refs/heads/master@{#18182} > > > Committed: https://chromium.googlesource.com/external/webrtc/+/37144b214e2baf62ecb262ab878dde8c59cdd6a3 > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=webrtc:4867 > > > > Review-Url: https://codereview.webrtc.org/2893843003 > > Cr-Commit-Position: refs/heads/master@{#18303} > > Committed: https://chromium.googlesource.com/external/webrtc/+/580c3522d294c877adfe555048c675bd8d166657 > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org,kthelgason@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:4867 > > Review-Url: https://codereview.webrtc.org/2911053002 > Cr-Commit-Position: refs/heads/master@{#18309} > Committed: https://chromium.googlesource.com/external/webrtc/+/af5c05540cc8208f682cafe88c5c16a505479196 TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org,mbonadei@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4867 Review-Url: https://codereview.webrtc.org/2913753003 Cr-Commit-Position: refs/heads/master@{#18319}
2017-05-30 01:48:47 -07:00
}
Fix native api in preparation for native_api example. Add native api conversions for video frames and video renderer. This also requires some changes to sdk/BUILD to avoid cyclic dependencies. Bug: webrtc:8832 Change-Id: Ibf21e63bdcae195dcb61d63f9262e6a8dc4fa790 Reviewed-on: https://webrtc-review.googlesource.com/57142 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22340}
2018-03-07 10:32:03 +01:00
rtc_static_library("wrapped_native_codec_objc") {
sources = [
"objc/Framework/Classes/PeerConnection/RTCWrappedNativeVideoDecoder.h",
"objc/Framework/Classes/PeerConnection/RTCWrappedNativeVideoDecoder.mm",
"objc/Framework/Classes/PeerConnection/RTCWrappedNativeVideoEncoder.h",
"objc/Framework/Classes/PeerConnection/RTCWrappedNativeVideoEncoder.mm",
]
configs += [ "..:common_objc" ]
public_configs = [ ":common_config_objc" ]
deps = [
":common_objc",
":videocodec_objc",
"../api/video_codecs:video_codecs_api",
"../media:rtc_media_base",
]
}
Create experimental Obj-C++ API. This can be used to wrap Objective-C components in C++ classes, so users can use the WebRTC C++ API directly together with the iOS specific components provided by our SDK. Bug: webrtc:8832 Change-Id: I6d34f7ec62d51df8d3a5340a2e17d30ae73e13e8 Reviewed-on: https://webrtc-review.googlesource.com/46162 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21850}
2018-02-01 15:47:05 +01:00
# The native API is currently experimental and may change without notice.
rtc_static_library("native_api") {
visibility = [ "*" ]
Mark built-in software video codecs as poisonous. The goal is to make these injectable, and only VP8 and VP9 specific targets should depend on them. Bug: webrtc:7925 Change-Id: Ie9239a54d197fe70c93de0582797211fef6997a2 Reviewed-on: https://webrtc-review.googlesource.com/72082 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23021}
2018-04-24 16:39:05 +02:00
allow_poison = [
"audio_codecs", # TODO(bugs.webrtc.org/8396): Remove.
"software_video_codecs", # TODO(bugs.webrtc.org/7925): Remove.
]
Create experimental Obj-C++ API. This can be used to wrap Objective-C components in C++ classes, so users can use the WebRTC C++ API directly together with the iOS specific components provided by our SDK. Bug: webrtc:8832 Change-Id: I6d34f7ec62d51df8d3a5340a2e17d30ae73e13e8 Reviewed-on: https://webrtc-review.googlesource.com/46162 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21850}
2018-02-01 15:47:05 +01:00
sources = [
Add an example app for iOS native API. Demonstrates how to use the iOS native API to wrap components into C++ classes. This CL also introduces a native API wrapper for the capturer. The C++ code is forked from the corresponding CL for Android at https://webrtc-review.googlesource.com/c/src/+/60540 Bug: webrtc:8832 Change-Id: I12d9f30e701c0222628e329218f6d5bfca26e6e0 Reviewed-on: https://webrtc-review.googlesource.com/61422 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22484}
2018-03-15 09:41:03 +01:00
"objc/Framework/Native/api/video_capturer.h",
"objc/Framework/Native/api/video_capturer.mm",
Create experimental Obj-C++ API. This can be used to wrap Objective-C components in C++ classes, so users can use the WebRTC C++ API directly together with the iOS specific components provided by our SDK. Bug: webrtc:8832 Change-Id: I6d34f7ec62d51df8d3a5340a2e17d30ae73e13e8 Reviewed-on: https://webrtc-review.googlesource.com/46162 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21850}
2018-02-01 15:47:05 +01:00
"objc/Framework/Native/api/video_decoder_factory.h",
"objc/Framework/Native/api/video_decoder_factory.mm",
"objc/Framework/Native/api/video_encoder_factory.h",
"objc/Framework/Native/api/video_encoder_factory.mm",
Fix native api in preparation for native_api example. Add native api conversions for video frames and video renderer. This also requires some changes to sdk/BUILD to avoid cyclic dependencies. Bug: webrtc:8832 Change-Id: Ibf21e63bdcae195dcb61d63f9262e6a8dc4fa790 Reviewed-on: https://webrtc-review.googlesource.com/57142 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22340}
2018-03-07 10:32:03 +01:00
"objc/Framework/Native/api/video_frame.h",
"objc/Framework/Native/api/video_frame.mm",
"objc/Framework/Native/api/video_frame_buffer.h",
"objc/Framework/Native/api/video_frame_buffer.mm",
"objc/Framework/Native/api/video_renderer.h",
"objc/Framework/Native/api/video_renderer.mm",
Create experimental Obj-C++ API. This can be used to wrap Objective-C components in C++ classes, so users can use the WebRTC C++ API directly together with the iOS specific components provided by our SDK. Bug: webrtc:8832 Change-Id: I6d34f7ec62d51df8d3a5340a2e17d30ae73e13e8 Reviewed-on: https://webrtc-review.googlesource.com/46162 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21850}
2018-02-01 15:47:05 +01:00
]
configs += [ "..:common_objc" ]
public_configs = [ ":common_config_objc" ]
deps = [
":native_video",
Add an example app for iOS native API. Demonstrates how to use the iOS native API to wrap components into C++ classes. This CL also introduces a native API wrapper for the capturer. The C++ code is forked from the corresponding CL for Android at https://webrtc-review.googlesource.com/c/src/+/60540 Bug: webrtc:8832 Change-Id: I12d9f30e701c0222628e329218f6d5bfca26e6e0 Reviewed-on: https://webrtc-review.googlesource.com/61422 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22484}
2018-03-15 09:41:03 +01:00
":videocapturebase_objc",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
":videocodec_objc",
":videoframebuffer_objc",
Fix native api in preparation for native_api example. Add native api conversions for video frames and video renderer. This also requires some changes to sdk/BUILD to avoid cyclic dependencies. Bug: webrtc:8832 Change-Id: Ibf21e63bdcae195dcb61d63f9262e6a8dc4fa790 Reviewed-on: https://webrtc-review.googlesource.com/57142 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22340}
2018-03-07 10:32:03 +01:00
":videorenderer_objc",
Add an example app for iOS native API. Demonstrates how to use the iOS native API to wrap components into C++ classes. This CL also introduces a native API wrapper for the capturer. The C++ code is forked from the corresponding CL for Android at https://webrtc-review.googlesource.com/c/src/+/60540 Bug: webrtc:8832 Change-Id: I12d9f30e701c0222628e329218f6d5bfca26e6e0 Reviewed-on: https://webrtc-review.googlesource.com/61422 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22484}
2018-03-15 09:41:03 +01:00
"../api:libjingle_peerconnection_api",
New file api/video/BUILD.gn Build targets involving files under api/video/ are moved into this file, from api/BUILD.gn. In addition, drop "_api" part of target names, and move the header file api/videosinkinterface.h to api/video/video_sink_interface.h. Bug: webrtc:9253 Change-Id: I2896d3f063db8dff902bc29738578395b2fcc155 Reviewed-on: https://webrtc-review.googlesource.com/75500 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23207}
2018-05-11 11:15:30 +02:00
"../api/video:video_frame",
Create experimental Obj-C++ API. This can be used to wrap Objective-C components in C++ classes, so users can use the WebRTC C++ API directly together with the iOS specific components provided by our SDK. Bug: webrtc:8832 Change-Id: I6d34f7ec62d51df8d3a5340a2e17d30ae73e13e8 Reviewed-on: https://webrtc-review.googlesource.com/46162 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21850}
2018-02-01 15:47:05 +01:00
"../api/video_codecs:video_codecs_api",
"../common_video",
"../rtc_base:rtc_base",
Add missing dependencies on //third_party/abseil-cpp/absl/memory. Abseil uses -isystem and -imsvc because of some warnings, these two flags are not used by "gn check", this introduced some regressions. CL https://chromium-review.googlesource.com/c/chromium/src/+/1124478 will try to switch back absl to -I. Bug: None Change-Id: I52e857ef1d11831393c35a1bee09479b83827bad Reviewed-on: https://webrtc-review.googlesource.com/88121 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23923}
2018-07-11 09:18:37 +02:00
"//third_party/abseil-cpp/absl/memory",
Create experimental Obj-C++ API. This can be used to wrap Objective-C components in C++ classes, so users can use the WebRTC C++ API directly together with the iOS specific components provided by our SDK. Bug: webrtc:8832 Change-Id: I6d34f7ec62d51df8d3a5340a2e17d30ae73e13e8 Reviewed-on: https://webrtc-review.googlesource.com/46162 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21850}
2018-02-01 15:47:05 +01:00
]
}
rtc_static_library("native_video") {
sources = [
Fix native api in preparation for native_api example. Add native api conversions for video frames and video renderer. This also requires some changes to sdk/BUILD to avoid cyclic dependencies. Bug: webrtc:8832 Change-Id: Ibf21e63bdcae195dcb61d63f9262e6a8dc4fa790 Reviewed-on: https://webrtc-review.googlesource.com/57142 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22340}
2018-03-07 10:32:03 +01:00
"objc/Framework/Native/src/objc_frame_buffer.h",
"objc/Framework/Native/src/objc_frame_buffer.mm",
Create experimental Obj-C++ API. This can be used to wrap Objective-C components in C++ classes, so users can use the WebRTC C++ API directly together with the iOS specific components provided by our SDK. Bug: webrtc:8832 Change-Id: I6d34f7ec62d51df8d3a5340a2e17d30ae73e13e8 Reviewed-on: https://webrtc-review.googlesource.com/46162 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21850}
2018-02-01 15:47:05 +01:00
"objc/Framework/Native/src/objc_video_decoder_factory.h",
"objc/Framework/Native/src/objc_video_decoder_factory.mm",
"objc/Framework/Native/src/objc_video_encoder_factory.h",
"objc/Framework/Native/src/objc_video_encoder_factory.mm",
Fix native api in preparation for native_api example. Add native api conversions for video frames and video renderer. This also requires some changes to sdk/BUILD to avoid cyclic dependencies. Bug: webrtc:8832 Change-Id: Ibf21e63bdcae195dcb61d63f9262e6a8dc4fa790 Reviewed-on: https://webrtc-review.googlesource.com/57142 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22340}
2018-03-07 10:32:03 +01:00
"objc/Framework/Native/src/objc_video_frame.h",
"objc/Framework/Native/src/objc_video_frame.mm",
"objc/Framework/Native/src/objc_video_renderer.h",
"objc/Framework/Native/src/objc_video_renderer.mm",
"objc/Framework/Native/src/objc_video_track_source.h",
"objc/Framework/Native/src/objc_video_track_source.mm",
Create experimental Obj-C++ API. This can be used to wrap Objective-C components in C++ classes, so users can use the WebRTC C++ API directly together with the iOS specific components provided by our SDK. Bug: webrtc:8832 Change-Id: I6d34f7ec62d51df8d3a5340a2e17d30ae73e13e8 Reviewed-on: https://webrtc-review.googlesource.com/46162 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21850}
2018-02-01 15:47:05 +01:00
]
configs += [ "..:common_objc" ]
public_configs = [ ":common_config_objc" ]
if (!build_with_chromium && is_clang) {
# Suppress warnings from the Chromium Clang plugin
# (bugs.webrtc.org/163).
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
}
deps = [
":common_objc",
Add an example app for iOS native API. Demonstrates how to use the iOS native API to wrap components into C++ classes. This CL also introduces a native API wrapper for the capturer. The C++ code is forked from the corresponding CL for Android at https://webrtc-review.googlesource.com/c/src/+/60540 Bug: webrtc:8832 Change-Id: I12d9f30e701c0222628e329218f6d5bfca26e6e0 Reviewed-on: https://webrtc-review.googlesource.com/61422 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22484}
2018-03-15 09:41:03 +01:00
":videocapturebase_objc",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
":videocodec_objc",
":videoframebuffer_objc",
Fix native api in preparation for native_api example. Add native api conversions for video frames and video renderer. This also requires some changes to sdk/BUILD to avoid cyclic dependencies. Bug: webrtc:8832 Change-Id: Ibf21e63bdcae195dcb61d63f9262e6a8dc4fa790 Reviewed-on: https://webrtc-review.googlesource.com/57142 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22340}
2018-03-07 10:32:03 +01:00
":videorenderer_objc",
":wrapped_native_codec_objc",
New file api/video/BUILD.gn Build targets involving files under api/video/ are moved into this file, from api/BUILD.gn. In addition, drop "_api" part of target names, and move the header file api/videosinkinterface.h to api/video/video_sink_interface.h. Bug: webrtc:9253 Change-Id: I2896d3f063db8dff902bc29738578395b2fcc155 Reviewed-on: https://webrtc-review.googlesource.com/75500 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23207}
2018-05-11 11:15:30 +02:00
"../api/video:video_frame",
"../api/video:video_frame_i420",
Create experimental Obj-C++ API. This can be used to wrap Objective-C components in C++ classes, so users can use the WebRTC C++ API directly together with the iOS specific components provided by our SDK. Bug: webrtc:8832 Change-Id: I6d34f7ec62d51df8d3a5340a2e17d30ae73e13e8 Reviewed-on: https://webrtc-review.googlesource.com/46162 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21850}
2018-02-01 15:47:05 +01:00
"../api/video_codecs:video_codecs_api",
"../common_video",
"../media:rtc_audio_video",
"../media:rtc_media_base",
"../modules:module_api",
"../modules/video_coding:video_codec_interface",
"../rtc_base:checks",
"../rtc_base:rtc_base",
Add missing dependencies on //third_party/abseil-cpp/absl/memory. Abseil uses -isystem and -imsvc because of some warnings, these two flags are not used by "gn check", this introduced some regressions. CL https://chromium-review.googlesource.com/c/chromium/src/+/1124478 will try to switch back absl to -I. Bug: None Change-Id: I52e857ef1d11831393c35a1bee09479b83827bad Reviewed-on: https://webrtc-review.googlesource.com/88121 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23923}
2018-07-11 09:18:37 +02:00
"//third_party/abseil-cpp/absl/memory",
Create experimental Obj-C++ API. This can be used to wrap Objective-C components in C++ classes, so users can use the WebRTC C++ API directly together with the iOS specific components provided by our SDK. Bug: webrtc:8832 Change-Id: I6d34f7ec62d51df8d3a5340a2e17d30ae73e13e8 Reviewed-on: https://webrtc-review.googlesource.com/46162 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21850}
2018-02-01 15:47:05 +01:00
]
}
The goal of this CL is to separate Obj-C/Obj-C++ code from targets which have also C++ code (see https://bugs.chromium.org/p/webrtc/issues/detail?id=7743 for more information). BUG=webrtc:7743 Review-Url: https://codereview.webrtc.org/2995753002 Cr-Commit-Position: refs/heads/master@{#19501}
2017-08-24 12:26:05 -07:00
rtc_static_library("video_toolbox_cc") {
Tightening visibility of video_toolbox_cc. This CL aligns the visibility to the standard decided in: https://codereview.webrtc.org/3001623003. BUG=webrtc:7743 NOTRY=True Review-Url: https://codereview.webrtc.org/3010123002 Cr-Commit-Position: refs/heads/master@{#19659}
2017-09-04 05:51:34 -07:00
visibility = [ ":videotoolbox_objc" ]
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
sources = [
ObjC: Implement HW codecs in ObjC instead of C++ The current ObjC HW encoder is implemented as a C++ webrtc::VideoEncoder. We then wrap it two times in the following way: webrtc::VideoEncoder -> RTCVideoEncoder -> webrtc::VideoEncoder. This was originally done to minimize the code diff when landing the injectable encoder. This CL removes the first wrapping and implements the ObjC HW encoder as a RTCVideoEncoder directly. Similarly, the decoder is implemented as a RTCVideoDecoder directly. Based on andersc@ CL: https://codereview.webrtc.org/2978623002/. BUG=webrtc:7924 Review-Url: https://codereview.webrtc.org/2987413002 Cr-Commit-Position: refs/heads/master@{#19255}
2017-08-07 06:55:28 -07:00
"objc/Framework/Classes/VideoToolbox/helpers.cc",
"objc/Framework/Classes/VideoToolbox/helpers.h",
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
"objc/Framework/Classes/VideoToolbox/nalu_rewriter.cc",
"objc/Framework/Classes/VideoToolbox/nalu_rewriter.h",
The goal of this CL is to separate Obj-C/Obj-C++ code from targets which have also C++ code (see https://bugs.chromium.org/p/webrtc/issues/detail?id=7743 for more information). BUG=webrtc:7743 Review-Url: https://codereview.webrtc.org/2995753002 Cr-Commit-Position: refs/heads/master@{#19501}
2017-08-24 12:26:05 -07:00
]
deps = [
"../common_video",
"../modules:module_api",
"../modules/video_coding:webrtc_h264",
Fix circular dependencies between optional, array_view, and rtc_base. This splits things out of rtc_base and makes dependencies explicit. Bug: webrtc:6828 Change-Id: Id521896c3c43595349021c857bec216e429a0c8d Reviewed-on: https://webrtc-review.googlesource.com/32780 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21264}
2017-12-13 16:05:42 +01:00
"../rtc_base:checks",
The goal of this CL is to separate Obj-C/Obj-C++ code from targets which have also C++ code (see https://bugs.chromium.org/p/webrtc/issues/detail?id=7743 for more information). BUG=webrtc:7743 Review-Url: https://codereview.webrtc.org/2995753002 Cr-Commit-Position: refs/heads/master@{#19501}
2017-08-24 12:26:05 -07:00
"../rtc_base:rtc_base_approved",
]
}
rtc_static_library("videotoolbox_objc") {
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
visibility = [ "*" ]
Mark built-in software video codecs as poisonous. The goal is to make these injectable, and only VP8 and VP9 specific targets should depend on them. Bug: webrtc:7925 Change-Id: Ie9239a54d197fe70c93de0582797211fef6997a2 Reviewed-on: https://webrtc-review.googlesource.com/72082 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23021}
2018-04-24 16:39:05 +02:00
allow_poison = [
"audio_codecs", # TODO(bugs.webrtc.org/8396): Remove.
"software_video_codecs", # TODO(bugs.webrtc.org/7925): Remove.
]
The goal of this CL is to separate Obj-C/Obj-C++ code from targets which have also C++ code (see https://bugs.chromium.org/p/webrtc/issues/detail?id=7743 for more information). BUG=webrtc:7743 Review-Url: https://codereview.webrtc.org/2995753002 Cr-Commit-Position: refs/heads/master@{#19501}
2017-08-24 12:26:05 -07:00
sources = [
"objc/Framework/Classes/VideoToolbox/RTCVideoDecoderH264.mm",
"objc/Framework/Classes/VideoToolbox/RTCVideoEncoderH264.mm",
Reland of Add a webrtc{en,de}coderfactory implementation for VideoToolbox (patchset #1 id:1 of https://codereview.webrtc.org/2483273002/ ) Reason for revert: Fix gyp build Original issue's description: > Revert of Add a webrtc{en,de}coderfactory implementation for VideoToolbox (patchset #2 id:20001 of https://codereview.webrtc.org/2463313002/ ) > > Reason for revert: > Broke dependent project because the .gn changes weren't accompanied by corresponding .gyp changes. > > Original issue's description: > > Add a webrtc{en,de}coderfactory implementation for VideoToolbox > > > > This CL removes the coupling of the VideoToolbox h264 implementation > > to the generic h264 code. The files have been moved into sdb/obj/Framework > > and all dependency on them has been removed from the rest of WebRTC. > > We now add it as an external encoder via a factory supplied to the > > CreatePeerConnectionFactory call. This also brings the iOS implementation > > closer to what we do on Android for MediaCodec. > > > > BUG=webrtc:6619 > > > > Committed: https://crrev.com/6a5047dad31f14f53dd9f8bc1ecde19e1dede2e4 > > Cr-Commit-Position: refs/heads/master@{#14953} > > TBR=magjed@webrtc.org,stefan@webrtc.org,kthelgason@webrtc.org > BUG=webrtc:6619 > > Committed: https://crrev.com/d69ad84420d9c0e1c11450c352f6c92e7c9583f1 > Cr-Commit-Position: refs/heads/master@{#14985} R=magjed@webrtc.org TBR=kwiberg@webrtc.org, magjed@webrtc.org, stefan@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6619 Review URL: https://codereview.webrtc.org/2487723004 . Cr-Commit-Position: refs/heads/master@{#14992}
2016-11-09 10:43:26 +01:00
]
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
Broadcast extension for AppRTCMobile on iOS This provides an environment for testing out using WebRTC from an iOS extension. It implements a ReplayKit broadcast extension for live streaming games and screensharing. The extension is only supported on iOS 11+ and is guarded by a build flag. Bug: webrtc:9335 Change-Id: Id218d6c73ef7599f5953c5a1e0e62e5d0dc4f10b Reviewed-on: https://webrtc-review.googlesource.com/80000 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23504}
2018-06-04 10:24:37 +02:00
configs += [
"..:common_objc",
":used_from_extension",
]
if (is_ios && rtc_apprtcmobile_broadcast_extension) {
defines = [ "RTC_APPRTCMOBILE_BROADCAST_EXTENSION" ]
}
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
deps = [
Rename all objc targets to be suffixed for consistency BUG=webrtc:6412 Review-Url: https://codereview.webrtc.org/3001023003 Cr-Commit-Position: refs/heads/master@{#19489}
2017-08-24 05:43:45 -07:00
":common_objc",
Create experimental Obj-C++ API. This can be used to wrap Objective-C components in C++ classes, so users can use the WebRTC C++ API directly together with the iOS specific components provided by our SDK. Bug: webrtc:8832 Change-Id: I6d34f7ec62d51df8d3a5340a2e17d30ae73e13e8 Reviewed-on: https://webrtc-review.googlesource.com/46162 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21850}
2018-02-01 15:47:05 +01:00
":native_api",
Rename all objc targets to be suffixed for consistency BUG=webrtc:6412 Review-Url: https://codereview.webrtc.org/3001023003 Cr-Commit-Position: refs/heads/master@{#19489}
2017-08-24 05:43:45 -07:00
":video_objc",
The goal of this CL is to separate Obj-C/Obj-C++ code from targets which have also C++ code (see https://bugs.chromium.org/p/webrtc/issues/detail?id=7743 for more information). BUG=webrtc:7743 Review-Url: https://codereview.webrtc.org/2995753002 Cr-Commit-Position: refs/heads/master@{#19501}
2017-08-24 12:26:05 -07:00
":video_toolbox_cc",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
":videocodec_objc",
":videoframebuffer_objc",
Fix native api in preparation for native_api example. Add native api conversions for video frames and video renderer. This also requires some changes to sdk/BUILD to avoid cyclic dependencies. Bug: webrtc:8832 Change-Id: Ibf21e63bdcae195dcb61d63f9262e6a8dc4fa790 Reviewed-on: https://webrtc-review.googlesource.com/57142 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22340}
2018-03-07 10:32:03 +01:00
":videosource_objc",
New file api/video/BUILD.gn Build targets involving files under api/video/ are moved into this file, from api/BUILD.gn. In addition, drop "_api" part of target names, and move the header file api/videosinkinterface.h to api/video/video_sink_interface.h. Bug: webrtc:9253 Change-Id: I2896d3f063db8dff902bc29738578395b2fcc155 Reviewed-on: https://webrtc-review.googlesource.com/75500 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23207}
2018-05-11 11:15:30 +02:00
"../api/video:video_frame",
Reland of Injectable Obj-C video codecs (patchset #1 id:1 of https://codereview.webrtc.org/2980173002/ ) Reason for revert: Relanding after fixing issues with no video. Original issue's description: > Revert of Injectable Obj-C video codecs (patchset #2 id:370001 of https://codereview.webrtc.org/2979983002/ ) > > Reason for revert: > Still having problems with no video. Reverting. > Once no video is visible, no video is available from then on even if the callee app is in the foreground. > > > Original issue's description: > > Reland of Injectable Obj-C video codecs (patchset #1 id:1 of https://codereview.webrtc.org/2979973002/ ) > > > > Reason for revert: > > Fix the broken build file > > > > Original issue's description: > > > Revert of Injectable Obj-C video codecs (patchset #3 id:400001 of https://codereview.webrtc.org/2981583002/ ) > > > > > > Reason for revert: > > > Breaks bots. Build file incorrect. > > > > > > Original issue's description: > > > > Reland of Injectable Obj-C video codecs (patchset #1 id:1 of https://codereview.webrtc.org/2975963002/ ) > > > > > > > > Reason for revert: > > > > New CL for fixing the issues > > > > > > > > Original issue's description: > > > > > Revert of Injectable Obj-C video codecs (patchset #8 id:140001 of https://codereview.webrtc.org/2966023002/ ) > > > > > > > > > > Reason for revert: > > > > > Causes no video in certain scenarios. Please come up with a test plan or unit test to prevent such problems in the future. > > > > > > > > > > Original issue's description: > > > > > > Injectable Obj-C video codecs > > > > > > > > > > > > Initial CL for this effort, with a working RTCVideoEncoder/Decoder for H264 > > > > > > (wrapping the VideoToolbox codec). > > > > > > > > > > > > Some notes / things left to do: > > > > > > - There are some hard-coded references to codec types that are supported by > > > > > > webrtc::VideoCodec, cricket::VideoCodec, webrtc::CodecSpecificInfo etc > > > > > > since we need to convert to/from these types in ObjCVideoEncoder/Decoder. > > > > > > These types would need to be more codec agnostic to avoid this. > > > > > > - Most interfaces are borrowed from the design document for injectable > > > > > > codecs in Android. Some data in the corresponding C++ classes is discarded > > > > > > when converting to the Obj-C version, since it has fewer fields. I have not > > > > > > verified whether all data that we do keep is needed, or whether we might be > > > > > > losing anything useful in these conversions. > > > > > > - Implement the VideoToolbox codec code directly in the RTCVideoEncoderH264 > > > > > > classes, instead of wrapping webrtc::H264VideoToolboxEncoder / decoder. > > > > > > Eliminates converting between ObjC/C++ types outside the ObjCVideoEncoder/ > > > > > > Decoder wrapper classes. > > > > > > - List the injected codec factory's supported codecs in the list of codecs in > > > > > > AppRTCMobile. > > > > > > > > > > > > BUG=webrtc:7924 > > > > > > R=magjed@webrtc.org > > > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2966023002 . > > > > > > Cr-Commit-Position: refs/heads/master@{#18928} > > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/a0349c138db62c52435be84b6c837f5f4758e264 > > > > > > > > > > TBR=magjed@webrtc.org,andersc@webrtc.org > > > > > # Not skipping CQ checks because original CL landed more than 1 days ago. > > > > > BUG=webrtc:7924 > > > > > NOTRY=true > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2975963002 > > > > > Cr-Commit-Position: refs/heads/master@{#18979} > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/1095ada7ad56fe29b7b2bbc560a8f6475a7978ce > > > > > > > > R=magjed@webrtc.org > > > > TBR=tkchin@webrtc.org > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > NOPRESUBMIT=true > > > > NOTREECHECKS=true > > > > NOTRY=true > > > > BUG=webrtc:7924 > > > > > > > > Review-Url: https://codereview.webrtc.org/2981583002 . > > > > Cr-Commit-Position: refs/heads/master@{#19002} > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/a5f1de1e6541de03f944bcbf49be87c01f57a18b > > > > > > TBR=magjed@webrtc.org,tkchin@webrtc.org,jtteh@webrtc.org,andersc@webrtc.org > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > NOPRESUBMIT=true > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG=webrtc:7924 > > > > > > Review-Url: https://codereview.webrtc.org/2979973002 > > > Cr-Commit-Position: refs/heads/master@{#19004} > > > Committed: https://chromium.googlesource.com/external/webrtc/+/81d40ee1491d5229c2677cc04b1f40d67c2babef > > > > TBR=magjed@webrtc.org,tkchin@webrtc.org,jtteh@webrtc.org,sprang@webrtc.org > > BUG=webrtc:7924 > > > > Review-Url: https://codereview.webrtc.org/2979983002 > > Cr-Commit-Position: refs/heads/master@{#19005} > > Committed: https://chromium.googlesource.com/external/webrtc/+/732a3437da4db7b452758b8e1cf26fce0ce3bf65 > > TBR=magjed@webrtc.org,tkchin@webrtc.org,sprang@webrtc.org,haysc@webrtc.org,andersc@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:7924 > > Review-Url: https://codereview.webrtc.org/2980173002 > Cr-Commit-Position: refs/heads/master@{#19036} > Committed: https://chromium.googlesource.com/external/webrtc/+/860f7298166084d966749e22b69aa2fdcf4d4ed6 TBR=magjed@webrtc.org,tkchin@webrtc.org,sprang@webrtc.org,haysc@webrtc.org,andersc@webrtc.org,jtteh@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:7924 Review-Url: https://codereview.webrtc.org/2977213002 Cr-Commit-Position: refs/heads/master@{#19135}
2017-07-25 07:55:58 -07:00
"../api/video_codecs:video_codecs_api",
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
"../common_video",
Stop using public_deps in media/. Bug: webrtc:8603 Change-Id: I7a6dad323ac298dc784feb5aa1fdc2ae5876cb5c No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/33180 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21591}
2018-01-11 17:07:30 +01:00
"../media:rtc_audio_video",
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
"../media:rtc_media",
"../media:rtc_media_base",
"../modules:module_api",
Add untracked headers to video_coding. This creates a new target for pure defines and interfaces. I think that makes sense (though include/ makes it harder to see when .cc and .h files should live together). Bug: webrtc:7620 Change-Id: Ifb0f50faf99166202836c0446feed3443eb52c6e Reviewed-on: https://webrtc-review.googlesource.com/34657 Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21516}
2018-01-08 11:05:10 +01:00
"../modules/video_coding:video_codec_interface",
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
"../modules/video_coding:video_coding_utility",
Fix circular dependencies between optional, array_view, and rtc_base. This splits things out of rtc_base and makes dependencies explicit. Bug: webrtc:6828 Change-Id: Id521896c3c43595349021c857bec216e429a0c8d Reviewed-on: https://webrtc-review.googlesource.com/32780 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21264}
2017-12-13 16:05:42 +01:00
"../rtc_base:checks",
Remove remains of webrtc/base All downstream code have been updated to the new location. In PRESUBMIT.py: * Remove webrtc/rtc_base from CPP_BLACKLIST * Add webrtc/rtc_base to LEGACY_API_DIRS Fix some duplicated paths in webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn BUG=webrtc:7634 TBR=kwiberg@webrtc.org Review-Url: https://codereview.webrtc.org/2976293002 Cr-Commit-Position: refs/heads/master@{#19094}
2017-07-19 10:40:47 -07:00
"../rtc_base:rtc_base_approved",
Removing $rtc_libyuv_dir and removing useless dependencies on libyuv. This CL removes the following GN variables: rtc_build_libyuv, rtc_libyuv_dir (as requested in webrtc:7906). It also removes some unneeded dependencies on //third_party/libyuv. WebRTC targets were using public_deps to depend on //third_party/libyuv and this created a build graph where targets that were depending on //third_party/libyuv were not declaring the dependency to GN because they were somehow getting it from another target that was exposing //third_party/libyuv header files even if it wasn't directly depending on it. Bug: webrtc:8605, webrtc:7906 Change-Id: If71f7988fd80421dc2ad887cf94c2ac66366c3fb Reviewed-on: https://webrtc-review.googlesource.com/32201 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21275}
2017-12-14 11:24:00 +01:00
"//third_party/libyuv",
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
]
libs = [
"CoreFoundation.framework",
"CoreMedia.framework",
"CoreVideo.framework",
"VideoToolbox.framework",
]
Reland of Add a webrtc{en,de}coderfactory implementation for VideoToolbox (patchset #1 id:1 of https://codereview.webrtc.org/2483273002/ ) Reason for revert: Fix gyp build Original issue's description: > Revert of Add a webrtc{en,de}coderfactory implementation for VideoToolbox (patchset #2 id:20001 of https://codereview.webrtc.org/2463313002/ ) > > Reason for revert: > Broke dependent project because the .gn changes weren't accompanied by corresponding .gyp changes. > > Original issue's description: > > Add a webrtc{en,de}coderfactory implementation for VideoToolbox > > > > This CL removes the coupling of the VideoToolbox h264 implementation > > to the generic h264 code. The files have been moved into sdb/obj/Framework > > and all dependency on them has been removed from the rest of WebRTC. > > We now add it as an external encoder via a factory supplied to the > > CreatePeerConnectionFactory call. This also brings the iOS implementation > > closer to what we do on Android for MediaCodec. > > > > BUG=webrtc:6619 > > > > Committed: https://crrev.com/6a5047dad31f14f53dd9f8bc1ecde19e1dede2e4 > > Cr-Commit-Position: refs/heads/master@{#14953} > > TBR=magjed@webrtc.org,stefan@webrtc.org,kthelgason@webrtc.org > BUG=webrtc:6619 > > Committed: https://crrev.com/d69ad84420d9c0e1c11450c352f6c92e7c9583f1 > Cr-Commit-Position: refs/heads/master@{#14985} R=magjed@webrtc.org TBR=kwiberg@webrtc.org, magjed@webrtc.org, stefan@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6619 Review URL: https://codereview.webrtc.org/2487723004 . Cr-Commit-Position: refs/heads/master@{#14992}
2016-11-09 10:43:26 +01:00
}
GN: Build iOS framework in build_ios_libs.sh BUG=webrtc:6372 NOTRY=True R=kjellander@webrtc.org Review URL: https://codereview.webrtc.org/2408983002 . Cr-Commit-Position: refs/heads/master@{#14603}
2016-10-11 13:27:26 -07:00
}
Build dynamic iOS SDK. - Places most ObjC code into webrtc/sdk/objc instead. - New gyp targets to build, strip and export symbols for dylib. - Removes old script used to generate dylib. BUG= Review URL: https://codereview.webrtc.org/1903663002 Cr-Commit-Position: refs/heads/master@{#12524}
2016-04-27 01:54:20 -07:00
}
Reference in New Issue Copy Permalink