webrtc_m130/test/BUILD.gn

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

1069 lines
27 KiB
Plaintext
Raw Normal View History

# Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
#
# Use of this source code is governed by a BSD-style license
# that can be found in the LICENSE file in the root of the source
# tree. An additional intellectual property rights grant can be found
# in the file PATENTS. All contributing project authors may
# be found in the AUTHORS file in the root of the source tree.
import("//build/config/ui.gni")
import("../webrtc.gni")
if (is_android) {
import("//build/config/android/rules.gni")
}
group("test") {
testonly = true
deps = [
":copy_to_file_audio_capturer",
":rtp_test_utils",
":test_common",
":test_renderer",
":test_support",
":video_test_common",
]
Reland of Enable GN check for webrtc/base (patchset #3 id:230001 of https://codereview.webrtc.org/2838683002/ ) Reason for revert: Fourth attempt to land. Waiting for https://codereview.webrtc.org/2845013003 to avoid conflicts on webrtc/modules/audio_coding:neteq_unittest_tools. Original issue's description: > Revert of Enable GN check for webrtc/base (patchset #13 id:240001 of https://codereview.webrtc.org/2717083002/ ) > > Reason for revert: > Breaks Chromium because in Chromium we import WebRTC with rtc_include_tests=false (https://bugs.chromium.org/p/chromium/issues/detail?id=713179#c6). > > Chromium uses webrtc/test/fuzzers and this CL adds test dependencies to neteq_rtc_fuzzer. > > Original issue's description: > > Enable GN check for webrtc/base > > > > It's not possible to enable it for the rtc_base_approved > > target but since a larger refactoring is ongoing for webrtc/base > > this CL doesn't attempt to fix that. > > > > Changes made: > > * Move webrtc/system_wrappers/include/stringize_macros.h into > > webrtc/base:rtc_base_approved_unittests (and corresponding > > unit test to rtc_base_approved_unittests). > > * Move md5digest.* from rtc_base_approved to rtc_base_test_utils target. > > * Move webrtc/system_wrappers/include/stringize_macros.h (+test) into > > webrtc/base. > > * Remove unused use include of webrtc/base/fileutils.h in > > webrtc/base/pathutils.cc > > > > BUG=webrtc:6828, webrtc:3806, webrtc:7480 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/2717083002 > > Cr-Commit-Position: refs/heads/master@{#17766} > > Committed: https://chromium.googlesource.com/external/webrtc/+/ed754e71ae8866db641677073274e86fe704eeac > > TBR=perkj@webrtc.org,tommi@webrtc.org,nisse@webrtc.org,kjellander@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:6828, webrtc:3806, webrtc:7480 > NOTRY=True > > Review-Url: https://codereview.webrtc.org/2838683002 > Cr-Commit-Position: refs/heads/master@{#17849} > Committed: https://chromium.googlesource.com/external/webrtc/+/11ed366c487a938815cd52ad2ab5467b0f90e1ae TBR=perkj@webrtc.org,tommi@webrtc.org,nisse@webrtc.org,kjellander@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6828, webrtc:3806, webrtc:7480 Review-Url: https://codereview.webrtc.org/2852663002 Cr-Commit-Position: refs/heads/master@{#17927}
2017-04-28 05:24:50 -07:00
if (rtc_include_tests) {
Reland of Enable GN check for webrtc/base (patchset #3 id:230001 of https://codereview.webrtc.org/2838683002/ ) Reason for revert: Fourth attempt to land. Waiting for https://codereview.webrtc.org/2845013003 to avoid conflicts on webrtc/modules/audio_coding:neteq_unittest_tools. Original issue's description: > Revert of Enable GN check for webrtc/base (patchset #13 id:240001 of https://codereview.webrtc.org/2717083002/ ) > > Reason for revert: > Breaks Chromium because in Chromium we import WebRTC with rtc_include_tests=false (https://bugs.chromium.org/p/chromium/issues/detail?id=713179#c6). > > Chromium uses webrtc/test/fuzzers and this CL adds test dependencies to neteq_rtc_fuzzer. > > Original issue's description: > > Enable GN check for webrtc/base > > > > It's not possible to enable it for the rtc_base_approved > > target but since a larger refactoring is ongoing for webrtc/base > > this CL doesn't attempt to fix that. > > > > Changes made: > > * Move webrtc/system_wrappers/include/stringize_macros.h into > > webrtc/base:rtc_base_approved_unittests (and corresponding > > unit test to rtc_base_approved_unittests). > > * Move md5digest.* from rtc_base_approved to rtc_base_test_utils target. > > * Move webrtc/system_wrappers/include/stringize_macros.h (+test) into > > webrtc/base. > > * Remove unused use include of webrtc/base/fileutils.h in > > webrtc/base/pathutils.cc > > > > BUG=webrtc:6828, webrtc:3806, webrtc:7480 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/2717083002 > > Cr-Commit-Position: refs/heads/master@{#17766} > > Committed: https://chromium.googlesource.com/external/webrtc/+/ed754e71ae8866db641677073274e86fe704eeac > > TBR=perkj@webrtc.org,tommi@webrtc.org,nisse@webrtc.org,kjellander@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:6828, webrtc:3806, webrtc:7480 > NOTRY=True > > Review-Url: https://codereview.webrtc.org/2838683002 > Cr-Commit-Position: refs/heads/master@{#17849} > Committed: https://chromium.googlesource.com/external/webrtc/+/11ed366c487a938815cd52ad2ab5467b0f90e1ae TBR=perkj@webrtc.org,tommi@webrtc.org,nisse@webrtc.org,kjellander@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6828, webrtc:3806, webrtc:7480 Review-Url: https://codereview.webrtc.org/2852663002 Cr-Commit-Position: refs/heads/master@{#17927}
2017-04-28 05:24:50 -07:00
deps += [
":test_main",
":test_support_unittests",
"pc/e2e",
Reland of Enable GN check for webrtc/base (patchset #3 id:230001 of https://codereview.webrtc.org/2838683002/ ) Reason for revert: Fourth attempt to land. Waiting for https://codereview.webrtc.org/2845013003 to avoid conflicts on webrtc/modules/audio_coding:neteq_unittest_tools. Original issue's description: > Revert of Enable GN check for webrtc/base (patchset #13 id:240001 of https://codereview.webrtc.org/2717083002/ ) > > Reason for revert: > Breaks Chromium because in Chromium we import WebRTC with rtc_include_tests=false (https://bugs.chromium.org/p/chromium/issues/detail?id=713179#c6). > > Chromium uses webrtc/test/fuzzers and this CL adds test dependencies to neteq_rtc_fuzzer. > > Original issue's description: > > Enable GN check for webrtc/base > > > > It's not possible to enable it for the rtc_base_approved > > target but since a larger refactoring is ongoing for webrtc/base > > this CL doesn't attempt to fix that. > > > > Changes made: > > * Move webrtc/system_wrappers/include/stringize_macros.h into > > webrtc/base:rtc_base_approved_unittests (and corresponding > > unit test to rtc_base_approved_unittests). > > * Move md5digest.* from rtc_base_approved to rtc_base_test_utils target. > > * Move webrtc/system_wrappers/include/stringize_macros.h (+test) into > > webrtc/base. > > * Remove unused use include of webrtc/base/fileutils.h in > > webrtc/base/pathutils.cc > > > > BUG=webrtc:6828, webrtc:3806, webrtc:7480 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/2717083002 > > Cr-Commit-Position: refs/heads/master@{#17766} > > Committed: https://chromium.googlesource.com/external/webrtc/+/ed754e71ae8866db641677073274e86fe704eeac > > TBR=perkj@webrtc.org,tommi@webrtc.org,nisse@webrtc.org,kjellander@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:6828, webrtc:3806, webrtc:7480 > NOTRY=True > > Review-Url: https://codereview.webrtc.org/2838683002 > Cr-Commit-Position: refs/heads/master@{#17849} > Committed: https://chromium.googlesource.com/external/webrtc/+/11ed366c487a938815cd52ad2ab5467b0f90e1ae TBR=perkj@webrtc.org,tommi@webrtc.org,nisse@webrtc.org,kjellander@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6828, webrtc:3806, webrtc:7480 Review-Url: https://codereview.webrtc.org/2852663002 Cr-Commit-Position: refs/heads/master@{#17927}
2017-04-28 05:24:50 -07:00
]
}
}
rtc_library("frame_generator_impl") {
visibility = [
"../api:create_frame_generator",
":*",
]
testonly = true
sources = [
"frame_generator.cc",
"frame_generator.h",
"testsupport/ivf_video_frame_generator.cc",
"testsupport/ivf_video_frame_generator.h",
]
deps = [
":frame_utils",
"../api:frame_generator_api",
"../api:scoped_refptr",
"../api/video:encoded_image",
"../api/video:video_frame",
"../api/video:video_frame_i010",
"../api/video:video_frame_i420",
"../api/video:video_rtp_headers",
"../api/video_codecs:video_codecs_api",
"../common_video",
"../media:rtc_media_base",
"../modules/video_coding:video_codec_interface",
"../modules/video_coding:video_coding_utility",
"../modules/video_coding:webrtc_h264",
"../modules/video_coding:webrtc_vp8",
"../modules/video_coding:webrtc_vp9",
"../rtc_base",
"../rtc_base:checks",
"../rtc_base:criticalsection",
"../rtc_base:rtc_base_approved",
"../rtc_base:rtc_event",
"../rtc_base/synchronization:sequence_checker",
"../rtc_base/system:file_wrapper",
"../system_wrappers",
]
absl_deps = [ "//third_party/abseil-cpp/absl/types:optional" ]
}
rtc_library("frame_utils") {
visibility = [ "*" ]
testonly = true
sources = [
"frame_utils.cc",
"frame_utils.h",
]
deps = [
"../api:scoped_refptr",
"../api/video:video_frame",
"../api/video:video_frame_i420",
]
}
rtc_library("video_test_common") {
Revert "Revert "GN rtc_* templates: Set default visibility to webrtc_root + "/*""" This reverts commit c73e1f437889d882cbf2987f7fb3a029a6150613. Reason for revert: The problem with failed deps in chrome content/renderer had already been fixed in https://webrtc-review.googlesource.com/c/src/+/38660 Original change's description: > Revert "GN rtc_* templates: Set default visibility to webrtc_root + "/*"" > > This reverts commit 588c548657b3ddf76e7b3f241263eef7f5799f16. > > Reason for revert: > > Breaks Chrome FYI: > > /b/c/b/Linux_Builder/src/buildtools/linux64/gn gen //out/Release --check > -> returned 1 > ERROR at //build/split_static_library.gni:12:5: Dependency not allowed. > static_library(target_name) { > ^---------------------------- > The item //content/renderer:renderer > can not depend on //third_party/webrtc/media:rtc_internal_video_codecs > because it is not in //third_party/webrtc/media:rtc_internal_video_codecs's visibility list: [ > //third_party/webrtc/* > //third_party/webrtc_overrides/* > ] > > https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.webrtc.fyi%2FLinux_Builder%2F23560%2F%2B%2Frecipes%2Fsteps%2Fgenerate_build_files%2F0%2Fstdout > > Original change's description: > > GN rtc_* templates: Set default visibility to webrtc_root + "/*" > > > > This means that by default, targets are visible to everything under > > the WebRTC root, but not visible to anything else. > > > > API targets are manually tagged with visibility "*", so that targets > > outside the WebRTC tree can see them. > > > > BUG=webrtc:8254 > > > > Change-Id: Icdbee6e0d22d93240ff2fb530c8f9dc48e351509 > > Reviewed-on: https://webrtc-review.googlesource.com/24140 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#21548} > > TBR=mbonadei@webrtc.org,kwiberg@webrtc.org > > Change-Id: I06620ce3d6f67482935c22efa231dd6cab91625a > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:8254 > Reviewed-on: https://webrtc-review.googlesource.com/38760 > Reviewed-by: Per Kjellander <perkj@webrtc.org> > Commit-Queue: Per Kjellander <perkj@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#21555} TBR=mbonadei@webrtc.org,kwiberg@webrtc.org,perkj@webrtc.org Change-Id: I6f720078ce21bd172e0a6471bae8c4c011e4a657 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:8254 Reviewed-on: https://webrtc-review.googlesource.com/38860 Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Per Kjellander <perkj@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21558}
2018-01-10 15:54:53 +00:00
visibility = [ "*" ]
testonly = true
sources = [
"fake_texture_frame.cc",
"fake_texture_frame.h",
"frame_forwarder.cc",
"frame_forwarder.h",
"frame_generator_capturer.cc",
"frame_generator_capturer.h",
"test_video_capturer.cc",
"test_video_capturer.h",
"video_codec_settings.h",
]
deps = [
":fileutils",
":frame_utils",
"../api:create_frame_generator",
"../api:frame_generator_api",
"../api:scoped_refptr",
"../api/task_queue",
"../api/video:video_frame",
"../api/video:video_frame_i010",
"../api/video:video_frame_i420",
"../api/video:video_rtp_headers",
"../api/video_codecs:video_codecs_api",
"../common_video",
Reland of Add framerate to VideoSinkWants and ability to signal on overuse (patchset #1 id:1 of https://codereview.webrtc.org/2783183003/ ) Reason for revert: Seem to be a flaky test rather than an issue with this cl. Creating reland, will add code to reduce flakiness to that test. Original issue's description: > Revert of Add framerate to VideoSinkWants and ability to signal on overuse (patchset #8 id:410001 of https://codereview.webrtc.org/2781433002/ ) > > Reason for revert: > This has resulted in failure of CallPerfTest.ReceivesCpuOveruseAndUnderuse test on the Win7 build bot https://build.chromium.org/p/client.webrtc.perf/builders/Win7/builds/1780 > > Original issue's description: > > Reland of Add framerate to VideoSinkWants and ability to signal on overuse (patchset #1 id:1 of https://codereview.webrtc.org/2764133002/ ) > > > > Reason for revert: > > Found issue with test case, will add fix to reland cl. > > > > Original issue's description: > > > Revert of Add framerate to VideoSinkWants and ability to signal on overuse (patchset #14 id:250001 of https://codereview.webrtc.org/2716643002/ ) > > > > > > Reason for revert: > > > Breaks perf tests: > > > https://build.chromium.org/p/client.webrtc.perf/builders/Win7/builds/1679 > > > https://build.chromium.org/p/client.webrtc.perf/builders/Android32%20Tests%20%28L%20Nexus5%29/builds/2325 > > > > > > Original issue's description: > > > > Add framerate to VideoSinkWants and ability to signal on overuse > > > > > > > > In ViEEncoder, try to reduce framerate instead of resolution if the > > > > current degradation preference is maintain-resolution rather than > > > > balanced. > > > > > > > > BUG=webrtc:4172 > > > > > > > > Review-Url: https://codereview.webrtc.org/2716643002 > > > > Cr-Commit-Position: refs/heads/master@{#17327} > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/72acf2526177bb4dbb5103cd6e165eb4361a5ae6 > > > > > > TBR=nisse@webrtc.org,magjed@webrtc.org,kthelgason@webrtc.org,ilnik@webrtc.org,stefan@webrtc.org,sprang@webrtc.org > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > NOPRESUBMIT=true > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG=webrtc:4172 > > > > > > Review-Url: https://codereview.webrtc.org/2764133002 > > > Cr-Commit-Position: refs/heads/master@{#17331} > > > Committed: https://chromium.googlesource.com/external/webrtc/+/8b45b11144c968b4173215c76f78c710c9a2ed0b > > > > TBR=nisse@webrtc.org,magjed@webrtc.org,kthelgason@webrtc.org,ilnik@webrtc.org,stefan@webrtc.org,skvlad@webrtc.org > > # Not skipping CQ checks because original CL landed more than 1 days ago. > > BUG=webrtc:4172 > > > > Review-Url: https://codereview.webrtc.org/2781433002 > > Cr-Commit-Position: refs/heads/master@{#17474} > > Committed: https://chromium.googlesource.com/external/webrtc/+/3ea3c77e93121b1ab9d5e46641e6764f2cca0d51 > > TBR=ilnik@webrtc.org,stefan@webrtc.org,asapersson@webrtc.org,sprang@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:4172 > > Review-Url: https://codereview.webrtc.org/2783183003 > Cr-Commit-Position: refs/heads/master@{#17477} > Committed: https://chromium.googlesource.com/external/webrtc/+/f9ed235c9b7248694edcb46feb1f29ce7456ab59 R=ilnik@webrtc.org,stefan@webrtc.org BUG=webrtc:4172 Review-Url: https://codereview.webrtc.org/2789823002 Cr-Commit-Position: refs/heads/master@{#17498}
2017-04-02 23:53:04 -07:00
"../media:rtc_media_base",
"../rtc_base",
"../rtc_base:checks",
"../rtc_base:criticalsection",
"../rtc_base:logging",
"../rtc_base:refcount",
"../rtc_base:rtc_base_approved",
"../rtc_base:rtc_task_queue",
"../rtc_base:timeutils",
"../rtc_base/task_utils:repeating_task",
Reland of Enabling `gn check` on webrtc/test (patchset #1 id:1 of https://codereview.webrtc.org/2920763002/ ) Reason for revert: Fixing and re-landing. Original issue's description: > Revert of Enabling `gn check` on webrtc/test (patchset #9 id:160001 of https://codereview.webrtc.org/2911203002/ ) > > Reason for revert: > ERROR at //webrtc/test/testsupport/fileutils_unittest.cc:20:11: Can't include this header from here. > #include "webrtc/base/checks.h" > ^------------------- > The target: > //webrtc/test:fileutils_unittests > is including a file from the target: > //webrtc/base:rtc_base_approved > > It's usually best to depend directly on the destination target. > In some cases, the destination target is considered a subcomponent > of an intermediate target. In this case, the intermediate target > should depend publicly on the destination to forward the ability > to include headers. > > Dependency chain (there may also be others): > //webrtc/test:fileutils_unittests --> > //webrtc/test:fileutils --[private]--> > //webrtc/base:rtc_base_approved > > > Original issue's description: > > Enabling `gn check` on webrtc/test > > > > BUG=webrtc:6828 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/2911203002 > > Cr-Commit-Position: refs/heads/master@{#18372} > > Committed: https://chromium.googlesource.com/external/webrtc/+/db5bb404b0f42a7c0a43f882b34ba1325d8cbae2 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6828 > > Review-Url: https://codereview.webrtc.org/2920763002 > Cr-Commit-Position: refs/heads/master@{#18375} > Committed: https://chromium.googlesource.com/external/webrtc/+/1a6f143d077aec85d919c516b4f74ada8b8c21a8 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6828 Review-Url: https://codereview.webrtc.org/2918793002 Cr-Commit-Position: refs/heads/master@{#18376}
2017-06-01 04:47:20 -07:00
"../system_wrappers",
]
absl_deps = [ "//third_party/abseil-cpp/absl/strings" ]
}
if (!build_with_chromium) {
if (is_mac || is_ios) {
rtc_library("video_test_mac") {
testonly = true
sources = [
"mac_capturer.h",
"mac_capturer.mm",
]
deps = [
":video_test_common",
"../api:libjingle_peerconnection_api",
"../api:media_stream_interface",
"../api:scoped_refptr",
"../modules/video_capture:video_capture_module",
"../rtc_base",
"../sdk:base_objc",
"../sdk:native_api",
"../sdk:native_video",
"../sdk:videocapture_objc",
]
}
}
rtc_library("platform_video_capturer") {
testonly = true
sources = [
"platform_video_capturer.cc",
"platform_video_capturer.h",
]
deps = [ ":video_test_common" ]
absl_deps = [ "//third_party/abseil-cpp/absl/memory" ]
if (is_mac || is_ios) {
deps += [ ":video_test_mac" ]
} else {
sources += [
"vcm_capturer.cc",
"vcm_capturer.h",
]
deps += [
"../api:scoped_refptr",
"../modules/video_capture:video_capture_module",
"../rtc_base:checks",
"../rtc_base:logging",
]
}
}
}
rtc_library("rtp_test_utils") {
testonly = true
sources = [
"rtcp_packet_parser.cc",
"rtcp_packet_parser.h",
"rtp_file_reader.cc",
"rtp_file_reader.h",
"rtp_file_writer.cc",
"rtp_file_writer.h",
"rtp_header_parser.cc",
"rtp_header_parser.h",
]
deps = [
"../api:array_view",
"../api:rtp_parameters",
"../modules/rtp_rtcp",
"../modules/rtp_rtcp:rtp_rtcp_format",
"../rtc_base:checks",
"../rtc_base:criticalsection",
"../rtc_base:logging",
"../rtc_base:macromagic",
"../rtc_base/system:arch",
]
}
rtc_library("field_trial") {
Revert "Revert "GN rtc_* templates: Set default visibility to webrtc_root + "/*""" This reverts commit c73e1f437889d882cbf2987f7fb3a029a6150613. Reason for revert: The problem with failed deps in chrome content/renderer had already been fixed in https://webrtc-review.googlesource.com/c/src/+/38660 Original change's description: > Revert "GN rtc_* templates: Set default visibility to webrtc_root + "/*"" > > This reverts commit 588c548657b3ddf76e7b3f241263eef7f5799f16. > > Reason for revert: > > Breaks Chrome FYI: > > /b/c/b/Linux_Builder/src/buildtools/linux64/gn gen //out/Release --check > -> returned 1 > ERROR at //build/split_static_library.gni:12:5: Dependency not allowed. > static_library(target_name) { > ^---------------------------- > The item //content/renderer:renderer > can not depend on //third_party/webrtc/media:rtc_internal_video_codecs > because it is not in //third_party/webrtc/media:rtc_internal_video_codecs's visibility list: [ > //third_party/webrtc/* > //third_party/webrtc_overrides/* > ] > > https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.webrtc.fyi%2FLinux_Builder%2F23560%2F%2B%2Frecipes%2Fsteps%2Fgenerate_build_files%2F0%2Fstdout > > Original change's description: > > GN rtc_* templates: Set default visibility to webrtc_root + "/*" > > > > This means that by default, targets are visible to everything under > > the WebRTC root, but not visible to anything else. > > > > API targets are manually tagged with visibility "*", so that targets > > outside the WebRTC tree can see them. > > > > BUG=webrtc:8254 > > > > Change-Id: Icdbee6e0d22d93240ff2fb530c8f9dc48e351509 > > Reviewed-on: https://webrtc-review.googlesource.com/24140 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#21548} > > TBR=mbonadei@webrtc.org,kwiberg@webrtc.org > > Change-Id: I06620ce3d6f67482935c22efa231dd6cab91625a > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:8254 > Reviewed-on: https://webrtc-review.googlesource.com/38760 > Reviewed-by: Per Kjellander <perkj@webrtc.org> > Commit-Queue: Per Kjellander <perkj@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#21555} TBR=mbonadei@webrtc.org,kwiberg@webrtc.org,perkj@webrtc.org Change-Id: I6f720078ce21bd172e0a6471bae8c4c011e4a657 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:8254 Reviewed-on: https://webrtc-review.googlesource.com/38860 Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Per Kjellander <perkj@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21558}
2018-01-10 15:54:53 +00:00
visibility = [ "*" ]
testonly = true
sources = [
"field_trial.cc",
"field_trial.h",
]
deps = [ "../system_wrappers:field_trial" ]
}
rtc_library("explicit_key_value_config") {
sources = [
"explicit_key_value_config.cc",
"explicit_key_value_config.h",
]
deps = [
"../api/transport:webrtc_key_value_config",
"../rtc_base:checks",
"../system_wrappers:field_trial",
]
absl_deps = [ "//third_party/abseil-cpp/absl/strings:strings" ]
}
rtc_library("perf_test") {
Revert "Revert "GN rtc_* templates: Set default visibility to webrtc_root + "/*""" This reverts commit c73e1f437889d882cbf2987f7fb3a029a6150613. Reason for revert: The problem with failed deps in chrome content/renderer had already been fixed in https://webrtc-review.googlesource.com/c/src/+/38660 Original change's description: > Revert "GN rtc_* templates: Set default visibility to webrtc_root + "/*"" > > This reverts commit 588c548657b3ddf76e7b3f241263eef7f5799f16. > > Reason for revert: > > Breaks Chrome FYI: > > /b/c/b/Linux_Builder/src/buildtools/linux64/gn gen //out/Release --check > -> returned 1 > ERROR at //build/split_static_library.gni:12:5: Dependency not allowed. > static_library(target_name) { > ^---------------------------- > The item //content/renderer:renderer > can not depend on //third_party/webrtc/media:rtc_internal_video_codecs > because it is not in //third_party/webrtc/media:rtc_internal_video_codecs's visibility list: [ > //third_party/webrtc/* > //third_party/webrtc_overrides/* > ] > > https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.webrtc.fyi%2FLinux_Builder%2F23560%2F%2B%2Frecipes%2Fsteps%2Fgenerate_build_files%2F0%2Fstdout > > Original change's description: > > GN rtc_* templates: Set default visibility to webrtc_root + "/*" > > > > This means that by default, targets are visible to everything under > > the WebRTC root, but not visible to anything else. > > > > API targets are manually tagged with visibility "*", so that targets > > outside the WebRTC tree can see them. > > > > BUG=webrtc:8254 > > > > Change-Id: Icdbee6e0d22d93240ff2fb530c8f9dc48e351509 > > Reviewed-on: https://webrtc-review.googlesource.com/24140 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#21548} > > TBR=mbonadei@webrtc.org,kwiberg@webrtc.org > > Change-Id: I06620ce3d6f67482935c22efa231dd6cab91625a > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:8254 > Reviewed-on: https://webrtc-review.googlesource.com/38760 > Reviewed-by: Per Kjellander <perkj@webrtc.org> > Commit-Queue: Per Kjellander <perkj@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#21555} TBR=mbonadei@webrtc.org,kwiberg@webrtc.org,perkj@webrtc.org Change-Id: I6f720078ce21bd172e0a6471bae8c4c011e4a657 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:8254 Reviewed-on: https://webrtc-review.googlesource.com/38860 Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Per Kjellander <perkj@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21558}
2018-01-10 15:54:53 +00:00
visibility = [ "*" ]
testonly = true
sources = [
Add PerfResultsReporter. This is the WebRTC equivalent of testing/perf/perf_result_reporter.h in Chromium. That class was introduced because the PrintResult functions are quite hard to use right. It was easy to mix up metrics, modifiers and stories, for instance. I choose to introduce this new class because I need to create a new API for PrintResult anyway. For instance, the important bool isn't really supported by histograms. Also I would like to restrict units to an enum because you cannot make up your own units anymore. We could also have had a strictly checked string type, but that's bad API design. An enum is better because the compiler will check that the unit is valid rather than at runtime. Furthermore, down the line we can probably make each reporter write protos directly to /tmp and merge them later, instead of having a singleton which writes results at the end and keeps all test results in memory. This abstraction makes it easy to make a clean and simple implementation of just that. Steps: 1) land this 2) start rewriting perf tests to use this class 3) nuke PrintResult functions 4) don't convert units to string, convert directly from Unit to proto::Unit 5) write protos directly from this class (either through a singleton or directly) and nuke the perf results writer abstraction. Bug: chromium:1029452 Change-Id: Ia919c371a69309130c797fdf01ae5bd64345ab2e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168770 Reviewed-by: Artem Titov <titovartem@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30599}
2020-02-24 13:16:03 +01:00
"testsupport/perf_result_reporter.cc",
"testsupport/perf_result_reporter.h",
"testsupport/perf_test.cc",
"testsupport/perf_test.h",
"testsupport/perf_test_histogram_writer.h",
"testsupport/perf_test_result_writer.h",
]
deps = [
"../api:array_view",
"../rtc_base:checks",
"../rtc_base:criticalsection",
"../rtc_base:logging",
"../rtc_base:rtc_numerics",
]
absl_deps = [ "//third_party/abseil-cpp/absl/types:optional" ]
if (rtc_enable_protobuf) {
sources += [ "testsupport/perf_test_histogram_writer.cc" ]
deps += [
"//third_party/catapult/tracing/tracing:histogram",
"//third_party/catapult/tracing/tracing:reserved_infos",
]
} else {
sources += [ "testsupport/perf_test_histogram_writer_no_protobuf.cc" ]
}
}
if (is_ios) {
rtc_library("test_support_objc") {
testonly = true
visibility = [ ":test_support" ]
sources = [
"ios/coverage_util_ios.h",
"ios/coverage_util_ios.mm",
"ios/test_support.h",
"ios/test_support.mm",
]
deps = [
":perf_test",
"../sdk:helpers_objc",
]
absl_deps = [ "//third_party/abseil-cpp/absl/types:optional" ]
configs += [ ":test_support_objc_config" ]
}
config("test_support_objc_config") {
defines = []
if (use_clang_coverage) {
defines += [ "WEBRTC_IOS_ENABLE_COVERAGE" ]
}
}
}
config("suppress_warning_4373") {
if (is_win) {
cflags = [
# MSVC has a bug which generates this warning when using mocks; see the
# section on warning 4373 in he googlemock FAQ. This warning isn't the
# least relevant for us, anyway.
"/wd4373",
]
}
}
config("test_main_direct_config") {
visibility = [ ":*" ]
defines = [ "UNIT_TEST" ]
}
Reland of Enable GN check for webrtc/base (patchset #3 id:230001 of https://codereview.webrtc.org/2838683002/ ) Reason for revert: Fourth attempt to land. Waiting for https://codereview.webrtc.org/2845013003 to avoid conflicts on webrtc/modules/audio_coding:neteq_unittest_tools. Original issue's description: > Revert of Enable GN check for webrtc/base (patchset #13 id:240001 of https://codereview.webrtc.org/2717083002/ ) > > Reason for revert: > Breaks Chromium because in Chromium we import WebRTC with rtc_include_tests=false (https://bugs.chromium.org/p/chromium/issues/detail?id=713179#c6). > > Chromium uses webrtc/test/fuzzers and this CL adds test dependencies to neteq_rtc_fuzzer. > > Original issue's description: > > Enable GN check for webrtc/base > > > > It's not possible to enable it for the rtc_base_approved > > target but since a larger refactoring is ongoing for webrtc/base > > this CL doesn't attempt to fix that. > > > > Changes made: > > * Move webrtc/system_wrappers/include/stringize_macros.h into > > webrtc/base:rtc_base_approved_unittests (and corresponding > > unit test to rtc_base_approved_unittests). > > * Move md5digest.* from rtc_base_approved to rtc_base_test_utils target. > > * Move webrtc/system_wrappers/include/stringize_macros.h (+test) into > > webrtc/base. > > * Remove unused use include of webrtc/base/fileutils.h in > > webrtc/base/pathutils.cc > > > > BUG=webrtc:6828, webrtc:3806, webrtc:7480 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/2717083002 > > Cr-Commit-Position: refs/heads/master@{#17766} > > Committed: https://chromium.googlesource.com/external/webrtc/+/ed754e71ae8866db641677073274e86fe704eeac > > TBR=perkj@webrtc.org,tommi@webrtc.org,nisse@webrtc.org,kjellander@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:6828, webrtc:3806, webrtc:7480 > NOTRY=True > > Review-Url: https://codereview.webrtc.org/2838683002 > Cr-Commit-Position: refs/heads/master@{#17849} > Committed: https://chromium.googlesource.com/external/webrtc/+/11ed366c487a938815cd52ad2ab5467b0f90e1ae TBR=perkj@webrtc.org,tommi@webrtc.org,nisse@webrtc.org,kjellander@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6828, webrtc:3806, webrtc:7480 Review-Url: https://codereview.webrtc.org/2852663002 Cr-Commit-Position: refs/heads/master@{#17927}
2017-04-28 05:24:50 -07:00
rtc_source_set("test_support") {
Revert "Revert "GN rtc_* templates: Set default visibility to webrtc_root + "/*""" This reverts commit c73e1f437889d882cbf2987f7fb3a029a6150613. Reason for revert: The problem with failed deps in chrome content/renderer had already been fixed in https://webrtc-review.googlesource.com/c/src/+/38660 Original change's description: > Revert "GN rtc_* templates: Set default visibility to webrtc_root + "/*"" > > This reverts commit 588c548657b3ddf76e7b3f241263eef7f5799f16. > > Reason for revert: > > Breaks Chrome FYI: > > /b/c/b/Linux_Builder/src/buildtools/linux64/gn gen //out/Release --check > -> returned 1 > ERROR at //build/split_static_library.gni:12:5: Dependency not allowed. > static_library(target_name) { > ^---------------------------- > The item //content/renderer:renderer > can not depend on //third_party/webrtc/media:rtc_internal_video_codecs > because it is not in //third_party/webrtc/media:rtc_internal_video_codecs's visibility list: [ > //third_party/webrtc/* > //third_party/webrtc_overrides/* > ] > > https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.webrtc.fyi%2FLinux_Builder%2F23560%2F%2B%2Frecipes%2Fsteps%2Fgenerate_build_files%2F0%2Fstdout > > Original change's description: > > GN rtc_* templates: Set default visibility to webrtc_root + "/*" > > > > This means that by default, targets are visible to everything under > > the WebRTC root, but not visible to anything else. > > > > API targets are manually tagged with visibility "*", so that targets > > outside the WebRTC tree can see them. > > > > BUG=webrtc:8254 > > > > Change-Id: Icdbee6e0d22d93240ff2fb530c8f9dc48e351509 > > Reviewed-on: https://webrtc-review.googlesource.com/24140 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#21548} > > TBR=mbonadei@webrtc.org,kwiberg@webrtc.org > > Change-Id: I06620ce3d6f67482935c22efa231dd6cab91625a > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:8254 > Reviewed-on: https://webrtc-review.googlesource.com/38760 > Reviewed-by: Per Kjellander <perkj@webrtc.org> > Commit-Queue: Per Kjellander <perkj@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#21555} TBR=mbonadei@webrtc.org,kwiberg@webrtc.org,perkj@webrtc.org Change-Id: I6f720078ce21bd172e0a6471bae8c4c011e4a657 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:8254 Reviewed-on: https://webrtc-review.googlesource.com/38860 Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Per Kjellander <perkj@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21558}
2018-01-10 15:54:53 +00:00
visibility = [ "*" ]
Reland of Enable GN check for webrtc/base (patchset #3 id:230001 of https://codereview.webrtc.org/2838683002/ ) Reason for revert: Fourth attempt to land. Waiting for https://codereview.webrtc.org/2845013003 to avoid conflicts on webrtc/modules/audio_coding:neteq_unittest_tools. Original issue's description: > Revert of Enable GN check for webrtc/base (patchset #13 id:240001 of https://codereview.webrtc.org/2717083002/ ) > > Reason for revert: > Breaks Chromium because in Chromium we import WebRTC with rtc_include_tests=false (https://bugs.chromium.org/p/chromium/issues/detail?id=713179#c6). > > Chromium uses webrtc/test/fuzzers and this CL adds test dependencies to neteq_rtc_fuzzer. > > Original issue's description: > > Enable GN check for webrtc/base > > > > It's not possible to enable it for the rtc_base_approved > > target but since a larger refactoring is ongoing for webrtc/base > > this CL doesn't attempt to fix that. > > > > Changes made: > > * Move webrtc/system_wrappers/include/stringize_macros.h into > > webrtc/base:rtc_base_approved_unittests (and corresponding > > unit test to rtc_base_approved_unittests). > > * Move md5digest.* from rtc_base_approved to rtc_base_test_utils target. > > * Move webrtc/system_wrappers/include/stringize_macros.h (+test) into > > webrtc/base. > > * Remove unused use include of webrtc/base/fileutils.h in > > webrtc/base/pathutils.cc > > > > BUG=webrtc:6828, webrtc:3806, webrtc:7480 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/2717083002 > > Cr-Commit-Position: refs/heads/master@{#17766} > > Committed: https://chromium.googlesource.com/external/webrtc/+/ed754e71ae8866db641677073274e86fe704eeac > > TBR=perkj@webrtc.org,tommi@webrtc.org,nisse@webrtc.org,kjellander@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:6828, webrtc:3806, webrtc:7480 > NOTRY=True > > Review-Url: https://codereview.webrtc.org/2838683002 > Cr-Commit-Position: refs/heads/master@{#17849} > Committed: https://chromium.googlesource.com/external/webrtc/+/11ed366c487a938815cd52ad2ab5467b0f90e1ae TBR=perkj@webrtc.org,tommi@webrtc.org,nisse@webrtc.org,kjellander@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6828, webrtc:3806, webrtc:7480 Review-Url: https://codereview.webrtc.org/2852663002 Cr-Commit-Position: refs/heads/master@{#17927}
2017-04-28 05:24:50 -07:00
testonly = true
all_dependent_configs = [
":suppress_warning_4373",
"//third_party/googletest:gmock_config",
"//third_party/googletest:gtest_config",
]
Reland of Enable GN check for webrtc/base (patchset #3 id:230001 of https://codereview.webrtc.org/2838683002/ ) Reason for revert: Fourth attempt to land. Waiting for https://codereview.webrtc.org/2845013003 to avoid conflicts on webrtc/modules/audio_coding:neteq_unittest_tools. Original issue's description: > Revert of Enable GN check for webrtc/base (patchset #13 id:240001 of https://codereview.webrtc.org/2717083002/ ) > > Reason for revert: > Breaks Chromium because in Chromium we import WebRTC with rtc_include_tests=false (https://bugs.chromium.org/p/chromium/issues/detail?id=713179#c6). > > Chromium uses webrtc/test/fuzzers and this CL adds test dependencies to neteq_rtc_fuzzer. > > Original issue's description: > > Enable GN check for webrtc/base > > > > It's not possible to enable it for the rtc_base_approved > > target but since a larger refactoring is ongoing for webrtc/base > > this CL doesn't attempt to fix that. > > > > Changes made: > > * Move webrtc/system_wrappers/include/stringize_macros.h into > > webrtc/base:rtc_base_approved_unittests (and corresponding > > unit test to rtc_base_approved_unittests). > > * Move md5digest.* from rtc_base_approved to rtc_base_test_utils target. > > * Move webrtc/system_wrappers/include/stringize_macros.h (+test) into > > webrtc/base. > > * Remove unused use include of webrtc/base/fileutils.h in > > webrtc/base/pathutils.cc > > > > BUG=webrtc:6828, webrtc:3806, webrtc:7480 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/2717083002 > > Cr-Commit-Position: refs/heads/master@{#17766} > > Committed: https://chromium.googlesource.com/external/webrtc/+/ed754e71ae8866db641677073274e86fe704eeac > > TBR=perkj@webrtc.org,tommi@webrtc.org,nisse@webrtc.org,kjellander@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:6828, webrtc:3806, webrtc:7480 > NOTRY=True > > Review-Url: https://codereview.webrtc.org/2838683002 > Cr-Commit-Position: refs/heads/master@{#17849} > Committed: https://chromium.googlesource.com/external/webrtc/+/11ed366c487a938815cd52ad2ab5467b0f90e1ae TBR=perkj@webrtc.org,tommi@webrtc.org,nisse@webrtc.org,kjellander@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6828, webrtc:3806, webrtc:7480 Review-Url: https://codereview.webrtc.org/2852663002 Cr-Commit-Position: refs/heads/master@{#17927}
2017-04-28 05:24:50 -07:00
sources = [
"gmock.h",
"gtest.h",
]
public_deps = [] # no-presubmit-check TODO(webrtc:8603)
if (is_ios) {
public_deps += # no-presubmit-check TODO(webrtc:8603)
[ ":test_support_objc" ]
}
public_configs = [ ":test_main_direct_config" ]
Reland of Enable GN check for webrtc/base (patchset #3 id:230001 of https://codereview.webrtc.org/2838683002/ ) Reason for revert: Fourth attempt to land. Waiting for https://codereview.webrtc.org/2845013003 to avoid conflicts on webrtc/modules/audio_coding:neteq_unittest_tools. Original issue's description: > Revert of Enable GN check for webrtc/base (patchset #13 id:240001 of https://codereview.webrtc.org/2717083002/ ) > > Reason for revert: > Breaks Chromium because in Chromium we import WebRTC with rtc_include_tests=false (https://bugs.chromium.org/p/chromium/issues/detail?id=713179#c6). > > Chromium uses webrtc/test/fuzzers and this CL adds test dependencies to neteq_rtc_fuzzer. > > Original issue's description: > > Enable GN check for webrtc/base > > > > It's not possible to enable it for the rtc_base_approved > > target but since a larger refactoring is ongoing for webrtc/base > > this CL doesn't attempt to fix that. > > > > Changes made: > > * Move webrtc/system_wrappers/include/stringize_macros.h into > > webrtc/base:rtc_base_approved_unittests (and corresponding > > unit test to rtc_base_approved_unittests). > > * Move md5digest.* from rtc_base_approved to rtc_base_test_utils target. > > * Move webrtc/system_wrappers/include/stringize_macros.h (+test) into > > webrtc/base. > > * Remove unused use include of webrtc/base/fileutils.h in > > webrtc/base/pathutils.cc > > > > BUG=webrtc:6828, webrtc:3806, webrtc:7480 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/2717083002 > > Cr-Commit-Position: refs/heads/master@{#17766} > > Committed: https://chromium.googlesource.com/external/webrtc/+/ed754e71ae8866db641677073274e86fe704eeac > > TBR=perkj@webrtc.org,tommi@webrtc.org,nisse@webrtc.org,kjellander@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:6828, webrtc:3806, webrtc:7480 > NOTRY=True > > Review-Url: https://codereview.webrtc.org/2838683002 > Cr-Commit-Position: refs/heads/master@{#17849} > Committed: https://chromium.googlesource.com/external/webrtc/+/11ed366c487a938815cd52ad2ab5467b0f90e1ae TBR=perkj@webrtc.org,tommi@webrtc.org,nisse@webrtc.org,kjellander@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6828, webrtc:3806, webrtc:7480 Review-Url: https://codereview.webrtc.org/2852663002 Cr-Commit-Position: refs/heads/master@{#17927}
2017-04-28 05:24:50 -07:00
deps = [
"../rtc_base:ignore_wundef",
Reland of Enable GN check for webrtc/base (patchset #3 id:230001 of https://codereview.webrtc.org/2838683002/ ) Reason for revert: Fourth attempt to land. Waiting for https://codereview.webrtc.org/2845013003 to avoid conflicts on webrtc/modules/audio_coding:neteq_unittest_tools. Original issue's description: > Revert of Enable GN check for webrtc/base (patchset #13 id:240001 of https://codereview.webrtc.org/2717083002/ ) > > Reason for revert: > Breaks Chromium because in Chromium we import WebRTC with rtc_include_tests=false (https://bugs.chromium.org/p/chromium/issues/detail?id=713179#c6). > > Chromium uses webrtc/test/fuzzers and this CL adds test dependencies to neteq_rtc_fuzzer. > > Original issue's description: > > Enable GN check for webrtc/base > > > > It's not possible to enable it for the rtc_base_approved > > target but since a larger refactoring is ongoing for webrtc/base > > this CL doesn't attempt to fix that. > > > > Changes made: > > * Move webrtc/system_wrappers/include/stringize_macros.h into > > webrtc/base:rtc_base_approved_unittests (and corresponding > > unit test to rtc_base_approved_unittests). > > * Move md5digest.* from rtc_base_approved to rtc_base_test_utils target. > > * Move webrtc/system_wrappers/include/stringize_macros.h (+test) into > > webrtc/base. > > * Remove unused use include of webrtc/base/fileutils.h in > > webrtc/base/pathutils.cc > > > > BUG=webrtc:6828, webrtc:3806, webrtc:7480 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/2717083002 > > Cr-Commit-Position: refs/heads/master@{#17766} > > Committed: https://chromium.googlesource.com/external/webrtc/+/ed754e71ae8866db641677073274e86fe704eeac > > TBR=perkj@webrtc.org,tommi@webrtc.org,nisse@webrtc.org,kjellander@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:6828, webrtc:3806, webrtc:7480 > NOTRY=True > > Review-Url: https://codereview.webrtc.org/2838683002 > Cr-Commit-Position: refs/heads/master@{#17849} > Committed: https://chromium.googlesource.com/external/webrtc/+/11ed366c487a938815cd52ad2ab5467b0f90e1ae TBR=perkj@webrtc.org,tommi@webrtc.org,nisse@webrtc.org,kjellander@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6828, webrtc:3806, webrtc:7480 Review-Url: https://codereview.webrtc.org/2852663002 Cr-Commit-Position: refs/heads/master@{#17927}
2017-04-28 05:24:50 -07:00
"//testing/gmock",
"//testing/gtest",
]
}
rtc_library("video_test_support") {
testonly = true
sources = [
"testsupport/frame_reader.h",
"testsupport/frame_writer.h",
"testsupport/mock/mock_frame_reader.h",
"testsupport/video_frame_writer.cc",
"testsupport/video_frame_writer.h",
"testsupport/y4m_frame_reader.cc",
"testsupport/y4m_frame_writer.cc",
"testsupport/yuv_frame_reader.cc",
"testsupport/yuv_frame_writer.cc",
]
deps = [
":fileutils",
":frame_utils",
":test_support",
":video_test_common",
"../api:scoped_refptr",
"../api/video:encoded_image",
"../api/video:video_frame",
"../api/video:video_frame_i420",
"../api/video_codecs:video_codecs_api",
"../common_video",
"../media:rtc_media_base",
"../modules/video_coding:video_codec_interface",
"../modules/video_coding:video_coding_utility",
"../modules/video_coding:webrtc_h264",
"../modules/video_coding:webrtc_vp8",
"../modules/video_coding:webrtc_vp9",
"../rtc_base:checks",
"../rtc_base:criticalsection",
"../rtc_base:logging",
"../rtc_base:rtc_base_approved",
"../rtc_base:rtc_event",
"../rtc_base/synchronization:sequence_checker",
"../rtc_base/system:file_wrapper",
]
absl_deps = [ "//third_party/abseil-cpp/absl/types:optional" ]
if (!is_ios) {
deps += [ "//third_party:jpeg" ]
sources += [ "testsupport/jpeg_frame_writer.cc" ]
} else {
sources += [ "testsupport/jpeg_frame_writer_ios.cc" ]
}
if (is_android) {
deps += [ "//base" ]
}
}
if (rtc_include_tests) {
rtc_library("resources_dir_flag") {
testonly = true
visibility = [ "*" ]
sources = [
"testsupport/resources_dir_flag.cc",
"testsupport/resources_dir_flag.h",
]
absl_deps = [ "//third_party/abseil-cpp/absl/flags:flag" ]
}
rtc_library("test_main_lib") {
Revert "Revert "GN rtc_* templates: Set default visibility to webrtc_root + "/*""" This reverts commit c73e1f437889d882cbf2987f7fb3a029a6150613. Reason for revert: The problem with failed deps in chrome content/renderer had already been fixed in https://webrtc-review.googlesource.com/c/src/+/38660 Original change's description: > Revert "GN rtc_* templates: Set default visibility to webrtc_root + "/*"" > > This reverts commit 588c548657b3ddf76e7b3f241263eef7f5799f16. > > Reason for revert: > > Breaks Chrome FYI: > > /b/c/b/Linux_Builder/src/buildtools/linux64/gn gen //out/Release --check > -> returned 1 > ERROR at //build/split_static_library.gni:12:5: Dependency not allowed. > static_library(target_name) { > ^---------------------------- > The item //content/renderer:renderer > can not depend on //third_party/webrtc/media:rtc_internal_video_codecs > because it is not in //third_party/webrtc/media:rtc_internal_video_codecs's visibility list: [ > //third_party/webrtc/* > //third_party/webrtc_overrides/* > ] > > https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.webrtc.fyi%2FLinux_Builder%2F23560%2F%2B%2Frecipes%2Fsteps%2Fgenerate_build_files%2F0%2Fstdout > > Original change's description: > > GN rtc_* templates: Set default visibility to webrtc_root + "/*" > > > > This means that by default, targets are visible to everything under > > the WebRTC root, but not visible to anything else. > > > > API targets are manually tagged with visibility "*", so that targets > > outside the WebRTC tree can see them. > > > > BUG=webrtc:8254 > > > > Change-Id: Icdbee6e0d22d93240ff2fb530c8f9dc48e351509 > > Reviewed-on: https://webrtc-review.googlesource.com/24140 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#21548} > > TBR=mbonadei@webrtc.org,kwiberg@webrtc.org > > Change-Id: I06620ce3d6f67482935c22efa231dd6cab91625a > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:8254 > Reviewed-on: https://webrtc-review.googlesource.com/38760 > Reviewed-by: Per Kjellander <perkj@webrtc.org> > Commit-Queue: Per Kjellander <perkj@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#21555} TBR=mbonadei@webrtc.org,kwiberg@webrtc.org,perkj@webrtc.org Change-Id: I6f720078ce21bd172e0a6471bae8c4c011e4a657 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:8254 Reviewed-on: https://webrtc-review.googlesource.com/38860 Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Per Kjellander <perkj@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21558}
2018-01-10 15:54:53 +00:00
visibility = [ "*" ]
testonly = true
sources = [
"test_main_lib.cc",
"test_main_lib.h",
]
deps = [
":field_trial",
":perf_test",
":resources_dir_flag",
":test_support",
"../rtc_base",
"../rtc_base:checks",
"../rtc_base:logging",
"../rtc_base:rtc_base_approved",
"../system_wrappers:field_trial",
"../system_wrappers:metrics",
]
absl_deps = [
"//third_party/abseil-cpp/absl/flags:flag",
"//third_party/abseil-cpp/absl/flags:parse",
"//third_party/abseil-cpp/absl/memory",
"//third_party/abseil-cpp/absl/strings:strings",
"//third_party/abseil-cpp/absl/types:optional",
]
}
rtc_library("test_main") {
visibility = [ "*" ]
testonly = true
sources = [ "test_main.cc" ]
deps = [ ":test_main_lib" ]
absl_deps = [
"//third_party/abseil-cpp/absl/debugging:failure_signal_handler",
"//third_party/abseil-cpp/absl/debugging:symbolize",
]
}
rtc_library("benchmark_main") {
testonly = true
sources = [ "benchmark_main.cc" ]
deps = [ "//third_party/google_benchmark" ]
}
rtc_library("test_support_test_artifacts") {
testonly = true
sources = [
"testsupport/test_artifacts.cc",
"testsupport/test_artifacts.h",
]
deps = [
":fileutils",
"../rtc_base:logging",
"../rtc_base/system:file_wrapper",
]
absl_deps = [
"//third_party/abseil-cpp/absl/flags:flag",
"//third_party/abseil-cpp/absl/flags:parse",
]
Reland of Enable GN check for webrtc/base (patchset #3 id:230001 of https://codereview.webrtc.org/2838683002/ ) Reason for revert: Fourth attempt to land. Waiting for https://codereview.webrtc.org/2845013003 to avoid conflicts on webrtc/modules/audio_coding:neteq_unittest_tools. Original issue's description: > Revert of Enable GN check for webrtc/base (patchset #13 id:240001 of https://codereview.webrtc.org/2717083002/ ) > > Reason for revert: > Breaks Chromium because in Chromium we import WebRTC with rtc_include_tests=false (https://bugs.chromium.org/p/chromium/issues/detail?id=713179#c6). > > Chromium uses webrtc/test/fuzzers and this CL adds test dependencies to neteq_rtc_fuzzer. > > Original issue's description: > > Enable GN check for webrtc/base > > > > It's not possible to enable it for the rtc_base_approved > > target but since a larger refactoring is ongoing for webrtc/base > > this CL doesn't attempt to fix that. > > > > Changes made: > > * Move webrtc/system_wrappers/include/stringize_macros.h into > > webrtc/base:rtc_base_approved_unittests (and corresponding > > unit test to rtc_base_approved_unittests). > > * Move md5digest.* from rtc_base_approved to rtc_base_test_utils target. > > * Move webrtc/system_wrappers/include/stringize_macros.h (+test) into > > webrtc/base. > > * Remove unused use include of webrtc/base/fileutils.h in > > webrtc/base/pathutils.cc > > > > BUG=webrtc:6828, webrtc:3806, webrtc:7480 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/2717083002 > > Cr-Commit-Position: refs/heads/master@{#17766} > > Committed: https://chromium.googlesource.com/external/webrtc/+/ed754e71ae8866db641677073274e86fe704eeac > > TBR=perkj@webrtc.org,tommi@webrtc.org,nisse@webrtc.org,kjellander@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:6828, webrtc:3806, webrtc:7480 > NOTRY=True > > Review-Url: https://codereview.webrtc.org/2838683002 > Cr-Commit-Position: refs/heads/master@{#17849} > Committed: https://chromium.googlesource.com/external/webrtc/+/11ed366c487a938815cd52ad2ab5467b0f90e1ae TBR=perkj@webrtc.org,tommi@webrtc.org,nisse@webrtc.org,kjellander@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6828, webrtc:3806, webrtc:7480 Review-Url: https://codereview.webrtc.org/2852663002 Cr-Commit-Position: refs/heads/master@{#17927}
2017-04-28 05:24:50 -07:00
}
test_support_unittests_resources = [
"../resources/foreman_cif_short.yuv",
"../resources/video_coding/frame-ethernet-ii.pcap",
"../resources/video_coding/frame-loopback.pcap",
"../resources/video_coding/pltype103.rtp",
"../resources/video_coding/pltype103_header_only.rtp",
"../resources/video_coding/ssrcs-2.pcap",
"../resources/video_coding/ssrcs-3.pcap",
Reland of Enable GN check for webrtc/base (patchset #3 id:230001 of https://codereview.webrtc.org/2838683002/ ) Reason for revert: Fourth attempt to land. Waiting for https://codereview.webrtc.org/2845013003 to avoid conflicts on webrtc/modules/audio_coding:neteq_unittest_tools. Original issue's description: > Revert of Enable GN check for webrtc/base (patchset #13 id:240001 of https://codereview.webrtc.org/2717083002/ ) > > Reason for revert: > Breaks Chromium because in Chromium we import WebRTC with rtc_include_tests=false (https://bugs.chromium.org/p/chromium/issues/detail?id=713179#c6). > > Chromium uses webrtc/test/fuzzers and this CL adds test dependencies to neteq_rtc_fuzzer. > > Original issue's description: > > Enable GN check for webrtc/base > > > > It's not possible to enable it for the rtc_base_approved > > target but since a larger refactoring is ongoing for webrtc/base > > this CL doesn't attempt to fix that. > > > > Changes made: > > * Move webrtc/system_wrappers/include/stringize_macros.h into > > webrtc/base:rtc_base_approved_unittests (and corresponding > > unit test to rtc_base_approved_unittests). > > * Move md5digest.* from rtc_base_approved to rtc_base_test_utils target. > > * Move webrtc/system_wrappers/include/stringize_macros.h (+test) into > > webrtc/base. > > * Remove unused use include of webrtc/base/fileutils.h in > > webrtc/base/pathutils.cc > > > > BUG=webrtc:6828, webrtc:3806, webrtc:7480 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/2717083002 > > Cr-Commit-Position: refs/heads/master@{#17766} > > Committed: https://chromium.googlesource.com/external/webrtc/+/ed754e71ae8866db641677073274e86fe704eeac > > TBR=perkj@webrtc.org,tommi@webrtc.org,nisse@webrtc.org,kjellander@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:6828, webrtc:3806, webrtc:7480 > NOTRY=True > > Review-Url: https://codereview.webrtc.org/2838683002 > Cr-Commit-Position: refs/heads/master@{#17849} > Committed: https://chromium.googlesource.com/external/webrtc/+/11ed366c487a938815cd52ad2ab5467b0f90e1ae TBR=perkj@webrtc.org,tommi@webrtc.org,nisse@webrtc.org,kjellander@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6828, webrtc:3806, webrtc:7480 Review-Url: https://codereview.webrtc.org/2852663002 Cr-Commit-Position: refs/heads/master@{#17927}
2017-04-28 05:24:50 -07:00
]
if (is_ios) {
bundle_data("test_support_unittests_bundle_data") {
testonly = true
sources = test_support_unittests_resources
outputs = [ "{{bundle_resources_dir}}/{{source_file_part}}" ]
}
}
rtc_test("test_support_unittests") {
deps = [
":call_config_utils",
":copy_to_file_audio_capturer_unittest",
":direct_transport",
":fake_video_codecs",
":fileutils",
":fileutils_unittests",
":frame_generator_impl",
":perf_test",
":rtc_expect_death",
":rtp_test_utils",
":test_common",
":test_main",
":test_support",
":test_support_test_artifacts",
":video_test_common",
":video_test_support",
"../api:create_frame_generator",
"../api:create_simulcast_test_fixture_api",
"../api:frame_generator_api",
"../api:scoped_refptr",
"../api:simulcast_test_fixture_api",
"../api/task_queue:task_queue_test",
"../api/test/video:function_video_factory",
"../api/video:encoded_image",
"../api/video:video_frame",
"../api/video:video_frame_i420",
"../api/video_codecs:video_codecs_api",
"../call:video_stream_api",
"../common_video",
"../media:rtc_media_base",
"../modules/rtp_rtcp",
"../modules/rtp_rtcp:rtp_rtcp_format",
"../modules/video_coding:simulcast_test_fixture_impl",
"../modules/video_coding:video_codec_interface",
"../modules/video_coding:video_coding_utility",
"../modules/video_coding:webrtc_h264",
"../modules/video_coding:webrtc_vp8",
"../modules/video_coding:webrtc_vp9",
"../rtc_base:criticalsection",
"../rtc_base:rtc_event",
"../rtc_base:rtc_task_queue",
"../rtc_base/system:file_wrapper",
"../rtc_base/task_utils:to_queued_task",
"pc/e2e:e2e_unittests",
"peer_scenario/tests",
"scenario:scenario_unittests",
"time_controller:time_controller",
"time_controller:time_controller_unittests",
"//third_party/abseil-cpp/absl/flags:flag",
"//third_party/abseil-cpp/absl/strings",
"//third_party/abseil-cpp/absl/types:optional",
]
sources = [
"call_config_utils_unittest.cc",
"direct_transport_unittest.cc",
"fake_vp8_encoder_unittest.cc",
"frame_generator_capturer_unittest.cc",
"frame_generator_unittest.cc",
"rtp_file_reader_unittest.cc",
"rtp_file_writer_unittest.cc",
"run_loop_unittest.cc",
"testsupport/ivf_video_frame_generator_unittest.cc",
"testsupport/perf_test_unittest.cc",
"testsupport/test_artifacts_unittest.cc",
"testsupport/video_frame_writer_unittest.cc",
"testsupport/y4m_frame_reader_unittest.cc",
"testsupport/y4m_frame_writer_unittest.cc",
"testsupport/yuv_frame_reader_unittest.cc",
"testsupport/yuv_frame_writer_unittest.cc",
]
if (rtc_enable_protobuf) {
sources += [ "testsupport/perf_test_histogram_writer_unittest.cc" ]
deps += [ "//third_party/catapult/tracing/tracing:histogram" ]
}
data = test_support_unittests_resources
if (is_android) {
deps += [ "//testing/android/native_test:native_test_support" ]
shard_timeout = 900
}
if (is_ios) {
deps += [ ":test_support_unittests_bundle_data" ]
}
if (!is_android && !build_with_chromium) {
# This is needed in order to avoid:
# undefined symbol: webrtc::videocapturemodule::VideoCaptureImpl::Create
deps += [ "../modules/video_capture:video_capture_internal_impl" ]
}
}
}
if (is_ios) {
rtc_library("fileutils_ios_objc") {
visibility = [
":fileutils",
":fileutils_override_impl",
]
sources = [
"testsupport/ios_file_utils.h",
"testsupport/ios_file_utils.mm",
]
deps = [
"../rtc_base:checks",
"../rtc_base:rtc_base_approved",
"../sdk:helpers_objc",
]
}
}
if (is_mac) {
rtc_library("fileutils_mac_objc") {
visibility = [
":fileutils",
":fileutils_override_impl",
]
sources = [
"testsupport/mac_file_utils.h",
"testsupport/mac_file_utils.mm",
]
deps = [ "../rtc_base:checks" ]
}
}
rtc_library("fileutils") {
testonly = true
visibility = [ "*" ]
sources = [
"testsupport/file_utils.cc",
"testsupport/file_utils.h",
]
Reland of Enabling `gn check` on webrtc/test (patchset #1 id:1 of https://codereview.webrtc.org/2920763002/ ) Reason for revert: Fixing and re-landing. Original issue's description: > Revert of Enabling `gn check` on webrtc/test (patchset #9 id:160001 of https://codereview.webrtc.org/2911203002/ ) > > Reason for revert: > ERROR at //webrtc/test/testsupport/fileutils_unittest.cc:20:11: Can't include this header from here. > #include "webrtc/base/checks.h" > ^------------------- > The target: > //webrtc/test:fileutils_unittests > is including a file from the target: > //webrtc/base:rtc_base_approved > > It's usually best to depend directly on the destination target. > In some cases, the destination target is considered a subcomponent > of an intermediate target. In this case, the intermediate target > should depend publicly on the destination to forward the ability > to include headers. > > Dependency chain (there may also be others): > //webrtc/test:fileutils_unittests --> > //webrtc/test:fileutils --[private]--> > //webrtc/base:rtc_base_approved > > > Original issue's description: > > Enabling `gn check` on webrtc/test > > > > BUG=webrtc:6828 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/2911203002 > > Cr-Commit-Position: refs/heads/master@{#18372} > > Committed: https://chromium.googlesource.com/external/webrtc/+/db5bb404b0f42a7c0a43f882b34ba1325d8cbae2 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6828 > > Review-Url: https://codereview.webrtc.org/2920763002 > Cr-Commit-Position: refs/heads/master@{#18375} > Committed: https://chromium.googlesource.com/external/webrtc/+/1a6f143d077aec85d919c516b4f74ada8b8c21a8 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6828 Review-Url: https://codereview.webrtc.org/2918793002 Cr-Commit-Position: refs/heads/master@{#18376}
2017-06-01 04:47:20 -07:00
deps = [
":fileutils_override_api",
":fileutils_override_impl",
"../rtc_base:checks",
"../rtc_base:stringutils",
]
absl_deps = [ "//third_party/abseil-cpp/absl/types:optional" ]
if (is_ios) {
deps += [ ":fileutils_ios_objc" ]
}
if (is_mac) {
deps += [ ":fileutils_mac_objc" ]
}
if (is_win) {
deps += [ "../rtc_base" ]
}
}
# We separate header into own target to make it possible for downstream
# projects to override implementation.
rtc_source_set("fileutils_override_api") {
testonly = true
sources = [ "testsupport/file_utils_override.h" ]
}
rtc_library("fileutils_override_impl") {
testonly = true
visibility = [ ":fileutils" ]
sources = [ "testsupport/file_utils_override.cc" ]
deps = [
":fileutils_override_api",
"../rtc_base:checks",
"../rtc_base:macromagic",
"../rtc_base:stringutils",
Reland of Enabling `gn check` on webrtc/test (patchset #1 id:1 of https://codereview.webrtc.org/2920763002/ ) Reason for revert: Fixing and re-landing. Original issue's description: > Revert of Enabling `gn check` on webrtc/test (patchset #9 id:160001 of https://codereview.webrtc.org/2911203002/ ) > > Reason for revert: > ERROR at //webrtc/test/testsupport/fileutils_unittest.cc:20:11: Can't include this header from here. > #include "webrtc/base/checks.h" > ^------------------- > The target: > //webrtc/test:fileutils_unittests > is including a file from the target: > //webrtc/base:rtc_base_approved > > It's usually best to depend directly on the destination target. > In some cases, the destination target is considered a subcomponent > of an intermediate target. In this case, the intermediate target > should depend publicly on the destination to forward the ability > to include headers. > > Dependency chain (there may also be others): > //webrtc/test:fileutils_unittests --> > //webrtc/test:fileutils --[private]--> > //webrtc/base:rtc_base_approved > > > Original issue's description: > > Enabling `gn check` on webrtc/test > > > > BUG=webrtc:6828 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/2911203002 > > Cr-Commit-Position: refs/heads/master@{#18372} > > Committed: https://chromium.googlesource.com/external/webrtc/+/db5bb404b0f42a7c0a43f882b34ba1325d8cbae2 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6828 > > Review-Url: https://codereview.webrtc.org/2920763002 > Cr-Commit-Position: refs/heads/master@{#18375} > Committed: https://chromium.googlesource.com/external/webrtc/+/1a6f143d077aec85d919c516b4f74ada8b8c21a8 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6828 Review-Url: https://codereview.webrtc.org/2918793002 Cr-Commit-Position: refs/heads/master@{#18376}
2017-06-01 04:47:20 -07:00
]
absl_deps = [ "//third_party/abseil-cpp/absl/types:optional" ]
if (is_ios) {
deps += [ ":fileutils_ios_objc" ]
}
if (is_mac) {
deps += [ ":fileutils_mac_objc" ]
Reland of Enabling `gn check` on webrtc/test (patchset #1 id:1 of https://codereview.webrtc.org/2920763002/ ) Reason for revert: Fixing and re-landing. Original issue's description: > Revert of Enabling `gn check` on webrtc/test (patchset #9 id:160001 of https://codereview.webrtc.org/2911203002/ ) > > Reason for revert: > ERROR at //webrtc/test/testsupport/fileutils_unittest.cc:20:11: Can't include this header from here. > #include "webrtc/base/checks.h" > ^------------------- > The target: > //webrtc/test:fileutils_unittests > is including a file from the target: > //webrtc/base:rtc_base_approved > > It's usually best to depend directly on the destination target. > In some cases, the destination target is considered a subcomponent > of an intermediate target. In this case, the intermediate target > should depend publicly on the destination to forward the ability > to include headers. > > Dependency chain (there may also be others): > //webrtc/test:fileutils_unittests --> > //webrtc/test:fileutils --[private]--> > //webrtc/base:rtc_base_approved > > > Original issue's description: > > Enabling `gn check` on webrtc/test > > > > BUG=webrtc:6828 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/2911203002 > > Cr-Commit-Position: refs/heads/master@{#18372} > > Committed: https://chromium.googlesource.com/external/webrtc/+/db5bb404b0f42a7c0a43f882b34ba1325d8cbae2 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6828 > > Review-Url: https://codereview.webrtc.org/2920763002 > Cr-Commit-Position: refs/heads/master@{#18375} > Committed: https://chromium.googlesource.com/external/webrtc/+/1a6f143d077aec85d919c516b4f74ada8b8c21a8 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6828 Review-Url: https://codereview.webrtc.org/2918793002 Cr-Commit-Position: refs/heads/master@{#18376}
2017-06-01 04:47:20 -07:00
}
if (is_win) {
deps += [ "../rtc_base" ]
}
}
rtc_source_set("run_test") {
testonly = true
if (is_mac) {
public_deps = [ ":run_test_objc" ] # no-presubmit-check TODO(webrtc:8603)
} else {
public_deps = # no-presubmit-check TODO(webrtc:8603)
[ ":run_test_generic" ]
}
}
rtc_source_set("run_test_interface") {
sources = [ "run_test.h" ]
}
if (is_mac) {
rtc_library("run_test_objc") {
testonly = true
visibility = [ ":run_test" ]
sources = [ "mac/run_test.mm" ]
deps = [ ":run_test_interface" ]
}
}
rtc_library("run_test_generic") {
testonly = true
visibility = [ ":run_test" ]
sources = [ "run_test.cc" ]
deps = [ ":run_test_interface" ]
}
rtc_library("fileutils_unittests") {
testonly = true
visibility = [ ":*" ] # Only targets in this file can depend on this.
sources = [ "testsupport/file_utils_unittest.cc" ]
deps = [
":fileutils",
Reland of Enabling `gn check` on webrtc/test (patchset #1 id:1 of https://codereview.webrtc.org/2920763002/ ) Reason for revert: Fixing and re-landing. Original issue's description: > Revert of Enabling `gn check` on webrtc/test (patchset #9 id:160001 of https://codereview.webrtc.org/2911203002/ ) > > Reason for revert: > ERROR at //webrtc/test/testsupport/fileutils_unittest.cc:20:11: Can't include this header from here. > #include "webrtc/base/checks.h" > ^------------------- > The target: > //webrtc/test:fileutils_unittests > is including a file from the target: > //webrtc/base:rtc_base_approved > > It's usually best to depend directly on the destination target. > In some cases, the destination target is considered a subcomponent > of an intermediate target. In this case, the intermediate target > should depend publicly on the destination to forward the ability > to include headers. > > Dependency chain (there may also be others): > //webrtc/test:fileutils_unittests --> > //webrtc/test:fileutils --[private]--> > //webrtc/base:rtc_base_approved > > > Original issue's description: > > Enabling `gn check` on webrtc/test > > > > BUG=webrtc:6828 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/2911203002 > > Cr-Commit-Position: refs/heads/master@{#18372} > > Committed: https://chromium.googlesource.com/external/webrtc/+/db5bb404b0f42a7c0a43f882b34ba1325d8cbae2 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6828 > > Review-Url: https://codereview.webrtc.org/2920763002 > Cr-Commit-Position: refs/heads/master@{#18375} > Committed: https://chromium.googlesource.com/external/webrtc/+/1a6f143d077aec85d919c516b4f74ada8b8c21a8 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6828 Review-Url: https://codereview.webrtc.org/2918793002 Cr-Commit-Position: refs/heads/master@{#18376}
2017-06-01 04:47:20 -07:00
":test_support",
"../rtc_base:checks",
]
absl_deps = [ "//third_party/abseil-cpp/absl/types:optional" ]
}
rtc_library("direct_transport") {
Revert "Revert "GN rtc_* templates: Set default visibility to webrtc_root + "/*""" This reverts commit c73e1f437889d882cbf2987f7fb3a029a6150613. Reason for revert: The problem with failed deps in chrome content/renderer had already been fixed in https://webrtc-review.googlesource.com/c/src/+/38660 Original change's description: > Revert "GN rtc_* templates: Set default visibility to webrtc_root + "/*"" > > This reverts commit 588c548657b3ddf76e7b3f241263eef7f5799f16. > > Reason for revert: > > Breaks Chrome FYI: > > /b/c/b/Linux_Builder/src/buildtools/linux64/gn gen //out/Release --check > -> returned 1 > ERROR at //build/split_static_library.gni:12:5: Dependency not allowed. > static_library(target_name) { > ^---------------------------- > The item //content/renderer:renderer > can not depend on //third_party/webrtc/media:rtc_internal_video_codecs > because it is not in //third_party/webrtc/media:rtc_internal_video_codecs's visibility list: [ > //third_party/webrtc/* > //third_party/webrtc_overrides/* > ] > > https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.webrtc.fyi%2FLinux_Builder%2F23560%2F%2B%2Frecipes%2Fsteps%2Fgenerate_build_files%2F0%2Fstdout > > Original change's description: > > GN rtc_* templates: Set default visibility to webrtc_root + "/*" > > > > This means that by default, targets are visible to everything under > > the WebRTC root, but not visible to anything else. > > > > API targets are manually tagged with visibility "*", so that targets > > outside the WebRTC tree can see them. > > > > BUG=webrtc:8254 > > > > Change-Id: Icdbee6e0d22d93240ff2fb530c8f9dc48e351509 > > Reviewed-on: https://webrtc-review.googlesource.com/24140 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#21548} > > TBR=mbonadei@webrtc.org,kwiberg@webrtc.org > > Change-Id: I06620ce3d6f67482935c22efa231dd6cab91625a > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:8254 > Reviewed-on: https://webrtc-review.googlesource.com/38760 > Reviewed-by: Per Kjellander <perkj@webrtc.org> > Commit-Queue: Per Kjellander <perkj@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#21555} TBR=mbonadei@webrtc.org,kwiberg@webrtc.org,perkj@webrtc.org Change-Id: I6f720078ce21bd172e0a6471bae8c4c011e4a657 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:8254 Reviewed-on: https://webrtc-review.googlesource.com/38860 Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Per Kjellander <perkj@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21558}
2018-01-10 15:54:53 +00:00
visibility = [ "*" ]
testonly = true
sources = [
"direct_transport.cc",
"direct_transport.h",
]
deps = [
":rtp_test_utils",
"../api:simulated_network_api",
"../api:transport_api",
"../api/task_queue",
"../api/units:time_delta",
"../call:call_interfaces",
"../call:simulated_packet_receiver",
"../rtc_base:macromagic",
"../rtc_base:timeutils",
"../rtc_base/synchronization:sequence_checker",
"../rtc_base/task_utils:repeating_task",
]
absl_deps = [ "//third_party/abseil-cpp/absl/memory" ]
public_deps = # no-presubmit-check TODO(webrtc:8603)
[ "../call:fake_network" ]
}
rtc_library("fake_video_codecs") {
allow_poison = [ "software_video_codecs" ]
visibility = [ "*" ]
sources = [
"configurable_frame_size_encoder.cc",
"configurable_frame_size_encoder.h",
"fake_decoder.cc",
"fake_decoder.h",
"fake_encoder.cc",
"fake_encoder.h",
"fake_vp8_decoder.cc",
"fake_vp8_decoder.h",
"fake_vp8_encoder.cc",
"fake_vp8_encoder.h",
]
deps = [
"../api:fec_controller_api",
"../api:scoped_refptr",
"../api/task_queue",
"../api/video:encoded_image",
"../api/video:video_bitrate_allocation",
"../api/video:video_frame",
"../api/video:video_frame_i420",
"../api/video:video_rtp_headers",
"../api/video_codecs:video_codecs_api",
"../api/video_codecs:vp8_temporal_layers_factory",
"../modules:module_api",
"../modules/video_coding:codec_globals_headers",
"../modules/video_coding:video_codec_interface",
"../modules/video_coding:video_coding_utility",
"../rtc_base:checks",
"../rtc_base:criticalsection",
"../rtc_base:macromagic",
"../rtc_base:rtc_task_queue",
"../rtc_base:timeutils",
"../rtc_base/synchronization:sequence_checker",
"../system_wrappers",
]
absl_deps = [ "//third_party/abseil-cpp/absl/types:optional" ]
}
rtc_library("null_transport") {
testonly = true
sources = [
"null_transport.cc",
"null_transport.h",
]
deps = [ "../api:transport_api" ]
}
rtc_library("encoder_settings") {
testonly = true
sources = [
"encoder_settings.cc",
"encoder_settings.h",
]
deps = [
"../api:scoped_refptr",
"../api/video_codecs:video_codecs_api",
"../call:rtp_interfaces",
"../call:video_stream_api",
"../rtc_base:checks",
"../rtc_base:refcount",
]
}
rtc_library("rtc_expect_death") {
testonly = true
sources = [ "testsupport/rtc_expect_death.h" ]
deps = [ ":test_support" ]
}
rtc_library("test_common") {
testonly = true
sources = [
"call_test.cc",
"call_test.h",
"drifting_clock.cc",
"drifting_clock.h",
"fake_videorenderer.h",
"layer_filtering_transport.cc",
"layer_filtering_transport.h",
"rtp_rtcp_observer.h",
"run_loop.cc",
"run_loop.h",
"video_decoder_proxy_factory.h",
"video_encoder_proxy_factory.h",
]
deps = [
":direct_transport",
":encoder_settings",
":fake_video_codecs",
":fileutils",
":mock_transport",
":rtp_test_utils",
":test_support",
":video_test_common",
"../api:create_frame_generator",
"../api:frame_generator_api",
"../api:rtp_headers",
"../api:rtp_parameters",
"../api:simulated_network_api",
Reland of Enabling `gn check` on webrtc/test (patchset #1 id:1 of https://codereview.webrtc.org/2920763002/ ) Reason for revert: Fixing and re-landing. Original issue's description: > Revert of Enabling `gn check` on webrtc/test (patchset #9 id:160001 of https://codereview.webrtc.org/2911203002/ ) > > Reason for revert: > ERROR at //webrtc/test/testsupport/fileutils_unittest.cc:20:11: Can't include this header from here. > #include "webrtc/base/checks.h" > ^------------------- > The target: > //webrtc/test:fileutils_unittests > is including a file from the target: > //webrtc/base:rtc_base_approved > > It's usually best to depend directly on the destination target. > In some cases, the destination target is considered a subcomponent > of an intermediate target. In this case, the intermediate target > should depend publicly on the destination to forward the ability > to include headers. > > Dependency chain (there may also be others): > //webrtc/test:fileutils_unittests --> > //webrtc/test:fileutils --[private]--> > //webrtc/base:rtc_base_approved > > > Original issue's description: > > Enabling `gn check` on webrtc/test > > > > BUG=webrtc:6828 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/2911203002 > > Cr-Commit-Position: refs/heads/master@{#18372} > > Committed: https://chromium.googlesource.com/external/webrtc/+/db5bb404b0f42a7c0a43f882b34ba1325d8cbae2 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6828 > > Review-Url: https://codereview.webrtc.org/2920763002 > Cr-Commit-Position: refs/heads/master@{#18375} > Committed: https://chromium.googlesource.com/external/webrtc/+/1a6f143d077aec85d919c516b4f74ada8b8c21a8 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6828 Review-Url: https://codereview.webrtc.org/2918793002 Cr-Commit-Position: refs/heads/master@{#18376}
2017-06-01 04:47:20 -07:00
"../api:transport_api",
"../api/audio_codecs:builtin_audio_decoder_factory",
"../api/audio_codecs:builtin_audio_encoder_factory",
"../api/rtc_event_log",
"../api/task_queue",
"../api/task_queue:default_task_queue_factory",
"../api/test/video:function_video_factory",
"../api/transport:field_trial_based_config",
"../api/video:builtin_video_bitrate_allocator_factory",
"../api/video:video_bitrate_allocator_factory",
"../api/video:video_frame",
Reland of Move video_encoder.h and video_decoder.h to /api and create GN targets for them (patchset #1 id:1 of https://codereview.webrtc.org/2794033002/ ) Reason for revert: Reland with temporary deprecated API to not break chromium and google3. Original issue's description: > Revert of Move video_encoder.h and video_decoder.h to /api and create GN targets for them (patchset #8 id:140001 of https://codereview.webrtc.org/2780943003/ ) > > Reason for revert: > Suspect of breaking Chrome FYI bots. > > See > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/23065 > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder > > Example logs: > ../../content/renderer/media/gpu/rtc_video_encoder_unittest.cc:18:46: fatal error: third_party/webrtc/video_encoder.h: No such file or directory > #include "third_party/webrtc/video_encoder.h" > ^ > > Original issue's description: > > Move video_encoder.h and video_decoder.h to /api and create GN targets for them > > > > BUG=webrtc:5881 > > # Because PRESUBMIT ignores LINT blacklist for moved files and these > > # headers have some not easy to resolve issues. > > NOPRESUBMIT=True > > > > Review-Url: https://codereview.webrtc.org/2780943003 > > Cr-Commit-Position: refs/heads/master@{#17511} > > Committed: https://chromium.googlesource.com/external/webrtc/+/c42f54057050c933008a49d57582577bfb9aed25 > > TBR=solenberg@webrtc.org,sprang@webrtc.org,ilnik@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:5881 > > Review-Url: https://codereview.webrtc.org/2794033002 > Cr-Commit-Position: refs/heads/master@{#17514} > Committed: https://chromium.googlesource.com/external/webrtc/+/716d7ac5c1ed6e392e264b34065800bbf03772b3 TBR=solenberg@webrtc.org,sprang@webrtc.org,guidou@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5881 Review-Url: https://codereview.webrtc.org/2795163002 Cr-Commit-Position: refs/heads/master@{#17537}
2017-04-05 03:02:20 -07:00
"../api/video_codecs:video_codecs_api",
"../call:call_interfaces",
"../call:fake_network",
"../call:simulated_network",
"../call:simulated_packet_receiver",
"../call:video_stream_api",
"../modules/audio_device:audio_device_impl",
"../modules/audio_mixer:audio_mixer_impl",
Reland of Enabling `gn check` on webrtc/test (patchset #1 id:1 of https://codereview.webrtc.org/2920763002/ ) Reason for revert: Fixing and re-landing. Original issue's description: > Revert of Enabling `gn check` on webrtc/test (patchset #9 id:160001 of https://codereview.webrtc.org/2911203002/ ) > > Reason for revert: > ERROR at //webrtc/test/testsupport/fileutils_unittest.cc:20:11: Can't include this header from here. > #include "webrtc/base/checks.h" > ^------------------- > The target: > //webrtc/test:fileutils_unittests > is including a file from the target: > //webrtc/base:rtc_base_approved > > It's usually best to depend directly on the destination target. > In some cases, the destination target is considered a subcomponent > of an intermediate target. In this case, the intermediate target > should depend publicly on the destination to forward the ability > to include headers. > > Dependency chain (there may also be others): > //webrtc/test:fileutils_unittests --> > //webrtc/test:fileutils --[private]--> > //webrtc/base:rtc_base_approved > > > Original issue's description: > > Enabling `gn check` on webrtc/test > > > > BUG=webrtc:6828 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/2911203002 > > Cr-Commit-Position: refs/heads/master@{#18372} > > Committed: https://chromium.googlesource.com/external/webrtc/+/db5bb404b0f42a7c0a43f882b34ba1325d8cbae2 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6828 > > Review-Url: https://codereview.webrtc.org/2920763002 > Cr-Commit-Position: refs/heads/master@{#18375} > Committed: https://chromium.googlesource.com/external/webrtc/+/1a6f143d077aec85d919c516b4f74ada8b8c21a8 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6828 Review-Url: https://codereview.webrtc.org/2918793002 Cr-Commit-Position: refs/heads/master@{#18376}
2017-06-01 04:47:20 -07:00
"../modules/rtp_rtcp",
"../modules/rtp_rtcp:rtp_rtcp_format",
"../modules/rtp_rtcp:rtp_video_header",
"../modules/video_coding:codec_globals_headers",
"../rtc_base:checks",
"../rtc_base:criticalsection",
"../rtc_base:rtc_base",
"../rtc_base:rtc_event",
"../rtc_base:task_queue_for_test",
"../rtc_base/task_utils:to_queued_task",
Reland of Enabling `gn check` on webrtc/test (patchset #1 id:1 of https://codereview.webrtc.org/2920763002/ ) Reason for revert: Fixing and re-landing. Original issue's description: > Revert of Enabling `gn check` on webrtc/test (patchset #9 id:160001 of https://codereview.webrtc.org/2911203002/ ) > > Reason for revert: > ERROR at //webrtc/test/testsupport/fileutils_unittest.cc:20:11: Can't include this header from here. > #include "webrtc/base/checks.h" > ^------------------- > The target: > //webrtc/test:fileutils_unittests > is including a file from the target: > //webrtc/base:rtc_base_approved > > It's usually best to depend directly on the destination target. > In some cases, the destination target is considered a subcomponent > of an intermediate target. In this case, the intermediate target > should depend publicly on the destination to forward the ability > to include headers. > > Dependency chain (there may also be others): > //webrtc/test:fileutils_unittests --> > //webrtc/test:fileutils --[private]--> > //webrtc/base:rtc_base_approved > > > Original issue's description: > > Enabling `gn check` on webrtc/test > > > > BUG=webrtc:6828 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/2911203002 > > Cr-Commit-Position: refs/heads/master@{#18372} > > Committed: https://chromium.googlesource.com/external/webrtc/+/db5bb404b0f42a7c0a43f882b34ba1325d8cbae2 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6828 > > Review-Url: https://codereview.webrtc.org/2920763002 > Cr-Commit-Position: refs/heads/master@{#18375} > Committed: https://chromium.googlesource.com/external/webrtc/+/1a6f143d077aec85d919c516b4f74ada8b8c21a8 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6828 Review-Url: https://codereview.webrtc.org/2918793002 Cr-Commit-Position: refs/heads/master@{#18376}
2017-06-01 04:47:20 -07:00
"../system_wrappers",
"../system_wrappers:field_trial",
]
absl_deps = [ "//third_party/abseil-cpp/absl/types:optional" ]
Reland of Enable GN check for webrtc/base (patchset #3 id:230001 of https://codereview.webrtc.org/2838683002/ ) Reason for revert: Fourth attempt to land. Waiting for https://codereview.webrtc.org/2845013003 to avoid conflicts on webrtc/modules/audio_coding:neteq_unittest_tools. Original issue's description: > Revert of Enable GN check for webrtc/base (patchset #13 id:240001 of https://codereview.webrtc.org/2717083002/ ) > > Reason for revert: > Breaks Chromium because in Chromium we import WebRTC with rtc_include_tests=false (https://bugs.chromium.org/p/chromium/issues/detail?id=713179#c6). > > Chromium uses webrtc/test/fuzzers and this CL adds test dependencies to neteq_rtc_fuzzer. > > Original issue's description: > > Enable GN check for webrtc/base > > > > It's not possible to enable it for the rtc_base_approved > > target but since a larger refactoring is ongoing for webrtc/base > > this CL doesn't attempt to fix that. > > > > Changes made: > > * Move webrtc/system_wrappers/include/stringize_macros.h into > > webrtc/base:rtc_base_approved_unittests (and corresponding > > unit test to rtc_base_approved_unittests). > > * Move md5digest.* from rtc_base_approved to rtc_base_test_utils target. > > * Move webrtc/system_wrappers/include/stringize_macros.h (+test) into > > webrtc/base. > > * Remove unused use include of webrtc/base/fileutils.h in > > webrtc/base/pathutils.cc > > > > BUG=webrtc:6828, webrtc:3806, webrtc:7480 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/2717083002 > > Cr-Commit-Position: refs/heads/master@{#17766} > > Committed: https://chromium.googlesource.com/external/webrtc/+/ed754e71ae8866db641677073274e86fe704eeac > > TBR=perkj@webrtc.org,tommi@webrtc.org,nisse@webrtc.org,kjellander@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:6828, webrtc:3806, webrtc:7480 > NOTRY=True > > Review-Url: https://codereview.webrtc.org/2838683002 > Cr-Commit-Position: refs/heads/master@{#17849} > Committed: https://chromium.googlesource.com/external/webrtc/+/11ed366c487a938815cd52ad2ab5467b0f90e1ae TBR=perkj@webrtc.org,tommi@webrtc.org,nisse@webrtc.org,kjellander@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6828, webrtc:3806, webrtc:7480 Review-Url: https://codereview.webrtc.org/2852663002 Cr-Commit-Position: refs/heads/master@{#17927}
2017-04-28 05:24:50 -07:00
if (!is_android && !build_with_chromium) {
deps += [ "../modules/video_capture:video_capture_internal_impl" ]
}
}
rtc_library("mock_transport") {
testonly = true
sources = [
"mock_transport.cc",
"mock_transport.h",
]
deps = [
":test_support",
"../api:transport_api",
]
}
rtc_source_set("test_renderer") {
public_deps = # no-presubmit-check TODO(webrtc:8603)
[ ":test_renderer_generic" ]
testonly = true
if (is_mac) {
public_deps += # no-presubmit-check TODO(webrtc:8603)
[ ":test_renderer_objc" ]
}
}
rtc_library("mock_frame_transformer") {
visibility = [ "*" ]
testonly = true
sources = [ "mock_frame_transformer.h" ]
deps = [
"../api:frame_transformer_interface",
"../test:test_support",
]
}
rtc_library("mock_transformable_frame") {
visibility = [ "*" ]
testonly = true
sources = [ "mock_transformable_frame.h" ]
deps = [
"../api:frame_transformer_interface",
"../test:test_support",
]
}
if (is_mac) {
rtc_library("test_renderer_objc") {
testonly = true
visibility = [ ":test_renderer" ]
sources = [
"mac/video_renderer_mac.h",
"mac/video_renderer_mac.mm",
]
deps = [
":test_renderer_generic",
"../rtc_base:rtc_base_approved",
]
frameworks = [
"Cocoa.framework",
"OpenGL.framework",
"CoreVideo.framework",
]
}
}
rtc_library("test_renderer_generic") {
testonly = true
visibility = [
":test_renderer",
":test_renderer_objc",
]
libs = []
sources = [
"video_renderer.cc",
"video_renderer.h",
]
deps = [
"../api/video:video_frame",
"../common_video",
"../rtc_base:checks",
]
if (is_win) {
sources += [
"win/d3d_renderer.cc",
"win/d3d_renderer.h",
]
deps += [ "../api:scoped_refptr" ]
}
if (!(is_linux && rtc_use_x11) && !is_mac && !is_win) {
sources += [ "null_platform_renderer.cc" ]
}
if ((is_linux && rtc_use_x11) || is_mac) {
sources += [
"gl/gl_renderer.cc",
"gl/gl_renderer.h",
]
}
if (is_linux && rtc_use_x11) {
sources += [
"linux/glx_renderer.cc",
"linux/glx_renderer.h",
"linux/video_renderer_linux.cc",
]
libs += [
"Xext",
"X11",
"GL",
]
}
if (is_android) {
libs += [
"GLESv2",
"log",
]
}
}
rtc_library("audio_codec_mocks") {
testonly = true
sources = [
# TODO(nisse): Move these factories to their own target, to avoid
# unnecessary dependencies on gmock and gtest.
"audio_decoder_proxy_factory.h",
"function_audio_decoder_factory.h",
"mock_audio_decoder.cc",
"mock_audio_decoder.h",
"mock_audio_decoder_factory.h",
"mock_audio_encoder.cc",
"mock_audio_encoder.h",
"mock_audio_encoder_factory.h",
]
deps = [
Reland of Enabling `gn check` on webrtc/test (patchset #1 id:1 of https://codereview.webrtc.org/2920763002/ ) Reason for revert: Fixing and re-landing. Original issue's description: > Revert of Enabling `gn check` on webrtc/test (patchset #9 id:160001 of https://codereview.webrtc.org/2911203002/ ) > > Reason for revert: > ERROR at //webrtc/test/testsupport/fileutils_unittest.cc:20:11: Can't include this header from here. > #include "webrtc/base/checks.h" > ^------------------- > The target: > //webrtc/test:fileutils_unittests > is including a file from the target: > //webrtc/base:rtc_base_approved > > It's usually best to depend directly on the destination target. > In some cases, the destination target is considered a subcomponent > of an intermediate target. In this case, the intermediate target > should depend publicly on the destination to forward the ability > to include headers. > > Dependency chain (there may also be others): > //webrtc/test:fileutils_unittests --> > //webrtc/test:fileutils --[private]--> > //webrtc/base:rtc_base_approved > > > Original issue's description: > > Enabling `gn check` on webrtc/test > > > > BUG=webrtc:6828 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/2911203002 > > Cr-Commit-Position: refs/heads/master@{#18372} > > Committed: https://chromium.googlesource.com/external/webrtc/+/db5bb404b0f42a7c0a43f882b34ba1325d8cbae2 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6828 > > Review-Url: https://codereview.webrtc.org/2920763002 > Cr-Commit-Position: refs/heads/master@{#18375} > Committed: https://chromium.googlesource.com/external/webrtc/+/1a6f143d077aec85d919c516b4f74ada8b8c21a8 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6828 Review-Url: https://codereview.webrtc.org/2918793002 Cr-Commit-Position: refs/heads/master@{#18376}
2017-06-01 04:47:20 -07:00
":test_support",
"../api:array_view",
"../api:scoped_refptr",
"../api/audio_codecs:audio_codecs_api",
Reland of Enabling `gn check` on webrtc/test (patchset #1 id:1 of https://codereview.webrtc.org/2920763002/ ) Reason for revert: Fixing and re-landing. Original issue's description: > Revert of Enabling `gn check` on webrtc/test (patchset #9 id:160001 of https://codereview.webrtc.org/2911203002/ ) > > Reason for revert: > ERROR at //webrtc/test/testsupport/fileutils_unittest.cc:20:11: Can't include this header from here. > #include "webrtc/base/checks.h" > ^------------------- > The target: > //webrtc/test:fileutils_unittests > is including a file from the target: > //webrtc/base:rtc_base_approved > > It's usually best to depend directly on the destination target. > In some cases, the destination target is considered a subcomponent > of an intermediate target. In this case, the intermediate target > should depend publicly on the destination to forward the ability > to include headers. > > Dependency chain (there may also be others): > //webrtc/test:fileutils_unittests --> > //webrtc/test:fileutils --[private]--> > //webrtc/base:rtc_base_approved > > > Original issue's description: > > Enabling `gn check` on webrtc/test > > > > BUG=webrtc:6828 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/2911203002 > > Cr-Commit-Position: refs/heads/master@{#18372} > > Committed: https://chromium.googlesource.com/external/webrtc/+/db5bb404b0f42a7c0a43f882b34ba1325d8cbae2 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6828 > > Review-Url: https://codereview.webrtc.org/2920763002 > Cr-Commit-Position: refs/heads/master@{#18375} > Committed: https://chromium.googlesource.com/external/webrtc/+/1a6f143d077aec85d919c516b4f74ada8b8c21a8 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6828 Review-Url: https://codereview.webrtc.org/2918793002 Cr-Commit-Position: refs/heads/master@{#18376}
2017-06-01 04:47:20 -07:00
"../api/audio_codecs:builtin_audio_decoder_factory",
"../rtc_base:checks",
"../rtc_base:refcount",
]
absl_deps = [ "//third_party/abseil-cpp/absl/memory" ]
}
rtc_library("copy_to_file_audio_capturer") {
testonly = true
sources = [
"testsupport/copy_to_file_audio_capturer.cc",
"testsupport/copy_to_file_audio_capturer.h",
]
deps = [
"../api:array_view",
"../common_audio",
"../modules/audio_device:audio_device_impl",
"../rtc_base:rtc_base_approved",
]
absl_deps = [ "//third_party/abseil-cpp/absl/types:optional" ]
}
rtc_library("copy_to_file_audio_capturer_unittest") {
testonly = true
sources = [ "testsupport/copy_to_file_audio_capturer_unittest.cc" ]
deps = [
":copy_to_file_audio_capturer",
":fileutils",
":test_support",
"../modules/audio_device:audio_device_impl",
]
}
if (!build_with_chromium && is_android) {
Reland: "Make javac warnings errors for WebRTC targets." This reverts commit 2bad72a27329ff30ceb9479253f5eb3d21888d25. Reason for revert: Fixing downstream projects (take 2). Original change's description: > Reland "Revert "Make javac warnings errors for WebRTC targets."" > > This is a reland of 098d24c3c18f4b1fd043d7ba716d7601f0ce2b74 > Original change's description: > > Revert "Make javac warnings errors for WebRTC targets." > > > > This reverts commit 19b761403c3522902d69d61179f4d184e3632f79. > > > > Reason for revert: Breaking internal builds > > > > Original change's description: > > > Make javac warnings errors for WebRTC targets. > > > > > > Adds new rtc_* templates for Android targets to allow specifying > > > default values that affect WebRTC targets. > > > > > > Bug: webrtc:6597 > > > Change-Id: Ie529bfc8500d1e785b8a59dba7078b5f88ccfcd1 > > > Reviewed-on: https://webrtc-review.googlesource.com/15103 > > > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > > > Commit-Queue: Sami Kalliomäki <sakal@webrtc.org> > > > Cr-Commit-Position: refs/heads/master@{#20567} > > > TBR=phoglund@webrtc.org,sakal@webrtc.org > > > > Change-Id: I6d3ff5604b3d4307765d3a65adb783f89fcc974c > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: webrtc:6597 > > Reviewed-on: https://webrtc-review.googlesource.com/20740 > > Reviewed-by: Lu Liu <lliuu@webrtc.org> > > Commit-Queue: Lu Liu <lliuu@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#20571} > > Bug: webrtc:6597 > Change-Id: Icfb5ded46ce76b674bae67bfa02054b4ec52bb0f > Reviewed-on: https://webrtc-review.googlesource.com/20800 > Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org> > Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#20577} TBR=phoglund@webrtc.org,ehmaldonado@webrtc.org,mbonadei@webrtc.org,sakal@webrtc.org,lliuu@webrtc.org Change-Id: Id3713c1885318741711987ae642a269a9ca5bb85 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:6597 Reviewed-on: https://webrtc-review.googlesource.com/18441 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20588}
2017-11-07 15:36:33 +00:00
rtc_android_library("native_test_java") {
testonly = true
sources = [
"android/org/webrtc/native_test/RTCNativeUnitTest.java",
"android/org/webrtc/native_test/RTCNativeUnitTestActivity.java",
]
deps = [
"../rtc_base:base_java",
"//testing/android/native_test:native_test_java",
]
}
}
rtc_library("call_config_utils") {
# TODO(bugs.webrtc.org/10814): Remove rtc_json_suppressions as soon as it
# gets removed upstream.
public_configs = [ "../rtc_base:rtc_json_suppressions" ]
sources = [
"call_config_utils.cc",
"call_config_utils.h",
]
deps = [
"../call:video_stream_api",
"../rtc_base:rtc_json",
]
}