2014-10-01 17:42:18 +00:00
|
|
|
/*
|
|
|
|
|
* Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
|
|
|
|
|
*
|
|
|
|
|
* Use of this source code is governed by a BSD-style license
|
|
|
|
|
* that can be found in the LICENSE file in the root of the source
|
|
|
|
|
* tree. An additional intellectual property rights grant can be found
|
|
|
|
|
* in the file PATENTS. All contributing project authors may
|
|
|
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
|
|
|
*/
|
|
|
|
|
|
2017-09-15 06:47:31 +02:00
|
|
|
#include "common_audio/real_fourier.h"
|
2014-10-01 17:42:18 +00:00
|
|
|
|
|
|
|
|
#include <stdlib.h>
|
|
|
|
|
|
2017-09-15 06:47:31 +02:00
|
|
|
#include "common_audio/real_fourier_ooura.h"
|
|
|
|
|
#include "test/gtest.h"
|
2014-10-01 17:42:18 +00:00
|
|
|
|
|
|
|
|
namespace webrtc {
|
|
|
|
|
|
|
|
|
|
using std::complex;
|
|
|
|
|
|
|
|
|
|
TEST(RealFourierStaticsTest, AllocatorAlignment) {
|
|
|
|
|
{
|
|
|
|
|
RealFourier::fft_real_scoper real;
|
|
|
|
|
real = RealFourier::AllocRealBuffer(3);
|
|
|
|
|
ASSERT_TRUE(real.get() != nullptr);
|
Misc. small cleanups.
* Better param names
* Avoid using negative values for (bogus) placeholder channel counts (mostly in tests). Since channels will be changing to size_t, negative values will be illegal; it's sufficient to use 0 in these cases.
* Use arraysize()
* Use size_t for counting frames, samples, blocks, buffers, and bytes -- most of these are already size_t in most places, this just fixes some stragglers
* reinterpret_cast<int64_t>(void*) is not necessarily safe; use uintptr_t instead
* Remove unnecessary code, e.g. dead code, needlessly long/repetitive code, or function overrides that exactly match the base definition
* Fix indenting
* Use uint32_t for timestamps (matching how it's already a uint32_t in most places)
* Spelling
* RTC_CHECK_EQ(expected, actual)
* Rewrap
* Use .empty()
* Be more pedantic about matching int/int32_t/
* Remove pointless consts on input parameters to functions
* Add missing sanity checks
All this was found in the course of constructing https://codereview.webrtc.org/1316523002/ , and is being landed separately first.
BUG=none
TEST=none
Review URL: https://codereview.webrtc.org/1534193008
Cr-Commit-Position: refs/heads/master@{#11191}
2016-01-08 13:50:27 -08:00
|
|
|
uintptr_t ptr_value = reinterpret_cast<uintptr_t>(real.get());
|
|
|
|
|
EXPECT_EQ(0u, ptr_value % RealFourier::kFftBufferAlignment);
|
2014-10-01 17:42:18 +00:00
|
|
|
}
|
|
|
|
|
{
|
|
|
|
|
RealFourier::fft_cplx_scoper cplx;
|
|
|
|
|
cplx = RealFourier::AllocCplxBuffer(3);
|
|
|
|
|
ASSERT_TRUE(cplx.get() != nullptr);
|
Misc. small cleanups.
* Better param names
* Avoid using negative values for (bogus) placeholder channel counts (mostly in tests). Since channels will be changing to size_t, negative values will be illegal; it's sufficient to use 0 in these cases.
* Use arraysize()
* Use size_t for counting frames, samples, blocks, buffers, and bytes -- most of these are already size_t in most places, this just fixes some stragglers
* reinterpret_cast<int64_t>(void*) is not necessarily safe; use uintptr_t instead
* Remove unnecessary code, e.g. dead code, needlessly long/repetitive code, or function overrides that exactly match the base definition
* Fix indenting
* Use uint32_t for timestamps (matching how it's already a uint32_t in most places)
* Spelling
* RTC_CHECK_EQ(expected, actual)
* Rewrap
* Use .empty()
* Be more pedantic about matching int/int32_t/
* Remove pointless consts on input parameters to functions
* Add missing sanity checks
All this was found in the course of constructing https://codereview.webrtc.org/1316523002/ , and is being landed separately first.
BUG=none
TEST=none
Review URL: https://codereview.webrtc.org/1534193008
Cr-Commit-Position: refs/heads/master@{#11191}
2016-01-08 13:50:27 -08:00
|
|
|
uintptr_t ptr_value = reinterpret_cast<uintptr_t>(cplx.get());
|
|
|
|
|
EXPECT_EQ(0u, ptr_value % RealFourier::kFftBufferAlignment);
|
2014-10-01 17:42:18 +00:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
TEST(RealFourierStaticsTest, OrderComputation) {
|
Reformat existing code. There should be no functional effects.
This includes changes like:
* Attempt to break lines at better positions
* Use "override" in more places, don't use "virtual" with it
* Use {} where the body is more than one line
* Make declaration and definition arg names match
* Eliminate unused code
* EXPECT_EQ(expected, actual) (but use (actual, expected) for e.g. _GT)
* Correct #include order
* Use anonymous namespaces in preference to "static" for file-scoping
* Eliminate unnecessary casts
* Update reference code in comments of ARM assembly sources to match actual current C code
* Fix indenting to be more style-guide compliant
* Use arraysize() in more places
* Use bool instead of int for "boolean" values (0/1)
* Shorten and simplify code
* Spaces around operators
* 80 column limit
* Use const more consistently
* Space goes after '*' in type name, not before
* Remove unnecessary return values
* Use "(var == const)", not "(const == var)"
* Spelling
* Prefer true, typed constants to "enum hack" constants
* Avoid "virtual" on non-overridden functions
* ASSERT(x == y) -> ASSERT_EQ(y, x)
BUG=none
R=andrew@webrtc.org, asapersson@webrtc.org, henrika@webrtc.org, juberti@webrtc.org, kjellander@webrtc.org, kwiberg@webrtc.org
Review URL: https://codereview.webrtc.org/1172163004
Cr-Commit-Position: refs/heads/master@{#9420}
2015-06-11 14:31:38 -07:00
|
|
|
EXPECT_EQ(4, RealFourier::FftOrder(13));
|
|
|
|
|
EXPECT_EQ(5, RealFourier::FftOrder(32));
|
|
|
|
|
EXPECT_EQ(1, RealFourier::FftOrder(2));
|
|
|
|
|
EXPECT_EQ(0, RealFourier::FftOrder(1));
|
2014-10-01 17:42:18 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
TEST(RealFourierStaticsTest, ComplexLengthComputation) {
|
Update a ton of audio code to use size_t more correctly and in general reduce
use of int16_t/uint16_t.
This is the upshot of a recommendation by henrik.lundin and kwiberg on an original small change ( https://webrtc-codereview.appspot.com/42569004/#ps1 ) to stop using int16_t just because values could fit in it, and is similar in nature to a previous "mass change to use size_t more" ( https://webrtc-codereview.appspot.com/23129004/ ) which also needed to be split up for review but to land all at once, since, like adding "const", such changes tend to cause a lot of transitive effects.
This was be reviewed and approved in pieces:
https://codereview.webrtc.org/1224093003
https://codereview.webrtc.org/1224123002
https://codereview.webrtc.org/1224163002
https://codereview.webrtc.org/1225133003
https://codereview.webrtc.org/1225173002
https://codereview.webrtc.org/1227163003
https://codereview.webrtc.org/1227203003
https://codereview.webrtc.org/1227213002
https://codereview.webrtc.org/1227893002
https://codereview.webrtc.org/1228793004
https://codereview.webrtc.org/1228803003
https://codereview.webrtc.org/1228823002
https://codereview.webrtc.org/1228823003
https://codereview.webrtc.org/1228843002
https://codereview.webrtc.org/1230693002
https://codereview.webrtc.org/1231713002
The change is being landed as TBR to all the folks who reviewed the above.
BUG=chromium:81439
TEST=none
R=andrew@webrtc.org, pbos@webrtc.org
TBR=aluebs, andrew, asapersson, henrika, hlundin, jan.skoglund, kwiberg, minyue, pbos, pthatcher
Review URL: https://codereview.webrtc.org/1230503003 .
Cr-Commit-Position: refs/heads/master@{#9768}
2015-08-24 14:52:23 -07:00
|
|
|
EXPECT_EQ(2U, RealFourier::ComplexLength(1));
|
|
|
|
|
EXPECT_EQ(3U, RealFourier::ComplexLength(2));
|
|
|
|
|
EXPECT_EQ(5U, RealFourier::ComplexLength(3));
|
|
|
|
|
EXPECT_EQ(9U, RealFourier::ComplexLength(4));
|
|
|
|
|
EXPECT_EQ(17U, RealFourier::ComplexLength(5));
|
|
|
|
|
EXPECT_EQ(65U, RealFourier::ComplexLength(7));
|
2014-10-01 17:42:18 +00:00
|
|
|
}
|
|
|
|
|
|
2015-03-19 20:06:29 +00:00
|
|
|
template <typename T>
|
2014-10-01 17:42:18 +00:00
|
|
|
class RealFourierTest : public ::testing::Test {
|
|
|
|
|
protected:
|
|
|
|
|
RealFourierTest()
|
2015-03-19 20:06:29 +00:00
|
|
|
: rf_(2),
|
2014-10-01 17:42:18 +00:00
|
|
|
real_buffer_(RealFourier::AllocRealBuffer(4)),
|
|
|
|
|
cplx_buffer_(RealFourier::AllocCplxBuffer(3)) {}
|
|
|
|
|
|
2018-06-19 15:03:05 +02:00
|
|
|
~RealFourierTest() {}
|
2014-10-01 17:42:18 +00:00
|
|
|
|
2015-03-19 20:06:29 +00:00
|
|
|
T rf_;
|
2014-10-01 17:42:18 +00:00
|
|
|
const RealFourier::fft_real_scoper real_buffer_;
|
|
|
|
|
const RealFourier::fft_cplx_scoper cplx_buffer_;
|
|
|
|
|
};
|
|
|
|
|
|
2018-04-24 11:47:52 +02:00
|
|
|
using FftTypes = ::testing::Types<RealFourierOoura>;
|
2019-01-31 12:20:57 +01:00
|
|
|
TYPED_TEST_SUITE(RealFourierTest, FftTypes);
|
2015-03-19 20:06:29 +00:00
|
|
|
|
|
|
|
|
TYPED_TEST(RealFourierTest, SimpleForwardTransform) {
|
|
|
|
|
this->real_buffer_[0] = 1.0f;
|
|
|
|
|
this->real_buffer_[1] = 2.0f;
|
|
|
|
|
this->real_buffer_[2] = 3.0f;
|
|
|
|
|
this->real_buffer_[3] = 4.0f;
|
|
|
|
|
|
|
|
|
|
this->rf_.Forward(this->real_buffer_.get(), this->cplx_buffer_.get());
|
|
|
|
|
|
|
|
|
|
EXPECT_NEAR(this->cplx_buffer_[0].real(), 10.0f, 1e-8f);
|
|
|
|
|
EXPECT_NEAR(this->cplx_buffer_[0].imag(), 0.0f, 1e-8f);
|
|
|
|
|
EXPECT_NEAR(this->cplx_buffer_[1].real(), -2.0f, 1e-8f);
|
|
|
|
|
EXPECT_NEAR(this->cplx_buffer_[1].imag(), 2.0f, 1e-8f);
|
|
|
|
|
EXPECT_NEAR(this->cplx_buffer_[2].real(), -2.0f, 1e-8f);
|
|
|
|
|
EXPECT_NEAR(this->cplx_buffer_[2].imag(), 0.0f, 1e-8f);
|
2014-10-01 17:42:18 +00:00
|
|
|
}
|
|
|
|
|
|
2015-03-19 20:06:29 +00:00
|
|
|
TYPED_TEST(RealFourierTest, SimpleBackwardTransform) {
|
|
|
|
|
this->cplx_buffer_[0] = complex<float>(10.0f, 0.0f);
|
|
|
|
|
this->cplx_buffer_[1] = complex<float>(-2.0f, 2.0f);
|
|
|
|
|
this->cplx_buffer_[2] = complex<float>(-2.0f, 0.0f);
|
2014-10-01 17:42:18 +00:00
|
|
|
|
2015-03-19 20:06:29 +00:00
|
|
|
this->rf_.Inverse(this->cplx_buffer_.get(), this->real_buffer_.get());
|
2014-10-01 17:42:18 +00:00
|
|
|
|
2015-03-19 20:06:29 +00:00
|
|
|
EXPECT_NEAR(this->real_buffer_[0], 1.0f, 1e-8f);
|
|
|
|
|
EXPECT_NEAR(this->real_buffer_[1], 2.0f, 1e-8f);
|
|
|
|
|
EXPECT_NEAR(this->real_buffer_[2], 3.0f, 1e-8f);
|
|
|
|
|
EXPECT_NEAR(this->real_buffer_[3], 4.0f, 1e-8f);
|
2014-10-01 17:42:18 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
} // namespace webrtc
|