admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
webrtc_m130/test/fuzzers/BUILD.gn

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

671 lines
18 KiB
Plaintext
Raw Normal View History

Implement fuzzing of VP9 depacketization. Provides an example for how to use fuzzing within the webrtc tree. BUG=webrtc:4771 R=aizatsky@chromium.org, asapersson@webrtc.org, kjellander@webrtc.org Review URL: https://codereview.webrtc.org/1463523002 . Cr-Commit-Position: refs/heads/master@{#10752}
2015-11-23 15:12:06 +01:00
# Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
#
# Use of this source code is governed by a BSD-style license
# that can be found in the LICENSE file in the root of the source
# tree. An additional intellectual property rights grant can be found
# in the file PATENTS. All contributing project authors may
# be found in the AUTHORS file in the root of the source tree.
import("//build/config/features.gni")
Use the Chromium libfuzzer template instead of rolling our own. This lets us use their fancy features, including seed_corpus which is super handy. NOTRY=true Review-Url: https://codereview.webrtc.org/2081683002 Cr-Commit-Position: refs/heads/master@{#13216}
2016-06-20 06:03:39 -07:00
import("//testing/libfuzzer/fuzzer_test.gni")
Decouple //rtc_base:rtc_base_tests_utils from gunit. This CL decouples //rtc_base:rtc_base_tests_utils from gunit by moving gunit helpers (rtc_base/gunit.h) and rtc_base/testclient.h (which depends on gunit helpers) to their own build target. It also removes some unused dependencies in the WebRTC build graph. Bug: None Change-Id: Ia9820e84ff697da39b351eef73c45f6e4bdf2623 Reviewed-on: https://webrtc-review.googlesource.com/c/111861 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25769}
2018-11-23 13:15:08 +01:00
import("../../webrtc.gni")
Implement fuzzing of VP9 depacketization. Provides an example for how to use fuzzing within the webrtc tree. BUG=webrtc:4771 R=aizatsky@chromium.org, asapersson@webrtc.org, kjellander@webrtc.org Review URL: https://codereview.webrtc.org/1463523002 . Cr-Commit-Position: refs/heads/master@{#10752}
2015-11-23 15:12:06 +01:00
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("webrtc_fuzzer_main") {
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "webrtc_fuzzer_main.cc" ]
Implement fuzzing of VP9 depacketization. Provides an example for how to use fuzzing within the webrtc tree. BUG=webrtc:4771 R=aizatsky@chromium.org, asapersson@webrtc.org, kjellander@webrtc.org Review URL: https://codereview.webrtc.org/1463523002 . Cr-Commit-Position: refs/heads/master@{#10752}
2015-11-23 15:12:06 +01:00
deps = [
Revert "Reland "Make webrtc_fuzzer_main depend on webrtc_component in Chromium."" This reverts commit 8994c8bab315fa34b75a8e79b78bb99c86f69966. Reason for revert: While RTC_EXPORTS are needed, this is still not enough, I will try another approach, similar to what we do for rtc_base/logging.{cc,h}. Original change's description: > Reland "Make webrtc_fuzzer_main depend on webrtc_component in Chromium." > > This is a reland of 2148e9a931ea1a8a2ac0bfffd56e12370f8bf18c > > Original change's description: > > Make webrtc_fuzzer_main depend on webrtc_component in Chromium. > > > > This is needed in order to land [1] and restrict visibility of some > > //third_party/webrtc_overrides targets. > > > > [1] - https://chromium-review.googlesource.com/c/chromium/src/+/1930801 > > > > Bug: chromium:896154 > > Change-Id: Ie71c44ee9a0203a85d77a1199acdcb8581dfb71b > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/160308 > > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#29875} > > No-Try: True > No-Tree-Checks: true > TBR: kwiberg@webrtc.org > Bug: chromium:896154 > Change-Id: I157bd4f90528a38ac16f17dd17af2f255dbd5ec9 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/160401 > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#29888} TBR=mbonadei@webrtc.org,kwiberg@webrtc.org Change-Id: If969618e3f0a0cd70204128f1e8a2b06cf407b6e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:896154 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/160402 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29889}
2019-11-23 15:10:32 +00:00
"../../rtc_base:rtc_base_approved",
Implement fuzzing of VP9 depacketization. Provides an example for how to use fuzzing within the webrtc tree. BUG=webrtc:4771 R=aizatsky@chromium.org, asapersson@webrtc.org, kjellander@webrtc.org Review URL: https://codereview.webrtc.org/1463523002 . Cr-Commit-Position: refs/heads/master@{#10752}
2015-11-23 15:12:06 +01:00
"//testing/libfuzzer:libfuzzer_main",
]
Revert "Reland "Make webrtc_fuzzer_main depend on webrtc_component in Chromium."" This reverts commit 8994c8bab315fa34b75a8e79b78bb99c86f69966. Reason for revert: While RTC_EXPORTS are needed, this is still not enough, I will try another approach, similar to what we do for rtc_base/logging.{cc,h}. Original change's description: > Reland "Make webrtc_fuzzer_main depend on webrtc_component in Chromium." > > This is a reland of 2148e9a931ea1a8a2ac0bfffd56e12370f8bf18c > > Original change's description: > > Make webrtc_fuzzer_main depend on webrtc_component in Chromium. > > > > This is needed in order to land [1] and restrict visibility of some > > //third_party/webrtc_overrides targets. > > > > [1] - https://chromium-review.googlesource.com/c/chromium/src/+/1930801 > > > > Bug: chromium:896154 > > Change-Id: Ie71c44ee9a0203a85d77a1199acdcb8581dfb71b > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/160308 > > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#29875} > > No-Try: True > No-Tree-Checks: true > TBR: kwiberg@webrtc.org > Bug: chromium:896154 > Change-Id: I157bd4f90528a38ac16f17dd17af2f255dbd5ec9 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/160401 > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#29888} TBR=mbonadei@webrtc.org,kwiberg@webrtc.org Change-Id: If969618e3f0a0cd70204128f1e8a2b06cf407b6e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:896154 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/160402 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29889}
2019-11-23 15:10:32 +00:00
# When WebRTC fuzzer tests are built on Chromium bots they need to link
Reland "Enable use of rtc::SystemTimeNanos() provided by Chromium" This reverts commit cd5127b11e04b7f49031b2412625c36e4a86c3da. Reason for revert: Fuzzer build problems fixed. Original change's description: > Revert "Enable use of rtc::SystemTimeNanos() provided by Chromium" > > This reverts commit dfe19719e53abfd4d73722942445c5e1046b671b. > > Reason for revert: Breaks fuzzers in Chromium builds. See https://ci.chromium.org/ui/p/chromium/builders/try/linux-libfuzzer-asan-rel/685438/overview. I am reverting since this blocks the roll but I will be in touch for a fix. > > Original change's description: > > Enable use of rtc::SystemTimeNanos() provided by Chromium > > > > This is the third CL out of three to enable overriding > > of the function SystemTimeNanos() in rtc_base/system_time.cc > > > > When WebRTC is built as part of Chromium the rtc::SystemTimeNanos() > > function provided by Chromium will be used. This is controlled > > by the build argument rtc_exclude_system_time which directly > > maps to the macro WEBRTC_EXCLUDE_SYSTEM_TIME. > > > > By doing this we are making sure that the WebRTC and Chromium > > clocks are the same. > > > > Bug: chromium:516700 > > Change-Id: If7f749c4aadefb1cfc07ba4c7e3f45dc6c31118b > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/208223 > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#33337} > > TBR=kron@webrtc.org > > Bug: chromium:516700 > Change-Id: I9ecd1784a6c1cdac8bae07d34f7df20c62a21a95 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/208740 > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#33340} Bug: chromium:516700 Change-Id: I4cd68bac1cc4befdb46351f5d6fb2cf1ef5c3062 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/208742 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Johannes Kron <kron@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33341}
2021-02-25 10:10:08 +01:00
# with Chromium's implementation of metrics, field trial, and system time.
Fix WebRTC fuzzers tests in Chromium. When WebRTC fuzzers tests are built on Chromium bots they need to link with Chromium's implementation of metrics. TBR=phoglund@webrtc.org Bug: webrtc:9631 Change-Id: I1c955e646366b6b37d3ca595888e8cc94fe1b00e Reviewed-on: https://webrtc-review.googlesource.com/100940 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Christian Fremerey <chfremer@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24771}
2018-09-18 23:41:33 +02:00
if (build_with_chromium) {
Revert "Reland "Make webrtc_fuzzer_main depend on webrtc_component in Chromium."" This reverts commit 8994c8bab315fa34b75a8e79b78bb99c86f69966. Reason for revert: While RTC_EXPORTS are needed, this is still not enough, I will try another approach, similar to what we do for rtc_base/logging.{cc,h}. Original change's description: > Reland "Make webrtc_fuzzer_main depend on webrtc_component in Chromium." > > This is a reland of 2148e9a931ea1a8a2ac0bfffd56e12370f8bf18c > > Original change's description: > > Make webrtc_fuzzer_main depend on webrtc_component in Chromium. > > > > This is needed in order to land [1] and restrict visibility of some > > //third_party/webrtc_overrides targets. > > > > [1] - https://chromium-review.googlesource.com/c/chromium/src/+/1930801 > > > > Bug: chromium:896154 > > Change-Id: Ie71c44ee9a0203a85d77a1199acdcb8581dfb71b > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/160308 > > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#29875} > > No-Try: True > No-Tree-Checks: true > TBR: kwiberg@webrtc.org > Bug: chromium:896154 > Change-Id: I157bd4f90528a38ac16f17dd17af2f255dbd5ec9 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/160401 > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#29888} TBR=mbonadei@webrtc.org,kwiberg@webrtc.org Change-Id: If969618e3f0a0cd70204128f1e8a2b06cf407b6e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:896154 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/160402 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29889}
2019-11-23 15:10:32 +00:00
deps += [
"../../../webrtc_overrides:field_trial",
"../../../webrtc_overrides:metrics",
Reland "Enable use of rtc::SystemTimeNanos() provided by Chromium" This reverts commit cd5127b11e04b7f49031b2412625c36e4a86c3da. Reason for revert: Fuzzer build problems fixed. Original change's description: > Revert "Enable use of rtc::SystemTimeNanos() provided by Chromium" > > This reverts commit dfe19719e53abfd4d73722942445c5e1046b671b. > > Reason for revert: Breaks fuzzers in Chromium builds. See https://ci.chromium.org/ui/p/chromium/builders/try/linux-libfuzzer-asan-rel/685438/overview. I am reverting since this blocks the roll but I will be in touch for a fix. > > Original change's description: > > Enable use of rtc::SystemTimeNanos() provided by Chromium > > > > This is the third CL out of three to enable overriding > > of the function SystemTimeNanos() in rtc_base/system_time.cc > > > > When WebRTC is built as part of Chromium the rtc::SystemTimeNanos() > > function provided by Chromium will be used. This is controlled > > by the build argument rtc_exclude_system_time which directly > > maps to the macro WEBRTC_EXCLUDE_SYSTEM_TIME. > > > > By doing this we are making sure that the WebRTC and Chromium > > clocks are the same. > > > > Bug: chromium:516700 > > Change-Id: If7f749c4aadefb1cfc07ba4c7e3f45dc6c31118b > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/208223 > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#33337} > > TBR=kron@webrtc.org > > Bug: chromium:516700 > Change-Id: I9ecd1784a6c1cdac8bae07d34f7df20c62a21a95 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/208740 > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#33340} Bug: chromium:516700 Change-Id: I4cd68bac1cc4befdb46351f5d6fb2cf1ef5c3062 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/208742 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Johannes Kron <kron@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33341}
2021-02-25 10:10:08 +01:00
"../../../webrtc_overrides:system_time",
Revert "Reland "Make webrtc_fuzzer_main depend on webrtc_component in Chromium."" This reverts commit 8994c8bab315fa34b75a8e79b78bb99c86f69966. Reason for revert: While RTC_EXPORTS are needed, this is still not enough, I will try another approach, similar to what we do for rtc_base/logging.{cc,h}. Original change's description: > Reland "Make webrtc_fuzzer_main depend on webrtc_component in Chromium." > > This is a reland of 2148e9a931ea1a8a2ac0bfffd56e12370f8bf18c > > Original change's description: > > Make webrtc_fuzzer_main depend on webrtc_component in Chromium. > > > > This is needed in order to land [1] and restrict visibility of some > > //third_party/webrtc_overrides targets. > > > > [1] - https://chromium-review.googlesource.com/c/chromium/src/+/1930801 > > > > Bug: chromium:896154 > > Change-Id: Ie71c44ee9a0203a85d77a1199acdcb8581dfb71b > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/160308 > > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#29875} > > No-Try: True > No-Tree-Checks: true > TBR: kwiberg@webrtc.org > Bug: chromium:896154 > Change-Id: I157bd4f90528a38ac16f17dd17af2f255dbd5ec9 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/160401 > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#29888} TBR=mbonadei@webrtc.org,kwiberg@webrtc.org Change-Id: If969618e3f0a0cd70204128f1e8a2b06cf407b6e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:896154 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/160402 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29889}
2019-11-23 15:10:32 +00:00
]
Fix WebRTC fuzzers tests in Chromium. When WebRTC fuzzers tests are built on Chromium bots they need to link with Chromium's implementation of metrics. TBR=phoglund@webrtc.org Bug: webrtc:9631 Change-Id: I1c955e646366b6b37d3ca595888e8cc94fe1b00e Reviewed-on: https://webrtc-review.googlesource.com/100940 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Christian Fremerey <chfremer@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24771}
2018-09-18 23:41:33 +02:00
}
Implement fuzzing of VP9 depacketization. Provides an example for how to use fuzzing within the webrtc tree. BUG=webrtc:4771 R=aizatsky@chromium.org, asapersson@webrtc.org, kjellander@webrtc.org Review URL: https://codereview.webrtc.org/1463523002 . Cr-Commit-Position: refs/heads/master@{#10752}
2015-11-23 15:12:06 +01:00
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("fuzz_data_helper") {
Opus Encoder fuzzer: separate target for FuzzAudioEncoder Move FuzzAudioEncoder to a separate target to make it available for other encoders. Bug: webrtc:11388 Change-Id: I8b9a0f810791880eedb129b55eb33f154790e48f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169364 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30634}
2020-02-27 16:32:56 +01:00
testonly = true
Update packet_buffer_fuzzer to fuzz full packets. Bug: webrtc:7728 Change-Id: I9d33404470c2ecf8d6f91c57c9dc9fd4dd821a18 Reviewed-on: https://webrtc-review.googlesource.com/77424 Commit-Queue: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Alex Loiko <aleloi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23485}
2018-05-17 16:44:47 +02:00
sources = [
"fuzz_data_helper.cc",
"fuzz_data_helper.h",
]
deps = [
"../../api:array_view",
"../../modules/rtp_rtcp:rtp_rtcp_format",
]
visibility = [ ":*" ] # Only targets in this file can depend on this.
}
Add absl_deps to webrtc_fuzzer_test. Bug: chromium:1046390 Change-Id: I531511dce156a10174c9ed80ccb2d5cd75ec33b0 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/177900 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31553}
2020-06-23 23:39:56 +02:00
set_defaults("webrtc_fuzzer_test") {
Reland "Make webrtc_fuzzer_test use //:common_config." This is a reland of 9e09831767995531ae1c2804e1c15fa2be4053f2 The field "additional_configs" needs to be used to set "configs" for the "fuzzer_test" GN template. See https://source.chromium.org/chromium/chromium/src/+/main:testing/libfuzzer/fuzzer_test.gni;l=18;drc=825f86aa594207bfc50f87495544b48014814c9d. Original change's description: > Make webrtc_fuzzer_test use //:common_config. > > Before this CL, the GN template webrtc_fuzzer_test was using a build > config that was different from the one used by other WebRTC's targets. > > We discovered this in [1] where we detected that RTC_DCHECK_IS_ON had > different values across translation units (1 everywhere and 0 in the > one of the .cc file owned by the webrtc_fuzzer_test). > > This was because webrtc_fuzzer_test was not including the default > config //:common_config in its "configs". > > [1] - https://webrtc-review.googlesource.com/c/src/+/226465 > > Bug: None > Change-Id: I5635d90281769c23c5d86ebc8cb494da029c2e85 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226540 > Reviewed-by: Andrey Logvin <landrey@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#34509} Bug: None Change-Id: I56e2a7ea811a94762e09953acf3d33d3f46b1d24 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226542 Reviewed-by: Andrey Logvin <landrey@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34511}
2021-07-20 10:37:07 +02:00
configs = rtc_add_configs
Add absl_deps to webrtc_fuzzer_test. Bug: chromium:1046390 Change-Id: I531511dce156a10174c9ed80ccb2d5cd75ec33b0 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/177900 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31553}
2020-06-23 23:39:56 +02:00
absl_deps = []
}
Use the Chromium libfuzzer template instead of rolling our own. This lets us use their fancy features, including seed_corpus which is super handy. NOTRY=true Review-Url: https://codereview.webrtc.org/2081683002 Cr-Commit-Position: refs/heads/master@{#13216}
2016-06-20 06:03:39 -07:00
template("webrtc_fuzzer_test") {
fuzzer_test(target_name) {
forward_variables_from(invoker, "*")
Unconditionally link fuzzers with rtc_task_queue_impl. Bug: webrtc:8166, chromium:770690 Change-Id: I9480720c99308f8a2a3dcf407a07d762249f5a9c Reviewed-on: https://webrtc-review.googlesource.com/6840 Reviewed-by: Henrik Kjellander <kjellander@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20219}
2017-10-05 10:58:49 +02:00
deps += [
Update packet_buffer_fuzzer to fuzz full packets. Bug: webrtc:7728 Change-Id: I9d33404470c2ecf8d6f91c57c9dc9fd4dd821a18 Reviewed-on: https://webrtc-review.googlesource.com/77424 Commit-Queue: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Alex Loiko <aleloi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23485}
2018-05-17 16:44:47 +02:00
":fuzz_data_helper",
Unconditionally link fuzzers with rtc_task_queue_impl. Bug: webrtc:8166, chromium:770690 Change-Id: I9480720c99308f8a2a3dcf407a07d762249f5a9c Reviewed-on: https://webrtc-review.googlesource.com/6840 Reviewed-by: Henrik Kjellander <kjellander@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20219}
2017-10-05 10:58:49 +02:00
":webrtc_fuzzer_main",
]
Reland "Make webrtc_fuzzer_test use //:common_config." This is a reland of 9e09831767995531ae1c2804e1c15fa2be4053f2 The field "additional_configs" needs to be used to set "configs" for the "fuzzer_test" GN template. See https://source.chromium.org/chromium/chromium/src/+/main:testing/libfuzzer/fuzzer_test.gni;l=18;drc=825f86aa594207bfc50f87495544b48014814c9d. Original change's description: > Make webrtc_fuzzer_test use //:common_config. > > Before this CL, the GN template webrtc_fuzzer_test was using a build > config that was different from the one used by other WebRTC's targets. > > We discovered this in [1] where we detected that RTC_DCHECK_IS_ON had > different values across translation units (1 everywhere and 0 in the > one of the .cc file owned by the webrtc_fuzzer_test). > > This was because webrtc_fuzzer_test was not including the default > config //:common_config in its "configs". > > [1] - https://webrtc-review.googlesource.com/c/src/+/226465 > > Bug: None > Change-Id: I5635d90281769c23c5d86ebc8cb494da029c2e85 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226540 > Reviewed-by: Andrey Logvin <landrey@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#34509} Bug: None Change-Id: I56e2a7ea811a94762e09953acf3d33d3f46b1d24 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226542 Reviewed-by: Andrey Logvin <landrey@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34511}
2021-07-20 10:37:07 +02:00
additional_configs = configs
Add absl_deps to webrtc_fuzzer_test. Bug: chromium:1046390 Change-Id: I531511dce156a10174c9ed80ccb2d5cd75ec33b0 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/177900 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31553}
2020-06-23 23:39:56 +02:00
# If absl_deps is [], no action is needed. If not [], then it needs to be
# converted to //third_party/abseil-cpp:absl when build_with_chromium=true
# otherwise it just needs to be added to deps.
if (absl_deps != []) {
if (!defined(deps)) {
deps = []
}
if (build_with_chromium) {
deps += [ "//third_party/abseil-cpp:absl" ]
} else {
deps += absl_deps
}
}
GN: Exclude suppressions of Chromium Clang warnings for Chromium builds. These suppressions are causing GN errors when Chromium targets are depending directly on WebRTC targets (needed for https://codereview.chromium.org/2413103004) BUG=webrtc:4256 NOTRY=True Review-Url: https://codereview.webrtc.org/2408133008 Cr-Commit-Position: refs/heads/master@{#14644}
2016-10-16 23:56:12 -07:00
if (!build_with_chromium && is_clang) {
Use the Chromium libfuzzer template instead of rolling our own. This lets us use their fancy features, including seed_corpus which is super handy. NOTRY=true Review-Url: https://codereview.webrtc.org/2081683002 Cr-Commit-Position: refs/heads/master@{#13216}
2016-06-20 06:03:39 -07:00
suppressed_configs = [ "//build/config/clang:find_bad_constructs" ]
}
}
}
Add VP8 and H264 depacketizer fuzzers. Also removes listing of targets in webrtc_fuzzers which is very prone to not being up to date. They're not required for ClusterFuzz integration or building locally. This also means that adding fuzzers won't require approval outside the fuzzers directory. BUG=webrtc:4771 R=kjellander@webrtc.org, stefan@webrtc.org Review URL: https://codereview.webrtc.org/1518973003 . Cr-Commit-Position: refs/heads/master@{#11067}
2015-12-17 14:28:16 +01:00
webrtc_fuzzer_test("h264_depacketizer_fuzzer") {
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "h264_depacketizer_fuzzer.cc" ]
deps = [ "../../modules/rtp_rtcp" ]
Add VP8 and H264 depacketizer fuzzers. Also removes listing of targets in webrtc_fuzzers which is very prone to not being up to date. They're not required for ClusterFuzz integration or building locally. This also means that adding fuzzers won't require approval outside the fuzzers directory. BUG=webrtc:4771 R=kjellander@webrtc.org, stefan@webrtc.org Review URL: https://codereview.webrtc.org/1518973003 . Cr-Commit-Position: refs/heads/master@{#11067}
2015-12-17 14:28:16 +01:00
}
webrtc_fuzzer_test("vp8_depacketizer_fuzzer") {
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "vp8_depacketizer_fuzzer.cc" ]
Add VP8 and H264 depacketizer fuzzers. Also removes listing of targets in webrtc_fuzzers which is very prone to not being up to date. They're not required for ClusterFuzz integration or building locally. This also means that adding fuzzers won't require approval outside the fuzzers directory. BUG=webrtc:4771 R=kjellander@webrtc.org, stefan@webrtc.org Review URL: https://codereview.webrtc.org/1518973003 . Cr-Commit-Position: refs/heads/master@{#11067}
2015-12-17 14:28:16 +01:00
deps = [
Delete RtpDepacketizerVp8 in favor of VideoRtpDepacketizerVp8 Bug: webrtc:11152 Change-Id: I1a6225701ecd6f7a34c946d7296f0ab0cbb5eaef Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165342 Reviewed-by: Markus Handell <handellm@webrtc.org> Reviewed-by: Sam Zackrisson <saza@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30190}
2020-01-08 13:36:38 +01:00
"../../api:array_view",
Add VP8 and H264 depacketizer fuzzers. Also removes listing of targets in webrtc_fuzzers which is very prone to not being up to date. They're not required for ClusterFuzz integration or building locally. This also means that adding fuzzers won't require approval outside the fuzzers directory. BUG=webrtc:4771 R=kjellander@webrtc.org, stefan@webrtc.org Review URL: https://codereview.webrtc.org/1518973003 . Cr-Commit-Position: refs/heads/master@{#11067}
2015-12-17 14:28:16 +01:00
"../../modules/rtp_rtcp",
Delete RtpDepacketizerVp8 in favor of VideoRtpDepacketizerVp8 Bug: webrtc:11152 Change-Id: I1a6225701ecd6f7a34c946d7296f0ab0cbb5eaef Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165342 Reviewed-by: Markus Handell <handellm@webrtc.org> Reviewed-by: Sam Zackrisson <saza@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30190}
2020-01-08 13:36:38 +01:00
"../../modules/rtp_rtcp:rtp_video_header",
Add VP8 and H264 depacketizer fuzzers. Also removes listing of targets in webrtc_fuzzers which is very prone to not being up to date. They're not required for ClusterFuzz integration or building locally. This also means that adding fuzzers won't require approval outside the fuzzers directory. BUG=webrtc:4771 R=kjellander@webrtc.org, stefan@webrtc.org Review URL: https://codereview.webrtc.org/1518973003 . Cr-Commit-Position: refs/heads/master@{#11067}
2015-12-17 14:28:16 +01:00
]
}
Reland of Base webrtc fuzzers on a template. (patchset #1 id:1 of https://codereview.webrtc.org/1528043002/ ) Reason for revert: Found missing public_configs that broke Chromium libfuzzer build. Original issue's description: > Revert of Base webrtc fuzzers on a template. (patchset #1 id:1 of https://codereview.webrtc.org/1524993002/ ) > > Reason for revert: > Suspect this is breaking the build: > https://build.chromium.org/p/chromium.fyi/builders/Libfuzzer%20Upload%20Linux/builds/1576/steps/compile/logs/stdio > > Original issue's description: > > Base webrtc fuzzers on a template. > > > > Removes noisy dependencies on webrtc_fuzzer_main and removal of > > find_bad_constructs, removes 1-6 lines of gn per fuzzer target. > > > > BUG=webrtc:4771 > > R=kjellander@webrtc.org > > > > Committed: https://crrev.com/5ea3da2cbbb0710f9617fb0627c0c4258437b09f > > Cr-Commit-Position: refs/heads/master@{#11022} > > TBR=kjellander@webrtc.org,pbos@webrtc.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:4771 > > Committed: https://crrev.com/5e0218c66e0686dd00719f1e53f844efa94c9f42 > Cr-Commit-Position: refs/heads/master@{#11032} TBR=kjellander@webrtc.org,tommi@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4771 Review URL: https://codereview.webrtc.org/1522003005 . Cr-Commit-Position: refs/heads/master@{#11035}
2015-12-15 21:57:52 +01:00
webrtc_fuzzer_test("vp9_depacketizer_fuzzer") {
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "vp9_depacketizer_fuzzer.cc" ]
Implement fuzzing of VP9 depacketization. Provides an example for how to use fuzzing within the webrtc tree. BUG=webrtc:4771 R=aizatsky@chromium.org, asapersson@webrtc.org, kjellander@webrtc.org Review URL: https://codereview.webrtc.org/1463523002 . Cr-Commit-Position: refs/heads/master@{#10752}
2015-11-23 15:12:06 +01:00
deps = [
Delete RtpDepacketizerVp9 in favor of VideoRtpDepacketizerVp9 Bug: webrtc:11152 Change-Id: Ic50f2dc49ca420b3406d4dea11ed20328aa59136 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165382 Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Sam Zackrisson <saza@webrtc.org> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30195}
2020-01-09 12:26:18 +01:00
"../../api:array_view",
Implement fuzzing of VP9 depacketization. Provides an example for how to use fuzzing within the webrtc tree. BUG=webrtc:4771 R=aizatsky@chromium.org, asapersson@webrtc.org, kjellander@webrtc.org Review URL: https://codereview.webrtc.org/1463523002 . Cr-Commit-Position: refs/heads/master@{#10752}
2015-11-23 15:12:06 +01:00
"../../modules/rtp_rtcp",
Delete RtpDepacketizerVp9 in favor of VideoRtpDepacketizerVp9 Bug: webrtc:11152 Change-Id: Ic50f2dc49ca420b3406d4dea11ed20328aa59136 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165382 Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Sam Zackrisson <saza@webrtc.org> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30195}
2020-01-09 12:26:18 +01:00
"../../modules/rtp_rtcp:rtp_video_header",
Implement fuzzing of VP9 depacketization. Provides an example for how to use fuzzing within the webrtc tree. BUG=webrtc:4771 R=aizatsky@chromium.org, asapersson@webrtc.org, kjellander@webrtc.org Review URL: https://codereview.webrtc.org/1463523002 . Cr-Commit-Position: refs/heads/master@{#10752}
2015-11-23 15:12:06 +01:00
]
}
Add fuzzing of VP8 QP parsing. BUG=webrtc:4771 R=asapersson@webrtc.org, kjellander@webrtc.org Review URL: https://codereview.webrtc.org/1469123004 . Cr-Commit-Position: refs/heads/master@{#10806}
2015-11-26 14:52:23 +01:00
Reland of Base webrtc fuzzers on a template. (patchset #1 id:1 of https://codereview.webrtc.org/1528043002/ ) Reason for revert: Found missing public_configs that broke Chromium libfuzzer build. Original issue's description: > Revert of Base webrtc fuzzers on a template. (patchset #1 id:1 of https://codereview.webrtc.org/1524993002/ ) > > Reason for revert: > Suspect this is breaking the build: > https://build.chromium.org/p/chromium.fyi/builders/Libfuzzer%20Upload%20Linux/builds/1576/steps/compile/logs/stdio > > Original issue's description: > > Base webrtc fuzzers on a template. > > > > Removes noisy dependencies on webrtc_fuzzer_main and removal of > > find_bad_constructs, removes 1-6 lines of gn per fuzzer target. > > > > BUG=webrtc:4771 > > R=kjellander@webrtc.org > > > > Committed: https://crrev.com/5ea3da2cbbb0710f9617fb0627c0c4258437b09f > > Cr-Commit-Position: refs/heads/master@{#11022} > > TBR=kjellander@webrtc.org,pbos@webrtc.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:4771 > > Committed: https://crrev.com/5e0218c66e0686dd00719f1e53f844efa94c9f42 > Cr-Commit-Position: refs/heads/master@{#11032} TBR=kjellander@webrtc.org,tommi@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4771 Review URL: https://codereview.webrtc.org/1522003005 . Cr-Commit-Position: refs/heads/master@{#11035}
2015-12-15 21:57:52 +01:00
webrtc_fuzzer_test("vp8_qp_parser_fuzzer") {
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "vp8_qp_parser_fuzzer.cc" ]
Add fuzzing of VP8 QP parsing. BUG=webrtc:4771 R=asapersson@webrtc.org, kjellander@webrtc.org Review URL: https://codereview.webrtc.org/1469123004 . Cr-Commit-Position: refs/heads/master@{#10806}
2015-11-26 14:52:23 +01:00
deps = [
Reland of Enabling `gn check` on webrtc/test (patchset #1 id:1 of https://codereview.webrtc.org/2920763002/ ) Reason for revert: Fixing and re-landing. Original issue's description: > Revert of Enabling `gn check` on webrtc/test (patchset #9 id:160001 of https://codereview.webrtc.org/2911203002/ ) > > Reason for revert: > ERROR at //webrtc/test/testsupport/fileutils_unittest.cc:20:11: Can't include this header from here. > #include "webrtc/base/checks.h" > ^------------------- > The target: > //webrtc/test:fileutils_unittests > is including a file from the target: > //webrtc/base:rtc_base_approved > > It's usually best to depend directly on the destination target. > In some cases, the destination target is considered a subcomponent > of an intermediate target. In this case, the intermediate target > should depend publicly on the destination to forward the ability > to include headers. > > Dependency chain (there may also be others): > //webrtc/test:fileutils_unittests --> > //webrtc/test:fileutils --[private]--> > //webrtc/base:rtc_base_approved > > > Original issue's description: > > Enabling `gn check` on webrtc/test > > > > BUG=webrtc:6828 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/2911203002 > > Cr-Commit-Position: refs/heads/master@{#18372} > > Committed: https://chromium.googlesource.com/external/webrtc/+/db5bb404b0f42a7c0a43f882b34ba1325d8cbae2 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6828 > > Review-Url: https://codereview.webrtc.org/2920763002 > Cr-Commit-Position: refs/heads/master@{#18375} > Committed: https://chromium.googlesource.com/external/webrtc/+/1a6f143d077aec85d919c516b4f74ada8b8c21a8 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6828 Review-Url: https://codereview.webrtc.org/2918793002 Cr-Commit-Position: refs/heads/master@{#18376}
2017-06-01 04:47:20 -07:00
"../../modules/video_coding:video_coding_utility",
Add fuzzing of VP8 QP parsing. BUG=webrtc:4771 R=asapersson@webrtc.org, kjellander@webrtc.org Review URL: https://codereview.webrtc.org/1469123004 . Cr-Commit-Position: refs/heads/master@{#10806}
2015-11-26 14:52:23 +01:00
"../../modules/video_coding/",
]
Fuzzer for FEC header readers. BUG=webrtc:5654 Review-Url: https://codereview.webrtc.org/2265493002 Cr-Commit-Position: refs/heads/master@{#14470}
2016-10-03 02:02:49 -07:00
}
Add fuzzer for vp9 qp parser. Return false if ReadBits fails. Prevents GetQp from returning true with a qp of zero. BUG=webrtc:7662 Review-Url: https://codereview.webrtc.org/2911013002 Cr-Commit-Position: refs/heads/master@{#18462}
2017-06-06 23:41:44 -07:00
webrtc_fuzzer_test("vp9_qp_parser_fuzzer") {
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "vp9_qp_parser_fuzzer.cc" ]
Add fuzzer for vp9 qp parser. Return false if ReadBits fails. Prevents GetQp from returning true with a qp of zero. BUG=webrtc:7662 Review-Url: https://codereview.webrtc.org/2911013002 Cr-Commit-Position: refs/heads/master@{#18462}
2017-06-06 23:41:44 -07:00
deps = [
"../../modules/video_coding:video_coding_utility",
"../../modules/video_coding/",
]
}
Add fuzzer for H264 bitstream parser. BUG=webrtc:6454 R=kthelgason@webrtc.org Review-Url: https://codereview.webrtc.org/2430703002 Cr-Commit-Position: refs/heads/master@{#14936}
2016-11-05 03:10:22 -07:00
webrtc_fuzzer_test("h264_bitstream_parser_fuzzer") {
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "h264_bitstream_parser_fuzzer.cc" ]
Add fuzzer for H264 bitstream parser. BUG=webrtc:6454 R=kthelgason@webrtc.org Review-Url: https://codereview.webrtc.org/2430703002 Cr-Commit-Position: refs/heads/master@{#14936}
2016-11-05 03:10:22 -07:00
deps = [
Reland of Enabling `gn check` on webrtc/test (patchset #1 id:1 of https://codereview.webrtc.org/2920763002/ ) Reason for revert: Fixing and re-landing. Original issue's description: > Revert of Enabling `gn check` on webrtc/test (patchset #9 id:160001 of https://codereview.webrtc.org/2911203002/ ) > > Reason for revert: > ERROR at //webrtc/test/testsupport/fileutils_unittest.cc:20:11: Can't include this header from here. > #include "webrtc/base/checks.h" > ^------------------- > The target: > //webrtc/test:fileutils_unittests > is including a file from the target: > //webrtc/base:rtc_base_approved > > It's usually best to depend directly on the destination target. > In some cases, the destination target is considered a subcomponent > of an intermediate target. In this case, the intermediate target > should depend publicly on the destination to forward the ability > to include headers. > > Dependency chain (there may also be others): > //webrtc/test:fileutils_unittests --> > //webrtc/test:fileutils --[private]--> > //webrtc/base:rtc_base_approved > > > Original issue's description: > > Enabling `gn check` on webrtc/test > > > > BUG=webrtc:6828 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/2911203002 > > Cr-Commit-Position: refs/heads/master@{#18372} > > Committed: https://chromium.googlesource.com/external/webrtc/+/db5bb404b0f42a7c0a43f882b34ba1325d8cbae2 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6828 > > Review-Url: https://codereview.webrtc.org/2920763002 > Cr-Commit-Position: refs/heads/master@{#18375} > Committed: https://chromium.googlesource.com/external/webrtc/+/1a6f143d077aec85d919c516b4f74ada8b8c21a8 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6828 Review-Url: https://codereview.webrtc.org/2918793002 Cr-Commit-Position: refs/heads/master@{#18376}
2017-06-01 04:47:20 -07:00
"../../common_video",
Add fuzzer for H264 bitstream parser. BUG=webrtc:6454 R=kthelgason@webrtc.org Review-Url: https://codereview.webrtc.org/2430703002 Cr-Commit-Position: refs/heads/master@{#14936}
2016-11-05 03:10:22 -07:00
"../../modules/video_coding/",
]
}
Add fuzzer for ForwardErrorCorrection::DecodeFec. Bug: webrtc:8481 Change-Id: I23aa59ffee542c1c0b31c82186876ccc21e28592 Reviewed-on: https://webrtc-review.googlesource.com/32305 Commit-Queue: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21248}
2017-12-13 14:04:24 +01:00
webrtc_fuzzer_test("forward_error_correction_fuzzer") {
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "forward_error_correction_fuzzer.cc" ]
Add fuzzer for ForwardErrorCorrection::DecodeFec. Bug: webrtc:8481 Change-Id: I23aa59ffee542c1c0b31c82186876ccc21e28592 Reviewed-on: https://webrtc-review.googlesource.com/32305 Commit-Queue: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21248}
2017-12-13 14:04:24 +01:00
deps = [
Remove rtc_base/scoped_ref_ptr.h. The type rtc::scoped_refptr<T> is now part of api/. Please include it from api/scoped_refptr.h. More info: See: https://groups.google.com/forum/#!topic/discuss-webrtc/Mme2MSz4z4o. Bug: webrtc:9887, webrtc:8205 No-Try: True Change-Id: Ic6c7c81e226e59f12f7933e472f573ae097b55bf Reviewed-on: https://webrtc-review.googlesource.com/c/119041 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26414}
2019-01-25 20:26:48 +01:00
"../../api:scoped_refptr",
Add fuzzer for ForwardErrorCorrection::DecodeFec. Bug: webrtc:8481 Change-Id: I23aa59ffee542c1c0b31c82186876ccc21e28592 Reviewed-on: https://webrtc-review.googlesource.com/32305 Commit-Queue: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21248}
2017-12-13 14:04:24 +01:00
"../../modules/rtp_rtcp",
"../../modules/rtp_rtcp:rtp_rtcp_format",
"../../rtc_base:rtc_base_approved",
]
}
Fuzzer for FEC header readers. BUG=webrtc:5654 Review-Url: https://codereview.webrtc.org/2265493002 Cr-Commit-Position: refs/heads/master@{#14470}
2016-10-03 02:02:49 -07:00
webrtc_fuzzer_test("flexfec_header_reader_fuzzer") {
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "flexfec_header_reader_fuzzer.cc" ]
Fuzzer for FEC header readers. BUG=webrtc:5654 Review-Url: https://codereview.webrtc.org/2265493002 Cr-Commit-Position: refs/heads/master@{#14470}
2016-10-03 02:02:49 -07:00
deps = [
Remove rtc_base/scoped_ref_ptr.h. The type rtc::scoped_refptr<T> is now part of api/. Please include it from api/scoped_refptr.h. More info: See: https://groups.google.com/forum/#!topic/discuss-webrtc/Mme2MSz4z4o. Bug: webrtc:9887, webrtc:8205 No-Try: True Change-Id: Ic6c7c81e226e59f12f7933e472f573ae097b55bf Reviewed-on: https://webrtc-review.googlesource.com/c/119041 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26414}
2019-01-25 20:26:48 +01:00
"../../api:scoped_refptr",
GN: Tighten up test target visibility + refactorings Make all rtc_source_test target that contains tests that are included in a test executable only be visible to the rtc_test target. Doing this exposed a couple of errors and dependency problems that were resolved. Having this could have prevented duplicated execution of tests like the case that was recently fixed by deadbeef@ in https://codereview.webrtc.org/2820263004 New targets: * //webrtc/modules/rtp_rtcp:fec_test_helper * //webrtc/modules/rtp_rtcp:mock_rtp_rtcp * //webrtc/modules/remote_bitrate_estimator:mock_remote_bitrate_observer The mock files and targets should probably be moved into webrtc/test in the future, but that's out of the scope of this CL. BUG=webrtc:5716 NOTRY=True Review-Url: https://codereview.webrtc.org/2828793003 Cr-Commit-Position: refs/heads/master@{#17863}
2017-04-25 04:04:50 -07:00
"../../modules/rtp_rtcp",
Stop using public_deps in modules/rtp_rtcp. TBR=phoglund@webrtc.org Bug: webrtc:8603 Change-Id: I86830df23db3f33a1a26098e639596bd3b86485a No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/29780 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21108}
2017-12-06 07:51:33 +01:00
"../../modules/rtp_rtcp:rtp_rtcp_format",
Remove remains of webrtc/base All downstream code have been updated to the new location. In PRESUBMIT.py: * Remove webrtc/rtc_base from CPP_BLACKLIST * Add webrtc/rtc_base to LEGACY_API_DIRS Fix some duplicated paths in webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn BUG=webrtc:7634 TBR=kwiberg@webrtc.org Review-Url: https://codereview.webrtc.org/2976293002 Cr-Commit-Position: refs/heads/master@{#19094}
2017-07-19 10:40:47 -07:00
"../../rtc_base:rtc_base_approved",
Fuzzer for FEC header readers. BUG=webrtc:5654 Review-Url: https://codereview.webrtc.org/2265493002 Cr-Commit-Position: refs/heads/master@{#14470}
2016-10-03 02:02:49 -07:00
]
}
Add fuzzer for FlexfecSender. BUG=webrtc:5654 NOTRY=true Review-Url: https://codereview.webrtc.org/2433373003 Cr-Commit-Position: refs/heads/master@{#14937}
2016-11-06 22:45:15 -08:00
webrtc_fuzzer_test("flexfec_sender_fuzzer") {
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "flexfec_sender_fuzzer.cc" ]
Add fuzzer for FlexfecSender. BUG=webrtc:5654 NOTRY=true Review-Url: https://codereview.webrtc.org/2433373003 Cr-Commit-Position: refs/heads/master@{#14937}
2016-11-06 22:45:15 -08:00
deps = [
GN: Tighten up test target visibility + refactorings Make all rtc_source_test target that contains tests that are included in a test executable only be visible to the rtc_test target. Doing this exposed a couple of errors and dependency problems that were resolved. Having this could have prevented duplicated execution of tests like the case that was recently fixed by deadbeef@ in https://codereview.webrtc.org/2820263004 New targets: * //webrtc/modules/rtp_rtcp:fec_test_helper * //webrtc/modules/rtp_rtcp:mock_rtp_rtcp * //webrtc/modules/remote_bitrate_estimator:mock_remote_bitrate_observer The mock files and targets should probably be moved into webrtc/test in the future, but that's out of the scope of this CL. BUG=webrtc:5716 NOTRY=True Review-Url: https://codereview.webrtc.org/2828793003 Cr-Commit-Position: refs/heads/master@{#17863}
2017-04-25 04:04:50 -07:00
"../../modules/rtp_rtcp",
Stop using public_deps in modules/rtp_rtcp. TBR=phoglund@webrtc.org Bug: webrtc:8603 Change-Id: I86830df23db3f33a1a26098e639596bd3b86485a No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/29780 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21108}
2017-12-06 07:51:33 +01:00
"../../modules/rtp_rtcp:rtp_rtcp_format",
Reland of Enabling `gn check` on webrtc/test (patchset #1 id:1 of https://codereview.webrtc.org/2920763002/ ) Reason for revert: Fixing and re-landing. Original issue's description: > Revert of Enabling `gn check` on webrtc/test (patchset #9 id:160001 of https://codereview.webrtc.org/2911203002/ ) > > Reason for revert: > ERROR at //webrtc/test/testsupport/fileutils_unittest.cc:20:11: Can't include this header from here. > #include "webrtc/base/checks.h" > ^------------------- > The target: > //webrtc/test:fileutils_unittests > is including a file from the target: > //webrtc/base:rtc_base_approved > > It's usually best to depend directly on the destination target. > In some cases, the destination target is considered a subcomponent > of an intermediate target. In this case, the intermediate target > should depend publicly on the destination to forward the ability > to include headers. > > Dependency chain (there may also be others): > //webrtc/test:fileutils_unittests --> > //webrtc/test:fileutils --[private]--> > //webrtc/base:rtc_base_approved > > > Original issue's description: > > Enabling `gn check` on webrtc/test > > > > BUG=webrtc:6828 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/2911203002 > > Cr-Commit-Position: refs/heads/master@{#18372} > > Committed: https://chromium.googlesource.com/external/webrtc/+/db5bb404b0f42a7c0a43f882b34ba1325d8cbae2 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6828 > > Review-Url: https://codereview.webrtc.org/2920763002 > Cr-Commit-Position: refs/heads/master@{#18375} > Committed: https://chromium.googlesource.com/external/webrtc/+/1a6f143d077aec85d919c516b4f74ada8b8c21a8 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6828 Review-Url: https://codereview.webrtc.org/2918793002 Cr-Commit-Position: refs/heads/master@{#18376}
2017-06-01 04:47:20 -07:00
"../../system_wrappers",
Add fuzzer for FlexfecSender. BUG=webrtc:5654 NOTRY=true Review-Url: https://codereview.webrtc.org/2433373003 Cr-Commit-Position: refs/heads/master@{#14937}
2016-11-06 22:45:15 -08:00
]
}
Fuzzer for FEC header readers. BUG=webrtc:5654 Review-Url: https://codereview.webrtc.org/2265493002 Cr-Commit-Position: refs/heads/master@{#14470}
2016-10-03 02:02:49 -07:00
webrtc_fuzzer_test("ulpfec_header_reader_fuzzer") {
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "ulpfec_header_reader_fuzzer.cc" ]
Fuzzer for FEC header readers. BUG=webrtc:5654 Review-Url: https://codereview.webrtc.org/2265493002 Cr-Commit-Position: refs/heads/master@{#14470}
2016-10-03 02:02:49 -07:00
deps = [
Remove rtc_base/scoped_ref_ptr.h. The type rtc::scoped_refptr<T> is now part of api/. Please include it from api/scoped_refptr.h. More info: See: https://groups.google.com/forum/#!topic/discuss-webrtc/Mme2MSz4z4o. Bug: webrtc:9887, webrtc:8205 No-Try: True Change-Id: Ic6c7c81e226e59f12f7933e472f573ae097b55bf Reviewed-on: https://webrtc-review.googlesource.com/c/119041 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26414}
2019-01-25 20:26:48 +01:00
"../../api:scoped_refptr",
GN: Tighten up test target visibility + refactorings Make all rtc_source_test target that contains tests that are included in a test executable only be visible to the rtc_test target. Doing this exposed a couple of errors and dependency problems that were resolved. Having this could have prevented duplicated execution of tests like the case that was recently fixed by deadbeef@ in https://codereview.webrtc.org/2820263004 New targets: * //webrtc/modules/rtp_rtcp:fec_test_helper * //webrtc/modules/rtp_rtcp:mock_rtp_rtcp * //webrtc/modules/remote_bitrate_estimator:mock_remote_bitrate_observer The mock files and targets should probably be moved into webrtc/test in the future, but that's out of the scope of this CL. BUG=webrtc:5716 NOTRY=True Review-Url: https://codereview.webrtc.org/2828793003 Cr-Commit-Position: refs/heads/master@{#17863}
2017-04-25 04:04:50 -07:00
"../../modules/rtp_rtcp",
"../../modules/rtp_rtcp:fec_test_helper",
Stop using public_deps in modules/rtp_rtcp. TBR=phoglund@webrtc.org Bug: webrtc:8603 Change-Id: I86830df23db3f33a1a26098e639596bd3b86485a No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/29780 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21108}
2017-12-06 07:51:33 +01:00
"../../modules/rtp_rtcp:rtp_rtcp_format",
Remove remains of webrtc/base All downstream code have been updated to the new location. In PRESUBMIT.py: * Remove webrtc/rtc_base from CPP_BLACKLIST * Add webrtc/rtc_base to LEGACY_API_DIRS Fix some duplicated paths in webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn BUG=webrtc:7634 TBR=kwiberg@webrtc.org Review-Url: https://codereview.webrtc.org/2976293002 Cr-Commit-Position: refs/heads/master@{#19094}
2017-07-19 10:40:47 -07:00
"../../rtc_base:rtc_base_approved",
Fuzzer for FEC header readers. BUG=webrtc:5654 Review-Url: https://codereview.webrtc.org/2265493002 Cr-Commit-Position: refs/heads/master@{#14470}
2016-10-03 02:02:49 -07:00
]
Add FEC producer fuzzing and a unittest for one of the issues found. BUG=webrtc:4800 R=pbos@webrtc.org Review URL: https://codereview.webrtc.org/1522463002 . Cr-Commit-Position: refs/heads/master@{#10990}
2015-12-11 18:25:45 +01:00
}
Rename ProducerFec to UlpfecGenerator. BUG=webrtc:5654 Review-Url: https://codereview.webrtc.org/2449783002 Cr-Commit-Position: refs/heads/master@{#14847}
2016-10-31 05:27:07 -07:00
webrtc_fuzzer_test("ulpfec_generator_fuzzer") {
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "ulpfec_generator_fuzzer.cc" ]
Add FEC producer fuzzing and a unittest for one of the issues found. BUG=webrtc:4800 R=pbos@webrtc.org Review URL: https://codereview.webrtc.org/1522463002 . Cr-Commit-Position: refs/heads/master@{#10990}
2015-12-11 18:25:45 +01:00
deps = [
In ULP FEC fuzzer test, make sure sequence number is not the same as previous sequence number. Bug: chromium:859265 Change-Id: I9acb9a177dfed3830ead0ba5a16ee4310f4d2b5b Reviewed-on: https://webrtc-review.googlesource.com/86547 Commit-Queue: Ying Wang <yinwa@webrtc.org> Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23806}
2018-07-02 17:28:07 +02:00
"../../modules:module_api_public",
GN: Tighten up test target visibility + refactorings Make all rtc_source_test target that contains tests that are included in a test executable only be visible to the rtc_test target. Doing this exposed a couple of errors and dependency problems that were resolved. Having this could have prevented duplicated execution of tests like the case that was recently fixed by deadbeef@ in https://codereview.webrtc.org/2820263004 New targets: * //webrtc/modules/rtp_rtcp:fec_test_helper * //webrtc/modules/rtp_rtcp:mock_rtp_rtcp * //webrtc/modules/remote_bitrate_estimator:mock_remote_bitrate_observer The mock files and targets should probably be moved into webrtc/test in the future, but that's out of the scope of this CL. BUG=webrtc:5716 NOTRY=True Review-Url: https://codereview.webrtc.org/2828793003 Cr-Commit-Position: refs/heads/master@{#17863}
2017-04-25 04:04:50 -07:00
"../../modules/rtp_rtcp",
"../../modules/rtp_rtcp:fec_test_helper",
Stop using public_deps in modules/rtp_rtcp. TBR=phoglund@webrtc.org Bug: webrtc:8603 Change-Id: I86830df23db3f33a1a26098e639596bd3b86485a No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/29780 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21108}
2017-12-06 07:51:33 +01:00
"../../modules/rtp_rtcp:rtp_rtcp_format",
Fix circular dependencies between optional, array_view, and rtc_base. This splits things out of rtc_base and makes dependencies explicit. Bug: webrtc:6828 Change-Id: Id521896c3c43595349021c857bec216e429a0c8d Reviewed-on: https://webrtc-review.googlesource.com/32780 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21264}
2017-12-13 16:05:42 +01:00
"../../rtc_base:checks",
Remove remains of webrtc/base All downstream code have been updated to the new location. In PRESUBMIT.py: * Remove webrtc/rtc_base from CPP_BLACKLIST * Add webrtc/rtc_base to LEGACY_API_DIRS Fix some duplicated paths in webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn BUG=webrtc:7634 TBR=kwiberg@webrtc.org Review-Url: https://codereview.webrtc.org/2976293002 Cr-Commit-Position: refs/heads/master@{#19094}
2017-07-19 10:40:47 -07:00
"../../rtc_base:rtc_base_approved",
Reland "Reland "Refactors UlpFec and FlexFec to use a common interface."" This is a reland of 49734dc0faa69616a58a1a95c7fc61a4610793cf Patchset 2 contains a fix for the fuzzer set up. Since we now parse an RtpPacket out of the fuzzer data, the header needs to be correct, otherwise we fail before even reaching the FEC code that we actually want to test. Bug: webrtc:11340, chromium:1052323, chromium:1055974 TBR=stefan@webrtc.org Original change's description: > Reland "Refactors UlpFec and FlexFec to use a common interface." > > This is a reland of 11af1d7444fd7438766b7bc52cbd64752d72e32e > > Original change's description: > > Refactors UlpFec and FlexFec to use a common interface. > > > > The new VideoFecGenerator is now injected into RtpSenderVideo, > > and generalizes the usage. > > This also prepares for being able to genera FEC in the RTP egress > > module. > > > > Bug: webrtc:11340 > > Change-Id: I8aa873129b2fb4131eb3399ee88f6ea2747155a3 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168347 > > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > > Reviewed-by: Sebastian Jansson <srte@webrtc.org> > > Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> > > Commit-Queue: Erik Språng <sprang@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#30515} > > Bug: webrtc:11340, chromium:1052323 > Change-Id: Id646047365f1c46cca9e6f3e8eefa5151207b4a0 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168608 > Commit-Queue: Erik Språng <sprang@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#30593} Bug: webrtc:11340, chromium:1052323 Change-Id: Ib8925f44e2edfcfeadc95c845c3bfc23822604ed Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169222 Commit-Queue: Erik Språng <sprang@webrtc.org> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30724}
2020-03-05 10:14:04 +01:00
"../../system_wrappers",
Add FEC producer fuzzing and a unittest for one of the issues found. BUG=webrtc:4800 R=pbos@webrtc.org Review URL: https://codereview.webrtc.org/1522463002 . Cr-Commit-Position: refs/heads/master@{#10990}
2015-12-11 18:25:45 +01:00
]
Add fuzzing of VP8 QP parsing. BUG=webrtc:4771 R=asapersson@webrtc.org, kjellander@webrtc.org Review URL: https://codereview.webrtc.org/1469123004 . Cr-Commit-Position: refs/heads/master@{#10806}
2015-11-26 14:52:23 +01:00
}
Create fuzzer tests for audio decoders This change adds fuzzer tests for iLBC, iSAC fix and float, and Opus. The fuzzer function takes a random input vector and splits it into a number of payloads. The lengths of the payloads is also determined by the random vector. The payloads are decoded with the decoders. BUG=webrtc:5306 R=kjellander@webrtc.org, pbos@webrtc.org Review URL: https://codereview.webrtc.org/1499093002 . Cr-Commit-Position: refs/heads/master@{#10932}
2015-12-08 11:27:27 +01:00
Adding libFuzzer target for UlpFEC receiver. Bug: none Change-Id: I20e622455aee2f5aebad835e915d65f3475fbd17 Reviewed-on: https://webrtc-review.googlesource.com/14300 Commit-Queue: Mark Brand <markbrand@google.com> Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20384}
2017-10-20 16:23:23 +02:00
webrtc_fuzzer_test("ulpfec_receiver_fuzzer") {
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "ulpfec_receiver_fuzzer.cc" ]
Adding libFuzzer target for UlpFEC receiver. Bug: none Change-Id: I20e622455aee2f5aebad835e915d65f3475fbd17 Reviewed-on: https://webrtc-review.googlesource.com/14300 Commit-Queue: Mark Brand <markbrand@google.com> Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20384}
2017-10-20 16:23:23 +02:00
deps = [
Cleanup passing rtp packet to ulpfec receiver. Pass RtpPacket class of header and raw packet separately Bug: None Change-Id: Id6d107db0e3751ff3dec87321ce6f850da0ee33a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153740 Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Reviewed-by: Sam Zackrisson <saza@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29254}
2019-09-20 11:40:12 +02:00
":fuzz_data_helper",
Adding libFuzzer target for UlpFEC receiver. Bug: none Change-Id: I20e622455aee2f5aebad835e915d65f3475fbd17 Reviewed-on: https://webrtc-review.googlesource.com/14300 Commit-Queue: Mark Brand <markbrand@google.com> Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20384}
2017-10-20 16:23:23 +02:00
"../../modules/rtp_rtcp",
Stop using public_deps in modules/rtp_rtcp. TBR=phoglund@webrtc.org Bug: webrtc:8603 Change-Id: I86830df23db3f33a1a26098e639596bd3b86485a No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/29780 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21108}
2017-12-06 07:51:33 +01:00
"../../modules/rtp_rtcp:rtp_rtcp_format",
Adding libFuzzer target for UlpFEC receiver. Bug: none Change-Id: I20e622455aee2f5aebad835e915d65f3475fbd17 Reviewed-on: https://webrtc-review.googlesource.com/14300 Commit-Queue: Mark Brand <markbrand@google.com> Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20384}
2017-10-20 16:23:23 +02:00
"../../rtc_base:rtc_base_approved",
]
}
Add a fuzzer for FlexfecReceiver. Specifically set max_len to 2000, to simulate multi-packet insertions. BUG=webrtc:5654 NOTRY=true Review-Url: https://codereview.webrtc.org/2391263002 Cr-Commit-Position: refs/heads/master@{#14656}
2016-10-18 01:18:04 -07:00
webrtc_fuzzer_test("flexfec_receiver_fuzzer") {
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "flexfec_receiver_fuzzer.cc" ]
Add a fuzzer for FlexfecReceiver. Specifically set max_len to 2000, to simulate multi-packet insertions. BUG=webrtc:5654 NOTRY=true Review-Url: https://codereview.webrtc.org/2391263002 Cr-Commit-Position: refs/heads/master@{#14656}
2016-10-18 01:18:04 -07:00
deps = [
GN: Tighten up test target visibility + refactorings Make all rtc_source_test target that contains tests that are included in a test executable only be visible to the rtc_test target. Doing this exposed a couple of errors and dependency problems that were resolved. Having this could have prevented duplicated execution of tests like the case that was recently fixed by deadbeef@ in https://codereview.webrtc.org/2820263004 New targets: * //webrtc/modules/rtp_rtcp:fec_test_helper * //webrtc/modules/rtp_rtcp:mock_rtp_rtcp * //webrtc/modules/remote_bitrate_estimator:mock_remote_bitrate_observer The mock files and targets should probably be moved into webrtc/test in the future, but that's out of the scope of this CL. BUG=webrtc:5716 NOTRY=True Review-Url: https://codereview.webrtc.org/2828793003 Cr-Commit-Position: refs/heads/master@{#17863}
2017-04-25 04:04:50 -07:00
"../../modules/rtp_rtcp",
Stop using public_deps in modules/rtp_rtcp. TBR=phoglund@webrtc.org Bug: webrtc:8603 Change-Id: I86830df23db3f33a1a26098e639596bd3b86485a No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/29780 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21108}
2017-12-06 07:51:33 +01:00
"../../modules/rtp_rtcp:rtp_rtcp_format",
Remove remains of webrtc/base All downstream code have been updated to the new location. In PRESUBMIT.py: * Remove webrtc/rtc_base from CPP_BLACKLIST * Add webrtc/rtc_base to LEGACY_API_DIRS Fix some duplicated paths in webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn BUG=webrtc:7634 TBR=kwiberg@webrtc.org Review-Url: https://codereview.webrtc.org/2976293002 Cr-Commit-Position: refs/heads/master@{#19094}
2017-07-19 10:40:47 -07:00
"../../rtc_base:rtc_base_approved",
Add a fuzzer for FlexfecReceiver. Specifically set max_len to 2000, to simulate multi-packet insertions. BUG=webrtc:5654 NOTRY=true Review-Url: https://codereview.webrtc.org/2391263002 Cr-Commit-Position: refs/heads/master@{#14656}
2016-10-18 01:18:04 -07:00
]
}
Don't detect a new frame if a previous packet is used in a previous frame. In this CL: - Removed unused variable |last_seq_num_|. - Fixed bug where a new incomplete frame was detected as a complete frame. - Added fuzzer to video_coding::PacketBuffer. BUG=chromium:677101 Review-Url: https://codereview.webrtc.org/2613833003 Cr-Commit-Position: refs/heads/master@{#16003}
2017-01-11 02:01:56 -08:00
webrtc_fuzzer_test("packet_buffer_fuzzer") {
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "packet_buffer_fuzzer.cc" ]
Don't detect a new frame if a previous packet is used in a previous frame. In this CL: - Removed unused variable |last_seq_num_|. - Fixed bug where a new incomplete frame was detected as a complete frame. - Added fuzzer to video_coding::PacketBuffer. BUG=chromium:677101 Review-Url: https://codereview.webrtc.org/2613833003 Cr-Commit-Position: refs/heads/master@{#16003}
2017-01-11 02:01:56 -08:00
deps = [
Revert of Enabling 'gn check' on //webrtc/test. (patchset #3 id:90001 of https://codereview.webrtc.org/2815103005/ ) Reason for revert: Breaks Chromium because in Chromium we import WebRTC with rtc_include_tests=false (https://bugs.chromium.org/p/chromium/issues/detail?id=713179#c6). Chromium uses webrtc/test/fuzzers and this CL adds test dependencies to neteq_rtc_fuzzer. Original issue's description: > Reland of Enabling 'gn check' on //webrtc/test. (patchset #1 id:1 of https://codereview.webrtc.org/2817003002/ ) > > Reason for revert: > The original CL was breaking a downstream buildbot: https://build.chromium.org/p/client.webrtc/builders/Linux64%20Release%20%28Libfuzzer%29/builds/5429 > > This CL fixes some dependencies in: webrtc/test/fuzzers/BUILD.gn > (PS #2 and PS #3). > > BUG=webrtc:6828 > > Original issue's description: > > Revert of Enabling 'gn check' on //webrtc/test. (patchset #10 id:180001 of https://codereview.webrtc.org/2796363003/ ) > > > > Reason for revert: > > It is breaking a downstream bot. > > > > Original issue's description: > > > Enabling 'gn check' on //webrtc/test. > > > > > > BUG=webrtc:6828 > > > NOTRY=True > > > > > > Review-Url: https://codereview.webrtc.org/2796363003 > > > Cr-Commit-Position: refs/heads/master@{#17689} > > > Committed: https://chromium.googlesource.com/external/webrtc/+/b41445858e23fb757e5e10ac5631aa80e9e5eea9 > > > > TBR=kjellander@webrtc.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=webrtc:6828 > > > > Review-Url: https://codereview.webrtc.org/2817003002 > > Cr-Commit-Position: refs/heads/master@{#17690} > > Committed: https://chromium.googlesource.com/external/webrtc/+/8a24f47bad6eebb0fba10c3bbdb9556e43e19379 > > Review-Url: https://codereview.webrtc.org/2815103005 > Cr-Commit-Position: refs/heads/master@{#17758} > Committed: https://chromium.googlesource.com/external/webrtc/+/6f27633f47d0192f7cb04852be0988013e6c19dd TBR=kjellander@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2842533002 Cr-Commit-Position: refs/heads/master@{#17851}
2017-04-24 13:05:47 -07:00
"../../modules/video_coding/",
Reland of Enabling `gn check` on webrtc/test (patchset #1 id:1 of https://codereview.webrtc.org/2920763002/ ) Reason for revert: Fixing and re-landing. Original issue's description: > Revert of Enabling `gn check` on webrtc/test (patchset #9 id:160001 of https://codereview.webrtc.org/2911203002/ ) > > Reason for revert: > ERROR at //webrtc/test/testsupport/fileutils_unittest.cc:20:11: Can't include this header from here. > #include "webrtc/base/checks.h" > ^------------------- > The target: > //webrtc/test:fileutils_unittests > is including a file from the target: > //webrtc/base:rtc_base_approved > > It's usually best to depend directly on the destination target. > In some cases, the destination target is considered a subcomponent > of an intermediate target. In this case, the intermediate target > should depend publicly on the destination to forward the ability > to include headers. > > Dependency chain (there may also be others): > //webrtc/test:fileutils_unittests --> > //webrtc/test:fileutils --[private]--> > //webrtc/base:rtc_base_approved > > > Original issue's description: > > Enabling `gn check` on webrtc/test > > > > BUG=webrtc:6828 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/2911203002 > > Cr-Commit-Position: refs/heads/master@{#18372} > > Committed: https://chromium.googlesource.com/external/webrtc/+/db5bb404b0f42a7c0a43f882b34ba1325d8cbae2 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6828 > > Review-Url: https://codereview.webrtc.org/2920763002 > Cr-Commit-Position: refs/heads/master@{#18375} > Committed: https://chromium.googlesource.com/external/webrtc/+/1a6f143d077aec85d919c516b4f74ada8b8c21a8 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6828 Review-Url: https://codereview.webrtc.org/2918793002 Cr-Commit-Position: refs/heads/master@{#18376}
2017-06-01 04:47:20 -07:00
"../../system_wrappers",
Don't detect a new frame if a previous packet is used in a previous frame. In this CL: - Removed unused variable |last_seq_num_|. - Fixed bug where a new incomplete frame was detected as a complete frame. - Added fuzzer to video_coding::PacketBuffer. BUG=chromium:677101 Review-Url: https://codereview.webrtc.org/2613833003 Cr-Commit-Position: refs/heads/master@{#16003}
2017-01-11 02:01:56 -08:00
]
}
Simple RTCP receiver fuzzer. Doesn't utilize the clock or any callbacks out of the receiver but should still be useful to test input packet parsing. BUG=webrtc:4771 R=danilchap@webrtc.org Review URL: https://codereview.webrtc.org/1716143002 . Cr-Commit-Position: refs/heads/master@{#11717}
2016-02-23 11:35:30 +01:00
webrtc_fuzzer_test("rtcp_receiver_fuzzer") {
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "rtcp_receiver_fuzzer.cc" ]
Simple RTCP receiver fuzzer. Doesn't utilize the clock or any callbacks out of the receiver but should still be useful to test input packet parsing. BUG=webrtc:4771 R=danilchap@webrtc.org Review URL: https://codereview.webrtc.org/1716143002 . Cr-Commit-Position: refs/heads/master@{#11717}
2016-02-23 11:35:30 +01:00
deps = [
GN: Tighten up test target visibility + refactorings Make all rtc_source_test target that contains tests that are included in a test executable only be visible to the rtc_test target. Doing this exposed a couple of errors and dependency problems that were resolved. Having this could have prevented duplicated execution of tests like the case that was recently fixed by deadbeef@ in https://codereview.webrtc.org/2820263004 New targets: * //webrtc/modules/rtp_rtcp:fec_test_helper * //webrtc/modules/rtp_rtcp:mock_rtp_rtcp * //webrtc/modules/remote_bitrate_estimator:mock_remote_bitrate_observer The mock files and targets should probably be moved into webrtc/test in the future, but that's out of the scope of this CL. BUG=webrtc:5716 NOTRY=True Review-Url: https://codereview.webrtc.org/2828793003 Cr-Commit-Position: refs/heads/master@{#17863}
2017-04-25 04:04:50 -07:00
"../../modules/rtp_rtcp",
Fix fuzzer build failures on Windows Fix the following issues with fuzz targets when built on Windows: 1. Fix audio_processing_fuzzer by making types match in invocations of CheckedDivExact by explicitly casting to size_t. 2. Fix packet_buffer_fuzzer by including "frame_object.h" for declaration of RtpFrameObject. 3. Fix rtcp_receiver_fuzzer by including "tmmb_item.h" for declaration of TmmbItem. Bug: chromium:891867 Change-Id: Iddc338360ca37d5fc31488ec908eb4cdb5cc7b94 Reviewed-on: https://webrtc-review.googlesource.com/c/103844 Commit-Queue: Jonathan Metzman <metzman@chromium.org> Reviewed-by: Alex Loiko <aleloi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25028}
2018-10-05 10:38:13 -07:00
"../../modules/rtp_rtcp:rtp_rtcp_format",
Fix circular dependencies between optional, array_view, and rtc_base. This splits things out of rtc_base and makes dependencies explicit. Bug: webrtc:6828 Change-Id: Id521896c3c43595349021c857bec216e429a0c8d Reviewed-on: https://webrtc-review.googlesource.com/32780 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21264}
2017-12-13 16:05:42 +01:00
"../../rtc_base:checks",
Remove remains of webrtc/base All downstream code have been updated to the new location. In PRESUBMIT.py: * Remove webrtc/rtc_base from CPP_BLACKLIST * Add webrtc/rtc_base to LEGACY_API_DIRS Fix some duplicated paths in webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn BUG=webrtc:7634 TBR=kwiberg@webrtc.org Review-Url: https://codereview.webrtc.org/2976293002 Cr-Commit-Position: refs/heads/master@{#19094}
2017-07-19 10:40:47 -07:00
"../../rtc_base:rtc_base_approved",
Cleanup BUILD.gn files from imports like foo:foo Repalce all occurrences of foo:foo in deps with just foo in BUILD.gn files. Done with Sublime regex replace. Find: \b([-a-zA-Z0-9_]+):+\1\b In: *.gn Replace with: \1 Bug: None Change-Id: I40aba1b14face687a595b852ffe443cb20197611 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127899 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27225}
2019-03-21 13:35:10 +01:00
"../../system_wrappers",
Simple RTCP receiver fuzzer. Doesn't utilize the clock or any callbacks out of the receiver but should still be useful to test input packet parsing. BUG=webrtc:4771 R=danilchap@webrtc.org Review URL: https://codereview.webrtc.org/1716143002 . Cr-Commit-Position: refs/heads/master@{#11717}
2016-02-23 11:35:30 +01:00
]
Add fuzzer corpora. - RTP and RTCP corpora for existing fuzzers - STUN/SDP/pseudotcp for upcoming ones - STUN/SDP tokens as well NOTRY=true Review-Url: https://codereview.webrtc.org/2082943002 Cr-Commit-Position: refs/heads/master@{#13253}
2016-06-22 06:43:22 -07:00
seed_corpus = "corpora/rtcp-corpus"
Simple RTCP receiver fuzzer. Doesn't utilize the clock or any callbacks out of the receiver but should still be useful to test input packet parsing. BUG=webrtc:4771 R=danilchap@webrtc.org Review URL: https://codereview.webrtc.org/1716143002 . Cr-Commit-Position: refs/heads/master@{#11717}
2016-02-23 11:35:30 +01:00
}
RtpPacket class introduced. BUG=webrtc:1994, webrtc:5261 Review URL: https://codereview.webrtc.org/1841453004 Cr-Commit-Position: refs/heads/master@{#12444}
2016-04-20 05:25:10 -07:00
webrtc_fuzzer_test("rtp_packet_fuzzer") {
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "rtp_packet_fuzzer.cc" ]
Add absl_deps to webrtc_fuzzer_test. Bug: chromium:1046390 Change-Id: I531511dce156a10174c9ed80ccb2d5cd75ec33b0 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/177900 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31553}
2020-06-23 23:39:56 +02:00
deps = [ "../../modules/rtp_rtcp:rtp_rtcp_format" ]
absl_deps = [ "//third_party/abseil-cpp/absl/types:optional" ]
Add fuzzer corpora. - RTP and RTCP corpora for existing fuzzers - STUN/SDP/pseudotcp for upcoming ones - STUN/SDP tokens as well NOTRY=true Review-Url: https://codereview.webrtc.org/2082943002 Cr-Commit-Position: refs/heads/master@{#13253}
2016-06-22 06:43:22 -07:00
seed_corpus = "corpora/rtp-corpus"
RtpPacket class introduced. BUG=webrtc:1994, webrtc:5261 Review URL: https://codereview.webrtc.org/1841453004 Cr-Commit-Position: refs/heads/master@{#12444}
2016-04-20 05:25:10 -07:00
}
Fuzz RtpPacketizerAv1 Bug: webrtc:11042 Change-Id: Id44699395f6dee9cb3bde84c936573b65ad0d848 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161009 Reviewed-by: Sam Zackrisson <saza@webrtc.org> Reviewed-by: Philip Eliasson <philipel@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30007}
2019-11-29 10:08:33 +01:00
webrtc_fuzzer_test("rtp_packetizer_av1_fuzzer") {
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "rtp_packetizer_av1_fuzzer.cc" ]
Fuzz RtpPacketizerAv1 Bug: webrtc:11042 Change-Id: Id44699395f6dee9cb3bde84c936573b65ad0d848 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161009 Reviewed-by: Sam Zackrisson <saza@webrtc.org> Reviewed-by: Philip Eliasson <philipel@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30007}
2019-11-29 10:08:33 +01:00
deps = [
"../../api/video:video_frame_type",
"../../modules/rtp_rtcp:rtp_rtcp",
"../../modules/rtp_rtcp:rtp_rtcp_format",
"../../rtc_base:checks",
]
}
Add a libfuzzer for RtpHeaderParser. NOTRY=true Review-Url: https://codereview.webrtc.org/2062103002 Cr-Commit-Position: refs/heads/master@{#13271}
2016-06-23 03:50:39 -07:00
webrtc_fuzzer_test("rtp_header_fuzzer") {
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "rtp_header_fuzzer.cc" ]
Add a libfuzzer for RtpHeaderParser. NOTRY=true Review-Url: https://codereview.webrtc.org/2062103002 Cr-Commit-Position: refs/heads/master@{#13271}
2016-06-23 03:50:39 -07:00
deps = [
GN: Tighten up test target visibility + refactorings Make all rtc_source_test target that contains tests that are included in a test executable only be visible to the rtc_test target. Doing this exposed a couple of errors and dependency problems that were resolved. Having this could have prevented duplicated execution of tests like the case that was recently fixed by deadbeef@ in https://codereview.webrtc.org/2820263004 New targets: * //webrtc/modules/rtp_rtcp:fec_test_helper * //webrtc/modules/rtp_rtcp:mock_rtp_rtcp * //webrtc/modules/remote_bitrate_estimator:mock_remote_bitrate_observer The mock files and targets should probably be moved into webrtc/test in the future, but that's out of the scope of this CL. BUG=webrtc:5716 NOTRY=True Review-Url: https://codereview.webrtc.org/2828793003 Cr-Commit-Position: refs/heads/master@{#17863}
2017-04-25 04:04:50 -07:00
"../../modules/rtp_rtcp",
Stop using public_deps in modules/rtp_rtcp. TBR=phoglund@webrtc.org Bug: webrtc:8603 Change-Id: I86830df23db3f33a1a26098e639596bd3b86485a No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/29780 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21108}
2017-12-06 07:51:33 +01:00
"../../modules/rtp_rtcp:rtp_rtcp_format",
Add a libfuzzer for RtpHeaderParser. NOTRY=true Review-Url: https://codereview.webrtc.org/2062103002 Cr-Commit-Position: refs/heads/master@{#13271}
2016-06-23 03:50:39 -07:00
]
}
Add a CongestionController fuzzer. BUG= Review-Url: https://codereview.webrtc.org/2157783002 Cr-Commit-Position: refs/heads/master@{#13497}
2016-07-18 09:26:06 -07:00
webrtc_fuzzer_test("congestion_controller_feedback_fuzzer") {
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "congestion_controller_feedback_fuzzer.cc" ]
Add a CongestionController fuzzer. BUG= Review-Url: https://codereview.webrtc.org/2157783002 Cr-Commit-Position: refs/heads/master@{#13497}
2016-07-18 09:26:06 -07:00
deps = [
Delete old CongestionController class Replaced by ReceiveSideCongestionController and SendSideCongestionController. Bug: webrtc:6847 Change-Id: I79caa019c883f8f716d0dd52d56bbdc2f8df0ded Reviewed-on: https://chromium-review.googlesource.com/616763 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Stefan Holmer <stefan@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#19423}
2017-08-21 10:45:07 +02:00
"../../modules/congestion_controller",
"../../modules/pacing",
Cleanup BUILD.gn files from imports like foo:foo Repalce all occurrences of foo:foo in deps with just foo in BUILD.gn files. Done with Sublime regex replace. Find: \b([-a-zA-Z0-9_]+):+\1\b In: *.gn Replace with: \1 Bug: None Change-Id: I40aba1b14face687a595b852ffe443cb20197611 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127899 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27225}
2019-03-21 13:35:10 +01:00
"../../modules/remote_bitrate_estimator",
Stop using public_deps in modules/rtp_rtcp. TBR=phoglund@webrtc.org Bug: webrtc:8603 Change-Id: I86830df23db3f33a1a26098e639596bd3b86485a No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/29780 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21108}
2017-12-06 07:51:33 +01:00
"../../modules/rtp_rtcp:rtp_rtcp_format",
Add a CongestionController fuzzer. BUG= Review-Url: https://codereview.webrtc.org/2157783002 Cr-Commit-Position: refs/heads/master@{#13497}
2016-07-18 09:26:06 -07:00
]
Remove REMB throttling funcionality from PacketRouter This removes PacketRouter inheritance from RemoteBitrateObserver and TransportFeedbackSenderInterface. Call binds methods for sending REMB and transport feedback messages from RemoteCongestionController to PacketRouter. This is needed until the RTCPTranseiver is used instead of the RTP modules. Bug: webrtc:12693 Change-Id: I7088de497cd6d1e15c98788ff3e6b0a2c8897ea8 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/215965 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Commit-Queue: Per Kjellander <perkj@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33993}
2021-05-12 09:02:43 +02:00
absl_deps = [ "//third_party/abseil-cpp/absl/functional:bind_front" ]
Add a CongestionController fuzzer. BUG= Review-Url: https://codereview.webrtc.org/2157783002 Cr-Commit-Position: refs/heads/master@{#13497}
2016-07-18 09:26:06 -07:00
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("audio_decoder_fuzzer") {
Opus Encoder fuzzer: separate target for FuzzAudioEncoder Move FuzzAudioEncoder to a separate target to make it available for other encoders. Bug: webrtc:11388 Change-Id: I8b9a0f810791880eedb129b55eb33f154790e48f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169364 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30634}
2020-02-27 16:32:56 +01:00
testonly = true
Create fuzzer tests for audio decoders This change adds fuzzer tests for iLBC, iSAC fix and float, and Opus. The fuzzer function takes a random input vector and splits it into a number of payloads. The lengths of the payloads is also determined by the random vector. The payloads are decoded with the decoders. BUG=webrtc:5306 R=kjellander@webrtc.org, pbos@webrtc.org Review URL: https://codereview.webrtc.org/1499093002 . Cr-Commit-Position: refs/heads/master@{#10932}
2015-12-08 11:27:27 +01:00
sources = [
"audio_decoder_fuzzer.cc",
"audio_decoder_fuzzer.h",
]
Reland of Enabling `gn check` on webrtc/test (patchset #1 id:1 of https://codereview.webrtc.org/2920763002/ ) Reason for revert: Fixing and re-landing. Original issue's description: > Revert of Enabling `gn check` on webrtc/test (patchset #9 id:160001 of https://codereview.webrtc.org/2911203002/ ) > > Reason for revert: > ERROR at //webrtc/test/testsupport/fileutils_unittest.cc:20:11: Can't include this header from here. > #include "webrtc/base/checks.h" > ^------------------- > The target: > //webrtc/test:fileutils_unittests > is including a file from the target: > //webrtc/base:rtc_base_approved > > It's usually best to depend directly on the destination target. > In some cases, the destination target is considered a subcomponent > of an intermediate target. In this case, the intermediate target > should depend publicly on the destination to forward the ability > to include headers. > > Dependency chain (there may also be others): > //webrtc/test:fileutils_unittests --> > //webrtc/test:fileutils --[private]--> > //webrtc/base:rtc_base_approved > > > Original issue's description: > > Enabling `gn check` on webrtc/test > > > > BUG=webrtc:6828 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/2911203002 > > Cr-Commit-Position: refs/heads/master@{#18372} > > Committed: https://chromium.googlesource.com/external/webrtc/+/db5bb404b0f42a7c0a43f882b34ba1325d8cbae2 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6828 > > Review-Url: https://codereview.webrtc.org/2920763002 > Cr-Commit-Position: refs/heads/master@{#18375} > Committed: https://chromium.googlesource.com/external/webrtc/+/1a6f143d077aec85d919c516b4f74ada8b8c21a8 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6828 Review-Url: https://codereview.webrtc.org/2918793002 Cr-Commit-Position: refs/heads/master@{#18376}
2017-06-01 04:47:20 -07:00
deps = [
"../../api/audio_codecs:audio_codecs_api",
Stop using public_deps in modules/rtp_rtcp. TBR=phoglund@webrtc.org Bug: webrtc:8603 Change-Id: I86830df23db3f33a1a26098e639596bd3b86485a No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/29780 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21108}
2017-12-06 07:51:33 +01:00
"../../modules/rtp_rtcp:rtp_rtcp_format",
Fix circular dependencies between optional, array_view, and rtc_base. This splits things out of rtc_base and makes dependencies explicit. Bug: webrtc:6828 Change-Id: Id521896c3c43595349021c857bec216e429a0c8d Reviewed-on: https://webrtc-review.googlesource.com/32780 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21264}
2017-12-13 16:05:42 +01:00
"../../rtc_base:checks",
Remove remains of webrtc/base All downstream code have been updated to the new location. In PRESUBMIT.py: * Remove webrtc/rtc_base from CPP_BLACKLIST * Add webrtc/rtc_base to LEGACY_API_DIRS Fix some duplicated paths in webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn BUG=webrtc:7634 TBR=kwiberg@webrtc.org Review-Url: https://codereview.webrtc.org/2976293002 Cr-Commit-Position: refs/heads/master@{#19094}
2017-07-19 10:40:47 -07:00
"../../rtc_base:rtc_base_approved",
Reland of Enabling `gn check` on webrtc/test (patchset #1 id:1 of https://codereview.webrtc.org/2920763002/ ) Reason for revert: Fixing and re-landing. Original issue's description: > Revert of Enabling `gn check` on webrtc/test (patchset #9 id:160001 of https://codereview.webrtc.org/2911203002/ ) > > Reason for revert: > ERROR at //webrtc/test/testsupport/fileutils_unittest.cc:20:11: Can't include this header from here. > #include "webrtc/base/checks.h" > ^------------------- > The target: > //webrtc/test:fileutils_unittests > is including a file from the target: > //webrtc/base:rtc_base_approved > > It's usually best to depend directly on the destination target. > In some cases, the destination target is considered a subcomponent > of an intermediate target. In this case, the intermediate target > should depend publicly on the destination to forward the ability > to include headers. > > Dependency chain (there may also be others): > //webrtc/test:fileutils_unittests --> > //webrtc/test:fileutils --[private]--> > //webrtc/base:rtc_base_approved > > > Original issue's description: > > Enabling `gn check` on webrtc/test > > > > BUG=webrtc:6828 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/2911203002 > > Cr-Commit-Position: refs/heads/master@{#18372} > > Committed: https://chromium.googlesource.com/external/webrtc/+/db5bb404b0f42a7c0a43f882b34ba1325d8cbae2 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6828 > > Review-Url: https://codereview.webrtc.org/2920763002 > Cr-Commit-Position: refs/heads/master@{#18375} > Committed: https://chromium.googlesource.com/external/webrtc/+/1a6f143d077aec85d919c516b4f74ada8b8c21a8 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6828 Review-Url: https://codereview.webrtc.org/2918793002 Cr-Commit-Position: refs/heads/master@{#18376}
2017-06-01 04:47:20 -07:00
]
Use absl_deps in order to preapre to the Abseil component build release. Bug: webrtc:1046390 Change-Id: Ia35545599de23b1a2c2d8be2d53469af7ac16f1d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176502 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31463}
2020-06-05 14:30:41 +02:00
absl_deps = [ "//third_party/abseil-cpp/absl/types:optional" ]
Create fuzzer tests for audio decoders This change adds fuzzer tests for iLBC, iSAC fix and float, and Opus. The fuzzer function takes a random input vector and splits it into a number of payloads. The lengths of the payloads is also determined by the random vector. The payloads are decoded with the decoders. BUG=webrtc:5306 R=kjellander@webrtc.org, pbos@webrtc.org Review URL: https://codereview.webrtc.org/1499093002 . Cr-Commit-Position: refs/heads/master@{#10932}
2015-12-08 11:27:27 +01:00
}
Reland of Base webrtc fuzzers on a template. (patchset #1 id:1 of https://codereview.webrtc.org/1528043002/ ) Reason for revert: Found missing public_configs that broke Chromium libfuzzer build. Original issue's description: > Revert of Base webrtc fuzzers on a template. (patchset #1 id:1 of https://codereview.webrtc.org/1524993002/ ) > > Reason for revert: > Suspect this is breaking the build: > https://build.chromium.org/p/chromium.fyi/builders/Libfuzzer%20Upload%20Linux/builds/1576/steps/compile/logs/stdio > > Original issue's description: > > Base webrtc fuzzers on a template. > > > > Removes noisy dependencies on webrtc_fuzzer_main and removal of > > find_bad_constructs, removes 1-6 lines of gn per fuzzer target. > > > > BUG=webrtc:4771 > > R=kjellander@webrtc.org > > > > Committed: https://crrev.com/5ea3da2cbbb0710f9617fb0627c0c4258437b09f > > Cr-Commit-Position: refs/heads/master@{#11022} > > TBR=kjellander@webrtc.org,pbos@webrtc.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:4771 > > Committed: https://crrev.com/5e0218c66e0686dd00719f1e53f844efa94c9f42 > Cr-Commit-Position: refs/heads/master@{#11032} TBR=kjellander@webrtc.org,tommi@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4771 Review URL: https://codereview.webrtc.org/1522003005 . Cr-Commit-Position: refs/heads/master@{#11035}
2015-12-15 21:57:52 +01:00
webrtc_fuzzer_test("audio_decoder_ilbc_fuzzer") {
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "audio_decoder_ilbc_fuzzer.cc" ]
Create fuzzer tests for audio decoders This change adds fuzzer tests for iLBC, iSAC fix and float, and Opus. The fuzzer function takes a random input vector and splits it into a number of payloads. The lengths of the payloads is also determined by the random vector. The payloads are decoded with the decoders. BUG=webrtc:5306 R=kjellander@webrtc.org, pbos@webrtc.org Review URL: https://codereview.webrtc.org/1499093002 . Cr-Commit-Position: refs/heads/master@{#10932}
2015-12-08 11:27:27 +01:00
deps = [
":audio_decoder_fuzzer",
"../../modules/audio_coding:ilbc",
]
}
Reland of Base webrtc fuzzers on a template. (patchset #1 id:1 of https://codereview.webrtc.org/1528043002/ ) Reason for revert: Found missing public_configs that broke Chromium libfuzzer build. Original issue's description: > Revert of Base webrtc fuzzers on a template. (patchset #1 id:1 of https://codereview.webrtc.org/1524993002/ ) > > Reason for revert: > Suspect this is breaking the build: > https://build.chromium.org/p/chromium.fyi/builders/Libfuzzer%20Upload%20Linux/builds/1576/steps/compile/logs/stdio > > Original issue's description: > > Base webrtc fuzzers on a template. > > > > Removes noisy dependencies on webrtc_fuzzer_main and removal of > > find_bad_constructs, removes 1-6 lines of gn per fuzzer target. > > > > BUG=webrtc:4771 > > R=kjellander@webrtc.org > > > > Committed: https://crrev.com/5ea3da2cbbb0710f9617fb0627c0c4258437b09f > > Cr-Commit-Position: refs/heads/master@{#11022} > > TBR=kjellander@webrtc.org,pbos@webrtc.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:4771 > > Committed: https://crrev.com/5e0218c66e0686dd00719f1e53f844efa94c9f42 > Cr-Commit-Position: refs/heads/master@{#11032} TBR=kjellander@webrtc.org,tommi@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4771 Review URL: https://codereview.webrtc.org/1522003005 . Cr-Commit-Position: refs/heads/master@{#11035}
2015-12-15 21:57:52 +01:00
webrtc_fuzzer_test("audio_decoder_isac_fuzzer") {
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "audio_decoder_isac_fuzzer.cc" ]
Create fuzzer tests for audio decoders This change adds fuzzer tests for iLBC, iSAC fix and float, and Opus. The fuzzer function takes a random input vector and splits it into a number of payloads. The lengths of the payloads is also determined by the random vector. The payloads are decoded with the decoders. BUG=webrtc:5306 R=kjellander@webrtc.org, pbos@webrtc.org Review URL: https://codereview.webrtc.org/1499093002 . Cr-Commit-Position: refs/heads/master@{#10932}
2015-12-08 11:27:27 +01:00
deps = [
":audio_decoder_fuzzer",
"../../modules/audio_coding:isac",
]
}
Reland of Base webrtc fuzzers on a template. (patchset #1 id:1 of https://codereview.webrtc.org/1528043002/ ) Reason for revert: Found missing public_configs that broke Chromium libfuzzer build. Original issue's description: > Revert of Base webrtc fuzzers on a template. (patchset #1 id:1 of https://codereview.webrtc.org/1524993002/ ) > > Reason for revert: > Suspect this is breaking the build: > https://build.chromium.org/p/chromium.fyi/builders/Libfuzzer%20Upload%20Linux/builds/1576/steps/compile/logs/stdio > > Original issue's description: > > Base webrtc fuzzers on a template. > > > > Removes noisy dependencies on webrtc_fuzzer_main and removal of > > find_bad_constructs, removes 1-6 lines of gn per fuzzer target. > > > > BUG=webrtc:4771 > > R=kjellander@webrtc.org > > > > Committed: https://crrev.com/5ea3da2cbbb0710f9617fb0627c0c4258437b09f > > Cr-Commit-Position: refs/heads/master@{#11022} > > TBR=kjellander@webrtc.org,pbos@webrtc.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:4771 > > Committed: https://crrev.com/5e0218c66e0686dd00719f1e53f844efa94c9f42 > Cr-Commit-Position: refs/heads/master@{#11032} TBR=kjellander@webrtc.org,tommi@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4771 Review URL: https://codereview.webrtc.org/1522003005 . Cr-Commit-Position: refs/heads/master@{#11035}
2015-12-15 21:57:52 +01:00
webrtc_fuzzer_test("audio_decoder_isacfix_fuzzer") {
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "audio_decoder_isacfix_fuzzer.cc" ]
Create fuzzer tests for audio decoders This change adds fuzzer tests for iLBC, iSAC fix and float, and Opus. The fuzzer function takes a random input vector and splits it into a number of payloads. The lengths of the payloads is also determined by the random vector. The payloads are decoded with the decoders. BUG=webrtc:5306 R=kjellander@webrtc.org, pbos@webrtc.org Review URL: https://codereview.webrtc.org/1499093002 . Cr-Commit-Position: refs/heads/master@{#10932}
2015-12-08 11:27:27 +01:00
deps = [
":audio_decoder_fuzzer",
"../../modules/audio_coding:isac_fix",
]
}
Reland of Base webrtc fuzzers on a template. (patchset #1 id:1 of https://codereview.webrtc.org/1528043002/ ) Reason for revert: Found missing public_configs that broke Chromium libfuzzer build. Original issue's description: > Revert of Base webrtc fuzzers on a template. (patchset #1 id:1 of https://codereview.webrtc.org/1524993002/ ) > > Reason for revert: > Suspect this is breaking the build: > https://build.chromium.org/p/chromium.fyi/builders/Libfuzzer%20Upload%20Linux/builds/1576/steps/compile/logs/stdio > > Original issue's description: > > Base webrtc fuzzers on a template. > > > > Removes noisy dependencies on webrtc_fuzzer_main and removal of > > find_bad_constructs, removes 1-6 lines of gn per fuzzer target. > > > > BUG=webrtc:4771 > > R=kjellander@webrtc.org > > > > Committed: https://crrev.com/5ea3da2cbbb0710f9617fb0627c0c4258437b09f > > Cr-Commit-Position: refs/heads/master@{#11022} > > TBR=kjellander@webrtc.org,pbos@webrtc.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:4771 > > Committed: https://crrev.com/5e0218c66e0686dd00719f1e53f844efa94c9f42 > Cr-Commit-Position: refs/heads/master@{#11032} TBR=kjellander@webrtc.org,tommi@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4771 Review URL: https://codereview.webrtc.org/1522003005 . Cr-Commit-Position: refs/heads/master@{#11035}
2015-12-15 21:57:52 +01:00
webrtc_fuzzer_test("audio_decoder_opus_fuzzer") {
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "audio_decoder_opus_fuzzer.cc" ]
Create fuzzer tests for audio decoders This change adds fuzzer tests for iLBC, iSAC fix and float, and Opus. The fuzzer function takes a random input vector and splits it into a number of payloads. The lengths of the payloads is also determined by the random vector. The payloads are decoded with the decoders. BUG=webrtc:5306 R=kjellander@webrtc.org, pbos@webrtc.org Review URL: https://codereview.webrtc.org/1499093002 . Cr-Commit-Position: refs/heads/master@{#10932}
2015-12-08 11:27:27 +01:00
deps = [
":audio_decoder_fuzzer",
"../../modules/audio_coding:webrtc_opus",
]
}
Fuzzer tests for AudioDecoder's DecodeRedundant and IncomingPacket This CL adds new fuzzer tests for the DecodeRedundant and IncomingPacket methods of AudioDecoder. In practice, only Opus has DecodeRedundant, and only iSAC has IncomingPacket. Did some minor work to generalize the helper function reading values from the fuzzed input. BUG=webrtc:5306 R=pbos@webrtc.org NOTRY=true Review URL: https://codereview.webrtc.org/1607173003 Cr-Commit-Position: refs/heads/master@{#11533}
2016-02-09 00:00:23 -08:00
webrtc_fuzzer_test("audio_decoder_opus_redundant_fuzzer") {
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "audio_decoder_opus_redundant_fuzzer.cc" ]
Fuzzer tests for AudioDecoder's DecodeRedundant and IncomingPacket This CL adds new fuzzer tests for the DecodeRedundant and IncomingPacket methods of AudioDecoder. In practice, only Opus has DecodeRedundant, and only iSAC has IncomingPacket. Did some minor work to generalize the helper function reading values from the fuzzed input. BUG=webrtc:5306 R=pbos@webrtc.org NOTRY=true Review URL: https://codereview.webrtc.org/1607173003 Cr-Commit-Position: refs/heads/master@{#11533}
2016-02-09 00:00:23 -08:00
deps = [
":audio_decoder_fuzzer",
"../../modules/audio_coding:webrtc_opus",
]
}
Add fuzzer for TURN unwrap. This is called on received network packets if dump_rtp_packets_ is on. NOTRY=true Review-Url: https://codereview.webrtc.org/2126463002 Cr-Commit-Position: refs/heads/master@{#13394}
2016-07-06 05:59:23 -07:00
Decoder for multistream Opus. See https://webrtc-review.googlesource.com/c/src/+/121764 for the overall vision. This CL adds a multistream Opus decoder. It's a new code-path to not interfere with the standard Opus decoder. We introduce new SDP syntax, which uses terminology of RFC 7845. We also set up the decoder side to parse it. The encoder part will come in a later CL. E.g. this is the new SDP syntax for 6.1 surround sound: "multiopus/48000/6 channel_mapping=0,4,1,2,3,5 num_streams=4 coupled_streams=2" Bug: webrtc:8649 Change-Id: Ifbc584cbb6d07aed373f223512a20d6d72cec5ec Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/129768 Commit-Queue: Alex Loiko <aleloi@webrtc.org> Reviewed-by: Oskar Sundbom <ossu@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27493}
2019-04-08 17:19:41 +02:00
webrtc_fuzzer_test("audio_decoder_multiopus_fuzzer") {
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "audio_decoder_multistream_opus_fuzzer.cc" ]
Decoder for multistream Opus. See https://webrtc-review.googlesource.com/c/src/+/121764 for the overall vision. This CL adds a multistream Opus decoder. It's a new code-path to not interfere with the standard Opus decoder. We introduce new SDP syntax, which uses terminology of RFC 7845. We also set up the decoder side to parse it. The encoder part will come in a later CL. E.g. this is the new SDP syntax for 6.1 surround sound: "multiopus/48000/6 channel_mapping=0,4,1,2,3,5 num_streams=4 coupled_streams=2" Bug: webrtc:8649 Change-Id: Ifbc584cbb6d07aed373f223512a20d6d72cec5ec Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/129768 Commit-Queue: Alex Loiko <aleloi@webrtc.org> Reviewed-by: Oskar Sundbom <ossu@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27493}
2019-04-08 17:19:41 +02:00
deps = [
":audio_decoder_fuzzer",
"../../api/audio_codecs/opus:audio_decoder_multiopus",
Encoder side of Multistream Opus. Follows https://webrtc-review.googlesource.com/c/src/+/129768 closely. Adds an ENCODER and sets it up to parse SDP config for multistream opus. E.g. this is the new SDP syntax for 6.1 surround sound: "multiopus/48000/6 channel_mapping=0,4,1,2,3,5 num_streams=4 coupled_streams=2" Bug: webrtc:8649 Change-Id: I3fc341e76f5c41dab0243cf65f6461e4c3d9d67d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132001 Commit-Queue: Alex Loiko <aleloi@webrtc.org> Reviewed-by: Oskar Sundbom <ossu@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27775}
2019-04-25 15:09:32 +02:00
"../../api/audio_codecs/opus:audio_decoder_opus_config",
Decoder for multistream Opus. See https://webrtc-review.googlesource.com/c/src/+/121764 for the overall vision. This CL adds a multistream Opus decoder. It's a new code-path to not interfere with the standard Opus decoder. We introduce new SDP syntax, which uses terminology of RFC 7845. We also set up the decoder side to parse it. The encoder part will come in a later CL. E.g. this is the new SDP syntax for 6.1 surround sound: "multiopus/48000/6 channel_mapping=0,4,1,2,3,5 num_streams=4 coupled_streams=2" Bug: webrtc:8649 Change-Id: Ifbc584cbb6d07aed373f223512a20d6d72cec5ec Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/129768 Commit-Queue: Alex Loiko <aleloi@webrtc.org> Reviewed-by: Oskar Sundbom <ossu@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27493}
2019-04-08 17:19:41 +02:00
]
}
Opus Encoder fuzzer: separate target for FuzzAudioEncoder Move FuzzAudioEncoder to a separate target to make it available for other encoders. Bug: webrtc:11388 Change-Id: I8b9a0f810791880eedb129b55eb33f154790e48f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169364 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30634}
2020-02-27 16:32:56 +01:00
rtc_library("audio_encoder_fuzzer") {
testonly = true
sources = [
"audio_encoder_fuzzer.cc",
"audio_encoder_fuzzer.h",
]
deps = [
":fuzz_data_helper",
"../../api:array_view",
"../../api/audio_codecs:audio_codecs_api",
"../../rtc_base:checks",
"../../rtc_base:rtc_base_approved",
]
}
Create a fuzzer for the Opus encoder The fuzzer is very simple. It only considers the default encoder configuration at this point. Bug: chromium:826914 Change-Id: Ifa248a1dba80efb231807750e40082ec5580636a Reviewed-on: https://webrtc-review.googlesource.com/75261 Commit-Queue: Henrik Lundin <henrik.lundin@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23192}
2018-05-09 14:56:08 +02:00
webrtc_fuzzer_test("audio_encoder_opus_fuzzer") {
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "audio_encoder_opus_fuzzer.cc" ]
Create a fuzzer for the Opus encoder The fuzzer is very simple. It only considers the default encoder configuration at this point. Bug: chromium:826914 Change-Id: Ifa248a1dba80efb231807750e40082ec5580636a Reviewed-on: https://webrtc-review.googlesource.com/75261 Commit-Queue: Henrik Lundin <henrik.lundin@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23192}
2018-05-09 14:56:08 +02:00
deps = [
Opus Encoder fuzzer: separate target for FuzzAudioEncoder Move FuzzAudioEncoder to a separate target to make it available for other encoders. Bug: webrtc:11388 Change-Id: I8b9a0f810791880eedb129b55eb33f154790e48f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169364 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30634}
2020-02-27 16:32:56 +01:00
":audio_encoder_fuzzer",
Create a fuzzer for the Opus encoder The fuzzer is very simple. It only considers the default encoder configuration at this point. Bug: chromium:826914 Change-Id: Ifa248a1dba80efb231807750e40082ec5580636a Reviewed-on: https://webrtc-review.googlesource.com/75261 Commit-Queue: Henrik Lundin <henrik.lundin@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23192}
2018-05-09 14:56:08 +02:00
"../../api/audio_codecs/opus:audio_encoder_opus",
"../../rtc_base:checks",
]
}
iSAC fixed|float encoder fuzzers Bug: webrtc:11388 Change-Id: I5910492ef9471aa193aa50ef5e14b4b66cb6542a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169365 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30635}
2020-02-27 16:33:29 +01:00
webrtc_fuzzer_test("audio_encoder_isac_fixed_fuzzer") {
fuzzers: fix isax typo TBR=saza@webrtc.org BUG=none Change-Id: If565fbcca92f162b9483eb6abeaf3c374998c2df Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176123 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Sam Zackrisson <saza@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31355}
2020-05-26 12:58:54 +02:00
sources = [ "audio_encoder_isac_fixed_fuzzer.cc" ]
iSAC fixed|float encoder fuzzers Bug: webrtc:11388 Change-Id: I5910492ef9471aa193aa50ef5e14b4b66cb6542a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169365 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30635}
2020-02-27 16:33:29 +01:00
deps = [
":audio_encoder_fuzzer",
"../../api/audio_codecs/isac:audio_encoder_isac_fix",
"../../rtc_base:checks",
]
}
webrtc_fuzzer_test("audio_encoder_isac_float_fuzzer") {
fuzzers: fix isax typo TBR=saza@webrtc.org BUG=none Change-Id: If565fbcca92f162b9483eb6abeaf3c374998c2df Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176123 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Sam Zackrisson <saza@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31355}
2020-05-26 12:58:54 +02:00
sources = [ "audio_encoder_isac_float_fuzzer.cc" ]
iSAC fixed|float encoder fuzzers Bug: webrtc:11388 Change-Id: I5910492ef9471aa193aa50ef5e14b4b66cb6542a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169365 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30635}
2020-02-27 16:33:29 +01:00
deps = [
":audio_encoder_fuzzer",
"../../api/audio_codecs/isac:audio_encoder_isac_float",
"../../rtc_base:checks",
]
}
Enable turn, sdp, pseudotcp and stun parse/validator fuzzers. These were blocked on GN work; should be good to go now. If they break the WebRTC FYI bots, there's more work to be done. Verified they build locally at least. Setting no-try because all bots went green except broken android bots. BUG=6368 NOTRY=true Review-Url: https://codereview.webrtc.org/2342843002 Cr-Commit-Position: refs/heads/master@{#14256}
2016-09-16 05:05:39 -07:00
webrtc_fuzzer_test("turn_unwrap_fuzzer") {
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "turn_unwrap_fuzzer.cc" ]
Enable turn, sdp, pseudotcp and stun parse/validator fuzzers. These were blocked on GN work; should be good to go now. If they break the WebRTC FYI bots, there's more work to be done. Verified they build locally at least. Setting no-try because all bots went green except broken android bots. BUG=6368 NOTRY=true Review-Url: https://codereview.webrtc.org/2342843002 Cr-Commit-Position: refs/heads/master@{#14256}
2016-09-16 05:05:39 -07:00
deps = [
Cleanup BUILD.gn files from imports like foo:foo Repalce all occurrences of foo:foo in deps with just foo in BUILD.gn files. Done with Sublime regex replace. Find: \b([-a-zA-Z0-9_]+):+\1\b In: *.gn Replace with: \1 Bug: None Change-Id: I40aba1b14face687a595b852ffe443cb20197611 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127899 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27225}
2019-03-21 13:35:10 +01:00
"../../media",
Stop using public_deps in media/. Bug: webrtc:8603 Change-Id: I7a6dad323ac298dc784feb5aa1fdc2ae5876cb5c No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/33180 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21591}
2018-01-11 17:07:30 +01:00
"../../media:rtc_media_base",
Enable turn, sdp, pseudotcp and stun parse/validator fuzzers. These were blocked on GN work; should be good to go now. If they break the WebRTC FYI bots, there's more work to be done. Verified they build locally at least. Setting no-try because all bots went green except broken android bots. BUG=6368 NOTRY=true Review-Url: https://codereview.webrtc.org/2342843002 Cr-Commit-Position: refs/heads/master@{#14256}
2016-09-16 05:05:39 -07:00
]
}
Reland of https://codereview.webrtc.org/2044523002. Landing these in WebRTC under a guard so they don't build in Chromium. The guard can be removed once Chromium has migrated to use the new GN targets. BUG=webrtc:6081 NOTRY=true Review-Url: https://codereview.webrtc.org/2117183005 Cr-Commit-Position: refs/heads/master@{#13397}
2016-07-06 08:02:00 -07:00
Relanding "Setting up an RTP input fuzzer for NetEq" The original CL (https://codereview.webrtc.org/2315633002) was reverted since the fuzzer depended on gflags and files in the resources folder; neither of this is allowed for a fuzzer test in Chromium. This new version streamlines the dependencies, and changes the test to generate a sinusoid input audio signal instead of reading from a file. Original commit message: This CL introduces a new fuzzer target neteq_rtp_fuzzer that manipulates the RTP header fields before inserting the packets into NetEq. A few helper classes are also introduced. BUG=webrtc:5447 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_chromium_rel_ng;master.tryserver.chromium.android:android_compile_dbg,linux_android_rel_ng;master.tryserver.chromium.linux:linux_chromium_rel_ng;master.tryserver.chromium.mac:mac_chromium_rel_ng,ios-device Review-Url: https://codereview.webrtc.org/2384423002 Cr-Commit-Position: refs/heads/master@{#14523}
2016-10-05 02:27:42 -07:00
webrtc_fuzzer_test("neteq_rtp_fuzzer") {
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "neteq_rtp_fuzzer.cc" ]
Relanding "Setting up an RTP input fuzzer for NetEq" The original CL (https://codereview.webrtc.org/2315633002) was reverted since the fuzzer depended on gflags and files in the resources folder; neither of this is allowed for a fuzzer test in Chromium. This new version streamlines the dependencies, and changes the test to generate a sinusoid input audio signal instead of reading from a file. Original commit message: This CL introduces a new fuzzer target neteq_rtp_fuzzer that manipulates the RTP header fields before inserting the packets into NetEq. A few helper classes are also introduced. BUG=webrtc:5447 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_chromium_rel_ng;master.tryserver.chromium.android:android_compile_dbg,linux_android_rel_ng;master.tryserver.chromium.linux:linux_chromium_rel_ng;master.tryserver.chromium.mac:mac_chromium_rel_ng,ios-device Review-Url: https://codereview.webrtc.org/2384423002 Cr-Commit-Position: refs/heads/master@{#14523}
2016-10-05 02:27:42 -07:00
deps = [
Move array_view.h to webrtc/api/ We use ArrayView in our public API, so its header should be in webrtc/api/. BUG=none Review-Url: https://codereview.webrtc.org/3007763002 Cr-Commit-Position: refs/heads/master@{#19658}
2017-09-04 05:43:17 -07:00
"../../api:array_view",
Reland "Add AudioDecoderFactory to NetEqTest constructor." This is a reland of daa970f33e1923c5651a4a63c18e3d5361d0a795 Original change's description: > Add AudioDecoderFactory to NetEqTest constructor. > > Update EventLogAnalyzer to not depend on builtin audio decoders. > > Bug: webrtc:8396, webrtc:10080 > Change-Id: Ie02ed9cda6d4f11bfdf2e65eb6482283b7520738 > Reviewed-on: https://webrtc-review.googlesource.com/c/114301 > Reviewed-by: Alex Loiko <aleloi@webrtc.org> > Reviewed-by: Ivo Creusen <ivoc@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Commit-Queue: Niels Moller <nisse@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#26026} Tbr: kwiberg@webrtc.org Bug: webrtc:8396, webrtc:10080 Change-Id: I598ce1cd41676b1992b0973b09476eeeb0e602d2 Reviewed-on: https://webrtc-review.googlesource.com/c/114940 Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Oleh Prypin <oprypin@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26058}
2018-12-19 15:06:17 +01:00
"../../api/audio_codecs:builtin_audio_decoder_factory",
Revert of Enable GN check for webrtc/base (patchset #9 id:350001 of https://codereview.webrtc.org/2840453004/ ) Reason for revert: It causes a Chromium build error: ERROR at //third_party/webrtc/test/BUILD.gn:113:5: Can't load input file. "//third_party/gflags", Original issue's description: > Reland of Enable GN check for webrtc/base (patchset #3 id:230001 of https://codereview.webrtc.org/2838683002/ ) > > Reason for revert: > Try to fix the webrtc/test/fuzzers issue and reland this CL because it > contains lots of fixes for our BUILD.gn files. > > Original issue's description: > > Revert of Enable GN check for webrtc/base (patchset #13 id:240001 of https://codereview.webrtc.org/2717083002/ ) > > > > Reason for revert: > > Breaks Chromium because in Chromium we import WebRTC with rtc_include_tests=false (https://bugs.chromium.org/p/chromium/issues/detail?id=713179#c6). > > > > Chromium uses webrtc/test/fuzzers and this CL adds test dependencies to neteq_rtc_fuzzer. > > > > Original issue's description: > > > Enable GN check for webrtc/base > > > > > > It's not possible to enable it for the rtc_base_approved > > > target but since a larger refactoring is ongoing for webrtc/base > > > this CL doesn't attempt to fix that. > > > > > > Changes made: > > > * Move webrtc/system_wrappers/include/stringize_macros.h into > > > webrtc/base:rtc_base_approved_unittests (and corresponding > > > unit test to rtc_base_approved_unittests). > > > * Move md5digest.* from rtc_base_approved to rtc_base_test_utils target. > > > * Move webrtc/system_wrappers/include/stringize_macros.h (+test) into > > > webrtc/base. > > > * Remove unused use include of webrtc/base/fileutils.h in > > > webrtc/base/pathutils.cc > > > > > > BUG=webrtc:6828, webrtc:3806, webrtc:7480 > > > NOTRY=True > > > > > > Review-Url: https://codereview.webrtc.org/2717083002 > > > Cr-Commit-Position: refs/heads/master@{#17766} > > > Committed: https://chromium.googlesource.com/external/webrtc/+/ed754e71ae8866db641677073274e86fe704eeac > > > > TBR=perkj@webrtc.org,tommi@webrtc.org,nisse@webrtc.org,kjellander@webrtc.org > > # Not skipping CQ checks because original CL landed more than 1 days ago. > > BUG=webrtc:6828, webrtc:3806, webrtc:7480 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/2838683002 > > Cr-Commit-Position: refs/heads/master@{#17849} > > Committed: https://chromium.googlesource.com/external/webrtc/+/11ed366c487a938815cd52ad2ab5467b0f90e1ae > > TBR=perkj@webrtc.org,tommi@webrtc.org,nisse@webrtc.org,kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6828, webrtc:3806, webrtc:7480 > > Review-Url: https://codereview.webrtc.org/2840453004 > Cr-Commit-Position: refs/heads/master@{#17876} > Committed: https://chromium.googlesource.com/external/webrtc/+/7054085e59c3123613cd0014bedb0fe91a56e26f TBR=perkj@webrtc.org,tommi@webrtc.org,nisse@webrtc.org,kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6828, webrtc:3806, webrtc:7480 Review-Url: https://codereview.webrtc.org/2846483002 Cr-Commit-Position: refs/heads/master@{#17877}
2017-04-26 00:38:48 -07:00
"../../modules/audio_coding:neteq",
Reland of Enabling `gn check` on webrtc/test (patchset #1 id:1 of https://codereview.webrtc.org/2920763002/ ) Reason for revert: Fixing and re-landing. Original issue's description: > Revert of Enabling `gn check` on webrtc/test (patchset #9 id:160001 of https://codereview.webrtc.org/2911203002/ ) > > Reason for revert: > ERROR at //webrtc/test/testsupport/fileutils_unittest.cc:20:11: Can't include this header from here. > #include "webrtc/base/checks.h" > ^------------------- > The target: > //webrtc/test:fileutils_unittests > is including a file from the target: > //webrtc/base:rtc_base_approved > > It's usually best to depend directly on the destination target. > In some cases, the destination target is considered a subcomponent > of an intermediate target. In this case, the intermediate target > should depend publicly on the destination to forward the ability > to include headers. > > Dependency chain (there may also be others): > //webrtc/test:fileutils_unittests --> > //webrtc/test:fileutils --[private]--> > //webrtc/base:rtc_base_approved > > > Original issue's description: > > Enabling `gn check` on webrtc/test > > > > BUG=webrtc:6828 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/2911203002 > > Cr-Commit-Position: refs/heads/master@{#18372} > > Committed: https://chromium.googlesource.com/external/webrtc/+/db5bb404b0f42a7c0a43f882b34ba1325d8cbae2 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6828 > > Review-Url: https://codereview.webrtc.org/2920763002 > Cr-Commit-Position: refs/heads/master@{#18375} > Committed: https://chromium.googlesource.com/external/webrtc/+/1a6f143d077aec85d919c516b4f74ada8b8c21a8 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6828 Review-Url: https://codereview.webrtc.org/2918793002 Cr-Commit-Position: refs/heads/master@{#18376}
2017-06-01 04:47:20 -07:00
"../../modules/audio_coding:neteq_test_tools",
NetEq tests: BUILD target reorg In this CL, the neteq_unittest_tools target is split in two separate targets. One still called neteq_tools which does not set testonly=true and that includes code related to audio input, replacement audio and fake decoding. The other target called neteq_test_tools contains the remaining files, and is still under testonly=true. Other renames: neteq_test_tools -> neteq_test_tools_deprecated neteq_test_minimal -> neteq_tools_minimal Cyclic dependencies were also cleaned up. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_compile_rel_ng,linux_chromium_compile_dbg_ng BUG=webrtc:7467,webrtc:6828 Review-Url: https://codereview.webrtc.org/2845013003 Cr-Commit-Position: refs/heads/master@{#17921}
2017-04-28 00:59:45 -07:00
"../../modules/audio_coding:neteq_tools_minimal",
Relanding "Setting up an RTP input fuzzer for NetEq" The original CL (https://codereview.webrtc.org/2315633002) was reverted since the fuzzer depended on gflags and files in the resources folder; neither of this is allowed for a fuzzer test in Chromium. This new version streamlines the dependencies, and changes the test to generate a sinusoid input audio signal instead of reading from a file. Original commit message: This CL introduces a new fuzzer target neteq_rtp_fuzzer that manipulates the RTP header fields before inserting the packets into NetEq. A few helper classes are also introduced. BUG=webrtc:5447 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_chromium_rel_ng;master.tryserver.chromium.android:android_compile_dbg,linux_android_rel_ng;master.tryserver.chromium.linux:linux_chromium_rel_ng;master.tryserver.chromium.mac:mac_chromium_rel_ng,ios-device Review-Url: https://codereview.webrtc.org/2384423002 Cr-Commit-Position: refs/heads/master@{#14523}
2016-10-05 02:27:42 -07:00
"../../modules/audio_coding:pcm16b",
Stop using public_deps in modules/rtp_rtcp. TBR=phoglund@webrtc.org Bug: webrtc:8603 Change-Id: I86830df23db3f33a1a26098e639596bd3b86485a No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/29780 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21108}
2017-12-06 07:51:33 +01:00
"../../modules/rtp_rtcp:rtp_rtcp_format",
Remove remains of webrtc/base All downstream code have been updated to the new location. In PRESUBMIT.py: * Remove webrtc/rtc_base from CPP_BLACKLIST * Add webrtc/rtc_base to LEGACY_API_DIRS Fix some duplicated paths in webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn BUG=webrtc:7634 TBR=kwiberg@webrtc.org Review-Url: https://codereview.webrtc.org/2976293002 Cr-Commit-Position: refs/heads/master@{#19094}
2017-07-19 10:40:47 -07:00
"../../rtc_base:rtc_base_approved",
Relanding "Setting up an RTP input fuzzer for NetEq" The original CL (https://codereview.webrtc.org/2315633002) was reverted since the fuzzer depended on gflags and files in the resources folder; neither of this is allowed for a fuzzer test in Chromium. This new version streamlines the dependencies, and changes the test to generate a sinusoid input audio signal instead of reading from a file. Original commit message: This CL introduces a new fuzzer target neteq_rtp_fuzzer that manipulates the RTP header fields before inserting the packets into NetEq. A few helper classes are also introduced. BUG=webrtc:5447 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_chromium_rel_ng;master.tryserver.chromium.android:android_compile_dbg,linux_android_rel_ng;master.tryserver.chromium.linux:linux_chromium_rel_ng;master.tryserver.chromium.mac:mac_chromium_rel_ng,ios-device Review-Url: https://codereview.webrtc.org/2384423002 Cr-Commit-Position: refs/heads/master@{#14523}
2016-10-05 02:27:42 -07:00
]
}
Add new neteq_signal_fuzzer NetEq has been fuzzed by neteq_rtp_fuzzer for some time. That fuzzer hammers the RTP data, but leaves much of the other data alone. This new fuzzer instead alters the encoded audio, packet arrival timing, clock drift, and packet losses. Bug: webrtc:8421 Change-Id: Ie25b77590a66a7451f32a73c6b5b570944244027 Reviewed-on: https://webrtc-review.googlesource.com/13860 Commit-Queue: Henrik Lundin <henrik.lundin@webrtc.org> Reviewed-by: Ivo Creusen <ivoc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20368}
2017-10-20 10:38:56 +02:00
webrtc_fuzzer_test("neteq_signal_fuzzer") {
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "neteq_signal_fuzzer.cc" ]
Add new neteq_signal_fuzzer NetEq has been fuzzed by neteq_rtp_fuzzer for some time. That fuzzer hammers the RTP data, but leaves much of the other data alone. This new fuzzer instead alters the encoded audio, packet arrival timing, clock drift, and packet losses. Bug: webrtc:8421 Change-Id: Ie25b77590a66a7451f32a73c6b5b570944244027 Reviewed-on: https://webrtc-review.googlesource.com/13860 Commit-Queue: Henrik Lundin <henrik.lundin@webrtc.org> Reviewed-by: Ivo Creusen <ivoc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20368}
2017-10-20 10:38:56 +02:00
deps = [
"../../api:array_view",
Reland "Add AudioDecoderFactory to NetEqTest constructor." This is a reland of daa970f33e1923c5651a4a63c18e3d5361d0a795 Original change's description: > Add AudioDecoderFactory to NetEqTest constructor. > > Update EventLogAnalyzer to not depend on builtin audio decoders. > > Bug: webrtc:8396, webrtc:10080 > Change-Id: Ie02ed9cda6d4f11bfdf2e65eb6482283b7520738 > Reviewed-on: https://webrtc-review.googlesource.com/c/114301 > Reviewed-by: Alex Loiko <aleloi@webrtc.org> > Reviewed-by: Ivo Creusen <ivoc@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Commit-Queue: Niels Moller <nisse@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#26026} Tbr: kwiberg@webrtc.org Bug: webrtc:8396, webrtc:10080 Change-Id: I598ce1cd41676b1992b0973b09476eeeb0e602d2 Reviewed-on: https://webrtc-review.googlesource.com/c/114940 Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Oleh Prypin <oprypin@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26058}
2018-12-19 15:06:17 +01:00
"../../api/audio_codecs:builtin_audio_decoder_factory",
Add new neteq_signal_fuzzer NetEq has been fuzzed by neteq_rtp_fuzzer for some time. That fuzzer hammers the RTP data, but leaves much of the other data alone. This new fuzzer instead alters the encoded audio, packet arrival timing, clock drift, and packet losses. Bug: webrtc:8421 Change-Id: Ie25b77590a66a7451f32a73c6b5b570944244027 Reviewed-on: https://webrtc-review.googlesource.com/13860 Commit-Queue: Henrik Lundin <henrik.lundin@webrtc.org> Reviewed-by: Ivo Creusen <ivoc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20368}
2017-10-20 10:38:56 +02:00
"../../modules/audio_coding:neteq",
"../../modules/audio_coding:neteq_test_tools",
"../../modules/audio_coding:neteq_tools_minimal",
"../../modules/audio_coding:pcm16b",
"../../rtc_base:rtc_base_approved",
]
}
Adds fuzzer for the residual echo detector. This is a robustness test for the residual echo detector, that can help to detect numerical issues. BUG=b/38014838 Review-Url: https://codereview.webrtc.org/2877803002 Cr-Commit-Position: refs/heads/master@{#18165}
2017-05-16 06:50:11 -07:00
webrtc_fuzzer_test("residual_echo_detector_fuzzer") {
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "residual_echo_detector_fuzzer.cc" ]
Adds fuzzer for the residual echo detector. This is a robustness test for the residual echo detector, that can help to detect numerical issues. BUG=b/38014838 Review-Url: https://codereview.webrtc.org/2877803002 Cr-Commit-Position: refs/heads/master@{#18165}
2017-05-16 06:50:11 -07:00
deps = [
Surface ResidualEchoDetector creation to API This allows users to inject the residual echo detector, as a step toward making it an optional part of compilation. Bug: webrtc:11292, webrtc:11539 Change-Id: I7fcc8dbaced67a82851cd6cdcbc115eb01c21fcf Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/174040 Reviewed-by: Per Åhgren <peah@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Sam Zackrisson <saza@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31222}
2020-05-12 10:48:19 +02:00
"../../api/audio:echo_detector_creator",
Fix circular dependencies between optional, array_view, and rtc_base. This splits things out of rtc_base and makes dependencies explicit. Bug: webrtc:6828 Change-Id: Id521896c3c43595349021c857bec216e429a0c8d Reviewed-on: https://webrtc-review.googlesource.com/32780 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21264}
2017-12-13 16:05:42 +01:00
"../../rtc_base:checks",
Remove remains of webrtc/base All downstream code have been updated to the new location. In PRESUBMIT.py: * Remove webrtc/rtc_base from CPP_BLACKLIST * Add webrtc/rtc_base to LEGACY_API_DIRS Fix some duplicated paths in webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn BUG=webrtc:7634 TBR=kwiberg@webrtc.org Review-Url: https://codereview.webrtc.org/2976293002 Cr-Commit-Position: refs/heads/master@{#19094}
2017-07-19 10:40:47 -07:00
"../../rtc_base:rtc_base_approved",
Adds fuzzer for the residual echo detector. This is a robustness test for the residual echo detector, that can help to detect numerical issues. BUG=b/38014838 Review-Url: https://codereview.webrtc.org/2877803002 Cr-Commit-Position: refs/heads/master@{#18165}
2017-05-16 06:50:11 -07:00
]
}
Enable turn, sdp, pseudotcp and stun parse/validator fuzzers. These were blocked on GN work; should be good to go now. If they break the WebRTC FYI bots, there's more work to be done. Verified they build locally at least. Setting no-try because all bots went green except broken android bots. BUG=6368 NOTRY=true Review-Url: https://codereview.webrtc.org/2342843002 Cr-Commit-Position: refs/heads/master@{#14256}
2016-09-16 05:05:39 -07:00
webrtc_fuzzer_test("sdp_parser_fuzzer") {
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "sdp_parser_fuzzer.cc" ]
Enable turn, sdp, pseudotcp and stun parse/validator fuzzers. These were blocked on GN work; should be good to go now. If they break the WebRTC FYI bots, there's more work to be done. Verified they build locally at least. Setting no-try because all bots went green except broken android bots. BUG=6368 NOTRY=true Review-Url: https://codereview.webrtc.org/2342843002 Cr-Commit-Position: refs/heads/master@{#14256}
2016-09-16 05:05:39 -07:00
deps = [
Stop using public_deps in pc/. TBR=phoglund@webrtc.org Bug: webrtc:8603 Change-Id: If18e5a4d212392bbd9b4e1f9c2f00ee79a2ab348 No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/29864 Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21139}
2017-12-06 11:23:19 +01:00
"../../api:libjingle_peerconnection_api",
Create //webrtc/api:libjingle_peerconnection_api + refactorings. Create a new target //webrtc/api:libjingle_peerconnection_api and start moving things into it. Move remaining parts of //webrtc/api:libjingle_peerconnection to //webrtc/pc:libjingle_peerconnection. Moved the RTCStatsCollectorCallback into its own header file, so that PeerConnectionInterface can include that instead of pulling in RTCStatsCollector and PeerConnection and everything. Separated cricket::MediaType into its own header/source set, so that it can be used in the api. BUG=webrtc:5883 Review-Url: https://codereview.webrtc.org/2514883002 Cr-Commit-Position: refs/heads/master@{#16210}
2017-01-23 04:56:25 -08:00
"../../pc:libjingle_peerconnection",
Enable turn, sdp, pseudotcp and stun parse/validator fuzzers. These were blocked on GN work; should be good to go now. If they break the WebRTC FYI bots, there's more work to be done. Verified they build locally at least. Setting no-try because all bots went green except broken android bots. BUG=6368 NOTRY=true Review-Url: https://codereview.webrtc.org/2342843002 Cr-Commit-Position: refs/heads/master@{#14256}
2016-09-16 05:05:39 -07:00
]
seed_corpus = "corpora/sdp-corpus"
}
Reland of https://codereview.webrtc.org/2044523002. Landing these in WebRTC under a guard so they don't build in Chromium. The guard can be removed once Chromium has migrated to use the new GN targets. BUG=webrtc:6081 NOTRY=true Review-Url: https://codereview.webrtc.org/2117183005 Cr-Commit-Position: refs/heads/master@{#13397}
2016-07-06 08:02:00 -07:00
Reland "Add a fuzzer test that tries to connect a PeerConnection." This reverts commit ae44fde18854390ca7a51bcab37ef199a1555e38. Reason for revert: Added Chromium compile guards Original change's description: > Revert "Add a fuzzer test that tries to connect a PeerConnection." > > This reverts commit c67b77eee4b08c05638a219723a9141a65015da4. > > Reason for revert: Breaks the libfuzzer chromium bots for WebRTC roll. > > Original change's description: > > Add a fuzzer test that tries to connect a PeerConnection. > > > > Bug: none > > Change-Id: I975c6a4cd5c7dfc4a7689259292ea7d443d270f7 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/209182 > > Commit-Queue: Harald Alvestrand <hta@webrtc.org> > > Reviewed-by: Henrik Boström <hbos@webrtc.org> > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#33369} > > NOPRESUBMIT=true > > Bug: none > Change-Id: Ib5fa809eb698c64b7c01835e8a311eaf85b19a18 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/209640 > Commit-Queue: Evan Shrubsole <eshr@google.com> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#33380} Bug: none Change-Id: I07bab58f1216fb91b9b607e7ba978c28838d9411 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/210680 Reviewed-by: Henrik Boström <hbos@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33397}
2021-03-08 07:01:48 +00:00
if (!build_with_chromium) {
# This target depends on test infrastructure that can't be built
# with Chromium at the moment.
# TODO(bugs.chromium.org/12534): Make this fuzzer build in Chromium.
webrtc_fuzzer_test("sdp_integration_fuzzer") {
sources = [ "sdp_integration_fuzzer.cc" ]
deps = [
"../../api:libjingle_peerconnection_api",
"../../pc:integration_test_helpers",
"../../pc:libjingle_peerconnection",
"../../test:test_support",
]
seed_corpus = "corpora/sdp-corpus"
}
}
Enable turn, sdp, pseudotcp and stun parse/validator fuzzers. These were blocked on GN work; should be good to go now. If they break the WebRTC FYI bots, there's more work to be done. Verified they build locally at least. Setting no-try because all bots went green except broken android bots. BUG=6368 NOTRY=true Review-Url: https://codereview.webrtc.org/2342843002 Cr-Commit-Position: refs/heads/master@{#14256}
2016-09-16 05:05:39 -07:00
webrtc_fuzzer_test("stun_parser_fuzzer") {
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "stun_parser_fuzzer.cc" ]
Enable turn, sdp, pseudotcp and stun parse/validator fuzzers. These were blocked on GN work; should be good to go now. If they break the WebRTC FYI bots, there's more work to be done. Verified they build locally at least. Setting no-try because all bots went green except broken android bots. BUG=6368 NOTRY=true Review-Url: https://codereview.webrtc.org/2342843002 Cr-Commit-Position: refs/heads/master@{#14256}
2016-09-16 05:05:39 -07:00
deps = [
Move stun.h to api/. We now have two downstream users of stun.h, so it appears to be generally usable. I put this in a new dir networking/, but I'm open to suggestions here (maybe some things in api/ should move in there). I checked what our downstream users are actually using, and it's cricket::ComputeStunCredentialHash cricket::<constants> cricket::TurnMessage cricket::GetStunErrorResponseType cricket::StunAttribute::CreateAddress cricket::StunErrorCodeAttribute cricket::StunByteStringAttribute StunAttribute::CreateUnknownAttributes cricket::TurnErrorType cricket::StunMessage I reckoned that was pretty much everything in stun.h, so I didn't bother splitting it up. They don't use every function and constant in there, but all _types_ of functions and constants, so for the sake of coherence I don't think it makes sense to split it. There's some old stuff in there like GTURN which could arguably be split out, but it should likely go away soon anyway, so I don't think it's worth the effort. Steps: 1) land this 2) update downstream to point to the new header and target 3) remove p2p/base:stun_types. Bug: webrtc:11091 Change-Id: I1f05bf06055475d25601197ec6fefb8d3b55e8e3 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159923 Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29822}
2019-11-18 15:53:32 +01:00
"../../api/transport:stun_types",
Enable turn, sdp, pseudotcp and stun parse/validator fuzzers. These were blocked on GN work; should be good to go now. If they break the WebRTC FYI bots, there's more work to be done. Verified they build locally at least. Setting no-try because all bots went green except broken android bots. BUG=6368 NOTRY=true Review-Url: https://codereview.webrtc.org/2342843002 Cr-Commit-Position: refs/heads/master@{#14256}
2016-09-16 05:05:39 -07:00
"../../p2p:rtc_p2p",
]
seed_corpus = "corpora/stun-corpus"
dict = "corpora/stun.tokens"
}
Reland of https://codereview.webrtc.org/2044523002. Landing these in WebRTC under a guard so they don't build in Chromium. The guard can be removed once Chromium has migrated to use the new GN targets. BUG=webrtc:6081 NOTRY=true Review-Url: https://codereview.webrtc.org/2117183005 Cr-Commit-Position: refs/heads/master@{#13397}
2016-07-06 08:02:00 -07:00
Enable turn, sdp, pseudotcp and stun parse/validator fuzzers. These were blocked on GN work; should be good to go now. If they break the WebRTC FYI bots, there's more work to be done. Verified they build locally at least. Setting no-try because all bots went green except broken android bots. BUG=6368 NOTRY=true Review-Url: https://codereview.webrtc.org/2342843002 Cr-Commit-Position: refs/heads/master@{#14256}
2016-09-16 05:05:39 -07:00
webrtc_fuzzer_test("stun_validator_fuzzer") {
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "stun_validator_fuzzer.cc" ]
Enable turn, sdp, pseudotcp and stun parse/validator fuzzers. These were blocked on GN work; should be good to go now. If they break the WebRTC FYI bots, there's more work to be done. Verified they build locally at least. Setting no-try because all bots went green except broken android bots. BUG=6368 NOTRY=true Review-Url: https://codereview.webrtc.org/2342843002 Cr-Commit-Position: refs/heads/master@{#14256}
2016-09-16 05:05:39 -07:00
deps = [
Move stun.h to api/. We now have two downstream users of stun.h, so it appears to be generally usable. I put this in a new dir networking/, but I'm open to suggestions here (maybe some things in api/ should move in there). I checked what our downstream users are actually using, and it's cricket::ComputeStunCredentialHash cricket::<constants> cricket::TurnMessage cricket::GetStunErrorResponseType cricket::StunAttribute::CreateAddress cricket::StunErrorCodeAttribute cricket::StunByteStringAttribute StunAttribute::CreateUnknownAttributes cricket::TurnErrorType cricket::StunMessage I reckoned that was pretty much everything in stun.h, so I didn't bother splitting it up. They don't use every function and constant in there, but all _types_ of functions and constants, so for the sake of coherence I don't think it makes sense to split it. There's some old stuff in there like GTURN which could arguably be split out, but it should likely go away soon anyway, so I don't think it's worth the effort. Steps: 1) land this 2) update downstream to point to the new header and target 3) remove p2p/base:stun_types. Bug: webrtc:11091 Change-Id: I1f05bf06055475d25601197ec6fefb8d3b55e8e3 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159923 Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29822}
2019-11-18 15:53:32 +01:00
"../../api/transport:stun_types",
Enable turn, sdp, pseudotcp and stun parse/validator fuzzers. These were blocked on GN work; should be good to go now. If they break the WebRTC FYI bots, there's more work to be done. Verified they build locally at least. Setting no-try because all bots went green except broken android bots. BUG=6368 NOTRY=true Review-Url: https://codereview.webrtc.org/2342843002 Cr-Commit-Position: refs/heads/master@{#14256}
2016-09-16 05:05:39 -07:00
"../../p2p:rtc_p2p",
]
seed_corpus = "corpora/stun-corpus"
dict = "corpora/stun.tokens"
}
Add a fuzzer for the pseudoTCP implementation used by chromoting. This found chromium:620694. Unfortunately it depends on unsafe GN targets, so do not build in Chromium. NOTRY=true Review-Url: https://codereview.webrtc.org/2129603003 Cr-Commit-Position: refs/heads/master@{#13407}
2016-07-07 05:52:24 -07:00
Enable turn, sdp, pseudotcp and stun parse/validator fuzzers. These were blocked on GN work; should be good to go now. If they break the WebRTC FYI bots, there's more work to be done. Verified they build locally at least. Setting no-try because all bots went green except broken android bots. BUG=6368 NOTRY=true Review-Url: https://codereview.webrtc.org/2342843002 Cr-Commit-Position: refs/heads/master@{#14256}
2016-09-16 05:05:39 -07:00
webrtc_fuzzer_test("pseudotcp_parser_fuzzer") {
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "pseudotcp_parser_fuzzer.cc" ]
Enable turn, sdp, pseudotcp and stun parse/validator fuzzers. These were blocked on GN work; should be good to go now. If they break the WebRTC FYI bots, there's more work to be done. Verified they build locally at least. Setting no-try because all bots went green except broken android bots. BUG=6368 NOTRY=true Review-Url: https://codereview.webrtc.org/2342843002 Cr-Commit-Position: refs/heads/master@{#14256}
2016-09-16 05:05:39 -07:00
deps = [
"../../p2p:rtc_p2p",
Cleanup BUILD.gn files from imports like foo:foo Repalce all occurrences of foo:foo in deps with just foo in BUILD.gn files. Done with Sublime regex replace. Find: \b([-a-zA-Z0-9_]+):+\1\b In: *.gn Replace with: \1 Bug: None Change-Id: I40aba1b14face687a595b852ffe443cb20197611 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127899 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27225}
2019-03-21 13:35:10 +01:00
"../../rtc_base",
Reland "Refactor rtc_base build targets." This is a reland of 69241a93fb14f6527a26d5c94dde879013012d2a Fix: The problem was related to NO_MAIN_THREAD_WRAPPING, which affects https://source.chromium.org/chromium/chromium/src/+/master:third_party/webrtc/rtc_base/thread.cc;l=257-263;drc=7acc2d9fe3a6e3c4d8881d2bdfc9b8968a724cd5. The original CL didn't attach the definition of the macro NO_MAIN_THREAD_WRAPPING when building for Chromium (which doesn't have to be related to //rtc_base anymore but to //rtc_base:threading). Original change's description: > Refactor rtc_base build targets. > > The "//rtc_base:rtc_base" build target has historically been one of the > biggest targets in the WebRTC build. Big targets are the main source of > circular dependencies and non-API types leakage. > > This CL is a step forward into splitting "//rtc_base:rtc_base" into > smaller targets (as originally started in 2018). > > The only non-automated changes are (like re-wiring the build system): > * The creation of //rtc_base/async_resolver.{h,cc} which allows to > break a circular dependency (is has been extracted from > //rtc_base/net_helpers.{h,cc}). > * The creation of //rtc_base/internal/default_socket_server.{h,cc} to > break another circular dependency. > > Bug: webrtc:9987 > Change-Id: I0c8f5e7efe2c8fd8e6bffa0d6dd2dd494cf3df02 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/196903 > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#32941} Bug: webrtc:9987 Change-Id: I7cdf49d2aac8357f1f50f90010bf2c2f62fa19f6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/202021 Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33001}
2021-01-15 10:41:01 +01:00
"../../rtc_base:threading",
Enable turn, sdp, pseudotcp and stun parse/validator fuzzers. These were blocked on GN work; should be good to go now. If they break the WebRTC FYI bots, there's more work to be done. Verified they build locally at least. Setting no-try because all bots went green except broken android bots. BUG=6368 NOTRY=true Review-Url: https://codereview.webrtc.org/2342843002 Cr-Commit-Position: refs/heads/master@{#14256}
2016-09-16 05:05:39 -07:00
]
Add fuzzer for TURN unwrap. This is called on received network packets if dump_rtp_packets_ is on. NOTRY=true Review-Url: https://codereview.webrtc.org/2126463002 Cr-Commit-Position: refs/heads/master@{#13394}
2016-07-06 05:59:23 -07:00
}
Add TransportFeedbackPacketLossTracker. This CL is to calculate packet loss metrics from TransportFeedback. The outcome of this will be passed down to audio encoder. BUG=webrtc:6904 Review-Url: https://codereview.webrtc.org/2579613003 Cr-Commit-Position: refs/heads/master@{#16217}
2017-01-23 08:07:05 -08:00
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("audio_processing_fuzzer_helper") {
Opus Encoder fuzzer: separate target for FuzzAudioEncoder Move FuzzAudioEncoder to a separate target to make it available for other encoders. Bug: webrtc:11388 Change-Id: I8b9a0f810791880eedb129b55eb33f154790e48f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169364 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30634}
2020-02-27 16:32:56 +01:00
testonly = true
Added new AudioProcessing fuzzer This is a high-level fuzzer that creates an AudioProcessing instance. All possible combinations of publicly visible components are fuzzed. Input and output sample rate, call order and use of the float/fix interface is fuzzed. Sample rate may change between calls. To fuzz floating point numbers, raw data is converted to floats, and filtered for special values like 'inf', 'nan' and very large values. Note that the default use case of APM is to only allow values between +/- 2^15. BUG=webrtc:7820 Review-Url: https://codereview.webrtc.org/2876793002 Cr-Commit-Position: refs/heads/master@{#18678}
2017-06-20 05:26:55 -07:00
sources = [
AEC-m and AEC-2 fuzzing. Going through the coverage of audio_processing_fuzzer, it was noticed that it didn't cover AEC-m and AEC-2 code. Therefore this CL adds 2 fuzzer targets that only fuzz the previous generation echo cancellers. To avoid code duplication, the APM running code was broken out in a new GN target. We have also changed all fuzzing code to use the FuzzDataHelper class to avoid manual pointer arithmetic. Bug: webrtc:7820 Change-Id: Ifea3266e396b487952a736945577fccea15d0e01 Reviewed-on: https://webrtc-review.googlesource.com/36500 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Reviewed-by: Sam Zackrisson <saza@webrtc.org> Commit-Queue: Alex Loiko <aleloi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21638}
2018-01-16 12:50:34 +01:00
"audio_processing_fuzzer_helper.cc",
"audio_processing_fuzzer_helper.h",
Added new AudioProcessing fuzzer This is a high-level fuzzer that creates an AudioProcessing instance. All possible combinations of publicly visible components are fuzzed. Input and output sample rate, call order and use of the float/fix interface is fuzzed. Sample rate may change between calls. To fuzz floating point numbers, raw data is converted to floats, and filtered for special values like 'inf', 'nan' and very large values. Note that the default use case of APM is to only allow values between +/- 2^15. BUG=webrtc:7820 Review-Url: https://codereview.webrtc.org/2876793002 Cr-Commit-Position: refs/heads/master@{#18678}
2017-06-20 05:26:55 -07:00
]
deps = [
AEC-m and AEC-2 fuzzing. Going through the coverage of audio_processing_fuzzer, it was noticed that it didn't cover AEC-m and AEC-2 code. Therefore this CL adds 2 fuzzer targets that only fuzz the previous generation echo cancellers. To avoid code duplication, the APM running code was broken out in a new GN target. We have also changed all fuzzing code to use the FuzzDataHelper class to avoid manual pointer arithmetic. Bug: webrtc:7820 Change-Id: Ifea3266e396b487952a736945577fccea15d0e01 Reviewed-on: https://webrtc-review.googlesource.com/36500 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Reviewed-by: Sam Zackrisson <saza@webrtc.org> Commit-Queue: Alex Loiko <aleloi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21638}
2018-01-16 12:50:34 +01:00
":fuzz_data_helper",
Remove dependencies on modules:module_api from AudioProcessing. - Directly include api/audio/audio_frame.h everywhere AudioFrame is used. - This *will* remove transient dependencies on libjpeg and a bunch of other things from the e.g. APM. - audio_frame.h still included from module_common_types.h for backwards compatibility with clients. Bug: webrtc:9139, webrtc:7504 Change-Id: Id96f9268c01667fbcc29a01f5c1dd25a37836897 Reviewed-on: https://webrtc-review.googlesource.com/62464 Commit-Queue: Fredrik Solenberg <solenberg@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22845}
2018-04-12 22:44:09 +02:00
"../../api/audio:audio_frame_api",
Added new AudioProcessing fuzzer This is a high-level fuzzer that creates an AudioProcessing instance. All possible combinations of publicly visible components are fuzzed. Input and output sample rate, call order and use of the float/fix interface is fuzzed. Sample rate may change between calls. To fuzz floating point numbers, raw data is converted to floats, and filtered for special values like 'inf', 'nan' and very large values. Note that the default use case of APM is to only allow values between +/- 2^15. BUG=webrtc:7820 Review-Url: https://codereview.webrtc.org/2876793002 Cr-Commit-Position: refs/heads/master@{#18678}
2017-06-20 05:26:55 -07:00
"../../modules/audio_processing",
Reland "Isolating APM API build target: making :api an actual target." This reverts commit 61c6e5643e7ea058e653956980a90e033249c055. Reason for revert: downstream projects prepared for this change Original change's description: > Revert "Isolating APM API build target: making :api an actual target." > > This reverts commit a7f77a7c05b5d26520fd01a773ffb2c8b15b60ff. > > Reason for revert: breaking downstream > > Original change's description: > > Isolating APM API build target: making :api an actual target. > > > > This CL is part of a refactoring work to unblock other CLs > > that would generate a circular dependency when including > > modules/audio_processing. It will also allow to easily move > > the APM interface part under //api. > > > > More in detail, this change moves the APM interface files from > > the build target modules/audio_processing to > > modules/audio_processing:api. It also adds :api as dependency > > where needed. > > > > Bug: webrtc:9535 > > Change-Id: I72829e22d08ba4d75985f0421e6e8bf0216ebecd > > Reviewed-on: https://webrtc-review.googlesource.com/c/109501 > > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > > Reviewed-by: Kári Helgason <kthelgason@webrtc.org> > > Reviewed-by: Niels Moller <nisse@webrtc.org> > > Reviewed-by: Sam Zackrisson <saza@webrtc.org> > > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#25539} > > TBR=saza@webrtc.org,alessiob@webrtc.org,kwiberg@webrtc.org,nisse@webrtc.org,kthelgason@webrtc.org > > Change-Id: I974c6237311e7c06970aa62e5f6940f3aa80113d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:9535 > Reviewed-on: https://webrtc-review.googlesource.com/c/109820 > Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#25540} TBR=saza@webrtc.org,alessiob@webrtc.org,kwiberg@webrtc.org,nisse@webrtc.org,kthelgason@webrtc.org Change-Id: Ic8ed4cc3baf43d639ce13cae256c007728c3ad92 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:9535 Reviewed-on: https://webrtc-review.googlesource.com/c/109884 Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25547}
2018-11-07 14:29:54 +00:00
"../../modules/audio_processing:api",
Reland "APM: Remove the usage of AudioFrame in the AudioProcessing interface" This is a reland of 12e2d4ddb235da6ec7a5c1c3a83ac33d394920b0 Original change's description: > APM: Remove the usage of AudioFrame in the AudioProcessing interface > > This CL removes the AudioFrame-based APIs from the AudioProcessing > interface. > > Bug: webrtc:5298 > Change-Id: Iab470b26b10e06dcf29c543851ae0085bc5b66f0 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/172939 > Reviewed-by: Sam Zackrisson <saza@webrtc.org> > Commit-Queue: Per Åhgren <peah@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#31016} Bug: webrtc:5298 Change-Id: I70e6d59afc3716ee6109d8b9dc384abc71c93624 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173476 Reviewed-by: Sam Zackrisson <saza@webrtc.org> Commit-Queue: Per Åhgren <peah@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31066}
2020-04-07 11:33:16 +02:00
"../../modules/audio_processing:audio_frame_proxies",
Fix circular dependencies between optional, array_view, and rtc_base. This splits things out of rtc_base and makes dependencies explicit. Bug: webrtc:6828 Change-Id: Id521896c3c43595349021c857bec216e429a0c8d Reviewed-on: https://webrtc-review.googlesource.com/32780 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21264}
2017-12-13 16:05:42 +01:00
"../../rtc_base:checks",
Remove remains of webrtc/base All downstream code have been updated to the new location. In PRESUBMIT.py: * Remove webrtc/rtc_base from CPP_BLACKLIST * Add webrtc/rtc_base to LEGACY_API_DIRS Fix some duplicated paths in webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn BUG=webrtc:7634 TBR=kwiberg@webrtc.org Review-Url: https://codereview.webrtc.org/2976293002 Cr-Commit-Position: refs/heads/master@{#19094}
2017-07-19 10:40:47 -07:00
"../../rtc_base:rtc_base_approved",
Added new AudioProcessing fuzzer This is a high-level fuzzer that creates an AudioProcessing instance. All possible combinations of publicly visible components are fuzzed. Input and output sample rate, call order and use of the float/fix interface is fuzzed. Sample rate may change between calls. To fuzz floating point numbers, raw data is converted to floats, and filtered for special values like 'inf', 'nan' and very large values. Note that the default use case of APM is to only allow values between +/- 2^15. BUG=webrtc:7820 Review-Url: https://codereview.webrtc.org/2876793002 Cr-Commit-Position: refs/heads/master@{#18678}
2017-06-20 05:26:55 -07:00
]
Use absl_deps in order to preapre to the Abseil component build release. Bug: webrtc:1046390 Change-Id: Ia35545599de23b1a2c2d8be2d53469af7ac16f1d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176502 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31463}
2020-06-05 14:30:41 +02:00
absl_deps = [ "//third_party/abseil-cpp/absl/types:optional" ]
Added new AudioProcessing fuzzer This is a high-level fuzzer that creates an AudioProcessing instance. All possible combinations of publicly visible components are fuzzed. Input and output sample rate, call order and use of the float/fix interface is fuzzed. Sample rate may change between calls. To fuzz floating point numbers, raw data is converted to floats, and filtered for special values like 'inf', 'nan' and very large values. Note that the default use case of APM is to only allow values between +/- 2^15. BUG=webrtc:7820 Review-Url: https://codereview.webrtc.org/2876793002 Cr-Commit-Position: refs/heads/master@{#18678}
2017-06-20 05:26:55 -07:00
}
Create a fuzzer for ComfortNoiseDecoder The fuzzer will hammer on the UpdateSid and Generate methods of ComfortNoiseDecoder. The change also includes a fix to an issue in WebRtcSpl_FilterAR, which was immediately found by running the fuzzer locally. Bug: none Change-Id: I5283427cb27844fb953e2caa35423ea873aca2ff Reviewed-on: https://webrtc-review.googlesource.com/28100 Commit-Queue: Henrik Lundin <henrik.lundin@webrtc.org> Reviewed-by: Sam Zackrisson <saza@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21134}
2017-12-07 09:21:36 +01:00
AEC-m and AEC-2 fuzzing. Going through the coverage of audio_processing_fuzzer, it was noticed that it didn't cover AEC-m and AEC-2 code. Therefore this CL adds 2 fuzzer targets that only fuzz the previous generation echo cancellers. To avoid code duplication, the APM running code was broken out in a new GN target. We have also changed all fuzzing code to use the FuzzDataHelper class to avoid manual pointer arithmetic. Bug: webrtc:7820 Change-Id: Ifea3266e396b487952a736945577fccea15d0e01 Reviewed-on: https://webrtc-review.googlesource.com/36500 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Reviewed-by: Sam Zackrisson <saza@webrtc.org> Commit-Queue: Alex Loiko <aleloi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21638}
2018-01-16 12:50:34 +01:00
webrtc_fuzzer_test("audio_processing_fuzzer") {
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "audio_processing_configs_fuzzer.cc" ]
AEC-m and AEC-2 fuzzing. Going through the coverage of audio_processing_fuzzer, it was noticed that it didn't cover AEC-m and AEC-2 code. Therefore this CL adds 2 fuzzer targets that only fuzz the previous generation echo cancellers. To avoid code duplication, the APM running code was broken out in a new GN target. We have also changed all fuzzing code to use the FuzzDataHelper class to avoid manual pointer arithmetic. Bug: webrtc:7820 Change-Id: Ifea3266e396b487952a736945577fccea15d0e01 Reviewed-on: https://webrtc-review.googlesource.com/36500 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Reviewed-by: Sam Zackrisson <saza@webrtc.org> Commit-Queue: Alex Loiko <aleloi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21638}
2018-01-16 12:50:34 +01:00
deps = [
":audio_processing_fuzzer_helper",
Remove rtc_base/scoped_ref_ptr.h. The type rtc::scoped_refptr<T> is now part of api/. Please include it from api/scoped_refptr.h. More info: See: https://groups.google.com/forum/#!topic/discuss-webrtc/Mme2MSz4z4o. Bug: webrtc:9887, webrtc:8205 No-Try: True Change-Id: Ic6c7c81e226e59f12f7933e472f573ae097b55bf Reviewed-on: https://webrtc-review.googlesource.com/c/119041 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26414}
2019-01-25 20:26:48 +01:00
"../../api:scoped_refptr",
Move EchoCanceller3Factory to api/auido The AEC3 factory is now part of the WebRTC API. Bug: webrtc:8844 Change-Id: If6f419b4ca0354e2d346c0e6474086e456ba747e Reviewed-on: https://webrtc-review.googlesource.com/57141 Commit-Queue: Gustaf Ullberg <gustaf@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Alex Loiko <aleloi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22204}
2018-02-27 13:58:45 +01:00
"../../api/audio:aec3_factory",
Use default task queue factory in fuzzers Bug: webrtc:10284 Change-Id: I31a7fe08f1ff3c4842ba657586a158bf632501d9 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145217 Reviewed-by: Sebastian Jansson <srte@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28549}
2019-07-11 13:58:14 +02:00
"../../api/task_queue:default_task_queue_factory",
AEC-m and AEC-2 fuzzing. Going through the coverage of audio_processing_fuzzer, it was noticed that it didn't cover AEC-m and AEC-2 code. Therefore this CL adds 2 fuzzer targets that only fuzz the previous generation echo cancellers. To avoid code duplication, the APM running code was broken out in a new GN target. We have also changed all fuzzing code to use the FuzzDataHelper class to avoid manual pointer arithmetic. Bug: webrtc:7820 Change-Id: Ifea3266e396b487952a736945577fccea15d0e01 Reviewed-on: https://webrtc-review.googlesource.com/36500 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Reviewed-by: Sam Zackrisson <saza@webrtc.org> Commit-Queue: Alex Loiko <aleloi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21638}
2018-01-16 12:50:34 +01:00
"../../modules/audio_processing",
Reland "Isolating APM API build target: making :api an actual target." This reverts commit 61c6e5643e7ea058e653956980a90e033249c055. Reason for revert: downstream projects prepared for this change Original change's description: > Revert "Isolating APM API build target: making :api an actual target." > > This reverts commit a7f77a7c05b5d26520fd01a773ffb2c8b15b60ff. > > Reason for revert: breaking downstream > > Original change's description: > > Isolating APM API build target: making :api an actual target. > > > > This CL is part of a refactoring work to unblock other CLs > > that would generate a circular dependency when including > > modules/audio_processing. It will also allow to easily move > > the APM interface part under //api. > > > > More in detail, this change moves the APM interface files from > > the build target modules/audio_processing to > > modules/audio_processing:api. It also adds :api as dependency > > where needed. > > > > Bug: webrtc:9535 > > Change-Id: I72829e22d08ba4d75985f0421e6e8bf0216ebecd > > Reviewed-on: https://webrtc-review.googlesource.com/c/109501 > > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > > Reviewed-by: Kári Helgason <kthelgason@webrtc.org> > > Reviewed-by: Niels Moller <nisse@webrtc.org> > > Reviewed-by: Sam Zackrisson <saza@webrtc.org> > > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#25539} > > TBR=saza@webrtc.org,alessiob@webrtc.org,kwiberg@webrtc.org,nisse@webrtc.org,kthelgason@webrtc.org > > Change-Id: I974c6237311e7c06970aa62e5f6940f3aa80113d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:9535 > Reviewed-on: https://webrtc-review.googlesource.com/c/109820 > Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#25540} TBR=saza@webrtc.org,alessiob@webrtc.org,kwiberg@webrtc.org,nisse@webrtc.org,kthelgason@webrtc.org Change-Id: Ic8ed4cc3baf43d639ce13cae256c007728c3ad92 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:9535 Reviewed-on: https://webrtc-review.googlesource.com/c/109884 Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25547}
2018-11-07 14:29:54 +00:00
"../../modules/audio_processing:api",
Make AEC3 the default desktop AEC option in WebRTC Bug: webrtc:10366 Change-Id: I854ed62df1da489fdab43e9157dff79b7287cacb Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/125081 Reviewed-by: Sam Zackrisson <saza@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Per Åhgren <peah@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26983}
2019-03-06 04:16:46 +01:00
"../../modules/audio_processing:audio_buffer",
APM: Add build flag to allow building WebRTC without APM This CL adds a build flag to allow building the non-test parts of WebRTC without the audio processing module. The CL also ensures that the WebRTC code correctly handles the case when no APM is available. Bug: webrtc:5298 Change-Id: I5c8b5d1f7115e5cce2af4c2b5ff701fa1c54e49e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/171509 Commit-Queue: Per Åhgren <peah@webrtc.org> Reviewed-by: Sam Zackrisson <saza@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31133}
2020-04-26 23:56:17 +02:00
"../../modules/audio_processing:audioproc_test_utils",
Separate build targets for aec3 and aec3_unittests Bug: webrtc:8844 Change-Id: Id6a98eae19aaedc87c3f402a004f58f0290d5c28 Reviewed-on: https://webrtc-review.googlesource.com/56580 Commit-Queue: Gustaf Ullberg <gustaf@webrtc.org> Reviewed-by: Alex Loiko <aleloi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22173}
2018-02-23 13:18:29 +01:00
"../../modules/audio_processing/aec3",
Increasing APM fuzzer coverage. Add AecDump to the list of fuzzed stuff. Attaches an AecDump to the Audio Processing Module in the APM-fuzzer. The AecDump writes to /dev/null. Bug: webrtc:7820 Change-Id: I03916ce4d1c69906ca8bb7e6fbe29c11e4ea55e5 Reviewed-on: https://webrtc-review.googlesource.com/c/107622 Reviewed-by: Sam Zackrisson <saza@webrtc.org> Commit-Queue: Alex Loiko <aleloi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25321}
2018-10-23 13:43:28 +02:00
"../../modules/audio_processing/aec_dump",
"../../modules/audio_processing/aec_dump:aec_dump_impl",
Fixed Digital mode of AGC2 implementation finished. This CL adds the GainCurveApplier (GCA). It owns a FixedDigitalLevelEstimator (LE) and an InterpolatedGainCurve (IGC). The GCA uses the LE to compute the input signal level, looks up a gain from IGC and applies it on the signal. The other IGC and LE submodules were added in previous CLs [1] and [2]. This CL also turns on AGC2 in the APM fuzzer. [1] https://webrtc-review.googlesource.com/c/src/+/51920 [2] https://webrtc-review.googlesource.com/c/src/+/52381 Bug: webrtc:7949 Change-Id: Idb10cc3ca9d6d2e4ac5824cc3391ed8aa680f6cd Reviewed-on: https://webrtc-review.googlesource.com/54361 Commit-Queue: Alex Loiko <aleloi@webrtc.org> Reviewed-by: Sam Zackrisson <saza@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22103}
2018-02-20 15:58:36 +01:00
"../../rtc_base:rtc_base_approved",
Increasing APM fuzzer coverage. Add AecDump to the list of fuzzed stuff. Attaches an AecDump to the Audio Processing Module in the APM-fuzzer. The AecDump writes to /dev/null. Bug: webrtc:7820 Change-Id: I03916ce4d1c69906ca8bb7e6fbe29c11e4ea55e5 Reviewed-on: https://webrtc-review.googlesource.com/c/107622 Reviewed-by: Sam Zackrisson <saza@webrtc.org> Commit-Queue: Alex Loiko <aleloi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25321}
2018-10-23 13:43:28 +02:00
"../../rtc_base:rtc_task_queue",
Separate build target for rtc_base/numerics/safe_minmax.h So that we can avoid dependency cycles. Bug: none Change-Id: I821d9f1319dff01403d6e4e310cbb2d4b2b125e8 Reviewed-on: https://webrtc-review.googlesource.com/60500 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22328}
2018-03-07 14:18:56 +01:00
"../../rtc_base:safe_minmax",
Remove deprecated field_trial_default and metrics_default. This CL removes some deprecated build targets (and their headers) from system_wrappers: - field_trial_api - field_trial_default - metrics_api - metrics_default It also refreshes all the dependencies on field_trial.h and metrics.h. A nice side effect is that it is finally possible to remove 'nogncheck' from the following files (when it was used with field_trial_default and metrics_default): - sdk/objc/api/peerconnection/RTCMetricsSampleInfo+Private.h - sdk/android/src/jni/pc/peerconnectionfactory.cc - sdk/objc/api/peerconnection/RTCFieldTrials.mm Bug: webrtc:9631 Change-Id: Ib621f41ef8ad0aba4fe1c1d7e749c044afc956c3 No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/100524 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24878}
2018-09-28 08:51:10 +02:00
"../../system_wrappers:field_trial",
AEC-m and AEC-2 fuzzing. Going through the coverage of audio_processing_fuzzer, it was noticed that it didn't cover AEC-m and AEC-2 code. Therefore this CL adds 2 fuzzer targets that only fuzz the previous generation echo cancellers. To avoid code duplication, the APM running code was broken out in a new GN target. We have also changed all fuzzing code to use the FuzzDataHelper class to avoid manual pointer arithmetic. Bug: webrtc:7820 Change-Id: Ifea3266e396b487952a736945577fccea15d0e01 Reviewed-on: https://webrtc-review.googlesource.com/36500 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Reviewed-by: Sam Zackrisson <saza@webrtc.org> Commit-Queue: Alex Loiko <aleloi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21638}
2018-01-16 12:50:34 +01:00
]
Add absl_deps to webrtc_fuzzer_test. Bug: chromium:1046390 Change-Id: I531511dce156a10174c9ed80ccb2d5cd75ec33b0 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/177900 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31553}
2020-06-23 23:39:56 +02:00
absl_deps = [ "//third_party/abseil-cpp/absl/memory" ]
Template argument and corpora for Audio Processing Fuzzer. We found out that int16_t x = test::FuzzDataHelper::ReadOrDefaultValue(0) reads 4 bytes from the fuzzer input instead of 2. That means that almost half the bits in the input data to audio_processing_fuzzer are ignored. This change adds template arguments to force reading 2 bytes when we only need 2. We also add a small manually generated corpus. During local testing we let the fuzzer run for a few hours on an empty corpus. Adding the manually-generated files resulted in an immediate coverage increase by ~3%, and then by another 3% over the next few hours. The manually generated corpus contains a short segment of speech with real echo. We suspect that triggering Voice Activity Detection or echo estimation filter convergence can be difficult for an automatic fuzzer. We remove the Level Controller config. We read 20 bytes extra after the config to guard against future configuration changes. Bug: webrtc:7820 Change-Id: If60c04f53b27c519c349a40bd13664eef7999368 Reviewed-on: https://webrtc-review.googlesource.com/58744 Reviewed-by: Sam Zackrisson <saza@webrtc.org> Commit-Queue: Alex Loiko <aleloi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22269}
2018-03-02 13:53:09 +01:00
seed_corpus = "corpora/audio_processing-corpus"
AEC-m and AEC-2 fuzzing. Going through the coverage of audio_processing_fuzzer, it was noticed that it didn't cover AEC-m and AEC-2 code. Therefore this CL adds 2 fuzzer targets that only fuzz the previous generation echo cancellers. To avoid code duplication, the APM running code was broken out in a new GN target. We have also changed all fuzzing code to use the FuzzDataHelper class to avoid manual pointer arithmetic. Bug: webrtc:7820 Change-Id: Ifea3266e396b487952a736945577fccea15d0e01 Reviewed-on: https://webrtc-review.googlesource.com/36500 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Reviewed-by: Sam Zackrisson <saza@webrtc.org> Commit-Queue: Alex Loiko <aleloi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21638}
2018-01-16 12:50:34 +01:00
}
Add AGC1 fuzzer Fuzzes the config and audio inputs to GainControlImpl. Seems able to cover a few hundred lines of code that the APM fuzzer hasn't been able to reach. Bug: webrtc:9413 Change-Id: I32776505be9c416ec03113c12437a92dcfadd827 Reviewed-on: https://webrtc-review.googlesource.com/84589 Commit-Queue: Sam Zackrisson <saza@webrtc.org> Reviewed-by: Alex Loiko <aleloi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23709}
2018-06-21 14:09:16 +02:00
webrtc_fuzzer_test("agc_fuzzer") {
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "agc_fuzzer.cc" ]
Add AGC1 fuzzer Fuzzes the config and audio inputs to GainControlImpl. Seems able to cover a few hundred lines of code that the APM fuzzer hasn't been able to reach. Bug: webrtc:9413 Change-Id: I32776505be9c416ec03113c12437a92dcfadd827 Reviewed-on: https://webrtc-review.googlesource.com/84589 Commit-Queue: Sam Zackrisson <saza@webrtc.org> Reviewed-by: Alex Loiko <aleloi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23709}
2018-06-21 14:09:16 +02:00
deps = [
":fuzz_data_helper",
"../../modules/audio_processing",
Reland "Isolating APM API build target: making :api an actual target." This reverts commit 61c6e5643e7ea058e653956980a90e033249c055. Reason for revert: downstream projects prepared for this change Original change's description: > Revert "Isolating APM API build target: making :api an actual target." > > This reverts commit a7f77a7c05b5d26520fd01a773ffb2c8b15b60ff. > > Reason for revert: breaking downstream > > Original change's description: > > Isolating APM API build target: making :api an actual target. > > > > This CL is part of a refactoring work to unblock other CLs > > that would generate a circular dependency when including > > modules/audio_processing. It will also allow to easily move > > the APM interface part under //api. > > > > More in detail, this change moves the APM interface files from > > the build target modules/audio_processing to > > modules/audio_processing:api. It also adds :api as dependency > > where needed. > > > > Bug: webrtc:9535 > > Change-Id: I72829e22d08ba4d75985f0421e6e8bf0216ebecd > > Reviewed-on: https://webrtc-review.googlesource.com/c/109501 > > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > > Reviewed-by: Kári Helgason <kthelgason@webrtc.org> > > Reviewed-by: Niels Moller <nisse@webrtc.org> > > Reviewed-by: Sam Zackrisson <saza@webrtc.org> > > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#25539} > > TBR=saza@webrtc.org,alessiob@webrtc.org,kwiberg@webrtc.org,nisse@webrtc.org,kthelgason@webrtc.org > > Change-Id: I974c6237311e7c06970aa62e5f6940f3aa80113d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:9535 > Reviewed-on: https://webrtc-review.googlesource.com/c/109820 > Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#25540} TBR=saza@webrtc.org,alessiob@webrtc.org,kwiberg@webrtc.org,nisse@webrtc.org,kthelgason@webrtc.org Change-Id: Ic8ed4cc3baf43d639ce13cae256c007728c3ad92 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:9535 Reviewed-on: https://webrtc-review.googlesource.com/c/109884 Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25547}
2018-11-07 14:29:54 +00:00
"../../modules/audio_processing:api",
Make AEC3 the default desktop AEC option in WebRTC Bug: webrtc:10366 Change-Id: I854ed62df1da489fdab43e9157dff79b7287cacb Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/125081 Reviewed-by: Sam Zackrisson <saza@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Per Åhgren <peah@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26983}
2019-03-06 04:16:46 +01:00
"../../modules/audio_processing:audio_buffer",
Add AGC1 fuzzer Fuzzes the config and audio inputs to GainControlImpl. Seems able to cover a few hundred lines of code that the APM fuzzer hasn't been able to reach. Bug: webrtc:9413 Change-Id: I32776505be9c416ec03113c12437a92dcfadd827 Reviewed-on: https://webrtc-review.googlesource.com/84589 Commit-Queue: Sam Zackrisson <saza@webrtc.org> Reviewed-by: Alex Loiko <aleloi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23709}
2018-06-21 14:09:16 +02:00
"../../rtc_base:rtc_base_approved",
"../../rtc_base:safe_minmax",
]
seed_corpus = "corpora/agc-corpus"
}
Add AEC3 config json parsing fuzzer Bug: webrtc:9535 Change-Id: Ic659a31b6d5b26a07aee955a5b83e889122b4705 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157306 Reviewed-by: Ivo Creusen <ivoc@webrtc.org> Commit-Queue: Sam Zackrisson <saza@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29520}
2019-10-17 17:56:21 +02:00
webrtc_fuzzer_test("aec3_config_json_fuzzer") {
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "aec3_config_json_fuzzer.cc" ]
Add AEC3 config json parsing fuzzer Bug: webrtc:9535 Change-Id: Ic659a31b6d5b26a07aee955a5b83e889122b4705 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157306 Reviewed-by: Ivo Creusen <ivoc@webrtc.org> Commit-Queue: Sam Zackrisson <saza@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29520}
2019-10-17 17:56:21 +02:00
deps = [
":fuzz_data_helper",
"../../api/audio:aec3_config",
"../../api/audio:aec3_config_json",
]
dict = "//testing/libfuzzer/fuzzers/dicts/json.dict"
seed_corpus = "corpora/aec3-config-json-corpus"
}
Fuzz AEC3 This fuzzer fuzzes AEC3 with the default configuration and variable sample rates and channel counts. Bug: None Change-Id: I0d178a320b75fc4cc389657fa2b99931f359b517 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/160646 Commit-Queue: Sam Zackrisson <saza@webrtc.org> Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29967}
2019-11-26 18:55:02 +01:00
webrtc_fuzzer_test("aec3_fuzzer") {
defines = []
if (apm_debug_dump) {
defines += [ "WEBRTC_APM_DEBUG_DUMP=1" ]
} else {
defines += [ "WEBRTC_APM_DEBUG_DUMP=0" ]
}
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "aec3_fuzzer.cc" ]
Fuzz AEC3 This fuzzer fuzzes AEC3 with the default configuration and variable sample rates and channel counts. Bug: None Change-Id: I0d178a320b75fc4cc389657fa2b99931f359b517 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/160646 Commit-Queue: Sam Zackrisson <saza@webrtc.org> Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29967}
2019-11-26 18:55:02 +01:00
deps = [
":fuzz_data_helper",
Fix aec3_fuzzer chromium build config. Dependencies need to use relative paths in order to work in Chromium, see [1]. [1] - https://ci.chromium.org/p/chromium/builders/try/linux-libfuzzer-asan-rel/334174 TBR: saza@webrtc.org Bug: None Change-Id: I50c401e5983fbb501d1da2ad909198261a8cb940 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161300 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30000}
2019-12-04 11:01:52 +01:00
"../../modules/audio_processing:api",
Fuzz AEC3 This fuzzer fuzzes AEC3 with the default configuration and variable sample rates and channel counts. Bug: None Change-Id: I0d178a320b75fc4cc389657fa2b99931f359b517 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/160646 Commit-Queue: Sam Zackrisson <saza@webrtc.org> Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29967}
2019-11-26 18:55:02 +01:00
"../../modules/audio_processing:audio_buffer",
"../../modules/audio_processing/aec3",
]
}
Create a fuzzer for ComfortNoiseDecoder The fuzzer will hammer on the UpdateSid and Generate methods of ComfortNoiseDecoder. The change also includes a fix to an issue in WebRtcSpl_FilterAR, which was immediately found by running the fuzzer locally. Bug: none Change-Id: I5283427cb27844fb953e2caa35423ea873aca2ff Reviewed-on: https://webrtc-review.googlesource.com/28100 Commit-Queue: Henrik Lundin <henrik.lundin@webrtc.org> Reviewed-by: Sam Zackrisson <saza@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21134}
2017-12-07 09:21:36 +01:00
webrtc_fuzzer_test("comfort_noise_decoder_fuzzer") {
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "comfort_noise_decoder_fuzzer.cc" ]
Create a fuzzer for ComfortNoiseDecoder The fuzzer will hammer on the UpdateSid and Generate methods of ComfortNoiseDecoder. The change also includes a fix to an issue in WebRtcSpl_FilterAR, which was immediately found by running the fuzzer locally. Bug: none Change-Id: I5283427cb27844fb953e2caa35423ea873aca2ff Reviewed-on: https://webrtc-review.googlesource.com/28100 Commit-Queue: Henrik Lundin <henrik.lundin@webrtc.org> Reviewed-by: Sam Zackrisson <saza@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21134}
2017-12-07 09:21:36 +01:00
deps = [
"../../api:array_view",
Hide the AudioEncoderCng class behind a create function And put codecs/cng/webrtc_cng.h in a non-public build target while we're at it. Bug: webrtc:8396 Change-Id: I9f51dffadfb645cd1454617fad30e09d639ff53c Reviewed-on: https://webrtc-review.googlesource.com/c/108782 Reviewed-by: Ivo Creusen <ivoc@webrtc.org> Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25486}
2018-11-01 11:13:44 +01:00
"../../modules/audio_coding:webrtc_cng",
Create a fuzzer for ComfortNoiseDecoder The fuzzer will hammer on the UpdateSid and Generate methods of ComfortNoiseDecoder. The change also includes a fix to an issue in WebRtcSpl_FilterAR, which was immediately found by running the fuzzer locally. Bug: none Change-Id: I5283427cb27844fb953e2caa35423ea873aca2ff Reviewed-on: https://webrtc-review.googlesource.com/28100 Commit-Queue: Henrik Lundin <henrik.lundin@webrtc.org> Reviewed-by: Sam Zackrisson <saza@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21134}
2017-12-07 09:21:36 +01:00
"../../rtc_base:rtc_base_approved",
]
}
Add fuzzer test for RtpDepacketizerAv1::AssembleFrame function Bug: webrtc:11042 Change-Id: If5b7e0d81fd8c6590823ecab8f3909ed6c824f06 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/160016 Reviewed-by: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Sam Zackrisson <saza@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29893}
2019-11-21 16:05:25 +01:00
webrtc_fuzzer_test("rtp_depacketizer_av1_assemble_frame_fuzzer") {
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "rtp_depacketizer_av1_assemble_frame_fuzzer.cc" ]
Fix undefined-shift in RtpDepacketizerAv1::AssembleFrame Bug: chromium:1028348 Change-Id: I824e84138acbf4e73fc21ee8248e29e5cc7a0ba0 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/160643 Reviewed-by: Sam Zackrisson <saza@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29945}
2019-11-26 10:13:07 +01:00
seed_corpus = "corpora/rtp-depacketizer-av1-assemble-frame-corpus"
Add fuzzer test for RtpDepacketizerAv1::AssembleFrame function Bug: webrtc:11042 Change-Id: If5b7e0d81fd8c6590823ecab8f3909ed6c824f06 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/160016 Reviewed-by: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Sam Zackrisson <saza@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29893}
2019-11-21 16:05:25 +01:00
deps = [
":fuzz_data_helper",
"../../api:array_view",
"../../modules/rtp_rtcp",
]
}
Add fuzzer testing for Dependency Descriptor rtp header extension Bug: webrtc:10342 Change-Id: I46c61b9a137a7148ed80ad38da62132dacb270f8 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153662 Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Sam Zackrisson <saza@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29255}
2019-09-20 12:24:56 +02:00
webrtc_fuzzer_test("rtp_dependency_descriptor_fuzzer") {
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "rtp_dependency_descriptor_fuzzer.cc" ]
Add fuzzer testing for Dependency Descriptor rtp header extension Bug: webrtc:10342 Change-Id: I46c61b9a137a7148ed80ad38da62132dacb270f8 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153662 Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Sam Zackrisson <saza@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29255}
2019-09-20 12:24:56 +02:00
seed_corpus = "corpora/dependency_descriptor-corpus"
deps = [
"../../api:array_view",
"../../common_video/generic_frame_descriptor",
"../../modules/rtp_rtcp:rtp_rtcp_format",
"../../rtc_base:checks",
]
}
RtpFrameReferenceFinder fuzzer. Bug: webrtc:7728 Change-Id: I641772837384a4d8070db2138b93f4157f997d03 Reviewed-on: https://webrtc-review.googlesource.com/74584 Commit-Queue: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Stefan Holmer <stefan@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23271}
2018-05-16 14:06:13 +02:00
webrtc_fuzzer_test("rtp_frame_reference_finder_fuzzer") {
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "rtp_frame_reference_finder_fuzzer.cc" ]
RtpFrameReferenceFinder fuzzer. Bug: webrtc:7728 Change-Id: I641772837384a4d8070db2138b93f4157f997d03 Reviewed-on: https://webrtc-review.googlesource.com/74584 Commit-Queue: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Stefan Holmer <stefan@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23271}
2018-05-16 14:06:13 +02:00
deps = [
Add plumbing of RtpPacketInfos to each VideoFrame as input for SourceTracker. This change adds the plumbing of RtpPacketInfo from RtpVideoStreamReceiver::OnRtpPacket() to VideoReceiveStream::OnFrame() for video. It is a step towards replacing the non-spec compliant ContributingSources that updates itself at packet-receive time, with the spec-compliant SourceTracker that will update itself at frame-delivery-to-track time. Bug: webrtc:10668 Change-Id: Ib97d430530c5a8487d3b129936c7c51e118889bd Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/139891 Reviewed-by: Stefan Holmer <stefan@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Commit-Queue: Chen Xing <chxg@google.com> Cr-Commit-Position: refs/heads/master@{#28332}
2019-06-20 10:05:55 +02:00
"../../api:rtp_packet_info",
Remove rtc_base/scoped_ref_ptr.h. The type rtc::scoped_refptr<T> is now part of api/. Please include it from api/scoped_refptr.h. More info: See: https://groups.google.com/forum/#!topic/discuss-webrtc/Mme2MSz4z4o. Bug: webrtc:9887, webrtc:8205 No-Try: True Change-Id: Ic6c7c81e226e59f12f7933e472f573ae097b55bf Reviewed-on: https://webrtc-review.googlesource.com/c/119041 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26414}
2019-01-25 20:26:48 +01:00
"../../api:scoped_refptr",
RtpFrameReferenceFinder fuzzer. Bug: webrtc:7728 Change-Id: I641772837384a4d8070db2138b93f4157f997d03 Reviewed-on: https://webrtc-review.googlesource.com/74584 Commit-Queue: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Stefan Holmer <stefan@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23271}
2018-05-16 14:06:13 +02:00
"../../modules/video_coding/",
"../../system_wrappers",
]
}
Fuzzing for video_coding::FrameBuffer2. Bug: webrtc:7728 Change-Id: I712289a82d408dde1db73a1cc44f0c69a6b639ff Reviewed-on: https://webrtc-review.googlesource.com/31841 Commit-Queue: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Stefan Holmer <stefan@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23282}
2018-05-17 13:34:53 +02:00
webrtc_fuzzer_test("frame_buffer2_fuzzer") {
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "frame_buffer2_fuzzer.cc" ]
Fuzzing for video_coding::FrameBuffer2. Bug: webrtc:7728 Change-Id: I712289a82d408dde1db73a1cc44f0c69a6b639ff Reviewed-on: https://webrtc-review.googlesource.com/31841 Commit-Queue: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Stefan Holmer <stefan@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23282}
2018-05-17 13:34:53 +02:00
deps = [
"../../modules/video_coding/",
Remove unused NextFrame function from FrameBuffer. Also updated FrameBuffer unittests to use the GlobalSimulatedTimeController. Bug: webrtc:7408, webrtc:9378 Change-Id: I8ade27492f66cdd8950b38f5f4a268714dbc35fc Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/164536 Reviewed-by: Sam Zackrisson <saza@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Commit-Queue: Philip Eliasson <philipel@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30422}
2020-01-29 17:36:11 +01:00
"../time_controller:time_controller",
Fuzzing for video_coding::FrameBuffer2. Bug: webrtc:7728 Change-Id: I712289a82d408dde1db73a1cc44f0c69a6b639ff Reviewed-on: https://webrtc-review.googlesource.com/31841 Commit-Queue: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Stefan Holmer <stefan@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23282}
2018-05-17 13:34:53 +02:00
]
}
Basic fuzzing of rtc::s_url_decode. rtc::s_url_decode internally calls transform on rtc::url_decode which operates on raw char buffers. This is used in some core parts of ice server parsing so it makes sense to add at least a basic fuzzer here. Corpus generation will be tailored in a future CL. Bug: webrtc:10117 Change-Id: If1685601c746c4a9f88c2a8d396eeb3f1b1688d4 Reviewed-on: https://webrtc-review.googlesource.com/c/113835 Commit-Queue: Benjamin Wright <benwright@webrtc.org> Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25980}
2018-12-11 16:35:04 -08:00
Field trial fuzzer. This simple fuzzer is intended to detect potential issues in the field trial parsing code. Since these can be set by the browser it is better to have some fuzzing coverage around this area. Bug: webrtc:10395 Change-Id: I1b8b859d2107a0bc99cb7520cf0ef96f3d110547 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127121 Commit-Queue: Benjamin Wright <benwright@webrtc.org> Reviewed-by: Qingsi Wang <qingsi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27087}
2019-03-12 10:56:05 -07:00
webrtc_fuzzer_test("field_trial_fuzzer") {
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "field_trial_fuzzer.cc" ]
deps = [ "../../system_wrappers:field_trial" ]
Field trial fuzzer. This simple fuzzer is intended to detect potential issues in the field trial parsing code. Since these can be set by the browser it is better to have some fuzzing coverage around this area. Bug: webrtc:10395 Change-Id: I1b8b859d2107a0bc99cb7520cf0ef96f3d110547 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127121 Commit-Queue: Benjamin Wright <benwright@webrtc.org> Reviewed-by: Qingsi Wang <qingsi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27087}
2019-03-12 10:56:05 -07:00
seed_corpus = "corpora/field_trial-corpus"
}
Fuzz rtc::StringToNumber. StringToNumber is directly used in parsing the SDP so it should be fuzzed. Bug: webrtc:10395 Change-Id: I85b520fbefd34d3dba49950c5ff297b482c572b1 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127123 Commit-Queue: Benjamin Wright <benwright@webrtc.org> Reviewed-by: Qingsi Wang <qingsi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27089}
2019-03-12 14:03:33 -07:00
webrtc_fuzzer_test("string_to_number_fuzzer") {
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "string_to_number_fuzzer.cc" ]
deps = [ "../../rtc_base:rtc_base_approved" ]
Fuzz rtc::StringToNumber. StringToNumber is directly used in parsing the SDP so it should be fuzzed. Bug: webrtc:10395 Change-Id: I85b520fbefd34d3dba49950c5ff297b482c572b1 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127123 Commit-Queue: Benjamin Wright <benwright@webrtc.org> Reviewed-by: Qingsi Wang <qingsi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27089}
2019-03-12 14:03:33 -07:00
seed_corpus = "corpora/string_to_number-corpus"
}
Add Fuzzing support for ParseRtcpPacketSenderSsrc. This function is called on each incoming RTCP payload. Bug: webrtc:10395 Change-Id: I164746fe45912cc503565e77046b5d884e0204e6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127122 Commit-Queue: Benjamin Wright <benwright@webrtc.org> Reviewed-by: Qingsi Wang <qingsi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27110}
2019-03-12 17:00:25 -07:00
Integrate parsing of SCTP messages into WebRTC Fuzzers. This change adds a basic fuzzer to exercise parsing of SCTP messages. Bug: webrtc:10395 Change-Id: I1fd7a8560add3463c1978ebcad30082ae31f2073 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127042 Reviewed-by: Steve Anton <steveanton@webrtc.org> Reviewed-by: Qingsi Wang <qingsi@webrtc.org> Commit-Queue: Benjamin Wright <benwright@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27113}
2019-03-13 10:59:12 -07:00
webrtc_fuzzer_test("sctp_utils_fuzzer") {
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "sctp_utils_fuzzer.cc" ]
Integrate parsing of SCTP messages into WebRTC Fuzzers. This change adds a basic fuzzer to exercise parsing of SCTP messages. Bug: webrtc:10395 Change-Id: I1fd7a8560add3463c1978ebcad30082ae31f2073 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127042 Reviewed-by: Steve Anton <steveanton@webrtc.org> Reviewed-by: Qingsi Wang <qingsi@webrtc.org> Commit-Queue: Benjamin Wright <benwright@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27113}
2019-03-13 10:59:12 -07:00
deps = [
"../../api:libjingle_peerconnection_api",
"../../pc:libjingle_peerconnection",
Reland "Reland "Refactor SCTP data channels to use DataChannelTransportInterface."" This is a reland of 487f9a17e426fd14bb06b13e861071b3f15d119b Original change's description: > Reland "Refactor SCTP data channels to use DataChannelTransportInterface." > > Also clears SctpTransport before deleting JsepTransport. > > SctpTransport is ref-counted, but the underlying transport is deleted when > JsepTransport clears the rtp_dtls_transport. This results in crashes when > usrsctp attempts to send outgoing packets through a dangling pointer to the > underlying transport. > > Clearing SctpTransport before DtlsTransport removes the pointer to the > underlying transport before it becomes invalid. > > This fixes a crash in chromium's web platform tests (see > https://chromium-review.googlesource.com/c/chromium/src/+/1776711). > > Original change's description: > > Refactor SCTP data channels to use DataChannelTransportInterface. > > > > This change moves SctpTransport to be owned by JsepTransport, which now > > holds a DataChannelTransport implementation for SCTP when it is used for > > data channels. > > > > This simplifies negotiation and fallback to SCTP. Negotiation can now > > use a composite DataChannelTransport, just as negotiation for RTP uses a > > composite RTP transport. > > > > PeerConnection also has one fewer way it needs to manage data channels. > > It now handles SCTP and datagram- or media-transport-based data channels > > the same way. > > > > There are a few leaky abstractions left. For example, PeerConnection > > calls Start() on the SctpTransport at a particular point in negotiation, > > but does not need to call this for other transports. Similarly, PC > > exposes an interface to the SCTP transport directly to the user; there > > is no equivalent for other transports. > > Bug: webrtc:9719 > Change-Id: I64e94b88afb119fdbf5f22750f88c8a084d53937 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151981 > Reviewed-by: Benjamin Wright <benwright@webrtc.org> > Reviewed-by: Steve Anton <steveanton@webrtc.org> > Commit-Queue: Benjamin Wright <benwright@webrtc.org> > Commit-Queue: Bjorn Mellem <mellem@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#29120} Bug: webrtc:9719 Change-Id: I28481a3de64a3506bc57748106383eeba4ef205c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/152740 Reviewed-by: Artem Titov <titovartem@webrtc.org> Reviewed-by: Benjamin Wright <benwright@webrtc.org> Reviewed-by: Seth Hampson <shampson@webrtc.org> Commit-Queue: Bjorn Mellem <mellem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29290}
2019-09-23 14:53:54 -07:00
"../../pc:rtc_pc_base",
Integrate parsing of SCTP messages into WebRTC Fuzzers. This change adds a basic fuzzer to exercise parsing of SCTP messages. Bug: webrtc:10395 Change-Id: I1fd7a8560add3463c1978ebcad30082ae31f2073 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127042 Reviewed-by: Steve Anton <steveanton@webrtc.org> Reviewed-by: Qingsi Wang <qingsi@webrtc.org> Commit-Queue: Benjamin Wright <benwright@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27113}
2019-03-13 10:59:12 -07:00
"../../rtc_base:rtc_base_approved",
]
}
dcsctp: Add socket fuzzer Bug: webrtc:12614 Change-Id: I43659e96fbd44a10b3e8d690602afa4673df1228 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/218501 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Victor Boivie <boivie@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34008}
2021-04-11 19:56:36 +02:00
webrtc_fuzzer_test("dcsctp_socket_fuzzer") {
sources = [ "dcsctp_socket_fuzzer.cc" ]
deps = [
"../../net/dcsctp/fuzzers:dcsctp_fuzzers",
"../../net/dcsctp/public:socket",
"../../net/dcsctp/public:types",
"../../net/dcsctp/socket:dcsctp_socket",
"../../rtc_base:rtc_base_approved",
]
}
SSLCertificate basic fuzzer. This change simply calls through all code paths in the SSLCertificate interface after passing in an untrusted PEM string. Corpus will follow in another CL. Bug: webrtc:10395 Change-Id: I001642fa89a84ce01505780f5e76f01a0e46a785 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127640 Commit-Queue: Benjamin Wright <benwright@webrtc.org> Reviewed-by: Steve Anton <steveanton@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27118}
2019-03-13 16:59:54 -07:00
webrtc_fuzzer_test("ssl_certificate_fuzzer") {
Fix ssl_certificate_fuzzer Bug: webrtc:10395 Change-Id: Iba79f257c427545c36052e74296d3c07a166ee7d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/225540 Reviewed-by: Sam Zackrisson <saza@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34446}
2021-07-08 16:21:31 +00:00
sources = [ "ssl_certificate_fuzzer.cc" ]
deps = [
"../:rtp_test_utils",
"../../rtc_base",
"../../rtc_base:stringutils",
]
SSLCertificate basic fuzzer. This change simply calls through all code paths in the SSLCertificate interface after passing in an untrusted PEM string. Corpus will follow in another CL. Bug: webrtc:10395 Change-Id: I001642fa89a84ce01505780f5e76f01a0e46a785 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127640 Commit-Queue: Benjamin Wright <benwright@webrtc.org> Reviewed-by: Steve Anton <steveanton@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27118}
2019-03-13 16:59:54 -07:00
}
Fuzzing support for RTPDump VP8 and VP9 Streams. This change integrates fuzzing support for RtpDumps in WebRTC. This allows LibFuzzer to directly fuzz the RTP code path from packet arrival all the way to actual decoding and rendering. It does this by replaying each RTP packet in the RTPDump which can be mutated directly by the fuzzer. For fuzzing support the RtpFileReader needs to support reading from a buffer instead of an file. The test class requires FILE* for all its parsing operations and is deeply coupled this way. I chose to solve this problem at an OS level by using the tmpfile() option and copying the buffer to the tmpfile(). fmemopen() is no available on most platforms so couldn't be used as a generic solution. The additional copy isn't ideal but won't be a bottleneck for the fuzzing. In the future I plan for the fuzzers to read from a configuration file. But given the current packaging strategy for fuzzers in WebRTC this isn't easy. Bug: webrtc:9860 Change-Id: I2560120e82663f9e9fb5b9640e6a6d16f9c1a360 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126682 Reviewed-by: Niels Moller <nisse@webrtc.org> Commit-Queue: Benjamin Wright <benwright@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27151}
2019-03-14 15:01:30 -07:00
webrtc_fuzzer_test("vp8_replay_fuzzer") {
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "vp8_replay_fuzzer.cc" ]
Fuzzing support for RTPDump VP8 and VP9 Streams. This change integrates fuzzing support for RtpDumps in WebRTC. This allows LibFuzzer to directly fuzz the RTP code path from packet arrival all the way to actual decoding and rendering. It does this by replaying each RTP packet in the RTPDump which can be mutated directly by the fuzzer. For fuzzing support the RtpFileReader needs to support reading from a buffer instead of an file. The test class requires FILE* for all its parsing operations and is deeply coupled this way. I chose to solve this problem at an OS level by using the tmpfile() option and copying the buffer to the tmpfile(). fmemopen() is no available on most platforms so couldn't be used as a generic solution. The additional copy isn't ideal but won't be a bottleneck for the fuzzing. In the future I plan for the fuzzers to read from a configuration file. But given the current packaging strategy for fuzzers in WebRTC this isn't easy. Bug: webrtc:9860 Change-Id: I2560120e82663f9e9fb5b9640e6a6d16f9c1a360 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126682 Reviewed-by: Niels Moller <nisse@webrtc.org> Commit-Queue: Benjamin Wright <benwright@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27151}
2019-03-14 15:01:30 -07:00
deps = [
"../../rtc_base:rtc_base_approved",
"utils:rtp_replayer",
]
seed_corpus = "corpora/rtpdump-corpus/vp8"
}
Add fuzzer to validate libvpx vp9 encoder wrapper Fix simulcast svc controller to reuse dropped frame configuration, same as full svc and k-svc controllers do. This fuzzer reminded the issue was still there. This is a reland of https://webrtc-review.googlesource.com/c/src/+/212281 Bug: webrtc:11999 Change-Id: Id3b2cd6c7e0923adfffb4e04c35ed2d6faca6704 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/215921 Reviewed-by: Erik Språng <sprang@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33802}
2021-04-21 14:35:54 +02:00
if (rtc_build_libvpx) {
webrtc_fuzzer_test("vp9_encoder_references_fuzzer") {
sources = [ "vp9_encoder_references_fuzzer.cc" ]
deps = [
"..:test_support",
"../../api:array_view",
"../../api/transport:webrtc_key_value_config",
"../../api/video:video_frame",
"../../api/video_codecs:video_codecs_api",
"../../modules/video_coding:frame_dependencies_calculator",
"../../modules/video_coding:mock_libvpx_interface",
"../../modules/video_coding:webrtc_vp9",
"../../rtc_base:safe_compare",
rtc_libvpx_dir,
]
absl_deps = [
"//third_party/abseil-cpp/absl/algorithm:container",
"//third_party/abseil-cpp/absl/base:core_headers",
"//third_party/abseil-cpp/absl/container:inlined_vector",
]
defines = [ "RTC_ENABLE_VP9" ]
}
}
Fuzzing support for RTPDump VP8 and VP9 Streams. This change integrates fuzzing support for RtpDumps in WebRTC. This allows LibFuzzer to directly fuzz the RTP code path from packet arrival all the way to actual decoding and rendering. It does this by replaying each RTP packet in the RTPDump which can be mutated directly by the fuzzer. For fuzzing support the RtpFileReader needs to support reading from a buffer instead of an file. The test class requires FILE* for all its parsing operations and is deeply coupled this way. I chose to solve this problem at an OS level by using the tmpfile() option and copying the buffer to the tmpfile(). fmemopen() is no available on most platforms so couldn't be used as a generic solution. The additional copy isn't ideal but won't be a bottleneck for the fuzzing. In the future I plan for the fuzzers to read from a configuration file. But given the current packaging strategy for fuzzers in WebRTC this isn't easy. Bug: webrtc:9860 Change-Id: I2560120e82663f9e9fb5b9640e6a6d16f9c1a360 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126682 Reviewed-by: Niels Moller <nisse@webrtc.org> Commit-Queue: Benjamin Wright <benwright@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27151}
2019-03-14 15:01:30 -07:00
webrtc_fuzzer_test("vp9_replay_fuzzer") {
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "vp9_replay_fuzzer.cc" ]
Fuzzing support for RTPDump VP8 and VP9 Streams. This change integrates fuzzing support for RtpDumps in WebRTC. This allows LibFuzzer to directly fuzz the RTP code path from packet arrival all the way to actual decoding and rendering. It does this by replaying each RTP packet in the RTPDump which can be mutated directly by the fuzzer. For fuzzing support the RtpFileReader needs to support reading from a buffer instead of an file. The test class requires FILE* for all its parsing operations and is deeply coupled this way. I chose to solve this problem at an OS level by using the tmpfile() option and copying the buffer to the tmpfile(). fmemopen() is no available on most platforms so couldn't be used as a generic solution. The additional copy isn't ideal but won't be a bottleneck for the fuzzing. In the future I plan for the fuzzers to read from a configuration file. But given the current packaging strategy for fuzzers in WebRTC this isn't easy. Bug: webrtc:9860 Change-Id: I2560120e82663f9e9fb5b9640e6a6d16f9c1a360 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126682 Reviewed-by: Niels Moller <nisse@webrtc.org> Commit-Queue: Benjamin Wright <benwright@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27151}
2019-03-14 15:01:30 -07:00
deps = [
"../../rtc_base:rtc_base_approved",
"utils:rtp_replayer",
]
seed_corpus = "corpora/rtpdump-corpus/vp9"
}
Reference in New Issue Copy Permalink