admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
webrtc_m130/webrtc/examples/BUILD.gn

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

672 lines
21 KiB
Plaintext
Raw Normal View History

Add GN targets for AppRTC Demo on Android. Adds GN equivalents for following targets: AppRTCDemo -> //webrtc/examples:AppRTCDemo AppRTCDemo_apk -> //webrtc/examples:AppRTCDemo_lib (kind of) AppRTCDemoJUnitTest -> //webrtc/examples:AppRTCDemoJUnitTest AppRTCDemoTest -> //webrtc/examples:AppRTCDemoTest libjingle_peerconnection_java -> //webrtc/api/libjingle_peerconnection_java libjingle_peerconnection_so -> //webrtc/api/libjingle_peerconnection_so New GN targets: //webrtc/base:base_java //webrtc/examples:AppRTCDemo_resources //webrtc/examples/androidapp/third_party/autobanh:autobanh_java BUG=webrtc:6035 R=magjed@webrtc.org, tommi@webrtc.org Review URL: https://codereview.webrtc.org/2105803002 . Cr-Commit-Position: refs/heads/master@{#13322}
2016-06-29 14:55:00 +02:00
# Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
#
# Use of this source code is governed by a BSD-style license
# that can be found in the LICENSE file in the root of the source
# tree. An additional intellectual property rights grant can be found
# in the file PATENTS. All contributing project authors may
# be found in the AUTHORS file in the root of the source tree.
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
import("../webrtc.gni")
Add GN targets for AppRTC Demo on Android. Adds GN equivalents for following targets: AppRTCDemo -> //webrtc/examples:AppRTCDemo AppRTCDemo_apk -> //webrtc/examples:AppRTCDemo_lib (kind of) AppRTCDemoJUnitTest -> //webrtc/examples:AppRTCDemoJUnitTest AppRTCDemoTest -> //webrtc/examples:AppRTCDemoTest libjingle_peerconnection_java -> //webrtc/api/libjingle_peerconnection_java libjingle_peerconnection_so -> //webrtc/api/libjingle_peerconnection_so New GN targets: //webrtc/base:base_java //webrtc/examples:AppRTCDemo_resources //webrtc/examples/androidapp/third_party/autobanh:autobanh_java BUG=webrtc:6035 R=magjed@webrtc.org, tommi@webrtc.org Review URL: https://codereview.webrtc.org/2105803002 . Cr-Commit-Position: refs/heads/master@{#13322}
2016-06-29 14:55:00 +02:00
if (is_android) {
import("//build/config/android/config.gni")
import("//build/config/android/rules.gni")
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
} else if (is_mac) {
import("//build/config/mac/rules.gni")
} else if (is_ios) {
import("//build/config/ios/rules.gni")
Add GN targets for AppRTC Demo on Android. Adds GN equivalents for following targets: AppRTCDemo -> //webrtc/examples:AppRTCDemo AppRTCDemo_apk -> //webrtc/examples:AppRTCDemo_lib (kind of) AppRTCDemoJUnitTest -> //webrtc/examples:AppRTCDemoJUnitTest AppRTCDemoTest -> //webrtc/examples:AppRTCDemoTest libjingle_peerconnection_java -> //webrtc/api/libjingle_peerconnection_java libjingle_peerconnection_so -> //webrtc/api/libjingle_peerconnection_so New GN targets: //webrtc/base:base_java //webrtc/examples:AppRTCDemo_resources //webrtc/examples/androidapp/third_party/autobanh:autobanh_java BUG=webrtc:6035 R=magjed@webrtc.org, tommi@webrtc.org Review URL: https://codereview.webrtc.org/2105803002 . Cr-Commit-Position: refs/heads/master@{#13322}
2016-06-29 14:55:00 +02:00
}
group("examples") {
GN: New conventions, default target and refactorings Introduce a convention on categorizing GN targets: 1. Production code 2. Tests 3. Examples 4. Tools The first two have targets spread out all over the tree, while the latter are isolated to examples/ and tools/ directories. Another new convention: Each directory's BUILD.gn file shall contain a target named similar to the directory name. This target shall contain the 'most common' production code, i.e. so that most consumers of the directory can depend on only the directory (which implicitly means that target in GN). //webrtc:webrtc_tests is changed to depend on all WebRTC tests. From now on, it's necessary to add new test targets to this dependency tree in order to get them compiled. Two new group targets are created: //webrtc/modules/audio_coding:audio_coding_tests //webrtc/modules/audio_processing:audio_processing_tests to reduce the long list of tests in //webrtc:webrtc_tests. Visibility on //webrtc:webrtc and //webrtc:webrtc_tests is restricted to the root target, to avoid circular dependencies due to the monolithic property of these targets (a problem we've had in the past). The 'root' target at the top level is renamed to 'default', which means GN will build this target instead of _all_ generated targets (see https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/faq.md#Can-I-control-what-targets-are-built-by-default). This target now depends on everything we want to build, meaning all targets now explicitly needs to be wired up from the root target in order to get build. Having this, the number of compiled objects on Android is decreased from 8855 to 6276. It also gives us better control over our build. BUG=webrtc:6440 TESTED=git cl try --clobber NOTRY=True Review-Url: https://codereview.webrtc.org/2441383002 Cr-Commit-Position: refs/heads/master@{#14821}
2016-10-28 05:44:03 -07:00
# This target shall build all targets in examples.
testonly = true
GN: Change group deps to public_deps. During GN vs GYP auditing it was discovered that some GN targets that had public_configs were not exposing them to dependents where the dependent depended on a group, which in turn included that target as a dependency. Instead of changing those public_configs to all_dependent_configs (which would be a change from GYP), it's better to just change those group targets to use public_deps instead. BUG=webrtc:6323 NOTRY=True TESTED=Generated GYP and GN project files on Mac and ran the tools/gyp_flag_compare.py script before and after this patch was applied. The file in question used for inspection was the webrtc/api/webrtcsessiondescriptionfactory.cc which is a part of the libjingle_peerconnection target. Review-Url: https://codereview.webrtc.org/2344623002 Cr-Commit-Position: refs/heads/master@{#14222}
2016-09-15 00:53:26 -07:00
public_deps = []
Add GN targets for AppRTC Demo on Android. Adds GN equivalents for following targets: AppRTCDemo -> //webrtc/examples:AppRTCDemo AppRTCDemo_apk -> //webrtc/examples:AppRTCDemo_lib (kind of) AppRTCDemoJUnitTest -> //webrtc/examples:AppRTCDemoJUnitTest AppRTCDemoTest -> //webrtc/examples:AppRTCDemoTest libjingle_peerconnection_java -> //webrtc/api/libjingle_peerconnection_java libjingle_peerconnection_so -> //webrtc/api/libjingle_peerconnection_so New GN targets: //webrtc/base:base_java //webrtc/examples:AppRTCDemo_resources //webrtc/examples/androidapp/third_party/autobanh:autobanh_java BUG=webrtc:6035 R=magjed@webrtc.org, tommi@webrtc.org Review URL: https://codereview.webrtc.org/2105803002 . Cr-Commit-Position: refs/heads/master@{#13322}
2016-06-29 14:55:00 +02:00
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
if (is_android) {
GN: New conventions, default target and refactorings Introduce a convention on categorizing GN targets: 1. Production code 2. Tests 3. Examples 4. Tools The first two have targets spread out all over the tree, while the latter are isolated to examples/ and tools/ directories. Another new convention: Each directory's BUILD.gn file shall contain a target named similar to the directory name. This target shall contain the 'most common' production code, i.e. so that most consumers of the directory can depend on only the directory (which implicitly means that target in GN). //webrtc:webrtc_tests is changed to depend on all WebRTC tests. From now on, it's necessary to add new test targets to this dependency tree in order to get them compiled. Two new group targets are created: //webrtc/modules/audio_coding:audio_coding_tests //webrtc/modules/audio_processing:audio_processing_tests to reduce the long list of tests in //webrtc:webrtc_tests. Visibility on //webrtc:webrtc and //webrtc:webrtc_tests is restricted to the root target, to avoid circular dependencies due to the monolithic property of these targets (a problem we've had in the past). The 'root' target at the top level is renamed to 'default', which means GN will build this target instead of _all_ generated targets (see https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/faq.md#Can-I-control-what-targets-are-built-by-default). This target now depends on everything we want to build, meaning all targets now explicitly needs to be wired up from the root target in order to get build. Having this, the number of compiled objects on Android is decreased from 8855 to 6276. It also gives us better control over our build. BUG=webrtc:6440 TESTED=git cl try --clobber NOTRY=True Review-Url: https://codereview.webrtc.org/2441383002 Cr-Commit-Position: refs/heads/master@{#14821}
2016-10-28 05:44:03 -07:00
public_deps += [
":AppRTCMobile",
":AppRTCMobileTest",
Espresso test case to control loopback call The test case is put inside a new test target. That test target will be started from a test script to asses video quality. BUG=webrtc:6545 Review-Url: https://codereview.webrtc.org/2585813002 Cr-Commit-Position: refs/heads/master@{#16088}
2017-01-16 02:23:09 -08:00
":AppRTCMobileTestStubbedVideoIO",
GN: New conventions, default target and refactorings Introduce a convention on categorizing GN targets: 1. Production code 2. Tests 3. Examples 4. Tools The first two have targets spread out all over the tree, while the latter are isolated to examples/ and tools/ directories. Another new convention: Each directory's BUILD.gn file shall contain a target named similar to the directory name. This target shall contain the 'most common' production code, i.e. so that most consumers of the directory can depend on only the directory (which implicitly means that target in GN). //webrtc:webrtc_tests is changed to depend on all WebRTC tests. From now on, it's necessary to add new test targets to this dependency tree in order to get them compiled. Two new group targets are created: //webrtc/modules/audio_coding:audio_coding_tests //webrtc/modules/audio_processing:audio_processing_tests to reduce the long list of tests in //webrtc:webrtc_tests. Visibility on //webrtc:webrtc and //webrtc:webrtc_tests is restricted to the root target, to avoid circular dependencies due to the monolithic property of these targets (a problem we've had in the past). The 'root' target at the top level is renamed to 'default', which means GN will build this target instead of _all_ generated targets (see https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/faq.md#Can-I-control-what-targets-are-built-by-default). This target now depends on everything we want to build, meaning all targets now explicitly needs to be wired up from the root target in order to get build. Having this, the number of compiled objects on Android is decreased from 8855 to 6276. It also gives us better control over our build. BUG=webrtc:6440 TESTED=git cl try --clobber NOTRY=True Review-Url: https://codereview.webrtc.org/2441383002 Cr-Commit-Position: refs/heads/master@{#14821}
2016-10-28 05:44:03 -07:00
]
}
Moving stun_prober target from webrtc/p2p to webrtc/examples BUG=webrtc:6440 NOTRY=True Review-Url: https://codereview.webrtc.org/2460343002 Cr-Commit-Position: refs/heads/master@{#14869}
2016-11-01 03:09:15 -07:00
if (!build_with_chromium) {
public_deps += [ ":stun_prober" ]
}
GN: New conventions, default target and refactorings Introduce a convention on categorizing GN targets: 1. Production code 2. Tests 3. Examples 4. Tools The first two have targets spread out all over the tree, while the latter are isolated to examples/ and tools/ directories. Another new convention: Each directory's BUILD.gn file shall contain a target named similar to the directory name. This target shall contain the 'most common' production code, i.e. so that most consumers of the directory can depend on only the directory (which implicitly means that target in GN). //webrtc:webrtc_tests is changed to depend on all WebRTC tests. From now on, it's necessary to add new test targets to this dependency tree in order to get them compiled. Two new group targets are created: //webrtc/modules/audio_coding:audio_coding_tests //webrtc/modules/audio_processing:audio_processing_tests to reduce the long list of tests in //webrtc:webrtc_tests. Visibility on //webrtc:webrtc and //webrtc:webrtc_tests is restricted to the root target, to avoid circular dependencies due to the monolithic property of these targets (a problem we've had in the past). The 'root' target at the top level is renamed to 'default', which means GN will build this target instead of _all_ generated targets (see https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/faq.md#Can-I-control-what-targets-are-built-by-default). This target now depends on everything we want to build, meaning all targets now explicitly needs to be wired up from the root target in order to get build. Having this, the number of compiled objects on Android is decreased from 8855 to 6276. It also gives us better control over our build. BUG=webrtc:6440 TESTED=git cl try --clobber NOTRY=True Review-Url: https://codereview.webrtc.org/2441383002 Cr-Commit-Position: refs/heads/master@{#14821}
2016-10-28 05:44:03 -07:00
if (is_ios || (is_mac && target_cpu != "x86")) {
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
public_deps += [ ":AppRTCMobile" ]
Add GN targets for AppRTC Demo on Android. Adds GN equivalents for following targets: AppRTCDemo -> //webrtc/examples:AppRTCDemo AppRTCDemo_apk -> //webrtc/examples:AppRTCDemo_lib (kind of) AppRTCDemoJUnitTest -> //webrtc/examples:AppRTCDemoJUnitTest AppRTCDemoTest -> //webrtc/examples:AppRTCDemoTest libjingle_peerconnection_java -> //webrtc/api/libjingle_peerconnection_java libjingle_peerconnection_so -> //webrtc/api/libjingle_peerconnection_so New GN targets: //webrtc/base:base_java //webrtc/examples:AppRTCDemo_resources //webrtc/examples/androidapp/third_party/autobanh:autobanh_java BUG=webrtc:6035 R=magjed@webrtc.org, tommi@webrtc.org Review URL: https://codereview.webrtc.org/2105803002 . Cr-Commit-Position: refs/heads/master@{#13322}
2016-06-29 14:55:00 +02:00
}
GN: New conventions, default target and refactorings Introduce a convention on categorizing GN targets: 1. Production code 2. Tests 3. Examples 4. Tools The first two have targets spread out all over the tree, while the latter are isolated to examples/ and tools/ directories. Another new convention: Each directory's BUILD.gn file shall contain a target named similar to the directory name. This target shall contain the 'most common' production code, i.e. so that most consumers of the directory can depend on only the directory (which implicitly means that target in GN). //webrtc:webrtc_tests is changed to depend on all WebRTC tests. From now on, it's necessary to add new test targets to this dependency tree in order to get them compiled. Two new group targets are created: //webrtc/modules/audio_coding:audio_coding_tests //webrtc/modules/audio_processing:audio_processing_tests to reduce the long list of tests in //webrtc:webrtc_tests. Visibility on //webrtc:webrtc and //webrtc:webrtc_tests is restricted to the root target, to avoid circular dependencies due to the monolithic property of these targets (a problem we've had in the past). The 'root' target at the top level is renamed to 'default', which means GN will build this target instead of _all_ generated targets (see https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/faq.md#Can-I-control-what-targets-are-built-by-default). This target now depends on everything we want to build, meaning all targets now explicitly needs to be wired up from the root target in order to get build. Having this, the number of compiled objects on Android is decreased from 8855 to 6276. It also gives us better control over our build. BUG=webrtc:6440 TESTED=git cl try --clobber NOTRY=True Review-Url: https://codereview.webrtc.org/2441383002 Cr-Commit-Position: refs/heads/master@{#14821}
2016-10-28 05:44:03 -07:00
if (is_linux || is_win) {
GN: Change group deps to public_deps. During GN vs GYP auditing it was discovered that some GN targets that had public_configs were not exposing them to dependents where the dependent depended on a group, which in turn included that target as a dependency. Instead of changing those public_configs to all_dependent_configs (which would be a change from GYP), it's better to just change those group targets to use public_deps instead. BUG=webrtc:6323 NOTRY=True TESTED=Generated GYP and GN project files on Mac and ran the tools/gyp_flag_compare.py script before and after this patch was applied. The file in question used for inspection was the webrtc/api/webrtcsessiondescriptionfactory.cc which is a part of the libjingle_peerconnection target. Review-Url: https://codereview.webrtc.org/2344623002 Cr-Commit-Position: refs/heads/master@{#14222}
2016-09-15 00:53:26 -07:00
public_deps += [
Create gn target for peerconnection examples BUG= Review-Url: https://codereview.webrtc.org/2218053002 Cr-Commit-Position: refs/heads/master@{#13673}
2016-08-08 09:03:23 -07:00
":peerconnection_client",
":peerconnection_server",
":relayserver",
":stunserver",
":turnserver",
]
}
Add GN targets for AppRTC Demo on Android. Adds GN equivalents for following targets: AppRTCDemo -> //webrtc/examples:AppRTCDemo AppRTCDemo_apk -> //webrtc/examples:AppRTCDemo_lib (kind of) AppRTCDemoJUnitTest -> //webrtc/examples:AppRTCDemoJUnitTest AppRTCDemoTest -> //webrtc/examples:AppRTCDemoTest libjingle_peerconnection_java -> //webrtc/api/libjingle_peerconnection_java libjingle_peerconnection_so -> //webrtc/api/libjingle_peerconnection_so New GN targets: //webrtc/base:base_java //webrtc/examples:AppRTCDemo_resources //webrtc/examples/androidapp/third_party/autobanh:autobanh_java BUG=webrtc:6035 R=magjed@webrtc.org, tommi@webrtc.org Review URL: https://codereview.webrtc.org/2105803002 . Cr-Commit-Position: refs/heads/master@{#13322}
2016-06-29 14:55:00 +02:00
}
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
if (is_android) {
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
android_apk("AppRTCMobile") {
Reland "Enable GN check for webrtc/examples" This is a reland of https://codereview.webrtc.org/2714343002 with the errors related to inclusions of test targets in webrtc/api resolved. BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2733673002 Cr-Commit-Position: refs/heads/master@{#17053}
2017-03-06 00:29:21 -08:00
testonly = true
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
apk_name = "AppRTCMobile"
Add GN targets for AppRTC Demo on Android. Adds GN equivalents for following targets: AppRTCDemo -> //webrtc/examples:AppRTCDemo AppRTCDemo_apk -> //webrtc/examples:AppRTCDemo_lib (kind of) AppRTCDemoJUnitTest -> //webrtc/examples:AppRTCDemoJUnitTest AppRTCDemoTest -> //webrtc/examples:AppRTCDemoTest libjingle_peerconnection_java -> //webrtc/api/libjingle_peerconnection_java libjingle_peerconnection_so -> //webrtc/api/libjingle_peerconnection_so New GN targets: //webrtc/base:base_java //webrtc/examples:AppRTCDemo_resources //webrtc/examples/androidapp/third_party/autobanh:autobanh_java BUG=webrtc:6035 R=magjed@webrtc.org, tommi@webrtc.org Review URL: https://codereview.webrtc.org/2105803002 . Cr-Commit-Position: refs/heads/master@{#13322}
2016-06-29 14:55:00 +02:00
android_manifest = "androidapp/AndroidManifest.xml"
deps = [
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
":AppRTCMobile_javalib",
":AppRTCMobile_resources",
Add GN targets for AppRTC Demo on Android. Adds GN equivalents for following targets: AppRTCDemo -> //webrtc/examples:AppRTCDemo AppRTCDemo_apk -> //webrtc/examples:AppRTCDemo_lib (kind of) AppRTCDemoJUnitTest -> //webrtc/examples:AppRTCDemoJUnitTest AppRTCDemoTest -> //webrtc/examples:AppRTCDemoTest libjingle_peerconnection_java -> //webrtc/api/libjingle_peerconnection_java libjingle_peerconnection_so -> //webrtc/api/libjingle_peerconnection_so New GN targets: //webrtc/base:base_java //webrtc/examples:AppRTCDemo_resources //webrtc/examples/androidapp/third_party/autobanh:autobanh_java BUG=webrtc:6035 R=magjed@webrtc.org, tommi@webrtc.org Review URL: https://codereview.webrtc.org/2105803002 . Cr-Commit-Position: refs/heads/master@{#13322}
2016-06-29 14:55:00 +02:00
"//base:base_java",
Reland "Move webrtc/{base => rtc_base}" (https://codereview.webrtc.org/2877023002) Reland the base->rtc_base without adding stub headers (will be done in follow-up CL). This preserves git blame history of all files. BUG=webrtc:7634 NOTRY=True TBR=kwiberg@webrtc.org Change-Id: Iea3bb6f3f67b8374c96337b63e8f5aa3e6181012 Reviewed-on: https://chromium-review.googlesource.com/554611 Reviewed-by: Henrik Kjellander <kjellander@webrtc.org> Cr-Commit-Position: refs/heads/master@{#18821}
2017-06-29 08:03:04 +02:00
"//webrtc/rtc_base:base_java",
Add GN targets for AppRTC Demo on Android. Adds GN equivalents for following targets: AppRTCDemo -> //webrtc/examples:AppRTCDemo AppRTCDemo_apk -> //webrtc/examples:AppRTCDemo_lib (kind of) AppRTCDemoJUnitTest -> //webrtc/examples:AppRTCDemoJUnitTest AppRTCDemoTest -> //webrtc/examples:AppRTCDemoTest libjingle_peerconnection_java -> //webrtc/api/libjingle_peerconnection_java libjingle_peerconnection_so -> //webrtc/api/libjingle_peerconnection_so New GN targets: //webrtc/base:base_java //webrtc/examples:AppRTCDemo_resources //webrtc/examples/androidapp/third_party/autobanh:autobanh_java BUG=webrtc:6035 R=magjed@webrtc.org, tommi@webrtc.org Review URL: https://codereview.webrtc.org/2105803002 . Cr-Commit-Position: refs/heads/master@{#13322}
2016-06-29 14:55:00 +02:00
]
Move /webrtc/api/android files to /webrtc/sdk/android I decided to make one webrtc/sdk/android/BUILD.gn for both tests and Java/jni src. External dependencies needs to be updated after this CL. Future work is required to clean up the Android api and move implementation details to /webrtc/sdk/android/src. BUG=webrtc:5882,webrtc:6804 NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2547483003 Cr-Commit-Position: refs/heads/master@{#15443}
2016-12-06 04:29:37 -08:00
shared_libraries = [ "//webrtc/sdk/android:libjingle_peerconnection_so" ]
Add GN targets for AppRTC Demo on Android. Adds GN equivalents for following targets: AppRTCDemo -> //webrtc/examples:AppRTCDemo AppRTCDemo_apk -> //webrtc/examples:AppRTCDemo_lib (kind of) AppRTCDemoJUnitTest -> //webrtc/examples:AppRTCDemoJUnitTest AppRTCDemoTest -> //webrtc/examples:AppRTCDemoTest libjingle_peerconnection_java -> //webrtc/api/libjingle_peerconnection_java libjingle_peerconnection_so -> //webrtc/api/libjingle_peerconnection_so New GN targets: //webrtc/base:base_java //webrtc/examples:AppRTCDemo_resources //webrtc/examples/androidapp/third_party/autobanh:autobanh_java BUG=webrtc:6035 R=magjed@webrtc.org, tommi@webrtc.org Review URL: https://codereview.webrtc.org/2105803002 . Cr-Commit-Position: refs/heads/master@{#13322}
2016-06-29 14:55:00 +02:00
}
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
android_library("AppRTCMobile_javalib") {
Reland "Enable GN check for webrtc/examples" This is a reland of https://codereview.webrtc.org/2714343002 with the errors related to inclusions of test targets in webrtc/api resolved. BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2733673002 Cr-Commit-Position: refs/heads/master@{#17053}
2017-03-06 00:29:21 -08:00
testonly = true
Add support for swapping feeds in Android AppRTCMobile. BUG=webrtc:6937 Review-Url: https://codereview.webrtc.org/2682943006 Cr-Commit-Position: refs/heads/master@{#16582}
2017-02-13 05:58:27 -08:00
android_manifest = "androidapp/AndroidManifest.xml"
Add GN targets for AppRTC Demo on Android. Adds GN equivalents for following targets: AppRTCDemo -> //webrtc/examples:AppRTCDemo AppRTCDemo_apk -> //webrtc/examples:AppRTCDemo_lib (kind of) AppRTCDemoJUnitTest -> //webrtc/examples:AppRTCDemoJUnitTest AppRTCDemoTest -> //webrtc/examples:AppRTCDemoTest libjingle_peerconnection_java -> //webrtc/api/libjingle_peerconnection_java libjingle_peerconnection_so -> //webrtc/api/libjingle_peerconnection_so New GN targets: //webrtc/base:base_java //webrtc/examples:AppRTCDemo_resources //webrtc/examples/androidapp/third_party/autobanh:autobanh_java BUG=webrtc:6035 R=magjed@webrtc.org, tommi@webrtc.org Review URL: https://codereview.webrtc.org/2105803002 . Cr-Commit-Position: refs/heads/master@{#13322}
2016-06-29 14:55:00 +02:00
java_files = [
"androidapp/src/org/appspot/apprtc/AppRTCAudioManager.java",
Adds basic Bluetooth support to AppRTCMobile BUG=webrtc:6649 - Supports Bluetooth Headset profile. - Detects new BT headset: + enabled at start, and + powered on during active call. - Enables/disables BT SCO channel when BT device is selected. - Removes proximity sensor usage to avoid conflicts (will be added again later). - Adds new (unused) APIs to explicitly select audio device. - Starts routing audio to BT headset when enabled, i.e, BT is default. Review-Url: https://codereview.webrtc.org/2501983002 Cr-Commit-Position: refs/heads/master@{#15610}
2016-12-14 07:36:56 -08:00
"androidapp/src/org/appspot/apprtc/AppRTCBluetoothManager.java",
Add GN targets for AppRTC Demo on Android. Adds GN equivalents for following targets: AppRTCDemo -> //webrtc/examples:AppRTCDemo AppRTCDemo_apk -> //webrtc/examples:AppRTCDemo_lib (kind of) AppRTCDemoJUnitTest -> //webrtc/examples:AppRTCDemoJUnitTest AppRTCDemoTest -> //webrtc/examples:AppRTCDemoTest libjingle_peerconnection_java -> //webrtc/api/libjingle_peerconnection_java libjingle_peerconnection_so -> //webrtc/api/libjingle_peerconnection_so New GN targets: //webrtc/base:base_java //webrtc/examples:AppRTCDemo_resources //webrtc/examples/androidapp/third_party/autobanh:autobanh_java BUG=webrtc:6035 R=magjed@webrtc.org, tommi@webrtc.org Review URL: https://codereview.webrtc.org/2105803002 . Cr-Commit-Position: refs/heads/master@{#13322}
2016-06-29 14:55:00 +02:00
"androidapp/src/org/appspot/apprtc/AppRTCClient.java",
"androidapp/src/org/appspot/apprtc/AppRTCProximitySensor.java",
"androidapp/src/org/appspot/apprtc/CallActivity.java",
"androidapp/src/org/appspot/apprtc/CallFragment.java",
"androidapp/src/org/appspot/apprtc/CaptureQualityController.java",
"androidapp/src/org/appspot/apprtc/ConnectActivity.java",
"androidapp/src/org/appspot/apprtc/CpuMonitor.java",
"androidapp/src/org/appspot/apprtc/DirectRTCClient.java",
"androidapp/src/org/appspot/apprtc/HudFragment.java",
"androidapp/src/org/appspot/apprtc/PeerConnectionClient.java",
"androidapp/src/org/appspot/apprtc/RoomParametersFetcher.java",
"androidapp/src/org/appspot/apprtc/SettingsActivity.java",
"androidapp/src/org/appspot/apprtc/SettingsFragment.java",
"androidapp/src/org/appspot/apprtc/TCPChannelClient.java",
"androidapp/src/org/appspot/apprtc/UnhandledExceptionHandler.java",
"androidapp/src/org/appspot/apprtc/WebSocketChannelClient.java",
"androidapp/src/org/appspot/apprtc/WebSocketRTCClient.java",
"androidapp/src/org/appspot/apprtc/util/AppRTCUtils.java",
"androidapp/src/org/appspot/apprtc/util/AsyncHttpURLConnection.java",
]
deps = [
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
":AppRTCMobile_resources",
Add GN targets for AppRTC Demo on Android. Adds GN equivalents for following targets: AppRTCDemo -> //webrtc/examples:AppRTCDemo AppRTCDemo_apk -> //webrtc/examples:AppRTCDemo_lib (kind of) AppRTCDemoJUnitTest -> //webrtc/examples:AppRTCDemoJUnitTest AppRTCDemoTest -> //webrtc/examples:AppRTCDemoTest libjingle_peerconnection_java -> //webrtc/api/libjingle_peerconnection_java libjingle_peerconnection_so -> //webrtc/api/libjingle_peerconnection_so New GN targets: //webrtc/base:base_java //webrtc/examples:AppRTCDemo_resources //webrtc/examples/androidapp/third_party/autobanh:autobanh_java BUG=webrtc:6035 R=magjed@webrtc.org, tommi@webrtc.org Review URL: https://codereview.webrtc.org/2105803002 . Cr-Commit-Position: refs/heads/master@{#13322}
2016-06-29 14:55:00 +02:00
"//webrtc/examples/androidapp/third_party/autobanh:autobanh_java",
Reland of Creating libwebrtc bundle jar (patchset #1 id:1 of https://codereview.webrtc.org/2640023010/ ) Reason for revert: It seems that we cannot skip the generation of "//webrtc/base/base_java" in chromium without some refactoring because it is included as a dependency in some places. Original issue's description: > Revert of Creating libwebrtc bundle jar (patchset #4 id:60001 of https://codereview.webrtc.org/2646443002/ ) > > Reason for revert: > This breaks some chromium.webrtc.fyi buildbots with the following error: > > ERROR Unresolved dependencies. > //third_party/webrtc/base:base(//build/toolchain/android:android_arm) > needs //third_party/webrtc/base:base_java(//build/toolchain/android:android_arm) > > > Original issue's description: > > Creating libwebrtc bundle jar > > > > Creates a JAR which includes: > > - //webrtc/base:base_java > > - //webrtc/modules/audio_device:audio_device_java > > - //webrtc/sdk/android:libjingle_peerconnection_java > > - //webrtc/sdk/android:libjingle_peerconnection_metrics_default_java > > > > The libwebrtc.jar file will be generated at '<output_dir>/lib.java/webrtc/sdk/android/libwebrtc.jar'. > > > > BUG=webrtc:6356 > > > > Review-Url: https://codereview.webrtc.org/2646443002 > > Cr-Commit-Position: refs/heads/master@{#16189} > > Committed: https://chromium.googlesource.com/external/webrtc/+/a62a82b7e7da5a1bbbf8b5614ef19334cc1603ce > > TBR=kjellander@webrtc.org,sakal@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6356 > > Review-Url: https://codereview.webrtc.org/2640023010 > Cr-Commit-Position: refs/heads/master@{#16190} > Committed: https://chromium.googlesource.com/external/webrtc/+/3c9151b9532b372a35f0b81cc7c6b34d820506e1 TBR=kjellander@webrtc.org,sakal@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6356 Review-Url: https://codereview.webrtc.org/2646093004 Cr-Commit-Position: refs/heads/master@{#16203}
2017-01-23 01:25:53 -08:00
"//webrtc/modules/audio_device:audio_device_java",
Reland "Move webrtc/{base => rtc_base}" (https://codereview.webrtc.org/2877023002) Reland the base->rtc_base without adding stub headers (will be done in follow-up CL). This preserves git blame history of all files. BUG=webrtc:7634 NOTRY=True TBR=kwiberg@webrtc.org Change-Id: Iea3bb6f3f67b8374c96337b63e8f5aa3e6181012 Reviewed-on: https://chromium-review.googlesource.com/554611 Reviewed-by: Henrik Kjellander <kjellander@webrtc.org> Cr-Commit-Position: refs/heads/master@{#18821}
2017-06-29 08:03:04 +02:00
"//webrtc/rtc_base:base_java",
Move /webrtc/api/android files to /webrtc/sdk/android I decided to make one webrtc/sdk/android/BUILD.gn for both tests and Java/jni src. External dependencies needs to be updated after this CL. Future work is required to clean up the Android api and move implementation details to /webrtc/sdk/android/src. BUG=webrtc:5882,webrtc:6804 NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2547483003 Cr-Commit-Position: refs/heads/master@{#15443}
2016-12-06 04:29:37 -08:00
"//webrtc/sdk/android:libjingle_peerconnection_java",
"//webrtc/sdk/android:libjingle_peerconnection_metrics_default_java",
Add GN targets for AppRTC Demo on Android. Adds GN equivalents for following targets: AppRTCDemo -> //webrtc/examples:AppRTCDemo AppRTCDemo_apk -> //webrtc/examples:AppRTCDemo_lib (kind of) AppRTCDemoJUnitTest -> //webrtc/examples:AppRTCDemoJUnitTest AppRTCDemoTest -> //webrtc/examples:AppRTCDemoTest libjingle_peerconnection_java -> //webrtc/api/libjingle_peerconnection_java libjingle_peerconnection_so -> //webrtc/api/libjingle_peerconnection_so New GN targets: //webrtc/base:base_java //webrtc/examples:AppRTCDemo_resources //webrtc/examples/androidapp/third_party/autobanh:autobanh_java BUG=webrtc:6035 R=magjed@webrtc.org, tommi@webrtc.org Review URL: https://codereview.webrtc.org/2105803002 . Cr-Commit-Position: refs/heads/master@{#13322}
2016-06-29 14:55:00 +02:00
]
}
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
android_resources("AppRTCMobile_resources") {
Reland "Enable GN check for webrtc/examples" This is a reland of https://codereview.webrtc.org/2714343002 with the errors related to inclusions of test targets in webrtc/api resolved. BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2733673002 Cr-Commit-Position: refs/heads/master@{#17053}
2017-03-06 00:29:21 -08:00
testonly = true
Add GN targets for AppRTC Demo on Android. Adds GN equivalents for following targets: AppRTCDemo -> //webrtc/examples:AppRTCDemo AppRTCDemo_apk -> //webrtc/examples:AppRTCDemo_lib (kind of) AppRTCDemoJUnitTest -> //webrtc/examples:AppRTCDemoJUnitTest AppRTCDemoTest -> //webrtc/examples:AppRTCDemoTest libjingle_peerconnection_java -> //webrtc/api/libjingle_peerconnection_java libjingle_peerconnection_so -> //webrtc/api/libjingle_peerconnection_so New GN targets: //webrtc/base:base_java //webrtc/examples:AppRTCDemo_resources //webrtc/examples/androidapp/third_party/autobanh:autobanh_java BUG=webrtc:6035 R=magjed@webrtc.org, tommi@webrtc.org Review URL: https://codereview.webrtc.org/2105803002 . Cr-Commit-Position: refs/heads/master@{#13322}
2016-06-29 14:55:00 +02:00
resource_dirs = [ "androidapp/res" ]
custom_package = "org.appspot.apprtc"
}
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
instrumentation_test_apk("AppRTCMobileTest") {
apk_name = "AppRTCMobileTest"
Add GN targets for AppRTC Demo on Android. Adds GN equivalents for following targets: AppRTCDemo -> //webrtc/examples:AppRTCDemo AppRTCDemo_apk -> //webrtc/examples:AppRTCDemo_lib (kind of) AppRTCDemoJUnitTest -> //webrtc/examples:AppRTCDemoJUnitTest AppRTCDemoTest -> //webrtc/examples:AppRTCDemoTest libjingle_peerconnection_java -> //webrtc/api/libjingle_peerconnection_java libjingle_peerconnection_so -> //webrtc/api/libjingle_peerconnection_so New GN targets: //webrtc/base:base_java //webrtc/examples:AppRTCDemo_resources //webrtc/examples/androidapp/third_party/autobanh:autobanh_java BUG=webrtc:6035 R=magjed@webrtc.org, tommi@webrtc.org Review URL: https://codereview.webrtc.org/2105803002 . Cr-Commit-Position: refs/heads/master@{#13322}
2016-06-29 14:55:00 +02:00
android_manifest = "androidtests/AndroidManifest.xml"
Move file capturer/renderer tests to the correct location. Move file capturer/renderer tests from the AppRTCMobile tests directory to the WebRTC tests directory. These tests do not test AppRTCMobile but rather WebRTC functionality. Therefore, they belong in WebRTC tests directory. BUG=webrtc:6545 Review-Url: https://codereview.webrtc.org/2632233002 Cr-Commit-Position: refs/heads/master@{#16115}
2017-01-17 03:32:06 -08:00
java_files = [ "androidtests/src/org/appspot/apprtc/test/PeerConnectionClientTest.java" ]
Add GN targets for AppRTC Demo on Android. Adds GN equivalents for following targets: AppRTCDemo -> //webrtc/examples:AppRTCDemo AppRTCDemo_apk -> //webrtc/examples:AppRTCDemo_lib (kind of) AppRTCDemoJUnitTest -> //webrtc/examples:AppRTCDemoJUnitTest AppRTCDemoTest -> //webrtc/examples:AppRTCDemoTest libjingle_peerconnection_java -> //webrtc/api/libjingle_peerconnection_java libjingle_peerconnection_so -> //webrtc/api/libjingle_peerconnection_so New GN targets: //webrtc/base:base_java //webrtc/examples:AppRTCDemo_resources //webrtc/examples/androidapp/third_party/autobanh:autobanh_java BUG=webrtc:6035 R=magjed@webrtc.org, tommi@webrtc.org Review URL: https://codereview.webrtc.org/2105803002 . Cr-Commit-Position: refs/heads/master@{#13322}
2016-06-29 14:55:00 +02:00
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
apk_under_test = ":AppRTCMobile"
Add GN targets for AppRTC Demo on Android. Adds GN equivalents for following targets: AppRTCDemo -> //webrtc/examples:AppRTCDemo AppRTCDemo_apk -> //webrtc/examples:AppRTCDemo_lib (kind of) AppRTCDemoJUnitTest -> //webrtc/examples:AppRTCDemoJUnitTest AppRTCDemoTest -> //webrtc/examples:AppRTCDemoTest libjingle_peerconnection_java -> //webrtc/api/libjingle_peerconnection_java libjingle_peerconnection_so -> //webrtc/api/libjingle_peerconnection_so New GN targets: //webrtc/base:base_java //webrtc/examples:AppRTCDemo_resources //webrtc/examples/androidapp/third_party/autobanh:autobanh_java BUG=webrtc:6035 R=magjed@webrtc.org, tommi@webrtc.org Review URL: https://codereview.webrtc.org/2105803002 . Cr-Commit-Position: refs/heads/master@{#13322}
2016-06-29 14:55:00 +02:00
deps = [
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
":AppRTCMobile_javalib",
Update AppRTCMobile tests to use JUnit4. BUG=webrtc:6597 Review-Url: https://codereview.webrtc.org/2621253002 Cr-Commit-Position: refs/heads/master@{#16010}
2017-01-11 06:21:26 -08:00
"//base:base_java_test_support",
"//third_party/android_support_test_runner:runner_java",
"//third_party/junit",
Move /webrtc/api/android files to /webrtc/sdk/android I decided to make one webrtc/sdk/android/BUILD.gn for both tests and Java/jni src. External dependencies needs to be updated after this CL. Future work is required to clean up the Android api and move implementation details to /webrtc/sdk/android/src. BUG=webrtc:5882,webrtc:6804 NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2547483003 Cr-Commit-Position: refs/heads/master@{#15443}
2016-12-06 04:29:37 -08:00
"//webrtc/sdk/android:libjingle_peerconnection_java",
Add GN targets for AppRTC Demo on Android. Adds GN equivalents for following targets: AppRTCDemo -> //webrtc/examples:AppRTCDemo AppRTCDemo_apk -> //webrtc/examples:AppRTCDemo_lib (kind of) AppRTCDemoJUnitTest -> //webrtc/examples:AppRTCDemoJUnitTest AppRTCDemoTest -> //webrtc/examples:AppRTCDemoTest libjingle_peerconnection_java -> //webrtc/api/libjingle_peerconnection_java libjingle_peerconnection_so -> //webrtc/api/libjingle_peerconnection_so New GN targets: //webrtc/base:base_java //webrtc/examples:AppRTCDemo_resources //webrtc/examples/androidapp/third_party/autobanh:autobanh_java BUG=webrtc:6035 R=magjed@webrtc.org, tommi@webrtc.org Review URL: https://codereview.webrtc.org/2105803002 . Cr-Commit-Position: refs/heads/master@{#13322}
2016-06-29 14:55:00 +02:00
]
}
Espresso test case to control loopback call The test case is put inside a new test target. That test target will be started from a test script to asses video quality. BUG=webrtc:6545 Review-Url: https://codereview.webrtc.org/2585813002 Cr-Commit-Position: refs/heads/master@{#16088}
2017-01-16 02:23:09 -08:00
instrumentation_test_apk("AppRTCMobileTestStubbedVideoIO") {
apk_name = "AppRTCMobileTestStubbedVideoIO"
android_manifest = "androidtests/AndroidManifest.xml"
Espresso test for loopback video quality testing Update the AppRTCMobileTestStubbedVideoIO test to run on phones without Internet connection. This is done by bringing up a local instance of AppRTC on the Linux machine connected to the Android device. Running this test will need the webrtc.DEPS solution to be configured for the checkout, since that will pull down the precompiled AppRTC package that is needed. Continued from http://crrev.com/2780493002#ps20001 (by kjellander@) Continued from http://crrev.com/2741743002#ps180001 (by mandermo@) BUG=webrtc:7185 Review-Url: https://codereview.webrtc.org/2825313002 Cr-Commit-Position: refs/heads/master@{#17838}
2017-04-24 04:15:13 -07:00
java_files = [ "androidtests/src/org/appspot/apprtc/test/CallActivityStubbedInputOutputTest.java" ]
Espresso test case to control loopback call The test case is put inside a new test target. That test target will be started from a test script to asses video quality. BUG=webrtc:6545 Review-Url: https://codereview.webrtc.org/2585813002 Cr-Commit-Position: refs/heads/master@{#16088}
2017-01-16 02:23:09 -08:00
apk_under_test = ":AppRTCMobile"
deps = [
":AppRTCMobile_javalib",
"//third_party/android_support_test_runner:rules_java",
"//third_party/android_support_test_runner:runner_java",
"//third_party/espresso:espresso_all_java",
"//third_party/hamcrest:hamcrest_java",
"//third_party/junit",
"//webrtc/sdk/android:libjingle_peerconnection_java",
]
data = [
"//resources/reference_video_640x360_30fps.y4m",
]
}
Add GN targets for AppRTC Demo on Android. Adds GN equivalents for following targets: AppRTCDemo -> //webrtc/examples:AppRTCDemo AppRTCDemo_apk -> //webrtc/examples:AppRTCDemo_lib (kind of) AppRTCDemoJUnitTest -> //webrtc/examples:AppRTCDemoJUnitTest AppRTCDemoTest -> //webrtc/examples:AppRTCDemoTest libjingle_peerconnection_java -> //webrtc/api/libjingle_peerconnection_java libjingle_peerconnection_so -> //webrtc/api/libjingle_peerconnection_so New GN targets: //webrtc/base:base_java //webrtc/examples:AppRTCDemo_resources //webrtc/examples/androidapp/third_party/autobanh:autobanh_java BUG=webrtc:6035 R=magjed@webrtc.org, tommi@webrtc.org Review URL: https://codereview.webrtc.org/2105803002 . Cr-Commit-Position: refs/heads/master@{#13322}
2016-06-29 14:55:00 +02:00
}
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
if (is_ios || (is_mac && target_cpu != "x86")) {
config("apprtc_common_config") {
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
include_dirs = [ "objc/AppRTCMobile/common" ]
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
}
GN: Change rtc_source_set targets --> rtc_static_library This changes most non-test related rtc_source_set targets to be rtc_static_library instead. Targets without any .cc files are excluded. This should bring back the build behavior we used to have with GYP (i.e. same symbols exported in the libjingle_peerconnection.a file, which are used by some downstream projects). After doing an Android build with these changes: $ nm --defined-only -g -C out/Release/lib.unstripped/libjingle_peerconnection_so.so | grep -i createpeerconnectionf 00077c51 T Java_org_webrtc_PeerConnectionFactory_nativeCreatePeerConnectionFactory $ nm --defined-only -g -C out/Release/obj/webrtc/api/libjingle_peerconnection.a | grep -i createpeerconnectionf 00000001 T webrtc::CreatePeerConnectionFactory(rtc::Thread*, rtc::Thread*, rtc::Thread*, webrtc::AudioDeviceModule*, cricket::WebRtcVideoEncoderFactory*, cricket::WebRtcVideoDecoderFactory*) 00000001 T webrtc::CreatePeerConnectionFactory() See https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/cookbook.md#Note-on-static-libraries for more details on this. NOTICE: This should be further cleaned up in the future, to reduce binary bloat and unnecessary linking time. Right now it's more important to restore the desired build output though. BUG=webrtc:6410, chromium:630755 Review-Url: https://codereview.webrtc.org/2361623004 Cr-Commit-Position: refs/heads/master@{#14364}
2016-09-23 00:38:52 -07:00
rtc_static_library("apprtc_common") {
Reland "Enable GN check for webrtc/examples" This is a reland of https://codereview.webrtc.org/2714343002 with the errors related to inclusions of test targets in webrtc/api resolved. BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2733673002 Cr-Commit-Position: refs/heads/master@{#17053}
2017-03-06 00:29:21 -08:00
testonly = true
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
sources = [
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
"objc/AppRTCMobile/common/ARDUtilities.h",
"objc/AppRTCMobile/common/ARDUtilities.m",
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
]
GN Templates: Move common_inherited_config to the template. Remove common_inherited_config from the targets and add it to the template instead. BUG=webrtc:6187 NOTRY=True Review-Url: https://codereview.webrtc.org/2311843002 Cr-Commit-Position: refs/heads/master@{#14069}
2016-09-05 06:10:18 -07:00
public_configs = [ ":apprtc_common_config" ]
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
deps = [
Reland "Enable GN check for webrtc/examples" This is a reland of https://codereview.webrtc.org/2714343002 with the errors related to inclusions of test targets in webrtc/api resolved. BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2733673002 Cr-Commit-Position: refs/heads/master@{#17053}
2017-03-06 00:29:21 -08:00
"//webrtc/system_wrappers:field_trial_default",
"//webrtc/system_wrappers:metrics_default",
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
]
Remove webrtc deps from AppRTCMobile. We want the example app to only link agains the framework. This ensures that we are actually testing the framework, and that AppRTCMobile doesn't require any other parts of WebRTC not included in the framework. Bug: webrtc:7759 Change-Id: Ib04aae0bc3ab2a1a508eaf4a4f15c2d37f521598 Reviewed-on: https://chromium-review.googlesource.com/522722 Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Commit-Queue: Kári Tristan Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#18470}
2017-06-02 14:05:56 +02:00
if (is_ios) {
deps += [ ":AppRTCMobile_ios_frameworks" ]
} else {
deps += [ "//webrtc/sdk:objc_common" ]
}
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
}
config("apprtc_signaling_config") {
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
include_dirs = [ "objc/AppRTCMobile" ]
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
# GN orders flags on a target before flags from configs. The default config
# adds these flags so to cancel them out they need to come from a config and
# cannot be on the target directly.
cflags = [
"-Wno-sign-compare",
"-Wno-unused-variable",
]
}
GN: Change rtc_source_set targets --> rtc_static_library This changes most non-test related rtc_source_set targets to be rtc_static_library instead. Targets without any .cc files are excluded. This should bring back the build behavior we used to have with GYP (i.e. same symbols exported in the libjingle_peerconnection.a file, which are used by some downstream projects). After doing an Android build with these changes: $ nm --defined-only -g -C out/Release/lib.unstripped/libjingle_peerconnection_so.so | grep -i createpeerconnectionf 00077c51 T Java_org_webrtc_PeerConnectionFactory_nativeCreatePeerConnectionFactory $ nm --defined-only -g -C out/Release/obj/webrtc/api/libjingle_peerconnection.a | grep -i createpeerconnectionf 00000001 T webrtc::CreatePeerConnectionFactory(rtc::Thread*, rtc::Thread*, rtc::Thread*, webrtc::AudioDeviceModule*, cricket::WebRtcVideoEncoderFactory*, cricket::WebRtcVideoDecoderFactory*) 00000001 T webrtc::CreatePeerConnectionFactory() See https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/cookbook.md#Note-on-static-libraries for more details on this. NOTICE: This should be further cleaned up in the future, to reduce binary bloat and unnecessary linking time. Right now it's more important to restore the desired build output though. BUG=webrtc:6410, chromium:630755 Review-Url: https://codereview.webrtc.org/2361623004 Cr-Commit-Position: refs/heads/master@{#14364}
2016-09-23 00:38:52 -07:00
rtc_static_library("apprtc_signaling") {
Reland "Enable GN check for webrtc/examples" This is a reland of https://codereview.webrtc.org/2714343002 with the errors related to inclusions of test targets in webrtc/api resolved. BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2733673002 Cr-Commit-Position: refs/heads/master@{#17053}
2017-03-06 00:29:21 -08:00
testonly = true
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
sources = [
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
"objc/AppRTCMobile/ARDAppClient+Internal.h",
"objc/AppRTCMobile/ARDAppClient.h",
"objc/AppRTCMobile/ARDAppClient.m",
"objc/AppRTCMobile/ARDAppEngineClient.h",
"objc/AppRTCMobile/ARDAppEngineClient.m",
"objc/AppRTCMobile/ARDBitrateTracker.h",
"objc/AppRTCMobile/ARDBitrateTracker.m",
Use new RTCCameraVideoCapturer in AppRTCMobile. Because the new API doesn't use constraints, refactors settings to instead have a video resolution setting. BUG=webrtc:7177 Review-Url: https://codereview.webrtc.org/2778163005 Cr-Commit-Position: refs/heads/master@{#17545}
2017-04-05 12:17:48 -07:00
"objc/AppRTCMobile/ARDCaptureController.h",
"objc/AppRTCMobile/ARDCaptureController.m",
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
"objc/AppRTCMobile/ARDJoinResponse+Internal.h",
"objc/AppRTCMobile/ARDJoinResponse.h",
"objc/AppRTCMobile/ARDJoinResponse.m",
"objc/AppRTCMobile/ARDMessageResponse+Internal.h",
"objc/AppRTCMobile/ARDMessageResponse.h",
"objc/AppRTCMobile/ARDMessageResponse.m",
"objc/AppRTCMobile/ARDRoomServerClient.h",
"objc/AppRTCMobile/ARDSDPUtils.h",
"objc/AppRTCMobile/ARDSDPUtils.m",
Pass settings model to ARDAppClient instead of individual settings. Moves settings model and related classes to code common for both iOS and Mac. BUG=webrtc:7177,webrtc:6494 Review-Url: https://codereview.webrtc.org/2770113004 Cr-Commit-Position: refs/heads/master@{#17408}
2017-03-28 01:22:48 -07:00
"objc/AppRTCMobile/ARDSettingsModel+Private.h",
"objc/AppRTCMobile/ARDSettingsModel.h",
"objc/AppRTCMobile/ARDSettingsModel.m",
"objc/AppRTCMobile/ARDSettingsStore.h",
"objc/AppRTCMobile/ARDSettingsStore.m",
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
"objc/AppRTCMobile/ARDSignalingChannel.h",
"objc/AppRTCMobile/ARDSignalingMessage.h",
"objc/AppRTCMobile/ARDSignalingMessage.m",
"objc/AppRTCMobile/ARDStatsBuilder.h",
"objc/AppRTCMobile/ARDStatsBuilder.m",
Update ice server provider response format in iOS AppRTCMobile BUG=webrtc:5963 Review-Url: https://codereview.webrtc.org/2627523004 Cr-Commit-Position: refs/heads/master@{#16050}
2017-01-13 05:59:46 -08:00
"objc/AppRTCMobile/ARDTURNClient+Internal.h",
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
"objc/AppRTCMobile/ARDTURNClient.h",
Update ice server provider response format in iOS AppRTCMobile BUG=webrtc:5963 Review-Url: https://codereview.webrtc.org/2627523004 Cr-Commit-Position: refs/heads/master@{#16050}
2017-01-13 05:59:46 -08:00
"objc/AppRTCMobile/ARDTURNClient.m",
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
"objc/AppRTCMobile/ARDWebSocketChannel.h",
"objc/AppRTCMobile/ARDWebSocketChannel.m",
"objc/AppRTCMobile/RTCIceCandidate+JSON.h",
"objc/AppRTCMobile/RTCIceCandidate+JSON.m",
"objc/AppRTCMobile/RTCIceServer+JSON.h",
"objc/AppRTCMobile/RTCIceServer+JSON.m",
"objc/AppRTCMobile/RTCMediaConstraints+JSON.h",
"objc/AppRTCMobile/RTCMediaConstraints+JSON.m",
"objc/AppRTCMobile/RTCSessionDescription+JSON.h",
"objc/AppRTCMobile/RTCSessionDescription+JSON.m",
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
]
GN Templates: Move common_inherited_config to the template. Remove common_inherited_config from the targets and add it to the template instead. BUG=webrtc:6187 NOTRY=True Review-Url: https://codereview.webrtc.org/2311843002 Cr-Commit-Position: refs/heads/master@{#14069}
2016-09-05 06:10:18 -07:00
public_configs = [ ":apprtc_signaling_config" ]
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
deps = [
":apprtc_common",
":socketrocket",
]
Remove webrtc deps from AppRTCMobile. We want the example app to only link agains the framework. This ensures that we are actually testing the framework, and that AppRTCMobile doesn't require any other parts of WebRTC not included in the framework. Bug: webrtc:7759 Change-Id: Ib04aae0bc3ab2a1a508eaf4a4f15c2d37f521598 Reviewed-on: https://chromium-review.googlesource.com/522722 Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Commit-Queue: Kári Tristan Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#18470}
2017-06-02 14:05:56 +02:00
if (is_ios) {
deps += [ ":AppRTCMobile_ios_frameworks" ]
} else {
public_deps = [
"//webrtc/sdk:objc_peerconnection",
]
}
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
libs = [ "QuartzCore.framework" ]
}
if (is_ios) {
Add ARDSettingsModelTests to apprtcmobile_test target. Also extract all iOS sources into a static library configuration so it's easier to include them in the test target as well. Also, fix a wrong test that was undiscovered because the tests were not running BUG=webrtc:6707 Review-Url: https://codereview.webrtc.org/2502623002 Cr-Commit-Position: refs/heads/master@{#15076}
2016-11-15 00:41:26 -08:00
rtc_static_library("AppRTCMobile_lib") {
Reland "Enable GN check for webrtc/examples" This is a reland of https://codereview.webrtc.org/2714343002 with the errors related to inclusions of test targets in webrtc/api resolved. BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2733673002 Cr-Commit-Position: refs/heads/master@{#17053}
2017-03-06 00:29:21 -08:00
testonly = true
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
sources = [
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
"objc/AppRTCMobile/ios/ARDAppDelegate.m",
"objc/AppRTCMobile/ios/ARDMainView.h",
"objc/AppRTCMobile/ios/ARDMainView.m",
"objc/AppRTCMobile/ios/ARDMainViewController.h",
"objc/AppRTCMobile/ios/ARDMainViewController.m",
Add setting to AppRTCMobile for iOS, that can change capture resolution. To achieve this, several changes needed to be made on both UI and app logic level. * Settings view controller is added (modally shown when the settings button is pressed). - From there the user can see the current capture resolution and select another capture resolution. * Model class for the capture resolution added. - Improves readability and makes separation of concerns cleaner - Handles persisting - Provides defaults - Maps video resolution setting to RTCMediaConstraints dictionary * Test for the model class In future it would be possible to extend this CL and add further settings (i.e bit rate). Also it would be easy to remove the hardcoded resolutions and use dynamic values depending on device capability. BUG=webrtc:6473 Review-Url: https://codereview.webrtc.org/2462623002 Cr-Commit-Position: refs/heads/master@{#14881}
2016-11-02 02:56:09 -07:00
"objc/AppRTCMobile/ios/ARDSettingsViewController.h",
"objc/AppRTCMobile/ios/ARDSettingsViewController.m",
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
"objc/AppRTCMobile/ios/ARDStatsView.h",
"objc/AppRTCMobile/ios/ARDStatsView.m",
"objc/AppRTCMobile/ios/ARDVideoCallView.h",
"objc/AppRTCMobile/ios/ARDVideoCallView.m",
"objc/AppRTCMobile/ios/ARDVideoCallViewController.h",
"objc/AppRTCMobile/ios/ARDVideoCallViewController.m",
"objc/AppRTCMobile/ios/AppRTCMobile-Prefix.pch",
"objc/AppRTCMobile/ios/UIImage+ARDUtilities.h",
"objc/AppRTCMobile/ios/UIImage+ARDUtilities.m",
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
]
deps = [
Remove webrtc deps from AppRTCMobile. We want the example app to only link agains the framework. This ensures that we are actually testing the framework, and that AppRTCMobile doesn't require any other parts of WebRTC not included in the framework. Bug: webrtc:7759 Change-Id: Ib04aae0bc3ab2a1a508eaf4a4f15c2d37f521598 Reviewed-on: https://chromium-review.googlesource.com/522722 Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Commit-Queue: Kári Tristan Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#18470}
2017-06-02 14:05:56 +02:00
":AppRTCMobile_ios_frameworks",
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
":apprtc_common",
":apprtc_signaling",
]
Add ARDSettingsModelTests to apprtcmobile_test target. Also extract all iOS sources into a static library configuration so it's easier to include them in the test target as well. Also, fix a wrong test that was undiscovered because the tests were not running BUG=webrtc:6707 Review-Url: https://codereview.webrtc.org/2502623002 Cr-Commit-Position: refs/heads/master@{#15076}
2016-11-15 00:41:26 -08:00
}
ios_app_bundle("AppRTCMobile") {
Reland "Enable GN check for webrtc/examples" This is a reland of https://codereview.webrtc.org/2714343002 with the errors related to inclusions of test targets in webrtc/api resolved. BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2733673002 Cr-Commit-Position: refs/heads/master@{#17053}
2017-03-06 00:29:21 -08:00
testonly = true
Add ARDSettingsModelTests to apprtcmobile_test target. Also extract all iOS sources into a static library configuration so it's easier to include them in the test target as well. Also, fix a wrong test that was undiscovered because the tests were not running BUG=webrtc:6707 Review-Url: https://codereview.webrtc.org/2502623002 Cr-Commit-Position: refs/heads/master@{#15076}
2016-11-15 00:41:26 -08:00
sources = [
"objc/AppRTCMobile/ios/main.m",
]
info_plist = "objc/AppRTCMobile/ios/Info.plist"
configs += [ "..:common_config" ]
public_configs = [ "..:common_inherited_config" ]
deps = [
":AppRTCMobile_ios_bundle_data",
AppRTCMobile links against framework target. BUG=None Review-Url: https://codereview.webrtc.org/2656833002 Cr-Commit-Position: refs/heads/master@{#16287}
2017-01-26 01:14:04 -08:00
":AppRTCMobile_ios_frameworks",
Add ARDSettingsModelTests to apprtcmobile_test target. Also extract all iOS sources into a static library configuration so it's easier to include them in the test target as well. Also, fix a wrong test that was undiscovered because the tests were not running BUG=webrtc:6707 Review-Url: https://codereview.webrtc.org/2502623002 Cr-Commit-Position: refs/heads/master@{#15076}
2016-11-15 00:41:26 -08:00
":AppRTCMobile_lib",
]
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
if (target_cpu == "x86") {
deps += [ "//testing/iossim:iossim" ]
}
}
AppRTCMobile links against framework target. BUG=None Review-Url: https://codereview.webrtc.org/2656833002 Cr-Commit-Position: refs/heads/master@{#16287}
2017-01-26 01:14:04 -08:00
bundle_data("AppRTCMobile_ios_frameworks") {
public_deps = [
Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2911053002/ ) Reason for revert: Take three of relanding this after all internal issues have been resolved. Original issue's description: > Revert of Split iOS sdk in to separate targets (patchset #3 id:320001 of https://codereview.webrtc.org/2893843003/ ) > > Reason for revert: > Breaks downstream project. > > Original issue's description: > > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2893593002/ ) > > > > Reason for revert: > > Take two of fixing downstream issues? > > > > Original issue's description: > > > Revert of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890733003/ ) > > > > > > Reason for revert: > > > Still problems with downstream projects > > > > > > Original issue's description: > > > > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890513002/ ) > > > > > > > > Reason for revert: > > > > Fixing downstream breakages > > > > > > > > Original issue's description: > > > > > Revert of Split iOS sdk in to separate targets (patchset #13 id:280001 of https://codereview.webrtc.org/2862543002/ ) > > > > > > > > > > Reason for revert: > > > > > Breaking downstream projects. > > > > > > > > > > Original issue's description: > > > > > > Split iOS sdk in to separate targets > > > > > > > > > > > > This CL splits the iOS sdk into separate static libraries for video, > > > > > > audio, ui, common, and peerconnection-related code. This will in the > > > > > > future make it easier to compile WebRTC without unneeded components. > > > > > > > > > > > > BUG=webrtc:4867 > > > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2862543002 > > > > > > Cr-Commit-Position: refs/heads/master@{#18166} > > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/52c83fe7102f566cf35a7533092873d58b38f426 > > > > > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,kthelgason@webrtc.org > > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > > NOPRESUBMIT=true > > > > > NOTREECHECKS=true > > > > > NOTRY=true > > > > > BUG=webrtc:4867 > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2890513002 > > > > > Cr-Commit-Position: refs/heads/master@{#18170} > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/9756238084707787f735e1294e896e462e459717 > > > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > NOPRESUBMIT=true > > > > NOTREECHECKS=true > > > > NOTRY=true > > > > BUG=webrtc:4867 > > > > > > > > Review-Url: https://codereview.webrtc.org/2890733003 > > > > Cr-Commit-Position: refs/heads/master@{#18174} > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/d51e042492bedd057bc0cac7828979d5c7369cea > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > NOPRESUBMIT=true > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG=webrtc:4867 > > > > > > Review-Url: https://codereview.webrtc.org/2893593002 > > > Cr-Commit-Position: refs/heads/master@{#18182} > > > Committed: https://chromium.googlesource.com/external/webrtc/+/37144b214e2baf62ecb262ab878dde8c59cdd6a3 > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=webrtc:4867 > > > > Review-Url: https://codereview.webrtc.org/2893843003 > > Cr-Commit-Position: refs/heads/master@{#18303} > > Committed: https://chromium.googlesource.com/external/webrtc/+/580c3522d294c877adfe555048c675bd8d166657 > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org,kthelgason@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:4867 > > Review-Url: https://codereview.webrtc.org/2911053002 > Cr-Commit-Position: refs/heads/master@{#18309} > Committed: https://chromium.googlesource.com/external/webrtc/+/af5c05540cc8208f682cafe88c5c16a505479196 TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org,mbonadei@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4867 Review-Url: https://codereview.webrtc.org/2913753003 Cr-Commit-Position: refs/heads/master@{#18319}
2017-05-30 01:48:47 -07:00
"//webrtc/sdk:objc_framework+link",
AppRTCMobile links against framework target. BUG=None Review-Url: https://codereview.webrtc.org/2656833002 Cr-Commit-Position: refs/heads/master@{#16287}
2017-01-26 01:14:04 -08:00
]
sources = [
"$root_out_dir/WebRTC.framework",
]
outputs = [
"{{bundle_resources_dir}}/Frameworks/{{source_file_part}}",
]
}
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
bundle_data("AppRTCMobile_ios_bundle_data") {
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
sources = [
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
"objc/AppRTCMobile/ios/resources/Roboto-Regular.ttf",
"objc/AppRTCMobile/ios/resources/iPhone5@2x.png",
"objc/AppRTCMobile/ios/resources/iPhone6@2x.png",
"objc/AppRTCMobile/ios/resources/iPhone6p@3x.png",
"objc/AppRTCMobile/ios/resources/ic_call_end_black_24dp.png",
"objc/AppRTCMobile/ios/resources/ic_call_end_black_24dp@2x.png",
"objc/AppRTCMobile/ios/resources/ic_clear_black_24dp.png",
"objc/AppRTCMobile/ios/resources/ic_clear_black_24dp@2x.png",
Add UINavigationController and settings bar button to AppRTCMobile. The navigation controller is used to display the title of the app and to feature the settings button. This work is foundation for adding settings screen to the app (see webrtc:6473 for more info) BUG=webrtc:6618, webrtc:6473 Review-Url: https://codereview.webrtc.org/2455363002 Cr-Commit-Position: refs/heads/master@{#14816}
2016-10-28 04:53:16 -07:00
"objc/AppRTCMobile/ios/resources/ic_settings_black_24dp.png",
"objc/AppRTCMobile/ios/resources/ic_settings_black_24dp@2x.png",
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
"objc/AppRTCMobile/ios/resources/ic_surround_sound_black_24dp.png",
"objc/AppRTCMobile/ios/resources/ic_surround_sound_black_24dp@2x.png",
"objc/AppRTCMobile/ios/resources/ic_switch_video_black_24dp.png",
"objc/AppRTCMobile/ios/resources/ic_switch_video_black_24dp@2x.png",
"objc/AppRTCMobile/ios/resources/mozart.mp3",
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
"objc/Icon.png",
]
outputs = [
"{{bundle_resources_dir}}/{{source_file_part}}",
]
}
}
if (is_mac) {
Add ARDSettingsModelTests to apprtcmobile_test target. Also extract all iOS sources into a static library configuration so it's easier to include them in the test target as well. Also, fix a wrong test that was undiscovered because the tests were not running BUG=webrtc:6707 Review-Url: https://codereview.webrtc.org/2502623002 Cr-Commit-Position: refs/heads/master@{#15076}
2016-11-15 00:41:26 -08:00
rtc_static_library("AppRTCMobile_lib") {
Reland "Enable GN check for webrtc/examples" This is a reland of https://codereview.webrtc.org/2714343002 with the errors related to inclusions of test targets in webrtc/api resolved. BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2733673002 Cr-Commit-Position: refs/heads/master@{#17053}
2017-03-06 00:29:21 -08:00
testonly = true
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
sources = [
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
"objc/AppRTCMobile/mac/APPRTCAppDelegate.h",
"objc/AppRTCMobile/mac/APPRTCAppDelegate.m",
"objc/AppRTCMobile/mac/APPRTCViewController.h",
"objc/AppRTCMobile/mac/APPRTCViewController.m",
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
]
Reland of GN: Enable ARC for Mac and iOS in rtc_* templates (patchset #1 id:1 of https://codereview.webrtc.org/2827223003/ ) Reason for revert: Relanding after fixing ARC issue. Original issue's description: > Revert of GN: Enable ARC for Mac and iOS in rtc_* templates (patchset #3 id:40001 of https://codereview.webrtc.org/2781713004/ ) > > Reason for revert: > Breaks mac build > > Original issue's description: > > GN: Enable ARC for Mac and iOS in rtc_* templates > > > > Remove all uses of retain/release and NSAutoreleasePool. > > > > This makes transformation to Bazel easier. > > > > This CL subsumes https://codereview.webrtc.org/2778163002 and depends on https://codereview.webrtc.org/2784483002/ > > > > BUG=webrtc:6412 > > > > Review-Url: https://codereview.webrtc.org/2781713004 > > Cr-Commit-Position: refs/heads/master@{#17780} > > Committed: https://chromium.googlesource.com/external/webrtc/+/6bda02b51dc00401d2a0d04be996ed10e5acac47 > > TBR=kjellander@webrtc.org,magjed@webrtc.org,stefan@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6412 > > Review-Url: https://codereview.webrtc.org/2827223003 > Cr-Commit-Position: refs/heads/master@{#17784} > Committed: https://chromium.googlesource.com/external/webrtc/+/7c8786ae8f2d8481f74b0ab16eb91a8101fe51dc TBR=kjellander@webrtc.org,magjed@webrtc.org,stefan@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6412 Review-Url: https://codereview.webrtc.org/2834273002 Cr-Commit-Position: refs/heads/master@{#17836}
2017-04-24 00:57:16 -07:00
configs += [ "//webrtc:common_objc" ]
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
deps = [
":apprtc_common",
":apprtc_signaling",
Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2911053002/ ) Reason for revert: Take three of relanding this after all internal issues have been resolved. Original issue's description: > Revert of Split iOS sdk in to separate targets (patchset #3 id:320001 of https://codereview.webrtc.org/2893843003/ ) > > Reason for revert: > Breaks downstream project. > > Original issue's description: > > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2893593002/ ) > > > > Reason for revert: > > Take two of fixing downstream issues? > > > > Original issue's description: > > > Revert of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890733003/ ) > > > > > > Reason for revert: > > > Still problems with downstream projects > > > > > > Original issue's description: > > > > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890513002/ ) > > > > > > > > Reason for revert: > > > > Fixing downstream breakages > > > > > > > > Original issue's description: > > > > > Revert of Split iOS sdk in to separate targets (patchset #13 id:280001 of https://codereview.webrtc.org/2862543002/ ) > > > > > > > > > > Reason for revert: > > > > > Breaking downstream projects. > > > > > > > > > > Original issue's description: > > > > > > Split iOS sdk in to separate targets > > > > > > > > > > > > This CL splits the iOS sdk into separate static libraries for video, > > > > > > audio, ui, common, and peerconnection-related code. This will in the > > > > > > future make it easier to compile WebRTC without unneeded components. > > > > > > > > > > > > BUG=webrtc:4867 > > > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2862543002 > > > > > > Cr-Commit-Position: refs/heads/master@{#18166} > > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/52c83fe7102f566cf35a7533092873d58b38f426 > > > > > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,kthelgason@webrtc.org > > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > > NOPRESUBMIT=true > > > > > NOTREECHECKS=true > > > > > NOTRY=true > > > > > BUG=webrtc:4867 > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2890513002 > > > > > Cr-Commit-Position: refs/heads/master@{#18170} > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/9756238084707787f735e1294e896e462e459717 > > > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > NOPRESUBMIT=true > > > > NOTREECHECKS=true > > > > NOTRY=true > > > > BUG=webrtc:4867 > > > > > > > > Review-Url: https://codereview.webrtc.org/2890733003 > > > > Cr-Commit-Position: refs/heads/master@{#18174} > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/d51e042492bedd057bc0cac7828979d5c7369cea > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > NOPRESUBMIT=true > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG=webrtc:4867 > > > > > > Review-Url: https://codereview.webrtc.org/2893593002 > > > Cr-Commit-Position: refs/heads/master@{#18182} > > > Committed: https://chromium.googlesource.com/external/webrtc/+/37144b214e2baf62ecb262ab878dde8c59cdd6a3 > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=webrtc:4867 > > > > Review-Url: https://codereview.webrtc.org/2893843003 > > Cr-Commit-Position: refs/heads/master@{#18303} > > Committed: https://chromium.googlesource.com/external/webrtc/+/580c3522d294c877adfe555048c675bd8d166657 > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org,kthelgason@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:4867 > > Review-Url: https://codereview.webrtc.org/2911053002 > Cr-Commit-Position: refs/heads/master@{#18309} > Committed: https://chromium.googlesource.com/external/webrtc/+/af5c05540cc8208f682cafe88c5c16a505479196 TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org,mbonadei@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4867 Review-Url: https://codereview.webrtc.org/2913753003 Cr-Commit-Position: refs/heads/master@{#18319}
2017-05-30 01:48:47 -07:00
"//webrtc/sdk:objc_ui",
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
]
}
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
mac_app_bundle("AppRTCMobile") {
Reland "Enable GN check for webrtc/examples" This is a reland of https://codereview.webrtc.org/2714343002 with the errors related to inclusions of test targets in webrtc/api resolved. BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2733673002 Cr-Commit-Position: refs/heads/master@{#17053}
2017-03-06 00:29:21 -08:00
testonly = true
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
output_name = "AppRTCMobile"
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
sources = [
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
"objc/AppRTCMobile/mac/main.m",
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
]
public_configs = [ "..:common_inherited_config" ]
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
info_plist = "objc/AppRTCMobile/mac/Info.plist"
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
libs = [ "AppKit.framework" ]
deps = [
Add ARDSettingsModelTests to apprtcmobile_test target. Also extract all iOS sources into a static library configuration so it's easier to include them in the test target as well. Also, fix a wrong test that was undiscovered because the tests were not running BUG=webrtc:6707 Review-Url: https://codereview.webrtc.org/2502623002 Cr-Commit-Position: refs/heads/master@{#15076}
2016-11-15 00:41:26 -08:00
":AppRTCMobile_lib",
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
]
}
}
config("socketrocket_include_config") {
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
include_dirs = [ "objc/AppRTCMobile/third_party/SocketRocket" ]
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
}
config("socketrocket_warning_config") {
# GN orders flags on a target before flags from configs. The default config
# adds these flags so to cancel them out they need to come from a config and
# cannot be on the target directly.
cflags = [
"-Wno-deprecated-declarations",
"-Wno-nonnull",
"-Wno-semicolon-before-method-body",
Revert of Remove some warning suppressions from SocketRocket. (patchset #1 id:1 of https://codereview.webrtc.org/2704383004/ ) Reason for revert: Breaks buildbot Original issue's description: > Remove some warning suppressions from SocketRocket. > > These warnings started appearing on a clang update. This CL patches the > vendored library and removes the supression. We assert on the return as > we're not equipped to deal with failures there anyway. > > BUG=webrtc:6396 > NOTRY=true > > Review-Url: https://codereview.webrtc.org/2704383004 > Cr-Commit-Position: refs/heads/master@{#16820} > Committed: https://chromium.googlesource.com/external/webrtc/+/49990e88fb523901b28d10f2026602cb86528b0d TBR=kjellander@webrtc.org,magjed@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6396 Review-Url: https://codereview.webrtc.org/2714123002 Cr-Commit-Position: refs/heads/master@{#16822}
2017-02-24 01:56:01 -08:00
"-Wno-unused-variable",
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
]
Ignores warning for SecRandomCopyBytes() using Xcode 8 BUG=webrtc:6396 NOTRY=TRUE TBR=kjellander Review-Url: https://codereview.webrtc.org/2356073004 Cr-Commit-Position: refs/heads/master@{#14326}
2016-09-21 04:13:00 -07:00
cflags_objc = [
# Enabled for cflags_objc in build/config/compiler/BUILD.gn.
"-Wno-objc-missing-property-synthesis",
]
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
}
GN: Change rtc_source_set targets --> rtc_static_library This changes most non-test related rtc_source_set targets to be rtc_static_library instead. Targets without any .cc files are excluded. This should bring back the build behavior we used to have with GYP (i.e. same symbols exported in the libjingle_peerconnection.a file, which are used by some downstream projects). After doing an Android build with these changes: $ nm --defined-only -g -C out/Release/lib.unstripped/libjingle_peerconnection_so.so | grep -i createpeerconnectionf 00077c51 T Java_org_webrtc_PeerConnectionFactory_nativeCreatePeerConnectionFactory $ nm --defined-only -g -C out/Release/obj/webrtc/api/libjingle_peerconnection.a | grep -i createpeerconnectionf 00000001 T webrtc::CreatePeerConnectionFactory(rtc::Thread*, rtc::Thread*, rtc::Thread*, webrtc::AudioDeviceModule*, cricket::WebRtcVideoEncoderFactory*, cricket::WebRtcVideoDecoderFactory*) 00000001 T webrtc::CreatePeerConnectionFactory() See https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/cookbook.md#Note-on-static-libraries for more details on this. NOTICE: This should be further cleaned up in the future, to reduce binary bloat and unnecessary linking time. Right now it's more important to restore the desired build output though. BUG=webrtc:6410, chromium:630755 Review-Url: https://codereview.webrtc.org/2361623004 Cr-Commit-Position: refs/heads/master@{#14364}
2016-09-23 00:38:52 -07:00
rtc_static_library("socketrocket") {
Reland "Enable GN check for webrtc/examples" This is a reland of https://codereview.webrtc.org/2714343002 with the errors related to inclusions of test targets in webrtc/api resolved. BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2733673002 Cr-Commit-Position: refs/heads/master@{#17053}
2017-03-06 00:29:21 -08:00
testonly = true
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
sources = [
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
"objc/AppRTCMobile/third_party/SocketRocket/SRWebSocket.h",
"objc/AppRTCMobile/third_party/SocketRocket/SRWebSocket.m",
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
]
Reland of GN: Enable ARC for Mac and iOS in rtc_* templates (patchset #1 id:1 of https://codereview.webrtc.org/2827223003/ ) Reason for revert: Relanding after fixing ARC issue. Original issue's description: > Revert of GN: Enable ARC for Mac and iOS in rtc_* templates (patchset #3 id:40001 of https://codereview.webrtc.org/2781713004/ ) > > Reason for revert: > Breaks mac build > > Original issue's description: > > GN: Enable ARC for Mac and iOS in rtc_* templates > > > > Remove all uses of retain/release and NSAutoreleasePool. > > > > This makes transformation to Bazel easier. > > > > This CL subsumes https://codereview.webrtc.org/2778163002 and depends on https://codereview.webrtc.org/2784483002/ > > > > BUG=webrtc:6412 > > > > Review-Url: https://codereview.webrtc.org/2781713004 > > Cr-Commit-Position: refs/heads/master@{#17780} > > Committed: https://chromium.googlesource.com/external/webrtc/+/6bda02b51dc00401d2a0d04be996ed10e5acac47 > > TBR=kjellander@webrtc.org,magjed@webrtc.org,stefan@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6412 > > Review-Url: https://codereview.webrtc.org/2827223003 > Cr-Commit-Position: refs/heads/master@{#17784} > Committed: https://chromium.googlesource.com/external/webrtc/+/7c8786ae8f2d8481f74b0ab16eb91a8101fe51dc TBR=kjellander@webrtc.org,magjed@webrtc.org,stefan@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6412 Review-Url: https://codereview.webrtc.org/2834273002 Cr-Commit-Position: refs/heads/master@{#17836}
2017-04-24 00:57:16 -07:00
configs += [ ":socketrocket_warning_config" ]
GN Templates: Move common_inherited_config to the template. Remove common_inherited_config from the targets and add it to the template instead. BUG=webrtc:6187 NOTRY=True Review-Url: https://codereview.webrtc.org/2311843002 Cr-Commit-Position: refs/heads/master@{#14069}
2016-09-05 06:10:18 -07:00
public_configs = [ ":socketrocket_include_config" ]
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
libs = [
"CFNetwork.framework",
"icucore",
]
}
Add a GN target for unit tests, get them working again and added a test. BUG=webrtc:3417 Review-Url: https://codereview.webrtc.org/2050153003 Cr-Commit-Position: refs/heads/master@{#14959}
2016-11-07 14:53:28 -08:00
if (rtc_include_tests) {
Move iOS tests to XCTest from gtest. This enables tighter integration with XCode tooling and is a prereq for adding UI tests. BUG=webrtc:7150 Review-Url: https://codereview.webrtc.org/2697603002 Cr-Commit-Position: refs/heads/master@{#16609}
2017-02-14 04:58:56 -08:00
# TODO(kthelgason): compile xctests on mac when chromium supports it.
if (is_ios) {
rtc_source_set("apprtcmobile_test_sources") {
Reland "Enable GN check for webrtc/examples" This is a reland of https://codereview.webrtc.org/2714343002 with the errors related to inclusions of test targets in webrtc/api resolved. BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2733673002 Cr-Commit-Position: refs/heads/master@{#17053}
2017-03-06 00:29:21 -08:00
testonly = true
Move iOS tests to XCTest from gtest. This enables tighter integration with XCode tooling and is a prereq for adding UI tests. BUG=webrtc:7150 Review-Url: https://codereview.webrtc.org/2697603002 Cr-Commit-Position: refs/heads/master@{#16609}
2017-02-14 04:58:56 -08:00
include_dirs = [
"objc/AppRTCMobile",
"objc/AppRTCMobile/ios",
]
testonly = true
sources = [
"objc/AppRTCMobile/tests/ARDAppClient_xctest.mm",
"objc/AppRTCMobile/tests/ARDSDPUtils_xctest.mm",
"objc/AppRTCMobile/tests/ARDSettingsModel_xctest.mm",
]
Reland "Enable GN check for webrtc/examples" This is a reland of https://codereview.webrtc.org/2714343002 with the errors related to inclusions of test targets in webrtc/api resolved. BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2733673002 Cr-Commit-Position: refs/heads/master@{#17053}
2017-03-06 00:29:21 -08:00
deps = [
Revert of Remove remains of webrtc/base (patchset #7 id:120001 of https://codereview.webrtc.org/2973183002/ ) Reason for revert: Breaks lots of downstream projects. Original issue's description: > Remove remains of webrtc/base > > All downstream code have been updated to the new location. > > In PRESUBMIT.py: > * Remove webrtc/rtc_base from CPP_BLACKLIST > * Add webrtc/rtc_base to LEGACY_API_DIRS > > Fix some duplicated paths in > webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn > > BUG=webrtc:7634 > TBR=kwiberg@webrtc.org > > Review-Url: https://codereview.webrtc.org/2973183002 > Cr-Commit-Position: refs/heads/master@{#18948} > Committed: https://chromium.googlesource.com/external/webrtc/+/9483b49bafc681a8360dff7217e7651a74dea71d TBR=kwiberg@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7634 Review-Url: https://codereview.webrtc.org/2976633002 Cr-Commit-Position: refs/heads/master@{#18949}
2017-07-10 05:58:42 -07:00
"//webrtc/base:rtc_base",
Reland "Enable GN check for webrtc/examples" This is a reland of https://codereview.webrtc.org/2714343002 with the errors related to inclusions of test targets in webrtc/api resolved. BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2733673002 Cr-Commit-Position: refs/heads/master@{#17053}
2017-03-06 00:29:21 -08:00
]
Move iOS tests to XCTest from gtest. This enables tighter integration with XCode tooling and is a prereq for adding UI tests. BUG=webrtc:7150 Review-Url: https://codereview.webrtc.org/2697603002 Cr-Commit-Position: refs/heads/master@{#16609}
2017-02-14 04:58:56 -08:00
public_deps = [
":AppRTCMobile_ios_frameworks",
":AppRTCMobile_lib",
"//build/config/ios:xctest",
"//third_party/ocmock",
]
}
Add a GN target for unit tests, get them working again and added a test. BUG=webrtc:3417 Review-Url: https://codereview.webrtc.org/2050153003 Cr-Commit-Position: refs/heads/master@{#14959}
2016-11-07 14:53:28 -08:00
Move iOS tests to XCTest from gtest. This enables tighter integration with XCode tooling and is a prereq for adding UI tests. BUG=webrtc:7150 Review-Url: https://codereview.webrtc.org/2697603002 Cr-Commit-Position: refs/heads/master@{#16609}
2017-02-14 04:58:56 -08:00
rtc_ios_xctest_test("apprtcmobile_tests") {
Add a GN target for unit tests, get them working again and added a test. BUG=webrtc:3417 Review-Url: https://codereview.webrtc.org/2050153003 Cr-Commit-Position: refs/heads/master@{#14959}
2016-11-07 14:53:28 -08:00
info_plist = "objc/AppRTCMobile/ios/Info.plist"
Move iOS tests to XCTest from gtest. This enables tighter integration with XCode tooling and is a prereq for adding UI tests. BUG=webrtc:7150 Review-Url: https://codereview.webrtc.org/2697603002 Cr-Commit-Position: refs/heads/master@{#16609}
2017-02-14 04:58:56 -08:00
sources = [
"objc/AppRTCMobile/ios/main.m",
]
deps = [
":apprtcmobile_test_sources",
]
ldflags = [ "-all_load" ]
Add a GN target for unit tests, get them working again and added a test. BUG=webrtc:3417 Review-Url: https://codereview.webrtc.org/2050153003 Cr-Commit-Position: refs/heads/master@{#14959}
2016-11-07 14:53:28 -08:00
}
}
}
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
}
Create gn target for peerconnection examples BUG= Review-Url: https://codereview.webrtc.org/2218053002 Cr-Commit-Position: refs/heads/master@{#13673}
2016-08-08 09:03:23 -07:00
if (is_linux || is_win) {
GN: Fix windows clang errors. Attempt 2. BUG=webrtc:6255 NOTRY=True Review-Url: https://codereview.webrtc.org/2281513002 Cr-Commit-Position: refs/heads/master@{#13942}
2016-08-26 13:31:24 -07:00
config("peerconnection_client_warnings_config") {
GN: Enable rtc_common_config for more targets. In the migration to GN templates, some targets got the whole rtc_common_config removed, which can have unpredicted consequences in terms of different code behavior due to defines not being set as expected etc. It's better to enable this config and only disable the warnings that fails the build. BUG=webrtc:6306,webrtc:6307,webrtc:6308 NOTRY=True Review-Url: https://codereview.webrtc.org/2347263002 Cr-Commit-Position: refs/heads/master@{#14280}
2016-09-18 08:12:29 -07:00
cflags = []
GN: Fix windows clang errors. Attempt 2. BUG=webrtc:6255 NOTRY=True Review-Url: https://codereview.webrtc.org/2281513002 Cr-Commit-Position: refs/heads/master@{#13942}
2016-08-26 13:31:24 -07:00
if (is_win && is_clang) {
GN: Enable rtc_common_config for more targets. In the migration to GN templates, some targets got the whole rtc_common_config removed, which can have unpredicted consequences in terms of different code behavior due to defines not being set as expected etc. It's better to enable this config and only disable the warnings that fails the build. BUG=webrtc:6306,webrtc:6307,webrtc:6308 NOTRY=True Review-Url: https://codereview.webrtc.org/2347263002 Cr-Commit-Position: refs/heads/master@{#14280}
2016-09-18 08:12:29 -07:00
cflags += [
GN: Fix windows clang errors. Attempt 2. BUG=webrtc:6255 NOTRY=True Review-Url: https://codereview.webrtc.org/2281513002 Cr-Commit-Position: refs/heads/master@{#13942}
2016-08-26 13:31:24 -07:00
# Disable warnings failing when compiling with Clang on Windows.
# https://bugs.chromium.org/p/webrtc/issues/detail?id=5366
"-Wno-format",
# See https://bugs.chromium.org/p/webrtc/issues/detail?id=6271
# for -Wno-reorder and -Wno-sign-compare
"-Wno-reorder",
"-Wno-sign-compare",
]
}
Disable -Wsentinel warning for Linux 32-bit builds. BUG=chromium:644167 NOTRY=True Review-Url: https://codereview.webrtc.org/2316943002 Cr-Commit-Position: refs/heads/master@{#14099}
2016-09-07 02:33:01 -07:00
if (is_linux && target_cpu == "x86") {
GN: Enable rtc_common_config for more targets. In the migration to GN templates, some targets got the whole rtc_common_config removed, which can have unpredicted consequences in terms of different code behavior due to defines not being set as expected etc. It's better to enable this config and only disable the warnings that fails the build. BUG=webrtc:6306,webrtc:6307,webrtc:6308 NOTRY=True Review-Url: https://codereview.webrtc.org/2347263002 Cr-Commit-Position: refs/heads/master@{#14280}
2016-09-18 08:12:29 -07:00
cflags += [
Disable -Wsentinel warning for Linux 32-bit builds. BUG=chromium:644167 NOTRY=True Review-Url: https://codereview.webrtc.org/2316943002 Cr-Commit-Position: refs/heads/master@{#14099}
2016-09-07 02:33:01 -07:00
# Needed to compile on Linux 32-bit.
"-Wno-sentinel",
]
}
GN: Enable rtc_common_config for more targets. In the migration to GN templates, some targets got the whole rtc_common_config removed, which can have unpredicted consequences in terms of different code behavior due to defines not being set as expected etc. It's better to enable this config and only disable the warnings that fails the build. BUG=webrtc:6306,webrtc:6307,webrtc:6308 NOTRY=True Review-Url: https://codereview.webrtc.org/2347263002 Cr-Commit-Position: refs/heads/master@{#14280}
2016-09-18 08:12:29 -07:00
if (is_clang) {
# TODO(ehmaldonado): Make peerconnection_client compile with the standard
# set of warnings.
# See https://bugs.chromium.org/p/webrtc/issues/detail?id=6306
cflags += [ "-Wno-inconsistent-missing-override" ]
}
GN: Fix windows clang errors. Attempt 2. BUG=webrtc:6255 NOTRY=True Review-Url: https://codereview.webrtc.org/2281513002 Cr-Commit-Position: refs/heads/master@{#13942}
2016-08-26 13:31:24 -07:00
}
GN: Introduce templates. Defines the rtc_executable, rtc_source_set, rtc_test and rtc_static_library templates. These templates provide no functionality yet, but will enable common configuration to be introduced, avoiding repetition in every target Changes summary: - Prepend rtc_ to test, source_set, executable and static_library targets - Change "configs -= [" to "suppressed_configs += [" - Include webrtc/build/webrtc.gni where it wasn't included yet - Delete import("//testing/test.gni"), since rtc_test makes it unnecessary. BUG=webrtc:6187 TBR=henrik.lundin@webrtc.org,tommi@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2301053002 Cr-Commit-Position: refs/heads/master@{#14043}
2016-09-02 04:10:34 -07:00
rtc_executable("peerconnection_client") {
Reland "Enable GN check for webrtc/examples" This is a reland of https://codereview.webrtc.org/2714343002 with the errors related to inclusions of test targets in webrtc/api resolved. BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2733673002 Cr-Commit-Position: refs/heads/master@{#17053}
2017-03-06 00:29:21 -08:00
testonly = true
Create gn target for peerconnection examples BUG= Review-Url: https://codereview.webrtc.org/2218053002 Cr-Commit-Position: refs/heads/master@{#13673}
2016-08-08 09:03:23 -07:00
sources = [
"peerconnection/client/conductor.cc",
"peerconnection/client/conductor.h",
"peerconnection/client/defaults.cc",
"peerconnection/client/defaults.h",
"peerconnection/client/peer_connection_client.cc",
"peerconnection/client/peer_connection_client.h",
]
GN Templates: Move common_config to the template. Remove common_config from the targets' config and add it to the template instead. BUG=webrtc:6187 NOTRY=True Review-Url: https://codereview.webrtc.org/2300413002 Cr-Commit-Position: refs/heads/master@{#14063}
2016-09-05 01:35:44 -07:00
GN: Exclude suppressions of Chromium Clang warnings for Chromium builds. These suppressions are causing GN errors when Chromium targets are depending directly on WebRTC targets (needed for https://codereview.chromium.org/2413103004) BUG=webrtc:4256 NOTRY=True Review-Url: https://codereview.webrtc.org/2408133008 Cr-Commit-Position: refs/heads/master@{#14644}
2016-10-16 23:56:12 -07:00
if (!build_with_chromium && is_clang) {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
GN: Introduce templates. Defines the rtc_executable, rtc_source_set, rtc_test and rtc_static_library templates. These templates provide no functionality yet, but will enable common configuration to be introduced, avoiding repetition in every target Changes summary: - Prepend rtc_ to test, source_set, executable and static_library targets - Change "configs -= [" to "suppressed_configs += [" - Include webrtc/build/webrtc.gni where it wasn't included yet - Delete import("//testing/test.gni"), since rtc_test makes it unnecessary. BUG=webrtc:6187 TBR=henrik.lundin@webrtc.org,tommi@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2301053002 Cr-Commit-Position: refs/heads/master@{#14043}
2016-09-02 04:10:34 -07:00
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
Create gn target for peerconnection examples BUG= Review-Url: https://codereview.webrtc.org/2218053002 Cr-Commit-Position: refs/heads/master@{#13673}
2016-08-08 09:03:23 -07:00
}
Reland "Enable GN check for webrtc/examples" This is a reland of https://codereview.webrtc.org/2714343002 with the errors related to inclusions of test targets in webrtc/api resolved. BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2733673002 Cr-Commit-Position: refs/heads/master@{#17053}
2017-03-06 00:29:21 -08:00
deps = []
Create gn target for peerconnection examples BUG= Review-Url: https://codereview.webrtc.org/2218053002 Cr-Commit-Position: refs/heads/master@{#13673}
2016-08-08 09:03:23 -07:00
if (is_win) {
sources += [
"peerconnection/client/flagdefs.h",
"peerconnection/client/main.cc",
"peerconnection/client/main_wnd.cc",
"peerconnection/client/main_wnd.h",
]
cflags = [ "/wd4245" ]
configs += [ "//build/config/win:windowed" ]
Reland "Enable GN check for webrtc/examples" This is a reland of https://codereview.webrtc.org/2714343002 with the errors related to inclusions of test targets in webrtc/api resolved. BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2733673002 Cr-Commit-Position: refs/heads/master@{#17053}
2017-03-06 00:29:21 -08:00
deps += [ "//webrtc/media:rtc_media_base" ]
Create gn target for peerconnection examples BUG= Review-Url: https://codereview.webrtc.org/2218053002 Cr-Commit-Position: refs/heads/master@{#13673}
2016-08-08 09:03:23 -07:00
}
if (is_linux) {
sources += [
"peerconnection/client/linux/main.cc",
"peerconnection/client/linux/main_wnd.cc",
"peerconnection/client/linux/main_wnd.h",
]
Roll chromium_revision 4f16f0c98f..a896ff44a3 (459568:459701) Change log: https://chromium.googlesource.com/chromium/src/+log/4f16f0c98f..a896ff44a3 Full diff: https://chromium.googlesource.com/chromium/src/+/4f16f0c98f..a896ff44a3 Changed dependencies: * src/base: https://chromium.googlesource.com/chromium/src/base/+log/d85a3c5a13..52145f4993 * src/build: https://chromium.googlesource.com/chromium/src/build/+log/f792848af8..ad3a39abce * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/46b14a7c3f..9f63fb7341 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/16c9fdd3a4..aa776e6172 * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/5982252235..6c4bf3684c * src/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/517173b5db..0cfeabf700 * src/third_party/libFuzzer/src: https://chromium.googlesource.com/chromium/llvm-project/llvm/lib/Fuzzer.git/+log/b9454401d3..57ed386045 * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/157e8fc5ce..297b0ff5dd DEPS diff: https://chromium.googlesource.com/chromium/src/+/4f16f0c98f..a896ff44a3/DEPS No update to Clang. TBR= BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/2777023002 . Cr-Commit-Position: refs/heads/master@{#17382}
2017-03-27 08:28:27 +02:00
cflags = [ "-Wno-deprecated-declarations" ]
Create gn target for peerconnection examples BUG= Review-Url: https://codereview.webrtc.org/2218053002 Cr-Commit-Position: refs/heads/master@{#13673}
2016-08-08 09:03:23 -07:00
libs = [
"X11",
"Xcomposite",
"Xext",
"Xrender",
]
Add a gtk3 port of peerconnection_client on Linux BUG=668446 Review-Url: https://codereview.webrtc.org/2563203002 Cr-Commit-Position: refs/heads/master@{#15569}
2016-12-13 02:57:43 -08:00
deps += [ "//build/config/linux/gtk" ]
Create gn target for peerconnection examples BUG= Review-Url: https://codereview.webrtc.org/2218053002 Cr-Commit-Position: refs/heads/master@{#13673}
2016-08-08 09:03:23 -07:00
}
GN: Fix windows clang errors. Attempt 2. BUG=webrtc:6255 NOTRY=True Review-Url: https://codereview.webrtc.org/2281513002 Cr-Commit-Position: refs/heads/master@{#13942}
2016-08-26 13:31:24 -07:00
configs += [ ":peerconnection_client_warnings_config" ]
Reland "Enable GN check for webrtc/examples" This is a reland of https://codereview.webrtc.org/2714343002 with the errors related to inclusions of test targets in webrtc/api resolved. BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2733673002 Cr-Commit-Position: refs/heads/master@{#17053}
2017-03-06 00:29:21 -08:00
deps += [
"//third_party/libyuv",
"//webrtc/api:libjingle_peerconnection_test_api",
"//webrtc/api:video_frame_api",
Revert of Remove remains of webrtc/base (patchset #7 id:120001 of https://codereview.webrtc.org/2973183002/ ) Reason for revert: Breaks lots of downstream projects. Original issue's description: > Remove remains of webrtc/base > > All downstream code have been updated to the new location. > > In PRESUBMIT.py: > * Remove webrtc/rtc_base from CPP_BLACKLIST > * Add webrtc/rtc_base to LEGACY_API_DIRS > > Fix some duplicated paths in > webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn > > BUG=webrtc:7634 > TBR=kwiberg@webrtc.org > > Review-Url: https://codereview.webrtc.org/2973183002 > Cr-Commit-Position: refs/heads/master@{#18948} > Committed: https://chromium.googlesource.com/external/webrtc/+/9483b49bafc681a8360dff7217e7651a74dea71d TBR=kwiberg@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7634 Review-Url: https://codereview.webrtc.org/2976633002 Cr-Commit-Position: refs/heads/master@{#18949}
2017-07-10 05:58:42 -07:00
"//webrtc/base:rtc_base",
"//webrtc/base:rtc_base_approved",
"//webrtc/base:rtc_json",
Reland "Enable GN check for webrtc/examples" This is a reland of https://codereview.webrtc.org/2714343002 with the errors related to inclusions of test targets in webrtc/api resolved. BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2733673002 Cr-Commit-Position: refs/heads/master@{#17053}
2017-03-06 00:29:21 -08:00
"//webrtc/media:rtc_media",
"//webrtc/modules/video_capture:video_capture_module",
"//webrtc/pc:libjingle_peerconnection",
"//webrtc/system_wrappers:field_trial_default",
"//webrtc/system_wrappers:metrics_default",
]
Create gn target for peerconnection examples BUG= Review-Url: https://codereview.webrtc.org/2218053002 Cr-Commit-Position: refs/heads/master@{#13673}
2016-08-08 09:03:23 -07:00
}
Disable -Wsentinel warning for Linux 32-bit builds. BUG=chromium:644167 NOTRY=True Review-Url: https://codereview.webrtc.org/2316943002 Cr-Commit-Position: refs/heads/master@{#14099}
2016-09-07 02:33:01 -07:00
GN: Introduce templates. Defines the rtc_executable, rtc_source_set, rtc_test and rtc_static_library templates. These templates provide no functionality yet, but will enable common configuration to be introduced, avoiding repetition in every target Changes summary: - Prepend rtc_ to test, source_set, executable and static_library targets - Change "configs -= [" to "suppressed_configs += [" - Include webrtc/build/webrtc.gni where it wasn't included yet - Delete import("//testing/test.gni"), since rtc_test makes it unnecessary. BUG=webrtc:6187 TBR=henrik.lundin@webrtc.org,tommi@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2301053002 Cr-Commit-Position: refs/heads/master@{#14043}
2016-09-02 04:10:34 -07:00
rtc_executable("peerconnection_server") {
Reland "Enable GN check for webrtc/examples" This is a reland of https://codereview.webrtc.org/2714343002 with the errors related to inclusions of test targets in webrtc/api resolved. BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2733673002 Cr-Commit-Position: refs/heads/master@{#17053}
2017-03-06 00:29:21 -08:00
testonly = true
Create gn target for peerconnection examples BUG= Review-Url: https://codereview.webrtc.org/2218053002 Cr-Commit-Position: refs/heads/master@{#13673}
2016-08-08 09:03:23 -07:00
sources = [
"peerconnection/server/data_socket.cc",
"peerconnection/server/data_socket.h",
"peerconnection/server/main.cc",
"peerconnection/server/peer_channel.cc",
"peerconnection/server/peer_channel.h",
"peerconnection/server/utils.cc",
"peerconnection/server/utils.h",
]
deps = [
"//webrtc:webrtc_common",
Revert of Remove remains of webrtc/base (patchset #7 id:120001 of https://codereview.webrtc.org/2973183002/ ) Reason for revert: Breaks lots of downstream projects. Original issue's description: > Remove remains of webrtc/base > > All downstream code have been updated to the new location. > > In PRESUBMIT.py: > * Remove webrtc/rtc_base from CPP_BLACKLIST > * Add webrtc/rtc_base to LEGACY_API_DIRS > > Fix some duplicated paths in > webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn > > BUG=webrtc:7634 > TBR=kwiberg@webrtc.org > > Review-Url: https://codereview.webrtc.org/2973183002 > Cr-Commit-Position: refs/heads/master@{#18948} > Committed: https://chromium.googlesource.com/external/webrtc/+/9483b49bafc681a8360dff7217e7651a74dea71d TBR=kwiberg@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7634 Review-Url: https://codereview.webrtc.org/2976633002 Cr-Commit-Position: refs/heads/master@{#18949}
2017-07-10 05:58:42 -07:00
"//webrtc/base:rtc_base_approved",
Move webrtc/{tools => rtc_tools} Leaving compatibility script in webrtc/tools/compare_videos.py to avoid breaking our video quality tests in Chromium. Forwarding GN targets are left in webrtc/tools/BUILD.gn. BUG=webrtc:7855 NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2965593002 Cr-Commit-Position: refs/heads/master@{#18848}
2017-06-30 03:04:59 -07:00
"//webrtc/rtc_tools:command_line_parser",
Create gn target for peerconnection examples BUG= Review-Url: https://codereview.webrtc.org/2218053002 Cr-Commit-Position: refs/heads/master@{#13673}
2016-08-08 09:03:23 -07:00
]
GN: Exclude suppressions of Chromium Clang warnings for Chromium builds. These suppressions are causing GN errors when Chromium targets are depending directly on WebRTC targets (needed for https://codereview.chromium.org/2413103004) BUG=webrtc:4256 NOTRY=True Review-Url: https://codereview.webrtc.org/2408133008 Cr-Commit-Position: refs/heads/master@{#14644}
2016-10-16 23:56:12 -07:00
if (!build_with_chromium && is_clang) {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
GN: Introduce templates. Defines the rtc_executable, rtc_source_set, rtc_test and rtc_static_library templates. These templates provide no functionality yet, but will enable common configuration to be introduced, avoiding repetition in every target Changes summary: - Prepend rtc_ to test, source_set, executable and static_library targets - Change "configs -= [" to "suppressed_configs += [" - Include webrtc/build/webrtc.gni where it wasn't included yet - Delete import("//testing/test.gni"), since rtc_test makes it unnecessary. BUG=webrtc:6187 TBR=henrik.lundin@webrtc.org,tommi@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2301053002 Cr-Commit-Position: refs/heads/master@{#14043}
2016-09-02 04:10:34 -07:00
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
Create gn target for peerconnection examples BUG= Review-Url: https://codereview.webrtc.org/2218053002 Cr-Commit-Position: refs/heads/master@{#13673}
2016-08-08 09:03:23 -07:00
}
}
GN: Introduce templates. Defines the rtc_executable, rtc_source_set, rtc_test and rtc_static_library templates. These templates provide no functionality yet, but will enable common configuration to be introduced, avoiding repetition in every target Changes summary: - Prepend rtc_ to test, source_set, executable and static_library targets - Change "configs -= [" to "suppressed_configs += [" - Include webrtc/build/webrtc.gni where it wasn't included yet - Delete import("//testing/test.gni"), since rtc_test makes it unnecessary. BUG=webrtc:6187 TBR=henrik.lundin@webrtc.org,tommi@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2301053002 Cr-Commit-Position: refs/heads/master@{#14043}
2016-09-02 04:10:34 -07:00
rtc_executable("relayserver") {
Reland "Enable GN check for webrtc/examples" This is a reland of https://codereview.webrtc.org/2714343002 with the errors related to inclusions of test targets in webrtc/api resolved. BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2733673002 Cr-Commit-Position: refs/heads/master@{#17053}
2017-03-06 00:29:21 -08:00
testonly = true
Create gn target for peerconnection examples BUG= Review-Url: https://codereview.webrtc.org/2218053002 Cr-Commit-Position: refs/heads/master@{#13673}
2016-08-08 09:03:23 -07:00
sources = [
"relayserver/relayserver_main.cc",
]
deps = [
Revert of Remove remains of webrtc/base (patchset #7 id:120001 of https://codereview.webrtc.org/2973183002/ ) Reason for revert: Breaks lots of downstream projects. Original issue's description: > Remove remains of webrtc/base > > All downstream code have been updated to the new location. > > In PRESUBMIT.py: > * Remove webrtc/rtc_base from CPP_BLACKLIST > * Add webrtc/rtc_base to LEGACY_API_DIRS > > Fix some duplicated paths in > webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn > > BUG=webrtc:7634 > TBR=kwiberg@webrtc.org > > Review-Url: https://codereview.webrtc.org/2973183002 > Cr-Commit-Position: refs/heads/master@{#18948} > Committed: https://chromium.googlesource.com/external/webrtc/+/9483b49bafc681a8360dff7217e7651a74dea71d TBR=kwiberg@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7634 Review-Url: https://codereview.webrtc.org/2976633002 Cr-Commit-Position: refs/heads/master@{#18949}
2017-07-10 05:58:42 -07:00
"../base:rtc_base",
"//webrtc/base:rtc_base_approved",
Reland "Enable GN check for webrtc/examples" This is a reland of https://codereview.webrtc.org/2714343002 with the errors related to inclusions of test targets in webrtc/api resolved. BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2733673002 Cr-Commit-Position: refs/heads/master@{#17053}
2017-03-06 00:29:21 -08:00
"//webrtc/p2p:rtc_p2p",
Create gn target for peerconnection examples BUG= Review-Url: https://codereview.webrtc.org/2218053002 Cr-Commit-Position: refs/heads/master@{#13673}
2016-08-08 09:03:23 -07:00
"//webrtc/pc:rtc_pc",
"//webrtc/system_wrappers:field_trial_default",
"//webrtc/system_wrappers:metrics_default",
]
GN: Exclude suppressions of Chromium Clang warnings for Chromium builds. These suppressions are causing GN errors when Chromium targets are depending directly on WebRTC targets (needed for https://codereview.chromium.org/2413103004) BUG=webrtc:4256 NOTRY=True Review-Url: https://codereview.webrtc.org/2408133008 Cr-Commit-Position: refs/heads/master@{#14644}
2016-10-16 23:56:12 -07:00
if (!build_with_chromium && is_clang) {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
GN: Introduce templates. Defines the rtc_executable, rtc_source_set, rtc_test and rtc_static_library templates. These templates provide no functionality yet, but will enable common configuration to be introduced, avoiding repetition in every target Changes summary: - Prepend rtc_ to test, source_set, executable and static_library targets - Change "configs -= [" to "suppressed_configs += [" - Include webrtc/build/webrtc.gni where it wasn't included yet - Delete import("//testing/test.gni"), since rtc_test makes it unnecessary. BUG=webrtc:6187 TBR=henrik.lundin@webrtc.org,tommi@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2301053002 Cr-Commit-Position: refs/heads/master@{#14043}
2016-09-02 04:10:34 -07:00
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
Create gn target for peerconnection examples BUG= Review-Url: https://codereview.webrtc.org/2218053002 Cr-Commit-Position: refs/heads/master@{#13673}
2016-08-08 09:03:23 -07:00
}
}
GN: Introduce templates. Defines the rtc_executable, rtc_source_set, rtc_test and rtc_static_library templates. These templates provide no functionality yet, but will enable common configuration to be introduced, avoiding repetition in every target Changes summary: - Prepend rtc_ to test, source_set, executable and static_library targets - Change "configs -= [" to "suppressed_configs += [" - Include webrtc/build/webrtc.gni where it wasn't included yet - Delete import("//testing/test.gni"), since rtc_test makes it unnecessary. BUG=webrtc:6187 TBR=henrik.lundin@webrtc.org,tommi@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2301053002 Cr-Commit-Position: refs/heads/master@{#14043}
2016-09-02 04:10:34 -07:00
rtc_executable("turnserver") {
Reland "Enable GN check for webrtc/examples" This is a reland of https://codereview.webrtc.org/2714343002 with the errors related to inclusions of test targets in webrtc/api resolved. BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2733673002 Cr-Commit-Position: refs/heads/master@{#17053}
2017-03-06 00:29:21 -08:00
testonly = true
Create gn target for peerconnection examples BUG= Review-Url: https://codereview.webrtc.org/2218053002 Cr-Commit-Position: refs/heads/master@{#13673}
2016-08-08 09:03:23 -07:00
sources = [
"turnserver/turnserver_main.cc",
]
deps = [
Revert of Remove remains of webrtc/base (patchset #7 id:120001 of https://codereview.webrtc.org/2973183002/ ) Reason for revert: Breaks lots of downstream projects. Original issue's description: > Remove remains of webrtc/base > > All downstream code have been updated to the new location. > > In PRESUBMIT.py: > * Remove webrtc/rtc_base from CPP_BLACKLIST > * Add webrtc/rtc_base to LEGACY_API_DIRS > > Fix some duplicated paths in > webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn > > BUG=webrtc:7634 > TBR=kwiberg@webrtc.org > > Review-Url: https://codereview.webrtc.org/2973183002 > Cr-Commit-Position: refs/heads/master@{#18948} > Committed: https://chromium.googlesource.com/external/webrtc/+/9483b49bafc681a8360dff7217e7651a74dea71d TBR=kwiberg@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7634 Review-Url: https://codereview.webrtc.org/2976633002 Cr-Commit-Position: refs/heads/master@{#18949}
2017-07-10 05:58:42 -07:00
"../base:rtc_base",
"//webrtc/base:rtc_base_approved",
Reland "Enable GN check for webrtc/examples" This is a reland of https://codereview.webrtc.org/2714343002 with the errors related to inclusions of test targets in webrtc/api resolved. BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2733673002 Cr-Commit-Position: refs/heads/master@{#17053}
2017-03-06 00:29:21 -08:00
"//webrtc/p2p:rtc_p2p",
Create gn target for peerconnection examples BUG= Review-Url: https://codereview.webrtc.org/2218053002 Cr-Commit-Position: refs/heads/master@{#13673}
2016-08-08 09:03:23 -07:00
"//webrtc/pc:rtc_pc",
"//webrtc/system_wrappers:field_trial_default",
"//webrtc/system_wrappers:metrics_default",
]
GN: Exclude suppressions of Chromium Clang warnings for Chromium builds. These suppressions are causing GN errors when Chromium targets are depending directly on WebRTC targets (needed for https://codereview.chromium.org/2413103004) BUG=webrtc:4256 NOTRY=True Review-Url: https://codereview.webrtc.org/2408133008 Cr-Commit-Position: refs/heads/master@{#14644}
2016-10-16 23:56:12 -07:00
if (!build_with_chromium && is_clang) {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
GN: Introduce templates. Defines the rtc_executable, rtc_source_set, rtc_test and rtc_static_library templates. These templates provide no functionality yet, but will enable common configuration to be introduced, avoiding repetition in every target Changes summary: - Prepend rtc_ to test, source_set, executable and static_library targets - Change "configs -= [" to "suppressed_configs += [" - Include webrtc/build/webrtc.gni where it wasn't included yet - Delete import("//testing/test.gni"), since rtc_test makes it unnecessary. BUG=webrtc:6187 TBR=henrik.lundin@webrtc.org,tommi@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2301053002 Cr-Commit-Position: refs/heads/master@{#14043}
2016-09-02 04:10:34 -07:00
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
Create gn target for peerconnection examples BUG= Review-Url: https://codereview.webrtc.org/2218053002 Cr-Commit-Position: refs/heads/master@{#13673}
2016-08-08 09:03:23 -07:00
}
}
GN: Introduce templates. Defines the rtc_executable, rtc_source_set, rtc_test and rtc_static_library templates. These templates provide no functionality yet, but will enable common configuration to be introduced, avoiding repetition in every target Changes summary: - Prepend rtc_ to test, source_set, executable and static_library targets - Change "configs -= [" to "suppressed_configs += [" - Include webrtc/build/webrtc.gni where it wasn't included yet - Delete import("//testing/test.gni"), since rtc_test makes it unnecessary. BUG=webrtc:6187 TBR=henrik.lundin@webrtc.org,tommi@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2301053002 Cr-Commit-Position: refs/heads/master@{#14043}
2016-09-02 04:10:34 -07:00
rtc_executable("stunserver") {
Reland "Enable GN check for webrtc/examples" This is a reland of https://codereview.webrtc.org/2714343002 with the errors related to inclusions of test targets in webrtc/api resolved. BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2733673002 Cr-Commit-Position: refs/heads/master@{#17053}
2017-03-06 00:29:21 -08:00
testonly = true
Create gn target for peerconnection examples BUG= Review-Url: https://codereview.webrtc.org/2218053002 Cr-Commit-Position: refs/heads/master@{#13673}
2016-08-08 09:03:23 -07:00
sources = [
"stunserver/stunserver_main.cc",
]
deps = [
Revert of Remove remains of webrtc/base (patchset #7 id:120001 of https://codereview.webrtc.org/2973183002/ ) Reason for revert: Breaks lots of downstream projects. Original issue's description: > Remove remains of webrtc/base > > All downstream code have been updated to the new location. > > In PRESUBMIT.py: > * Remove webrtc/rtc_base from CPP_BLACKLIST > * Add webrtc/rtc_base to LEGACY_API_DIRS > > Fix some duplicated paths in > webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn > > BUG=webrtc:7634 > TBR=kwiberg@webrtc.org > > Review-Url: https://codereview.webrtc.org/2973183002 > Cr-Commit-Position: refs/heads/master@{#18948} > Committed: https://chromium.googlesource.com/external/webrtc/+/9483b49bafc681a8360dff7217e7651a74dea71d TBR=kwiberg@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7634 Review-Url: https://codereview.webrtc.org/2976633002 Cr-Commit-Position: refs/heads/master@{#18949}
2017-07-10 05:58:42 -07:00
"../base:rtc_base",
"//webrtc/base:rtc_base_approved",
Reland "Enable GN check for webrtc/examples" This is a reland of https://codereview.webrtc.org/2714343002 with the errors related to inclusions of test targets in webrtc/api resolved. BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2733673002 Cr-Commit-Position: refs/heads/master@{#17053}
2017-03-06 00:29:21 -08:00
"//webrtc/p2p:rtc_p2p",
Create gn target for peerconnection examples BUG= Review-Url: https://codereview.webrtc.org/2218053002 Cr-Commit-Position: refs/heads/master@{#13673}
2016-08-08 09:03:23 -07:00
"//webrtc/pc:rtc_pc",
"//webrtc/system_wrappers:field_trial_default",
"//webrtc/system_wrappers:metrics_default",
]
GN: Exclude suppressions of Chromium Clang warnings for Chromium builds. These suppressions are causing GN errors when Chromium targets are depending directly on WebRTC targets (needed for https://codereview.chromium.org/2413103004) BUG=webrtc:4256 NOTRY=True Review-Url: https://codereview.webrtc.org/2408133008 Cr-Commit-Position: refs/heads/master@{#14644}
2016-10-16 23:56:12 -07:00
if (!build_with_chromium && is_clang) {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
GN: Introduce templates. Defines the rtc_executable, rtc_source_set, rtc_test and rtc_static_library templates. These templates provide no functionality yet, but will enable common configuration to be introduced, avoiding repetition in every target Changes summary: - Prepend rtc_ to test, source_set, executable and static_library targets - Change "configs -= [" to "suppressed_configs += [" - Include webrtc/build/webrtc.gni where it wasn't included yet - Delete import("//testing/test.gni"), since rtc_test makes it unnecessary. BUG=webrtc:6187 TBR=henrik.lundin@webrtc.org,tommi@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2301053002 Cr-Commit-Position: refs/heads/master@{#14043}
2016-09-02 04:10:34 -07:00
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
Create gn target for peerconnection examples BUG= Review-Url: https://codereview.webrtc.org/2218053002 Cr-Commit-Position: refs/heads/master@{#13673}
2016-08-08 09:03:23 -07:00
}
}
}
Moving stun_prober target from webrtc/p2p to webrtc/examples BUG=webrtc:6440 NOTRY=True Review-Url: https://codereview.webrtc.org/2460343002 Cr-Commit-Position: refs/heads/master@{#14869}
2016-11-01 03:09:15 -07:00
An example of Unity native plugin of webrtc for Windows OS Unity native plugin has to use Pinvoke technology in its APIs This plugin dll can also be used by Windows C# applications other than Unity. BUG=webrtc:7389 Review-Url: https://codereview.webrtc.org/2823783002 Cr-Commit-Position: refs/heads/master@{#18108}
2017-05-11 16:10:03 -07:00
if (is_win) {
rtc_shared_library("webrtc_unity_plugin") {
testonly = true
sources = [
"unityplugin/simple_peer_connection.cc",
"unityplugin/simple_peer_connection.h",
"unityplugin/unity_plugin_apis.cc",
"unityplugin/unity_plugin_apis.h",
]
if (!build_with_chromium && is_clang) {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
}
cflags = [ "/wd4245" ]
configs += [
"//build/config/win:windowed",
":peerconnection_client_warnings_config",
]
deps = [
"//webrtc/api:libjingle_peerconnection_test_api",
"//webrtc/api:video_frame_api",
Revert of Remove remains of webrtc/base (patchset #7 id:120001 of https://codereview.webrtc.org/2973183002/ ) Reason for revert: Breaks lots of downstream projects. Original issue's description: > Remove remains of webrtc/base > > All downstream code have been updated to the new location. > > In PRESUBMIT.py: > * Remove webrtc/rtc_base from CPP_BLACKLIST > * Add webrtc/rtc_base to LEGACY_API_DIRS > > Fix some duplicated paths in > webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn > > BUG=webrtc:7634 > TBR=kwiberg@webrtc.org > > Review-Url: https://codereview.webrtc.org/2973183002 > Cr-Commit-Position: refs/heads/master@{#18948} > Committed: https://chromium.googlesource.com/external/webrtc/+/9483b49bafc681a8360dff7217e7651a74dea71d TBR=kwiberg@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7634 Review-Url: https://codereview.webrtc.org/2976633002 Cr-Commit-Position: refs/heads/master@{#18949}
2017-07-10 05:58:42 -07:00
"//webrtc/base:rtc_base",
"//webrtc/base:rtc_base_approved",
"//webrtc/base:rtc_json",
An example of Unity native plugin of webrtc for Windows OS Unity native plugin has to use Pinvoke technology in its APIs This plugin dll can also be used by Windows C# applications other than Unity. BUG=webrtc:7389 Review-Url: https://codereview.webrtc.org/2823783002 Cr-Commit-Position: refs/heads/master@{#18108}
2017-05-11 16:10:03 -07:00
"//webrtc/media:rtc_media",
"//webrtc/media:rtc_media_base",
"//webrtc/modules/video_capture:video_capture_module",
"//webrtc/pc:libjingle_peerconnection",
"//webrtc/system_wrappers:field_trial_default",
"//webrtc/system_wrappers:metrics_default",
]
}
}
Moving stun_prober target from webrtc/p2p to webrtc/examples BUG=webrtc:6440 NOTRY=True Review-Url: https://codereview.webrtc.org/2460343002 Cr-Commit-Position: refs/heads/master@{#14869}
2016-11-01 03:09:15 -07:00
if (!build_with_chromium) {
# Doesn't build within Chrome on Win.
rtc_executable("stun_prober") {
Reland "Enable GN check for webrtc/examples" This is a reland of https://codereview.webrtc.org/2714343002 with the errors related to inclusions of test targets in webrtc/api resolved. BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2733673002 Cr-Commit-Position: refs/heads/master@{#17053}
2017-03-06 00:29:21 -08:00
testonly = true
Moving stun_prober target from webrtc/p2p to webrtc/examples BUG=webrtc:6440 NOTRY=True Review-Url: https://codereview.webrtc.org/2460343002 Cr-Commit-Position: refs/heads/master@{#14869}
2016-11-01 03:09:15 -07:00
sources = [
"stunprober/main.cc",
]
if (!build_with_chromium && is_clang) {
# Suppress warnings from Chrome's Clang plugins.
# See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
}
deps = [
Revert of Remove remains of webrtc/base (patchset #7 id:120001 of https://codereview.webrtc.org/2973183002/ ) Reason for revert: Breaks lots of downstream projects. Original issue's description: > Remove remains of webrtc/base > > All downstream code have been updated to the new location. > > In PRESUBMIT.py: > * Remove webrtc/rtc_base from CPP_BLACKLIST > * Add webrtc/rtc_base to LEGACY_API_DIRS > > Fix some duplicated paths in > webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn > > BUG=webrtc:7634 > TBR=kwiberg@webrtc.org > > Review-Url: https://codereview.webrtc.org/2973183002 > Cr-Commit-Position: refs/heads/master@{#18948} > Committed: https://chromium.googlesource.com/external/webrtc/+/9483b49bafc681a8360dff7217e7651a74dea71d TBR=kwiberg@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7634 Review-Url: https://codereview.webrtc.org/2976633002 Cr-Commit-Position: refs/heads/master@{#18949}
2017-07-10 05:58:42 -07:00
"../base:rtc_base",
"../base:rtc_base_approved",
Moving stun_prober target from webrtc/p2p to webrtc/examples BUG=webrtc:6440 NOTRY=True Review-Url: https://codereview.webrtc.org/2460343002 Cr-Commit-Position: refs/heads/master@{#14869}
2016-11-01 03:09:15 -07:00
"../p2p:libstunprober",
"../p2p:rtc_p2p",
"../system_wrappers:field_trial_default",
]
}
}
Reference in New Issue Copy Permalink