admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
webrtc_m130/webrtc/modules/BUILD.gn

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

261 lines
10 KiB
Plaintext
Raw Normal View History

GN: Add modules_unittests Changes: * Enabled protobuf for iOS globally. * Set WEBRTC_INCLUDE_INTERNAL_AUDIO_DEVICE on a global scope similar to GYP since tests depend on it. * Added missing rtc_libvpx_build_vp9 variable. * Moved out audio_coding defines into .gni file to avoid code duplication * Renamed files to avoid object naming conflicts that GN disallows: * webrtc/modules/audio_processing/{echo_cancellation_unittest.cc->echo_cancellation_bit_exact_unittest.cc} * webrtc/modules/video_coding/codecs/vp9/{screenshare_layers_unittest.cc->vp9_screenshare_layers_unittest.cc} BUG=webrtc:5949 TESTED=Built and ran the tests on Mac. Also ran: gn gen out/Default --args="rtc_enable_bwe_test_logging=true" and verified that more objects are being built (1885 vs 1883) when compiling modules_unittests. NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2041233006 Cr-Commit-Position: refs/heads/master@{#13108}
2016-06-13 00:19:48 -07:00
# Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
#
# Use of this source code is governed by a BSD-style license
# that can be found in the LICENSE file in the root of the source
# tree. An additional intellectual property rights grant can be found
# in the file PATENTS. All contributing project authors may
# be found in the AUTHORS file in the root of the source tree.
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
import("../webrtc.gni")
GN: Add modules_unittests Changes: * Enabled protobuf for iOS globally. * Set WEBRTC_INCLUDE_INTERNAL_AUDIO_DEVICE on a global scope similar to GYP since tests depend on it. * Added missing rtc_libvpx_build_vp9 variable. * Moved out audio_coding defines into .gni file to avoid code duplication * Renamed files to avoid object naming conflicts that GN disallows: * webrtc/modules/audio_processing/{echo_cancellation_unittest.cc->echo_cancellation_bit_exact_unittest.cc} * webrtc/modules/video_coding/codecs/vp9/{screenshare_layers_unittest.cc->vp9_screenshare_layers_unittest.cc} BUG=webrtc:5949 TESTED=Built and ran the tests on Mac. Also ran: gn gen out/Default --args="rtc_enable_bwe_test_logging=true" and verified that more objects are being built (1885 vs 1883) when compiling modules_unittests. NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2041233006 Cr-Commit-Position: refs/heads/master@{#13108}
2016-06-13 00:19:48 -07:00
import("audio_coding/audio_coding.gni")
group("modules") {
GN: Change group deps to public_deps. During GN vs GYP auditing it was discovered that some GN targets that had public_configs were not exposing them to dependents where the dependent depended on a group, which in turn included that target as a dependency. Instead of changing those public_configs to all_dependent_configs (which would be a change from GYP), it's better to just change those group targets to use public_deps instead. BUG=webrtc:6323 NOTRY=True TESTED=Generated GYP and GN project files on Mac and ran the tools/gyp_flag_compare.py script before and after this patch was applied. The file in question used for inspection was the webrtc/api/webrtcsessiondescriptionfactory.cc which is a part of the libjingle_peerconnection target. Review-Url: https://codereview.webrtc.org/2344623002 Cr-Commit-Position: refs/heads/master@{#14222}
2016-09-15 00:53:26 -07:00
public_deps = [
GN: Add modules_unittests Changes: * Enabled protobuf for iOS globally. * Set WEBRTC_INCLUDE_INTERNAL_AUDIO_DEVICE on a global scope similar to GYP since tests depend on it. * Added missing rtc_libvpx_build_vp9 variable. * Moved out audio_coding defines into .gni file to avoid code duplication * Renamed files to avoid object naming conflicts that GN disallows: * webrtc/modules/audio_processing/{echo_cancellation_unittest.cc->echo_cancellation_bit_exact_unittest.cc} * webrtc/modules/video_coding/codecs/vp9/{screenshare_layers_unittest.cc->vp9_screenshare_layers_unittest.cc} BUG=webrtc:5949 TESTED=Built and ran the tests on Mac. Also ran: gn gen out/Default --args="rtc_enable_bwe_test_logging=true" and verified that more objects are being built (1885 vs 1883) when compiling modules_unittests. NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2041233006 Cr-Commit-Position: refs/heads/master@{#13108}
2016-06-13 00:19:48 -07:00
"audio_coding",
"audio_conference_mixer",
"audio_device",
GN: New conventions, default target and refactorings Introduce a convention on categorizing GN targets: 1. Production code 2. Tests 3. Examples 4. Tools The first two have targets spread out all over the tree, while the latter are isolated to examples/ and tools/ directories. Another new convention: Each directory's BUILD.gn file shall contain a target named similar to the directory name. This target shall contain the 'most common' production code, i.e. so that most consumers of the directory can depend on only the directory (which implicitly means that target in GN). //webrtc:webrtc_tests is changed to depend on all WebRTC tests. From now on, it's necessary to add new test targets to this dependency tree in order to get them compiled. Two new group targets are created: //webrtc/modules/audio_coding:audio_coding_tests //webrtc/modules/audio_processing:audio_processing_tests to reduce the long list of tests in //webrtc:webrtc_tests. Visibility on //webrtc:webrtc and //webrtc:webrtc_tests is restricted to the root target, to avoid circular dependencies due to the monolithic property of these targets (a problem we've had in the past). The 'root' target at the top level is renamed to 'default', which means GN will build this target instead of _all_ generated targets (see https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/faq.md#Can-I-control-what-targets-are-built-by-default). This target now depends on everything we want to build, meaning all targets now explicitly needs to be wired up from the root target in order to get build. Having this, the number of compiled objects on Android is decreased from 8855 to 6276. It also gives us better control over our build. BUG=webrtc:6440 TESTED=git cl try --clobber NOTRY=True Review-Url: https://codereview.webrtc.org/2441383002 Cr-Commit-Position: refs/heads/master@{#14821}
2016-10-28 05:44:03 -07:00
"audio_mixer",
GN: Add modules_unittests Changes: * Enabled protobuf for iOS globally. * Set WEBRTC_INCLUDE_INTERNAL_AUDIO_DEVICE on a global scope similar to GYP since tests depend on it. * Added missing rtc_libvpx_build_vp9 variable. * Moved out audio_coding defines into .gni file to avoid code duplication * Renamed files to avoid object naming conflicts that GN disallows: * webrtc/modules/audio_processing/{echo_cancellation_unittest.cc->echo_cancellation_bit_exact_unittest.cc} * webrtc/modules/video_coding/codecs/vp9/{screenshare_layers_unittest.cc->vp9_screenshare_layers_unittest.cc} BUG=webrtc:5949 TESTED=Built and ran the tests on Mac. Also ran: gn gen out/Default --args="rtc_enable_bwe_test_logging=true" and verified that more objects are being built (1885 vs 1883) when compiling modules_unittests. NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2041233006 Cr-Commit-Position: refs/heads/master@{#13108}
2016-06-13 00:19:48 -07:00
"audio_processing",
"bitrate_controller",
GN: New conventions, default target and refactorings Introduce a convention on categorizing GN targets: 1. Production code 2. Tests 3. Examples 4. Tools The first two have targets spread out all over the tree, while the latter are isolated to examples/ and tools/ directories. Another new convention: Each directory's BUILD.gn file shall contain a target named similar to the directory name. This target shall contain the 'most common' production code, i.e. so that most consumers of the directory can depend on only the directory (which implicitly means that target in GN). //webrtc:webrtc_tests is changed to depend on all WebRTC tests. From now on, it's necessary to add new test targets to this dependency tree in order to get them compiled. Two new group targets are created: //webrtc/modules/audio_coding:audio_coding_tests //webrtc/modules/audio_processing:audio_processing_tests to reduce the long list of tests in //webrtc:webrtc_tests. Visibility on //webrtc:webrtc and //webrtc:webrtc_tests is restricted to the root target, to avoid circular dependencies due to the monolithic property of these targets (a problem we've had in the past). The 'root' target at the top level is renamed to 'default', which means GN will build this target instead of _all_ generated targets (see https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/faq.md#Can-I-control-what-targets-are-built-by-default). This target now depends on everything we want to build, meaning all targets now explicitly needs to be wired up from the root target in order to get build. Having this, the number of compiled objects on Android is decreased from 8855 to 6276. It also gives us better control over our build. BUG=webrtc:6440 TESTED=git cl try --clobber NOTRY=True Review-Url: https://codereview.webrtc.org/2441383002 Cr-Commit-Position: refs/heads/master@{#14821}
2016-10-28 05:44:03 -07:00
"congestion_controller",
GN: Add modules_unittests Changes: * Enabled protobuf for iOS globally. * Set WEBRTC_INCLUDE_INTERNAL_AUDIO_DEVICE on a global scope similar to GYP since tests depend on it. * Added missing rtc_libvpx_build_vp9 variable. * Moved out audio_coding defines into .gni file to avoid code duplication * Renamed files to avoid object naming conflicts that GN disallows: * webrtc/modules/audio_processing/{echo_cancellation_unittest.cc->echo_cancellation_bit_exact_unittest.cc} * webrtc/modules/video_coding/codecs/vp9/{screenshare_layers_unittest.cc->vp9_screenshare_layers_unittest.cc} BUG=webrtc:5949 TESTED=Built and ran the tests on Mac. Also ran: gn gen out/Default --args="rtc_enable_bwe_test_logging=true" and verified that more objects are being built (1885 vs 1883) when compiling modules_unittests. NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2041233006 Cr-Commit-Position: refs/heads/master@{#13108}
2016-06-13 00:19:48 -07:00
"desktop_capture",
"media_file",
GN: New conventions, default target and refactorings Introduce a convention on categorizing GN targets: 1. Production code 2. Tests 3. Examples 4. Tools The first two have targets spread out all over the tree, while the latter are isolated to examples/ and tools/ directories. Another new convention: Each directory's BUILD.gn file shall contain a target named similar to the directory name. This target shall contain the 'most common' production code, i.e. so that most consumers of the directory can depend on only the directory (which implicitly means that target in GN). //webrtc:webrtc_tests is changed to depend on all WebRTC tests. From now on, it's necessary to add new test targets to this dependency tree in order to get them compiled. Two new group targets are created: //webrtc/modules/audio_coding:audio_coding_tests //webrtc/modules/audio_processing:audio_processing_tests to reduce the long list of tests in //webrtc:webrtc_tests. Visibility on //webrtc:webrtc and //webrtc:webrtc_tests is restricted to the root target, to avoid circular dependencies due to the monolithic property of these targets (a problem we've had in the past). The 'root' target at the top level is renamed to 'default', which means GN will build this target instead of _all_ generated targets (see https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/faq.md#Can-I-control-what-targets-are-built-by-default). This target now depends on everything we want to build, meaning all targets now explicitly needs to be wired up from the root target in order to get build. Having this, the number of compiled objects on Android is decreased from 8855 to 6276. It also gives us better control over our build. BUG=webrtc:6440 TESTED=git cl try --clobber NOTRY=True Review-Url: https://codereview.webrtc.org/2441383002 Cr-Commit-Position: refs/heads/master@{#14821}
2016-10-28 05:44:03 -07:00
"pacing",
"remote_bitrate_estimator",
GN: Add modules_unittests Changes: * Enabled protobuf for iOS globally. * Set WEBRTC_INCLUDE_INTERNAL_AUDIO_DEVICE on a global scope similar to GYP since tests depend on it. * Added missing rtc_libvpx_build_vp9 variable. * Moved out audio_coding defines into .gni file to avoid code duplication * Renamed files to avoid object naming conflicts that GN disallows: * webrtc/modules/audio_processing/{echo_cancellation_unittest.cc->echo_cancellation_bit_exact_unittest.cc} * webrtc/modules/video_coding/codecs/vp9/{screenshare_layers_unittest.cc->vp9_screenshare_layers_unittest.cc} BUG=webrtc:5949 TESTED=Built and ran the tests on Mac. Also ran: gn gen out/Default --args="rtc_enable_bwe_test_logging=true" and verified that more objects are being built (1885 vs 1883) when compiling modules_unittests. NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2041233006 Cr-Commit-Position: refs/heads/master@{#13108}
2016-06-13 00:19:48 -07:00
"rtp_rtcp",
"utility",
"video_coding",
"video_processing",
]
}
Reland of Creating webrtc/modules:module_api (patchset #1 id:1 of https://codereview.webrtc.org/2839963005/ ) Reason for revert: Fixing the Gn error and try to reland. Original issue's description: > Revert of Creating webrtc/modules:module_api (patchset #5 id:80001 of https://codereview.webrtc.org/2838873002/ ) > > Reason for revert: > Causes build problem: https://build.chromium.org/p/client.webrtc/builders/iOS64%20Sim%20Debug%20%28iOS%209.0%29/builds/1630/steps/generate%20build%20files%20%28mb%29/logs/stdio > > Original issue's description: > > Creating webrtc/modules:module_api > > > > This target keeps track of .h the files under webrtc/modules/include/ > > that are not part of any target. > > If a .h file is not part of a target the 'gn check' utility is not > > able to spot if a target is missing a dependency because even if > > it parses '#include' directives it is not able to find a target that > > contains these headers. > > > > BUG=webrtc:7513 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/2838873002 > > Cr-Commit-Position: refs/heads/master@{#17880} > > Committed: https://chromium.googlesource.com/external/webrtc/+/5a1a092ed09ca92719eeb293275f64c0cdcc0e51 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7513 > > Review-Url: https://codereview.webrtc.org/2839963005 > Cr-Commit-Position: refs/heads/master@{#17881} > Committed: https://chromium.googlesource.com/external/webrtc/+/bb08c3e29656fafe8a2d5d16ec4a62db49689f8a TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true TBR=kjellander@webrtc.org BUG=webrtc:7513 Review-Url: https://codereview.webrtc.org/2843913002 Cr-Commit-Position: refs/heads/master@{#17884}
2017-04-26 03:38:35 -07:00
rtc_source_set("module_api") {
sources = [
"include/module.h",
"include/module_common_types.h",
]
deps = [
"..:webrtc_common",
"../api:video_frame_api",
Revert of Remove remains of webrtc/base (patchset #7 id:120001 of https://codereview.webrtc.org/2973183002/ ) Reason for revert: Breaks lots of downstream projects. Original issue's description: > Remove remains of webrtc/base > > All downstream code have been updated to the new location. > > In PRESUBMIT.py: > * Remove webrtc/rtc_base from CPP_BLACKLIST > * Add webrtc/rtc_base to LEGACY_API_DIRS > > Fix some duplicated paths in > webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn > > BUG=webrtc:7634 > TBR=kwiberg@webrtc.org > > Review-Url: https://codereview.webrtc.org/2973183002 > Cr-Commit-Position: refs/heads/master@{#18948} > Committed: https://chromium.googlesource.com/external/webrtc/+/9483b49bafc681a8360dff7217e7651a74dea71d TBR=kwiberg@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7634 Review-Url: https://codereview.webrtc.org/2976633002 Cr-Commit-Position: refs/heads/master@{#18949}
2017-07-10 05:58:42 -07:00
"../base:rtc_base_approved",
Reland of Creating webrtc/modules:module_api (patchset #1 id:1 of https://codereview.webrtc.org/2839963005/ ) Reason for revert: Fixing the Gn error and try to reland. Original issue's description: > Revert of Creating webrtc/modules:module_api (patchset #5 id:80001 of https://codereview.webrtc.org/2838873002/ ) > > Reason for revert: > Causes build problem: https://build.chromium.org/p/client.webrtc/builders/iOS64%20Sim%20Debug%20%28iOS%209.0%29/builds/1630/steps/generate%20build%20files%20%28mb%29/logs/stdio > > Original issue's description: > > Creating webrtc/modules:module_api > > > > This target keeps track of .h the files under webrtc/modules/include/ > > that are not part of any target. > > If a .h file is not part of a target the 'gn check' utility is not > > able to spot if a target is missing a dependency because even if > > it parses '#include' directives it is not able to find a target that > > contains these headers. > > > > BUG=webrtc:7513 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/2838873002 > > Cr-Commit-Position: refs/heads/master@{#17880} > > Committed: https://chromium.googlesource.com/external/webrtc/+/5a1a092ed09ca92719eeb293275f64c0cdcc0e51 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7513 > > Review-Url: https://codereview.webrtc.org/2839963005 > Cr-Commit-Position: refs/heads/master@{#17881} > Committed: https://chromium.googlesource.com/external/webrtc/+/bb08c3e29656fafe8a2d5d16ec4a62db49689f8a TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true TBR=kjellander@webrtc.org BUG=webrtc:7513 Review-Url: https://codereview.webrtc.org/2843913002 Cr-Commit-Position: refs/heads/master@{#17884}
2017-04-26 03:38:35 -07:00
]
}
GN: Add modules_unittests Changes: * Enabled protobuf for iOS globally. * Set WEBRTC_INCLUDE_INTERNAL_AUDIO_DEVICE on a global scope similar to GYP since tests depend on it. * Added missing rtc_libvpx_build_vp9 variable. * Moved out audio_coding defines into .gni file to avoid code duplication * Renamed files to avoid object naming conflicts that GN disallows: * webrtc/modules/audio_processing/{echo_cancellation_unittest.cc->echo_cancellation_bit_exact_unittest.cc} * webrtc/modules/video_coding/codecs/vp9/{screenshare_layers_unittest.cc->vp9_screenshare_layers_unittest.cc} BUG=webrtc:5949 TESTED=Built and ran the tests on Mac. Also ran: gn gen out/Default --args="rtc_enable_bwe_test_logging=true" and verified that more objects are being built (1885 vs 1883) when compiling modules_unittests. NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2041233006 Cr-Commit-Position: refs/heads/master@{#13108}
2016-06-13 00:19:48 -07:00
if (rtc_include_tests) {
GN: Declare resources for targets. Declare resources for GN targets so that they can be isolated NOTRY=True BUG=chromium:497757 Review-Url: https://codereview.webrtc.org/2340753002 Cr-Commit-Position: refs/heads/master@{#14210}
2016-09-14 05:10:01 -07:00
modules_tests_resources = [
"//resources/audio_coding/testfile32kHz.pcm",
"//resources/audio_coding/teststereo32kHz.pcm",
"//resources/foreman_cif.yuv",
"//resources/paris_qcif.yuv",
]
GN: Fix resource files for iOS test target In order to get resource files to be properly packaged into the .app for a unit test on iOS, the resource files needs to be listed as sources in a bundle_data target. BUG=webrtc:5949 NOTRY=True Review-Url: https://codereview.webrtc.org/2292853002 Cr-Commit-Position: refs/heads/master@{#13968}
2016-08-30 02:53:49 -07:00
if (is_ios) {
bundle_data("modules_tests_bundle_data") {
testonly = true
sources = modules_tests_resources
outputs = [
"{{bundle_resources_dir}}/{{source_file_part}}",
]
}
}
GN: Introduce templates. Defines the rtc_executable, rtc_source_set, rtc_test and rtc_static_library templates. These templates provide no functionality yet, but will enable common configuration to be introduced, avoiding repetition in every target Changes summary: - Prepend rtc_ to test, source_set, executable and static_library targets - Change "configs -= [" to "suppressed_configs += [" - Include webrtc/build/webrtc.gni where it wasn't included yet - Delete import("//testing/test.gni"), since rtc_test makes it unnecessary. BUG=webrtc:6187 TBR=henrik.lundin@webrtc.org,tommi@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2301053002 Cr-Commit-Position: refs/heads/master@{#14043}
2016-09-02 04:10:34 -07:00
rtc_test("modules_tests") {
GN: Add target for modules_tests. Additional changes I needed to make it work: - Modified a header in RTPFile.cc. Every other file is using "webrtc/engine_configurations.h" instead. - Disabled flag 4373 for msvs because it was disabled in build/common.gypi. BUG=webrtc:6038 TBR=kwiberg@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2187563005 Cr-Commit-Position: refs/heads/master@{#13628}
2016-08-03 10:46:47 -07:00
testonly = true
deps = [
Replace test_support_main by test_main and get rid of test_support_main_threaded_mac test_support_main_threaded_mac doesn't seem to be used. It looks like it was last used about a year and a half ago, and was removed in https://webrtc-codereview.appspot.com/55379004 BUG=webrtc:6424 R=kjellander@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2540693002 Cr-Commit-Position: refs/heads/master@{#15332}
2016-11-30 06:12:01 -08:00
"../test:test_main",
Move frame_generator_capture.{cc, h} and video_capturer.h to video_test_common. Remove video_capture as a dependency of test_common and add it as a dependency of modules_unittests, as it was before the refactor in https://codereview.webrtc.org/2629923002 BUG=webrtc:7037 NOTRY=True Review-Url: https://codereview.webrtc.org/2666113003 Cr-Commit-Position: refs/heads/master@{#16439}
2017-02-06 02:21:11 -08:00
"../test:video_test_common",
Reland of GN: Refactor modules_unittests to eliminate package boundary violations. (patchset #1 id:1 of https://codereview.webrtc.org/2651023005/ ) Reason for revert: Will change the name from bwe_simulator to bwe_simulator_test. Original issue's description: > Revert of GN: Refactor modules_unittests to eliminate package boundary violations. (patchset #4 id:130001 of https://codereview.webrtc.org/2649563002/ ) > > Reason for revert: > Did break the bots. > https://build.chromium.org/p/client.webrtc/builders/iOS32%20Release/builds/9807 > > Original issue's description: > > GN: Refactor modules_unittests to eliminate package boundary violations. > > > > Also move bwe_simulator to webrtc/modules/remote_bitrate_estimator > > > > BUG=webrtc:6954 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/2649563002 > > Cr-Commit-Position: refs/heads/master@{#16270} > > Committed: https://chromium.googlesource.com/external/webrtc/+/36cb55d7157dcba872f666e0e1fb75cae1a940a6 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6954 > > Review-Url: https://codereview.webrtc.org/2651023005 > Cr-Commit-Position: refs/heads/master@{#16271} > Committed: https://chromium.googlesource.com/external/webrtc/+/3373eaa57757386823730e9998cd225dd6be477c R=kjellander@webrtc.org NOTRY=true BUG=webrtc:6954 Review-Url: https://codereview.webrtc.org/2653173003 Cr-Commit-Position: refs/heads/master@{#16356}
2017-01-30 03:07:03 -08:00
"audio_coding:audio_coding_modules_tests",
"desktop_capture:desktop_capture_modules_tests",
"rtp_rtcp:rtp_rtcp_modules_tests",
"video_coding:video_coding_modules_tests",
Move ScreenCapturer 'real' tests out of screen_capturer_unittest.cc. This is a trivial change, I just cutted and pasted part of the code in screen_capturer_unittest.cc to screen_capturer_integration_test.cc, removed DISABLED_ prefixes, and updated build file. BUG=webrtc:6366 Review-Url: https://codereview.webrtc.org/2444583002 Cr-Commit-Position: refs/heads/master@{#14806}
2016-10-27 16:50:35 -07:00
"//testing/gmock",
GN: Add target for modules_tests. Additional changes I needed to make it work: - Modified a header in RTPFile.cc. Every other file is using "webrtc/engine_configurations.h" instead. - Disabled flag 4373 for msvs because it was disabled in build/common.gypi. BUG=webrtc:6038 TBR=kwiberg@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2187563005 Cr-Commit-Position: refs/heads/master@{#13628}
2016-08-03 10:46:47 -07:00
"//testing/gtest",
]
GN: Declare resources for targets. Declare resources for GN targets so that they can be isolated NOTRY=True BUG=chromium:497757 Review-Url: https://codereview.webrtc.org/2340753002 Cr-Commit-Position: refs/heads/master@{#14210}
2016-09-14 05:10:01 -07:00
data = modules_tests_resources
GN: Add target for modules_tests. Additional changes I needed to make it work: - Modified a header in RTPFile.cc. Every other file is using "webrtc/engine_configurations.h" instead. - Disabled flag 4373 for msvs because it was disabled in build/common.gypi. BUG=webrtc:6038 TBR=kwiberg@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2187563005 Cr-Commit-Position: refs/heads/master@{#13628}
2016-08-03 10:46:47 -07:00
if (is_android) {
deps += [ "//testing/android/native_test:native_test_native_code" ]
GN: Update tests to have the correct shard timeout value on Android. TBR=mflodman@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2231413002 Cr-Commit-Position: refs/heads/master@{#13741}
2016-08-15 02:29:11 -07:00
shard_timeout = 900
GN: Add target for modules_tests. Additional changes I needed to make it work: - Modified a header in RTPFile.cc. Every other file is using "webrtc/engine_configurations.h" instead. - Disabled flag 4373 for msvs because it was disabled in build/common.gypi. BUG=webrtc:6038 TBR=kwiberg@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2187563005 Cr-Commit-Position: refs/heads/master@{#13628}
2016-08-03 10:46:47 -07:00
}
GN: Fix resource files for iOS test target In order to get resource files to be properly packaged into the .app for a unit test on iOS, the resource files needs to be listed as sources in a bundle_data target. BUG=webrtc:5949 NOTRY=True Review-Url: https://codereview.webrtc.org/2292853002 Cr-Commit-Position: refs/heads/master@{#13968}
2016-08-30 02:53:49 -07:00
if (is_ios) {
deps += [ ":modules_tests_bundle_data" ]
GN: Add target for modules_tests. Additional changes I needed to make it work: - Modified a header in RTPFile.cc. Every other file is using "webrtc/engine_configurations.h" instead. - Disabled flag 4373 for msvs because it was disabled in build/common.gypi. BUG=webrtc:6038 TBR=kwiberg@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2187563005 Cr-Commit-Position: refs/heads/master@{#13628}
2016-08-03 10:46:47 -07:00
}
GN: Exclude suppressions of Chromium Clang warnings for Chromium builds. These suppressions are causing GN errors when Chromium targets are depending directly on WebRTC targets (needed for https://codereview.chromium.org/2413103004) BUG=webrtc:4256 NOTRY=True Review-Url: https://codereview.webrtc.org/2408133008 Cr-Commit-Position: refs/heads/master@{#14644}
2016-10-16 23:56:12 -07:00
if (!build_with_chromium && is_clang) {
GN: Add target for modules_tests. Additional changes I needed to make it work: - Modified a header in RTPFile.cc. Every other file is using "webrtc/engine_configurations.h" instead. - Disabled flag 4373 for msvs because it was disabled in build/common.gypi. BUG=webrtc:6038 TBR=kwiberg@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2187563005 Cr-Commit-Position: refs/heads/master@{#13628}
2016-08-03 10:46:47 -07:00
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
GN: Introduce templates. Defines the rtc_executable, rtc_source_set, rtc_test and rtc_static_library templates. These templates provide no functionality yet, but will enable common configuration to be introduced, avoiding repetition in every target Changes summary: - Prepend rtc_ to test, source_set, executable and static_library targets - Change "configs -= [" to "suppressed_configs += [" - Include webrtc/build/webrtc.gni where it wasn't included yet - Delete import("//testing/test.gni"), since rtc_test makes it unnecessary. BUG=webrtc:6187 TBR=henrik.lundin@webrtc.org,tommi@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2301053002 Cr-Commit-Position: refs/heads/master@{#14043}
2016-09-02 04:10:34 -07:00
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
GN: Add target for modules_tests. Additional changes I needed to make it work: - Modified a header in RTPFile.cc. Every other file is using "webrtc/engine_configurations.h" instead. - Disabled flag 4373 for msvs because it was disabled in build/common.gypi. BUG=webrtc:6038 TBR=kwiberg@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2187563005 Cr-Commit-Position: refs/heads/master@{#13628}
2016-08-03 10:46:47 -07:00
}
if (is_win) {
cflags = [
# TODO(phoglund): get rid of 4373 supression when
# http://code.google.com/p/webrtc/issues/detail?id=261 is solved.
# legacy warning for ignoring const / volatile in signatures.
"/wd4373",
]
}
}
GN: Declare resources for targets. Declare resources for GN targets so that they can be isolated NOTRY=True BUG=chromium:497757 Review-Url: https://codereview.webrtc.org/2340753002 Cr-Commit-Position: refs/heads/master@{#14210}
2016-09-14 05:10:01 -07:00
modules_unittests_resources = [
"//resources/att-downlink.rx",
"//resources/att-uplink.rx",
"//resources/audio_coding/neteq_opus.rtp",
"//resources/audio_coding/neteq_universal_new.rtp",
"//resources/audio_coding/speech_mono_16kHz.pcm",
"//resources/audio_coding/speech_mono_32_48kHz.pcm",
"//resources/audio_coding/testfile32kHz.pcm",
"//resources/audio_coding/teststereo32kHz.pcm",
"//resources/audio_device/audio_short16.pcm",
"//resources/audio_device/audio_short44.pcm",
"//resources/audio_device/audio_short48.pcm",
"//resources/audio_processing/agc/agc_audio.pcm",
"//resources/audio_processing/agc/agc_no_circular_buffer.dat",
"//resources/audio_processing/agc/agc_pitch_gain.dat",
"//resources/audio_processing/agc/agc_pitch_lag.dat",
"//resources/audio_processing/agc/agc_spectral_peak.dat",
"//resources/audio_processing/agc/agc_vad.dat",
"//resources/audio_processing/agc/agc_voicing_prob.dat",
"//resources/audio_processing/agc/agc_with_circular_buffer.dat",
Modify audio_processing_unittest to use ResourcePath instead of ProjectRootPath. Move the resources to //resources and upload them to Google Storage. BUG=webrtc:6727 Review-Url: https://codereview.webrtc.org/2508943004 Cr-Commit-Position: refs/heads/master@{#15152}
2016-11-18 04:52:22 -08:00
"//resources/audio_processing/output_data_fixed.pb",
"//resources/audio_processing/output_data_float.pb",
"//resources/audio_processing/output_data_mac.pb",
GN: Declare resources for targets. Declare resources for GN targets so that they can be isolated NOTRY=True BUG=chromium:497757 Review-Url: https://codereview.webrtc.org/2340753002 Cr-Commit-Position: refs/heads/master@{#14210}
2016-09-14 05:10:01 -07:00
"//resources/audio_processing/transient/ajm-macbook-1-spke16m.pcm",
"//resources/audio_processing/transient/audio16kHz.pcm",
"//resources/audio_processing/transient/audio32kHz.pcm",
"//resources/audio_processing/transient/audio48kHz.pcm",
"//resources/audio_processing/transient/audio8kHz.pcm",
"//resources/audio_processing/transient/detect16kHz.dat",
"//resources/audio_processing/transient/detect32kHz.dat",
"//resources/audio_processing/transient/detect48kHz.dat",
"//resources/audio_processing/transient/detect8kHz.dat",
"//resources/audio_processing/transient/double-utils.dat",
"//resources/audio_processing/transient/float-utils.dat",
"//resources/audio_processing/transient/suppressed16kHz.pcm",
"//resources/audio_processing/transient/suppressed32kHz.pcm",
"//resources/audio_processing/transient/suppressed8kHz.pcm",
"//resources/audio_processing/transient/wpd0.dat",
"//resources/audio_processing/transient/wpd1.dat",
"//resources/audio_processing/transient/wpd2.dat",
"//resources/audio_processing/transient/wpd3.dat",
"//resources/audio_processing/transient/wpd4.dat",
"//resources/audio_processing/transient/wpd5.dat",
"//resources/audio_processing/transient/wpd6.dat",
"//resources/audio_processing/transient/wpd7.dat",
"//resources/deflicker_before_cif_short.yuv",
"//resources/far16_stereo.pcm",
"//resources/far32_stereo.pcm",
"//resources/far44_stereo.pcm",
"//resources/far48_stereo.pcm",
"//resources/far8_stereo.pcm",
"//resources/foremanColorEnhanced_cif_short.yuv",
"//resources/foreman_cif.yuv",
"//resources/foreman_cif_short.yuv",
"//resources/near16_stereo.pcm",
"//resources/near32_stereo.pcm",
"//resources/near44_stereo.pcm",
"//resources/near48_stereo.pcm",
"//resources/near8_stereo.pcm",
"//resources/ref03.aecdump",
"//resources/remote_bitrate_estimator/VideoSendersTest_BweTest_IncreasingChoke1_0_AST.bin",
"//resources/remote_bitrate_estimator/VideoSendersTest_BweTest_IncreasingChoke1_0_TOF.bin",
"//resources/remote_bitrate_estimator/VideoSendersTest_BweTest_IncreasingChoke1_1_AST.bin",
"//resources/remote_bitrate_estimator/VideoSendersTest_BweTest_IncreasingChoke1_1_TOF.bin",
"//resources/remote_bitrate_estimator/VideoSendersTest_BweTest_IncreasingChoke2_0_AST.bin",
"//resources/remote_bitrate_estimator/VideoSendersTest_BweTest_IncreasingChoke2_0_TOF.bin",
"//resources/remote_bitrate_estimator/VideoSendersTest_BweTest_IncreasingChoke2_1_AST.bin",
"//resources/remote_bitrate_estimator/VideoSendersTest_BweTest_IncreasingChoke2_1_TOF.bin",
"//resources/remote_bitrate_estimator/VideoSendersTest_BweTest_IncreasingDelay1_0_AST.bin",
"//resources/remote_bitrate_estimator/VideoSendersTest_BweTest_IncreasingDelay1_0_TOF.bin",
"//resources/remote_bitrate_estimator/VideoSendersTest_BweTest_IncreasingLoss1_0_AST.bin",
"//resources/remote_bitrate_estimator/VideoSendersTest_BweTest_IncreasingLoss1_0_TOF.bin",
"//resources/remote_bitrate_estimator/VideoSendersTest_BweTest_Multi1_1_AST.bin",
"//resources/remote_bitrate_estimator/VideoSendersTest_BweTest_Multi1_1_TOF.bin",
"//resources/remote_bitrate_estimator/VideoSendersTest_BweTest_SteadyChoke_0_AST.bin",
"//resources/remote_bitrate_estimator/VideoSendersTest_BweTest_SteadyChoke_0_TOF.bin",
"//resources/remote_bitrate_estimator/VideoSendersTest_BweTest_SteadyChoke_1_AST.bin",
"//resources/remote_bitrate_estimator/VideoSendersTest_BweTest_SteadyChoke_1_TOF.bin",
"//resources/remote_bitrate_estimator/VideoSendersTest_BweTest_SteadyDelay_0_AST.bin",
"//resources/remote_bitrate_estimator/VideoSendersTest_BweTest_SteadyDelay_0_TOF.bin",
"//resources/remote_bitrate_estimator/VideoSendersTest_BweTest_SteadyLoss_0_AST.bin",
"//resources/remote_bitrate_estimator/VideoSendersTest_BweTest_SteadyLoss_0_TOF.bin",
"//resources/remote_bitrate_estimator/VideoSendersTest_BweTest_UnlimitedSpeed_0_AST.bin",
"//resources/remote_bitrate_estimator/VideoSendersTest_BweTest_UnlimitedSpeed_0_TOF.bin",
"//resources/short_mixed_mono_48.dat",
"//resources/short_mixed_mono_48_arm.dat",
"//resources/short_mixed_mono_48.pcm",
"//resources/short_mixed_stereo_48.dat",
"//resources/short_mixed_stereo_48.pcm",
"//resources/sprint-downlink.rx",
"//resources/sprint-uplink.rx",
"//resources/synthetic-trace.rx",
"//resources/tmobile-downlink.rx",
"//resources/tmobile-uplink.rx",
"//resources/verizon3g-downlink.rx",
"//resources/verizon3g-uplink.rx",
"//resources/verizon4g-downlink.rx",
"//resources/verizon4g-uplink.rx",
WebRTC: Replace ProjectRootPath by ResourcePath BUG=webrtc:6727 NOTRY=True Review-Url: https://codereview.webrtc.org/2513363004 Cr-Commit-Position: refs/heads/master@{#15201}
2016-11-22 10:42:59 -08:00
"//resources/voice_engine/audio_tiny48.wav",
GN: Declare resources for targets. Declare resources for GN targets so that they can be isolated NOTRY=True BUG=chromium:497757 Review-Url: https://codereview.webrtc.org/2340753002 Cr-Commit-Position: refs/heads/master@{#14210}
2016-09-14 05:10:01 -07:00
]
GN: Fix resource files for iOS test target In order to get resource files to be properly packaged into the .app for a unit test on iOS, the resource files needs to be listed as sources in a bundle_data target. BUG=webrtc:5949 NOTRY=True Review-Url: https://codereview.webrtc.org/2292853002 Cr-Commit-Position: refs/heads/master@{#13968}
2016-08-30 02:53:49 -07:00
if (is_ios) {
bundle_data("modules_unittests_bundle_data") {
testonly = true
sources = modules_unittests_resources
outputs = [
"{{bundle_resources_dir}}/{{source_file_part}}",
]
}
}
GN: Introduce templates. Defines the rtc_executable, rtc_source_set, rtc_test and rtc_static_library templates. These templates provide no functionality yet, but will enable common configuration to be introduced, avoiding repetition in every target Changes summary: - Prepend rtc_ to test, source_set, executable and static_library targets - Change "configs -= [" to "suppressed_configs += [" - Include webrtc/build/webrtc.gni where it wasn't included yet - Delete import("//testing/test.gni"), since rtc_test makes it unnecessary. BUG=webrtc:6187 TBR=henrik.lundin@webrtc.org,tommi@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2301053002 Cr-Commit-Position: refs/heads/master@{#14043}
2016-09-02 04:10:34 -07:00
rtc_test("modules_unittests") {
GN: Add modules_unittests Changes: * Enabled protobuf for iOS globally. * Set WEBRTC_INCLUDE_INTERNAL_AUDIO_DEVICE on a global scope similar to GYP since tests depend on it. * Added missing rtc_libvpx_build_vp9 variable. * Moved out audio_coding defines into .gni file to avoid code duplication * Renamed files to avoid object naming conflicts that GN disallows: * webrtc/modules/audio_processing/{echo_cancellation_unittest.cc->echo_cancellation_bit_exact_unittest.cc} * webrtc/modules/video_coding/codecs/vp9/{screenshare_layers_unittest.cc->vp9_screenshare_layers_unittest.cc} BUG=webrtc:5949 TESTED=Built and ran the tests on Mac. Also ran: gn gen out/Default --args="rtc_enable_bwe_test_logging=true" and verified that more objects are being built (1885 vs 1883) when compiling modules_unittests. NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2041233006 Cr-Commit-Position: refs/heads/master@{#13108}
2016-06-13 00:19:48 -07:00
testonly = true
GN: Refactor modules_unittests to eliminate package boundary violations. BUG=webrtc:6954 Review-Url: https://codereview.webrtc.org/2629923002 Cr-Commit-Position: refs/heads/master@{#16166}
2017-01-19 08:27:11 -08:00
defines = []
GN: Add modules_unittests Changes: * Enabled protobuf for iOS globally. * Set WEBRTC_INCLUDE_INTERNAL_AUDIO_DEVICE on a global scope similar to GYP since tests depend on it. * Added missing rtc_libvpx_build_vp9 variable. * Moved out audio_coding defines into .gni file to avoid code duplication * Renamed files to avoid object naming conflicts that GN disallows: * webrtc/modules/audio_processing/{echo_cancellation_unittest.cc->echo_cancellation_bit_exact_unittest.cc} * webrtc/modules/video_coding/codecs/vp9/{screenshare_layers_unittest.cc->vp9_screenshare_layers_unittest.cc} BUG=webrtc:5949 TESTED=Built and ran the tests on Mac. Also ran: gn gen out/Default --args="rtc_enable_bwe_test_logging=true" and verified that more objects are being built (1885 vs 1883) when compiling modules_unittests. NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2041233006 Cr-Commit-Position: refs/heads/master@{#13108}
2016-06-13 00:19:48 -07:00
sources = [
"module_common_types_unittest.cc",
]
GN: Refactor modules_unittests to eliminate package boundary violations. BUG=webrtc:6954 Review-Url: https://codereview.webrtc.org/2629923002 Cr-Commit-Position: refs/heads/master@{#16166}
2017-01-19 08:27:11 -08:00
if (!build_with_chromium && is_clang) {
GN: Add modules_unittests Changes: * Enabled protobuf for iOS globally. * Set WEBRTC_INCLUDE_INTERNAL_AUDIO_DEVICE on a global scope similar to GYP since tests depend on it. * Added missing rtc_libvpx_build_vp9 variable. * Moved out audio_coding defines into .gni file to avoid code duplication * Renamed files to avoid object naming conflicts that GN disallows: * webrtc/modules/audio_processing/{echo_cancellation_unittest.cc->echo_cancellation_bit_exact_unittest.cc} * webrtc/modules/video_coding/codecs/vp9/{screenshare_layers_unittest.cc->vp9_screenshare_layers_unittest.cc} BUG=webrtc:5949 TESTED=Built and ran the tests on Mac. Also ran: gn gen out/Default --args="rtc_enable_bwe_test_logging=true" and verified that more objects are being built (1885 vs 1883) when compiling modules_unittests. NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2041233006 Cr-Commit-Position: refs/heads/master@{#13108}
2016-06-13 00:19:48 -07:00
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
GN: Introduce templates. Defines the rtc_executable, rtc_source_set, rtc_test and rtc_static_library templates. These templates provide no functionality yet, but will enable common configuration to be introduced, avoiding repetition in every target Changes summary: - Prepend rtc_ to test, source_set, executable and static_library targets - Change "configs -= [" to "suppressed_configs += [" - Include webrtc/build/webrtc.gni where it wasn't included yet - Delete import("//testing/test.gni"), since rtc_test makes it unnecessary. BUG=webrtc:6187 TBR=henrik.lundin@webrtc.org,tommi@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2301053002 Cr-Commit-Position: refs/heads/master@{#14043}
2016-09-02 04:10:34 -07:00
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
GN: Add modules_unittests Changes: * Enabled protobuf for iOS globally. * Set WEBRTC_INCLUDE_INTERNAL_AUDIO_DEVICE on a global scope similar to GYP since tests depend on it. * Added missing rtc_libvpx_build_vp9 variable. * Moved out audio_coding defines into .gni file to avoid code duplication * Renamed files to avoid object naming conflicts that GN disallows: * webrtc/modules/audio_processing/{echo_cancellation_unittest.cc->echo_cancellation_bit_exact_unittest.cc} * webrtc/modules/video_coding/codecs/vp9/{screenshare_layers_unittest.cc->vp9_screenshare_layers_unittest.cc} BUG=webrtc:5949 TESTED=Built and ran the tests on Mac. Also ran: gn gen out/Default --args="rtc_enable_bwe_test_logging=true" and verified that more objects are being built (1885 vs 1883) when compiling modules_unittests. NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2041233006 Cr-Commit-Position: refs/heads/master@{#13108}
2016-06-13 00:19:48 -07:00
}
Reland of Creating webrtc/modules:module_api (patchset #1 id:1 of https://codereview.webrtc.org/2839963005/ ) Reason for revert: Fixing the Gn error and try to reland. Original issue's description: > Revert of Creating webrtc/modules:module_api (patchset #5 id:80001 of https://codereview.webrtc.org/2838873002/ ) > > Reason for revert: > Causes build problem: https://build.chromium.org/p/client.webrtc/builders/iOS64%20Sim%20Debug%20%28iOS%209.0%29/builds/1630/steps/generate%20build%20files%20%28mb%29/logs/stdio > > Original issue's description: > > Creating webrtc/modules:module_api > > > > This target keeps track of .h the files under webrtc/modules/include/ > > that are not part of any target. > > If a .h file is not part of a target the 'gn check' utility is not > > able to spot if a target is missing a dependency because even if > > it parses '#include' directives it is not able to find a target that > > contains these headers. > > > > BUG=webrtc:7513 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/2838873002 > > Cr-Commit-Position: refs/heads/master@{#17880} > > Committed: https://chromium.googlesource.com/external/webrtc/+/5a1a092ed09ca92719eeb293275f64c0cdcc0e51 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7513 > > Review-Url: https://codereview.webrtc.org/2839963005 > Cr-Commit-Position: refs/heads/master@{#17881} > Committed: https://chromium.googlesource.com/external/webrtc/+/bb08c3e29656fafe8a2d5d16ec4a62db49689f8a TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true TBR=kjellander@webrtc.org BUG=webrtc:7513 Review-Url: https://codereview.webrtc.org/2843913002 Cr-Commit-Position: refs/heads/master@{#17884}
2017-04-26 03:38:35 -07:00
deps = [
":module_api",
Replace test_support_main by test_main and get rid of test_support_main_threaded_mac test_support_main_threaded_mac doesn't seem to be used. It looks like it was last used about a year and a half ago, and was removed in https://webrtc-codereview.appspot.com/55379004 BUG=webrtc:6424 R=kjellander@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2540693002 Cr-Commit-Position: refs/heads/master@{#15332}
2016-11-30 06:12:01 -08:00
"../test:test_main",
GN: Refactor modules_unittests to eliminate package boundary violations. BUG=webrtc:6954 Review-Url: https://codereview.webrtc.org/2629923002 Cr-Commit-Position: refs/heads/master@{#16166}
2017-01-19 08:27:11 -08:00
"audio_coding:audio_coding_unittests",
GN: Add audio_conference_mixer_unittests to modules_unittests. Was removed by accident in https://codereview.webrtc.org/2629923002/ BUG=webrtc:6954 R=kjellander@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2641203002 Cr-Commit-Position: refs/heads/master@{#16170}
2017-01-19 11:57:56 -08:00
"audio_conference_mixer:audio_conference_mixer_unittests",
GN: Refactor modules_unittests to eliminate package boundary violations. BUG=webrtc:6954 Review-Url: https://codereview.webrtc.org/2629923002 Cr-Commit-Position: refs/heads/master@{#16166}
2017-01-19 08:27:11 -08:00
"audio_device:audio_device_unittests",
"audio_mixer:audio_mixer_unittests",
"audio_processing:audio_processing_unittests",
"bitrate_controller:bitrate_controller_unittests",
"congestion_controller:congestion_controller_unittests",
"desktop_capture:desktop_capture_unittests",
"media_file:media_file_unittests",
"pacing:pacing_unittests",
"remote_bitrate_estimator:remote_bitrate_estimator_unittests",
"rtp_rtcp:rtp_rtcp_unittests",
"utility:utility_unittests",
Move frame_generator_capture.{cc, h} and video_capturer.h to video_test_common. Remove video_capture as a dependency of test_common and add it as a dependency of modules_unittests, as it was before the refactor in https://codereview.webrtc.org/2629923002 BUG=webrtc:7037 NOTRY=True Review-Url: https://codereview.webrtc.org/2666113003 Cr-Commit-Position: refs/heads/master@{#16439}
2017-02-06 02:21:11 -08:00
"video_capture",
GN: Refactor modules_unittests to eliminate package boundary violations. BUG=webrtc:6954 Review-Url: https://codereview.webrtc.org/2629923002 Cr-Commit-Position: refs/heads/master@{#16166}
2017-01-19 08:27:11 -08:00
"video_coding:video_coding_unittests",
"video_processing:video_processing_unittests",
GN: Add modules_unittests Changes: * Enabled protobuf for iOS globally. * Set WEBRTC_INCLUDE_INTERNAL_AUDIO_DEVICE on a global scope similar to GYP since tests depend on it. * Added missing rtc_libvpx_build_vp9 variable. * Moved out audio_coding defines into .gni file to avoid code duplication * Renamed files to avoid object naming conflicts that GN disallows: * webrtc/modules/audio_processing/{echo_cancellation_unittest.cc->echo_cancellation_bit_exact_unittest.cc} * webrtc/modules/video_coding/codecs/vp9/{screenshare_layers_unittest.cc->vp9_screenshare_layers_unittest.cc} BUG=webrtc:5949 TESTED=Built and ran the tests on Mac. Also ran: gn gen out/Default --args="rtc_enable_bwe_test_logging=true" and verified that more objects are being built (1885 vs 1883) when compiling modules_unittests. NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2041233006 Cr-Commit-Position: refs/heads/master@{#13108}
2016-06-13 00:19:48 -07:00
]
GN: Declare resources for targets. Declare resources for GN targets so that they can be isolated NOTRY=True BUG=chromium:497757 Review-Url: https://codereview.webrtc.org/2340753002 Cr-Commit-Position: refs/heads/master@{#14210}
2016-09-14 05:10:01 -07:00
data = modules_unittests_resources
GN: Add modules_unittests Changes: * Enabled protobuf for iOS globally. * Set WEBRTC_INCLUDE_INTERNAL_AUDIO_DEVICE on a global scope similar to GYP since tests depend on it. * Added missing rtc_libvpx_build_vp9 variable. * Moved out audio_coding defines into .gni file to avoid code duplication * Renamed files to avoid object naming conflicts that GN disallows: * webrtc/modules/audio_processing/{echo_cancellation_unittest.cc->echo_cancellation_bit_exact_unittest.cc} * webrtc/modules/video_coding/codecs/vp9/{screenshare_layers_unittest.cc->vp9_screenshare_layers_unittest.cc} BUG=webrtc:5949 TESTED=Built and ran the tests on Mac. Also ran: gn gen out/Default --args="rtc_enable_bwe_test_logging=true" and verified that more objects are being built (1885 vs 1883) when compiling modules_unittests. NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2041233006 Cr-Commit-Position: refs/heads/master@{#13108}
2016-06-13 00:19:48 -07:00
if (is_android) {
GN: Add dependency libjingle_peerconnection_java to modules_unittests. This change only affects the Android build. BUG=webrtc:6189 TBR=tommi@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2233903002 Cr-Commit-Position: refs/heads/master@{#13722}
2016-08-11 00:59:15 -07:00
deps += [
"//testing/android/native_test:native_test_support",
Move /webrtc/api/android files to /webrtc/sdk/android I decided to make one webrtc/sdk/android/BUILD.gn for both tests and Java/jni src. External dependencies needs to be updated after this CL. Future work is required to clean up the Android api and move implementation details to /webrtc/sdk/android/src. BUG=webrtc:5882,webrtc:6804 NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2547483003 Cr-Commit-Position: refs/heads/master@{#15443}
2016-12-06 04:29:37 -08:00
"//webrtc/sdk/android:libjingle_peerconnection_java",
GN: Add dependency libjingle_peerconnection_java to modules_unittests. This change only affects the Android build. BUG=webrtc:6189 TBR=tommi@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2233903002 Cr-Commit-Position: refs/heads/master@{#13722}
2016-08-11 00:59:15 -07:00
]
GN: Synchronize resources between Android and iOS. iOS tests packaged into an .app uses the same way of defining resources (the data attribute). Some iOS simulator tests are failing due to missing resources, so let's sync them all. BUG=webrtc:5949 NOTRY=True Review-Url: https://codereview.webrtc.org/2277753003 Cr-Commit-Position: refs/heads/master@{#13898}
2016-08-24 07:48:42 -07:00
shard_timeout = 900
}
GN: Add modules_unittests Changes: * Enabled protobuf for iOS globally. * Set WEBRTC_INCLUDE_INTERNAL_AUDIO_DEVICE on a global scope similar to GYP since tests depend on it. * Added missing rtc_libvpx_build_vp9 variable. * Moved out audio_coding defines into .gni file to avoid code duplication * Renamed files to avoid object naming conflicts that GN disallows: * webrtc/modules/audio_processing/{echo_cancellation_unittest.cc->echo_cancellation_bit_exact_unittest.cc} * webrtc/modules/video_coding/codecs/vp9/{screenshare_layers_unittest.cc->vp9_screenshare_layers_unittest.cc} BUG=webrtc:5949 TESTED=Built and ran the tests on Mac. Also ran: gn gen out/Default --args="rtc_enable_bwe_test_logging=true" and verified that more objects are being built (1885 vs 1883) when compiling modules_unittests. NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2041233006 Cr-Commit-Position: refs/heads/master@{#13108}
2016-06-13 00:19:48 -07:00
if (is_ios) {
Add custom info.plist to modules_unittests This is to fix an issue introduced with iOS 10 where all applications that access the microphone have to include a string in the Info.plist file explaining why they need it. BUG=webrtc:6403 Review-Url: https://codereview.webrtc.org/2359863003 Cr-Commit-Position: refs/heads/master@{#14354}
2016-09-22 08:00:52 -07:00
info_plist = "//webrtc/test/ios/Info.plist"
GN: Fix resource files for iOS test target In order to get resource files to be properly packaged into the .app for a unit test on iOS, the resource files needs to be listed as sources in a bundle_data target. BUG=webrtc:5949 NOTRY=True Review-Url: https://codereview.webrtc.org/2292853002 Cr-Commit-Position: refs/heads/master@{#13968}
2016-08-30 02:53:49 -07:00
deps += [ ":modules_unittests_bundle_data" ]
GN: Refactor modules_unittests to eliminate package boundary violations. BUG=webrtc:6954 Review-Url: https://codereview.webrtc.org/2629923002 Cr-Commit-Position: refs/heads/master@{#16166}
2017-01-19 08:27:11 -08:00
configs += [ "..:common_objc" ]
GN: Add modules_unittests Changes: * Enabled protobuf for iOS globally. * Set WEBRTC_INCLUDE_INTERNAL_AUDIO_DEVICE on a global scope similar to GYP since tests depend on it. * Added missing rtc_libvpx_build_vp9 variable. * Moved out audio_coding defines into .gni file to avoid code duplication * Renamed files to avoid object naming conflicts that GN disallows: * webrtc/modules/audio_processing/{echo_cancellation_unittest.cc->echo_cancellation_bit_exact_unittest.cc} * webrtc/modules/video_coding/codecs/vp9/{screenshare_layers_unittest.cc->vp9_screenshare_layers_unittest.cc} BUG=webrtc:5949 TESTED=Built and ran the tests on Mac. Also ran: gn gen out/Default --args="rtc_enable_bwe_test_logging=true" and verified that more objects are being built (1885 vs 1883) when compiling modules_unittests. NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2041233006 Cr-Commit-Position: refs/heads/master@{#13108}
2016-06-13 00:19:48 -07:00
ldflags = [ "-ObjC" ]
}
}
}
Reference in New Issue Copy Permalink