admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
webrtc_m130/logging/BUILD.gn

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

415 lines
12 KiB
Plaintext
Raw Normal View History

Moved RtcEventLog files from call/ to logging/ The RtcEventLog headers need to be accessible from any place which needs logging, and the implementation needs access to data structures that are logged. After a discussion in the code review, we all agreed to move the RtcEventLog implementation into its own top level directory - which I called "logging/" in expectation that other types of logging may have similar requirements. The directory contains two main build targets - "rtc_event_log_api", which is just rtc_event_log.h, that has no external dependencies and can be used from anywhere, and "rtc_event_log_impl" which contains the rest of the implementation and has many dependencies (more in the future). The "api" target can be referenced from anywhere, while the "impl" target is only needed at the place of instantiation (currently Call, soon to be moved to PeerConnection by https://codereview.webrtc.org/2353033005/). This change allows using RtcEventLog in the p2p/ directory, so that we can log STUN pings and ICE state transitions. BUG=webrtc:6393 R=kjellander@webrtc.org, kwiberg@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, terelius@webrtc.org Review URL: https://codereview.webrtc.org/2380683005 . Cr-Commit-Position: refs/heads/master@{#14485}
2016-10-03 18:31:22 -07:00
# Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
#
# Use of this source code is governed by a BSD-style license
# that can be found in the LICENSE file in the root of the source
# tree. An additional intellectual property rights grant can be found
# in the file PATENTS. All contributing project authors may
# be found in the AUTHORS file in the root of the source tree.
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
import("../webrtc.gni")
Update gn files to support Mozilla build Bug: webrtc:8670 No-Presubmit: true Change-Id: I085dc63daa8274b5068540cbf56b6330f40643fa Reviewed-on: https://webrtc-review.googlesource.com/38920 Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21624}
2018-01-15 10:20:00 -05:00
if (!build_with_mozilla) {
import("//third_party/protobuf/proto_library.gni")
}
Moved RtcEventLog files from call/ to logging/ The RtcEventLog headers need to be accessible from any place which needs logging, and the implementation needs access to data structures that are logged. After a discussion in the code review, we all agreed to move the RtcEventLog implementation into its own top level directory - which I called "logging/" in expectation that other types of logging may have similar requirements. The directory contains two main build targets - "rtc_event_log_api", which is just rtc_event_log.h, that has no external dependencies and can be used from anywhere, and "rtc_event_log_impl" which contains the rest of the implementation and has many dependencies (more in the future). The "api" target can be referenced from anywhere, while the "impl" target is only needed at the place of instantiation (currently Call, soon to be moved to PeerConnection by https://codereview.webrtc.org/2353033005/). This change allows using RtcEventLog in the p2p/ directory, so that we can log STUN pings and ICE state transitions. BUG=webrtc:6393 R=kjellander@webrtc.org, kwiberg@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, terelius@webrtc.org Review URL: https://codereview.webrtc.org/2380683005 . Cr-Commit-Position: refs/heads/master@{#14485}
2016-10-03 18:31:22 -07:00
if (is_android) {
import("//build/config/android/config.gni")
import("//build/config/android/rules.gni")
}
GN: New conventions, default target and refactorings Introduce a convention on categorizing GN targets: 1. Production code 2. Tests 3. Examples 4. Tools The first two have targets spread out all over the tree, while the latter are isolated to examples/ and tools/ directories. Another new convention: Each directory's BUILD.gn file shall contain a target named similar to the directory name. This target shall contain the 'most common' production code, i.e. so that most consumers of the directory can depend on only the directory (which implicitly means that target in GN). //webrtc:webrtc_tests is changed to depend on all WebRTC tests. From now on, it's necessary to add new test targets to this dependency tree in order to get them compiled. Two new group targets are created: //webrtc/modules/audio_coding:audio_coding_tests //webrtc/modules/audio_processing:audio_processing_tests to reduce the long list of tests in //webrtc:webrtc_tests. Visibility on //webrtc:webrtc and //webrtc:webrtc_tests is restricted to the root target, to avoid circular dependencies due to the monolithic property of these targets (a problem we've had in the past). The 'root' target at the top level is renamed to 'default', which means GN will build this target instead of _all_ generated targets (see https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/faq.md#Can-I-control-what-targets-are-built-by-default). This target now depends on everything we want to build, meaning all targets now explicitly needs to be wired up from the root target in order to get build. Having this, the number of compiled objects on Android is decreased from 8855 to 6276. It also gives us better control over our build. BUG=webrtc:6440 TESTED=git cl try --clobber NOTRY=True Review-Url: https://codereview.webrtc.org/2441383002 Cr-Commit-Position: refs/heads/master@{#14821}
2016-10-28 05:44:03 -07:00
group("logging") {
Stop using public_deps in logging/. Bug: webrtc:8603 Change-Id: Id0df997620a27e47067e4b21e4e8db16aec90640 No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/30940 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21228}
2017-12-12 12:46:13 +01:00
deps = [
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
":rtc_event_audio",
":rtc_event_bwe",
":rtc_event_log_impl_base",
":rtc_event_log_impl_encoder",
":rtc_event_log_impl_output",
":rtc_event_pacing",
":rtc_event_rtp_rtcp",
":rtc_event_video",
GN: New conventions, default target and refactorings Introduce a convention on categorizing GN targets: 1. Production code 2. Tests 3. Examples 4. Tools The first two have targets spread out all over the tree, while the latter are isolated to examples/ and tools/ directories. Another new convention: Each directory's BUILD.gn file shall contain a target named similar to the directory name. This target shall contain the 'most common' production code, i.e. so that most consumers of the directory can depend on only the directory (which implicitly means that target in GN). //webrtc:webrtc_tests is changed to depend on all WebRTC tests. From now on, it's necessary to add new test targets to this dependency tree in order to get them compiled. Two new group targets are created: //webrtc/modules/audio_coding:audio_coding_tests //webrtc/modules/audio_processing:audio_processing_tests to reduce the long list of tests in //webrtc:webrtc_tests. Visibility on //webrtc:webrtc and //webrtc:webrtc_tests is restricted to the root target, to avoid circular dependencies due to the monolithic property of these targets (a problem we've had in the past). The 'root' target at the top level is renamed to 'default', which means GN will build this target instead of _all_ generated targets (see https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/faq.md#Can-I-control-what-targets-are-built-by-default). This target now depends on everything we want to build, meaning all targets now explicitly needs to be wired up from the root target in order to get build. Having this, the number of compiled objects on Android is decreased from 8855 to 6276. It also gives us better control over our build. BUG=webrtc:6440 TESTED=git cl try --clobber NOTRY=True Review-Url: https://codereview.webrtc.org/2441383002 Cr-Commit-Position: refs/heads/master@{#14821}
2016-10-28 05:44:03 -07:00
]
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
GN: New conventions, default target and refactorings Introduce a convention on categorizing GN targets: 1. Production code 2. Tests 3. Examples 4. Tools The first two have targets spread out all over the tree, while the latter are isolated to examples/ and tools/ directories. Another new convention: Each directory's BUILD.gn file shall contain a target named similar to the directory name. This target shall contain the 'most common' production code, i.e. so that most consumers of the directory can depend on only the directory (which implicitly means that target in GN). //webrtc:webrtc_tests is changed to depend on all WebRTC tests. From now on, it's necessary to add new test targets to this dependency tree in order to get them compiled. Two new group targets are created: //webrtc/modules/audio_coding:audio_coding_tests //webrtc/modules/audio_processing:audio_processing_tests to reduce the long list of tests in //webrtc:webrtc_tests. Visibility on //webrtc:webrtc and //webrtc:webrtc_tests is restricted to the root target, to avoid circular dependencies due to the monolithic property of these targets (a problem we've had in the past). The 'root' target at the top level is renamed to 'default', which means GN will build this target instead of _all_ generated targets (see https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/faq.md#Can-I-control-what-targets-are-built-by-default). This target now depends on everything we want to build, meaning all targets now explicitly needs to be wired up from the root target in order to get build. Having this, the number of compiled objects on Android is decreased from 8855 to 6276. It also gives us better control over our build. BUG=webrtc:6440 TESTED=git cl try --clobber NOTRY=True Review-Url: https://codereview.webrtc.org/2441383002 Cr-Commit-Position: refs/heads/master@{#14821}
2016-10-28 05:44:03 -07:00
if (rtc_enable_protobuf) {
Stop using public_deps in logging/. Bug: webrtc:8603 Change-Id: Id0df997620a27e47067e4b21e4e8db16aec90640 No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/30940 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21228}
2017-12-12 12:46:13 +01:00
deps += [ ":rtc_event_log_parser" ]
GN: New conventions, default target and refactorings Introduce a convention on categorizing GN targets: 1. Production code 2. Tests 3. Examples 4. Tools The first two have targets spread out all over the tree, while the latter are isolated to examples/ and tools/ directories. Another new convention: Each directory's BUILD.gn file shall contain a target named similar to the directory name. This target shall contain the 'most common' production code, i.e. so that most consumers of the directory can depend on only the directory (which implicitly means that target in GN). //webrtc:webrtc_tests is changed to depend on all WebRTC tests. From now on, it's necessary to add new test targets to this dependency tree in order to get them compiled. Two new group targets are created: //webrtc/modules/audio_coding:audio_coding_tests //webrtc/modules/audio_processing:audio_processing_tests to reduce the long list of tests in //webrtc:webrtc_tests. Visibility on //webrtc:webrtc and //webrtc:webrtc_tests is restricted to the root target, to avoid circular dependencies due to the monolithic property of these targets (a problem we've had in the past). The 'root' target at the top level is renamed to 'default', which means GN will build this target instead of _all_ generated targets (see https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/faq.md#Can-I-control-what-targets-are-built-by-default). This target now depends on everything we want to build, meaning all targets now explicitly needs to be wired up from the root target in order to get build. Having this, the number of compiled objects on Android is decreased from 8855 to 6276. It also gives us better control over our build. BUG=webrtc:6440 TESTED=git cl try --clobber NOTRY=True Review-Url: https://codereview.webrtc.org/2441383002 Cr-Commit-Position: refs/heads/master@{#14821}
2016-10-28 05:44:03 -07:00
}
}
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
# TODO(mbonadei): Remove when the following CL is landed:
# https://webrtc-review.googlesource.com/c/src/+/46900.
# This is only a backwards compatible target.
rtc_source_set("rtc_event_log_impl") {
visibility = [ "*" ]
deps = [
":rtc_event_log_impl_base",
]
}
Moved RtcEventLog files from call/ to logging/ The RtcEventLog headers need to be accessible from any place which needs logging, and the implementation needs access to data structures that are logged. After a discussion in the code review, we all agreed to move the RtcEventLog implementation into its own top level directory - which I called "logging/" in expectation that other types of logging may have similar requirements. The directory contains two main build targets - "rtc_event_log_api", which is just rtc_event_log.h, that has no external dependencies and can be used from anywhere, and "rtc_event_log_impl" which contains the rest of the implementation and has many dependencies (more in the future). The "api" target can be referenced from anywhere, while the "impl" target is only needed at the place of instantiation (currently Call, soon to be moved to PeerConnection by https://codereview.webrtc.org/2353033005/). This change allows using RtcEventLog in the p2p/ directory, so that we can log STUN pings and ICE state transitions. BUG=webrtc:6393 R=kjellander@webrtc.org, kwiberg@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, terelius@webrtc.org Review URL: https://codereview.webrtc.org/2380683005 . Cr-Commit-Position: refs/heads/master@{#14485}
2016-10-03 18:31:22 -07:00
rtc_source_set("rtc_event_log_api") {
sources = [
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
"rtc_event_log/encoder/rtc_event_log_encoder.h",
Introduce RtcEvent and subclasses We're moving to an RtcEventLog interface that accepts std::unique_ptr<EventLog> and stores the event for encoding when encoding becomes necessary, rather than before. This will be useful while we maintain the legacy (current) encoding alongside the new encoding on which we're working. This CL just introduces the new RtcEvent and its sub-classes, without constructors and without use. Upcoming CLs will finish the work. BUG=webrtc:8111 Change-Id: I782383e861c31670b7cd13ffc6b43ca6a26c98f6 Reviewed-on: https://webrtc-review.googlesource.com/1360 Commit-Queue: Elad Alon <eladalon@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20068}
2017-10-02 11:27:52 +02:00
"rtc_event_log/events/rtc_event.h",
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
"rtc_event_log/rtc_event_log.h",
"rtc_event_log/rtc_event_log_factory_interface.h",
]
deps = [
"../api:libjingle_logging_api",
"../rtc_base:rtc_base_approved",
]
}
rtc_source_set("rtc_stream_config") {
sources = [
"rtc_event_log/rtc_stream_config.cc",
"rtc_event_log/rtc_stream_config.h",
]
deps = [
":rtc_event_log_api",
"..:webrtc_common",
"../api:libjingle_peerconnection_api",
]
}
rtc_source_set("rtc_event_pacing") {
sources = [
Add new event type to RtcEventLog Alr state is now logged by the pacer. To avoid confusion, loopback tools will now create two separate rtc event logs for sender and receiver calls. Bug: webrtc:8287, webrtc:8588 Change-Id: Ib3e47d109c3a65a7ed069b9a613e6a08fe6a2f30 Reviewed-on: https://webrtc-review.googlesource.com/26880 Reviewed-by: Erik Språng <sprang@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Reviewed-by: Philip Eliasson <philipel@webrtc.org> Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21084}
2017-12-05 13:19:45 +01:00
"rtc_event_log/events/rtc_event_alr_state.cc",
"rtc_event_log/events/rtc_event_alr_state.h",
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
]
deps = [
":rtc_event_log_api",
"../:typedefs",
]
}
rtc_source_set("rtc_event_audio") {
sources = [
Introduce RtcEvent and subclasses We're moving to an RtcEventLog interface that accepts std::unique_ptr<EventLog> and stores the event for encoding when encoding becomes necessary, rather than before. This will be useful while we maintain the legacy (current) encoding alongside the new encoding on which we're working. This CL just introduces the new RtcEvent and its sub-classes, without constructors and without use. Upcoming CLs will finish the work. BUG=webrtc:8111 Change-Id: I782383e861c31670b7cd13ffc6b43ca6a26c98f6 Reviewed-on: https://webrtc-review.googlesource.com/1360 Commit-Queue: Elad Alon <eladalon@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20068}
2017-10-02 11:27:52 +02:00
"rtc_event_log/events/rtc_event_audio_network_adaptation.cc",
"rtc_event_log/events/rtc_event_audio_network_adaptation.h",
"rtc_event_log/events/rtc_event_audio_playout.cc",
"rtc_event_log/events/rtc_event_audio_playout.h",
"rtc_event_log/events/rtc_event_audio_receive_stream_config.cc",
"rtc_event_log/events/rtc_event_audio_receive_stream_config.h",
"rtc_event_log/events/rtc_event_audio_send_stream_config.cc",
"rtc_event_log/events/rtc_event_audio_send_stream_config.h",
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
]
deps = [
":rtc_event_log_api",
":rtc_stream_config",
"../modules/audio_coding:audio_network_adaptor_config",
]
}
rtc_source_set("rtc_event_bwe") {
sources = [
Introduce RtcEvent and subclasses We're moving to an RtcEventLog interface that accepts std::unique_ptr<EventLog> and stores the event for encoding when encoding becomes necessary, rather than before. This will be useful while we maintain the legacy (current) encoding alongside the new encoding on which we're working. This CL just introduces the new RtcEvent and its sub-classes, without constructors and without use. Upcoming CLs will finish the work. BUG=webrtc:8111 Change-Id: I782383e861c31670b7cd13ffc6b43ca6a26c98f6 Reviewed-on: https://webrtc-review.googlesource.com/1360 Commit-Queue: Elad Alon <eladalon@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20068}
2017-10-02 11:27:52 +02:00
"rtc_event_log/events/rtc_event_bwe_update_delay_based.cc",
"rtc_event_log/events/rtc_event_bwe_update_delay_based.h",
"rtc_event_log/events/rtc_event_bwe_update_loss_based.cc",
"rtc_event_log/events/rtc_event_bwe_update_loss_based.h",
"rtc_event_log/events/rtc_event_probe_cluster_created.cc",
"rtc_event_log/events/rtc_event_probe_cluster_created.h",
"rtc_event_log/events/rtc_event_probe_result_failure.cc",
"rtc_event_log/events/rtc_event_probe_result_failure.h",
"rtc_event_log/events/rtc_event_probe_result_success.cc",
"rtc_event_log/events/rtc_event_probe_result_success.h",
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
]
deps = [
":rtc_event_log_api",
"../modules/remote_bitrate_estimator:remote_bitrate_estimator",
]
}
rtc_source_set("rtc_event_rtp_rtcp") {
sources = [
Introduce RtcEvent and subclasses We're moving to an RtcEventLog interface that accepts std::unique_ptr<EventLog> and stores the event for encoding when encoding becomes necessary, rather than before. This will be useful while we maintain the legacy (current) encoding alongside the new encoding on which we're working. This CL just introduces the new RtcEvent and its sub-classes, without constructors and without use. Upcoming CLs will finish the work. BUG=webrtc:8111 Change-Id: I782383e861c31670b7cd13ffc6b43ca6a26c98f6 Reviewed-on: https://webrtc-review.googlesource.com/1360 Commit-Queue: Elad Alon <eladalon@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20068}
2017-10-02 11:27:52 +02:00
"rtc_event_log/events/rtc_event_rtcp_packet_incoming.cc",
"rtc_event_log/events/rtc_event_rtcp_packet_incoming.h",
"rtc_event_log/events/rtc_event_rtcp_packet_outgoing.cc",
"rtc_event_log/events/rtc_event_rtcp_packet_outgoing.h",
"rtc_event_log/events/rtc_event_rtp_packet_incoming.cc",
"rtc_event_log/events/rtc_event_rtp_packet_incoming.h",
"rtc_event_log/events/rtc_event_rtp_packet_outgoing.cc",
"rtc_event_log/events/rtc_event_rtp_packet_outgoing.h",
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
]
deps = [
":rtc_event_log_api",
"../api:array_view",
"../modules/rtp_rtcp:rtp_rtcp_format",
"../rtc_base:rtc_base_approved",
]
}
rtc_source_set("rtc_event_video") {
sources = [
Introduce RtcEvent and subclasses We're moving to an RtcEventLog interface that accepts std::unique_ptr<EventLog> and stores the event for encoding when encoding becomes necessary, rather than before. This will be useful while we maintain the legacy (current) encoding alongside the new encoding on which we're working. This CL just introduces the new RtcEvent and its sub-classes, without constructors and without use. Upcoming CLs will finish the work. BUG=webrtc:8111 Change-Id: I782383e861c31670b7cd13ffc6b43ca6a26c98f6 Reviewed-on: https://webrtc-review.googlesource.com/1360 Commit-Queue: Elad Alon <eladalon@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20068}
2017-10-02 11:27:52 +02:00
"rtc_event_log/events/rtc_event_video_receive_stream_config.cc",
"rtc_event_log/events/rtc_event_video_receive_stream_config.h",
"rtc_event_log/events/rtc_event_video_send_stream_config.cc",
"rtc_event_log/events/rtc_event_video_send_stream_config.h",
Moved RtcEventLog files from call/ to logging/ The RtcEventLog headers need to be accessible from any place which needs logging, and the implementation needs access to data structures that are logged. After a discussion in the code review, we all agreed to move the RtcEventLog implementation into its own top level directory - which I called "logging/" in expectation that other types of logging may have similar requirements. The directory contains two main build targets - "rtc_event_log_api", which is just rtc_event_log.h, that has no external dependencies and can be used from anywhere, and "rtc_event_log_impl" which contains the rest of the implementation and has many dependencies (more in the future). The "api" target can be referenced from anywhere, while the "impl" target is only needed at the place of instantiation (currently Call, soon to be moved to PeerConnection by https://codereview.webrtc.org/2353033005/). This change allows using RtcEventLog in the p2p/ directory, so that we can log STUN pings and ICE state transitions. BUG=webrtc:6393 R=kjellander@webrtc.org, kwiberg@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, terelius@webrtc.org Review URL: https://codereview.webrtc.org/2380683005 . Cr-Commit-Position: refs/heads/master@{#14485}
2016-10-03 18:31:22 -07:00
]
Create and use RtcEventLogOutput for output We need to support two modes of writing to the output: 1. Current way - the application lets lets WebRTC know which file to write to, and WebRTC is then in charge of the writing. 2. New way - the application would receive indications from WebRTC about (encoded) RTC events, and would itself be in charge of processing them (be it writing it to a file, uploading it somewhere, etc.). We achieve this by creating an interface for output - RtcEventLogOutput. By providing an instance of the subclass, RtcEventLogOutputFile, the old behavior is achieved. The subclass of the new behavior is to be added by a later CL. TBR=stefan@webrtc.org Bug: webrtc:8111 Change-Id: I9c50521a7f7144d86d8353a65995795862e19c44 Reviewed-on: https://webrtc-review.googlesource.com/2686 Commit-Queue: Elad Alon <eladalon@webrtc.org> Reviewed-by: Elad Alon <eladalon@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20135}
2017-10-04 13:18:26 +02:00
Enable GN check for webrtc/logging BUG=webrtc:6828, webrtc:7257 NOTRY=True Review-Url: https://codereview.webrtc.org/2717903002 Cr-Commit-Position: refs/heads/master@{#17111}
2017-03-08 02:12:11 -08:00
deps = [
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
":rtc_event_log_api",
":rtc_stream_config",
]
}
rtc_static_library("rtc_event_log_impl_encoder") {
visibility = [ "*" ]
sources = [
"rtc_event_log/encoder/rtc_event_log_encoder_legacy.cc",
"rtc_event_log/encoder/rtc_event_log_encoder_legacy.h",
]
defines = []
deps = [
":rtc_event_audio",
":rtc_event_bwe",
":rtc_event_log_api",
":rtc_event_log_impl_output",
":rtc_event_pacing",
":rtc_event_rtp_rtcp",
":rtc_event_video",
":rtc_stream_config",
"../modules/audio_coding:audio_network_adaptor",
Add the internals of RtcEvent's subclasses We're moving to an RtcEventLog interface that accepts std::unique_ptr<EventLog> and stores the event for encoding when encoding becomes necessary, rather than before. This will be useful while we maintain the legacy (current) encoding alongside the new encoding on which we're working. This CL adds the internals of RtcEvent's subclasses - the actual data that they keep. (Work on this was broken down into several CLs in order to make reviewing easier.) BUG=webrtc:8111 Change-Id: I402c9c64bffef6a5a6d227bde5da0fd3152daba1 Reviewed-on: https://webrtc-review.googlesource.com/1362 Commit-Queue: Elad Alon <eladalon@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20108}
2017-10-02 13:33:31 +02:00
"../modules/remote_bitrate_estimator:remote_bitrate_estimator",
"../modules/rtp_rtcp:rtp_rtcp_format",
Fix circular dependencies between optional, array_view, and rtc_base. This splits things out of rtc_base and makes dependencies explicit. Bug: webrtc:6828 Change-Id: Id521896c3c43595349021c857bec216e429a0c8d Reviewed-on: https://webrtc-review.googlesource.com/32780 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21264}
2017-12-13 16:05:42 +01:00
"../rtc_base:checks",
Remove remains of webrtc/base All downstream code have been updated to the new location. In PRESUBMIT.py: * Remove webrtc/rtc_base from CPP_BLACKLIST * Add webrtc/rtc_base to LEGACY_API_DIRS Fix some duplicated paths in webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn BUG=webrtc:7634 TBR=kwiberg@webrtc.org Review-Url: https://codereview.webrtc.org/2976293002 Cr-Commit-Position: refs/heads/master@{#19094}
2017-07-19 10:40:47 -07:00
"../rtc_base:rtc_base_approved",
Enable GN check for webrtc/logging BUG=webrtc:6828, webrtc:7257 NOTRY=True Review-Url: https://codereview.webrtc.org/2717903002 Cr-Commit-Position: refs/heads/master@{#17111}
2017-03-08 02:12:11 -08:00
]
Create and use RtcEventLogOutput for output We need to support two modes of writing to the output: 1. Current way - the application lets lets WebRTC know which file to write to, and WebRTC is then in charge of the writing. 2. New way - the application would receive indications from WebRTC about (encoded) RTC events, and would itself be in charge of processing them (be it writing it to a file, uploading it somewhere, etc.). We achieve this by creating an interface for output - RtcEventLogOutput. By providing an instance of the subclass, RtcEventLogOutputFile, the old behavior is achieved. The subclass of the new behavior is to be added by a later CL. TBR=stefan@webrtc.org Bug: webrtc:8111 Change-Id: I9c50521a7f7144d86d8353a65995795862e19c44 Reviewed-on: https://webrtc-review.googlesource.com/2686 Commit-Queue: Elad Alon <eladalon@webrtc.org> Reviewed-by: Elad Alon <eladalon@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20135}
2017-10-04 13:18:26 +02:00
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
if (rtc_enable_protobuf) {
defines += [ "ENABLE_RTC_EVENT_LOG" ]
deps += [ ":rtc_event_log_proto" ]
}
Create and use RtcEventLogOutput for output We need to support two modes of writing to the output: 1. Current way - the application lets lets WebRTC know which file to write to, and WebRTC is then in charge of the writing. 2. New way - the application would receive indications from WebRTC about (encoded) RTC events, and would itself be in charge of processing them (be it writing it to a file, uploading it somewhere, etc.). We achieve this by creating an interface for output - RtcEventLogOutput. By providing an instance of the subclass, RtcEventLogOutputFile, the old behavior is achieved. The subclass of the new behavior is to be added by a later CL. TBR=stefan@webrtc.org Bug: webrtc:8111 Change-Id: I9c50521a7f7144d86d8353a65995795862e19c44 Reviewed-on: https://webrtc-review.googlesource.com/2686 Commit-Queue: Elad Alon <eladalon@webrtc.org> Reviewed-by: Elad Alon <eladalon@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20135}
2017-10-04 13:18:26 +02:00
# TODO(eladalon): Remove this.
if (!build_with_chromium && is_clang) {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
}
Moved RtcEventLog files from call/ to logging/ The RtcEventLog headers need to be accessible from any place which needs logging, and the implementation needs access to data structures that are logged. After a discussion in the code review, we all agreed to move the RtcEventLog implementation into its own top level directory - which I called "logging/" in expectation that other types of logging may have similar requirements. The directory contains two main build targets - "rtc_event_log_api", which is just rtc_event_log.h, that has no external dependencies and can be used from anywhere, and "rtc_event_log_impl" which contains the rest of the implementation and has many dependencies (more in the future). The "api" target can be referenced from anywhere, while the "impl" target is only needed at the place of instantiation (currently Call, soon to be moved to PeerConnection by https://codereview.webrtc.org/2353033005/). This change allows using RtcEventLog in the p2p/ directory, so that we can log STUN pings and ICE state transitions. BUG=webrtc:6393 R=kjellander@webrtc.org, kwiberg@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, terelius@webrtc.org Review URL: https://codereview.webrtc.org/2380683005 . Cr-Commit-Position: refs/heads/master@{#14485}
2016-10-03 18:31:22 -07:00
}
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
rtc_source_set("rtc_event_log_impl_output") {
sources = [
"rtc_event_log/output/rtc_event_log_output_file.cc",
"rtc_event_log/output/rtc_event_log_output_file.h",
]
deps = [
":rtc_event_log_api",
"../api:libjingle_logging_api",
"../rtc_base:checks",
"../rtc_base:rtc_base_approved",
]
if (!build_with_chromium && is_clang) {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
}
}
rtc_static_library("rtc_event_log_impl_base") {
Revert "Revert "GN rtc_* templates: Set default visibility to webrtc_root + "/*""" This reverts commit c73e1f437889d882cbf2987f7fb3a029a6150613. Reason for revert: The problem with failed deps in chrome content/renderer had already been fixed in https://webrtc-review.googlesource.com/c/src/+/38660 Original change's description: > Revert "GN rtc_* templates: Set default visibility to webrtc_root + "/*"" > > This reverts commit 588c548657b3ddf76e7b3f241263eef7f5799f16. > > Reason for revert: > > Breaks Chrome FYI: > > /b/c/b/Linux_Builder/src/buildtools/linux64/gn gen //out/Release --check > -> returned 1 > ERROR at //build/split_static_library.gni:12:5: Dependency not allowed. > static_library(target_name) { > ^---------------------------- > The item //content/renderer:renderer > can not depend on //third_party/webrtc/media:rtc_internal_video_codecs > because it is not in //third_party/webrtc/media:rtc_internal_video_codecs's visibility list: [ > //third_party/webrtc/* > //third_party/webrtc_overrides/* > ] > > https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.webrtc.fyi%2FLinux_Builder%2F23560%2F%2B%2Frecipes%2Fsteps%2Fgenerate_build_files%2F0%2Fstdout > > Original change's description: > > GN rtc_* templates: Set default visibility to webrtc_root + "/*" > > > > This means that by default, targets are visible to everything under > > the WebRTC root, but not visible to anything else. > > > > API targets are manually tagged with visibility "*", so that targets > > outside the WebRTC tree can see them. > > > > BUG=webrtc:8254 > > > > Change-Id: Icdbee6e0d22d93240ff2fb530c8f9dc48e351509 > > Reviewed-on: https://webrtc-review.googlesource.com/24140 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#21548} > > TBR=mbonadei@webrtc.org,kwiberg@webrtc.org > > Change-Id: I06620ce3d6f67482935c22efa231dd6cab91625a > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:8254 > Reviewed-on: https://webrtc-review.googlesource.com/38760 > Reviewed-by: Per Kjellander <perkj@webrtc.org> > Commit-Queue: Per Kjellander <perkj@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#21555} TBR=mbonadei@webrtc.org,kwiberg@webrtc.org,perkj@webrtc.org Change-Id: I6f720078ce21bd172e0a6471bae8c4c011e4a657 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:8254 Reviewed-on: https://webrtc-review.googlesource.com/38860 Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Per Kjellander <perkj@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21558}
2018-01-10 15:54:53 +00:00
visibility = [ "*" ]
Moved RtcEventLog files from call/ to logging/ The RtcEventLog headers need to be accessible from any place which needs logging, and the implementation needs access to data structures that are logged. After a discussion in the code review, we all agreed to move the RtcEventLog implementation into its own top level directory - which I called "logging/" in expectation that other types of logging may have similar requirements. The directory contains two main build targets - "rtc_event_log_api", which is just rtc_event_log.h, that has no external dependencies and can be used from anywhere, and "rtc_event_log_impl" which contains the rest of the implementation and has many dependencies (more in the future). The "api" target can be referenced from anywhere, while the "impl" target is only needed at the place of instantiation (currently Call, soon to be moved to PeerConnection by https://codereview.webrtc.org/2353033005/). This change allows using RtcEventLog in the p2p/ directory, so that we can log STUN pings and ICE state transitions. BUG=webrtc:6393 R=kjellander@webrtc.org, kwiberg@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, terelius@webrtc.org Review URL: https://codereview.webrtc.org/2380683005 . Cr-Commit-Position: refs/heads/master@{#14485}
2016-10-03 18:31:22 -07:00
sources = [
Support building WebRTC without audio and video. This CL makes the WebRTC more modular and allows the users to build WebRTC without audio and video(DataChannel only). The BUILD files in call/, logging/, media/ and pc/ are modified to support modular WebRTC. The dependencies on Call and RtcEventLog are removed from the PeerConnection. Instead of being created internally, they would be passed in by the PeerConnectionFactory. Add the CreateModularPeerConnectionFactory function which allow the users to create a PeerConnectionFactory with the modules they need. If the users want to build WebRTC without audio and video, they can pass in null pointers for modules they don't need. (MediaEngine, VideoEncoderFactory etc.) BUG=webrtc:7613 Review-Url: https://codereview.webrtc.org/2854123003 Cr-Commit-Position: refs/heads/master@{#18617}
2017-06-15 12:52:32 -07:00
"rtc_event_log/rtc_event_log_factory.cc",
"rtc_event_log/rtc_event_log_factory.h",
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
"rtc_event_log/rtc_event_log_impl.cc",
Moved RtcEventLog files from call/ to logging/ The RtcEventLog headers need to be accessible from any place which needs logging, and the implementation needs access to data structures that are logged. After a discussion in the code review, we all agreed to move the RtcEventLog implementation into its own top level directory - which I called "logging/" in expectation that other types of logging may have similar requirements. The directory contains two main build targets - "rtc_event_log_api", which is just rtc_event_log.h, that has no external dependencies and can be used from anywhere, and "rtc_event_log_impl" which contains the rest of the implementation and has many dependencies (more in the future). The "api" target can be referenced from anywhere, while the "impl" target is only needed at the place of instantiation (currently Call, soon to be moved to PeerConnection by https://codereview.webrtc.org/2353033005/). This change allows using RtcEventLog in the p2p/ directory, so that we can log STUN pings and ICE state transitions. BUG=webrtc:6393 R=kjellander@webrtc.org, kwiberg@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, terelius@webrtc.org Review URL: https://codereview.webrtc.org/2380683005 . Cr-Commit-Position: refs/heads/master@{#14485}
2016-10-03 18:31:22 -07:00
]
defines = []
deps = [
":rtc_event_log_api",
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
":rtc_event_log_impl_encoder",
":rtc_event_log_impl_output",
Fix circular dependencies between optional, array_view, and rtc_base. This splits things out of rtc_base and makes dependencies explicit. Bug: webrtc:6828 Change-Id: Id521896c3c43595349021c857bec216e429a0c8d Reviewed-on: https://webrtc-review.googlesource.com/32780 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21264}
2017-12-13 16:05:42 +01:00
"../rtc_base:checks",
Remove remains of webrtc/base All downstream code have been updated to the new location. In PRESUBMIT.py: * Remove webrtc/rtc_base from CPP_BLACKLIST * Add webrtc/rtc_base to LEGACY_API_DIRS Fix some duplicated paths in webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn BUG=webrtc:7634 TBR=kwiberg@webrtc.org Review-Url: https://codereview.webrtc.org/2976293002 Cr-Commit-Position: refs/heads/master@{#19094}
2017-07-19 10:40:47 -07:00
"../rtc_base:rtc_base_approved",
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
"../rtc_base:rtc_task_queue_api",
Reland of Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread ( https://codereview.webrtc.org/3007473002/ ) Original issue's description: > Revert of Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread (patchset #18 id:340001 of https://codereview.webrtc.org/3007473002/ ) > > Reason for revert: > Breaks google3 project. > > Original issue's description: > > Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread > > > > Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread. This will eventually allow us to run multiple log sessions on a single task-queue. > > > > BUG=webrtc:8142, webrtc:8143, webrtc:8145 > > > > Review-Url: https://codereview.webrtc.org/3007473002 > > Cr-Commit-Position: refs/heads/master@{#19666} > > Committed: https://chromium.googlesource.com/external/webrtc/+/f33cee7534f0469330b6b7aa57f84eec4b082598 TBR=terelius@webrtc.org,nisse@webrtc.org,charujain@webrtc.org NOPRESUBMIT=true NOTRY=True BUG=webrtc:8142, webrtc:8143, webrtc:8145 Review-Url: https://codereview.webrtc.org/3012783002 Cr-Commit-Position: refs/heads/master@{#19712}
2017-09-06 05:18:15 -07:00
"../rtc_base:sequenced_task_checker",
Moved RtcEventLog files from call/ to logging/ The RtcEventLog headers need to be accessible from any place which needs logging, and the implementation needs access to data structures that are logged. After a discussion in the code review, we all agreed to move the RtcEventLog implementation into its own top level directory - which I called "logging/" in expectation that other types of logging may have similar requirements. The directory contains two main build targets - "rtc_event_log_api", which is just rtc_event_log.h, that has no external dependencies and can be used from anywhere, and "rtc_event_log_impl" which contains the rest of the implementation and has many dependencies (more in the future). The "api" target can be referenced from anywhere, while the "impl" target is only needed at the place of instantiation (currently Call, soon to be moved to PeerConnection by https://codereview.webrtc.org/2353033005/). This change allows using RtcEventLog in the p2p/ directory, so that we can log STUN pings and ICE state transitions. BUG=webrtc:6393 R=kjellander@webrtc.org, kwiberg@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, terelius@webrtc.org Review URL: https://codereview.webrtc.org/2380683005 . Cr-Commit-Position: refs/heads/master@{#14485}
2016-10-03 18:31:22 -07:00
]
if (rtc_enable_protobuf) {
defines += [ "ENABLE_RTC_EVENT_LOG" ]
deps += [ ":rtc_event_log_proto" ]
}
Revert "Break up rtc_event_log_api to solve circular dependencies." This reverts commit 001546da953275c7a39eb220592b440c9b47d756. Reason for revert: breaks downstream projects. Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=phoglund@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org,pthatcher@google.com,pthatcher@webrtc.org,qingsi@google.com Change-Id: I82540eac176c4abfb7e50dc51671585b32a1bace No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://webrtc-review.googlesource.com/46581 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21823}
2018-01-31 09:39:23 +00:00
if (!build_with_chromium && is_clang) {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
}
Moved RtcEventLog files from call/ to logging/ The RtcEventLog headers need to be accessible from any place which needs logging, and the implementation needs access to data structures that are logged. After a discussion in the code review, we all agreed to move the RtcEventLog implementation into its own top level directory - which I called "logging/" in expectation that other types of logging may have similar requirements. The directory contains two main build targets - "rtc_event_log_api", which is just rtc_event_log.h, that has no external dependencies and can be used from anywhere, and "rtc_event_log_impl" which contains the rest of the implementation and has many dependencies (more in the future). The "api" target can be referenced from anywhere, while the "impl" target is only needed at the place of instantiation (currently Call, soon to be moved to PeerConnection by https://codereview.webrtc.org/2353033005/). This change allows using RtcEventLog in the p2p/ directory, so that we can log STUN pings and ICE state transitions. BUG=webrtc:6393 R=kjellander@webrtc.org, kwiberg@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, terelius@webrtc.org Review URL: https://codereview.webrtc.org/2380683005 . Cr-Commit-Position: refs/heads/master@{#14485}
2016-10-03 18:31:22 -07:00
}
if (rtc_enable_protobuf) {
proto_library("rtc_event_log_proto") {
sources = [
"rtc_event_log/rtc_event_log.proto",
]
Fixing WebRTC after moving from src/webrtc to src/ In https://webrtc-review.googlesource.com/c/src/+/1560 we moved WebRTC from src/webrtc to src/ (in order to preserve an healthy git history). This CL takes care of fixing header guards, #include paths, etc... NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true TBR=tommi@webrtc.org Bug: chromium:611808 Change-Id: Iea91618212bee0af16aa3f05071eab8f93706578 Reviewed-on: https://webrtc-review.googlesource.com/1561 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#19846}
2017-09-15 06:47:31 +02:00
proto_out_dir = "logging/rtc_event_log"
Moved RtcEventLog files from call/ to logging/ The RtcEventLog headers need to be accessible from any place which needs logging, and the implementation needs access to data structures that are logged. After a discussion in the code review, we all agreed to move the RtcEventLog implementation into its own top level directory - which I called "logging/" in expectation that other types of logging may have similar requirements. The directory contains two main build targets - "rtc_event_log_api", which is just rtc_event_log.h, that has no external dependencies and can be used from anywhere, and "rtc_event_log_impl" which contains the rest of the implementation and has many dependencies (more in the future). The "api" target can be referenced from anywhere, while the "impl" target is only needed at the place of instantiation (currently Call, soon to be moved to PeerConnection by https://codereview.webrtc.org/2353033005/). This change allows using RtcEventLog in the p2p/ directory, so that we can log STUN pings and ICE state transitions. BUG=webrtc:6393 R=kjellander@webrtc.org, kwiberg@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, terelius@webrtc.org Review URL: https://codereview.webrtc.org/2380683005 . Cr-Commit-Position: refs/heads/master@{#14485}
2016-10-03 18:31:22 -07:00
}
Reland "New protobuf format for event log."""" This reverts commit 6cfbc35ad7e6c64874c1e2dbd58b8d7c4ab3a679. Reason for revert: Fixing downstream projects. Original change's description: > Revert "Revert "Revert "New protobuf format for event log.""" > > This reverts commit ef8f42040367b3809295a007d7eeeff4526e1b39. > > Reason for revert: New problems with downstream project. > > Original change's description: > > Revert "Revert "New protobuf format for event log."" > > > > This reverts commit 546373fc66e24d041e8eb8ffd2fc522847d841d1. > > > > Reason for revert: Downstream project fixed. > > > > Original change's description: > > > Revert "New protobuf format for event log." > > > > > > This reverts commit 99463c14dbbc88732f0991cb30e7bbfcdaeb3cdc. > > > > > > Reason for revert: Speculative revert for downstream project breakage. > > > > > > Original change's description: > > > > New protobuf format for event log. > > > > > > > > Bug: webrtc:6295 > > > > Change-Id: Ie20a2808a4f076b05fb6195f4fed73215f6fd3b2 > > > > Reviewed-on: https://webrtc-review.googlesource.com/8880 > > > > Commit-Queue: Björn Terelius <terelius@webrtc.org> > > > > Reviewed-by: Per Kjellander <perkj@webrtc.org> > > > > Reviewed-by: Dino Radaković <dinor@webrtc.org> > > > > Cr-Commit-Position: refs/heads/master@{#21291} > > > > > > TBR=terelius@webrtc.org,perkj@webrtc.org,dinor@webrtc.org > > > > > > Change-Id: Ic319170a7a777002ca29248d102cb4e26966d5ae > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: webrtc:6295 > > > Reviewed-on: https://webrtc-review.googlesource.com/33400 > > > Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> > > > Commit-Queue: Rasmus Brandt <brandtr@webrtc.org> > > > Cr-Commit-Position: refs/heads/master@{#21292} > > > > TBR=brandtr@webrtc.org,terelius@webrtc.org,perkj@webrtc.org,dinor@webrtc.org > > > > Change-Id: I9e96e5007d0447e63178d47c7330488b2a8f2b6f > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: webrtc:6295 > > Reviewed-on: https://webrtc-review.googlesource.com/33440 > > Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> > > Commit-Queue: Rasmus Brandt <brandtr@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#21296} > > TBR=brandtr@webrtc.org,terelius@webrtc.org,perkj@webrtc.org,dinor@webrtc.org > > Change-Id: I4eb15c809f67af13ffa7b7df6eb06088af21f63f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:6295 > Reviewed-on: https://webrtc-review.googlesource.com/33480 > Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> > Commit-Queue: Rasmus Brandt <brandtr@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#21297} TBR=brandtr@webrtc.org,terelius@webrtc.org,perkj@webrtc.org,dinor@webrtc.org Change-Id: I7895575f2b6e4ec2c36296fe81a7596147158601 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:6295 Reviewed-on: https://webrtc-review.googlesource.com/33520 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21299}
2017-12-15 17:12:42 +01:00
proto_library("rtc_event_log2_proto") {
sources = [
"rtc_event_log/rtc_event_log2.proto",
]
proto_out_dir = "logging/rtc_event_log"
}
Moved RtcEventLog files from call/ to logging/ The RtcEventLog headers need to be accessible from any place which needs logging, and the implementation needs access to data structures that are logged. After a discussion in the code review, we all agreed to move the RtcEventLog implementation into its own top level directory - which I called "logging/" in expectation that other types of logging may have similar requirements. The directory contains two main build targets - "rtc_event_log_api", which is just rtc_event_log.h, that has no external dependencies and can be used from anywhere, and "rtc_event_log_impl" which contains the rest of the implementation and has many dependencies (more in the future). The "api" target can be referenced from anywhere, while the "impl" target is only needed at the place of instantiation (currently Call, soon to be moved to PeerConnection by https://codereview.webrtc.org/2353033005/). This change allows using RtcEventLog in the p2p/ directory, so that we can log STUN pings and ICE state transitions. BUG=webrtc:6393 R=kjellander@webrtc.org, kwiberg@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, terelius@webrtc.org Review URL: https://codereview.webrtc.org/2380683005 . Cr-Commit-Position: refs/heads/master@{#14485}
2016-10-03 18:31:22 -07:00
rtc_static_library("rtc_event_log_parser") {
sources = [
"rtc_event_log/rtc_event_log_parser.cc",
"rtc_event_log/rtc_event_log_parser.h",
]
Stop using public_deps in logging/. Bug: webrtc:8603 Change-Id: Id0df997620a27e47067e4b21e4e8db16aec90640 No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/30940 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21228}
2017-12-12 12:46:13 +01:00
deps = [
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
":rtc_event_bwe",
Reland "New protobuf format for event log."""" This reverts commit 6cfbc35ad7e6c64874c1e2dbd58b8d7c4ab3a679. Reason for revert: Fixing downstream projects. Original change's description: > Revert "Revert "Revert "New protobuf format for event log.""" > > This reverts commit ef8f42040367b3809295a007d7eeeff4526e1b39. > > Reason for revert: New problems with downstream project. > > Original change's description: > > Revert "Revert "New protobuf format for event log."" > > > > This reverts commit 546373fc66e24d041e8eb8ffd2fc522847d841d1. > > > > Reason for revert: Downstream project fixed. > > > > Original change's description: > > > Revert "New protobuf format for event log." > > > > > > This reverts commit 99463c14dbbc88732f0991cb30e7bbfcdaeb3cdc. > > > > > > Reason for revert: Speculative revert for downstream project breakage. > > > > > > Original change's description: > > > > New protobuf format for event log. > > > > > > > > Bug: webrtc:6295 > > > > Change-Id: Ie20a2808a4f076b05fb6195f4fed73215f6fd3b2 > > > > Reviewed-on: https://webrtc-review.googlesource.com/8880 > > > > Commit-Queue: Björn Terelius <terelius@webrtc.org> > > > > Reviewed-by: Per Kjellander <perkj@webrtc.org> > > > > Reviewed-by: Dino Radaković <dinor@webrtc.org> > > > > Cr-Commit-Position: refs/heads/master@{#21291} > > > > > > TBR=terelius@webrtc.org,perkj@webrtc.org,dinor@webrtc.org > > > > > > Change-Id: Ic319170a7a777002ca29248d102cb4e26966d5ae > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: webrtc:6295 > > > Reviewed-on: https://webrtc-review.googlesource.com/33400 > > > Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> > > > Commit-Queue: Rasmus Brandt <brandtr@webrtc.org> > > > Cr-Commit-Position: refs/heads/master@{#21292} > > > > TBR=brandtr@webrtc.org,terelius@webrtc.org,perkj@webrtc.org,dinor@webrtc.org > > > > Change-Id: I9e96e5007d0447e63178d47c7330488b2a8f2b6f > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: webrtc:6295 > > Reviewed-on: https://webrtc-review.googlesource.com/33440 > > Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> > > Commit-Queue: Rasmus Brandt <brandtr@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#21296} > > TBR=brandtr@webrtc.org,terelius@webrtc.org,perkj@webrtc.org,dinor@webrtc.org > > Change-Id: I4eb15c809f67af13ffa7b7df6eb06088af21f63f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:6295 > Reviewed-on: https://webrtc-review.googlesource.com/33480 > Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> > Commit-Queue: Rasmus Brandt <brandtr@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#21297} TBR=brandtr@webrtc.org,terelius@webrtc.org,perkj@webrtc.org,dinor@webrtc.org Change-Id: I7895575f2b6e4ec2c36296fe81a7596147158601 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:6295 Reviewed-on: https://webrtc-review.googlesource.com/33520 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21299}
2017-12-15 17:12:42 +01:00
":rtc_event_log2_proto",
Enable GN check for webrtc/logging BUG=webrtc:6828, webrtc:7257 NOTRY=True Review-Url: https://codereview.webrtc.org/2717903002 Cr-Commit-Position: refs/heads/master@{#17111}
2017-03-08 02:12:11 -08:00
":rtc_event_log_api",
Moved RtcEventLog files from call/ to logging/ The RtcEventLog headers need to be accessible from any place which needs logging, and the implementation needs access to data structures that are logged. After a discussion in the code review, we all agreed to move the RtcEventLog implementation into its own top level directory - which I called "logging/" in expectation that other types of logging may have similar requirements. The directory contains two main build targets - "rtc_event_log_api", which is just rtc_event_log.h, that has no external dependencies and can be used from anywhere, and "rtc_event_log_impl" which contains the rest of the implementation and has many dependencies (more in the future). The "api" target can be referenced from anywhere, while the "impl" target is only needed at the place of instantiation (currently Call, soon to be moved to PeerConnection by https://codereview.webrtc.org/2353033005/). This change allows using RtcEventLog in the p2p/ directory, so that we can log STUN pings and ICE state transitions. BUG=webrtc:6393 R=kjellander@webrtc.org, kwiberg@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, terelius@webrtc.org Review URL: https://codereview.webrtc.org/2380683005 . Cr-Commit-Position: refs/heads/master@{#14485}
2016-10-03 18:31:22 -07:00
":rtc_event_log_proto",
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
":rtc_stream_config",
Moved RtcEventLog files from call/ to logging/ The RtcEventLog headers need to be accessible from any place which needs logging, and the implementation needs access to data structures that are logged. After a discussion in the code review, we all agreed to move the RtcEventLog implementation into its own top level directory - which I called "logging/" in expectation that other types of logging may have similar requirements. The directory contains two main build targets - "rtc_event_log_api", which is just rtc_event_log.h, that has no external dependencies and can be used from anywhere, and "rtc_event_log_impl" which contains the rest of the implementation and has many dependencies (more in the future). The "api" target can be referenced from anywhere, while the "impl" target is only needed at the place of instantiation (currently Call, soon to be moved to PeerConnection by https://codereview.webrtc.org/2353033005/). This change allows using RtcEventLog in the p2p/ directory, so that we can log STUN pings and ICE state transitions. BUG=webrtc:6393 R=kjellander@webrtc.org, kwiberg@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, terelius@webrtc.org Review URL: https://codereview.webrtc.org/2380683005 . Cr-Commit-Position: refs/heads/master@{#14485}
2016-10-03 18:31:22 -07:00
"..:webrtc_common",
Stop using public_deps in logging/. Bug: webrtc:8603 Change-Id: Id0df997620a27e47067e4b21e4e8db16aec90640 No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/30940 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21228}
2017-12-12 12:46:13 +01:00
"../call:video_stream_api",
Resolve cyclic dependency between audio network adaptor and event log api BUG=webrtc:7257 Review-Url: https://codereview.webrtc.org/2745473003 Cr-Commit-Position: refs/heads/master@{#17565}
2017-04-06 05:59:10 -07:00
"../modules/audio_coding:audio_network_adaptor",
Resolve dependency between rtc_event_log_api and remote_bitrate_estimator BUG=webrtc:7257 Review-Url: https://codereview.webrtc.org/2800633004 Cr-Commit-Position: refs/heads/master@{#17638}
2017-04-11 00:49:44 -07:00
"../modules/remote_bitrate_estimator:remote_bitrate_estimator",
Stop using public_deps in modules/rtp_rtcp. TBR=phoglund@webrtc.org Bug: webrtc:8603 Change-Id: I86830df23db3f33a1a26098e639596bd3b86485a No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/29780 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21108}
2017-12-06 07:51:33 +01:00
"../modules/rtp_rtcp",
Stop using public_deps in logging/. Bug: webrtc:8603 Change-Id: Id0df997620a27e47067e4b21e4e8db16aec90640 No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/30940 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21228}
2017-12-12 12:46:13 +01:00
"../modules/rtp_rtcp:rtp_rtcp_format",
Fix circular dependencies between optional, array_view, and rtc_base. This splits things out of rtc_base and makes dependencies explicit. Bug: webrtc:6828 Change-Id: Id521896c3c43595349021c857bec216e429a0c8d Reviewed-on: https://webrtc-review.googlesource.com/32780 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21264}
2017-12-13 16:05:42 +01:00
"../rtc_base:checks",
Stop using public_deps in logging/. Bug: webrtc:8603 Change-Id: Id0df997620a27e47067e4b21e4e8db16aec90640 No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/30940 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21228}
2017-12-12 12:46:13 +01:00
"../rtc_base:protobuf_utils",
"../rtc_base:rtc_base_approved",
Moved RtcEventLog files from call/ to logging/ The RtcEventLog headers need to be accessible from any place which needs logging, and the implementation needs access to data structures that are logged. After a discussion in the code review, we all agreed to move the RtcEventLog implementation into its own top level directory - which I called "logging/" in expectation that other types of logging may have similar requirements. The directory contains two main build targets - "rtc_event_log_api", which is just rtc_event_log.h, that has no external dependencies and can be used from anywhere, and "rtc_event_log_impl" which contains the rest of the implementation and has many dependencies (more in the future). The "api" target can be referenced from anywhere, while the "impl" target is only needed at the place of instantiation (currently Call, soon to be moved to PeerConnection by https://codereview.webrtc.org/2353033005/). This change allows using RtcEventLog in the p2p/ directory, so that we can log STUN pings and ICE state transitions. BUG=webrtc:6393 R=kjellander@webrtc.org, kwiberg@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, terelius@webrtc.org Review URL: https://codereview.webrtc.org/2380683005 . Cr-Commit-Position: refs/heads/master@{#14485}
2016-10-03 18:31:22 -07:00
]
GN: Exclude suppressions of Chromium Clang warnings for Chromium builds. These suppressions are causing GN errors when Chromium targets are depending directly on WebRTC targets (needed for https://codereview.chromium.org/2413103004) BUG=webrtc:4256 NOTRY=True Review-Url: https://codereview.webrtc.org/2408133008 Cr-Commit-Position: refs/heads/master@{#14644}
2016-10-16 23:56:12 -07:00
if (!build_with_chromium && is_clang) {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
Moved RtcEventLog files from call/ to logging/ The RtcEventLog headers need to be accessible from any place which needs logging, and the implementation needs access to data structures that are logged. After a discussion in the code review, we all agreed to move the RtcEventLog implementation into its own top level directory - which I called "logging/" in expectation that other types of logging may have similar requirements. The directory contains two main build targets - "rtc_event_log_api", which is just rtc_event_log.h, that has no external dependencies and can be used from anywhere, and "rtc_event_log_impl" which contains the rest of the implementation and has many dependencies (more in the future). The "api" target can be referenced from anywhere, while the "impl" target is only needed at the place of instantiation (currently Call, soon to be moved to PeerConnection by https://codereview.webrtc.org/2353033005/). This change allows using RtcEventLog in the p2p/ directory, so that we can log STUN pings and ICE state transitions. BUG=webrtc:6393 R=kjellander@webrtc.org, kwiberg@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, terelius@webrtc.org Review URL: https://codereview.webrtc.org/2380683005 . Cr-Commit-Position: refs/heads/master@{#14485}
2016-10-03 18:31:22 -07:00
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
}
}
GN: Refactor so that WebRTC compiles with rtc_enable_protobuf=false. This is a first step towards it. I plan to refactor modules_unittests before continuing with this. BUG=webrtc:6626 NOTRY=True Review-Url: https://codereview.webrtc.org/2626163004 Cr-Commit-Position: refs/heads/master@{#16109}
2017-01-17 02:37:34 -08:00
if (rtc_include_tests) {
rtc_source_set("rtc_event_log_tests") {
testonly = true
Create RtcEventLogEncoderLegacy We're moving to an RtcEventLog interface that accepts std::unique_ptr<EventLog> and stores the event for encoding when encoding becomes necessary, rather than before. This will be useful while we maintain the legacy (current) encoding alongside the new encoding on which we're working. This CL introduces RtcEventLogEncoderLegacy, which takes provides the encoding currently done by RtcEventLogImpl. After this, we can modify RtcEventLogImpl to use a dynamically chosen encoding, allowing us to easily choose between the current encoding and the new one on which we're working. BUG=webrtc:8111 TBR=stefan@webrtc.org Change-Id: I3dde7e222a40a117549a094a59b04219467f490a Reviewed-on: https://webrtc-review.googlesource.com/1364 Commit-Queue: Elad Alon <eladalon@webrtc.org> Reviewed-by: Elad Alon <eladalon@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20116}
2017-10-03 15:01:03 +02:00
assert(rtc_enable_protobuf)
defines = [ "ENABLE_RTC_EVENT_LOG" ]
Reintroduce WritingToInactiveFileForbidden and DisallowUnreasonableFileSizeLimits Both tests failed the linux_memchecks trybot, and so were removed. This attempts to reintroduce them. Bug: webrtc:8111 Change-Id: I32c49cb1b2af16d80e6f32258501ab79535700c0 Reviewed-on: https://webrtc-review.googlesource.com/6285 Commit-Queue: Elad Alon <eladalon@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20169}
2017-10-05 15:27:29 +02:00
if (rtc_use_memcheck) {
defines += [ "WEBRTC_USE_MEMCHECK" ]
}
GN: Refactor so that WebRTC compiles with rtc_enable_protobuf=false. This is a first step towards it. I plan to refactor modules_unittests before continuing with this. BUG=webrtc:6626 NOTRY=True Review-Url: https://codereview.webrtc.org/2626163004 Cr-Commit-Position: refs/heads/master@{#16109}
2017-01-17 02:37:34 -08:00
sources = [
Create RtcEventLogEncoderLegacy We're moving to an RtcEventLog interface that accepts std::unique_ptr<EventLog> and stores the event for encoding when encoding becomes necessary, rather than before. This will be useful while we maintain the legacy (current) encoding alongside the new encoding on which we're working. This CL introduces RtcEventLogEncoderLegacy, which takes provides the encoding currently done by RtcEventLogImpl. After this, we can modify RtcEventLogImpl to use a dynamically chosen encoding, allowing us to easily choose between the current encoding and the new one on which we're working. BUG=webrtc:8111 TBR=stefan@webrtc.org Change-Id: I3dde7e222a40a117549a094a59b04219467f490a Reviewed-on: https://webrtc-review.googlesource.com/1364 Commit-Queue: Elad Alon <eladalon@webrtc.org> Reviewed-by: Elad Alon <eladalon@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20116}
2017-10-03 15:01:03 +02:00
"rtc_event_log/encoder/rtc_event_log_encoder_unittest.cc",
Create and use RtcEventLogOutput for output We need to support two modes of writing to the output: 1. Current way - the application lets lets WebRTC know which file to write to, and WebRTC is then in charge of the writing. 2. New way - the application would receive indications from WebRTC about (encoded) RTC events, and would itself be in charge of processing them (be it writing it to a file, uploading it somewhere, etc.). We achieve this by creating an interface for output - RtcEventLogOutput. By providing an instance of the subclass, RtcEventLogOutputFile, the old behavior is achieved. The subclass of the new behavior is to be added by a later CL. TBR=stefan@webrtc.org Bug: webrtc:8111 Change-Id: I9c50521a7f7144d86d8353a65995795862e19c44 Reviewed-on: https://webrtc-review.googlesource.com/2686 Commit-Queue: Elad Alon <eladalon@webrtc.org> Reviewed-by: Elad Alon <eladalon@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20135}
2017-10-04 13:18:26 +02:00
"rtc_event_log/output/rtc_event_log_output_file_unittest.cc",
GN: Refactor so that WebRTC compiles with rtc_enable_protobuf=false. This is a first step towards it. I plan to refactor modules_unittests before continuing with this. BUG=webrtc:6626 NOTRY=True Review-Url: https://codereview.webrtc.org/2626163004 Cr-Commit-Position: refs/heads/master@{#16109}
2017-01-17 02:37:34 -08:00
"rtc_event_log/rtc_event_log_unittest.cc",
"rtc_event_log/rtc_event_log_unittest_helper.cc",
Add rtc_event_log_unittest_helper.h to relevant BUILD.gn BUG=None Review-Url: https://codereview.webrtc.org/3002813002 Cr-Commit-Position: refs/heads/master@{#19389}
2017-08-17 08:32:39 -07:00
"rtc_event_log/rtc_event_log_unittest_helper.h",
GN: Refactor so that WebRTC compiles with rtc_enable_protobuf=false. This is a first step towards it. I plan to refactor modules_unittests before continuing with this. BUG=webrtc:6626 NOTRY=True Review-Url: https://codereview.webrtc.org/2626163004 Cr-Commit-Position: refs/heads/master@{#16109}
2017-01-17 02:37:34 -08:00
]
deps = [
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
":rtc_event_audio",
":rtc_event_bwe",
Stop using public_deps in logging/. Bug: webrtc:8603 Change-Id: Id0df997620a27e47067e4b21e4e8db16aec90640 No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/30940 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21228}
2017-12-12 12:46:13 +01:00
":rtc_event_log_api",
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
":rtc_event_log_impl_base",
":rtc_event_log_impl_encoder",
":rtc_event_log_impl_output",
GN: Refactor so that WebRTC compiles with rtc_enable_protobuf=false. This is a first step towards it. I plan to refactor modules_unittests before continuing with this. BUG=webrtc:6626 NOTRY=True Review-Url: https://codereview.webrtc.org/2626163004 Cr-Commit-Position: refs/heads/master@{#16109}
2017-01-17 02:37:34 -08:00
":rtc_event_log_parser",
Stop using public_deps in logging/. Bug: webrtc:8603 Change-Id: Id0df997620a27e47067e4b21e4e8db16aec90640 No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/30940 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21228}
2017-12-12 12:46:13 +01:00
":rtc_event_log_proto",
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
":rtc_event_rtp_rtcp",
":rtc_event_video",
":rtc_stream_config",
Stop using public_deps in the call module. Bug: webrtc:8603 Change-Id: I048127bc86f213e638e6814ac8a86761cb8a64db Reviewed-on: https://webrtc-review.googlesource.com/28624 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21072}
2017-12-04 10:50:51 +01:00
"../api:libjingle_peerconnection_api",
GN: Refactor so that WebRTC compiles with rtc_enable_protobuf=false. This is a first step towards it. I plan to refactor modules_unittests before continuing with this. BUG=webrtc:6626 NOTRY=True Review-Url: https://codereview.webrtc.org/2626163004 Cr-Commit-Position: refs/heads/master@{#16109}
2017-01-17 02:37:34 -08:00
"../call",
Stop using public_deps in the call module. Bug: webrtc:8603 Change-Id: I048127bc86f213e638e6814ac8a86761cb8a64db Reviewed-on: https://webrtc-review.googlesource.com/28624 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21072}
2017-12-04 10:50:51 +01:00
"../call:call_interfaces",
Resolve cyclic dependency between audio network adaptor and event log api BUG=webrtc:7257 Review-Url: https://codereview.webrtc.org/2745473003 Cr-Commit-Position: refs/heads/master@{#17565}
2017-04-06 05:59:10 -07:00
"../modules/audio_coding:audio_network_adaptor",
Resolve dependency between rtc_event_log_api and remote_bitrate_estimator BUG=webrtc:7257 Review-Url: https://codereview.webrtc.org/2800633004 Cr-Commit-Position: refs/heads/master@{#17638}
2017-04-11 00:49:44 -07:00
"../modules/remote_bitrate_estimator:remote_bitrate_estimator",
Stop using public_deps in modules/rtp_rtcp. TBR=phoglund@webrtc.org Bug: webrtc:8603 Change-Id: I86830df23db3f33a1a26098e639596bd3b86485a No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/29780 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21108}
2017-12-06 07:51:33 +01:00
"../modules/rtp_rtcp:rtp_rtcp_format",
Fix circular dependencies between optional, array_view, and rtc_base. This splits things out of rtc_base and makes dependencies explicit. Bug: webrtc:6828 Change-Id: Id521896c3c43595349021c857bec216e429a0c8d Reviewed-on: https://webrtc-review.googlesource.com/32780 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21264}
2017-12-13 16:05:42 +01:00
"../rtc_base:checks",
Remove remains of webrtc/base All downstream code have been updated to the new location. In PRESUBMIT.py: * Remove webrtc/rtc_base from CPP_BLACKLIST * Add webrtc/rtc_base to LEGACY_API_DIRS Fix some duplicated paths in webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn BUG=webrtc:7634 TBR=kwiberg@webrtc.org Review-Url: https://codereview.webrtc.org/2976293002 Cr-Commit-Position: refs/heads/master@{#19094}
2017-07-19 10:40:47 -07:00
"../rtc_base:rtc_base_approved",
"../rtc_base:rtc_base_tests_utils",
Enable GN check for webrtc/logging BUG=webrtc:6828, webrtc:7257 NOTRY=True Review-Url: https://codereview.webrtc.org/2717903002 Cr-Commit-Position: refs/heads/master@{#17111}
2017-03-08 02:12:11 -08:00
"../test:test_support",
GN: Refactor so that WebRTC compiles with rtc_enable_protobuf=false. This is a first step towards it. I plan to refactor modules_unittests before continuing with this. BUG=webrtc:6626 NOTRY=True Review-Url: https://codereview.webrtc.org/2626163004 Cr-Commit-Position: refs/heads/master@{#16109}
2017-01-17 02:37:34 -08:00
"//testing/gtest",
]
if (!build_with_chromium && is_clang) {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
}
}
Added gn target for rtc_event_log2rtp_dump. BUG=webrtc:6191 Review-Url: https://codereview.webrtc.org/2629353004 Cr-Commit-Position: refs/heads/master@{#16483}
2017-02-08 00:28:09 -08:00
rtc_test("rtc_event_log2rtp_dump") {
testonly = true
sources = [
"rtc_event_log/rtc_event_log2rtp_dump.cc",
]
deps = [
":rtc_event_log_api",
":rtc_event_log_parser",
Stop using public_deps in logging/. Bug: webrtc:8603 Change-Id: Id0df997620a27e47067e4b21e4e8db16aec90640 No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/30940 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21228}
2017-12-12 12:46:13 +01:00
"../modules/rtp_rtcp",
Stop using public_deps in modules/rtp_rtcp. TBR=phoglund@webrtc.org Bug: webrtc:8603 Change-Id: I86830df23db3f33a1a26098e639596bd3b86485a No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/29780 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21108}
2017-12-06 07:51:33 +01:00
"../modules/rtp_rtcp:rtp_rtcp_format",
Fix circular dependencies between optional, array_view, and rtc_base. This splits things out of rtc_base and makes dependencies explicit. Bug: webrtc:6828 Change-Id: Id521896c3c43595349021c857bec216e429a0c8d Reviewed-on: https://webrtc-review.googlesource.com/32780 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21264}
2017-12-13 16:05:42 +01:00
"../rtc_base:checks",
Stop using public_deps in logging/. Bug: webrtc:8603 Change-Id: Id0df997620a27e47067e4b21e4e8db16aec90640 No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/30940 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21228}
2017-12-12 12:46:13 +01:00
"../rtc_base:protobuf_utils",
Remove remains of webrtc/base All downstream code have been updated to the new location. In PRESUBMIT.py: * Remove webrtc/rtc_base from CPP_BLACKLIST * Add webrtc/rtc_base to LEGACY_API_DIRS Fix some duplicated paths in webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn BUG=webrtc:7634 TBR=kwiberg@webrtc.org Review-Url: https://codereview.webrtc.org/2976293002 Cr-Commit-Position: refs/heads/master@{#19094}
2017-07-19 10:40:47 -07:00
"../rtc_base:rtc_base_approved",
Added gn target for rtc_event_log2rtp_dump. BUG=webrtc:6191 Review-Url: https://codereview.webrtc.org/2629353004 Cr-Commit-Position: refs/heads/master@{#16483}
2017-02-08 00:28:09 -08:00
"../system_wrappers:field_trial_default",
"../system_wrappers:metrics_default",
"../test:rtp_test_utils",
]
if (!build_with_chromium && is_clang) {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
}
}
GN: Refactor so that WebRTC compiles with rtc_enable_protobuf=false. This is a first step towards it. I plan to refactor modules_unittests before continuing with this. BUG=webrtc:6626 NOTRY=True Review-Url: https://codereview.webrtc.org/2626163004 Cr-Commit-Position: refs/heads/master@{#16109}
2017-01-17 02:37:34 -08:00
}
Reland: Add mock_rtc_event_log.h. Bug: webrtc:7642 Change-Id: I3f97a8b603e34819e1563b335c1eeb51f89b11ac Reviewed-on: https://webrtc-review.googlesource.com/37081 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21480}
2018-01-03 09:08:20 +01:00
New tool for printing basic packet information from an RTC event log to stdout. BUG=webrtc:7118 Review-Url: https://codereview.webrtc.org/2673403002 Cr-Commit-Position: refs/heads/master@{#16488}
2017-02-08 04:22:53 -08:00
if (rtc_include_tests) {
rtc_executable("rtc_event_log2text") {
testonly = true
sources = [
"rtc_event_log/rtc_event_log2text.cc",
]
deps = [
":rtc_event_log_api",
":rtc_event_log_parser",
Stop using public_deps in logging/. Bug: webrtc:8603 Change-Id: Id0df997620a27e47067e4b21e4e8db16aec90640 No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/30940 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21228}
2017-12-12 12:46:13 +01:00
"../:webrtc_common",
Move RtpExtension to api/ directory and config.h/.cc to call/. BUG=webrtc:5876 R=deadbeef@webrtc.org, solenberg@webrtc.org Review-Url: https://codereview.webrtc.org/3004723002 . Cr-Commit-Position: refs/heads/master@{#19639}
2017-09-01 15:29:28 +02:00
"../call:video_stream_api",
Stop using public_deps in modules/rtp_rtcp. TBR=phoglund@webrtc.org Bug: webrtc:8603 Change-Id: I86830df23db3f33a1a26098e639596bd3b86485a No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/29780 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21108}
2017-12-06 07:51:33 +01:00
"../modules/rtp_rtcp:rtp_rtcp_format",
Fix circular dependencies between optional, array_view, and rtc_base. This splits things out of rtc_base and makes dependencies explicit. Bug: webrtc:6828 Change-Id: Id521896c3c43595349021c857bec216e429a0c8d Reviewed-on: https://webrtc-review.googlesource.com/32780 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21264}
2017-12-13 16:05:42 +01:00
"../rtc_base:checks",
Stop using public_deps in logging/. Bug: webrtc:8603 Change-Id: Id0df997620a27e47067e4b21e4e8db16aec90640 No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/30940 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21228}
2017-12-12 12:46:13 +01:00
"../rtc_base:protobuf_utils",
Remove remains of webrtc/base All downstream code have been updated to the new location. In PRESUBMIT.py: * Remove webrtc/rtc_base from CPP_BLACKLIST * Add webrtc/rtc_base to LEGACY_API_DIRS Fix some duplicated paths in webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn BUG=webrtc:7634 TBR=kwiberg@webrtc.org Review-Url: https://codereview.webrtc.org/2976293002 Cr-Commit-Position: refs/heads/master@{#19094}
2017-07-19 10:40:47 -07:00
"../rtc_base:rtc_base_approved",
Add option to print information about configured SSRCs from RTC event logs. BUG=webrtc:7118 Review-Url: https://codereview.webrtc.org/2686823002 Cr-Commit-Position: refs/heads/master@{#16500}
2017-02-08 09:37:30 -08:00
# TODO(kwiberg): Remove this dependency.
Move AudioDecoder and related stuff to the api/ directory BUG=webrtc:5805, webrtc:6725 Review-Url: https://codereview.webrtc.org/2668523004 Cr-Commit-Position: refs/heads/master@{#16534}
2017-02-10 08:15:44 -08:00
"../api/audio_codecs:audio_codecs_api",
Make rtc_event_log2text handle all events [2/2] rtc_event_log2text doesn't currently handle all possible RtcEvent-s. 1. Previous CL - to make sure events are not forgotten in the future, change the succession of if-statements to a switch, so that the compiler would complain if events are ever added, but are not handled here. 2. This CL - add handling of currently-unhandled events. BUG=webrtc:8111 Change-Id: I5c726c077483b5d85cf8060674c8191a90cb84cc Reviewed-on: https://webrtc-review.googlesource.com/1244 Reviewed-by: Björn Terelius <terelius@webrtc.org> Commit-Queue: Elad Alon <eladalon@webrtc.org> Cr-Commit-Position: refs/heads/master@{#19869}
2017-09-15 16:13:21 +02:00
"../modules/audio_coding:audio_network_adaptor_config",
Stop using public_deps in modules/rtp_rtcp. TBR=phoglund@webrtc.org Bug: webrtc:8603 Change-Id: I86830df23db3f33a1a26098e639596bd3b86485a No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/29780 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21108}
2017-12-06 07:51:33 +01:00
"../modules/rtp_rtcp",
New tool for printing basic packet information from an RTC event log to stdout. BUG=webrtc:7118 Review-Url: https://codereview.webrtc.org/2673403002 Cr-Commit-Position: refs/heads/master@{#16488}
2017-02-08 04:22:53 -08:00
]
if (!build_with_chromium && is_clang) {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
}
}
}
Create tool to print statistics about the file size usage of an RTC event log. BUG=webrtc:7502 Review-Url: https://codereview.webrtc.org/2717553004 Cr-Commit-Position: refs/heads/master@{#17932}
2017-04-28 07:48:17 -07:00
if (rtc_include_tests) {
rtc_executable("rtc_event_log2stats") {
testonly = true
sources = [
"rtc_event_log/rtc_event_log2stats.cc",
]
deps = [
":rtc_event_log_api",
":rtc_event_log_proto",
Fix circular dependencies between optional, array_view, and rtc_base. This splits things out of rtc_base and makes dependencies explicit. Bug: webrtc:6828 Change-Id: Id521896c3c43595349021c857bec216e429a0c8d Reviewed-on: https://webrtc-review.googlesource.com/32780 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21264}
2017-12-13 16:05:42 +01:00
"../rtc_base:checks",
Remove remains of webrtc/base All downstream code have been updated to the new location. In PRESUBMIT.py: * Remove webrtc/rtc_base from CPP_BLACKLIST * Add webrtc/rtc_base to LEGACY_API_DIRS Fix some duplicated paths in webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn BUG=webrtc:7634 TBR=kwiberg@webrtc.org Review-Url: https://codereview.webrtc.org/2976293002 Cr-Commit-Position: refs/heads/master@{#19094}
2017-07-19 10:40:47 -07:00
"../rtc_base:rtc_base_approved",
Create tool to print statistics about the file size usage of an RTC event log. BUG=webrtc:7502 Review-Url: https://codereview.webrtc.org/2717553004 Cr-Commit-Position: refs/heads/master@{#17932}
2017-04-28 07:48:17 -07:00
]
if (!build_with_chromium && is_clang) {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
}
}
}
Moved RtcEventLog files from call/ to logging/ The RtcEventLog headers need to be accessible from any place which needs logging, and the implementation needs access to data structures that are logged. After a discussion in the code review, we all agreed to move the RtcEventLog implementation into its own top level directory - which I called "logging/" in expectation that other types of logging may have similar requirements. The directory contains two main build targets - "rtc_event_log_api", which is just rtc_event_log.h, that has no external dependencies and can be used from anywhere, and "rtc_event_log_impl" which contains the rest of the implementation and has many dependencies (more in the future). The "api" target can be referenced from anywhere, while the "impl" target is only needed at the place of instantiation (currently Call, soon to be moved to PeerConnection by https://codereview.webrtc.org/2353033005/). This change allows using RtcEventLog in the p2p/ directory, so that we can log STUN pings and ICE state transitions. BUG=webrtc:6393 R=kjellander@webrtc.org, kwiberg@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, terelius@webrtc.org Review URL: https://codereview.webrtc.org/2380683005 . Cr-Commit-Position: refs/heads/master@{#14485}
2016-10-03 18:31:22 -07:00
}
Reland: Add mock_rtc_event_log.h. Bug: webrtc:7642 Change-Id: I3f97a8b603e34819e1563b335c1eeb51f89b11ac Reviewed-on: https://webrtc-review.googlesource.com/37081 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21480}
2018-01-03 09:08:20 +01:00
if (rtc_include_tests) {
rtc_source_set("mocks") {
testonly = true
sources = [
"rtc_event_log/mock/mock_rtc_event_log.h",
]
deps = [
":rtc_event_log_api",
"../../test:test_support",
]
}
}
Reference in New Issue Copy Permalink