2014-05-13 18:00:26 +00:00
|
|
|
/*
|
|
|
|
|
* Copyright 2004 The WebRTC Project Authors. All rights reserved.
|
|
|
|
|
*
|
|
|
|
|
* Use of this source code is governed by a BSD-style license
|
|
|
|
|
* that can be found in the LICENSE file in the root of the source
|
|
|
|
|
* tree. An additional intellectual property rights grant can be found
|
|
|
|
|
* in the file PATENTS. All contributing project authors may
|
|
|
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
|
|
|
*/
|
|
|
|
|
|
2015-04-30 14:16:07 +02:00
|
|
|
#ifndef WEBRTC_BASE_CRITICALSECTION_H_
|
|
|
|
|
#define WEBRTC_BASE_CRITICALSECTION_H_
|
2014-05-13 18:00:26 +00:00
|
|
|
|
2015-04-30 14:16:07 +02:00
|
|
|
#include "webrtc/base/atomicops.h"
|
2014-05-13 18:00:26 +00:00
|
|
|
#include "webrtc/base/constructormagic.h"
|
2014-09-24 07:10:57 +00:00
|
|
|
#include "webrtc/base/thread_annotations.h"
|
2016-01-22 05:13:33 -08:00
|
|
|
#include "webrtc/base/platform_thread_types.h"
|
2014-05-13 18:00:26 +00:00
|
|
|
|
|
|
|
|
#if defined(WEBRTC_WIN)
|
2015-03-04 20:09:37 +00:00
|
|
|
// Include winsock2.h before including <windows.h> to maintain consistency with
|
|
|
|
|
// win32.h. We can't include win32.h directly here since it pulls in
|
|
|
|
|
// headers such as basictypes.h which causes problems in Chromium where webrtc
|
|
|
|
|
// exists as two separate projects, webrtc and libjingle.
|
|
|
|
|
#include <winsock2.h>
|
|
|
|
|
#include <windows.h>
|
2015-04-27 17:39:23 +02:00
|
|
|
#include <sal.h> // must come after windows headers.
|
|
|
|
|
#endif // defined(WEBRTC_WIN)
|
2014-05-13 18:00:26 +00:00
|
|
|
|
|
|
|
|
#if defined(WEBRTC_POSIX)
|
|
|
|
|
#include <pthread.h>
|
|
|
|
|
#endif
|
|
|
|
|
|
2016-01-21 23:47:25 -08:00
|
|
|
// See notes in the 'Performance' unit test for the effects of this flag.
|
|
|
|
|
#define USE_NATIVE_MUTEX_ON_MAC 0
|
|
|
|
|
|
|
|
|
|
#if defined(WEBRTC_MAC) && !USE_NATIVE_MUTEX_ON_MAC
|
|
|
|
|
#include <dispatch/dispatch.h>
|
|
|
|
|
#endif
|
|
|
|
|
|
Revert of Test RTC_DCHECK_IS_ON instead of checking DCHECK_ALWAYS_ON everywhere (patchset #2 id:20001 of https://codereview.webrtc.org/2384693002/ )
Reason for revert:
This CL breaks FYI bots with a compile error.
Sample error:
jingle/glue/thread_wrapper.cc -o obj/jingle/jingle_glue/thread_wrapper.o
In file included from ../../jingle/glue/thread_wrapper.cc:5:
In file included from ../../jingle/glue/thread_wrapper.h:16:
In file included from ../../base/message_loop/message_loop.h:17:
In file included from ../../base/memory/ref_counted.h:19:
../../base/logging.h:598:1: error: call to 'MakeCheckOpString' is ambiguous
DEFINE_CHECK_OP_IMPL(EQ, ==)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../base/logging.h:592:17: note: expanded from macro 'DEFINE_CHECK_OP_IMPL'
else return MakeCheckOpString(v1, v2, names); \
^~~~~~~~~~~~~~~~~
../../jingle/glue/thread_wrapper.cc:46:3: note: in instantiation of function template specialization 'logging::CheckEQImpl<rtc::Thread *, jingle_glue::JingleThreadWrapper *>' requested here
DCHECK_EQ(rtc::Thread::Current(), current());
^
../../base/logging.h:748:31: note: expanded from macro 'DCHECK_EQ'
#define DCHECK_EQ(val1, val2) DCHECK_OP(EQ, ==, val1, val2)
^
../../base/logging.h:721:18: note: expanded from macro 'DCHECK_OP'
::logging::Check##name##Impl((val1), (val2), \
^
<scratch space>:102:1: note: expanded from here
CheckEQImpl
^
../../base/logging.h:555:14: note: candidate function [with t1 = rtc::Thread *, t2 = jingle_glue::JingleThreadWrapper *]
std::string* MakeCheckOpString(const t1& v1, const t2& v2, const char* names) {
^
../../third_party/webrtc/base/checks.h:122:14: note: candidate function [with t1 = rtc::Thread *, t2 = jingle_glue::JingleThreadWrapper *]
std::string* MakeCheckOpString(const t1& v1, const t2& v2, const char* names) {
^
In file included from ../../jingle/glue/thread_wrapper.cc:5:
In file included from ../../jingle/glue/thread_wrapper.h:16:
In file included from ../../base/message_loop/message_loop.h:17:
In file included from ../../base/memory/ref_counted.h:19:
../../base/logging.h:598:1: error: call to 'MakeCheckOpString' is ambiguous
DEFINE_CHECK_OP_IMPL(EQ, ==)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../base/logging.h:592:17: note: expanded from macro 'DEFINE_CHECK_OP_IMPL'
else return MakeCheckOpString(v1, v2, names); \
^~~~~~~~~~~~~~~~~
../../jingle/glue/thread_wrapper.cc:81:3: note: in instantiation of function template specialization 'logging::CheckEQImpl<jingle_glue::JingleThreadWrapper *, jingle_glue::JingleThreadWrapper *>' requested here
DCHECK_EQ(this, JingleThreadWrapper::current());
^
../../base/logging.h:748:31: note: expanded from macro 'DCHECK_EQ'
#define DCHECK_EQ(val1, val2) DCHECK_OP(EQ, ==, val1, val2)
^
../../base/logging.h:721:18: note: expanded from macro 'DCHECK_OP'
::logging::Check##name##Impl((val1), (val2), \
^
<scratch space>:5:1: note: expanded from here
CheckEQImpl
^
../../base/logging.h:555:14: note: candidate function [with t1 = jingle_glue::JingleThreadWrapper *, t2 = jingle_glue::JingleThreadWrapper *]
std::string* MakeCheckOpString(const t1& v1, const t2& v2, const char* names) {
^
../../third_party/webrtc/base/checks.h:122:14: note: candidate function [with t1 = jingle_glue::JingleThreadWrapper *, t2 = jingle_glue::JingleThreadWrapper *]
std::string* MakeCheckOpString(const t1& v1, const t2& v2, const char* names) {
^
In file included from ../../jingle/glue/thread_wrapper.cc:5:
In file included from ../../jingle/glue/thread_wrapper.h:16:
In file included from ../../base/message_loop/message_loop.h:17:
In file included from ../../base/memory/ref_counted.h:19:
../../base/logging.h:598:1: error: call to 'MakeCheckOpString' is ambiguous
DEFINE_CHECK_OP_IMPL(EQ, ==)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../base/logging.h:592:17: note: expanded from macro 'DEFINE_CHECK_OP_IMPL'
else return MakeCheckOpString(v1, v2, names); \
^~~~~~~~~~~~~~~~~
../../jingle/glue/thread_wrapper.cc:82:3: note: in instantiation of function template specialization 'logging::CheckEQImpl<jingle_glue::JingleThreadWrapper *, rtc::Thread *>' requested here
DCHECK_EQ(this, rtc::Thread::Current());
^
../../base/logging.h:748:31: note: expanded from macro 'DCHECK_EQ'
#define DCHECK_EQ(val1, val2) DCHECK_OP(EQ, ==, val1, val2)
^
../../base/logging.h:721:18: note: expanded from macro 'DCHECK_OP'
::logging::Check##name##Impl((val1), (val2), \
^
<scratch space>:12:1: note: expanded from here
CheckEQImpl
^
../../base/logging.h:555:14: note: candidate function [with t1 = jingle_glue::JingleThreadWrapper *, t2 = rtc::Thread *]
std::string* MakeCheckOpString(const t1& v1, const t2& v2, const char* names) {
^
../../third_party/webrtc/base/checks.h:122:14: note: candidate function [with t1 = jingle_glue::JingleThreadWrapper *, t2 = rtc::Thread *]
std::string* MakeCheckOpString(const t1& v1, const t2& v2, const char* names) {
^
3 errors generated.
Original issue's description:
> Test RTC_DCHECK_IS_ON instead of checking DCHECK_ALWAYS_ON everywhere
>
> The former is always defined (by webrtc/base/checks.h) to either 0 or
> 1, whereas the latter isn't necessarily defined.
>
> NOTRY=true
> BUG=webrtc:6451
>
> Committed: https://crrev.com/ab0b929321d37669165d5795268fa10a8c97ec5b
> Cr-Commit-Position: refs/heads/master@{#14474}
TBR=ossu@webrtc.org,kwiberg@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:6451
Review-Url: https://codereview.webrtc.org/2384083004
Cr-Commit-Position: refs/heads/master@{#14480}
2016-10-03 08:32:31 -07:00
|
|
|
#if (!defined(NDEBUG) || defined(DCHECK_ALWAYS_ON))
|
|
|
|
|
#define CS_DEBUG_CHECKS 1
|
|
|
|
|
#else
|
|
|
|
|
#define CS_DEBUG_CHECKS 0
|
|
|
|
|
#endif
|
2014-05-13 18:00:26 +00:00
|
|
|
|
2015-04-27 17:39:23 +02:00
|
|
|
#if CS_DEBUG_CHECKS
|
|
|
|
|
#define CS_DEBUG_CODE(x) x
|
|
|
|
|
#else // !CS_DEBUG_CHECKS
|
|
|
|
|
#define CS_DEBUG_CODE(x)
|
|
|
|
|
#endif // !CS_DEBUG_CHECKS
|
2014-05-13 18:00:26 +00:00
|
|
|
|
|
|
|
|
namespace rtc {
|
|
|
|
|
|
2016-01-21 16:56:52 +01:00
|
|
|
// Locking methods (Enter, TryEnter, Leave)are const to permit protecting
|
|
|
|
|
// members inside a const context without requiring mutable CriticalSections
|
|
|
|
|
// everywhere.
|
2014-09-24 07:10:57 +00:00
|
|
|
class LOCKABLE CriticalSection {
|
2014-05-13 18:00:26 +00:00
|
|
|
public:
|
2015-04-27 17:39:23 +02:00
|
|
|
CriticalSection();
|
|
|
|
|
~CriticalSection();
|
2014-05-13 18:00:26 +00:00
|
|
|
|
2016-01-21 16:56:52 +01:00
|
|
|
void Enter() const EXCLUSIVE_LOCK_FUNCTION();
|
|
|
|
|
bool TryEnter() const EXCLUSIVE_TRYLOCK_FUNCTION(true);
|
|
|
|
|
void Leave() const UNLOCK_FUNCTION();
|
2014-05-13 18:00:26 +00:00
|
|
|
|
2016-07-08 02:45:40 -07:00
|
|
|
private:
|
2015-09-17 00:24:34 -07:00
|
|
|
// Use only for RTC_DCHECKing.
|
2015-04-27 17:39:23 +02:00
|
|
|
bool CurrentThreadIsOwner() const;
|
2014-05-13 18:00:26 +00:00
|
|
|
|
2015-04-27 17:39:23 +02:00
|
|
|
#if defined(WEBRTC_WIN)
|
2016-01-21 16:56:52 +01:00
|
|
|
mutable CRITICAL_SECTION crit_;
|
2015-04-27 17:39:23 +02:00
|
|
|
#elif defined(WEBRTC_POSIX)
|
2016-01-21 23:47:25 -08:00
|
|
|
#if defined(WEBRTC_MAC) && !USE_NATIVE_MUTEX_ON_MAC
|
|
|
|
|
// Number of times the lock has been locked + number of threads waiting.
|
|
|
|
|
// TODO(tommi): We could use this number and subtract the recursion count
|
|
|
|
|
// to find places where we have multiple threads contending on the same lock.
|
|
|
|
|
mutable volatile int lock_queue_;
|
|
|
|
|
// |recursion_| represents the recursion count + 1 for the thread that owns
|
|
|
|
|
// the lock. Only modified by the thread that owns the lock.
|
|
|
|
|
mutable int recursion_;
|
|
|
|
|
// Used to signal a single waiting thread when the lock becomes available.
|
|
|
|
|
mutable dispatch_semaphore_t semaphore_;
|
|
|
|
|
// The thread that currently holds the lock. Required to handle recursion.
|
2016-01-22 05:13:33 -08:00
|
|
|
mutable PlatformThreadRef owning_thread_;
|
2016-01-21 23:47:25 -08:00
|
|
|
#else
|
2016-01-21 16:56:52 +01:00
|
|
|
mutable pthread_mutex_t mutex_;
|
2016-01-21 23:47:25 -08:00
|
|
|
#endif
|
2016-01-22 05:13:33 -08:00
|
|
|
CS_DEBUG_CODE(mutable PlatformThreadRef thread_);
|
2016-01-21 16:56:52 +01:00
|
|
|
CS_DEBUG_CODE(mutable int recursion_count_);
|
2015-04-27 17:39:23 +02:00
|
|
|
#endif
|
2014-05-13 18:00:26 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
|
|
// CritScope, for serializing execution through a scope.
|
2014-09-24 07:10:57 +00:00
|
|
|
class SCOPED_LOCKABLE CritScope {
|
2014-05-13 18:00:26 +00:00
|
|
|
public:
|
2016-01-21 16:56:52 +01:00
|
|
|
explicit CritScope(const CriticalSection* cs) EXCLUSIVE_LOCK_FUNCTION(cs);
|
2015-04-27 17:39:23 +02:00
|
|
|
~CritScope() UNLOCK_FUNCTION();
|
2014-05-13 18:00:26 +00:00
|
|
|
private:
|
2016-01-21 16:56:52 +01:00
|
|
|
const CriticalSection* const cs_;
|
2015-09-16 05:37:44 -07:00
|
|
|
RTC_DISALLOW_COPY_AND_ASSIGN(CritScope);
|
2014-05-13 18:00:26 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
|
|
// Tries to lock a critical section on construction via
|
|
|
|
|
// CriticalSection::TryEnter, and unlocks on destruction if the
|
|
|
|
|
// lock was taken. Never blocks.
|
|
|
|
|
//
|
|
|
|
|
// IMPORTANT: Unlike CritScope, the lock may not be owned by this thread in
|
|
|
|
|
// subsequent code. Users *must* check locked() to determine if the
|
|
|
|
|
// lock was taken. If you're not calling locked(), you're doing it wrong!
|
|
|
|
|
class TryCritScope {
|
|
|
|
|
public:
|
2016-01-21 16:56:52 +01:00
|
|
|
explicit TryCritScope(const CriticalSection* cs);
|
2015-04-27 17:39:23 +02:00
|
|
|
~TryCritScope();
|
|
|
|
|
#if defined(WEBRTC_WIN)
|
|
|
|
|
_Check_return_ bool locked() const;
|
|
|
|
|
#else
|
2016-01-08 04:51:38 -08:00
|
|
|
bool locked() const __attribute__ ((__warn_unused_result__));
|
2015-04-27 17:39:23 +02:00
|
|
|
#endif
|
2014-05-13 18:00:26 +00:00
|
|
|
private:
|
2016-01-21 16:56:52 +01:00
|
|
|
const CriticalSection* const cs_;
|
2015-04-27 17:39:23 +02:00
|
|
|
const bool locked_;
|
|
|
|
|
CS_DEBUG_CODE(mutable bool lock_was_called_);
|
2015-09-16 05:37:44 -07:00
|
|
|
RTC_DISALLOW_COPY_AND_ASSIGN(TryCritScope);
|
2014-05-13 18:00:26 +00:00
|
|
|
};
|
|
|
|
|
|
2015-03-26 14:38:46 -07:00
|
|
|
// A POD lock used to protect global variables. Do NOT use for other purposes.
|
|
|
|
|
// No custom constructor or private data member should be added.
|
|
|
|
|
class LOCKABLE GlobalLockPod {
|
|
|
|
|
public:
|
|
|
|
|
void Lock() EXCLUSIVE_LOCK_FUNCTION();
|
|
|
|
|
|
|
|
|
|
void Unlock() UNLOCK_FUNCTION();
|
|
|
|
|
|
2015-12-07 14:29:14 -08:00
|
|
|
volatile int lock_acquired;
|
2015-03-26 14:38:46 -07:00
|
|
|
};
|
|
|
|
|
|
2015-11-17 03:21:02 -08:00
|
|
|
class GlobalLock : public GlobalLockPod {
|
|
|
|
|
public:
|
|
|
|
|
GlobalLock();
|
|
|
|
|
};
|
2015-03-26 14:38:46 -07:00
|
|
|
|
2015-05-27 23:41:43 +02:00
|
|
|
// GlobalLockScope, for serializing execution through a scope.
|
|
|
|
|
class SCOPED_LOCKABLE GlobalLockScope {
|
|
|
|
|
public:
|
|
|
|
|
explicit GlobalLockScope(GlobalLockPod* lock) EXCLUSIVE_LOCK_FUNCTION(lock);
|
|
|
|
|
~GlobalLockScope() UNLOCK_FUNCTION();
|
|
|
|
|
private:
|
|
|
|
|
GlobalLockPod* const lock_;
|
2015-09-16 05:37:44 -07:00
|
|
|
RTC_DISALLOW_COPY_AND_ASSIGN(GlobalLockScope);
|
2015-05-27 23:41:43 +02:00
|
|
|
};
|
|
|
|
|
|
2014-05-13 18:00:26 +00:00
|
|
|
} // namespace rtc
|
|
|
|
|
|
2015-04-30 14:16:07 +02:00
|
|
|
#endif // WEBRTC_BASE_CRITICALSECTION_H_
|