admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
webrtc_m130/examples/BUILD.gn

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

908 lines
29 KiB
Plaintext
Raw Normal View History

Add GN targets for AppRTC Demo on Android. Adds GN equivalents for following targets: AppRTCDemo -> //webrtc/examples:AppRTCDemo AppRTCDemo_apk -> //webrtc/examples:AppRTCDemo_lib (kind of) AppRTCDemoJUnitTest -> //webrtc/examples:AppRTCDemoJUnitTest AppRTCDemoTest -> //webrtc/examples:AppRTCDemoTest libjingle_peerconnection_java -> //webrtc/api/libjingle_peerconnection_java libjingle_peerconnection_so -> //webrtc/api/libjingle_peerconnection_so New GN targets: //webrtc/base:base_java //webrtc/examples:AppRTCDemo_resources //webrtc/examples/androidapp/third_party/autobanh:autobanh_java BUG=webrtc:6035 R=magjed@webrtc.org, tommi@webrtc.org Review URL: https://codereview.webrtc.org/2105803002 . Cr-Commit-Position: refs/heads/master@{#13322}
2016-06-29 14:55:00 +02:00
# Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
#
# Use of this source code is governed by a BSD-style license
# that can be found in the LICENSE file in the root of the source
# tree. An additional intellectual property rights grant can be found
# in the file PATENTS. All contributing project authors may
# be found in the AUTHORS file in the root of the source tree.
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
import("../webrtc.gni")
Reland: Add Alpha Channel Support For WebRTC Unity Plugin This CL make webrtc unity plugin compatible with alpha channel support. TBR=gyzhou@chromium.org,magjed@webrtc.org Bug: webrtc:8645 Change-Id: Ic1c11f8c82f8244b84b8ab67c623ad2002b940e8 Reviewed-on: https://webrtc-review.googlesource.com/35421 Reviewed-by: George Zhou <gyzhou@chromium.org> Reviewed-by: Qiang Chen <qiangchen@chromium.org> Commit-Queue: Qiang Chen <qiangchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#21398}
2017-12-20 10:47:36 -08:00
Add GN targets for AppRTC Demo on Android. Adds GN equivalents for following targets: AppRTCDemo -> //webrtc/examples:AppRTCDemo AppRTCDemo_apk -> //webrtc/examples:AppRTCDemo_lib (kind of) AppRTCDemoJUnitTest -> //webrtc/examples:AppRTCDemoJUnitTest AppRTCDemoTest -> //webrtc/examples:AppRTCDemoTest libjingle_peerconnection_java -> //webrtc/api/libjingle_peerconnection_java libjingle_peerconnection_so -> //webrtc/api/libjingle_peerconnection_so New GN targets: //webrtc/base:base_java //webrtc/examples:AppRTCDemo_resources //webrtc/examples/androidapp/third_party/autobanh:autobanh_java BUG=webrtc:6035 R=magjed@webrtc.org, tommi@webrtc.org Review URL: https://codereview.webrtc.org/2105803002 . Cr-Commit-Position: refs/heads/master@{#13322}
2016-06-29 14:55:00 +02:00
if (is_android) {
import("//build/config/android/config.gni")
import("//build/config/android/rules.gni")
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
} else if (is_mac) {
import("//build/config/mac/rules.gni")
} else if (is_ios) {
import("//build/config/ios/rules.gni")
Add GN targets for AppRTC Demo on Android. Adds GN equivalents for following targets: AppRTCDemo -> //webrtc/examples:AppRTCDemo AppRTCDemo_apk -> //webrtc/examples:AppRTCDemo_lib (kind of) AppRTCDemoJUnitTest -> //webrtc/examples:AppRTCDemoJUnitTest AppRTCDemoTest -> //webrtc/examples:AppRTCDemoTest libjingle_peerconnection_java -> //webrtc/api/libjingle_peerconnection_java libjingle_peerconnection_so -> //webrtc/api/libjingle_peerconnection_so New GN targets: //webrtc/base:base_java //webrtc/examples:AppRTCDemo_resources //webrtc/examples/androidapp/third_party/autobanh:autobanh_java BUG=webrtc:6035 R=magjed@webrtc.org, tommi@webrtc.org Review URL: https://codereview.webrtc.org/2105803002 . Cr-Commit-Position: refs/heads/master@{#13322}
2016-06-29 14:55:00 +02:00
}
group("examples") {
GN: New conventions, default target and refactorings Introduce a convention on categorizing GN targets: 1. Production code 2. Tests 3. Examples 4. Tools The first two have targets spread out all over the tree, while the latter are isolated to examples/ and tools/ directories. Another new convention: Each directory's BUILD.gn file shall contain a target named similar to the directory name. This target shall contain the 'most common' production code, i.e. so that most consumers of the directory can depend on only the directory (which implicitly means that target in GN). //webrtc:webrtc_tests is changed to depend on all WebRTC tests. From now on, it's necessary to add new test targets to this dependency tree in order to get them compiled. Two new group targets are created: //webrtc/modules/audio_coding:audio_coding_tests //webrtc/modules/audio_processing:audio_processing_tests to reduce the long list of tests in //webrtc:webrtc_tests. Visibility on //webrtc:webrtc and //webrtc:webrtc_tests is restricted to the root target, to avoid circular dependencies due to the monolithic property of these targets (a problem we've had in the past). The 'root' target at the top level is renamed to 'default', which means GN will build this target instead of _all_ generated targets (see https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/faq.md#Can-I-control-what-targets-are-built-by-default). This target now depends on everything we want to build, meaning all targets now explicitly needs to be wired up from the root target in order to get build. Having this, the number of compiled objects on Android is decreased from 8855 to 6276. It also gives us better control over our build. BUG=webrtc:6440 TESTED=git cl try --clobber NOTRY=True Review-Url: https://codereview.webrtc.org/2441383002 Cr-Commit-Position: refs/heads/master@{#14821}
2016-10-28 05:44:03 -07:00
# This target shall build all targets in examples.
testonly = true
Stop using public_deps in examples. Bug: webrtc:8603 Change-Id: I1c25055109825c97e3d571efd07de79aa8c503b5 Reviewed-on: https://webrtc-review.googlesource.com/29863 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21278}
2017-12-14 13:06:10 +01:00
deps = []
Add GN targets for AppRTC Demo on Android. Adds GN equivalents for following targets: AppRTCDemo -> //webrtc/examples:AppRTCDemo AppRTCDemo_apk -> //webrtc/examples:AppRTCDemo_lib (kind of) AppRTCDemoJUnitTest -> //webrtc/examples:AppRTCDemoJUnitTest AppRTCDemoTest -> //webrtc/examples:AppRTCDemoTest libjingle_peerconnection_java -> //webrtc/api/libjingle_peerconnection_java libjingle_peerconnection_so -> //webrtc/api/libjingle_peerconnection_so New GN targets: //webrtc/base:base_java //webrtc/examples:AppRTCDemo_resources //webrtc/examples/androidapp/third_party/autobanh:autobanh_java BUG=webrtc:6035 R=magjed@webrtc.org, tommi@webrtc.org Review URL: https://codereview.webrtc.org/2105803002 . Cr-Commit-Position: refs/heads/master@{#13322}
2016-06-29 14:55:00 +02:00
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
if (is_android) {
Stop using public_deps in examples. Bug: webrtc:8603 Change-Id: I1c25055109825c97e3d571efd07de79aa8c503b5 Reviewed-on: https://webrtc-review.googlesource.com/29863 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21278}
2017-12-14 13:06:10 +01:00
deps += [
GN: New conventions, default target and refactorings Introduce a convention on categorizing GN targets: 1. Production code 2. Tests 3. Examples 4. Tools The first two have targets spread out all over the tree, while the latter are isolated to examples/ and tools/ directories. Another new convention: Each directory's BUILD.gn file shall contain a target named similar to the directory name. This target shall contain the 'most common' production code, i.e. so that most consumers of the directory can depend on only the directory (which implicitly means that target in GN). //webrtc:webrtc_tests is changed to depend on all WebRTC tests. From now on, it's necessary to add new test targets to this dependency tree in order to get them compiled. Two new group targets are created: //webrtc/modules/audio_coding:audio_coding_tests //webrtc/modules/audio_processing:audio_processing_tests to reduce the long list of tests in //webrtc:webrtc_tests. Visibility on //webrtc:webrtc and //webrtc:webrtc_tests is restricted to the root target, to avoid circular dependencies due to the monolithic property of these targets (a problem we've had in the past). The 'root' target at the top level is renamed to 'default', which means GN will build this target instead of _all_ generated targets (see https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/faq.md#Can-I-control-what-targets-are-built-by-default). This target now depends on everything we want to build, meaning all targets now explicitly needs to be wired up from the root target in order to get build. Having this, the number of compiled objects on Android is decreased from 8855 to 6276. It also gives us better control over our build. BUG=webrtc:6440 TESTED=git cl try --clobber NOTRY=True Review-Url: https://codereview.webrtc.org/2441383002 Cr-Commit-Position: refs/heads/master@{#14821}
2016-10-28 05:44:03 -07:00
":AppRTCMobile",
Rename rtc_instrumentation_test_apk targets to end with _test_apk. This matches Chromium pattern of naming instrumentation test apks with a name ending in _test_apk. The old naming confuses generate_gradle.py. Renames: - AppRTCMobileTest -> AppRTCMobile_test_apk - AppRTCMobileTestStubbedVideoIO -> AppRTCMobile_stubbed_video_io_test_apk - libjingle_peerconnection_android_unittest -> android_instrumentation_test_apk Bug: webrtc:9588 TBR: phoglund Change-Id: Idb82dc4bd089bc7c90e9373f7c3d572f9fd2d95a Reviewed-on: https://webrtc-review.googlesource.com/92380 Commit-Queue: Sami Kalliomäki <sakal@webrtc.org> Reviewed-by: Oleh Prypin <oprypin@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24184}
2018-08-03 13:23:05 +02:00
":AppRTCMobile_test_apk",
Synced webrtc_unity_plugin to the latest webrtc and fixed bugs. 1, Let targets libwebrtc_unity and webrtc_unity_plugin built with Ninja -C out/***. 2, Fixed compile issue of libwebrtc_unity. 3, Built libwebrtc_unity classes into Java 7 instead of Java 8 for android. 4, Added an interface to enable peerconnectionFactory for android in Unity. Bug: webrtc:8986 Change-Id: I2a206a77ab38895ec9ac845ce89507d61076d396 Reviewed-on: https://webrtc-review.googlesource.com/59000 Reviewed-by: Qiang Chen <qiangchen@chromium.org> Commit-Queue: George Zhou <gyzhou@chromium.org> Cr-Commit-Position: refs/heads/master@{#22373}
2018-03-07 09:58:54 -08:00
":libwebrtc_unity",
Implemented Android Demo Application for VoIP API The app showcased the ability to send real-time voice data between two endpoints using the VoIP API. Users can also configure session parameters such as the endpoint information and codec used. Bug: webrtc:11723 Change-Id: I682f4aa743b707759536bce59e598789a77b7ec6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178467 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Sami Kalliomäki <sakal@webrtc.org> Reviewed-by: Tim Na <natim@webrtc.org> Commit-Queue: Tim Na <natim@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31775}
2020-07-20 17:52:12 -04:00
"androidvoip",
GN: New conventions, default target and refactorings Introduce a convention on categorizing GN targets: 1. Production code 2. Tests 3. Examples 4. Tools The first two have targets spread out all over the tree, while the latter are isolated to examples/ and tools/ directories. Another new convention: Each directory's BUILD.gn file shall contain a target named similar to the directory name. This target shall contain the 'most common' production code, i.e. so that most consumers of the directory can depend on only the directory (which implicitly means that target in GN). //webrtc:webrtc_tests is changed to depend on all WebRTC tests. From now on, it's necessary to add new test targets to this dependency tree in order to get them compiled. Two new group targets are created: //webrtc/modules/audio_coding:audio_coding_tests //webrtc/modules/audio_processing:audio_processing_tests to reduce the long list of tests in //webrtc:webrtc_tests. Visibility on //webrtc:webrtc and //webrtc:webrtc_tests is restricted to the root target, to avoid circular dependencies due to the monolithic property of these targets (a problem we've had in the past). The 'root' target at the top level is renamed to 'default', which means GN will build this target instead of _all_ generated targets (see https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/faq.md#Can-I-control-what-targets-are-built-by-default). This target now depends on everything we want to build, meaning all targets now explicitly needs to be wired up from the root target in order to get build. Having this, the number of compiled objects on Android is decreased from 8855 to 6276. It also gives us better control over our build. BUG=webrtc:6440 TESTED=git cl try --clobber NOTRY=True Review-Url: https://codereview.webrtc.org/2441383002 Cr-Commit-Position: refs/heads/master@{#14821}
2016-10-28 05:44:03 -07:00
]
Add an example app for Android native API. The app is a simple loopback demo demonstrating the usage of Android native API. This is an initial version and I will add support for HW codecs etc. in the future. Bug: webrtc:8769 Change-Id: Ifb6209769dabeb8ca3185b969a1ef8afd6d84390 Reviewed-on: https://webrtc-review.googlesource.com/60540 Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Commit-Queue: Sami Kalliomäki <sakal@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22385}
2018-03-08 16:43:16 +01:00
# TODO(sakal): We include some code from the tests. Remove this dependency
# and remove this if-clause.
if (rtc_include_tests) {
Cleanup BUILD.gn files from imports like foo:foo Repalce all occurrences of foo:foo in deps with just foo in BUILD.gn files. Done with Sublime regex replace. Find: \b([-a-zA-Z0-9_]+):+\1\b In: *.gn Replace with: \1 Bug: None Change-Id: I40aba1b14face687a595b852ffe443cb20197611 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127899 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27225}
2019-03-21 13:35:10 +01:00
deps += [ "androidnativeapi" ]
Add an example app for Android native API. The app is a simple loopback demo demonstrating the usage of Android native API. This is an initial version and I will add support for HW codecs etc. in the future. Bug: webrtc:8769 Change-Id: Ifb6209769dabeb8ca3185b969a1ef8afd6d84390 Reviewed-on: https://webrtc-review.googlesource.com/60540 Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Commit-Queue: Sami Kalliomäki <sakal@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22385}
2018-03-08 16:43:16 +01:00
}
GN: New conventions, default target and refactorings Introduce a convention on categorizing GN targets: 1. Production code 2. Tests 3. Examples 4. Tools The first two have targets spread out all over the tree, while the latter are isolated to examples/ and tools/ directories. Another new convention: Each directory's BUILD.gn file shall contain a target named similar to the directory name. This target shall contain the 'most common' production code, i.e. so that most consumers of the directory can depend on only the directory (which implicitly means that target in GN). //webrtc:webrtc_tests is changed to depend on all WebRTC tests. From now on, it's necessary to add new test targets to this dependency tree in order to get them compiled. Two new group targets are created: //webrtc/modules/audio_coding:audio_coding_tests //webrtc/modules/audio_processing:audio_processing_tests to reduce the long list of tests in //webrtc:webrtc_tests. Visibility on //webrtc:webrtc and //webrtc:webrtc_tests is restricted to the root target, to avoid circular dependencies due to the monolithic property of these targets (a problem we've had in the past). The 'root' target at the top level is renamed to 'default', which means GN will build this target instead of _all_ generated targets (see https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/faq.md#Can-I-control-what-targets-are-built-by-default). This target now depends on everything we want to build, meaning all targets now explicitly needs to be wired up from the root target in order to get build. Having this, the number of compiled objects on Android is decreased from 8855 to 6276. It also gives us better control over our build. BUG=webrtc:6440 TESTED=git cl try --clobber NOTRY=True Review-Url: https://codereview.webrtc.org/2441383002 Cr-Commit-Position: refs/heads/master@{#14821}
2016-10-28 05:44:03 -07:00
}
Moving stun_prober target from webrtc/p2p to webrtc/examples BUG=webrtc:6440 NOTRY=True Review-Url: https://codereview.webrtc.org/2460343002 Cr-Commit-Position: refs/heads/master@{#14869}
2016-11-01 03:09:15 -07:00
if (!build_with_chromium) {
Stop using public_deps in examples. Bug: webrtc:8603 Change-Id: I1c25055109825c97e3d571efd07de79aa8c503b5 Reviewed-on: https://webrtc-review.googlesource.com/29863 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21278}
2017-12-14 13:06:10 +01:00
deps += [ ":stun_prober" ]
Moving stun_prober target from webrtc/p2p to webrtc/examples BUG=webrtc:6440 NOTRY=True Review-Url: https://codereview.webrtc.org/2460343002 Cr-Commit-Position: refs/heads/master@{#14869}
2016-11-01 03:09:15 -07:00
}
GN: New conventions, default target and refactorings Introduce a convention on categorizing GN targets: 1. Production code 2. Tests 3. Examples 4. Tools The first two have targets spread out all over the tree, while the latter are isolated to examples/ and tools/ directories. Another new convention: Each directory's BUILD.gn file shall contain a target named similar to the directory name. This target shall contain the 'most common' production code, i.e. so that most consumers of the directory can depend on only the directory (which implicitly means that target in GN). //webrtc:webrtc_tests is changed to depend on all WebRTC tests. From now on, it's necessary to add new test targets to this dependency tree in order to get them compiled. Two new group targets are created: //webrtc/modules/audio_coding:audio_coding_tests //webrtc/modules/audio_processing:audio_processing_tests to reduce the long list of tests in //webrtc:webrtc_tests. Visibility on //webrtc:webrtc and //webrtc:webrtc_tests is restricted to the root target, to avoid circular dependencies due to the monolithic property of these targets (a problem we've had in the past). The 'root' target at the top level is renamed to 'default', which means GN will build this target instead of _all_ generated targets (see https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/faq.md#Can-I-control-what-targets-are-built-by-default). This target now depends on everything we want to build, meaning all targets now explicitly needs to be wired up from the root target in order to get build. Having this, the number of compiled objects on Android is decreased from 8855 to 6276. It also gives us better control over our build. BUG=webrtc:6440 TESTED=git cl try --clobber NOTRY=True Review-Url: https://codereview.webrtc.org/2441383002 Cr-Commit-Position: refs/heads/master@{#14821}
2016-10-28 05:44:03 -07:00
if (is_ios || (is_mac && target_cpu != "x86")) {
Stop using public_deps in examples. Bug: webrtc:8603 Change-Id: I1c25055109825c97e3d571efd07de79aa8c503b5 Reviewed-on: https://webrtc-review.googlesource.com/29863 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21278}
2017-12-14 13:06:10 +01:00
deps += [ ":AppRTCMobile" ]
Add GN targets for AppRTC Demo on Android. Adds GN equivalents for following targets: AppRTCDemo -> //webrtc/examples:AppRTCDemo AppRTCDemo_apk -> //webrtc/examples:AppRTCDemo_lib (kind of) AppRTCDemoJUnitTest -> //webrtc/examples:AppRTCDemoJUnitTest AppRTCDemoTest -> //webrtc/examples:AppRTCDemoTest libjingle_peerconnection_java -> //webrtc/api/libjingle_peerconnection_java libjingle_peerconnection_so -> //webrtc/api/libjingle_peerconnection_so New GN targets: //webrtc/base:base_java //webrtc/examples:AppRTCDemo_resources //webrtc/examples/androidapp/third_party/autobanh:autobanh_java BUG=webrtc:6035 R=magjed@webrtc.org, tommi@webrtc.org Review URL: https://codereview.webrtc.org/2105803002 . Cr-Commit-Position: refs/heads/master@{#13322}
2016-06-29 14:55:00 +02:00
}
GN: New conventions, default target and refactorings Introduce a convention on categorizing GN targets: 1. Production code 2. Tests 3. Examples 4. Tools The first two have targets spread out all over the tree, while the latter are isolated to examples/ and tools/ directories. Another new convention: Each directory's BUILD.gn file shall contain a target named similar to the directory name. This target shall contain the 'most common' production code, i.e. so that most consumers of the directory can depend on only the directory (which implicitly means that target in GN). //webrtc:webrtc_tests is changed to depend on all WebRTC tests. From now on, it's necessary to add new test targets to this dependency tree in order to get them compiled. Two new group targets are created: //webrtc/modules/audio_coding:audio_coding_tests //webrtc/modules/audio_processing:audio_processing_tests to reduce the long list of tests in //webrtc:webrtc_tests. Visibility on //webrtc:webrtc and //webrtc:webrtc_tests is restricted to the root target, to avoid circular dependencies due to the monolithic property of these targets (a problem we've had in the past). The 'root' target at the top level is renamed to 'default', which means GN will build this target instead of _all_ generated targets (see https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/faq.md#Can-I-control-what-targets-are-built-by-default). This target now depends on everything we want to build, meaning all targets now explicitly needs to be wired up from the root target in order to get build. Having this, the number of compiled objects on Android is decreased from 8855 to 6276. It also gives us better control over our build. BUG=webrtc:6440 TESTED=git cl try --clobber NOTRY=True Review-Url: https://codereview.webrtc.org/2441383002 Cr-Commit-Position: refs/heads/master@{#14821}
2016-10-28 05:44:03 -07:00
Expand is_linux to is_linux || is_chromeos. Currently is_linux is set to true on Chrome OS build, but it is planned to be set false. This CL is the preparation to keep the compatibility. Bug: chromium:1110266 Test: Build locally. Change-Id: Ic79a202b0b3baeff157955cd03a07556bfb958a8 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/183860 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#32073}
2020-09-10 18:10:11 +09:00
if (is_linux || is_chromeos || is_win) {
Stop using public_deps in examples. Bug: webrtc:8603 Change-Id: I1c25055109825c97e3d571efd07de79aa8c503b5 Reviewed-on: https://webrtc-review.googlesource.com/29863 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21278}
2017-12-14 13:06:10 +01:00
deps += [
Create gn target for peerconnection examples BUG= Review-Url: https://codereview.webrtc.org/2218053002 Cr-Commit-Position: refs/heads/master@{#13673}
2016-08-08 09:03:23 -07:00
":peerconnection_server",
":stunserver",
":turnserver",
]
Adding WinUWP compilation support to WebRTC. Windows UWP allows an application to be built that targets across all Windows 10 based systems and the Windows store. Change-Id: I69694bb7e83fb01ad6db2438b065b55738cf01fd Bug: webrtc:10046 Reviewed-on: https://webrtc-review.googlesource.com/c/110570 Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25814}
2018-11-22 20:10:11 -05:00
if (current_os != "winuwp") {
deps += [ ":peerconnection_client" ]
}
Create gn target for peerconnection examples BUG= Review-Url: https://codereview.webrtc.org/2218053002 Cr-Commit-Position: refs/heads/master@{#13673}
2016-08-08 09:03:23 -07:00
}
Synced webrtc_unity_plugin to the latest webrtc and fixed bugs. 1, Let targets libwebrtc_unity and webrtc_unity_plugin built with Ninja -C out/***. 2, Fixed compile issue of libwebrtc_unity. 3, Built libwebrtc_unity classes into Java 7 instead of Java 8 for android. 4, Added an interface to enable peerconnectionFactory for android in Unity. Bug: webrtc:8986 Change-Id: I2a206a77ab38895ec9ac845ce89507d61076d396 Reviewed-on: https://webrtc-review.googlesource.com/59000 Reviewed-by: Qiang Chen <qiangchen@chromium.org> Commit-Queue: George Zhou <gyzhou@chromium.org> Cr-Commit-Position: refs/heads/master@{#22373}
2018-03-07 09:58:54 -08:00
if (is_android || is_win) {
deps += [ ":webrtc_unity_plugin" ]
}
Add GN targets for AppRTC Demo on Android. Adds GN equivalents for following targets: AppRTCDemo -> //webrtc/examples:AppRTCDemo AppRTCDemo_apk -> //webrtc/examples:AppRTCDemo_lib (kind of) AppRTCDemoJUnitTest -> //webrtc/examples:AppRTCDemoJUnitTest AppRTCDemoTest -> //webrtc/examples:AppRTCDemoTest libjingle_peerconnection_java -> //webrtc/api/libjingle_peerconnection_java libjingle_peerconnection_so -> //webrtc/api/libjingle_peerconnection_so New GN targets: //webrtc/base:base_java //webrtc/examples:AppRTCDemo_resources //webrtc/examples/androidapp/third_party/autobanh:autobanh_java BUG=webrtc:6035 R=magjed@webrtc.org, tommi@webrtc.org Review URL: https://codereview.webrtc.org/2105803002 . Cr-Commit-Position: refs/heads/master@{#13322}
2016-06-29 14:55:00 +02:00
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("read_auth_file") {
Delete OptionsFile class. Refactored only user, TurnFileAuth. Bug: webrtc:6424 Change-Id: I4b74cd6197f2cb060d1aff70e3adadbdf7f7a580 Reviewed-on: https://webrtc-review.googlesource.com/c/108122 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25426}
2018-10-30 12:20:03 +01:00
testonly = true
sources = [
"turnserver/read_auth_file.cc",
"turnserver/read_auth_file.h",
]
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
deps = [ "../rtc_base" ]
Delete OptionsFile class. Refactored only user, TurnFileAuth. Bug: webrtc:6424 Change-Id: I4b74cd6197f2cb060d1aff70e3adadbdf7f7a580 Reviewed-on: https://webrtc-review.googlesource.com/c/108122 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25426}
2018-10-30 12:20:03 +01:00
}
if (rtc_include_tests) {
rtc_test("examples_unittests") {
testonly = true
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "turnserver/read_auth_file_unittest.cc" ]
Delete OptionsFile class. Refactored only user, TurnFileAuth. Bug: webrtc:6424 Change-Id: I4b74cd6197f2cb060d1aff70e3adadbdf7f7a580 Reviewed-on: https://webrtc-review.googlesource.com/c/108122 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25426}
2018-10-30 12:20:03 +01:00
deps = [
":read_auth_file",
"../test:test_main",
"//test:test_support",
"//testing/gtest",
]
}
}
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
if (is_android) {
Reland: "Make javac warnings errors for WebRTC targets." This reverts commit 2bad72a27329ff30ceb9479253f5eb3d21888d25. Reason for revert: Fixing downstream projects (take 2). Original change's description: > Reland "Revert "Make javac warnings errors for WebRTC targets."" > > This is a reland of 098d24c3c18f4b1fd043d7ba716d7601f0ce2b74 > Original change's description: > > Revert "Make javac warnings errors for WebRTC targets." > > > > This reverts commit 19b761403c3522902d69d61179f4d184e3632f79. > > > > Reason for revert: Breaking internal builds > > > > Original change's description: > > > Make javac warnings errors for WebRTC targets. > > > > > > Adds new rtc_* templates for Android targets to allow specifying > > > default values that affect WebRTC targets. > > > > > > Bug: webrtc:6597 > > > Change-Id: Ie529bfc8500d1e785b8a59dba7078b5f88ccfcd1 > > > Reviewed-on: https://webrtc-review.googlesource.com/15103 > > > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > > > Commit-Queue: Sami Kalliomäki <sakal@webrtc.org> > > > Cr-Commit-Position: refs/heads/master@{#20567} > > > TBR=phoglund@webrtc.org,sakal@webrtc.org > > > > Change-Id: I6d3ff5604b3d4307765d3a65adb783f89fcc974c > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: webrtc:6597 > > Reviewed-on: https://webrtc-review.googlesource.com/20740 > > Reviewed-by: Lu Liu <lliuu@webrtc.org> > > Commit-Queue: Lu Liu <lliuu@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#20571} > > Bug: webrtc:6597 > Change-Id: Icfb5ded46ce76b674bae67bfa02054b4ec52bb0f > Reviewed-on: https://webrtc-review.googlesource.com/20800 > Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org> > Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#20577} TBR=phoglund@webrtc.org,ehmaldonado@webrtc.org,mbonadei@webrtc.org,sakal@webrtc.org,lliuu@webrtc.org Change-Id: Id3713c1885318741711987ae642a269a9ca5bb85 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:6597 Reviewed-on: https://webrtc-review.googlesource.com/18441 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20588}
2017-11-07 15:36:33 +00:00
rtc_android_apk("AppRTCMobile") {
Reland "Enable GN check for webrtc/examples" This is a reland of https://codereview.webrtc.org/2714343002 with the errors related to inclusions of test targets in webrtc/api resolved. BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2733673002 Cr-Commit-Position: refs/heads/master@{#17053}
2017-03-06 00:29:21 -08:00
testonly = true
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
apk_name = "AppRTCMobile"
Add GN targets for AppRTC Demo on Android. Adds GN equivalents for following targets: AppRTCDemo -> //webrtc/examples:AppRTCDemo AppRTCDemo_apk -> //webrtc/examples:AppRTCDemo_lib (kind of) AppRTCDemoJUnitTest -> //webrtc/examples:AppRTCDemoJUnitTest AppRTCDemoTest -> //webrtc/examples:AppRTCDemoTest libjingle_peerconnection_java -> //webrtc/api/libjingle_peerconnection_java libjingle_peerconnection_so -> //webrtc/api/libjingle_peerconnection_so New GN targets: //webrtc/base:base_java //webrtc/examples:AppRTCDemo_resources //webrtc/examples/androidapp/third_party/autobanh:autobanh_java BUG=webrtc:6035 R=magjed@webrtc.org, tommi@webrtc.org Review URL: https://codereview.webrtc.org/2105803002 . Cr-Commit-Position: refs/heads/master@{#13322}
2016-06-29 14:55:00 +02:00
android_manifest = "androidapp/AndroidManifest.xml"
Roll chromium_revision 4d95e6c77b..71a0e1904e (776481:782339) Change log: https://chromium.googlesource.com/chromium/src/+log/4d95e6c77b..71a0e1904e Full diff: https://chromium.googlesource.com/chromium/src/+/4d95e6c77b..71a0e1904e Changed dependencies * src/base: https://chromium.googlesource.com/chromium/src/base/+log/2df7267880..736d9fb42c * src/build: https://chromium.googlesource.com/chromium/src/build/+log/a03951acb9..876a780600 * src/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/1b066f0216..1ed99573d5 * src/buildtools/linux64: git_revision:d0a6f072070988e7b038496c4e7d6c562b649732..git_revision:7d7e8deea36d126397bda2cf924682504271f0e1 * src/buildtools/mac: git_revision:d0a6f072070988e7b038496c4e7d6c562b649732..git_revision:7d7e8deea36d126397bda2cf924682504271f0e1 * src/buildtools/win: git_revision:d0a6f072070988e7b038496c4e7d6c562b649732..git_revision:7d7e8deea36d126397bda2cf924682504271f0e1 * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/9200aad36b..73c8bcb1b1 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/502600d41a..77ba7104d5 * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/e0df6e10ad..1908162da7 * src/third_party/android_deps/libs/androidx_activity_activity: version:1.0.0-cr0..version:1.1.0-cr0 * src/third_party/android_deps/libs/androidx_arch_core_core_runtime: version:2.0.0-cr0..version:2.1.0-cr0 * src/third_party/android_deps/libs/androidx_fragment_fragment: version:1.1.0-cr0..version:1.2.5-cr0 * src/third_party/android_deps/libs/androidx_lifecycle_lifecycle_common: version:2.1.0-cr0..version:2.2.0-cr0 * src/third_party/android_deps/libs/androidx_lifecycle_lifecycle_livedata_core: version:2.0.0-cr0..version:2.2.0-cr0 * src/third_party/android_deps/libs/androidx_lifecycle_lifecycle_runtime: version:2.1.0-cr0..version:2.2.0-cr0 * src/third_party/android_deps/libs/androidx_lifecycle_lifecycle_viewmodel: version:2.1.0-cr0..version:2.2.0-cr0 * src/third_party/android_deps/libs/androidx_preference_preference: version:1.0.0-cr0..version:1.1.1-cr0 * src/third_party/android_deps/libs/org_robolectric_shadows_multidex: version:4.3.1-cr0..version:4.3.1-cr1 * src/third_party/android_sdk/public: CR25ixsRhwuRnhdgDpGFyl9S0C_0HO9SUgFrwX46zq8C..uM0XtAW9BHh8phcbhBDA9GfzP3bku2SP7AiMahhimnoC * src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/88024df121..430a742303 * src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/2ad47493f8..e0658a4adf * src/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/37e562110f..87c8b91639 * src/third_party/espresso: c92dcfc4e894555a0b3c309f2b7939640eb1fee4..y8fIfH8Leo2cPm7iGCYnBxZpwOlgLv8rm2mlcmJlvGsC * src/third_party/ffmpeg: https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/be66dc5fd0..23b2a15c25 * src/third_party/freetype/src: https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/62fea391fa..a443474755 * src/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu.git/+log/630b884f84..79326efe26 * src/third_party/libaom/source/libaom: https://aomedia.googlesource.com/aom.git/+log/2aa13c436e..e1ebb418eb * src/third_party/libunwindstack: https://chromium.googlesource.com/chromium/src/third_party/libunwindstack.git/+log/046920fc49..11659d420a * src/third_party/libvpx/source/libvpx: https://chromium.googlesource.com/webm/libvpx.git/+log/c176557314..769129fb29 * src/third_party/perfetto: https://android.googlesource.com/platform/external/perfetto.git/+log/60cf022c02..44e38c4643 * src/third_party/r8: gobCh01BNwJNyLHHNFUmLWSMaAbe4x3izuzBFzxQpDoC..B467c9t23JiW_6XGqhvHvtEKWSkrPS2xG_gho_gbAI4C * src/third_party/turbine: 3UJ600difG3ThRhtYrN9AfZ5kh8wCYtBiii1-NMlCrMC..mr9FyghUYWLYv4L5Nr3C_oceLfmmybnFgAi366GjQoYC * src/third_party/turbine/src: https://chromium.googlesource.com/external/github.com/google/turbine.git/+log/95f6fb6f1e..1c98ea6854 * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/050a4a5e26..d6998993f9 Added dependency * src/third_party/android_deps/libs/androidx_lifecycle_lifecycle_viewmodel_savedstate DEPS diff: https://chromium.googlesource.com/chromium/src/+/4d95e6c77b..71a0e1904e/DEPS Clang version changed f7f1abdb8893af4a606ca1a8f5347a426e9c7f9e:4e813bbdf Details: https://chromium.googlesource.com/chromium/src/+/4d95e6c77b..71a0e1904e/tools/clang/scripts/update.py TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,marpan@webrtc.org, jianj@chromium.org, BUG=None Change-Id: Idb4a2ccc6eab502ecf78b34247a479ff5726b50a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178084 Reviewed-by: Jeremy Leconte <jleconte@google.com> Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#31569}
2020-06-25 22:57:49 +02:00
min_sdk_version = 21
Roll chromium_revision 6ae0f0cd4c..bf62d746a4 (669703:669828) + fix AndroidManifest In https://chromium-review.googlesource.com/1650265 attributes like minSdkVersion were moved from AndroidManifest.xml to GN files. For WebRTC there were a few problems with that. * We don't want to suppress UsesMinSdkAttributes lint but now there are these "invalid" manifest files that we can't exclude or discern. So disable this lint error. https://chromium-review.googlesource.com/c/chromium/src/+/1650265/14/build/android/AndroidManifest.xml * We should specify the versions in GN files, so I did that here (by exactly copying the versions that are already in the targets' corresponding XML files), but we never want to get rid of them in the XML files. For now this information will just be duplicated (without any synchronicity check!) so there should be followup to this. Change log: https://chromium.googlesource.com/chromium/src/+log/6ae0f0cd4c..bf62d746a4 Full diff: https://chromium.googlesource.com/chromium/src/+/6ae0f0cd4c..bf62d746a4 Changed dependencies * src/base: https://chromium.googlesource.com/chromium/src/base/+log/9e5e9332df..e5a1d1f652 * src/build: https://chromium.googlesource.com/chromium/src/build/+log/5a031748ec..2ef566e990 * src/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/6ae683be2f..6f3775ad6e * src/buildtools/linux64: git_revision:8c7f49102234f4f4b9349dcb258554675475e596..git_revision:81ee1967d3fcbc829bac1c005c3da59739c88df9 * src/buildtools/mac: git_revision:8c7f49102234f4f4b9349dcb258554675475e596..git_revision:81ee1967d3fcbc829bac1c005c3da59739c88df9 * src/buildtools/win: git_revision:8c7f49102234f4f4b9349dcb258554675475e596..git_revision:81ee1967d3fcbc829bac1c005c3da59739c88df9 * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/2f5c817266..7f1a97d593 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/1d4247de57..b1b36ff0d4 * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/6f7cbf7c46..42e96c4074 * src/third_party/android_sdk/public: ki7EDQRAiZAUYlnTWR1XmI6cJTk65fJ-DNZUU1zrtS8C..xhyuoquVvBTcJelgRjMKZeoBVSQRjB7pLVJPt5C9saIC * src/third_party/android_sdk/public: iIwhhDox5E-mHgwUhCz8JACWQCpUjdqt5KTY9VLugKQC..ppQ4TnqDvBHQ3lXx5KPq97egzF5X2FFyOrVHkGmiTMQC * src/third_party/android_sdk/public: 4Y2Cb2LGzoc-qt-oIUIlhySotJaKeE3ELFedSVe6Uk8C..MSnxgXN7IurL-MQs1RrTkSFSb8Xd1UtZjLArI8Ty1FgC * src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/ed9fcf3f70..9e5dbd8b46 * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/f58f33bca1..a9a4b8fc7b DEPS diff: https://chromium.googlesource.com/chromium/src/+/6ae0f0cd4c..bf62d746a4/DEPS No update to Clang. Bug: chromium:891996 Change-Id: I773d6fa90e8083d934c84eecc1cb9d7d4496eca0 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/142235 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Oleh Prypin <oprypin@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28311}
2019-06-18 17:09:51 +02:00
target_sdk_version = 29
Add GN targets for AppRTC Demo on Android. Adds GN equivalents for following targets: AppRTCDemo -> //webrtc/examples:AppRTCDemo AppRTCDemo_apk -> //webrtc/examples:AppRTCDemo_lib (kind of) AppRTCDemoJUnitTest -> //webrtc/examples:AppRTCDemoJUnitTest AppRTCDemoTest -> //webrtc/examples:AppRTCDemoTest libjingle_peerconnection_java -> //webrtc/api/libjingle_peerconnection_java libjingle_peerconnection_so -> //webrtc/api/libjingle_peerconnection_so New GN targets: //webrtc/base:base_java //webrtc/examples:AppRTCDemo_resources //webrtc/examples/androidapp/third_party/autobanh:autobanh_java BUG=webrtc:6035 R=magjed@webrtc.org, tommi@webrtc.org Review URL: https://codereview.webrtc.org/2105803002 . Cr-Commit-Position: refs/heads/master@{#13322}
2016-06-29 14:55:00 +02:00
deps = [
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
":AppRTCMobile_javalib",
":AppRTCMobile_resources",
Use relative paths in GN files. BUG=webrtc:7952 TBR=kjellander@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2974863003 Cr-Commit-Position: refs/heads/master@{#18970}
2017-07-11 06:20:45 -07:00
"../rtc_base:base_java",
Add GN targets for AppRTC Demo on Android. Adds GN equivalents for following targets: AppRTCDemo -> //webrtc/examples:AppRTCDemo AppRTCDemo_apk -> //webrtc/examples:AppRTCDemo_lib (kind of) AppRTCDemoJUnitTest -> //webrtc/examples:AppRTCDemoJUnitTest AppRTCDemoTest -> //webrtc/examples:AppRTCDemoTest libjingle_peerconnection_java -> //webrtc/api/libjingle_peerconnection_java libjingle_peerconnection_so -> //webrtc/api/libjingle_peerconnection_so New GN targets: //webrtc/base:base_java //webrtc/examples:AppRTCDemo_resources //webrtc/examples/androidapp/third_party/autobanh:autobanh_java BUG=webrtc:6035 R=magjed@webrtc.org, tommi@webrtc.org Review URL: https://codereview.webrtc.org/2105803002 . Cr-Commit-Position: refs/heads/master@{#13322}
2016-06-29 14:55:00 +02:00
]
Use relative paths in GN files. BUG=webrtc:7952 TBR=kjellander@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2974863003 Cr-Commit-Position: refs/heads/master@{#18970}
2017-07-11 06:20:45 -07:00
shared_libraries = [ "../sdk/android:libjingle_peerconnection_so" ]
Add GN targets for AppRTC Demo on Android. Adds GN equivalents for following targets: AppRTCDemo -> //webrtc/examples:AppRTCDemo AppRTCDemo_apk -> //webrtc/examples:AppRTCDemo_lib (kind of) AppRTCDemoJUnitTest -> //webrtc/examples:AppRTCDemoJUnitTest AppRTCDemoTest -> //webrtc/examples:AppRTCDemoTest libjingle_peerconnection_java -> //webrtc/api/libjingle_peerconnection_java libjingle_peerconnection_so -> //webrtc/api/libjingle_peerconnection_so New GN targets: //webrtc/base:base_java //webrtc/examples:AppRTCDemo_resources //webrtc/examples/androidapp/third_party/autobanh:autobanh_java BUG=webrtc:6035 R=magjed@webrtc.org, tommi@webrtc.org Review URL: https://codereview.webrtc.org/2105803002 . Cr-Commit-Position: refs/heads/master@{#13322}
2016-06-29 14:55:00 +02:00
}
Reland: "Make javac warnings errors for WebRTC targets." This reverts commit 2bad72a27329ff30ceb9479253f5eb3d21888d25. Reason for revert: Fixing downstream projects (take 2). Original change's description: > Reland "Revert "Make javac warnings errors for WebRTC targets."" > > This is a reland of 098d24c3c18f4b1fd043d7ba716d7601f0ce2b74 > Original change's description: > > Revert "Make javac warnings errors for WebRTC targets." > > > > This reverts commit 19b761403c3522902d69d61179f4d184e3632f79. > > > > Reason for revert: Breaking internal builds > > > > Original change's description: > > > Make javac warnings errors for WebRTC targets. > > > > > > Adds new rtc_* templates for Android targets to allow specifying > > > default values that affect WebRTC targets. > > > > > > Bug: webrtc:6597 > > > Change-Id: Ie529bfc8500d1e785b8a59dba7078b5f88ccfcd1 > > > Reviewed-on: https://webrtc-review.googlesource.com/15103 > > > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > > > Commit-Queue: Sami Kalliomäki <sakal@webrtc.org> > > > Cr-Commit-Position: refs/heads/master@{#20567} > > > TBR=phoglund@webrtc.org,sakal@webrtc.org > > > > Change-Id: I6d3ff5604b3d4307765d3a65adb783f89fcc974c > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: webrtc:6597 > > Reviewed-on: https://webrtc-review.googlesource.com/20740 > > Reviewed-by: Lu Liu <lliuu@webrtc.org> > > Commit-Queue: Lu Liu <lliuu@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#20571} > > Bug: webrtc:6597 > Change-Id: Icfb5ded46ce76b674bae67bfa02054b4ec52bb0f > Reviewed-on: https://webrtc-review.googlesource.com/20800 > Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org> > Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#20577} TBR=phoglund@webrtc.org,ehmaldonado@webrtc.org,mbonadei@webrtc.org,sakal@webrtc.org,lliuu@webrtc.org Change-Id: Id3713c1885318741711987ae642a269a9ca5bb85 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:6597 Reviewed-on: https://webrtc-review.googlesource.com/18441 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20588}
2017-11-07 15:36:33 +00:00
rtc_android_library("AppRTCMobile_javalib") {
Reland "Enable GN check for webrtc/examples" This is a reland of https://codereview.webrtc.org/2714343002 with the errors related to inclusions of test targets in webrtc/api resolved. BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2733673002 Cr-Commit-Position: refs/heads/master@{#17053}
2017-03-06 00:29:21 -08:00
testonly = true
Remove android_manifest_for_lint from BUILD.gn files Remove android_manifest_for_lint from BUILD.gn files The Chromium Roll into WebRTC isn't flowing The first CL that caused the problem is https://webrtc-review.googlesource.com/c/src/+/175140/ The error is: ERROR at //examples/BUILD.gn:104:33: Assignment had no effect. android_manifest_for_lint = "androidapp/AndroidManifest.xml" android_manifest_for_lint has ben removed so update BUILD files that use that feature to reflect this. BUG=None Change-Id: If526d9a4dd80cddca7f2c9dd7f67ba9efe3f1a84 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/175661 Commit-Queue: Courtney Edwards <courtneyfe@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31325}
2020-05-19 13:44:42 +02:00
android_manifest = "androidapp/AndroidManifest.xml"
Add support for swapping feeds in Android AppRTCMobile. BUG=webrtc:6937 Review-Url: https://codereview.webrtc.org/2682943006 Cr-Commit-Position: refs/heads/master@{#16582}
2017-02-13 05:58:27 -08:00
[Android] Replace java_files with sources Replace all usages of java_files with sources in gn files, and automatically format. This is in preparation for java_files being completely removed upstream in favor of sources. NOPRESUBMIT=true Bug: chromium:1035074 Change-Id: Ib9a698740b7ad26a127031d90321c7ae2feb59bf Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/163161 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Natalie Chouinard <chouinard@google.com> Cr-Commit-Position: refs/heads/master@{#30135}
2019-12-23 14:02:25 -08:00
sources = [
Add GN targets for AppRTC Demo on Android. Adds GN equivalents for following targets: AppRTCDemo -> //webrtc/examples:AppRTCDemo AppRTCDemo_apk -> //webrtc/examples:AppRTCDemo_lib (kind of) AppRTCDemoJUnitTest -> //webrtc/examples:AppRTCDemoJUnitTest AppRTCDemoTest -> //webrtc/examples:AppRTCDemoTest libjingle_peerconnection_java -> //webrtc/api/libjingle_peerconnection_java libjingle_peerconnection_so -> //webrtc/api/libjingle_peerconnection_so New GN targets: //webrtc/base:base_java //webrtc/examples:AppRTCDemo_resources //webrtc/examples/androidapp/third_party/autobanh:autobanh_java BUG=webrtc:6035 R=magjed@webrtc.org, tommi@webrtc.org Review URL: https://codereview.webrtc.org/2105803002 . Cr-Commit-Position: refs/heads/master@{#13322}
2016-06-29 14:55:00 +02:00
"androidapp/src/org/appspot/apprtc/AppRTCAudioManager.java",
Adds basic Bluetooth support to AppRTCMobile BUG=webrtc:6649 - Supports Bluetooth Headset profile. - Detects new BT headset: + enabled at start, and + powered on during active call. - Enables/disables BT SCO channel when BT device is selected. - Removes proximity sensor usage to avoid conflicts (will be added again later). - Adds new (unused) APIs to explicitly select audio device. - Starts routing audio to BT headset when enabled, i.e, BT is default. Review-Url: https://codereview.webrtc.org/2501983002 Cr-Commit-Position: refs/heads/master@{#15610}
2016-12-14 07:36:56 -08:00
"androidapp/src/org/appspot/apprtc/AppRTCBluetoothManager.java",
Add GN targets for AppRTC Demo on Android. Adds GN equivalents for following targets: AppRTCDemo -> //webrtc/examples:AppRTCDemo AppRTCDemo_apk -> //webrtc/examples:AppRTCDemo_lib (kind of) AppRTCDemoJUnitTest -> //webrtc/examples:AppRTCDemoJUnitTest AppRTCDemoTest -> //webrtc/examples:AppRTCDemoTest libjingle_peerconnection_java -> //webrtc/api/libjingle_peerconnection_java libjingle_peerconnection_so -> //webrtc/api/libjingle_peerconnection_so New GN targets: //webrtc/base:base_java //webrtc/examples:AppRTCDemo_resources //webrtc/examples/androidapp/third_party/autobanh:autobanh_java BUG=webrtc:6035 R=magjed@webrtc.org, tommi@webrtc.org Review URL: https://codereview.webrtc.org/2105803002 . Cr-Commit-Position: refs/heads/master@{#13322}
2016-06-29 14:55:00 +02:00
"androidapp/src/org/appspot/apprtc/AppRTCClient.java",
"androidapp/src/org/appspot/apprtc/AppRTCProximitySensor.java",
"androidapp/src/org/appspot/apprtc/CallActivity.java",
"androidapp/src/org/appspot/apprtc/CallFragment.java",
"androidapp/src/org/appspot/apprtc/CaptureQualityController.java",
"androidapp/src/org/appspot/apprtc/ConnectActivity.java",
"androidapp/src/org/appspot/apprtc/CpuMonitor.java",
"androidapp/src/org/appspot/apprtc/DirectRTCClient.java",
"androidapp/src/org/appspot/apprtc/HudFragment.java",
"androidapp/src/org/appspot/apprtc/PeerConnectionClient.java",
[Android] Replace java_files with sources Replace all usages of java_files with sources in gn files, and automatically format. This is in preparation for java_files being completely removed upstream in favor of sources. NOPRESUBMIT=true Bug: chromium:1035074 Change-Id: Ib9a698740b7ad26a127031d90321c7ae2feb59bf Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/163161 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Natalie Chouinard <chouinard@google.com> Cr-Commit-Position: refs/heads/master@{#30135}
2019-12-23 14:02:25 -08:00
"androidapp/src/org/appspot/apprtc/RecordedAudioToFileController.java",
Add GN targets for AppRTC Demo on Android. Adds GN equivalents for following targets: AppRTCDemo -> //webrtc/examples:AppRTCDemo AppRTCDemo_apk -> //webrtc/examples:AppRTCDemo_lib (kind of) AppRTCDemoJUnitTest -> //webrtc/examples:AppRTCDemoJUnitTest AppRTCDemoTest -> //webrtc/examples:AppRTCDemoTest libjingle_peerconnection_java -> //webrtc/api/libjingle_peerconnection_java libjingle_peerconnection_so -> //webrtc/api/libjingle_peerconnection_so New GN targets: //webrtc/base:base_java //webrtc/examples:AppRTCDemo_resources //webrtc/examples/androidapp/third_party/autobanh:autobanh_java BUG=webrtc:6035 R=magjed@webrtc.org, tommi@webrtc.org Review URL: https://codereview.webrtc.org/2105803002 . Cr-Commit-Position: refs/heads/master@{#13322}
2016-06-29 14:55:00 +02:00
"androidapp/src/org/appspot/apprtc/RoomParametersFetcher.java",
Add RtcEventLog to AppRTCMobile with preference setting. Enable diagnostic packet and event recording as in the "webrtc-internal" setting in Chromium. Bug: webrtc:8859 Change-Id: I1d4a19e0dd60133cdd0d4e18a55780623b65653c Reviewed-on: https://webrtc-review.googlesource.com/49541 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Sami Kalliomäki <sakal@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21987}
2018-02-12 10:34:18 -08:00
"androidapp/src/org/appspot/apprtc/RtcEventLog.java",
Add GN targets for AppRTC Demo on Android. Adds GN equivalents for following targets: AppRTCDemo -> //webrtc/examples:AppRTCDemo AppRTCDemo_apk -> //webrtc/examples:AppRTCDemo_lib (kind of) AppRTCDemoJUnitTest -> //webrtc/examples:AppRTCDemoJUnitTest AppRTCDemoTest -> //webrtc/examples:AppRTCDemoTest libjingle_peerconnection_java -> //webrtc/api/libjingle_peerconnection_java libjingle_peerconnection_so -> //webrtc/api/libjingle_peerconnection_so New GN targets: //webrtc/base:base_java //webrtc/examples:AppRTCDemo_resources //webrtc/examples/androidapp/third_party/autobanh:autobanh_java BUG=webrtc:6035 R=magjed@webrtc.org, tommi@webrtc.org Review URL: https://codereview.webrtc.org/2105803002 . Cr-Commit-Position: refs/heads/master@{#13322}
2016-06-29 14:55:00 +02:00
"androidapp/src/org/appspot/apprtc/SettingsActivity.java",
"androidapp/src/org/appspot/apprtc/SettingsFragment.java",
"androidapp/src/org/appspot/apprtc/TCPChannelClient.java",
"androidapp/src/org/appspot/apprtc/UnhandledExceptionHandler.java",
"androidapp/src/org/appspot/apprtc/WebSocketChannelClient.java",
"androidapp/src/org/appspot/apprtc/WebSocketRTCClient.java",
"androidapp/src/org/appspot/apprtc/util/AppRTCUtils.java",
"androidapp/src/org/appspot/apprtc/util/AsyncHttpURLConnection.java",
]
Migrate android_resources targets to not create R.java files R.java file creation responsibilities will be moved to android_library and android_apk targets and creating R.java files in the android_resources targets is now deprecated. This cl migrates webrtc targets to the new way. Bug: chromium:1073476 Change-Id: I0a2fa759d3ff1d8e201e5719c9238701a58171e9 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/183060 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32026}
2020-09-01 15:51:12 -04:00
resources_package = "org.appspot.apprtc"
Add GN targets for AppRTC Demo on Android. Adds GN equivalents for following targets: AppRTCDemo -> //webrtc/examples:AppRTCDemo AppRTCDemo_apk -> //webrtc/examples:AppRTCDemo_lib (kind of) AppRTCDemoJUnitTest -> //webrtc/examples:AppRTCDemoJUnitTest AppRTCDemoTest -> //webrtc/examples:AppRTCDemoTest libjingle_peerconnection_java -> //webrtc/api/libjingle_peerconnection_java libjingle_peerconnection_so -> //webrtc/api/libjingle_peerconnection_so New GN targets: //webrtc/base:base_java //webrtc/examples:AppRTCDemo_resources //webrtc/examples/androidapp/third_party/autobanh:autobanh_java BUG=webrtc:6035 R=magjed@webrtc.org, tommi@webrtc.org Review URL: https://codereview.webrtc.org/2105803002 . Cr-Commit-Position: refs/heads/master@{#13322}
2016-06-29 14:55:00 +02:00
deps = [
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
":AppRTCMobile_resources",
Use relative paths in GN files. BUG=webrtc:7952 TBR=kjellander@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2974863003 Cr-Commit-Position: refs/heads/master@{#18970}
2017-07-11 06:20:45 -07:00
"../rtc_base:base_java",
Make depending on a specific audio implementation optional. Splits out audio_java into audio_api_java and java_audio_device_module_java. Makes depending on java_audio_device_module_jni optional for clients that do not use it. It is only necessary to depend on this target if depending on java_audio_device_module_java. Also some cleanup. Bug: webrtc:7452 Change-Id: Ic6c4dbe11db3ed8330802a8e90203acb8ef18e72 Reviewed-on: https://webrtc-review.googlesource.com/70220 Commit-Queue: Sami Kalliomäki <sakal@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22981}
2018-04-23 15:07:34 +02:00
"../sdk/android:audio_api_java",
Split out peerconnection, swcodec and hwcodec targets from Android SDK. Bug: webrtc:9048 Change-Id: I3094ca8993cd754a0ea799e325f941d3ffd5578b Reviewed-on: https://webrtc-review.googlesource.com/63700 Commit-Queue: Sami Kalliomäki <sakal@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22644}
2018-03-28 10:49:18 +02:00
"../sdk/android:base_java",
Split out video targets from //sdk/android:base_java. Bug: webrtc:9048 Change-Id: Icda0fabf41610f99254d244e0b11d321eee345f7 Reviewed-on: https://webrtc-review.googlesource.com/65120 Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Commit-Queue: Sami Kalliomäki <sakal@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22752}
2018-04-04 15:59:31 +02:00
"../sdk/android:camera_java",
Migrate legacy Android video codec factories. Prepare for building without built-in software codecs. When passing null, inject the new type of factories but wrap them in the built-in software codecs outside the videoengine. Bug: webrtc:7925 Change-Id: I7408e6e46e6b9efdf346852954bf51a97e023b5c Reviewed-on: https://webrtc-review.googlesource.com/83729 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23897}
2018-07-10 09:33:30 +02:00
"../sdk/android:default_video_codec_factory_java",
Split out video targets from //sdk/android:base_java. Bug: webrtc:9048 Change-Id: Icda0fabf41610f99254d244e0b11d321eee345f7 Reviewed-on: https://webrtc-review.googlesource.com/65120 Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Commit-Queue: Sami Kalliomäki <sakal@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22752}
2018-04-04 15:59:31 +02:00
"../sdk/android:filevideo_java",
Split out peerconnection, swcodec and hwcodec targets from Android SDK. Bug: webrtc:9048 Change-Id: I3094ca8993cd754a0ea799e325f941d3ffd5578b Reviewed-on: https://webrtc-review.googlesource.com/63700 Commit-Queue: Sami Kalliomäki <sakal@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22644}
2018-03-28 10:49:18 +02:00
"../sdk/android:hwcodecs_java",
Make depending on a specific audio implementation optional. Splits out audio_java into audio_api_java and java_audio_device_module_java. Makes depending on java_audio_device_module_jni optional for clients that do not use it. It is only necessary to depend on this target if depending on java_audio_device_module_java. Also some cleanup. Bug: webrtc:7452 Change-Id: Ic6c4dbe11db3ed8330802a8e90203acb8ef18e72 Reviewed-on: https://webrtc-review.googlesource.com/70220 Commit-Queue: Sami Kalliomäki <sakal@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22981}
2018-04-23 15:07:34 +02:00
"../sdk/android:java_audio_device_module_java",
Use relative paths in GN files. BUG=webrtc:7952 TBR=kjellander@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2974863003 Cr-Commit-Position: refs/heads/master@{#18970}
2017-07-11 06:20:45 -07:00
"../sdk/android:libjingle_peerconnection_java",
"../sdk/android:libjingle_peerconnection_metrics_default_java",
Split out video targets from //sdk/android:base_java. Bug: webrtc:9048 Change-Id: Icda0fabf41610f99254d244e0b11d321eee345f7 Reviewed-on: https://webrtc-review.googlesource.com/65120 Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Commit-Queue: Sami Kalliomäki <sakal@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22752}
2018-04-04 15:59:31 +02:00
"../sdk/android:peerconnection_java",
"../sdk/android:screencapturer_java",
"../sdk/android:surfaceviewrenderer_java",
Split out peerconnection, swcodec and hwcodec targets from Android SDK. Bug: webrtc:9048 Change-Id: I3094ca8993cd754a0ea799e325f941d3ffd5578b Reviewed-on: https://webrtc-review.googlesource.com/63700 Commit-Queue: Sami Kalliomäki <sakal@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22644}
2018-03-28 10:49:18 +02:00
"../sdk/android:swcodecs_java",
Split out video targets from //sdk/android:base_java. Bug: webrtc:9048 Change-Id: Icda0fabf41610f99254d244e0b11d321eee345f7 Reviewed-on: https://webrtc-review.googlesource.com/65120 Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Commit-Queue: Sami Kalliomäki <sakal@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22752}
2018-04-04 15:59:31 +02:00
"../sdk/android:video_api_java",
Move VideoCapturer to video_api and cleanup. This should only be landed after clients have been given time to upgrade to the new interface. Bug: webrtc:9496, webrtc:9181 Change-Id: Ideb37637d9f0b9a3a9748811879c263c64f81d11 Reviewed-on: https://webrtc-review.googlesource.com/87308 Commit-Queue: Sami Kalliomäki <sakal@webrtc.org> Reviewed-by: Paulina Hensman <phensman@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24080}
2018-07-24 10:53:28 +02:00
"../sdk/android:video_java",
Use relative paths in GN files. BUG=webrtc:7952 TBR=kjellander@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2974863003 Cr-Commit-Position: refs/heads/master@{#18970}
2017-07-11 06:20:45 -07:00
"androidapp/third_party/autobanh:autobanh_java",
Android: Use android_deps directly This is preparing for upstream removing the alias java_groups for the individual support library targets: https://crrev.com/c/1500780 Bug: chromium:937987 Change-Id: I1c9efd83f6997288b334f3dc2f41233fa4e2ab61 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/125961 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#26995}
2019-03-06 09:18:57 -05:00
"//third_party/android_deps:com_android_support_support_annotations_java",
Add GN targets for AppRTC Demo on Android. Adds GN equivalents for following targets: AppRTCDemo -> //webrtc/examples:AppRTCDemo AppRTCDemo_apk -> //webrtc/examples:AppRTCDemo_lib (kind of) AppRTCDemoJUnitTest -> //webrtc/examples:AppRTCDemoJUnitTest AppRTCDemoTest -> //webrtc/examples:AppRTCDemoTest libjingle_peerconnection_java -> //webrtc/api/libjingle_peerconnection_java libjingle_peerconnection_so -> //webrtc/api/libjingle_peerconnection_so New GN targets: //webrtc/base:base_java //webrtc/examples:AppRTCDemo_resources //webrtc/examples/androidapp/third_party/autobanh:autobanh_java BUG=webrtc:6035 R=magjed@webrtc.org, tommi@webrtc.org Review URL: https://codereview.webrtc.org/2105803002 . Cr-Commit-Position: refs/heads/master@{#13322}
2016-06-29 14:55:00 +02:00
]
}
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
android_resources("AppRTCMobile_resources") {
Reland "Enable GN check for webrtc/examples" This is a reland of https://codereview.webrtc.org/2714343002 with the errors related to inclusions of test targets in webrtc/api resolved. BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2733673002 Cr-Commit-Position: refs/heads/master@{#17053}
2017-03-06 00:29:21 -08:00
testonly = true
Chromium refactor: Replace "resources_dirs" with "sources" Bug: chromium:1062263 Change-Id: I4b7b06cfeaf4cb655a0b3533dba25a77756bdcd0 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/171741 Commit-Queue: Andrew Grieve <agrieve@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30889}
2020-03-25 12:59:50 -04:00
sources = [
"androidapp/res/drawable-hdpi/disconnect.png",
"androidapp/res/drawable-hdpi/ic_action_full_screen.png",
"androidapp/res/drawable-hdpi/ic_action_return_from_full_screen.png",
"androidapp/res/drawable-hdpi/ic_launcher.png",
"androidapp/res/drawable-hdpi/ic_loopback_call.png",
"androidapp/res/drawable-ldpi/disconnect.png",
"androidapp/res/drawable-ldpi/ic_action_full_screen.png",
"androidapp/res/drawable-ldpi/ic_action_return_from_full_screen.png",
"androidapp/res/drawable-ldpi/ic_launcher.png",
"androidapp/res/drawable-ldpi/ic_loopback_call.png",
"androidapp/res/drawable-mdpi/disconnect.png",
"androidapp/res/drawable-mdpi/ic_action_full_screen.png",
"androidapp/res/drawable-mdpi/ic_action_return_from_full_screen.png",
"androidapp/res/drawable-mdpi/ic_launcher.png",
"androidapp/res/drawable-mdpi/ic_loopback_call.png",
"androidapp/res/drawable-xhdpi/disconnect.png",
"androidapp/res/drawable-xhdpi/ic_action_full_screen.png",
"androidapp/res/drawable-xhdpi/ic_action_return_from_full_screen.png",
"androidapp/res/drawable-xhdpi/ic_launcher.png",
"androidapp/res/drawable-xhdpi/ic_loopback_call.png",
"androidapp/res/layout/activity_call.xml",
"androidapp/res/layout/activity_connect.xml",
"androidapp/res/layout/fragment_call.xml",
"androidapp/res/layout/fragment_hud.xml",
"androidapp/res/menu/connect_menu.xml",
"androidapp/res/values-v17/styles.xml",
"androidapp/res/values-v21/styles.xml",
Add missing deps for android libs to unblock chromium roll Bug: None Change-Id: I1404f02cf43c3d8288fa7ae3bf128ed76856def4 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176445 Reviewed-by: Sami Kalliomäki <sakal@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31428}
2020-06-03 16:42:57 +02:00
"androidapp/res/values/arrays.xml",
"androidapp/res/values/strings.xml",
Chromium refactor: Replace "resources_dirs" with "sources" Bug: chromium:1062263 Change-Id: I4b7b06cfeaf4cb655a0b3533dba25a77756bdcd0 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/171741 Commit-Queue: Andrew Grieve <agrieve@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30889}
2020-03-25 12:59:50 -04:00
"androidapp/res/xml/preferences.xml",
]
# Needed for Bazel converter.
Migrate android_resources targets to not create R.java files R.java file creation responsibilities will be moved to android_library and android_apk targets and creating R.java files in the android_resources targets is now deprecated. This cl migrates webrtc targets to the new way. Bug: chromium:1073476 Change-Id: I0a2fa759d3ff1d8e201e5719c9238701a58171e9 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/183060 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32026}
2020-09-01 15:51:12 -04:00
custom_package = "org.appspot.apprtc"
Chromium refactor: Replace "resources_dirs" with "sources" Bug: chromium:1062263 Change-Id: I4b7b06cfeaf4cb655a0b3533dba25a77756bdcd0 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/171741 Commit-Queue: Andrew Grieve <agrieve@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30889}
2020-03-25 12:59:50 -04:00
resource_dirs = [ "androidapp/res" ]
assert(resource_dirs != []) # Mark as used.
Add GN targets for AppRTC Demo on Android. Adds GN equivalents for following targets: AppRTCDemo -> //webrtc/examples:AppRTCDemo AppRTCDemo_apk -> //webrtc/examples:AppRTCDemo_lib (kind of) AppRTCDemoJUnitTest -> //webrtc/examples:AppRTCDemoJUnitTest AppRTCDemoTest -> //webrtc/examples:AppRTCDemoTest libjingle_peerconnection_java -> //webrtc/api/libjingle_peerconnection_java libjingle_peerconnection_so -> //webrtc/api/libjingle_peerconnection_so New GN targets: //webrtc/base:base_java //webrtc/examples:AppRTCDemo_resources //webrtc/examples/androidapp/third_party/autobanh:autobanh_java BUG=webrtc:6035 R=magjed@webrtc.org, tommi@webrtc.org Review URL: https://codereview.webrtc.org/2105803002 . Cr-Commit-Position: refs/heads/master@{#13322}
2016-06-29 14:55:00 +02:00
}
Rename rtc_instrumentation_test_apk targets to end with _test_apk. This matches Chromium pattern of naming instrumentation test apks with a name ending in _test_apk. The old naming confuses generate_gradle.py. Renames: - AppRTCMobileTest -> AppRTCMobile_test_apk - AppRTCMobileTestStubbedVideoIO -> AppRTCMobile_stubbed_video_io_test_apk - libjingle_peerconnection_android_unittest -> android_instrumentation_test_apk Bug: webrtc:9588 TBR: phoglund Change-Id: Idb82dc4bd089bc7c90e9373f7c3d572f9fd2d95a Reviewed-on: https://webrtc-review.googlesource.com/92380 Commit-Queue: Sami Kalliomäki <sakal@webrtc.org> Reviewed-by: Oleh Prypin <oprypin@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24184}
2018-08-03 13:23:05 +02:00
rtc_instrumentation_test_apk("AppRTCMobile_test_apk") {
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
apk_name = "AppRTCMobileTest"
Add GN targets for AppRTC Demo on Android. Adds GN equivalents for following targets: AppRTCDemo -> //webrtc/examples:AppRTCDemo AppRTCDemo_apk -> //webrtc/examples:AppRTCDemo_lib (kind of) AppRTCDemoJUnitTest -> //webrtc/examples:AppRTCDemoJUnitTest AppRTCDemoTest -> //webrtc/examples:AppRTCDemoTest libjingle_peerconnection_java -> //webrtc/api/libjingle_peerconnection_java libjingle_peerconnection_so -> //webrtc/api/libjingle_peerconnection_so New GN targets: //webrtc/base:base_java //webrtc/examples:AppRTCDemo_resources //webrtc/examples/androidapp/third_party/autobanh:autobanh_java BUG=webrtc:6035 R=magjed@webrtc.org, tommi@webrtc.org Review URL: https://codereview.webrtc.org/2105803002 . Cr-Commit-Position: refs/heads/master@{#13322}
2016-06-29 14:55:00 +02:00
android_manifest = "androidtests/AndroidManifest.xml"
Roll chromium_revision 4d95e6c77b..71a0e1904e (776481:782339) Change log: https://chromium.googlesource.com/chromium/src/+log/4d95e6c77b..71a0e1904e Full diff: https://chromium.googlesource.com/chromium/src/+/4d95e6c77b..71a0e1904e Changed dependencies * src/base: https://chromium.googlesource.com/chromium/src/base/+log/2df7267880..736d9fb42c * src/build: https://chromium.googlesource.com/chromium/src/build/+log/a03951acb9..876a780600 * src/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/1b066f0216..1ed99573d5 * src/buildtools/linux64: git_revision:d0a6f072070988e7b038496c4e7d6c562b649732..git_revision:7d7e8deea36d126397bda2cf924682504271f0e1 * src/buildtools/mac: git_revision:d0a6f072070988e7b038496c4e7d6c562b649732..git_revision:7d7e8deea36d126397bda2cf924682504271f0e1 * src/buildtools/win: git_revision:d0a6f072070988e7b038496c4e7d6c562b649732..git_revision:7d7e8deea36d126397bda2cf924682504271f0e1 * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/9200aad36b..73c8bcb1b1 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/502600d41a..77ba7104d5 * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/e0df6e10ad..1908162da7 * src/third_party/android_deps/libs/androidx_activity_activity: version:1.0.0-cr0..version:1.1.0-cr0 * src/third_party/android_deps/libs/androidx_arch_core_core_runtime: version:2.0.0-cr0..version:2.1.0-cr0 * src/third_party/android_deps/libs/androidx_fragment_fragment: version:1.1.0-cr0..version:1.2.5-cr0 * src/third_party/android_deps/libs/androidx_lifecycle_lifecycle_common: version:2.1.0-cr0..version:2.2.0-cr0 * src/third_party/android_deps/libs/androidx_lifecycle_lifecycle_livedata_core: version:2.0.0-cr0..version:2.2.0-cr0 * src/third_party/android_deps/libs/androidx_lifecycle_lifecycle_runtime: version:2.1.0-cr0..version:2.2.0-cr0 * src/third_party/android_deps/libs/androidx_lifecycle_lifecycle_viewmodel: version:2.1.0-cr0..version:2.2.0-cr0 * src/third_party/android_deps/libs/androidx_preference_preference: version:1.0.0-cr0..version:1.1.1-cr0 * src/third_party/android_deps/libs/org_robolectric_shadows_multidex: version:4.3.1-cr0..version:4.3.1-cr1 * src/third_party/android_sdk/public: CR25ixsRhwuRnhdgDpGFyl9S0C_0HO9SUgFrwX46zq8C..uM0XtAW9BHh8phcbhBDA9GfzP3bku2SP7AiMahhimnoC * src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/88024df121..430a742303 * src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/2ad47493f8..e0658a4adf * src/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/37e562110f..87c8b91639 * src/third_party/espresso: c92dcfc4e894555a0b3c309f2b7939640eb1fee4..y8fIfH8Leo2cPm7iGCYnBxZpwOlgLv8rm2mlcmJlvGsC * src/third_party/ffmpeg: https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/be66dc5fd0..23b2a15c25 * src/third_party/freetype/src: https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/62fea391fa..a443474755 * src/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu.git/+log/630b884f84..79326efe26 * src/third_party/libaom/source/libaom: https://aomedia.googlesource.com/aom.git/+log/2aa13c436e..e1ebb418eb * src/third_party/libunwindstack: https://chromium.googlesource.com/chromium/src/third_party/libunwindstack.git/+log/046920fc49..11659d420a * src/third_party/libvpx/source/libvpx: https://chromium.googlesource.com/webm/libvpx.git/+log/c176557314..769129fb29 * src/third_party/perfetto: https://android.googlesource.com/platform/external/perfetto.git/+log/60cf022c02..44e38c4643 * src/third_party/r8: gobCh01BNwJNyLHHNFUmLWSMaAbe4x3izuzBFzxQpDoC..B467c9t23JiW_6XGqhvHvtEKWSkrPS2xG_gho_gbAI4C * src/third_party/turbine: 3UJ600difG3ThRhtYrN9AfZ5kh8wCYtBiii1-NMlCrMC..mr9FyghUYWLYv4L5Nr3C_oceLfmmybnFgAi366GjQoYC * src/third_party/turbine/src: https://chromium.googlesource.com/external/github.com/google/turbine.git/+log/95f6fb6f1e..1c98ea6854 * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/050a4a5e26..d6998993f9 Added dependency * src/third_party/android_deps/libs/androidx_lifecycle_lifecycle_viewmodel_savedstate DEPS diff: https://chromium.googlesource.com/chromium/src/+/4d95e6c77b..71a0e1904e/DEPS Clang version changed f7f1abdb8893af4a606ca1a8f5347a426e9c7f9e:4e813bbdf Details: https://chromium.googlesource.com/chromium/src/+/4d95e6c77b..71a0e1904e/tools/clang/scripts/update.py TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,marpan@webrtc.org, jianj@chromium.org, BUG=None Change-Id: Idb4a2ccc6eab502ecf78b34247a479ff5726b50a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178084 Reviewed-by: Jeremy Leconte <jleconte@google.com> Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#31569}
2020-06-25 22:57:49 +02:00
min_sdk_version = 21
Roll chromium_revision 6ae0f0cd4c..bf62d746a4 (669703:669828) + fix AndroidManifest In https://chromium-review.googlesource.com/1650265 attributes like minSdkVersion were moved from AndroidManifest.xml to GN files. For WebRTC there were a few problems with that. * We don't want to suppress UsesMinSdkAttributes lint but now there are these "invalid" manifest files that we can't exclude or discern. So disable this lint error. https://chromium-review.googlesource.com/c/chromium/src/+/1650265/14/build/android/AndroidManifest.xml * We should specify the versions in GN files, so I did that here (by exactly copying the versions that are already in the targets' corresponding XML files), but we never want to get rid of them in the XML files. For now this information will just be duplicated (without any synchronicity check!) so there should be followup to this. Change log: https://chromium.googlesource.com/chromium/src/+log/6ae0f0cd4c..bf62d746a4 Full diff: https://chromium.googlesource.com/chromium/src/+/6ae0f0cd4c..bf62d746a4 Changed dependencies * src/base: https://chromium.googlesource.com/chromium/src/base/+log/9e5e9332df..e5a1d1f652 * src/build: https://chromium.googlesource.com/chromium/src/build/+log/5a031748ec..2ef566e990 * src/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/6ae683be2f..6f3775ad6e * src/buildtools/linux64: git_revision:8c7f49102234f4f4b9349dcb258554675475e596..git_revision:81ee1967d3fcbc829bac1c005c3da59739c88df9 * src/buildtools/mac: git_revision:8c7f49102234f4f4b9349dcb258554675475e596..git_revision:81ee1967d3fcbc829bac1c005c3da59739c88df9 * src/buildtools/win: git_revision:8c7f49102234f4f4b9349dcb258554675475e596..git_revision:81ee1967d3fcbc829bac1c005c3da59739c88df9 * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/2f5c817266..7f1a97d593 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/1d4247de57..b1b36ff0d4 * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/6f7cbf7c46..42e96c4074 * src/third_party/android_sdk/public: ki7EDQRAiZAUYlnTWR1XmI6cJTk65fJ-DNZUU1zrtS8C..xhyuoquVvBTcJelgRjMKZeoBVSQRjB7pLVJPt5C9saIC * src/third_party/android_sdk/public: iIwhhDox5E-mHgwUhCz8JACWQCpUjdqt5KTY9VLugKQC..ppQ4TnqDvBHQ3lXx5KPq97egzF5X2FFyOrVHkGmiTMQC * src/third_party/android_sdk/public: 4Y2Cb2LGzoc-qt-oIUIlhySotJaKeE3ELFedSVe6Uk8C..MSnxgXN7IurL-MQs1RrTkSFSb8Xd1UtZjLArI8Ty1FgC * src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/ed9fcf3f70..9e5dbd8b46 * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/f58f33bca1..a9a4b8fc7b DEPS diff: https://chromium.googlesource.com/chromium/src/+/6ae0f0cd4c..bf62d746a4/DEPS No update to Clang. Bug: chromium:891996 Change-Id: I773d6fa90e8083d934c84eecc1cb9d7d4496eca0 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/142235 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Oleh Prypin <oprypin@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28311}
2019-06-18 17:09:51 +02:00
target_sdk_version = 21
Add GN targets for AppRTC Demo on Android. Adds GN equivalents for following targets: AppRTCDemo -> //webrtc/examples:AppRTCDemo AppRTCDemo_apk -> //webrtc/examples:AppRTCDemo_lib (kind of) AppRTCDemoJUnitTest -> //webrtc/examples:AppRTCDemoJUnitTest AppRTCDemoTest -> //webrtc/examples:AppRTCDemoTest libjingle_peerconnection_java -> //webrtc/api/libjingle_peerconnection_java libjingle_peerconnection_so -> //webrtc/api/libjingle_peerconnection_so New GN targets: //webrtc/base:base_java //webrtc/examples:AppRTCDemo_resources //webrtc/examples/androidapp/third_party/autobanh:autobanh_java BUG=webrtc:6035 R=magjed@webrtc.org, tommi@webrtc.org Review URL: https://codereview.webrtc.org/2105803002 . Cr-Commit-Position: refs/heads/master@{#13322}
2016-06-29 14:55:00 +02:00
[Android] Replace java_files with sources Replace all usages of java_files with sources in gn files, and automatically format. This is in preparation for java_files being completely removed upstream in favor of sources. NOPRESUBMIT=true Bug: chromium:1035074 Change-Id: Ib9a698740b7ad26a127031d90321c7ae2feb59bf Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/163161 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Natalie Chouinard <chouinard@google.com> Cr-Commit-Position: refs/heads/master@{#30135}
2019-12-23 14:02:25 -08:00
sources = [
Fix circular dependencies between optional, array_view, and rtc_base. This splits things out of rtc_base and makes dependencies explicit. Bug: webrtc:6828 Change-Id: Id521896c3c43595349021c857bec216e429a0c8d Reviewed-on: https://webrtc-review.googlesource.com/32780 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21264}
2017-12-13 16:05:42 +01:00
"androidtests/src/org/appspot/apprtc/test/PeerConnectionClientTest.java",
]
Add GN targets for AppRTC Demo on Android. Adds GN equivalents for following targets: AppRTCDemo -> //webrtc/examples:AppRTCDemo AppRTCDemo_apk -> //webrtc/examples:AppRTCDemo_lib (kind of) AppRTCDemoJUnitTest -> //webrtc/examples:AppRTCDemoJUnitTest AppRTCDemoTest -> //webrtc/examples:AppRTCDemoTest libjingle_peerconnection_java -> //webrtc/api/libjingle_peerconnection_java libjingle_peerconnection_so -> //webrtc/api/libjingle_peerconnection_so New GN targets: //webrtc/base:base_java //webrtc/examples:AppRTCDemo_resources //webrtc/examples/androidapp/third_party/autobanh:autobanh_java BUG=webrtc:6035 R=magjed@webrtc.org, tommi@webrtc.org Review URL: https://codereview.webrtc.org/2105803002 . Cr-Commit-Position: refs/heads/master@{#13322}
2016-06-29 14:55:00 +02:00
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
apk_under_test = ":AppRTCMobile"
Add GN targets for AppRTC Demo on Android. Adds GN equivalents for following targets: AppRTCDemo -> //webrtc/examples:AppRTCDemo AppRTCDemo_apk -> //webrtc/examples:AppRTCDemo_lib (kind of) AppRTCDemoJUnitTest -> //webrtc/examples:AppRTCDemoJUnitTest AppRTCDemoTest -> //webrtc/examples:AppRTCDemoTest libjingle_peerconnection_java -> //webrtc/api/libjingle_peerconnection_java libjingle_peerconnection_so -> //webrtc/api/libjingle_peerconnection_so New GN targets: //webrtc/base:base_java //webrtc/examples:AppRTCDemo_resources //webrtc/examples/androidapp/third_party/autobanh:autobanh_java BUG=webrtc:6035 R=magjed@webrtc.org, tommi@webrtc.org Review URL: https://codereview.webrtc.org/2105803002 . Cr-Commit-Position: refs/heads/master@{#13322}
2016-06-29 14:55:00 +02:00
deps = [
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
":AppRTCMobile_javalib",
Add missing dependencies to java targets. Starting from http://crrev.com/c/2289614, transitive dependencies are not allowed anymore for java targts. This CL prepares WebRTC for the next Chromium Roll. Bug: None Change-Id: I2aafa7be66c215b70d79e0f95272233fe7b37d3a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179061 Reviewed-by: Artem Titov <titovartem@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31695}
2020-07-10 10:36:04 +02:00
"../sdk/android:base_java",
Add missing deps for android libs to unblock chromium roll Bug: None Change-Id: I1404f02cf43c3d8288fa7ae3bf128ed76856def4 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176445 Reviewed-by: Sami Kalliomäki <sakal@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31428}
2020-06-03 16:42:57 +02:00
"../sdk/android:camera_java",
Use relative paths in GN files. BUG=webrtc:7952 TBR=kjellander@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2974863003 Cr-Commit-Position: refs/heads/master@{#18970}
2017-07-11 06:20:45 -07:00
"../sdk/android:libjingle_peerconnection_java",
Add missing deps for android libs to unblock chromium roll Bug: None Change-Id: I1404f02cf43c3d8288fa7ae3bf128ed76856def4 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176445 Reviewed-by: Sami Kalliomäki <sakal@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31428}
2020-06-03 16:42:57 +02:00
"../sdk/android:peerconnection_java",
"../sdk/android:video_api_java",
Move VideoCapturer to video_api and cleanup. This should only be landed after clients have been given time to upgrade to the new interface. Bug: webrtc:9496, webrtc:9181 Change-Id: Ideb37637d9f0b9a3a9748811879c263c64f81d11 Reviewed-on: https://webrtc-review.googlesource.com/87308 Commit-Queue: Sami Kalliomäki <sakal@webrtc.org> Reviewed-by: Paulina Hensman <phensman@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24080}
2018-07-24 10:53:28 +02:00
"../sdk/android:video_java",
Update AppRTCMobile tests to use JUnit4. BUG=webrtc:6597 Review-Url: https://codereview.webrtc.org/2621253002 Cr-Commit-Position: refs/heads/master@{#16010}
2017-01-11 06:21:26 -08:00
"//third_party/android_support_test_runner:runner_java",
"//third_party/junit",
Add GN targets for AppRTC Demo on Android. Adds GN equivalents for following targets: AppRTCDemo -> //webrtc/examples:AppRTCDemo AppRTCDemo_apk -> //webrtc/examples:AppRTCDemo_lib (kind of) AppRTCDemoJUnitTest -> //webrtc/examples:AppRTCDemoJUnitTest AppRTCDemoTest -> //webrtc/examples:AppRTCDemoTest libjingle_peerconnection_java -> //webrtc/api/libjingle_peerconnection_java libjingle_peerconnection_so -> //webrtc/api/libjingle_peerconnection_so New GN targets: //webrtc/base:base_java //webrtc/examples:AppRTCDemo_resources //webrtc/examples/androidapp/third_party/autobanh:autobanh_java BUG=webrtc:6035 R=magjed@webrtc.org, tommi@webrtc.org Review URL: https://codereview.webrtc.org/2105803002 . Cr-Commit-Position: refs/heads/master@{#13322}
2016-06-29 14:55:00 +02:00
]
}
}
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
if (is_ios || (is_mac && target_cpu != "x86")) {
config("apprtc_common_config") {
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
include_dirs = [ "objc/AppRTCMobile/common" ]
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("apprtc_common") {
Reland "Enable GN check for webrtc/examples" This is a reland of https://codereview.webrtc.org/2714343002 with the errors related to inclusions of test targets in webrtc/api resolved. BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2733673002 Cr-Commit-Position: refs/heads/master@{#17053}
2017-03-06 00:29:21 -08:00
testonly = true
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
sources = [
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
"objc/AppRTCMobile/common/ARDUtilities.h",
"objc/AppRTCMobile/common/ARDUtilities.m",
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
]
GN Templates: Move common_inherited_config to the template. Remove common_inherited_config from the targets and add it to the template instead. BUG=webrtc:6187 NOTRY=True Review-Url: https://codereview.webrtc.org/2311843002 Cr-Commit-Position: refs/heads/master@{#14069}
2016-09-05 06:10:18 -07:00
public_configs = [ ":apprtc_common_config" ]
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
Remove webrtc deps from AppRTCMobile. We want the example app to only link agains the framework. This ensures that we are actually testing the framework, and that AppRTCMobile doesn't require any other parts of WebRTC not included in the framework. Bug: webrtc:7759 Change-Id: Ib04aae0bc3ab2a1a508eaf4a4f15c2d37f521598 Reviewed-on: https://chromium-review.googlesource.com/522722 Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Commit-Queue: Kári Tristan Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#18470}
2017-06-02 14:05:56 +02:00
if (is_ios) {
Re-enabling 'gn check' on //examples/*. Bug: webrtc:8850 Change-Id: I7397bc17e0f790a31d417d1bf5db6c5f9e32088d No-Presubmit: true Reviewed-on: https://webrtc-review.googlesource.com/54314 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22085}
2018-02-19 15:14:04 +01:00
# iOS must use WebRTC.framework which is dynamically linked.
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
deps = [ "../sdk:framework_objc+link" ]
Remove webrtc deps from AppRTCMobile. We want the example app to only link agains the framework. This ensures that we are actually testing the framework, and that AppRTCMobile doesn't require any other parts of WebRTC not included in the framework. Bug: webrtc:7759 Change-Id: Ib04aae0bc3ab2a1a508eaf4a4f15c2d37f521598 Reviewed-on: https://chromium-review.googlesource.com/522722 Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Commit-Queue: Kári Tristan Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#18470}
2017-06-02 14:05:56 +02:00
} else {
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
deps = [ "../sdk:mac_framework_objc+link" ]
Remove webrtc deps from AppRTCMobile. We want the example app to only link agains the framework. This ensures that we are actually testing the framework, and that AppRTCMobile doesn't require any other parts of WebRTC not included in the framework. Bug: webrtc:7759 Change-Id: Ib04aae0bc3ab2a1a508eaf4a4f15c2d37f521598 Reviewed-on: https://chromium-review.googlesource.com/522722 Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Commit-Queue: Kári Tristan Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#18470}
2017-06-02 14:05:56 +02:00
}
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
}
config("apprtc_signaling_config") {
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
include_dirs = [ "objc/AppRTCMobile" ]
Disable -Wunguarded-availability for apprtc_signaling. Bug: webrtc:10837 Change-Id: Ib410589ea4358ffce0b8166402bfb0f665f4e9b2 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/147264 Reviewed-by: Oleh Prypin <oprypin@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28702}
2019-07-30 11:38:08 +02:00
cflags_objc = [
# TODO(bugs.webrtc.org/10837): Remove this when usage of
# archivedDataWithRootObject will be removed.
"-Wno-unguarded-availability",
]
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("apprtc_signaling") {
Reland "Enable GN check for webrtc/examples" This is a reland of https://codereview.webrtc.org/2714343002 with the errors related to inclusions of test targets in webrtc/api resolved. BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2733673002 Cr-Commit-Position: refs/heads/master@{#17053}
2017-03-06 00:29:21 -08:00
testonly = true
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
sources = [
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
"objc/AppRTCMobile/ARDAppClient+Internal.h",
"objc/AppRTCMobile/ARDAppClient.h",
"objc/AppRTCMobile/ARDAppClient.m",
"objc/AppRTCMobile/ARDAppEngineClient.h",
"objc/AppRTCMobile/ARDAppEngineClient.m",
"objc/AppRTCMobile/ARDBitrateTracker.h",
"objc/AppRTCMobile/ARDBitrateTracker.m",
Use new RTCCameraVideoCapturer in AppRTCMobile. Because the new API doesn't use constraints, refactors settings to instead have a video resolution setting. BUG=webrtc:7177 Review-Url: https://codereview.webrtc.org/2778163005 Cr-Commit-Position: refs/heads/master@{#17545}
2017-04-05 12:17:48 -07:00
"objc/AppRTCMobile/ARDCaptureController.h",
"objc/AppRTCMobile/ARDCaptureController.m",
Broadcast extension for AppRTCMobile on iOS This provides an environment for testing out using WebRTC from an iOS extension. It implements a ReplayKit broadcast extension for live streaming games and screensharing. The extension is only supported on iOS 11+ and is guarded by a build flag. Bug: webrtc:9335 Change-Id: Id218d6c73ef7599f5953c5a1e0e62e5d0dc4f10b Reviewed-on: https://webrtc-review.googlesource.com/80000 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23504}
2018-06-04 10:24:37 +02:00
"objc/AppRTCMobile/ARDExternalSampleCapturer.h",
"objc/AppRTCMobile/ARDExternalSampleCapturer.m",
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
"objc/AppRTCMobile/ARDJoinResponse+Internal.h",
"objc/AppRTCMobile/ARDJoinResponse.h",
"objc/AppRTCMobile/ARDJoinResponse.m",
"objc/AppRTCMobile/ARDMessageResponse+Internal.h",
"objc/AppRTCMobile/ARDMessageResponse.h",
"objc/AppRTCMobile/ARDMessageResponse.m",
"objc/AppRTCMobile/ARDRoomServerClient.h",
Pass settings model to ARDAppClient instead of individual settings. Moves settings model and related classes to code common for both iOS and Mac. BUG=webrtc:7177,webrtc:6494 Review-Url: https://codereview.webrtc.org/2770113004 Cr-Commit-Position: refs/heads/master@{#17408}
2017-03-28 01:22:48 -07:00
"objc/AppRTCMobile/ARDSettingsModel+Private.h",
"objc/AppRTCMobile/ARDSettingsModel.h",
"objc/AppRTCMobile/ARDSettingsModel.m",
"objc/AppRTCMobile/ARDSettingsStore.h",
"objc/AppRTCMobile/ARDSettingsStore.m",
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
"objc/AppRTCMobile/ARDSignalingChannel.h",
"objc/AppRTCMobile/ARDSignalingMessage.h",
"objc/AppRTCMobile/ARDSignalingMessage.m",
"objc/AppRTCMobile/ARDStatsBuilder.h",
"objc/AppRTCMobile/ARDStatsBuilder.m",
Update ice server provider response format in iOS AppRTCMobile BUG=webrtc:5963 Review-Url: https://codereview.webrtc.org/2627523004 Cr-Commit-Position: refs/heads/master@{#16050}
2017-01-13 05:59:46 -08:00
"objc/AppRTCMobile/ARDTURNClient+Internal.h",
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
"objc/AppRTCMobile/ARDTURNClient.h",
Update ice server provider response format in iOS AppRTCMobile BUG=webrtc:5963 Review-Url: https://codereview.webrtc.org/2627523004 Cr-Commit-Position: refs/heads/master@{#16050}
2017-01-13 05:59:46 -08:00
"objc/AppRTCMobile/ARDTURNClient.m",
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
"objc/AppRTCMobile/ARDWebSocketChannel.h",
"objc/AppRTCMobile/ARDWebSocketChannel.m",
"objc/AppRTCMobile/RTCIceCandidate+JSON.h",
"objc/AppRTCMobile/RTCIceCandidate+JSON.m",
"objc/AppRTCMobile/RTCIceServer+JSON.h",
"objc/AppRTCMobile/RTCIceServer+JSON.m",
"objc/AppRTCMobile/RTCSessionDescription+JSON.h",
"objc/AppRTCMobile/RTCSessionDescription+JSON.m",
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
]
GN Templates: Move common_inherited_config to the template. Remove common_inherited_config from the targets and add it to the template instead. BUG=webrtc:6187 NOTRY=True Review-Url: https://codereview.webrtc.org/2311843002 Cr-Commit-Position: refs/heads/master@{#14069}
2016-09-05 06:10:18 -07:00
public_configs = [ ":apprtc_signaling_config" ]
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
deps = [
":apprtc_common",
":socketrocket",
]
Finally delete deprecated mac capturer. Landing this CL will break video_loopback but cl 124827 fixes that. Bug: webrtc:6898, webrtc:6333, webrtc:7861 Change-Id: Iecbbf75fab08570cc537784f7bbd11a841a2e5a6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/124828 Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27012}
2019-03-07 10:44:26 +01:00
Remove webrtc deps from AppRTCMobile. We want the example app to only link agains the framework. This ensures that we are actually testing the framework, and that AppRTCMobile doesn't require any other parts of WebRTC not included in the framework. Bug: webrtc:7759 Change-Id: Ib04aae0bc3ab2a1a508eaf4a4f15c2d37f521598 Reviewed-on: https://chromium-review.googlesource.com/522722 Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Commit-Queue: Kári Tristan Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#18470}
2017-06-02 14:05:56 +02:00
if (is_ios) {
Re-enabling 'gn check' on //examples/*. Bug: webrtc:8850 Change-Id: I7397bc17e0f790a31d417d1bf5db6c5f9e32088d No-Presubmit: true Reviewed-on: https://webrtc-review.googlesource.com/54314 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22085}
2018-02-19 15:14:04 +01:00
# iOS must use WebRTC.framework which is dynamically linked.
Stop using public_deps in examples. Bug: webrtc:8603 Change-Id: I1c25055109825c97e3d571efd07de79aa8c503b5 Reviewed-on: https://webrtc-review.googlesource.com/29863 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21278}
2017-12-14 13:06:10 +01:00
deps += [
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"../sdk:framework_objc+link",
"../sdk:ios_framework_bundle",
Remove webrtc deps from AppRTCMobile. We want the example app to only link agains the framework. This ensures that we are actually testing the framework, and that AppRTCMobile doesn't require any other parts of WebRTC not included in the framework. Bug: webrtc:7759 Change-Id: Ib04aae0bc3ab2a1a508eaf4a4f15c2d37f521598 Reviewed-on: https://chromium-review.googlesource.com/522722 Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Commit-Queue: Kári Tristan Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#18470}
2017-06-02 14:05:56 +02:00
]
Stop using public_deps in examples. Bug: webrtc:8603 Change-Id: I1c25055109825c97e3d571efd07de79aa8c503b5 Reviewed-on: https://webrtc-review.googlesource.com/29863 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21278}
2017-12-14 13:06:10 +01:00
} else {
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
deps += [ "../sdk:mac_framework_objc+link" ]
Remove webrtc deps from AppRTCMobile. We want the example app to only link agains the framework. This ensures that we are actually testing the framework, and that AppRTCMobile doesn't require any other parts of WebRTC not included in the framework. Bug: webrtc:7759 Change-Id: Ib04aae0bc3ab2a1a508eaf4a4f15c2d37f521598 Reviewed-on: https://chromium-review.googlesource.com/522722 Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Commit-Queue: Kári Tristan Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#18470}
2017-06-02 14:05:56 +02:00
}
Convert GN libs lists to frameworks GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: chromium:1052560 Change-Id: I263230ddd3c468061584423bba9e1f887503bcaa Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178601 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#31632}
2020-07-03 10:19:30 +02:00
frameworks = [
Finally delete deprecated mac capturer. Landing this CL will break video_loopback but cl 124827 fixes that. Bug: webrtc:6898, webrtc:6333, webrtc:7861 Change-Id: Iecbbf75fab08570cc537784f7bbd11a841a2e5a6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/124828 Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27012}
2019-03-07 10:44:26 +01:00
"CoreMedia.framework",
"QuartzCore.framework",
]
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
}
if (is_ios) {
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("AppRTCMobile_lib") {
Re-enabling 'gn check' on //examples/*. Bug: webrtc:8850 Change-Id: I7397bc17e0f790a31d417d1bf5db6c5f9e32088d No-Presubmit: true Reviewed-on: https://webrtc-review.googlesource.com/54314 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22085}
2018-02-19 15:14:04 +01:00
# iOS must use WebRTC.framework which is dynamically linked.
Reland "Enable GN check for webrtc/examples" This is a reland of https://codereview.webrtc.org/2714343002 with the errors related to inclusions of test targets in webrtc/api resolved. BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2733673002 Cr-Commit-Position: refs/heads/master@{#17053}
2017-03-06 00:29:21 -08:00
testonly = true
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
sources = [
Add ARDAppDelegate.h. Bug: webrtc:7643 Change-Id: Ib1980c82c64ffa3acc009a855a7f077509872548 Reviewed-on: https://webrtc-review.googlesource.com/37002 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21476}
2018-01-02 14:41:54 +01:00
"objc/AppRTCMobile/ios/ARDAppDelegate.h",
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
"objc/AppRTCMobile/ios/ARDAppDelegate.m",
Reland "Add file capturer to AppRTCMobile on simulator." This is a reland of 5adcd198752b651f7b7e9199a91f9b873b7d7237 Original change's description: > Add file capturer to AppRTCMobile on simulator. > > To achieve this, the CL does the following > - Adds sample mp4 video > - Refactors the existing RTCFileVideoCapturer to achieve continious > capture and adds tests. > > Bug: webrtc:8406 > Change-Id: Ibc0891176c58ec9053b42e340d2113036e7199ec > Reviewed-on: https://webrtc-review.googlesource.com/12180 > Reviewed-by: Anders Carlsson <andersc@webrtc.org> > Reviewed-by: Magnus Jedvert <magjed@webrtc.org> > Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#20598} Bug: webrtc:8406 Change-Id: I93be89b86e342a9a8195e19ebaf4aef1410d2c20 Reviewed-on: https://webrtc-review.googlesource.com/23200 Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20870}
2017-11-15 13:15:24 +01:00
"objc/AppRTCMobile/ios/ARDFileCaptureController.h",
"objc/AppRTCMobile/ios/ARDFileCaptureController.m",
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
"objc/AppRTCMobile/ios/ARDMainView.h",
"objc/AppRTCMobile/ios/ARDMainView.m",
"objc/AppRTCMobile/ios/ARDMainViewController.h",
"objc/AppRTCMobile/ios/ARDMainViewController.m",
Add setting to AppRTCMobile for iOS, that can change capture resolution. To achieve this, several changes needed to be made on both UI and app logic level. * Settings view controller is added (modally shown when the settings button is pressed). - From there the user can see the current capture resolution and select another capture resolution. * Model class for the capture resolution added. - Improves readability and makes separation of concerns cleaner - Handles persisting - Provides defaults - Maps video resolution setting to RTCMediaConstraints dictionary * Test for the model class In future it would be possible to extend this CL and add further settings (i.e bit rate). Also it would be easy to remove the hardcoded resolutions and use dynamic values depending on device capability. BUG=webrtc:6473 Review-Url: https://codereview.webrtc.org/2462623002 Cr-Commit-Position: refs/heads/master@{#14881}
2016-11-02 02:56:09 -07:00
"objc/AppRTCMobile/ios/ARDSettingsViewController.h",
"objc/AppRTCMobile/ios/ARDSettingsViewController.m",
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
"objc/AppRTCMobile/ios/ARDStatsView.h",
"objc/AppRTCMobile/ios/ARDStatsView.m",
"objc/AppRTCMobile/ios/ARDVideoCallView.h",
"objc/AppRTCMobile/ios/ARDVideoCallView.m",
"objc/AppRTCMobile/ios/ARDVideoCallViewController.h",
"objc/AppRTCMobile/ios/ARDVideoCallViewController.m",
AppRTCMobile iOS: Use video encoder factory to manage codec preference. List codecs from factory in settings, select by changing order in factory. Bug: webrtc:7925 Change-Id: If3c45e56713104c88705c67560325d002e6d6700 Reviewed-on: https://webrtc-review.googlesource.com/3720 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20312}
2017-10-16 13:51:43 +02:00
"objc/AppRTCMobile/ios/RTCVideoCodecInfo+HumanReadable.h",
"objc/AppRTCMobile/ios/RTCVideoCodecInfo+HumanReadable.m",
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
"objc/AppRTCMobile/ios/UIImage+ARDUtilities.h",
"objc/AppRTCMobile/ios/UIImage+ARDUtilities.m",
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
]
Make sure RTC_SUPPORTS_METAL is set in AppRTCMobile. Otherwise the metal renderer is not used on supported platforms. Bug: None Change-Id: I0da56dec1ec8900b7b251794a071663c4badb1de Reviewed-on: https://webrtc-review.googlesource.com/c/123786 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26803}
2019-02-21 16:11:40 +01:00
configs += [ "..:common_objc" ]
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
deps = [
":apprtc_common",
":apprtc_signaling",
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"../sdk:framework_objc+link",
"../sdk:ios_framework_bundle",
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
]
Finally delete deprecated mac capturer. Landing this CL will break video_loopback but cl 124827 fixes that. Bug: webrtc:6898, webrtc:6333, webrtc:7861 Change-Id: Iecbbf75fab08570cc537784f7bbd11a841a2e5a6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/124828 Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27012}
2019-03-07 10:44:26 +01:00
Convert GN libs lists to frameworks GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: chromium:1052560 Change-Id: I263230ddd3c468061584423bba9e1f887503bcaa Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178601 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#31632}
2020-07-03 10:19:30 +02:00
frameworks = [ "AVFoundation.framework" ]
Add ARDSettingsModelTests to apprtcmobile_test target. Also extract all iOS sources into a static library configuration so it's easier to include them in the test target as well. Also, fix a wrong test that was undiscovered because the tests were not running BUG=webrtc:6707 Review-Url: https://codereview.webrtc.org/2502623002 Cr-Commit-Position: refs/heads/master@{#15076}
2016-11-15 00:41:26 -08:00
}
ios_app_bundle("AppRTCMobile") {
Reland "Enable GN check for webrtc/examples" This is a reland of https://codereview.webrtc.org/2714343002 with the errors related to inclusions of test targets in webrtc/api resolved. BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2733673002 Cr-Commit-Position: refs/heads/master@{#17053}
2017-03-06 00:29:21 -08:00
testonly = true
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "objc/AppRTCMobile/ios/main.m" ]
Add ARDSettingsModelTests to apprtcmobile_test target. Also extract all iOS sources into a static library configuration so it's easier to include them in the test target as well. Also, fix a wrong test that was undiscovered because the tests were not running BUG=webrtc:6707 Review-Url: https://codereview.webrtc.org/2502623002 Cr-Commit-Position: refs/heads/master@{#15076}
2016-11-15 00:41:26 -08:00
info_plist = "objc/AppRTCMobile/ios/Info.plist"
configs += [ "..:common_config" ]
public_configs = [ "..:common_inherited_config" ]
deps = [
":AppRTCMobile_ios_bundle_data",
":AppRTCMobile_lib",
Stop using public_deps in examples. Bug: webrtc:8603 Change-Id: I1c25055109825c97e3d571efd07de79aa8c503b5 Reviewed-on: https://webrtc-review.googlesource.com/29863 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21278}
2017-12-14 13:06:10 +01:00
"../sdk:framework_objc",
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"../sdk:ios_framework_bundle",
Add ARDSettingsModelTests to apprtcmobile_test target. Also extract all iOS sources into a static library configuration so it's easier to include them in the test target as well. Also, fix a wrong test that was undiscovered because the tests were not running BUG=webrtc:6707 Review-Url: https://codereview.webrtc.org/2502623002 Cr-Commit-Position: refs/heads/master@{#15076}
2016-11-15 00:41:26 -08:00
]
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
Broadcast extension for AppRTCMobile on iOS This provides an environment for testing out using WebRTC from an iOS extension. It implements a ReplayKit broadcast extension for live streaming games and screensharing. The extension is only supported on iOS 11+ and is guarded by a build flag. Bug: webrtc:9335 Change-Id: Id218d6c73ef7599f5953c5a1e0e62e5d0dc4f10b Reviewed-on: https://webrtc-review.googlesource.com/80000 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23504}
2018-06-04 10:24:37 +02:00
if (rtc_apprtcmobile_broadcast_extension) {
deps += [
":AppRTCMobileBroadcastSetupUI_extension_bundle",
":AppRTCMobileBroadcastUpload_extension_bundle",
]
}
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
if (target_cpu == "x86") {
Cleanup BUILD.gn files from imports like foo:foo Repalce all occurrences of foo:foo in deps with just foo in BUILD.gn files. Done with Sublime regex replace. Find: \b([-a-zA-Z0-9_]+):+\1\b In: *.gn Replace with: \1 Bug: None Change-Id: I40aba1b14face687a595b852ffe443cb20197611 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127899 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27225}
2019-03-21 13:35:10 +01:00
deps += [ "//testing/iossim" ]
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
}
}
Broadcast extension for AppRTCMobile on iOS This provides an environment for testing out using WebRTC from an iOS extension. It implements a ReplayKit broadcast extension for live streaming games and screensharing. The extension is only supported on iOS 11+ and is guarded by a build flag. Bug: webrtc:9335 Change-Id: Id218d6c73ef7599f5953c5a1e0e62e5d0dc4f10b Reviewed-on: https://webrtc-review.googlesource.com/80000 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23504}
2018-06-04 10:24:37 +02:00
if (rtc_apprtcmobile_broadcast_extension) {
bundle_data("AppRTCMobileBroadcastUpload_extension_bundle") {
testonly = true
Add missing deps for android libs to unblock chromium roll Bug: None Change-Id: I1404f02cf43c3d8288fa7ae3bf128ed76856def4 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176445 Reviewed-by: Sami Kalliomäki <sakal@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31428}
2020-06-03 16:42:57 +02:00
public_deps = [ # no-presubmit-check TODO(webrtc:8603)
":AppRTCMobileBroadcastUpload", # prevent code format
]
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "$root_out_dir/AppRTCMobileBroadcastUpload.appex" ]
outputs = [ "{{bundle_contents_dir}}/Plugins/{{source_file_part}}" ]
Broadcast extension for AppRTCMobile on iOS This provides an environment for testing out using WebRTC from an iOS extension. It implements a ReplayKit broadcast extension for live streaming games and screensharing. The extension is only supported on iOS 11+ and is guarded by a build flag. Bug: webrtc:9335 Change-Id: Id218d6c73ef7599f5953c5a1e0e62e5d0dc4f10b Reviewed-on: https://webrtc-review.googlesource.com/80000 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23504}
2018-06-04 10:24:37 +02:00
}
bundle_data("AppRTCMobileBroadcastSetupUI_extension_bundle") {
testonly = true
Add missing deps for android libs to unblock chromium roll Bug: None Change-Id: I1404f02cf43c3d8288fa7ae3bf128ed76856def4 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176445 Reviewed-by: Sami Kalliomäki <sakal@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31428}
2020-06-03 16:42:57 +02:00
public_deps = [ # no-presubmit-check TODO(webrtc:8603)
":AppRTCMobileBroadcastSetupUI", # prevent code format
]
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "$root_out_dir/AppRTCMobileBroadcastSetupUI.appex" ]
outputs = [ "{{bundle_contents_dir}}/Plugins/{{source_file_part}}" ]
Broadcast extension for AppRTCMobile on iOS This provides an environment for testing out using WebRTC from an iOS extension. It implements a ReplayKit broadcast extension for live streaming games and screensharing. The extension is only supported on iOS 11+ and is guarded by a build flag. Bug: webrtc:9335 Change-Id: Id218d6c73ef7599f5953c5a1e0e62e5d0dc4f10b Reviewed-on: https://webrtc-review.googlesource.com/80000 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23504}
2018-06-04 10:24:37 +02:00
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("AppRTCMobileBroadcastUpload_lib") {
Broadcast extension for AppRTCMobile on iOS This provides an environment for testing out using WebRTC from an iOS extension. It implements a ReplayKit broadcast extension for live streaming games and screensharing. The extension is only supported on iOS 11+ and is guarded by a build flag. Bug: webrtc:9335 Change-Id: Id218d6c73ef7599f5953c5a1e0e62e5d0dc4f10b Reviewed-on: https://webrtc-review.googlesource.com/80000 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23504}
2018-06-04 10:24:37 +02:00
testonly = true
sources = [
"objc/AppRTCMobile/ios/broadcast_extension/ARDBroadcastSampleHandler.h",
"objc/AppRTCMobile/ios/broadcast_extension/ARDBroadcastSampleHandler.m",
]
deps = [
":apprtc_signaling",
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"../sdk:framework_objc+link",
"../sdk:ios_framework_bundle",
Broadcast extension for AppRTCMobile on iOS This provides an environment for testing out using WebRTC from an iOS extension. It implements a ReplayKit broadcast extension for live streaming games and screensharing. The extension is only supported on iOS 11+ and is guarded by a build flag. Bug: webrtc:9335 Change-Id: Id218d6c73ef7599f5953c5a1e0e62e5d0dc4f10b Reviewed-on: https://webrtc-review.googlesource.com/80000 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23504}
2018-06-04 10:24:37 +02:00
]
Convert GN libs lists to frameworks GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: chromium:1052560 Change-Id: I263230ddd3c468061584423bba9e1f887503bcaa Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178601 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#31632}
2020-07-03 10:19:30 +02:00
frameworks = [ "ReplayKit.framework" ]
Broadcast extension for AppRTCMobile on iOS This provides an environment for testing out using WebRTC from an iOS extension. It implements a ReplayKit broadcast extension for live streaming games and screensharing. The extension is only supported on iOS 11+ and is guarded by a build flag. Bug: webrtc:9335 Change-Id: Id218d6c73ef7599f5953c5a1e0e62e5d0dc4f10b Reviewed-on: https://webrtc-review.googlesource.com/80000 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23504}
2018-06-04 10:24:37 +02:00
}
ios_appex_bundle("AppRTCMobileBroadcastUpload") {
testonly = true
configs += [ "..:common_config" ]
public_configs = [ "..:common_inherited_config" ]
info_plist = "objc/AppRTCMobile/ios/broadcast_extension/BroadcastUploadInfo.plist"
deps = [
":AppRTCMobileBroadcastUpload_lib",
"../sdk:framework_objc",
]
}
ios_appex_bundle("AppRTCMobileBroadcastSetupUI") {
sources = [
"objc/AppRTCMobile/ios/broadcast_extension/ARDBroadcastSetupViewController.h",
"objc/AppRTCMobile/ios/broadcast_extension/ARDBroadcastSetupViewController.m",
]
info_plist = "objc/AppRTCMobile/ios/broadcast_extension/BroadcastSetupUIInfo.plist"
Convert GN libs lists to frameworks GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: chromium:1052560 Change-Id: I263230ddd3c468061584423bba9e1f887503bcaa Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178601 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#31632}
2020-07-03 10:19:30 +02:00
frameworks = [ "ReplayKit.framework" ]
Broadcast extension for AppRTCMobile on iOS This provides an environment for testing out using WebRTC from an iOS extension. It implements a ReplayKit broadcast extension for live streaming games and screensharing. The extension is only supported on iOS 11+ and is guarded by a build flag. Bug: webrtc:9335 Change-Id: Id218d6c73ef7599f5953c5a1e0e62e5d0dc4f10b Reviewed-on: https://webrtc-review.googlesource.com/80000 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23504}
2018-06-04 10:24:37 +02:00
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
deps = [ ":AppRTCMobile_ios_bundle_data" ]
Broadcast extension for AppRTCMobile on iOS This provides an environment for testing out using WebRTC from an iOS extension. It implements a ReplayKit broadcast extension for live streaming games and screensharing. The extension is only supported on iOS 11+ and is guarded by a build flag. Bug: webrtc:9335 Change-Id: Id218d6c73ef7599f5953c5a1e0e62e5d0dc4f10b Reviewed-on: https://webrtc-review.googlesource.com/80000 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23504}
2018-06-04 10:24:37 +02:00
}
}
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
bundle_data("AppRTCMobile_ios_bundle_data") {
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
sources = [
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
"objc/AppRTCMobile/ios/resources/Roboto-Regular.ttf",
Reland "Add file capturer to AppRTCMobile on simulator." This is a reland of 5adcd198752b651f7b7e9199a91f9b873b7d7237 Original change's description: > Add file capturer to AppRTCMobile on simulator. > > To achieve this, the CL does the following > - Adds sample mp4 video > - Refactors the existing RTCFileVideoCapturer to achieve continious > capture and adds tests. > > Bug: webrtc:8406 > Change-Id: Ibc0891176c58ec9053b42e340d2113036e7199ec > Reviewed-on: https://webrtc-review.googlesource.com/12180 > Reviewed-by: Anders Carlsson <andersc@webrtc.org> > Reviewed-by: Magnus Jedvert <magjed@webrtc.org> > Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#20598} Bug: webrtc:8406 Change-Id: I93be89b86e342a9a8195e19ebaf4aef1410d2c20 Reviewed-on: https://webrtc-review.googlesource.com/23200 Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20870}
2017-11-15 13:15:24 +01:00
# Sample video taken from https://media.xiph.org/video/derf/
"objc/AppRTCMobile/ios/resources/foreman.mp4",
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
"objc/AppRTCMobile/ios/resources/iPhone5@2x.png",
"objc/AppRTCMobile/ios/resources/iPhone6@2x.png",
"objc/AppRTCMobile/ios/resources/iPhone6p@3x.png",
"objc/AppRTCMobile/ios/resources/ic_call_end_black_24dp.png",
"objc/AppRTCMobile/ios/resources/ic_call_end_black_24dp@2x.png",
"objc/AppRTCMobile/ios/resources/ic_clear_black_24dp.png",
"objc/AppRTCMobile/ios/resources/ic_clear_black_24dp@2x.png",
Add UINavigationController and settings bar button to AppRTCMobile. The navigation controller is used to display the title of the app and to feature the settings button. This work is foundation for adding settings screen to the app (see webrtc:6473 for more info) BUG=webrtc:6618, webrtc:6473 Review-Url: https://codereview.webrtc.org/2455363002 Cr-Commit-Position: refs/heads/master@{#14816}
2016-10-28 04:53:16 -07:00
"objc/AppRTCMobile/ios/resources/ic_settings_black_24dp.png",
"objc/AppRTCMobile/ios/resources/ic_settings_black_24dp@2x.png",
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
"objc/AppRTCMobile/ios/resources/ic_surround_sound_black_24dp.png",
"objc/AppRTCMobile/ios/resources/ic_surround_sound_black_24dp@2x.png",
"objc/AppRTCMobile/ios/resources/ic_switch_video_black_24dp.png",
"objc/AppRTCMobile/ios/resources/ic_switch_video_black_24dp@2x.png",
"objc/AppRTCMobile/ios/resources/mozart.mp3",
AppRTCMobile: Use high resolution app icon on retina screens. Finally, no more hurting your eyes when looking at the app icon on a retina device. BUG=None TBR=magjed@webrtc.org Review-Url: https://codereview.webrtc.org/3001693002 Cr-Commit-Position: refs/heads/master@{#19351}
2017-08-15 04:07:12 -07:00
"objc/Icon-120.png",
"objc/Icon-180.png",
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
"objc/Icon.png",
]
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
outputs = [ "{{bundle_resources_dir}}/{{source_file_part}}" ]
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
}
Add an example app for iOS native API. Demonstrates how to use the iOS native API to wrap components into C++ classes. This CL also introduces a native API wrapper for the capturer. The C++ code is forked from the corresponding CL for Android at https://webrtc-review.googlesource.com/c/src/+/60540 Bug: webrtc:8832 Change-Id: I12d9f30e701c0222628e329218f6d5bfca26e6e0 Reviewed-on: https://webrtc-review.googlesource.com/61422 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22484}
2018-03-15 09:41:03 +01:00
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("ObjCNativeAPIDemo_lib") {
Add an example app for iOS native API. Demonstrates how to use the iOS native API to wrap components into C++ classes. This CL also introduces a native API wrapper for the capturer. The C++ code is forked from the corresponding CL for Android at https://webrtc-review.googlesource.com/c/src/+/60540 Bug: webrtc:8832 Change-Id: I12d9f30e701c0222628e329218f6d5bfca26e6e0 Reviewed-on: https://webrtc-review.googlesource.com/61422 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22484}
2018-03-15 09:41:03 +01:00
testonly = true
sources = [
"objcnativeapi/objc/NADAppDelegate.h",
"objcnativeapi/objc/NADAppDelegate.m",
"objcnativeapi/objc/NADViewController.h",
"objcnativeapi/objc/NADViewController.mm",
(4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries Mechanically generated by running this command: tools_webrtc/do-renames.sh update all-renames.txt && git cl format Then manually updating: tools_webrtc/sanitizers/tsan_suppressions_webrtc.cc Bug: webrtc:10159 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I54824cd91dada8fc3ee3d098f971bc319d477833 Reviewed-on: https://webrtc-review.googlesource.com/c/115653 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26226}
2019-01-11 09:11:00 -08:00
"objcnativeapi/objc/objc_call_client.h",
"objcnativeapi/objc/objc_call_client.mm",
Add an example app for iOS native API. Demonstrates how to use the iOS native API to wrap components into C++ classes. This CL also introduces a native API wrapper for the capturer. The C++ code is forked from the corresponding CL for Android at https://webrtc-review.googlesource.com/c/src/+/60540 Bug: webrtc:8832 Change-Id: I12d9f30e701c0222628e329218f6d5bfca26e6e0 Reviewed-on: https://webrtc-review.googlesource.com/61422 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22484}
2018-03-15 09:41:03 +01:00
]
deps = [
"../api:libjingle_peerconnection_api",
Remove rtc_base/scoped_ref_ptr.h. The type rtc::scoped_refptr<T> is now part of api/. Please include it from api/scoped_refptr.h. More info: See: https://groups.google.com/forum/#!topic/discuss-webrtc/Mme2MSz4z4o. Bug: webrtc:9887, webrtc:8205 No-Try: True Change-Id: Ic6c7c81e226e59f12f7933e472f573ae097b55bf Reviewed-on: https://webrtc-review.googlesource.com/c/119041 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26414}
2019-01-25 20:26:48 +01:00
"../api:scoped_refptr",
Add an example app for iOS native API. Demonstrates how to use the iOS native API to wrap components into C++ classes. This CL also introduces a native API wrapper for the capturer. The C++ code is forked from the corresponding CL for Android at https://webrtc-review.googlesource.com/c/src/+/60540 Bug: webrtc:8832 Change-Id: I12d9f30e701c0222628e329218f6d5bfca26e6e0 Reviewed-on: https://webrtc-review.googlesource.com/61422 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22484}
2018-03-15 09:41:03 +01:00
"../api/audio_codecs:builtin_audio_decoder_factory",
"../api/audio_codecs:builtin_audio_encoder_factory",
Delete RtcEventLogFactory factory as now unused Bug: webrtc:10206, webrtc:10284 Change-Id: I34fa780f566b52e375ec625bf0d5d02c505d9912 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/143782 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28400}
2019-06-26 15:49:47 +02:00
"../api/rtc_event_log:rtc_event_log_factory",
Use single argument PeerConnectionFactory factory in objc code Bug: webrtc:10284 Change-Id: If656af94636731d1caa208db78e460740edbf83c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/137422 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28002}
2019-05-17 13:20:14 +02:00
"../api/task_queue:default_task_queue_factory",
Add an example app for iOS native API. Demonstrates how to use the iOS native API to wrap components into C++ classes. This CL also introduces a native API wrapper for the capturer. The C++ code is forked from the corresponding CL for Android at https://webrtc-review.googlesource.com/c/src/+/60540 Bug: webrtc:8832 Change-Id: I12d9f30e701c0222628e329218f6d5bfca26e6e0 Reviewed-on: https://webrtc-review.googlesource.com/61422 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22484}
2018-03-15 09:41:03 +01:00
"../media:rtc_audio_video",
Cleanup BUILD.gn files from imports like foo:foo Repalce all occurrences of foo:foo in deps with just foo in BUILD.gn files. Done with Sublime regex replace. Find: \b([-a-zA-Z0-9_]+):+\1\b In: *.gn Replace with: \1 Bug: None Change-Id: I40aba1b14face687a595b852ffe443cb20197611 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127899 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27225}
2019-03-21 13:35:10 +01:00
"../modules/audio_processing",
Reland "Isolating APM API build target: making :api an actual target." This reverts commit 61c6e5643e7ea058e653956980a90e033249c055. Reason for revert: downstream projects prepared for this change Original change's description: > Revert "Isolating APM API build target: making :api an actual target." > > This reverts commit a7f77a7c05b5d26520fd01a773ffb2c8b15b60ff. > > Reason for revert: breaking downstream > > Original change's description: > > Isolating APM API build target: making :api an actual target. > > > > This CL is part of a refactoring work to unblock other CLs > > that would generate a circular dependency when including > > modules/audio_processing. It will also allow to easily move > > the APM interface part under //api. > > > > More in detail, this change moves the APM interface files from > > the build target modules/audio_processing to > > modules/audio_processing:api. It also adds :api as dependency > > where needed. > > > > Bug: webrtc:9535 > > Change-Id: I72829e22d08ba4d75985f0421e6e8bf0216ebecd > > Reviewed-on: https://webrtc-review.googlesource.com/c/109501 > > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > > Reviewed-by: Kári Helgason <kthelgason@webrtc.org> > > Reviewed-by: Niels Moller <nisse@webrtc.org> > > Reviewed-by: Sam Zackrisson <saza@webrtc.org> > > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#25539} > > TBR=saza@webrtc.org,alessiob@webrtc.org,kwiberg@webrtc.org,nisse@webrtc.org,kthelgason@webrtc.org > > Change-Id: I974c6237311e7c06970aa62e5f6940f3aa80113d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:9535 > Reviewed-on: https://webrtc-review.googlesource.com/c/109820 > Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#25540} TBR=saza@webrtc.org,alessiob@webrtc.org,kwiberg@webrtc.org,nisse@webrtc.org,kthelgason@webrtc.org Change-Id: Ic8ed4cc3baf43d639ce13cae256c007728c3ad92 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:9535 Reviewed-on: https://webrtc-review.googlesource.com/c/109884 Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25547}
2018-11-07 14:29:54 +00:00
"../modules/audio_processing:api",
Add an example app for iOS native API. Demonstrates how to use the iOS native API to wrap components into C++ classes. This CL also introduces a native API wrapper for the capturer. The C++ code is forked from the corresponding CL for Android at https://webrtc-review.googlesource.com/c/src/+/60540 Bug: webrtc:8832 Change-Id: I12d9f30e701c0222628e329218f6d5bfca26e6e0 Reviewed-on: https://webrtc-review.googlesource.com/61422 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22484}
2018-03-15 09:41:03 +01:00
"../pc:libjingle_peerconnection",
Cleanup BUILD.gn files from imports like foo:foo Repalce all occurrences of foo:foo in deps with just foo in BUILD.gn files. Done with Sublime regex replace. Find: \b([-a-zA-Z0-9_]+):+\1\b In: *.gn Replace with: \1 Bug: None Change-Id: I40aba1b14face687a595b852ffe443cb20197611 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127899 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27225}
2019-03-21 13:35:10 +01:00
"../rtc_base",
Migrate common_video/ and examples/ to webrtc::Mutex. Bug: webrtc:11567 Change-Id: I8e01c8adf1e5a0326e7956bdc635cfd3679a0d1a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176743 Reviewed-by: Magnus Flodman <mflodman@webrtc.org> Commit-Queue: Markus Handell <handellm@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31647}
2020-07-07 09:17:56 +02:00
"../rtc_base/synchronization:mutex",
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"../sdk:base_objc",
Add an example app for iOS native API. Demonstrates how to use the iOS native API to wrap components into C++ classes. This CL also introduces a native API wrapper for the capturer. The C++ code is forked from the corresponding CL for Android at https://webrtc-review.googlesource.com/c/src/+/60540 Bug: webrtc:8832 Change-Id: I12d9f30e701c0222628e329218f6d5bfca26e6e0 Reviewed-on: https://webrtc-review.googlesource.com/61422 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22484}
2018-03-15 09:41:03 +01:00
"../sdk:default_codec_factory_objc",
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"../sdk:helpers_objc",
Add an example app for iOS native API. Demonstrates how to use the iOS native API to wrap components into C++ classes. This CL also introduces a native API wrapper for the capturer. The C++ code is forked from the corresponding CL for Android at https://webrtc-review.googlesource.com/c/src/+/60540 Bug: webrtc:8832 Change-Id: I12d9f30e701c0222628e329218f6d5bfca26e6e0 Reviewed-on: https://webrtc-review.googlesource.com/61422 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22484}
2018-03-15 09:41:03 +01:00
"../sdk:native_api",
"../sdk:ui_objc",
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"../sdk:videocapture_objc",
Add an example app for iOS native API. Demonstrates how to use the iOS native API to wrap components into C++ classes. This CL also introduces a native API wrapper for the capturer. The C++ code is forked from the corresponding CL for Android at https://webrtc-review.googlesource.com/c/src/+/60540 Bug: webrtc:8832 Change-Id: I12d9f30e701c0222628e329218f6d5bfca26e6e0 Reviewed-on: https://webrtc-review.googlesource.com/61422 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22484}
2018-03-15 09:41:03 +01:00
"../sdk:videotoolbox_objc",
]
if (current_cpu == "arm64") {
deps += [ "../sdk:metal_objc" ]
}
}
ios_app_bundle("ObjCNativeAPIDemo") {
testonly = true
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "objcnativeapi/objc/main.m" ]
Add an example app for iOS native API. Demonstrates how to use the iOS native API to wrap components into C++ classes. This CL also introduces a native API wrapper for the capturer. The C++ code is forked from the corresponding CL for Android at https://webrtc-review.googlesource.com/c/src/+/60540 Bug: webrtc:8832 Change-Id: I12d9f30e701c0222628e329218f6d5bfca26e6e0 Reviewed-on: https://webrtc-review.googlesource.com/61422 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22484}
2018-03-15 09:41:03 +01:00
info_plist = "objcnativeapi/Info.plist"
configs += [ "..:common_config" ]
public_configs = [ "..:common_inherited_config" ]
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
deps = [ ":ObjCNativeAPIDemo_lib" ]
Add an example app for iOS native API. Demonstrates how to use the iOS native API to wrap components into C++ classes. This CL also introduces a native API wrapper for the capturer. The C++ code is forked from the corresponding CL for Android at https://webrtc-review.googlesource.com/c/src/+/60540 Bug: webrtc:8832 Change-Id: I12d9f30e701c0222628e329218f6d5bfca26e6e0 Reviewed-on: https://webrtc-review.googlesource.com/61422 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22484}
2018-03-15 09:41:03 +01:00
if (target_cpu == "x86") {
Cleanup BUILD.gn files from imports like foo:foo Repalce all occurrences of foo:foo in deps with just foo in BUILD.gn files. Done with Sublime regex replace. Find: \b([-a-zA-Z0-9_]+):+\1\b In: *.gn Replace with: \1 Bug: None Change-Id: I40aba1b14face687a595b852ffe443cb20197611 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127899 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27225}
2019-03-21 13:35:10 +01:00
deps += [ "//testing/iossim" ]
Add an example app for iOS native API. Demonstrates how to use the iOS native API to wrap components into C++ classes. This CL also introduces a native API wrapper for the capturer. The C++ code is forked from the corresponding CL for Android at https://webrtc-review.googlesource.com/c/src/+/60540 Bug: webrtc:8832 Change-Id: I12d9f30e701c0222628e329218f6d5bfca26e6e0 Reviewed-on: https://webrtc-review.googlesource.com/61422 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22484}
2018-03-15 09:41:03 +01:00
}
}
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
}
if (is_mac) {
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("AppRTCMobile_lib") {
Reland "Enable GN check for webrtc/examples" This is a reland of https://codereview.webrtc.org/2714343002 with the errors related to inclusions of test targets in webrtc/api resolved. BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2733673002 Cr-Commit-Position: refs/heads/master@{#17053}
2017-03-06 00:29:21 -08:00
testonly = true
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
sources = [
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
"objc/AppRTCMobile/mac/APPRTCAppDelegate.h",
"objc/AppRTCMobile/mac/APPRTCAppDelegate.m",
"objc/AppRTCMobile/mac/APPRTCViewController.h",
"objc/AppRTCMobile/mac/APPRTCViewController.m",
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
]
Use relative paths in GN files. BUG=webrtc:7952 TBR=kjellander@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2974863003 Cr-Commit-Position: refs/heads/master@{#18970}
2017-07-11 06:20:45 -07:00
configs += [ "..:common_objc" ]
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
deps = [
":apprtc_common",
":apprtc_signaling",
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"../sdk:mac_framework_objc+link",
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
]
}
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
mac_app_bundle("AppRTCMobile") {
Reland "Enable GN check for webrtc/examples" This is a reland of https://codereview.webrtc.org/2714343002 with the errors related to inclusions of test targets in webrtc/api resolved. BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2733673002 Cr-Commit-Position: refs/heads/master@{#17053}
2017-03-06 00:29:21 -08:00
testonly = true
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
output_name = "AppRTCMobile"
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "objc/AppRTCMobile/mac/main.m" ]
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
public_configs = [ "..:common_inherited_config" ]
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
info_plist = "objc/AppRTCMobile/mac/Info.plist"
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
Convert GN libs lists to frameworks GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: chromium:1052560 Change-Id: I263230ddd3c468061584423bba9e1f887503bcaa Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178601 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#31632}
2020-07-03 10:19:30 +02:00
frameworks = [ "AppKit.framework" ]
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
Set @rpath in AppRTCMobile for macOS. Without this, the application can't find the WebRTC dynamic library when started from the built app bundle (debugging in Xcode worked). Bug: webrtc:10111 Change-Id: I1610948aae070fe9938e873ce073e05ba7255c7d Reviewed-on: https://webrtc-review.googlesource.com/c/113805 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25949}
2018-12-10 14:04:12 +01:00
ldflags = [
"-rpath",
"@executable_path/../Frameworks",
]
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
deps = [
Add ARDSettingsModelTests to apprtcmobile_test target. Also extract all iOS sources into a static library configuration so it's easier to include them in the test target as well. Also, fix a wrong test that was undiscovered because the tests were not running BUG=webrtc:6707 Review-Url: https://codereview.webrtc.org/2502623002 Cr-Commit-Position: refs/heads/master@{#15076}
2016-11-15 00:41:26 -08:00
":AppRTCMobile_lib",
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"../sdk:mac_framework_bundle",
"../sdk:mac_framework_objc+link",
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
]
}
}
config("socketrocket_include_config") {
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
include_dirs = [ "objc/AppRTCMobile/third_party/SocketRocket" ]
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
}
config("socketrocket_warning_config") {
# GN orders flags on a target before flags from configs. The default config
# adds these flags so to cancel them out they need to come from a config and
# cannot be on the target directly.
cflags = [
"-Wno-deprecated-declarations",
"-Wno-nonnull",
"-Wno-semicolon-before-method-body",
Revert of Remove some warning suppressions from SocketRocket. (patchset #1 id:1 of https://codereview.webrtc.org/2704383004/ ) Reason for revert: Breaks buildbot Original issue's description: > Remove some warning suppressions from SocketRocket. > > These warnings started appearing on a clang update. This CL patches the > vendored library and removes the supression. We assert on the return as > we're not equipped to deal with failures there anyway. > > BUG=webrtc:6396 > NOTRY=true > > Review-Url: https://codereview.webrtc.org/2704383004 > Cr-Commit-Position: refs/heads/master@{#16820} > Committed: https://chromium.googlesource.com/external/webrtc/+/49990e88fb523901b28d10f2026602cb86528b0d TBR=kjellander@webrtc.org,magjed@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6396 Review-Url: https://codereview.webrtc.org/2714123002 Cr-Commit-Position: refs/heads/master@{#16822}
2017-02-24 01:56:01 -08:00
"-Wno-unused-variable",
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
]
Ignores warning for SecRandomCopyBytes() using Xcode 8 BUG=webrtc:6396 NOTRY=TRUE TBR=kjellander Review-Url: https://codereview.webrtc.org/2356073004 Cr-Commit-Position: refs/heads/master@{#14326}
2016-09-21 04:13:00 -07:00
cflags_objc = [
# Enabled for cflags_objc in build/config/compiler/BUILD.gn.
"-Wno-objc-missing-property-synthesis",
]
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("socketrocket") {
Reland "Enable GN check for webrtc/examples" This is a reland of https://codereview.webrtc.org/2714343002 with the errors related to inclusions of test targets in webrtc/api resolved. BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2733673002 Cr-Commit-Position: refs/heads/master@{#17053}
2017-03-06 00:29:21 -08:00
testonly = true
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
sources = [
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 10:10:41 +02:00
"objc/AppRTCMobile/third_party/SocketRocket/SRWebSocket.h",
"objc/AppRTCMobile/third_party/SocketRocket/SRWebSocket.m",
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
]
Reland of GN: Enable ARC for Mac and iOS in rtc_* templates (patchset #1 id:1 of https://codereview.webrtc.org/2827223003/ ) Reason for revert: Relanding after fixing ARC issue. Original issue's description: > Revert of GN: Enable ARC for Mac and iOS in rtc_* templates (patchset #3 id:40001 of https://codereview.webrtc.org/2781713004/ ) > > Reason for revert: > Breaks mac build > > Original issue's description: > > GN: Enable ARC for Mac and iOS in rtc_* templates > > > > Remove all uses of retain/release and NSAutoreleasePool. > > > > This makes transformation to Bazel easier. > > > > This CL subsumes https://codereview.webrtc.org/2778163002 and depends on https://codereview.webrtc.org/2784483002/ > > > > BUG=webrtc:6412 > > > > Review-Url: https://codereview.webrtc.org/2781713004 > > Cr-Commit-Position: refs/heads/master@{#17780} > > Committed: https://chromium.googlesource.com/external/webrtc/+/6bda02b51dc00401d2a0d04be996ed10e5acac47 > > TBR=kjellander@webrtc.org,magjed@webrtc.org,stefan@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6412 > > Review-Url: https://codereview.webrtc.org/2827223003 > Cr-Commit-Position: refs/heads/master@{#17784} > Committed: https://chromium.googlesource.com/external/webrtc/+/7c8786ae8f2d8481f74b0ab16eb91a8101fe51dc TBR=kjellander@webrtc.org,magjed@webrtc.org,stefan@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6412 Review-Url: https://codereview.webrtc.org/2834273002 Cr-Commit-Position: refs/heads/master@{#17836}
2017-04-24 00:57:16 -07:00
configs += [ ":socketrocket_warning_config" ]
GN Templates: Move common_inherited_config to the template. Remove common_inherited_config from the targets and add it to the template instead. BUG=webrtc:6187 NOTRY=True Review-Url: https://codereview.webrtc.org/2311843002 Cr-Commit-Position: refs/heads/master@{#14069}
2016-09-05 06:10:18 -07:00
public_configs = [ ":socketrocket_include_config" ]
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
Convert GN libs lists to frameworks GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: chromium:1052560 Change-Id: I263230ddd3c468061584423bba9e1f887503bcaa Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178601 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#31632}
2020-07-03 10:19:30 +02:00
libs = [ "icucore" ]
frameworks = [
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
"CFNetwork.framework",
Reland "Don't use all_dependent_configs for sdk frameworks" This is a reland of 63741c7fa1aa55a38af11ac8cc04498722f9407d It's possible to reland after the downstream fix in https://chromium-review.googlesource.com/1730415 Original change's description: > Don't use all_dependent_configs for sdk frameworks > > libs should be propagated to the final binary even without that: > https://gn.googlesource.com/gn/+/master/docs/reference.md#var_libs > > But add some missing SDK framework dependencies: > > * RTCNativeI420Buffer.mm uses CGBitmapContextGetBytesPerRow. > * socketrocket uses SecCertificateCopyData. > > Bug: None > Change-Id: Iba38a5dfaf470a5a790d494cbec8ade44b1d16ba > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146082 > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Commit-Queue: Oleh Prypin <oprypin@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#28605} Bug: None Change-Id: I6a1cd80c5177ef3a3b92ee55fc91e187b202d864 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/147720 Commit-Queue: Oleh Prypin <oprypin@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28740}
2019-07-18 22:25:48 +02:00
"Security.framework",
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
]
}
Add a GN target for unit tests, get them working again and added a test. BUG=webrtc:3417 Review-Url: https://codereview.webrtc.org/2050153003 Cr-Commit-Position: refs/heads/master@{#14959}
2016-11-07 14:53:28 -08:00
if (rtc_include_tests) {
Move iOS tests to XCTest from gtest. This enables tighter integration with XCode tooling and is a prereq for adding UI tests. BUG=webrtc:7150 Review-Url: https://codereview.webrtc.org/2697603002 Cr-Commit-Position: refs/heads/master@{#16609}
2017-02-14 04:58:56 -08:00
# TODO(kthelgason): compile xctests on mac when chromium supports it.
if (is_ios) {
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("apprtcmobile_test_sources") {
Re-enabling 'gn check' on //examples/*. Bug: webrtc:8850 Change-Id: I7397bc17e0f790a31d417d1bf5db6c5f9e32088d No-Presubmit: true Reviewed-on: https://webrtc-review.googlesource.com/54314 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22085}
2018-02-19 15:14:04 +01:00
# iOS must use WebRTC.framework which is dynamically linked.
Reland "Enable GN check for webrtc/examples" This is a reland of https://codereview.webrtc.org/2714343002 with the errors related to inclusions of test targets in webrtc/api resolved. BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2733673002 Cr-Commit-Position: refs/heads/master@{#17053}
2017-03-06 00:29:21 -08:00
testonly = true
Move iOS tests to XCTest from gtest. This enables tighter integration with XCode tooling and is a prereq for adding UI tests. BUG=webrtc:7150 Review-Url: https://codereview.webrtc.org/2697603002 Cr-Commit-Position: refs/heads/master@{#16609}
2017-02-14 04:58:56 -08:00
include_dirs = [
"objc/AppRTCMobile",
"objc/AppRTCMobile/ios",
]
sources = [
"objc/AppRTCMobile/tests/ARDAppClient_xctest.mm",
Reland "Add file capturer to AppRTCMobile on simulator." This is a reland of 5adcd198752b651f7b7e9199a91f9b873b7d7237 Original change's description: > Add file capturer to AppRTCMobile on simulator. > > To achieve this, the CL does the following > - Adds sample mp4 video > - Refactors the existing RTCFileVideoCapturer to achieve continious > capture and adds tests. > > Bug: webrtc:8406 > Change-Id: Ibc0891176c58ec9053b42e340d2113036e7199ec > Reviewed-on: https://webrtc-review.googlesource.com/12180 > Reviewed-by: Anders Carlsson <andersc@webrtc.org> > Reviewed-by: Magnus Jedvert <magjed@webrtc.org> > Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#20598} Bug: webrtc:8406 Change-Id: I93be89b86e342a9a8195e19ebaf4aef1410d2c20 Reviewed-on: https://webrtc-review.googlesource.com/23200 Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20870}
2017-11-15 13:15:24 +01:00
"objc/AppRTCMobile/tests/ARDFileCaptureController_xctest.mm",
Move iOS tests to XCTest from gtest. This enables tighter integration with XCode tooling and is a prereq for adding UI tests. BUG=webrtc:7150 Review-Url: https://codereview.webrtc.org/2697603002 Cr-Commit-Position: refs/heads/master@{#16609}
2017-02-14 04:58:56 -08:00
"objc/AppRTCMobile/tests/ARDSettingsModel_xctest.mm",
]
Reland "Enable GN check for webrtc/examples" This is a reland of https://codereview.webrtc.org/2714343002 with the errors related to inclusions of test targets in webrtc/api resolved. BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2733673002 Cr-Commit-Position: refs/heads/master@{#17053}
2017-03-06 00:29:21 -08:00
deps = [
Move iOS tests to XCTest from gtest. This enables tighter integration with XCode tooling and is a prereq for adding UI tests. BUG=webrtc:7150 Review-Url: https://codereview.webrtc.org/2697603002 Cr-Commit-Position: refs/heads/master@{#16609}
2017-02-14 04:58:56 -08:00
":AppRTCMobile_lib",
Re-enabling 'gn check' on //examples/*. Bug: webrtc:8850 Change-Id: I7397bc17e0f790a31d417d1bf5db6c5f9e32088d No-Presubmit: true Reviewed-on: https://webrtc-review.googlesource.com/54314 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22085}
2018-02-19 15:14:04 +01:00
":apprtc_signaling",
Cleanup BUILD.gn files from imports like foo:foo Repalce all occurrences of foo:foo in deps with just foo in BUILD.gn files. Done with Sublime regex replace. Find: \b([-a-zA-Z0-9_]+):+\1\b In: *.gn Replace with: \1 Bug: None Change-Id: I40aba1b14face687a595b852ffe443cb20197611 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127899 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27225}
2019-03-21 13:35:10 +01:00
"../rtc_base",
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"../sdk:framework_objc+link",
"../sdk:ios_framework_bundle",
Move iOS tests to XCTest from gtest. This enables tighter integration with XCode tooling and is a prereq for adding UI tests. BUG=webrtc:7150 Review-Url: https://codereview.webrtc.org/2697603002 Cr-Commit-Position: refs/heads/master@{#16609}
2017-02-14 04:58:56 -08:00
"//build/config/ios:xctest",
"//third_party/ocmock",
]
}
Add a GN target for unit tests, get them working again and added a test. BUG=webrtc:3417 Review-Url: https://codereview.webrtc.org/2050153003 Cr-Commit-Position: refs/heads/master@{#14959}
2016-11-07 14:53:28 -08:00
Reland "Switch from rtc_ios_xctest_test to rtc_test". This is a reland of https://webrtc-review.googlesource.com/c/src/+/182680, and it is based on https://chromium-review.googlesource.com/c/chromium/src/+/2414169 which allows to force a "test" to be executed as an XCtest on a build target basis instead of on a GN args basis like it was happening in https://webrtc-review.googlesource.com/c/src/+/182680 because that was causing issues when launching tests on real devices. Bug: webrtc:11881, webrtc:11937 Change-Id: I4bec7f471cd0f878b6050f266cd0cca3b518d415 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184360 Reviewed-by: Dirk Pranke <dpranke@google.com> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32126}
2020-09-16 15:09:53 +02:00
rtc_test("apprtcmobile_tests") {
is_xctest = true
Add a GN target for unit tests, get them working again and added a test. BUG=webrtc:3417 Review-Url: https://codereview.webrtc.org/2050153003 Cr-Commit-Position: refs/heads/master@{#14959}
2016-11-07 14:53:28 -08:00
info_plist = "objc/AppRTCMobile/ios/Info.plist"
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "objc/AppRTCMobile/tests/main.mm" ]
Move iOS tests to XCTest from gtest. This enables tighter integration with XCode tooling and is a prereq for adding UI tests. BUG=webrtc:7150 Review-Url: https://codereview.webrtc.org/2697603002 Cr-Commit-Position: refs/heads/master@{#16609}
2017-02-14 04:58:56 -08:00
deps = [
Re-enabling 'gn check' on //examples/*. Bug: webrtc:8850 Change-Id: I7397bc17e0f790a31d417d1bf5db6c5f9e32088d No-Presubmit: true Reviewed-on: https://webrtc-review.googlesource.com/54314 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22085}
2018-02-19 15:14:04 +01:00
":AppRTCMobile_lib",
Move iOS tests to XCTest from gtest. This enables tighter integration with XCode tooling and is a prereq for adding UI tests. BUG=webrtc:7150 Review-Url: https://codereview.webrtc.org/2697603002 Cr-Commit-Position: refs/heads/master@{#16609}
2017-02-14 04:58:56 -08:00
":apprtcmobile_test_sources",
Stop using public_deps in examples. Bug: webrtc:8603 Change-Id: I1c25055109825c97e3d571efd07de79aa8c503b5 Reviewed-on: https://webrtc-review.googlesource.com/29863 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21278}
2017-12-14 13:06:10 +01:00
"../sdk:framework_objc",
Add support for computing iOS code coverage Also disable failing PosixSignalDeliveryTest* tests for iOS Bug: chromium:844647 Change-Id: I64bb233bef2f06f6778f2d475b6d3ad685fb9143 Reviewed-on: https://webrtc-review.googlesource.com/c/105641 Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Reviewed-by: Artem Titarenko <artit@webrtc.org> Commit-Queue: Artem Titarenko <artit@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25524}
2018-11-06 12:29:29 +01:00
"//test:test_support",
Move iOS tests to XCTest from gtest. This enables tighter integration with XCode tooling and is a prereq for adding UI tests. BUG=webrtc:7150 Review-Url: https://codereview.webrtc.org/2697603002 Cr-Commit-Position: refs/heads/master@{#16609}
2017-02-14 04:58:56 -08:00
]
ldflags = [ "-all_load" ]
Add a GN target for unit tests, get them working again and added a test. BUG=webrtc:3417 Review-Url: https://codereview.webrtc.org/2050153003 Cr-Commit-Position: refs/heads/master@{#14959}
2016-11-07 14:53:28 -08:00
}
}
}
GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Review-Url: https://codereview.webrtc.org/2211413003 Cr-Commit-Position: refs/heads/master@{#13666}
2016-08-07 21:37:45 -07:00
}
Create gn target for peerconnection examples BUG= Review-Url: https://codereview.webrtc.org/2218053002 Cr-Commit-Position: refs/heads/master@{#13673}
2016-08-08 09:03:23 -07:00
Expand is_linux to is_linux || is_chromeos. Currently is_linux is set to true on Chrome OS build, but it is planned to be set false. This CL is the preparation to keep the compatibility. Bug: chromium:1110266 Test: Build locally. Change-Id: Ic79a202b0b3baeff157955cd03a07556bfb958a8 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/183860 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#32073}
2020-09-10 18:10:11 +09:00
if (is_linux || is_chromeos || is_win) {
GN: Introduce templates. Defines the rtc_executable, rtc_source_set, rtc_test and rtc_static_library templates. These templates provide no functionality yet, but will enable common configuration to be introduced, avoiding repetition in every target Changes summary: - Prepend rtc_ to test, source_set, executable and static_library targets - Change "configs -= [" to "suppressed_configs += [" - Include webrtc/build/webrtc.gni where it wasn't included yet - Delete import("//testing/test.gni"), since rtc_test makes it unnecessary. BUG=webrtc:6187 TBR=henrik.lundin@webrtc.org,tommi@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2301053002 Cr-Commit-Position: refs/heads/master@{#14043}
2016-09-02 04:10:34 -07:00
rtc_executable("peerconnection_client") {
Reland "Enable GN check for webrtc/examples" This is a reland of https://codereview.webrtc.org/2714343002 with the errors related to inclusions of test targets in webrtc/api resolved. BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2733673002 Cr-Commit-Position: refs/heads/master@{#17053}
2017-03-06 00:29:21 -08:00
testonly = true
Create gn target for peerconnection examples BUG= Review-Url: https://codereview.webrtc.org/2218053002 Cr-Commit-Position: refs/heads/master@{#13673}
2016-08-08 09:03:23 -07:00
sources = [
"peerconnection/client/conductor.cc",
"peerconnection/client/conductor.h",
"peerconnection/client/defaults.cc",
"peerconnection/client/defaults.h",
"peerconnection/client/peer_connection_client.cc",
"peerconnection/client/peer_connection_client.h",
]
GN Templates: Move common_config to the template. Remove common_config from the targets' config and add it to the template instead. BUG=webrtc:6187 NOTRY=True Review-Url: https://codereview.webrtc.org/2300413002 Cr-Commit-Position: refs/heads/master@{#14063}
2016-09-05 01:35:44 -07:00
Separate i420 and i444 implementations to separate targets. This means we can properly declare the dependency between libjingle_peerconnection_api and video_frame_api. i420 pulls in system_wrappers, which can't be a dependency of the public API. Plan: 1) Land this CL + send out PSA 2) Make all direct users of i420_buffer depend on the new video_frame_api_i420 target 3) Move i420_buffer.cc to the new target 4) Make libjingle_peerconnection_api depend on video_frame_api, since it no longer contains i420 code Bug: webrtc:7504 Change-Id: I30d90f2ac7af53748859bbde8aed92386d5501f9 Reviewed-on: https://webrtc-review.googlesource.com/9382 Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20656}
2017-11-13 10:19:58 +01:00
deps = [
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2. This is a follow-up to https://webrtc-review.googlesource.com/c/src/+/106280. This time the whole code base is covered. Some files may have not been fixed though, whenever the IWYU tool was breaking the build. Bug: webrtc:8311 Change-Id: I2c31f552a87e887d33931d46e87b6208b1e483ef Reviewed-on: https://webrtc-review.googlesource.com/c/111965 Commit-Queue: Yves Gerey <yvesg@google.com> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25830}
2018-11-28 16:47:49 +01:00
"../api:audio_options_api",
Move webrtc::CreatePeerConnectionFactory definition next to decl. This CL moves webrtc::CreatePeerConnectionFactory definitions out of pc:create_pc_factory and merges it with its declaration in the api/ directory. In order to avoid circular dependencies a new build target is created: * api:create_peerconnection_factory Bug: webrtc:9862 Change-Id: Ie215c94460cba026f5bf7d11c9a5aa03792064af Reviewed-on: https://webrtc-review.googlesource.com/c/111186 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25744}
2018-11-22 09:00:13 +01:00
"../api:create_peerconnection_factory",
Stop using public_deps in api/. Bug: webrtc:8603 Change-Id: I12f91365fa9a3ed12be1a9658999b6f6aad7e5e3 No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/33220 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21584}
2018-01-11 10:13:56 +01:00
"../api:libjingle_peerconnection_api",
New build target api:media_interface Bug: webrtc:8733 Change-Id: I84bbefb1a5ef8e592db29b79499d60ac80c23464 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153180 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Steve Anton <steveanton@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29234}
2019-09-17 14:30:41 +02:00
"../api:media_stream_interface",
Remove rtc_base/scoped_ref_ptr.h. The type rtc::scoped_refptr<T> is now part of api/. Please include it from api/scoped_refptr.h. More info: See: https://groups.google.com/forum/#!topic/discuss-webrtc/Mme2MSz4z4o. Bug: webrtc:9887, webrtc:8205 No-Try: True Change-Id: Ic6c7c81e226e59f12f7933e472f573ae097b55bf Reviewed-on: https://webrtc-review.googlesource.com/c/119041 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26414}
2019-01-25 20:26:48 +01:00
"../api:scoped_refptr",
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2. This is a follow-up to https://webrtc-review.googlesource.com/c/src/+/106280. This time the whole code base is covered. Some files may have not been fixed though, whenever the IWYU tool was breaking the build. Bug: webrtc:8311 Change-Id: I2c31f552a87e887d33931d46e87b6208b1e483ef Reviewed-on: https://webrtc-review.googlesource.com/c/111965 Commit-Queue: Yves Gerey <yvesg@google.com> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25830}
2018-11-28 16:47:49 +01:00
"../api/audio:audio_mixer_api",
"../api/audio_codecs:audio_codecs_api",
Reland "Add scaling interface to VideoFrameBuffer" (Reland with no changes after the fix to the downstream project) This can be overriden for kNative frame types to perform scaling efficiently. Default implementations for existing buffer types require actual buffer implementation, thus this CL also merges "video_frame" with "video_frame_I420" build targets. Originally Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/186303 (Landing with TBR as it's unchaged reland of already approved CL) TBR=nisse@webrtc.org,sakal@webrtc.org Bug: webrtc:11976, chromium:1132299 Change-Id: Ia23f7d3e474bd9cdc177104cc5c6d772f04b210f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/187345 Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Stefan Holmer <stefan@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32362}
2020-10-08 14:36:33 +00:00
"../api/video:video_frame",
Prepare for splitting the api/video:video_frames build rule. This change is part of a change to break the dependency between "api:rtp_headers" and "api/video:video_frame". It does so by first creating an empty "api/video:video_rtp_headers" build rule so that downstream projects can be fixed before moving the source files. Bug: webrtc:10668 Change-Id: I81aa6edfef3639b457a40aa93de048e62cbfd8ef Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/140291 Commit-Queue: Chen Xing <chxg@google.com> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28209}
2019-06-10 12:59:38 +02:00
"../api/video:video_rtp_headers",
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2. This is a follow-up to https://webrtc-review.googlesource.com/c/src/+/106280. This time the whole code base is covered. Some files may have not been fixed though, whenever the IWYU tool was breaking the build. Bug: webrtc:8311 Change-Id: I2c31f552a87e887d33931d46e87b6208b1e483ef Reviewed-on: https://webrtc-review.googlesource.com/c/111965 Commit-Queue: Yves Gerey <yvesg@google.com> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25830}
2018-11-28 16:47:49 +01:00
"../api/video_codecs:video_codecs_api",
"../media:rtc_media_base",
"../p2p:rtc_p2p",
Break out separate compile targets for various classes This reduces the degree of interdependency among modules related to the PeerConnection class, and makes it easier to isolate inappropriate external dependencies. Bug: webrtc:11967 Change-Id: Id9777a2ab690cc349dd5842a3a95e24478144c71 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185882 Commit-Queue: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32235}
2020-09-29 14:21:47 +00:00
"../pc:video_track_source",
Fix circular dependencies between optional, array_view, and rtc_base. This splits things out of rtc_base and makes dependencies explicit. Bug: webrtc:6828 Change-Id: Id521896c3c43595349021c857bec216e429a0c8d Reviewed-on: https://webrtc-review.googlesource.com/32780 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21264}
2017-12-13 16:05:42 +01:00
"../rtc_base:checks",
Move sigslot to proper third_party directory Extract sigslot into separate target and move it to proper third_party directory. Bug: webrtc:8366 Change-Id: Id2e0712bd020bfad811947803c94553dce06d976 Reviewed-on: https://webrtc-review.googlesource.com/84141 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Niklas Enbom <niklas.enbom@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24099}
2018-07-25 15:04:28 +02:00
"../rtc_base/third_party/sigslot",
Add support for field trials in peerconnection_client|server Bug: webrtc:9935 Change-Id: Icb96123c5feb9dee309734d2a8ba88e23a467bef Reviewed-on: https://webrtc-review.googlesource.com/c/108301 Commit-Queue: Björn Terelius <terelius@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25431}
2018-10-29 15:26:27 +01:00
"../system_wrappers:field_trial",
"../test:field_trial",
Rewrite video_loopback to use new mac capturer. The old one has been deprecated for a long time. Bug: webrtc:6333, webrtc:6898, webrtc:7861 Change-Id: Ib9b798262817e80019afcacc5b41d18957a28101 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/124827 Reviewed-by: Stefan Holmer <stefan@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26993}
2019-03-06 10:34:09 +01:00
"../test:platform_video_capturer",
Make the RtpHeaderParserImpl available to tests and tools only. There are a few reasons for making this test only: * The code is only used by tests and utilities. * The pure interface has only a single implementation so an interface isn't really needed. (a followup change could remove it altogether) * The implementation always incorporates locking regardless of how the class gets used. See e.g. previous use in the Packet class. * The implementation is a layer on top of RtpUtility::RtpHeaderParser which is sufficient for most production cases. Change-Id: Ide6d50567cf8ae5127a2eb04cceeb10cf317ec36 Bug: none Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150658 Commit-Queue: Tommi <tommi@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29010}
2019-08-29 16:39:05 +02:00
"../test:rtp_test_utils",
Convert peerconnection_client to use VcmCapturer Eliminates the last use of WebRtcVideoDeviceCapturerFactory. Bug: webrtc:6353 Change-Id: I72f8a1a968143037c04777e4fb443fff3801f763 Reviewed-on: https://webrtc-review.googlesource.com/c/115340 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26118}
2018-12-20 16:28:23 +01:00
"//third_party/abseil-cpp/absl/memory",
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2. This is a follow-up to https://webrtc-review.googlesource.com/c/src/+/106280. This time the whole code base is covered. Some files may have not been fixed though, whenever the IWYU tool was breaking the build. Bug: webrtc:8311 Change-Id: I2c31f552a87e887d33931d46e87b6208b1e483ef Reviewed-on: https://webrtc-review.googlesource.com/c/111965 Commit-Queue: Yves Gerey <yvesg@google.com> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25830}
2018-11-28 16:47:49 +01:00
"//third_party/abseil-cpp/absl/types:optional",
Separate i420 and i444 implementations to separate targets. This means we can properly declare the dependency between libjingle_peerconnection_api and video_frame_api. i420 pulls in system_wrappers, which can't be a dependency of the public API. Plan: 1) Land this CL + send out PSA 2) Make all direct users of i420_buffer depend on the new video_frame_api_i420 target 3) Move i420_buffer.cc to the new target 4) Make libjingle_peerconnection_api depend on video_frame_api, since it no longer contains i420 code Bug: webrtc:7504 Change-Id: I30d90f2ac7af53748859bbde8aed92386d5501f9 Reviewed-on: https://webrtc-review.googlesource.com/9382 Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20656}
2017-11-13 10:19:58 +01:00
]
Create gn target for peerconnection examples BUG= Review-Url: https://codereview.webrtc.org/2218053002 Cr-Commit-Position: refs/heads/master@{#13673}
2016-08-08 09:03:23 -07:00
if (is_win) {
sources += [
(4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries Mechanically generated by running this command: tools_webrtc/do-renames.sh update all-renames.txt && git cl format Then manually updating: tools_webrtc/sanitizers/tsan_suppressions_webrtc.cc Bug: webrtc:10159 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I54824cd91dada8fc3ee3d098f971bc319d477833 Reviewed-on: https://webrtc-review.googlesource.com/c/115653 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26226}
2019-01-11 09:11:00 -08:00
"peerconnection/client/flag_defs.h",
Create gn target for peerconnection examples BUG= Review-Url: https://codereview.webrtc.org/2218053002 Cr-Commit-Position: refs/heads/master@{#13673}
2016-08-08 09:03:23 -07:00
"peerconnection/client/main.cc",
"peerconnection/client/main_wnd.cc",
"peerconnection/client/main_wnd.h",
]
configs += [ "//build/config/win:windowed" ]
Move win32 files to a new "win32" target to avoid cyclic dependencies. I ran into this when using repeating_task, which depends on clock (in system_wrappers) which in turn added a dependency on rtc_base on Windows due to win32 files. That's a problem since rtc_base depends on repeating_task: //rtc_base:rtc_base -> //rtc_base/task_utils:repeating_task -> //system_wrappers:system_wrappers -> //rtc_base:rtc_base We could additionally consider moving Clock out of system_wrappers. Bug: webrtc:9987 Change-Id: I54ed715ad5eb9e3f5dd6c322233c18c05d895dff Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185506 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32203}
2020-09-26 11:57:26 +02:00
deps += [
"../media:rtc_media_base",
"../rtc_base:win32",
]
Create gn target for peerconnection examples BUG= Review-Url: https://codereview.webrtc.org/2218053002 Cr-Commit-Position: refs/heads/master@{#13673}
2016-08-08 09:03:23 -07:00
}
Expand is_linux to is_linux || is_chromeos. Currently is_linux is set to true on Chrome OS build, but it is planned to be set false. This CL is the preparation to keep the compatibility. Bug: chromium:1110266 Test: Build locally. Change-Id: Ic79a202b0b3baeff157955cd03a07556bfb958a8 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/183860 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#32073}
2020-09-10 18:10:11 +09:00
if (is_linux || is_chromeos) {
Create gn target for peerconnection examples BUG= Review-Url: https://codereview.webrtc.org/2218053002 Cr-Commit-Position: refs/heads/master@{#13673}
2016-08-08 09:03:23 -07:00
sources += [
"peerconnection/client/linux/main.cc",
"peerconnection/client/linux/main_wnd.cc",
"peerconnection/client/linux/main_wnd.h",
]
Roll chromium_revision 4f16f0c98f..a896ff44a3 (459568:459701) Change log: https://chromium.googlesource.com/chromium/src/+log/4f16f0c98f..a896ff44a3 Full diff: https://chromium.googlesource.com/chromium/src/+/4f16f0c98f..a896ff44a3 Changed dependencies: * src/base: https://chromium.googlesource.com/chromium/src/base/+log/d85a3c5a13..52145f4993 * src/build: https://chromium.googlesource.com/chromium/src/build/+log/f792848af8..ad3a39abce * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/46b14a7c3f..9f63fb7341 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/16c9fdd3a4..aa776e6172 * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/5982252235..6c4bf3684c * src/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/517173b5db..0cfeabf700 * src/third_party/libFuzzer/src: https://chromium.googlesource.com/chromium/llvm-project/llvm/lib/Fuzzer.git/+log/b9454401d3..57ed386045 * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/157e8fc5ce..297b0ff5dd DEPS diff: https://chromium.googlesource.com/chromium/src/+/4f16f0c98f..a896ff44a3/DEPS No update to Clang. TBR= BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/2777023002 . Cr-Commit-Position: refs/heads/master@{#17382}
2017-03-27 08:28:27 +02:00
cflags = [ "-Wno-deprecated-declarations" ]
Create gn target for peerconnection examples BUG= Review-Url: https://codereview.webrtc.org/2218053002 Cr-Commit-Position: refs/heads/master@{#13673}
2016-08-08 09:03:23 -07:00
libs = [
"X11",
"Xcomposite",
"Xext",
"Xrender",
]
Add a gtk3 port of peerconnection_client on Linux BUG=668446 Review-Url: https://codereview.webrtc.org/2563203002 Cr-Commit-Position: refs/heads/master@{#15569}
2016-12-13 02:57:43 -08:00
deps += [ "//build/config/linux/gtk" ]
Create gn target for peerconnection examples BUG= Review-Url: https://codereview.webrtc.org/2218053002 Cr-Commit-Position: refs/heads/master@{#13673}
2016-08-08 09:03:23 -07:00
}
Reland "Enable GN check for webrtc/examples" This is a reland of https://codereview.webrtc.org/2714343002 with the errors related to inclusions of test targets in webrtc/api resolved. BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2733673002 Cr-Commit-Position: refs/heads/master@{#17053}
2017-03-06 00:29:21 -08:00
deps += [
Rename Call::Config to CallConfig, keep old name as alias. We want api/peerconnectioninterface.h (and corresponding build target) to not depend on call.h, and generally we treat Call as an internal, non-api, class. But we need CallFactoryInterface in the api in order to enable use of PeerConnection with or without support for media. Making CallConfig a top-level class makes it possible to forward declare it, together with Call, for use in callfactoryinterface.h and peerconnectioninterface.h. Delete the peerconnection_and_implicit_call_api target, replaced by new target callfactory_api, to link between Call and Peerconnection. Bug: webrtc:7504 Change-Id: I5e3978ef89bcd6705e94536f8676bcf89fc82fe1 Reviewed-on: https://webrtc-review.googlesource.com/46201 Reviewed-by: Stefan Holmer <stefan@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22020}
2018-02-14 12:20:13 +01:00
"../api:libjingle_peerconnection_api",
Don't call deprecated CreatePeerConnectionFactory() overloads They're about to be removed. BUG=webrtc:8396 Change-Id: Ie9a45f4c0dccb4414d2a2f939aa5f142edc6e4b6 Reviewed-on: https://webrtc-review.googlesource.com/12280 Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20328}
2017-10-17 14:48:54 +02:00
"../api/audio_codecs:builtin_audio_decoder_factory",
"../api/audio_codecs:builtin_audio_encoder_factory",
New file api/video/BUILD.gn Build targets involving files under api/video/ are moved into this file, from api/BUILD.gn. In addition, drop "_api" part of target names, and move the header file api/videosinkinterface.h to api/video/video_sink_interface.h. Bug: webrtc:9253 Change-Id: I2896d3f063db8dff902bc29738578395b2fcc155 Reviewed-on: https://webrtc-review.googlesource.com/75500 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23207}
2018-05-11 11:15:30 +02:00
"../api/video:video_frame",
Prepare for splitting the api/video:video_frames build rule. This change is part of a change to break the dependency between "api:rtp_headers" and "api/video:video_frame". It does so by first creating an empty "api/video:video_rtp_headers" build rule so that downstream projects can be fixed before moving the source files. Bug: webrtc:10668 Change-Id: I81aa6edfef3639b457a40aa93de048e62cbfd8ef Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/140291 Commit-Queue: Chen Xing <chxg@google.com> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28209}
2019-06-10 12:59:38 +02:00
"../api/video:video_rtp_headers",
Built in video codec factories. To prepare for making the software codecs optional and injectable, these codec factories provide a way to pass in identical factories as were the default old behaviour. Bug: webrtc:7925 Change-Id: I0c70fa3c56c999e9d1af6e172eff2fbba849e921 Reviewed-on: https://webrtc-review.googlesource.com/71162 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23096}
2018-05-03 11:28:29 +02:00
"../api/video_codecs:builtin_video_decoder_factory",
"../api/video_codecs:builtin_video_encoder_factory",
Stop using public_deps in media/. Bug: webrtc:8603 Change-Id: I7a6dad323ac298dc784feb5aa1fdc2ae5876cb5c No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/33180 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21591}
2018-01-11 17:07:30 +01:00
"../media:rtc_audio_video",
Cleanup BUILD.gn files from imports like foo:foo Repalce all occurrences of foo:foo in deps with just foo in BUILD.gn files. Done with Sublime regex replace. Find: \b([-a-zA-Z0-9_]+):+\1\b In: *.gn Replace with: \1 Bug: None Change-Id: I40aba1b14face687a595b852ffe443cb20197611 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127899 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27225}
2019-03-21 13:35:10 +01:00
"../modules/audio_device",
"../modules/audio_processing",
Reland "Isolating APM API build target: making :api an actual target." This reverts commit 61c6e5643e7ea058e653956980a90e033249c055. Reason for revert: downstream projects prepared for this change Original change's description: > Revert "Isolating APM API build target: making :api an actual target." > > This reverts commit a7f77a7c05b5d26520fd01a773ffb2c8b15b60ff. > > Reason for revert: breaking downstream > > Original change's description: > > Isolating APM API build target: making :api an actual target. > > > > This CL is part of a refactoring work to unblock other CLs > > that would generate a circular dependency when including > > modules/audio_processing. It will also allow to easily move > > the APM interface part under //api. > > > > More in detail, this change moves the APM interface files from > > the build target modules/audio_processing to > > modules/audio_processing:api. It also adds :api as dependency > > where needed. > > > > Bug: webrtc:9535 > > Change-Id: I72829e22d08ba4d75985f0421e6e8bf0216ebecd > > Reviewed-on: https://webrtc-review.googlesource.com/c/109501 > > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > > Reviewed-by: Kári Helgason <kthelgason@webrtc.org> > > Reviewed-by: Niels Moller <nisse@webrtc.org> > > Reviewed-by: Sam Zackrisson <saza@webrtc.org> > > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#25539} > > TBR=saza@webrtc.org,alessiob@webrtc.org,kwiberg@webrtc.org,nisse@webrtc.org,kthelgason@webrtc.org > > Change-Id: I974c6237311e7c06970aa62e5f6940f3aa80113d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:9535 > Reviewed-on: https://webrtc-review.googlesource.com/c/109820 > Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#25540} TBR=saza@webrtc.org,alessiob@webrtc.org,kwiberg@webrtc.org,nisse@webrtc.org,kthelgason@webrtc.org Change-Id: Ic8ed4cc3baf43d639ce13cae256c007728c3ad92 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:9535 Reviewed-on: https://webrtc-review.googlesource.com/c/109884 Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25547}
2018-11-07 14:29:54 +00:00
"../modules/audio_processing:api",
Use relative paths in GN files. BUG=webrtc:7952 TBR=kjellander@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2974863003 Cr-Commit-Position: refs/heads/master@{#18970}
2017-07-11 06:20:45 -07:00
"../modules/video_capture:video_capture_module",
"../pc:libjingle_peerconnection",
Convert peerconnection_client to use VcmCapturer Eliminates the last use of WebRtcVideoDeviceCapturerFactory. Bug: webrtc:6353 Change-Id: I72f8a1a968143037c04777e4fb443fff3801f763 Reviewed-on: https://webrtc-review.googlesource.com/c/115340 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26118}
2018-12-20 16:28:23 +01:00
"../pc:peerconnection",
Cleanup BUILD.gn files from imports like foo:foo Repalce all occurrences of foo:foo in deps with just foo in BUILD.gn files. Done with Sublime regex replace. Find: \b([-a-zA-Z0-9_]+):+\1\b In: *.gn Replace with: \1 Bug: None Change-Id: I40aba1b14face687a595b852ffe443cb20197611 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127899 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27225}
2019-03-21 13:35:10 +01:00
"../rtc_base",
Remove remains of webrtc/base All downstream code have been updated to the new location. In PRESUBMIT.py: * Remove webrtc/rtc_base from CPP_BLACKLIST * Add webrtc/rtc_base to LEGACY_API_DIRS Fix some duplicated paths in webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn BUG=webrtc:7634 TBR=kwiberg@webrtc.org Review-Url: https://codereview.webrtc.org/2976293002 Cr-Commit-Position: refs/heads/master@{#19094}
2017-07-19 10:40:47 -07:00
"../rtc_base:rtc_base_approved",
"../rtc_base:rtc_json",
Convert peerconnection_client to use VcmCapturer Eliminates the last use of WebRtcVideoDeviceCapturerFactory. Bug: webrtc:6353 Change-Id: I72f8a1a968143037c04777e4fb443fff3801f763 Reviewed-on: https://webrtc-review.googlesource.com/c/115340 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26118}
2018-12-20 16:28:23 +01:00
"../test:video_test_common",
Switch pc client and stunprober to ABSL_FLAG. Bug: webrtc:10616 Change-Id: I74e65a527da88a7f723c5000e5097dc1766826dd Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144624 Reviewed-by: Tommi <tommi@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28588}
2019-07-16 18:40:05 +02:00
"//third_party/abseil-cpp/absl/flags:flag",
"//third_party/abseil-cpp/absl/flags:parse",
Reland "Enable GN check for webrtc/examples" This is a reland of https://codereview.webrtc.org/2714343002 with the errors related to inclusions of test targets in webrtc/api resolved. BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2733673002 Cr-Commit-Position: refs/heads/master@{#17053}
2017-03-06 00:29:21 -08:00
"//third_party/libyuv",
]
Create gn target for peerconnection examples BUG= Review-Url: https://codereview.webrtc.org/2218053002 Cr-Commit-Position: refs/heads/master@{#13673}
2016-08-08 09:03:23 -07:00
}
Disable -Wsentinel warning for Linux 32-bit builds. BUG=chromium:644167 NOTRY=True Review-Url: https://codereview.webrtc.org/2316943002 Cr-Commit-Position: refs/heads/master@{#14099}
2016-09-07 02:33:01 -07:00
GN: Introduce templates. Defines the rtc_executable, rtc_source_set, rtc_test and rtc_static_library templates. These templates provide no functionality yet, but will enable common configuration to be introduced, avoiding repetition in every target Changes summary: - Prepend rtc_ to test, source_set, executable and static_library targets - Change "configs -= [" to "suppressed_configs += [" - Include webrtc/build/webrtc.gni where it wasn't included yet - Delete import("//testing/test.gni"), since rtc_test makes it unnecessary. BUG=webrtc:6187 TBR=henrik.lundin@webrtc.org,tommi@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2301053002 Cr-Commit-Position: refs/heads/master@{#14043}
2016-09-02 04:10:34 -07:00
rtc_executable("peerconnection_server") {
Reland "Enable GN check for webrtc/examples" This is a reland of https://codereview.webrtc.org/2714343002 with the errors related to inclusions of test targets in webrtc/api resolved. BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2733673002 Cr-Commit-Position: refs/heads/master@{#17053}
2017-03-06 00:29:21 -08:00
testonly = true
Create gn target for peerconnection examples BUG= Review-Url: https://codereview.webrtc.org/2218053002 Cr-Commit-Position: refs/heads/master@{#13673}
2016-08-08 09:03:23 -07:00
sources = [
"peerconnection/server/data_socket.cc",
"peerconnection/server/data_socket.h",
"peerconnection/server/main.cc",
"peerconnection/server/peer_channel.cc",
"peerconnection/server/peer_channel.h",
"peerconnection/server/utils.cc",
"peerconnection/server/utils.h",
]
deps = [
Remove remains of webrtc/base All downstream code have been updated to the new location. In PRESUBMIT.py: * Remove webrtc/rtc_base from CPP_BLACKLIST * Add webrtc/rtc_base to LEGACY_API_DIRS Fix some duplicated paths in webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn BUG=webrtc:7634 TBR=kwiberg@webrtc.org Review-Url: https://codereview.webrtc.org/2976293002 Cr-Commit-Position: refs/heads/master@{#19094}
2017-07-19 10:40:47 -07:00
"../rtc_base:rtc_base_approved",
Add support for field trials in peerconnection_client|server Bug: webrtc:9935 Change-Id: Icb96123c5feb9dee309734d2a8ba88e23a467bef Reviewed-on: https://webrtc-review.googlesource.com/c/108301 Commit-Queue: Björn Terelius <terelius@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25431}
2018-10-29 15:26:27 +01:00
"../system_wrappers:field_trial",
"../test:field_trial",
Switch example peerconnection server to ABSL_FLAG. TBR=kwiberg@webrtc.org Bug: webrtc:10616 Change-Id: I611f6f67c5473b7f7ef623fa788e5403e7a8001a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/143790 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28373}
2019-06-25 15:43:23 +02:00
"//third_party/abseil-cpp/absl/flags:flag",
"//third_party/abseil-cpp/absl/flags:parse",
Add usage message to peerconnection_server. Bug: webrtc:10616 Change-Id: I5d8165c3c1f73dc5b5c3eb2307c26fe107ed96be Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146211 Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28615}
2019-07-19 12:12:14 +02:00
"//third_party/abseil-cpp/absl/flags:usage",
Create gn target for peerconnection examples BUG= Review-Url: https://codereview.webrtc.org/2218053002 Cr-Commit-Position: refs/heads/master@{#13673}
2016-08-08 09:03:23 -07:00
]
}
GN: Introduce templates. Defines the rtc_executable, rtc_source_set, rtc_test and rtc_static_library templates. These templates provide no functionality yet, but will enable common configuration to be introduced, avoiding repetition in every target Changes summary: - Prepend rtc_ to test, source_set, executable and static_library targets - Change "configs -= [" to "suppressed_configs += [" - Include webrtc/build/webrtc.gni where it wasn't included yet - Delete import("//testing/test.gni"), since rtc_test makes it unnecessary. BUG=webrtc:6187 TBR=henrik.lundin@webrtc.org,tommi@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2301053002 Cr-Commit-Position: refs/heads/master@{#14043}
2016-09-02 04:10:34 -07:00
rtc_executable("turnserver") {
Reland "Enable GN check for webrtc/examples" This is a reland of https://codereview.webrtc.org/2714343002 with the errors related to inclusions of test targets in webrtc/api resolved. BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2733673002 Cr-Commit-Position: refs/heads/master@{#17053}
2017-03-06 00:29:21 -08:00
testonly = true
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "turnserver/turnserver_main.cc" ]
Create gn target for peerconnection examples BUG= Review-Url: https://codereview.webrtc.org/2218053002 Cr-Commit-Position: refs/heads/master@{#13673}
2016-08-08 09:03:23 -07:00
deps = [
Delete OptionsFile class. Refactored only user, TurnFileAuth. Bug: webrtc:6424 Change-Id: I4b74cd6197f2cb060d1aff70e3adadbdf7f7a580 Reviewed-on: https://webrtc-review.googlesource.com/c/108122 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25426}
2018-10-30 12:20:03 +01:00
":read_auth_file",
Reland "Move relay server code to a test-only target p2p_server_utils." This is a reland of e284c521f76d810e9c68a238e4821e8f0f99a2cd Original change's description: > Move relay server code to a test-only target p2p_server_utils. > > Bug: webrtc:9798 > Change-Id: I5926cbb11922c7bd1adfa2099431dc461cc63f20 > Reviewed-on: https://webrtc-review.googlesource.com/c/107361 > Reviewed-by: Per Kjellander <perkj@webrtc.org> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Commit-Queue: Niels Moller <nisse@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#25347} Bug: webrtc:9798 Change-Id: I82c6c7d9524217237ad83839cc0fe6f2c184b0e3 Reviewed-on: https://webrtc-review.googlesource.com/c/108300 Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26024}
2018-11-08 16:47:14 +01:00
"../p2p:p2p_server_utils",
Use relative paths in GN files. BUG=webrtc:7952 TBR=kjellander@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2974863003 Cr-Commit-Position: refs/heads/master@{#18970}
2017-07-11 06:20:45 -07:00
"../p2p:rtc_p2p",
"../pc:rtc_pc",
Cleanup BUILD.gn files from imports like foo:foo Repalce all occurrences of foo:foo in deps with just foo in BUILD.gn files. Done with Sublime regex replace. Find: \b([-a-zA-Z0-9_]+):+\1\b In: *.gn Replace with: \1 Bug: None Change-Id: I40aba1b14face687a595b852ffe443cb20197611 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127899 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27225}
2019-03-21 13:35:10 +01:00
"../rtc_base",
Remove remains of webrtc/base All downstream code have been updated to the new location. In PRESUBMIT.py: * Remove webrtc/rtc_base from CPP_BLACKLIST * Add webrtc/rtc_base to LEGACY_API_DIRS Fix some duplicated paths in webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn BUG=webrtc:7634 TBR=kwiberg@webrtc.org Review-Url: https://codereview.webrtc.org/2976293002 Cr-Commit-Position: refs/heads/master@{#19094}
2017-07-19 10:40:47 -07:00
"../rtc_base:rtc_base_approved",
Create gn target for peerconnection examples BUG= Review-Url: https://codereview.webrtc.org/2218053002 Cr-Commit-Position: refs/heads/master@{#13673}
2016-08-08 09:03:23 -07:00
]
}
GN: Introduce templates. Defines the rtc_executable, rtc_source_set, rtc_test and rtc_static_library templates. These templates provide no functionality yet, but will enable common configuration to be introduced, avoiding repetition in every target Changes summary: - Prepend rtc_ to test, source_set, executable and static_library targets - Change "configs -= [" to "suppressed_configs += [" - Include webrtc/build/webrtc.gni where it wasn't included yet - Delete import("//testing/test.gni"), since rtc_test makes it unnecessary. BUG=webrtc:6187 TBR=henrik.lundin@webrtc.org,tommi@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2301053002 Cr-Commit-Position: refs/heads/master@{#14043}
2016-09-02 04:10:34 -07:00
rtc_executable("stunserver") {
Reland "Enable GN check for webrtc/examples" This is a reland of https://codereview.webrtc.org/2714343002 with the errors related to inclusions of test targets in webrtc/api resolved. BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2733673002 Cr-Commit-Position: refs/heads/master@{#17053}
2017-03-06 00:29:21 -08:00
testonly = true
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "stunserver/stunserver_main.cc" ]
Create gn target for peerconnection examples BUG= Review-Url: https://codereview.webrtc.org/2218053002 Cr-Commit-Position: refs/heads/master@{#13673}
2016-08-08 09:03:23 -07:00
deps = [
Reland "Move relay server code to a test-only target p2p_server_utils." This is a reland of e284c521f76d810e9c68a238e4821e8f0f99a2cd Original change's description: > Move relay server code to a test-only target p2p_server_utils. > > Bug: webrtc:9798 > Change-Id: I5926cbb11922c7bd1adfa2099431dc461cc63f20 > Reviewed-on: https://webrtc-review.googlesource.com/c/107361 > Reviewed-by: Per Kjellander <perkj@webrtc.org> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Commit-Queue: Niels Moller <nisse@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#25347} Bug: webrtc:9798 Change-Id: I82c6c7d9524217237ad83839cc0fe6f2c184b0e3 Reviewed-on: https://webrtc-review.googlesource.com/c/108300 Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26024}
2018-11-08 16:47:14 +01:00
"../p2p:p2p_server_utils",
Use relative paths in GN files. BUG=webrtc:7952 TBR=kjellander@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2974863003 Cr-Commit-Position: refs/heads/master@{#18970}
2017-07-11 06:20:45 -07:00
"../p2p:rtc_p2p",
"../pc:rtc_pc",
Cleanup BUILD.gn files from imports like foo:foo Repalce all occurrences of foo:foo in deps with just foo in BUILD.gn files. Done with Sublime regex replace. Find: \b([-a-zA-Z0-9_]+):+\1\b In: *.gn Replace with: \1 Bug: None Change-Id: I40aba1b14face687a595b852ffe443cb20197611 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127899 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27225}
2019-03-21 13:35:10 +01:00
"../rtc_base",
Remove remains of webrtc/base All downstream code have been updated to the new location. In PRESUBMIT.py: * Remove webrtc/rtc_base from CPP_BLACKLIST * Add webrtc/rtc_base to LEGACY_API_DIRS Fix some duplicated paths in webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn BUG=webrtc:7634 TBR=kwiberg@webrtc.org Review-Url: https://codereview.webrtc.org/2976293002 Cr-Commit-Position: refs/heads/master@{#19094}
2017-07-19 10:40:47 -07:00
"../rtc_base:rtc_base_approved",
Create gn target for peerconnection examples BUG= Review-Url: https://codereview.webrtc.org/2218053002 Cr-Commit-Position: refs/heads/master@{#13673}
2016-08-08 09:03:23 -07:00
]
}
}
Moving stun_prober target from webrtc/p2p to webrtc/examples BUG=webrtc:6440 NOTRY=True Review-Url: https://codereview.webrtc.org/2460343002 Cr-Commit-Position: refs/heads/master@{#14869}
2016-11-01 03:09:15 -07:00
Add Android Camera To Unity Plugin The existing unity plugin (an example in webrtc codebase) does not support camera access on Android platform. This CL implements such functionality. TBR=gyzhou@chromium.org BUG=webrtc:8067 Review-Url: https://codereview.webrtc.org/2993273002 Cr-Commit-Position: refs/heads/master@{#19277}
2017-08-08 17:08:03 -07:00
if (is_win || is_android) {
An example of Unity native plugin of webrtc for Windows OS Unity native plugin has to use Pinvoke technology in its APIs This plugin dll can also be used by Windows C# applications other than Unity. BUG=webrtc:7389 Review-Url: https://codereview.webrtc.org/2823783002 Cr-Commit-Position: refs/heads/master@{#18108}
2017-05-11 16:10:03 -07:00
rtc_shared_library("webrtc_unity_plugin") {
testonly = true
sources = [
"unityplugin/simple_peer_connection.cc",
"unityplugin/simple_peer_connection.h",
"unityplugin/unity_plugin_apis.cc",
"unityplugin/unity_plugin_apis.h",
Update native plugin dll for turn servers and video. This CL was modified from work of sharifferdous@ (intern supervised by lliuu@) BUG=webrtc:7389 Review-Url: https://codereview.webrtc.org/2987723002 Cr-Commit-Position: refs/heads/master@{#19146}
2017-07-25 16:04:31 -07:00
"unityplugin/video_observer.cc",
"unityplugin/video_observer.h",
An example of Unity native plugin of webrtc for Windows OS Unity native plugin has to use Pinvoke technology in its APIs This plugin dll can also be used by Windows C# applications other than Unity. BUG=webrtc:7389 Review-Url: https://codereview.webrtc.org/2823783002 Cr-Commit-Position: refs/heads/master@{#18108}
2017-05-11 16:10:03 -07:00
]
Add Android Camera To Unity Plugin The existing unity plugin (an example in webrtc codebase) does not support camera access on Android platform. This CL implements such functionality. TBR=gyzhou@chromium.org BUG=webrtc:8067 Review-Url: https://codereview.webrtc.org/2993273002 Cr-Commit-Position: refs/heads/master@{#19277}
2017-08-08 17:08:03 -07:00
if (is_android) {
sources += [
(4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries Mechanically generated by running this command: tools_webrtc/do-renames.sh update all-renames.txt && git cl format Then manually updating: tools_webrtc/sanitizers/tsan_suppressions_webrtc.cc Bug: webrtc:10159 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I54824cd91dada8fc3ee3d098f971bc319d477833 Reviewed-on: https://webrtc-review.googlesource.com/c/115653 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26226}
2019-01-11 09:11:00 -08:00
"unityplugin/class_reference_holder.cc",
"unityplugin/class_reference_holder.h",
Add Android Camera To Unity Plugin The existing unity plugin (an example in webrtc codebase) does not support camera access on Android platform. This CL implements such functionality. TBR=gyzhou@chromium.org BUG=webrtc:8067 Review-Url: https://codereview.webrtc.org/2993273002 Cr-Commit-Position: refs/heads/master@{#19277}
2017-08-08 17:08:03 -07:00
"unityplugin/jni_onload.cc",
]
Reland: Add Alpha Channel Support For WebRTC Unity Plugin This CL make webrtc unity plugin compatible with alpha channel support. TBR=gyzhou@chromium.org,magjed@webrtc.org Bug: webrtc:8645 Change-Id: Ic1c11f8c82f8244b84b8ab67c623ad2002b940e8 Reviewed-on: https://webrtc-review.googlesource.com/35421 Reviewed-by: George Zhou <gyzhou@chromium.org> Reviewed-by: Qiang Chen <qiangchen@chromium.org> Commit-Queue: Qiang Chen <qiangchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#21398}
2017-12-20 10:47:36 -08:00
suppressed_configs += [ "//build/config/android:hide_all_but_jni_onload" ]
Add Android Camera To Unity Plugin The existing unity plugin (an example in webrtc codebase) does not support camera access on Android platform. This CL implements such functionality. TBR=gyzhou@chromium.org BUG=webrtc:8067 Review-Url: https://codereview.webrtc.org/2993273002 Cr-Commit-Position: refs/heads/master@{#19277}
2017-08-08 17:08:03 -07:00
}
if (is_win) {
Remove -Wno-reorder from examples/BUILD.gn. Bug: webrtc:9251 Change-Id: I447469e94ad938eaaa628edcd1a57cdeac6ed603 Reviewed-on: https://webrtc-review.googlesource.com/88123 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23928}
2018-07-11 10:47:42 +02:00
configs += [ "//build/config/win:windowed" ]
Add Android Camera To Unity Plugin The existing unity plugin (an example in webrtc codebase) does not support camera access on Android platform. This CL implements such functionality. TBR=gyzhou@chromium.org BUG=webrtc:8067 Review-Url: https://codereview.webrtc.org/2993273002 Cr-Commit-Position: refs/heads/master@{#19277}
2017-08-08 17:08:03 -07:00
}
An example of Unity native plugin of webrtc for Windows OS Unity native plugin has to use Pinvoke technology in its APIs This plugin dll can also be used by Windows C# applications other than Unity. BUG=webrtc:7389 Review-Url: https://codereview.webrtc.org/2823783002 Cr-Commit-Position: refs/heads/master@{#18108}
2017-05-11 16:10:03 -07:00
deps = [
Move webrtc::CreatePeerConnectionFactory definition next to decl. This CL moves webrtc::CreatePeerConnectionFactory definitions out of pc:create_pc_factory and merges it with its declaration in the api/ directory. In order to avoid circular dependencies a new build target is created: * api:create_peerconnection_factory Bug: webrtc:9862 Change-Id: Ie215c94460cba026f5bf7d11c9a5aa03792064af Reviewed-on: https://webrtc-review.googlesource.com/c/111186 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25744}
2018-11-22 09:00:13 +01:00
"../api:create_peerconnection_factory",
Stop using public_deps in api/. Bug: webrtc:8603 Change-Id: I12f91365fa9a3ed12be1a9658999b6f6aad7e5e3 No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/33220 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21584}
2018-01-11 10:13:56 +01:00
"../api:libjingle_peerconnection_api",
New build target api:media_interface Bug: webrtc:8733 Change-Id: I84bbefb1a5ef8e592db29b79499d60ac80c23464 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153180 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Steve Anton <steveanton@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29234}
2019-09-17 14:30:41 +02:00
"../api:media_stream_interface",
Bug Fix: WebRTC Unity Plugin Audio One Way When audio_only is on for the webrtc unity plugin, there is a bug that the audio from hologram cannot be heard at the remote side. Actually we found the audio is transmitted to the remote side, but the remote side wants video data also to playout everything. So without video data, the remote side will drop all the audio data. Thus, on the hologram (using webrtc unity plugin) side, we should not hook up a dummy camera, but instead we should use media constraint to request the remote side to send video data. This CL fixes the bug. Bug: webrtc:8555 Change-Id: I21ddda65185b645088aa4ac15f47b3f8ffad1873 Reviewed-on: https://webrtc-review.googlesource.com/24680 Commit-Queue: Qiang Chen <qiangchen@chromium.org> Reviewed-by: George Zhou <gyzhou@chromium.org> Cr-Commit-Position: refs/heads/master@{#21094}
2017-12-05 11:11:21 -08:00
"../api/audio_codecs:builtin_audio_decoder_factory",
"../api/audio_codecs:builtin_audio_encoder_factory",
New file api/video/BUILD.gn Build targets involving files under api/video/ are moved into this file, from api/BUILD.gn. In addition, drop "_api" part of target names, and move the header file api/videosinkinterface.h to api/video/video_sink_interface.h. Bug: webrtc:9253 Change-Id: I2896d3f063db8dff902bc29738578395b2fcc155 Reviewed-on: https://webrtc-review.googlesource.com/75500 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23207}
2018-05-11 11:15:30 +02:00
"../api/video:video_frame",
Prepare for splitting the api/video:video_frames build rule. This change is part of a change to break the dependency between "api:rtp_headers" and "api/video:video_frame". It does so by first creating an empty "api/video:video_rtp_headers" build rule so that downstream projects can be fixed before moving the source files. Bug: webrtc:10668 Change-Id: I81aa6edfef3639b457a40aa93de048e62cbfd8ef Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/140291 Commit-Queue: Chen Xing <chxg@google.com> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28209}
2019-06-10 12:59:38 +02:00
"../api/video:video_rtp_headers",
Stop using public_deps in media/. Bug: webrtc:8603 Change-Id: I7a6dad323ac298dc784feb5aa1fdc2ae5876cb5c No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/33180 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21591}
2018-01-11 17:07:30 +01:00
"../media:rtc_audio_video",
Reland "Reland "Reland "Put internal video codec factories into separate target""" This is a reland of 727b7d0470c0515397d21698ee089197c31cb5ff Original change's description: > Reland "Reland "Put internal video codec factories into separate target"" > > This is a reland of 0efd1e8b7e69900a6a516a176f1ab69d0e6b8a26 > Original change's description: > > Reland "Put internal video codec factories into separate target" > > > > This is a reland of 51698aefd4925f2dfa0310a321f836d433fa9258 > > Original change's description: > > > Put internal video codec factories into separate target > > > > > > The purpose is to start splitting out the dependencies to the built-in > > > SW video codecs, so that clients can decide to not depend on them and > > > get a reduction in binary size. > > > > > > Replaces https://webrtc-review.googlesource.com/c/src/+/29101 > > > > > > Bug: webrtc:7925 > > > Change-Id: I46b95aaf42ead70ba78776de60600b8a66a1fe0c > > > Reviewed-on: https://webrtc-review.googlesource.com/33420 > > > Commit-Queue: Anders Carlsson <andersc@webrtc.org> > > > Reviewed-by: Magnus Jedvert <magjed@webrtc.org> > > > Cr-Commit-Position: refs/heads/master@{#21381} > > > > Bug: webrtc:7925 > > Change-Id: I105287fd41ec3ee5bd964b94efcc9c7b3ecdb842 > > Reviewed-on: https://webrtc-review.googlesource.com/35261 > > Reviewed-by: Magnus Jedvert <magjed@webrtc.org> > > Commit-Queue: Anders Carlsson <andersc@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#21389} > > Bug: webrtc:7925 > Change-Id: Id1c7f270676e9e4ca57ca8aa1305cf5554290754 > Reviewed-on: https://webrtc-review.googlesource.com/35501 > Commit-Queue: Anders Carlsson <andersc@webrtc.org> > Reviewed-by: Magnus Jedvert <magjed@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#21464} Bug: webrtc:7925 Change-Id: I0b3b5e03d29dadbcbe13cb7ce5369299bb6c0454 Reviewed-on: https://webrtc-review.googlesource.com/37000 Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21513}
2018-01-04 15:10:22 +01:00
"../media:rtc_internal_video_codecs",
Use relative paths in GN files. BUG=webrtc:7952 TBR=kjellander@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2974863003 Cr-Commit-Position: refs/heads/master@{#18970}
2017-07-11 06:20:45 -07:00
"../media:rtc_media",
"../media:rtc_media_base",
Cleanup BUILD.gn files from imports like foo:foo Repalce all occurrences of foo:foo in deps with just foo in BUILD.gn files. Done with Sublime regex replace. Find: \b([-a-zA-Z0-9_]+):+\1\b In: *.gn Replace with: \1 Bug: None Change-Id: I40aba1b14face687a595b852ffe443cb20197611 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127899 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27225}
2019-03-21 13:35:10 +01:00
"../modules/audio_device",
"../modules/audio_processing",
Reland "Isolating APM API build target: making :api an actual target." This reverts commit 61c6e5643e7ea058e653956980a90e033249c055. Reason for revert: downstream projects prepared for this change Original change's description: > Revert "Isolating APM API build target: making :api an actual target." > > This reverts commit a7f77a7c05b5d26520fd01a773ffb2c8b15b60ff. > > Reason for revert: breaking downstream > > Original change's description: > > Isolating APM API build target: making :api an actual target. > > > > This CL is part of a refactoring work to unblock other CLs > > that would generate a circular dependency when including > > modules/audio_processing. It will also allow to easily move > > the APM interface part under //api. > > > > More in detail, this change moves the APM interface files from > > the build target modules/audio_processing to > > modules/audio_processing:api. It also adds :api as dependency > > where needed. > > > > Bug: webrtc:9535 > > Change-Id: I72829e22d08ba4d75985f0421e6e8bf0216ebecd > > Reviewed-on: https://webrtc-review.googlesource.com/c/109501 > > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > > Reviewed-by: Kári Helgason <kthelgason@webrtc.org> > > Reviewed-by: Niels Moller <nisse@webrtc.org> > > Reviewed-by: Sam Zackrisson <saza@webrtc.org> > > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#25539} > > TBR=saza@webrtc.org,alessiob@webrtc.org,kwiberg@webrtc.org,nisse@webrtc.org,kthelgason@webrtc.org > > Change-Id: I974c6237311e7c06970aa62e5f6940f3aa80113d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:9535 > Reviewed-on: https://webrtc-review.googlesource.com/c/109820 > Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#25540} TBR=saza@webrtc.org,alessiob@webrtc.org,kwiberg@webrtc.org,nisse@webrtc.org,kthelgason@webrtc.org Change-Id: Ic8ed4cc3baf43d639ce13cae256c007728c3ad92 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:9535 Reviewed-on: https://webrtc-review.googlesource.com/c/109884 Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25547}
2018-11-07 14:29:54 +00:00
"../modules/audio_processing:api",
Use relative paths in GN files. BUG=webrtc:7952 TBR=kjellander@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2974863003 Cr-Commit-Position: refs/heads/master@{#18970}
2017-07-11 06:20:45 -07:00
"../modules/video_capture:video_capture_module",
"../pc:libjingle_peerconnection",
Update unityplugin to use VcmCapturer. Replaces use of WebRtcVideoDeviceCapturerFactory. Bug: webrtc:6353 Change-Id: I3c1626af46cb56817190739a39842c4c5a51560d Reviewed-on: https://webrtc-review.googlesource.com/c/115960 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26117}
2019-01-02 15:12:38 +01:00
"../pc:peerconnection",
Break out separate compile targets for various classes This reduces the degree of interdependency among modules related to the PeerConnection class, and makes it easier to isolate inappropriate external dependencies. Bug: webrtc:11967 Change-Id: Id9777a2ab690cc349dd5842a3a95e24478144c71 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185882 Commit-Queue: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32235}
2020-09-29 14:21:47 +00:00
"../pc:video_track_source",
Cleanup BUILD.gn files from imports like foo:foo Repalce all occurrences of foo:foo in deps with just foo in BUILD.gn files. Done with Sublime regex replace. Find: \b([-a-zA-Z0-9_]+):+\1\b In: *.gn Replace with: \1 Bug: None Change-Id: I40aba1b14face687a595b852ffe443cb20197611 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127899 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27225}
2019-03-21 13:35:10 +01:00
"../rtc_base",
Rewrite video_loopback to use new mac capturer. The old one has been deprecated for a long time. Bug: webrtc:6333, webrtc:6898, webrtc:7861 Change-Id: Ib9b798262817e80019afcacc5b41d18957a28101 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/124827 Reviewed-by: Stefan Holmer <stefan@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26993}
2019-03-06 10:34:09 +01:00
"../test:platform_video_capturer",
Update unityplugin to use VcmCapturer. Replaces use of WebRtcVideoDeviceCapturerFactory. Bug: webrtc:6353 Change-Id: I3c1626af46cb56817190739a39842c4c5a51560d Reviewed-on: https://webrtc-review.googlesource.com/c/115960 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26117}
2019-01-02 15:12:38 +01:00
"../test:video_test_common",
Use absl::make_unique and absl::WrapUnique directly Instead of going through our wrappers in ptr_util.h. This CL was generated by the following script: git grep -l ptr_util | xargs perl -pi -e 's,#include "rtc_base/ptr_util.h",#include "absl/memory/memory.h",' git grep -l MakeUnique | xargs perl -pi -e 's,\b(rtc::)?MakeUnique\b,absl::make_unique,g' git grep -l WrapUnique | xargs perl -pi -e 's,\b(rtc::)?WrapUnique\b,absl::WrapUnique,g' git checkout -- rtc_base/ptr_util{.h,_unittest.cc} git cl format Followed by manually adding dependencies on //third_party/abseil-cpp/absl/memory until `gn check` stopped complaining. Bug: webrtc:9473 Change-Id: I89ccd363f070479b8c431eb2c3d404a46eaacc1c Reviewed-on: https://webrtc-review.googlesource.com/86600 Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23850}
2018-07-05 11:40:33 +02:00
"//third_party/abseil-cpp/absl/memory",
An example of Unity native plugin of webrtc for Windows OS Unity native plugin has to use Pinvoke technology in its APIs This plugin dll can also be used by Windows C# applications other than Unity. BUG=webrtc:7389 Review-Url: https://codereview.webrtc.org/2823783002 Cr-Commit-Position: refs/heads/master@{#18108}
2017-05-11 16:10:03 -07:00
]
Add Android Camera To Unity Plugin The existing unity plugin (an example in webrtc codebase) does not support camera access on Android platform. This CL implements such functionality. TBR=gyzhou@chromium.org BUG=webrtc:8067 Review-Url: https://codereview.webrtc.org/2993273002 Cr-Commit-Position: refs/heads/master@{#19277}
2017-08-08 17:08:03 -07:00
if (is_android) {
Synced webrtc_unity_plugin to the latest webrtc and fixed bugs. 1, Let targets libwebrtc_unity and webrtc_unity_plugin built with Ninja -C out/***. 2, Fixed compile issue of libwebrtc_unity. 3, Built libwebrtc_unity classes into Java 7 instead of Java 8 for android. 4, Added an interface to enable peerconnectionFactory for android in Unity. Bug: webrtc:8986 Change-Id: I2a206a77ab38895ec9ac845ce89507d61076d396 Reviewed-on: https://webrtc-review.googlesource.com/59000 Reviewed-by: Qiang Chen <qiangchen@chromium.org> Commit-Queue: George Zhou <gyzhou@chromium.org> Cr-Commit-Position: refs/heads/master@{#22373}
2018-03-07 09:58:54 -08:00
deps += [
Cleanup BUILD.gn files from imports like foo:foo Repalce all occurrences of foo:foo in deps with just foo in BUILD.gn files. Done with Sublime regex replace. Find: \b([-a-zA-Z0-9_]+):+\1\b In: *.gn Replace with: \1 Bug: None Change-Id: I40aba1b14face687a595b852ffe443cb20197611 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127899 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27225}
2019-03-21 13:35:10 +01:00
"../modules/utility",
Synced webrtc_unity_plugin to the latest webrtc and fixed bugs. 1, Let targets libwebrtc_unity and webrtc_unity_plugin built with Ninja -C out/***. 2, Fixed compile issue of libwebrtc_unity. 3, Built libwebrtc_unity classes into Java 7 instead of Java 8 for android. 4, Added an interface to enable peerconnectionFactory for android in Unity. Bug: webrtc:8986 Change-Id: I2a206a77ab38895ec9ac845ce89507d61076d396 Reviewed-on: https://webrtc-review.googlesource.com/59000 Reviewed-by: Qiang Chen <qiangchen@chromium.org> Commit-Queue: George Zhou <gyzhou@chromium.org> Cr-Commit-Position: refs/heads/master@{#22373}
2018-03-07 09:58:54 -08:00
"../sdk/android:libjingle_peerconnection_jni",
]
Add Android Camera To Unity Plugin The existing unity plugin (an example in webrtc codebase) does not support camera access on Android platform. This CL implements such functionality. TBR=gyzhou@chromium.org BUG=webrtc:8067 Review-Url: https://codereview.webrtc.org/2993273002 Cr-Commit-Position: refs/heads/master@{#19277}
2017-08-08 17:08:03 -07:00
}
}
}
if (is_android) {
Reland: "Make javac warnings errors for WebRTC targets." This reverts commit 2bad72a27329ff30ceb9479253f5eb3d21888d25. Reason for revert: Fixing downstream projects (take 2). Original change's description: > Reland "Revert "Make javac warnings errors for WebRTC targets."" > > This is a reland of 098d24c3c18f4b1fd043d7ba716d7601f0ce2b74 > Original change's description: > > Revert "Make javac warnings errors for WebRTC targets." > > > > This reverts commit 19b761403c3522902d69d61179f4d184e3632f79. > > > > Reason for revert: Breaking internal builds > > > > Original change's description: > > > Make javac warnings errors for WebRTC targets. > > > > > > Adds new rtc_* templates for Android targets to allow specifying > > > default values that affect WebRTC targets. > > > > > > Bug: webrtc:6597 > > > Change-Id: Ie529bfc8500d1e785b8a59dba7078b5f88ccfcd1 > > > Reviewed-on: https://webrtc-review.googlesource.com/15103 > > > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > > > Commit-Queue: Sami Kalliomäki <sakal@webrtc.org> > > > Cr-Commit-Position: refs/heads/master@{#20567} > > > TBR=phoglund@webrtc.org,sakal@webrtc.org > > > > Change-Id: I6d3ff5604b3d4307765d3a65adb783f89fcc974c > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: webrtc:6597 > > Reviewed-on: https://webrtc-review.googlesource.com/20740 > > Reviewed-by: Lu Liu <lliuu@webrtc.org> > > Commit-Queue: Lu Liu <lliuu@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#20571} > > Bug: webrtc:6597 > Change-Id: Icfb5ded46ce76b674bae67bfa02054b4ec52bb0f > Reviewed-on: https://webrtc-review.googlesource.com/20800 > Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org> > Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#20577} TBR=phoglund@webrtc.org,ehmaldonado@webrtc.org,mbonadei@webrtc.org,sakal@webrtc.org,lliuu@webrtc.org Change-Id: Id3713c1885318741711987ae642a269a9ca5bb85 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:6597 Reviewed-on: https://webrtc-review.googlesource.com/18441 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20588}
2017-11-07 15:36:33 +00:00
rtc_android_library("webrtc_unity_java") {
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "unityplugin/java/src/org/webrtc/UnityUtility.java" ]
Add Android Camera To Unity Plugin The existing unity plugin (an example in webrtc codebase) does not support camera access on Android platform. This CL implements such functionality. TBR=gyzhou@chromium.org BUG=webrtc:8067 Review-Url: https://codereview.webrtc.org/2993273002 Cr-Commit-Position: refs/heads/master@{#19277}
2017-08-08 17:08:03 -07:00
deps = [
"../rtc_base:base_java",
Use android Nullable instead of javax Nullable This is a propagation of upstream chromium change needed to resume DEPS autorolls into WebRTC. Original comment from upstream change: > This change is made in preparation for an ErrorProne > check to catch this at compile time. See bug for details. Bug: chromium:771683 Change-Id: I56aed15f73a633dcadae7ece6c645cd3596f9257 Reviewed-on: https://webrtc-review.googlesource.com/c/113505 Reviewed-by: Oleh Prypin <oprypin@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Reviewed-by: Sami Kalliomäki <sakal@webrtc.org> Commit-Queue: Artem Titarenko <artit@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25951}
2018-12-10 12:30:46 +01:00
"../sdk/android:camera_java",
Add Android Camera To Unity Plugin The existing unity plugin (an example in webrtc codebase) does not support camera access on Android platform. This CL implements such functionality. TBR=gyzhou@chromium.org BUG=webrtc:8067 Review-Url: https://codereview.webrtc.org/2993273002 Cr-Commit-Position: refs/heads/master@{#19277}
2017-08-08 17:08:03 -07:00
"../sdk/android:libjingle_peerconnection_java",
Use android Nullable instead of javax Nullable This is a propagation of upstream chromium change needed to resume DEPS autorolls into WebRTC. Original comment from upstream change: > This change is made in preparation for an ErrorProne > check to catch this at compile time. See bug for details. Bug: chromium:771683 Change-Id: I56aed15f73a633dcadae7ece6c645cd3596f9257 Reviewed-on: https://webrtc-review.googlesource.com/c/113505 Reviewed-by: Oleh Prypin <oprypin@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Reviewed-by: Sami Kalliomäki <sakal@webrtc.org> Commit-Queue: Artem Titarenko <artit@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25951}
2018-12-10 12:30:46 +01:00
"../sdk/android:peerconnection_java",
Add missing dependencies to java targets. Starting from http://crrev.com/c/2289614, transitive dependencies are not allowed anymore for java targts. This CL prepares WebRTC for the next Chromium Roll. Bug: None Change-Id: I2aafa7be66c215b70d79e0f95272233fe7b37d3a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179061 Reviewed-by: Artem Titov <titovartem@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31695}
2020-07-10 10:36:04 +02:00
"../sdk/android:video_api_java",
Use android Nullable instead of javax Nullable This is a propagation of upstream chromium change needed to resume DEPS autorolls into WebRTC. Original comment from upstream change: > This change is made in preparation for an ErrorProne > check to catch this at compile time. See bug for details. Bug: chromium:771683 Change-Id: I56aed15f73a633dcadae7ece6c645cd3596f9257 Reviewed-on: https://webrtc-review.googlesource.com/c/113505 Reviewed-by: Oleh Prypin <oprypin@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Reviewed-by: Sami Kalliomäki <sakal@webrtc.org> Commit-Queue: Artem Titarenko <artit@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25951}
2018-12-10 12:30:46 +01:00
"../sdk/android:video_java",
Android: Use android_deps directly This is preparing for upstream removing the alias java_groups for the individual support library targets: https://crrev.com/c/1500780 Bug: chromium:937987 Change-Id: I1c9efd83f6997288b334f3dc2f41233fa4e2ab61 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/125961 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#26995}
2019-03-06 09:18:57 -05:00
"//third_party/android_deps:com_android_support_support_annotations_java",
Add Android Camera To Unity Plugin The existing unity plugin (an example in webrtc codebase) does not support camera access on Android platform. This CL implements such functionality. TBR=gyzhou@chromium.org BUG=webrtc:8067 Review-Url: https://codereview.webrtc.org/2993273002 Cr-Commit-Position: refs/heads/master@{#19277}
2017-08-08 17:08:03 -07:00
]
}
dist_jar("libwebrtc_unity") {
_target_dir_name = get_label_info(":$target_name", "dir")
output = "${root_out_dir}/lib.java${_target_dir_name}/${target_name}.jar"
Synced webrtc_unity_plugin to the latest webrtc and fixed bugs. 1, Let targets libwebrtc_unity and webrtc_unity_plugin built with Ninja -C out/***. 2, Fixed compile issue of libwebrtc_unity. 3, Built libwebrtc_unity classes into Java 7 instead of Java 8 for android. 4, Added an interface to enable peerconnectionFactory for android in Unity. Bug: webrtc:8986 Change-Id: I2a206a77ab38895ec9ac845ce89507d61076d396 Reviewed-on: https://webrtc-review.googlesource.com/59000 Reviewed-by: Qiang Chen <qiangchen@chromium.org> Commit-Queue: George Zhou <gyzhou@chromium.org> Cr-Commit-Position: refs/heads/master@{#22373}
2018-03-07 09:58:54 -08:00
direct_deps_only = false
Add Android Camera To Unity Plugin The existing unity plugin (an example in webrtc codebase) does not support camera access on Android platform. This CL implements such functionality. TBR=gyzhou@chromium.org BUG=webrtc:8067 Review-Url: https://codereview.webrtc.org/2993273002 Cr-Commit-Position: refs/heads/master@{#19277}
2017-08-08 17:08:03 -07:00
use_interface_jars = false
Synced webrtc_unity_plugin to the latest webrtc and fixed bugs. 1, Let targets libwebrtc_unity and webrtc_unity_plugin built with Ninja -C out/***. 2, Fixed compile issue of libwebrtc_unity. 3, Built libwebrtc_unity classes into Java 7 instead of Java 8 for android. 4, Added an interface to enable peerconnectionFactory for android in Unity. Bug: webrtc:8986 Change-Id: I2a206a77ab38895ec9ac845ce89507d61076d396 Reviewed-on: https://webrtc-review.googlesource.com/59000 Reviewed-by: Qiang Chen <qiangchen@chromium.org> Commit-Queue: George Zhou <gyzhou@chromium.org> Cr-Commit-Position: refs/heads/master@{#22373}
2018-03-07 09:58:54 -08:00
use_unprocessed_jars = false
Roll chromium_revision 008fb813c3..fe71bbc1fb (503673:503807) + Android fix Specify requires_android = true in Android dist_jar targets. Not specifying it became an error since the commit "Android: Add proguard and dex options to dist_jar" https://chromium-review.googlesource.com/673094 Change log: https://chromium.googlesource.com/chromium/src/+log/008fb813c3..fe71bbc1fb Full diff: https://chromium.googlesource.com/chromium/src/+/008fb813c3..fe71bbc1fb Changed dependencies: * src/base: https://chromium.googlesource.com/chromium/src/base/+log/c18a0c6f24..9529eebc82 * src/build: https://chromium.googlesource.com/chromium/src/build/+log/59ac1990b6..29038c884d * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/17d0800b46..39c4b2fcf7 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/1f35ec36f2..cc96d3d66b * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/7e981769b0..302a45ca40 * src/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/b233ea0e0e..aa736cc76e * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/92042cc6a9..46c94ba649 DEPS diff: https://chromium.googlesource.com/chromium/src/+/008fb813c3..fe71bbc1fb/DEPS No update to Clang. TBR=kjellander@webrtc.org BUG=None CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal Change-Id: Icb025a8a8635bb14da08e2ef3c1ac10ce88cfe15 Reviewed-on: https://webrtc-review.googlesource.com/3060 Commit-Queue: Oleh Prypin <oprypin@webrtc.org> Reviewed-by: Oleh Prypin <oprypin@webrtc.org> Cr-Commit-Position: refs/heads/master@{#19933}
2017-09-24 22:29:06 +02:00
requires_android = true
Add Android Camera To Unity Plugin The existing unity plugin (an example in webrtc codebase) does not support camera access on Android platform. This CL implements such functionality. TBR=gyzhou@chromium.org BUG=webrtc:8067 Review-Url: https://codereview.webrtc.org/2993273002 Cr-Commit-Position: refs/heads/master@{#19277}
2017-08-08 17:08:03 -07:00
deps = [
":webrtc_unity_java",
"../rtc_base:base_java",
"../sdk/android:libjingle_peerconnection_java",
"../sdk/android:libjingle_peerconnection_metrics_default_java",
Android: Use android_deps directly This is preparing for upstream removing the alias java_groups for the individual support library targets: https://crrev.com/c/1500780 Bug: chromium:937987 Change-Id: I1c9efd83f6997288b334f3dc2f41233fa4e2ab61 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/125961 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#26995}
2019-03-06 09:18:57 -05:00
"//third_party/android_deps:com_android_support_support_annotations_java",
Add Android Camera To Unity Plugin The existing unity plugin (an example in webrtc codebase) does not support camera access on Android platform. This CL implements such functionality. TBR=gyzhou@chromium.org BUG=webrtc:8067 Review-Url: https://codereview.webrtc.org/2993273002 Cr-Commit-Position: refs/heads/master@{#19277}
2017-08-08 17:08:03 -07:00
]
An example of Unity native plugin of webrtc for Windows OS Unity native plugin has to use Pinvoke technology in its APIs This plugin dll can also be used by Windows C# applications other than Unity. BUG=webrtc:7389 Review-Url: https://codereview.webrtc.org/2823783002 Cr-Commit-Position: refs/heads/master@{#18108}
2017-05-11 16:10:03 -07:00
}
Split android_junit_tests and move targets in the right package. This is the first step to move //:android_junit_tests to the righ package (the target is triggering presubmit errors every time //BUILD.gn gets updated). Next steps: * Update recipes * Remove //:android_junit_tests Issues with GN formatting, introduced by [1] will be addressed separately in a "format all" CL. [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11289 No-Presubmit: True Change-Id: I70c0927d722911f82dd971c30c7ffb581aed69c0 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166603 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30328}
2020-01-20 15:28:57 +01:00
junit_binary("android_examples_junit_tests") {
sources = [
"androidjunit/src/org/appspot/apprtc/BluetoothManagerTest.java",
"androidjunit/src/org/appspot/apprtc/DirectRTCClientTest.java",
"androidjunit/src/org/appspot/apprtc/TCPChannelClientTest.java",
]
deps = [
":AppRTCMobile_javalib",
Add missing deps for android libs to unblock chromium roll Bug: None Change-Id: I1404f02cf43c3d8288fa7ae3bf128ed76856def4 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176445 Reviewed-by: Sami Kalliomäki <sakal@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31428}
2020-06-03 16:42:57 +02:00
"../sdk/android:peerconnection_java",
Split android_junit_tests and move targets in the right package. This is the first step to move //:android_junit_tests to the righ package (the target is triggering presubmit errors every time //BUILD.gn gets updated). Next steps: * Update recipes * Remove //:android_junit_tests Issues with GN formatting, introduced by [1] will be addressed separately in a "format all" CL. [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11289 No-Presubmit: True Change-Id: I70c0927d722911f82dd971c30c7ffb581aed69c0 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166603 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30328}
2020-01-20 15:28:57 +01:00
"//base:base_java_test_support",
"//third_party/google-truth:google_truth_java",
]
additional_jar_files = [ [
"../sdk/android/tests/resources/robolectric.properties",
"robolectric.properties",
] ]
}
An example of Unity native plugin of webrtc for Windows OS Unity native plugin has to use Pinvoke technology in its APIs This plugin dll can also be used by Windows C# applications other than Unity. BUG=webrtc:7389 Review-Url: https://codereview.webrtc.org/2823783002 Cr-Commit-Position: refs/heads/master@{#18108}
2017-05-11 16:10:03 -07:00
}
Moving stun_prober target from webrtc/p2p to webrtc/examples BUG=webrtc:6440 NOTRY=True Review-Url: https://codereview.webrtc.org/2460343002 Cr-Commit-Position: refs/heads/master@{#14869}
2016-11-01 03:09:15 -07:00
if (!build_with_chromium) {
# Doesn't build within Chrome on Win.
rtc_executable("stun_prober") {
Reland "Enable GN check for webrtc/examples" This is a reland of https://codereview.webrtc.org/2714343002 with the errors related to inclusions of test targets in webrtc/api resolved. BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2733673002 Cr-Commit-Position: refs/heads/master@{#17053}
2017-03-06 00:29:21 -08:00
testonly = true
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "stunprober/main.cc" ]
Moving stun_prober target from webrtc/p2p to webrtc/examples BUG=webrtc:6440 NOTRY=True Review-Url: https://codereview.webrtc.org/2460343002 Cr-Commit-Position: refs/heads/master@{#14869}
2016-11-01 03:09:15 -07:00
deps = [
"../p2p:libstunprober",
"../p2p:rtc_p2p",
Cleanup BUILD.gn files from imports like foo:foo Repalce all occurrences of foo:foo in deps with just foo in BUILD.gn files. Done with Sublime regex replace. Find: \b([-a-zA-Z0-9_]+):+\1\b In: *.gn Replace with: \1 Bug: None Change-Id: I40aba1b14face687a595b852ffe443cb20197611 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127899 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27225}
2019-03-21 13:35:10 +01:00
"../rtc_base",
Fix circular dependencies between optional, array_view, and rtc_base. This splits things out of rtc_base and makes dependencies explicit. Bug: webrtc:6828 Change-Id: Id521896c3c43595349021c857bec216e429a0c8d Reviewed-on: https://webrtc-review.googlesource.com/32780 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21264}
2017-12-13 16:05:42 +01:00
"../rtc_base:checks",
Remove remains of webrtc/base All downstream code have been updated to the new location. In PRESUBMIT.py: * Remove webrtc/rtc_base from CPP_BLACKLIST * Add webrtc/rtc_base to LEGACY_API_DIRS Fix some duplicated paths in webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn BUG=webrtc:7634 TBR=kwiberg@webrtc.org Review-Url: https://codereview.webrtc.org/2976293002 Cr-Commit-Position: refs/heads/master@{#19094}
2017-07-19 10:40:47 -07:00
"../rtc_base:rtc_base_approved",
Switch pc client and stunprober to ABSL_FLAG. Bug: webrtc:10616 Change-Id: I74e65a527da88a7f723c5000e5097dc1766826dd Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144624 Reviewed-by: Tommi <tommi@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28588}
2019-07-16 18:40:05 +02:00
"//third_party/abseil-cpp/absl/flags:flag",
"//third_party/abseil-cpp/absl/flags:parse",
Moving stun_prober target from webrtc/p2p to webrtc/examples BUG=webrtc:6440 NOTRY=True Review-Url: https://codereview.webrtc.org/2460343002 Cr-Commit-Position: refs/heads/master@{#14869}
2016-11-01 03:09:15 -07:00
]
}
}
Reference in New Issue Copy Permalink