admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
webrtc_m130/api/DEPS

305 lines
5.9 KiB
Plaintext
Raw Normal View History

Simplify api/DEPS presubmit check. After the problem fixed by [1], it seems wiser to only check that `include_rules` contains all the top level directories and delegate the action of adding a rule for .cc file to the first user of an header from a new root level directory. This should make the presubmit check more actionable (in [1] for example the solution was to *not* add "+ios" but to consider ios/ as a non WebRTC directory). [1] - https://webrtc-review.googlesource.com/c/107707 Bug: webrtc:9887, webrtc:9924 Change-Id: Ic85e2153a2b83a4874c8faec3c5d1a8c61fe6faf Reviewed-on: https://webrtc-review.googlesource.com/c/107731 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25386}
2018-10-26 13:17:47 +02:00
# This is supposed to be a complete list of top-level directories,
# excepting only api/ itself.
Reland "Add check_deps rules in DEPS files." Relanding https://codereview.webrtc.org/1796413002/ without the change to the openmax_dl include path (which broke downstream code). TBR=tommi@webrtc.org BUG=webrtc:5623 TESTED=Passing runs using: buildtools/checkdeps/checkdeps.py --root=. talk buildtools/checkdeps/checkdeps.py --root=. webrtc Review URL: https://codereview.webrtc.org/1804333002 . Cr-Commit-Position: refs/heads/master@{#12031}
2016-03-17 12:05:36 +01:00
include_rules = [
Use checkdeps to ensure API headers don't include internal headers. This CL updates the checkdeps configuration for the api/ folder in order to explicitly avoid to #include non API headers from API headers. In order to force a careful review of potential exceptions to this rule, the CL also adds mbonadei@ and kwiberg@ as OWNERS of api/DEPS. Bug: webrtc:9887 Change-Id: I0ada6f1020186b2782c7d060af36079c452ba1aa Reviewed-on: https://webrtc-review.googlesource.com/c/106800 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25338}
2018-10-24 13:57:25 +02:00
"-audio",
"-base",
"-build",
"-buildtools",
"-build_overrides",
"-call",
"-common_audio",
"-common_video",
"-data",
"-examples",
Add missing directory to api/DEPS and PRESUBMIT.py. TBR: kwiberg@webrtc.org Bug: webrtc:9887 Change-Id: Ib285005fc2a25549e72922bc38b05a170c6ef228 No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/c/107707 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Yves Gerey <yvesg@google.com> Cr-Commit-Position: refs/heads/master@{#25342}
2018-10-24 15:53:33 +02:00
"-ios",
Use checkdeps to ensure API headers don't include internal headers. This CL updates the checkdeps configuration for the api/ folder in order to explicitly avoid to #include non API headers from API headers. In order to force a careful review of potential exceptions to this rule, the CL also adds mbonadei@ and kwiberg@ as OWNERS of api/DEPS. Bug: webrtc:9887 Change-Id: I0ada6f1020186b2782c7d060af36079c452ba1aa Reviewed-on: https://webrtc-review.googlesource.com/c/106800 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25338}
2018-10-24 13:57:25 +02:00
"-infra",
"-logging",
"-media",
"-modules",
"-out",
"-p2p",
"-pc",
"-resources",
"-rtc_base",
"-rtc_tools",
"-sdk",
"-stats",
"-style-guide",
"-system_wrappers",
"-test",
"-testing",
"-third_party",
"-tools",
"-tools_webrtc",
"-video",
"-external/webrtc/webrtc", # Android platform build.
"-libyuv",
"-common_types.h",
"-WebRTC",
Reland "Add check_deps rules in DEPS files." Relanding https://codereview.webrtc.org/1796413002/ without the change to the openmax_dl include path (which broke downstream code). TBR=tommi@webrtc.org BUG=webrtc:5623 TESTED=Passing runs using: buildtools/checkdeps/checkdeps.py --root=. talk buildtools/checkdeps/checkdeps.py --root=. webrtc Review URL: https://codereview.webrtc.org/1804333002 . Cr-Commit-Position: refs/heads/master@{#12031}
2016-03-17 12:05:36 +01:00
]
specific_include_rules = {
Use checkdeps to ensure API headers don't include internal headers. This CL updates the checkdeps configuration for the api/ folder in order to explicitly avoid to #include non API headers from API headers. In order to force a careful review of potential exceptions to this rule, the CL also adds mbonadei@ and kwiberg@ as OWNERS of api/DEPS. Bug: webrtc:9887 Change-Id: I0ada6f1020186b2782c7d060af36079c452ba1aa Reviewed-on: https://webrtc-review.googlesource.com/c/106800 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25338}
2018-10-24 13:57:25 +02:00
# Some internal headers are allowed even in API headers:
".*\.h": [
"+rtc_base/checks.h",
"+rtc_base/system/rtc_export.h",
Adds shared base class for data units. This reduces code duplication and ensures common behavior between the unit classes. Bug: webrtc:9709 Change-Id: I9529ef10b3f538355f53250a2b67c6b4e250cce8 Reviewed-on: https://webrtc-review.googlesource.com/c/110901 Commit-Queue: Sebastian Jansson <srte@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25690}
2018-11-19 11:17:12 +01:00
"+rtc_base/units/unit_base.h",
Use checkdeps to ensure API headers don't include internal headers. This CL updates the checkdeps configuration for the api/ folder in order to explicitly avoid to #include non API headers from API headers. In order to force a careful review of potential exceptions to this rule, the CL also adds mbonadei@ and kwiberg@ as OWNERS of api/DEPS. Bug: webrtc:9887 Change-Id: I0ada6f1020186b2782c7d060af36079c452ba1aa Reviewed-on: https://webrtc-review.googlesource.com/c/106800 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25338}
2018-10-24 13:57:25 +02:00
],
"array_view\.h": [
"+rtc_base/type_traits.h",
],
Opus implementation of the AudioEncoderFactoryTemplate API This was previously reverted, because external projects were using the internal webrtc::AudioEncoderOpus class and broke when it was renamed. This re-land avoids renaming it immediately, to give those projects time to adapt. It also has to revert some of the changes I had made to the Config struct, since that was also used by the same external projects. BUG=webrtc:7831 Review-Url: https://codereview.webrtc.org/2948483002 Cr-Commit-Position: refs/heads/master@{#18852}
2017-06-30 04:23:22 -07:00
# Needed because AudioEncoderOpus is in the wrong place for
# backwards compatibilty reasons. See
# https://bugs.chromium.org/p/webrtc/issues/detail?id=7847
"audio_encoder_opus\.h": [
Fixing WebRTC after moving from src/webrtc to src/ In https://webrtc-review.googlesource.com/c/src/+/1560 we moved WebRTC from src/webrtc to src/ (in order to preserve an healthy git history). This CL takes care of fixing header guards, #include paths, etc... NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true TBR=tommi@webrtc.org Bug: chromium:611808 Change-Id: Iea91618212bee0af16aa3f05071eab8f93706578 Reviewed-on: https://webrtc-review.googlesource.com/1561 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#19846}
2017-09-15 06:47:31 +02:00
"+modules/audio_coding/codecs/opus/audio_encoder_opus.h",
Opus implementation of the AudioEncoderFactoryTemplate API This was previously reverted, because external projects were using the internal webrtc::AudioEncoderOpus class and broke when it was renamed. This re-land avoids renaming it immediately, to give those projects time to adapt. It also has to revert some of the changes I had made to the Config struct, since that was also used by the same external projects. BUG=webrtc:7831 Review-Url: https://codereview.webrtc.org/2948483002 Cr-Commit-Position: refs/heads/master@{#18852}
2017-06-30 04:23:22 -07:00
],
Use checkdeps to ensure API headers don't include internal headers. This CL updates the checkdeps configuration for the api/ folder in order to explicitly avoid to #include non API headers from API headers. In order to force a careful review of potential exceptions to this rule, the CL also adds mbonadei@ and kwiberg@ as OWNERS of api/DEPS. Bug: webrtc:9887 Change-Id: I0ada6f1020186b2782c7d060af36079c452ba1aa Reviewed-on: https://webrtc-review.googlesource.com/c/106800 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25338}
2018-10-24 13:57:25 +02:00
"asyncresolverfactory\.h": [
"+rtc_base/asyncresolverinterface.h",
],
"candidate\.h": [
"+rtc_base/network_constants.h",
"+rtc_base/socketaddress.h",
],
"datachannelinterface\.h": [
"+rtc_base/copyonwritebuffer.h",
"+rtc_base/refcount.h",
],
"dtmfsenderinterface\.h": [
"+rtc_base/refcount.h",
],
"fec_controller\.h": [
"+modules/include/module_fec_types.h",
],
"jsep\.h": [
"+rtc_base/refcount.h",
],
"jsepicecandidate\.h": [
"+rtc_base/constructormagic.h",
],
"jsepsessiondescription\.h": [
"+rtc_base/constructormagic.h",
],
"mediastreaminterface\.h": [
"+modules/audio_processing/include/audio_processing_statistics.h",
"+rtc_base/refcount.h",
"+rtc_base/scoped_ref_ptr.h",
],
Add interfaces for using MediaTransport as the transport for data channels. Adds the types and methods required for sending and receiving data channel messages over the media transport. These are: - A DataMessageType to distinguish between text, binary, and control messages - A parameters struct for sending data messages, which specifies the channel id, type, and ordering/reliability parameters - A sink for data-channel related callbacks (receive data, begin closing procedure, and end closing procedure) - A method to set the sink for data channels - Methods to open, close, and send on data channels These methods, combined with the state sink, allow PeerConnection to implement the DataChannelProviderInterface using MediaTransport as the underlying transport. Change-Id: Iccb2ba374594762a5b4f995564e2a1ff7d8805f5 Bug: webrtc:9719 Reviewed-on: https://webrtc-review.googlesource.com/c/108541 Reviewed-by: Anton Sukhanov <sukhanov@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Seth Hampson <shampson@webrtc.org> Reviewed-by: Peter Slatala <psla@webrtc.org> Commit-Queue: Bjorn Mellem <mellem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25454}
2018-10-30 15:15:00 -07:00
"media_transport_interface\.h": [
"+rtc_base/copyonwritebuffer.h", # As used by datachannelinterface.h
Callback changes to media transport interface: 1) allow multiple target rate observers 2) add getter for overhead 3) add getter for target rate 4) add callback for network route changed. Bug: webrtc:9719 Change-Id: I06518cd9aed0ebabd204a7f6af3b86f51fd694e0 Reviewed-on: https://webrtc-review.googlesource.com/c/109940 Reviewed-by: Steve Anton <steveanton@webrtc.org> Reviewed-by: Qingsi Wang <qingsi@webrtc.org> Reviewed-by: Anton Sukhanov <sukhanov@webrtc.org> Reviewed-by: Bjorn Mellem <mellem@webrtc.org> Commit-Queue: Peter Slatala <psla@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25572}
2018-11-08 07:43:31 -08:00
"+rtc_base/networkroute.h"
Add interfaces for using MediaTransport as the transport for data channels. Adds the types and methods required for sending and receiving data channel messages over the media transport. These are: - A DataMessageType to distinguish between text, binary, and control messages - A parameters struct for sending data messages, which specifies the channel id, type, and ordering/reliability parameters - A sink for data-channel related callbacks (receive data, begin closing procedure, and end closing procedure) - A method to set the sink for data channels - Methods to open, close, and send on data channels These methods, combined with the state sink, allow PeerConnection to implement the DataChannelProviderInterface using MediaTransport as the underlying transport. Change-Id: Iccb2ba374594762a5b4f995564e2a1ff7d8805f5 Bug: webrtc:9719 Reviewed-on: https://webrtc-review.googlesource.com/c/108541 Reviewed-by: Anton Sukhanov <sukhanov@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Seth Hampson <shampson@webrtc.org> Reviewed-by: Peter Slatala <psla@webrtc.org> Commit-Queue: Bjorn Mellem <mellem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25454}
2018-10-30 15:15:00 -07:00
],
Use checkdeps to ensure API headers don't include internal headers. This CL updates the checkdeps configuration for the api/ folder in order to explicitly avoid to #include non API headers from API headers. In order to force a careful review of potential exceptions to this rule, the CL also adds mbonadei@ and kwiberg@ as OWNERS of api/DEPS. Bug: webrtc:9887 Change-Id: I0ada6f1020186b2782c7d060af36079c452ba1aa Reviewed-on: https://webrtc-review.googlesource.com/c/106800 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25338}
2018-10-24 13:57:25 +02:00
"peerconnectionfactoryproxy\.h": [
"+rtc_base/bind.h",
],
"refcountedbase\.h": [
"+rtc_base/constructormagic.h",
"+rtc_base/refcount.h",
"+rtc_base/refcounter.h",
],
"rtcerror\.h": [
"+rtc_base/logging.h",
],
"rtpreceiverinterface\.h": [
"+rtc_base/refcount.h",
"+rtc_base/scoped_ref_ptr.h",
],
"rtpsenderinterface\.h": [
"+rtc_base/refcount.h",
"+rtc_base/scoped_ref_ptr.h",
],
"rtptransceiverinterface\.h": [
"+rtc_base/refcount.h",
],
"setremotedescriptionobserverinterface\.h": [
"+rtc_base/refcount.h",
],
"statstypes\.h": [
"+rtc_base/constructormagic.h",
"+rtc_base/refcount.h",
"+rtc_base/scoped_ref_ptr.h",
"+rtc_base/stringencode.h",
"+rtc_base/thread_checker.h",
],
"umametrics\.h": [
"+rtc_base/refcount.h",
],
"audio_frame\.h": [
"+rtc_base/constructormagic.h",
],
"audio_mixer\.h": [
"+rtc_base/refcount.h",
],
"audio_decoder\.h": [
"+rtc_base/buffer.h",
"+rtc_base/constructormagic.h",
],
"audio_decoder_factory\.h": [
"+rtc_base/refcount.h",
],
"audio_decoder_factory_template\.h": [
"+rtc_base/refcountedobject.h",
"+rtc_base/scoped_ref_ptr.h",
],
"audio_encoder\.h": [
"+rtc_base/buffer.h",
"+rtc_base/deprecation.h",
],
"audio_encoder_factory\.h": [
"+rtc_base/refcount.h",
],
"audio_encoder_factory_template\.h": [
"+rtc_base/refcountedobject.h",
"+rtc_base/scoped_ref_ptr.h",
],
"builtin_audio_decoder_factory\.h": [
"+rtc_base/scoped_ref_ptr.h",
],
"builtin_audio_encoder_factory\.h": [
"+rtc_base/scoped_ref_ptr.h",
],
"framedecryptorinterface\.h": [
"+rtc_base/refcount.h",
],
"frameencryptorinterface\.h": [
"+rtc_base/refcount.h",
],
"ortcfactoryinterface\.h": [
"+rtc_base/network.h",
"+rtc_base/scoped_ref_ptr.h",
"+rtc_base/thread.h",
],
"udptransportinterface\.h": [
"+rtc_base/socketaddress.h",
],
"rtcstatscollectorcallback\.h": [
"+rtc_base/refcount.h",
"+rtc_base/scoped_ref_ptr.h",
],
"rtcstatsreport\.h": [
"+rtc_base/refcount.h",
"+rtc_base/refcountedobject.h",
"+rtc_base/scoped_ref_ptr.h",
],
"audioproc_float\.h": [
"+modules/audio_processing/include/audio_processing.h",
],
"fake_frame_decryptor\.h": [
"+rtc_base/refcountedobject.h",
],
"fake_frame_encryptor\.h": [
"+rtc_base/refcountedobject.h",
],
"fakeconstraints\.h": [
"+rtc_base/stringencode.h",
],
"mock.*\.h": [
"+test/gmock.h",
],
"simulated_network\.h": [
"+rtc_base/criticalsection.h",
"+rtc_base/random.h",
"+rtc_base/thread_annotations.h",
],
"test_dependency_factory\.h": [
"+rtc_base/thread_checker.h",
],
"videocodec_test_fixture\.h": [
"+modules/video_coding/include/video_codec_interface.h"
],
"i010_buffer\.h": [
"+rtc_base/memory/aligned_malloc.h"
],
"i420_buffer\.h": [
"+rtc_base/memory/aligned_malloc.h",
],
"video_frame_buffer\.h": [
"+rtc_base/refcount.h",
"+rtc_base/scoped_ref_ptr.h",
],
"video_timing\.h": [
"+rtc_base/numerics/safe_conversions.h",
],
"video_encoder_config\.h": [
"+rtc_base/refcount.h",
"+rtc_base/scoped_ref_ptr.h",
],
Simplify api/DEPS presubmit check. After the problem fixed by [1], it seems wiser to only check that `include_rules` contains all the top level directories and delegate the action of adding a rule for .cc file to the first user of an header from a new root level directory. This should make the presubmit check more actionable (in [1] for example the solution was to *not* add "+ios" but to consider ios/ as a non WebRTC directory). [1] - https://webrtc-review.googlesource.com/c/107707 Bug: webrtc:9887, webrtc:9924 Change-Id: Ic85e2153a2b83a4874c8faec3c5d1a8c61fe6faf Reviewed-on: https://webrtc-review.googlesource.com/c/107731 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25386}
2018-10-26 13:17:47 +02:00
# .cc files in api/ should not be restricted in what they can #include,
# so we re-add all the top-level directories here. (That's because .h
# files leak their #includes to whoever's #including them, but .cc files
# do not since no one #includes them.)
Move AudioDecoder and related stuff to the api/ directory BUG=webrtc:5805, webrtc:6725 Review-Url: https://codereview.webrtc.org/2668523004 Cr-Commit-Position: refs/heads/master@{#16534}
2017-02-10 08:15:44 -08:00
".*\.cc": [
Use checkdeps to ensure API headers don't include internal headers. This CL updates the checkdeps configuration for the api/ folder in order to explicitly avoid to #include non API headers from API headers. In order to force a careful review of potential exceptions to this rule, the CL also adds mbonadei@ and kwiberg@ as OWNERS of api/DEPS. Bug: webrtc:9887 Change-Id: I0ada6f1020186b2782c7d060af36079c452ba1aa Reviewed-on: https://webrtc-review.googlesource.com/c/106800 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25338}
2018-10-24 13:57:25 +02:00
"+audio",
"+call",
"+common_audio",
"+common_video",
"+examples",
"+logging",
"+media",
"+modules",
"+p2p",
"+pc",
"+rtc_base",
"+rtc_tools",
"+sdk",
"+stats",
"+system_wrappers",
"+test",
"+tools",
"+tools_webrtc",
"+video",
"+third_party",
Add CreatePeerConnectionFactory overloads that take audio codec factory args BUG=5805 Review-Url: https://codereview.webrtc.org/2653343003 Cr-Commit-Position: refs/heads/master@{#16371}
2017-01-31 01:48:08 -08:00
],
Reland "Add check_deps rules in DEPS files." Relanding https://codereview.webrtc.org/1796413002/ without the change to the openmax_dl include path (which broke downstream code). TBR=tommi@webrtc.org BUG=webrtc:5623 TESTED=Passing runs using: buildtools/checkdeps/checkdeps.py --root=. talk buildtools/checkdeps/checkdeps.py --root=. webrtc Review URL: https://codereview.webrtc.org/1804333002 . Cr-Commit-Position: refs/heads/master@{#12031}
2016-03-17 12:05:36 +01:00
}
Reference in New Issue Copy Permalink