admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
webrtc_m130/modules/congestion_controller/BUILD.gn

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

125 lines
3.9 KiB
Plaintext
Raw Normal View History

Move congestion controller to a separate module. This allows other projects to more easily depend on this. The plan is to move remote_bitrate_estimator and bitrate_controller into this module and reduce the exposed interface to only a simplified version of congestion_controller.h. No functional changes in this CL. R=mflodman@webrtc.org, pbos@webrtc.org Review URL: https://codereview.webrtc.org/1718473002 . Cr-Commit-Position: refs/heads/master@{#11718}
2016-02-23 13:30:42 +01:00
# Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
#
# Use of this source code is governed by a BSD-style license
# that can be found in the LICENSE file in the root of the source
# tree. An additional intellectual property rights grant can be found
# in the file PATENTS. All contributing project authors may
# be found in the AUTHORS file in the root of the source tree.
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
import("../../webrtc.gni")
Move congestion controller to a separate module. This allows other projects to more easily depend on this. The plan is to move remote_bitrate_estimator and bitrate_controller into this module and reduce the exposed interface to only a simplified version of congestion_controller.h. No functional changes in this CL. R=mflodman@webrtc.org, pbos@webrtc.org Review URL: https://codereview.webrtc.org/1718473002 . Cr-Commit-Position: refs/heads/master@{#11718}
2016-02-23 13:30:42 +01:00
GN: Change rtc_source_set targets --> rtc_static_library This changes most non-test related rtc_source_set targets to be rtc_static_library instead. Targets without any .cc files are excluded. This should bring back the build behavior we used to have with GYP (i.e. same symbols exported in the libjingle_peerconnection.a file, which are used by some downstream projects). After doing an Android build with these changes: $ nm --defined-only -g -C out/Release/lib.unstripped/libjingle_peerconnection_so.so | grep -i createpeerconnectionf 00077c51 T Java_org_webrtc_PeerConnectionFactory_nativeCreatePeerConnectionFactory $ nm --defined-only -g -C out/Release/obj/webrtc/api/libjingle_peerconnection.a | grep -i createpeerconnectionf 00000001 T webrtc::CreatePeerConnectionFactory(rtc::Thread*, rtc::Thread*, rtc::Thread*, webrtc::AudioDeviceModule*, cricket::WebRtcVideoEncoderFactory*, cricket::WebRtcVideoDecoderFactory*) 00000001 T webrtc::CreatePeerConnectionFactory() See https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/cookbook.md#Note-on-static-libraries for more details on this. NOTICE: This should be further cleaned up in the future, to reduce binary bloat and unnecessary linking time. Right now it's more important to restore the desired build output though. BUG=webrtc:6410, chromium:630755 Review-Url: https://codereview.webrtc.org/2361623004 Cr-Commit-Position: refs/heads/master@{#14364}
2016-09-23 00:38:52 -07:00
rtc_static_library("congestion_controller") {
Move congestion controller to a separate module. This allows other projects to more easily depend on this. The plan is to move remote_bitrate_estimator and bitrate_controller into this module and reduce the exposed interface to only a simplified version of congestion_controller.h. No functional changes in this CL. R=mflodman@webrtc.org, pbos@webrtc.org Review URL: https://codereview.webrtc.org/1718473002 . Cr-Commit-Position: refs/heads/master@{#11718}
2016-02-23 13:30:42 +01:00
sources = [
Reimplemeted "Test and fix for huge bwe drop after alr state" BUG=webrtc:7746 Test and fix for huge bwe drop after alr state. BUG=webrtc:7746 Review-Url: https://codereview.webrtc.org/2931873002 Cr-Commit-Position: refs/heads/master@{#18692} Committed: https://chromium.googlesource.com/external/webrtc/+/37aa8ba61641962119071646175bfe3bc2bda063 patch from issue 2931873002 at patchset 320001 (http://crrev.com/2931873002#ps320001) Review-Url: https://codereview.webrtc.org/2970653004 Cr-Commit-Position: refs/heads/master@{#19055}
2017-07-17 01:41:41 -07:00
"acknowledged_bitrate_estimator.cc",
"acknowledged_bitrate_estimator.h",
"bitrate_estimator.cc",
"bitrate_estimator.h",
Use |probe_cluster_id| to cluster packets. Introduced new class DelayBasedProbingEstimator which is a copy of RemoteBitrateEstimatorAbsSendTime with only minor changes. This makes probing more reliable but is still not usable for mid-call probing. BUG= Review-Url: https://codereview.webrtc.org/2038023002 Cr-Commit-Position: refs/heads/master@{#13195}
2016-06-17 09:21:34 -07:00
"delay_based_bwe.cc",
"delay_based_bwe.h",
Split CongestionController into send- and receive-side classes. New class ReceiveSideCongestionController, extracted from CongestionController, and responsible for the OnReceivedPacket processing. Rest of the CongestionController moved to a new class SendSideCongestionController. To avoid breaking applications, CongestionController is redefined as a union of these two classes, with no intended change in behavior. With one exception: CongestionController::SetBweBitrates used to call remote_bitrate_estimator_.SetMinBitrate, but after remote_bitrate_estimator_ was moved to ReceiveSideCongestionController, it no longer does this. BUG=webrtc:6847 Review-Url: https://codereview.webrtc.org/2752233002 Cr-Commit-Position: refs/heads/master@{#17321}
2017-03-21 06:41:12 -07:00
"include/receive_side_congestion_controller.h",
"include/send_side_congestion_controller.h",
Implement Theil-Sen's method for fitting a line to noisy data (used in bandwidth estimation). Theil and Sen's estimator essentially looks at the line through every pair of points and selects the median slope. This is robust to corruption of up to 29% of the data points. Wire up new estimator to field trial experiment. Add unit and integration tests. Results are promising. BUG=webrtc:6728 Review-Url: https://codereview.webrtc.org/2512693002 Cr-Commit-Position: refs/heads/master@{#15508}
2016-12-09 05:50:01 -08:00
"median_slope_estimator.cc",
"median_slope_estimator.h",
New ProbingCalculator class. The ProbingCalculator class calculates and validates the results from probing attempts. BUG=webrtc:5859 Review-Url: https://codereview.webrtc.org/2121183002 Cr-Commit-Position: refs/heads/master@{#13589}
2016-08-01 08:49:04 -07:00
"probe_bitrate_estimator.cc",
"probe_bitrate_estimator.h",
Probing: Add support for exponential startup probing Adds support for exponentially probing the bandwidth at start-up to allow ramp-up to real capacity of the network. BUG=webrtc:6332 R=philipel@webrtc.org, stefan@webrtc.org Review URL: https://codereview.webrtc.org/2235373004 . Cr-Commit-Position: refs/heads/master@{#14189}
2016-09-12 12:28:54 -07:00
"probe_controller.cc",
"probe_controller.h",
Split CongestionController into send- and receive-side classes. New class ReceiveSideCongestionController, extracted from CongestionController, and responsible for the OnReceivedPacket processing. Rest of the CongestionController moved to a new class SendSideCongestionController. To avoid breaking applications, CongestionController is redefined as a union of these two classes, with no intended change in behavior. With one exception: CongestionController::SetBweBitrates used to call remote_bitrate_estimator_.SetMinBitrate, but after remote_bitrate_estimator_ was moved to ReceiveSideCongestionController, it no longer does this. BUG=webrtc:6847 Review-Url: https://codereview.webrtc.org/2752233002 Cr-Commit-Position: refs/heads/master@{#17321}
2017-03-21 06:41:12 -07:00
"receive_side_congestion_controller.cc",
"send_side_congestion_controller.cc",
Reland: Fix race / crash in OnNetworkRouteChanged(). To achieve this some refactoring was done to make it possible to synchronize access to the DelayBasedBwe in TransportFeedbackAdapter: - The callback was removed from DelayBasedBwe, it now instead returns its result. - TransportFeedbackAdapter was moved to modules/congestion_controller to avoid unnecessary dependencies. Reenables previously disabled flaky test. Can no longer reproduce flakiness with gtest-parallel and asan/tsan builds. BUG=webrtc:6427, webrtc:6422 R=terelius@webrtc.org Review URL: https://codereview.webrtc.org/2378103005 . Cr-Commit-Position: refs/heads/master@{#14452}
2016-09-30 10:06:51 +02:00
"transport_feedback_adapter.cc",
"transport_feedback_adapter.h",
Add a new overuse estimator for the delay based BWE behind experiment. Parse the estimation parameters from the field trial string. BUG=webrtc:6690 Review-Url: https://codereview.webrtc.org/2489323002 Cr-Commit-Position: refs/heads/master@{#15126}
2016-11-17 03:48:18 -08:00
"trendline_estimator.cc",
"trendline_estimator.h",
Move congestion controller to a separate module. This allows other projects to more easily depend on this. The plan is to move remote_bitrate_estimator and bitrate_controller into this module and reduce the exposed interface to only a simplified version of congestion_controller.h. No functional changes in this CL. R=mflodman@webrtc.org, pbos@webrtc.org Review URL: https://codereview.webrtc.org/1718473002 . Cr-Commit-Position: refs/heads/master@{#11718}
2016-02-23 13:30:42 +01:00
]
Add a new overuse estimator for the delay based BWE behind experiment. Parse the estimation parameters from the field trial string. BUG=webrtc:6690 Review-Url: https://codereview.webrtc.org/2489323002 Cr-Commit-Position: refs/heads/master@{#15126}
2016-11-17 03:48:18 -08:00
if (rtc_enable_bwe_test_logging) {
defines = [ "BWE_TEST_LOGGING_COMPILE_TIME_ENABLE=1" ]
} else {
defines = [ "BWE_TEST_LOGGING_COMPILE_TIME_ENABLE=0" ]
}
GN: Replace Windows suppressions of warning 4267 with config. This makes the GN configurations easier to read. BUG=webrtc:5949 NOTRY=True Review-Url: https://codereview.webrtc.org/2020343003 Cr-Commit-Position: refs/heads/master@{#13006}
2016-06-02 02:09:52 -07:00
# TODO(jschuh): Bug 1348: fix this warning.
configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
GN: Exclude suppressions of Chromium Clang warnings for Chromium builds. These suppressions are causing GN errors when Chromium targets are depending directly on WebRTC targets (needed for https://codereview.chromium.org/2413103004) BUG=webrtc:4256 NOTRY=True Review-Url: https://codereview.webrtc.org/2408133008 Cr-Commit-Position: refs/heads/master@{#14644}
2016-10-16 23:56:12 -07:00
if (!build_with_chromium && is_clang) {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
GN: Introduce templates. Defines the rtc_executable, rtc_source_set, rtc_test and rtc_static_library templates. These templates provide no functionality yet, but will enable common configuration to be introduced, avoiding repetition in every target Changes summary: - Prepend rtc_ to test, source_set, executable and static_library targets - Change "configs -= [" to "suppressed_configs += [" - Include webrtc/build/webrtc.gni where it wasn't included yet - Delete import("//testing/test.gni"), since rtc_test makes it unnecessary. BUG=webrtc:6187 TBR=henrik.lundin@webrtc.org,tommi@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2301053002 Cr-Commit-Position: refs/heads/master@{#14043}
2016-09-02 04:10:34 -07:00
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
Move congestion controller to a separate module. This allows other projects to more easily depend on this. The plan is to move remote_bitrate_estimator and bitrate_controller into this module and reduce the exposed interface to only a simplified version of congestion_controller.h. No functional changes in this CL. R=mflodman@webrtc.org, pbos@webrtc.org Review URL: https://codereview.webrtc.org/1718473002 . Cr-Commit-Position: refs/heads/master@{#11718}
2016-02-23 13:30:42 +01:00
}
deps = [
Reland of Creating webrtc/modules:module_api (patchset #1 id:1 of https://codereview.webrtc.org/2839963005/ ) Reason for revert: Fixing the Gn error and try to reland. Original issue's description: > Revert of Creating webrtc/modules:module_api (patchset #5 id:80001 of https://codereview.webrtc.org/2838873002/ ) > > Reason for revert: > Causes build problem: https://build.chromium.org/p/client.webrtc/builders/iOS64%20Sim%20Debug%20%28iOS%209.0%29/builds/1630/steps/generate%20build%20files%20%28mb%29/logs/stdio > > Original issue's description: > > Creating webrtc/modules:module_api > > > > This target keeps track of .h the files under webrtc/modules/include/ > > that are not part of any target. > > If a .h file is not part of a target the 'gn check' utility is not > > able to spot if a target is missing a dependency because even if > > it parses '#include' directives it is not able to find a target that > > contains these headers. > > > > BUG=webrtc:7513 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/2838873002 > > Cr-Commit-Position: refs/heads/master@{#17880} > > Committed: https://chromium.googlesource.com/external/webrtc/+/5a1a092ed09ca92719eeb293275f64c0cdcc0e51 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7513 > > Review-Url: https://codereview.webrtc.org/2839963005 > Cr-Commit-Position: refs/heads/master@{#17881} > Committed: https://chromium.googlesource.com/external/webrtc/+/bb08c3e29656fafe8a2d5d16ec4a62db49689f8a TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true TBR=kjellander@webrtc.org BUG=webrtc:7513 Review-Url: https://codereview.webrtc.org/2843913002 Cr-Commit-Position: refs/heads/master@{#17884}
2017-04-26 03:38:35 -07:00
"..:module_api",
Refactor bitrate_controller, remote_bitrate_estimator and congestion_contoller for gn check. These targets are now checked: - "//webrtc/modules/bitrate_controller/*" - "//webrtc/modules/congestion_controller/*" - "//webrtc/modules/remote_bitrate_estimator/*" BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2602563003 Cr-Commit-Position: refs/heads/master@{#15818}
2016-12-28 04:43:46 -08:00
"../..:webrtc_common",
Fix circular dependencies in webrtc_common. One reason for the circular deps is that common_types.h is a historical dumping ground for various structs and defines that are believed to be generally useful. I tried moving things out that did not appear to be used downstream (StreamCounters, RtpCounters etc) and moved the things that seemed used (RtpHeader + supporting structs) to a new file api/rtp_headers.h. This makes their place in the api more clear while moving out the things that don't belong in the API in the first place. I had to extract out typedefs.h from webrtc_common to resolve another circular dependency. I believe checks includes typedefs, but common depends on checks. Bug: webrtc:7745 Change-Id: I725d49616b1ec0cdc8b74be7c078f7a4d46f084b Reviewed-on: https://webrtc-review.googlesource.com/33001 Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21295}
2017-12-15 14:40:10 +01:00
"../../:typedefs",
Move optional.h to webrtc/api/ We use Optional in our public API, so its header should be in webrtc/api/. BUG=webrtc:8205 Review-Url: https://codereview.webrtc.org/3011943002 Cr-Commit-Position: refs/heads/master@{#19693}
2017-09-05 08:43:13 -07:00
"../../api:optional",
Add logging of delay-based bandwidth estimate. BUG=webrtc:6423 Review-Url: https://codereview.webrtc.org/2695923004 Cr-Commit-Position: refs/heads/master@{#16663}
2017-02-17 03:38:28 -08:00
"../../logging:rtc_event_log_api",
Fix circular dependencies between optional, array_view, and rtc_base. This splits things out of rtc_base and makes dependencies explicit. Bug: webrtc:6828 Change-Id: Id521896c3c43595349021c857bec216e429a0c8d Reviewed-on: https://webrtc-review.googlesource.com/32780 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21264}
2017-12-13 16:05:42 +01:00
"../../rtc_base:checks",
"../../rtc_base:rate_limiter",
Remove remains of webrtc/base All downstream code have been updated to the new location. In PRESUBMIT.py: * Remove webrtc/rtc_base from CPP_BLACKLIST * Add webrtc/rtc_base to LEGACY_API_DIRS Fix some duplicated paths in webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn BUG=webrtc:7634 TBR=kwiberg@webrtc.org Review-Url: https://codereview.webrtc.org/2976293002 Cr-Commit-Position: refs/heads/master@{#19094}
2017-07-19 10:40:47 -07:00
"../../rtc_base:rtc_base",
"../../rtc_base:rtc_base_approved",
"../../rtc_base:rtc_numerics",
Refactor bitrate_controller, remote_bitrate_estimator and congestion_contoller for gn check. These targets are now checked: - "//webrtc/modules/bitrate_controller/*" - "//webrtc/modules/congestion_controller/*" - "//webrtc/modules/remote_bitrate_estimator/*" BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2602563003 Cr-Commit-Position: refs/heads/master@{#15818}
2016-12-28 04:43:46 -08:00
"../../system_wrappers",
Stop using public_deps in system_wrappers. TBR=phoglund@webrtc.org Bug: webrtc:8603 Change-Id: I5e515f0e4dc955a01460d69ba4e21bdfdf152d20 Reviewed-on: https://webrtc-review.googlesource.com/29104 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21112}
2017-12-06 09:17:14 +01:00
"../../system_wrappers:field_trial_api",
"../../system_wrappers:metrics_api",
Move congestion controller to a separate module. This allows other projects to more easily depend on this. The plan is to move remote_bitrate_estimator and bitrate_controller into this module and reduce the exposed interface to only a simplified version of congestion_controller.h. No functional changes in this CL. R=mflodman@webrtc.org, pbos@webrtc.org Review URL: https://codereview.webrtc.org/1718473002 . Cr-Commit-Position: refs/heads/master@{#11718}
2016-02-23 13:30:42 +01:00
"../bitrate_controller",
"../pacing",
Refactor bitrate_controller, remote_bitrate_estimator and congestion_contoller for gn check. These targets are now checked: - "//webrtc/modules/bitrate_controller/*" - "//webrtc/modules/congestion_controller/*" - "//webrtc/modules/remote_bitrate_estimator/*" BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2602563003 Cr-Commit-Position: refs/heads/master@{#15818}
2016-12-28 04:43:46 -08:00
"../remote_bitrate_estimator",
Stop using public_deps in modules/rtp_rtcp. TBR=phoglund@webrtc.org Bug: webrtc:8603 Change-Id: I86830df23db3f33a1a26098e639596bd3b86485a No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/29780 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21108}
2017-12-06 07:51:33 +01:00
"../rtp_rtcp:rtp_rtcp_format",
Refactor bitrate_controller, remote_bitrate_estimator and congestion_contoller for gn check. These targets are now checked: - "//webrtc/modules/bitrate_controller/*" - "//webrtc/modules/congestion_controller/*" - "//webrtc/modules/remote_bitrate_estimator/*" BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2602563003 Cr-Commit-Position: refs/heads/master@{#15818}
2016-12-28 04:43:46 -08:00
"../utility",
Move congestion controller to a separate module. This allows other projects to more easily depend on this. The plan is to move remote_bitrate_estimator and bitrate_controller into this module and reduce the exposed interface to only a simplified version of congestion_controller.h. No functional changes in this CL. R=mflodman@webrtc.org, pbos@webrtc.org Review URL: https://codereview.webrtc.org/1718473002 . Cr-Commit-Position: refs/heads/master@{#11718}
2016-02-23 13:30:42 +01:00
]
}
GN: Refactor modules_unittests to eliminate package boundary violations. BUG=webrtc:6954 Review-Url: https://codereview.webrtc.org/2629923002 Cr-Commit-Position: refs/heads/master@{#16166}
2017-01-19 08:27:11 -08:00
if (rtc_include_tests) {
rtc_source_set("congestion_controller_unittests") {
testonly = true
GN: Tighten up test target visibility + refactorings Make all rtc_source_test target that contains tests that are included in a test executable only be visible to the rtc_test target. Doing this exposed a couple of errors and dependency problems that were resolved. Having this could have prevented duplicated execution of tests like the case that was recently fixed by deadbeef@ in https://codereview.webrtc.org/2820263004 New targets: * //webrtc/modules/rtp_rtcp:fec_test_helper * //webrtc/modules/rtp_rtcp:mock_rtp_rtcp * //webrtc/modules/remote_bitrate_estimator:mock_remote_bitrate_observer The mock files and targets should probably be moved into webrtc/test in the future, but that's out of the scope of this CL. BUG=webrtc:5716 NOTRY=True Review-Url: https://codereview.webrtc.org/2828793003 Cr-Commit-Position: refs/heads/master@{#17863}
2017-04-25 04:04:50 -07:00
GN: Refactor modules_unittests to eliminate package boundary violations. BUG=webrtc:6954 Review-Url: https://codereview.webrtc.org/2629923002 Cr-Commit-Position: refs/heads/master@{#16166}
2017-01-19 08:27:11 -08:00
sources = [
Reimplemeted "Test and fix for huge bwe drop after alr state" BUG=webrtc:7746 Test and fix for huge bwe drop after alr state. BUG=webrtc:7746 Review-Url: https://codereview.webrtc.org/2931873002 Cr-Commit-Position: refs/heads/master@{#18692} Committed: https://chromium.googlesource.com/external/webrtc/+/37aa8ba61641962119071646175bfe3bc2bda063 patch from issue 2931873002 at patchset 320001 (http://crrev.com/2931873002#ps320001) Review-Url: https://codereview.webrtc.org/2970653004 Cr-Commit-Position: refs/heads/master@{#19055}
2017-07-17 01:41:41 -07:00
"acknowledged_bitrate_estimator_unittest.cc",
Move delay_based_bwe_ into CongestionController BUG=webrtc:7058 Review-Url: https://codereview.webrtc.org/2725823002 Cr-Commit-Position: refs/heads/master@{#17146}
2017-03-09 06:40:08 -08:00
"congestion_controller_unittests_helper.cc",
"congestion_controller_unittests_helper.h",
GN: Refactor modules_unittests to eliminate package boundary violations. BUG=webrtc:6954 Review-Url: https://codereview.webrtc.org/2629923002 Cr-Commit-Position: refs/heads/master@{#16166}
2017-01-19 08:27:11 -08:00
"delay_based_bwe_unittest.cc",
"delay_based_bwe_unittest_helper.cc",
"delay_based_bwe_unittest_helper.h",
"median_slope_estimator_unittest.cc",
"probe_bitrate_estimator_unittest.cc",
"probe_controller_unittest.cc",
Delete old CongestionController class Replaced by ReceiveSideCongestionController and SendSideCongestionController. Bug: webrtc:6847 Change-Id: I79caa019c883f8f716d0dd52d56bbdc2f8df0ded Reviewed-on: https://chromium-review.googlesource.com/616763 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Stefan Holmer <stefan@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#19423}
2017-08-21 10:45:07 +02:00
"receive_side_congestion_controller_unittest.cc",
"send_side_congestion_controller_unittest.cc",
GN: Refactor modules_unittests to eliminate package boundary violations. BUG=webrtc:6954 Review-Url: https://codereview.webrtc.org/2629923002 Cr-Commit-Position: refs/heads/master@{#16166}
2017-01-19 08:27:11 -08:00
"transport_feedback_adapter_unittest.cc",
"trendline_estimator_unittest.cc",
]
deps = [
":congestion_controller",
This will allow me to test that Call invokes SendSideCongestionController::SetBweBitrates as expected (for https://codereview.chromium.org/2793913008). FakeRtpTransportController moves to a common header and its constructor is changed to take a SendSideCongestionController to enable injecting the mock. BUG=webrtc:7395 Review-Url: https://codereview.webrtc.org/2834663003 Cr-Commit-Position: refs/heads/master@{#18055}
2017-05-08 11:52:38 -07:00
":mock_congestion_controller",
Fix circular dependencies between optional, array_view, and rtc_base. This splits things out of rtc_base and makes dependencies explicit. Bug: webrtc:6828 Change-Id: Id521896c3c43595349021c857bec216e429a0c8d Reviewed-on: https://webrtc-review.googlesource.com/32780 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21264}
2017-12-13 16:05:42 +01:00
"../../rtc_base:checks",
Remove remains of webrtc/base All downstream code have been updated to the new location. In PRESUBMIT.py: * Remove webrtc/rtc_base from CPP_BLACKLIST * Add webrtc/rtc_base to LEGACY_API_DIRS Fix some duplicated paths in webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn BUG=webrtc:7634 TBR=kwiberg@webrtc.org Review-Url: https://codereview.webrtc.org/2976293002 Cr-Commit-Position: refs/heads/master@{#19094}
2017-07-19 10:40:47 -07:00
"../../rtc_base:rtc_base",
"../../rtc_base:rtc_base_approved",
"../../rtc_base:rtc_base_tests_utils",
Stop using public_deps in system_wrappers. TBR=phoglund@webrtc.org Bug: webrtc:8603 Change-Id: I5e515f0e4dc955a01460d69ba4e21bdfdf152d20 Reviewed-on: https://webrtc-review.googlesource.com/29104 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21112}
2017-12-06 09:17:14 +01:00
"../../system_wrappers",
GN: Refactor modules_unittests to eliminate package boundary violations. BUG=webrtc:6954 Review-Url: https://codereview.webrtc.org/2629923002 Cr-Commit-Position: refs/heads/master@{#16166}
2017-01-19 08:27:11 -08:00
"../../test:field_trial",
"../../test:test_support",
"../bitrate_controller:bitrate_controller",
Tracking mock_paced_sender.h with a GN target Untracked headers fly under the 'gn check' radar and in the long term this can cause problems like unnoticed cyclic dependencies. This cl creates a synthetic target for this header since no other targets in webrtc/modules/pacing/BUILD.gn seem to be related to it. BUG=webrtc:7649 NOTRY=True Review-Url: https://codereview.webrtc.org/2887593003 Cr-Commit-Position: refs/heads/master@{#19656}
2017-09-04 04:57:11 -07:00
"../pacing:mock_paced_sender",
GN: Refactor modules_unittests to eliminate package boundary violations. BUG=webrtc:6954 Review-Url: https://codereview.webrtc.org/2629923002 Cr-Commit-Position: refs/heads/master@{#16166}
2017-01-19 08:27:11 -08:00
"../pacing:pacing",
"../remote_bitrate_estimator:remote_bitrate_estimator",
Stop using public_deps in modules/rtp_rtcp. TBR=phoglund@webrtc.org Bug: webrtc:8603 Change-Id: I86830df23db3f33a1a26098e639596bd3b86485a No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/29780 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21108}
2017-12-06 07:51:33 +01:00
"../rtp_rtcp:rtp_rtcp_format",
GN: Refactor modules_unittests to eliminate package boundary violations. BUG=webrtc:6954 Review-Url: https://codereview.webrtc.org/2629923002 Cr-Commit-Position: refs/heads/master@{#16166}
2017-01-19 08:27:11 -08:00
"//testing/gmock",
]
if (!build_with_chromium && is_clang) {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
}
}
This will allow me to test that Call invokes SendSideCongestionController::SetBweBitrates as expected (for https://codereview.chromium.org/2793913008). FakeRtpTransportController moves to a common header and its constructor is changed to take a SendSideCongestionController to enable injecting the mock. BUG=webrtc:7395 Review-Url: https://codereview.webrtc.org/2834663003 Cr-Commit-Position: refs/heads/master@{#18055}
2017-05-08 11:52:38 -07:00
rtc_source_set("mock_congestion_controller") {
testonly = true
sources = [
"include/mock/mock_congestion_observer.h",
"include/mock/mock_send_side_congestion_controller.h",
]
deps = [
":congestion_controller",
"../../test:test_support",
]
}
GN: Refactor modules_unittests to eliminate package boundary violations. BUG=webrtc:6954 Review-Url: https://codereview.webrtc.org/2629923002 Cr-Commit-Position: refs/heads/master@{#16166}
2017-01-19 08:27:11 -08:00
}
Reference in New Issue Copy Permalink