admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
webrtc_m130/rtc_tools/BUILD.gn

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

504 lines
14 KiB
Plaintext
Raw Normal View History

Move webrtc/{tools => rtc_tools} Leaving compatibility script in webrtc/tools/compare_videos.py to avoid breaking our video quality tests in Chromium. Forwarding GN targets are left in webrtc/tools/BUILD.gn. BUG=webrtc:7855 NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2965593002 Cr-Commit-Position: refs/heads/master@{#18848}
2017-06-30 03:04:59 -07:00
# Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
#
# Use of this source code is governed by a BSD-style license
# that can be found in the LICENSE file in the root of the source
# tree. An additional intellectual property rights grant can be found
# in the file PATENTS. All contributing project authors may
# be found in the AUTHORS file in the root of the source tree.
import("//third_party/protobuf/proto_library.gni")
import("../webrtc.gni")
group("rtc_tools") {
# This target shall build all targets in tools/.
testonly = true
Stop using public_deps in rtc_tools. Bug: webrtc:8603 Change-Id: I8126971f80310ad077a1e536c022a296612f573a No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/30300 Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21162}
2017-12-06 16:31:18 +01:00
deps = [
Move webrtc/{tools => rtc_tools} Leaving compatibility script in webrtc/tools/compare_videos.py to avoid breaking our video quality tests in Chromium. Forwarding GN targets are left in webrtc/tools/BUILD.gn. BUG=webrtc:7855 NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2965593002 Cr-Commit-Position: refs/heads/master@{#18848}
2017-06-30 03:04:59 -07:00
":command_line_parser",
":frame_analyzer",
Reland "Add Y4mFileReader" This is a reland of 404be7f302358e6be16aadeba8bc8f8aba348c0f It adds support for reading .yuv files as well to not break anything. Original change's description: > Add Y4mFileReader > > Encapsulate logic for reading .y4m video files in a single class. We > currently have spread out logic for opening .y4m files with partial > parsing. This CL consolidates this logic into a single class with a well > defined interface. > > Change-Id: Id61673b3c95a0053b30e95b4cf382e1c6b05fc30 > Bug: webrtc:9642 > Reviewed-on: https://webrtc-review.googlesource.com/94772 > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > Reviewed-by: Paulina Hensman <phensman@webrtc.org> > Commit-Queue: Magnus Jedvert <magjed@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#24398} TBR=phensman,phoglund Bug: webrtc:9642 Change-Id: Idecc5ec5da767221a5f5b439989f4fe07e3b3615 Reviewed-on: https://webrtc-review.googlesource.com/97983 Commit-Queue: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24571}
2018-09-05 10:46:18 +02:00
":video_file_reader",
Expose less targets in webrtc/rtc_tools in Chromium builds. This should solve recent linking problems with frame_editor and also speed up the Chromium build a little. BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/3006093002 Cr-Commit-Position: refs/heads/master@{#19677}
2017-09-04 23:42:45 -07:00
":video_quality_analysis",
Move webrtc/{tools => rtc_tools} Leaving compatibility script in webrtc/tools/compare_videos.py to avoid breaking our video quality tests in Chromium. Forwarding GN targets are left in webrtc/tools/BUILD.gn. BUG=webrtc:7855 NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2965593002 Cr-Commit-Position: refs/heads/master@{#18848}
2017-06-30 03:04:59 -07:00
]
Expose less targets in webrtc/rtc_tools in Chromium builds. This should solve recent linking problems with frame_editor and also speed up the Chromium build a little. BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/3006093002 Cr-Commit-Position: refs/heads/master@{#19677}
2017-09-04 23:42:45 -07:00
if (!build_with_chromium) {
Stop using public_deps in rtc_tools. Bug: webrtc:8603 Change-Id: I8126971f80310ad077a1e536c022a296612f573a No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/30300 Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21162}
2017-12-06 16:31:18 +01:00
deps += [
Expose less targets in webrtc/rtc_tools in Chromium builds. This should solve recent linking problems with frame_editor and also speed up the Chromium build a little. BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/3006093002 Cr-Commit-Position: refs/heads/master@{#19677}
2017-09-04 23:42:45 -07:00
":frame_editor",
":psnr_ssim_analyzer",
":rgba_to_i420_converter",
]
if (rtc_enable_protobuf) {
Stop using public_deps in rtc_tools. Bug: webrtc:8603 Change-Id: I8126971f80310ad077a1e536c022a296612f573a No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/30300 Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21162}
2017-12-06 16:31:18 +01:00
deps += [ ":chart_proto" ]
Expose less targets in webrtc/rtc_tools in Chromium builds. This should solve recent linking problems with frame_editor and also speed up the Chromium build a little. BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/3006093002 Cr-Commit-Position: refs/heads/master@{#19677}
2017-09-04 23:42:45 -07:00
}
Move webrtc/{tools => rtc_tools} Leaving compatibility script in webrtc/tools/compare_videos.py to avoid breaking our video quality tests in Chromium. Forwarding GN targets are left in webrtc/tools/BUILD.gn. BUG=webrtc:7855 NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2965593002 Cr-Commit-Position: refs/heads/master@{#18848}
2017-06-30 03:04:59 -07:00
}
if (rtc_include_tests) {
Stop using public_deps in rtc_tools. Bug: webrtc:8603 Change-Id: I8126971f80310ad077a1e536c022a296612f573a No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/30300 Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21162}
2017-12-06 16:31:18 +01:00
deps += [
Move webrtc/{tools => rtc_tools} Leaving compatibility script in webrtc/tools/compare_videos.py to avoid breaking our video quality tests in Chromium. Forwarding GN targets are left in webrtc/tools/BUILD.gn. BUG=webrtc:7855 NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2965593002 Cr-Commit-Position: refs/heads/master@{#18848}
2017-06-30 03:04:59 -07:00
":activity_metric",
":tools_unittests",
]
if (rtc_enable_protobuf) {
Harmonize paths to dependent targets. This CL consistently use: * relative paths for WebRTC dependent targets (test_support) * absolute paths for shared dependent targets (abseil) This is a necessary (but insufficient) step to build WebRTC tests from Chromium tree (rtc_include_tests=true), since test/ doesn't sit anymore in the top level directory. We also make sure that target declarations and uses are consistent in regard to build_with_chromium flag. Bug: webrtc:9943 Bug: webrtc:9855 Change-Id: I21dea98894df2fd4bfe2fd7ee7b71ba971e0ab5b Reviewed-on: https://webrtc-review.googlesource.com/c/108720 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Yves Gerey <yvesg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25445}
2018-10-30 21:12:42 +01:00
if (!build_with_chromium) {
deps += [ ":event_log_visualizer" ]
}
Stop using public_deps in rtc_tools. Bug: webrtc:8603 Change-Id: I8126971f80310ad077a1e536c022a296612f573a No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/30300 Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21162}
2017-12-06 16:31:18 +01:00
deps += [
Move webrtc/{tools => rtc_tools} Leaving compatibility script in webrtc/tools/compare_videos.py to avoid breaking our video quality tests in Chromium. Forwarding GN targets are left in webrtc/tools/BUILD.gn. BUG=webrtc:7855 NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2965593002 Cr-Commit-Position: refs/heads/master@{#18848}
2017-06-30 03:04:59 -07:00
":rtp_analyzer",
Move unpack_aecdump to a more public location. This tool is used downstream, so we want to christen rtc_tools as a kind of api dir for tools. Tools in other locations should be considered off limits. I chose rtc_tools because video_quality_toolchain is already there, which is also used downstream. Bug: None Change-Id: I234d874c8a590ca7413357ecda26b16d9b399836 Reviewed-on: https://webrtc-review.googlesource.com/32340 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21236}
2017-12-12 15:53:31 +01:00
":unpack_aecdump",
Move webrtc/{tools => rtc_tools} Leaving compatibility script in webrtc/tools/compare_videos.py to avoid breaking our video quality tests in Chromium. Forwarding GN targets are left in webrtc/tools/BUILD.gn. BUG=webrtc:7855 NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2965593002 Cr-Commit-Position: refs/heads/master@{#18848}
2017-06-30 03:04:59 -07:00
"network_tester",
]
}
}
}
rtc_static_library("command_line_parser") {
sources = [
"simple_command_line_parser.cc",
"simple_command_line_parser.h",
]
deps = [
Remove remains of webrtc/base All downstream code have been updated to the new location. In PRESUBMIT.py: * Remove webrtc/rtc_base from CPP_BLACKLIST * Add webrtc/rtc_base to LEGACY_API_DIRS Fix some duplicated paths in webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn BUG=webrtc:7634 TBR=kwiberg@webrtc.org Review-Url: https://codereview.webrtc.org/2976293002 Cr-Commit-Position: refs/heads/master@{#19094}
2017-07-19 10:40:47 -07:00
"../rtc_base:gtest_prod",
"../rtc_base:rtc_base_approved",
Move webrtc/{tools => rtc_tools} Leaving compatibility script in webrtc/tools/compare_videos.py to avoid breaking our video quality tests in Chromium. Forwarding GN targets are left in webrtc/tools/BUILD.gn. BUG=webrtc:7855 NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2965593002 Cr-Commit-Position: refs/heads/master@{#18848}
2017-06-30 03:04:59 -07:00
]
}
Reland "Add Y4mFileReader" This is a reland of 404be7f302358e6be16aadeba8bc8f8aba348c0f It adds support for reading .yuv files as well to not break anything. Original change's description: > Add Y4mFileReader > > Encapsulate logic for reading .y4m video files in a single class. We > currently have spread out logic for opening .y4m files with partial > parsing. This CL consolidates this logic into a single class with a well > defined interface. > > Change-Id: Id61673b3c95a0053b30e95b4cf382e1c6b05fc30 > Bug: webrtc:9642 > Reviewed-on: https://webrtc-review.googlesource.com/94772 > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > Reviewed-by: Paulina Hensman <phensman@webrtc.org> > Commit-Queue: Magnus Jedvert <magjed@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#24398} TBR=phensman,phoglund Bug: webrtc:9642 Change-Id: Idecc5ec5da767221a5f5b439989f4fe07e3b3615 Reviewed-on: https://webrtc-review.googlesource.com/97983 Commit-Queue: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24571}
2018-09-05 10:46:18 +02:00
rtc_static_library("video_file_reader") {
sources = [
"video_file_reader.cc",
"video_file_reader.h",
]
deps = [
Remove rtc_base/scoped_ref_ptr.h. The type rtc::scoped_refptr<T> is now part of api/. Please include it from api/scoped_refptr.h. More info: See: https://groups.google.com/forum/#!topic/discuss-webrtc/Mme2MSz4z4o. Bug: webrtc:9887, webrtc:8205 No-Try: True Change-Id: Ic6c7c81e226e59f12f7933e472f573ae097b55bf Reviewed-on: https://webrtc-review.googlesource.com/c/119041 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26414}
2019-01-25 20:26:48 +01:00
"../api:scoped_refptr",
Reland "Add Y4mFileReader" This is a reland of 404be7f302358e6be16aadeba8bc8f8aba348c0f It adds support for reading .yuv files as well to not break anything. Original change's description: > Add Y4mFileReader > > Encapsulate logic for reading .y4m video files in a single class. We > currently have spread out logic for opening .y4m files with partial > parsing. This CL consolidates this logic into a single class with a well > defined interface. > > Change-Id: Id61673b3c95a0053b30e95b4cf382e1c6b05fc30 > Bug: webrtc:9642 > Reviewed-on: https://webrtc-review.googlesource.com/94772 > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > Reviewed-by: Paulina Hensman <phensman@webrtc.org> > Commit-Queue: Magnus Jedvert <magjed@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#24398} TBR=phensman,phoglund Bug: webrtc:9642 Change-Id: Idecc5ec5da767221a5f5b439989f4fe07e3b3615 Reviewed-on: https://webrtc-review.googlesource.com/97983 Commit-Queue: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24571}
2018-09-05 10:46:18 +02:00
"../api/video:video_frame",
"../api/video:video_frame_i420",
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2. This is a follow-up to https://webrtc-review.googlesource.com/c/src/+/106280. This time the whole code base is covered. Some files may have not been fixed though, whenever the IWYU tool was breaking the build. Bug: webrtc:8311 Change-Id: I2c31f552a87e887d33931d46e87b6208b1e483ef Reviewed-on: https://webrtc-review.googlesource.com/c/111965 Commit-Queue: Yves Gerey <yvesg@google.com> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25830}
2018-11-28 16:47:49 +01:00
"../rtc_base:checks",
Reland "Add Y4mFileReader" This is a reland of 404be7f302358e6be16aadeba8bc8f8aba348c0f It adds support for reading .yuv files as well to not break anything. Original change's description: > Add Y4mFileReader > > Encapsulate logic for reading .y4m video files in a single class. We > currently have spread out logic for opening .y4m files with partial > parsing. This CL consolidates this logic into a single class with a well > defined interface. > > Change-Id: Id61673b3c95a0053b30e95b4cf382e1c6b05fc30 > Bug: webrtc:9642 > Reviewed-on: https://webrtc-review.googlesource.com/94772 > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > Reviewed-by: Paulina Hensman <phensman@webrtc.org> > Commit-Queue: Magnus Jedvert <magjed@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#24398} TBR=phensman,phoglund Bug: webrtc:9642 Change-Id: Idecc5ec5da767221a5f5b439989f4fe07e3b3615 Reviewed-on: https://webrtc-review.googlesource.com/97983 Commit-Queue: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24571}
2018-09-05 10:46:18 +02:00
"../rtc_base:rtc_base_approved",
Replace starts_with and ends_with with Abseil Bug: None Change-Id: I7eae3db1aeb81f0f1d37ff50d5c85c16ecb1f366 Reviewed-on: https://webrtc-review.googlesource.com/c/114221 Commit-Queue: Steve Anton <steveanton@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26032}
2018-12-13 17:41:25 -08:00
"//third_party/abseil-cpp/absl/strings",
Reland "Add Y4mFileReader" This is a reland of 404be7f302358e6be16aadeba8bc8f8aba348c0f It adds support for reading .yuv files as well to not break anything. Original change's description: > Add Y4mFileReader > > Encapsulate logic for reading .y4m video files in a single class. We > currently have spread out logic for opening .y4m files with partial > parsing. This CL consolidates this logic into a single class with a well > defined interface. > > Change-Id: Id61673b3c95a0053b30e95b4cf382e1c6b05fc30 > Bug: webrtc:9642 > Reviewed-on: https://webrtc-review.googlesource.com/94772 > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > Reviewed-by: Paulina Hensman <phensman@webrtc.org> > Commit-Queue: Magnus Jedvert <magjed@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#24398} TBR=phensman,phoglund Bug: webrtc:9642 Change-Id: Idecc5ec5da767221a5f5b439989f4fe07e3b3615 Reviewed-on: https://webrtc-review.googlesource.com/97983 Commit-Queue: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24571}
2018-09-05 10:46:18 +02:00
"//third_party/abseil-cpp/absl/types:optional",
]
}
Add WriteVideoToFile to video_file_reader. The function checks the file extension to determine YUV or Y4M format. Also adds a flag aligned_output_file to compare_videos.py, which allows saving the aligned reference video to a file. Bug: webrtc:9642 Change-Id: Ia59f5c123a1e41104756eb6b235b6581c4ffbd77 Reviewed-on: https://webrtc-review.googlesource.com/99503 Reviewed-by: Sami Kalliomäki <sakal@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Paulina Hensman <phensman@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24787}
2018-09-14 11:32:00 +02:00
rtc_static_library("video_file_writer") {
sources = [
"video_file_writer.cc",
"video_file_writer.h",
]
deps = [
":video_file_reader",
Remove rtc_base/scoped_ref_ptr.h. The type rtc::scoped_refptr<T> is now part of api/. Please include it from api/scoped_refptr.h. More info: See: https://groups.google.com/forum/#!topic/discuss-webrtc/Mme2MSz4z4o. Bug: webrtc:9887, webrtc:8205 No-Try: True Change-Id: Ic6c7c81e226e59f12f7933e472f573ae097b55bf Reviewed-on: https://webrtc-review.googlesource.com/c/119041 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26414}
2019-01-25 20:26:48 +01:00
"../api:scoped_refptr",
Add WriteVideoToFile to video_file_reader. The function checks the file extension to determine YUV or Y4M format. Also adds a flag aligned_output_file to compare_videos.py, which allows saving the aligned reference video to a file. Bug: webrtc:9642 Change-Id: Ia59f5c123a1e41104756eb6b235b6581c4ffbd77 Reviewed-on: https://webrtc-review.googlesource.com/99503 Reviewed-by: Sami Kalliomäki <sakal@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Paulina Hensman <phensman@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24787}
2018-09-14 11:32:00 +02:00
"../api/video:video_frame",
"../api/video:video_frame_i420",
"../rtc_base:rtc_base_approved",
Replace starts_with and ends_with with Abseil Bug: None Change-Id: I7eae3db1aeb81f0f1d37ff50d5c85c16ecb1f366 Reviewed-on: https://webrtc-review.googlesource.com/c/114221 Commit-Queue: Steve Anton <steveanton@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26032}
2018-12-13 17:41:25 -08:00
"//third_party/abseil-cpp/absl/strings",
Add WriteVideoToFile to video_file_reader. The function checks the file extension to determine YUV or Y4M format. Also adds a flag aligned_output_file to compare_videos.py, which allows saving the aligned reference video to a file. Bug: webrtc:9642 Change-Id: Ia59f5c123a1e41104756eb6b235b6581c4ffbd77 Reviewed-on: https://webrtc-review.googlesource.com/99503 Reviewed-by: Sami Kalliomäki <sakal@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Paulina Hensman <phensman@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24787}
2018-09-14 11:32:00 +02:00
"//third_party/abseil-cpp/absl/types:optional",
]
}
Move webrtc/{tools => rtc_tools} Leaving compatibility script in webrtc/tools/compare_videos.py to avoid breaking our video quality tests in Chromium. Forwarding GN targets are left in webrtc/tools/BUILD.gn. BUG=webrtc:7855 NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2965593002 Cr-Commit-Position: refs/heads/master@{#18848}
2017-06-30 03:04:59 -07:00
rtc_static_library("video_quality_analysis") {
sources = [
Add tool for aligning color space of video files This class adds logic for aligning color space of a test video compared to a reference video. If there is a color space mismatch, it typically does not have much impact on human perception, but it has a big impact on PSNR and SSIM calculations. For example, aligning a test run with VP8 improves PSNR and SSIM from: Average PSNR: 29.142818, average SSIM: 0.946026 to: Average PSNR: 38.146229, average SSIM: 0.965388. The optiomal color transformation between the two videos were: 0.86 0.01 0.00 14.37 0.00 0.88 0.00 15.32 0.00 0.00 0.88 15.74 which is converting YUV full range to YUV limited range. There is already a CL out for fixing this discrepancy here: https://webrtc-review.googlesource.com/c/src/+/94543 After that, hopefully there is no color space mismatch when saving the raw YUV values. It's good that the video quality tool is color space agnostic anyway, and can compensate for differences when the test video is obtained by e.g. filming a physical device screen. Also, the linear least square logic will be used for compensating geometric distorisions in a follow-up CL. Bug: webrtc:9642 Change-Id: I499713960a0544d8e45c5d09886e68ec829b28a7 Reviewed-on: https://webrtc-review.googlesource.com/c/95950 Reviewed-by: Sami Kalliomäki <sakal@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25193}
2018-09-11 12:56:06 +02:00
"frame_analyzer/linear_least_squares.cc",
"frame_analyzer/linear_least_squares.h",
"frame_analyzer/video_color_aligner.cc",
"frame_analyzer/video_color_aligner.h",
Add tool for aligning cropped region of video files This class adds logic for aligning what part of a test video has been encoded from a reference video. It does that by cropping and zooming in on a region of the reference video that most closely matches the test video. A small cropping does not have much impact on human perception, but it has a big impact on PSNR and SSIM calculations. For example, if the test video is cropped with one row in the top and bottom, adjusting for this improves average PSNR from 27.7146 to 29.3357 and average SSIM from 0.934891 to 0.95318 in an example test video. TBR=phoglund Bug: webrtc:9642 Change-Id: I02cfe0e2261fb58df8cdb1e15ba93285e3dc4538 Reviewed-on: https://webrtc-review.googlesource.com/c/99480 Commit-Queue: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@google.com> Reviewed-by: Sami Kalliomäki <sakal@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25755}
2018-11-22 15:17:30 +01:00
"frame_analyzer/video_geometry_aligner.cc",
"frame_analyzer/video_geometry_aligner.h",
Move webrtc/{tools => rtc_tools} Leaving compatibility script in webrtc/tools/compare_videos.py to avoid breaking our video quality tests in Chromium. Forwarding GN targets are left in webrtc/tools/BUILD.gn. BUG=webrtc:7855 NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2965593002 Cr-Commit-Position: refs/heads/master@{#18848}
2017-06-30 03:04:59 -07:00
"frame_analyzer/video_quality_analysis.cc",
"frame_analyzer/video_quality_analysis.h",
Reland "Add tool for aliging video files" This is a reland of b2c0e8f60fad10e2786e5e131136a0da1299d883 Original change's description: > Add tool for aliging video files > > This class adds logic for aligning a test video to a reference video > by an algorithm that maximizes SSIM between them. Aligned videos will be > easier to run video quality metrics on. This is a generic way of > aligning videos and can be replace the intrusive barcode stamping that > we currently use. This will be done in a follow-up CL. > > Change-Id: I71cf1e2179c0f1e03eff9e4d8fc492fd5cfbbb1c > Bug: webrtc:9642 > Reviewed-on: https://webrtc-review.googlesource.com/94773 > Commit-Queue: Magnus Jedvert <magjed@webrtc.org> > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > Reviewed-by: Paulina Hensman <phensman@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#24407} TBR=phensman,phoglund Bug: webrtc:9642 Change-Id: I35d6b0e598335b8d80fbfa37ba06d5c651bda4f6 Reviewed-on: https://webrtc-review.googlesource.com/98040 Commit-Queue: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24580}
2018-09-05 15:04:08 +02:00
"frame_analyzer/video_temporal_aligner.cc",
"frame_analyzer/video_temporal_aligner.h",
Move webrtc/{tools => rtc_tools} Leaving compatibility script in webrtc/tools/compare_videos.py to avoid breaking our video quality tests in Chromium. Forwarding GN targets are left in webrtc/tools/BUILD.gn. BUG=webrtc:7855 NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2965593002 Cr-Commit-Position: refs/heads/master@{#18848}
2017-06-30 03:04:59 -07:00
]
Stop using public_deps to depend on libyuv. A lot of WebRTC targets were depending on //third_party/libyuv using public_deps instead of deps. This causes issues because a the inclusion of libyuv headers is not declared to the build system and this creates hidden dependencies that put the modularity of the project at risk. Bug: webrtc:8603 Change-Id: Ide0ceb84eb5640ae664dc782f3a722b55c3b601a No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/28120 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Magnus Flodman <mflodman@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21039}
2017-12-01 13:53:04 +01:00
deps = [
Reland "Add Y4mFileReader" This is a reland of 404be7f302358e6be16aadeba8bc8f8aba348c0f It adds support for reading .yuv files as well to not break anything. Original change's description: > Add Y4mFileReader > > Encapsulate logic for reading .y4m video files in a single class. We > currently have spread out logic for opening .y4m files with partial > parsing. This CL consolidates this logic into a single class with a well > defined interface. > > Change-Id: Id61673b3c95a0053b30e95b4cf382e1c6b05fc30 > Bug: webrtc:9642 > Reviewed-on: https://webrtc-review.googlesource.com/94772 > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > Reviewed-by: Paulina Hensman <phensman@webrtc.org> > Commit-Queue: Magnus Jedvert <magjed@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#24398} TBR=phensman,phoglund Bug: webrtc:9642 Change-Id: Idecc5ec5da767221a5f5b439989f4fe07e3b3615 Reviewed-on: https://webrtc-review.googlesource.com/97983 Commit-Queue: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24571}
2018-09-05 10:46:18 +02:00
":video_file_reader",
Add tool for aligning color space of video files This class adds logic for aligning color space of a test video compared to a reference video. If there is a color space mismatch, it typically does not have much impact on human perception, but it has a big impact on PSNR and SSIM calculations. For example, aligning a test run with VP8 improves PSNR and SSIM from: Average PSNR: 29.142818, average SSIM: 0.946026 to: Average PSNR: 38.146229, average SSIM: 0.965388. The optiomal color transformation between the two videos were: 0.86 0.01 0.00 14.37 0.00 0.88 0.00 15.32 0.00 0.00 0.88 15.74 which is converting YUV full range to YUV limited range. There is already a CL out for fixing this discrepancy here: https://webrtc-review.googlesource.com/c/src/+/94543 After that, hopefully there is no color space mismatch when saving the raw YUV values. It's good that the video quality tool is color space agnostic anyway, and can compensate for differences when the test video is obtained by e.g. filming a physical device screen. Also, the linear least square logic will be used for compensating geometric distorisions in a follow-up CL. Bug: webrtc:9642 Change-Id: I499713960a0544d8e45c5d09886e68ec829b28a7 Reviewed-on: https://webrtc-review.googlesource.com/c/95950 Reviewed-by: Sami Kalliomäki <sakal@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25193}
2018-09-11 12:56:06 +02:00
"../api:array_view",
Remove rtc_base/scoped_ref_ptr.h. The type rtc::scoped_refptr<T> is now part of api/. Please include it from api/scoped_refptr.h. More info: See: https://groups.google.com/forum/#!topic/discuss-webrtc/Mme2MSz4z4o. Bug: webrtc:9887, webrtc:8205 No-Try: True Change-Id: Ic6c7c81e226e59f12f7933e472f573ae097b55bf Reviewed-on: https://webrtc-review.googlesource.com/c/119041 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26414}
2019-01-25 20:26:48 +01:00
"../api:scoped_refptr",
Add tool for aligning cropped region of video files This class adds logic for aligning what part of a test video has been encoded from a reference video. It does that by cropping and zooming in on a region of the reference video that most closely matches the test video. A small cropping does not have much impact on human perception, but it has a big impact on PSNR and SSIM calculations. For example, if the test video is cropped with one row in the top and bottom, adjusting for this improves average PSNR from 27.7146 to 29.3357 and average SSIM from 0.934891 to 0.95318 in an example test video. TBR=phoglund Bug: webrtc:9642 Change-Id: I02cfe0e2261fb58df8cdb1e15ba93285e3dc4538 Reviewed-on: https://webrtc-review.googlesource.com/c/99480 Commit-Queue: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@google.com> Reviewed-by: Sami Kalliomäki <sakal@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25755}
2018-11-22 15:17:30 +01:00
"../api/video:video_frame",
Reland "Add Y4mFileReader" This is a reland of 404be7f302358e6be16aadeba8bc8f8aba348c0f It adds support for reading .yuv files as well to not break anything. Original change's description: > Add Y4mFileReader > > Encapsulate logic for reading .y4m video files in a single class. We > currently have spread out logic for opening .y4m files with partial > parsing. This CL consolidates this logic into a single class with a well > defined interface. > > Change-Id: Id61673b3c95a0053b30e95b4cf382e1c6b05fc30 > Bug: webrtc:9642 > Reviewed-on: https://webrtc-review.googlesource.com/94772 > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > Reviewed-by: Paulina Hensman <phensman@webrtc.org> > Commit-Queue: Magnus Jedvert <magjed@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#24398} TBR=phensman,phoglund Bug: webrtc:9642 Change-Id: Idecc5ec5da767221a5f5b439989f4fe07e3b3615 Reviewed-on: https://webrtc-review.googlesource.com/97983 Commit-Queue: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24571}
2018-09-05 10:46:18 +02:00
"../api/video:video_frame_i420",
Stop using public_deps in rtc_tools. Bug: webrtc:8603 Change-Id: I8126971f80310ad077a1e536c022a296612f573a No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/30300 Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21162}
2017-12-06 16:31:18 +01:00
"../common_video",
Reland "Add tool for aliging video files" This is a reland of b2c0e8f60fad10e2786e5e131136a0da1299d883 Original change's description: > Add tool for aliging video files > > This class adds logic for aligning a test video to a reference video > by an algorithm that maximizes SSIM between them. Aligned videos will be > easier to run video quality metrics on. This is a generic way of > aligning videos and can be replace the intrusive barcode stamping that > we currently use. This will be done in a follow-up CL. > > Change-Id: I71cf1e2179c0f1e03eff9e4d8fc492fd5cfbbb1c > Bug: webrtc:9642 > Reviewed-on: https://webrtc-review.googlesource.com/94773 > Commit-Queue: Magnus Jedvert <magjed@webrtc.org> > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > Reviewed-by: Paulina Hensman <phensman@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#24407} TBR=phensman,phoglund Bug: webrtc:9642 Change-Id: I35d6b0e598335b8d80fbfa37ba06d5c651bda4f6 Reviewed-on: https://webrtc-review.googlesource.com/98040 Commit-Queue: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24580}
2018-09-05 15:04:08 +02:00
"../rtc_base:checks",
"../rtc_base:rtc_base_approved",
Store video_quality_loopback_test perf results in Chart JSON format. Adds a flag to store the perf results in a JSON file using the Chart JSON format [1]. [1] https://github.com/catapult-project/catapult/blob/master/dashboard/docs/data-format.md TBR=phoglund@webrtc.org Bug: chromium:755660 Change-Id: I6a896654a4a558df217ddefa4e8a52a487cdbebd Reviewed-on: https://webrtc-review.googlesource.com/43180 Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21809}
2018-01-30 15:33:02 +01:00
"../test:perf_test",
Reland "Add tool for aliging video files" This is a reland of b2c0e8f60fad10e2786e5e131136a0da1299d883 Original change's description: > Add tool for aliging video files > > This class adds logic for aligning a test video to a reference video > by an algorithm that maximizes SSIM between them. Aligned videos will be > easier to run video quality metrics on. This is a generic way of > aligning videos and can be replace the intrusive barcode stamping that > we currently use. This will be done in a follow-up CL. > > Change-Id: I71cf1e2179c0f1e03eff9e4d8fc492fd5cfbbb1c > Bug: webrtc:9642 > Reviewed-on: https://webrtc-review.googlesource.com/94773 > Commit-Queue: Magnus Jedvert <magjed@webrtc.org> > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > Reviewed-by: Paulina Hensman <phensman@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#24407} TBR=phensman,phoglund Bug: webrtc:9642 Change-Id: I35d6b0e598335b8d80fbfa37ba06d5c651bda4f6 Reviewed-on: https://webrtc-review.googlesource.com/98040 Commit-Queue: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24580}
2018-09-05 15:04:08 +02:00
"//third_party/abseil-cpp/absl/types:optional",
Removing $rtc_libyuv_dir and removing useless dependencies on libyuv. This CL removes the following GN variables: rtc_build_libyuv, rtc_libyuv_dir (as requested in webrtc:7906). It also removes some unneeded dependencies on //third_party/libyuv. WebRTC targets were using public_deps to depend on //third_party/libyuv and this created a build graph where targets that were depending on //third_party/libyuv were not declaring the dependency to GN because they were somehow getting it from another target that was exposing //third_party/libyuv header files even if it wasn't directly depending on it. Bug: webrtc:8605, webrtc:7906 Change-Id: If71f7988fd80421dc2ad887cf94c2ac66366c3fb Reviewed-on: https://webrtc-review.googlesource.com/32201 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21275}
2017-12-14 11:24:00 +01:00
"//third_party/libyuv",
Move webrtc/{tools => rtc_tools} Leaving compatibility script in webrtc/tools/compare_videos.py to avoid breaking our video quality tests in Chromium. Forwarding GN targets are left in webrtc/tools/BUILD.gn. BUG=webrtc:7855 NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2965593002 Cr-Commit-Position: refs/heads/master@{#18848}
2017-06-30 03:04:59 -07:00
]
}
rtc_executable("frame_analyzer") {
Revert "Revert "GN rtc_* templates: Set default visibility to webrtc_root + "/*""" This reverts commit c73e1f437889d882cbf2987f7fb3a029a6150613. Reason for revert: The problem with failed deps in chrome content/renderer had already been fixed in https://webrtc-review.googlesource.com/c/src/+/38660 Original change's description: > Revert "GN rtc_* templates: Set default visibility to webrtc_root + "/*"" > > This reverts commit 588c548657b3ddf76e7b3f241263eef7f5799f16. > > Reason for revert: > > Breaks Chrome FYI: > > /b/c/b/Linux_Builder/src/buildtools/linux64/gn gen //out/Release --check > -> returned 1 > ERROR at //build/split_static_library.gni:12:5: Dependency not allowed. > static_library(target_name) { > ^---------------------------- > The item //content/renderer:renderer > can not depend on //third_party/webrtc/media:rtc_internal_video_codecs > because it is not in //third_party/webrtc/media:rtc_internal_video_codecs's visibility list: [ > //third_party/webrtc/* > //third_party/webrtc_overrides/* > ] > > https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.webrtc.fyi%2FLinux_Builder%2F23560%2F%2B%2Frecipes%2Fsteps%2Fgenerate_build_files%2F0%2Fstdout > > Original change's description: > > GN rtc_* templates: Set default visibility to webrtc_root + "/*" > > > > This means that by default, targets are visible to everything under > > the WebRTC root, but not visible to anything else. > > > > API targets are manually tagged with visibility "*", so that targets > > outside the WebRTC tree can see them. > > > > BUG=webrtc:8254 > > > > Change-Id: Icdbee6e0d22d93240ff2fb530c8f9dc48e351509 > > Reviewed-on: https://webrtc-review.googlesource.com/24140 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#21548} > > TBR=mbonadei@webrtc.org,kwiberg@webrtc.org > > Change-Id: I06620ce3d6f67482935c22efa231dd6cab91625a > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:8254 > Reviewed-on: https://webrtc-review.googlesource.com/38760 > Reviewed-by: Per Kjellander <perkj@webrtc.org> > Commit-Queue: Per Kjellander <perkj@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#21555} TBR=mbonadei@webrtc.org,kwiberg@webrtc.org,perkj@webrtc.org Change-Id: I6f720078ce21bd172e0a6471bae8c4c011e4a657 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:8254 Reviewed-on: https://webrtc-review.googlesource.com/38860 Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Per Kjellander <perkj@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21558}
2018-01-10 15:54:53 +00:00
visibility = [ "*" ]
Move webrtc/{tools => rtc_tools} Leaving compatibility script in webrtc/tools/compare_videos.py to avoid breaking our video quality tests in Chromium. Forwarding GN targets are left in webrtc/tools/BUILD.gn. BUG=webrtc:7855 NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2965593002 Cr-Commit-Position: refs/heads/master@{#18848}
2017-06-30 03:04:59 -07:00
sources = [
"frame_analyzer/frame_analyzer.cc",
]
deps = [
":command_line_parser",
Reland "Add Y4mFileReader" This is a reland of 404be7f302358e6be16aadeba8bc8f8aba348c0f It adds support for reading .yuv files as well to not break anything. Original change's description: > Add Y4mFileReader > > Encapsulate logic for reading .y4m video files in a single class. We > currently have spread out logic for opening .y4m files with partial > parsing. This CL consolidates this logic into a single class with a well > defined interface. > > Change-Id: Id61673b3c95a0053b30e95b4cf382e1c6b05fc30 > Bug: webrtc:9642 > Reviewed-on: https://webrtc-review.googlesource.com/94772 > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > Reviewed-by: Paulina Hensman <phensman@webrtc.org> > Commit-Queue: Magnus Jedvert <magjed@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#24398} TBR=phensman,phoglund Bug: webrtc:9642 Change-Id: Idecc5ec5da767221a5f5b439989f4fe07e3b3615 Reviewed-on: https://webrtc-review.googlesource.com/97983 Commit-Queue: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24571}
2018-09-05 10:46:18 +02:00
":video_file_reader",
Add WriteVideoToFile to video_file_reader. The function checks the file extension to determine YUV or Y4M format. Also adds a flag aligned_output_file to compare_videos.py, which allows saving the aligned reference video to a file. Bug: webrtc:9642 Change-Id: Ia59f5c123a1e41104756eb6b235b6581c4ffbd77 Reviewed-on: https://webrtc-review.googlesource.com/99503 Reviewed-by: Sami Kalliomäki <sakal@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Paulina Hensman <phensman@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24787}
2018-09-14 11:32:00 +02:00
":video_file_writer",
Move webrtc/{tools => rtc_tools} Leaving compatibility script in webrtc/tools/compare_videos.py to avoid breaking our video quality tests in Chromium. Forwarding GN targets are left in webrtc/tools/BUILD.gn. BUG=webrtc:7855 NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2965593002 Cr-Commit-Position: refs/heads/master@{#18848}
2017-06-30 03:04:59 -07:00
":video_quality_analysis",
Remove rtc_base/scoped_ref_ptr.h. The type rtc::scoped_refptr<T> is now part of api/. Please include it from api/scoped_refptr.h. More info: See: https://groups.google.com/forum/#!topic/discuss-webrtc/Mme2MSz4z4o. Bug: webrtc:9887, webrtc:8205 No-Try: True Change-Id: Ic6c7c81e226e59f12f7933e472f573ae097b55bf Reviewed-on: https://webrtc-review.googlesource.com/c/119041 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26414}
2019-01-25 20:26:48 +01:00
"../api:scoped_refptr",
Reland "Reland "Update video_quality_analysis to align videos instead of using barcodes"" This is a reland of 9bb55fc09b6bfa00cba7779c37ad6c39b4206f7a Original change's description: > Reland "Update video_quality_analysis to align videos instead of using barcodes" > > This is a reland of d65e143801a7aaa9affdb939ea836aec1955cdcc > > The binary for frame_analyzer.cpp is precompiled and stored in the cloud, so it > won't automatically pick up change to the source file. Therefore, restore all > old code to be backwards compatible. > > Original change's description: > > Update video_quality_analysis to align videos instead of using barcodes > > > > This CL is a follow-up to the previous CL > > https://webrtc-review.googlesource.com/c/src/+/94773 that added generic > > logic for aligning videos. This will allow us to easily extend > > video_quality_analysis with new sophisticated video quality metrics. > > Also, we can use any kind of video that does not necessarily need to > > contain bar codes. Removing the need to decode barcodes also leads to a > > big speedup for the tests. > > > > Bug: webrtc:9642 > > Change-Id: I74b0d630b3e1ed44781ad024115ded3143e28f50 > > Reviewed-on: https://webrtc-review.googlesource.com/94845 > > Reviewed-by: Paulina Hensman <phensman@webrtc.org> > > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > > Commit-Queue: Magnus Jedvert <magjed@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#24423} > > TBR=phensman@webrtc.org,phoglund@webrtc.org > > Bug: webrtc:9642 > Change-Id: Id8d129ce103284504c67690f8363c03eaae3eee7 > Reviewed-on: https://webrtc-review.googlesource.com/96000 > Reviewed-by: Magnus Jedvert <magjed@webrtc.org> > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > Commit-Queue: Magnus Jedvert <magjed@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#24429} TBR=phensman,phoglund Bug: webrtc:9642 Change-Id: Ic248b7831ae148251a1a4ebeec5d154286f91a0a Reviewed-on: https://webrtc-review.googlesource.com/98080 Commit-Queue: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24583}
2018-09-05 16:11:48 +02:00
"../rtc_base:stringutils",
Store video_quality_loopback_test perf results in Chart JSON format. Adds a flag to store the perf results in a JSON file using the Chart JSON format [1]. [1] https://github.com/catapult-project/catapult/blob/master/dashboard/docs/data-format.md TBR=phoglund@webrtc.org Bug: chromium:755660 Change-Id: I6a896654a4a558df217ddefa4e8a52a487cdbebd Reviewed-on: https://webrtc-review.googlesource.com/43180 Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21809}
2018-01-30 15:33:02 +01:00
"../test:perf_test",
Replace starts_with and ends_with with Abseil Bug: None Change-Id: I7eae3db1aeb81f0f1d37ff50d5c85c16ecb1f366 Reviewed-on: https://webrtc-review.googlesource.com/c/114221 Commit-Queue: Steve Anton <steveanton@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26032}
2018-12-13 17:41:25 -08:00
"//third_party/abseil-cpp/absl/strings",
Move webrtc/{tools => rtc_tools} Leaving compatibility script in webrtc/tools/compare_videos.py to avoid breaking our video quality tests in Chromium. Forwarding GN targets are left in webrtc/tools/BUILD.gn. BUG=webrtc:7855 NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2965593002 Cr-Commit-Position: refs/heads/master@{#18848}
2017-06-30 03:04:59 -07:00
]
}
Do not compile frame_analyzer_host during Chromium builds. Bug: webrtc:9665 Change-Id: I42ff7a02664c3552ea31972a84f1d7d18cab13ac No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/100805 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Oleh Prypin <oprypin@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24765}
2018-09-18 13:39:37 +02:00
if (!build_with_chromium && !build_with_mozilla) {
action("frame_analyzer_host") {
script = "//tools_webrtc/executable_host_build.py"
outputs = [
"${root_out_dir}/frame_analyzer_host",
]
args = [
"--executable_name",
"frame_analyzer",
]
}
Reland "Compile frame analyzer for the host machine on perf tests." This is a reland of d8ff3f29ce92e27529e100ecf71afbae6334419f. See https://webrtc-review.googlesource.com/c/src/+/100681/1..4 for the fix. Error "Failed to open video file for emulated camera" should be addressed by that change. Original change's description: > Compile frame analyzer for the host machine on perf tests. > > Bug: webrtc:9665 > Change-Id: I05c01ee4bef0995556b1a679498b3d9132de7c26 > Reviewed-on: https://webrtc-review.googlesource.com/100360 > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > Reviewed-by: Oleh Prypin <oprypin@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#24756} TBR=phoglund@webrtc.org, oprypin@webrtc.org Bug: webrtc:9665 Change-Id: If6a4f2259dabf50718abf47c9cf303d143a1895a Reviewed-on: https://webrtc-review.googlesource.com/100681 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Oleh Prypin <oprypin@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24762}
2018-09-18 11:03:39 +02:00
}
Expose less targets in webrtc/rtc_tools in Chromium builds. This should solve recent linking problems with frame_editor and also speed up the Chromium build a little. BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/3006093002 Cr-Commit-Position: refs/heads/master@{#19677}
2017-09-04 23:42:45 -07:00
# Only expose the targets needed by Chromium (e.g. frame_analyzer) to avoid
# building a lot of redundant code as part of Chromium builds.
if (!build_with_chromium) {
Do not build rtp_generator in Chromium builds. This tool is only needed for WebRTC standalone so there is no need to build it on Chromium trybots (if we want to do that, we need to explicitly link against the Chromium's TQ implementation). [1] - https://cs.chromium.org/chromium/src/third_party/webrtc_overrides/BUILD.gn?l=114-124&rcl=3514203635d4f5c2d660784dd3007f1018c9af88 Bug: None Change-Id: Ib75204205717637e6b9b4320deaad5221ce35692 Reviewed-on: https://webrtc-review.googlesource.com/c/121405 Reviewed-by: Henrik Boström <hbos@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26533}
2019-02-04 15:21:46 +01:00
rtc_executable("rtp_generator") {
visibility = [ "*" ]
testonly = true
sources = [
"rtp_generator/main.cc",
"rtp_generator/rtp_generator.cc",
"rtp_generator/rtp_generator.h",
]
deps = [
":command_line_parser",
"../api:libjingle_peerconnection_api",
"../api:transport_api",
"../api/video:builtin_video_bitrate_allocator_factory",
"../api/video_codecs:builtin_video_decoder_factory",
"../api/video_codecs:builtin_video_encoder_factory",
"../api/video_codecs:video_codecs_api",
"../call",
"../call:call_interfaces",
"../call:fake_network",
"../call:rtp_interfaces",
"../call:rtp_sender",
"../call:simulated_network",
"../call:simulated_packet_receiver",
"../call:video_stream_api",
"../logging:rtc_event_log_api",
"../logging:rtc_event_log_impl_base",
"../media:rtc_audio_video",
"../media:rtc_media_base",
"../rtc_base:rtc_base",
"../rtc_base:rtc_base_approved",
"../rtc_base:rtc_json",
"../rtc_base/system:file_wrapper",
"../test:fileutils",
"../test:rtp_test_utils",
"../test:video_test_common",
"//third_party/abseil-cpp/absl/strings",
]
if (!build_with_chromium && is_clang) {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
}
}
Expose less targets in webrtc/rtc_tools in Chromium builds. This should solve recent linking problems with frame_editor and also speed up the Chromium build a little. BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/3006093002 Cr-Commit-Position: refs/heads/master@{#19677}
2017-09-04 23:42:45 -07:00
rtc_executable("psnr_ssim_analyzer") {
sources = [
"psnr_ssim_analyzer/psnr_ssim_analyzer.cc",
]
Move webrtc/{tools => rtc_tools} Leaving compatibility script in webrtc/tools/compare_videos.py to avoid breaking our video quality tests in Chromium. Forwarding GN targets are left in webrtc/tools/BUILD.gn. BUG=webrtc:7855 NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2965593002 Cr-Commit-Position: refs/heads/master@{#18848}
2017-06-30 03:04:59 -07:00
Expose less targets in webrtc/rtc_tools in Chromium builds. This should solve recent linking problems with frame_editor and also speed up the Chromium build a little. BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/3006093002 Cr-Commit-Position: refs/heads/master@{#19677}
2017-09-04 23:42:45 -07:00
deps = [
":command_line_parser",
Reland "Add Y4mFileReader" This is a reland of 404be7f302358e6be16aadeba8bc8f8aba348c0f It adds support for reading .yuv files as well to not break anything. Original change's description: > Add Y4mFileReader > > Encapsulate logic for reading .y4m video files in a single class. We > currently have spread out logic for opening .y4m files with partial > parsing. This CL consolidates this logic into a single class with a well > defined interface. > > Change-Id: Id61673b3c95a0053b30e95b4cf382e1c6b05fc30 > Bug: webrtc:9642 > Reviewed-on: https://webrtc-review.googlesource.com/94772 > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > Reviewed-by: Paulina Hensman <phensman@webrtc.org> > Commit-Queue: Magnus Jedvert <magjed@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#24398} TBR=phensman,phoglund Bug: webrtc:9642 Change-Id: Idecc5ec5da767221a5f5b439989f4fe07e3b3615 Reviewed-on: https://webrtc-review.googlesource.com/97983 Commit-Queue: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24571}
2018-09-05 10:46:18 +02:00
":video_file_reader",
Expose less targets in webrtc/rtc_tools in Chromium builds. This should solve recent linking problems with frame_editor and also speed up the Chromium build a little. BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/3006093002 Cr-Commit-Position: refs/heads/master@{#19677}
2017-09-04 23:42:45 -07:00
":video_quality_analysis",
Remove rtc_base/scoped_ref_ptr.h. The type rtc::scoped_refptr<T> is now part of api/. Please include it from api/scoped_refptr.h. More info: See: https://groups.google.com/forum/#!topic/discuss-webrtc/Mme2MSz4z4o. Bug: webrtc:9887, webrtc:8205 No-Try: True Change-Id: Ic6c7c81e226e59f12f7933e472f573ae097b55bf Reviewed-on: https://webrtc-review.googlesource.com/c/119041 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26414}
2019-01-25 20:26:48 +01:00
"../api:scoped_refptr",
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2. This is a follow-up to https://webrtc-review.googlesource.com/c/src/+/106280. This time the whole code base is covered. Some files may have not been fixed though, whenever the IWYU tool was breaking the build. Bug: webrtc:8311 Change-Id: I2c31f552a87e887d33931d46e87b6208b1e483ef Reviewed-on: https://webrtc-review.googlesource.com/c/111965 Commit-Queue: Yves Gerey <yvesg@google.com> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25830}
2018-11-28 16:47:49 +01:00
"../api/video:video_frame",
Expose less targets in webrtc/rtc_tools in Chromium builds. This should solve recent linking problems with frame_editor and also speed up the Chromium build a little. BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/3006093002 Cr-Commit-Position: refs/heads/master@{#19677}
2017-09-04 23:42:45 -07:00
]
Move webrtc/{tools => rtc_tools} Leaving compatibility script in webrtc/tools/compare_videos.py to avoid breaking our video quality tests in Chromium. Forwarding GN targets are left in webrtc/tools/BUILD.gn. BUG=webrtc:7855 NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2965593002 Cr-Commit-Position: refs/heads/master@{#18848}
2017-06-30 03:04:59 -07:00
}
Expose less targets in webrtc/rtc_tools in Chromium builds. This should solve recent linking problems with frame_editor and also speed up the Chromium build a little. BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/3006093002 Cr-Commit-Position: refs/heads/master@{#19677}
2017-09-04 23:42:45 -07:00
rtc_static_library("reference_less_video_analysis_lib") {
sources = [
"frame_analyzer/reference_less_video_analysis_lib.cc",
"frame_analyzer/reference_less_video_analysis_lib.h",
]
Move webrtc/{tools => rtc_tools} Leaving compatibility script in webrtc/tools/compare_videos.py to avoid breaking our video quality tests in Chromium. Forwarding GN targets are left in webrtc/tools/BUILD.gn. BUG=webrtc:7855 NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2965593002 Cr-Commit-Position: refs/heads/master@{#18848}
2017-06-30 03:04:59 -07:00
Expose less targets in webrtc/rtc_tools in Chromium builds. This should solve recent linking problems with frame_editor and also speed up the Chromium build a little. BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/3006093002 Cr-Commit-Position: refs/heads/master@{#19677}
2017-09-04 23:42:45 -07:00
deps = [
Reland "Add Y4mFileReader" This is a reland of 404be7f302358e6be16aadeba8bc8f8aba348c0f It adds support for reading .yuv files as well to not break anything. Original change's description: > Add Y4mFileReader > > Encapsulate logic for reading .y4m video files in a single class. We > currently have spread out logic for opening .y4m files with partial > parsing. This CL consolidates this logic into a single class with a well > defined interface. > > Change-Id: Id61673b3c95a0053b30e95b4cf382e1c6b05fc30 > Bug: webrtc:9642 > Reviewed-on: https://webrtc-review.googlesource.com/94772 > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > Reviewed-by: Paulina Hensman <phensman@webrtc.org> > Commit-Queue: Magnus Jedvert <magjed@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#24398} TBR=phensman,phoglund Bug: webrtc:9642 Change-Id: Idecc5ec5da767221a5f5b439989f4fe07e3b3615 Reviewed-on: https://webrtc-review.googlesource.com/97983 Commit-Queue: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24571}
2018-09-05 10:46:18 +02:00
":video_file_reader",
Expose less targets in webrtc/rtc_tools in Chromium builds. This should solve recent linking problems with frame_editor and also speed up the Chromium build a little. BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/3006093002 Cr-Commit-Position: refs/heads/master@{#19677}
2017-09-04 23:42:45 -07:00
":video_quality_analysis",
Remove rtc_base/scoped_ref_ptr.h. The type rtc::scoped_refptr<T> is now part of api/. Please include it from api/scoped_refptr.h. More info: See: https://groups.google.com/forum/#!topic/discuss-webrtc/Mme2MSz4z4o. Bug: webrtc:9887, webrtc:8205 No-Try: True Change-Id: Ic6c7c81e226e59f12f7933e472f573ae097b55bf Reviewed-on: https://webrtc-review.googlesource.com/c/119041 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26414}
2019-01-25 20:26:48 +01:00
"../api:scoped_refptr",
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2. This is a follow-up to https://webrtc-review.googlesource.com/c/src/+/106280. This time the whole code base is covered. Some files may have not been fixed though, whenever the IWYU tool was breaking the build. Bug: webrtc:8311 Change-Id: I2c31f552a87e887d33931d46e87b6208b1e483ef Reviewed-on: https://webrtc-review.googlesource.com/c/111965 Commit-Queue: Yves Gerey <yvesg@google.com> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25830}
2018-11-28 16:47:49 +01:00
"../api/video:video_frame",
Expose less targets in webrtc/rtc_tools in Chromium builds. This should solve recent linking problems with frame_editor and also speed up the Chromium build a little. BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/3006093002 Cr-Commit-Position: refs/heads/master@{#19677}
2017-09-04 23:42:45 -07:00
]
}
Move webrtc/{tools => rtc_tools} Leaving compatibility script in webrtc/tools/compare_videos.py to avoid breaking our video quality tests in Chromium. Forwarding GN targets are left in webrtc/tools/BUILD.gn. BUG=webrtc:7855 NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2965593002 Cr-Commit-Position: refs/heads/master@{#18848}
2017-06-30 03:04:59 -07:00
Expose less targets in webrtc/rtc_tools in Chromium builds. This should solve recent linking problems with frame_editor and also speed up the Chromium build a little. BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/3006093002 Cr-Commit-Position: refs/heads/master@{#19677}
2017-09-04 23:42:45 -07:00
rtc_executable("reference_less_video_analysis") {
Move webrtc/{tools => rtc_tools} Leaving compatibility script in webrtc/tools/compare_videos.py to avoid breaking our video quality tests in Chromium. Forwarding GN targets are left in webrtc/tools/BUILD.gn. BUG=webrtc:7855 NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2965593002 Cr-Commit-Position: refs/heads/master@{#18848}
2017-06-30 03:04:59 -07:00
sources = [
Expose less targets in webrtc/rtc_tools in Chromium builds. This should solve recent linking problems with frame_editor and also speed up the Chromium build a little. BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/3006093002 Cr-Commit-Position: refs/heads/master@{#19677}
2017-09-04 23:42:45 -07:00
"frame_analyzer/reference_less_video_analysis.cc",
Move webrtc/{tools => rtc_tools} Leaving compatibility script in webrtc/tools/compare_videos.py to avoid breaking our video quality tests in Chromium. Forwarding GN targets are left in webrtc/tools/BUILD.gn. BUG=webrtc:7855 NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2965593002 Cr-Commit-Position: refs/heads/master@{#18848}
2017-06-30 03:04:59 -07:00
]
deps = [
Expose less targets in webrtc/rtc_tools in Chromium builds. This should solve recent linking problems with frame_editor and also speed up the Chromium build a little. BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/3006093002 Cr-Commit-Position: refs/heads/master@{#19677}
2017-09-04 23:42:45 -07:00
":command_line_parser",
":reference_less_video_analysis_lib",
Move webrtc/{tools => rtc_tools} Leaving compatibility script in webrtc/tools/compare_videos.py to avoid breaking our video quality tests in Chromium. Forwarding GN targets are left in webrtc/tools/BUILD.gn. BUG=webrtc:7855 NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2965593002 Cr-Commit-Position: refs/heads/master@{#18848}
2017-06-30 03:04:59 -07:00
]
}
Expose less targets in webrtc/rtc_tools in Chromium builds. This should solve recent linking problems with frame_editor and also speed up the Chromium build a little. BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/3006093002 Cr-Commit-Position: refs/heads/master@{#19677}
2017-09-04 23:42:45 -07:00
rtc_executable("rgba_to_i420_converter") {
Revert "Revert "GN rtc_* templates: Set default visibility to webrtc_root + "/*""" This reverts commit c73e1f437889d882cbf2987f7fb3a029a6150613. Reason for revert: The problem with failed deps in chrome content/renderer had already been fixed in https://webrtc-review.googlesource.com/c/src/+/38660 Original change's description: > Revert "GN rtc_* templates: Set default visibility to webrtc_root + "/*"" > > This reverts commit 588c548657b3ddf76e7b3f241263eef7f5799f16. > > Reason for revert: > > Breaks Chrome FYI: > > /b/c/b/Linux_Builder/src/buildtools/linux64/gn gen //out/Release --check > -> returned 1 > ERROR at //build/split_static_library.gni:12:5: Dependency not allowed. > static_library(target_name) { > ^---------------------------- > The item //content/renderer:renderer > can not depend on //third_party/webrtc/media:rtc_internal_video_codecs > because it is not in //third_party/webrtc/media:rtc_internal_video_codecs's visibility list: [ > //third_party/webrtc/* > //third_party/webrtc_overrides/* > ] > > https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.webrtc.fyi%2FLinux_Builder%2F23560%2F%2B%2Frecipes%2Fsteps%2Fgenerate_build_files%2F0%2Fstdout > > Original change's description: > > GN rtc_* templates: Set default visibility to webrtc_root + "/*" > > > > This means that by default, targets are visible to everything under > > the WebRTC root, but not visible to anything else. > > > > API targets are manually tagged with visibility "*", so that targets > > outside the WebRTC tree can see them. > > > > BUG=webrtc:8254 > > > > Change-Id: Icdbee6e0d22d93240ff2fb530c8f9dc48e351509 > > Reviewed-on: https://webrtc-review.googlesource.com/24140 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#21548} > > TBR=mbonadei@webrtc.org,kwiberg@webrtc.org > > Change-Id: I06620ce3d6f67482935c22efa231dd6cab91625a > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:8254 > Reviewed-on: https://webrtc-review.googlesource.com/38760 > Reviewed-by: Per Kjellander <perkj@webrtc.org> > Commit-Queue: Per Kjellander <perkj@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#21555} TBR=mbonadei@webrtc.org,kwiberg@webrtc.org,perkj@webrtc.org Change-Id: I6f720078ce21bd172e0a6471bae8c4c011e4a657 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:8254 Reviewed-on: https://webrtc-review.googlesource.com/38860 Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Per Kjellander <perkj@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21558}
2018-01-10 15:54:53 +00:00
visibility = [ "*" ]
Move webrtc/{tools => rtc_tools} Leaving compatibility script in webrtc/tools/compare_videos.py to avoid breaking our video quality tests in Chromium. Forwarding GN targets are left in webrtc/tools/BUILD.gn. BUG=webrtc:7855 NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2965593002 Cr-Commit-Position: refs/heads/master@{#18848}
2017-06-30 03:04:59 -07:00
sources = [
Expose less targets in webrtc/rtc_tools in Chromium builds. This should solve recent linking problems with frame_editor and also speed up the Chromium build a little. BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/3006093002 Cr-Commit-Position: refs/heads/master@{#19677}
2017-09-04 23:42:45 -07:00
"converter/converter.cc",
"converter/converter.h",
"converter/rgba_to_i420_converter.cc",
]
deps = [
":command_line_parser",
"../common_video",
Removing $rtc_libyuv_dir and removing useless dependencies on libyuv. This CL removes the following GN variables: rtc_build_libyuv, rtc_libyuv_dir (as requested in webrtc:7906). It also removes some unneeded dependencies on //third_party/libyuv. WebRTC targets were using public_deps to depend on //third_party/libyuv and this created a build graph where targets that were depending on //third_party/libyuv were not declaring the dependency to GN because they were somehow getting it from another target that was exposing //third_party/libyuv header files even if it wasn't directly depending on it. Bug: webrtc:8605, webrtc:7906 Change-Id: If71f7988fd80421dc2ad887cf94c2ac66366c3fb Reviewed-on: https://webrtc-review.googlesource.com/32201 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21275}
2017-12-14 11:24:00 +01:00
"//third_party/libyuv",
Move webrtc/{tools => rtc_tools} Leaving compatibility script in webrtc/tools/compare_videos.py to avoid breaking our video quality tests in Chromium. Forwarding GN targets are left in webrtc/tools/BUILD.gn. BUG=webrtc:7855 NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2965593002 Cr-Commit-Position: refs/heads/master@{#18848}
2017-06-30 03:04:59 -07:00
]
}
Expose less targets in webrtc/rtc_tools in Chromium builds. This should solve recent linking problems with frame_editor and also speed up the Chromium build a little. BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/3006093002 Cr-Commit-Position: refs/heads/master@{#19677}
2017-09-04 23:42:45 -07:00
rtc_static_library("frame_editing_lib") {
Move webrtc/{tools => rtc_tools} Leaving compatibility script in webrtc/tools/compare_videos.py to avoid breaking our video quality tests in Chromium. Forwarding GN targets are left in webrtc/tools/BUILD.gn. BUG=webrtc:7855 NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2965593002 Cr-Commit-Position: refs/heads/master@{#18848}
2017-06-30 03:04:59 -07:00
sources = [
Expose less targets in webrtc/rtc_tools in Chromium builds. This should solve recent linking problems with frame_editor and also speed up the Chromium build a little. BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/3006093002 Cr-Commit-Position: refs/heads/master@{#19677}
2017-09-04 23:42:45 -07:00
"frame_editing/frame_editing_lib.cc",
"frame_editing/frame_editing_lib.h",
Move webrtc/{tools => rtc_tools} Leaving compatibility script in webrtc/tools/compare_videos.py to avoid breaking our video quality tests in Chromium. Forwarding GN targets are left in webrtc/tools/BUILD.gn. BUG=webrtc:7855 NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2965593002 Cr-Commit-Position: refs/heads/master@{#18848}
2017-06-30 03:04:59 -07:00
]
Expose less targets in webrtc/rtc_tools in Chromium builds. This should solve recent linking problems with frame_editor and also speed up the Chromium build a little. BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/3006093002 Cr-Commit-Position: refs/heads/master@{#19677}
2017-09-04 23:42:45 -07:00
Move webrtc/{tools => rtc_tools} Leaving compatibility script in webrtc/tools/compare_videos.py to avoid breaking our video quality tests in Chromium. Forwarding GN targets are left in webrtc/tools/BUILD.gn. BUG=webrtc:7855 NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2965593002 Cr-Commit-Position: refs/heads/master@{#18848}
2017-06-30 03:04:59 -07:00
deps = [
Expose less targets in webrtc/rtc_tools in Chromium builds. This should solve recent linking problems with frame_editor and also speed up the Chromium build a little. BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/3006093002 Cr-Commit-Position: refs/heads/master@{#19677}
2017-09-04 23:42:45 -07:00
"..:webrtc_common",
"../common_video",
Move webrtc/{tools => rtc_tools} Leaving compatibility script in webrtc/tools/compare_videos.py to avoid breaking our video quality tests in Chromium. Forwarding GN targets are left in webrtc/tools/BUILD.gn. BUG=webrtc:7855 NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2965593002 Cr-Commit-Position: refs/heads/master@{#18848}
2017-06-30 03:04:59 -07:00
]
Expose less targets in webrtc/rtc_tools in Chromium builds. This should solve recent linking problems with frame_editor and also speed up the Chromium build a little. BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/3006093002 Cr-Commit-Position: refs/heads/master@{#19677}
2017-09-04 23:42:45 -07:00
}
rtc_executable("frame_editor") {
sources = [
"frame_editing/frame_editing.cc",
]
deps = [
":command_line_parser",
":frame_editing_lib",
Move webrtc/{tools => rtc_tools} Leaving compatibility script in webrtc/tools/compare_videos.py to avoid breaking our video quality tests in Chromium. Forwarding GN targets are left in webrtc/tools/BUILD.gn. BUG=webrtc:7855 NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2965593002 Cr-Commit-Position: refs/heads/master@{#18848}
2017-06-30 03:04:59 -07:00
]
}
Expose less targets in webrtc/rtc_tools in Chromium builds. This should solve recent linking problems with frame_editor and also speed up the Chromium build a little. BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/3006093002 Cr-Commit-Position: refs/heads/master@{#19677}
2017-09-04 23:42:45 -07:00
if (rtc_enable_protobuf) {
proto_library("chart_proto") {
sources = [
Move chart proto for event_log_visualizer. Bug: None Change-Id: I7bca9002f208ac0bafc2d2d399978a289209496f Reviewed-on: https://webrtc-review.googlesource.com/c/113815 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25963}
2018-12-10 18:42:09 +01:00
"event_log_visualizer/proto/chart.proto",
"event_log_visualizer/proto/chart_enums.proto",
Expose less targets in webrtc/rtc_tools in Chromium builds. This should solve recent linking problems with frame_editor and also speed up the Chromium build a little. BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/3006093002 Cr-Commit-Position: refs/heads/master@{#19677}
2017-09-04 23:42:45 -07:00
]
Move chart proto for event_log_visualizer. Bug: None Change-Id: I7bca9002f208ac0bafc2d2d399978a289209496f Reviewed-on: https://webrtc-review.googlesource.com/c/113815 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25963}
2018-12-10 18:42:09 +01:00
proto_out_dir = "rtc_tools/event_log_visualizer/proto"
Expose less targets in webrtc/rtc_tools in Chromium builds. This should solve recent linking problems with frame_editor and also speed up the Chromium build a little. BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/3006093002 Cr-Commit-Position: refs/heads/master@{#19677}
2017-09-04 23:42:45 -07:00
}
rtc_static_library("event_log_visualizer_utils") {
Revert "Revert "Make some more targets publicly visible"" This reverts commit 55d1809d0d73592a1ddf4f0fb02ce7444fa066aa. Reason for revert: This cl was not the culprit for breaking chrome content/renderer deps. Original change's description: > Revert "Make some more targets publicly visible" > > This reverts commit 60d179256213c7516808aff827637cab8a47de89. > > Reason for revert: > > Breaks Chrome FYI: > > /b/c/b/Linux_Builder/src/buildtools/linux64/gn gen //out/Release --check > -> returned 1 > ERROR at //build/split_static_library.gni:12:5: Dependency not allowed. > static_library(target_name) { > ^---------------------------- > The item //content/renderer:renderer > can not depend on //third_party/webrtc/media:rtc_internal_video_codecs > because it is not in //third_party/webrtc/media:rtc_internal_video_codecs's visibility list: [ > //third_party/webrtc/* > //third_party/webrtc_overrides/* > ] > > https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.webrtc.fyi%2FLinux_Builder%2F23560%2F%2B%2Frecipes%2Fsteps%2Fgenerate_build_files%2F0%2Fstdout > > Original change's description: > > Make some more targets publicly visible > > > > To fix build errors introduced by > > https://webrtc-review.googlesource.com/c/src/+/24140 > > > > BUG=webrtc:8254 > > NOTRY=true > > > > Change-Id: I9cdf9cee39735368af78291134dbad70aebb7195 > > Reviewed-on: https://webrtc-review.googlesource.com/38660 > > Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#21552} > > TBR=mbonadei@webrtc.org,kwiberg@webrtc.org > > Change-Id: I475ac382218fa77d33abc595f0773275d715a28e > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:8254 > Reviewed-on: https://webrtc-review.googlesource.com/38740 > Reviewed-by: Per Kjellander <perkj@webrtc.org> > Commit-Queue: Per Kjellander <perkj@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#21554} TBR=mbonadei@webrtc.org,kwiberg@webrtc.org,perkj@webrtc.org Change-Id: If8e9b7b1c934ec4b5ed61941c845e62e43bef97e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:8254 Reviewed-on: https://webrtc-review.googlesource.com/38841 Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Per Kjellander <perkj@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21559}
2018-01-10 15:57:32 +00:00
visibility = [ "*" ]
Expose less targets in webrtc/rtc_tools in Chromium builds. This should solve recent linking problems with frame_editor and also speed up the Chromium build a little. BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/3006093002 Cr-Commit-Position: refs/heads/master@{#19677}
2017-09-04 23:42:45 -07:00
sources = [
"event_log_visualizer/analyzer.cc",
"event_log_visualizer/analyzer.h",
"event_log_visualizer/plot_base.cc",
"event_log_visualizer/plot_base.h",
"event_log_visualizer/plot_protobuf.cc",
"event_log_visualizer/plot_protobuf.h",
"event_log_visualizer/plot_python.cc",
"event_log_visualizer/plot_python.h",
Aid triaging of bugs by printing notifications about interesting parts of an event log. Notifications are printed for gaps in seq number, capture timestamp, arrival and send times for RTP and RTCP, and high average loss. The notifications are printed to stderr by default, but internally they are represented as subclasses to a TriageNotification base class in order to facilitate other output formats. Initially, this is only run if the event_log_visualizer is given the flag --print_triage_notifications. Only the first (LOG_START, LOG_END) segment is processed. Bug: webrtc:8383 Change-Id: If43ef7f115f622fa5552dc50951a11d5f9e3cbaa Reviewed-on: https://webrtc-review.googlesource.com/8720 Commit-Queue: Björn Terelius <terelius@webrtc.org> Reviewed-by: Philip Eliasson <philipel@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20974}
2017-11-30 15:15:25 +01:00
"event_log_visualizer/triage_notifications.h",
Expose less targets in webrtc/rtc_tools in Chromium builds. This should solve recent linking problems with frame_editor and also speed up the Chromium build a little. BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/3006093002 Cr-Commit-Position: refs/heads/master@{#19677}
2017-09-04 23:42:45 -07:00
]
if (!build_with_chromium && is_clang) {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
}
defines = [ "ENABLE_RTC_EVENT_LOG" ]
deps = [
Stop using public_deps in rtc_tools. Bug: webrtc:8603 Change-Id: I8126971f80310ad077a1e536c022a296612f573a No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/30300 Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21162}
2017-12-06 16:31:18 +01:00
":chart_proto",
Stop using public_deps in logging/. Bug: webrtc:8603 Change-Id: Id0df997620a27e47067e4b21e4e8db16aec90640 No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/30940 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21228}
2017-12-12 12:46:13 +01:00
"../:webrtc_common",
Reland "Add AudioDecoderFactory to NetEqTest constructor." This is a reland of daa970f33e1923c5651a4a63c18e3d5361d0a795 Original change's description: > Add AudioDecoderFactory to NetEqTest constructor. > > Update EventLogAnalyzer to not depend on builtin audio decoders. > > Bug: webrtc:8396, webrtc:10080 > Change-Id: Ie02ed9cda6d4f11bfdf2e65eb6482283b7520738 > Reviewed-on: https://webrtc-review.googlesource.com/c/114301 > Reviewed-by: Alex Loiko <aleloi@webrtc.org> > Reviewed-by: Ivo Creusen <ivoc@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Commit-Queue: Niels Moller <nisse@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#26026} Tbr: kwiberg@webrtc.org Bug: webrtc:8396, webrtc:10080 Change-Id: I598ce1cd41676b1992b0973b09476eeeb0e602d2 Reviewed-on: https://webrtc-review.googlesource.com/c/114940 Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Oleh Prypin <oprypin@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26058}
2018-12-19 15:06:17 +01:00
# TODO(kwiberg): Remove this dependency.
"../api/audio_codecs:audio_codecs_api",
Adds WebRtcKeyValueConfig interface The WebRtcKeyValueConfig interface allows providing custom key value configurations that changes per instance of GoogCcNetworkController. Bug: webrtc:10009 Change-Id: I520fff030d1c3c755455ec8f67896fe8a6b4d970 Reviewed-on: https://webrtc-review.googlesource.com/c/116989 Commit-Queue: Sebastian Jansson <srte@webrtc.org> Reviewed-by: Per Kjellander <perkj@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26312}
2019-01-17 16:24:12 +01:00
"../api/transport:field_trial_based_config",
Reland "Add AudioDecoderFactory to NetEqTest constructor." This is a reland of daa970f33e1923c5651a4a63c18e3d5361d0a795 Original change's description: > Add AudioDecoderFactory to NetEqTest constructor. > > Update EventLogAnalyzer to not depend on builtin audio decoders. > > Bug: webrtc:8396, webrtc:10080 > Change-Id: Ie02ed9cda6d4f11bfdf2e65eb6482283b7520738 > Reviewed-on: https://webrtc-review.googlesource.com/c/114301 > Reviewed-by: Alex Loiko <aleloi@webrtc.org> > Reviewed-by: Ivo Creusen <ivoc@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Commit-Queue: Niels Moller <nisse@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#26026} Tbr: kwiberg@webrtc.org Bug: webrtc:8396, webrtc:10080 Change-Id: I598ce1cd41676b1992b0973b09476eeeb0e602d2 Reviewed-on: https://webrtc-review.googlesource.com/c/114940 Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Oleh Prypin <oprypin@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26058}
2018-12-19 15:06:17 +01:00
"../api/transport:goog_cc",
Expose less targets in webrtc/rtc_tools in Chromium builds. This should solve recent linking problems with frame_editor and also speed up the Chromium build a little. BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/3006093002 Cr-Commit-Position: refs/heads/master@{#19677}
2017-09-04 23:42:45 -07:00
"../call:call_interfaces",
"../call:video_stream_api",
Stop using public_deps in logging/. Bug: webrtc:8603 Change-Id: Id0df997620a27e47067e4b21e4e8db16aec90640 No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/30940 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21228}
2017-12-12 12:46:13 +01:00
"../logging:rtc_event_log_api",
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
"../logging:rtc_event_log_impl_base",
Expose less targets in webrtc/rtc_tools in Chromium builds. This should solve recent linking problems with frame_editor and also speed up the Chromium build a little. BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/3006093002 Cr-Commit-Position: refs/heads/master@{#19677}
2017-09-04 23:42:45 -07:00
"../logging:rtc_event_log_parser",
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
"../logging:rtc_stream_config",
Expose less targets in webrtc/rtc_tools in Chromium builds. This should solve recent linking problems with frame_editor and also speed up the Chromium build a little. BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/3006093002 Cr-Commit-Position: refs/heads/master@{#19677}
2017-09-04 23:42:45 -07:00
"../modules/audio_coding:ana_debug_dump_proto",
Stop using public_deps in logging/. Bug: webrtc:8603 Change-Id: Id0df997620a27e47067e4b21e4e8db16aec90640 No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/30940 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21228}
2017-12-12 12:46:13 +01:00
"../modules/audio_coding:audio_network_adaptor",
Expose less targets in webrtc/rtc_tools in Chromium builds. This should solve recent linking problems with frame_editor and also speed up the Chromium build a little. BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/3006093002 Cr-Commit-Position: refs/heads/master@{#19677}
2017-09-04 23:42:45 -07:00
"../modules/audio_coding:neteq_tools",
"../modules/congestion_controller",
Removes redundant delay based bwe. This removes the legacy DelayBasedBwe to reduce code redundancy and avoid the risk of applying changes on only one version. Bug: webrtc:8415 Change-Id: I88aba03adbb77ee0ff0a97a8b3be6ddf028af48a Reviewed-on: https://webrtc-review.googlesource.com/85364 Commit-Queue: Sebastian Jansson <srte@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23798}
2018-07-02 09:25:25 +02:00
"../modules/congestion_controller/goog_cc:delay_based_bwe",
Replaces redundant congestion controller components This CL replaces components in the congestion controller module that are identical to equivalent components in the rtp and goog_cc subfolder. Some redundant components are left as they were not trivial to replace. Bug: webrtc:8415 Change-Id: I86a1f164d7b100b8ec8ba7dbc1c9bda2128a4f37 Reviewed-on: https://webrtc-review.googlesource.com/78521 Commit-Queue: Sebastian Jansson <srte@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23384}
2018-05-24 14:17:06 +02:00
"../modules/congestion_controller/goog_cc:estimators",
Removes analyzer dependency on legacy congestion controller. Bug: webrtc:9586 Change-Id: Ic1f2445d6432202aeba9164acd49b75261e91aa0 Reviewed-on: https://webrtc-review.googlesource.com/c/105107 Commit-Queue: Sebastian Jansson <srte@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25183}
2018-10-15 18:46:51 +02:00
"../modules/congestion_controller/rtp:transport_feedback",
Delete deprecated constructor of SendSideCongestionController. Move packet_router #include to where it's needed, and delete unused MockPacketRouter. Bug: webrtc:6847 Change-Id: I03c86c6fb8b413f5a535a237fa1724cc10960ffa Reviewed-on: https://webrtc-review.googlesource.com/17320 Commit-Queue: Stefan Holmer <stefan@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Stefan Holmer <stefan@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20564}
2017-10-31 10:19:10 +01:00
"../modules/pacing",
Removes analyzer dependency on legacy congestion controller. Bug: webrtc:9586 Change-Id: Ic1f2445d6432202aeba9164acd49b75261e91aa0 Reviewed-on: https://webrtc-review.googlesource.com/c/105107 Commit-Queue: Sebastian Jansson <srte@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25183}
2018-10-15 18:46:51 +02:00
"../modules/remote_bitrate_estimator",
Expose less targets in webrtc/rtc_tools in Chromium builds. This should solve recent linking problems with frame_editor and also speed up the Chromium build a little. BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/3006093002 Cr-Commit-Position: refs/heads/master@{#19677}
2017-09-04 23:42:45 -07:00
"../modules/rtp_rtcp",
Reland "Add AudioDecoderFactory to NetEqTest constructor." This is a reland of daa970f33e1923c5651a4a63c18e3d5361d0a795 Original change's description: > Add AudioDecoderFactory to NetEqTest constructor. > > Update EventLogAnalyzer to not depend on builtin audio decoders. > > Bug: webrtc:8396, webrtc:10080 > Change-Id: Ie02ed9cda6d4f11bfdf2e65eb6482283b7520738 > Reviewed-on: https://webrtc-review.googlesource.com/c/114301 > Reviewed-by: Alex Loiko <aleloi@webrtc.org> > Reviewed-by: Ivo Creusen <ivoc@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Commit-Queue: Niels Moller <nisse@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#26026} Tbr: kwiberg@webrtc.org Bug: webrtc:8396, webrtc:10080 Change-Id: I598ce1cd41676b1992b0973b09476eeeb0e602d2 Reviewed-on: https://webrtc-review.googlesource.com/c/114940 Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Oleh Prypin <oprypin@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26058}
2018-12-19 15:06:17 +01:00
"../modules/rtp_rtcp:rtp_rtcp_format",
"../rtc_base:checks",
"../rtc_base:rtc_base_approved",
"../rtc_base:rtc_numerics",
"../rtc_base:stringutils",
Use absl::make_unique and absl::WrapUnique directly Instead of going through our wrappers in ptr_util.h. This CL was generated by the following script: git grep -l ptr_util | xargs perl -pi -e 's,#include "rtc_base/ptr_util.h",#include "absl/memory/memory.h",' git grep -l MakeUnique | xargs perl -pi -e 's,\b(rtc::)?MakeUnique\b,absl::make_unique,g' git grep -l WrapUnique | xargs perl -pi -e 's,\b(rtc::)?WrapUnique\b,absl::WrapUnique,g' git checkout -- rtc_base/ptr_util{.h,_unittest.cc} git cl format Followed by manually adding dependencies on //third_party/abseil-cpp/absl/memory until `gn check` stopped complaining. Bug: webrtc:9473 Change-Id: I89ccd363f070479b8c431eb2c3d404a46eaacc1c Reviewed-on: https://webrtc-review.googlesource.com/86600 Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23850}
2018-07-05 11:40:33 +02:00
"//third_party/abseil-cpp/absl/memory",
Avoid depending on testonly target in event_log_visualizer_utils. This is done by creating a custom ReplacementAudioDecoderFactory. Bug: webrtc:8396, webrtc:10080 Change-Id: Ie1cb614fec855b82d65c6ef86c3593f547254559 Reviewed-on: https://webrtc-review.googlesource.com/c/116795 Commit-Queue: Björn Terelius <terelius@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26217}
2019-01-11 13:01:29 +01:00
"//third_party/abseil-cpp/absl/strings",
Expose less targets in webrtc/rtc_tools in Chromium builds. This should solve recent linking problems with frame_editor and also speed up the Chromium build a little. BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/3006093002 Cr-Commit-Position: refs/heads/master@{#19677}
2017-09-04 23:42:45 -07:00
]
}
}
Move webrtc/{tools => rtc_tools} Leaving compatibility script in webrtc/tools/compare_videos.py to avoid breaking our video quality tests in Chromium. Forwarding GN targets are left in webrtc/tools/BUILD.gn. BUG=webrtc:7855 NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2965593002 Cr-Commit-Position: refs/heads/master@{#18848}
2017-06-30 03:04:59 -07:00
}
if (rtc_include_tests) {
Harmonize paths to dependent targets. This CL consistently use: * relative paths for WebRTC dependent targets (test_support) * absolute paths for shared dependent targets (abseil) This is a necessary (but insufficient) step to build WebRTC tests from Chromium tree (rtc_include_tests=true), since test/ doesn't sit anymore in the top level directory. We also make sure that target declarations and uses are consistent in regard to build_with_chromium flag. Bug: webrtc:9943 Bug: webrtc:9855 Change-Id: I21dea98894df2fd4bfe2fd7ee7b71ba971e0ab5b Reviewed-on: https://webrtc-review.googlesource.com/c/108720 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Yves Gerey <yvesg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25445}
2018-10-30 21:12:42 +01:00
if (rtc_enable_protobuf && !build_with_chromium) {
Move webrtc/{tools => rtc_tools} Leaving compatibility script in webrtc/tools/compare_videos.py to avoid breaking our video quality tests in Chromium. Forwarding GN targets are left in webrtc/tools/BUILD.gn. BUG=webrtc:7855 NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2965593002 Cr-Commit-Position: refs/heads/master@{#18848}
2017-06-30 03:04:59 -07:00
rtc_executable("event_log_visualizer") {
testonly = true
sources = [
"event_log_visualizer/main.cc",
]
if (!build_with_chromium && is_clang) {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
}
defines = [ "ENABLE_RTC_EVENT_LOG" ]
deps = [
":event_log_visualizer_utils",
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2. This is a follow-up to https://webrtc-review.googlesource.com/c/src/+/106280. This time the whole code base is covered. Some files may have not been fixed though, whenever the IWYU tool was breaking the build. Bug: webrtc:8311 Change-Id: I2c31f552a87e887d33931d46e87b6208b1e483ef Reviewed-on: https://webrtc-review.googlesource.com/c/111965 Commit-Queue: Yves Gerey <yvesg@google.com> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25830}
2018-11-28 16:47:49 +01:00
"../logging:rtc_event_log_api",
Stop using public_deps in rtc_tools. Bug: webrtc:8603 Change-Id: I8126971f80310ad077a1e536c022a296612f573a No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/30300 Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21162}
2017-12-06 16:31:18 +01:00
"../logging:rtc_event_log_parser",
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2. This is a follow-up to https://webrtc-review.googlesource.com/c/src/+/106280. This time the whole code base is covered. Some files may have not been fixed though, whenever the IWYU tool was breaking the build. Bug: webrtc:8311 Change-Id: I2c31f552a87e887d33931d46e87b6208b1e483ef Reviewed-on: https://webrtc-review.googlesource.com/c/111965 Commit-Queue: Yves Gerey <yvesg@google.com> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25830}
2018-11-28 16:47:49 +01:00
"../modules/audio_coding:neteq",
"../modules/rtp_rtcp:rtp_rtcp_format",
"../rtc_base:checks",
Stop using public_deps in logging/. Bug: webrtc:8603 Change-Id: Id0df997620a27e47067e4b21e4e8db16aec90640 No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/30940 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21228}
2017-12-12 12:46:13 +01:00
"../rtc_base:protobuf_utils",
Remove remains of webrtc/base All downstream code have been updated to the new location. In PRESUBMIT.py: * Remove webrtc/rtc_base from CPP_BLACKLIST * Add webrtc/rtc_base to LEGACY_API_DIRS Fix some duplicated paths in webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn BUG=webrtc:7634 TBR=kwiberg@webrtc.org Review-Url: https://codereview.webrtc.org/2976293002 Cr-Commit-Position: refs/heads/master@{#19094}
2017-07-19 10:40:47 -07:00
"../rtc_base:rtc_base_approved",
Remove deprecated field_trial_default and metrics_default. This CL removes some deprecated build targets (and their headers) from system_wrappers: - field_trial_api - field_trial_default - metrics_api - metrics_default It also refreshes all the dependencies on field_trial.h and metrics.h. A nice side effect is that it is finally possible to remove 'nogncheck' from the following files (when it was used with field_trial_default and metrics_default): - sdk/objc/api/peerconnection/RTCMetricsSampleInfo+Private.h - sdk/android/src/jni/pc/peerconnectionfactory.cc - sdk/objc/api/peerconnection/RTCFieldTrials.mm Bug: webrtc:9631 Change-Id: Ib621f41ef8ad0aba4fe1c1d7e749c044afc956c3 No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/100524 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24878}
2018-09-28 08:51:10 +02:00
"../system_wrappers:field_trial",
Move webrtc/{tools => rtc_tools} Leaving compatibility script in webrtc/tools/compare_videos.py to avoid breaking our video quality tests in Chromium. Forwarding GN targets are left in webrtc/tools/BUILD.gn. BUG=webrtc:7855 NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2965593002 Cr-Commit-Position: refs/heads/master@{#18848}
2017-06-30 03:04:59 -07:00
"../test:field_trial",
Remove the public_deps to fileutils from test_support. Bug: webrtc:8946 Change-Id: Ia01d8bb1b42485e29f26792b9266228743d7fd90 No-Presubmit: true Reviewed-on: https://webrtc-review.googlesource.com/62100 Commit-Queue: Artem Titov <titovartem@webrtc.org> Reviewed-by: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22465}
2018-03-15 15:05:39 +01:00
"../test:fileutils",
Move webrtc/{tools => rtc_tools} Leaving compatibility script in webrtc/tools/compare_videos.py to avoid breaking our video quality tests in Chromium. Forwarding GN targets are left in webrtc/tools/BUILD.gn. BUG=webrtc:7855 NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2965593002 Cr-Commit-Position: refs/heads/master@{#18848}
2017-06-30 03:04:59 -07:00
"../test:test_support",
]
}
}
rtc_executable("activity_metric") {
testonly = true
sources = [
"agc/activity_metric.cc",
]
deps = [
Remove dependencies on modules:module_api from AudioProcessing. - Directly include api/audio/audio_frame.h everywhere AudioFrame is used. - This *will* remove transient dependencies on libjpeg and a bunch of other things from the e.g. APM. - audio_frame.h still included from module_common_types.h for backwards compatibility with clients. Bug: webrtc:9139, webrtc:7504 Change-Id: Id96f9268c01667fbcc29a01f5c1dd25a37836897 Reviewed-on: https://webrtc-review.googlesource.com/62464 Commit-Queue: Fredrik Solenberg <solenberg@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22845}
2018-04-12 22:44:09 +02:00
"../api/audio:audio_frame_api",
Break out Agc code from audio_processing. Splits 'modules/audio_processing:audio_processing' target. The files in modules/audio_processing/agc now are in targets in that folder. Reason for doing this was to include modules/audio_processing/agc/agc.h from another target in the dependent CL https://webrtc-review.googlesource.com/c/src/+/86603 This could help reducing the binary size in the future. Bug: webrtc:7494 Change-Id: I61f50ab6d5ce24d19f4097e0f3fa8b0170010887 Reviewed-on: https://webrtc-review.googlesource.com/87422 Commit-Queue: Alex Loiko <aleloi@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23873}
2018-07-06 14:54:30 +02:00
"../modules/audio_processing/agc:level_estimation",
Made modules/audio_processing/vad its own target. WHAT: made a BUILD.gn with library and tests in the Audio Processing Module Voice Activity Detector directory. Updated depending code. Fixed a Clang warning. WHY: to make it possible for a target to depend on just the VAD and not the whole APM. There are other benefits: * Sometimes faster compilation. * The VAD takes up 28000 bytes of libjingle_peerconnection_so.so. Making a peerconnection shared object file without the VAD has to be done in steps. The first step is a custom target for the VAD. Hence this Cl. Change-Id: Iea0207a0b5979db26baaf46b24beaefbb1c431af BUG: webrtc:5716, webrtc:7494 Reviewed-on: https://webrtc-review.googlesource.com/47521 Commit-Queue: Alex Loiko <aleloi@webrtc.org> Reviewed-by: Sam Zackrisson <saza@webrtc.org> Reviewed-by: Oleh Prypin <oprypin@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21893}
2018-02-05 11:15:23 +01:00
"../modules/audio_processing/vad",
Remove remains of webrtc/base All downstream code have been updated to the new location. In PRESUBMIT.py: * Remove webrtc/rtc_base from CPP_BLACKLIST * Add webrtc/rtc_base to LEGACY_API_DIRS Fix some duplicated paths in webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn BUG=webrtc:7634 TBR=kwiberg@webrtc.org Review-Url: https://codereview.webrtc.org/2976293002 Cr-Commit-Position: refs/heads/master@{#19094}
2017-07-19 10:40:47 -07:00
"../rtc_base:rtc_base_approved",
Separate build target for rtc_base/numerics/safe_minmax.h So that we can avoid dependency cycles. Bug: none Change-Id: I821d9f1319dff01403d6e4e310cbb2d4b2b125e8 Reviewed-on: https://webrtc-review.googlesource.com/60500 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22328}
2018-03-07 14:18:56 +01:00
"../rtc_base:safe_minmax",
Move webrtc/{tools => rtc_tools} Leaving compatibility script in webrtc/tools/compare_videos.py to avoid breaking our video quality tests in Chromium. Forwarding GN targets are left in webrtc/tools/BUILD.gn. BUG=webrtc:7855 NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2965593002 Cr-Commit-Position: refs/heads/master@{#18848}
2017-06-30 03:04:59 -07:00
"../test:test_support",
"//testing/gtest",
]
}
tools_unittests_resources = [
Reland "Add tool for aliging video files" This is a reland of b2c0e8f60fad10e2786e5e131136a0da1299d883 Original change's description: > Add tool for aliging video files > > This class adds logic for aligning a test video to a reference video > by an algorithm that maximizes SSIM between them. Aligned videos will be > easier to run video quality metrics on. This is a generic way of > aligning videos and can be replace the intrusive barcode stamping that > we currently use. This will be done in a follow-up CL. > > Change-Id: I71cf1e2179c0f1e03eff9e4d8fc492fd5cfbbb1c > Bug: webrtc:9642 > Reviewed-on: https://webrtc-review.googlesource.com/94773 > Commit-Queue: Magnus Jedvert <magjed@webrtc.org> > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > Reviewed-by: Paulina Hensman <phensman@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#24407} TBR=phensman,phoglund Bug: webrtc:9642 Change-Id: I35d6b0e598335b8d80fbfa37ba06d5c651bda4f6 Reviewed-on: https://webrtc-review.googlesource.com/98040 Commit-Queue: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24580}
2018-09-05 15:04:08 +02:00
"../resources/foreman_128x96.yuv",
Fixing WebRTC after moving from src/webrtc to src/ In https://webrtc-review.googlesource.com/c/src/+/1560 we moved WebRTC from src/webrtc to src/ (in order to preserve an healthy git history). This CL takes care of fixing header guards, #include paths, etc... NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true TBR=tommi@webrtc.org Bug: chromium:611808 Change-Id: Iea91618212bee0af16aa3f05071eab8f93706578 Reviewed-on: https://webrtc-review.googlesource.com/1561 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#19846}
2017-09-15 06:47:31 +02:00
"../resources/foreman_cif.yuv",
"../resources/reference_less_video_test_file.y4m",
Move webrtc/{tools => rtc_tools} Leaving compatibility script in webrtc/tools/compare_videos.py to avoid breaking our video quality tests in Chromium. Forwarding GN targets are left in webrtc/tools/BUILD.gn. BUG=webrtc:7855 NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2965593002 Cr-Commit-Position: refs/heads/master@{#18848}
2017-06-30 03:04:59 -07:00
]
if (is_ios) {
bundle_data("tools_unittests_bundle_data") {
testonly = true
sources = tools_unittests_resources
outputs = [
"{{bundle_resources_dir}}/{{source_file_part}}",
]
}
}
rtc_test("tools_unittests") {
testonly = true
sources = [
Add tool for aligning color space of video files This class adds logic for aligning color space of a test video compared to a reference video. If there is a color space mismatch, it typically does not have much impact on human perception, but it has a big impact on PSNR and SSIM calculations. For example, aligning a test run with VP8 improves PSNR and SSIM from: Average PSNR: 29.142818, average SSIM: 0.946026 to: Average PSNR: 38.146229, average SSIM: 0.965388. The optiomal color transformation between the two videos were: 0.86 0.01 0.00 14.37 0.00 0.88 0.00 15.32 0.00 0.00 0.88 15.74 which is converting YUV full range to YUV limited range. There is already a CL out for fixing this discrepancy here: https://webrtc-review.googlesource.com/c/src/+/94543 After that, hopefully there is no color space mismatch when saving the raw YUV values. It's good that the video quality tool is color space agnostic anyway, and can compensate for differences when the test video is obtained by e.g. filming a physical device screen. Also, the linear least square logic will be used for compensating geometric distorisions in a follow-up CL. Bug: webrtc:9642 Change-Id: I499713960a0544d8e45c5d09886e68ec829b28a7 Reviewed-on: https://webrtc-review.googlesource.com/c/95950 Reviewed-by: Sami Kalliomäki <sakal@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25193}
2018-09-11 12:56:06 +02:00
"frame_analyzer/linear_least_squares_unittest.cc",
Move webrtc/{tools => rtc_tools} Leaving compatibility script in webrtc/tools/compare_videos.py to avoid breaking our video quality tests in Chromium. Forwarding GN targets are left in webrtc/tools/BUILD.gn. BUG=webrtc:7855 NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2965593002 Cr-Commit-Position: refs/heads/master@{#18848}
2017-06-30 03:04:59 -07:00
"frame_analyzer/reference_less_video_analysis_unittest.cc",
Add tool for aligning color space of video files This class adds logic for aligning color space of a test video compared to a reference video. If there is a color space mismatch, it typically does not have much impact on human perception, but it has a big impact on PSNR and SSIM calculations. For example, aligning a test run with VP8 improves PSNR and SSIM from: Average PSNR: 29.142818, average SSIM: 0.946026 to: Average PSNR: 38.146229, average SSIM: 0.965388. The optiomal color transformation between the two videos were: 0.86 0.01 0.00 14.37 0.00 0.88 0.00 15.32 0.00 0.00 0.88 15.74 which is converting YUV full range to YUV limited range. There is already a CL out for fixing this discrepancy here: https://webrtc-review.googlesource.com/c/src/+/94543 After that, hopefully there is no color space mismatch when saving the raw YUV values. It's good that the video quality tool is color space agnostic anyway, and can compensate for differences when the test video is obtained by e.g. filming a physical device screen. Also, the linear least square logic will be used for compensating geometric distorisions in a follow-up CL. Bug: webrtc:9642 Change-Id: I499713960a0544d8e45c5d09886e68ec829b28a7 Reviewed-on: https://webrtc-review.googlesource.com/c/95950 Reviewed-by: Sami Kalliomäki <sakal@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25193}
2018-09-11 12:56:06 +02:00
"frame_analyzer/video_color_aligner_unittest.cc",
Add tool for aligning cropped region of video files This class adds logic for aligning what part of a test video has been encoded from a reference video. It does that by cropping and zooming in on a region of the reference video that most closely matches the test video. A small cropping does not have much impact on human perception, but it has a big impact on PSNR and SSIM calculations. For example, if the test video is cropped with one row in the top and bottom, adjusting for this improves average PSNR from 27.7146 to 29.3357 and average SSIM from 0.934891 to 0.95318 in an example test video. TBR=phoglund Bug: webrtc:9642 Change-Id: I02cfe0e2261fb58df8cdb1e15ba93285e3dc4538 Reviewed-on: https://webrtc-review.googlesource.com/c/99480 Commit-Queue: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@google.com> Reviewed-by: Sami Kalliomäki <sakal@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25755}
2018-11-22 15:17:30 +01:00
"frame_analyzer/video_geometry_aligner_unittest.cc",
Move webrtc/{tools => rtc_tools} Leaving compatibility script in webrtc/tools/compare_videos.py to avoid breaking our video quality tests in Chromium. Forwarding GN targets are left in webrtc/tools/BUILD.gn. BUG=webrtc:7855 NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2965593002 Cr-Commit-Position: refs/heads/master@{#18848}
2017-06-30 03:04:59 -07:00
"frame_analyzer/video_quality_analysis_unittest.cc",
Reland "Add tool for aliging video files" This is a reland of b2c0e8f60fad10e2786e5e131136a0da1299d883 Original change's description: > Add tool for aliging video files > > This class adds logic for aligning a test video to a reference video > by an algorithm that maximizes SSIM between them. Aligned videos will be > easier to run video quality metrics on. This is a generic way of > aligning videos and can be replace the intrusive barcode stamping that > we currently use. This will be done in a follow-up CL. > > Change-Id: I71cf1e2179c0f1e03eff9e4d8fc492fd5cfbbb1c > Bug: webrtc:9642 > Reviewed-on: https://webrtc-review.googlesource.com/94773 > Commit-Queue: Magnus Jedvert <magjed@webrtc.org> > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > Reviewed-by: Paulina Hensman <phensman@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#24407} TBR=phensman,phoglund Bug: webrtc:9642 Change-Id: I35d6b0e598335b8d80fbfa37ba06d5c651bda4f6 Reviewed-on: https://webrtc-review.googlesource.com/98040 Commit-Queue: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24580}
2018-09-05 15:04:08 +02:00
"frame_analyzer/video_temporal_aligner_unittest.cc",
Move webrtc/{tools => rtc_tools} Leaving compatibility script in webrtc/tools/compare_videos.py to avoid breaking our video quality tests in Chromium. Forwarding GN targets are left in webrtc/tools/BUILD.gn. BUG=webrtc:7855 NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2965593002 Cr-Commit-Position: refs/heads/master@{#18848}
2017-06-30 03:04:59 -07:00
"frame_editing/frame_editing_unittest.cc",
Add a check that sanitizers cause a fatal failure Inspired by https://chromium.googlesource.com/chromium/src/+/master/base/tools_sanity_unittest.cc BUG=webrtc:8214 R=kjellander@webrtc.org, kwiberg@webrtc.org Review-Url: https://codereview.webrtc.org/3005273002 . Cr-Commit-Position: refs/heads/master@{#19830}
2017-09-14 13:05:00 +02:00
"sanitizers_unittest.cc",
Move webrtc/{tools => rtc_tools} Leaving compatibility script in webrtc/tools/compare_videos.py to avoid breaking our video quality tests in Chromium. Forwarding GN targets are left in webrtc/tools/BUILD.gn. BUG=webrtc:7855 NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2965593002 Cr-Commit-Position: refs/heads/master@{#18848}
2017-06-30 03:04:59 -07:00
"simple_command_line_parser_unittest.cc",
Reland "Add Y4mFileReader" This is a reland of 404be7f302358e6be16aadeba8bc8f8aba348c0f It adds support for reading .yuv files as well to not break anything. Original change's description: > Add Y4mFileReader > > Encapsulate logic for reading .y4m video files in a single class. We > currently have spread out logic for opening .y4m files with partial > parsing. This CL consolidates this logic into a single class with a well > defined interface. > > Change-Id: Id61673b3c95a0053b30e95b4cf382e1c6b05fc30 > Bug: webrtc:9642 > Reviewed-on: https://webrtc-review.googlesource.com/94772 > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > Reviewed-by: Paulina Hensman <phensman@webrtc.org> > Commit-Queue: Magnus Jedvert <magjed@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#24398} TBR=phensman,phoglund Bug: webrtc:9642 Change-Id: Idecc5ec5da767221a5f5b439989f4fe07e3b3615 Reviewed-on: https://webrtc-review.googlesource.com/97983 Commit-Queue: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24571}
2018-09-05 10:46:18 +02:00
"video_file_reader_unittest.cc",
Add WriteVideoToFile to video_file_reader. The function checks the file extension to determine YUV or Y4M format. Also adds a flag aligned_output_file to compare_videos.py, which allows saving the aligned reference video to a file. Bug: webrtc:9642 Change-Id: Ia59f5c123a1e41104756eb6b235b6581c4ffbd77 Reviewed-on: https://webrtc-review.googlesource.com/99503 Reviewed-by: Sami Kalliomäki <sakal@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Paulina Hensman <phensman@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24787}
2018-09-14 11:32:00 +02:00
"video_file_writer_unittest.cc",
Move webrtc/{tools => rtc_tools} Leaving compatibility script in webrtc/tools/compare_videos.py to avoid breaking our video quality tests in Chromium. Forwarding GN targets are left in webrtc/tools/BUILD.gn. BUG=webrtc:7855 NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2965593002 Cr-Commit-Position: refs/heads/master@{#18848}
2017-06-30 03:04:59 -07:00
]
if (!build_with_chromium && is_clang) {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
}
deps = [
":command_line_parser",
Reland "Add Y4mFileReader" This is a reland of 404be7f302358e6be16aadeba8bc8f8aba348c0f It adds support for reading .yuv files as well to not break anything. Original change's description: > Add Y4mFileReader > > Encapsulate logic for reading .y4m video files in a single class. We > currently have spread out logic for opening .y4m files with partial > parsing. This CL consolidates this logic into a single class with a well > defined interface. > > Change-Id: Id61673b3c95a0053b30e95b4cf382e1c6b05fc30 > Bug: webrtc:9642 > Reviewed-on: https://webrtc-review.googlesource.com/94772 > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > Reviewed-by: Paulina Hensman <phensman@webrtc.org> > Commit-Queue: Magnus Jedvert <magjed@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#24398} TBR=phensman,phoglund Bug: webrtc:9642 Change-Id: Idecc5ec5da767221a5f5b439989f4fe07e3b3615 Reviewed-on: https://webrtc-review.googlesource.com/97983 Commit-Queue: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24571}
2018-09-05 10:46:18 +02:00
":video_file_reader",
Add WriteVideoToFile to video_file_reader. The function checks the file extension to determine YUV or Y4M format. Also adds a flag aligned_output_file to compare_videos.py, which allows saving the aligned reference video to a file. Bug: webrtc:9642 Change-Id: Ia59f5c123a1e41104756eb6b235b6581c4ffbd77 Reviewed-on: https://webrtc-review.googlesource.com/99503 Reviewed-by: Sami Kalliomäki <sakal@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Paulina Hensman <phensman@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24787}
2018-09-14 11:32:00 +02:00
":video_file_writer",
Move webrtc/{tools => rtc_tools} Leaving compatibility script in webrtc/tools/compare_videos.py to avoid breaking our video quality tests in Chromium. Forwarding GN targets are left in webrtc/tools/BUILD.gn. BUG=webrtc:7855 NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2965593002 Cr-Commit-Position: refs/heads/master@{#18848}
2017-06-30 03:04:59 -07:00
":video_quality_analysis",
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2. This is a follow-up to https://webrtc-review.googlesource.com/c/src/+/106280. This time the whole code base is covered. Some files may have not been fixed though, whenever the IWYU tool was breaking the build. Bug: webrtc:8311 Change-Id: I2c31f552a87e887d33931d46e87b6208b1e483ef Reviewed-on: https://webrtc-review.googlesource.com/c/111965 Commit-Queue: Yves Gerey <yvesg@google.com> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25830}
2018-11-28 16:47:49 +01:00
"../:webrtc_common",
Remove rtc_base/scoped_ref_ptr.h. The type rtc::scoped_refptr<T> is now part of api/. Please include it from api/scoped_refptr.h. More info: See: https://groups.google.com/forum/#!topic/discuss-webrtc/Mme2MSz4z4o. Bug: webrtc:9887, webrtc:8205 No-Try: True Change-Id: Ic6c7c81e226e59f12f7933e472f573ae097b55bf Reviewed-on: https://webrtc-review.googlesource.com/c/119041 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26414}
2019-01-25 20:26:48 +01:00
"../api:scoped_refptr",
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2. This is a follow-up to https://webrtc-review.googlesource.com/c/src/+/106280. This time the whole code base is covered. Some files may have not been fixed though, whenever the IWYU tool was breaking the build. Bug: webrtc:8311 Change-Id: I2c31f552a87e887d33931d46e87b6208b1e483ef Reviewed-on: https://webrtc-review.googlesource.com/c/111965 Commit-Queue: Yves Gerey <yvesg@google.com> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25830}
2018-11-28 16:47:49 +01:00
"../api/video:video_frame",
"../api/video:video_frame_i420",
Stop using public_deps to depend on libyuv. A lot of WebRTC targets were depending on //third_party/libyuv using public_deps instead of deps. This causes issues because a the inclusion of libyuv headers is not declared to the build system and this creates hidden dependencies that put the modularity of the project at risk. Bug: webrtc:8603 Change-Id: Ide0ceb84eb5640ae664dc782f3a722b55c3b601a No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/28120 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Magnus Flodman <mflodman@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21039}
2017-12-01 13:53:04 +01:00
"../common_video:common_video",
Add a check that sanitizers cause a fatal failure Inspired by https://chromium.googlesource.com/chromium/src/+/master/base/tools_sanity_unittest.cc BUG=webrtc:8214 R=kjellander@webrtc.org, kwiberg@webrtc.org Review-Url: https://codereview.webrtc.org/3005273002 . Cr-Commit-Position: refs/heads/master@{#19830}
2017-09-14 13:05:00 +02:00
"../rtc_base",
Fix circular dependencies between optional, array_view, and rtc_base. This splits things out of rtc_base and makes dependencies explicit. Bug: webrtc:6828 Change-Id: Id521896c3c43595349021c857bec216e429a0c8d Reviewed-on: https://webrtc-review.googlesource.com/32780 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21264}
2017-12-13 16:05:42 +01:00
"../rtc_base:checks",
Remove the public_deps to fileutils from test_support. Bug: webrtc:8946 Change-Id: Ia01d8bb1b42485e29f26792b9266228743d7fd90 No-Presubmit: true Reviewed-on: https://webrtc-review.googlesource.com/62100 Commit-Queue: Artem Titov <titovartem@webrtc.org> Reviewed-by: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22465}
2018-03-15 15:05:39 +01:00
"../test:fileutils",
Move webrtc/{tools => rtc_tools} Leaving compatibility script in webrtc/tools/compare_videos.py to avoid breaking our video quality tests in Chromium. Forwarding GN targets are left in webrtc/tools/BUILD.gn. BUG=webrtc:7855 NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2965593002 Cr-Commit-Position: refs/heads/master@{#18848}
2017-06-30 03:04:59 -07:00
"../test:test_main",
Harmonize paths to dependent targets. This CL consistently use: * relative paths for WebRTC dependent targets (test_support) * absolute paths for shared dependent targets (abseil) This is a necessary (but insufficient) step to build WebRTC tests from Chromium tree (rtc_include_tests=true), since test/ doesn't sit anymore in the top level directory. We also make sure that target declarations and uses are consistent in regard to build_with_chromium flag. Bug: webrtc:9943 Bug: webrtc:9855 Change-Id: I21dea98894df2fd4bfe2fd7ee7b71ba971e0ab5b Reviewed-on: https://webrtc-review.googlesource.com/c/108720 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Yves Gerey <yvesg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25445}
2018-10-30 21:12:42 +01:00
"../test:test_support",
Move webrtc/{tools => rtc_tools} Leaving compatibility script in webrtc/tools/compare_videos.py to avoid breaking our video quality tests in Chromium. Forwarding GN targets are left in webrtc/tools/BUILD.gn. BUG=webrtc:7855 NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2965593002 Cr-Commit-Position: refs/heads/master@{#18848}
2017-06-30 03:04:59 -07:00
"//testing/gtest",
Use absl::make_unique and absl::WrapUnique directly Instead of going through our wrappers in ptr_util.h. This CL was generated by the following script: git grep -l ptr_util | xargs perl -pi -e 's,#include "rtc_base/ptr_util.h",#include "absl/memory/memory.h",' git grep -l MakeUnique | xargs perl -pi -e 's,\b(rtc::)?MakeUnique\b,absl::make_unique,g' git grep -l WrapUnique | xargs perl -pi -e 's,\b(rtc::)?WrapUnique\b,absl::WrapUnique,g' git checkout -- rtc_base/ptr_util{.h,_unittest.cc} git cl format Followed by manually adding dependencies on //third_party/abseil-cpp/absl/memory until `gn check` stopped complaining. Bug: webrtc:9473 Change-Id: I89ccd363f070479b8c431eb2c3d404a46eaacc1c Reviewed-on: https://webrtc-review.googlesource.com/86600 Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23850}
2018-07-05 11:40:33 +02:00
"//third_party/abseil-cpp/absl/memory",
Add tool for aligning color space of video files This class adds logic for aligning color space of a test video compared to a reference video. If there is a color space mismatch, it typically does not have much impact on human perception, but it has a big impact on PSNR and SSIM calculations. For example, aligning a test run with VP8 improves PSNR and SSIM from: Average PSNR: 29.142818, average SSIM: 0.946026 to: Average PSNR: 38.146229, average SSIM: 0.965388. The optiomal color transformation between the two videos were: 0.86 0.01 0.00 14.37 0.00 0.88 0.00 15.32 0.00 0.00 0.88 15.74 which is converting YUV full range to YUV limited range. There is already a CL out for fixing this discrepancy here: https://webrtc-review.googlesource.com/c/src/+/94543 After that, hopefully there is no color space mismatch when saving the raw YUV values. It's good that the video quality tool is color space agnostic anyway, and can compensate for differences when the test video is obtained by e.g. filming a physical device screen. Also, the linear least square logic will be used for compensating geometric distorisions in a follow-up CL. Bug: webrtc:9642 Change-Id: I499713960a0544d8e45c5d09886e68ec829b28a7 Reviewed-on: https://webrtc-review.googlesource.com/c/95950 Reviewed-by: Sami Kalliomäki <sakal@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25193}
2018-09-11 12:56:06 +02:00
"//third_party/libyuv",
Move webrtc/{tools => rtc_tools} Leaving compatibility script in webrtc/tools/compare_videos.py to avoid breaking our video quality tests in Chromium. Forwarding GN targets are left in webrtc/tools/BUILD.gn. BUG=webrtc:7855 NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2965593002 Cr-Commit-Position: refs/heads/master@{#18848}
2017-06-30 03:04:59 -07:00
]
Harmonize paths to dependent targets. This CL consistently use: * relative paths for WebRTC dependent targets (test_support) * absolute paths for shared dependent targets (abseil) This is a necessary (but insufficient) step to build WebRTC tests from Chromium tree (rtc_include_tests=true), since test/ doesn't sit anymore in the top level directory. We also make sure that target declarations and uses are consistent in regard to build_with_chromium flag. Bug: webrtc:9943 Bug: webrtc:9855 Change-Id: I21dea98894df2fd4bfe2fd7ee7b71ba971e0ab5b Reviewed-on: https://webrtc-review.googlesource.com/c/108720 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Yves Gerey <yvesg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25445}
2018-10-30 21:12:42 +01:00
if (!build_with_chromium) {
deps += [
":frame_editing_lib",
":reference_less_video_analysis_lib",
]
}
Move webrtc/{tools => rtc_tools} Leaving compatibility script in webrtc/tools/compare_videos.py to avoid breaking our video quality tests in Chromium. Forwarding GN targets are left in webrtc/tools/BUILD.gn. BUG=webrtc:7855 NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2965593002 Cr-Commit-Position: refs/heads/master@{#18848}
2017-06-30 03:04:59 -07:00
if (rtc_enable_protobuf) {
deps += [ "network_tester:network_tester_unittests" ]
}
data = tools_unittests_resources
if (is_android) {
deps += [ "//testing/android/native_test:native_test_support" ]
shard_timeout = 900
}
if (is_ios) {
deps += [ ":tools_unittests_bundle_data" ]
}
}
if (rtc_enable_protobuf) {
copy("rtp_analyzer") {
sources = [
"py_event_log_analyzer/misc.py",
"py_event_log_analyzer/pb_parse.py",
"py_event_log_analyzer/rtp_analyzer.py",
"py_event_log_analyzer/rtp_analyzer.sh",
]
outputs = [
"$root_build_dir/{{source_file_part}}",
]
deps = [
"../logging:rtc_event_log_proto",
]
Move unpack_aecdump to a more public location. This tool is used downstream, so we want to christen rtc_tools as a kind of api dir for tools. Tools in other locations should be considered off limits. I chose rtc_tools because video_quality_toolchain is already there, which is also used downstream. Bug: None Change-Id: I234d874c8a590ca7413357ecda26b16d9b399836 Reviewed-on: https://webrtc-review.googlesource.com/32340 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21236}
2017-12-12 15:53:31 +01:00
} # rtp_analyzer
rtc_executable("unpack_aecdump") {
Making rtc_tools:unpack_aecdump publicly visible. Bug: webrtc:8254 Change-Id: I0dce33dc45f108e5dcfe18e22480d533f93073c4 No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/38960 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21569}
2018-01-10 22:18:27 +01:00
visibility = [ "*" ]
Move unpack_aecdump to a more public location. This tool is used downstream, so we want to christen rtc_tools as a kind of api dir for tools. Tools in other locations should be considered off limits. I chose rtc_tools because video_quality_toolchain is already there, which is also used downstream. Bug: None Change-Id: I234d874c8a590ca7413357ecda26b16d9b399836 Reviewed-on: https://webrtc-review.googlesource.com/32340 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21236}
2017-12-12 15:53:31 +01:00
testonly = true
sources = [
"unpack_aecdump/unpack.cc",
]
deps = [
"..:webrtc_common",
"../common_audio",
"../modules/audio_processing",
"../modules/audio_processing:audioproc_debug_proto",
"../modules/audio_processing:audioproc_debug_proto",
"../modules/audio_processing:audioproc_protobuf_utils",
"../modules/audio_processing:audioproc_test_utils",
"../rtc_base:protobuf_utils",
"../rtc_base:rtc_base_approved",
]
} # unpack_aecdump
Move webrtc/{tools => rtc_tools} Leaving compatibility script in webrtc/tools/compare_videos.py to avoid breaking our video quality tests in Chromium. Forwarding GN targets are left in webrtc/tools/BUILD.gn. BUG=webrtc:7855 NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2965593002 Cr-Commit-Position: refs/heads/master@{#18848}
2017-06-30 03:04:59 -07:00
}
}
Reference in New Issue Copy Permalink