webrtc_m130/webrtc.gni

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

1221 lines
39 KiB
Plaintext
Raw Normal View History

Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
# Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
#
# Use of this source code is governed by a BSD-style license
# that can be found in the LICENSE file in the root of the source
# tree. An additional intellectual property rights grant can be found
# in the file PATENTS. All contributing project authors may
# be found in the AUTHORS file in the root of the source tree.
import("//build/config/arm.gni")
import("//build/config/features.gni")
import("//build/config/mips.gni")
import("//build/config/ozone.gni")
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
import("//build/config/sanitizers/sanitizers.gni")
import("//build/config/sysroot.gni")
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
import("//build_overrides/build.gni")
Reland of Setting is_component_build to false by default (patchset #1 id:1 of https://codereview.webrtc.org/2731703004/ ) Reason for revert: Trying to fix this skipping the check if we are building webrtc within chromium. Original issue's description: > Revert of Setting is_component_build to false by default (patchset #5 id:80001 of https://codereview.webrtc.org/2728643003/ ) > > Reason for revert: > Breaks chrome rolls > > Original issue's description: > > Setting is_component_build to false by default > > > > Webrtc does not support component builds so we want to override > > the chromium default value (which can be true on debug builds if the > > os is different from iOS). > > > > Please note that the user can set this value to true in two ways: > > > > - using --args (e.g.: gn gen out/default --args='is_component_build=true' > > - changing the value in the args.gn file > > > > But in both cases the value will be ignored because we don't use the > > 'component' template but we rely directly on 'rtc_static_library' and > > 'rtc_shared_library'. > > > > BUG=webrtc:6975 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/2728643003 > > Cr-Commit-Position: refs/heads/master@{#17020} > > Committed: https://chromium.googlesource.com/external/webrtc/+/2cb3944ba7e4467601ebd94888e1811a6d77be49 > > TBR=kjellander@webrtc.org,mbonadei@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6975 > > Review-Url: https://codereview.webrtc.org/2731703004 > Cr-Commit-Position: refs/heads/master@{#17025} > Committed: https://chromium.googlesource.com/external/webrtc/+/2d9e7685a59c05e62c23d7125064c8e5c1f88edb TBR=kjellander@webrtc.org,tommi@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6975 Review-Url: https://codereview.webrtc.org/2729243003 Cr-Commit-Position: refs/heads/master@{#17027}
2017-03-03 19:41:59 -08:00
if (!build_with_chromium && is_component_build) {
print("The Gn argument `is_component_build` is currently " +
"ignored for WebRTC builds.")
print("Component builds are supported by Chromium and the argument " +
"`is_component_build` makes it possible to create shared libraries " +
"instead of static libraries.")
print("If an app depends on WebRTC it makes sense to just depend on the " +
"WebRTC static library, so there is no difference between " +
"`is_component_build=true` and `is_component_build=false`.")
print(
"More info about component builds at: " + "https://chromium.googlesource.com/chromium/src/+/main/docs/component_build.md")
Reland of Setting is_component_build to false by default (patchset #1 id:1 of https://codereview.webrtc.org/2731703004/ ) Reason for revert: Trying to fix this skipping the check if we are building webrtc within chromium. Original issue's description: > Revert of Setting is_component_build to false by default (patchset #5 id:80001 of https://codereview.webrtc.org/2728643003/ ) > > Reason for revert: > Breaks chrome rolls > > Original issue's description: > > Setting is_component_build to false by default > > > > Webrtc does not support component builds so we want to override > > the chromium default value (which can be true on debug builds if the > > os is different from iOS). > > > > Please note that the user can set this value to true in two ways: > > > > - using --args (e.g.: gn gen out/default --args='is_component_build=true' > > - changing the value in the args.gn file > > > > But in both cases the value will be ignored because we don't use the > > 'component' template but we rely directly on 'rtc_static_library' and > > 'rtc_shared_library'. > > > > BUG=webrtc:6975 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/2728643003 > > Cr-Commit-Position: refs/heads/master@{#17020} > > Committed: https://chromium.googlesource.com/external/webrtc/+/2cb3944ba7e4467601ebd94888e1811a6d77be49 > > TBR=kjellander@webrtc.org,mbonadei@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6975 > > Review-Url: https://codereview.webrtc.org/2731703004 > Cr-Commit-Position: refs/heads/master@{#17025} > Committed: https://chromium.googlesource.com/external/webrtc/+/2d9e7685a59c05e62c23d7125064c8e5c1f88edb TBR=kjellander@webrtc.org,tommi@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6975 Review-Url: https://codereview.webrtc.org/2729243003 Cr-Commit-Position: refs/heads/master@{#17027}
2017-03-03 19:41:59 -08:00
assert(!is_component_build, "Component builds are not supported in WebRTC.")
}
if (is_ios) {
import("//build/config/ios/rules.gni")
}
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
if (is_mac) {
import("//build/config/mac/rules.gni")
}
# This declare_args is separated from the next one because args declared
# in this one, can be read from the next one (args defined in the same
# declare_args cannot be referenced in that scope).
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
declare_args() {
# Setting this to true will make RTC_EXPORT (see rtc_base/system/rtc_export.h)
# expand to code that will manage symbols visibility.
rtc_enable_symbol_export = false
}
declare_args() {
# Setting this to true, will make RTC_DLOG() expand to log statements instead
# of being removed by the preprocessor.
# This is useful for example to be able to get RTC_DLOGs on a release build.
rtc_dlog_always_on = false
# Setting this to true will make RTC_OBJC_EXPORT expand to code that will
# manage symbols visibility. By default, Obj-C/Obj-C++ symbols are exported
# if C++ symbols are but setting this arg to true while keeping
# rtc_enable_symbol_export=false will only export RTC_OBJC_EXPORT
# annotated symbols.
rtc_enable_objc_symbol_export = rtc_enable_symbol_export
# Setting this to true will define WEBRTC_EXCLUDE_FIELD_TRIAL_DEFAULT which
# will tell the pre-processor to remove the default definition of symbols
# needed to use field_trial. In that case a new implementation needs to be
# provided.
if (build_with_chromium) {
# When WebRTC is built as part of Chromium it should exclude the default
# implementation of field_trial unless it is building for NACL or
# Chromecast.
rtc_exclude_field_trial_default = !is_nacl && !is_chromecast
} else {
rtc_exclude_field_trial_default = false
}
# Setting this to true will define WEBRTC_EXCLUDE_METRICS_DEFAULT which
# will tell the pre-processor to remove the default definition of symbols
# needed to use metrics. In that case a new implementation needs to be
# provided.
rtc_exclude_metrics_default = build_with_chromium
# Setting this to true will define WEBRTC_EXCLUDE_SYSTEM_TIME which
# will tell the pre-processor to remove the default definition of the
# SystemTimeNanos() which is defined in rtc_base/system_time.cc. In
# that case a new implementation needs to be provided.
Reland "Enable use of rtc::SystemTimeNanos() provided by Chromium" This reverts commit cd5127b11e04b7f49031b2412625c36e4a86c3da. Reason for revert: Fuzzer build problems fixed. Original change's description: > Revert "Enable use of rtc::SystemTimeNanos() provided by Chromium" > > This reverts commit dfe19719e53abfd4d73722942445c5e1046b671b. > > Reason for revert: Breaks fuzzers in Chromium builds. See https://ci.chromium.org/ui/p/chromium/builders/try/linux-libfuzzer-asan-rel/685438/overview. I am reverting since this blocks the roll but I will be in touch for a fix. > > Original change's description: > > Enable use of rtc::SystemTimeNanos() provided by Chromium > > > > This is the third CL out of three to enable overriding > > of the function SystemTimeNanos() in rtc_base/system_time.cc > > > > When WebRTC is built as part of Chromium the rtc::SystemTimeNanos() > > function provided by Chromium will be used. This is controlled > > by the build argument rtc_exclude_system_time which directly > > maps to the macro WEBRTC_EXCLUDE_SYSTEM_TIME. > > > > By doing this we are making sure that the WebRTC and Chromium > > clocks are the same. > > > > Bug: chromium:516700 > > Change-Id: If7f749c4aadefb1cfc07ba4c7e3f45dc6c31118b > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/208223 > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#33337} > > TBR=kron@webrtc.org > > Bug: chromium:516700 > Change-Id: I9ecd1784a6c1cdac8bae07d34f7df20c62a21a95 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/208740 > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#33340} Bug: chromium:516700 Change-Id: I4cd68bac1cc4befdb46351f5d6fb2cf1ef5c3062 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/208742 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Johannes Kron <kron@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33341}
2021-02-25 10:10:08 +01:00
rtc_exclude_system_time = build_with_chromium
# Setting this to false will require the API user to pass in their own
# SSLCertificateVerifier to verify the certificates presented from a
# TLS-TURN server. In return disabling this saves around 100kb in the binary.
rtc_builtin_ssl_root_certificates = true
# Include the iLBC audio codec?
Revert "Build: Disable the iLBC audio codec by default" This reverts commit f14d2a500d5daadc3354c8ccd2bf1619bc0782e9. Reason for revert: low_bandwidth_perf_tests regression. https://bugs.chromium.org/p/webrtc/issues/detail?id=11748#c28 Should be fine to reland as soon as we understand why iLBC affects low_bandwidth_perf_tests BUG=webrtc:11748 Original change's description: > Build: Disable the iLBC audio codec by default > > webrtc.org no longer builds with the iLBC audio codec by default by > setting rtc_include_ilbc to false in webrtc.gni. > > You can read more about iLBC at > https://webrtc.github.io/webrtc-org/license/ilbc-freeware/ > > iLBC is not a mandatory-to-implement codec in WebRTC (and we are > pretty sure it was never enabled in Chrome). This affects only > native applications which can change the build flag again. > > BUG=webrtc:11740 > > Change-Id: I513658a950100a90346370c9210806aee0f34607 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178395 > Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#31599} TBR=mbonadei@webrtc.org,kwiberg@webrtc.org,hta@webrtc.org,philipp.hancke@googlemail.com,courtneyfe@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: webrtc:11740 Change-Id: Iaa0c39487464d31661ac8c22c9e21b6cb79b645a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178907 Commit-Queue: Olga Sharonova <olka@webrtc.org> Reviewed-by: Olga Sharonova <olka@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31685}
2020-07-09 09:50:42 +00:00
rtc_include_ilbc = true
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
# Disable this to avoid building the Opus audio codec.
rtc_include_opus = true
# Enable this if the Opus version upon which WebRTC is built supports direct
# encoding of 120 ms packets.
rtc_opus_support_120ms_ptime = true
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
# Enable this to let the Opus audio codec change complexity on the fly.
rtc_opus_variable_complexity = false
# Used to specify an external Jsoncpp include path when not compiling the
# library that comes with WebRTC (i.e. rtc_build_json == 0).
rtc_jsoncpp_root = "//third_party/jsoncpp/source/include"
# Used to specify an external OpenSSL include path when not compiling the
# library that comes with WebRTC (i.e. rtc_build_ssl == 0).
rtc_ssl_root = ""
# Enable when an external authentication mechanism is used for performing
# packet authentication for RTP packets instead of libsrtp.
rtc_enable_external_auth = build_with_chromium
# Selects whether debug dumps for the audio processing module
# should be generated.
apm_debug_dump = false
# Selects whether the audio processing module should be excluded.
rtc_exclude_audio_processing_module = false
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
# Set this to true to enable BWE test logging.
rtc_enable_bwe_test_logging = false
# Set this to false to skip building examples.
rtc_build_examples = true
# Set this to false to skip building tools.
rtc_build_tools = true
# Set this to false to skip building code that requires X11.
rtc_use_x11 = ozone_platform_x11
# Set this to use PipeWire on the Wayland display server.
Reland "Default to dlopening the PipeWire." This is a reland of 0cc42d47389c039c57e47d7ec0c76b97e2da2b0b Original change's description: > Reland "Default to dlopening the PipeWire." > > This is a reland of a099877d8946eb942046ca1295cc142e4fa7ea6f > > Original change's description: > > Reland "Default to dlopening the PipeWire." > > > > This is a reland of a13be019017449c57f48203d0fb778f34f7553a7 > > > > Original change's description: > > > Default to dlopening the PipeWire. > > > > > > Reuse the existing infra from Chromium to do that. Additionally the > > > target_gen_dir needs to the added to the include directories, otherwise > > > the Chromium build will fail as it won't find the generated stubs. Also the > > > pw_properties_new() was replaced with pw_properties_new_string() as it doesn't > > > require a variadic parameter because the //tools/generate_stubs/generate_stubs.py > > > doesn't work with them correctly. With all these changes in place the PipeWire > > > support is enabled when compiling on Linux. > > > > > > Bug: chromium:682122 > > > Change-Id: I3bbc5efaecd9a08e20cbcf998b2cb534224eae7d > > > Reviewed-on: https://webrtc-review.googlesource.com/c/111081 > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > Reviewed-by: Brave Yao <braveyao@webrtc.org> > > > Commit-Queue: Tomáš Popela <tomas.popela@gmail.com> > > > Cr-Commit-Position: refs/heads/master@{#25720} > > > > Bug: chromium:682122 > > Change-Id: I3cca3d4d961dc7a088346c8fd3c970d3dfde3b79 > > Reviewed-on: https://webrtc-review.googlesource.com/c/113040 > > Reviewed-by: Weiyong Yao <braveyao@chromium.org> > > Reviewed-by: Brave Yao <braveyao@webrtc.org> > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Reviewed-by: Oleh Prypin <oprypin@webrtc.org> > > Commit-Queue: Oleh Prypin <oprypin@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#25981} > > Bug: chromium:682122 > Change-Id: Ief26c93069f946f981340664a267fcb412229285 > Reviewed-on: https://webrtc-review.googlesource.com/c/114163 > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Brave Yao <braveyao@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#26004} Bug: chromium:682122 Change-Id: I0a4ea7b39be5970f26df6dbc3e437dd63cdb8708 Reviewed-on: https://webrtc-review.googlesource.com/c/116280 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Brave Yao <braveyao@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26154}
2018-12-12 14:37:51 +01:00
# By default it's only enabled on desktop Linux (excludes ChromeOS) and
# only when using the sysroot as PipeWire is not available in older and
# supported Ubuntu and Debian distributions.
Revert "Reland "PipeWire capturer: implement proper DMA-BUFs support""" This reverts commit 677195d3eb6a5f0bc1d31d794a5190ba281c0335. Reason for revert: Broke WebRTC to Chrome rolls: https://crrev.com/c/3141000 example: https://ci.chromium.org/ui/p/chromium/builders/try/linux-rel/790256/overview The error is similar to the failure on previous attempt to land this CL. See: https://crrev.com/c/3135220, and crash https://ci.chromium.org/ui/p/chromium/builders/try/linux-rel/787945/overview Original change's description: > Reland "PipeWire capturer: implement proper DMA-BUFs support"" > > This is a reland of f2177f6612079ccce9c320ea7e77bc934c684f5c > > Original change's description: > > PipeWire capturer: implement proper DMA-BUFs support > > > > Currently both KWin (KDE) and Mutter (GNOME) window managers don't > > use DMA-BUFs by default, but only when client asks specifically for > > them (KWin) or when experimental DMA-BUF support is enabled (Mutter). > > While current implementation works just fine on integrated graphics > > cards, it causes issues on dedicated GPUs (AMD and NVidia) where the > > code either crashes or screensharing is slow and unusable. > > > > To fix this, DMA-BUFs has to be opened using OpenGL context and not > > being directly mmaped(). This implementation requires to use DMA-BUF > > modifiers, as they are now mandatory for DMA-BUFs usage. > > > > Documentation for this behavior can be found here: > > https://gitlab.freedesktop.org/pipewire/pipewire/-/blob/master/doc/dma-buf.dox > > > > Bug: chromium:1233417, webrtc:13137 > > Change-Id: I0cecf16d6bb0f576954b9e8f071cab526f7baf2c > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227022 > > Commit-Queue: Tommi <tommi@webrtc.org> > > Reviewed-by: Tommi <tommi@webrtc.org> > > Reviewed-by: Erik Språng <sprang@webrtc.org> > > Cr-Commit-Position: refs/heads/main@{#34889} > > Bug: chromium:1233417, webrtc:13137 > Change-Id: I7d5763dd5db708cee20a31e559b26db0287f40d6 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/230946 > Reviewed-by: Tommi <tommi@webrtc.org> > Commit-Queue: Tommi <tommi@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#34903} # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1233417, webrtc:13137 Change-Id: I64e2ce864f69e6097aba65ade04af7166e407409 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/231135 Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/main@{#34915}
2021-09-03 10:07:20 +00:00
rtc_use_pipewire = is_linux && use_sysroot
Reland "Default to dlopening the PipeWire." This is a reland of 0cc42d47389c039c57e47d7ec0c76b97e2da2b0b Original change's description: > Reland "Default to dlopening the PipeWire." > > This is a reland of a099877d8946eb942046ca1295cc142e4fa7ea6f > > Original change's description: > > Reland "Default to dlopening the PipeWire." > > > > This is a reland of a13be019017449c57f48203d0fb778f34f7553a7 > > > > Original change's description: > > > Default to dlopening the PipeWire. > > > > > > Reuse the existing infra from Chromium to do that. Additionally the > > > target_gen_dir needs to the added to the include directories, otherwise > > > the Chromium build will fail as it won't find the generated stubs. Also the > > > pw_properties_new() was replaced with pw_properties_new_string() as it doesn't > > > require a variadic parameter because the //tools/generate_stubs/generate_stubs.py > > > doesn't work with them correctly. With all these changes in place the PipeWire > > > support is enabled when compiling on Linux. > > > > > > Bug: chromium:682122 > > > Change-Id: I3bbc5efaecd9a08e20cbcf998b2cb534224eae7d > > > Reviewed-on: https://webrtc-review.googlesource.com/c/111081 > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > Reviewed-by: Brave Yao <braveyao@webrtc.org> > > > Commit-Queue: Tomáš Popela <tomas.popela@gmail.com> > > > Cr-Commit-Position: refs/heads/master@{#25720} > > > > Bug: chromium:682122 > > Change-Id: I3cca3d4d961dc7a088346c8fd3c970d3dfde3b79 > > Reviewed-on: https://webrtc-review.googlesource.com/c/113040 > > Reviewed-by: Weiyong Yao <braveyao@chromium.org> > > Reviewed-by: Brave Yao <braveyao@webrtc.org> > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Reviewed-by: Oleh Prypin <oprypin@webrtc.org> > > Commit-Queue: Oleh Prypin <oprypin@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#25981} > > Bug: chromium:682122 > Change-Id: Ief26c93069f946f981340664a267fcb412229285 > Reviewed-on: https://webrtc-review.googlesource.com/c/114163 > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Brave Yao <braveyao@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#26004} Bug: chromium:682122 Change-Id: I0a4ea7b39be5970f26df6dbc3e437dd63cdb8708 Reviewed-on: https://webrtc-review.googlesource.com/c/116280 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Brave Yao <braveyao@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26154}
2018-12-12 14:37:51 +01:00
Reland "PipeWire capturer: implement proper DMA-BUFs support"" This is a reland of f2177f6612079ccce9c320ea7e77bc934c684f5c Original change's description: > PipeWire capturer: implement proper DMA-BUFs support > > Currently both KWin (KDE) and Mutter (GNOME) window managers don't > use DMA-BUFs by default, but only when client asks specifically for > them (KWin) or when experimental DMA-BUF support is enabled (Mutter). > While current implementation works just fine on integrated graphics > cards, it causes issues on dedicated GPUs (AMD and NVidia) where the > code either crashes or screensharing is slow and unusable. > > To fix this, DMA-BUFs has to be opened using OpenGL context and not > being directly mmaped(). This implementation requires to use DMA-BUF > modifiers, as they are now mandatory for DMA-BUFs usage. > > Documentation for this behavior can be found here: > https://gitlab.freedesktop.org/pipewire/pipewire/-/blob/master/doc/dma-buf.dox > > Bug: chromium:1233417 > Change-Id: I0cecf16d6bb0f576954b9e8f071cab526f7baf2c > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227022 > Commit-Queue: Tommi <tommi@webrtc.org> > Reviewed-by: Tommi <tommi@webrtc.org> > Reviewed-by: Erik Språng <sprang@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#34889} Bug: chromium:1233417 Change-Id: I308501d86ec18ab6df9bcee569c4b72df7926549 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/231180 Reviewed-by: Erik Språng <sprang@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Commit-Queue: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/main@{#35152}
2021-09-21 20:36:16 +02:00
# Set this to link PipeWire and required libraries directly instead of using the dlopen.
Reland "Default to dlopening the PipeWire." This is a reland of 0cc42d47389c039c57e47d7ec0c76b97e2da2b0b Original change's description: > Reland "Default to dlopening the PipeWire." > > This is a reland of a099877d8946eb942046ca1295cc142e4fa7ea6f > > Original change's description: > > Reland "Default to dlopening the PipeWire." > > > > This is a reland of a13be019017449c57f48203d0fb778f34f7553a7 > > > > Original change's description: > > > Default to dlopening the PipeWire. > > > > > > Reuse the existing infra from Chromium to do that. Additionally the > > > target_gen_dir needs to the added to the include directories, otherwise > > > the Chromium build will fail as it won't find the generated stubs. Also the > > > pw_properties_new() was replaced with pw_properties_new_string() as it doesn't > > > require a variadic parameter because the //tools/generate_stubs/generate_stubs.py > > > doesn't work with them correctly. With all these changes in place the PipeWire > > > support is enabled when compiling on Linux. > > > > > > Bug: chromium:682122 > > > Change-Id: I3bbc5efaecd9a08e20cbcf998b2cb534224eae7d > > > Reviewed-on: https://webrtc-review.googlesource.com/c/111081 > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > Reviewed-by: Brave Yao <braveyao@webrtc.org> > > > Commit-Queue: Tomáš Popela <tomas.popela@gmail.com> > > > Cr-Commit-Position: refs/heads/master@{#25720} > > > > Bug: chromium:682122 > > Change-Id: I3cca3d4d961dc7a088346c8fd3c970d3dfde3b79 > > Reviewed-on: https://webrtc-review.googlesource.com/c/113040 > > Reviewed-by: Weiyong Yao <braveyao@chromium.org> > > Reviewed-by: Brave Yao <braveyao@webrtc.org> > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Reviewed-by: Oleh Prypin <oprypin@webrtc.org> > > Commit-Queue: Oleh Prypin <oprypin@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#25981} > > Bug: chromium:682122 > Change-Id: Ief26c93069f946f981340664a267fcb412229285 > Reviewed-on: https://webrtc-review.googlesource.com/c/114163 > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Brave Yao <braveyao@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#26004} Bug: chromium:682122 Change-Id: I0a4ea7b39be5970f26df6dbc3e437dd63cdb8708 Reviewed-on: https://webrtc-review.googlesource.com/c/116280 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Brave Yao <braveyao@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26154}
2018-12-12 14:37:51 +01:00
rtc_link_pipewire = false
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
# Enable to use the Mozilla internal settings.
build_with_mozilla = false
# Experimental: enable use of Android AAudio which requires Android SDK 26 or above
# and NDK r16 or above.
rtc_enable_android_aaudio = false
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
# Set to "func", "block", "edge" for coverage generation.
# At unit test runtime set UBSAN_OPTIONS="coverage=1".
# It is recommend to set include_examples=0.
# Use llvm's sancov -html-report for human readable reports.
# See http://clang.llvm.org/docs/SanitizerCoverage.html .
rtc_sanitize_coverage = ""
# Selects fixed-point code where possible.
rtc_prefer_fixed_point = false
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
if (current_cpu == "arm" || current_cpu == "arm64") {
rtc_prefer_fixed_point = true
}
# Determines whether NEON code will be built.
rtc_build_with_neon =
(current_cpu == "arm" && arm_use_neon) || current_cpu == "arm64"
# Enable this to build OpenH264 encoder/FFmpeg decoder. This is supported on
# all platforms except Android and iOS. Because FFmpeg can be built
# with/without H.264 support, `ffmpeg_branding` has to separately be set to a
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
# value that includes H.264, for example "Chrome". If FFmpeg is built without
# H.264, compilation succeeds but `H264DecoderImpl` fails to initialize.
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
# CHECK THE OPENH264, FFMPEG AND H.264 LICENSES/PATENTS BEFORE BUILDING.
# http://www.openh264.org, https://www.ffmpeg.org/
#
# Enabling H264 when building with MSVC is currently not supported, see
# bugs.webrtc.org/9213#c13 for more info.
rtc_use_h264 =
proprietary_codecs && !is_android && !is_ios && !(is_win && !is_clang)
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
# Enable this flag to make webrtc::Mutex be implemented by absl::Mutex.
rtc_use_absl_mutex = false
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
# By default, use normal platform audio support or dummy audio, but don't
# use file-based audio playout and record.
rtc_use_dummy_audio_file_devices = false
# When set to true, replace the audio output with a sinus tone at 440Hz.
# The ADM will ask for audio data from WebRTC but instead of reading real
# audio samples from NetEQ, a sinus tone will be generated and replace the
# real audio samples.
rtc_audio_device_plays_sinus_tone = false
if (is_ios) {
# Build broadcast extension in AppRTCMobile for iOS. This results in the
# binary only running on iOS 11+, which is why it is disabled by default.
rtc_apprtcmobile_broadcast_extension = false
}
# Determines whether OpenGL is available on iOS/macOS.
rtc_ios_macos_use_opengl_rendering =
!(is_ios && target_environment == "catalyst")
# When set to false, builtin audio encoder/decoder factories and all the
# audio codecs they depend on will not be included in libwebrtc.{a|lib}
# (they will still be included in libjingle_peerconnection_so.so and
# WebRTC.framework)
rtc_include_builtin_audio_codecs = true
# When set to false, builtin video encoder/decoder factories and all the
# video codecs they depends on will not be included in libwebrtc.{a|lib}
# (they will still be included in libjingle_peerconnection_so.so and
# WebRTC.framework)
rtc_include_builtin_video_codecs = true
# When set to true and in a standalone build, it will undefine UNICODE and
# _UNICODE (which are always defined globally by the Chromium Windows
# toolchain).
# This is only needed for testing purposes, WebRTC wants to be sure it
# doesn't assume /DUNICODE and /D_UNICODE but that it explicitly uses
# wide character functions.
rtc_win_undef_unicode = false
Reland "Begin implementing WGC CaptureFrame" This reverts commit 61709a3233174618d5ab46e1ee5847e4b150c7ef. Reason for revert: Some downstream projects have issues building this change due to the inclusion of the <windows.graphics.capture.h> header which is newly available in the Win 10 SDK v10.0.19041. To get around this issue for now, this change adds an off-by-default build flag for these files. However, in the future we will want to toggle this flag on, and the downstream projects will either need to update their SDK versions or toggle this flag in their WebRTC clone. Original change's description: > Revert "Begin implementing WGC CaptureFrame" > > This reverts commit e820cef5340610b9beebbcb63868743b95b97fcd. > > Reason for revert: Breaks downstream client. I will investigate and > get back with a suggestion to fix. > > Original change's description: > > Begin implementing WGC CaptureFrame > > > > This change introduces the design that will allow us to deliver frames > > synchronously to callers despite the Windows.Graphics.Capture APIs being > > inherently asynchronous. > > > > We achieve this by having WindowCapturerWinWgc create and maintain a > > WgcCaptureSession object for each window that it is asked to capture a > > frame for. The capture session object will be the class that actually > > uses the WGC APIs, and it will store the frames it receives in a frame > > pool and deliver them via GetMostRecentFrame. > > > > The next CL will add the necessary functionality to the > > WgcCaptureSession class. > > > > Bug: webrtc:9273 > > Change-Id: I44e164f4874503d8ccc8e6a210e74f9c8458f6c4 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184220 > > Commit-Queue: Austin Orion <auorion@microsoft.com> > > Reviewed-by: Tommi <tommi@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#32240} > > TBR=mbonadei@webrtc.org,jamiewalch@chromium.org,tommi@webrtc.org,auorion@microsoft.com > > Change-Id: I114944357ce5be7d1e2da817703dc95d544aa99a > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:9273 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/186045 > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#32248} Bug: webrtc:9273 Change-Id: I9644fbf8f1fd1a84cb716176b8f14e3683a3f7cb Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/186423 Commit-Queue: Tommi <tommi@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32286}
2020-10-01 13:47:54 -07:00
# When set to true, a capturer implementation that uses the
# Windows.Graphics.Capture APIs will be available for use. This introduces a
# dependency on the Win 10 SDK v10.0.17763.0.
rtc_enable_win_wgc = is_win
Reland "Add dav1d decoder to WebRTC." This reverts commit 8498b7e7f6b90fa036de2a6887d34256f0565b4f. Reason for revert: Updating CL to include conditional build flag. Original change's description: > Revert "Add dav1d decoder to WebRTC." > > This reverts commit 147858577d4db6d257d3cc248fe571a1bbf887e3. > > Reason for revert: High binary size increase > > Original change's description: > > Add dav1d decoder to WebRTC. > > > > Bug: none > > Change-Id: I7642f42e592dcf510679f881f118bc4dab93b31c > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/237504 > > Commit-Queue: Philip Eliasson <philipel@webrtc.org> > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> > > Reviewed-by: Magnus Flodman <mflodman@webrtc.org> > > Reviewed-by: Sergey Silkin <ssilkin@webrtc.org> > > Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> > > Cr-Commit-Position: refs/heads/main@{#35394} > > TBR=danilchap@webrtc.org,mbonadei@webrtc.org,ilnik@webrtc.org,philipel@webrtc.org,mflodman@webrtc.org,ssilkin@webrtc.org,webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com > > Change-Id: I00a8acd6ea94ce523c2d5ba705333c9174678180 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: none > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/238560 > Reviewed-by: Artem Titov <titovartem@webrtc.org> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Owners-Override: Mirko Bonadei <mbonadei@webrtc.org> > Owners-Override: Artem Titov <titovartem@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#35395} # Not skipping CQ checks because original CL landed > 1 day ago. Bug: none Change-Id: Iff51848731646159e87e075c38af7cb6355f5b5b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/238661 Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Magnus Flodman <mflodman@webrtc.org> Reviewed-by: Sergey Silkin <ssilkin@webrtc.org> Reviewed-by: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Commit-Queue: Philip Eliasson <philipel@webrtc.org> Cr-Commit-Position: refs/heads/main@{#35409}
2021-11-23 11:00:24 +01:00
# Includes the dav1d decoder in the internal decoder factory when set to true.
rtc_include_dav1d_in_internal_decoder_factory = true
}
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
if (!build_with_mozilla) {
import("//testing/test.gni")
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
}
# A second declare_args block, so that declarations within it can
# depend on the possibly overridden variables in the first
# declare_args block.
declare_args() {
# Enables the use of protocol buffers for debug recordings.
rtc_enable_protobuf = !build_with_mozilla
# Set this to disable building with support for SCTP data channels.
rtc_enable_sctp = !build_with_mozilla
# Disable these to not build components which can be externally provided.
rtc_build_json = !build_with_mozilla
rtc_build_libsrtp = !build_with_mozilla
rtc_build_libvpx = !build_with_mozilla
rtc_libvpx_build_vp9 = !build_with_mozilla
rtc_build_opus = !build_with_mozilla
rtc_build_ssl = !build_with_mozilla
# Enable libevent task queues on platforms that support it.
if (is_win || is_mac || is_ios || is_nacl || is_fuchsia ||
target_cpu == "wasm") {
rtc_enable_libevent = false
rtc_build_libevent = false
} else {
rtc_enable_libevent = true
rtc_build_libevent = !build_with_mozilla
}
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
# Excluded in Chromium since its prerequisites don't require Pulse Audio.
rtc_include_pulse_audio = !build_with_chromium
# Chromium uses its own IO handling, so the internal ADM is only built for
# standalone WebRTC.
rtc_include_internal_audio_device = !build_with_chromium
# Set this to true to enable the avx2 support in webrtc.
# TODO: Make sure that AVX2 works also for non-clang compilers.
if (is_clang == true) {
rtc_enable_avx2 = true
} else {
rtc_enable_avx2 = false
}
# Set this to true to build the unit tests.
# Disabled when building with Chromium or Mozilla.
rtc_include_tests = !build_with_chromium && !build_with_mozilla
# Set this to false to skip building code that also requires X11 extensions
# such as Xdamage, Xfixes.
rtc_use_x11_extensions = rtc_use_x11
# Set this to true to fully remove logging from WebRTC.
rtc_disable_logging = false
# Set this to true to disable trace events.
rtc_disable_trace_events = false
# Set this to true to disable detailed error message and logging for
# RTC_CHECKs.
rtc_disable_check_msg = false
# Set this to true to disable webrtc metrics.
rtc_disable_metrics = false
# Set this to true to exclude the transient suppressor in the audio processing
# module from the build.
rtc_exclude_transient_suppressor = false
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
}
declare_args() {
# Enable the dcsctp backend for DataChannels and related unittests
rtc_build_dcsctp = !build_with_mozilla && rtc_enable_sctp
# Enable the usrsctp backend for DataChannels and related unittests
rtc_build_usrsctp = !build_with_mozilla && rtc_enable_sctp
}
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
# Make it possible to provide custom locations for some libraries (move these
# up into declare_args should we need to actually use them for the GN build).
rtc_libvpx_dir = "//third_party/libvpx"
rtc_opus_dir = "//third_party/opus"
# Desktop capturer is supported only on Windows, OSX and Linux.
rtc_desktop_capture_supported =
(is_win && current_os != "winuwp") || is_mac ||
((is_linux || is_chromeos) && (rtc_use_x11_extensions || rtc_use_pipewire))
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
###############################################################################
# Templates
#
# Points to // in webrtc stand-alone or to //third_party/webrtc/ in
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
# chromium.
# We need absolute paths for all configs in templates as they are shared in
# different subdirectories.
webrtc_root = get_path_info(".", "abspath")
# Global configuration that should be applied to all WebRTC targets.
# You normally shouldn't need to include this in your target as it's
# automatically included when using the rtc_* templates.
# It sets defines, include paths and compilation warnings accordingly,
# both for WebRTC stand-alone builds and for the scenario when WebRTC
# native code is built as part of Chromium.
rtc_common_configs = [ webrtc_root + ":common_config" ]
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
Reland of GN: Enable ARC for Mac and iOS in rtc_* templates (patchset #1 id:1 of https://codereview.webrtc.org/2827223003/ ) Reason for revert: Relanding after fixing ARC issue. Original issue's description: > Revert of GN: Enable ARC for Mac and iOS in rtc_* templates (patchset #3 id:40001 of https://codereview.webrtc.org/2781713004/ ) > > Reason for revert: > Breaks mac build > > Original issue's description: > > GN: Enable ARC for Mac and iOS in rtc_* templates > > > > Remove all uses of retain/release and NSAutoreleasePool. > > > > This makes transformation to Bazel easier. > > > > This CL subsumes https://codereview.webrtc.org/2778163002 and depends on https://codereview.webrtc.org/2784483002/ > > > > BUG=webrtc:6412 > > > > Review-Url: https://codereview.webrtc.org/2781713004 > > Cr-Commit-Position: refs/heads/master@{#17780} > > Committed: https://chromium.googlesource.com/external/webrtc/+/6bda02b51dc00401d2a0d04be996ed10e5acac47 > > TBR=kjellander@webrtc.org,magjed@webrtc.org,stefan@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6412 > > Review-Url: https://codereview.webrtc.org/2827223003 > Cr-Commit-Position: refs/heads/master@{#17784} > Committed: https://chromium.googlesource.com/external/webrtc/+/7c8786ae8f2d8481f74b0ab16eb91a8101fe51dc TBR=kjellander@webrtc.org,magjed@webrtc.org,stefan@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6412 Review-Url: https://codereview.webrtc.org/2834273002 Cr-Commit-Position: refs/heads/master@{#17836}
2017-04-24 00:57:16 -07:00
if (is_mac || is_ios) {
rtc_common_configs += [ "//build/config/compiler:enable_arc" ]
}
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
# Global public configuration that should be applied to all WebRTC targets. You
# normally shouldn't need to include this in your target as it's automatically
# included when using the rtc_* templates. It set the defines, include paths and
# compilation warnings that should be propagated to dependents of the targets
# depending on the target having this config.
rtc_common_inherited_config = webrtc_root + ":common_inherited_config"
# Common configs to remove or add in all rtc targets.
rtc_remove_configs = []
if (!build_with_chromium && is_clang) {
rtc_remove_configs += [ "//build/config/clang:find_bad_constructs" ]
}
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
rtc_add_configs = rtc_common_configs
rtc_prod_configs = [ webrtc_root + ":rtc_prod_config" ]
Reland "Add RTC_EXPORT macro to export WebRTC symbols." This is a reland of 55daf1aef65218a97eff88999e5190a2f2f6b72e. In order to avoid problems on case insensitive file systems this CL moves rtc_export.h to rtc_base/system (avoiding problems with build/). Diff: https://webrtc-review.googlesource.com/c/src/+/100804/1..2. Original change's description: > Add RTC_EXPORT macro to export WebRTC symbols. > > This CL introduces the utility macro RTC_EXPORT which will let WebRTC > developers decide which symbols are supposed to be exported/imported > and which ones are private. > > RTC_EXPORT will only export/import symbols in a component build, more > info: https://cs.chromium.org/chromium/src/docs/component_build.md. > During a component build, the macro COMPONENT_BUILD will be globally > defined in a consistent fashion so it is safe to rely on it to > understand how to expand RTC_EXPORT. > In a non component build, RTC_EXPORT will expand to nothing. > > Bug: webrtc:9419 > Change-Id: Ic58162783be7f5883136ade27f324d6d34fdf932 > Reviewed-on: https://webrtc-review.googlesource.com/97960 > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > Reviewed-by: Niels Moller <nisse@webrtc.org> > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > Reviewed-by: Yves Gerey <yvesg@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#24757} Bug: webrtc:9419 Change-Id: Icfedea5fc3416ea1af2185de443fa879fb2dee8b Reviewed-on: https://webrtc-review.googlesource.com/100804 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24766}
2018-09-18 13:15:54 +02:00
rtc_library_impl_config = [ webrtc_root + ":library_impl_config" ]
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
set_defaults("rtc_test") {
configs = rtc_add_configs
suppressed_configs = []
}
set_defaults("rtc_library") {
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
configs = rtc_add_configs
suppressed_configs = []
absl_deps = []
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
}
set_defaults("rtc_source_set") {
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
configs = rtc_add_configs
suppressed_configs = []
absl_deps = []
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
}
set_defaults("rtc_static_library") {
configs = rtc_add_configs
suppressed_configs = []
absl_deps = []
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
}
set_defaults("rtc_executable") {
configs = rtc_add_configs
suppressed_configs = []
}
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
set_defaults("rtc_shared_library") {
configs = rtc_add_configs
suppressed_configs = []
}
Revert "Revert "GN rtc_* templates: Set default visibility to webrtc_root + "/*""" This reverts commit c73e1f437889d882cbf2987f7fb3a029a6150613. Reason for revert: The problem with failed deps in chrome content/renderer had already been fixed in https://webrtc-review.googlesource.com/c/src/+/38660 Original change's description: > Revert "GN rtc_* templates: Set default visibility to webrtc_root + "/*"" > > This reverts commit 588c548657b3ddf76e7b3f241263eef7f5799f16. > > Reason for revert: > > Breaks Chrome FYI: > > /b/c/b/Linux_Builder/src/buildtools/linux64/gn gen //out/Release --check > -> returned 1 > ERROR at //build/split_static_library.gni:12:5: Dependency not allowed. > static_library(target_name) { > ^---------------------------- > The item //content/renderer:renderer > can not depend on //third_party/webrtc/media:rtc_internal_video_codecs > because it is not in //third_party/webrtc/media:rtc_internal_video_codecs's visibility list: [ > //third_party/webrtc/* > //third_party/webrtc_overrides/* > ] > > https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.webrtc.fyi%2FLinux_Builder%2F23560%2F%2B%2Frecipes%2Fsteps%2Fgenerate_build_files%2F0%2Fstdout > > Original change's description: > > GN rtc_* templates: Set default visibility to webrtc_root + "/*" > > > > This means that by default, targets are visible to everything under > > the WebRTC root, but not visible to anything else. > > > > API targets are manually tagged with visibility "*", so that targets > > outside the WebRTC tree can see them. > > > > BUG=webrtc:8254 > > > > Change-Id: Icdbee6e0d22d93240ff2fb530c8f9dc48e351509 > > Reviewed-on: https://webrtc-review.googlesource.com/24140 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#21548} > > TBR=mbonadei@webrtc.org,kwiberg@webrtc.org > > Change-Id: I06620ce3d6f67482935c22efa231dd6cab91625a > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:8254 > Reviewed-on: https://webrtc-review.googlesource.com/38760 > Reviewed-by: Per Kjellander <perkj@webrtc.org> > Commit-Queue: Per Kjellander <perkj@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#21555} TBR=mbonadei@webrtc.org,kwiberg@webrtc.org,perkj@webrtc.org Change-Id: I6f720078ce21bd172e0a6471bae8c4c011e4a657 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:8254 Reviewed-on: https://webrtc-review.googlesource.com/38860 Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Per Kjellander <perkj@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21558}
2018-01-10 15:54:53 +00:00
webrtc_default_visibility = [ webrtc_root + "/*" ]
if (build_with_chromium) {
# Allow Chromium's WebRTC overrides targets to bypass the regular
# visibility restrictions.
webrtc_default_visibility += [ webrtc_root + "/../webrtc_overrides/*" ]
}
# ---- Poisons ----
#
# The general idea is that some targets declare that they contain some
# kind of poison, which makes it impossible for other targets to
# depend on them (even transitively) unless they declare themselves
# immune to that particular type of poison.
#
# Targets that *contain* poison of type foo should contain the line
#
# poisonous = [ "foo" ]
#
# and targets that *are immune but arent't themselves poisonous*
# should contain
#
# allow_poison = [ "foo" ]
#
# This useful in cases where we have some large target or set of
# targets and want to ensure that most other targets do not
# transitively depend on them. For example, almost no high-level
# target should depend on the audio codecs, since we want WebRTC users
# to be able to inject any subset of them and actually end up with a
# binary that doesn't include the codecs they didn't inject.
#
# Test-only targets (`testonly` set to true) and non-public targets
# (`visibility` not containing "*") are automatically immune to all
# types of poison.
#
# Here's the complete list of all types of poison. It must be kept in
# 1:1 correspondence with the set of //:poison_* targets.
#
all_poison_types = [
# Encoders and decoders for specific audio codecs such as Opus and iSAC.
"audio_codecs",
# Default task queue implementation.
"default_task_queue",
APM: Make echo detector an optionally compilable and injectable component Important: This change does not in any way affect echo cancellation or standardized stats. The user audio experience is unchanged. Only non-standard stats are affected. Echo return loss metrics are unchanged. Residual echo likelihood {recent max} will no longer be computed by default. Important: The echo detector is no longer enabled by default. API change, PSA: https://groups.google.com/g/discuss-webrtc/c/mJV5cDysBDI/m/7PTPBjVHCgAJ This CL removes the default usage of the residual echo detector in APM. It can now only be used via injection and the helper function webrtc::CreateEchoDetector. See how the function audio_processing_unittest.cc:CreateApm() changed, for an example. The echo detector implementation is marked poisonous, to avoid accidental dependencies. Some cleanup is done: - EchoDetector::PackRenderAudioBuffer is declared in one target but is defined in another target. It is not necessary to keep in the API. It is made an implementation detail, and the echo detector input is documented in the API. - The internal state of APM is large and difficult to track. Submodule pointers that are set permanently on construction are now appropriately marked const. Tested: - existing + new unit tests - audioproc_f is bitexact on a large number of aecdumps Bug: webrtc:11539 Change-Id: I00cc2ee112fedb06451a533409311605220064d0 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239652 Reviewed-by: Ivo Creusen <ivoc@webrtc.org> Reviewed-by: Per Kjellander <perkj@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Sam Zackrisson <saza@webrtc.org> Cr-Commit-Position: refs/heads/main@{#35550}
2021-12-06 15:40:04 +01:00
# Default echo detector implementation.
"default_echo_detector",
# JSON parsing should not be needed in the "slim and modular" WebRTC.
"rtc_json",
# Software video codecs (VP8 and VP9 through libvpx).
"software_video_codecs",
]
Reland "Reland "Adding absl includes and defines to rtc_* templates."" This reverts commit 759eb4f2ad7e23b65fe0b834f8ba7f580bf1a933. Reason for revert: The problem has been fixed in https://chromium-review.googlesource.com/1075889. Original change's description: > Revert "Reland "Adding absl includes and defines to rtc_* templates."" > > This reverts commit fae51e4c95780f59f4bedf6e01403ff86152e168. > > Reason for revert: > When use_xcode_clang = true we get: > error: unknown warning option '-Wno-unused-template'; did you mean '-Wno-unused-result'? [-Werror,-Wunknown-warning-option] > error: unknown warning option '-Wno-zero-as-null-pointer-constant'; did you mean '-Wno-int-to-void-pointer-cast'? [-Werror,-Wunknown-warning-option] > > > Original change's description: > > Reland "Adding absl includes and defines to rtc_* templates." > > > > This reverts commit 8436a699a998e4fa30d97786142baad08f110d2a. > > > > Reason for revert: > > New absl roll -> https://chromium-review.googlesource.com/1071468 > > > > Original change's description: > > > Revert "Reland "Adding absl includes and defines to rtc_* templates."" > > > > > > This reverts commit bdb0fe42bc46d190ca45fc5a6658eddbfa5eead5. > > > > > > Reason for revert: https://ci.chromium.org/buildbot/chromium.fyi/Jumbo%20Win%20x64/11502 > > > > > > Original change's description: > > > > Reland "Adding absl includes and defines to rtc_* templates." > > > > > > > > This reverts commit 85cb19fec7caf558dee7a09aafabe01c5ac78f3f. > > > > > > > > Reason for revert: The new version of Abseil should fix the previous > > > > issue. > > > > > > > > Original change's description: > > > > > Revert "Reland "Adding absl includes and defines to rtc_* templates."" > > > > > > > > > > This reverts commit 9632112a16d70a146e917db4de761e6253dfc364. > > > > > > > > > > Reason for revert: It breaks the WebRTC roll into Chromium. > > > > > https://chromium-review.googlesource.com/c/chromium/src/+/1061476 > > > > > > > > > > Original change's description: > > > > > > Reland "Adding absl includes and defines to rtc_* templates." > > > > > > > > > > > > This reverts commit d161eda477491b2b97fb3f26d229c625a2a0e9b8. > > > > > > > > > > > > Reason for revert: The problem with iOS trybots should be fixed. > > > > > > > > > > > > Original change's description: > > > > > > > Revert "Adding absl includes and defines to rtc_* templates." > > > > > > > > > > > > > > This reverts commit 9d8f3850f4c4faad5dc5ab32ab6f2c9c43df7b6c. > > > > > > > > > > > > > > Reason for revert: Breaks some trybots: https://build.chromium.org/p/client.webrtc/builders/iOS64%20Release/builds/12793. > > > > > > > > > > > > > > Original change's description: > > > > > > > > Adding absl includes and defines to rtc_* templates. > > > > > > > > > > > > > > > > This CL implicitly adds the -I compiler flag and absl macros to WebRTC > > > > > > > > templates. In order to include absl headers using relative paths, WebRTC > > > > > > > > needs to ensure that all its build targets are able to see absl headers. > > > > > > > > > > > > > > > > This can also be done with public_deps, but WebRTC is trying to avoid > > > > > > > > it because it creates problems with other build systems. Given this > > > > > > > > constraint, using rtc_* templates is the most reliable solution. > > > > > > > > > > > > > > > > Please note that rtc_* templates are adding absl includes and defines > > > > > > > > as public_configs, this means that build targets with WebRTC targets > > > > > > > > in their public_deps will propagate these configs following the GN > > > > > > > > guideline. > > > > > > > > > > > > > > > > Bug: webrtc:8821 > > > > > > > > Change-Id: I4aa594a524f4bd045bcb3e80d76cc27f06fe01d7 > > > > > > > > Reviewed-on: https://webrtc-review.googlesource.com/70367 > > > > > > > > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > > > > > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > > > > > Cr-Commit-Position: refs/heads/master@{#22927} > > > > > > > > > > > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > > > > > > > > > > > Change-Id: Id8e1f881c57553386566eb1970f6b9f8632cab37 > > > > > > > No-Presubmit: true > > > > > > > No-Tree-Checks: true > > > > > > > No-Try: true > > > > > > > Bug: webrtc:8821 > > > > > > > Reviewed-on: https://webrtc-review.googlesource.com/71000 > > > > > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > > > > Cr-Commit-Position: refs/heads/master@{#22928} > > > > > > > > > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > > > > > > > > > Bug: webrtc:8821 > > > > > > Change-Id: I6ee2eda97bbcd4c9be25c9c4073272192b0373f8 > > > > > > Reviewed-on: https://webrtc-review.googlesource.com/71700 > > > > > > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > > > > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > > > Cr-Commit-Position: refs/heads/master@{#23251} > > > > > > > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > > > > > > > Change-Id: I61fb749797314ca514691b341c66f7f39ef45491 > > > > > No-Presubmit: true > > > > > No-Tree-Checks: true > > > > > No-Try: true > > > > > Bug: webrtc:8821 > > > > > Reviewed-on: https://webrtc-review.googlesource.com/77220 > > > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > > Cr-Commit-Position: refs/heads/master@{#23264} > > > > > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > > > > > Bug: webrtc:8821 > > > > Change-Id: I71dea953a002a0d526949c627653bcad0c6518fc > > > > Reviewed-on: https://webrtc-review.googlesource.com/77781 > > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > Cr-Commit-Position: refs/heads/master@{#23317} > > > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > > > Change-Id: I6010f9264dba7bcc4e82c4f4bbfb2eca561e500e > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: webrtc:8821, chromium:845158 > > > Reviewed-on: https://webrtc-review.googlesource.com/78061 > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > Cr-Commit-Position: refs/heads/master@{#23328} > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: webrtc:8821, chromium:845158 > > Change-Id: Iebe0958012c39e1321487e5425f43904eaf5fe91 > > Reviewed-on: https://webrtc-review.googlesource.com/78705 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#23403} > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > Change-Id: I8285cf59402aa6862ea7e3ec21f885360b7050fb > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:8821, chromium:845158 > Reviewed-on: https://webrtc-review.googlesource.com/79420 > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#23416} TBR=phoglund@webrtc.org,mbonadei@webrtc.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: webrtc:8821, chromium:845158 Change-Id: I18ffdb0d7be61daf0b6464c68d219aa352f42dde Reviewed-on: https://webrtc-review.googlesource.com/79582 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23435}
2018-05-29 14:22:32 +00:00
absl_include_config = "//third_party/abseil-cpp:absl_include_config"
absl_define_config = "//third_party/abseil-cpp:absl_define_config"
# Abseil Flags are testonly, so this config will only be applied to WebRTC targets
# that are testonly.
absl_flags_config = webrtc_root + ":absl_flags_configs"
Build and run iOS tests as XCTests. After upgrading to xcode 12, some Gtest tests have started to randomly fail. The solution around this problem is to build and run GTests as XCTests. In order to achieve that, the CL sets enable_run_ios_unittests_with_xctest to true in all iOS builds and adds a dependency on //base/test:google_test_runner for each Gtest that needs to run as an XCTest. Real XCTest don't need the dependency and they are marked with the rtc_test() argument `is_xctest=true` (apprtcmobile_tests, sdk_unittests and sdk_framework_unittests). This CL is based on [1] which passes --xctest to the runner and uses --undefok to avoid to crash when absl/flags doesn't recognize the flag --enable-run-ios-unittests-with-xctest (absl/flags cannot have "-" in flags so WebRTC binaries cannot define that flag). To workaround the issue, WebRTC tests always behave like --enable-run-ios-unittests-with-xctest is always set (by linking only with //base/test:google_test_runner to run iOS tests). This fixes iOS12 and iOS13 tests but not iOS14 on which some tests are failing because of restricted access to resources (this will be addressed in another CL). Long term, this solution might cause problems when Chromium decides to update test() GN template and/or the test launcher, so WebRTC should plan a better integration with Chromium's iOS infra. [1] - https://chromium-review.googlesource.com/c/chromium/tools/build/+/2550656 Bug: webrtc:12134 Change-Id: I24c731dee0310e02ae1bbe6c23d359d6fcd18f17 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193620 Reviewed-by: Jeremy Leconte <jleconte@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32716}
2020-11-25 16:41:37 +01:00
# WebRTC wrapper of Chromium's test() template. This template just adds some
# WebRTC only configuration in order to avoid to duplicate it for every WebRTC
# target.
# The parameter `is_xctest` is different from the one in the Chromium's test()
# template (and it is not forwarded to it). In rtc_test(), the argument
# `is_xctest` is used to avoid to take dependencies that are not needed
# in case the test is a real XCTest (using the XCTest framework).
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
template("rtc_test") {
test(target_name) {
forward_variables_from(invoker,
"*",
[
"configs",
Build and run iOS tests as XCTests. After upgrading to xcode 12, some Gtest tests have started to randomly fail. The solution around this problem is to build and run GTests as XCTests. In order to achieve that, the CL sets enable_run_ios_unittests_with_xctest to true in all iOS builds and adds a dependency on //base/test:google_test_runner for each Gtest that needs to run as an XCTest. Real XCTest don't need the dependency and they are marked with the rtc_test() argument `is_xctest=true` (apprtcmobile_tests, sdk_unittests and sdk_framework_unittests). This CL is based on [1] which passes --xctest to the runner and uses --undefok to avoid to crash when absl/flags doesn't recognize the flag --enable-run-ios-unittests-with-xctest (absl/flags cannot have "-" in flags so WebRTC binaries cannot define that flag). To workaround the issue, WebRTC tests always behave like --enable-run-ios-unittests-with-xctest is always set (by linking only with //base/test:google_test_runner to run iOS tests). This fixes iOS12 and iOS13 tests but not iOS14 on which some tests are failing because of restricted access to resources (this will be addressed in another CL). Long term, this solution might cause problems when Chromium decides to update test() GN template and/or the test launcher, so WebRTC should plan a better integration with Chromium's iOS infra. [1] - https://chromium-review.googlesource.com/c/chromium/tools/build/+/2550656 Bug: webrtc:12134 Change-Id: I24c731dee0310e02ae1bbe6c23d359d6fcd18f17 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193620 Reviewed-by: Jeremy Leconte <jleconte@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32716}
2020-11-25 16:41:37 +01:00
"is_xctest",
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
"public_configs",
"suppressed_configs",
"visibility",
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
])
# Always override to public because when target_os is Android the `test`
# template can override it to [ "*" ] and we want to avoid conditional
# visibility.
visibility = [ "*" ]
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
configs += invoker.configs
configs -= rtc_remove_configs
configs -= invoker.suppressed_configs
Reland "Reland "Adding absl includes and defines to rtc_* templates."" This reverts commit 759eb4f2ad7e23b65fe0b834f8ba7f580bf1a933. Reason for revert: The problem has been fixed in https://chromium-review.googlesource.com/1075889. Original change's description: > Revert "Reland "Adding absl includes and defines to rtc_* templates."" > > This reverts commit fae51e4c95780f59f4bedf6e01403ff86152e168. > > Reason for revert: > When use_xcode_clang = true we get: > error: unknown warning option '-Wno-unused-template'; did you mean '-Wno-unused-result'? [-Werror,-Wunknown-warning-option] > error: unknown warning option '-Wno-zero-as-null-pointer-constant'; did you mean '-Wno-int-to-void-pointer-cast'? [-Werror,-Wunknown-warning-option] > > > Original change's description: > > Reland "Adding absl includes and defines to rtc_* templates." > > > > This reverts commit 8436a699a998e4fa30d97786142baad08f110d2a. > > > > Reason for revert: > > New absl roll -> https://chromium-review.googlesource.com/1071468 > > > > Original change's description: > > > Revert "Reland "Adding absl includes and defines to rtc_* templates."" > > > > > > This reverts commit bdb0fe42bc46d190ca45fc5a6658eddbfa5eead5. > > > > > > Reason for revert: https://ci.chromium.org/buildbot/chromium.fyi/Jumbo%20Win%20x64/11502 > > > > > > Original change's description: > > > > Reland "Adding absl includes and defines to rtc_* templates." > > > > > > > > This reverts commit 85cb19fec7caf558dee7a09aafabe01c5ac78f3f. > > > > > > > > Reason for revert: The new version of Abseil should fix the previous > > > > issue. > > > > > > > > Original change's description: > > > > > Revert "Reland "Adding absl includes and defines to rtc_* templates."" > > > > > > > > > > This reverts commit 9632112a16d70a146e917db4de761e6253dfc364. > > > > > > > > > > Reason for revert: It breaks the WebRTC roll into Chromium. > > > > > https://chromium-review.googlesource.com/c/chromium/src/+/1061476 > > > > > > > > > > Original change's description: > > > > > > Reland "Adding absl includes and defines to rtc_* templates." > > > > > > > > > > > > This reverts commit d161eda477491b2b97fb3f26d229c625a2a0e9b8. > > > > > > > > > > > > Reason for revert: The problem with iOS trybots should be fixed. > > > > > > > > > > > > Original change's description: > > > > > > > Revert "Adding absl includes and defines to rtc_* templates." > > > > > > > > > > > > > > This reverts commit 9d8f3850f4c4faad5dc5ab32ab6f2c9c43df7b6c. > > > > > > > > > > > > > > Reason for revert: Breaks some trybots: https://build.chromium.org/p/client.webrtc/builders/iOS64%20Release/builds/12793. > > > > > > > > > > > > > > Original change's description: > > > > > > > > Adding absl includes and defines to rtc_* templates. > > > > > > > > > > > > > > > > This CL implicitly adds the -I compiler flag and absl macros to WebRTC > > > > > > > > templates. In order to include absl headers using relative paths, WebRTC > > > > > > > > needs to ensure that all its build targets are able to see absl headers. > > > > > > > > > > > > > > > > This can also be done with public_deps, but WebRTC is trying to avoid > > > > > > > > it because it creates problems with other build systems. Given this > > > > > > > > constraint, using rtc_* templates is the most reliable solution. > > > > > > > > > > > > > > > > Please note that rtc_* templates are adding absl includes and defines > > > > > > > > as public_configs, this means that build targets with WebRTC targets > > > > > > > > in their public_deps will propagate these configs following the GN > > > > > > > > guideline. > > > > > > > > > > > > > > > > Bug: webrtc:8821 > > > > > > > > Change-Id: I4aa594a524f4bd045bcb3e80d76cc27f06fe01d7 > > > > > > > > Reviewed-on: https://webrtc-review.googlesource.com/70367 > > > > > > > > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > > > > > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > > > > > Cr-Commit-Position: refs/heads/master@{#22927} > > > > > > > > > > > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > > > > > > > > > > > Change-Id: Id8e1f881c57553386566eb1970f6b9f8632cab37 > > > > > > > No-Presubmit: true > > > > > > > No-Tree-Checks: true > > > > > > > No-Try: true > > > > > > > Bug: webrtc:8821 > > > > > > > Reviewed-on: https://webrtc-review.googlesource.com/71000 > > > > > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > > > > Cr-Commit-Position: refs/heads/master@{#22928} > > > > > > > > > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > > > > > > > > > Bug: webrtc:8821 > > > > > > Change-Id: I6ee2eda97bbcd4c9be25c9c4073272192b0373f8 > > > > > > Reviewed-on: https://webrtc-review.googlesource.com/71700 > > > > > > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > > > > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > > > Cr-Commit-Position: refs/heads/master@{#23251} > > > > > > > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > > > > > > > Change-Id: I61fb749797314ca514691b341c66f7f39ef45491 > > > > > No-Presubmit: true > > > > > No-Tree-Checks: true > > > > > No-Try: true > > > > > Bug: webrtc:8821 > > > > > Reviewed-on: https://webrtc-review.googlesource.com/77220 > > > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > > Cr-Commit-Position: refs/heads/master@{#23264} > > > > > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > > > > > Bug: webrtc:8821 > > > > Change-Id: I71dea953a002a0d526949c627653bcad0c6518fc > > > > Reviewed-on: https://webrtc-review.googlesource.com/77781 > > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > Cr-Commit-Position: refs/heads/master@{#23317} > > > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > > > Change-Id: I6010f9264dba7bcc4e82c4f4bbfb2eca561e500e > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: webrtc:8821, chromium:845158 > > > Reviewed-on: https://webrtc-review.googlesource.com/78061 > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > Cr-Commit-Position: refs/heads/master@{#23328} > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: webrtc:8821, chromium:845158 > > Change-Id: Iebe0958012c39e1321487e5425f43904eaf5fe91 > > Reviewed-on: https://webrtc-review.googlesource.com/78705 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#23403} > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > Change-Id: I8285cf59402aa6862ea7e3ec21f885360b7050fb > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:8821, chromium:845158 > Reviewed-on: https://webrtc-review.googlesource.com/79420 > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#23416} TBR=phoglund@webrtc.org,mbonadei@webrtc.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: webrtc:8821, chromium:845158 Change-Id: I18ffdb0d7be61daf0b6464c68d219aa352f42dde Reviewed-on: https://webrtc-review.googlesource.com/79582 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23435}
2018-05-29 14:22:32 +00:00
public_configs = [
rtc_common_inherited_config,
absl_include_config,
absl_define_config,
absl_flags_config,
Reland "Reland "Adding absl includes and defines to rtc_* templates."" This reverts commit 759eb4f2ad7e23b65fe0b834f8ba7f580bf1a933. Reason for revert: The problem has been fixed in https://chromium-review.googlesource.com/1075889. Original change's description: > Revert "Reland "Adding absl includes and defines to rtc_* templates."" > > This reverts commit fae51e4c95780f59f4bedf6e01403ff86152e168. > > Reason for revert: > When use_xcode_clang = true we get: > error: unknown warning option '-Wno-unused-template'; did you mean '-Wno-unused-result'? [-Werror,-Wunknown-warning-option] > error: unknown warning option '-Wno-zero-as-null-pointer-constant'; did you mean '-Wno-int-to-void-pointer-cast'? [-Werror,-Wunknown-warning-option] > > > Original change's description: > > Reland "Adding absl includes and defines to rtc_* templates." > > > > This reverts commit 8436a699a998e4fa30d97786142baad08f110d2a. > > > > Reason for revert: > > New absl roll -> https://chromium-review.googlesource.com/1071468 > > > > Original change's description: > > > Revert "Reland "Adding absl includes and defines to rtc_* templates."" > > > > > > This reverts commit bdb0fe42bc46d190ca45fc5a6658eddbfa5eead5. > > > > > > Reason for revert: https://ci.chromium.org/buildbot/chromium.fyi/Jumbo%20Win%20x64/11502 > > > > > > Original change's description: > > > > Reland "Adding absl includes and defines to rtc_* templates." > > > > > > > > This reverts commit 85cb19fec7caf558dee7a09aafabe01c5ac78f3f. > > > > > > > > Reason for revert: The new version of Abseil should fix the previous > > > > issue. > > > > > > > > Original change's description: > > > > > Revert "Reland "Adding absl includes and defines to rtc_* templates."" > > > > > > > > > > This reverts commit 9632112a16d70a146e917db4de761e6253dfc364. > > > > > > > > > > Reason for revert: It breaks the WebRTC roll into Chromium. > > > > > https://chromium-review.googlesource.com/c/chromium/src/+/1061476 > > > > > > > > > > Original change's description: > > > > > > Reland "Adding absl includes and defines to rtc_* templates." > > > > > > > > > > > > This reverts commit d161eda477491b2b97fb3f26d229c625a2a0e9b8. > > > > > > > > > > > > Reason for revert: The problem with iOS trybots should be fixed. > > > > > > > > > > > > Original change's description: > > > > > > > Revert "Adding absl includes and defines to rtc_* templates." > > > > > > > > > > > > > > This reverts commit 9d8f3850f4c4faad5dc5ab32ab6f2c9c43df7b6c. > > > > > > > > > > > > > > Reason for revert: Breaks some trybots: https://build.chromium.org/p/client.webrtc/builders/iOS64%20Release/builds/12793. > > > > > > > > > > > > > > Original change's description: > > > > > > > > Adding absl includes and defines to rtc_* templates. > > > > > > > > > > > > > > > > This CL implicitly adds the -I compiler flag and absl macros to WebRTC > > > > > > > > templates. In order to include absl headers using relative paths, WebRTC > > > > > > > > needs to ensure that all its build targets are able to see absl headers. > > > > > > > > > > > > > > > > This can also be done with public_deps, but WebRTC is trying to avoid > > > > > > > > it because it creates problems with other build systems. Given this > > > > > > > > constraint, using rtc_* templates is the most reliable solution. > > > > > > > > > > > > > > > > Please note that rtc_* templates are adding absl includes and defines > > > > > > > > as public_configs, this means that build targets with WebRTC targets > > > > > > > > in their public_deps will propagate these configs following the GN > > > > > > > > guideline. > > > > > > > > > > > > > > > > Bug: webrtc:8821 > > > > > > > > Change-Id: I4aa594a524f4bd045bcb3e80d76cc27f06fe01d7 > > > > > > > > Reviewed-on: https://webrtc-review.googlesource.com/70367 > > > > > > > > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > > > > > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > > > > > Cr-Commit-Position: refs/heads/master@{#22927} > > > > > > > > > > > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > > > > > > > > > > > Change-Id: Id8e1f881c57553386566eb1970f6b9f8632cab37 > > > > > > > No-Presubmit: true > > > > > > > No-Tree-Checks: true > > > > > > > No-Try: true > > > > > > > Bug: webrtc:8821 > > > > > > > Reviewed-on: https://webrtc-review.googlesource.com/71000 > > > > > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > > > > Cr-Commit-Position: refs/heads/master@{#22928} > > > > > > > > > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > > > > > > > > > Bug: webrtc:8821 > > > > > > Change-Id: I6ee2eda97bbcd4c9be25c9c4073272192b0373f8 > > > > > > Reviewed-on: https://webrtc-review.googlesource.com/71700 > > > > > > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > > > > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > > > Cr-Commit-Position: refs/heads/master@{#23251} > > > > > > > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > > > > > > > Change-Id: I61fb749797314ca514691b341c66f7f39ef45491 > > > > > No-Presubmit: true > > > > > No-Tree-Checks: true > > > > > No-Try: true > > > > > Bug: webrtc:8821 > > > > > Reviewed-on: https://webrtc-review.googlesource.com/77220 > > > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > > Cr-Commit-Position: refs/heads/master@{#23264} > > > > > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > > > > > Bug: webrtc:8821 > > > > Change-Id: I71dea953a002a0d526949c627653bcad0c6518fc > > > > Reviewed-on: https://webrtc-review.googlesource.com/77781 > > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > Cr-Commit-Position: refs/heads/master@{#23317} > > > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > > > Change-Id: I6010f9264dba7bcc4e82c4f4bbfb2eca561e500e > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: webrtc:8821, chromium:845158 > > > Reviewed-on: https://webrtc-review.googlesource.com/78061 > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > Cr-Commit-Position: refs/heads/master@{#23328} > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: webrtc:8821, chromium:845158 > > Change-Id: Iebe0958012c39e1321487e5425f43904eaf5fe91 > > Reviewed-on: https://webrtc-review.googlesource.com/78705 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#23403} > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > Change-Id: I8285cf59402aa6862ea7e3ec21f885360b7050fb > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:8821, chromium:845158 > Reviewed-on: https://webrtc-review.googlesource.com/79420 > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#23416} TBR=phoglund@webrtc.org,mbonadei@webrtc.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: webrtc:8821, chromium:845158 Change-Id: I18ffdb0d7be61daf0b6464c68d219aa352f42dde Reviewed-on: https://webrtc-review.googlesource.com/79582 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23435}
2018-05-29 14:22:32 +00:00
]
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
if (defined(invoker.public_configs)) {
public_configs += invoker.public_configs
}
if (!build_with_chromium && is_android) {
android_manifest = webrtc_root + "test/android/AndroidManifest.xml"
use_raw_android_executable = false
Roll chromium_revision 4d95e6c77b..71a0e1904e (776481:782339) Change log: https://chromium.googlesource.com/chromium/src/+log/4d95e6c77b..71a0e1904e Full diff: https://chromium.googlesource.com/chromium/src/+/4d95e6c77b..71a0e1904e Changed dependencies * src/base: https://chromium.googlesource.com/chromium/src/base/+log/2df7267880..736d9fb42c * src/build: https://chromium.googlesource.com/chromium/src/build/+log/a03951acb9..876a780600 * src/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/1b066f0216..1ed99573d5 * src/buildtools/linux64: git_revision:d0a6f072070988e7b038496c4e7d6c562b649732..git_revision:7d7e8deea36d126397bda2cf924682504271f0e1 * src/buildtools/mac: git_revision:d0a6f072070988e7b038496c4e7d6c562b649732..git_revision:7d7e8deea36d126397bda2cf924682504271f0e1 * src/buildtools/win: git_revision:d0a6f072070988e7b038496c4e7d6c562b649732..git_revision:7d7e8deea36d126397bda2cf924682504271f0e1 * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/9200aad36b..73c8bcb1b1 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/502600d41a..77ba7104d5 * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/e0df6e10ad..1908162da7 * src/third_party/android_deps/libs/androidx_activity_activity: version:1.0.0-cr0..version:1.1.0-cr0 * src/third_party/android_deps/libs/androidx_arch_core_core_runtime: version:2.0.0-cr0..version:2.1.0-cr0 * src/third_party/android_deps/libs/androidx_fragment_fragment: version:1.1.0-cr0..version:1.2.5-cr0 * src/third_party/android_deps/libs/androidx_lifecycle_lifecycle_common: version:2.1.0-cr0..version:2.2.0-cr0 * src/third_party/android_deps/libs/androidx_lifecycle_lifecycle_livedata_core: version:2.0.0-cr0..version:2.2.0-cr0 * src/third_party/android_deps/libs/androidx_lifecycle_lifecycle_runtime: version:2.1.0-cr0..version:2.2.0-cr0 * src/third_party/android_deps/libs/androidx_lifecycle_lifecycle_viewmodel: version:2.1.0-cr0..version:2.2.0-cr0 * src/third_party/android_deps/libs/androidx_preference_preference: version:1.0.0-cr0..version:1.1.1-cr0 * src/third_party/android_deps/libs/org_robolectric_shadows_multidex: version:4.3.1-cr0..version:4.3.1-cr1 * src/third_party/android_sdk/public: CR25ixsRhwuRnhdgDpGFyl9S0C_0HO9SUgFrwX46zq8C..uM0XtAW9BHh8phcbhBDA9GfzP3bku2SP7AiMahhimnoC * src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/88024df121..430a742303 * src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/2ad47493f8..e0658a4adf * src/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/37e562110f..87c8b91639 * src/third_party/espresso: c92dcfc4e894555a0b3c309f2b7939640eb1fee4..y8fIfH8Leo2cPm7iGCYnBxZpwOlgLv8rm2mlcmJlvGsC * src/third_party/ffmpeg: https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/be66dc5fd0..23b2a15c25 * src/third_party/freetype/src: https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/62fea391fa..a443474755 * src/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu.git/+log/630b884f84..79326efe26 * src/third_party/libaom/source/libaom: https://aomedia.googlesource.com/aom.git/+log/2aa13c436e..e1ebb418eb * src/third_party/libunwindstack: https://chromium.googlesource.com/chromium/src/third_party/libunwindstack.git/+log/046920fc49..11659d420a * src/third_party/libvpx/source/libvpx: https://chromium.googlesource.com/webm/libvpx.git/+log/c176557314..769129fb29 * src/third_party/perfetto: https://android.googlesource.com/platform/external/perfetto.git/+log/60cf022c02..44e38c4643 * src/third_party/r8: gobCh01BNwJNyLHHNFUmLWSMaAbe4x3izuzBFzxQpDoC..B467c9t23JiW_6XGqhvHvtEKWSkrPS2xG_gho_gbAI4C * src/third_party/turbine: 3UJ600difG3ThRhtYrN9AfZ5kh8wCYtBiii1-NMlCrMC..mr9FyghUYWLYv4L5Nr3C_oceLfmmybnFgAi366GjQoYC * src/third_party/turbine/src: https://chromium.googlesource.com/external/github.com/google/turbine.git/+log/95f6fb6f1e..1c98ea6854 * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/050a4a5e26..d6998993f9 Added dependency * src/third_party/android_deps/libs/androidx_lifecycle_lifecycle_viewmodel_savedstate DEPS diff: https://chromium.googlesource.com/chromium/src/+/4d95e6c77b..71a0e1904e/DEPS Clang version changed f7f1abdb8893af4a606ca1a8f5347a426e9c7f9e:4e813bbdf Details: https://chromium.googlesource.com/chromium/src/+/4d95e6c77b..71a0e1904e/tools/clang/scripts/update.py TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,marpan@webrtc.org, jianj@chromium.org, BUG=None Change-Id: Idb4a2ccc6eab502ecf78b34247a479ff5726b50a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178084 Reviewed-by: Jeremy Leconte <jleconte@google.com> Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#31569}
2020-06-25 22:57:49 +02:00
min_sdk_version = 21
target_sdk_version = 23
Roll chromium_revision 34f3c82122..2dffe06711 (867171:871492) Change log: https://chromium.googlesource.com/chromium/src/+log/34f3c82122..2dffe06711 Full diff: https://chromium.googlesource.com/chromium/src/+/34f3c82122..2dffe06711 Changed dependencies * src/base: https://chromium.googlesource.com/chromium/src/base/+log/cbc66d2601..db151ac5c5 * src/build: https://chromium.googlesource.com/chromium/src/build/+log/0cea8e20fb..399fa5ad74 * src/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/99a2527e91..5dbd89c9d9 * src/buildtools/linux64: git_revision:b2e3d8622c1ce1bd853c7a11f62a739946669cdd..git_revision:dba01723a441c358d843a575cb7720d54ddcdf92 * src/buildtools/mac: git_revision:b2e3d8622c1ce1bd853c7a11f62a739946669cdd..git_revision:dba01723a441c358d843a575cb7720d54ddcdf92 * src/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/cbf9455e83..d0f33885a2 * src/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/cc80b4ac98..08f35c8514 * src/buildtools/win: git_revision:b2e3d8622c1ce1bd853c7a11f62a739946669cdd..git_revision:dba01723a441c358d843a575cb7720d54ddcdf92 * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/b106ab6171..3ba3cf8e84 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/9511ad8751..85de9f3f89 * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/d4a93a19d0..32fe4ba2c6 * src/third_party/android_deps/libs/android_arch_core_common: version:1.1.1.cr0..version:2@1.1.1.cr0 * src/third_party/android_deps/libs/android_arch_core_runtime: version:1.1.1.cr0..version:2@1.1.1.cr0 * src/third_party/android_deps/libs/android_arch_lifecycle_common: version:1.1.1.cr0..version:2@1.1.1.cr0 * src/third_party/android_deps/libs/android_arch_lifecycle_common_java8: version:1.1.1.cr0..version:2@1.1.1.cr0 * src/third_party/android_deps/libs/android_arch_lifecycle_livedata: version:1.1.1.cr0..version:2@1.1.1.cr0 * src/third_party/android_deps/libs/android_arch_lifecycle_livedata_core: version:1.1.1.cr0..version:2@1.1.1.cr0 * src/third_party/android_deps/libs/android_arch_lifecycle_runtime: version:1.1.1.cr0..version:2@1.1.1.cr0 * src/third_party/android_deps/libs/android_arch_lifecycle_viewmodel: version:1.1.1.cr0..version:2@1.1.1.cr0 * src/third_party/android_deps/libs/backport_util_concurrent_backport_util_concurrent: version:3.1.cr0..version:2@3.1.cr0 * src/third_party/android_deps/libs/classworlds_classworlds: version:1.1-alpha-2.cr0..version:2@1.1-alpha-2.cr0 * src/third_party/android_deps/libs/com_android_support_animated_vector_drawable: version:28.0.0.cr0..version:2@28.0.0.cr0 * src/third_party/android_deps/libs/com_android_support_appcompat_v7: version:28.0.0.cr0..version:2@28.0.0.cr0 * src/third_party/android_deps/libs/com_android_support_asynclayoutinflater: version:28.0.0.cr0..version:2@28.0.0.cr0 * src/third_party/android_deps/libs/com_android_support_cardview_v7: version:28.0.0.cr0..version:2@28.0.0.cr0 * src/third_party/android_deps/libs/com_android_support_collections: version:28.0.0.cr0..version:2@28.0.0.cr0 * src/third_party/android_deps/libs/com_android_support_coordinatorlayout: version:28.0.0.cr0..version:2@28.0.0.cr0 * src/third_party/android_deps/libs/com_android_support_cursoradapter: version:28.0.0.cr0..version:2@28.0.0.cr0 * src/third_party/android_deps/libs/com_android_support_customview: version:28.0.0.cr0..version:2@28.0.0.cr0 * src/third_party/android_deps/libs/com_android_support_design: version:28.0.0.cr0..version:2@28.0.0.cr0 * src/third_party/android_deps/libs/com_android_support_documentfile: version:28.0.0.cr0..version:2@28.0.0.cr0 * src/third_party/android_deps/libs/com_android_support_drawerlayout: version:28.0.0.cr0..version:2@28.0.0.cr0 * src/third_party/android_deps/libs/com_android_support_interpolator: version:28.0.0.cr0..version:2@28.0.0.cr0 * src/third_party/android_deps/libs/com_android_support_loader: version:28.0.0.cr0..version:2@28.0.0.cr0 * src/third_party/android_deps/libs/com_android_support_localbroadcastmanager: version:28.0.0.cr0..version:2@28.0.0.cr0 * src/third_party/android_deps/libs/com_android_support_multidex: version:1.0.0.cr0..version:2@1.0.0.cr0 * src/third_party/android_deps/libs/com_android_support_print: version:28.0.0.cr0..version:2@28.0.0.cr0 * src/third_party/android_deps/libs/com_android_support_recyclerview_v7: version:28.0.0.cr0..version:2@28.0.0.cr0 * src/third_party/android_deps/libs/com_android_support_slidingpanelayout: version:28.0.0.cr0..version:2@28.0.0.cr0 * src/third_party/android_deps/libs/com_android_support_support_annotations: version:28.0.0.cr0..version:2@28.0.0.cr0 * src/third_party/android_deps/libs/com_android_support_support_compat: version:28.0.0.cr0..version:2@28.0.0.cr0 * src/third_party/android_deps/libs/com_android_support_support_core_ui: version:28.0.0.cr0..version:2@28.0.0.cr0 * src/third_party/android_deps/libs/com_android_support_support_core_utils: version:28.0.0.cr0..version:2@28.0.0.cr0 * src/third_party/android_deps/libs/com_android_support_support_fragment: version:28.0.0.cr0..version:2@28.0.0.cr0 * src/third_party/android_deps/libs/com_android_support_support_media_compat: version:28.0.0.cr0..version:2@28.0.0.cr0 * src/third_party/android_deps/libs/com_android_support_support_v4: version:28.0.0.cr0..version:2@28.0.0.cr0 * src/third_party/android_deps/libs/com_android_support_support_vector_drawable: version:28.0.0.cr0..version:2@28.0.0.cr0 * src/third_party/android_deps/libs/com_android_support_swiperefreshlayout: version:28.0.0.cr0..version:2@28.0.0.cr0 * src/third_party/android_deps/libs/com_android_support_transition: version:28.0.0.cr0..version:2@28.0.0.cr0 * src/third_party/android_deps/libs/com_android_support_versionedparcelable: version:28.0.0.cr0..version:2@28.0.0.cr0 * src/third_party/android_deps/libs/com_android_support_viewpager: version:28.0.0.cr0..version:2@28.0.0.cr0 * src/third_party/android_deps/libs/com_android_tools_desugar_jdk_libs: version:1.1.1.cr0..version:2@1.1.1.cr0 * src/third_party/android_deps/libs/com_android_tools_desugar_jdk_libs_configuration: version:1.1.1.cr0..version:2@1.1.1.cr0 * src/third_party/android_deps/libs/com_github_ben_manes_caffeine_caffeine: version:2.8.0.cr0..version:2@2.8.0.cr0 * src/third_party/android_deps/libs/com_github_kevinstern_software_and_algorithms: version:1.0.cr0..version:2@1.0.cr0 * src/third_party/android_deps/libs/com_google_android_datatransport_transport_api: version:2.2.1.cr0..version:2@2.2.1.cr0 * src/third_party/android_deps/libs/com_google_android_gms_play_services_auth: version:17.0.0.cr0..version:2@17.0.0.cr0 * src/third_party/android_deps/libs/com_google_android_gms_play_services_auth_api_phone: version:17.5.0.cr0..version:2@17.5.0.cr0 * src/third_party/android_deps/libs/com_google_android_gms_play_services_auth_base: version:17.0.0.cr0..version:2@17.0.0.cr0 * src/third_party/android_deps/libs/com_google_android_gms_play_services_base: version:17.5.0.cr0..version:2@17.5.0.cr0 * src/third_party/android_deps/libs/com_google_android_gms_play_services_basement: version:17.5.0.cr0..version:2@17.5.0.cr0 * src/third_party/android_deps/libs/com_google_android_gms_play_services_cast: version:17.0.0.cr0..version:2@17.0.0.cr0 * src/third_party/android_deps/libs/com_google_android_gms_play_services_cast_framework: version:17.0.0.cr0..version:2@17.0.0.cr0 * src/third_party/android_deps/libs/com_google_android_gms_play_services_clearcut: version:17.0.0.cr0..version:2@17.0.0.cr0 * src/third_party/android_deps/libs/com_google_android_gms_play_services_cloud_messaging: version:16.0.0.cr0..version:2@16.0.0.cr0 * src/third_party/android_deps/libs/com_google_android_gms_play_services_fido: version:19.0.0-beta.cr0..version:2@19.0.0-beta.cr0 * src/third_party/android_deps/libs/com_google_android_gms_play_services_flags: version:17.0.0.cr0..version:2@17.0.0.cr0 * src/third_party/android_deps/libs/com_google_android_gms_play_services_gcm: version:17.0.0.cr0..version:2@17.0.0.cr0 * src/third_party/android_deps/libs/com_google_android_gms_play_services_iid: version:17.0.0.cr0..version:2@17.0.0.cr0 * src/third_party/android_deps/libs/com_google_android_gms_play_services_instantapps: version:17.0.0.cr0..version:2@17.0.0.cr0 * src/third_party/android_deps/libs/com_google_android_gms_play_services_location: version:17.0.0.cr0..version:2@17.0.0.cr0 * src/third_party/android_deps/libs/com_google_android_gms_play_services_phenotype: version:17.0.0.cr0..version:2@17.0.0.cr0 * src/third_party/android_deps/libs/com_google_android_gms_play_services_places_placereport: version:17.0.0.cr0..version:2@17.0.0.cr0 * src/third_party/android_deps/libs/com_google_android_gms_play_services_stats: version:17.0.0.cr0..version:2@17.0.0.cr0 * src/third_party/android_deps/libs/com_google_android_gms_play_services_tasks: version:17.2.0.cr0..version:2@17.2.0.cr0 * src/third_party/android_deps/libs/com_google_android_gms_play_services_vision: version:18.0.0.cr0..version:2@18.0.0.cr0 * src/third_party/android_deps/libs/com_google_android_gms_play_services_vision_common: version:18.0.0.cr0..version:2@18.0.0.cr0 * src/third_party/android_deps/libs/com_google_android_material_material: version:1.2.0-alpha06.cr0..version:2@1.2.0-alpha06.cr0 * src/third_party/android_deps/libs/com_google_auto_auto_common: version:0.10.cr0..version:2@0.10.cr0 * src/third_party/android_deps/libs/com_google_auto_service_auto_service: version:1.0-rc6.cr0..version:2@1.0-rc6.cr0 * src/third_party/android_deps/libs/com_google_auto_service_auto_service_annotations: version:1.0-rc6.cr0..version:2@1.0-rc6.cr0 * src/third_party/android_deps/libs/com_google_auto_value_auto_value_annotations: version:1.7.cr0..version:2@1.7.cr0 * src/third_party/android_deps/libs/com_google_code_findbugs_jformatstring: version:3.0.0.cr0..version:2@3.0.0.cr0 * src/third_party/android_deps/libs/com_google_code_findbugs_jsr305: version:3.0.2.cr0..version:2@3.0.2.cr0 * src/third_party/android_deps/libs/com_google_code_gson_gson: version:2.8.0.cr0..version:2@2.8.0.cr0 * src/third_party/android_deps/libs/com_google_dagger_dagger: version:2.30.cr0..version:2@2.30.cr0 * src/third_party/android_deps/libs/com_google_dagger_dagger_compiler: version:2.30.cr0..version:2@2.30.cr0 * src/third_party/android_deps/libs/com_google_dagger_dagger_producers: version:2.30.cr0..version:2@2.30.cr0 * src/third_party/android_deps/libs/com_google_dagger_dagger_spi: version:2.30.cr0..version:2@2.30.cr0 * src/third_party/android_deps/libs/com_google_errorprone_error_prone_annotation: version:2.4.0.cr0..version:2@2.4.0.cr0 * src/third_party/android_deps/libs/com_google_errorprone_error_prone_annotations: version:2.4.0.cr0..version:2@2.4.0.cr0 * src/third_party/android_deps/libs/com_google_errorprone_error_prone_check_api: version:2.4.0.cr0..version:2@2.4.0.cr0 * src/third_party/android_deps/libs/com_google_errorprone_error_prone_core: version:2.4.0.cr0..version:2@2.4.0.cr0 * src/third_party/android_deps/libs/com_google_errorprone_error_prone_type_annotations: version:2.4.0.cr0..version:2@2.4.0.cr0 * src/third_party/android_deps/libs/com_google_errorprone_javac: version:9+181-r4173-1.cr0..version:2@9+181-r4173-1.cr0 * src/third_party/android_deps/libs/com_google_errorprone_javac_shaded: version:9-dev-r4023-3.cr0..version:2@9-dev-r4023-3.cr0 * src/third_party/android_deps/libs/com_google_firebase_firebase_annotations: version:16.0.0.cr0..version:2@16.0.0.cr0 * src/third_party/android_deps/libs/com_google_firebase_firebase_common: version:19.5.0.cr0..version:2@19.5.0.cr0 * src/third_party/android_deps/libs/com_google_firebase_firebase_components: version:16.1.0.cr0..version:2@16.1.0.cr0 * src/third_party/android_deps/libs/com_google_firebase_firebase_encoders: version:16.1.0.cr0..version:2@16.1.0.cr0 * src/third_party/android_deps/libs/com_google_firebase_firebase_encoders_json: version:17.1.0.cr0..version:2@17.1.0.cr0 * src/third_party/android_deps/libs/com_google_firebase_firebase_iid: version:21.0.1.cr0..version:2@21.0.1.cr0 * src/third_party/android_deps/libs/com_google_firebase_firebase_iid_interop: version:17.0.0.cr0..version:2@17.0.0.cr0 * src/third_party/android_deps/libs/com_google_firebase_firebase_installations: version:16.3.5.cr0..version:2@16.3.5.cr0 * src/third_party/android_deps/libs/com_google_firebase_firebase_installations_interop: version:16.0.1.cr0..version:2@16.0.1.cr0 * src/third_party/android_deps/libs/com_google_firebase_firebase_measurement_connector: version:18.0.0.cr0..version:2@18.0.0.cr0 * src/third_party/android_deps/libs/com_google_firebase_firebase_messaging: version:21.0.1.cr0..version:2@21.0.1.cr0 * src/third_party/android_deps/libs/com_google_googlejavaformat_google_java_format: version:1.5.cr0..version:2@1.5.cr0 * src/third_party/android_deps/libs/com_google_guava_failureaccess: version:1.0.1.cr0..version:2@1.0.1.cr0 * src/third_party/android_deps/libs/com_google_guava_guava: version:30.1-jre.cr0..version:2@30.1-jre.cr0 * src/third_party/android_deps/libs/com_google_guava_guava_android: version:30.1-android.cr0..version:2@30.1-android.cr0 * src/third_party/android_deps/libs/com_google_guava_listenablefuture: version:1.0.cr0..version:2@1.0.cr0 * src/third_party/android_deps/libs/com_google_j2objc_j2objc_annotations: version:1.3.cr0..version:2@1.3.cr0 * src/third_party/android_deps/libs/com_google_protobuf_protobuf_java: version:3.4.0.cr0..version:2@3.4.0.cr0 * src/third_party/android_deps/libs/com_google_protobuf_protobuf_javalite: version:3.13.0.cr0..version:2@3.13.0.cr0 * src/third_party/android_deps/libs/com_googlecode_java_diff_utils_diffutils: version:1.3.0.cr0..version:2@1.3.0.cr0 * src/third_party/android_deps/libs/com_squareup_javapoet: version:1.13.0.cr0..version:2@1.13.0.cr0 * src/third_party/android_deps/libs/com_squareup_javawriter: version:2.1.1.cr0..version:2@2.1.1.cr0 * src/third_party/android_deps/libs/javax_annotation_javax_annotation_api: version:1.3.2.cr0..version:2@1.3.2.cr0 * src/third_party/android_deps/libs/javax_annotation_jsr250_api: version:1.0.cr0..version:2@1.0.cr0 * src/third_party/android_deps/libs/javax_inject_javax_inject: version:1.cr0..version:2@1.cr0 * src/third_party/android_deps/libs/nekohtml_nekohtml: version:1.9.6.2.cr0..version:2@1.9.6.2.cr0 * src/third_party/android_deps/libs/nekohtml_xercesminimal: version:1.9.6.2.cr0..version:2@1.9.6.2.cr0 * src/third_party/android_deps/libs/net_ltgt_gradle_incap_incap: version:0.2.cr0..version:2@0.2.cr0 * src/third_party/android_deps/libs/net_sf_kxml_kxml2: version:2.3.0.cr0..version:2@2.3.0.cr0 * src/third_party/android_deps/libs/org_apache_ant_ant: version:1.8.0.cr0..version:2@1.8.0.cr0 * src/third_party/android_deps/libs/org_apache_ant_ant_launcher: version:1.8.0.cr0..version:2@1.8.0.cr0 * src/third_party/android_deps/libs/org_apache_maven_maven_ant_tasks: version:2.1.3.cr0..version:2@2.1.3.cr0 * src/third_party/android_deps/libs/org_apache_maven_maven_artifact: version:2.2.1.cr0..version:2@2.2.1.cr0 * src/third_party/android_deps/libs/org_apache_maven_maven_artifact_manager: version:2.2.1.cr0..version:2@2.2.1.cr0 * src/third_party/android_deps/libs/org_apache_maven_maven_error_diagnostics: version:2.2.1.cr0..version:2@2.2.1.cr0 * src/third_party/android_deps/libs/org_apache_maven_maven_model: version:2.2.1.cr0..version:2@2.2.1.cr0 * src/third_party/android_deps/libs/org_apache_maven_maven_plugin_registry: version:2.2.1.cr0..version:2@2.2.1.cr0 * src/third_party/android_deps/libs/org_apache_maven_maven_profile: version:2.2.1.cr0..version:2@2.2.1.cr0 * src/third_party/android_deps/libs/org_apache_maven_maven_project: version:2.2.1.cr0..version:2@2.2.1.cr0 * src/third_party/android_deps/libs/org_apache_maven_maven_repository_metadata: version:2.2.1.cr0..version:2@2.2.1.cr0 * src/third_party/android_deps/libs/org_apache_maven_maven_settings: version:2.2.1.cr0..version:2@2.2.1.cr0 * src/third_party/android_deps/libs/org_apache_maven_wagon_wagon_file: version:1.0-beta-6.cr0..version:2@1.0-beta-6.cr0 * src/third_party/android_deps/libs/org_apache_maven_wagon_wagon_http_lightweight: version:1.0-beta-6.cr0..version:2@1.0-beta-6.cr0 * src/third_party/android_deps/libs/org_apache_maven_wagon_wagon_http_shared: version:1.0-beta-6.cr0..version:2@1.0-beta-6.cr0 * src/third_party/android_deps/libs/org_apache_maven_wagon_wagon_provider_api: version:1.0-beta-6.cr0..version:2@1.0-beta-6.cr0 * src/third_party/android_deps/libs/org_ccil_cowan_tagsoup_tagsoup: version:1.2.1.cr0..version:2@1.2.1.cr0 * src/third_party/android_deps/libs/org_checkerframework_checker_compat_qual: version:2.5.5.cr0..version:2@2.5.5.cr0 * src/third_party/android_deps/libs/org_checkerframework_checker_qual: version:3.5.0.cr0..version:2@3.5.0.cr0 * src/third_party/android_deps/libs/org_checkerframework_dataflow_shaded: version:3.1.2.cr0..version:2@3.1.2.cr0 * src/third_party/android_deps/libs/org_codehaus_mojo_animal_sniffer_annotations: version:1.17.cr0..version:2@1.17.cr0 * src/third_party/android_deps/libs/org_codehaus_plexus_plexus_container_default: version:1.0-alpha-9-stable-1.cr0..version:2@1.0-alpha-9-stable-1.cr0 * src/third_party/android_deps/libs/org_codehaus_plexus_plexus_interpolation: version:1.11.cr0..version:2@1.11.cr0 * src/third_party/android_deps/libs/org_codehaus_plexus_plexus_utils: version:1.5.15.cr0..version:2@1.5.15.cr0 * src/third_party/android_deps/libs/org_jetbrains_annotations: version:13.0.cr0..version:2@13.0.cr0 * src/third_party/android_deps/libs/org_jetbrains_kotlin_kotlin_stdlib: version:1.3.72.cr0..version:2@1.4.30.cr0 * src/third_party/android_deps/libs/org_jetbrains_kotlin_kotlin_stdlib_common: version:1.3.72.cr0..version:2@1.4.30.cr0 * src/third_party/android_deps/libs/org_jetbrains_kotlinx_kotlinx_metadata_jvm: version:0.1.0.cr0..version:2@0.1.0.cr0 * src/third_party/android_deps/libs/org_ow2_asm_asm: version:7.0.cr0..version:2@7.0.cr0 * src/third_party/android_deps/libs/org_ow2_asm_asm_analysis: version:7.0.cr0..version:2@7.0.cr0 * src/third_party/android_deps/libs/org_ow2_asm_asm_commons: version:7.0.cr0..version:2@7.0.cr0 * src/third_party/android_deps/libs/org_ow2_asm_asm_tree: version:7.0.cr0..version:2@7.0.cr0 * src/third_party/android_deps/libs/org_ow2_asm_asm_util: version:7.0.cr0..version:2@7.0.cr0 * src/third_party/android_deps/libs/org_pcollections_pcollections: version:2.1.2.cr0..version:2@2.1.2.cr0 * src/third_party/android_deps/libs/org_robolectric_annotations: version:4.3.1.cr0..version:2@4.3.1.cr0 * src/third_party/android_deps/libs/org_robolectric_junit: version:4.3.1.cr0..version:2@4.3.1.cr0 * src/third_party/android_deps/libs/org_robolectric_pluginapi: version:4.3.1.cr0..version:2@4.3.1.cr0 * src/third_party/android_deps/libs/org_robolectric_plugins_maven_dependency_resolver: version:4.3.1.cr0..version:2@4.3.1.cr0 * src/third_party/android_deps/libs/org_robolectric_resources: version:4.3.1.cr0..version:2@4.3.1.cr0 * src/third_party/android_deps/libs/org_robolectric_robolectric: version:4.3.1.cr0..version:2@4.3.1.cr0 * src/third_party/android_deps/libs/org_robolectric_sandbox: version:4.3.1.cr0..version:2@4.3.1.cr0 * src/third_party/android_deps/libs/org_robolectric_shadowapi: version:4.3.1.cr0..version:2@4.3.1.cr0 * src/third_party/android_deps/libs/org_robolectric_shadows_framework: version:4.3.1.cr0..version:2@4.3.1.cr0 * src/third_party/android_deps/libs/org_robolectric_shadows_playservices: version:4.3.1.cr0..version:2@4.3.1.cr0 * src/third_party/android_deps/libs/org_robolectric_utils: version:4.3.1.cr0..version:2@4.3.1.cr0 * src/third_party/android_deps/libs/org_robolectric_utils_reflector: version:4.3.1.cr0..version:2@4.3.1.cr0 * src/third_party/android_deps/libs/org_threeten_threeten_extra: version:1.5.0.cr0..version:2@1.5.0.cr0 * src/third_party/androidx: v-p1zbJ800vLETiv98_a04Og1z_1IR6Cph3aB-RvpO0C..elLOzilYbu3vB2mpMZzZsC0i9QukqoU9miZ_PUmpeE8C * src/third_party/breakpad/breakpad: https://chromium.googlesource.com/breakpad/breakpad.git/+log/dff7d5afd5..3bea2815bf * src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/36e45025a8..ab687ea7be * src/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e0de6a88e5..057831ef1f * src/third_party/ffmpeg: https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/104674b531..4fb42ae52e * src/third_party/freetype/src: https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/e9c50fa77d..b9b74f9f78 * src/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/1a8ecf1813..965f8ecbfd * src/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu.git/+log/d879aac971..81d656878e * src/third_party/libaom/source/libaom: https://aomedia.googlesource.com/aom.git/+log/79b7757996..6c93db7ff6 * src/third_party/libyuv: https://chromium.googlesource.com/libyuv/libyuv.git/+log/a8c181050c..64994843e6 * src/third_party/lss: https://chromium.googlesource.com/linux-syscall-support.git/+log/29f7c7e018..92a65a8f5d * src/third_party/perfetto: https://android.googlesource.com/platform/external/perfetto.git/+log/acb2e677b4..9511660f93 * src/third_party/r8: TNGssqzExjlZ_AG4P92Hje4YYbM8o_TMSLQeRxrAB-8C..wupRO-hEg2hxgKU9FC5HKY88dMpfEpdimjxcgekXH8oC * src/third_party/usrsctp/usrsctplib: https://chromium.googlesource.com/external/github.com/sctplab/usrsctp/+log/79f0178cd3..70d42ae95a * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/add6c82864..78b6ac0da4 * src/tools/luci-go: git_revision:40e3c704aad0fceec04344d281ae333de04fd2a5..git_revision:f784260b204b2d93c7bd6d1a619f09c6822e5926 * src/tools/luci-go: git_revision:40e3c704aad0fceec04344d281ae333de04fd2a5..git_revision:f784260b204b2d93c7bd6d1a619f09c6822e5926 * src/tools/luci-go: git_revision:40e3c704aad0fceec04344d281ae333de04fd2a5..git_revision:f784260b204b2d93c7bd6d1a619f09c6822e5926 Added dependencies * src/third_party/android_deps/libs/com_android_tools_layoutlib_layoutlib_api * src/third_party/android_deps/libs/com_android_tools_sdk_common * src/third_party/android_deps/libs/com_android_tools_common DEPS diff: https://chromium.googlesource.com/chromium/src/+/34f3c82122..2dffe06711/DEPS Clang version changed llvmorg-13-init-4720-g7bafe336:llvmorg-13-init-6429-g0e92cbd6 Details: https://chromium.googlesource.com/chromium/src/+/34f3c82122..2dffe06711/tools/clang/scripts/update.py TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com, BUG=None Change-Id: I3b3a469e48383e250adaf46b186d5cad038957a6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/215021 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33696}
2021-04-12 19:03:37 +02:00
deps += [
"//build/android/gtest_apk:native_test_instrumentation_test_runner_java",
webrtc_root + "test:native_test_java",
]
}
Build and run iOS tests as XCTests. After upgrading to xcode 12, some Gtest tests have started to randomly fail. The solution around this problem is to build and run GTests as XCTests. In order to achieve that, the CL sets enable_run_ios_unittests_with_xctest to true in all iOS builds and adds a dependency on //base/test:google_test_runner for each Gtest that needs to run as an XCTest. Real XCTest don't need the dependency and they are marked with the rtc_test() argument `is_xctest=true` (apprtcmobile_tests, sdk_unittests and sdk_framework_unittests). This CL is based on [1] which passes --xctest to the runner and uses --undefok to avoid to crash when absl/flags doesn't recognize the flag --enable-run-ios-unittests-with-xctest (absl/flags cannot have "-" in flags so WebRTC binaries cannot define that flag). To workaround the issue, WebRTC tests always behave like --enable-run-ios-unittests-with-xctest is always set (by linking only with //base/test:google_test_runner to run iOS tests). This fixes iOS12 and iOS13 tests but not iOS14 on which some tests are failing because of restricted access to resources (this will be addressed in another CL). Long term, this solution might cause problems when Chromium decides to update test() GN template and/or the test launcher, so WebRTC should plan a better integration with Chromium's iOS infra. [1] - https://chromium-review.googlesource.com/c/chromium/tools/build/+/2550656 Bug: webrtc:12134 Change-Id: I24c731dee0310e02ae1bbe6c23d359d6fcd18f17 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193620 Reviewed-by: Jeremy Leconte <jleconte@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32716}
2020-11-25 16:41:37 +01:00
# Build //base/test:google_test_runner when the test is not a real XCTest.
if (is_ios && rtc_include_tests) {
Build and run iOS tests as XCTests. After upgrading to xcode 12, some Gtest tests have started to randomly fail. The solution around this problem is to build and run GTests as XCTests. In order to achieve that, the CL sets enable_run_ios_unittests_with_xctest to true in all iOS builds and adds a dependency on //base/test:google_test_runner for each Gtest that needs to run as an XCTest. Real XCTest don't need the dependency and they are marked with the rtc_test() argument `is_xctest=true` (apprtcmobile_tests, sdk_unittests and sdk_framework_unittests). This CL is based on [1] which passes --xctest to the runner and uses --undefok to avoid to crash when absl/flags doesn't recognize the flag --enable-run-ios-unittests-with-xctest (absl/flags cannot have "-" in flags so WebRTC binaries cannot define that flag). To workaround the issue, WebRTC tests always behave like --enable-run-ios-unittests-with-xctest is always set (by linking only with //base/test:google_test_runner to run iOS tests). This fixes iOS12 and iOS13 tests but not iOS14 on which some tests are failing because of restricted access to resources (this will be addressed in another CL). Long term, this solution might cause problems when Chromium decides to update test() GN template and/or the test launcher, so WebRTC should plan a better integration with Chromium's iOS infra. [1] - https://chromium-review.googlesource.com/c/chromium/tools/build/+/2550656 Bug: webrtc:12134 Change-Id: I24c731dee0310e02ae1bbe6c23d359d6fcd18f17 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193620 Reviewed-by: Jeremy Leconte <jleconte@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32716}
2020-11-25 16:41:37 +01:00
if (!defined(invoker.is_xctest) || !invoker.is_xctest) {
xctest_module_target = "//base/test:google_test_runner"
}
}
# If absl_deps is [], no action is needed. If not [], then it needs to be
# converted to //third_party/abseil-cpp:absl when build_with_chromium=true
# otherwise it just needs to be added to deps.
if (defined(absl_deps) && absl_deps != []) {
if (!defined(deps)) {
deps = []
}
if (build_with_chromium) {
deps += [ "//third_party/abseil-cpp:absl" ]
} else {
deps += absl_deps
}
}
Fix roll chromium_revision 18311e2720..e3ed290da5 (844473:846763) Change log: https://chromium.googlesource.com/chromium/src/+log/18311e2720..e3ed290da5 Full diff: https://chromium.googlesource.com/chromium/src/+/18311e2720..e3ed290da5 Changed dependencies * src/base: https://chromium.googlesource.com/chromium/src/base/+log/f7f5bac81f..5397c2600c * src/build: https://chromium.googlesource.com/chromium/src/build/+log/43dd249695..4ba9b31907 * src/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/c38b5ab1c6..13547b97da * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/ad2e59ea45..8790968c74 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/ca81cc1c21..01cab16640 * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/3ee03ddfde..cc28b65885 * src/third_party/android_deps/libs/androidx_activity_activity: version:1.1.0-cr0..version:1.3.0-SNAPSHOT-cr0 * src/third_party/android_deps/libs/androidx_annotation_annotation: version:1.2.0-alpha01-cr0..version:1.2.0-SNAPSHOT-cr0 * src/third_party/android_deps/libs/androidx_appcompat_appcompat: version:1.2.0-beta01-cr0..version:1.3.0-SNAPSHOT-cr0 * src/third_party/android_deps/libs/androidx_appcompat_appcompat_resources: version:1.2.0-cr0..version:1.3.0-SNAPSHOT-cr0 * src/third_party/android_deps/libs/androidx_fragment_fragment: version:1.2.5-cr0..version:1.4.0-SNAPSHOT-cr0 * src/third_party/android_deps/libs/androidx_gridlayout_gridlayout: version:1.0.0-cr0..version:1.1.0-SNAPSHOT-cr0 * src/third_party/android_deps/libs/androidx_leanback_leanback: version:1.0.0-cr0..version:1.1.0-beta01-cr0 * src/third_party/android_deps/libs/androidx_leanback_leanback_preference: version:1.0.0-cr0..version:1.1.0-SNAPSHOT-cr0 * src/third_party/android_deps/libs/androidx_lifecycle_lifecycle_common: version:2.2.0-cr0..version:2.4.0-SNAPSHOT-cr0 * src/third_party/android_deps/libs/androidx_lifecycle_lifecycle_common_java8: version:2.0.0-cr0..version:2.4.0-SNAPSHOT-cr0 * src/third_party/android_deps/libs/androidx_lifecycle_lifecycle_livedata: version:2.0.0-cr0..version:2.4.0-SNAPSHOT-cr0 * src/third_party/android_deps/libs/androidx_lifecycle_lifecycle_livedata_core: version:2.2.0-cr0..version:2.4.0-SNAPSHOT-cr0 * src/third_party/android_deps/libs/androidx_lifecycle_lifecycle_runtime: version:2.2.0-cr0..version:2.4.0-SNAPSHOT-cr0 * src/third_party/android_deps/libs/androidx_lifecycle_lifecycle_viewmodel: version:2.2.0-cr0..version:2.4.0-SNAPSHOT-cr0 * src/third_party/android_deps/libs/androidx_lifecycle_lifecycle_viewmodel_savedstate: version:2.2.0-cr0..version:2.4.0-SNAPSHOT-cr0 * src/third_party/android_deps/libs/androidx_preference_preference: version:1.1.1-cr0..version:1.2.0-SNAPSHOT-cr0 * src/third_party/android_deps/libs/androidx_recyclerview_recyclerview: version:1.2.0-alpha06-cr0..version:1.2.0-beta01-cr0 * src/third_party/android_deps/libs/androidx_savedstate_savedstate: version:1.0.0-cr0..version:1.2.0-SNAPSHOT-cr0 * src/third_party/android_deps/libs/androidx_slice_slice_builders: version:1.0.0-cr0..version:1.1.0-SNAPSHOT-cr0 * src/third_party/android_deps/libs/androidx_slice_slice_core: version:1.0.0-cr0..version:1.1.0-SNAPSHOT-cr0 * src/third_party/android_deps/libs/androidx_transition_transition: version:1.4.0-SNAPSHOT-cr0..version:1.5.0-SNAPSHOT-cr0 * src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/f8f35c9555..c47bfce062 * src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/cf567b6b96..957dfeae29 * src/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/dabd965527..f08e425f2d * src/third_party/freetype/src: https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/03ceda9701..c7cc947c0f * src/third_party/perfetto: https://android.googlesource.com/platform/external/perfetto.git/+log/2d79f95e90..122834484a * src/third_party/usrsctp/usrsctplib: https://chromium.googlesource.com/external/github.com/sctplab/usrsctp/+log/a3c3ef666b..07f871bda2 * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/c952341d24..262a9440ba * src/tools/swarming_client: https://chromium.googlesource.com/infra/luci/client-py.git/+log/1a072711d4..a32a1607f6 Added dependencies * src/third_party/android_deps/libs/androidx_remotecallback_remotecallback * src/third_party/android_deps/libs/androidx_tracing_tracing Removed dependency * src/third_party/android_deps/libs/androidx_legacy_legacy_preference_v14 DEPS diff: https://chromium.googlesource.com/chromium/src/+/18311e2720..e3ed290da5/DEPS Clang version changed llvmorg-12-init-16296-g5e476061:llvmorg-12-init-17251-g6de48655 Details: https://chromium.googlesource.com/chromium/src/+/18311e2720..e3ed290da5/tools/clang/scripts/update.py TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com, BUG=None Change-Id: I5879700bb906a7356c4fdecc6fbef52268dbf6ba Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/203887 Reviewed-by: Artem Titov <titovartem@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33076}
2021-01-26 17:10:04 +01:00
if (using_sanitizer) {
if (is_linux) {
if (!defined(invoker.data)) {
data = []
}
data +=
[ "//third_party/llvm-build/Release+Asserts/lib/libstdc++.so.6" ]
}
}
# TODO(crbug.com/webrtc/13556): Adding the .app folder in the runtime_deps
# shoulnd't be necessary. this code should be removed and the same solution
# as Chromium should be used.
if (is_ios) {
if (!defined(invoker.data)) {
data = []
}
data += [ "${root_out_dir}/${target_name}.app" ]
}
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
}
}
template("rtc_source_set") {
source_set(target_name) {
forward_variables_from(invoker,
"*",
[
"configs",
"public_configs",
"suppressed_configs",
"visibility",
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
])
forward_variables_from(invoker, [ "visibility" ])
Revert "Revert "GN rtc_* templates: Set default visibility to webrtc_root + "/*""" This reverts commit c73e1f437889d882cbf2987f7fb3a029a6150613. Reason for revert: The problem with failed deps in chrome content/renderer had already been fixed in https://webrtc-review.googlesource.com/c/src/+/38660 Original change's description: > Revert "GN rtc_* templates: Set default visibility to webrtc_root + "/*"" > > This reverts commit 588c548657b3ddf76e7b3f241263eef7f5799f16. > > Reason for revert: > > Breaks Chrome FYI: > > /b/c/b/Linux_Builder/src/buildtools/linux64/gn gen //out/Release --check > -> returned 1 > ERROR at //build/split_static_library.gni:12:5: Dependency not allowed. > static_library(target_name) { > ^---------------------------- > The item //content/renderer:renderer > can not depend on //third_party/webrtc/media:rtc_internal_video_codecs > because it is not in //third_party/webrtc/media:rtc_internal_video_codecs's visibility list: [ > //third_party/webrtc/* > //third_party/webrtc_overrides/* > ] > > https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.webrtc.fyi%2FLinux_Builder%2F23560%2F%2B%2Frecipes%2Fsteps%2Fgenerate_build_files%2F0%2Fstdout > > Original change's description: > > GN rtc_* templates: Set default visibility to webrtc_root + "/*" > > > > This means that by default, targets are visible to everything under > > the WebRTC root, but not visible to anything else. > > > > API targets are manually tagged with visibility "*", so that targets > > outside the WebRTC tree can see them. > > > > BUG=webrtc:8254 > > > > Change-Id: Icdbee6e0d22d93240ff2fb530c8f9dc48e351509 > > Reviewed-on: https://webrtc-review.googlesource.com/24140 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#21548} > > TBR=mbonadei@webrtc.org,kwiberg@webrtc.org > > Change-Id: I06620ce3d6f67482935c22efa231dd6cab91625a > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:8254 > Reviewed-on: https://webrtc-review.googlesource.com/38760 > Reviewed-by: Per Kjellander <perkj@webrtc.org> > Commit-Queue: Per Kjellander <perkj@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#21555} TBR=mbonadei@webrtc.org,kwiberg@webrtc.org,perkj@webrtc.org Change-Id: I6f720078ce21bd172e0a6471bae8c4c011e4a657 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:8254 Reviewed-on: https://webrtc-review.googlesource.com/38860 Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Per Kjellander <perkj@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21558}
2018-01-10 15:54:53 +00:00
if (!defined(visibility)) {
visibility = webrtc_default_visibility
}
# What's your poison?
if (defined(testonly) && testonly) {
assert(!defined(poisonous))
assert(!defined(allow_poison))
} else {
if (!defined(poisonous)) {
poisonous = []
}
if (!defined(allow_poison)) {
allow_poison = []
}
if (!defined(assert_no_deps)) {
assert_no_deps = []
}
if (!defined(deps)) {
deps = []
}
foreach(p, poisonous) {
deps += [ webrtc_root + ":poison_" + p ]
}
foreach(poison_type, all_poison_types) {
allow_dep = true
foreach(v, visibility) {
if (v == "*") {
allow_dep = false
}
}
foreach(p, allow_poison + poisonous) {
if (p == poison_type) {
allow_dep = true
}
}
if (!allow_dep) {
assert_no_deps += [ webrtc_root + ":poison_" + poison_type ]
}
}
}
# Chromium should only depend on the WebRTC component in order to
# avoid to statically link WebRTC in a component build.
if (build_with_chromium) {
publicly_visible = false
foreach(v, visibility) {
if (v == "*") {
publicly_visible = true
}
}
if (publicly_visible) {
visibility = []
visibility = webrtc_default_visibility
}
}
if (!defined(testonly) || !testonly) {
configs += rtc_prod_configs
}
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
configs += invoker.configs
Reland "Add RTC_EXPORT macro to export WebRTC symbols." This is a reland of 55daf1aef65218a97eff88999e5190a2f2f6b72e. In order to avoid problems on case insensitive file systems this CL moves rtc_export.h to rtc_base/system (avoiding problems with build/). Diff: https://webrtc-review.googlesource.com/c/src/+/100804/1..2. Original change's description: > Add RTC_EXPORT macro to export WebRTC symbols. > > This CL introduces the utility macro RTC_EXPORT which will let WebRTC > developers decide which symbols are supposed to be exported/imported > and which ones are private. > > RTC_EXPORT will only export/import symbols in a component build, more > info: https://cs.chromium.org/chromium/src/docs/component_build.md. > During a component build, the macro COMPONENT_BUILD will be globally > defined in a consistent fashion so it is safe to rely on it to > understand how to expand RTC_EXPORT. > In a non component build, RTC_EXPORT will expand to nothing. > > Bug: webrtc:9419 > Change-Id: Ic58162783be7f5883136ade27f324d6d34fdf932 > Reviewed-on: https://webrtc-review.googlesource.com/97960 > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > Reviewed-by: Niels Moller <nisse@webrtc.org> > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > Reviewed-by: Yves Gerey <yvesg@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#24757} Bug: webrtc:9419 Change-Id: Icfedea5fc3416ea1af2185de443fa879fb2dee8b Reviewed-on: https://webrtc-review.googlesource.com/100804 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24766}
2018-09-18 13:15:54 +02:00
configs += rtc_library_impl_config
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
configs -= rtc_remove_configs
configs -= invoker.suppressed_configs
Reland "Reland "Adding absl includes and defines to rtc_* templates."" This reverts commit 759eb4f2ad7e23b65fe0b834f8ba7f580bf1a933. Reason for revert: The problem has been fixed in https://chromium-review.googlesource.com/1075889. Original change's description: > Revert "Reland "Adding absl includes and defines to rtc_* templates."" > > This reverts commit fae51e4c95780f59f4bedf6e01403ff86152e168. > > Reason for revert: > When use_xcode_clang = true we get: > error: unknown warning option '-Wno-unused-template'; did you mean '-Wno-unused-result'? [-Werror,-Wunknown-warning-option] > error: unknown warning option '-Wno-zero-as-null-pointer-constant'; did you mean '-Wno-int-to-void-pointer-cast'? [-Werror,-Wunknown-warning-option] > > > Original change's description: > > Reland "Adding absl includes and defines to rtc_* templates." > > > > This reverts commit 8436a699a998e4fa30d97786142baad08f110d2a. > > > > Reason for revert: > > New absl roll -> https://chromium-review.googlesource.com/1071468 > > > > Original change's description: > > > Revert "Reland "Adding absl includes and defines to rtc_* templates."" > > > > > > This reverts commit bdb0fe42bc46d190ca45fc5a6658eddbfa5eead5. > > > > > > Reason for revert: https://ci.chromium.org/buildbot/chromium.fyi/Jumbo%20Win%20x64/11502 > > > > > > Original change's description: > > > > Reland "Adding absl includes and defines to rtc_* templates." > > > > > > > > This reverts commit 85cb19fec7caf558dee7a09aafabe01c5ac78f3f. > > > > > > > > Reason for revert: The new version of Abseil should fix the previous > > > > issue. > > > > > > > > Original change's description: > > > > > Revert "Reland "Adding absl includes and defines to rtc_* templates."" > > > > > > > > > > This reverts commit 9632112a16d70a146e917db4de761e6253dfc364. > > > > > > > > > > Reason for revert: It breaks the WebRTC roll into Chromium. > > > > > https://chromium-review.googlesource.com/c/chromium/src/+/1061476 > > > > > > > > > > Original change's description: > > > > > > Reland "Adding absl includes and defines to rtc_* templates." > > > > > > > > > > > > This reverts commit d161eda477491b2b97fb3f26d229c625a2a0e9b8. > > > > > > > > > > > > Reason for revert: The problem with iOS trybots should be fixed. > > > > > > > > > > > > Original change's description: > > > > > > > Revert "Adding absl includes and defines to rtc_* templates." > > > > > > > > > > > > > > This reverts commit 9d8f3850f4c4faad5dc5ab32ab6f2c9c43df7b6c. > > > > > > > > > > > > > > Reason for revert: Breaks some trybots: https://build.chromium.org/p/client.webrtc/builders/iOS64%20Release/builds/12793. > > > > > > > > > > > > > > Original change's description: > > > > > > > > Adding absl includes and defines to rtc_* templates. > > > > > > > > > > > > > > > > This CL implicitly adds the -I compiler flag and absl macros to WebRTC > > > > > > > > templates. In order to include absl headers using relative paths, WebRTC > > > > > > > > needs to ensure that all its build targets are able to see absl headers. > > > > > > > > > > > > > > > > This can also be done with public_deps, but WebRTC is trying to avoid > > > > > > > > it because it creates problems with other build systems. Given this > > > > > > > > constraint, using rtc_* templates is the most reliable solution. > > > > > > > > > > > > > > > > Please note that rtc_* templates are adding absl includes and defines > > > > > > > > as public_configs, this means that build targets with WebRTC targets > > > > > > > > in their public_deps will propagate these configs following the GN > > > > > > > > guideline. > > > > > > > > > > > > > > > > Bug: webrtc:8821 > > > > > > > > Change-Id: I4aa594a524f4bd045bcb3e80d76cc27f06fe01d7 > > > > > > > > Reviewed-on: https://webrtc-review.googlesource.com/70367 > > > > > > > > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > > > > > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > > > > > Cr-Commit-Position: refs/heads/master@{#22927} > > > > > > > > > > > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > > > > > > > > > > > Change-Id: Id8e1f881c57553386566eb1970f6b9f8632cab37 > > > > > > > No-Presubmit: true > > > > > > > No-Tree-Checks: true > > > > > > > No-Try: true > > > > > > > Bug: webrtc:8821 > > > > > > > Reviewed-on: https://webrtc-review.googlesource.com/71000 > > > > > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > > > > Cr-Commit-Position: refs/heads/master@{#22928} > > > > > > > > > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > > > > > > > > > Bug: webrtc:8821 > > > > > > Change-Id: I6ee2eda97bbcd4c9be25c9c4073272192b0373f8 > > > > > > Reviewed-on: https://webrtc-review.googlesource.com/71700 > > > > > > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > > > > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > > > Cr-Commit-Position: refs/heads/master@{#23251} > > > > > > > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > > > > > > > Change-Id: I61fb749797314ca514691b341c66f7f39ef45491 > > > > > No-Presubmit: true > > > > > No-Tree-Checks: true > > > > > No-Try: true > > > > > Bug: webrtc:8821 > > > > > Reviewed-on: https://webrtc-review.googlesource.com/77220 > > > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > > Cr-Commit-Position: refs/heads/master@{#23264} > > > > > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > > > > > Bug: webrtc:8821 > > > > Change-Id: I71dea953a002a0d526949c627653bcad0c6518fc > > > > Reviewed-on: https://webrtc-review.googlesource.com/77781 > > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > Cr-Commit-Position: refs/heads/master@{#23317} > > > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > > > Change-Id: I6010f9264dba7bcc4e82c4f4bbfb2eca561e500e > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: webrtc:8821, chromium:845158 > > > Reviewed-on: https://webrtc-review.googlesource.com/78061 > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > Cr-Commit-Position: refs/heads/master@{#23328} > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: webrtc:8821, chromium:845158 > > Change-Id: Iebe0958012c39e1321487e5425f43904eaf5fe91 > > Reviewed-on: https://webrtc-review.googlesource.com/78705 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#23403} > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > Change-Id: I8285cf59402aa6862ea7e3ec21f885360b7050fb > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:8821, chromium:845158 > Reviewed-on: https://webrtc-review.googlesource.com/79420 > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#23416} TBR=phoglund@webrtc.org,mbonadei@webrtc.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: webrtc:8821, chromium:845158 Change-Id: I18ffdb0d7be61daf0b6464c68d219aa352f42dde Reviewed-on: https://webrtc-review.googlesource.com/79582 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23435}
2018-05-29 14:22:32 +00:00
public_configs = [
rtc_common_inherited_config,
absl_include_config,
absl_define_config,
]
if (defined(testonly) && testonly) {
public_configs += [ absl_flags_config ]
}
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
if (defined(invoker.public_configs)) {
public_configs += invoker.public_configs
}
# If absl_deps is [], no action is needed. If not [], then it needs to be
# converted to //third_party/abseil-cpp:absl when build_with_chromium=true
# otherwise it just needs to be added to deps.
if (absl_deps != []) {
if (!defined(deps)) {
deps = []
}
if (build_with_chromium) {
deps += [ "//third_party/abseil-cpp:absl" ]
} else {
deps += absl_deps
}
}
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
}
}
template("rtc_static_library") {
static_library(target_name) {
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
forward_variables_from(invoker,
"*",
[
"configs",
"public_configs",
"suppressed_configs",
"visibility",
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
])
forward_variables_from(invoker, [ "visibility" ])
Revert "Revert "GN rtc_* templates: Set default visibility to webrtc_root + "/*""" This reverts commit c73e1f437889d882cbf2987f7fb3a029a6150613. Reason for revert: The problem with failed deps in chrome content/renderer had already been fixed in https://webrtc-review.googlesource.com/c/src/+/38660 Original change's description: > Revert "GN rtc_* templates: Set default visibility to webrtc_root + "/*"" > > This reverts commit 588c548657b3ddf76e7b3f241263eef7f5799f16. > > Reason for revert: > > Breaks Chrome FYI: > > /b/c/b/Linux_Builder/src/buildtools/linux64/gn gen //out/Release --check > -> returned 1 > ERROR at //build/split_static_library.gni:12:5: Dependency not allowed. > static_library(target_name) { > ^---------------------------- > The item //content/renderer:renderer > can not depend on //third_party/webrtc/media:rtc_internal_video_codecs > because it is not in //third_party/webrtc/media:rtc_internal_video_codecs's visibility list: [ > //third_party/webrtc/* > //third_party/webrtc_overrides/* > ] > > https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.webrtc.fyi%2FLinux_Builder%2F23560%2F%2B%2Frecipes%2Fsteps%2Fgenerate_build_files%2F0%2Fstdout > > Original change's description: > > GN rtc_* templates: Set default visibility to webrtc_root + "/*" > > > > This means that by default, targets are visible to everything under > > the WebRTC root, but not visible to anything else. > > > > API targets are manually tagged with visibility "*", so that targets > > outside the WebRTC tree can see them. > > > > BUG=webrtc:8254 > > > > Change-Id: Icdbee6e0d22d93240ff2fb530c8f9dc48e351509 > > Reviewed-on: https://webrtc-review.googlesource.com/24140 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#21548} > > TBR=mbonadei@webrtc.org,kwiberg@webrtc.org > > Change-Id: I06620ce3d6f67482935c22efa231dd6cab91625a > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:8254 > Reviewed-on: https://webrtc-review.googlesource.com/38760 > Reviewed-by: Per Kjellander <perkj@webrtc.org> > Commit-Queue: Per Kjellander <perkj@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#21555} TBR=mbonadei@webrtc.org,kwiberg@webrtc.org,perkj@webrtc.org Change-Id: I6f720078ce21bd172e0a6471bae8c4c011e4a657 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:8254 Reviewed-on: https://webrtc-review.googlesource.com/38860 Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Per Kjellander <perkj@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21558}
2018-01-10 15:54:53 +00:00
if (!defined(visibility)) {
visibility = webrtc_default_visibility
}
# What's your poison?
if (defined(testonly) && testonly) {
assert(!defined(poisonous))
assert(!defined(allow_poison))
} else {
if (!defined(poisonous)) {
poisonous = []
}
if (!defined(allow_poison)) {
allow_poison = []
}
if (!defined(assert_no_deps)) {
assert_no_deps = []
}
if (!defined(deps)) {
deps = []
}
foreach(p, poisonous) {
deps += [ webrtc_root + ":poison_" + p ]
}
foreach(poison_type, all_poison_types) {
allow_dep = true
foreach(v, visibility) {
if (v == "*") {
allow_dep = false
}
}
foreach(p, allow_poison + poisonous) {
if (p == poison_type) {
allow_dep = true
}
}
if (!allow_dep) {
assert_no_deps += [ webrtc_root + ":poison_" + poison_type ]
}
}
}
if (!defined(testonly) || !testonly) {
configs += rtc_prod_configs
}
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
configs += invoker.configs
configs += rtc_library_impl_config
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
configs -= rtc_remove_configs
configs -= invoker.suppressed_configs
Reland "Reland "Adding absl includes and defines to rtc_* templates."" This reverts commit 759eb4f2ad7e23b65fe0b834f8ba7f580bf1a933. Reason for revert: The problem has been fixed in https://chromium-review.googlesource.com/1075889. Original change's description: > Revert "Reland "Adding absl includes and defines to rtc_* templates."" > > This reverts commit fae51e4c95780f59f4bedf6e01403ff86152e168. > > Reason for revert: > When use_xcode_clang = true we get: > error: unknown warning option '-Wno-unused-template'; did you mean '-Wno-unused-result'? [-Werror,-Wunknown-warning-option] > error: unknown warning option '-Wno-zero-as-null-pointer-constant'; did you mean '-Wno-int-to-void-pointer-cast'? [-Werror,-Wunknown-warning-option] > > > Original change's description: > > Reland "Adding absl includes and defines to rtc_* templates." > > > > This reverts commit 8436a699a998e4fa30d97786142baad08f110d2a. > > > > Reason for revert: > > New absl roll -> https://chromium-review.googlesource.com/1071468 > > > > Original change's description: > > > Revert "Reland "Adding absl includes and defines to rtc_* templates."" > > > > > > This reverts commit bdb0fe42bc46d190ca45fc5a6658eddbfa5eead5. > > > > > > Reason for revert: https://ci.chromium.org/buildbot/chromium.fyi/Jumbo%20Win%20x64/11502 > > > > > > Original change's description: > > > > Reland "Adding absl includes and defines to rtc_* templates." > > > > > > > > This reverts commit 85cb19fec7caf558dee7a09aafabe01c5ac78f3f. > > > > > > > > Reason for revert: The new version of Abseil should fix the previous > > > > issue. > > > > > > > > Original change's description: > > > > > Revert "Reland "Adding absl includes and defines to rtc_* templates."" > > > > > > > > > > This reverts commit 9632112a16d70a146e917db4de761e6253dfc364. > > > > > > > > > > Reason for revert: It breaks the WebRTC roll into Chromium. > > > > > https://chromium-review.googlesource.com/c/chromium/src/+/1061476 > > > > > > > > > > Original change's description: > > > > > > Reland "Adding absl includes and defines to rtc_* templates." > > > > > > > > > > > > This reverts commit d161eda477491b2b97fb3f26d229c625a2a0e9b8. > > > > > > > > > > > > Reason for revert: The problem with iOS trybots should be fixed. > > > > > > > > > > > > Original change's description: > > > > > > > Revert "Adding absl includes and defines to rtc_* templates." > > > > > > > > > > > > > > This reverts commit 9d8f3850f4c4faad5dc5ab32ab6f2c9c43df7b6c. > > > > > > > > > > > > > > Reason for revert: Breaks some trybots: https://build.chromium.org/p/client.webrtc/builders/iOS64%20Release/builds/12793. > > > > > > > > > > > > > > Original change's description: > > > > > > > > Adding absl includes and defines to rtc_* templates. > > > > > > > > > > > > > > > > This CL implicitly adds the -I compiler flag and absl macros to WebRTC > > > > > > > > templates. In order to include absl headers using relative paths, WebRTC > > > > > > > > needs to ensure that all its build targets are able to see absl headers. > > > > > > > > > > > > > > > > This can also be done with public_deps, but WebRTC is trying to avoid > > > > > > > > it because it creates problems with other build systems. Given this > > > > > > > > constraint, using rtc_* templates is the most reliable solution. > > > > > > > > > > > > > > > > Please note that rtc_* templates are adding absl includes and defines > > > > > > > > as public_configs, this means that build targets with WebRTC targets > > > > > > > > in their public_deps will propagate these configs following the GN > > > > > > > > guideline. > > > > > > > > > > > > > > > > Bug: webrtc:8821 > > > > > > > > Change-Id: I4aa594a524f4bd045bcb3e80d76cc27f06fe01d7 > > > > > > > > Reviewed-on: https://webrtc-review.googlesource.com/70367 > > > > > > > > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > > > > > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > > > > > Cr-Commit-Position: refs/heads/master@{#22927} > > > > > > > > > > > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > > > > > > > > > > > Change-Id: Id8e1f881c57553386566eb1970f6b9f8632cab37 > > > > > > > No-Presubmit: true > > > > > > > No-Tree-Checks: true > > > > > > > No-Try: true > > > > > > > Bug: webrtc:8821 > > > > > > > Reviewed-on: https://webrtc-review.googlesource.com/71000 > > > > > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > > > > Cr-Commit-Position: refs/heads/master@{#22928} > > > > > > > > > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > > > > > > > > > Bug: webrtc:8821 > > > > > > Change-Id: I6ee2eda97bbcd4c9be25c9c4073272192b0373f8 > > > > > > Reviewed-on: https://webrtc-review.googlesource.com/71700 > > > > > > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > > > > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > > > Cr-Commit-Position: refs/heads/master@{#23251} > > > > > > > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > > > > > > > Change-Id: I61fb749797314ca514691b341c66f7f39ef45491 > > > > > No-Presubmit: true > > > > > No-Tree-Checks: true > > > > > No-Try: true > > > > > Bug: webrtc:8821 > > > > > Reviewed-on: https://webrtc-review.googlesource.com/77220 > > > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > > Cr-Commit-Position: refs/heads/master@{#23264} > > > > > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > > > > > Bug: webrtc:8821 > > > > Change-Id: I71dea953a002a0d526949c627653bcad0c6518fc > > > > Reviewed-on: https://webrtc-review.googlesource.com/77781 > > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > Cr-Commit-Position: refs/heads/master@{#23317} > > > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > > > Change-Id: I6010f9264dba7bcc4e82c4f4bbfb2eca561e500e > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: webrtc:8821, chromium:845158 > > > Reviewed-on: https://webrtc-review.googlesource.com/78061 > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > Cr-Commit-Position: refs/heads/master@{#23328} > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: webrtc:8821, chromium:845158 > > Change-Id: Iebe0958012c39e1321487e5425f43904eaf5fe91 > > Reviewed-on: https://webrtc-review.googlesource.com/78705 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#23403} > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > Change-Id: I8285cf59402aa6862ea7e3ec21f885360b7050fb > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:8821, chromium:845158 > Reviewed-on: https://webrtc-review.googlesource.com/79420 > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#23416} TBR=phoglund@webrtc.org,mbonadei@webrtc.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: webrtc:8821, chromium:845158 Change-Id: I18ffdb0d7be61daf0b6464c68d219aa352f42dde Reviewed-on: https://webrtc-review.googlesource.com/79582 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23435}
2018-05-29 14:22:32 +00:00
public_configs = [
rtc_common_inherited_config,
absl_include_config,
absl_define_config,
]
if (defined(testonly) && testonly) {
public_configs += [ absl_flags_config ]
}
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
if (defined(invoker.public_configs)) {
public_configs += invoker.public_configs
}
# If absl_deps is [], no action is needed. If not [], then it needs to be
# converted to //third_party/abseil-cpp:absl when build_with_chromium=true
# otherwise it just needs to be added to deps.
if (absl_deps != []) {
if (!defined(deps)) {
deps = []
}
if (build_with_chromium) {
deps += [ "//third_party/abseil-cpp:absl" ]
} else {
deps += absl_deps
}
}
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
}
}
# This template automatically switches the target type between source_set
# and static_library.
#
# This should be the default target type for all the WebRTC targets with
# one exception. Do not use this template for header only targets, in that case
# rtc_source_set must be used in order to avoid build errors (e.g. libtool
# complains if the output .a file is empty).
#
# How does it work:
# Since all files in a source_set are linked into a final binary, while files
# in a static library are only linked in if at least one symbol in them is
# referenced, in component builds source_sets are easy to deal with because
# all their object files are passed to the linker to create a shared library.
# In release builds instead, static_libraries are preferred since they allow
# the linker to discard dead code.
# For the same reason, testonly targets will always be expanded to
# source_set in order to be sure that tests are present in the test binary.
template("rtc_library") {
if (is_component_build || (defined(invoker.testonly) && invoker.testonly)) {
target_type = "source_set"
} else {
target_type = "static_library"
}
target(target_type, target_name) {
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
forward_variables_from(invoker,
"*",
[
"configs",
"public_configs",
"suppressed_configs",
"visibility",
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
])
forward_variables_from(invoker, [ "visibility" ])
Revert "Revert "GN rtc_* templates: Set default visibility to webrtc_root + "/*""" This reverts commit c73e1f437889d882cbf2987f7fb3a029a6150613. Reason for revert: The problem with failed deps in chrome content/renderer had already been fixed in https://webrtc-review.googlesource.com/c/src/+/38660 Original change's description: > Revert "GN rtc_* templates: Set default visibility to webrtc_root + "/*"" > > This reverts commit 588c548657b3ddf76e7b3f241263eef7f5799f16. > > Reason for revert: > > Breaks Chrome FYI: > > /b/c/b/Linux_Builder/src/buildtools/linux64/gn gen //out/Release --check > -> returned 1 > ERROR at //build/split_static_library.gni:12:5: Dependency not allowed. > static_library(target_name) { > ^---------------------------- > The item //content/renderer:renderer > can not depend on //third_party/webrtc/media:rtc_internal_video_codecs > because it is not in //third_party/webrtc/media:rtc_internal_video_codecs's visibility list: [ > //third_party/webrtc/* > //third_party/webrtc_overrides/* > ] > > https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.webrtc.fyi%2FLinux_Builder%2F23560%2F%2B%2Frecipes%2Fsteps%2Fgenerate_build_files%2F0%2Fstdout > > Original change's description: > > GN rtc_* templates: Set default visibility to webrtc_root + "/*" > > > > This means that by default, targets are visible to everything under > > the WebRTC root, but not visible to anything else. > > > > API targets are manually tagged with visibility "*", so that targets > > outside the WebRTC tree can see them. > > > > BUG=webrtc:8254 > > > > Change-Id: Icdbee6e0d22d93240ff2fb530c8f9dc48e351509 > > Reviewed-on: https://webrtc-review.googlesource.com/24140 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#21548} > > TBR=mbonadei@webrtc.org,kwiberg@webrtc.org > > Change-Id: I06620ce3d6f67482935c22efa231dd6cab91625a > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:8254 > Reviewed-on: https://webrtc-review.googlesource.com/38760 > Reviewed-by: Per Kjellander <perkj@webrtc.org> > Commit-Queue: Per Kjellander <perkj@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#21555} TBR=mbonadei@webrtc.org,kwiberg@webrtc.org,perkj@webrtc.org Change-Id: I6f720078ce21bd172e0a6471bae8c4c011e4a657 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:8254 Reviewed-on: https://webrtc-review.googlesource.com/38860 Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Per Kjellander <perkj@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21558}
2018-01-10 15:54:53 +00:00
if (!defined(visibility)) {
visibility = webrtc_default_visibility
}
# What's your poison?
if (defined(testonly) && testonly) {
assert(!defined(poisonous))
assert(!defined(allow_poison))
} else {
if (!defined(poisonous)) {
poisonous = []
}
if (!defined(allow_poison)) {
allow_poison = []
}
if (!defined(assert_no_deps)) {
assert_no_deps = []
}
if (!defined(deps)) {
deps = []
}
foreach(p, poisonous) {
deps += [ webrtc_root + ":poison_" + p ]
}
foreach(poison_type, all_poison_types) {
allow_dep = true
foreach(v, visibility) {
if (v == "*") {
allow_dep = false
}
}
foreach(p, allow_poison + poisonous) {
if (p == poison_type) {
allow_dep = true
}
}
if (!allow_dep) {
assert_no_deps += [ webrtc_root + ":poison_" + poison_type ]
}
}
}
# Chromium should only depend on the WebRTC component in order to
# avoid to statically link WebRTC in a component build.
if (build_with_chromium) {
publicly_visible = false
foreach(v, visibility) {
if (v == "*") {
publicly_visible = true
}
}
if (publicly_visible) {
visibility = []
visibility = webrtc_default_visibility
}
}
if (!defined(testonly) || !testonly) {
configs += rtc_prod_configs
}
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
configs += invoker.configs
Reland "Add RTC_EXPORT macro to export WebRTC symbols." This is a reland of 55daf1aef65218a97eff88999e5190a2f2f6b72e. In order to avoid problems on case insensitive file systems this CL moves rtc_export.h to rtc_base/system (avoiding problems with build/). Diff: https://webrtc-review.googlesource.com/c/src/+/100804/1..2. Original change's description: > Add RTC_EXPORT macro to export WebRTC symbols. > > This CL introduces the utility macro RTC_EXPORT which will let WebRTC > developers decide which symbols are supposed to be exported/imported > and which ones are private. > > RTC_EXPORT will only export/import symbols in a component build, more > info: https://cs.chromium.org/chromium/src/docs/component_build.md. > During a component build, the macro COMPONENT_BUILD will be globally > defined in a consistent fashion so it is safe to rely on it to > understand how to expand RTC_EXPORT. > In a non component build, RTC_EXPORT will expand to nothing. > > Bug: webrtc:9419 > Change-Id: Ic58162783be7f5883136ade27f324d6d34fdf932 > Reviewed-on: https://webrtc-review.googlesource.com/97960 > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > Reviewed-by: Niels Moller <nisse@webrtc.org> > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > Reviewed-by: Yves Gerey <yvesg@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#24757} Bug: webrtc:9419 Change-Id: Icfedea5fc3416ea1af2185de443fa879fb2dee8b Reviewed-on: https://webrtc-review.googlesource.com/100804 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24766}
2018-09-18 13:15:54 +02:00
configs += rtc_library_impl_config
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
configs -= rtc_remove_configs
configs -= invoker.suppressed_configs
Reland "Reland "Adding absl includes and defines to rtc_* templates."" This reverts commit 759eb4f2ad7e23b65fe0b834f8ba7f580bf1a933. Reason for revert: The problem has been fixed in https://chromium-review.googlesource.com/1075889. Original change's description: > Revert "Reland "Adding absl includes and defines to rtc_* templates."" > > This reverts commit fae51e4c95780f59f4bedf6e01403ff86152e168. > > Reason for revert: > When use_xcode_clang = true we get: > error: unknown warning option '-Wno-unused-template'; did you mean '-Wno-unused-result'? [-Werror,-Wunknown-warning-option] > error: unknown warning option '-Wno-zero-as-null-pointer-constant'; did you mean '-Wno-int-to-void-pointer-cast'? [-Werror,-Wunknown-warning-option] > > > Original change's description: > > Reland "Adding absl includes and defines to rtc_* templates." > > > > This reverts commit 8436a699a998e4fa30d97786142baad08f110d2a. > > > > Reason for revert: > > New absl roll -> https://chromium-review.googlesource.com/1071468 > > > > Original change's description: > > > Revert "Reland "Adding absl includes and defines to rtc_* templates."" > > > > > > This reverts commit bdb0fe42bc46d190ca45fc5a6658eddbfa5eead5. > > > > > > Reason for revert: https://ci.chromium.org/buildbot/chromium.fyi/Jumbo%20Win%20x64/11502 > > > > > > Original change's description: > > > > Reland "Adding absl includes and defines to rtc_* templates." > > > > > > > > This reverts commit 85cb19fec7caf558dee7a09aafabe01c5ac78f3f. > > > > > > > > Reason for revert: The new version of Abseil should fix the previous > > > > issue. > > > > > > > > Original change's description: > > > > > Revert "Reland "Adding absl includes and defines to rtc_* templates."" > > > > > > > > > > This reverts commit 9632112a16d70a146e917db4de761e6253dfc364. > > > > > > > > > > Reason for revert: It breaks the WebRTC roll into Chromium. > > > > > https://chromium-review.googlesource.com/c/chromium/src/+/1061476 > > > > > > > > > > Original change's description: > > > > > > Reland "Adding absl includes and defines to rtc_* templates." > > > > > > > > > > > > This reverts commit d161eda477491b2b97fb3f26d229c625a2a0e9b8. > > > > > > > > > > > > Reason for revert: The problem with iOS trybots should be fixed. > > > > > > > > > > > > Original change's description: > > > > > > > Revert "Adding absl includes and defines to rtc_* templates." > > > > > > > > > > > > > > This reverts commit 9d8f3850f4c4faad5dc5ab32ab6f2c9c43df7b6c. > > > > > > > > > > > > > > Reason for revert: Breaks some trybots: https://build.chromium.org/p/client.webrtc/builders/iOS64%20Release/builds/12793. > > > > > > > > > > > > > > Original change's description: > > > > > > > > Adding absl includes and defines to rtc_* templates. > > > > > > > > > > > > > > > > This CL implicitly adds the -I compiler flag and absl macros to WebRTC > > > > > > > > templates. In order to include absl headers using relative paths, WebRTC > > > > > > > > needs to ensure that all its build targets are able to see absl headers. > > > > > > > > > > > > > > > > This can also be done with public_deps, but WebRTC is trying to avoid > > > > > > > > it because it creates problems with other build systems. Given this > > > > > > > > constraint, using rtc_* templates is the most reliable solution. > > > > > > > > > > > > > > > > Please note that rtc_* templates are adding absl includes and defines > > > > > > > > as public_configs, this means that build targets with WebRTC targets > > > > > > > > in their public_deps will propagate these configs following the GN > > > > > > > > guideline. > > > > > > > > > > > > > > > > Bug: webrtc:8821 > > > > > > > > Change-Id: I4aa594a524f4bd045bcb3e80d76cc27f06fe01d7 > > > > > > > > Reviewed-on: https://webrtc-review.googlesource.com/70367 > > > > > > > > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > > > > > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > > > > > Cr-Commit-Position: refs/heads/master@{#22927} > > > > > > > > > > > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > > > > > > > > > > > Change-Id: Id8e1f881c57553386566eb1970f6b9f8632cab37 > > > > > > > No-Presubmit: true > > > > > > > No-Tree-Checks: true > > > > > > > No-Try: true > > > > > > > Bug: webrtc:8821 > > > > > > > Reviewed-on: https://webrtc-review.googlesource.com/71000 > > > > > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > > > > Cr-Commit-Position: refs/heads/master@{#22928} > > > > > > > > > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > > > > > > > > > Bug: webrtc:8821 > > > > > > Change-Id: I6ee2eda97bbcd4c9be25c9c4073272192b0373f8 > > > > > > Reviewed-on: https://webrtc-review.googlesource.com/71700 > > > > > > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > > > > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > > > Cr-Commit-Position: refs/heads/master@{#23251} > > > > > > > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > > > > > > > Change-Id: I61fb749797314ca514691b341c66f7f39ef45491 > > > > > No-Presubmit: true > > > > > No-Tree-Checks: true > > > > > No-Try: true > > > > > Bug: webrtc:8821 > > > > > Reviewed-on: https://webrtc-review.googlesource.com/77220 > > > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > > Cr-Commit-Position: refs/heads/master@{#23264} > > > > > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > > > > > Bug: webrtc:8821 > > > > Change-Id: I71dea953a002a0d526949c627653bcad0c6518fc > > > > Reviewed-on: https://webrtc-review.googlesource.com/77781 > > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > Cr-Commit-Position: refs/heads/master@{#23317} > > > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > > > Change-Id: I6010f9264dba7bcc4e82c4f4bbfb2eca561e500e > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: webrtc:8821, chromium:845158 > > > Reviewed-on: https://webrtc-review.googlesource.com/78061 > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > Cr-Commit-Position: refs/heads/master@{#23328} > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: webrtc:8821, chromium:845158 > > Change-Id: Iebe0958012c39e1321487e5425f43904eaf5fe91 > > Reviewed-on: https://webrtc-review.googlesource.com/78705 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#23403} > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > Change-Id: I8285cf59402aa6862ea7e3ec21f885360b7050fb > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:8821, chromium:845158 > Reviewed-on: https://webrtc-review.googlesource.com/79420 > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#23416} TBR=phoglund@webrtc.org,mbonadei@webrtc.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: webrtc:8821, chromium:845158 Change-Id: I18ffdb0d7be61daf0b6464c68d219aa352f42dde Reviewed-on: https://webrtc-review.googlesource.com/79582 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23435}
2018-05-29 14:22:32 +00:00
public_configs = [
rtc_common_inherited_config,
absl_include_config,
absl_define_config,
]
if (defined(testonly) && testonly) {
public_configs += [ absl_flags_config ]
}
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
if (defined(invoker.public_configs)) {
public_configs += invoker.public_configs
}
# If absl_deps is [], no action is needed. If not [], then it needs to be
# converted to //third_party/abseil-cpp:absl when build_with_chromium=true
# otherwise it just needs to be added to deps.
if (absl_deps != []) {
if (!defined(deps)) {
deps = []
}
if (build_with_chromium) {
deps += [ "//third_party/abseil-cpp:absl" ]
} else {
deps += absl_deps
}
}
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
}
}
template("rtc_executable") {
executable(target_name) {
forward_variables_from(invoker,
"*",
[
"deps",
"configs",
"public_configs",
"suppressed_configs",
"visibility",
])
forward_variables_from(invoker, [ "visibility" ])
if (!defined(visibility)) {
visibility = webrtc_default_visibility
}
configs += invoker.configs
configs -= rtc_remove_configs
configs -= invoker.suppressed_configs
deps = invoker.deps
public_configs = [
rtc_common_inherited_config,
absl_include_config,
absl_define_config,
]
if (defined(testonly) && testonly) {
public_configs += [ absl_flags_config ]
}
if (defined(invoker.public_configs)) {
public_configs += invoker.public_configs
}
if (is_win) {
deps += [
# Give executables the default manifest on Windows (a no-op elsewhere).
"//build/win:default_exe_manifest",
]
}
}
}
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
template("rtc_shared_library") {
shared_library(target_name) {
forward_variables_from(invoker,
"*",
[
"configs",
"public_configs",
"suppressed_configs",
"visibility",
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
])
forward_variables_from(invoker, [ "visibility" ])
Revert "Revert "GN rtc_* templates: Set default visibility to webrtc_root + "/*""" This reverts commit c73e1f437889d882cbf2987f7fb3a029a6150613. Reason for revert: The problem with failed deps in chrome content/renderer had already been fixed in https://webrtc-review.googlesource.com/c/src/+/38660 Original change's description: > Revert "GN rtc_* templates: Set default visibility to webrtc_root + "/*"" > > This reverts commit 588c548657b3ddf76e7b3f241263eef7f5799f16. > > Reason for revert: > > Breaks Chrome FYI: > > /b/c/b/Linux_Builder/src/buildtools/linux64/gn gen //out/Release --check > -> returned 1 > ERROR at //build/split_static_library.gni:12:5: Dependency not allowed. > static_library(target_name) { > ^---------------------------- > The item //content/renderer:renderer > can not depend on //third_party/webrtc/media:rtc_internal_video_codecs > because it is not in //third_party/webrtc/media:rtc_internal_video_codecs's visibility list: [ > //third_party/webrtc/* > //third_party/webrtc_overrides/* > ] > > https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.webrtc.fyi%2FLinux_Builder%2F23560%2F%2B%2Frecipes%2Fsteps%2Fgenerate_build_files%2F0%2Fstdout > > Original change's description: > > GN rtc_* templates: Set default visibility to webrtc_root + "/*" > > > > This means that by default, targets are visible to everything under > > the WebRTC root, but not visible to anything else. > > > > API targets are manually tagged with visibility "*", so that targets > > outside the WebRTC tree can see them. > > > > BUG=webrtc:8254 > > > > Change-Id: Icdbee6e0d22d93240ff2fb530c8f9dc48e351509 > > Reviewed-on: https://webrtc-review.googlesource.com/24140 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#21548} > > TBR=mbonadei@webrtc.org,kwiberg@webrtc.org > > Change-Id: I06620ce3d6f67482935c22efa231dd6cab91625a > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:8254 > Reviewed-on: https://webrtc-review.googlesource.com/38760 > Reviewed-by: Per Kjellander <perkj@webrtc.org> > Commit-Queue: Per Kjellander <perkj@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#21555} TBR=mbonadei@webrtc.org,kwiberg@webrtc.org,perkj@webrtc.org Change-Id: I6f720078ce21bd172e0a6471bae8c4c011e4a657 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:8254 Reviewed-on: https://webrtc-review.googlesource.com/38860 Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Per Kjellander <perkj@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21558}
2018-01-10 15:54:53 +00:00
if (!defined(visibility)) {
visibility = webrtc_default_visibility
}
# What's your poison?
if (defined(testonly) && testonly) {
assert(!defined(poisonous))
assert(!defined(allow_poison))
} else {
if (!defined(poisonous)) {
poisonous = []
}
if (!defined(allow_poison)) {
allow_poison = []
}
if (!defined(assert_no_deps)) {
assert_no_deps = []
}
if (!defined(deps)) {
deps = []
}
foreach(p, poisonous) {
deps += [ webrtc_root + ":poison_" + p ]
}
foreach(poison_type, all_poison_types) {
allow_dep = true
foreach(v, visibility) {
if (v == "*") {
allow_dep = false
}
}
foreach(p, allow_poison + poisonous) {
if (p == poison_type) {
allow_dep = true
}
}
if (!allow_dep) {
assert_no_deps += [ webrtc_root + ":poison_" + poison_type ]
}
}
}
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
configs += invoker.configs
configs -= rtc_remove_configs
configs -= invoker.suppressed_configs
Reland "Reland "Adding absl includes and defines to rtc_* templates."" This reverts commit 759eb4f2ad7e23b65fe0b834f8ba7f580bf1a933. Reason for revert: The problem has been fixed in https://chromium-review.googlesource.com/1075889. Original change's description: > Revert "Reland "Adding absl includes and defines to rtc_* templates."" > > This reverts commit fae51e4c95780f59f4bedf6e01403ff86152e168. > > Reason for revert: > When use_xcode_clang = true we get: > error: unknown warning option '-Wno-unused-template'; did you mean '-Wno-unused-result'? [-Werror,-Wunknown-warning-option] > error: unknown warning option '-Wno-zero-as-null-pointer-constant'; did you mean '-Wno-int-to-void-pointer-cast'? [-Werror,-Wunknown-warning-option] > > > Original change's description: > > Reland "Adding absl includes and defines to rtc_* templates." > > > > This reverts commit 8436a699a998e4fa30d97786142baad08f110d2a. > > > > Reason for revert: > > New absl roll -> https://chromium-review.googlesource.com/1071468 > > > > Original change's description: > > > Revert "Reland "Adding absl includes and defines to rtc_* templates."" > > > > > > This reverts commit bdb0fe42bc46d190ca45fc5a6658eddbfa5eead5. > > > > > > Reason for revert: https://ci.chromium.org/buildbot/chromium.fyi/Jumbo%20Win%20x64/11502 > > > > > > Original change's description: > > > > Reland "Adding absl includes and defines to rtc_* templates." > > > > > > > > This reverts commit 85cb19fec7caf558dee7a09aafabe01c5ac78f3f. > > > > > > > > Reason for revert: The new version of Abseil should fix the previous > > > > issue. > > > > > > > > Original change's description: > > > > > Revert "Reland "Adding absl includes and defines to rtc_* templates."" > > > > > > > > > > This reverts commit 9632112a16d70a146e917db4de761e6253dfc364. > > > > > > > > > > Reason for revert: It breaks the WebRTC roll into Chromium. > > > > > https://chromium-review.googlesource.com/c/chromium/src/+/1061476 > > > > > > > > > > Original change's description: > > > > > > Reland "Adding absl includes and defines to rtc_* templates." > > > > > > > > > > > > This reverts commit d161eda477491b2b97fb3f26d229c625a2a0e9b8. > > > > > > > > > > > > Reason for revert: The problem with iOS trybots should be fixed. > > > > > > > > > > > > Original change's description: > > > > > > > Revert "Adding absl includes and defines to rtc_* templates." > > > > > > > > > > > > > > This reverts commit 9d8f3850f4c4faad5dc5ab32ab6f2c9c43df7b6c. > > > > > > > > > > > > > > Reason for revert: Breaks some trybots: https://build.chromium.org/p/client.webrtc/builders/iOS64%20Release/builds/12793. > > > > > > > > > > > > > > Original change's description: > > > > > > > > Adding absl includes and defines to rtc_* templates. > > > > > > > > > > > > > > > > This CL implicitly adds the -I compiler flag and absl macros to WebRTC > > > > > > > > templates. In order to include absl headers using relative paths, WebRTC > > > > > > > > needs to ensure that all its build targets are able to see absl headers. > > > > > > > > > > > > > > > > This can also be done with public_deps, but WebRTC is trying to avoid > > > > > > > > it because it creates problems with other build systems. Given this > > > > > > > > constraint, using rtc_* templates is the most reliable solution. > > > > > > > > > > > > > > > > Please note that rtc_* templates are adding absl includes and defines > > > > > > > > as public_configs, this means that build targets with WebRTC targets > > > > > > > > in their public_deps will propagate these configs following the GN > > > > > > > > guideline. > > > > > > > > > > > > > > > > Bug: webrtc:8821 > > > > > > > > Change-Id: I4aa594a524f4bd045bcb3e80d76cc27f06fe01d7 > > > > > > > > Reviewed-on: https://webrtc-review.googlesource.com/70367 > > > > > > > > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > > > > > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > > > > > Cr-Commit-Position: refs/heads/master@{#22927} > > > > > > > > > > > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > > > > > > > > > > > Change-Id: Id8e1f881c57553386566eb1970f6b9f8632cab37 > > > > > > > No-Presubmit: true > > > > > > > No-Tree-Checks: true > > > > > > > No-Try: true > > > > > > > Bug: webrtc:8821 > > > > > > > Reviewed-on: https://webrtc-review.googlesource.com/71000 > > > > > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > > > > Cr-Commit-Position: refs/heads/master@{#22928} > > > > > > > > > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > > > > > > > > > Bug: webrtc:8821 > > > > > > Change-Id: I6ee2eda97bbcd4c9be25c9c4073272192b0373f8 > > > > > > Reviewed-on: https://webrtc-review.googlesource.com/71700 > > > > > > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > > > > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > > > Cr-Commit-Position: refs/heads/master@{#23251} > > > > > > > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > > > > > > > Change-Id: I61fb749797314ca514691b341c66f7f39ef45491 > > > > > No-Presubmit: true > > > > > No-Tree-Checks: true > > > > > No-Try: true > > > > > Bug: webrtc:8821 > > > > > Reviewed-on: https://webrtc-review.googlesource.com/77220 > > > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > > Cr-Commit-Position: refs/heads/master@{#23264} > > > > > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > > > > > Bug: webrtc:8821 > > > > Change-Id: I71dea953a002a0d526949c627653bcad0c6518fc > > > > Reviewed-on: https://webrtc-review.googlesource.com/77781 > > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > Cr-Commit-Position: refs/heads/master@{#23317} > > > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > > > Change-Id: I6010f9264dba7bcc4e82c4f4bbfb2eca561e500e > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: webrtc:8821, chromium:845158 > > > Reviewed-on: https://webrtc-review.googlesource.com/78061 > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > Cr-Commit-Position: refs/heads/master@{#23328} > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: webrtc:8821, chromium:845158 > > Change-Id: Iebe0958012c39e1321487e5425f43904eaf5fe91 > > Reviewed-on: https://webrtc-review.googlesource.com/78705 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#23403} > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > Change-Id: I8285cf59402aa6862ea7e3ec21f885360b7050fb > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:8821, chromium:845158 > Reviewed-on: https://webrtc-review.googlesource.com/79420 > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#23416} TBR=phoglund@webrtc.org,mbonadei@webrtc.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: webrtc:8821, chromium:845158 Change-Id: I18ffdb0d7be61daf0b6464c68d219aa352f42dde Reviewed-on: https://webrtc-review.googlesource.com/79582 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23435}
2018-05-29 14:22:32 +00:00
public_configs = [
rtc_common_inherited_config,
absl_include_config,
absl_define_config,
]
if (defined(testonly) && testonly) {
public_configs += [ absl_flags_config ]
}
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
if (defined(invoker.public_configs)) {
public_configs += invoker.public_configs
}
}
}
if (is_ios) {
# TODO: Generate module.modulemap file to enable use in Swift
# projects. See "mac_framework_bundle_with_umbrella_header".
template("ios_framework_bundle_with_umbrella_header") {
forward_variables_from(invoker, [ "output_name" ])
Reland "Remove placeholder Obj-C headers and use angle-bracketed headers." This is a reland of 37d41eea047799ccca2f09c941870c26ee3ffc0a Original change's description: > Reland "Remove placeholder Obj-C headers and use angle-bracketed headers." > > This is a reland of 6bfad33fd866e682c871c2ef2172b70b609593d1 > > Original change's description: > > Remove placeholder Obj-C headers and use angle-bracketed headers. > > > > sdk/objc/Framework/Headers are just a placeholder headers > > for backward compatibility and I don't think it is really need this for now. > > Instead, we can generate the framework header in > > ios/mac_framework_bundle_with_umbrella_header. > > Also clang supports the -Wquoted-include-in-framework-header warning, > > and in Xcode 12, it's in Xcode's recommended settings. This warnings > > can be avoided by replacing double-quoted includes with angle-bracketed > > includes when generate framework headers. > > > > No-Presubmit: True > > Bug: webrtc:9627, webrtc:11984 > > Change-Id: I3f6258dfa77a5acee669614005b2747feee35e39 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185920 > > Commit-Queue: Anders Carlsson <andersc@webrtc.org> > > Reviewed-by: Anders Carlsson <andersc@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#32343} > > TBR=tommi@webrtc.org, andersc@webrtc.org > > No-Presubmit: True > Bug: webrtc:9627 > Bug: webrtc:11984 > Change-Id: I8f44232f1a70b8ff2ce6a4b4792f0a18472fcec3 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/187280 > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#32429} TBR=tommi@webrtc.org, andersc@webrtc.org No-Presubmit: True Bug: webrtc:9627 Bug: webrtc:11984 Change-Id: Ida92b8864dffaea37d3053d3c00381644988b54e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/189781 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32470}
2020-10-17 07:49:28 +09:00
this_target_name = target_name
umbrella_header_path =
Reland "Remove placeholder Obj-C headers and use angle-bracketed headers." This is a reland of 37d41eea047799ccca2f09c941870c26ee3ffc0a Original change's description: > Reland "Remove placeholder Obj-C headers and use angle-bracketed headers." > > This is a reland of 6bfad33fd866e682c871c2ef2172b70b609593d1 > > Original change's description: > > Remove placeholder Obj-C headers and use angle-bracketed headers. > > > > sdk/objc/Framework/Headers are just a placeholder headers > > for backward compatibility and I don't think it is really need this for now. > > Instead, we can generate the framework header in > > ios/mac_framework_bundle_with_umbrella_header. > > Also clang supports the -Wquoted-include-in-framework-header warning, > > and in Xcode 12, it's in Xcode's recommended settings. This warnings > > can be avoided by replacing double-quoted includes with angle-bracketed > > includes when generate framework headers. > > > > No-Presubmit: True > > Bug: webrtc:9627, webrtc:11984 > > Change-Id: I3f6258dfa77a5acee669614005b2747feee35e39 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185920 > > Commit-Queue: Anders Carlsson <andersc@webrtc.org> > > Reviewed-by: Anders Carlsson <andersc@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#32343} > > TBR=tommi@webrtc.org, andersc@webrtc.org > > No-Presubmit: True > Bug: webrtc:9627 > Bug: webrtc:11984 > Change-Id: I8f44232f1a70b8ff2ce6a4b4792f0a18472fcec3 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/187280 > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#32429} TBR=tommi@webrtc.org, andersc@webrtc.org No-Presubmit: True Bug: webrtc:9627 Bug: webrtc:11984 Change-Id: Ida92b8864dffaea37d3053d3c00381644988b54e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/189781 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32470}
2020-10-17 07:49:28 +09:00
"$target_gen_dir/$output_name.framework/WebRTC/$output_name.h"
action_foreach("create_bracket_include_headers_$target_name") {
script = "//tools_webrtc/apple/copy_framework_header.py"
sources = invoker.sources
output_name = invoker.output_name
outputs = [
"$target_gen_dir/$output_name.framework/WebRTC/{{source_file_part}}",
]
args = [
"--input",
"{{source}}",
"--output",
rebase_path(target_gen_dir, root_build_dir) +
"/$output_name.framework/WebRTC/{{source_file_part}}",
]
}
ios_framework_bundle(target_name) {
Reland "Remove placeholder Obj-C headers and use angle-bracketed headers." This is a reland of 37d41eea047799ccca2f09c941870c26ee3ffc0a Original change's description: > Reland "Remove placeholder Obj-C headers and use angle-bracketed headers." > > This is a reland of 6bfad33fd866e682c871c2ef2172b70b609593d1 > > Original change's description: > > Remove placeholder Obj-C headers and use angle-bracketed headers. > > > > sdk/objc/Framework/Headers are just a placeholder headers > > for backward compatibility and I don't think it is really need this for now. > > Instead, we can generate the framework header in > > ios/mac_framework_bundle_with_umbrella_header. > > Also clang supports the -Wquoted-include-in-framework-header warning, > > and in Xcode 12, it's in Xcode's recommended settings. This warnings > > can be avoided by replacing double-quoted includes with angle-bracketed > > includes when generate framework headers. > > > > No-Presubmit: True > > Bug: webrtc:9627, webrtc:11984 > > Change-Id: I3f6258dfa77a5acee669614005b2747feee35e39 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185920 > > Commit-Queue: Anders Carlsson <andersc@webrtc.org> > > Reviewed-by: Anders Carlsson <andersc@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#32343} > > TBR=tommi@webrtc.org, andersc@webrtc.org > > No-Presubmit: True > Bug: webrtc:9627 > Bug: webrtc:11984 > Change-Id: I8f44232f1a70b8ff2ce6a4b4792f0a18472fcec3 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/187280 > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#32429} TBR=tommi@webrtc.org, andersc@webrtc.org No-Presubmit: True Bug: webrtc:9627 Bug: webrtc:11984 Change-Id: Ida92b8864dffaea37d3053d3c00381644988b54e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/189781 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32470}
2020-10-17 07:49:28 +09:00
forward_variables_from(invoker, "*", [ "public_headers" ])
public_headers = get_target_outputs(
":create_bracket_include_headers_$this_target_name")
deps += [
":copy_umbrella_header_$target_name",
":create_bracket_include_headers_$target_name",
]
}
action("umbrella_header_$target_name") {
Reland "Remove placeholder Obj-C headers and use angle-bracketed headers." This is a reland of 37d41eea047799ccca2f09c941870c26ee3ffc0a Original change's description: > Reland "Remove placeholder Obj-C headers and use angle-bracketed headers." > > This is a reland of 6bfad33fd866e682c871c2ef2172b70b609593d1 > > Original change's description: > > Remove placeholder Obj-C headers and use angle-bracketed headers. > > > > sdk/objc/Framework/Headers are just a placeholder headers > > for backward compatibility and I don't think it is really need this for now. > > Instead, we can generate the framework header in > > ios/mac_framework_bundle_with_umbrella_header. > > Also clang supports the -Wquoted-include-in-framework-header warning, > > and in Xcode 12, it's in Xcode's recommended settings. This warnings > > can be avoided by replacing double-quoted includes with angle-bracketed > > includes when generate framework headers. > > > > No-Presubmit: True > > Bug: webrtc:9627, webrtc:11984 > > Change-Id: I3f6258dfa77a5acee669614005b2747feee35e39 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185920 > > Commit-Queue: Anders Carlsson <andersc@webrtc.org> > > Reviewed-by: Anders Carlsson <andersc@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#32343} > > TBR=tommi@webrtc.org, andersc@webrtc.org > > No-Presubmit: True > Bug: webrtc:9627 > Bug: webrtc:11984 > Change-Id: I8f44232f1a70b8ff2ce6a4b4792f0a18472fcec3 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/187280 > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#32429} TBR=tommi@webrtc.org, andersc@webrtc.org No-Presubmit: True Bug: webrtc:9627 Bug: webrtc:11984 Change-Id: Ida92b8864dffaea37d3053d3c00381644988b54e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/189781 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32470}
2020-10-17 07:49:28 +09:00
public_headers = get_target_outputs(
":create_bracket_include_headers_$this_target_name")
script = "//tools_webrtc/ios/generate_umbrella_header.py"
outputs = [ umbrella_header_path ]
args = [
"--out",
rebase_path(umbrella_header_path, root_build_dir),
"--sources",
] + public_headers
Reland "Remove placeholder Obj-C headers and use angle-bracketed headers." This is a reland of 37d41eea047799ccca2f09c941870c26ee3ffc0a Original change's description: > Reland "Remove placeholder Obj-C headers and use angle-bracketed headers." > > This is a reland of 6bfad33fd866e682c871c2ef2172b70b609593d1 > > Original change's description: > > Remove placeholder Obj-C headers and use angle-bracketed headers. > > > > sdk/objc/Framework/Headers are just a placeholder headers > > for backward compatibility and I don't think it is really need this for now. > > Instead, we can generate the framework header in > > ios/mac_framework_bundle_with_umbrella_header. > > Also clang supports the -Wquoted-include-in-framework-header warning, > > and in Xcode 12, it's in Xcode's recommended settings. This warnings > > can be avoided by replacing double-quoted includes with angle-bracketed > > includes when generate framework headers. > > > > No-Presubmit: True > > Bug: webrtc:9627, webrtc:11984 > > Change-Id: I3f6258dfa77a5acee669614005b2747feee35e39 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185920 > > Commit-Queue: Anders Carlsson <andersc@webrtc.org> > > Reviewed-by: Anders Carlsson <andersc@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#32343} > > TBR=tommi@webrtc.org, andersc@webrtc.org > > No-Presubmit: True > Bug: webrtc:9627 > Bug: webrtc:11984 > Change-Id: I8f44232f1a70b8ff2ce6a4b4792f0a18472fcec3 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/187280 > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#32429} TBR=tommi@webrtc.org, andersc@webrtc.org No-Presubmit: True Bug: webrtc:9627 Bug: webrtc:11984 Change-Id: Ida92b8864dffaea37d3053d3c00381644988b54e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/189781 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32470}
2020-10-17 07:49:28 +09:00
deps = [ ":create_bracket_include_headers_$this_target_name" ]
}
if (target_environment == "catalyst") {
# Catalyst frameworks use the same layout as regular Mac frameworks.
headers_dir = "Versions/A/Headers"
} else {
headers_dir = "Headers"
}
copy("copy_umbrella_header_$target_name") {
sources = [ umbrella_header_path ]
outputs =
[ "$root_out_dir/$output_name.framework/$headers_dir/$output_name.h" ]
deps = [ ":umbrella_header_$target_name" ]
}
}
set_defaults("ios_framework_bundle_with_umbrella_header") {
configs = default_shared_library_configs
}
}
Reland: "Make javac warnings errors for WebRTC targets." This reverts commit 2bad72a27329ff30ceb9479253f5eb3d21888d25. Reason for revert: Fixing downstream projects (take 2). Original change's description: > Reland "Revert "Make javac warnings errors for WebRTC targets."" > > This is a reland of 098d24c3c18f4b1fd043d7ba716d7601f0ce2b74 > Original change's description: > > Revert "Make javac warnings errors for WebRTC targets." > > > > This reverts commit 19b761403c3522902d69d61179f4d184e3632f79. > > > > Reason for revert: Breaking internal builds > > > > Original change's description: > > > Make javac warnings errors for WebRTC targets. > > > > > > Adds new rtc_* templates for Android targets to allow specifying > > > default values that affect WebRTC targets. > > > > > > Bug: webrtc:6597 > > > Change-Id: Ie529bfc8500d1e785b8a59dba7078b5f88ccfcd1 > > > Reviewed-on: https://webrtc-review.googlesource.com/15103 > > > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > > > Commit-Queue: Sami Kalliomäki <sakal@webrtc.org> > > > Cr-Commit-Position: refs/heads/master@{#20567} > > > TBR=phoglund@webrtc.org,sakal@webrtc.org > > > > Change-Id: I6d3ff5604b3d4307765d3a65adb783f89fcc974c > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: webrtc:6597 > > Reviewed-on: https://webrtc-review.googlesource.com/20740 > > Reviewed-by: Lu Liu <lliuu@webrtc.org> > > Commit-Queue: Lu Liu <lliuu@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#20571} > > Bug: webrtc:6597 > Change-Id: Icfb5ded46ce76b674bae67bfa02054b4ec52bb0f > Reviewed-on: https://webrtc-review.googlesource.com/20800 > Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org> > Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#20577} TBR=phoglund@webrtc.org,ehmaldonado@webrtc.org,mbonadei@webrtc.org,sakal@webrtc.org,lliuu@webrtc.org Change-Id: Id3713c1885318741711987ae642a269a9ca5bb85 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:6597 Reviewed-on: https://webrtc-review.googlesource.com/18441 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20588}
2017-11-07 15:36:33 +00:00
if (is_mac) {
template("mac_framework_bundle_with_umbrella_header") {
forward_variables_from(invoker, [ "output_name" ])
this_target_name = target_name
umbrella_header_path = "$target_gen_dir/umbrella_header/$output_name.h"
modulemap_path = "$target_gen_dir/Modules/module.modulemap"
mac_framework_bundle(target_name) {
forward_variables_from(invoker, "*", [ "configs" ])
if (defined(invoker.configs)) {
configs += invoker.configs
}
framework_version = "A"
framework_contents = [
"Headers",
"Modules",
"Resources",
]
ldflags = [
"-all_load",
"-install_name",
"@rpath/$output_name.framework/$output_name",
]
deps += [
":copy_framework_headers_$this_target_name",
":copy_modulemap_$this_target_name",
":copy_umbrella_header_$this_target_name",
Reland "Remove placeholder Obj-C headers and use angle-bracketed headers." This is a reland of 37d41eea047799ccca2f09c941870c26ee3ffc0a Original change's description: > Reland "Remove placeholder Obj-C headers and use angle-bracketed headers." > > This is a reland of 6bfad33fd866e682c871c2ef2172b70b609593d1 > > Original change's description: > > Remove placeholder Obj-C headers and use angle-bracketed headers. > > > > sdk/objc/Framework/Headers are just a placeholder headers > > for backward compatibility and I don't think it is really need this for now. > > Instead, we can generate the framework header in > > ios/mac_framework_bundle_with_umbrella_header. > > Also clang supports the -Wquoted-include-in-framework-header warning, > > and in Xcode 12, it's in Xcode's recommended settings. This warnings > > can be avoided by replacing double-quoted includes with angle-bracketed > > includes when generate framework headers. > > > > No-Presubmit: True > > Bug: webrtc:9627, webrtc:11984 > > Change-Id: I3f6258dfa77a5acee669614005b2747feee35e39 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185920 > > Commit-Queue: Anders Carlsson <andersc@webrtc.org> > > Reviewed-by: Anders Carlsson <andersc@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#32343} > > TBR=tommi@webrtc.org, andersc@webrtc.org > > No-Presubmit: True > Bug: webrtc:9627 > Bug: webrtc:11984 > Change-Id: I8f44232f1a70b8ff2ce6a4b4792f0a18472fcec3 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/187280 > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#32429} TBR=tommi@webrtc.org, andersc@webrtc.org No-Presubmit: True Bug: webrtc:9627 Bug: webrtc:11984 Change-Id: Ida92b8864dffaea37d3053d3c00381644988b54e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/189781 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32470}
2020-10-17 07:49:28 +09:00
":create_bracket_include_headers_$this_target_name",
":modulemap_$this_target_name",
":umbrella_header_$this_target_name",
]
}
Reland "Remove placeholder Obj-C headers and use angle-bracketed headers." This is a reland of 37d41eea047799ccca2f09c941870c26ee3ffc0a Original change's description: > Reland "Remove placeholder Obj-C headers and use angle-bracketed headers." > > This is a reland of 6bfad33fd866e682c871c2ef2172b70b609593d1 > > Original change's description: > > Remove placeholder Obj-C headers and use angle-bracketed headers. > > > > sdk/objc/Framework/Headers are just a placeholder headers > > for backward compatibility and I don't think it is really need this for now. > > Instead, we can generate the framework header in > > ios/mac_framework_bundle_with_umbrella_header. > > Also clang supports the -Wquoted-include-in-framework-header warning, > > and in Xcode 12, it's in Xcode's recommended settings. This warnings > > can be avoided by replacing double-quoted includes with angle-bracketed > > includes when generate framework headers. > > > > No-Presubmit: True > > Bug: webrtc:9627, webrtc:11984 > > Change-Id: I3f6258dfa77a5acee669614005b2747feee35e39 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185920 > > Commit-Queue: Anders Carlsson <andersc@webrtc.org> > > Reviewed-by: Anders Carlsson <andersc@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#32343} > > TBR=tommi@webrtc.org, andersc@webrtc.org > > No-Presubmit: True > Bug: webrtc:9627 > Bug: webrtc:11984 > Change-Id: I8f44232f1a70b8ff2ce6a4b4792f0a18472fcec3 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/187280 > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#32429} TBR=tommi@webrtc.org, andersc@webrtc.org No-Presubmit: True Bug: webrtc:9627 Bug: webrtc:11984 Change-Id: Ida92b8864dffaea37d3053d3c00381644988b54e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/189781 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32470}
2020-10-17 07:49:28 +09:00
action_foreach("create_bracket_include_headers_$this_target_name") {
script = "//tools_webrtc/apple/copy_framework_header.py"
sources = invoker.sources
output_name = invoker.output_name
outputs = [
"$target_gen_dir/$output_name.framework/WebRTC/{{source_file_part}}",
]
args = [
"--input",
"{{source}}",
"--output",
rebase_path(target_gen_dir, root_build_dir) +
"/$output_name.framework/WebRTC/{{source_file_part}}",
]
}
bundle_data("copy_framework_headers_$this_target_name") {
Reland "Remove placeholder Obj-C headers and use angle-bracketed headers." This is a reland of 37d41eea047799ccca2f09c941870c26ee3ffc0a Original change's description: > Reland "Remove placeholder Obj-C headers and use angle-bracketed headers." > > This is a reland of 6bfad33fd866e682c871c2ef2172b70b609593d1 > > Original change's description: > > Remove placeholder Obj-C headers and use angle-bracketed headers. > > > > sdk/objc/Framework/Headers are just a placeholder headers > > for backward compatibility and I don't think it is really need this for now. > > Instead, we can generate the framework header in > > ios/mac_framework_bundle_with_umbrella_header. > > Also clang supports the -Wquoted-include-in-framework-header warning, > > and in Xcode 12, it's in Xcode's recommended settings. This warnings > > can be avoided by replacing double-quoted includes with angle-bracketed > > includes when generate framework headers. > > > > No-Presubmit: True > > Bug: webrtc:9627, webrtc:11984 > > Change-Id: I3f6258dfa77a5acee669614005b2747feee35e39 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185920 > > Commit-Queue: Anders Carlsson <andersc@webrtc.org> > > Reviewed-by: Anders Carlsson <andersc@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#32343} > > TBR=tommi@webrtc.org, andersc@webrtc.org > > No-Presubmit: True > Bug: webrtc:9627 > Bug: webrtc:11984 > Change-Id: I8f44232f1a70b8ff2ce6a4b4792f0a18472fcec3 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/187280 > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#32429} TBR=tommi@webrtc.org, andersc@webrtc.org No-Presubmit: True Bug: webrtc:9627 Bug: webrtc:11984 Change-Id: Ida92b8864dffaea37d3053d3c00381644988b54e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/189781 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32470}
2020-10-17 07:49:28 +09:00
sources = get_target_outputs(
":create_bracket_include_headers_$this_target_name")
outputs = [ "{{bundle_contents_dir}}/Headers/{{source_file_part}}" ]
Reland "Remove placeholder Obj-C headers and use angle-bracketed headers." This is a reland of 37d41eea047799ccca2f09c941870c26ee3ffc0a Original change's description: > Reland "Remove placeholder Obj-C headers and use angle-bracketed headers." > > This is a reland of 6bfad33fd866e682c871c2ef2172b70b609593d1 > > Original change's description: > > Remove placeholder Obj-C headers and use angle-bracketed headers. > > > > sdk/objc/Framework/Headers are just a placeholder headers > > for backward compatibility and I don't think it is really need this for now. > > Instead, we can generate the framework header in > > ios/mac_framework_bundle_with_umbrella_header. > > Also clang supports the -Wquoted-include-in-framework-header warning, > > and in Xcode 12, it's in Xcode's recommended settings. This warnings > > can be avoided by replacing double-quoted includes with angle-bracketed > > includes when generate framework headers. > > > > No-Presubmit: True > > Bug: webrtc:9627, webrtc:11984 > > Change-Id: I3f6258dfa77a5acee669614005b2747feee35e39 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185920 > > Commit-Queue: Anders Carlsson <andersc@webrtc.org> > > Reviewed-by: Anders Carlsson <andersc@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#32343} > > TBR=tommi@webrtc.org, andersc@webrtc.org > > No-Presubmit: True > Bug: webrtc:9627 > Bug: webrtc:11984 > Change-Id: I8f44232f1a70b8ff2ce6a4b4792f0a18472fcec3 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/187280 > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#32429} TBR=tommi@webrtc.org, andersc@webrtc.org No-Presubmit: True Bug: webrtc:9627 Bug: webrtc:11984 Change-Id: Ida92b8864dffaea37d3053d3c00381644988b54e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/189781 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32470}
2020-10-17 07:49:28 +09:00
deps = [ ":create_bracket_include_headers_$this_target_name" ]
}
action("modulemap_$this_target_name") {
script = "//tools_webrtc/ios/generate_modulemap.py"
args = [
"--out",
rebase_path(modulemap_path, root_build_dir),
"--name",
output_name,
]
outputs = [ modulemap_path ]
}
bundle_data("copy_modulemap_$this_target_name") {
sources = [ modulemap_path ]
outputs = [ "{{bundle_contents_dir}}/Modules/module.modulemap" ]
deps = [ ":modulemap_$this_target_name" ]
}
action("umbrella_header_$this_target_name") {
Reland "Remove placeholder Obj-C headers and use angle-bracketed headers." This is a reland of 37d41eea047799ccca2f09c941870c26ee3ffc0a Original change's description: > Reland "Remove placeholder Obj-C headers and use angle-bracketed headers." > > This is a reland of 6bfad33fd866e682c871c2ef2172b70b609593d1 > > Original change's description: > > Remove placeholder Obj-C headers and use angle-bracketed headers. > > > > sdk/objc/Framework/Headers are just a placeholder headers > > for backward compatibility and I don't think it is really need this for now. > > Instead, we can generate the framework header in > > ios/mac_framework_bundle_with_umbrella_header. > > Also clang supports the -Wquoted-include-in-framework-header warning, > > and in Xcode 12, it's in Xcode's recommended settings. This warnings > > can be avoided by replacing double-quoted includes with angle-bracketed > > includes when generate framework headers. > > > > No-Presubmit: True > > Bug: webrtc:9627, webrtc:11984 > > Change-Id: I3f6258dfa77a5acee669614005b2747feee35e39 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185920 > > Commit-Queue: Anders Carlsson <andersc@webrtc.org> > > Reviewed-by: Anders Carlsson <andersc@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#32343} > > TBR=tommi@webrtc.org, andersc@webrtc.org > > No-Presubmit: True > Bug: webrtc:9627 > Bug: webrtc:11984 > Change-Id: I8f44232f1a70b8ff2ce6a4b4792f0a18472fcec3 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/187280 > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#32429} TBR=tommi@webrtc.org, andersc@webrtc.org No-Presubmit: True Bug: webrtc:9627 Bug: webrtc:11984 Change-Id: Ida92b8864dffaea37d3053d3c00381644988b54e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/189781 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32470}
2020-10-17 07:49:28 +09:00
sources = get_target_outputs(
":create_bracket_include_headers_$this_target_name")
script = "//tools_webrtc/ios/generate_umbrella_header.py"
outputs = [ umbrella_header_path ]
args = [
"--out",
rebase_path(umbrella_header_path, root_build_dir),
"--sources",
] + sources
Reland "Remove placeholder Obj-C headers and use angle-bracketed headers." This is a reland of 37d41eea047799ccca2f09c941870c26ee3ffc0a Original change's description: > Reland "Remove placeholder Obj-C headers and use angle-bracketed headers." > > This is a reland of 6bfad33fd866e682c871c2ef2172b70b609593d1 > > Original change's description: > > Remove placeholder Obj-C headers and use angle-bracketed headers. > > > > sdk/objc/Framework/Headers are just a placeholder headers > > for backward compatibility and I don't think it is really need this for now. > > Instead, we can generate the framework header in > > ios/mac_framework_bundle_with_umbrella_header. > > Also clang supports the -Wquoted-include-in-framework-header warning, > > and in Xcode 12, it's in Xcode's recommended settings. This warnings > > can be avoided by replacing double-quoted includes with angle-bracketed > > includes when generate framework headers. > > > > No-Presubmit: True > > Bug: webrtc:9627, webrtc:11984 > > Change-Id: I3f6258dfa77a5acee669614005b2747feee35e39 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185920 > > Commit-Queue: Anders Carlsson <andersc@webrtc.org> > > Reviewed-by: Anders Carlsson <andersc@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#32343} > > TBR=tommi@webrtc.org, andersc@webrtc.org > > No-Presubmit: True > Bug: webrtc:9627 > Bug: webrtc:11984 > Change-Id: I8f44232f1a70b8ff2ce6a4b4792f0a18472fcec3 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/187280 > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#32429} TBR=tommi@webrtc.org, andersc@webrtc.org No-Presubmit: True Bug: webrtc:9627 Bug: webrtc:11984 Change-Id: Ida92b8864dffaea37d3053d3c00381644988b54e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/189781 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32470}
2020-10-17 07:49:28 +09:00
deps = [ ":create_bracket_include_headers_$this_target_name" ]
}
bundle_data("copy_umbrella_header_$this_target_name") {
sources = [ umbrella_header_path ]
outputs = [ "{{bundle_contents_dir}}/Headers/$output_name.h" ]
deps = [ ":umbrella_header_$this_target_name" ]
}
}
}
Reland: "Make javac warnings errors for WebRTC targets." This reverts commit 2bad72a27329ff30ceb9479253f5eb3d21888d25. Reason for revert: Fixing downstream projects (take 2). Original change's description: > Reland "Revert "Make javac warnings errors for WebRTC targets."" > > This is a reland of 098d24c3c18f4b1fd043d7ba716d7601f0ce2b74 > Original change's description: > > Revert "Make javac warnings errors for WebRTC targets." > > > > This reverts commit 19b761403c3522902d69d61179f4d184e3632f79. > > > > Reason for revert: Breaking internal builds > > > > Original change's description: > > > Make javac warnings errors for WebRTC targets. > > > > > > Adds new rtc_* templates for Android targets to allow specifying > > > default values that affect WebRTC targets. > > > > > > Bug: webrtc:6597 > > > Change-Id: Ie529bfc8500d1e785b8a59dba7078b5f88ccfcd1 > > > Reviewed-on: https://webrtc-review.googlesource.com/15103 > > > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > > > Commit-Queue: Sami Kalliomäki <sakal@webrtc.org> > > > Cr-Commit-Position: refs/heads/master@{#20567} > > > TBR=phoglund@webrtc.org,sakal@webrtc.org > > > > Change-Id: I6d3ff5604b3d4307765d3a65adb783f89fcc974c > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: webrtc:6597 > > Reviewed-on: https://webrtc-review.googlesource.com/20740 > > Reviewed-by: Lu Liu <lliuu@webrtc.org> > > Commit-Queue: Lu Liu <lliuu@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#20571} > > Bug: webrtc:6597 > Change-Id: Icfb5ded46ce76b674bae67bfa02054b4ec52bb0f > Reviewed-on: https://webrtc-review.googlesource.com/20800 > Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org> > Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#20577} TBR=phoglund@webrtc.org,ehmaldonado@webrtc.org,mbonadei@webrtc.org,sakal@webrtc.org,lliuu@webrtc.org Change-Id: Id3713c1885318741711987ae642a269a9ca5bb85 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:6597 Reviewed-on: https://webrtc-review.googlesource.com/18441 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20588}
2017-11-07 15:36:33 +00:00
if (is_android) {
template("rtc_android_library") {
android_library(target_name) {
forward_variables_from(invoker,
"*",
[
"configs",
"public_configs",
"suppressed_configs",
"visibility",
])
Roll chromium_revision f9be7d3d66..d298cced6c (610432:610627) Also fix Android build by switching to the new `errorprone_args` parameter introduced in https://chromium-review.googlesource.com/1349672 Change log: https://chromium.googlesource.com/chromium/src/+log/f9be7d3d66..d298cced6c Full diff: https://chromium.googlesource.com/chromium/src/+/f9be7d3d66..d298cced6c Changed dependencies * src/base: https://chromium.googlesource.com/chromium/src/base/+log/c501123f4c..637e844c7c * src/build: https://chromium.googlesource.com/chromium/src/build/+log/a608842209..d6391e35ea * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/7ec4d4bb81..37ce0c91d6 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/64a90737d6..e78a57eb5b * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/9e781ebbaf..6c250624d7 * src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/4176781039..43e8ebcaf2 * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/3c063fd823..6b41cb2c41 DEPS diff: https://chromium.googlesource.com/chromium/src/+/f9be7d3d66..d298cced6c/DEPS No update to Clang. Bug: chromium:906803 Change-Id: I45b0cf87d9aefdb4b43a6335deb389ad3e8ab9d4 Reviewed-on: https://webrtc-review.googlesource.com/c/111926 Reviewed-by: Oleksandr Iakovenko <iakovenko@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Oleh Prypin <oprypin@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25776}
2018-11-23 17:29:44 +01:00
errorprone_args = []
Reland: "Make javac warnings errors for WebRTC targets." This reverts commit 2bad72a27329ff30ceb9479253f5eb3d21888d25. Reason for revert: Fixing downstream projects (take 2). Original change's description: > Reland "Revert "Make javac warnings errors for WebRTC targets."" > > This is a reland of 098d24c3c18f4b1fd043d7ba716d7601f0ce2b74 > Original change's description: > > Revert "Make javac warnings errors for WebRTC targets." > > > > This reverts commit 19b761403c3522902d69d61179f4d184e3632f79. > > > > Reason for revert: Breaking internal builds > > > > Original change's description: > > > Make javac warnings errors for WebRTC targets. > > > > > > Adds new rtc_* templates for Android targets to allow specifying > > > default values that affect WebRTC targets. > > > > > > Bug: webrtc:6597 > > > Change-Id: Ie529bfc8500d1e785b8a59dba7078b5f88ccfcd1 > > > Reviewed-on: https://webrtc-review.googlesource.com/15103 > > > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > > > Commit-Queue: Sami Kalliomäki <sakal@webrtc.org> > > > Cr-Commit-Position: refs/heads/master@{#20567} > > > TBR=phoglund@webrtc.org,sakal@webrtc.org > > > > Change-Id: I6d3ff5604b3d4307765d3a65adb783f89fcc974c > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: webrtc:6597 > > Reviewed-on: https://webrtc-review.googlesource.com/20740 > > Reviewed-by: Lu Liu <lliuu@webrtc.org> > > Commit-Queue: Lu Liu <lliuu@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#20571} > > Bug: webrtc:6597 > Change-Id: Icfb5ded46ce76b674bae67bfa02054b4ec52bb0f > Reviewed-on: https://webrtc-review.googlesource.com/20800 > Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org> > Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#20577} TBR=phoglund@webrtc.org,ehmaldonado@webrtc.org,mbonadei@webrtc.org,sakal@webrtc.org,lliuu@webrtc.org Change-Id: Id3713c1885318741711987ae642a269a9ca5bb85 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:6597 Reviewed-on: https://webrtc-review.googlesource.com/18441 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20588}
2017-11-07 15:36:33 +00:00
# Treat warnings as errors.
Roll chromium_revision f9be7d3d66..d298cced6c (610432:610627) Also fix Android build by switching to the new `errorprone_args` parameter introduced in https://chromium-review.googlesource.com/1349672 Change log: https://chromium.googlesource.com/chromium/src/+log/f9be7d3d66..d298cced6c Full diff: https://chromium.googlesource.com/chromium/src/+/f9be7d3d66..d298cced6c Changed dependencies * src/base: https://chromium.googlesource.com/chromium/src/base/+log/c501123f4c..637e844c7c * src/build: https://chromium.googlesource.com/chromium/src/build/+log/a608842209..d6391e35ea * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/7ec4d4bb81..37ce0c91d6 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/64a90737d6..e78a57eb5b * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/9e781ebbaf..6c250624d7 * src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/4176781039..43e8ebcaf2 * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/3c063fd823..6b41cb2c41 DEPS diff: https://chromium.googlesource.com/chromium/src/+/f9be7d3d66..d298cced6c/DEPS No update to Clang. Bug: chromium:906803 Change-Id: I45b0cf87d9aefdb4b43a6335deb389ad3e8ab9d4 Reviewed-on: https://webrtc-review.googlesource.com/c/111926 Reviewed-by: Oleksandr Iakovenko <iakovenko@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Oleh Prypin <oprypin@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25776}
2018-11-23 17:29:44 +01:00
errorprone_args += [ "-Werror" ]
# Add any arguments defined by the invoker.
Roll chromium_revision f9be7d3d66..d298cced6c (610432:610627) Also fix Android build by switching to the new `errorprone_args` parameter introduced in https://chromium-review.googlesource.com/1349672 Change log: https://chromium.googlesource.com/chromium/src/+log/f9be7d3d66..d298cced6c Full diff: https://chromium.googlesource.com/chromium/src/+/f9be7d3d66..d298cced6c Changed dependencies * src/base: https://chromium.googlesource.com/chromium/src/base/+log/c501123f4c..637e844c7c * src/build: https://chromium.googlesource.com/chromium/src/build/+log/a608842209..d6391e35ea * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/7ec4d4bb81..37ce0c91d6 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/64a90737d6..e78a57eb5b * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/9e781ebbaf..6c250624d7 * src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/4176781039..43e8ebcaf2 * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/3c063fd823..6b41cb2c41 DEPS diff: https://chromium.googlesource.com/chromium/src/+/f9be7d3d66..d298cced6c/DEPS No update to Clang. Bug: chromium:906803 Change-Id: I45b0cf87d9aefdb4b43a6335deb389ad3e8ab9d4 Reviewed-on: https://webrtc-review.googlesource.com/c/111926 Reviewed-by: Oleksandr Iakovenko <iakovenko@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Oleh Prypin <oprypin@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25776}
2018-11-23 17:29:44 +01:00
if (defined(invoker.errorprone_args)) {
errorprone_args += invoker.errorprone_args
}
Reland: "Make javac warnings errors for WebRTC targets." This reverts commit 2bad72a27329ff30ceb9479253f5eb3d21888d25. Reason for revert: Fixing downstream projects (take 2). Original change's description: > Reland "Revert "Make javac warnings errors for WebRTC targets."" > > This is a reland of 098d24c3c18f4b1fd043d7ba716d7601f0ce2b74 > Original change's description: > > Revert "Make javac warnings errors for WebRTC targets." > > > > This reverts commit 19b761403c3522902d69d61179f4d184e3632f79. > > > > Reason for revert: Breaking internal builds > > > > Original change's description: > > > Make javac warnings errors for WebRTC targets. > > > > > > Adds new rtc_* templates for Android targets to allow specifying > > > default values that affect WebRTC targets. > > > > > > Bug: webrtc:6597 > > > Change-Id: Ie529bfc8500d1e785b8a59dba7078b5f88ccfcd1 > > > Reviewed-on: https://webrtc-review.googlesource.com/15103 > > > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > > > Commit-Queue: Sami Kalliomäki <sakal@webrtc.org> > > > Cr-Commit-Position: refs/heads/master@{#20567} > > > TBR=phoglund@webrtc.org,sakal@webrtc.org > > > > Change-Id: I6d3ff5604b3d4307765d3a65adb783f89fcc974c > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: webrtc:6597 > > Reviewed-on: https://webrtc-review.googlesource.com/20740 > > Reviewed-by: Lu Liu <lliuu@webrtc.org> > > Commit-Queue: Lu Liu <lliuu@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#20571} > > Bug: webrtc:6597 > Change-Id: Icfb5ded46ce76b674bae67bfa02054b4ec52bb0f > Reviewed-on: https://webrtc-review.googlesource.com/20800 > Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org> > Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#20577} TBR=phoglund@webrtc.org,ehmaldonado@webrtc.org,mbonadei@webrtc.org,sakal@webrtc.org,lliuu@webrtc.org Change-Id: Id3713c1885318741711987ae642a269a9ca5bb85 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:6597 Reviewed-on: https://webrtc-review.googlesource.com/18441 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20588}
2017-11-07 15:36:33 +00:00
if (!defined(deps)) {
deps = []
}
Reland: "Make javac warnings errors for WebRTC targets." This reverts commit 2bad72a27329ff30ceb9479253f5eb3d21888d25. Reason for revert: Fixing downstream projects (take 2). Original change's description: > Reland "Revert "Make javac warnings errors for WebRTC targets."" > > This is a reland of 098d24c3c18f4b1fd043d7ba716d7601f0ce2b74 > Original change's description: > > Revert "Make javac warnings errors for WebRTC targets." > > > > This reverts commit 19b761403c3522902d69d61179f4d184e3632f79. > > > > Reason for revert: Breaking internal builds > > > > Original change's description: > > > Make javac warnings errors for WebRTC targets. > > > > > > Adds new rtc_* templates for Android targets to allow specifying > > > default values that affect WebRTC targets. > > > > > > Bug: webrtc:6597 > > > Change-Id: Ie529bfc8500d1e785b8a59dba7078b5f88ccfcd1 > > > Reviewed-on: https://webrtc-review.googlesource.com/15103 > > > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > > > Commit-Queue: Sami Kalliomäki <sakal@webrtc.org> > > > Cr-Commit-Position: refs/heads/master@{#20567} > > > TBR=phoglund@webrtc.org,sakal@webrtc.org > > > > Change-Id: I6d3ff5604b3d4307765d3a65adb783f89fcc974c > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: webrtc:6597 > > Reviewed-on: https://webrtc-review.googlesource.com/20740 > > Reviewed-by: Lu Liu <lliuu@webrtc.org> > > Commit-Queue: Lu Liu <lliuu@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#20571} > > Bug: webrtc:6597 > Change-Id: Icfb5ded46ce76b674bae67bfa02054b4ec52bb0f > Reviewed-on: https://webrtc-review.googlesource.com/20800 > Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org> > Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#20577} TBR=phoglund@webrtc.org,ehmaldonado@webrtc.org,mbonadei@webrtc.org,sakal@webrtc.org,lliuu@webrtc.org Change-Id: Id3713c1885318741711987ae642a269a9ca5bb85 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:6597 Reviewed-on: https://webrtc-review.googlesource.com/18441 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20588}
2017-11-07 15:36:33 +00:00
no_build_hooks = true
not_needed([ "android_manifest" ])
Reland: "Make javac warnings errors for WebRTC targets." This reverts commit 2bad72a27329ff30ceb9479253f5eb3d21888d25. Reason for revert: Fixing downstream projects (take 2). Original change's description: > Reland "Revert "Make javac warnings errors for WebRTC targets."" > > This is a reland of 098d24c3c18f4b1fd043d7ba716d7601f0ce2b74 > Original change's description: > > Revert "Make javac warnings errors for WebRTC targets." > > > > This reverts commit 19b761403c3522902d69d61179f4d184e3632f79. > > > > Reason for revert: Breaking internal builds > > > > Original change's description: > > > Make javac warnings errors for WebRTC targets. > > > > > > Adds new rtc_* templates for Android targets to allow specifying > > > default values that affect WebRTC targets. > > > > > > Bug: webrtc:6597 > > > Change-Id: Ie529bfc8500d1e785b8a59dba7078b5f88ccfcd1 > > > Reviewed-on: https://webrtc-review.googlesource.com/15103 > > > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > > > Commit-Queue: Sami Kalliomäki <sakal@webrtc.org> > > > Cr-Commit-Position: refs/heads/master@{#20567} > > > TBR=phoglund@webrtc.org,sakal@webrtc.org > > > > Change-Id: I6d3ff5604b3d4307765d3a65adb783f89fcc974c > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: webrtc:6597 > > Reviewed-on: https://webrtc-review.googlesource.com/20740 > > Reviewed-by: Lu Liu <lliuu@webrtc.org> > > Commit-Queue: Lu Liu <lliuu@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#20571} > > Bug: webrtc:6597 > Change-Id: Icfb5ded46ce76b674bae67bfa02054b4ec52bb0f > Reviewed-on: https://webrtc-review.googlesource.com/20800 > Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org> > Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#20577} TBR=phoglund@webrtc.org,ehmaldonado@webrtc.org,mbonadei@webrtc.org,sakal@webrtc.org,lliuu@webrtc.org Change-Id: Id3713c1885318741711987ae642a269a9ca5bb85 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:6597 Reviewed-on: https://webrtc-review.googlesource.com/18441 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20588}
2017-11-07 15:36:33 +00:00
}
}
template("rtc_android_apk") {
android_apk(target_name) {
forward_variables_from(invoker,
"*",
[
"configs",
"public_configs",
"suppressed_configs",
"visibility",
])
# Treat warnings as errors.
errorprone_args = []
errorprone_args += [ "-Werror" ]
if (!defined(deps)) {
deps = []
}
Reland: "Make javac warnings errors for WebRTC targets." This reverts commit 2bad72a27329ff30ceb9479253f5eb3d21888d25. Reason for revert: Fixing downstream projects (take 2). Original change's description: > Reland "Revert "Make javac warnings errors for WebRTC targets."" > > This is a reland of 098d24c3c18f4b1fd043d7ba716d7601f0ce2b74 > Original change's description: > > Revert "Make javac warnings errors for WebRTC targets." > > > > This reverts commit 19b761403c3522902d69d61179f4d184e3632f79. > > > > Reason for revert: Breaking internal builds > > > > Original change's description: > > > Make javac warnings errors for WebRTC targets. > > > > > > Adds new rtc_* templates for Android targets to allow specifying > > > default values that affect WebRTC targets. > > > > > > Bug: webrtc:6597 > > > Change-Id: Ie529bfc8500d1e785b8a59dba7078b5f88ccfcd1 > > > Reviewed-on: https://webrtc-review.googlesource.com/15103 > > > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > > > Commit-Queue: Sami Kalliomäki <sakal@webrtc.org> > > > Cr-Commit-Position: refs/heads/master@{#20567} > > > TBR=phoglund@webrtc.org,sakal@webrtc.org > > > > Change-Id: I6d3ff5604b3d4307765d3a65adb783f89fcc974c > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: webrtc:6597 > > Reviewed-on: https://webrtc-review.googlesource.com/20740 > > Reviewed-by: Lu Liu <lliuu@webrtc.org> > > Commit-Queue: Lu Liu <lliuu@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#20571} > > Bug: webrtc:6597 > Change-Id: Icfb5ded46ce76b674bae67bfa02054b4ec52bb0f > Reviewed-on: https://webrtc-review.googlesource.com/20800 > Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org> > Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#20577} TBR=phoglund@webrtc.org,ehmaldonado@webrtc.org,mbonadei@webrtc.org,sakal@webrtc.org,lliuu@webrtc.org Change-Id: Id3713c1885318741711987ae642a269a9ca5bb85 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:6597 Reviewed-on: https://webrtc-review.googlesource.com/18441 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20588}
2017-11-07 15:36:33 +00:00
no_build_hooks = true
}
}
template("rtc_instrumentation_test_apk") {
instrumentation_test_apk(target_name) {
forward_variables_from(invoker,
"*",
[
"configs",
"public_configs",
"suppressed_configs",
"visibility",
])
# Treat warnings as errors.
errorprone_args = []
errorprone_args += [ "-Werror" ]
if (!defined(deps)) {
deps = []
}
Reland: "Make javac warnings errors for WebRTC targets." This reverts commit 2bad72a27329ff30ceb9479253f5eb3d21888d25. Reason for revert: Fixing downstream projects (take 2). Original change's description: > Reland "Revert "Make javac warnings errors for WebRTC targets."" > > This is a reland of 098d24c3c18f4b1fd043d7ba716d7601f0ce2b74 > Original change's description: > > Revert "Make javac warnings errors for WebRTC targets." > > > > This reverts commit 19b761403c3522902d69d61179f4d184e3632f79. > > > > Reason for revert: Breaking internal builds > > > > Original change's description: > > > Make javac warnings errors for WebRTC targets. > > > > > > Adds new rtc_* templates for Android targets to allow specifying > > > default values that affect WebRTC targets. > > > > > > Bug: webrtc:6597 > > > Change-Id: Ie529bfc8500d1e785b8a59dba7078b5f88ccfcd1 > > > Reviewed-on: https://webrtc-review.googlesource.com/15103 > > > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > > > Commit-Queue: Sami Kalliomäki <sakal@webrtc.org> > > > Cr-Commit-Position: refs/heads/master@{#20567} > > > TBR=phoglund@webrtc.org,sakal@webrtc.org > > > > Change-Id: I6d3ff5604b3d4307765d3a65adb783f89fcc974c > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: webrtc:6597 > > Reviewed-on: https://webrtc-review.googlesource.com/20740 > > Reviewed-by: Lu Liu <lliuu@webrtc.org> > > Commit-Queue: Lu Liu <lliuu@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#20571} > > Bug: webrtc:6597 > Change-Id: Icfb5ded46ce76b674bae67bfa02054b4ec52bb0f > Reviewed-on: https://webrtc-review.googlesource.com/20800 > Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org> > Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#20577} TBR=phoglund@webrtc.org,ehmaldonado@webrtc.org,mbonadei@webrtc.org,sakal@webrtc.org,lliuu@webrtc.org Change-Id: Id3713c1885318741711987ae642a269a9ca5bb85 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:6597 Reviewed-on: https://webrtc-review.googlesource.com/18441 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20588}
2017-11-07 15:36:33 +00:00
no_build_hooks = true
}
}
}