332 lines
9.5 KiB
C++
Raw Normal View History

/*
* Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
*
* Use of this source code is governed by a BSD-style license
* that can be found in the LICENSE file in the root of the source
* tree. An additional intellectual property rights grant can be found
* in the file PATENTS. All contributing project authors may
* be found in the AUTHORS file in the root of the source tree.
*/
Move talk/media to webrtc/media I removed the 'libjingle' target in talk/libjingle.gyp and replaced all users of it with base/base.gyp:rtc_base. It seems the jsoncpp and expat dependencies were not used by it's previous references. The files in talk/media/testdata were uploaded to Google Storage and added .sha1 files in resources/media instead of simply moving them. The previously disabled warnings that were inherited from talk/build/common.gypi are now replaced by target-specific disabling of only the failing warnings. Additional disabling was needed since the stricter compilation warnings that applies to code in webrtc/. License headers will be updated in a follow-up CL in order to not break Git history. Other modifications: * Updated the header guards. * Sorted the includes using chromium/src/tools/sort-headers.py except for these files: talk/app/webrtc/peerconnectionendtoend_unittest.cc talk/app/webrtc/java/jni/androidmediadecoder_jni.cc talk/app/webrtc/java/jni/androidmediaencoder_jni.cc webrtc/media/devices/win32devicemanager.cc. * Unused GYP reference to libjingle_tests_additional_deps was removed. * Removed duplicated GYP entries of webrtc/base/testutils.cc webrtc/base/testutils.h The HAVE_WEBRTC_VIDEO and HAVE_WEBRTC_VOICE defines were used by only talk/media, so they were moved to the media.gyp. I also checked that none of EXPAT_RELATIVE_PATH, FEATURE_ENABLE_VOICEMAIL, GTEST_RELATIVE_PATH, JSONCPP_RELATIVE_PATH, LOGGING=1, SRTP_RELATIVE_PATH, FEATURE_ENABLE_SSL, FEATURE_ENABLE_VOICEMAIL, FEATURE_ENABLE_PSTN, HAVE_SCTP, HAVE_SRTP, are used by the talk/media code. For Chromium, the following changes will need to be applied to the roll CL that updates the DEPS for WebRTC and libjingle: https://codereview.chromium.org/1604303002/ BUG=webrtc:5420 NOPRESUBMIT=True TBR=tommi@webrtc.org Review URL: https://codereview.webrtc.org/1587193006 Cr-Commit-Position: refs/heads/master@{#11495}
2016-02-04 23:52:28 -08:00
#include "webrtc/media/base/codec.h"
#include <algorithm>
#include <sstream>
#include "webrtc/base/common.h"
#include "webrtc/base/logging.h"
#include "webrtc/base/stringencode.h"
#include "webrtc/base/stringutils.h"
namespace cricket {
const int kMaxPayloadId = 127;
bool FeedbackParam::operator==(const FeedbackParam& other) const {
return _stricmp(other.id().c_str(), id().c_str()) == 0 &&
_stricmp(other.param().c_str(), param().c_str()) == 0;
}
bool FeedbackParams::operator==(const FeedbackParams& other) const {
return params_ == other.params_;
}
bool FeedbackParams::Has(const FeedbackParam& param) const {
return std::find(params_.begin(), params_.end(), param) != params_.end();
}
void FeedbackParams::Add(const FeedbackParam& param) {
if (param.id().empty()) {
return;
}
if (Has(param)) {
// Param already in |this|.
return;
}
params_.push_back(param);
ASSERT(!HasDuplicateEntries());
}
void FeedbackParams::Intersect(const FeedbackParams& from) {
std::vector<FeedbackParam>::iterator iter_to = params_.begin();
while (iter_to != params_.end()) {
if (!from.Has(*iter_to)) {
iter_to = params_.erase(iter_to);
} else {
++iter_to;
}
}
}
bool FeedbackParams::HasDuplicateEntries() const {
for (std::vector<FeedbackParam>::const_iterator iter = params_.begin();
iter != params_.end(); ++iter) {
for (std::vector<FeedbackParam>::const_iterator found = iter + 1;
found != params_.end(); ++found) {
if (*found == *iter) {
return true;
}
}
}
return false;
}
Make webrtc 50 KB smaller by not inlining Codec. The Codec class is a big class and objects of the Codec class are passed around by value. That means that inlined operations would be duplicated at many places, in particular inside STL. By not inlining Codec methods, webrtc shrinks by 50 KB in a Linux x64 clang build. Total change: -54147 bytes ========================== +2810 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/base/codec.cc - (gained 2920, lost 110) -1003 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/base/codec.h - (gained 0, lost 1003) -1129 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/sctp/sctpdataengine.cc - (gained 1660, lost 2789) -1190 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/base/rtpdataengine.cc - (gained 1408, lost 2598) -1747 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/session/media/mediasession.cc - (gained 803, lost 2550) -2141 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/webrtc/webrtcvideoengine.cc - (gained 1679, lost 3820) -2250 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/app/webrtc/webrtcsdp.cc - (gained 1224, lost 3474) -2927 - Source: /usr/include/c++/4.8/bits/stl_vector.h - (gained 0, lost 2927) -3729 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/webrtc/webrtcvideoengine2.cc - (gained 10925, lost 14654) -6369 - Source: /usr/include/c++/4.8/bits/vector.tcc - (gained 0, lost 6369) -10582 - Source: /usr/include/c++/4.8/bits/stl_heap.h - (gained 0, lost 10582) -19324 - Source: /usr/include/c++/4.8/bits/stl_algo.h - (gained 743, lost 20067) BUG= R=juberti@webrtc.org Review URL: https://webrtc-codereview.appspot.com/40729005 Cr-Commit-Position: refs/heads/master@{#8436} git-svn-id: http://webrtc.googlecode.com/svn/trunk@8436 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-19 17:55:18 +00:00
Codec::Codec(int id, const std::string& name, int clockrate, int preference)
: id(id), name(name), clockrate(clockrate), preference(preference) {
Make webrtc 50 KB smaller by not inlining Codec. The Codec class is a big class and objects of the Codec class are passed around by value. That means that inlined operations would be duplicated at many places, in particular inside STL. By not inlining Codec methods, webrtc shrinks by 50 KB in a Linux x64 clang build. Total change: -54147 bytes ========================== +2810 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/base/codec.cc - (gained 2920, lost 110) -1003 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/base/codec.h - (gained 0, lost 1003) -1129 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/sctp/sctpdataengine.cc - (gained 1660, lost 2789) -1190 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/base/rtpdataengine.cc - (gained 1408, lost 2598) -1747 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/session/media/mediasession.cc - (gained 803, lost 2550) -2141 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/webrtc/webrtcvideoengine.cc - (gained 1679, lost 3820) -2250 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/app/webrtc/webrtcsdp.cc - (gained 1224, lost 3474) -2927 - Source: /usr/include/c++/4.8/bits/stl_vector.h - (gained 0, lost 2927) -3729 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/webrtc/webrtcvideoengine2.cc - (gained 10925, lost 14654) -6369 - Source: /usr/include/c++/4.8/bits/vector.tcc - (gained 0, lost 6369) -10582 - Source: /usr/include/c++/4.8/bits/stl_heap.h - (gained 0, lost 10582) -19324 - Source: /usr/include/c++/4.8/bits/stl_algo.h - (gained 743, lost 20067) BUG= R=juberti@webrtc.org Review URL: https://webrtc-codereview.appspot.com/40729005 Cr-Commit-Position: refs/heads/master@{#8436} git-svn-id: http://webrtc.googlecode.com/svn/trunk@8436 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-19 17:55:18 +00:00
}
Codec::Codec() : id(0), clockrate(0), preference(0) {
}
Codec::Codec(const Codec& c) = default;
Codec::~Codec() = default;
Codec& Codec::operator=(const Codec& c) {
this->id = c.id; // id is reserved in objective-c
name = c.name;
clockrate = c.clockrate;
preference = c.preference;
params = c.params;
feedback_params = c.feedback_params;
return *this;
}
bool Codec::operator==(const Codec& c) const {
return this->id == c.id && // id is reserved in objective-c
name == c.name && clockrate == c.clockrate &&
preference == c.preference && params == c.params &&
Make webrtc 50 KB smaller by not inlining Codec. The Codec class is a big class and objects of the Codec class are passed around by value. That means that inlined operations would be duplicated at many places, in particular inside STL. By not inlining Codec methods, webrtc shrinks by 50 KB in a Linux x64 clang build. Total change: -54147 bytes ========================== +2810 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/base/codec.cc - (gained 2920, lost 110) -1003 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/base/codec.h - (gained 0, lost 1003) -1129 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/sctp/sctpdataengine.cc - (gained 1660, lost 2789) -1190 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/base/rtpdataengine.cc - (gained 1408, lost 2598) -1747 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/session/media/mediasession.cc - (gained 803, lost 2550) -2141 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/webrtc/webrtcvideoengine.cc - (gained 1679, lost 3820) -2250 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/app/webrtc/webrtcsdp.cc - (gained 1224, lost 3474) -2927 - Source: /usr/include/c++/4.8/bits/stl_vector.h - (gained 0, lost 2927) -3729 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/webrtc/webrtcvideoengine2.cc - (gained 10925, lost 14654) -6369 - Source: /usr/include/c++/4.8/bits/vector.tcc - (gained 0, lost 6369) -10582 - Source: /usr/include/c++/4.8/bits/stl_heap.h - (gained 0, lost 10582) -19324 - Source: /usr/include/c++/4.8/bits/stl_algo.h - (gained 743, lost 20067) BUG= R=juberti@webrtc.org Review URL: https://webrtc-codereview.appspot.com/40729005 Cr-Commit-Position: refs/heads/master@{#8436} git-svn-id: http://webrtc.googlecode.com/svn/trunk@8436 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-19 17:55:18 +00:00
feedback_params == c.feedback_params;
}
bool Codec::Matches(const Codec& codec) const {
// Match the codec id/name based on the typical static/dynamic name rules.
// Matching is case-insensitive.
const int kMaxStaticPayloadId = 95;
return (codec.id <= kMaxStaticPayloadId) ?
(id == codec.id) : (_stricmp(name.c_str(), codec.name.c_str()) == 0);
}
bool Codec::GetParam(const std::string& name, std::string* out) const {
CodecParameterMap::const_iterator iter = params.find(name);
if (iter == params.end())
return false;
*out = iter->second;
return true;
}
bool Codec::GetParam(const std::string& name, int* out) const {
CodecParameterMap::const_iterator iter = params.find(name);
if (iter == params.end())
return false;
return rtc::FromString(iter->second, out);
}
void Codec::SetParam(const std::string& name, const std::string& value) {
params[name] = value;
}
void Codec::SetParam(const std::string& name, int value) {
params[name] = rtc::ToString(value);
}
bool Codec::RemoveParam(const std::string& name) {
return params.erase(name) == 1;
}
void Codec::AddFeedbackParam(const FeedbackParam& param) {
feedback_params.Add(param);
}
bool Codec::HasFeedbackParam(const FeedbackParam& param) const {
return feedback_params.Has(param);
}
void Codec::IntersectFeedbackParams(const Codec& other) {
feedback_params.Intersect(other.feedback_params);
}
AudioCodec::AudioCodec(int id,
const std::string& name,
int clockrate,
int bitrate,
size_t channels,
int preference)
: Codec(id, name, clockrate, preference),
bitrate(bitrate),
channels(channels) {
Make webrtc 50 KB smaller by not inlining Codec. The Codec class is a big class and objects of the Codec class are passed around by value. That means that inlined operations would be duplicated at many places, in particular inside STL. By not inlining Codec methods, webrtc shrinks by 50 KB in a Linux x64 clang build. Total change: -54147 bytes ========================== +2810 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/base/codec.cc - (gained 2920, lost 110) -1003 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/base/codec.h - (gained 0, lost 1003) -1129 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/sctp/sctpdataengine.cc - (gained 1660, lost 2789) -1190 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/base/rtpdataengine.cc - (gained 1408, lost 2598) -1747 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/session/media/mediasession.cc - (gained 803, lost 2550) -2141 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/webrtc/webrtcvideoengine.cc - (gained 1679, lost 3820) -2250 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/app/webrtc/webrtcsdp.cc - (gained 1224, lost 3474) -2927 - Source: /usr/include/c++/4.8/bits/stl_vector.h - (gained 0, lost 2927) -3729 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/webrtc/webrtcvideoengine2.cc - (gained 10925, lost 14654) -6369 - Source: /usr/include/c++/4.8/bits/vector.tcc - (gained 0, lost 6369) -10582 - Source: /usr/include/c++/4.8/bits/stl_heap.h - (gained 0, lost 10582) -19324 - Source: /usr/include/c++/4.8/bits/stl_algo.h - (gained 743, lost 20067) BUG= R=juberti@webrtc.org Review URL: https://webrtc-codereview.appspot.com/40729005 Cr-Commit-Position: refs/heads/master@{#8436} git-svn-id: http://webrtc.googlecode.com/svn/trunk@8436 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-19 17:55:18 +00:00
}
AudioCodec::AudioCodec() : Codec(), bitrate(0), channels(0) {
Make webrtc 50 KB smaller by not inlining Codec. The Codec class is a big class and objects of the Codec class are passed around by value. That means that inlined operations would be duplicated at many places, in particular inside STL. By not inlining Codec methods, webrtc shrinks by 50 KB in a Linux x64 clang build. Total change: -54147 bytes ========================== +2810 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/base/codec.cc - (gained 2920, lost 110) -1003 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/base/codec.h - (gained 0, lost 1003) -1129 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/sctp/sctpdataengine.cc - (gained 1660, lost 2789) -1190 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/base/rtpdataengine.cc - (gained 1408, lost 2598) -1747 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/session/media/mediasession.cc - (gained 803, lost 2550) -2141 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/webrtc/webrtcvideoengine.cc - (gained 1679, lost 3820) -2250 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/app/webrtc/webrtcsdp.cc - (gained 1224, lost 3474) -2927 - Source: /usr/include/c++/4.8/bits/stl_vector.h - (gained 0, lost 2927) -3729 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/webrtc/webrtcvideoengine2.cc - (gained 10925, lost 14654) -6369 - Source: /usr/include/c++/4.8/bits/vector.tcc - (gained 0, lost 6369) -10582 - Source: /usr/include/c++/4.8/bits/stl_heap.h - (gained 0, lost 10582) -19324 - Source: /usr/include/c++/4.8/bits/stl_algo.h - (gained 743, lost 20067) BUG= R=juberti@webrtc.org Review URL: https://webrtc-codereview.appspot.com/40729005 Cr-Commit-Position: refs/heads/master@{#8436} git-svn-id: http://webrtc.googlecode.com/svn/trunk@8436 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-19 17:55:18 +00:00
}
AudioCodec::AudioCodec(const AudioCodec& c) = default;
AudioCodec& AudioCodec::operator=(const AudioCodec& c) {
Codec::operator=(c);
bitrate = c.bitrate;
channels = c.channels;
return *this;
}
bool AudioCodec::operator==(const AudioCodec& c) const {
return bitrate == c.bitrate && channels == c.channels && Codec::operator==(c);
Make webrtc 50 KB smaller by not inlining Codec. The Codec class is a big class and objects of the Codec class are passed around by value. That means that inlined operations would be duplicated at many places, in particular inside STL. By not inlining Codec methods, webrtc shrinks by 50 KB in a Linux x64 clang build. Total change: -54147 bytes ========================== +2810 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/base/codec.cc - (gained 2920, lost 110) -1003 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/base/codec.h - (gained 0, lost 1003) -1129 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/sctp/sctpdataengine.cc - (gained 1660, lost 2789) -1190 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/base/rtpdataengine.cc - (gained 1408, lost 2598) -1747 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/session/media/mediasession.cc - (gained 803, lost 2550) -2141 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/webrtc/webrtcvideoengine.cc - (gained 1679, lost 3820) -2250 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/app/webrtc/webrtcsdp.cc - (gained 1224, lost 3474) -2927 - Source: /usr/include/c++/4.8/bits/stl_vector.h - (gained 0, lost 2927) -3729 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/webrtc/webrtcvideoengine2.cc - (gained 10925, lost 14654) -6369 - Source: /usr/include/c++/4.8/bits/vector.tcc - (gained 0, lost 6369) -10582 - Source: /usr/include/c++/4.8/bits/stl_heap.h - (gained 0, lost 10582) -19324 - Source: /usr/include/c++/4.8/bits/stl_algo.h - (gained 743, lost 20067) BUG= R=juberti@webrtc.org Review URL: https://webrtc-codereview.appspot.com/40729005 Cr-Commit-Position: refs/heads/master@{#8436} git-svn-id: http://webrtc.googlecode.com/svn/trunk@8436 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-19 17:55:18 +00:00
}
bool AudioCodec::Matches(const AudioCodec& codec) const {
// If a nonzero clockrate is specified, it must match the actual clockrate.
// If a nonzero bitrate is specified, it must match the actual bitrate,
// unless the codec is VBR (0), where we just force the supplied value.
// The number of channels must match exactly, with the exception
// that channels=0 is treated synonymously as channels=1, per RFC
// 4566 section 6: " [The channels] parameter is OPTIONAL and may be
// omitted if the number of channels is one."
// Preference is ignored.
// TODO(juberti): Treat a zero clockrate as 8000Hz, the RTP default clockrate.
return Codec::Matches(codec) &&
((codec.clockrate == 0 /*&& clockrate == 8000*/) ||
clockrate == codec.clockrate) &&
(codec.bitrate == 0 || bitrate <= 0 || bitrate == codec.bitrate) &&
((codec.channels < 2 && channels < 2) || channels == codec.channels);
}
std::string AudioCodec::ToString() const {
std::ostringstream os;
os << "AudioCodec[" << id << ":" << name << ":" << clockrate << ":" << bitrate
<< ":" << channels << ":" << preference << "]";
return os.str();
}
std::string VideoCodec::ToString() const {
std::ostringstream os;
os << "VideoCodec[" << id << ":" << name << ":" << width << ":" << height
<< ":" << framerate << ":" << preference << "]";
return os.str();
}
VideoCodec::VideoCodec(int id,
const std::string& name,
int width,
int height,
int framerate,
int preference)
: Codec(id, name, kVideoCodecClockrate, preference),
width(width),
height(height),
framerate(framerate) {
Make webrtc 50 KB smaller by not inlining Codec. The Codec class is a big class and objects of the Codec class are passed around by value. That means that inlined operations would be duplicated at many places, in particular inside STL. By not inlining Codec methods, webrtc shrinks by 50 KB in a Linux x64 clang build. Total change: -54147 bytes ========================== +2810 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/base/codec.cc - (gained 2920, lost 110) -1003 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/base/codec.h - (gained 0, lost 1003) -1129 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/sctp/sctpdataengine.cc - (gained 1660, lost 2789) -1190 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/base/rtpdataengine.cc - (gained 1408, lost 2598) -1747 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/session/media/mediasession.cc - (gained 803, lost 2550) -2141 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/webrtc/webrtcvideoengine.cc - (gained 1679, lost 3820) -2250 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/app/webrtc/webrtcsdp.cc - (gained 1224, lost 3474) -2927 - Source: /usr/include/c++/4.8/bits/stl_vector.h - (gained 0, lost 2927) -3729 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/webrtc/webrtcvideoengine2.cc - (gained 10925, lost 14654) -6369 - Source: /usr/include/c++/4.8/bits/vector.tcc - (gained 0, lost 6369) -10582 - Source: /usr/include/c++/4.8/bits/stl_heap.h - (gained 0, lost 10582) -19324 - Source: /usr/include/c++/4.8/bits/stl_algo.h - (gained 743, lost 20067) BUG= R=juberti@webrtc.org Review URL: https://webrtc-codereview.appspot.com/40729005 Cr-Commit-Position: refs/heads/master@{#8436} git-svn-id: http://webrtc.googlecode.com/svn/trunk@8436 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-19 17:55:18 +00:00
}
VideoCodec::VideoCodec(int id, const std::string& name)
: Codec(id, name, kVideoCodecClockrate, 0),
width(0),
height(0),
framerate(0) {
}
Make webrtc 50 KB smaller by not inlining Codec. The Codec class is a big class and objects of the Codec class are passed around by value. That means that inlined operations would be duplicated at many places, in particular inside STL. By not inlining Codec methods, webrtc shrinks by 50 KB in a Linux x64 clang build. Total change: -54147 bytes ========================== +2810 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/base/codec.cc - (gained 2920, lost 110) -1003 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/base/codec.h - (gained 0, lost 1003) -1129 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/sctp/sctpdataengine.cc - (gained 1660, lost 2789) -1190 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/base/rtpdataengine.cc - (gained 1408, lost 2598) -1747 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/session/media/mediasession.cc - (gained 803, lost 2550) -2141 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/webrtc/webrtcvideoengine.cc - (gained 1679, lost 3820) -2250 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/app/webrtc/webrtcsdp.cc - (gained 1224, lost 3474) -2927 - Source: /usr/include/c++/4.8/bits/stl_vector.h - (gained 0, lost 2927) -3729 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/webrtc/webrtcvideoengine2.cc - (gained 10925, lost 14654) -6369 - Source: /usr/include/c++/4.8/bits/vector.tcc - (gained 0, lost 6369) -10582 - Source: /usr/include/c++/4.8/bits/stl_heap.h - (gained 0, lost 10582) -19324 - Source: /usr/include/c++/4.8/bits/stl_algo.h - (gained 743, lost 20067) BUG= R=juberti@webrtc.org Review URL: https://webrtc-codereview.appspot.com/40729005 Cr-Commit-Position: refs/heads/master@{#8436} git-svn-id: http://webrtc.googlecode.com/svn/trunk@8436 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-19 17:55:18 +00:00
VideoCodec::VideoCodec() : Codec(), width(0), height(0), framerate(0) {
clockrate = kVideoCodecClockrate;
}
VideoCodec::VideoCodec(const VideoCodec& c) = default;
VideoCodec& VideoCodec::operator=(const VideoCodec& c) {
Codec::operator=(c);
width = c.width;
height = c.height;
framerate = c.framerate;
return *this;
}
bool VideoCodec::operator==(const VideoCodec& c) const {
return width == c.width && height == c.height && framerate == c.framerate &&
Codec::operator==(c);
}
VideoCodec VideoCodec::CreateRtxCodec(int rtx_payload_type,
int associated_payload_type) {
VideoCodec rtx_codec(rtx_payload_type, kRtxCodecName, 0, 0, 0, 0);
rtx_codec.SetParam(kCodecParamAssociatedPayloadType, associated_payload_type);
return rtx_codec;
}
VideoCodec::CodecType VideoCodec::GetCodecType() const {
const char* payload_name = name.c_str();
if (_stricmp(payload_name, kRedCodecName) == 0) {
return CODEC_RED;
}
if (_stricmp(payload_name, kUlpfecCodecName) == 0) {
return CODEC_ULPFEC;
}
if (_stricmp(payload_name, kRtxCodecName) == 0) {
return CODEC_RTX;
}
return CODEC_VIDEO;
}
bool VideoCodec::ValidateCodecFormat() const {
if (id < 0 || id > 127) {
LOG(LS_ERROR) << "Codec with invalid payload type: " << ToString();
return false;
}
if (GetCodecType() != CODEC_VIDEO) {
return true;
}
// Video validation from here on.
if (width <= 0 || height <= 0) {
LOG(LS_ERROR) << "Codec with invalid dimensions: " << ToString();
return false;
}
int min_bitrate = -1;
int max_bitrate = -1;
if (GetParam(kCodecParamMinBitrate, &min_bitrate) &&
GetParam(kCodecParamMaxBitrate, &max_bitrate)) {
if (max_bitrate < min_bitrate) {
LOG(LS_ERROR) << "Codec with max < min bitrate: " << ToString();
return false;
}
}
return true;
}
Make webrtc 50 KB smaller by not inlining Codec. The Codec class is a big class and objects of the Codec class are passed around by value. That means that inlined operations would be duplicated at many places, in particular inside STL. By not inlining Codec methods, webrtc shrinks by 50 KB in a Linux x64 clang build. Total change: -54147 bytes ========================== +2810 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/base/codec.cc - (gained 2920, lost 110) -1003 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/base/codec.h - (gained 0, lost 1003) -1129 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/sctp/sctpdataengine.cc - (gained 1660, lost 2789) -1190 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/base/rtpdataengine.cc - (gained 1408, lost 2598) -1747 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/session/media/mediasession.cc - (gained 803, lost 2550) -2141 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/webrtc/webrtcvideoengine.cc - (gained 1679, lost 3820) -2250 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/app/webrtc/webrtcsdp.cc - (gained 1224, lost 3474) -2927 - Source: /usr/include/c++/4.8/bits/stl_vector.h - (gained 0, lost 2927) -3729 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/webrtc/webrtcvideoengine2.cc - (gained 10925, lost 14654) -6369 - Source: /usr/include/c++/4.8/bits/vector.tcc - (gained 0, lost 6369) -10582 - Source: /usr/include/c++/4.8/bits/stl_heap.h - (gained 0, lost 10582) -19324 - Source: /usr/include/c++/4.8/bits/stl_algo.h - (gained 743, lost 20067) BUG= R=juberti@webrtc.org Review URL: https://webrtc-codereview.appspot.com/40729005 Cr-Commit-Position: refs/heads/master@{#8436} git-svn-id: http://webrtc.googlecode.com/svn/trunk@8436 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-19 17:55:18 +00:00
DataCodec::DataCodec(int id, const std::string& name, int preference)
: Codec(id, name, kDataCodecClockrate, preference) {
}
DataCodec::DataCodec() : Codec() {
clockrate = kDataCodecClockrate;
}
DataCodec::DataCodec(const DataCodec& c) = default;
DataCodec& DataCodec::operator=(const DataCodec& c) = default;
std::string DataCodec::ToString() const {
std::ostringstream os;
os << "DataCodec[" << id << ":" << name << "]";
return os.str();
}
bool HasNack(const Codec& codec) {
return codec.HasFeedbackParam(
FeedbackParam(kRtcpFbParamNack, kParamValueEmpty));
}
bool HasRemb(const Codec& codec) {
return codec.HasFeedbackParam(
FeedbackParam(kRtcpFbParamRemb, kParamValueEmpty));
}
bool HasTransportCc(const Codec& codec) {
return codec.HasFeedbackParam(
FeedbackParam(kRtcpFbParamTransportCc, kParamValueEmpty));
}
bool CodecNamesEq(const std::string& name1, const std::string& name2) {
return _stricmp(name1.c_str(), name2.c_str()) == 0;
}
} // namespace cricket