admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
webrtc_m130/sdk/objc/Framework/Classes/Common/RTCUIApplicationStatusObserver.h

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

25 lines
638 B
C
Raw Normal View History

Fix VideoToolbox backgrounding issues. When the iOS application is not in the foreground, the hardware encoder and decoder become invalidated. There doesn't seem to be a way to query their state so we don't know they're invalid until we get an error code after an encode/decode request. To solve the issue, we just don't encode/decode when the app is not active, and reinitialize the encoder/decoder when the app is active again. Also fixes a leak in the decoder. BUG=webrtc:4081 Review URL: https://codereview.webrtc.org/1732953003 Cr-Commit-Position: refs/heads/master@{#11916}
2016-03-08 10:51:54 -08:00
/*
* Copyright 2016 The WebRTC Project Authors. All rights reserved.
*
* Use of this source code is governed by a BSD-style license
* that can be found in the LICENSE file in the root of the source
* tree. An additional intellectual property rights grant can be found
* in the file PATENTS. All contributing project authors may
* be found in the AUTHORS file in the root of the source tree.
*/
#if defined(WEBRTC_IOS)
Access UIApplication on main thread Track UIApplication applicationState changes from a C++ class. Uses NSNotificationCenter to access changes on the main thread and exposes a local variable that can be checked from any thread. This fixes a runtime warning on iOS 11 beta. My Objective-C++ is a little rusty so please check if this follows the conventions for C++ code in the project. It also changes the interface exposed by RTCUIApplication.h, not sure if that has impact on any public APIs that needs to be documented somewhere? Bug: webrtc:7773 Change-Id: I9c8ba090ef9f28d812114026a906cef742192c39 Reviewed-on: https://chromium-review.googlesource.com/527442 Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Kári Tristan Helgason <kthelgason@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#18558}
2017-06-12 14:16:20 +02:00
#import <Foundation/Foundation.h>
@interface RTCUIApplicationStatusObserver : NSObject
+ (instancetype)sharedInstance;
Enhance RTCUIApplicationStatusObserver thread safety. Add locking around waiting for initialization to finish, since calling dispatch_block_wait from multiple threads leads to undefined behavior. Initialize RTCUIApplicationStatusObserver earlier to give the initialization block more time to run on the main thread before starting to query the application state. http://www.dailymotion.com/video/x2mckmh BUG=b/65558688 Review-Url: https://codereview.webrtc.org/3009383002 Cr-Commit-Position: refs/heads/master@{#19822}
2017-09-13 07:31:46 -07:00
+ (void)prepareForUse;
Access UIApplication on main thread Track UIApplication applicationState changes from a C++ class. Uses NSNotificationCenter to access changes on the main thread and exposes a local variable that can be checked from any thread. This fixes a runtime warning on iOS 11 beta. My Objective-C++ is a little rusty so please check if this follows the conventions for C++ code in the project. It also changes the interface exposed by RTCUIApplication.h, not sure if that has impact on any public APIs that needs to be documented somewhere? Bug: webrtc:7773 Change-Id: I9c8ba090ef9f28d812114026a906cef742192c39 Reviewed-on: https://chromium-review.googlesource.com/527442 Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Kári Tristan Helgason <kthelgason@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#18558}
2017-06-12 14:16:20 +02:00
- (BOOL)isApplicationActive;
Fix VideoToolbox backgrounding issues. When the iOS application is not in the foreground, the hardware encoder and decoder become invalidated. There doesn't seem to be a way to query their state so we don't know they're invalid until we get an error code after an encode/decode request. To solve the issue, we just don't encode/decode when the app is not active, and reinitialize the encoder/decoder when the app is active again. Also fixes a leak in the decoder. BUG=webrtc:4081 Review URL: https://codereview.webrtc.org/1732953003 Cr-Commit-Position: refs/heads/master@{#11916}
2016-03-08 10:51:54 -08:00
Access UIApplication on main thread Track UIApplication applicationState changes from a C++ class. Uses NSNotificationCenter to access changes on the main thread and exposes a local variable that can be checked from any thread. This fixes a runtime warning on iOS 11 beta. My Objective-C++ is a little rusty so please check if this follows the conventions for C++ code in the project. It also changes the interface exposed by RTCUIApplication.h, not sure if that has impact on any public APIs that needs to be documented somewhere? Bug: webrtc:7773 Change-Id: I9c8ba090ef9f28d812114026a906cef742192c39 Reviewed-on: https://chromium-review.googlesource.com/527442 Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Kári Tristan Helgason <kthelgason@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#18558}
2017-06-12 14:16:20 +02:00
@end
Fix VideoToolbox backgrounding issues. When the iOS application is not in the foreground, the hardware encoder and decoder become invalidated. There doesn't seem to be a way to query their state so we don't know they're invalid until we get an error code after an encode/decode request. To solve the issue, we just don't encode/decode when the app is not active, and reinitialize the encoder/decoder when the app is active again. Also fixes a leak in the decoder. BUG=webrtc:4081 Review URL: https://codereview.webrtc.org/1732953003 Cr-Commit-Position: refs/heads/master@{#11916}
2016-03-08 10:51:54 -08:00
Access UIApplication on main thread Track UIApplication applicationState changes from a C++ class. Uses NSNotificationCenter to access changes on the main thread and exposes a local variable that can be checked from any thread. This fixes a runtime warning on iOS 11 beta. My Objective-C++ is a little rusty so please check if this follows the conventions for C++ code in the project. It also changes the interface exposed by RTCUIApplication.h, not sure if that has impact on any public APIs that needs to be documented somewhere? Bug: webrtc:7773 Change-Id: I9c8ba090ef9f28d812114026a906cef742192c39 Reviewed-on: https://chromium-review.googlesource.com/527442 Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Kári Tristan Helgason <kthelgason@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#18558}
2017-06-12 14:16:20 +02:00
#endif // WEBRTC_IOS
Reference in New Issue Copy Permalink