Logo
Explore Help
Register Sign In
admin/webrtc_m130
1
0
Fork 0
You've already forked webrtc_m130
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
webrtc_m130/logging/OWNERS

4 lines
56 B
Plaintext
Raw Normal View History

Moved RtcEventLog files from call/ to logging/ The RtcEventLog headers need to be accessible from any place which needs logging, and the implementation needs access to data structures that are logged. After a discussion in the code review, we all agreed to move the RtcEventLog implementation into its own top level directory - which I called "logging/" in expectation that other types of logging may have similar requirements. The directory contains two main build targets - "rtc_event_log_api", which is just rtc_event_log.h, that has no external dependencies and can be used from anywhere, and "rtc_event_log_impl" which contains the rest of the implementation and has many dependencies (more in the future). The "api" target can be referenced from anywhere, while the "impl" target is only needed at the place of instantiation (currently Call, soon to be moved to PeerConnection by https://codereview.webrtc.org/2353033005/). This change allows using RtcEventLog in the p2p/ directory, so that we can log STUN pings and ICE state transitions. BUG=webrtc:6393 R=kjellander@webrtc.org, kwiberg@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, terelius@webrtc.org Review URL: https://codereview.webrtc.org/2380683005 . Cr-Commit-Position: refs/heads/master@{#14485}
2016-10-03 18:31:22 -07:00
skvlad@webrtc.org
stefan@webrtc.org
terelius@webrtc.org
Reference in New Issue Copy Permalink
Powered by Gitea Version: 1.23.5 Page: 307ms Template: 1ms
English
Bahasa Indonesia Deutsch English Español Français Gaeilge Italiano Latviešu Magyar nyelv Nederlands Polski Português de Portugal Português do Brasil Suomi Svenska Türkçe Čeština Ελληνικά Български Русский Українська فارسی മലയാളം 日本語 简体中文 繁體中文(台灣) 繁體中文(香港) 한국어
Licenses API