admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[PCLF] Make AddPeer return PeerHandle*

Browse Source 
Bug: b/198796179
Change-Id: Ib4d2fbdf2c4e69f8349095858c8fbe47b25aa82b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/231183
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#34921}
This commit is contained in:
Artem Titov 2021-09-03 23:38:40 +02:00 committed by WebRTC LUCI CQ
parent 79f82c1a57
commit 15157abf02
3 changed files with 12 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
api/test/peerconnection_quality_test_fixture.h
View File

@ -498,9 +498,12 @@ class PeerConnectionE2EQualityTestFixture {
// `network_manager` will be used to provide network interfaces for peer's
// peer connection.
// `configurer` function will be used to configure peer in the call.
virtual void AddPeer(rtc::Thread* network_thread,
rtc::NetworkManager* network_manager,
rtc::FunctionView<void(PeerConfigurer*)> configurer) {}
virtual PeerHandle* AddPeer(
rtc::Thread* network_thread,
rtc::NetworkManager* network_manager,
rtc::FunctionView<void(PeerConfigurer*)> configurer) {
return nullptr;
}
virtual PeerHandle* AddAndReturnPeer(
rtc::Thread* network_thread,
rtc::NetworkManager* network_manager,

4
test/pc/e2e/peer_connection_quality_test.cc
View File

@ -166,11 +166,11 @@ PeerConnectionE2EQualityTest::AddAndReturnPeer(
return &peer_handles_.back();
}
void PeerConnectionE2EQualityTest::AddPeer(
PeerConnectionE2EQualityTest::PeerHandle* PeerConnectionE2EQualityTest::AddPeer(
rtc::Thread* network_thread,
rtc::NetworkManager* network_manager,
rtc::FunctionView<void(PeerConfigurer*)> configurer) {
AddAndReturnPeer(network_thread, network_manager, configurer);
return AddAndReturnPeer(network_thread, network_manager, configurer);
}
void PeerConnectionE2EQualityTest::Run(RunParams run_params) {

7
test/pc/e2e/peer_connection_quality_test.h
View File

@ -68,9 +68,10 @@ class PeerConnectionE2EQualityTest
void AddQualityMetricsReporter(std::unique_ptr<QualityMetricsReporter>
quality_metrics_reporter) override;
void AddPeer(rtc::Thread* network_thread,
rtc::NetworkManager* network_manager,
rtc::FunctionView<void(PeerConfigurer*)> configurer) override;
PeerHandle* AddPeer(
rtc::Thread* network_thread,
rtc::NetworkManager* network_manager,
rtc::FunctionView<void(PeerConfigurer*)> configurer) override;
PeerHandle* AddAndReturnPeer(
rtc::Thread* network_thread,
rtc::NetworkManager* network_manager,