admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make .clang-format ObjC respect Chromium column limit length

Browse Source 
Currently, WebRTC .clang-format file is configured to support column length of up to 100: https://source.chromium.org/chromium/chromium/src/+/main:third_party/webrtc/.clang-format;l=12;drc=73012534918d8c65ae748fff8ca18ad5c857b82e

While Google guidelines mention supporting up to 100 (https://google.github.io/styleguide/objcguide.html#line-length), Chromium guidelines mention up to 80, like in C++ (https://chromium.googlesource.com/chromium/src/+/lkgr/styleguide/objective-c/objective-c.md#line-length)

WebRTC guidelines mention that in case of conflicts, the Chromium guidelines should be followed (https://webrtc.googlesource.com/src/+/HEAD/g3doc/style-guide.md)

Hence, I'm suggesting changing the ObjC ColumnLimit parameter from 100 to 80.

Bug: webrtc:387828388
Change-Id: If9186bebec92cb0c01015084c3e47ad210dccc33
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/373620
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43663}
This commit is contained in:
Boris Tsirkin 2025-01-06 08:20:11 -08:00 committed by WebRTC LUCI CQ
parent 2b04fb77a1
commit 4b96bfde96
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.clang-format
View File

@ -9,7 +9,7 @@ Language: ObjC
BasedOnStyle: Google
BinPackParameters: false
BinPackArguments: false
ColumnLimit: 100
ColumnLimit: 80
ObjCBlockIndentWidth: 2
AllowAllParametersOfDeclarationOnNextLine: true
AlignOperands: false