admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Ensure the sequence number is initialized in DelayBasedBweTest

Browse Source 
The sequence number is generally not used for the estimation,
but may be used as a tie-breaker when ordering packet feedbacks.

Bug: b/299667054
Change-Id: I52a5145c889c8f6924838667cc267b1cd9565f7b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/320240
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40749}
This commit is contained in:
Björn Terelius 2023-09-14 10:07:53 +02:00 committed by WebRTC LUCI CQ
parent 1a5630eb99
commit 4f8ccc3c60
2 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
modules/congestion_controller/goog_cc/delay_based_bwe_unittest_helper.cc
View File

@ -166,6 +166,7 @@ DelayBasedBweTest::DelayBasedBweTest()
stream_generator_(new test::StreamGenerator(1e6, // Capacity.
clock_.TimeInMicroseconds())),
arrival_time_offset_ms_(0),
next_sequence_number_(0),
first_update_(true) {}
DelayBasedBweTest::~DelayBasedBweTest() {}
@ -201,6 +202,7 @@ void DelayBasedBweTest::IncomingFeedback(Timestamp receive_time,
packet.sent_packet.send_time = send_time;
packet.sent_packet.size = DataSize::Bytes(payload_size);
packet.sent_packet.pacing_info = pacing_info;
packet.sent_packet.sequence_number = next_sequence_number_++;
if (packet.sent_packet.pacing_info.probe_cluster_id !=
PacedPacketInfo::kNotAProbe)
probe_bitrate_estimator_->HandleProbeAndEstimateBitrate(packet);

1
modules/congestion_controller/goog_cc/delay_based_bwe_unittest_helper.h
View File

@ -180,6 +180,7 @@ class DelayBasedBweTest : public ::testing::Test {
std::unique_ptr<DelayBasedBwe> bitrate_estimator_;
std::unique_ptr<test::StreamGenerator> stream_generator_;
int64_t arrival_time_offset_ms_;
int64_t next_sequence_number_;
bool first_update_;
};