admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Replace RTPHeader memset with assignment from a fresh object.

Browse Source 
Since RTPHeader contains std::string members, memset results in
undefined behavior, with memory leaks being the best case.

Bug: chromium:945598
Change-Id: I5c04e6b2fb08816fc036abfbb6ba7aaf19469687
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/129720
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27282}
This commit is contained in:
Niels Möller 2019-03-26 10:36:02 +01:00 committed by Commit Bot
parent f2ca8c5341
commit 50686460ca
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
modules/rtp_rtcp/source/rtp_header_parser.cc
View File

@ -64,7 +64,7 @@ bool RtpHeaderParserImpl::Parse(const uint8_t* packet,
size_t length,
RTPHeader* header) const {
RtpUtility::RtpHeaderParser rtp_parser(packet, length);
memset(header, 0, sizeof(*header));
*header = RTPHeader();
RtpHeaderExtensionMap map;
{