admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Skip nullable check when building in Chromium

Browse Source 
Otherwise it fails when building 'all':
"javac: invalid flag: -Xep:ParameterNotNullable:ERROR"

No-Try: True
Bug: chromium:824679, webrtc:8881
Change-Id: Ib2e5ca1257bfe3c3d0f0ecfce2d5ac2bd165720b
Reviewed-on: https://webrtc-review.googlesource.com/64040
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22556}
This commit is contained in:
Oleh Prypin 2018-03-22 10:02:10 +01:00 committed by Commit Bot
parent 24a842a15c
commit a09993d147
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
rtc_base/BUILD.gn
View File

@ -1381,11 +1381,14 @@ if (is_android) {
"java/src/org/webrtc/ThreadUtils.java",
]
javac_args = [
"-Xep:ParameterNotNullable:ERROR",
"-Xep:FieldMissingNullable:ERROR",
"-Xep:ReturnMissingNullable:ERROR",
]
# TODO(crbug.com/824679): Find out why this fails in Chromium
if (!build_with_chromium) {
javac_args = [
"-Xep:ParameterNotNullable:ERROR",
"-Xep:FieldMissingNullable:ERROR",
"-Xep:ReturnMissingNullable:ERROR",
]
}
deps = [
"//third_party/jsr-305:jsr_305_javalib",