Update old TODO comments

Bug: None
Change-Id: I531ed648fe3d1f0dd1202f53c59ed023aed1ea7c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267664
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37432}
This commit is contained in:
Niels Möller 2022-07-05 09:59:27 +02:00 committed by WebRTC LUCI CQ
parent 27b35a7882
commit b5b159d98c
9 changed files with 13 additions and 19 deletions

View File

@ -1245,8 +1245,8 @@ void LegacyStatsCollector::ExtractSenderInfo() {
RTC_DCHECK_RUN_ON(pc_->signaling_thread()); RTC_DCHECK_RUN_ON(pc_->signaling_thread());
for (const auto& sender : pc_->GetSenders()) { for (const auto& sender : pc_->GetSenders()) {
// TODO(nisse): SSRC == 0 currently means none. Delete check when // TODO(bugs.webrtc.org/8694): SSRC == 0 currently means none. Delete check
// that is fixed. // when that is fixed.
if (!sender->ssrc()) { if (!sender->ssrc()) {
continue; continue;
} }

View File

@ -201,8 +201,8 @@ class RtpSenderBase : public RtpSenderInternal, public ObserverInterface {
RtpSenderBase(rtc::Thread* worker_thread, RtpSenderBase(rtc::Thread* worker_thread,
const std::string& id, const std::string& id,
SetStreamsObserver* set_streams_observer); SetStreamsObserver* set_streams_observer);
// TODO(nisse): Since SSRC == 0 is technically valid, figure out // TODO(bugs.webrtc.org/8694): Since SSRC == 0 is technically valid, figure
// some other way to test if we have a valid SSRC. // out some other way to test if we have a valid SSRC.
bool can_send_track() const { return track_ && ssrc_; } bool can_send_track() const { return track_ && ssrc_; }
virtual std::string track_kind() const = 0; virtual std::string track_kind() const = 0;

View File

@ -28,8 +28,6 @@ namespace webrtc {
// FakePeerConnectionBase then overriding the interesting methods. This class // FakePeerConnectionBase then overriding the interesting methods. This class
// takes care of providing default implementations for all the pure virtual // takes care of providing default implementations for all the pure virtual
// functions specified in the interfaces. // functions specified in the interfaces.
// TODO(nisse): Try to replace this with DummyPeerConnection, from
// api/test/ ?
class FakePeerConnectionBase : public PeerConnectionInternal { class FakePeerConnectionBase : public PeerConnectionInternal {
public: public:
// PeerConnectionInterface implementation. // PeerConnectionInterface implementation.

View File

@ -36,9 +36,7 @@ public final class YuvConverter {
// Since the alpha read from the texture is always 1, this could // Since the alpha read from the texture is always 1, this could
// be written as a mat4 x vec4 multiply. However, that seems to // be written as a mat4 x vec4 multiply. However, that seems to
// give a worse framerate, possibly because the additional // give a worse framerate, possibly because the additional
// multiplies by 1.0 consume resources. TODO(nisse): Could also // multiplies by 1.0 consume resources.
// try to do it as a vec3 x mat3x4, followed by an add in of a
// constant vector.
+ " gl_FragColor.r = coeffs.a + dot(coeffs.rgb,\n" + " gl_FragColor.r = coeffs.a + dot(coeffs.rgb,\n"
+ " sample(tc - 1.5 * xUnit).rgb);\n" + " sample(tc - 1.5 * xUnit).rgb);\n"
+ " gl_FragColor.g = coeffs.a + dot(coeffs.rgb,\n" + " gl_FragColor.g = coeffs.a + dot(coeffs.rgb,\n"

View File

@ -30,7 +30,6 @@ class ScopedJavaRefCounted {
const JavaRef<jobject>& j_object); const JavaRef<jobject>& j_object);
ScopedJavaRefCounted(ScopedJavaRefCounted&& other) = default; ScopedJavaRefCounted(ScopedJavaRefCounted&& other) = default;
// TODO(nisse): Implement move assignment and copy operations when needed.
ScopedJavaRefCounted(const ScopedJavaRefCounted& other) = delete; ScopedJavaRefCounted(const ScopedJavaRefCounted& other) = delete;
ScopedJavaRefCounted& operator=(const ScopedJavaRefCounted&) = delete; ScopedJavaRefCounted& operator=(const ScopedJavaRefCounted&) = delete;

View File

@ -58,8 +58,9 @@ class StatsBasedNetworkQualityMetricsReporter
private: private:
struct PCStats { struct PCStats {
// TODO(nisse): Separate audio and video counters. Depends on standard stat // TODO(bugs.webrtc.org/10525): Separate audio and video counters. Depends
// counters, enabled by field trial "WebRTC-UseStandardBytesStats". // on standard stat counters, enabled by field trial
// "WebRTC-UseStandardBytesStats".
DataSize payload_received = DataSize::Zero(); DataSize payload_received = DataSize::Zero();
DataSize payload_sent = DataSize::Zero(); DataSize payload_sent = DataSize::Zero();

View File

@ -646,11 +646,11 @@ void RtpVideoStreamReceiver2::OnRecoveredPacket(const uint8_t* rtp_packet,
packet.IdentifyExtensions(rtp_header_extensions_); packet.IdentifyExtensions(rtp_header_extensions_);
packet.set_payload_type_frequency(kVideoPayloadTypeFrequency); packet.set_payload_type_frequency(kVideoPayloadTypeFrequency);
// TODO(nisse): UlpfecReceiverImpl::ProcessReceivedFec passes both // TODO(bugs.webrtc.org/7135): UlpfecReceiverImpl::ProcessReceivedFec passes
// original (decapsulated) media packets and recovered packets to // both original (decapsulated) media packets and recovered packets to this
// this callback. We need a way to distinguish, for setting // callback. We need a way to distinguish, for setting packet.recovered()
// packet.recovered() correctly. Ideally, move RED decapsulation out // correctly. Ideally, move RED decapsulation out of the Ulpfec
// of the Ulpfec implementation. // implementation.
ReceivePacket(packet); ReceivePacket(packet);
} }

View File

@ -954,7 +954,6 @@ void VideoQualityTest::SetupThumbnails(Transport* send_transport,
// sender_call. // sender_call.
VideoSendStream::Config thumbnail_send_config(recv_transport); VideoSendStream::Config thumbnail_send_config(recv_transport);
thumbnail_send_config.rtp.ssrcs.push_back(kThumbnailSendSsrcStart + i); thumbnail_send_config.rtp.ssrcs.push_back(kThumbnailSendSsrcStart + i);
// TODO(nisse): Could use a simpler VP8-only encoder factory.
thumbnail_send_config.encoder_settings.encoder_factory = thumbnail_send_config.encoder_settings.encoder_factory =
&video_encoder_factory_; &video_encoder_factory_;
thumbnail_send_config.encoder_settings.bitrate_allocator_factory = thumbnail_send_config.encoder_settings.bitrate_allocator_factory =

View File

@ -2274,7 +2274,6 @@ void VideoStreamEncoder::RunPostEncode(const EncodedImage& encoded_image,
absl::optional<int> encode_duration_us; absl::optional<int> encode_duration_us;
if (encoded_image.timing_.flags != VideoSendTiming::kInvalid) { if (encoded_image.timing_.flags != VideoSendTiming::kInvalid) {
encode_duration_us = encode_duration_us =
// TODO(nisse): Maybe use capture_time_ms_ rather than encode_start_ms_?
TimeDelta::Millis(encoded_image.timing_.encode_finish_ms - TimeDelta::Millis(encoded_image.timing_.encode_finish_ms -
encoded_image.timing_.encode_start_ms) encoded_image.timing_.encode_start_ms)
.us(); .us();