admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Check out the msan instrumented libraries by default.

Browse Source 
In order to unblock the chromium roll into WebRTC we have to
uniform the WebRTC DEPS file to the change done in:
https://chromium-review.googlesource.com/c/chromium/src/+/706280.

third_party/instrumented_libraries/scripts/download_binaries.py is
not needed anymore and msan instrumented libraries are downloaded
by default.

Bug: None
Change-Id: I46e7442866be38b366a6d53efa2b81bcd276c919
Reviewed-on: https://webrtc-review.googlesource.com/7863
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Henrik Kjellander <kjellander@google.com>
Cr-Commit-Position: refs/heads/master@{#20220}
This commit is contained in:
Mirko Bonadei 2017-10-10 13:28:18 +02:00 committed by Commit Bot
parent 6e8785045f
commit cb2bc11e7b
1 changed files with 26 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
DEPS
View File

@ -2,6 +2,10 @@
vars = { vars = {
'chromium_git': 'https://chromium.googlesource.com', 'chromium_git': 'https://chromium.googlesource.com',
# By default, we should check out everything needed to run on the main
# chromium waterfalls. More info at: crbug.com/570091.
'checkout_configuration': 'default',
'checkout_instrumented_libraries': 'checkout_linux and checkout_configuration == "default"',
'webrtc_git': 'https://webrtc.googlesource.com', 'webrtc_git': 'https://webrtc.googlesource.com',
'chromium_revision': 'c6405066cc384ad8a623c2e54fcee6d7ce3aebb9', 'chromium_revision': 'c6405066cc384ad8a623c2e54fcee6d7ce3aebb9',
'boringssl_git': 'https://boringssl.googlesource.com', 'boringssl_git': 'https://boringssl.googlesource.com',
@ -349,13 +353,28 @@ hooks = [
], ],
}, },
{ {
# Pull sanitizer-instrumented third-party libraries if requested via 'name': 'msan_chained_origins',
# GYP_DEFINES. 'pattern': '.',
# See src/third_party/instrumented_libraries/scripts/download_binaries.py. 'condition': 'checkout_instrumented_libraries',
# TODO(kjellander): Update comment when GYP is completely cleaned up. 'action': [ 'python',
'name': 'instrumented_libraries', 'src/third_party/depot_tools/download_from_google_storage.py',
'pattern': '\\.sha1', "--no_resume",
'action': ['python', 'src/third_party/instrumented_libraries/scripts/download_binaries.py'], "--no_auth",
"--bucket", "chromium-instrumented-libraries",
"-s", "src/third_party/instrumented_libraries/binaries/msan-chained-origins-trusty.tgz.sha1",
],
},
{
'name': 'msan_no_origins',
'pattern': '.',
'condition': 'checkout_instrumented_libraries',
'action': [ 'python',
'src/third_party/depot_tools/download_from_google_storage.py',
"--no_resume",
"--no_auth",
"--bucket", "chromium-instrumented-libraries",
"-s", "src/third_party/instrumented_libraries/binaries/msan-no-origins-trusty.tgz.sha1",
],
}, },
{ {
# Download test resources, i.e. video and audio files from Google Storage. # Download test resources, i.e. video and audio files from Google Storage.