admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Enable -Winconsistent-missing-override flag.

Browse Source 
The problem with gmock is worked around by commenting out any other override declarations in classes using gmock.

NOPRESUBMIT=True
BUG=webrtc:3970

Review-Url: https://codereview.webrtc.org/1921653002
Cr-Commit-Position: refs/heads/master@{#12563}
This commit is contained in:
nisse 2016-04-29 06:09:15 -07:00 committed by Commit bot
parent b296d0591c
commit ef8b61e110
58 changed files with 231 additions and 196 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
webrtc/BUILD.gn
View File

@ -117,6 +117,7 @@ config("common_config") {
cflags += [
"-Wimplicit-fallthrough",
"-Wthread-safety",
"-Winconsistent-missing-override",
]
}
}

2
webrtc/api/dtmfsender.h
View File

@ -83,7 +83,7 @@ class DtmfSender
DtmfSender();
// Implements MessageHandler.
virtual void OnMessage(rtc::Message* msg);
void OnMessage(rtc::Message* msg) override;
// The DTMF sending task.
void DoInsertDtmf();

2
webrtc/api/dtmfsender_unittest.cc
View File

@ -96,7 +96,7 @@ class FakeDtmfProvider : public DtmfProviderInterface {
return true;
}
virtual sigslot::signal0<>* GetOnDestroyedSignal() {
sigslot::signal0<>* GetOnDestroyedSignal() override {
return &SignalDestroyed;
}

2
webrtc/api/java/jni/peerconnection_jni.cc
View File

@ -202,7 +202,7 @@ class PCOJava : public PeerConnectionObserver {
}
void OnIceCandidatesRemoved(
const std::vector<cricket::Candidate>& candidates) {
const std::vector<cricket::Candidate>& candidates) override {
ScopedLocalRefFrame local_ref_frame(jni());
jobjectArray candidates_array = ToJavaCandidateArray(jni(), candidates);
jmethodID m =

8
webrtc/api/mediastream.h
View File

@ -31,10 +31,10 @@ class MediaStream : public Notifier<MediaStreamInterface> {
bool AddTrack(VideoTrackInterface* track) override;
bool RemoveTrack(AudioTrackInterface* track) override;
bool RemoveTrack(VideoTrackInterface* track) override;
virtual rtc::scoped_refptr<AudioTrackInterface>
FindAudioTrack(const std::string& track_id);
virtual rtc::scoped_refptr<VideoTrackInterface>
FindVideoTrack(const std::string& track_id);
rtc::scoped_refptr<AudioTrackInterface>
FindAudioTrack(const std::string& track_id) override;
rtc::scoped_refptr<VideoTrackInterface>
FindVideoTrack(const std::string& track_id) override;
AudioTrackVector GetAudioTracks() override { return audio_tracks_; }
VideoTrackVector GetVideoTracks() override { return video_tracks_; }

2
webrtc/api/peerconnectionfactory.h
View File

@ -35,7 +35,7 @@ typedef rtc::RefCountedObject<DtlsIdentityStoreImpl>
class PeerConnectionFactory : public PeerConnectionFactoryInterface {
public:
virtual void SetOptions(const Options& options) {
void SetOptions(const Options& options) override {
options_ = options;
}

4
webrtc/api/peerconnectioninterface_unittest.cc
View File

@ -424,8 +424,8 @@ class MockPeerConnectionObserver : public PeerConnectionObserver {
state_ = pc_->signaling_state();
}
}
virtual void OnSignalingChange(
PeerConnectionInterface::SignalingState new_state) {
void OnSignalingChange(
PeerConnectionInterface::SignalingState new_state) override {
EXPECT_EQ(pc_->signaling_state(), new_state);
state_ = new_state;
}

8
webrtc/api/rtpsender.h
View File

@ -98,8 +98,8 @@ class AudioRtpSender : public ObserverInterface,
void Stop() override;
RtpParameters GetParameters() const;
bool SetParameters(const RtpParameters& parameters);
RtpParameters GetParameters() const override;
bool SetParameters(const RtpParameters& parameters) override;
private:
// TODO(nisse): Since SSRC == 0 is technically valid, figure out
@ -164,8 +164,8 @@ class VideoRtpSender : public ObserverInterface,
void Stop() override;
RtpParameters GetParameters() const;
bool SetParameters(const RtpParameters& parameters);
RtpParameters GetParameters() const override;
bool SetParameters(const RtpParameters& parameters) override;
private:
bool can_send_track() const { return track_ && ssrc_; }

10
webrtc/api/rtpsenderreceiver_unittest.cc
View File

@ -43,7 +43,11 @@ namespace webrtc {
// Helper class to test RtpSender/RtpReceiver.
class MockAudioProvider : public AudioProviderInterface {
public:
~MockAudioProvider() override {}
// TODO(nisse): Valid overrides commented out, because the gmock
// methods don't use any override declarations, and we want to avoid
// warnings from -Winconsistent-missing-override. See
// http://crbug.com/428099.
~MockAudioProvider() /* override */ {}
MOCK_METHOD2(SetAudioPlayout,
void(uint32_t ssrc,
@ -58,8 +62,8 @@ class MockAudioProvider : public AudioProviderInterface {
MOCK_METHOD2(SetAudioRtpParameters,
bool(uint32_t ssrc, const RtpParameters&));
void SetRawAudioSink(uint32_t,
std::unique_ptr<AudioSinkInterface> sink) override {
void SetRawAudioSink(
uint32_t, std::unique_ptr<AudioSinkInterface> sink) /* override */ {
sink_ = std::move(sink);
}

6
webrtc/api/statscollector_unittest.cc
View File

@ -67,6 +67,10 @@ const uint32_t kSsrcOfTrack = 1234;
class MockWebRtcSession : public webrtc::WebRtcSession {
public:
// TODO(nisse): Valid overrides commented out, because the gmock
// methods don't use any override declarations, and we want to avoid
// warnings from -Winconsistent-missing-override. See
// http://crbug.com/428099.
explicit MockWebRtcSession(webrtc::MediaControllerInterface* media_controller)
: WebRtcSession(media_controller,
rtc::Thread::Current(),
@ -85,7 +89,7 @@ class MockWebRtcSession : public webrtc::WebRtcSession {
// Workaround for gmock's inability to cope with move-only return values.
std::unique_ptr<rtc::SSLCertificate> GetRemoteSSLCertificate(
const std::string& transport_name) override {
const std::string& transport_name) /* override */ {
return std::unique_ptr<rtc::SSLCertificate>(
GetRemoteSSLCertificate_ReturnsRawPointer(transport_name));
}

12
webrtc/api/test/fakeaudiocapturemodule.h
View File

@ -174,12 +174,12 @@ class FakeAudioCaptureModule
int32_t ResetAudioDevice() override;
int32_t SetLoudspeakerStatus(bool enable) override;
int32_t GetLoudspeakerStatus(bool* enabled) const override;
virtual bool BuiltInAECIsAvailable() const { return false; }
virtual int32_t EnableBuiltInAEC(bool enable) { return -1; }
virtual bool BuiltInAGCIsAvailable() const { return false; }
virtual int32_t EnableBuiltInAGC(bool enable) { return -1; }
virtual bool BuiltInNSIsAvailable() const { return false; }
virtual int32_t EnableBuiltInNS(bool enable) { return -1; }
bool BuiltInAECIsAvailable() const override { return false; }
int32_t EnableBuiltInAEC(bool enable) override { return -1; }
bool BuiltInAGCIsAvailable() const override { return false; }
int32_t EnableBuiltInAGC(bool enable) override { return -1; }
bool BuiltInNSIsAvailable() const override { return false; }
int32_t EnableBuiltInNS(bool enable) override { return -1; }
// End of functions inherited from webrtc::AudioDeviceModule.
// The following function is inherited from rtc::MessageHandler.

2
webrtc/api/test/fakeaudiocapturemodule_unittest.cc
View File

@ -31,7 +31,7 @@ class FakeAdmTest : public testing::Test,
memset(rec_buffer_, 0, sizeof(rec_buffer_));
}
virtual void SetUp() {
void SetUp() override {
fake_audio_capture_module_ = FakeAudioCaptureModule::Create();
EXPECT_TRUE(fake_audio_capture_module_.get() != NULL);
}

2
webrtc/api/test/fakedtlsidentitystore.h
View File

@ -146,7 +146,7 @@ class FakeDtlsIdentityStore : public webrtc::DtlsIdentityStoreInterface,
const char* get_cert() { return kKeysAndCerts[key_index_].cert_pem; }
// rtc::MessageHandler implementation.
void OnMessage(rtc::Message* msg) {
void OnMessage(rtc::Message* msg) override {
MessageData* message_data = static_cast<MessageData*>(msg->pdata);
rtc::scoped_refptr<webrtc::DtlsIdentityRequestObserver> observer =
message_data->data();

6
webrtc/api/videotrack.h
View File

@ -33,11 +33,11 @@ class VideoTrack : public MediaStreamTrack<VideoTrackInterface>,
const rtc::VideoSinkWants& wants) override;
void RemoveSink(rtc::VideoSinkInterface<cricket::VideoFrame>* sink) override;
virtual VideoTrackSourceInterface* GetSource() const {
VideoTrackSourceInterface* GetSource() const override {
return video_source_.get();
}
virtual bool set_enabled(bool enable);
virtual std::string kind() const;
bool set_enabled(bool enable) override;
std::string kind() const override;
protected:
VideoTrack(const std::string& id, VideoTrackSourceInterface* video_source);

4
webrtc/api/videotracksource.h
View File

@ -36,8 +36,8 @@ class VideoTrackSource : public Notifier<VideoTrackSourceInterface> {
void Stop() override{};
void Restart() override{};
virtual bool is_screencast() const { return false; }
virtual rtc::Optional<bool> needs_denoising() const {
bool is_screencast() const override { return false; }
rtc::Optional<bool> needs_denoising() const override {
return rtc::Optional<bool>(); }
bool GetStats(Stats* stats) override { return false; }

8
webrtc/api/webrtcsession.h
View File

@ -267,10 +267,10 @@ class WebRtcSession : public AudioProviderInterface,
const RtpParameters& parameters) override;
// Implements DtmfProviderInterface.
virtual bool CanInsertDtmf(const std::string& track_id);
virtual bool InsertDtmf(const std::string& track_id,
int code, int duration);
virtual sigslot::signal0<>* GetOnDestroyedSignal();
bool CanInsertDtmf(const std::string& track_id) override;
bool InsertDtmf(const std::string& track_id,
int code, int duration) override;
sigslot::signal0<>* GetOnDestroyedSignal() override;
// Implements DataChannelProviderInterface.
bool SendData(const cricket::SendDataParams& params,

2
webrtc/api/webrtcsession_unittest.cc
View File

@ -191,7 +191,7 @@ class MockIceObserver : public webrtc::IceObserver {
// Some local candidates are removed.
void OnIceCandidatesRemoved(
const std::vector<cricket::Candidate>& candidates) {
const std::vector<cricket::Candidate>& candidates) override {
num_candidates_removed_ += candidates.size();
}

2
webrtc/base/callback_unittest.cc
View File

@ -34,7 +34,7 @@ class RefCountedBindTester : public RefCountInterface {
int AddRef() const override {
return ++count_;
}
int Release() const {
int Release() const override {
return --count_;
}
int RefCount() const { return count_; }

18
webrtc/base/fakesslidentity.h
View File

@ -37,13 +37,13 @@ class FakeSSLCertificate : public rtc::SSLCertificate {
certs_.push_back(FakeSSLCertificate(*it));
}
}
virtual FakeSSLCertificate* GetReference() const {
FakeSSLCertificate* GetReference() const override {
return new FakeSSLCertificate(*this);
}
virtual std::string ToPEMString() const {
std::string ToPEMString() const override {
return data_;
}
virtual void ToDER(Buffer* der_buffer) const {
void ToDER(Buffer* der_buffer) const override {
std::string der_string;
VERIFY(SSLIdentity::PemToDer(kPemTypeCertificate, data_, &der_string));
der_buffer->SetData(der_string.c_str(), der_string.size());
@ -57,19 +57,19 @@ class FakeSSLCertificate : public rtc::SSLCertificate {
void set_digest_algorithm(const std::string& algorithm) {
digest_algorithm_ = algorithm;
}
virtual bool GetSignatureDigestAlgorithm(std::string* algorithm) const {
bool GetSignatureDigestAlgorithm(std::string* algorithm) const override {
*algorithm = digest_algorithm_;
return true;
}
virtual bool ComputeDigest(const std::string& algorithm,
unsigned char* digest,
size_t size,
size_t* length) const {
bool ComputeDigest(const std::string& algorithm,
unsigned char* digest,
size_t size,
size_t* length) const override {
*length = rtc::ComputeDigest(algorithm, data_.c_str(), data_.size(),
digest, size);
return (*length != 0);
}
virtual std::unique_ptr<SSLCertChain> GetChain() const {
std::unique_ptr<SSLCertChain> GetChain() const override {
if (certs_.empty())
return nullptr;
std::vector<SSLCertificate*> new_certs(certs_.size());

4
webrtc/base/rtccertificategenerator_unittest.cc
View File

@ -36,13 +36,13 @@ class RTCCertificateGeneratorFixture : public RTCCertificateGeneratorCallback {
RTCCertificateGenerator* generator() const { return generator_.get(); }
RTCCertificate* certificate() const { return certificate_.get(); }
void OnSuccess(const scoped_refptr<RTCCertificate>& certificate) {
void OnSuccess(const scoped_refptr<RTCCertificate>& certificate) override {
RTC_CHECK(signaling_thread_->IsCurrent());
RTC_CHECK(certificate);
certificate_ = certificate;
generate_async_completed_ = true;
}
void OnFailure() {
void OnFailure() override {
RTC_CHECK(signaling_thread_->IsCurrent());
certificate_ = nullptr;
generate_async_completed_ = true;

12
webrtc/base/sslstreamadapter_unittest.cc
View File

@ -562,7 +562,7 @@ class SSLStreamAdapterTestTLS
}
// Test data transfer for TLS
virtual void TestTransfer(int size) {
void TestTransfer(int size) override {
LOG(LS_INFO) << "Starting transfer test with " << size << " bytes";
// Create some dummy data to send.
size_t received;
@ -591,7 +591,7 @@ class SSLStreamAdapterTestTLS
recv_stream_.GetBuffer(), size));
}
void WriteData() {
void WriteData() override {
size_t position, tosend, size;
rtc::StreamResult rv;
size_t sent;
@ -627,7 +627,7 @@ class SSLStreamAdapterTestTLS
}
};
virtual void ReadData(rtc::StreamInterface *stream) {
void ReadData(rtc::StreamInterface *stream) override {
char buffer[1600];
size_t bread;
int err2;
@ -691,7 +691,7 @@ class SSLStreamAdapterTestDTLS
new SSLDummyStreamDTLS(this, "s2c", &server_buffer_, &client_buffer_);
}
virtual void WriteData() {
void WriteData() override {
unsigned char *packet = new unsigned char[1600];
while (sent_ < count_) {
@ -720,7 +720,7 @@ class SSLStreamAdapterTestDTLS
delete [] packet;
}
virtual void ReadData(rtc::StreamInterface *stream) {
void ReadData(rtc::StreamInterface *stream) override {
unsigned char buffer[2000];
size_t bread;
int err2;
@ -756,7 +756,7 @@ class SSLStreamAdapterTestDTLS
}
}
virtual void TestTransfer(int count) {
void TestTransfer(int count) override {
count_ = count;
WriteData();

1
webrtc/build/common.gypi
View File

@ -309,6 +309,7 @@
'cflags': [
'-Wimplicit-fallthrough',
'-Wthread-safety',
'-Winconsistent-missing-override',
],
}],
],

2
webrtc/call/call_perf_tests.cc
View File

@ -395,7 +395,7 @@ void CallPerfTest::TestCaptureNtpTime(const FakeNetworkPipe::Config& net_config,
EXPECT_TRUE(std::abs(time_offset_ms) < threshold_ms_);
}
virtual Action OnSendRtp(const uint8_t* packet, size_t length) {
Action OnSendRtp(const uint8_t* packet, size_t length) override {
rtc::CritScope lock(&crit_);
RTPHeader header;
EXPECT_TRUE(parser_->Parse(packet, length, &header));

2
webrtc/common_video/i420_buffer_pool.cc
View File

@ -30,7 +30,7 @@ class PooledI420Buffer : public webrtc::VideoFrameBuffer {
const uint8_t* DataU() const override { return buffer_->DataU(); }
const uint8_t* DataV() const override { return buffer_->DataV(); }
bool IsMutable() { return HasOneRef(); }
bool IsMutable() override { return HasOneRef(); }
// Make the IsMutable() check here instead of in |buffer_|, because the pool
// also has a reference to |buffer_|.
uint8_t* MutableDataY() override {

22
webrtc/media/base/fakemediaengine.h
View File

@ -482,23 +482,23 @@ class FakeVideoMediaChannel : public RtpHelper<VideoMediaChannel> {
return sinks_;
}
int max_bps() const { return max_bps_; }
virtual bool SetSendParameters(const VideoSendParameters& params) {
bool SetSendParameters(const VideoSendParameters& params) override {
return (SetSendCodecs(params.codecs) &&
SetSendRtpHeaderExtensions(params.extensions) &&
SetMaxSendBandwidth(params.max_bandwidth_bps));
}
virtual bool SetRecvParameters(const VideoRecvParameters& params) {
bool SetRecvParameters(const VideoRecvParameters& params) override {
return (SetRecvCodecs(params.codecs) &&
SetRecvRtpHeaderExtensions(params.extensions));
}
virtual bool AddSendStream(const StreamParams& sp) {
bool AddSendStream(const StreamParams& sp) override {
return RtpHelper<VideoMediaChannel>::AddSendStream(sp);
}
virtual bool RemoveSendStream(uint32_t ssrc) {
bool RemoveSendStream(uint32_t ssrc) override {
return RtpHelper<VideoMediaChannel>::RemoveSendStream(ssrc);
}
virtual bool GetSendCodec(VideoCodec* send_codec) {
bool GetSendCodec(VideoCodec* send_codec) override {
if (send_codecs_.empty()) {
return false;
}
@ -516,9 +516,9 @@ class FakeVideoMediaChannel : public RtpHelper<VideoMediaChannel> {
return true;
}
virtual bool SetSend(bool send) { return set_sending(send); }
virtual bool SetVideoSend(uint32_t ssrc, bool enable,
const VideoOptions* options) {
bool SetSend(bool send) override { return set_sending(send); }
bool SetVideoSend(uint32_t ssrc, bool enable,
const VideoOptions* options) override {
if (!RtpHelper<VideoMediaChannel>::MuteStream(ssrc, !enable)) {
return false;
}
@ -536,20 +536,20 @@ class FakeVideoMediaChannel : public RtpHelper<VideoMediaChannel> {
bool HasSource(uint32_t ssrc) const {
return sources_.find(ssrc) != sources_.end();
}
virtual bool AddRecvStream(const StreamParams& sp) {
bool AddRecvStream(const StreamParams& sp) override {
if (!RtpHelper<VideoMediaChannel>::AddRecvStream(sp))
return false;
sinks_[sp.first_ssrc()] = NULL;
return true;
}
virtual bool RemoveRecvStream(uint32_t ssrc) {
bool RemoveRecvStream(uint32_t ssrc) override {
if (!RtpHelper<VideoMediaChannel>::RemoveRecvStream(ssrc))
return false;
sinks_.erase(ssrc);
return true;
}
virtual bool GetStats(VideoMediaInfo* info) { return false; }
bool GetStats(VideoMediaInfo* info) override { return false; }
private:
bool SetRecvCodecs(const std::vector<VideoCodec>& codecs) {

12
webrtc/media/engine/fakewebrtcvideoengine.h
View File

@ -182,8 +182,8 @@ class FakeWebRtcVideoEncoderFactory : public WebRtcVideoEncoderFactory {
num_created_encoders_(0),
encoders_have_internal_sources_(false) {}
virtual webrtc::VideoEncoder* CreateVideoEncoder(
webrtc::VideoCodecType type) {
webrtc::VideoEncoder* CreateVideoEncoder(
webrtc::VideoCodecType type) override {
rtc::CritScope lock(&crit_);
if (supported_codec_types_.count(type) == 0) {
return NULL;
@ -203,7 +203,7 @@ class FakeWebRtcVideoEncoderFactory : public WebRtcVideoEncoderFactory {
return false;
}
virtual void DestroyVideoEncoder(webrtc::VideoEncoder* encoder) {
void DestroyVideoEncoder(webrtc::VideoEncoder* encoder) override {
rtc::CritScope lock(&crit_);
encoders_.erase(
std::remove(encoders_.begin(), encoders_.end(), encoder),
@ -211,12 +211,12 @@ class FakeWebRtcVideoEncoderFactory : public WebRtcVideoEncoderFactory {
delete encoder;
}
virtual const std::vector<WebRtcVideoEncoderFactory::VideoCodec>& codecs()
const {
const std::vector<WebRtcVideoEncoderFactory::VideoCodec>& codecs()
const override {
return codecs_;
}
virtual bool EncoderTypeHasInternalSource(
bool EncoderTypeHasInternalSource(
webrtc::VideoCodecType type) const override {
return encoders_have_internal_sources_;
}

16
webrtc/media/engine/fakewebrtcvoiceengine.h
View File

@ -298,7 +298,7 @@ class FakeWebRtcVoiceEngine
channels_[channel]->associate_send_channel = accociate_send_channel;
return 0;
}
webrtc::RtcEventLog* GetEventLog() { return nullptr; }
webrtc::RtcEventLog* GetEventLog() override { return nullptr; }
// webrtc::VoECodec
WEBRTC_STUB(NumOfCodecs, ());
@ -449,11 +449,11 @@ class FakeWebRtcVoiceEngine
WEBRTC_STUB(SetPlayoutSampleRate, (unsigned int samples_per_sec));
WEBRTC_STUB_CONST(PlayoutSampleRate, (unsigned int* samples_per_sec));
WEBRTC_STUB(EnableBuiltInAEC, (bool enable));
virtual bool BuiltInAECIsAvailable() const { return false; }
bool BuiltInAECIsAvailable() const override { return false; }
WEBRTC_STUB(EnableBuiltInAGC, (bool enable));
virtual bool BuiltInAGCIsAvailable() const { return false; }
bool BuiltInAGCIsAvailable() const override { return false; }
WEBRTC_STUB(EnableBuiltInNS, (bool enable));
virtual bool BuiltInNSIsAvailable() const { return false; }
bool BuiltInNSIsAvailable() const override { return false; }
// webrtc::VoENetwork
WEBRTC_FUNC(RegisterExternalTransport, (int channel,
@ -661,17 +661,17 @@ class FakeWebRtcVoiceEngine
int reportingThreshold,
int penaltyDecay,
int typeEventDelay));
int EnableHighPassFilter(bool enable) {
int EnableHighPassFilter(bool enable) override {
highpass_filter_enabled_ = enable;
return 0;
}
bool IsHighPassFilterEnabled() {
bool IsHighPassFilterEnabled() override {
return highpass_filter_enabled_;
}
bool IsStereoChannelSwappingEnabled() {
bool IsStereoChannelSwappingEnabled() override {
return stereo_swapping_enabled_;
}
void EnableStereoChannelSwapping(bool enable) {
void EnableStereoChannelSwapping(bool enable) override {
stereo_swapping_enabled_ = enable;
}
int GetNetEqCapacity() const {

10
webrtc/media/engine/webrtcvideocapturer.h
View File

@ -61,14 +61,14 @@ class WebRtcVideoCapturer : public VideoCapturer,
protected:
void OnSinkWantsChanged(const rtc::VideoSinkWants& wants) override;
// Override virtual methods of the parent class VideoCapturer.
virtual bool GetPreferredFourccs(std::vector<uint32_t>* fourccs);
bool GetPreferredFourccs(std::vector<uint32_t>* fourccs) override;
private:
// Callback when a frame is captured by camera.
virtual void OnIncomingCapturedFrame(const int32_t id,
const webrtc::VideoFrame& frame);
virtual void OnCaptureDelayChanged(const int32_t id,
const int32_t delay);
void OnIncomingCapturedFrame(const int32_t id,
const webrtc::VideoFrame& frame) override;
void OnCaptureDelayChanged(const int32_t id,
const int32_t delay) override;
// Used to signal captured frames on the same thread as invoked Start().
// With WebRTC's current VideoCapturer implementations, this will mean a

2
webrtc/modules/audio_coding/acm2/acm_send_test_oldapi.h
View File

@ -47,7 +47,7 @@ class AcmSendTestOldApi : public AudioPacketizationCallback,
// Returns the next encoded packet. Returns NULL if the test duration was
// exceeded. Ownership of the packet is handed over to the caller.
// Inherited from PacketSource.
Packet* NextPacket();
Packet* NextPacket() override;
// Inherited from AudioPacketizationCallback.
int32_t SendData(FrameType frame_type,

14
webrtc/modules/audio_coding/acm2/audio_coding_module_unittest_oldapi.cc
View File

@ -608,7 +608,7 @@ class AcmIsacMtTestOldApi : public AudioCodingModuleMtTestOldApi {
~AcmIsacMtTestOldApi() {}
void SetUp() {
void SetUp() override {
AudioCodingModuleTestOldApi::SetUp();
RegisterCodec(); // Must be called before the threads start below.
@ -642,7 +642,7 @@ class AcmIsacMtTestOldApi : public AudioCodingModuleMtTestOldApi {
ASSERT_EQ(0, acm_->RegisterSendCodec(codec_));
}
void InsertPacket() {
void InsertPacket() override {
int num_calls = packet_cb_.num_calls(); // Store locally for thread safety.
if (num_calls > last_packet_number_) {
// Get the new payload out from the callback handler.
@ -661,7 +661,7 @@ class AcmIsacMtTestOldApi : public AudioCodingModuleMtTestOldApi {
&last_payload_vec_[0], last_payload_vec_.size(), rtp_header_));
}
void InsertAudio() {
void InsertAudio() override {
// TODO(kwiberg): Use std::copy here. Might be complications because AFAICS
// this call confuses the number of samples with the number of bytes, and
// ends up copying only half of what it should.
@ -677,7 +677,7 @@ class AcmIsacMtTestOldApi : public AudioCodingModuleMtTestOldApi {
// This method is the same as AudioCodingModuleMtTestOldApi::TestDone(), but
// here it is using the constants defined in this class (i.e., shorter test
// run).
virtual bool TestDone() {
bool TestDone() override {
if (packet_cb_.num_calls() > kNumPackets) {
rtc::CritScope lock(&crit_sect_);
if (pull_audio_count_ > kNumPullCalls) {
@ -728,7 +728,7 @@ class AcmReRegisterIsacMtTestOldApi : public AudioCodingModuleTestOldApi {
clock_ = fake_clock_.get();
}
void SetUp() {
void SetUp() override {
AudioCodingModuleTestOldApi::SetUp();
// Set up input audio source to read from specified file, loop after 5
// seconds, and deliver blocks of 10 ms.
@ -757,7 +757,7 @@ class AcmReRegisterIsacMtTestOldApi : public AudioCodingModuleTestOldApi {
codec_registration_thread_.SetPriority(rtc::kRealtimePriority);
}
void TearDown() {
void TearDown() override {
AudioCodingModuleTestOldApi::TearDown();
receive_thread_.Stop();
codec_registration_thread_.Stop();
@ -1737,7 +1737,7 @@ class AcmSwitchingOutputFrequencyOldApi : public ::testing::Test,
}
// Inherited from test::AudioSink.
bool WriteArray(const int16_t* audio, size_t num_samples) {
bool WriteArray(const int16_t* audio, size_t num_samples) override {
// Skip checking the first output frame, since it has a number of zeros
// due to how NetEq is initialized.
if (first_output_) {

8
webrtc/modules/audio_coding/codecs/isac/fix/test/isac_speed_test.cc
View File

@ -25,10 +25,10 @@ class IsacSpeedTest : public AudioCodecSpeedTest {
IsacSpeedTest();
void SetUp() override;
void TearDown() override;
virtual float EncodeABlock(int16_t* in_data, uint8_t* bit_stream,
size_t max_bytes, size_t* encoded_bytes);
virtual float DecodeABlock(const uint8_t* bit_stream, size_t encoded_bytes,
int16_t* out_data);
float EncodeABlock(int16_t* in_data, uint8_t* bit_stream,
size_t max_bytes, size_t* encoded_bytes) override;
float DecodeABlock(const uint8_t* bit_stream, size_t encoded_bytes,
int16_t* out_data) override;
ISACFIX_MainStruct *ISACFIX_main_inst_;
};

6
webrtc/modules/audio_coding/codecs/mock/mock_audio_encoder.h
View File

@ -22,7 +22,11 @@ namespace webrtc {
class MockAudioEncoder : public AudioEncoder {
public:
~MockAudioEncoder() override { Die(); }
// TODO(nisse): Valid overrides commented out, because the gmock
// methods don't use any override declarations, and we want to avoid
// warnings from -Winconsistent-missing-override. See
// http://crbug.com/428099.
~MockAudioEncoder() /* override */ { Die(); }
MOCK_METHOD0(Die, void());
MOCK_METHOD1(Mark, void(std::string desc));
MOCK_CONST_METHOD0(SampleRateHz, int());

8
webrtc/modules/audio_coding/codecs/opus/opus_speed_test.cc
View File

@ -23,10 +23,10 @@ class OpusSpeedTest : public AudioCodecSpeedTest {
OpusSpeedTest();
void SetUp() override;
void TearDown() override;
virtual float EncodeABlock(int16_t* in_data, uint8_t* bit_stream,
size_t max_bytes, size_t* encoded_bytes);
virtual float DecodeABlock(const uint8_t* bit_stream, size_t encoded_bytes,
int16_t* out_data);
float EncodeABlock(int16_t* in_data, uint8_t* bit_stream,
size_t max_bytes, size_t* encoded_bytes) override;
float DecodeABlock(const uint8_t* bit_stream, size_t encoded_bytes,
int16_t* out_data) override;
WebRtcOpusEncInst* opus_encoder_;
WebRtcOpusDecInst* opus_decoder_;
};

8
webrtc/modules/audio_coding/neteq/neteq_impl_unittest.cc
View File

@ -783,11 +783,15 @@ TEST_F(NetEqImplTest, UnsupportedDecoder) {
class MockAudioDecoder : public AudioDecoder {
public:
void Reset() override {}
// TODO(nisse): Valid overrides commented out, because the gmock
// methods don't use any override declarations, and we want to avoid
// warnings from -Winconsistent-missing-override. See
// http://crbug.com/428099.
void Reset() /* override */ {}
MOCK_CONST_METHOD2(PacketDuration, int(const uint8_t*, size_t));
MOCK_METHOD5(DecodeInternal, int(const uint8_t*, size_t, int, int16_t*,
SpeechType*));
size_t Channels() const override { return kChannels; }
size_t Channels() const /* override */ { return kChannels; }
} decoder_;
const uint8_t kFirstPayloadValue = 1;

23
webrtc/modules/audio_coding/neteq/neteq_network_stats_unittest.cc
View File

@ -24,31 +24,36 @@ using ::testing::Return;
class MockAudioDecoder final : public AudioDecoder {
public:
// TODO(nisse): Valid overrides commented out, because the gmock
// methods don't use any override declarations, and we want to avoid
// warnings from -Winconsistent-missing-override. See
// http://crbug.com/428099.
static const int kPacketDuration = 960; // 48 kHz * 20 ms
explicit MockAudioDecoder(size_t num_channels)
: num_channels_(num_channels), fec_enabled_(false) {
}
~MockAudioDecoder() override { Die(); }
~MockAudioDecoder() /* override */ { Die(); }
MOCK_METHOD0(Die, void());
MOCK_METHOD0(Reset, void());
int PacketDuration(const uint8_t* encoded,
size_t encoded_len) const override {
size_t encoded_len) const /* override */ {
return kPacketDuration;
}
int PacketDurationRedundant(const uint8_t* encoded,
size_t encoded_len) const override {
size_t encoded_len) const /* override */ {
return kPacketDuration;
}
bool PacketHasFec(const uint8_t* encoded, size_t encoded_len) const override {
bool PacketHasFec(
const uint8_t* encoded, size_t encoded_len) const /* override */ {
return fec_enabled_;
}
size_t Channels() const override { return num_channels_; }
size_t Channels() const /* override */ { return num_channels_; }
void set_fec_enabled(bool enable_fec) { fec_enabled_ = enable_fec; }
@ -60,7 +65,7 @@ class MockAudioDecoder final : public AudioDecoder {
size_t encoded_len,
int /*sample_rate_hz*/,
int16_t* decoded,
SpeechType* speech_type) override {
SpeechType* speech_type) /* override */ {
*speech_type = kSpeech;
memset(decoded, 0, sizeof(int16_t) * kPacketDuration * Channels());
return kPacketDuration * Channels();
@ -70,7 +75,7 @@ class MockAudioDecoder final : public AudioDecoder {
size_t encoded_len,
int sample_rate_hz,
int16_t* decoded,
SpeechType* speech_type) override {
SpeechType* speech_type) /* override */ {
return DecodeInternal(encoded, encoded_len, sample_rate_hz, decoded,
speech_type);
}
@ -294,7 +299,3 @@ TEST(NetEqNetworkStatsTest, NoiseExpansionTest) {
} // namespace test
} // namespace webrtc

4
webrtc/modules/audio_coding/neteq/test/neteq_isac_quality_test.cc
View File

@ -43,8 +43,8 @@ class NetEqIsacQualityTest : public NetEqQualityTest {
NetEqIsacQualityTest();
void SetUp() override;
void TearDown() override;
virtual int EncodeBlock(int16_t* in_data, size_t block_size_samples,
rtc::Buffer* payload, size_t max_bytes);
int EncodeBlock(int16_t* in_data, size_t block_size_samples,
rtc::Buffer* payload, size_t max_bytes) override;
private:
ISACFIX_MainStruct* isac_encoder_;
int bit_rate_kbps_;

4
webrtc/modules/audio_coding/neteq/test/neteq_opus_quality_test.cc
View File

@ -103,8 +103,8 @@ class NetEqOpusQualityTest : public NetEqQualityTest {
NetEqOpusQualityTest();
void SetUp() override;
void TearDown() override;
virtual int EncodeBlock(int16_t* in_data, size_t block_size_samples,
rtc::Buffer* payload, size_t max_bytes);
int EncodeBlock(int16_t* in_data, size_t block_size_samples,
rtc::Buffer* payload, size_t max_bytes) override;
private:
WebRtcOpusEncInst* opus_encoder_;
OpusRepacketizer* repacketizer_;

2
webrtc/modules/congestion_controller/congestion_controller.cc
View File

@ -81,7 +81,7 @@ class WrappingBitrateEstimator : public RemoteBitrateEstimator {
return rbe_->LatestEstimate(ssrcs, bitrate_bps);
}
void SetMinBitrate(int min_bitrate_bps) {
void SetMinBitrate(int min_bitrate_bps) override {
CriticalSectionScoped cs(crit_sect_.get());
rbe_->SetMinBitrate(min_bitrate_bps);
min_bitrate_bps_ = min_bitrate_bps;

4
webrtc/modules/rtp_rtcp/source/receive_statistics_unittest.cc
View File

@ -157,8 +157,8 @@ TEST_F(ReceiveStatisticsTest, RtcpCallbacks) {
: RtcpStatisticsCallback(), num_calls_(0), ssrc_(0), stats_() {}
virtual ~TestCallback() {}
virtual void StatisticsUpdated(const RtcpStatistics& statistics,
uint32_t ssrc) {
void StatisticsUpdated(const RtcpStatistics& statistics,
uint32_t ssrc) override {
ssrc_ = ssrc;
stats_ = statistics;
++num_calls_;

2
webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.h
View File

@ -50,7 +50,7 @@ class ReceiverReport : public RtcpPacket {
static const size_t kRrBaseLength = 4;
static const size_t kMaxNumberOfReportBlocks = 0x1F;
size_t BlockLength() const {
size_t BlockLength() const override {
return kHeaderLength + kRrBaseLength +
report_blocks_.size() * ReportBlock::kLength;
}

6
webrtc/modules/rtp_rtcp/source/rtp_payload_registry.cc
View File

@ -406,7 +406,8 @@ class RTPPayloadAudioStrategy : public RTPPayloadStrategy {
return payload;
}
int GetPayloadTypeFrequency(const RtpUtility::Payload& payload) const {
int GetPayloadTypeFrequency(
const RtpUtility::Payload& payload) const override {
return payload.typeSpecific.Audio.frequency;
}
};
@ -456,7 +457,8 @@ class RTPPayloadVideoStrategy : public RTPPayloadStrategy {
return payload;
}
int GetPayloadTypeFrequency(const RtpUtility::Payload& payload) const {
int GetPayloadTypeFrequency(
const RtpUtility::Payload& payload) const override {
return kVideoPayloadTypeFrequency;
}
};

8
webrtc/modules/rtp_rtcp/source/rtp_receiver_audio.h
View File

@ -31,15 +31,15 @@ class RTPReceiverAudio : public RTPReceiverStrategy,
// The following three methods implement the TelephoneEventHandler interface.
// Forward DTMFs to decoder for playout.
void SetTelephoneEventForwardToDecoder(bool forward_to_decoder);
void SetTelephoneEventForwardToDecoder(bool forward_to_decoder) override;
// Is forwarding of outband telephone events turned on/off?
bool TelephoneEventForwardToDecoder() const;
bool TelephoneEventForwardToDecoder() const override;
// Is TelephoneEvent configured with payload type payload_type
bool TelephoneEventPayloadType(const int8_t payload_type) const;
bool TelephoneEventPayloadType(const int8_t payload_type) const override;
TelephoneEventHandler* GetTelephoneEventHandler() { return this; }
TelephoneEventHandler* GetTelephoneEventHandler() override { return this; }
// Returns true if CNG is configured with payload type payload_type. If so,
// the frequency and cng_payload_type_has_changed are filled in.

2
webrtc/modules/rtp_rtcp/source/rtp_receiver_video.h
View File

@ -34,7 +34,7 @@ class RTPReceiverVideo : public RTPReceiverStrategy {
int64_t timestamp,
bool is_first_packet) override;
TelephoneEventHandler* GetTelephoneEventHandler() { return NULL; }
TelephoneEventHandler* GetTelephoneEventHandler() override { return NULL; }
int GetPayloadTypeFrequency() const override;

6
webrtc/modules/utility/include/mock/mock_process_thread.h
View File

@ -21,6 +21,10 @@ namespace webrtc {
class MockProcessThread : public ProcessThread {
public:
// TODO(nisse): Valid overrides commented out, because the gmock
// methods don't use any override declarations, and we want to avoid
// warnings from -Winconsistent-missing-override. See
// http://crbug.com/428099.
MOCK_METHOD0(Start, void());
MOCK_METHOD0(Stop, void());
MOCK_METHOD1(WakeUp, void(Module* module));
@ -31,7 +35,7 @@ class MockProcessThread : public ProcessThread {
// MOCK_METHOD1 gets confused with mocking this method, so we work around it
// by overriding the method from the interface and forwarding the call to a
// mocked, simpler method.
void PostTask(std::unique_ptr<ProcessTask> task) override {
void PostTask(std::unique_ptr<ProcessTask> task) /* override */ {
PostTask(task.get());
}
};

22
webrtc/modules/utility/source/file_recorder_impl.h
View File

@ -45,23 +45,23 @@ public:
virtual ~FileRecorderImpl();
// FileRecorder functions.
virtual int32_t RegisterModuleFileCallback(FileCallback* callback);
virtual FileFormats RecordingFileFormat() const;
virtual int32_t StartRecordingAudioFile(
int32_t RegisterModuleFileCallback(FileCallback* callback) override;
FileFormats RecordingFileFormat() const override;
int32_t StartRecordingAudioFile(
const char* fileName,
const CodecInst& codecInst,
uint32_t notificationTimeMs) override;
virtual int32_t StartRecordingAudioFile(
int32_t StartRecordingAudioFile(
OutStream& destStream,
const CodecInst& codecInst,
uint32_t notificationTimeMs) override;
virtual int32_t StopRecording();
virtual bool IsRecording() const;
virtual int32_t codec_info(CodecInst& codecInst) const;
virtual int32_t RecordAudioToFile(
int32_t StopRecording() override;
bool IsRecording() const override;
int32_t codec_info(CodecInst& codecInst) const override;
int32_t RecordAudioToFile(
const AudioFrame& frame,
const TickTime* playoutTS = NULL);
virtual int32_t StartRecordingVideoFile(
const TickTime* playoutTS = NULL) override;
int32_t StartRecordingVideoFile(
const char* fileName,
const CodecInst& audioCodecInst,
const VideoCodec& videoCodecInst,
@ -69,7 +69,7 @@ public:
{
return -1;
}
virtual int32_t RecordVideoToFile(const VideoFrame& videoFrame) {
int32_t RecordVideoToFile(const VideoFrame& videoFrame) override {
return -1;
}

18
webrtc/modules/video_coding/codecs/vp8/realtime_temporal_layers.cc
View File

@ -101,10 +101,10 @@ class RealTimeTemporalLayers : public TemporalLayers {
virtual ~RealTimeTemporalLayers() {}
virtual bool ConfigureBitrates(int bitrate_kbit,
int max_bitrate_kbit,
int framerate,
vpx_codec_enc_cfg_t* cfg) {
bool ConfigureBitrates(int bitrate_kbit,
int max_bitrate_kbit,
int framerate,
vpx_codec_enc_cfg_t* cfg) override {
temporal_layers_ =
CalculateNumberOfTemporalLayers(temporal_layers_, framerate);
temporal_layers_ = std::min(temporal_layers_, max_temporal_layers_);
@ -184,7 +184,7 @@ class RealTimeTemporalLayers : public TemporalLayers {
return true;
}
virtual int EncodeFlags(uint32_t timestamp) {
int EncodeFlags(uint32_t timestamp) override {
frame_counter_++;
return CurrentEncodeFlags();
}
@ -196,16 +196,16 @@ class RealTimeTemporalLayers : public TemporalLayers {
return encode_flags_[index];
}
virtual int CurrentLayerId() const {
int CurrentLayerId() const override {
assert(layer_ids_length_ > 0 && layer_ids_ != NULL);
int index = frame_counter_ % layer_ids_length_;
assert(index >= 0 && index < layer_ids_length_);
return layer_ids_[index];
}
virtual void PopulateCodecSpecific(bool base_layer_sync,
CodecSpecificInfoVP8* vp8_info,
uint32_t timestamp) {
void PopulateCodecSpecific(bool base_layer_sync,
CodecSpecificInfoVP8* vp8_info,
uint32_t timestamp) override {
assert(temporal_layers_ > 0);
if (temporal_layers_ == 1) {

18
webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc
View File

@ -107,34 +107,40 @@ TEST_F(TestSimulcastEncoderAdapter, DISABLED_TestRPSIEncoder) {
class MockVideoEncoder : public VideoEncoder {
public:
// TODO(nisse): Valid overrides commented out, because the gmock
// methods don't use any override declarations, and we want to avoid
// warnings from -Winconsistent-missing-override. See
// http://crbug.com/428099.
int32_t InitEncode(const VideoCodec* codecSettings,
int32_t numberOfCores,
size_t maxPayloadSize) override {
size_t maxPayloadSize) /* override */ {
codec_ = *codecSettings;
return 0;
}
int32_t Encode(const VideoFrame& inputImage,
const CodecSpecificInfo* codecSpecificInfo,
const std::vector<FrameType>* frame_types) override {
const std::vector<FrameType>* frame_types) /* override */ {
return 0;
}
int32_t RegisterEncodeCompleteCallback(
EncodedImageCallback* callback) override {
EncodedImageCallback* callback) /* override */ {
callback_ = callback;
return 0;
}
int32_t Release() override { return 0; }
int32_t Release() /* override */ { return 0; }
int32_t SetRates(uint32_t newBitRate, uint32_t frameRate) override {
int32_t SetRates(uint32_t newBitRate, uint32_t frameRate) /* override */ {
return 0;
}
MOCK_METHOD2(SetChannelParameters, int32_t(uint32_t packetLoss, int64_t rtt));
bool SupportsNativeHandle() const override { return supports_native_handle_; }
bool SupportsNativeHandle() const /* override */ {
return supports_native_handle_;
}
virtual ~MockVideoEncoder() {}

2
webrtc/modules/video_coding/codecs/vp8/simulcast_unittest.h
View File

@ -168,7 +168,7 @@ class SkipEncodingUnusedStreamsTest {
virtual ~SpyingTemporalLayers() { delete layers_; }
virtual int EncodeFlags(uint32_t timestamp) {
int EncodeFlags(uint32_t timestamp) override {
return layers_->EncodeFlags(timestamp);
}

20
webrtc/modules/video_coding/codecs/vp8/vp8_impl.h
View File

@ -40,21 +40,21 @@ class VP8EncoderImpl : public VP8Encoder {
virtual ~VP8EncoderImpl();
virtual int Release();
int Release() override;
virtual int InitEncode(const VideoCodec* codec_settings,
int number_of_cores,
size_t max_payload_size);
int InitEncode(const VideoCodec* codec_settings,
int number_of_cores,
size_t max_payload_size) override;
virtual int Encode(const VideoFrame& input_image,
const CodecSpecificInfo* codec_specific_info,
const std::vector<FrameType>* frame_types);
int Encode(const VideoFrame& input_image,
const CodecSpecificInfo* codec_specific_info,
const std::vector<FrameType>* frame_types) override;
virtual int RegisterEncodeCompleteCallback(EncodedImageCallback* callback);
int RegisterEncodeCompleteCallback(EncodedImageCallback* callback) override;
virtual int SetChannelParameters(uint32_t packet_loss, int64_t rtt);
int SetChannelParameters(uint32_t packet_loss, int64_t rtt) override;
virtual int SetRates(uint32_t new_bitrate_kbit, uint32_t frame_rate);
int SetRates(uint32_t new_bitrate_kbit, uint32_t frame_rate) override;
void OnDroppedFrame() override {}

2
webrtc/modules/video_coding/jitter_buffer_unittest.cc
View File

@ -215,7 +215,7 @@ class TestBasicJitterBuffer : public ::testing::TestWithParam<std::string>,
protected:
TestBasicJitterBuffer() : scoped_field_trial_(GetParam()) {}
virtual void SetUp() {
void SetUp() override {
clock_.reset(new SimulatedClock(0));
jitter_buffer_.reset(new VCMJitterBuffer(
clock_.get(),

4
webrtc/p2p/base/faketransportcontroller.h
View File

@ -231,7 +231,7 @@ class FakeTransportChannel : public TransportChannelImpl,
}
bool SetLocalCertificate(
const rtc::scoped_refptr<rtc::RTCCertificate>& certificate) {
const rtc::scoped_refptr<rtc::RTCCertificate>& certificate) override {
local_cert_ = certificate;
return true;
}
@ -257,7 +257,7 @@ class FakeTransportChannel : public TransportChannelImpl,
bool GetSslCipherSuite(int* cipher_suite) override { return false; }
rtc::scoped_refptr<rtc::RTCCertificate> GetLocalCertificate() const {
rtc::scoped_refptr<rtc::RTCCertificate> GetLocalCertificate() const override {
return local_cert_;
}

2
webrtc/p2p/base/port_unittest.cc
View File

@ -965,7 +965,7 @@ class FakePacketSocketFactory : public rtc::PacketSocketFactory {
void set_next_client_tcp_socket(AsyncPacketSocket* next_client_tcp_socket) {
next_client_tcp_socket_ = next_client_tcp_socket;
}
rtc::AsyncResolverInterface* CreateAsyncResolver() {
rtc::AsyncResolverInterface* CreateAsyncResolver() override {
return NULL;
}

9
webrtc/test/mock_voice_engine.h
View File

@ -24,6 +24,10 @@ namespace test {
// able to get the various interfaces as usual, via T::GetInterface().
class MockVoiceEngine : public VoiceEngineImpl {
public:
// TODO(nisse): Valid overrides commented out, because the gmock
// methods don't use any override declarations, and we want to avoid
// warnings from -Winconsistent-missing-override. See
// http://crbug.com/428099.
MockVoiceEngine() : VoiceEngineImpl(new Config(), true) {
// Increase ref count so this object isn't automatically deleted whenever
// interfaces are Release():d.
@ -36,7 +40,7 @@ class MockVoiceEngine : public VoiceEngineImpl {
return new testing::NiceMock<MockVoEChannelProxy>();
}));
}
~MockVoiceEngine() override {
~MockVoiceEngine() /* override */ {
// Decrease ref count before base class d-tor is called; otherwise it will
// trigger an assertion.
--_ref_count;
@ -45,7 +49,8 @@ class MockVoiceEngine : public VoiceEngineImpl {
MOCK_METHOD1(ChannelProxyFactory, voe::ChannelProxy*(int channel_id));
// VoiceEngineImpl
std::unique_ptr<voe::ChannelProxy> GetChannelProxy(int channel_id) override {
std::unique_ptr<voe::ChannelProxy> GetChannelProxy(
int channel_id) /* override */ {
return std::unique_ptr<voe::ChannelProxy>(ChannelProxyFactory(channel_id));
}

2
webrtc/test/rtp_file_reader.cc
View File

@ -131,7 +131,7 @@ class RtpDumpReader : public RtpFileReaderImpl {
}
bool Init(const std::string& filename,
const std::set<uint32_t>& ssrc_filter) {
const std::set<uint32_t>& ssrc_filter) override {
file_ = fopen(filename.c_str(), "rb");
if (file_ == NULL) {
printf("ERROR: Can't open file: %s\n", filename.c_str());

4
webrtc/video/end_to_end_tests.cc
View File

@ -1765,7 +1765,7 @@ TEST_F(EndToEndTest, RembWithSendSideBwe) {
~BweObserver() {}
test::PacketTransport* CreateReceiveTransport() {
test::PacketTransport* CreateReceiveTransport() override {
receive_transport_ = new test::PacketTransport(
nullptr, this, test::PacketTransport::kReceiver,
FakeNetworkPipe::Config());
@ -2248,7 +2248,7 @@ void EndToEndTest::TestXrReceiverReferenceTimeReport(bool enable_rrtr) {
return SEND_PACKET;
}
// Send stream should send SR packets (and DLRR packets if enabled).
virtual Action OnSendRtcp(const uint8_t* packet, size_t length) {
Action OnSendRtcp(const uint8_t* packet, size_t length) override {
rtc::CritScope lock(&crit_);
RTCPUtility::RTCPParserV2 parser(packet, length, true);
EXPECT_TRUE(parser.IsValid());

2
webrtc/video/overuse_frame_detector_unittest.cc
View File

@ -53,7 +53,7 @@ class CpuOveruseObserverImpl : public CpuOveruseObserver {
class OveruseFrameDetectorTest : public ::testing::Test,
public CpuOveruseMetricsObserver {
protected:
virtual void SetUp() {
void SetUp() override {
clock_.reset(new SimulatedClock(1234));
observer_.reset(new MockCpuOveruseObserver());
options_.min_process_count = 0;

8
webrtc/video/video_send_stream_tests.cc
View File

@ -708,7 +708,7 @@ void VideoSendStreamTest::TestPacketFragmentationSize(VideoFormat format,
}
}
virtual void EncodedFrameCallback(const EncodedFrame& encoded_frame) {
void EncodedFrameCallback(const EncodedFrame& encoded_frame) override {
// Increase frame size for next encoded frame, in the context of the
// encoder thread.
if (!use_fec_ &&
@ -999,8 +999,8 @@ TEST_F(VideoSendStreamTest, NoPaddingWhenVideoIsMuted) {
size_t GetNumVideoStreams() const override { return 3; }
virtual void OnFrameGeneratorCapturerCreated(
test::FrameGeneratorCapturer* frame_generator_capturer) {
void OnFrameGeneratorCapturerCreated(
test::FrameGeneratorCapturer* frame_generator_capturer) override {
rtc::CritScope lock(&crit_);
capturer_ = frame_generator_capturer;
}
@ -1040,7 +1040,7 @@ TEST_F(VideoSendStreamTest, MinTransmitBitrateRespectsRemb) {
}
private:
virtual Action OnSendRtp(const uint8_t* packet, size_t length) {
Action OnSendRtp(const uint8_t* packet, size_t length) override {
if (RtpHeaderParser::IsRtcp(packet, length))
return DROP_PACKET;

25
webrtc/video/vie_channel.h
View File

@ -81,11 +81,10 @@ class ViEChannel : public VCMFrameTypeCallback,
CallStatsObserver* GetStatsObserver();
// Implements VCMReceiveCallback.
virtual int32_t FrameToRender(VideoFrame& video_frame); // NOLINT
int32_t FrameToRender(VideoFrame& video_frame) override; // NOLINT
// Implements VCMReceiveCallback.
virtual int32_t ReceivedDecodedReferenceFrame(
const uint64_t picture_id);
int32_t ReceivedDecodedReferenceFrame(const uint64_t picture_id) override;
// Implements VCMReceiveCallback.
void OnIncomingPayloadType(int payload_type) override;
@ -97,20 +96,20 @@ class ViEChannel : public VCMFrameTypeCallback,
void OnFrameCountsUpdated(const FrameCounts& frame_counts) override;
// Implements VCMDecoderTimingCallback.
virtual void OnDecoderTiming(int decode_ms,
int max_decode_ms,
int current_delay_ms,
int target_delay_ms,
int jitter_buffer_ms,
int min_playout_delay_ms,
int render_delay_ms);
void OnDecoderTiming(int decode_ms,
int max_decode_ms,
int current_delay_ms,
int target_delay_ms,
int jitter_buffer_ms,
int min_playout_delay_ms,
int render_delay_ms) override;
// Implements FrameTypeCallback.
virtual int32_t RequestKeyFrame();
int32_t RequestKeyFrame() override;
// Implements FrameTypeCallback.
virtual int32_t SliceLossIndicationRequest(
const uint64_t picture_id);
int32_t SliceLossIndicationRequest(
const uint64_t picture_id) override;
// Implements VideoPacketRequestCallback.
int32_t ResendPackets(const uint16_t* sequence_numbers,