admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix some clang-tidy issues in call/

Browse Source 
Bug: None
Change-Id: I4bc6425e33324e48cadb27a5d1bb6261221a07a3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/373905
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43694}
This commit is contained in:
Björn Terelius 2025-01-08 17:53:06 +01:00 committed by WebRTC LUCI CQ
parent ae6eec4a30
commit f8c03702c6
6 changed files with 9 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
call/flexfec_receive_stream_unittest.cc
View File

@ -33,7 +33,6 @@ namespace webrtc {
namespace { namespace {
using ::testing::_;
using ::testing::Eq; using ::testing::Eq;
using ::testing::Property; using ::testing::Property;

6
call/payload_type_picker.cc
View File

@ -179,7 +179,7 @@ PayloadTypePicker::PayloadTypePicker() {
{{cricket::kDtmfCodecName, 32000, 1}, 112}, {{cricket::kDtmfCodecName, 32000, 1}, 112},
{{cricket::kDtmfCodecName, 16000, 1}, 113}, {{cricket::kDtmfCodecName, 16000, 1}, 113},
{{cricket::kDtmfCodecName, 8000, 1}, 126}}; {{cricket::kDtmfCodecName, 8000, 1}, 126}};
for (auto entry : default_audio_mappings) { for (const MapTableEntry& entry : default_audio_mappings) {
AddMapping(PayloadType(entry.payload_type), AddMapping(PayloadType(entry.payload_type),
cricket::CreateAudioCodec(entry.format)); cricket::CreateAudioCodec(entry.format));
} }
@ -198,7 +198,7 @@ RTCErrorOr<PayloadType> PayloadTypePicker::SuggestMapping(
} }
// The first matching entry is returned, unless excluder // The first matching entry is returned, unless excluder
// maps it to something different. // maps it to something different.
for (auto entry : entries_) { for (const MapEntry& entry : entries_) {
if (MatchesWithReferenceAttributes(entry.codec(), codec)) { if (MatchesWithReferenceAttributes(entry.codec(), codec)) {
if (excluder) { if (excluder) {
auto result = excluder->LookupCodec(entry.payload_type()); auto result = excluder->LookupCodec(entry.payload_type());
@ -223,7 +223,7 @@ RTCError PayloadTypePicker::AddMapping(PayloadType payload_type,
cricket::Codec codec) { cricket::Codec codec) {
// Completely duplicate mappings are ignored. // Completely duplicate mappings are ignored.
// Multiple mappings for the same codec and the same PT are legal; // Multiple mappings for the same codec and the same PT are legal;
for (auto entry : entries_) { for (const MapEntry& entry : entries_) {
if (payload_type == entry.payload_type() && if (payload_type == entry.payload_type() &&
MatchesWithReferenceAttributes(codec, entry.codec())) { MatchesWithReferenceAttributes(codec, entry.codec())) {
return RTCError::OK(); return RTCError::OK();

6
call/rtp_payload_params.cc
View File

@ -381,16 +381,16 @@ std::optional<FrameDependencyStructure> RtpPayloadParams::GenericStructure(
case VideoCodecType::kVideoCodecGeneric: case VideoCodecType::kVideoCodecGeneric:
if (simulate_generic_structure_) { if (simulate_generic_structure_) {
return MinimalisticStructure(/*num_spatial_layers=*/1, return MinimalisticStructure(/*num_spatial_layers=*/1,
/*num_temporal_layer=*/1); /*num_temporal_layers=*/1);
} }
return std::nullopt; return std::nullopt;
case VideoCodecType::kVideoCodecVP8: case VideoCodecType::kVideoCodecVP8:
return MinimalisticStructure(/*num_spatial_layers=*/1, return MinimalisticStructure(/*num_spatial_layers=*/1,
/*num_temporal_layer=*/kMaxTemporalStreams); /*num_temporal_layers=*/kMaxTemporalStreams);
case VideoCodecType::kVideoCodecVP9: { case VideoCodecType::kVideoCodecVP9: {
std::optional<FrameDependencyStructure> structure = MinimalisticStructure( std::optional<FrameDependencyStructure> structure = MinimalisticStructure(
/*num_spatial_layers=*/kMaxSimulatedSpatialLayers, /*num_spatial_layers=*/kMaxSimulatedSpatialLayers,
/*num_temporal_layer=*/kMaxTemporalStreams); /*num_temporal_layers=*/kMaxTemporalStreams);
const CodecSpecificInfoVP9& vp9 = codec_specific_info->codecSpecific.VP9; const CodecSpecificInfoVP9& vp9 = codec_specific_info->codecSpecific.VP9;
if (vp9.ss_data_available && vp9.spatial_layer_resolution_present) { if (vp9.ss_data_available && vp9.spatial_layer_resolution_present) {
RenderResolution first_valid; RenderResolution first_valid;

1
call/rtp_payload_params_unittest.cc
View File

@ -14,6 +14,7 @@
#include <map> #include <map>
#include <optional> #include <optional>
#include <set> #include <set>
#include <vector>
#include "absl/container/inlined_vector.h" #include "absl/container/inlined_vector.h"
#include "absl/types/variant.h" #include "absl/types/variant.h"

4
call/rtp_video_sender_unittest.cc
View File

@ -1343,7 +1343,7 @@ TEST(RtpVideoSenderTest, ClearsPendingPacketsOnInactivation) {
// Set a very low bitrate. // Set a very low bitrate.
test.router()->OnBitrateUpdated( test.router()->OnBitrateUpdated(
CreateBitrateAllocationUpdate(/*rate_bps=*/10'000), CreateBitrateAllocationUpdate(/*target_bitrate_bps=*/10'000),
/*framerate=*/30); /*framerate=*/30);
// Create and send a large keyframe. // Create and send a large keyframe.
@ -1421,7 +1421,7 @@ TEST(RtpVideoSenderTest,
// Set a very low bitrate. // Set a very low bitrate.
test.router()->OnBitrateUpdated( test.router()->OnBitrateUpdated(
CreateBitrateAllocationUpdate(/*rate_bps=*/10'000), CreateBitrateAllocationUpdate(/*target_bitrate_bps=*/10'000),
/*framerate=*/30); /*framerate=*/30);
// Create and send a large keyframe. // Create and send a large keyframe.

1
call/rtx_receive_stream_unittest.cc
View File

@ -30,7 +30,6 @@ namespace webrtc {
namespace { namespace {
using ::testing::_;
using ::testing::Property; using ::testing::Property;
using ::testing::StrictMock; using ::testing::StrictMock;