Add a fallback path to tools/valgrind-webrtc/webrtc_tests.sh if locate_valgrind.sh fails.
This is a workaround to run memcheck on swarming, since locate_valgrind.sh fails even though the files are present. This is almost certainly because the way we use symlinks.
A warning message is displayed to warn the developers to follow the instructions to get the valgrind binaries.
Some extra suppressions were needed. The bug tracking them is https://bugs.webrtc.org/6773R=kjellander@chromium.org
BUG=chromium:497757
Review-Url: https://codereview.webrtc.org/2531573003
Cr-Commit-Position: refs/heads/master@{#15244}
When set to true, this adds the files necessary to run memcheck as data dependencies, listed in the .gni files.
This will enable us to run memcheck on swarming.
R=kjellander@chromium.org
BUG=chromium:497757
NOTRY=True
Review-Url: https://codereview.webrtc.org/2510033004
Cr-Commit-Position: refs/heads/master@{#15219}
This removes the need of executing Chromium's runhooks.
A selection of hooks (not all) were picked that should be
sufficient for WebRTC's needs.
New dependencies:
* third_party/espresso
* third_party/javax_inject
* tools/clang_format_merge_driver
BUG=webrtc:5578, webrtc:5006, webrtc:6741
TESTED=
rm -rf third_party/android_tools/sdk/extras/google/m2repository/
gclient runhooks
Verified that third_party/android_tools/sdk/extras/google/m2repository/ is downloaded without any license prompt.
NOTRY=True
Review-Url: https://codereview.webrtc.org/2524673002
Cr-Commit-Position: refs/heads/master@{#15195}
Both of these are unused legacy stuff.
BUG=webrtc:6323
NOTRY=True
Review-Url: https://codereview.webrtc.org/2520253002
Cr-Commit-Position: refs/heads/master@{#15183}
This change adds code that lets Opus increase the complexity setting
at low bitrates (only relevant for mobile where the default complexity
is not already maximum). The feature is default off.
Also adding a performance test to make sure the complexity adaptation
has desired effect.
BUG=webrtc:6708
Review-Url: https://codereview.webrtc.org/2503443002
Cr-Commit-Position: refs/heads/master@{#15182}
After https://chromium-review.googlesource.com/c/412190/
we can remove all the GYP variables. The GN args are also not used
during runhooks (only GYP_DEFINES had any effect), so they're also
removed to avoid confusion. Only use_goma=True was left since
the ios recipe module uses it to decide if Goma shall be started
on the bots.
Delete unused GN/GYP-specific JSON files for bots that are now removed.
Finally, bump iOS version 10.0 and change simulator phones to
iPhone 6s to match what Chromium uses (may help solving bugs.webrtc.org/4752)
BUG=webrtc:4752, webrtc:6323
NOTRY=True
Review-Url: https://codereview.webrtc.org/2507063008
Cr-Commit-Position: refs/heads/master@{#15160}
Add new perf desktop bots.
Remove dcheck_always_on=true for all perf bots.
Cleanup some more GYP traces.
Remove gn_ prefix for all mixins for readability.
BUG=chromium:665874
NOTRY=True
Review-Url: https://codereview.webrtc.org/2505183003
Cr-Commit-Position: refs/heads/master@{#15138}
Moving one of the targets that shouldn't pollute the already large
webrtc/BUILD.gn file.
BUG=webrtc:6440
NOTRY=True
Review-Url: https://codereview.webrtc.org/2440963002
Cr-Commit-Position: refs/heads/master@{#14970}
This will enable more warnings for Android ARM64 build.
The main purpose is to clean up clutter in the warnings config.
BUG=webrtc:6653
NOTRY=True
Review-Url: https://codereview.webrtc.org/2479533002
Cr-Commit-Position: refs/heads/master@{#14917}
Restoring a line from the older version (GYP-days) of the
build_ios_libs.sh script: modifying PATH so that the
PlistBuddy utility can be successfully found and called,
as it normally is not available under the PATH directories
in a typical OS X environment (even on developer configs).
NOTRY=True
BUG=webrtc:6372
Review-Url: https://codereview.webrtc.org/2463623002
Cr-Commit-Position: refs/heads/master@{#14834}
Now that Chromium has taken libsrtp2, remove any compatibility bridge code in WebRTC that was only needed for libsrtp1.
Remove SRTP_RELATIVE_PATH now that Google's internal copy of libsrtp and the Chromium copy have the same directory structure.
Fix some include orderings per the Chromium C++ style guide.
Remove the `extern "C"` blocks now that the libsrtp headers include them (https://github.com/cisco/libsrtp/pull/195).
BUG=webrtc:6376
Review-Url: https://codereview.webrtc.org/2447893002
Cr-Commit-Position: refs/heads/master@{#14776}
The Dr Memory toolchain is no longer supported by Chromium and
their bots have been removed. WebRTC will now rely on the LLVM
santizers for catching such errors.
BUG=webrtc:6553
NOTRY=True
R=ehmaldonado@webrtc.org
Review URL: https://codereview.webrtc.org/2434563003 .
Cr-Commit-Position: refs/heads/master@{#14703}
Most other targets were converted to static_library to match the
GYP build in https://codereview.webrtc.org/2361623004.
The monolithic 'webrtc' wasn't converted due to a limitation in
libtool on Mac: it will fail if there are no object files to link
(see http://crbug.com/625874).
Because of that, a no_op_function.cc source file was added to
the sources here, even if it's not used. This will be further
refactored in the future as part of the Slim and Modular
effort (bugs.webrtc.org/5716).
BUG=webrtc:6418, webrtc:6410
NOTRY=True
Review-Url: https://codereview.webrtc.org/2372983002
Cr-Commit-Position: refs/heads/master@{#14403}
This CL removes the use_objc_h264 flag. This means that the VideoToolbox
H264 encoder and decoder will always be built.
BUG=webrtc:4081
NOTRY=TRUE
Review-Url: https://codereview.webrtc.org/2366443003
Cr-Commit-Position: refs/heads/master@{#14372}
Remove a large number of targets that are no longer built, to reduce maintenance.
Only targets that have a GN version were removed.
BUG=webrtc:6323
NOTRY=True
NOPRESUBMIT=True
Review-Url: https://codereview.webrtc.org/2340773003
Cr-Commit-Position: refs/heads/master@{#14231}
A recent build error on Android revealed that we're always doing
static builds for the Android Debug builders. This changes one
to be building shared library instead (is_component_build=true),
which should prevent such breakages in the future.
BUG=webrtc:6360
NOTRY=True
Review-Url: https://codereview.webrtc.org/2342033002
Cr-Commit-Position: refs/heads/master@{#14226}
This patch enables bwe related variable logging to the command line.
This is useful to test congestion control algorithm over real networks.
NOTRY=true
Review-Url: https://codereview.webrtc.org/2296253002
Cr-Commit-Position: refs/heads/master@{#14209}
