In this CL:
- Don't insert a packet if we have explicitly cleared past it.
- Added some logging to ExpandBufferSize.
- Renamed IsContinuous to PotentialNewFrame.
- Unittests updated/added for this new behavior.
- Refactored TestPacketBuffer unittests.
BUG=webrtc:5514
R=danilchap@webrtc.org, stefan@webrtc.org
Review URL: https://codereview.webrtc.org/2399373002 .
Cr-Commit-Position: refs/heads/master@{#14871}
Reason for revert:
Eh, I forgot to run the libfuzzer trybot :( broke in the main waterfall.
Original issue's description:
> Only expose gflags target in non-Chromium and non-fuzzer builds.
>
> Since gflags is not present in Chromium nor the libfuzzer infrastructure,
> we have to ensure we don't accidentally depend on it in WebRTC code
> that is used in such places.
>
> BUG=chromium:645069
> NOTRY=True
>
> Committed: https://crrev.com/9365338db2e0505d6e5f8ea62fa8fe2c45ea8f74
> Cr-Commit-Position: refs/heads/master@{#14145}
TBR=ehmaldonado@webrtc.org,henrik.lundin@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:645069
Review-Url: https://codereview.webrtc.org/2320723007
Cr-Commit-Position: refs/heads/master@{#14149}
Since gflags is not present in Chromium nor the libfuzzer infrastructure,
we have to ensure we don't accidentally depend on it in WebRTC code
that is used in such places.
BUG=chromium:645069
NOTRY=True
Review-Url: https://codereview.webrtc.org/2321963002
Cr-Commit-Position: refs/heads/master@{#14145}
22c71034 Add flag for running only failed and new tests
2f5c75fd Fix support for TYPED_TEST_CASEs.
Review-Url: https://codereview.webrtc.org/2025293002
Cr-Commit-Position: refs/heads/master@{#12994}
This pulls in several fixes and gets Visual Studio 2015 support.
The new repo is located at https://github.com/gflags/gflags
which is mirrored in Chrome infrastructure at
https://chromium.googlesource.com/external/github.com/gflags/gflags
New configuration headers were generated according to README.webrtc
on Windows and Linux. I verified the Linux generated ones are working
on Mac. The generating headers on Mac are identical with only a minor
difference (an __unused attribute) that doesn't effect the build.
BUG=webrtc:5185
NOTRY=True
NOPRESUBMIT=True
TESTED=Successfully ran:
out/Release/video_quality_measurement --input_filename=resources/foreman_cif.yuv --width=352 --height=288
to verify flags are still being parsed properly.
I also ran the compile trybots and the baremetal bots
(since they run tests that have gflags flags).
Review URL: https://codereview.webrtc.org/1679263002
Cr-Commit-Position: refs/heads/master@{#11539}
Brings in fixes that save log output to disk instead of piping them
through Python. Should fix problem where output from tests stall for
more than 10 seconds.
Also enabling JsepPeerConnectionP2PTestClient on all platforms again.
BUG=webrtc:5231
R=kjellander@webrtc.org
Review URL: https://codereview.webrtc.org/1509463002 .
Cr-Commit-Position: refs/heads/master@{#10917}
Libvpx now supports GN and this CL turns on compiling it.
I also introduced an executable target 'webrtc_tests'
that depends on all in WeBRTC + tests in order to get a full
linking step executed (since we've seen link problems for GN
when rolling WebRTC into Chromium).
I also converted a few test targets and made a GN file for
third_party/gflags.
BUG=3441
TESTED=Trybots + full Chromium build with a symlinked src/third_party/webrtc
dir to a workspace wit this CL applied.
R=brettw@chromium.orgTBR=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/25569004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7344 4adac7df-926f-26a2-2b94-8c16560cd09d
This CL brought to you by:
$ for d in $(for f in $(git ls-files '*gyp' '*gypi'); do dirname $f; done|sort|uniq|grep -v '^\.$'); do echo -e "\n# These are for the common case of adding or renaming files. If you're doing\n# structural changes, please get a review from a reviewer in this file.\nper-file *.gyp=*\nper-file *.gypi=*" >> $d/OWNERS; done
$ for d in $(for f in $(git ls-files '*gyp' '*gypi'); do dirname $f; done|sort|uniq|grep -v '^\.$'); do git add $d/OWNERS; done
(and then removed the talk/ impact)
R=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/11969004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5903 4adac7df-926f-26a2-2b94-8c16560cd09d
This CL is the landing of http://review.webrtc.org/1277004/ for yujie.mao@intel.com.
I verified the added files are identical with the previously added ones
in third_party/google-gflags/gen/arch/linux/ia32 (which is the way this library needs to be handled when supporting the additional Android platforms).
BUG=none
TEST=Successfully compiled WebRTC on Linux Precise with:
source build/android/envsetup.sh --target-arch=x86
gclient runhooks
ninja -C out/Debug
Review URL: https://webrtc-codereview.appspot.com/1273005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3749 4adac7df-926f-26a2-2b94-8c16560cd09d
This resolves ninja error on Windows due to recent depot_tools update, since a newer GYP will be synced.
Initially we ran into a compile issue with libvpx: http://code.google.com/p/webm/issues/detail?id=521
The change in libvpx.gyp is needed since the newer version of Clang that
is used with this Chromium revision provides the -fsanitize=address flag
instead of the old (now deprecated) -faddress-sanitizer. Without
disabling them when asan=1, we'll get compile errors for the assembly
offsets generated for Libvpx. See http://crbug.com/159580 for more details.
BUG=libyuv:173
TEST=trybots passing.
Review URL: https://webrtc-codereview.appspot.com/1026004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3361 4adac7df-926f-26a2-2b94-8c16560cd09d
BUG=1120
TEST=trybot, local test on xoom and nexus
Message:
It turned out the last CL can only build neon code that
caused problem on Xoom.
Description:
In order to support audo-cpu-detection, I split files into two gypi files, one
contains non-neon code, antoher one ONLY contains neon specific code, so I can
apply different flags to them. Also created two build targets for each of them
We build for linux as before.
Tested on xoom and nexus S.
Review URL: https://webrtc-codereview.appspot.com/930024
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3141 4adac7df-926f-26a2-2b94-8c16560cd09d
Message:
I decided to separate libvpx configuraton files for linux/arm and
Android/arm. I will continue maintaining linux/arm configuration files.
The reasons to change:
It will be two sets of configuration files for android, one is arm, the
other one is arm-neon. For "arm" configuration, I will enable
"cpu-auto-detection" which means that binary can run on any armv7 devices.
For "arm-neon" configuration, it will be used for "neon" enabled devices
only. "arm" configuration will be the default configuration which is as
same as what we have for webrtc.
Description:
This CL separates libvpx configuration files for linux/arm and
Android/arm. Configuration files for Android arm are added, also
"cpu-auto-detection" is enabled.
BUG=None
TEST=local
Review URL: https://webrtc-codereview.appspot.com/934013
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3082 4adac7df-926f-26a2-2b94-8c16560cd09d
