admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
14,320 Commits 1 Branch 0 Tags
Commit Graph

576 Commits

Author SHA1 Message Date
kjellander
a013a02e01 MB: Copy MB from Chromium repo 
Essentially a copy of https://codereview.chromium.org/2299953002/
plus changes to WebRTC's license, changed OWNERS and additional
MB updates up to Chromium revision http://crrev.com/f1e2718a3ff.

The PRESUBMIT.py check was updated to use the existing
webrtc/build/mb_config.pyl to avoid breaking bots (that have
this path hardcoded).

This replaces the previously symlinked MB, which already
runs validation of the WebRTC configs as part of
webrtc/build/PRESUBMIT.py.

BUG=chromium:664425
NOTRY=True
TESTED=Ran:
tools/mb/mb.py gen -m client.webrtc -b 'Mac64 Release' --config-file webrtc/build/mb_config.pyl --isolate-map-file=webrtc/build/gn_isolate_map.pyl --gyp-script=webrtc/build/gyp_webrtc.py //out/Release

Review-Url: https://codereview.webrtc.org/2306163002
Cr-Commit-Position: refs/heads/master@{#15068}
 2016-11-14 13:54:29 +00:00
Henrik Kjellander
bb9212a33e Add ffmpeg and zxing to webrtc/tools/video_quality_toolchain. 
Usually .sha1 files are downlaoded using DEPS hooks but since this
bucket is internal we can't run it everywhere since it would fail
non-Googler checkouts. Instead we download the binaries by calling
a Python script, which will be added as a separate build step on the
buildbots.

The .sha1 files are copied from
https://cs.chromium.org/chromium/src/chrome/test/data/webrtc/resources/tools/
leaving out pesq and sox.

BUG=webrtc:6633
TESTED=Ran the download.py script on Mac and verified the files were downloaded.
R=mandermo@google.com, phoglund@webrtc.org

Review URL: https://codereview.webrtc.org/2462023002 .

Cr-Commit-Position: refs/heads/master@{#14859}
 2016-10-31 21:02:36 +00:00
Henrik Kjellander
057b8d91a6 Remove all traces of Dr Memory. 
The Dr Memory toolchain is no longer supported by Chromium and
their bots have been removed. WebRTC will now rely on the LLVM
santizers for catching such errors.

BUG=webrtc:6553
NOTRY=True
R=ehmaldonado@webrtc.org

Review URL: https://codereview.webrtc.org/2434563003 .

Cr-Commit-Position: refs/heads/master@{#14703}
 2016-10-20 11:17:25 +00:00
kjellander
91718a1629 Roll script: Update after SVN support was dropped from depot tools 
After https://codereview.chromium.org/2404413002 PyLint started
failing for our roll script. This fixes that.

BUG=webrtc:6544
TBR=phoglund@webrtc.org
NOTRY=True

Review-Url: https://codereview.webrtc.org/2425923002
Cr-Commit-Position: refs/heads/master@{#14654}
 2016-10-18 08:15:05 +00:00
henrik.lundin
0d8385770b NetEq: Convert AverageIAT from int to float calculations 
With this change, the calculations inside AverageIAT are changed to be
in double-precision floating point instead of in fixed point. Also,
the method's name is changed to EstimatedClockDriftPpm to better
reflect what it returns.

A few unit tests had to be updated because of minor numerical
differences.

Also removing the UBSan suppression related to this issue.

BUG=webrtc:5889

Review-Url: https://codereview.webrtc.org/2408653002
Cr-Commit-Position: refs/heads/master@{#14628}
 2016-10-13 10:35:58 +00:00
ivoc
52f6f2057c Disable VideoSendStreamTest.ChangingNetworkRoute and VideoSendStreamTest.EncoderSetupPropagatesVp8Config on WinDrMemoryFull. 
BUG=webrtc:6472
TBR=kjellander@webrtc.org
NOTRY=true

Review-Url: https://codereview.webrtc.org/2388893003
Cr-Commit-Position: refs/heads/master@{#14504}
 2016-10-04 15:36:53 +00:00
honghaiz
8b8459e31b suppress memcheck test errors in the Opus decoder and encoder. 
BUG=webrtc:6444

TBR=kjellander@webrtc.org
NOTRY=True

Review-Url: https://codereview.webrtc.org/2374253006
Cr-Commit-Position: refs/heads/master@{#14444}
 2016-09-30 04:12:46 +00:00
henrik.lundin
591c709fcb Suppress a memcheck error in Opus decoder 
BUG=webrtc:6444
TBR=kjellander@webrtc.org
NOTRY=True

Review-Url: https://codereview.webrtc.org/2376103004
Cr-Commit-Position: refs/heads/master@{#14439}
 2016-09-29 15:45:26 +00:00
Henrik Kjellander
0bb7f0594a Add BUG=None to autoroll CLs for chromium_revision in DEPS. 
TBR=ehmaldonado@webrtc.org
BUG=None

Review URL: https://codereview.webrtc.org/2355383003 .

Cr-Commit-Position: refs/heads/master@{#14338}
 2016-09-21 21:11:41 +00:00
zijiehe
8295c9326d [WebRTC] Add TwoCapturers test and TwoMagnifierCapturers test 
This change is to add more test cases for ScreenCapturer implementation.

BUG=

Review-Url: https://codereview.webrtc.org/2320763003
Cr-Commit-Position: refs/heads/master@{#14218}
 2016-09-14 17:22:01 +00:00
ehmaldonado
4e869e9f34 A more useful gyp_flag_compare script 
NOTRY=True
BUG=webrtc:5949

Review-Url: https://codereview.webrtc.org/2320873003
Cr-Commit-Position: refs/heads/master@{#14123}
 2016-09-08 10:12:24 +00:00
ehmaldonado
0b1b472c51 Enable gyp_compare_flag_script to compare all targets. 
BUG=webrtc:6310
NOTRY=True

Review-Url: https://codereview.webrtc.org/2310983002
Cr-Commit-Position: refs/heads/master@{#14079}
 2016-09-06 06:19:49 +00:00
Henrik Kjellander
b27c0918f2 Exclude flaky PhysicalSocketTest tests on Dr Memory bots. 
Also update the referenced bug for the Memcheck exclusion.

BUG=webrtc:4958
TBR=ehmaldonado@webrtc.org

Review URL: https://codereview.webrtc.org/2315493003 .

Cr-Commit-Position: refs/heads/master@{#14078}
 2016-09-06 05:38:38 +00:00
philipel
c07c8bb626 Suppress memcheck errors on linux bot. 
BUG=

Review-Url: https://codereview.webrtc.org/2278183002
Cr-Commit-Position: refs/heads/master@{#13932}
 2016-08-26 12:28:43 +00:00
ehmaldonado
94b9199fb1 Add a copy of gyp_flag_compare from Chromium to WebRTC's webrtc/tools. 
This should help spot any differences between GN and GYP.

BUG=webrtc:5949
NOTRY=True

Review-Url: https://codereview.webrtc.org/2246203004
Cr-Commit-Position: refs/heads/master@{#13840}
 2016-08-22 09:23:27 +00:00
Peter Boström
c21560b3e1 Remove pbos@webrtc.org from autoroll TBRs. 
BUG=
TBR=kjellander@webrtc.org

Review URL: https://codereview.webrtc.org/2259933002 .

Cr-Commit-Position: refs/heads/master@{#13824}
 2016-08-18 19:10:49 +00:00
jbauch
ed2f1ef369 Remove memcheck suppressions pointing to libnss3.so 
NSS has been replaced by BoringSSL/OpenSSL on all platforms, so the memcheck
suppressions should no longer be required.

BUG=
R=kjellander@webrtc.org
NOTRY=True

Review-Url: https://codereview.webrtc.org/2222243002
Cr-Commit-Position: refs/heads/master@{#13686}
 2016-08-09 06:01:36 +00:00
deadbeef
d356843706 Disable EndToEndTest.GetStats on Dr. Memory Full. 
BUG=webrtc:6146
TBR=kjellander@webrtc.org
NOTRY=True

Review-Url: https://codereview.webrtc.org/2182333004
Cr-Commit-Position: refs/heads/master@{#13545}
 2016-07-27 18:09:37 +00:00
mflodman
d4e6cbdbbe Remove suppression for non-existing test. 
R=pbos@webrtc.org

Review URL: https://codereview.webrtc.org/2177473002 .

Cr-Commit-Position: refs/heads/master@{#13509}
 2016-07-22 13:36:00 +00:00
Johan Ahlers
9ddac18d1c Add minimal LLVM sanity coverage (sancov) reporting for unittests. 
This CL enables generating *.sancov data. Blacklist for sancov tool is
provided, too. Sancov tool for report generation needs to be build from
llvm compiler-rt sources (llvm 3.9.0 or newer).

See http://clang.llvm.org/docs/SanitizerCoverage.html .

BUG=webrtc:6136
R=phoglund@webrtc.org
TBR=kjellander@webrtc.org

Review URL: https://codereview.webrtc.org/2144273002 .

Cr-Commit-Position: refs/heads/master@{#13506}
 2016-07-22 06:57:38 +00:00
stefan
a540ada1e1 Remove stefan@webrtc.org from libvpx roll notification. 
TBR=kjellander@webrtc.org
NOTRY=true

Review-Url: https://codereview.webrtc.org/2159873003
Cr-Commit-Position: refs/heads/master@{#13498}
 2016-07-18 18:15:59 +00:00
minyue
fd634c43e9 Reland of Re-enable UBsan on AGC. 
patchset #8 id:300001 of https://codereview.webrtc.org/2003623003/

This reverts commit 4867ca2689d6576a750180b8f8e6bd9a9e23056f.

BUG=webrtc:5530
TBR=peah@webrtc.org, kjellander@webrtc.org

Review-Url: https://codereview.webrtc.org/2072033004
Cr-Commit-Position: refs/heads/master@{#13188}
 2016-06-17 11:36:15 +00:00
pbos
4867ca2689 Revert of -enable UBsan on AGC. (patchset #1 id:1 of https://codereview.webrtc.org/2063643003/ ) 
Reason for revert:
Breaks downstream code import.

Original issue's description:
> Reland of Re-enable UBsan on AGC.
>
> patchset #8 id:300001 of https://codereview.webrtc.org/2003623003/
>
> This reverts commit 2b9423f7a18145255deb93f2505a4fd1c3fa9ad7.
>
> BUG=webrtc:5530
> TBR=peah@webrtc.org, kjellander@webrtc.org
>
> Committed: https://crrev.com/b1963b403f8e9258c35a02d2622da254cbb90c51
> Cr-Commit-Position: refs/heads/master@{#13132}

TBR=henrik.lundin@webrtc.org,minyue@webrtc.org
BUG=webrtc:5530
NOTRY=true

Review-Url: https://codereview.webrtc.org/2078433003
Cr-Commit-Position: refs/heads/master@{#13169}
 2016-06-16 14:59:13 +00:00
deadbeef
14461d42bc Fixing flaky test: WebRtcSessionTest.TestPacketOptionsAndOnPacketSent 
The test sent a media packet, then verified it was sent by checking the
"last packet sent"'s ID. But the last packet sent may have been
a STUN packet that came *after* the media packet.

BUG=webrtc:5978

Review-Url: https://codereview.webrtc.org/2071573002
Cr-Commit-Position: refs/heads/master@{#13156}
 2016-06-15 18:07:05 +00:00
minyue
b1963b403f Reland of Re-enable UBsan on AGC. 
patchset #8 id:300001 of https://codereview.webrtc.org/2003623003/

This reverts commit 2b9423f7a18145255deb93f2505a4fd1c3fa9ad7.

BUG=webrtc:5530
TBR=peah@webrtc.org, kjellander@webrtc.org

Review-Url: https://codereview.webrtc.org/2063643003
Cr-Commit-Position: refs/heads/master@{#13132}
 2016-06-14 14:18:17 +00:00
Åsa Persson
2b9423f7a1 Revert of Re-enable UBsan on AGC. (patchset #8 id:300001 of https://codereview.webrtc.org/2003623003/ ) 
Reason for revert:
Breaks bot.

Original issue's description:
> Re-enable UBsan on AGC.
>
> BUG=webrtc:5530
>
> Committed: https://crrev.com/293c86d67384c15f46b8296096a62a14b4a58d33
> Cr-Commit-Position: refs/heads/master@{#13034}

R=kjellander@webrtc.org, peah@webrtc.org
TBR=kjellander@webrtc.org, minyue@webrtc.org, peah@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:5530

Review URL: https://codereview.webrtc.org/2056683002 .

Cr-Commit-Position: refs/heads/master@{#13096}
 2016-06-10 07:12:43 +00:00
asapersson
2c1bec3fcc Add suppressions for memcheck errors. 
BUG=webrtc:5986,webrtc:5987,webrtc:5988, webrtc:5989
NOTRY=True

Review-Url: https://codereview.webrtc.org/2056713002
Cr-Commit-Position: refs/heads/master@{#13091}
 2016-06-09 15:08:15 +00:00
asapersson
da75f7cc2c Disable flaky test (WebRtcSessionTest.TestPacketOptionsAndOnPacketSent) on Dr Memory. 
BUG=webrtc:5978
NOTRY=True

Review-Url: https://codereview.webrtc.org/2051033002
Cr-Commit-Position: refs/heads/master@{#13086}
 2016-06-09 09:07:27 +00:00
asapersson
1503df6aef Add suppressions for memcheck errors. 
BUG=webrtc:5983,webrtc:5984
NOTRY=True

Review-Url: https://codereview.webrtc.org/2054683002
Cr-Commit-Position: refs/heads/master@{#13084}
 2016-06-09 07:46:38 +00:00
Åsa Persson
e1cac64842 Disable all BasicPortAllocatorTests on Dr Memory (flaky). 
BUG=webrtc:5929
NOTRY=True
R=kjellander@webrtc.org

Review URL: https://codereview.webrtc.org/2049523006 .

Cr-Commit-Position: refs/heads/master@{#13082}
 2016-06-09 07:15:23 +00:00
Åsa Persson
b6439396bf Disable flaky TurnPortTests on Memcheck. 
BUG=webrtc:5981
NOTRY=True
R=kjellander@webrtc.org

Review URL: https://codereview.webrtc.org/2045203003 .

Cr-Commit-Position: refs/heads/master@{#13071}
 2016-06-08 14:57:41 +00:00
minyue
293c86d673 Re-enable UBsan on AGC. 
BUG=webrtc:5530

Review-Url: https://codereview.webrtc.org/2003623003
Cr-Commit-Position: refs/heads/master@{#13034}
 2016-06-03 13:07:41 +00:00
kjellander@webrtc.org
2a3a93783e DrMemory: Exclude PingTaskTest tests. 
BUG=webrtc:5943
TBR=deadbeef@chromium.org

Review URL: https://codereview.webrtc.org/2024563002 .

Cr-Commit-Position: refs/heads/master@{#12955}
 2016-05-30 03:35:23 +00:00
deadbeef
2ce871548f Excluding some PhysicalSocketTest tests on memcheck. 
NOTRY=True

Review-Url: https://codereview.webrtc.org/2017453002
Cr-Commit-Position: refs/heads/master@{#12914}
 2016-05-26 11:03:50 +00:00
kjellander
2e15593803 Add memcheck suppression hitting only our linux_memcheck trybot. 
It seems the GCE VMs that are used for our trybots have slightly
different OS/libc versions than the Chrome infra Golo VMs, causing
it to fail with the current suppressions. This should make it go green.

See https://build.chromium.org/p/tryserver.webrtc/builders/linux_memcheck/builds/4374
for an example.

NOTRY=True
TBR=deadbeef@webrtc.org

Review-Url: https://codereview.webrtc.org/2016613003
Cr-Commit-Position: refs/heads/master@{#12912}
 2016-05-26 10:57:58 +00:00
philipel
be7a9e5f8a Revert "Revert of FrameBuffer for the new jitter buffer. (patchset #9 id:160001 of https://codereview.webrtc.org/1969403007/ )" 
Also disabled modules_unittest.TestFrameBuffer2.* in drmemory.

This reverts commit b711f10d9683b9de6ee78186f77b225fc7ebfb8f.

TBR=honghaiz@webrtc.org

BUG=

Review URL: https://codereview.webrtc.org/1991133003 .

Cr-Commit-Position: refs/heads/master@{#12806}
 2016-05-19 10:19:44 +00:00
Peter Boström
353ca7610b Disable SendsAndReceivesH264 on Memcheck. 
Test runs too slowly to complete.

BUG=webrtc:5893
R=tommi@webrtc.org

Review URL: https://codereview.webrtc.org/1977223002 .

Cr-Commit-Position: refs/heads/master@{#12748}
 2016-05-14 13:53:32 +00:00
Henrik Kjellander
27178676cf UBSan: Suppress openh264 and NetEq errors. 
As part of the work enabling OpenH264 in
WebRTC it was discovered that some of its code triggers
an UBSan errors:
third_party/openh264/src/codec/common/inc/golomb_common.h:103:3: runtime error: shift exponent 32 is too large for 32-bit type 'uint32_t' (aka 'unsigned int')
third_party/ffmpeg/libavcodec/h264_cavlc.c:585:54: runtime error: index -1 out of bounds for type 'VLC [15]'
Suppress such errors since this source code is out of our control.

This CL also includes a new NetEq suppression.

BUG=webrtc:5889
TBR=hbos@webrtc.org

Review URL: https://codereview.webrtc.org/1975863002 .

Cr-Commit-Position: refs/heads/master@{#12706}
 2016-05-12 16:24:40 +00:00
terelius
7b94c69213 Remove DropOldEvents from list of excluded tests. As of last week, the test no longer exists. (https://codereview.webrtc.org/1687703002/) 
BUG=webrtc:5312

Review-Url: https://codereview.webrtc.org/1917723003
Cr-Commit-Position: refs/heads/master@{#12584}
 2016-05-02 00:57:32 +00:00
Peter Boström
cd5c25cb80 Use vcm::VideoSender in ViEEncoder. 
ViEEncoder doesn't need a full VideoCodingModule since it only uses the
sender side either way.

BUG=webrtc:3608,webrtc:5687
R=perkj@webrtc.org

Review URL: https://codereview.webrtc.org/1904983002 .

Cr-Commit-Position: refs/heads/master@{#12456}
 2016-04-21 14:48:18 +00:00
kjellander
052af4cea2 autoroller: Use 10 characters for shortened Git hashes. 
Recently, the shortened hash
https://chromium.googlesource.com/chromium/src/+/355fabf
was not suffucient for the Chromium repo. Adding three more
should reduce the chance of this happening by 16^3.

NOTRY=True

Review URL: https://codereview.webrtc.org/1841563004

Cr-Commit-Position: refs/heads/master@{#12156}
 2016-03-30 09:30:59 +00:00
stefan
0e2e5d994f Revert of Revert opus memcheck suppression (patchset #1 id:1 of https://codereview.webrtc.org/1801233002/ ) 
Reason for revert:
Reverting since the memcheck bot still fails.

Original issue's description:
> Revert opus memcheck suppression
>
> BUG=https://bugs.chromium.org/p/webrtc/issues/detail?id=5651
>
> Committed: https://crrev.com/f62d107aa7ad6fcf2bacec3c6eb4a16469ed2287
> Cr-Commit-Position: refs/heads/master@{#12012}

TBR=flim@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=https://bugs.chromium.org/p/webrtc/issues/detail?id=5651

Review URL: https://codereview.webrtc.org/1807673004

Cr-Commit-Position: refs/heads/master@{#12017}
 2016-03-16 14:43:35 +00:00
flim
f62d107aa7 Revert opus memcheck suppression 
BUG=https://bugs.chromium.org/p/webrtc/issues/detail?id=5651

Review URL: https://codereview.webrtc.org/1801233002

Cr-Commit-Position: refs/heads/master@{#12012}
 2016-03-16 09:33:28 +00:00
Stefan Holmer
d67717f9ad Make opus memcheck suppression more generic 
TBR=kjellander@webrtc.org

BUG=webrtc:5651

Review URL: https://codereview.webrtc.org/1799093002 .

Cr-Commit-Position: refs/heads/master@{#11979}
 2016-03-14 15:00:12 +00:00
Stefan Holmer
479a04cbb7 Suppress invalid read in Opus. 
TBR=kjellander@webrtc.org
BUG=webrtc:5651

Review URL: https://codereview.webrtc.org/1803533002 .

Cr-Commit-Position: refs/heads/master@{#11975}
 2016-03-14 09:23:08 +00:00
kjellander@webrtc.org
2875077458 Roll chromium_revision db8316d..6a56b54 (380688:380836): MSVS 2015 switch 
This CL switches over to using Microsoft Visual Studio 2015 by default
on Windows. This large effort is described in more detail in
https://crbug.com/440500.

Change log: db8316d..6a56b54
Full diff: db8316d..6a56b54

No dependencies changed.
No update to Clang.

TBR=tommi@webrtc.org

Review URL: https://codereview.webrtc.org/1792633002 .

Cr-Commit-Position: refs/heads/master@{#11974}
 2016-03-14 05:49:17 +00:00
Henrik Kjellander
e496badf3c autoroller: Remove sending tryjobs (done via CQ). 
Skip running 'git cl try' since tryjobs are sent when
the CL is sent to the CQ anyway.

BUG=
R=pbos@webrtc.org

Review URL: https://codereview.webrtc.org/1746993003 .

Cr-Commit-Position: refs/heads/master@{#11827}
 2016-03-01 10:30:36 +00:00
kwiberg
806706875d iSAC entropy coder: Avoid signed integer overflow 
By doing an unsigned instead of a signed addition, we get the exact
same machine code (in non-UBSan builds), but no longer trigger
undefined behavior since unsigned overflow is defined behavior.

BUG=webrtc:5485

Review URL: https://codereview.webrtc.org/1734883003

Cr-Commit-Position: refs/heads/master@{#11776}
 2016-02-26 10:52:14 +00:00
peah
1cfe94096c Added the agc digital_agc.c file to the ubsan blacklist 
in order to suppress UBSan errors from the AGC.

BUG=webrtc:5124, webrtc:5487

Review URL: https://codereview.webrtc.org/1696153002

Cr-Commit-Position: refs/heads/master@{#11730}
 2016-02-24 07:06:56 +00:00
henrik.lundin
452df1cb44 Suppress UBSan errors in common_audio 
BUG=webrtc:5486,webrtc:5512
NOTRY=true

Review URL: https://codereview.webrtc.org/1714443002

Cr-Commit-Position: refs/heads/master@{#11671}
 2016-02-18 15:41:21 +00:00