Restoring a line from the older version (GYP-days) of the
build_ios_libs.sh script: modifying PATH so that the
PlistBuddy utility can be successfully found and called,
as it normally is not available under the PATH directories
in a typical OS X environment (even on developer configs).
NOTRY=True
BUG=webrtc:6372
Review-Url: https://codereview.webrtc.org/2463623002
Cr-Commit-Position: refs/heads/master@{#14834}
This CL removes the use_objc_h264 flag. This means that the VideoToolbox
H264 encoder and decoder will always be built.
BUG=webrtc:4081
NOTRY=TRUE
Review-Url: https://codereview.webrtc.org/2366443003
Cr-Commit-Position: refs/heads/master@{#14372}
Change the previous GN configs to build GYP instead
(since we'll keep GYP around for a while) but exclude tests
and examples for that config, since we'll only support the production
code for GYP.
Add new configs for upcoming rename of those bots to GYP instead
of GN.
BUG=webrtc:5949
NOTRY=True
TBR=ehmaldonado@webrtc.org
Review-Url: https://codereview.webrtc.org/2291443002
Cr-Commit-Position: refs/heads/master@{#13980}
On OS X El Capitan, the system location of 'PlistBuddy' is:
"/usr/libexec/PlistBuddy"
and default system path environment variable is:
"PATH=/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin"
NOTRY=True
Review-Url: https://codereview.webrtc.org/2262813002
Cr-Commit-Position: refs/heads/master@{#13841}
Turns out that if mb_type is missing in the JSON, GYP is run the
traditional way instead of having the MB configuration decide.
This turns on MB for those builders.
See https://codereview.chromium.org/2194703002 for how Chromium
switched from GYP->GN.
The JSON environment for GYP and GN is only used during runhooks
step since there are scripts that key on some of these environment variables.
The actual build that is compiled is defined by the MB config, which
is now updated to have component=static_library everywhere for iOS.
With this CL, all configs gets a full GYP+GN environment.
When flipping bots over to GN, the following line will need to be added
in addition to changing mb_type:
"additional_compile_targets": [ "all" ],
Goma was also enabled for all builders to reduce compile time.
BUG=589510
NOTRY=True
Review-Url: https://codereview.webrtc.org/2239643002
Cr-Commit-Position: refs/heads/master@{#13775}
I did some archaelogy here and found that the binary was (incorrectly?)
added here: https://codereview.webrtc.org/1903663002/. I can't find any
trace that a rtc_sdk_peerconnection_objc_tests has ever existed, or at
least that it doesn't exist now.
Removing it seems the right thing to do. However, I also see
rtc_sdk_peerconnection_objc target is folded into rtc_unittests in
webrtc_tests.gyp, but that target isn't listed in common_tests.json.
Should it be?
BUG=623500
TBR=tkchin@webrtc.org
Review-Url: https://codereview.webrtc.org/2121963002
Cr-Commit-Position: refs/heads/master@{#13392}
- Places most ObjC code into webrtc/sdk/objc instead.
- New gyp targets to build, strip and export symbols for dylib.
- Removes old script used to generate dylib.
BUG=
Review URL: https://codereview.webrtc.org/1903663002
Cr-Commit-Position: refs/heads/master@{#12524}
For historical reasons gyp_webrtc.py was launcher script
for gyp_webrtc and the python logic lived in the
gyp_webrtc. This change moves python code into the
.py file makes the extension-free gyp_webrtc a launcher
for gyp_webrtc.py.
Other changes:
* Move the code into a main() function.
* Add call to disable GC to save some processing time.
* Set executable permission on gyp_webrtc.py and remove it from
gyp_webrtc.
Similar Chromium CL: https://codereview.chromium.org/1216863010
Motivation for this change:
* Gets checked with PyLint
* Easy to add unit tests if we add our own functionality.
R=phoglund@webrtc.orgTBR=tkchin@webrtc.org
Review URL: https://codereview.webrtc.org/1895713002 .
Cr-Commit-Position: refs/heads/master@{#12410}
This is the only failing test of the currently deployed
at the iOS Simulator bots. Let's disable it so we can promote
the passing tests to the main waterfall and the trybots.
BUG=4755
TBR=henrika@webrtc.org
Review URL: https://codereview.webrtc.org/1722523002 .
Cr-Commit-Position: refs/heads/master@{#11703}
With this change the following tests have been successfully
passing in the iOS Simulator for iPhone 5 and iOS 9:
* audio_decoder_unittests
* common_video_unittests
* modules_tests
* rtc_api_objc_tests
* rtc_pc_unittests
* system_wrappers_unittests
* voice_engine_unittests
The modules_unittests and common_audio_unittests are
handled in https://codereview.webrtc.org/1698033002/
BUG=webrtc:4755
NOTRY=True
Review URL: https://codereview.webrtc.org/1694353003
Cr-Commit-Position: refs/heads/master@{#11646}
This reverts "iOS: Add mb_type config for GYP builders."
and also removes Goma from these builders, as it will not work for WebRTC
since MB's GYP mode is hardcoded to use gyp_chromium.
MB should be working for GN since it's a stand-alone tool.
Goma doesn't work since $(goma_dir) in the JSON throws an error during
compile. So let's turn off Goma for these bots for now.
BUG=chromium:498746
NOTRY=True
TBR=smut@google.com
Review URL: https://codereview.webrtc.org/1685683007
Cr-Commit-Position: refs/heads/master@{#11578}
The PRESUBMIT code is basically a stripped-down copy of the code in
Chromium's src/PRESUBMIT.py.
BUG=chromium:498746
TESTED=I verified with 'git cl presubmit' that the existing
error was found. Then I ran it again after fixing it, with
presubmit passing.
NOTRY=True
Review URL: https://codereview.webrtc.org/1682393002
Cr-Commit-Position: refs/heads/master@{#11572}
