kwiberg
91d9756bc6
Replace scoped_ptr with unique_ptr in webrtc/modules/audio_coding/codecs/
...
BUG=webrtc:5520
Review URL: https://codereview.webrtc.org/1696853004
Cr-Commit-Position: refs/heads/master@{#11613}
2016-02-14 09:10:08 +00:00
kwiberg
e9e7896293
Turn webrtc::Vad into a pure virtual interface
...
Review URL: https://codereview.webrtc.org/1317243005
Cr-Commit-Position: refs/heads/master@{#9899}
2015-09-09 06:04:57 +00:00
kwiberg
12cfc9b4da
Fold AudioEncoderMutable into AudioEncoder
...
It makes more sense to combine the two interfaces, since there wasn't
a clear line separating them. The result is a combined interface with
just over a dozen methods, half of which need to be implemented by
every subclass, while the other half have sensible (and trivial)
default implementations and are implemented only by the few subclasses
that need non-default behavior.
Review URL: https://codereview.webrtc.org/1322973004
Cr-Commit-Position: refs/heads/master@{#9894}
2015-09-08 12:57:59 +00:00
Peter Kasting
dce40cf804
Update a ton of audio code to use size_t more correctly and in general reduce
...
use of int16_t/uint16_t.
This is the upshot of a recommendation by henrik.lundin and kwiberg on an original small change ( https://webrtc-codereview.appspot.com/42569004/#ps1 ) to stop using int16_t just because values could fit in it, and is similar in nature to a previous "mass change to use size_t more" ( https://webrtc-codereview.appspot.com/23129004/ ) which also needed to be split up for review but to land all at once, since, like adding "const", such changes tend to cause a lot of transitive effects.
This was be reviewed and approved in pieces:
https://codereview.webrtc.org/1224093003
https://codereview.webrtc.org/1224123002
https://codereview.webrtc.org/1224163002
https://codereview.webrtc.org/1225133003
https://codereview.webrtc.org/1225173002
https://codereview.webrtc.org/1227163003
https://codereview.webrtc.org/1227203003
https://codereview.webrtc.org/1227213002
https://codereview.webrtc.org/1227893002
https://codereview.webrtc.org/1228793004
https://codereview.webrtc.org/1228803003
https://codereview.webrtc.org/1228823002
https://codereview.webrtc.org/1228823003
https://codereview.webrtc.org/1228843002
https://codereview.webrtc.org/1230693002
https://codereview.webrtc.org/1231713002
The change is being landed as TBR to all the folks who reviewed the above.
BUG=chromium:81439
TEST=none
R=andrew@webrtc.org , pbos@webrtc.org
TBR=aluebs, andrew, asapersson, henrika, hlundin, jan.skoglund, kwiberg, minyue, pbos, pthatcher
Review URL: https://codereview.webrtc.org/1230503003 .
Cr-Commit-Position: refs/heads/master@{#9768}
2015-08-24 21:52:45 +00:00
Bjorn Volcker
c3deaa30d5
common_audio/vad: Removes head allocation failure check
...
Related to https://webrtc-codereview.appspot.com/51919004/ where Create() was changed. This CL removes a useless malloc failure check.
BUG=441, 3347
R=kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/51109004
Cr-Commit-Position: refs/heads/master@{#9312}
2015-05-28 12:30:29 +00:00
Bjorn Volcker
de4703c5d1
Refactor common_audio/vad: Create now returns the handle directly instead of an error code
...
Changed the WebRtcVad_Create() function to the more conventional format of returning the handle directly instead of an error code to take care of.
In addition NULL was changed to nullptr in the files where it applied.
Affected components:
* AGC
* VAD
* NetEQ
BUG=441, 3347
TESTED=locally on Linux and trybots
R=kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/51919004
Cr-Commit-Position: refs/heads/master@{#9291}
2015-05-27 05:23:11 +00:00
henrik.lundin@webrtc.org
ff1a3e36bd
Make an AudioEncoder subclass for comfort noise
...
BUG=3926
R=bjornv@webrtc.org , kjellander@webrtc.org , kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/31129004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7857 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-10 07:29:08 +00:00
henrik.lundin@webrtc.org
8aa4d2d2cd
Creating a C++ wrapper class for VAD
...
Also adding a mock. This work is part of an ongoing effort to
encapsulate encoders in AudioEncoder classes. The CNG encoder will also
be implemented as an AudioEncoder class, and will also contain a VAD
C++ wrapper.
BUG=3926
R=bjornv@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/27839004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7570 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-30 13:23:25 +00:00
andrew@webrtc.org
65f933899b
Fix constness of AudioBuffer accessors.
...
Don't return non-const pointers from const accessors and deal with the
spillover. Provide overloaded versions as needed.
Inspired by kwiberg:
https://webrtc-codereview.appspot.com/12379005/
R=bjornv@webrtc.org , kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/15379004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6030 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-30 16:44:13 +00:00
bjornv@webrtc.org
2a796720f8
common_audio: VADFree() now returns void
...
* Files in audio_coding are not affected since they never use the return value.
* voice_detection in audio_processing does.
* Updated vad_unittest.cc
BUG=441
TESTED=trybots
R=andrew@webrtc.org , tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/12059005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5948 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-22 04:45:35 +00:00
pbos@webrtc.org
aa30bb7ef5
Include files from webrtc/.. paths in common_audio/
...
BUG=1662
R=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1535005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4107 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-27 09:49:58 +00:00
andrew@webrtc.org
14b43beb7c
Move src/ -> webrtc/
...
TBR=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/915006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2963 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-22 18:19:23 +00:00
