Henrik Kjellander
e6cefb60f8
GYP variables for building expat, icu, libsrtp, usrsctp
...
This makes the build more flexible when linking against
prebuilt external libraries.
Use existing build_* variables for libyuv and json in talk/
(already in use in webrtc/).
Also make it possible to avoid building the GTK parts of the Linux build.
BUG=4242
R=andrew@webrtc.org , tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/44179005
Cr-Commit-Position: refs/heads/master@{#9087}
2015-04-27 12:38:37 +00:00
Thiago Farina
91543731c3
Do not define POSIX.
...
It breaks integration with upstream re2 library on Chromium.
Without patching re2 library, with this define, it produces the
following error:
../../third_party/re2/re2/re2.h:254:5: error: expected identifier
POSIX, // POSIX syntax, leftmost-longest match
As we define POSIX on the command line, the C preprocessor changes
RE2::POSIX to nothing and thus break the compilation. :(
See chromium-dev mailing list for this discussion in
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/UXCHnX7pV44/discussion
BUG=None
TEST=ninja -C out/Debug, everything compiles as before
R=sergeyu@chromium.org , tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/46049004
Patch from Thiago Farina <tfarina@chromium.org>.
Cr-Commit-Position: refs/heads/master@{#9032}
2015-04-20 11:14:22 +00:00
Thiago Farina
ae0f0ee79e
Cleanup: Remove DISALLOW_EVIL_CONSTRUCTORS macro.
...
Just use the less-evil version, DISALLOW_COPY_AND_ASSIGN macro.
This should help with my TODO in
https://chromium.googlesource.com/chromium/src/+/master/base/macros.h#33
Tested on Linux with the following command lines:
$ rm -rf out/
$ gn gen //out/Debug --args='is_debug=true target_cpu="x64" build_with_chromium=false'
$ ninja -C out/Debug
BUG=None
TEST=see above
R=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/50599004
Patch from Thiago Farina <tfarina@chromium.org>.
Cr-Commit-Position: refs/heads/master@{#8927}
2015-04-04 23:56:56 +00:00
Henrik Kjellander
722ef1fb59
Remove henrike@ from OWNERS
...
Since he has left the team.
R=henrike@webrtc.org , tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/48789004
Cr-Commit-Position: refs/heads/master@{#8913}
2015-04-01 15:08:49 +00:00
kwiberg@webrtc.org
00b8f6b364
Use base/scoped_ptr.h; system_wrappers/interface/scoped_ptr.h is going away
...
BUG=
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/36229004
Cr-Commit-Position: refs/heads/master@{#8517}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8517 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-26 14:43:50 +00:00
kwiberg@webrtc.org
ac2d27d9ae
Fix style violations in common_types.h and config.h
...
Mostly, it's about moving constructors and descructors to the .cc
files, so that they won't be inlined everywhere.
The reason this CL is so big is that a lot of code was using
common_types.h without declaring a dependency on webrtc_common, which
broke the build once common_types.h started to depend on
common_types.cc.
BUG=163
R=kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/26089004
Cr-Commit-Position: refs/heads/master@{#8516}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8516 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-26 14:01:28 +00:00
andresp@webrtc.org
ff689be3c0
Use std::min and std::max instead of self-defined functions such as rtc::_min/_max.
...
R=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/35079004
Cr-Commit-Position: refs/heads/master@{#8347}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8347 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-12 11:55:32 +00:00
kjellander@webrtc.org
7d2b6a9346
Enable Clang warning implicit-fallthrough and annotate the code.
...
BUG=4242
R=henrik.lundin@webrtc.org , stefan@webrtc.org , tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/34899004
Cr-Commit-Position: refs/heads/master@{#8187}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8187 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-28 18:38:13 +00:00
kjellander@webrtc.org
d7e34e1086
Make it easier to use external libyuv + cleanup GYP files.
...
It is now easier to use an external libyuv library.
Fix some GYP errors.
Remove the temporary webrtc_base target (depends on
https://codereview.chromium.org/865603002/ being landed
first).
BUG=4185
R=andresp@webrtc.org , andrew@webrtc.org , perkj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/39579004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8154 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-26 19:17:26 +00:00
tommi@webrtc.org
586f2eda0d
Change GetStreamBySsrc to not copy StreamParams.
...
This is something I stumbled upon while looking at string copying we do (in spades) and did a simple change to not be constantly copying things around needlessly. There's a lot more that can be done in these files of course so this is sort of a reminder for future code edits that it's possible to design interfaces/function in a way that's more performance aware and avoid forcing creation of copies, while still being very simple. Also, we can use lambdas now :)
BUG=
R=perkj@webrtc.org , pthatcher@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/41589004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8131 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-22 23:00:41 +00:00
pthatcher@webrtc.org
0ba1533fdb
Added support for an Origin header in STUN messages.
...
For WebRTC there are instances where it may be desirable to provide
information to the STUN/TURN server about the website that initiated
a peer connection. This modification allows an origin string to be
included in the MediaConstraints object provided by the browser, which
is then passed as a STUN header in communications with the server.
A separate change will be submitted to the Chromium project that
uses and is dependent on this change, implementing IETF draft
http://tools.ietf.org/html/draft-johnston-tram-stun-origin-02
Originally a patch from skobalt@gmail.com .
(https://webrtc-codereview.appspot.com/12839005/edit )
R=juberti@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/41409004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8035 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-10 00:47:02 +00:00
pthatcher@webrtc.org
5ad4178137
Move the Jingle-specific network code into webrtc/libjingle.
...
R=pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/29319004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7977 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-23 22:14:15 +00:00
pthatcher@webrtc.org
4c0544ab07
Move Jingle-specific files from talk/session/media to webrtc/libjingle/session/media. This is part of an ongoing effort to remove Jingle-specific files from the WebRTC repository.
...
Also, fix the includes and header guards of examples/call.
R=juberti@webrtc.org , pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/34559004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7972 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-19 22:29:55 +00:00
pthatcher@webrtc.org
5647877b2d
Breakup Transports and TransportParsers and move TransportParsers into webrtc/libjingle. This is part of an ongoing effort to move Jingle-specific code out of WebRTC and into its own repository.
...
R=juberti@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/33679004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7959 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-19 03:32:59 +00:00
pthatcher@webrtc.org
aacc23465b
Split up (Jingle)Session from BaseSession. This is part of an ongoing effort to move Jingle-specific code out of WebRTC and into its own repository.
...
(This is the 3rd try)
R=juberti@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/29309004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7956 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-18 20:31:29 +00:00
pthatcher@webrtc.org
f5847d7746
Move session/tunnel to webrtc/libjingle. This is part of the ongoing effort to move Jingle-specific things out of WebRTC and into its own repository. I won't submit this until all other projects have moved off of compiling this as well.
...
R=juberti@webrtc.org , pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/38369004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7953 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-18 17:09:11 +00:00
pthatcher@webrtc.org
4cb3856a4d
Revert "Split up (Jingle)Session from BaseSession. This is part of an ongoing effort to move Jingle-specific code out of WebRTC and into its own repository."
...
This reverts r7939 because it broke Chromium and other depedent projects that rely on certain logic remaining in p2p/base/session.cc and not in webrtc/libjingle/session.cc.
BUG=
R=turaj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/36589004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7940 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-18 02:28:25 +00:00
pthatcher@webrtc.org
536f999e58
Split up (Jingle)Session from BaseSession. This is part of an ongoing effort to move Jingle-specific code out of WebRTC and into its own repository.
...
This is an un-revert of r7992 and r7993.
R=henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/32869004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7939 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-18 01:22:02 +00:00
pthatcher@webrtc.org
bc03192560
Move jingle examples from talk/ into webrtc/libjingle. This is part of the effor to move Jingle out of WebRTC and into its own repository.
...
R=juberti@webrtc.org , pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/32849004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7936 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-17 22:15:11 +00:00
pthatcher@webrtc.org
f050791ba0
Revert "Split up (Jingle)Session from BaseSession. This is part of an ongoing effort to move Jingle-specific code out of WebRTC and into its own repository."
...
This reverts r7992.
It broke the Chromium build because the Chroumium build relies on the logic in webtc/libjingle/session.cc, but Chromium doesn't compile that file.
R=henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/38389004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7923 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-16 22:28:03 +00:00
pthatcher@webrtc.org
4afb59903c
Split up (Jingle)Session from BaseSession. This is part of an ongoing effort to move Jingle-specific code out of WebRTC and into its own repository.
...
R=juberti@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/35529004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7922 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-16 21:37:37 +00:00
pthatcher@webrtc.org
02c21dbef1
Make one OWNERS files for all of webrtc/libjingle so we don't need approval from webrtc/OWNERS every time we want to add a directory.
...
R=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/37429004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7919 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-16 21:04:41 +00:00
pbos@webrtc.org
18a3896bd2
Revert r7886:7887.
...
Broke build steps in other code that uses securetunnelsessionclient.cc
and others.
TBR=tommi@webrtc.org ,pthatcher@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/36439004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7890 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-15 07:03:04 +00:00
pthatcher@webrtc.org
e9db7fe80c
Put pseudotcp back because remoting uses it.
...
R=andrew@webrtc.org , niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/36409004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7887 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-13 01:56:39 +00:00
pthatcher@webrtc.org
dee76f3b89
Move the obvious/easy Jingle-specific code into webrtc/libjingle.
...
R=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/32669004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7886 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-12 21:04:42 +00:00
henrike@webrtc.org
269fb4bc90
move xmpp and p2p to webrtc
...
Create a copy of talk/xmpp and talk/p2p under webrtc/libjingle/xmpp and
webrtc/p2p. Also makes libjingle use those version instead of the one in the talk folder.
BUG=3379
Review URL: https://webrtc-codereview.appspot.com/26999004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7549 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-28 22:20:11 +00:00
henrike@webrtc.org
28100cb388
Reverts r7459 "Create a copy of talk/xmpp and talk/p2p under webrtc/libjingle/xmpp and webrtc/p2p."
...
BUG=N/A
TBR=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/29829004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7472 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-17 22:03:39 +00:00
henrike@webrtc.org
d1ba6d9cbf
Create a copy of talk/xmpp and talk/p2p under webrtc/libjingle/xmpp and webrtc/p2p.
...
BUG=3379
R=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/27709005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7459 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-15 17:30:28 +00:00
henrike@webrtc.org
2fe5893748
Mac: adds missing _DEBUG flag to mac debug builds.
...
BUG=3836
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/25769004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7377 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-06 22:04:11 +00:00
henrike@webrtc.org
31b75eae05
Moves xmllite's unittests to rtc_unittest.
...
BUG=3836
R=andrew@webrtc.org , kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/26669005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7369 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-02 18:43:47 +00:00
henrike@webrtc.org
b2efb6771c
Put base tests in webrtc_tests.gyp
...
BUG=N/A
R=andrew@webrtc.org , pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/14249004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7140 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-10 17:28:19 +00:00
andresp@webrtc.org
fa822b940f
Fix strange owners files with comments that crashs "git cl presubmit"
...
TBR=henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/14359004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7064 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-04 14:25:07 +00:00
henrike@webrtc.org
d72a7599d4
Create a copy of talk/xmllite under webrtc/xmllite.
...
BUG=3379
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/22249004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7027 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-02 15:41:12 +00:00