admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
14,320 Commits 1 Branch 0 Tags
Commit Graph

16 Commits

Author SHA1 Message Date
kwiberg
1e8ed4a801 Replace calls to assert() with RTC_DCHECK_*() in .c code 
We have RTC_CHECK and RTC_DCHECK for C now, so we should use it. It's
one fewer difference between our C and C++ code.

NOPRESUBMIT=true

Review-Url: https://codereview.webrtc.org/2274083002
Cr-Commit-Position: refs/heads/master@{#13930}
 2016-08-26 11:33:41 +00:00
minyue
fd634c43e9 Reland of Re-enable UBsan on AGC. 
patchset #8 id:300001 of https://codereview.webrtc.org/2003623003/

This reverts commit 4867ca2689d6576a750180b8f8e6bd9a9e23056f.

BUG=webrtc:5530
TBR=peah@webrtc.org, kjellander@webrtc.org

Review-Url: https://codereview.webrtc.org/2072033004
Cr-Commit-Position: refs/heads/master@{#13188}
 2016-06-17 11:36:15 +00:00
pbos
4867ca2689 Revert of -enable UBsan on AGC. (patchset #1 id:1 of https://codereview.webrtc.org/2063643003/ ) 
Reason for revert:
Breaks downstream code import.

Original issue's description:
> Reland of Re-enable UBsan on AGC.
>
> patchset #8 id:300001 of https://codereview.webrtc.org/2003623003/
>
> This reverts commit 2b9423f7a18145255deb93f2505a4fd1c3fa9ad7.
>
> BUG=webrtc:5530
> TBR=peah@webrtc.org, kjellander@webrtc.org
>
> Committed: https://crrev.com/b1963b403f8e9258c35a02d2622da254cbb90c51
> Cr-Commit-Position: refs/heads/master@{#13132}

TBR=henrik.lundin@webrtc.org,minyue@webrtc.org
BUG=webrtc:5530
NOTRY=true

Review-Url: https://codereview.webrtc.org/2078433003
Cr-Commit-Position: refs/heads/master@{#13169}
 2016-06-16 14:59:13 +00:00
minyue
b1963b403f Reland of Re-enable UBsan on AGC. 
patchset #8 id:300001 of https://codereview.webrtc.org/2003623003/

This reverts commit 2b9423f7a18145255deb93f2505a4fd1c3fa9ad7.

BUG=webrtc:5530
TBR=peah@webrtc.org, kjellander@webrtc.org

Review-Url: https://codereview.webrtc.org/2063643003
Cr-Commit-Position: refs/heads/master@{#13132}
 2016-06-14 14:18:17 +00:00
Åsa Persson
2b9423f7a1 Revert of Re-enable UBsan on AGC. (patchset #8 id:300001 of https://codereview.webrtc.org/2003623003/ ) 
Reason for revert:
Breaks bot.

Original issue's description:
> Re-enable UBsan on AGC.
>
> BUG=webrtc:5530
>
> Committed: https://crrev.com/293c86d67384c15f46b8296096a62a14b4a58d33
> Cr-Commit-Position: refs/heads/master@{#13034}

R=kjellander@webrtc.org, peah@webrtc.org
TBR=kjellander@webrtc.org, minyue@webrtc.org, peah@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:5530

Review URL: https://codereview.webrtc.org/2056683002 .

Cr-Commit-Position: refs/heads/master@{#13096}
 2016-06-10 07:12:43 +00:00
minyue
293c86d673 Re-enable UBsan on AGC. 
BUG=webrtc:5530

Review-Url: https://codereview.webrtc.org/2003623003
Cr-Commit-Position: refs/heads/master@{#13034}
 2016-06-03 13:07:41 +00:00
minyue
cac94aae3e Clang format on AGC legacy code. 
BUG=

Review-Url: https://codereview.webrtc.org/1998183002
Cr-Commit-Position: refs/heads/master@{#12831}
 2016-05-20 15:42:30 +00:00
peah
4d291f7d5e Applied the render queueing to the agc. 
BUG=webrtc:5099

Review URL: https://codereview.webrtc.org/1416583003

Cr-Commit-Position: refs/heads/master@{#10667}
 2015-11-17 07:52:32 +00:00
Peter Kasting
dce40cf804 Update a ton of audio code to use size_t more correctly and in general reduce 
use of int16_t/uint16_t.

This is the upshot of a recommendation by henrik.lundin and kwiberg on an original small change ( https://webrtc-codereview.appspot.com/42569004/#ps1 ) to stop using int16_t just because values could fit in it, and is similar in nature to a previous "mass change to use size_t more" ( https://webrtc-codereview.appspot.com/23129004/ ) which also needed to be split up for review but to land all at once, since, like adding "const", such changes tend to cause a lot of transitive effects.

This was be reviewed and approved in pieces:
https://codereview.webrtc.org/1224093003
https://codereview.webrtc.org/1224123002
https://codereview.webrtc.org/1224163002
https://codereview.webrtc.org/1225133003
https://codereview.webrtc.org/1225173002
https://codereview.webrtc.org/1227163003
https://codereview.webrtc.org/1227203003
https://codereview.webrtc.org/1227213002
https://codereview.webrtc.org/1227893002
https://codereview.webrtc.org/1228793004
https://codereview.webrtc.org/1228803003
https://codereview.webrtc.org/1228823002
https://codereview.webrtc.org/1228823003
https://codereview.webrtc.org/1228843002
https://codereview.webrtc.org/1230693002
https://codereview.webrtc.org/1231713002

The change is being landed as TBR to all the folks who reviewed the above.

BUG=chromium:81439
TEST=none
R=andrew@webrtc.org, pbos@webrtc.org
TBR=aluebs, andrew, asapersson, henrika, hlundin, jan.skoglund, kwiberg, minyue, pbos, pthatcher

Review URL: https://codereview.webrtc.org/1230503003 .

Cr-Commit-Position: refs/heads/master@{#9768}
 2015-08-24 21:52:45 +00:00
Bjorn Volcker
9345e86551 audio_processing: Create now returns a pointer to the object 
Affects
* NS
* AGC
* AEC

BUG=441
TESTED=locally on Linux and trybots
R=kwiberg@webrtc.org

Review URL: https://codereview.webrtc.org/1175903002.

Cr-Commit-Position: refs/heads/master@{#9411}
 2015-06-10 19:43:46 +00:00
Bjorn Volcker
f6a99e63b6 Refactor audio_processing: Free functions return void 
There is no point in returning an error when Free() fails. In fact it can only happen if we have a null pointer as object. There is further no place where the return value is used.

Affected components are
- aec
- aecm
- agc
- ns

BUG=441
R=kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/50579004

Cr-Commit-Position: refs/heads/master@{#8966}
 2015-04-10 05:56:59 +00:00
bjornv@webrtc.org
1afbdc7555 Refactor audio_processing/agc: Removes usage of macro WEBRTC_SPL_MUL_16_16_RSFT 
The macro is defined as
#define WEBRTC_SPL_MUL_16_16_RSFT(a, b, c) \
(WEBRTC_SPL_MUL_16_16(a, b) >> (c))

where the latter macro is in C defined as
#define WEBRTC_SPL_MUL_16_16(a, b) \
((int32_t) (((int16_t)(a)) * ((int16_t)(b))))
(For definitions on ARMv7 and MIPS, see common_audio/signal_processing/include/spl_inl_{armv7,mips}.h)

The replacement consists of
- avoiding casts to int16_t if inputs already are int16_t
- adding explicit cast to <type> if result is assigned to <type> (other than int or int32_t)
- minor cleanups like remove of unnecessary parentheses and style changes

BUG=3348,3353
TESTED=locally on Mac and trybots
R=kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/47449004

Cr-Commit-Position: refs/heads/master@{#8664}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8664 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-03-10 06:38:16 +00:00
bjornv@webrtc.org
5e5b32706a audio_processing/agc: Removed usage of macro WEBRTC_SPL_MUL_16_16 in legacy/agc 
The macro is in C defined as
#define WEBRTC_SPL_MUL_16_16(a, b) ((int32_t) (((int16_t)(a)) * ((int16_t)(b))))
(For definition on ARMv7 and MIPS, see common_audio/signal_processing/include/spl_inl_armv7.h and common_audio/signal_processing/include/spl_inl_mips.h)

The replacement consists of
- avoiding casts to int16_t if inputs already are int16_t
- adding explicit cast to <type> if result is assigned to <type> (other than int or int32_t)

BUG=3348, 3353
TESTED=locally on Mac and trybots
R=kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/39389004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@8023 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-01-08 17:25:34 +00:00
pbos@webrtc.org
e468bc9e60 Rename _t struct types in audio_processing. 
_t names are reserved in POSIX.

R=bjornv@webrtc.org
BUG=162

Review URL: https://webrtc-codereview.appspot.com/34509005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7943 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-12-18 09:11:33 +00:00
aluebs@webrtc.org
cf6d0b64ef Add 48kHz support to AGC 
Doing the same for the 16-24kHz band than was done in the 8-16kHz.
Results look and sound as nice.

Originally reviewed here:
https://webrtc-codereview.appspot.com/26339004/

BUG=webrtc:3146
R=andrew@webrtc.org, kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/28299004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7917 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-12-16 20:56:09 +00:00
bjornv@webrtc.org
b395a5ea65 audio_processing: Moved legacy AGC code to webrtc/modules/audio_processing/agc/legacy/ 
include/ is renamed to legacy/ and analog_agc.* and digital_agc.* moved into the directory.

BUG=
R=andrew@webrtc.org, pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/36479004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7909 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-12-16 10:38:10 +00:00