22 Commits

Author SHA1 Message Date
Kári Tristan Helgason
470c0887b3 Fix modules_unittests on iOS.
Some of the module tests were failing on iOS, causing them to be ignored
on the trybots. Specifically this CL:
- Skips some tests that should not run on the simulator
- Fixes iOS file system test helpers
- Fixes failing nalu parser unittest

BUG=webrtc:4752
R=henrika@webrtc.org, peah@webrtc.org, sprang@webrtc.org
TBR=tkchin@webrtc.org

Review URL: https://codereview.webrtc.org/2352063002 .

Cr-Commit-Position: refs/heads/master@{#14472}
2016-10-03 11:13:33 +00:00
ehmaldonado
8b28b8017f Assume ProjectRootPath() equals ../.. in Desktop
This way we don't have to rely on the existence of DEPS, and the tests
can be run in swarming bots (which don't have a checkout and therefore
don't have a DEPS file).

This seems to be where Chromium is assumming the project root path to
be.

NOTRY=True
BUG=chromium:497757

Review-Url: https://codereview.webrtc.org/2340773002
Cr-Commit-Position: refs/heads/master@{#14230}
2016-09-15 11:45:55 +00:00
kjellander
68208897be Roll chromium_revision 7fa6701bc5..1a73d11e65 (398458:399420)
A fix was needed to make Android tests pass after
https://codereview.chromium.org/2043803003

Another fix was needed for the webrtc_perf_tests.isolate sinc eit was missing
one file.

Change log: 7fa6701bc5..1a73d11e65
Full diff: 7fa6701bc5..1a73d11e65

Changed dependencies:
* src/buildtools: 8dd3c8e39a..099f1da55b
* src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/0fc7df55c0..171b5403ee
* src/third_party/ffmpeg: 7f03319b9d..bcb8b67b8b
DEPS diff: 7fa6701bc5..1a73d11e65/DEPS

No update to Clang.

TBR=
BUG=webrtc:5990
NOTRY=True

Review-Url: https://codereview.webrtc.org/2074043002
Cr-Commit-Position: refs/heads/master@{#13178}
2016-06-17 06:29:38 +00:00
kjellander
dfe6937666 Revert of Roll chromium_revision 7fa6701bc5..1a73d11e65 (398458:399420) (patchset #2 id:20001 of https://codereview.webrtc.org/2061723002/ )
Reason for revert:
webrtc_perf_tests fails on all Android Release testers:
http://build.chromium.org/p/client.webrtc/builders/Android64%20Tests%20%28L%20Nexus9%29/builds/3673

Original issue's description:
> Roll chromium_revision 7fa6701bc5..1a73d11e65 (398458:399420)
>
> A fix was needed to make Android tests pass after
> https://codereview.chromium.org/2043803003
>
> Change log: 7fa6701bc5..1a73d11e65
> Full diff: 7fa6701bc5..1a73d11e65
>
> Changed dependencies:
> * src/buildtools: 8dd3c8e39a..099f1da55b
> * src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/0fc7df55c0..171b5403ee
> * src/third_party/ffmpeg: 7f03319b9d..bcb8b67b8b
> DEPS diff: 7fa6701bc5..1a73d11e65/DEPS
>
> No update to Clang.
>
> TBR=
> BUG=webrtc:5990
> NOTRY=True
>
> Committed: https://crrev.com/c49cf1308f879ce029f5f0e804b4eef3b08b67c5
> Cr-Commit-Position: refs/heads/master@{#13117}

TBR=
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:5990

Review-Url: https://codereview.webrtc.org/2059423002
Cr-Commit-Position: refs/heads/master@{#13118}
2016-06-13 21:11:09 +00:00
kjellander
c49cf1308f Roll chromium_revision 7fa6701bc5..1a73d11e65 (398458:399420)
A fix was needed to make Android tests pass after
https://codereview.chromium.org/2043803003

Change log: 7fa6701bc5..1a73d11e65
Full diff: 7fa6701bc5..1a73d11e65

Changed dependencies:
* src/buildtools: 8dd3c8e39a..099f1da55b
* src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/0fc7df55c0..171b5403ee
* src/third_party/ffmpeg: 7f03319b9d..bcb8b67b8b
DEPS diff: 7fa6701bc5..1a73d11e65/DEPS

No update to Clang.

TBR=
BUG=webrtc:5990
NOTRY=True

Review-Url: https://codereview.webrtc.org/2061723002
Cr-Commit-Position: refs/heads/master@{#13117}
2016-06-13 19:12:47 +00:00
kwiberg
bfefb03ec1 Replace scoped_ptr with unique_ptr everywhere
But keep #including scoped_ptr.h in .h files, so as not to break
WebRTC users who expect those .h files to give them rtc::scoped_ptr.

BUG=webrtc:5520

Review-Url: https://codereview.webrtc.org/1937693002
Cr-Commit-Position: refs/heads/master@{#12581}
2016-05-01 21:53:55 +00:00
kjellander
0206000a66 iOS: Add resource files for tests and implement OutputPath
With this change the following tests have been successfully
passing in the iOS Simulator for iPhone 5 and iOS 9:
* audio_decoder_unittests
* common_video_unittests
* modules_tests
* rtc_api_objc_tests
* rtc_pc_unittests
* system_wrappers_unittests
* voice_engine_unittests

The modules_unittests and common_audio_unittests are
handled in https://codereview.webrtc.org/1698033002/

BUG=webrtc:4755
NOTRY=True

Review URL: https://codereview.webrtc.org/1694353003

Cr-Commit-Position: refs/heads/master@{#11646}
2016-02-17 06:06:17 +00:00
ivoc
72c08edced Reenables several NetEq unittests on android.
Several unittests were disabled on android, this CL will reenable them. One of
the tests was accidentally disabled on all platforms, and now no longer gives a
bitexact result.

BUG=webrtc:3343,webrtc:5349

Review URL: https://codereview.webrtc.org/1532903002

Cr-Commit-Position: refs/heads/master@{#11323}
2016-01-20 15:26:28 +00:00
Henrik Kjellander
98f53510b2 system_wrappers: rename interface -> include
BUG=webrtc:5095
R=tommi@webrtc.org

Review URL: https://codereview.webrtc.org/1413333002 .

Cr-Commit-Position: refs/heads/master@{#10438}
2015-10-28 17:17:50 +00:00
henrika
1d34fe979c Adds support for webrtc::test::ResourcePath on iOS
BUG=webrtc:4752
R=tkchin@webrtc.org

Review URL: https://codereview.webrtc.org/1178843002.

Cr-Commit-Position: refs/heads/master@{#9445}
2015-06-16 08:04:24 +00:00
kwiberg@webrtc.org
00b8f6b364 Use base/scoped_ptr.h; system_wrappers/interface/scoped_ptr.h is going away
BUG=
R=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/36229004

Cr-Commit-Position: refs/heads/master@{#8517}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8517 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-26 14:43:50 +00:00
kjellander@webrtc.org
72fd339352 Restore old behavior for Android in fileutils.cc
From r7014 the Android APK tests are designed to be
build from a standalone WebRTC checkout instead of a
Chromium checkout. Because of that, the special handling
for both cases can be removed.

I also don't think we need to use the
base::android::GetExternalStorageDirectory() method since
all devices has a symlink at /sdcard that points
to /storage/emulated/legacy on the Android device.

This essentially reverts the changes in
https://webrtc-codereview.appspot.com/1754005/
plus some minor changes.

BUG=webrtc:3741
TEST=Locally running test_support_unittests APK test on an
Android device using:
CHECKOUT_SOURCE_ROOT=`pwd` build/android/test_runner.py gtest -s test_support_unittests --verbose --isolate-file-path=webrtc/test/test_support_unittests.isolate
R=henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/15329004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7632 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-05 06:28:50 +00:00
henrike@webrtc.org
f2aafe4355 Added include of assert.h for files calling assert but missing the include.
BUG=N/A
R=niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/19409005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6022 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-29 17:54:17 +00:00
kjellander@webrtc.org
7de47bce12 Remove use of tmpnam.
This solves compilation with the Mac SDK 10.9.

BUG=3120, 3151
TEST=git try -t modules_tests:VideoProcessorIntegrationTest*
R=fischman@webrtc.org, henrike@webrtc.org, stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/10739005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5917 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-16 08:04:26 +00:00
kjellander@webrtc.org
de499669ef Fix fileutils.cc for tests running under Win memory tools.
On Windows, when tests are run under memory tools like
DrMemory and TSan, slashes occur in the path as directory
separators. This makes the fileutils.cc fail to figure out
the project root, making paths to resource files invalid.

By replacing slashes in the path with backslashes for Windows
this can be fixed.

BUG=2318
TEST=running the same command as the bot locally, succeeding after this patch is applied.
R=phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2137004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4640 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-29 11:26:41 +00:00
pbos@webrtc.org
12dc1a38ca Switch C++-style C headers with their C equivalents.
The C++ headers define the C functions within the std:: namespace, but
we mainly don't use the std:: namespace for C functions. Therefore we
should include the C headers.

BUG=1833
R=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1917004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4486 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-05 16:22:53 +00:00
pbos@webrtc.org
fc496d95df Add root_path_android.cc to webrtc/test/Android.mk.
Fixes the broken android-platform build (build that uses .mk files).

TBR=andrew@webrtc.org,henrike@webrtc.org
BUG=

Review URL: https://webrtc-codereview.appspot.com/1777004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4314 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-09 15:24:16 +00:00
henrike@webrtc.org
34773d9b6b Unreverts revert: Makes it possible to find files used by some unit tests when running them as Chrome native tests.
TBR=andrew@webrtc.org

BUG=N/A

Review URL: https://webrtc-codereview.appspot.com/1754005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4303 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-08 14:55:23 +00:00
pbos@webrtc.org
db7d82f26f Revert 4298 "Makes it possible to find files used by some unit t..."
> Makes it possible to find files used by some unit tests when running them as Chrome native tests.
> 
> BUG=N/A
> R=andrew@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/1749004

Broke Android NDK/Android.mk builds.

TBR=henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1752006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4299 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-05 08:49:09 +00:00
henrike@webrtc.org
caf2fcca6a Makes it possible to find files used by some unit tests when running them as Chrome native tests.
BUG=N/A
R=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1749004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4298 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-05 04:15:38 +00:00
pbos@webrtc.org
34741c8b0e Include files from webrtc/.. paths in test/
BUG=1662
R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1549004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4105 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-27 08:02:22 +00:00
andrew@webrtc.org
14b43beb7c Move src/ -> webrtc/
TBR=niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/915006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2963 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-22 18:19:23 +00:00