tommi@webrtc.org
38492c5b6f
Re-land 8810 "- Add a SetPriority method to ThreadWr..."
...
> Revert 8810 "- Add a SetPriority method to ThreadWrapper"
> Seeing if this is causing roll issues.
>
> > - Add a SetPriority method to ThreadWrapper
> > - Remove 'priority' from CreateThread and related member variables from implementations
> > - Make supplying a name for threads, non-optional
> >
> > BUG=
> > R=magjed@webrtc.org
> >
> > Review URL: https://webrtc-codereview.appspot.com/44729004
>
> TBR=tommi@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/48609004
TBR=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/50459005
Cr-Commit-Position: refs/heads/master@{#8819}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8819 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-22 14:42:46 +00:00
tommi@webrtc.org
90a1cb4630
Revert 8810 "- Add a SetPriority method to ThreadWrapper"
...
Seeing if this is causing roll issues.
> - Add a SetPriority method to ThreadWrapper
> - Remove 'priority' from CreateThread and related member variables from implementations
> - Make supplying a name for threads, non-optional
>
> BUG=
> R=magjed@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/44729004
TBR=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/48609004
Cr-Commit-Position: refs/heads/master@{#8818}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8818 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-22 14:34:46 +00:00
tommi@webrtc.org
b6817d793f
- Add a SetPriority method to ThreadWrapper
...
- Remove 'priority' from CreateThread and related member variables from implementations
- Make supplying a name for threads, non-optional
BUG=
R=magjed@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/44729004
Cr-Commit-Position: refs/heads/master@{#8810}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8810 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-20 15:52:43 +00:00
tommi@webrtc.org
361981faa8
Use scoped_ptr for ThreadWrapper::CreateThread.
...
BUG=
R=henrika@webrtc.org , pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/45799004
Cr-Commit-Position: refs/heads/master@{#8794}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8794 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-19 14:45:42 +00:00
pbos@webrtc.org
86639737b8
Remove thread id from ThreadWrapper::Start().
...
Removes ThreadPosix::InitParams and a corresponding wait for an event.
This unblocks ThreadPosix::Start which had to wait for thread scheduling
for an event to trigger on the spawned thread, giving faster Start()
calls.
BUG=4413
R=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/43699004
Cr-Commit-Position: refs/heads/master@{#8709}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8709 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-13 00:07:45 +00:00
tommi@webrtc.org
5d32f43219
Disable CondVarTest.InitFunctionsWork.
...
The order of Sleep/Wake calls doesn't seem to be guaranteed, so this test
is flaky.
BUG=4262
TBR=bjornv@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/37189004
Cr-Commit-Position: refs/heads/master@{#8247}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8247 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-05 06:26:35 +00:00
tommi@webrtc.org
875c97ed9d
Remove SetNotAlive method from the thread class.
...
Also cleaning up methods with the same name in other classes that are derived from the above method.
R=perkj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/41759004
Cr-Commit-Position: refs/heads/master@{#8242}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8242 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-04 11:12:39 +00:00
bjornv@webrtc.org
dc096f2c7e
system_wrappers: Disabled flaky test CondVarTest.PassBatonMultipleTimes
...
Has been flaky on Win since r8220.
Disabling for now.
BUG=4262
TBR=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/37149004
Cr-Commit-Position: refs/heads/master@{#8240}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8240 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-04 09:14:42 +00:00
andresp@webrtc.org
3c637cdaa5
Clean data races from system_wrappers_unittests.
...
- Remove unittest_utilities that are not used.
- Remove SetLevelFilter that does not seems necessary and anyhow was racy.
BUG=3549
R=henrike@webrtc.org , henrike
Review URL: https://webrtc-codereview.appspot.com/16819004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6617 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-07 20:37:39 +00:00
kjellander@webrtc.org
5ed4f46af1
Remove TSan v2 disabled test in condition_variable_unittest.cc
...
When we rolled our chromium_revision 226126:228675 in r4966
we picked up Clang r191856, which fixes the problem we've
seen earlier in condition_variable_unittest.cc.
Because of this, I'm now re-enabling this test.
TEST=trybots passing
BUG=2259
R=hta@webrtc.org , perkj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2404004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4971 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-16 10:50:41 +00:00
kjellander@webrtc.org
f8c16b8bf4
Disabling CondVarTest for TSan v2 (take 2)
...
This test goes into an eternal loop sometimes when run under
TSan v2, therefore I'm disabling it until this is resolved.
Doing that, the TSan v2 bot in our new WebRTC FYI waterfall at
http://build.chromium.org/p/client.webrtc.fyi/waterfall
will hopefully go green.
The define used only exists for TSan v2, so v1 should be
unaffected.
The suppression added in http://review.webrtc.org/2126005/
turns out actually has no effect, so I'm removing it again.
It's probably useless since TSan v2 obviously alters the code's
behavior, causing these errors. Since the errors are not TSan v2
failures, the suppression has no effect.
BUG=2259
TEST=test passing locally when run as described in 2259 (since
no tests are run).
R=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2115005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4639 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-29 09:47:18 +00:00
pbos@webrtc.org
acaf3a1b13
Include files from webrtc/.. paths in system_wrappers/
...
BUG=1662
R=henrikg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1550004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4111 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-27 15:07:45 +00:00
pbos@webrtc.org
046deb9b20
WebRtc_Word32 -> int32_t in system_wrappers
...
BUG=314
Review URL: https://webrtc-codereview.appspot.com/1301004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3791 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-09 09:06:11 +00:00
andrew@webrtc.org
50419b0777
Add libjingle-style stream-style logging.
...
Add a highly stripped-down version of libjingle's base/logging.h. It is
a thin wrapper around WEBRTC_TRACE, maintaining the libjingle log
semantics to ease a transition to that format.
Also add some helper macros for easy API and function failure logging.
Review URL: https://webrtc-codereview.appspot.com/931010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3099 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-14 19:07:54 +00:00
phoglund@webrtc.org
a36d75a03c
Reformatted condition_variable* in system_wrappers.
...
BUG=
TEST=Ran trybots.
Review URL: https://webrtc-codereview.appspot.com/937017
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3095 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-14 09:55:04 +00:00
andrew@webrtc.org
14b43beb7c
Move src/ -> webrtc/
...
TBR=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/915006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2963 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-22 18:19:23 +00:00