18 Commits

Author SHA1 Message Date
Danil Chapovalov
07633bdc6c Rename rtp_header_extension.h to rtp_header_extension_map.h
Move it to include path of the rtp_rtcp module to indicate it is ok to include it outside of the module.

Renamed to match the class it introduce and to reduce confusion with rtp_header_extensions.h

Bug: webrtc:5565
Change-Id: Ic4b4e9f6b75cb9275e23539cd6e88632c1e7c8d2
Reviewed-on: https://chromium-review.googlesource.com/520947
Reviewed-by: Niels Moller <nisse@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#18402}
2017-06-02 09:11:27 +00:00
eladalon
ae550e397a Correct sequence-number injection into packets in rtp_packet_unittest.cc
BUG=None

Review-Url: https://codereview.webrtc.org/2899293002
Cr-Commit-Position: refs/heads/master@{#18257}
2017-05-24 15:28:13 +00:00
erikvarga
e6b16194c7 Add write support for the RtpStreamId and RepairedRtpStreamId header extensions.
BUG=webrtc:7433

Review-Url: https://codereview.webrtc.org/2871813003
Cr-Commit-Position: refs/heads/master@{#18093}
2017-05-11 09:36:32 +00:00
danilchap
ef8d773d26 Add read support of RtpStreamId/RepairedRtpStreamId header extensions.
BUG=webrtc:7433

Review-Url: https://codereview.webrtc.org/2805023002
Cr-Commit-Position: refs/heads/master@{#17759}
2017-04-19 09:59:48 +00:00
danilchap
c547e84ec5 Allow rtp::Packet::*RawExtension to take 0 as an extension id
BUG=webrtc:7433

Review-Url: https://codereview.webrtc.org/2803623004
Cr-Commit-Position: refs/heads/master@{#17610}
2017-04-10 08:31:49 +00:00
danilchap
978504e25c Move rtp header extension length check from Packet::FindExtension to ExtensionT::Parse
to allow to read variable-length extensions.

BUG=webrtc:7433

Review-Url: https://codereview.webrtc.org/2801733002
Cr-Commit-Position: refs/heads/master@{#17554}
2017-04-06 08:03:53 +00:00
danilchap
653063f6fd Add functions to get/set rtp header extension by id.
This helps with dynamic size extensions.

BUG=webrtc:7433

Review-Url: https://codereview.webrtc.org/2789773004
Cr-Commit-Position: refs/heads/master@{#17505}
2017-04-03 13:16:30 +00:00
danilchap
07a01b3357 Allow RtpPacket::SetPayloadSize to increase payload size
Make SetPayloadSize return buffer to write to so that it can replace
AllocatePayload function.

BUG=None

Review-Url: https://codereview.webrtc.org/2785713002
Cr-Commit-Position: refs/heads/master@{#17450}
2017-03-29 14:33:13 +00:00
danilchap
70f39a30e9 In RtpPacket do not keep pointer to RtpHeaderExtensionMap
Having that dependency require user of RtpPacket to ensure
RtpHeaderExtensionMap always outlive packet and that RtpPacket's access
to RtpHeaderExtensionMap is properly syncrhonized.
Dropping this dependencies make use of RtpPacket less error-prone.

BUG=webrtc:5261

Review-Url: https://codereview.webrtc.org/2576653003
Cr-Commit-Position: refs/heads/master@{#15653}
2016-12-16 13:48:18 +00:00
danilchap
96c1587551 RtpPacket::payload() return rtc::ArrayView instead of raw pointer
BUG=webrtc:5261

Review-Url: https://codereview.webrtc.org/2506373004
Cr-Commit-Position: refs/heads/master@{#15162}
2016-11-21 09:35:33 +00:00
kwiberg
ac9f876bc0 Sort #includes that got unsorted when gmock.h and gtest.h moved to webrtc/test/
gmock.h and gtest.h were moved (or rather, got wrappers so that we
could put some icky compatibility hacks in one place instead of 500)
in this CL: https://codereview.webrtc.org/2358993004/

NOPRESUBMIT=true
BUG=webrtc:6398

Review-Url: https://codereview.webrtc.org/2381013002
Cr-Commit-Position: refs/heads/master@{#14464}
2016-10-01 05:29:53 +00:00
kwiberg
77eab70470 Enable the -Wundef warning for clang
NOPRESUBMIT=true
BUG=webrtc:6398

Review-Url: https://codereview.webrtc.org/2358993004
Cr-Commit-Position: refs/heads/master@{#14425}
2016-09-29 00:42:08 +00:00
Danil Chapovalov
a64a2fbf6d Fix oversized rtp extension parsing.
When size of individual one-byte extension span beyound extension block

BUG=chromium:645201
R=brandtr@webrtc.org

Review URL: https://codereview.webrtc.org/2327743003 .

Cr-Commit-Position: refs/heads/master@{#14183}
2016-09-12 09:41:44 +00:00
Danil Chapovalov
31e4e806b1 RtpPacketHistory rewritten to use RtpPacket class.
RtpSender updated to use new version of RtpPacketHistory.

BUG=webrtc:5261
R=asapersson@webrtc.org

Review URL: https://codereview.webrtc.org/1945773002 .

Cr-Commit-Position: refs/heads/master@{#13626}
2016-08-03 16:27:50 +00:00
danilchap
07ec26d1a9 Fix crash parsing malformed rtp packet
where header extesnsion size mismatch expected.

Reland of https://codereview.webrtc.org/2067793003/

BUG=chromium:620242
R=åsapersson

Review-Url: https://codereview.webrtc.org/2060943009
Cr-Commit-Position: refs/heads/master@{#13187}
2016-06-17 11:18:58 +00:00
danilchap
e565a04de3 Revert of Fix crash parsing malformed rtp packet (patchset #1 id:1 of https://codereview.webrtc.org/2067793003/ )
Reason for revert:
breaks Win64 bots compile

Original issue's description:
> Fix crash parsing malformed rtp packet
> where header extesnsion size mismatch expected.
>
> BUG=chromium:620242
> R=asapersson@webrtc.org
>
> Committed: https://crrev.com/5a45fe6fd7a509fb4c3a9b09cdbd2278055f1d4c
> Cr-Commit-Position: refs/heads/master@{#13170}

TBR=asapersson@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:620242

Review-Url: https://codereview.webrtc.org/2074763002
Cr-Commit-Position: refs/heads/master@{#13171}
2016-06-16 17:04:57 +00:00
Danil Chapovalov
5a45fe6fd7 Fix crash parsing malformed rtp packet
where header extesnsion size mismatch expected.

BUG=chromium:620242
R=asapersson@webrtc.org

Review URL: https://codereview.webrtc.org/2067793003 .

Cr-Commit-Position: refs/heads/master@{#13170}
2016-06-16 16:52:47 +00:00
danilchap
1edb7ab7bd RtpPacket class introduced.
BUG=webrtc:1994, webrtc:5261

Review URL: https://codereview.webrtc.org/1841453004

Cr-Commit-Position: refs/heads/master@{#12444}
2016-04-20 12:25:19 +00:00