admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
17,012 Commits 1 Branch 0 Tags
Commit Graph

11 Commits

Author SHA1 Message Date
nisse
7b3ce5b872 Delete FilesystemInterface::CopyFile. 
Only use of this method was to implement the cross-device case of
MoveFile on unix systems.

In turn, only use of the MoveFile method is in
FileRotatingStream::RotateFiles. Since file rotation should never
involve any copying of log data, the MoveFile fallback to copying can
be deleted.

BUG=webrtc:6424

Review-Url: https://codereview.webrtc.org/2747373003
Cr-Commit-Position: refs/heads/master@{#17364}
 2017-03-23 17:54:16 +00:00
deadbeef
37f5ecfd8f Replace NULL with nullptr or null in webrtc/base/. 
BUG=webrtc:7147

Review-Url: https://codereview.webrtc.org/2718663005
Cr-Commit-Position: refs/heads/master@{#16878}
 2017-02-27 22:06:41 +00:00
nisse
bf25bbdc63 Delete unused Filesystem methods GetAppDataFolder and GetDiskFreeSpace. 
BUG=webrtc:6424

Review-Url: https://codereview.webrtc.org/2699143002
Cr-Commit-Position: refs/heads/master@{#16709}
 2017-02-20 08:37:21 +00:00
nisse
0ebdf2757c Delete or update left-over ASSERT use and comments. 
BUG=webrtc:6424,webrtc:6323

Review-Url: https://codereview.webrtc.org/2647663002
Cr-Commit-Position: refs/heads/master@{#16215}
 2017-01-23 15:43:05 +00:00
nisse
da35f3e3ce Delete unused features of rtc::FilesystemInterface and related classes. 
Deleted methods:

DirectoryIterator::FileSize
DirectoryIterator::IsDots
DirectoryIterator::OlderThan

FilesystemInterface::CleanAppTempFolder
FilesystemInterface::CopyFileOrFolder
FilesystemInterface::CopyFolder
FilesystemInterface::CreatePrivateFile
FilesystemInterface::DeleteFileOrFolder
FilesystemInterface::GetAppPathname
FilesystemInterface::GetCurrentDirectory
FilesystemInterface::MoveFileOrFolder
FilesystemInterface::MoveFolder

Filesystem::CleanAppTempFolder
Filesystem::CopyFolder
Filesystem::CreatePrivateFile
Filesystem::CreateUniqueFile
Filesystem::DeleteEmptyFolder
Filesystem::GetAppPathname
Filesystem::GetCurrentDirectory
Filesystem::MoveFolder

BUG=webrtc:6424

Review-Url: https://codereview.webrtc.org/2445733002
Cr-Commit-Position: refs/heads/master@{#14800}
 2016-10-27 11:44:43 +00:00
erikchen
2ca8d5c430 Remove deprecated FSRef-manipulation methods. 
The replacement methods had already been added to applefilesystem.mm, they just
weren't being used on macOS.

BUG=webrtc:6028

Review-Url: https://codereview.webrtc.org/2395593002
Cr-Commit-Position: refs/heads/master@{#14535}
 2016-10-05 23:04:39 +00:00
Peter Boström
0c4e06b4c6 Use suffixed {uint,int}{8,16,32,64}_t types. 
Removes the use of uint8, etc. in favor of uint8_t.

BUG=webrtc:5024
R=henrik.lundin@webrtc.org, henrikg@webrtc.org, perkj@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, tina.legrand@webrtc.org

Review URL: https://codereview.webrtc.org/1362503003 .

Cr-Commit-Position: refs/heads/master@{#10196}
 2015-10-07 10:23:32 +00:00
kwiberg@webrtc.org
67186fe00c Fix clang style warnings in webrtc/base 
Mostly this consists of marking functions with override when
applicable, and moving function bodies from .h to .cc files.

Not inlining virtual functions with simple bodies such as

  { return false; }

strikes me as probably losing more in readability than we gain in
binary size and compilation time, but I guess it's just like any other
case where enabling a generally good warning forces us to write
slightly worse code in a couple of places.

BUG=163
R=kjellander@webrtc.org, tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/47429004

Cr-Commit-Position: refs/heads/master@{#8656}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8656 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-03-09 22:24:25 +00:00
henrike@webrtc.org
f048872e91 Adds a modified copy of talk/base to webrtc/base. It is the first step in 
migrating talk/base to webrtc/base.

BUG=N/A
R=niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/17479005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6129 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-05-13 18:00:26 +00:00
perkj@webrtc.org
e9a604accd Revert 6107 "Adds a modified copy of talk/base to webrtc/base. I..." 
This breaks Chromium FYI builds and prevent roll of webrtc/libjingle to Chrome.

http://chromegw.corp.google.com/i/chromium.webrtc.fyi/builders/Win%20Builder/builds/457


> Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base.
> 
> BUG=N/A
> R=andrew@webrtc.org, wu@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/12199004

TBR=henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/14479004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6116 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-05-13 08:15:48 +00:00
henrike@webrtc.org
2c7d1b39b9 Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base. 
BUG=N/A
R=andrew@webrtc.org, wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/12199004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6107 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-05-12 18:03:09 +00:00