andrew@webrtc.org
c83a00ad49
Add some VoE and AudioProcessing mocks.
...
Includes a bit of shared helpers in fake_common.h.
Review URL: https://webrtc-codereview.appspot.com/1221004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3722 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-25 21:20:38 +00:00
sjlee@webrtc.org
b4c441a785
Enable the below APIs for iOS.
...
class VoEAudioProcessing
int RegisterRxVadObserver();
int DeRegisterRxVadObserver();
int SetEcMetricsStatus();
int GetEcMetricsStatus()
int GetEchoMetrics();
int GetEcDelayMetrics();
class VoENetEqStats
int GetNetworkStatistics();
class VoEVolumeControl
int SetChannelOutputVolumeScaling();
int GetChannelOutputVolumeScaling();
Review URL: https://webrtc-codereview.appspot.com/1159004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3719 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-25 11:12:20 +00:00
pwestin@webrtc.org
e30823911c
Move the VoE tests to use external transport instead of the built in udp transport
...
Review URL: https://webrtc-codereview.appspot.com/1223006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3708 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-22 16:12:57 +00:00
pwestin@webrtc.org
684f0577fb
Revert r3667 and r3665
...
Review URL: https://webrtc-codereview.appspot.com/1199004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3668 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-13 23:20:57 +00:00
pwestin@webrtc.org
361bac7a4f
Removed the engine API:s related to transport such as SetSendDestination, the functionality is now provided via the test frame work.
...
Review URL: https://webrtc-codereview.appspot.com/1029004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3665 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-13 17:52:42 +00:00
turaj@webrtc.org
b7edd06530
Remove DTMF detection. Talk team has been in the loop and there is no need for
...
DTMF detection at the receiver side.
test=voe_auto_test, VoE extended test DTMF
Review URL: https://webrtc-codereview.appspot.com/1168004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3663 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-12 22:27:27 +00:00
andrew@webrtc.org
a9a1df0035
Remove the error return on SetAGC failure introduced by r3605.
...
BUG=webrtc:1464
Review URL: https://webrtc-codereview.appspot.com/1166005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3616 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-05 23:36:10 +00:00
turaj@webrtc.org
24045c5a02
None of the clients of VoE use SetNetEQBGNMode(), furthermore, NetEq 4 does not provide an API to change the mode of the background noise.
...
bug=issue1370
test=trybots
Review URL: https://webrtc-codereview.appspot.com/1121007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3607 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-05 03:14:22 +00:00
andrew@webrtc.org
f0a90c37c4
Expose the capture-side AudioProcessing object and allow it to be injected.
...
* Clean up the configuration code, including removing most of the weird defines.
* Add a unit test.
Review URL: https://webrtc-codereview.appspot.com/1152005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3605 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-05 01:12:49 +00:00
andrew@webrtc.org
2412085bc1
Don't upsample the capture signal early.
...
* Remove the unneeded _mixingFrequency.
* Rename CheckForSendCodecChanges to better elucidate its function.
* Remove an unnecessary memcpy.
Upsampling should be done late in the chain. This is practically relevant
on mobile, where the capture rate is fixed at 16 kHz. When using Opus, the
signal was upsampled to 32 kHz and was no longer compatible with AECM, which only supports up to 16 kHz.
NEEDS_QA=true
TEST=run calls with a variety of capture device rates and codecs
BUG=chromium:178040,webrtc:1446
Review URL: https://webrtc-codereview.appspot.com/1146004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3594 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-02 00:14:46 +00:00
andrew@webrtc.org
6be1e934ad
Properly error check calls to AudioProcessing.
...
Checks must be made with "!= 0", not "== -1". Additionally:
* Clean up the function calling into AudioProcessing.
* Remove the unused _noiseWarning.
* Make the other warnings bool.
BUG=chromium:178040
Review URL: https://webrtc-codereview.appspot.com/1147004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3590 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-01 18:47:28 +00:00
leozwang@webrtc.org
9ee5a4ccd8
Enable External MediaProcessing on Mobile
...
Bug=None
TEST=trybots
Review URL: https://webrtc-codereview.appspot.com/1133005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3589 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-01 17:19:35 +00:00
tina.legrand@webrtc.org
7a7a008031
Changing non-const reference arguments to pointers, ACM
...
Part of refactoring of ACM, and recent lint-warnings.
This CL changes non-const references in the ACM API to pointers.
BUG=issue1372
Committed: https://code.google.com/p/webrtc/source/detail?r=3543
Review URL: https://webrtc-codereview.appspot.com/1103012
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3555 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-21 10:27:48 +00:00
fischman@webrtc.org
f61e02c81f
Misc cleanups to webrtc/android code:
...
- Replace some deprecated calls/enums with their more modern equivalents.
- Clean up some usage of global data and/or hide it better
- Catch specific exceptions instead of Exception, and log the exception instead
of just its message.
- Random log message cleanups
- Added a build_with_libjingle gyp variable to mimic build_with_chromium for
when webrtc is built as part of a libjingle project but not part of chromium.
BUG=webrtc:1169
TEST=none
Review URL: https://webrtc-codereview.appspot.com/1105010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3554 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-20 23:13:46 +00:00
tina.legrand@webrtc.org
eb7ebf20ed
Revert 3543
...
> Changing non-const reference arguments to pointers, ACM
>
> Part of refactoring of ACM, and recent lint-warnings.
> This CL changes non-const references in the ACM API to pointers.
>
> BUG=issue1372
>
> Review URL: https://webrtc-codereview.appspot.com/1103012
TBR=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1116004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3544 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-20 15:57:31 +00:00
tina.legrand@webrtc.org
374aa49e1a
Changing non-const reference arguments to pointers, ACM
...
Part of refactoring of ACM, and recent lint-warnings.
This CL changes non-const references in the ACM API to pointers.
BUG=issue1372
Review URL: https://webrtc-codereview.appspot.com/1103012
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3543 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-20 15:22:23 +00:00
tommi@webrtc.org
0989fb7bfa
Make VoiceEngineImpl inherit from VoiceEngine.
...
This associates the two types instead of incorrectly reinterpret casting
VoiceEngineImpl* to VoiceEngine* (since these types were previously unrelated).
Please see more details in the bug for how this is currently causing problems
with security tools.
BUG=38612
Review URL: https://webrtc-codereview.appspot.com/1099013
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3520 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-15 15:07:32 +00:00
turaj@webrtc.org
6388c3e2fd
Implement initial delay. This CL allows clients of VoE to set an initial delay. Playout of audio is delayed and the extra playout delay is maintained during the call. While packets are buffered (in NetEq) to acheive the desired delay. ACM will playout silence (zeros). Initial delay has to be set before any packet is pushed into ACM.
...
TEST=ACM unit test is added, also a manual integration test is writen.
Review URL: https://webrtc-codereview.appspot.com/1097009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3506 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-12 21:42:18 +00:00
andrew@webrtc.org
1e7ed7afe9
Use LOG_F interface for unsupported functions.
...
This will provide the function name in the log.
BUG=b/8115521
TESTED=enabled ANDROID_NOT_SUPPORTED on Linux and observed log lines as expected
Review URL: https://webrtc-codereview.appspot.com/1096005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3474 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-05 21:23:39 +00:00
kjellander@webrtc.org
fa53d8717c
Fixing/disabling Windows x64 warnings
...
Disabled MSVC #4267 warnings in common.gypi to enable x64 builds
for Windows.
Fixed MSVC #4267 warnings in test/testsupport.
Added third_party/directxsdk to .gitignore.
With http://review.webrtc.org/1070008 landed, this should make it possible
to build for x64 on Windows.
BUG=1348
TEST=Compiling with http://review.webrtc.org/1070008 applied:
set GYP_DEFINES="target_arch=x64"
set GYP_GENERATORS=ninja
gclient sync
ninja -C out\Debug_x64
Review URL: https://webrtc-codereview.appspot.com/1060008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3464 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-04 10:07:17 +00:00
andrew@webrtc.org
6ed8ebcef9
Fix MaxChannels test; 32 -> 100.
...
TBR=henrika
Review URL: https://webrtc-codereview.appspot.com/1060010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3460 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-02 00:05:58 +00:00
andrew@webrtc.org
4a6f62d4dc
Remove (in practice) the voice engine channel limit.
...
There's really no reason for this limit. I've bumped it to a
practically unreachable ceiling, with a TODO for removing it
entirely.
TBR=henrika
BUG=b/8122300
Review URL: https://webrtc-codereview.appspot.com/1070014
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3459 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-01 23:42:44 +00:00
turaj@webrtc.org
9d532fd275
Fix propagating RED paylaod-type to ACM.
...
BUG=issue1322
TBR=henrika@google.com
Review URL: https://webrtc-codereview.appspot.com/1086005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3449 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-31 18:34:19 +00:00
turaj@webrtc.org
8c8ad85c5d
fix issue 1322, accept -1 as default payload-type for redundant coding (FEC).
...
issue=1322
test=trybot, voe auto-tes
Review URL: https://webrtc-codereview.appspot.com/1043007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3446 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-31 18:20:17 +00:00
henrike@webrtc.org
09738616de
Fixes payload spelling error.
...
BUG=N/A
Review URL: https://webrtc-codereview.appspot.com/1052006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3398 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-22 16:43:45 +00:00
andrew@webrtc.org
ae1a58bba4
Replace AudioFrame's operator= with CopyFrom().
...
Enforce DISALLOW_COPY_AND_ASSIGN to catch offenders.
Review URL: https://webrtc-codereview.appspot.com/1031007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3395 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-22 04:44:30 +00:00
wjia@webrtc.org
a3c82bf667
Remove '<(library)' in gyp files.
...
This will remove all usage of '<(library)' in all webrtc gyp files.
Review URL: https://webrtc-codereview.appspot.com/1049005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3392 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-18 23:42:21 +00:00
niklas.enbom@webrtc.org
218c542c0b
Make VoE handle longer delays
...
Review URL: https://webrtc-codereview.appspot.com/1047004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3385 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-17 22:25:49 +00:00
wjia@webrtc.org
3f9db3735e
Fix android clang build.
...
Android clang build complains about unused private field.
Review URL: https://webrtc-codereview.appspot.com/1025006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3368 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-12 01:09:03 +00:00
andrew@webrtc.org
a5e7e76def
Use %d for signed value in trace.
...
BUG=1259
TBR=henrika
Review URL: https://webrtc-codereview.appspot.com/1028007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3349 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-09 17:11:50 +00:00
andrew@webrtc.org
08d660f08e
Allow for some error in volume testing.
...
BUG=616
TESTED=voe_auto_test:VolumeTest.* now passes on a MacBook
Review URL: https://webrtc-codereview.appspot.com/1028005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3348 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-09 17:07:02 +00:00
phoglund@webrtc.org
d005468e9b
Generalized mechanism for excluding gtests on platforms, disabled broken tests on mac.
...
BUG=1268
TEST=vie_auto_test on mac and linux
TBR=mflodman, kjellander
Review URL: https://webrtc-codereview.appspot.com/1027006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3347 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-09 16:53:42 +00:00
andrew@webrtc.org
1926d33344
Change Sleep() comment in test fixture.
...
TBR=phoglund
Review URL: https://webrtc-codereview.appspot.com/1023006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3335 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-05 03:30:11 +00:00
phoglund@webrtc.org
6f62836ccf
Reverting two mixing test patches: seems to introduce a persistent problem for win voe_auto_test (wrapping problem?)
...
Revert "Further relax thresholds in mixing test."
This reverts commit 53c7e973a02d65e0b4981129e7ccfc145d955eda.
Revert "Fix implicit conversion error in mixing test."
This reverts commit 68d7e2258082d7d2b9461061e03e2f2d6ae78c4f.
TBR=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1018005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3331 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-03 14:33:00 +00:00
andrew@webrtc.org
201d4b61d1
Fix implicit conversion error in mixing test.
...
TBR=mikhal
Review URL: https://webrtc-codereview.appspot.com/1020004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3328 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-02 19:59:53 +00:00
andrew@webrtc.org
b2b628d5cd
Further relax thresholds in mixing test.
...
TBR=mikhal
Review URL: https://webrtc-codereview.appspot.com/1019004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3327 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-02 18:50:13 +00:00
andrew@webrtc.org
00c7c4315b
Replace voice engine utility functions with system wrapper variants.
...
SLEEP -> SleepMs
GET_TIME_IN_MS -> TickTime::MillisecondTimestamp
These could cause unused function errors on some compilers.
BUG=1228
Review URL: https://webrtc-codereview.appspot.com/1013004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3326 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-02 16:06:39 +00:00
phoglund@webrtc.org
1c75918302
Disabled flaky test.
...
From flake in http://webrtc-cb-linux-master.cbf.corp.google.com:8011/builders/LinuxLargeTests/builds/270
Review URL: https://webrtc-codereview.appspot.com/1001004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3293 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-14 10:40:05 +00:00
roosa@google.com
b8ba4d8109
Add number of inserted samples to NetEq statistics.
...
BUG=
Review URL: https://webrtc-codereview.appspot.com/964030
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3289 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-14 00:06:18 +00:00
roosa@google.com
1b60ceb499
Add GetAudioFrame API to VoiceEngine.
...
Allows the caller to pull frames from a channel instead of sending them to the output mixer.
BUG=
Review URL: https://webrtc-codereview.appspot.com/973012
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3273 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-12 23:00:29 +00:00
roosa@google.com
b718619f0a
Expose NetEq playout mode off through VoiceEngine.
...
BUG=
Review URL: https://webrtc-codereview.appspot.com/971016
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3272 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-12 21:59:14 +00:00
roosa@google.com
0870f02cdb
Add API to retreive last received RTP timestamp to VoiceEngine.
...
BUG=
Review URL: https://webrtc-codereview.appspot.com/969016
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3271 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-12 21:31:41 +00:00
turaj@webrtc.org
42259e7ebc
VoE Changes to enable dual_streaming.
...
TEST=added new unit-test
This CL depends on issue 933015 http://webrtc-codereview.appspot.com/933015/
which is under review. Should be committed after issue 933015 is committed.
Committed: https://code.google.com/p/webrtc/source/detail?r=3231
Review URL: https://webrtc-codereview.appspot.com/970005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3257 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-11 02:15:12 +00:00
leozwang@webrtc.org
96bcac8fbb
Expose Set and Get Recording/Playout sample rate apis
...
Message:
This is the first cl to add Set/Get Recording and Playout sample rate apis.
In this cl, apis are enabled but returns -1, will add android
implementation in next cl, it's easy for review and coding.
Description:
This CL expose fours voice engine apis,
SetRecordingSampleRate,
RecordingSampleRate,
SetPlayoutSampleRate,
PlayoutSampleRate.
BUG=none
TEST=trybots
Review URL: https://webrtc-codereview.appspot.com/626004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3239 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-04 19:11:55 +00:00
perkj@webrtc.org
2cf22a6abc
Revert 3231 - VoE Changes to enable dual_streaming.
...
TEST=added new unit-test
This CL depends on issue 933015 http://webrtc-codereview.appspot.com/933015/
which is under review. Should be committed after issue 933015 is committed.
Review URL: https://webrtc-codereview.appspot.com/970005
TBR=turaj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/929040
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3236 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-04 10:02:02 +00:00
turaj@webrtc.org
767d87cf24
VoE Changes to enable dual_streaming.
...
TEST=added new unit-test
This CL depends on issue 933015 http://webrtc-codereview.appspot.com/933015/
which is under review. Should be committed after issue 933015 is committed.
Review URL: https://webrtc-codereview.appspot.com/970005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3231 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-03 22:51:37 +00:00
turaj@webrtc.org
b0dff12d2b
48 kHz extension to iSAC.
...
Test:
-manual test with voe_cmd_test.
-manual test with RTPEncode & NetEqRTPPlay.
-manual test with simpleKenny.
-Bit-exact test of iSAC-swb and iSAC-wb with head revision of trunk. The bit-exactness is confirmed on all files generated by running webrtc/modules/audio_coding/codecs/isac/main/test/QA/runiSACLongtest.txt
Review URL: https://webrtc-codereview.appspot.com/937025
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3226 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-03 17:43:52 +00:00
phoglund@webrtc.org
0f8286fd75
Added last (?) suppressions for known issues.
...
BUG=1152
Review URL: https://webrtc-codereview.appspot.com/933027
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3180 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-28 14:21:12 +00:00
phoglund@webrtc.org
8d334d387b
Disabled flaky test on Linux, added disable-on-platform macros, fixed \n's
...
BUG=1155
Review URL: https://webrtc-codereview.appspot.com/972006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3178 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-28 12:28:06 +00:00
kjellander@webrtc.org
52ec985d82
Fixing vie and voe auto test project paths for test execution.
...
By letting fileutils.h know the path to the executable, the tests will be able to find the project root dir and resource file paths even when the test is executed outside the checkout dir.
See http://review.webrtc.org/858014/ for more background.
Today, these tests are failing in the FYI waterfall since they are run "Chromium style" (i.e. from one level above the checkout dir). Since we're moving in that direction this needs to be fixed. It has been fixed for all other tests already.
TEST=Local test execution of vie_auto_test and voe_auto_test with CWD one level above trunk/
Review URL: https://webrtc-codereview.appspot.com/974004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3173 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-27 10:01:01 +00:00