ivoc
85228d6af6
Regression test for issue where Opus DTX status was being forgotten.
...
BUG=webrtc:6020
Review-Url: https://codereview.webrtc.org/2177263002
Cr-Commit-Position: refs/heads/master@{#13539}
2016-07-27 11:53:52 +00:00
ivoc
14d5dbe5b3
Reland of "Move RtcEventLog object from inside VoiceEngine to Call.", "Fix to make the start/stop functions for the Rtc Eventlog non-virtual." and "Fix for RtcEventLog ObjC interface"
...
The breaking tests in Chromium have been temporarily disabled, they will be fixed and reenabled soon.
Original CLs: https://codereview.webrtc.org/1748403002/ , https://codereview.webrtc.org/2107253002/ and https://codereview.webrtc.org/2106103003/ .
TBR=solenberg@webrtc.org ,tommi@webrtc.org,stefan@webrtc.org,terelius@webrtc.org,tkchin@webrtc.org
BUG=webrtc:4741, webrtc:5603, chromium:609749
Review-Url: https://codereview.webrtc.org/2110113003
Cr-Commit-Position: refs/heads/master@{#13379}
2016-07-04 14:07:03 +00:00
ivoc
9e03c3b372
Revert of Move RtcEventLog object from inside VoiceEngine to Call. (patchset #16 id:420001 of https://codereview.webrtc.org/1748403002/ )
...
Reason for revert:
Reverting all CLs related to moving the eventlog, as they break Chromium tests.
Original issue's description:
> Move RtcEventLog object from inside VoiceEngine to Call.
>
> In addition to moving the logging object itself, this also moves the interface from PeerConnectionFactory to PeerConnection, which makes more sense for this functionality. An API parameter to set an upper limit to the size of the logfile is introduced.
> The old interface on PeerConnectionFactory is not removed in this CL, because it is called from Chrome, it will be removed after Chrome is updated to use the PeerConnection interface.
>
> BUG=webrtc:4741,webrtc:5603,chromium:609749
> R=solenberg@webrtc.org , stefan@webrtc.org , terelius@webrtc.org , tommi@webrtc.org
>
> Committed: https://crrev.com/1895526c6130e3d0e9b154f95079b8eda7567016
> Cr-Commit-Position: refs/heads/master@{#13321}
TBR=solenberg@webrtc.org ,tommi@webrtc.org,stefan@webrtc.org,terelius@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:4741,webrtc:5603,chromium:609749
Review-Url: https://codereview.webrtc.org/2111813002
Cr-Commit-Position: refs/heads/master@{#13340}
2016-06-30 07:59:49 +00:00
Ivo Creusen
1895526c61
Move RtcEventLog object from inside VoiceEngine to Call.
...
In addition to moving the logging object itself, this also moves the interface from PeerConnectionFactory to PeerConnection, which makes more sense for this functionality. An API parameter to set an upper limit to the size of the logfile is introduced.
The old interface on PeerConnectionFactory is not removed in this CL, because it is called from Chrome, it will be removed after Chrome is updated to use the PeerConnection interface.
BUG=webrtc:4741,webrtc:5603,chromium:609749
R=solenberg@webrtc.org , stefan@webrtc.org , terelius@webrtc.org , tommi@webrtc.org
Review URL: https://codereview.webrtc.org/1748403002 .
Cr-Commit-Position: refs/heads/master@{#13321}
2016-06-29 11:57:01 +00:00
kwiberg
12e21a0d6c
Remove dead code (we no longer support SILK)
...
Review URL: https://codereview.webrtc.org/1461043002
Cr-Commit-Position: refs/heads/master@{#10715}
2015-11-19 19:08:35 +00:00
ivoc
b04965ccf8
Hooked up RtcEventLog. It lives in Voice Engine and pointers are propagated to ACM and Call.
...
An option was added to voe_cmd_test to make a RtcEventLog dump.
BUG=webrtc:4741
Review URL: https://codereview.webrtc.org/1267683002
Cr-Commit-Position: refs/heads/master@{#9901}
2015-09-09 07:09:49 +00:00
Jelena Marusic
0d266054ac
VoE: apply new style guide on VoE interfaces and their implementations
...
Changes:
1. Ran clang-format on VoE interfaces and their implementations.
2. Replaced virtual with override in derived classes.
R=henrika@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/49239004
Cr-Commit-Position: refs/heads/master@{#9130}
2015-05-04 12:15:41 +00:00
Ivo Creusen
adf89b7e33
Added SetBitRate function to VoE API to allow changing the audio bitrate.
...
If the requested bitrate is not valid for the codec, the codec will decide on
an appropriate value.
Updated VoE command line tool to use new SetBitRate function.
Includes unittests for SetBitRate function.
BUG=
R=henrik.lundin@webrtc.org , henrika@webrtc.org , kwiberg@webrtc.org , pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/50789004
Cr-Commit-Position: refs/heads/master@{#9115}
2015-04-29 14:03:45 +00:00
minyue@webrtc.org
9b2e1144df
Supporting Opus DTX in Voice Engine.
...
Opus DTX is an Opus specific feature. It does not require WebRTC VAD/DTX, therefore is not set by VoECodec::SetVADStatus(), but rather a dedicated API.
BUG=1014
R=henrika@webrtc.org , pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/43709004
Cr-Commit-Position: refs/heads/master@{#8716}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8716 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-13 09:38:55 +00:00
henrik.lundin@webrtc.org
8315d7de85
Remove dual stream functionality in VoiceEngine
...
This is old code that is no longer in use. The clean-up is part of the
ACM redesign work. The corresponding code in ACM will be deleted in a
follow-up CL.
BUG=3520
R=henrika@webrtc.org , pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/32999004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8060 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-14 16:07:26 +00:00
minyue@webrtc.org
adee8f9242
Renaming SetOpusMaxBandwidth to SetOpusMaxPlaybackRate
...
This is to maintain the consistency with the Opus codec option "maxplaybackrate" defined in http://tools.ietf.org/html/draft-spittka-payload-rtp-opus-03
BUG=
R=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/14279004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7038 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-03 12:28:06 +00:00
minyue@webrtc.org
6aac93bd9c
Adding SetOpusMaxBandwidth in VoE and ACM
...
This is a step to solve
https://code.google.com/p/webrtc/issues/detail?id=1906
In particular, we add an API in VoE and ACM to call Opus's API of setting maximum bandwidth.
TEST = added a test in voe_cmd_test and listened to the result
BUG=
R=henrika@google.com , henrika@webrtc.org , turaj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/21129004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6869 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-12 08:13:33 +00:00
minyue@webrtc.org
c1a40a7b68
This CL is to adding feedback of packet loss rate to encoder in voice engine. A direct reason for doing it is to make use of Opus FEC, which can adapt itself to changes in the packet loss rate.
...
This CL is going to be combined with another CL in ACM, which is to be landed.
TEST=passed_try_bots
BUG=
R=stefan@webrtc.org , xians@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/13449004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6262 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-28 09:52:06 +00:00
henrika@webrtc.org
0f7375504a
Removes VoECodec sub API as part of a clean-up operation where the goal is to remove unused APIs.
...
BUG=3206
R=juberti@webrtc.org , niklas.enbom@webrtc.org , tina.legrand@webrtc.org , turaj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/11789004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5927 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-17 10:38:08 +00:00
pbos@webrtc.org
d900e8bea8
Proper spacing for end-of-namespace comments.
...
BUG=
R=mflodman@webrtc.org , tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1760006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4293 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-03 15:12:26 +00:00
pbos@webrtc.org
956aa7e087
Include files from webrtc/.. paths in voice_engine/
...
BUG=1662
R=henrikg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1434005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4079 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-21 13:52:32 +00:00
turaj@webrtc.org
42259e7ebc
VoE Changes to enable dual_streaming.
...
TEST=added new unit-test
This CL depends on issue 933015 http://webrtc-codereview.appspot.com/933015/
which is under review. Should be committed after issue 933015 is committed.
Committed: https://code.google.com/p/webrtc/source/detail?r=3231
Review URL: https://webrtc-codereview.appspot.com/970005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3257 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-11 02:15:12 +00:00
perkj@webrtc.org
2cf22a6abc
Revert 3231 - VoE Changes to enable dual_streaming.
...
TEST=added new unit-test
This CL depends on issue 933015 http://webrtc-codereview.appspot.com/933015/
which is under review. Should be committed after issue 933015 is committed.
Review URL: https://webrtc-codereview.appspot.com/970005
TBR=turaj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/929040
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3236 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-04 10:02:02 +00:00
turaj@webrtc.org
767d87cf24
VoE Changes to enable dual_streaming.
...
TEST=added new unit-test
This CL depends on issue 933015 http://webrtc-codereview.appspot.com/933015/
which is under review. Should be committed after issue 933015 is committed.
Review URL: https://webrtc-codereview.appspot.com/970005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3231 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-03 22:51:37 +00:00
andrew@webrtc.org
14b43beb7c
Move src/ -> webrtc/
...
TBR=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/915006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2963 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-22 18:19:23 +00:00