admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
38,247 Commits 1 Branch 0 Tags
Commit Graph

236 Commits

Author SHA1 Message Date
Björn Terelius
c044295ab4 Reland "Remove old Nexus perf bots" 
This reverts commit f00483206dc3fc5d9ddc4e8822ecaba1925399ea.

Reason for revert: Attempt to reland

Original change's description:
> Revert "Remove old Nexus perf bots"
>
> This reverts commit ec609b1cdd3ffd15c45445275899cf4010285399.
>
> Reason for revert: Investigate whether the correct builder is used for Pixel devices
>
> Original change's description:
> > Remove old Nexus perf bots
> >
> > Bug: b/236797526
> > Change-Id: I3a3b88fb29ef8a8df074ead975c785a0bfbc84a7
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/287700
> > Reviewed-by: Jeremy Leconte <jleconte@google.com>
> > Commit-Queue: Björn Terelius <terelius@webrtc.org>
> > Cr-Commit-Position: refs/heads/main@{#38895}
>
> Bug: b/236797526
> Change-Id: I3ca98ddc9a336fb91eec48d54a94ddff19038366
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/288240
> Commit-Queue: Björn Terelius <terelius@webrtc.org>
> Auto-Submit: Björn Terelius <terelius@webrtc.org>
> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/main@{#38898}

Bug: b/236797526
Change-Id: I4fc2e1c1f195ce89e61f0767037b418030d94afe
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/288640
Reviewed-by: Andrey Logvin <landrey@webrtc.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Christoffer Jansson <jansson@google.com>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38927}
 2022-12-20 13:34:59 +00:00
Jeremy Leconte
91b62e0e8f Remove global gtest_parallel timeout. 
It is causing flakiness on win asan bots rtc_unittests.
The gtest_parallel timeout is set to 15 minutes but there is already a swarming timeout set to one hour.
https://luci-analysis.appspot.com/p/webrtc/clusters/testname-v3/218550890147469e975d34b17d4c6545#recent-failures
https://luci-analysis.appspot.com/p/webrtc/clusters/testname-v3/968d49e7d00955cc65fa84dfa54b7c2a#recent-failures

There is a comment stating that it's useful because it gets information when the swarming timeout is reached but:
* swarming timeouts are more likely to occur on device phone before impacting desktop bots.
* if a swarming timeout occurs, isolating which tests take too long shouldn't be too hard.

Change-Id: I2089918e8cd266510d58bac8c91d92b6c8e81728
Bug: webrtc:14790
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/288384
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#38918}
 2022-12-19 13:08:42 +00:00
Björn Terelius
f00483206d Revert "Remove old Nexus perf bots" 
This reverts commit ec609b1cdd3ffd15c45445275899cf4010285399.

Reason for revert: Investigate whether the correct builder is used for Pixel devices

Original change's description:
> Remove old Nexus perf bots
>
> Bug: b/236797526
> Change-Id: I3a3b88fb29ef8a8df074ead975c785a0bfbc84a7
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/287700
> Reviewed-by: Jeremy Leconte <jleconte@google.com>
> Commit-Queue: Björn Terelius <terelius@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#38895}

Bug: b/236797526
Change-Id: I3ca98ddc9a336fb91eec48d54a94ddff19038366
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/288240
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Auto-Submit: Björn Terelius <terelius@webrtc.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#38898}
 2022-12-15 12:44:07 +00:00
Björn Terelius
ec609b1cdd Remove old Nexus perf bots 
Bug: b/236797526
Change-Id: I3a3b88fb29ef8a8df074ead975c785a0bfbc84a7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/287700
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38895}
 2022-12-15 09:14:21 +00:00
Björn Terelius
7ff599b753 Only instrument changed lines on coverage bot 
Bug: b/236797073
Change-Id: I2a371a16e0a41597ae4cfa4510b637c5973bbc4d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/287340
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#38872}
 2022-12-12 10:13:49 +00:00
Byoungchan Lee
100de33983 Add instrumented_libraries_release arg to MSAN bots 
Bug: None
Change-Id: I306f63b44cb3ce88b7527d6a5456bddd113e807a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/286761
Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#38835}
 2022-12-07 12:10:49 +00:00
Junji Watanabe
bed6401c23 Add mb configs for CQ reclient shadow builders 
List of shadow builders that I'm going to setup.
- android_arm_rel_reclient
- ios_compile_arm64_rel_reclient
- linux_rel_reclient
- mac_rel_reclient
- win_compile_x64_clang_rel_reclient

Bug: b/243594984
Change-Id: Ic812adab9e4671894a2f19c31b7968b3b461478c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/286521
Auto-Submit: Junji Watanabe <jwata@google.com>
Commit-Queue: Junji Watanabe <jwata@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38816}
 2022-12-06 07:42:30 +00:00
Björn Terelius
737dc4455c Add new linux code coverage bot 
Bug: b/236797073
Change-Id: I7acd8cbe12c1fe7455db337515178e28dffda523
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285940
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38804}
 2022-12-04 14:13:50 +00:00
Jeremy Leconte
c8157c33b4 Add a column_limit=80 to yapf setup.cfg 
Also apply the formatting to the .pyl files.

Change-Id: I5dc668b53570d042862d2de5948b72d1cf6d31b3
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285941
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#38797}
 2022-12-02 13:36:15 +00:00
Jeremy Leconte
9665d01e69 Run tests on Windows CI for Release and Debug configuration. 
Currently the tests are running only on Windows x86 Release.
* Windows capture_tests are moved to run on x64.
* win_x64_clang_dbg_win10 is removed because it's a duplicate of * win_x64_clang_dbg.

Change-Id: Ibf4db1d1749aa31d665ad30825e9dcfef6910be4
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285540
Reviewed-by: Christoffer Jansson <jansson@google.com>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38772}
 2022-11-30 08:31:48 +00:00
Christoffer Jansson
a5e7941a57 Rename Win 7 to Win 10 to reflect whats being benchmarked 
Bug: None
Change-Id: If41eb2d47ee381afba66a9a62e1b7d9481df4efb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285465
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Christoffer Jansson <jansson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38763}
 2022-11-29 15:59:18 +00:00
Christoffer Jansson
c06dc4df80 Add Fuchsia Perf bot 
Bug: b/232740856
Change-Id: I901c283262cc444f835a099a99ee9a6e09d6b759
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285442
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Christoffer Jansson <jansson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38758}
 2022-11-29 13:27:52 +00:00
Jeremy Leconte
c6ae33fb07 Replace dash by underscore in the command line argument before absl flag parsing. 
The expected behavior is to have something similar than python:
https://docs.python.org/dev/library/argparse.html#dest:
"Any internal - characters will be converted to _ characters to make sure the string is a valid attribute name".

This allows to catch chromium arguments like 'isolated-script-test-output' that previously needed some preprocessing done for example in flags_compatibility.py.

This CL also fixes a fuchsia specific issue where the test runner needs a 'isolated-script-test-output' argument but then pass the argument to WebRTC that expects a 'isolated_script_test_output' argument. Thus calling flags_compatibility before the test_runner fails and there is not much room to change the argument in between the test runner and the test.

Change-Id: I48a591743fa50484a0ec584a3f9e97d9e0fd25ef
Bug: webrtc:14694
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284541
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38707}
 2022-11-22 11:03:33 +00:00
Mirko Bonadei
b301b58b3f Rename CI Android testers. 
This makes it easier to update devices in th e future (avoiding multiple
CLs to change names, etc..).

Bug: b/259076774
Change-Id: I20ae940823978fbae84495d266345e4990184130
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283720
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38650}
 2022-11-16 15:38:21 +00:00
Jeremy Leconte
e085366aca Fix some minor issues with the android bots. 
* Use the same logdog_butler as Chromium instead of redefining one.
* Use luci-auth to prevent "local auth - HTTP 400" errors.

Change-Id: I2a0d1393f9f0e1e41b2bcc9a9fec2c50c19675f3
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283520
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#38637}
 2022-11-16 09:09:25 +00:00
Jeremy Leconte
d957836794 Use gtest_parallel for PipeWire tests. 
This CL will also make PipeWire tests retried 3 times in case of failures.

Change-Id: I9c66351f7ee171e29266fe4b8dcd52ca282c8f6d
Bug: webrtc:14644
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/282820
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38595}
 2022-11-09 15:37:58 +00:00
Christoffer Jansson
119fb1910a Add Pixel2 and Pixel5 arm32 perf tester 
Bug: b/257916734
Change-Id: I733e3d451daa47fa25d370f5d2fff7c9b1f5b8db
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/282560
Commit-Queue: Christoffer Jansson <jansson@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#38584}
 2022-11-08 12:44:18 +00:00
Christoffer Jansson
ddae5e6fae Add Pixel5 perf config 
Bug: b/257916734
Change-Id: I7a9fc7db85cf7742b7de0ce4c2dc4d25548050f2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/282220
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Christoffer Jansson <jansson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38566}
 2022-11-07 15:50:51 +00:00
Junji Watanabe
1d490cb4bf [infra] Fix debug_bot_arm to have use_goma=true 
Linux Debug (ARM) builder is still using Goma.
https://ci.chromium.org/ui/p/webrtc/builders/ci/Linux32%20Debug%20(ARM)/18995/overview

`Override MB config to use reclient` step fails to replace use_goma=true with use_remoteexec=true because there is no use_goma=true in this builder's mb config.

I don't know why the builder uses Goma without use_goma=true.
But, maybe this is due to the default setting or some recipe logic.

Bug: b:239908030
Change-Id: Iabf0c857144769e842c5f4080fe01339841d8c0c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/281820
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Auto-Submit: Junji Watanabe <jwata@google.com>
Commit-Queue: Junji Watanabe <jwata@google.com>
Cr-Commit-Position: refs/heads/main@{#38550}
 2022-11-04 08:01:31 +00:00
Junji Watanabe
4349137885 [infra] Remove reclient shadow builders for CI 
Keeping shadow builders may cause worker pool saturation.

Bug: b:239908030
Change-Id: I5c0272c7a1772df143290cbaa2083c93a4c96c52
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/280320
Auto-Submit: Junji Watanabe <jwata@google.com>
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Commit-Queue: Christoffer Jansson <jansson@webrtc.org>
Reviewed-by: Christoffer Jansson <jansson@google.com>
Reviewed-by: Takuto Ikuta <tikuta@google.com>
Cr-Commit-Position: refs/heads/main@{#38462}
 2022-10-25 07:56:06 +00:00
Jeremy Leconte
f30bf5b746 Add flags_compatibility script for fuchsia bots. 
Change-Id: Ic57f23e16945f83027d9152a70943f43a2282dfd
Bug: b/232740856
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/277222
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#38277}
 2022-10-03 14:05:29 +00:00
Christoffer Jansson
fb409c975f Do not use gtest_parallell for fuchsia 
Bug: b/232740856
Change-Id: If1191c1e90b7eb18acd8e393f3927ddee4b92b34
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/277181
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Christoffer Jansson <jansson@google.com>
Cr-Commit-Position: refs/heads/main@{#38234}
 2022-09-28 12:31:14 +00:00
Junji Watanabe
5ff51ee283 Migrate Linux64 Release (Libfuzzer) to use reclient 
All CI builders on Linux with standlone.py recipe have already been migrated to reclient.
This is the only remaining Linux builder with libfuzzer.py recipe.

Test:
[pass] https://ci.chromium.org/swarming/task/5d4962978d596a10

Bug: b/239908030
Change-Id: I861ded5672f2296f61d42b1f4678cd5602d50030
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/275061
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Auto-Submit: Junji Watanabe <jwata@google.com>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Takuto Ikuta <tikuta@google.com>
Cr-Commit-Position: refs/heads/main@{#38057}
 2022-09-12 07:52:59 +00:00
Christoffer Jansson
7fc45e1701 Use target_os="fuchsia" 
Bug: b/232740856
Change-Id: I1e8a204cff0a256ba5aeba9b3077d314b6fe105e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/274408
Commit-Queue: Christoffer Jansson <jansson@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38030}
 2022-09-07 15:09:25 +00:00
Christoffer Jansson
a45a7cbc0d Add fuchsia bot 
No-Try: true
Bug: b/232740856
Change-Id: I5b4c9b41395466e68e00a7e63fffb26eb31d8313
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/274401
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Christoffer Jansson <jansson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38028}
 2022-09-07 12:44:00 +00:00
Junji Watanabe
808b951ab9 Migrate Andorid32 (M Nexus5X) builder to use reclient 
We have already confirmed that reclient has better performance for Android builds.

Bug: b/239908030
Change-Id: I6a83f48a6b4f6024053a0f60c6650d5d931f40d3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/274420
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Auto-Submit: Junji Watanabe <jwata@google.com>
Reviewed-by: Takuto Ikuta <tikuta@google.com>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38024}
 2022-09-07 07:21:22 +00:00
Junji Watanabe
cb6154346a Migrate Linux64 Release builder to use recilent 
The reclient shadow builder already shows better performance than goma builds.

Bug: b/239908030
Change-Id: Idf6488a45beedbd6ef63fca10ddb8ae3a8ef98de
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/274201
Reviewed-by: Takuto Ikuta <tikuta@google.com>
Commit-Queue: Junji Watanabe <jwata@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38023}
 2022-09-07 03:28:22 +00:00
Junji Watanabe
4680f3370d Add reclient shadow builders to mb_config.pyl 
Bug: b:243628179
Change-Id: Ic1b1e42f9c11ba049addaca42cf7fa8a98cbd87a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/273124
Auto-Submit: Junji Watanabe <jwata@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Junji Watanabe <jwata@google.com>
Cr-Commit-Position: refs/heads/main@{#37917}
 2022-08-26 13:25:29 +00:00
Junji Watanabe
5800f36632 Add mb_config for Linux64 Release (reclient) builder 
Bug: b/243628179
Change-Id: I2072261fe87d83979044f6b95b6635a0d993f39e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/272864
Auto-Submit: Junji Watanabe <jwata@google.com>
Reviewed-by: Takuto Ikuta <tikuta@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37898}
 2022-08-25 06:52:42 +00:00
Jeremy Leconte
3d38cd3c41 Migrate mb script to python3. 
Change-Id: Ief72dd7f9c5ca65c6ce67d1784c6d8321554a07a
Bug: b/216091827
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/271294
Reviewed-by: Evan Shrubsole <eshr@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#37809}
 2022-08-17 13:50:43 +00:00
Jeremy Leconte
35fc144e01 Rename 'iOS64 Sim Debug (iOS 14.0)' bot. 
Change-Id: I83bb0dfd0edcc199c2e44d2627bb6945514a6c84
Bug: b/228171822
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264941
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37104}
 2022-06-03 07:17:27 +00:00
Christoffer Jansson
353d5b243a Remove crosscompile for Perf Mac M1 Arm64 12 
Since the Perf tester is actually compiling histogram code, it needs
to have it's own native OS gclient and GN config. The Builder has already
built and cached the MacOS arm64 binaries to be tested for M1.

I got confused and thought the tester was also compiling something for
the bot it shards to.

Bug: b/232347569
Change-Id: I0468945a04905d2d647626229af77c00d1f632fd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/263200
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Christoffer Jansson <jansson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36969}
 2022-05-23 09:54:48 +00:00
Christoffer Jansson
bf2d75d86f Add specific mac arm64 mb config 
Trying to solve https://ci.chromium.org/ui/p/webrtc/builders/perf/Perf%20Mac%20M1%20Arm64%2012/1/overview

Bug: b/230719743
Change-Id: I43e0206548fe6223552909a23748e3eea678e2a9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261902
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Christoffer Jansson <jansson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36837}
 2022-05-10 13:08:31 +00:00
Christoffer Jansson
598044f9ee Add M1 perf bot 
Companion CL: https://chromium-review.googlesource.com/c/chromium/tools/build/+/3634362

Bug: b/230719743
Change-Id: I52babb62dddbcadeb2854720c3c022ee3e04dbec
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260321
Commit-Queue: Christoffer Jansson <jansson@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36829}
 2022-05-10 08:10:20 +00:00
Jeremy Leconte
4ef2de6290 Remove the iOS internal try bots. 
Bug: b/230708129
Change-Id: Ic4315997af0c01c5f5d987d13d88ada7d76ab0ea
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260191
Reviewed-by: Mirko Bonadei <mbonadei@google.com>
Commit-Queue: Jeremy Leconte <jleconte@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36770}
 2022-05-05 07:20:49 +00:00
Jeremy Leconte
55c55c3c43 Reorder mb_config.pyl to fix 'mb.py validate' 
This is a follow up of this CL: https://crrev.com/c/3611486.

Bug: b/231404336
Change-Id: I3b6f4b780aa1939b6b2d0f1d08d1746a3a6f86dc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261080
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36752}
 2022-05-04 08:31:29 +00:00
Christoffer Jansson
b45d4deb3b Rename MacOS perf bot to 11 to reflect OS version 
Bug: b/227442116
Change-Id: I80cf745a3a38d08c833864d2f8e4533776be2585
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260460
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Christoffer Jansson <jansson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36702}
 2022-04-29 09:24:13 +00:00
Jeremy Leconte
7c94291c58 Remove reference to //base in mb_unittest.py 
Also remove tests in //tools_webrtc/mb/mb_unittest.py that are testing exclusively code in //tools/mb/mb.py.

Bug: webrtc:13662
Change-Id: Ifdfbe26c11f7c315e307856b1d3ab06483d57641
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260041
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36651}
 2022-04-26 07:44:44 +00:00
Jeremy Leconte
e288161529 Don't use windows path in mb.py 
Swarming Windows bots translate the path to Windows path.
https://chromium-swarm.appspot.com/task?id=5a5a3b202f930010

Bug: webrtc:13475
Change-Id: I21589e67057174651d467f4f78e33bdd21a4e1c5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259302
Reviewed-by: Christoffer Jansson <jansson@google.com>
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36571}
 2022-04-19 12:24:26 +00:00
Jeremy Leconte
424cc65a4a Centralized test command argument in .pyl configuration. 
* Remove args from gn_isolate_map.pyl
* Set idempotent to false for performance tests

Bug: webrtc:13899
Change-Id: Icde80af02070e024c1292721db9c0b8a4d906343
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/258685
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36531}
 2022-04-12 10:43:05 +00:00
Jeremy Leconte
f5fd25ca04 Remove duplicate gn_isolate_map.pyl 
The other one is in the //infra/specs folder.

Bug: webrtc:13899
Change-Id: Idbf3c888b60741aa8a35d25bd3b7deb4f1a81a95
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/258682
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36525}
 2022-04-11 15:53:08 +00:00
Jeremy Leconte
ac5cf78801 Add mb.py to pylint check of the root PRESUBMIT.py. 
This now possible because of https://webrtc-review.googlesource.com/c/src/+/256972

Bug: webrtc:13605
Change-Id: Ie5c058c5ff459dde05c90f757a1df8bd53f35ccc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257281
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Christoffer Jansson <jansson@google.com>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36390}
 2022-03-31 10:24:02 +00:00
Jeremy Leconte
81635f33ef Make tools_webrtc/mb inherit from tools/mb (3rd attempt). 
Previous attempts:
https://webrtc-review.googlesource.com/c/src/+/256809
https://webrtc-review.googlesource.com/c/src/+/256970

Bug: webrtc:13867
Change-Id: I5dc268b711dc17016a5d673f2b3ec733c9cff4f2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256972
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36367}
 2022-03-29 12:07:30 +00:00
Jeremy Leconte
bddfa1d9de Prepare the code to inherit from chromium's mb.py (3rd attempt). 
Basically try to make low_bandwidth_audio_perf_test target work with chromium's mb.

Bug: webrtc:13867
Change-Id: If111e2b0f4f82935062d6321f4d16cc72c77d572
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256975
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36364}
 2022-03-29 10:11:51 +00:00
Jeremy Leconte
137173c296 Revert "Reland "Make tools_webrtc/mb inherit from tools/mb."" 
This reverts commit aa0d4061ba1d65bfbd562c6a173440911c0357d8.

Reason for revert: All green except for the android bots compiling low_bandwidth_audio_perf_test.
https://ci.chromium.org/ui/p/webrtc/builders/ci/Android32%20Builder%20arm/12133/overview

Original change's description:
> Reland "Make tools_webrtc/mb inherit from tools/mb."
>
> This is a reland of commit 7a324b977c5ab6f9b88bcce3353feade943ccefe
>
> Original change's description:
> > Make tools_webrtc/mb inherit from tools/mb.
> >
> > Bug: webrtc:13867
> > Change-Id: I33e998d260454d16120b09fedecf0c25d2654611
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256809
> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> > Commit-Queue: Jeremy Leconte <jleconte@google.com>
> > Cr-Commit-Position: refs/heads/main@{#36347}
>
> Bug: webrtc:13867
> Change-Id: I8fe4424771876ea725f5c9a3c5d13b2f6ad83917
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256970
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Commit-Queue: Jeremy Leconte <jleconte@google.com>
> Cr-Commit-Position: refs/heads/main@{#36361}

Bug: webrtc:13867
Change-Id: I69948eb028a57b915feba1037e71e82e2d8bc7c7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256971
Auto-Submit: Jeremy Leconte <jleconte@google.com>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36362}
 2022-03-29 07:14:04 +00:00
Jeremy Leconte
aa0d4061ba Reland "Make tools_webrtc/mb inherit from tools/mb." 
This is a reland of commit 7a324b977c5ab6f9b88bcce3353feade943ccefe

Original change's description:
> Make tools_webrtc/mb inherit from tools/mb.
>
> Bug: webrtc:13867
> Change-Id: I33e998d260454d16120b09fedecf0c25d2654611
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256809
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Commit-Queue: Jeremy Leconte <jleconte@google.com>
> Cr-Commit-Position: refs/heads/main@{#36347}

Bug: webrtc:13867
Change-Id: I8fe4424771876ea725f5c9a3c5d13b2f6ad83917
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256970
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36361}
 2022-03-29 07:02:40 +00:00
Jeremy Leconte
145ff4cc45 Prepare the code to inherit from chromium's mb.py. 
* Don't use 'script' type because it's breaking mb gen.
* Simplify 'raw' type command generation.

Bug: webrtc:13867
Change-Id: I68486c5010c84e41297daafdf11ab63bbca58d4b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256862
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36351}
 2022-03-28 09:52:30 +00:00
Jeremy Leconte
ad3f490946 Revert "Make tools_webrtc/mb inherit from tools/mb." 
This reverts commit 7a324b977c5ab6f9b88bcce3353feade943ccefe.

Reason for revert: Some failures like this one:
https://ci.chromium.org/p/webrtc/builders/ci/Linux64%20Builder/12121

Original change's description:
> Make tools_webrtc/mb inherit from tools/mb.
>
> Bug: webrtc:13867
> Change-Id: I33e998d260454d16120b09fedecf0c25d2654611
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256809
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Commit-Queue: Jeremy Leconte <jleconte@google.com>
> Cr-Commit-Position: refs/heads/main@{#36347}

Bug: webrtc:13867
Change-Id: If11473f31c8c5f365018f464b413220b2730ee7a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256960
Auto-Submit: Jeremy Leconte <jleconte@google.com>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36348}
 2022-03-28 07:22:50 +00:00
Jeremy Leconte
7a324b977c Make tools_webrtc/mb inherit from tools/mb. 
Bug: webrtc:13867
Change-Id: I33e998d260454d16120b09fedecf0c25d2654611
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256809
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36347}
 2022-03-28 07:10:00 +00:00
Jeremy Leconte
d8654cf636 Prepare the code to inherit from chromium's mb.py. 
Type 'additional_compile_target' are not meant to be tests.
Type 'raw' has no usage for xctests.
Explicitly set dcheck_always_on=false.

Bug: webrtc:13867
Change-Id: Ie47c300609ff5054d36110e8ee6c7a059ec452da
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256805
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36336}
 2022-03-25 13:01:24 +00:00