andersc
151aa6b3f7
Adjust for initial cropping when adapting frame.
...
When adapting a frame, any initial cropping coordinate was replaced
by the coordinate calculated for adapting. Offset initial coordinate
instead.
BUG=webrtc:7880
Review-Url: https://codereview.webrtc.org/2975613002
Cr-Commit-Position: refs/heads/master@{#19509}
2017-08-25 08:33:18 +00:00
VladimirTechMan
26afe214ad
Properly export the symbols of video frame-buffer classes for link-time
...
Linking external ObjC / Swift apps fails when the app code is using any
of the new frame-buffer classes RTCI420Buffer, RTCMutableI420Buffer, or
RTCCVPixelBuffer. To fix, we need to add the appropriate attribute to
the classes (e.g. using the RTC_EXPORT macro).
BUG=None
Review-Url: https://codereview.webrtc.org/2961293002
Cr-Commit-Position: refs/heads/master@{#18840}
2017-06-29 16:11:10 +00:00
Anders Carlsson
e5960ce737
Revert "Revert "Revert "Revert "Support more formats in RTCVideoFrame""""
...
This reverts commit 1cfeb435427a2fa677a495e34c882096efc193d0.
Reason for revert: Fix unit test
Original change's description:
> Revert "Revert "Revert "Support more formats in RTCVideoFrame"""
>
> This reverts commit 7583390d1a3a7c4e9a77da0d77250abac0c34d1d.
>
> Reason for revert: Breaks unit tests
>
> Original change's description:
> > Revert "Revert "Support more formats in RTCVideoFrame""
> >
> > This reverts commit 0789dab2cbd1617e94d7300e375163d42345f3d4.
> >
> > Reason for revert: Include obc_corevideoframebuffer target
> >
> > Original change's description:
> > > Revert "Support more formats in RTCVideoFrame"
> > >
> > > This reverts commit bd2220a9c496ef2e8567b68d4be9435a110bdc34.
> > >
> > > Reason for revert: Broke external clients
> > >
> > > Original change's description:
> > > > Support more formats in RTCVideoFrame
> > > >
> > > > Implement Obj-C version of webrtc::VideoFrameBuffer and use that in
> > > > RTCVideoFrame.
> > > >
> > > > Bug: webrtc:7785
> > > > Change-Id: I49f42bcf451dd6769b3a79a65fe7b400dce22677
> > > > Reviewed-on: https://chromium-review.googlesource.com/536773
> > > > Commit-Queue: Anders Carlsson <andersc@webrtc.org>
> > > > Reviewed-by: Magnus Jedvert <magjed@webrtc.org>
> > > > Cr-Commit-Position: refs/heads/master@{#18691}
> > >
> > > TBR=magjed@webrtc.org ,andersc@webrtc.org
> > >
> > > Change-Id: Id765dd9543ed0613a6b2de108b268c3501025fcd
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: webrtc:7785
> > > Reviewed-on: https://chromium-review.googlesource.com/542837
> > > Reviewed-by: Anders Carlsson <andersc@webrtc.org>
> > > Commit-Queue: Anders Carlsson <andersc@webrtc.org>
> > > Cr-Commit-Position: refs/heads/master@{#18697}
> >
> > TBR=magjed@webrtc.org ,andersc@webrtc.org
> >
> > Change-Id: I1ef5313b4a6c56eb8c7fd02d95db62c4e3c00255
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: webrtc:7785
> > Reviewed-on: https://chromium-review.googlesource.com/542838
> > Commit-Queue: Anders Carlsson <andersc@webrtc.org>
> > Reviewed-by: Anders Carlsson <andersc@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#18716}
>
> TBR=magjed@webrtc.org ,andersc@webrtc.org
>
> Change-Id: Id12f33698eb02041607cb9a5c54f37f01bfac5b1
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:7785
> Reviewed-on: https://chromium-review.googlesource.com/544840
> Reviewed-by: Anders Carlsson <andersc@webrtc.org>
> Commit-Queue: Anders Carlsson <andersc@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#18718}
TBR=magjed@webrtc.org ,andersc@webrtc.org
Change-Id: I184303ecba8db91ef7de709f982a295a2efe92eb
Bug: webrtc:7785
Reviewed-on: https://chromium-review.googlesource.com/544841
Commit-Queue: Magnus Jedvert <magjed@webrtc.org>
Reviewed-by: Anders Carlsson <andersc@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#18731}
2017-06-23 10:59:41 +00:00
Anders Carlsson
1cfeb43542
Revert "Revert "Revert "Support more formats in RTCVideoFrame"""
...
This reverts commit 7583390d1a3a7c4e9a77da0d77250abac0c34d1d.
Reason for revert: Breaks unit tests
Original change's description:
> Revert "Revert "Support more formats in RTCVideoFrame""
>
> This reverts commit 0789dab2cbd1617e94d7300e375163d42345f3d4.
>
> Reason for revert: Include obc_corevideoframebuffer target
>
> Original change's description:
> > Revert "Support more formats in RTCVideoFrame"
> >
> > This reverts commit bd2220a9c496ef2e8567b68d4be9435a110bdc34.
> >
> > Reason for revert: Broke external clients
> >
> > Original change's description:
> > > Support more formats in RTCVideoFrame
> > >
> > > Implement Obj-C version of webrtc::VideoFrameBuffer and use that in
> > > RTCVideoFrame.
> > >
> > > Bug: webrtc:7785
> > > Change-Id: I49f42bcf451dd6769b3a79a65fe7b400dce22677
> > > Reviewed-on: https://chromium-review.googlesource.com/536773
> > > Commit-Queue: Anders Carlsson <andersc@webrtc.org>
> > > Reviewed-by: Magnus Jedvert <magjed@webrtc.org>
> > > Cr-Commit-Position: refs/heads/master@{#18691}
> >
> > TBR=magjed@webrtc.org ,andersc@webrtc.org
> >
> > Change-Id: Id765dd9543ed0613a6b2de108b268c3501025fcd
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: webrtc:7785
> > Reviewed-on: https://chromium-review.googlesource.com/542837
> > Reviewed-by: Anders Carlsson <andersc@webrtc.org>
> > Commit-Queue: Anders Carlsson <andersc@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#18697}
>
> TBR=magjed@webrtc.org ,andersc@webrtc.org
>
> Change-Id: I1ef5313b4a6c56eb8c7fd02d95db62c4e3c00255
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:7785
> Reviewed-on: https://chromium-review.googlesource.com/542838
> Commit-Queue: Anders Carlsson <andersc@webrtc.org>
> Reviewed-by: Anders Carlsson <andersc@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#18716}
TBR=magjed@webrtc.org ,andersc@webrtc.org
Change-Id: Id12f33698eb02041607cb9a5c54f37f01bfac5b1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:7785
Reviewed-on: https://chromium-review.googlesource.com/544840
Reviewed-by: Anders Carlsson <andersc@webrtc.org>
Commit-Queue: Anders Carlsson <andersc@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#18718}
2017-06-22 13:06:45 +00:00
Anders Carlsson
7583390d1a
Revert "Revert "Support more formats in RTCVideoFrame""
...
This reverts commit 0789dab2cbd1617e94d7300e375163d42345f3d4.
Reason for revert: Include obc_corevideoframebuffer target
Original change's description:
> Revert "Support more formats in RTCVideoFrame"
>
> This reverts commit bd2220a9c496ef2e8567b68d4be9435a110bdc34.
>
> Reason for revert: Broke external clients
>
> Original change's description:
> > Support more formats in RTCVideoFrame
> >
> > Implement Obj-C version of webrtc::VideoFrameBuffer and use that in
> > RTCVideoFrame.
> >
> > Bug: webrtc:7785
> > Change-Id: I49f42bcf451dd6769b3a79a65fe7b400dce22677
> > Reviewed-on: https://chromium-review.googlesource.com/536773
> > Commit-Queue: Anders Carlsson <andersc@webrtc.org>
> > Reviewed-by: Magnus Jedvert <magjed@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#18691}
>
> TBR=magjed@webrtc.org ,andersc@webrtc.org
>
> Change-Id: Id765dd9543ed0613a6b2de108b268c3501025fcd
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:7785
> Reviewed-on: https://chromium-review.googlesource.com/542837
> Reviewed-by: Anders Carlsson <andersc@webrtc.org>
> Commit-Queue: Anders Carlsson <andersc@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#18697}
TBR=magjed@webrtc.org ,andersc@webrtc.org
Change-Id: I1ef5313b4a6c56eb8c7fd02d95db62c4e3c00255
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:7785
Reviewed-on: https://chromium-review.googlesource.com/542838
Commit-Queue: Anders Carlsson <andersc@webrtc.org>
Reviewed-by: Anders Carlsson <andersc@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#18716}
2017-06-22 12:23:03 +00:00
Anders Carlsson
0789dab2cb
Revert "Support more formats in RTCVideoFrame"
...
This reverts commit bd2220a9c496ef2e8567b68d4be9435a110bdc34.
Reason for revert: Broke external clients
Original change's description:
> Support more formats in RTCVideoFrame
>
> Implement Obj-C version of webrtc::VideoFrameBuffer and use that in
> RTCVideoFrame.
>
> Bug: webrtc:7785
> Change-Id: I49f42bcf451dd6769b3a79a65fe7b400dce22677
> Reviewed-on: https://chromium-review.googlesource.com/536773
> Commit-Queue: Anders Carlsson <andersc@webrtc.org>
> Reviewed-by: Magnus Jedvert <magjed@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#18691}
TBR=magjed@webrtc.org ,andersc@webrtc.org
Change-Id: Id765dd9543ed0613a6b2de108b268c3501025fcd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:7785
Reviewed-on: https://chromium-review.googlesource.com/542837
Reviewed-by: Anders Carlsson <andersc@webrtc.org>
Commit-Queue: Anders Carlsson <andersc@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#18697}
2017-06-21 08:41:37 +00:00
Anders Carlsson
bd2220a9c4
Support more formats in RTCVideoFrame
...
Implement Obj-C version of webrtc::VideoFrameBuffer and use that in
RTCVideoFrame.
Bug: webrtc:7785
Change-Id: I49f42bcf451dd6769b3a79a65fe7b400dce22677
Reviewed-on: https://chromium-review.googlesource.com/536773
Commit-Queue: Anders Carlsson <andersc@webrtc.org>
Reviewed-by: Magnus Jedvert <magjed@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#18691}
2017-06-21 06:30:23 +00:00