deadbeef
|
37f5ecfd8f
|
Replace NULL with nullptr or null in webrtc/base/.
BUG=webrtc:7147
Review-Url: https://codereview.webrtc.org/2718663005
Cr-Commit-Position: refs/heads/master@{#16878}
|
2017-02-27 22:06:41 +00:00 |
|
danilchap
|
b7b9dca4e4
|
Reland Enable socketservers unittests on windows.
Original CL: https://codereview.webrtc.org/2199193004/
Revert CL: https://codereview.webrtc.org/2209333002/
NOTRY=true
BUG=webrtc:6167,webrtc:6178
Review-Url: https://codereview.webrtc.org/2218853002
Cr-Commit-Position: refs/heads/master@{#13654}
|
2016-08-05 12:55:49 +00:00 |
|
ehmaldonado
|
9f1771b729
|
Revert of Enable socketservers unittests on windows (patchset #7 id:260001 of https://codereview.webrtc.org/2199193004/ )
Reason for revert:
Win64 Debug seems to be broken because of this CL.
https://build.chromium.org/p/client.webrtc/builders/Win64%20Debug
The Win32SocketTest.TestGetSetOptionsIPv4 test is failing with
[ RUN ] Win32SocketTest.TestGetSetOptionsIPv4
(win32socketserver.cc:299): GetRemoteAddress: unable to get remote addr, socket=672
(winping.cc:262): IcmpSendEcho(, 65507): 0
Full logs at
https://build.chromium.org/p/client.webrtc/builders/Win64%20Debug/builds/8444/steps/webrtc_nonparallel_tests/logs/stdio
I filed a bug at https://bugs.chromium.org/p/webrtc/issues/detail?id=6178
Original issue's description:
> Enable socketservers unittests on windows.
> failing tests disabling moved to ifdefs within the test files from build files.
>
> R=tommi@webrtc.org
>
> Committed: https://crrev.com/e51e11910faddb00921a8bb274f0d9374d55011f
> Cr-Commit-Position: refs/heads/master@{#13623}
TBR=tommi@webrtc.org,danilchap@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
Review-Url: https://codereview.webrtc.org/2209333002
Cr-Commit-Position: refs/heads/master@{#13642}
|
2016-08-04 16:18:18 +00:00 |
|
Danil Chapovalov
|
e51e11910f
|
Enable socketservers unittests on windows.
failing tests disabling moved to ifdefs within the test files from build files.
R=tommi@webrtc.org
Review URL: https://codereview.webrtc.org/2199193004 .
Cr-Commit-Position: refs/heads/master@{#13623}
|
2016-08-03 13:14:48 +00:00 |
|
Peter Boström
|
0c4e06b4c6
|
Use suffixed {uint,int}{8,16,32,64}_t types.
Removes the use of uint8, etc. in favor of uint8_t.
BUG=webrtc:5024
R=henrik.lundin@webrtc.org, henrikg@webrtc.org, perkj@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, tina.legrand@webrtc.org
Review URL: https://codereview.webrtc.org/1362503003 .
Cr-Commit-Position: refs/heads/master@{#10196}
|
2015-10-07 10:23:32 +00:00 |
|
henrike@webrtc.org
|
f048872e91
|
Adds a modified copy of talk/base to webrtc/base. It is the first step in
migrating talk/base to webrtc/base.
BUG=N/A
R=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/17479005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6129 4adac7df-926f-26a2-2b94-8c16560cd09d
|
2014-05-13 18:00:26 +00:00 |
|
perkj@webrtc.org
|
e9a604accd
|
Revert 6107 "Adds a modified copy of talk/base to webrtc/base. I..."
This breaks Chromium FYI builds and prevent roll of webrtc/libjingle to Chrome.
http://chromegw.corp.google.com/i/chromium.webrtc.fyi/builders/Win%20Builder/builds/457
> Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base.
>
> BUG=N/A
> R=andrew@webrtc.org, wu@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/12199004
TBR=henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/14479004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6116 4adac7df-926f-26a2-2b94-8c16560cd09d
|
2014-05-13 08:15:48 +00:00 |
|
henrike@webrtc.org
|
2c7d1b39b9
|
Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base.
BUG=N/A
R=andrew@webrtc.org, wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/12199004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6107 4adac7df-926f-26a2-2b94-8c16560cd09d
|
2014-05-12 18:03:09 +00:00 |
|