25 Commits

Author SHA1 Message Date
Peter Boström
1d1944187f Replace RefCountImpl with rtc::RefCountedObject.
Removes code duplication and use of the dangerous public destructor in
RefCountImpl.

Also making wider use of scoped_refptr and fixing various leaks in the
process.

BUG=webrtc:5229
R=tommi@webrtc.org

Review URL: https://codereview.webrtc.org/1477013005 .

Cr-Commit-Position: refs/heads/master@{#12075}
2016-03-21 15:44:41 +00:00
Henrik Kjellander
5dda80abea Remove webrtc/modules/video_{capture,render}/include
BUG=webrtc:5095
TESTED=git cl try -c --bot=android_compile_rel --bot=linux_compile_rel --bot=win_compile_rel --bot=mac_compile_rel --bot=ios_rel --bot=linux_gn_rel --bot=win_x64_gn_rel --bot=mac_x64_gn_rel --bot=android_gn_rel -m tryserver.webrtc
R=pbos@webrtc.org, perkj@webrtc.org

Review URL: https://codereview.webrtc.org/1439823002 .

Cr-Commit-Position: refs/heads/master@{#10619}
2015-11-12 11:47:02 +00:00
Henrik Kjellander
98f53510b2 system_wrappers: rename interface -> include
BUG=webrtc:5095
R=tommi@webrtc.org

Review URL: https://codereview.webrtc.org/1413333002 .

Cr-Commit-Position: refs/heads/master@{#10438}
2015-10-28 17:17:50 +00:00
Peter Boström
26b08605e2 Use one scoped_refptr.
Uses webrtc/base/scoped_ref_ptr.h and removes the copy in
system_wrappers.

BUG=
R=kwiberg@webrtc.org, tommi@webrtc.org

Review URL: https://codereview.webrtc.org/1152733005

Cr-Commit-Position: refs/heads/master@{#9370}
2015-06-04 13:18:28 +00:00
Jon Hjelle
c2cb266c93 Match video orientation with device orientation for portrait and portrait upside down
BUG=
R=tkchin@webrtc.org

Committed: https://crrev.com/14c2695f2968d6e8546545a9b62940563073b4b6
Patch from Jon Hjelle <hjon@andynet.net>.

Cr-Commit-Position: refs/heads/master@{#9336}

Review URL: https://webrtc-codereview.appspot.com/55459004

Patch from Jon Hjelle <hjon@andyet.net>.

Cr-Commit-Position: refs/heads/master@{#9338}
2015-05-29 23:38:31 +00:00
Zeke Chin
7be99bdea1 Revert "Match video orientation with device orientation for portrait and portrait upside down"
Misspelt contributor's email address. Easier to revert and reland.
TBR=hjon@andyet.net

This reverts commit 14c2695f2968d6e8546545a9b62940563073b4b6.

BUG=

Review URL: https://webrtc-codereview.appspot.com/54619004

Cr-Commit-Position: refs/heads/master@{#9337}
2015-05-29 23:34:43 +00:00
Jon Hjelle
14c2695f29 Match video orientation with device orientation for portrait and portrait upside down
BUG=
R=tkchin@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/55459004

Patch from Jon Hjelle <hjon@andynet.net>.

Cr-Commit-Position: refs/heads/master@{#9336}
2015-05-29 22:25:00 +00:00
Yuriy Shevchuk
39f2b0c870 Implemented video device info for iOS
R=pbos@webrtc.org, tkchin@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/42189004

Patch from Yuriy Shevchuk <youwrk@gmail.com>.

Cr-Commit-Position: refs/heads/master@{#9190}
2015-05-14 21:16:01 +00:00
Jonas Martinsson
036b420db6 Updated iOS video capturer to take device orientation into consideration.
BUG=4122
R=tkchin@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/48769004

Patch from Jonas Martinsson <jonas.d.martinsson@gmail.com>.

Cr-Commit-Position: refs/heads/master@{#8953}
2015-04-08 18:12:48 +00:00
tkchin@webrtc.org
da4fcc494c Add minor fixes to video_capture_ios.mm in order to make it more robust.
R=tkchin@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/46429005

Patch from Iurii Shevchuk <youwrk@gmail.com>.

Cr-Commit-Position: refs/heads/master@{#8763}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8763 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-17 20:13:49 +00:00
kjellander@webrtc.org
14665ff7d4 Roll chromium_revision e144d30..6fdb142 (318658:318841) + remove OVERRIDE macro
Clang version changed 223108:230914
Details: e144d30..6fdb142/tools/clang/scripts/update.sh

Removes the OVERRIDE macro defined in:
* webrtc/base/common.h
* webrtc/typedefs.h

The majority of the source changes were done by running this in src/:
perl -0pi -e "s/virtual\s([^({;]*(\([^({;]*\)[^({;]*))(OVERRIDE|override)/\1override/sg" `find {talk,webrtc} -name "*.h"  -o -name "*.cc*" -o -name "*.mm*"`

which converted all:
virtual Foo() OVERRIDE
functions to:
Foo() override

Then I manually edited:
* talk/media/webrtc/fakewebrtccommon.h
* webrtc/test/fake_common.h

Remaining uses of OVERRIDE was fixed by search+replace.

Manual edits were done to fix virtual destructors that were
overriding inherited ones.

Finally a build error related to the pure virtual definitions of
Read, Write and Rewind in common_types.h required a bit of
refactoring in:
* webrtc/common_types.cc
* webrtc/common_types.h
* webrtc/system_wrappers/interface/file_wrapper.h
* webrtc/system_wrappers/source/file_impl.cc

This roll should make it possible for us to finally re-enable deadlock
detection for TSan on the buildbots.

BUG=4106
R=pbos@webrtc.org, tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/41069004

Cr-Commit-Position: refs/heads/master@{#8596}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8596 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-04 13:04:54 +00:00
guoweis@webrtc.org
5a7dc39277 This is a code clean up. No functional change intended.
Consolidate the enum for capturer/frame rotation we use through out the code base.

BUG=4145
R=mflodman@webrtc.org, perkj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/39859004

Cr-Commit-Position: refs/heads/master@{#8365}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8365 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-13 14:32:13 +00:00
pkasting@chromium.org
4591fbd09f Use size_t more consistently for packet/payload lengths.
See design doc at https://docs.google.com/a/chromium.org/document/d/1I6nmE9D_BmCY-IoV6MDPY2V6WYpEI-dg2apWXTfZyUI/edit?usp=sharing for more information.

This CL was reviewed and approved in pieces in the following CLs:
https://webrtc-codereview.appspot.com/24209004/
https://webrtc-codereview.appspot.com/24229004/
https://webrtc-codereview.appspot.com/24259004/
https://webrtc-codereview.appspot.com/25109004/
https://webrtc-codereview.appspot.com/26099004/
https://webrtc-codereview.appspot.com/27069004/
https://webrtc-codereview.appspot.com/27969004/
https://webrtc-codereview.appspot.com/27989004/
https://webrtc-codereview.appspot.com/29009004/
https://webrtc-codereview.appspot.com/30929004/
https://webrtc-codereview.appspot.com/30939004/
https://webrtc-codereview.appspot.com/31999004/
Committing as TBR to the original reviewers.

BUG=chromium:81439
TEST=none
TBR=pthatcher,henrik.lundin,tina.legrand,stefan,tkchin,glaznev,kjellander,perkj,mflodman,henrika,asapersson,niklas.enbom

Review URL: https://webrtc-codereview.appspot.com/23129004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7726 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-20 22:28:14 +00:00
tkchin@webrtc.org
143ffa4bd5 Update iOS video capture to use non-deprecated APIs.
BUG=3626
R=glaznev@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/17279004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7229 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-18 21:44:54 +00:00
tkchin@webrtc.org
ff50debd37 Runtime guard for iOS7 property.
BUG=3487
R=glaznev@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/19989004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6733 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-18 17:17:59 +00:00
tkchin@webrtc.org
4a472fb18d Fixes up rtc so that it compiles on iOS 8 SDK.
Adds support for UIInterfaceOrientationUnknown (new with in SDK) and makes it the same as
UIInterfaceOrientationPortrait.

R=noahric@google.com, tkchin@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/13029004

Patch from David Maclachlan <dmaclach@chromium.org>.

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6712 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-17 00:21:59 +00:00
tkchin@webrtc.org
2e3c97ddf5 Compile-time guard for iOS7 specific property.
BUG=3487
R=glaznev@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/17969004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6706 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-16 19:59:05 +00:00
tkchin@webrtc.org
122caa51b1 After an audio interruption the audio unit no longer invokes its render callback, which results in a loss of audio. Restarting the audio unit post interruption fixes the issue.
CL also replaces deprecated AudioSession calls with equivalent AVAudioSession ones.

BUG=3487
R=glaznev@webrtc.org, noahric@chromium.org

Review URL: https://webrtc-codereview.appspot.com/21769004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6697 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-15 20:20:47 +00:00
fischman@webrtc.org
984e4fbaaa video_capture(iOS): move stopCapture to background thread
Also suspend frame delivery on stopCapture() to avoid pause+onVideoError
during hangup.

BUG=3162
R=noahric@google.com

Review URL: https://webrtc-codereview.appspot.com/11389004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5863 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-08 21:06:52 +00:00
fischman@webrtc.org
e52b3b9c95 iOS video_capture: move @private vars to impl.
Promised change from https://webrtc-codereview.appspot.com/10539005/ that got
dropped accidentally.

R=noahric@google.com

Review URL: https://webrtc-codereview.appspot.com/10639004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5781 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-25 18:15:07 +00:00
fischman@webrtc.org
b64d52c292 iOS video_capture: start camera in the background.
Camera start is a blocking operation so never a good idea to do on a main
thread, but worse than that is that the guts of WebView appear to be
interacting with capture start in a bad way causing startup to pause for 10s
while a timeout expires.  This change eliminates that 10s delay.

R=noahric@google.com

Review URL: https://webrtc-codereview.appspot.com/10449004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5772 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-25 05:23:32 +00:00
fischman@webrtc.org
e68102e046 iOS VideoEngine: move video_{capture,render} to ARC.
Replaces ye olde timey explicit release with teh hotness of automatic
reference counting.

This is the webrtc/ half; the talk/ half is in https://webrtc-codereview.appspot.com/10499005/

BUG=3054,3055
R=noahric@google.com

Review URL: https://webrtc-codereview.appspot.com/10539005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5770 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-25 05:15:44 +00:00
fischman@webrtc.org
f792d17870 AppRTCDemo(iOS): video support; part 1 of 2: webrtc/.
(needs to land separately from the rest because PRESUBMIT)

Original review URL: https://webrtc-codereview.appspot.com/9229004

BUG=2168
TESTED=trybots
RISK=P3 (code is unused ATM)

Patch from Sajid Hussain <shussain@temasys.com.sg>.

R=noahric@google.com

Review URL: https://webrtc-codereview.appspot.com/9619004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5671 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-10 17:12:08 +00:00
fischman@webrtc.org
d0f4c2185b iOS: unbreak the build following r4546
BUG=2255
R=niklas.enbom@webrtc.org, sjlee@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2078004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4577 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-20 22:16:55 +00:00
sjlee@webrtc.org
d690eab54f The video capture module for iOS.
This CL is from https://webrtc-codereview.appspot.com/1339004.

Patch this CL, then run the trunk/webrtc/build/vie-webrtc.sh.

BUG=2105
R=fischman@webrtc.org, mallinath@webrtc.org, niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1641004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4546 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-14 22:07:04 +00:00